remove scaling by sd (now done internally by the method)

dajmcdon · dajmcdon · commit 264fbcf0e224 · 2025-01-28T21:39:22.000-08:00
diff --git a/R/growth_rate.R b/R/growth_rate.R
@@ -240,8 +240,6 @@ growth_rate <- function(
       }
     } else { # Trend filtering
       params <- parse_trendfilter_params(params)
-      sdy <- stats::sd(y) # speeds computation significantly
-      y <- y / sdy
       if (params$cv) {
         obj <- trendfilter::cv_trendfilter(
           y, x,
@@ -262,7 +260,7 @@ growth_rate <- function(
         )
         single_lambda <- length(obj$lambda) == 1L
         lam <- ifelse(single_lambda, obj$lambda, obj$lambda[which.min(abs(params$df - obj$dof))])
-        f <- stats::predict(obj, newx = x0, lambda = lam) * sdy
+        f <- stats::predict(obj, newx = x0, lambda = lam)
       }
 
       d <- diff(f) / diff(x0)

Original file line number	Diff line number	Diff line change
`@@ -240,8 +240,6 @@ growth_rate <- function(`
`240`	`240`	`}`
`241`	`241`	`} else { # Trend filtering`
`242`	`242`	`params <- parse_trendfilter_params(params)`
`243`		`- sdy <- stats::sd(y) # speeds computation significantly`
`244`		`- y <- y / sdy`
`245`	`243`	`if (params$cv) {`
`246`	`244`	`obj <- trendfilter::cv_trendfilter(`
`247`	`245`	`y, x,`
`@@ -262,7 +260,7 @@ growth_rate <- function(`
`262`	`260`	`)`
`263`	`261`	`single_lambda <- length(obj$lambda) == 1L`
`264`	`262`	`lam <- ifelse(single_lambda, obj$lambda, obj$lambda[which.min(abs(params$df - obj$dof))])`
`265`		`- f <- stats::predict(obj, newx = x0, lambda = lam) * sdy`
	`263`	`+ f <- stats::predict(obj, newx = x0, lambda = lam)`
`266`	`264`	`}`
`267`	`265`
`268`	`266`	`d <- diff(f) / diff(x0)`