Remove improper and faulty tidyselect usage from group_by tests

- Directly "passing" a reference to a character vector object is ambiguous; we
  might want to test that we trigger the message about this, but this might
  require mucking about in the internals of tidyselect (it seems to have its own
  frequency mechanism separate from rlang conditions).
- `tidyselect::eval_select` doesn't support `!!!`, but testthat expectations
  somehow makes this empty out the `group_by` arg, which _coincidentally_ passes
  the tests, because the default for the test archive is to group by `geo_value`.
  Plus, `!!!` is intended to splice/splat a list of language objects, not a
  character vector.

Author: lcbrooks

tests/testthat/test-methods-epi_archive.R

@@ -82,13 +82,17 @@ test_that("quosure passing issue in epix_slide is resolved + other potential iss
     ),
     reference
   )
-  # test the passing-string-var behavior:
+  # Might also want to test the passing-string-var-without-all_of behavior, but
+  # make sure to set, trigger, then reset (or restore to old value) the
+  # tidyselect once-per-session message about the ambiguity
+  #
+  # test the passing-all-of-string-var behavior:
   my_group_by = "geo_value"
   expect_identical(
     epix_slide(x = archive_cases_dv_subset,
                f = ~ mean(.x$case_rate_7d_av),
                n = 3,
-               group_by = my_group_by,
+               group_by = tidyselect::all_of(my_group_by),
                ref_time_values = time_values,
                new_col_name = 'case_rate_3d_av'),
     reference
@@ -97,28 +101,7 @@ test_that("quosure passing issue in epix_slide is resolved + other potential iss
     archive_cases_dv_subset$slide(
       f = ~ mean(.x$case_rate_7d_av),
       n = 3,
-      group_by = my_group_by,
-      ref_time_values = time_values,
-      new_col_name = 'case_rate_3d_av'
-    ),
-    reference
-  )
-  # test the passing-splatted-string-var behavior:
-  my_group_by = "geo_value"
-  expect_identical(
-    epix_slide(x = archive_cases_dv_subset,
-               f = ~ mean(.x$case_rate_7d_av),
-               n = 3,
-               group_by = !!!my_group_by,
-               ref_time_values = time_values,
-               new_col_name = 'case_rate_3d_av'),
-    reference
-  )
-  expect_identical(
-    archive_cases_dv_subset$slide(
-      f = ~ mean(.x$case_rate_7d_av),
-      n = 3,
-      group_by = !!!my_group_by,
+      group_by = tidyselect::all_of(my_group_by),
       ref_time_values = time_values,
       new_col_name = 'case_rate_3d_av'
     ),