other_keys is character()

Author: dajmcdon

DESCRIPTION

@@ -73,3 +73,22 @@ Encoding: UTF-8
 LazyData: true
 Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.3.2
+Collate: 
+    'archive.R'
+    'autoplot.R'
+    'correlation.R'
+    'data.R'
+    'epi_df.R'
+    'epiprocess.R'
+    'group_by_epi_df_methods.R'
+    'methods-epi_archive.R'
+    'grouped_epi_archive.R'
+    'growth_rate.R'
+    'key_colnames.R'
+    'methods-epi_df.R'
+    'outliers.R'
+    'reexports.R'
+    'revision_analysis.R'
+    'slide.R'
+    'utils.R'
+    'utils_pipe.R'

R/archive.R

@@ -479,7 +479,7 @@ as_epi_archive <- function(
     x,
     geo_type = deprecated(),
     time_type = deprecated(),
-    other_keys = character(0L),
+    other_keys = character(),
     compactify = NULL,
     clobberable_versions_start = NA,
     .versions_end = max_version_with_row_in(x), ...,

R/epi_df.R

@@ -171,7 +171,7 @@ NULL
 #'
 #' @export
 new_epi_df <- function(x = tibble::tibble(), geo_type, time_type, as_of,
-                       other_keys = character(0L), ...) {
+                       other_keys = character(), ...) {
   # Define metadata fields
   metadata <- list()
   metadata$geo_type <- geo_type
@@ -223,7 +223,7 @@ as_epi_df.tbl_df <- function(
     geo_type = deprecated(),
     time_type = deprecated(),
     as_of,
-    other_keys = NULL,
+    other_keys = character(),
     ...) {
   # possible standard substitutions for time_value
   x <- rename(x, ...)
@@ -269,23 +269,23 @@ as_epi_df.tbl_df <- function(
     } # Use the current day-time
   }
 
-  assert_character(other_keys, null.ok = TRUE)
+  assert_character(other_keys)
   new_epi_df(x, geo_type, time_type, as_of, other_keys)
 }
 
 #' @method as_epi_df data.frame
 #' @rdname epi_df
 #' @export
-as_epi_df.data.frame <- function(x, as_of, other_keys = NULL, ...) {
+as_epi_df.data.frame <- function(x, as_of, other_keys = character(), ...) {
   as_epi_df.tbl_df(x = tibble::as_tibble(x), as_of = as_of, other_keys = other_keys, ...)
 }
 
 #' @method as_epi_df tbl_ts
 #' @rdname epi_df
 #' @export
-as_epi_df.tbl_ts <- function(x, as_of, other_keys = NULL, ...) {
+as_epi_df.tbl_ts <- function(x, as_of, other_keys = character(), ...) {
   tsibble_other_keys <- setdiff(tsibble::key_vars(x), "geo_value")
-  if (length(tsibble_other_keys) != 0) {
+  if (length(tsibble_other_keys) > 0) {
     other_keys <- unique(c(other_keys, tsibble_other_keys))
   }
   as_epi_df.tbl_df(x = tibble::as_tibble(x), as_of = as_of, other_keys = other_keys, ...)

R/methods-epi_archive.R

@@ -65,7 +65,6 @@ epix_as_of <- function(x, max_version, min_time_value = -Inf, all_versions = FAL
     key(x$DT),
     c("geo_value", "time_value", "version")
   )
-  if (length(other_keys) == 0) other_keys <- NULL
 
   # Check a few things on max_version
   if (!identical(class(max_version), class(x$DT$version))) {

R/methods-epi_df.R

@@ -64,7 +64,7 @@ print.epi_df <- function(x, ...) {
   cat(sprintf("* %-9s = %s\n", "geo_type", attributes(x)$metadata$geo_type))
   cat(sprintf("* %-9s = %s\n", "time_type", attributes(x)$metadata$time_type))
   ok <- attributes(x)$metadata$other_keys
-  if (!is.null(ok)) {
+  if (length(ok) > 0) {
     cat(sprintf("* %-9s = %s\n", "other_keys", paste(ok, collapse = ", ")))
   }
   cat(sprintf("* %-9s = %s\n", "as_of", attributes(x)$metadata$as_of))
@@ -91,7 +91,7 @@ summary.epi_df <- function(object, ...) {
   cat("An `epi_df` x, with metadata:\n")
   cat(sprintf("* %-9s = %s\n", "geo_type", attributes(object)$metadata$geo_type))
   ok <- attributes(object)$metadata$other_keys
-  if (!is.null(ok)) {
+  if (length(ok) > 0) {
     cat(sprintf("* %-9s = %s\n", "other_keys", paste(ok, collapse = ", ")))
   }
   cat(sprintf("* %-9s = %s\n", "as_of", attributes(object)$metadata$as_of))