Nat's recommendations

Author: dsweber2

R/slide.R

@@ -509,10 +509,10 @@ epi_slide_opt <- function(x, col_names, f, ..., before = NULL, after = NULL, ref
   # positions of user-provided `col_names` into string column names. We avoid
   # using `names(pos)` directly for robustness and in case we later want to
   # allow users to rename fields via tidyselection.
-  if (typeof(quo_get_expr(enquo(col_names))) == "character") {
-    pos <- eval_select(all_of(col_names), data = x, allow_rename = FALSE)
-  } else {
+  if (class(quo_get_expr(enquo(col_names))) == "call") {
     pos <- eval_select(enquo(col_names), data = x, allow_rename = FALSE)
+  } else {
+    pos <- eval_select(all_of(col_names), data = x, allow_rename = FALSE)
   }
   col_names_chr <- names(x)[pos]
   # Always rename results to "slide_value_<original column name>".

man-roxygen/opt-slide-params.R

@@ -3,8 +3,7 @@
 #'   [other tidy-select expression][tidyselect::language], or a vector of
 #'   characters (e.g. `c("cases", "deaths")`). Variable names can be used as if
 #'   they were positions in the data frame, so expressions like `x:y` can be
-#'   used to select a range of variables. If you have the desired column names
-#'   stored in a vector `vars`, use `col_names = all_of(vars)`.
+#'   used to select a range of variables.
 #'
 #'   The tidy-selection renaming interface is not supported, and cannot be used
 #'   to provide output column names; if you want to customize the output column