changefeedccl: prep logging channel migration of changefeed events #151807
Conversation
|
This change is |
kyle-a-wong
changed the title
kyle-a-wong
force-pushed
the
cdc_CHANGFEED_logs
branch
7 times, most recently
from
ceffa74 to
1aec79f
Compare
kyle-a-wong
changed the title
kyle-a-wong
requested review from
dhartunian,
arjunmahishi,
aa-joshi,
Abhinav1299,
rharding6373 and
a team
and removed request for
a team
kyle-a-wong
force-pushed
the
cdc_CHANGFEED_logs
branch
from
1aec79f to
ce204e5
Compare
There was a problem hiding this comment.
Nice! I'm curious whether the cluster setting log.channel_compatibility_mode.enabled will be used to gate more channels than just the new CHANGEFEED channel?
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @aa-joshi, @Abhinav1299, @arjunmahishi, and @dhartunian)
pkg/util/log/eventpb/changefeed_events.proto line 15 at r1 (raw file):
// TODO (#151948): Update channel from TELEMETRY to CHANGEFEED once the // `log.channel_compatibility_mode_enabled` cluster setting is set to false // cluster setting is set to false by default.
minor nit: repeated phrase
pkg/ccl/changefeedccl/changefeed_test.go line 10791 at r1 (raw file):
closeFeed(t, coreFeed) failLogs := waitForLogs(t, &s.Server.ClusterSettings().SV) //failLogs := waitçorLogs(t, beforeCoreSinkClose)
nit: leftover debugging comment?
In v26.1, changefeed events will be moved from the TELEMETRY logging channel to the CHANGEFEED logging channel. This commit gates this migration under the cluster setting: `log.channel_compatibility_mode.enabled` and will log these events to the CHANGEFEED channel if this setting is set to false. Users can set this setting to false in their clusters to validate, test, and identify potential downstream impacts to their logging setups and pipelines. Epic: CRDB-53410 Part of: CRDB-53412 Release note (ops change): changefeed events will be moved to the CHANGEFEED channel in 26.1. In order to test the impact of these changes, users can set the setting: `log.channel_compatibility_mode.enabled` to false. Note that this will cause these logs to start logging in the CHANGEFEED channel so this shouldn't be tested in a production environment.
kyle-a-wong
force-pushed
the
cdc_CHANGFEED_logs
branch
from
ce204e5 to
267e0fe
Compare
There was a problem hiding this comment.
Yup, there are some logs #151949 and #151827 also include events that are being moved to different logging channels. Do you have any concerns about it?
Reviewable status:
There was a problem hiding this comment.
No, I was just curious because of the generic naming. Thanks!
@rharding6373 reviewed 5 of 8 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
|
TFTR! bors r+ |
In v26.1, changefeed events will be moved from the TELEMETRY logging
channel to the CHANGEFEED logging channel.
This commit gates this migration under the cluster setting:
log.channel_compatibility_mode.enabledand will log these eventsto the CHANGEFEED channel if this setting is set to false. Users can
set this setting to false in their clusters to validate, test, and
identify potential downstream impacts to their logging setups and
pipelines.
Epic: CRDB-53410
Part of: CRDB-53412
Release note (ops change): changefeed events will be moved to the
CHANGEFEED channel in 26.1. In order to test the impact of these
changes, users can set the setting:
log.channel_compatibility_mode.enabledto false. Note that thiswill cause these logs to start logging in the CHANGEFEED channel so
this shouldn't be tested in a production environment.
This is a stacked PR, only the last commit should be reviewed