fix(models,utils,plugin-axe): improve type handling

Author: hanna-skryl

packages/models/docs/models-reference.md

@@ -1374,7 +1374,7 @@ _Union of the following possible types:_
 
 - `string` (_url_)
 - `Array<string (_url_)>`
-- _Object with dynamic keys of type_ `string` (_url_) _and values of type_ `number` (_>0_)
+- _Object with dynamic keys of type_ `string` (_url_) _and values of type_ `number` (_≥0_)
 
 ## Report
 

packages/models/src/lib/plugin-config.ts

@@ -8,6 +8,7 @@ import {
   packageVersionSchema,
   scoreTargetSchema,
   slugSchema,
+  weightSchema,
 } from './implementation/schemas.js';
 import { formatSlugsList, hasMissingStrings } from './implementation/utils.js';
 import { runnerConfigSchema, runnerFunctionSchema } from './runner-config.js';
@@ -73,7 +74,7 @@ export const pluginConfigSchema = pluginMetaSchema
 export type PluginConfig = z.infer<typeof pluginConfigSchema>;
 
 export const pluginUrlsSchema = z
-  .union([z.url(), z.array(z.url()), z.record(z.url(), z.number().positive())])
+  .union([z.url(), z.array(z.url()), z.record(z.url(), weightSchema)])
   .meta({
     title: 'PluginUrls',
     description:

packages/plugin-axe/src/lib/axe-plugin.ts

@@ -1,8 +1,12 @@
 import { createRequire } from 'node:module';
-import type { PluginConfig, PluginUrls } from '@code-pushup/models';
+import {
+  type PluginConfig,
+  type PluginUrls,
+  validate,
+} from '@code-pushup/models';
 import { normalizeUrlInput } from '@code-pushup/utils';
-import type { AxePluginOptions } from './config.js';
-import { AXE_DEFAULT_PRESET, AXE_PLUGIN_SLUG } from './constants.js';
+import { type AxePluginOptions, axePluginOptionsSchema } from './config.js';
+import { AXE_PLUGIN_SLUG } from './constants.js';
 import { processAuditsAndGroups } from './processing.js';
 import { createRunnerFunction } from './runner/runner.js';
 
@@ -16,10 +20,9 @@ import { createRunnerFunction } from './runner/runner.js';
  */
 export function axePlugin(
   urls: PluginUrls,
-  options?: AxePluginOptions,
+  options: AxePluginOptions = {},
 ): PluginConfig {
-  const scoreTargets = options?.scoreTargets;
-  const preset = options?.preset ?? AXE_DEFAULT_PRESET;
+  const { preset, scoreTargets } = validate(axePluginOptionsSchema, options);
 
   const { urls: normalizedUrls, context } = normalizeUrlInput(urls);
 

packages/plugin-axe/src/lib/runner/transform.ts

@@ -96,15 +96,16 @@ function toIssue(node: NodeResult, result: Result, url: string): Issue {
   };
 }
 
-function impactToSeverity(impact?: ImpactValue): IssueSeverity {
+function impactToSeverity(impact: ImpactValue | undefined): IssueSeverity {
   switch (impact) {
     case 'critical':
     case 'serious':
       return 'error';
     case 'moderate':
       return 'warning';
     case 'minor':
-    default:
+    case null:
+    case undefined:
       return 'info';
   }
 }

packages/utils/src/lib/reports/formatting.ts

@@ -177,7 +177,7 @@ export function formatFileLink(
  * Wraps HTML tags in backticks to prevent markdown parsers
  * from interpreting them as actual HTML.
  */
-export function wrapTags(text?: string): string {
+export function wrapTags(text: string | undefined): string {
   if (!text) {
     return '';
   }