Naming duh

Author: dvlpp

demo/app/Sharp/Authors/Commands/VisitFacebookProfileCommand.php

@@ -20,7 +20,7 @@ public function buildCommandConfig(): void
 
     public function execute(mixed $instanceId, array $data = []): array
     {
-        return $this->link('https://facebook.com', targetBlank: true);
+        return $this->link('https://facebook.com', openInNewTab: true);
     }
 
     public function authorizeFor(mixed $instanceId): bool

docs/guide/commands.md

@@ -176,7 +176,7 @@ Finally, let's review the return possibilities: after a Command has been execute
 - `return $this->refresh(mixed $ids)`*: refresh only instance(s) with an id in `$ids`, which can be either a single id or an array.
 - `return $this->view(string $bladeView, array $params = [])`: display a view right in Sharp; useful for page previews.
 - `return $this->html(string $htmlContent)`: display an HTML content.
-- `return $this->link(string $link, bool $targetBlank = false)`: redirect to the given path. The second argument, optional (default is `false`), is a boolean to open the link in a new tab.
+- `return $this->link(string $link, bool $openInNewTab = false)`: redirect to the given path. The second argument, optional (default is `false`), is a boolean to open the link in a new tab.
 - `return $this->download(string $filePath, ?string $fileName = null, ?string $diskName = null)`: the browser will download the specified file.
 - `return $this->streamDownload(string $fileContent, string $fileName)`: the browser will stream the specified file.
 

src/Data/Commands/CommandResponseData.php

@@ -8,7 +8,7 @@
 
 // download & streamDownload actions returns the file directly in the response
 #[LiteralTypeScriptType(
-    '{ action: "'.CommandAction::Link->value.'", link: string, targetBlank: boolean } | '.
+    '{ action: "'.CommandAction::Link->value.'", link: string, openInNewTab: boolean } | '.
     '{ action: "'.CommandAction::Info->value.'", message: string, reload: boolean } | '.
     '{ action: "'.CommandAction::Refresh->value.'", items?: Array<{ [key: string]: any }> } | '.
     '{ action: "'.CommandAction::Reload->value.'" } | '.

src/EntityList/Commands/Command.php

@@ -44,12 +44,12 @@ protected function info(string $message, bool $reload = false): array
         ];
     }
 
-    protected function link(string $link, bool $targetBlank = false): array
+    protected function link(string $link, bool $openInNewTab = false): array
     {
         return [
             'action' => CommandAction::Link->value,
             'link' => $link,
-            'targetBlank' => $targetBlank,
+            'openInNewTab' => $openInNewTab,
         ];
     }
 

src/EntityList/Commands/EntityState.php

@@ -46,7 +46,7 @@ protected function streamDownload(string $fileContent, string $fileName): array
         throw new SharpInvalidConfigException('StreamDownload return type is not supported for a state.');
     }
 
-    protected function link(string $link, bool $targetBlank = false): array
+    protected function link(string $link, bool $openInNewTab = false): array
     {
         throw new SharpInvalidConfigException('Link return type is not supported for a state.');
     }

tests/Http/Api/Commands/ApiEntityListEntityCommandControllerTest.php

@@ -238,11 +238,11 @@ public function execute(array $data = []): array
         ->assertJson([
             'action' => 'link',
             'link' => 'https://sharp.code16.fr',
-            'targetBlank' => false,
+            'openInNewTab' => false,
         ]);
 });
 
-it('allows to call an link + targetBlank entity command', function () {
+it('allows to call an link + openInNewTab entity command', function () {
     fakeListFor('person', new class() extends PersonList
     {
         protected function getEntityCommands(): ?array
@@ -257,7 +257,7 @@ public function label(): ?string
 
                     public function execute(array $data = []): array
                     {
-                        return $this->link('https://sharp.code16.fr', targetBlank: true);
+                        return $this->link('https://sharp.code16.fr', openInNewTab: true);
                     }
                 },
             ];
@@ -269,7 +269,7 @@ public function execute(array $data = []): array
         ->assertJson([
             'action' => 'link',
             'link' => 'https://sharp.code16.fr',
-            'targetBlank' => true,
+            'openInNewTab' => true,
         ]);
 });