Skip to content

⚡️ Speed up method IndexVariable._to_index by 105% #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method IndexVariable._to_index by 105% #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions xarray/core/variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2784,15 +2784,22 @@ def _to_index(self) -> pd.Index:
assert self.ndim == 1
index = self._data.array
if isinstance(index, pd.MultiIndex):
# set default names for multi-index unnamed levels so that
# we can safely rename dimension / coordinate later
valid_level_names = [
name or f"{self.dims[0]}_level_{i}"
for i, name in enumerate(index.names)
]
index = index.set_names(valid_level_names)
# If all level names are not None, skip set_names
# (MultiIndex always has names tuple)
if any(name is None for name in index.names):
# Valid level names construction using generator expression (saves memory):
valid_level_names = tuple(
name if name is not None else f"{self.dims[0]}_level_{i}"
for i, name in enumerate(index.names)
)
index = index.set_names(valid_level_names)
# else, all names are set, nothing to do
else:
index = index.set_names(self.name)
# For Index and RangeIndex, only set name if it is different
cur_name = index.name
new_name = self.name
if cur_name != new_name:
index = index.set_names(new_name)
return index

def to_index(self) -> pd.Index:
Expand Down