fix: remove reset in sandbox runner (#714)

Author: caroljung-cg

src/codegen/runner/clients/codebase_client.py

@@ -66,9 +66,9 @@ def _wait_for_server(self, timeout: int = 30, interval: float = 0.3) -> None:
     def _get_envs(self) -> dict:
         envs = os.environ.copy()
         codebase_envs = {
-            "REPOSITORY_LANGUAGE": self.repo_config.language.value,
-            "REPOSITORY_OWNER": self.repo_config.organization_name,
             "REPOSITORY_PATH": str(self.repo_config.repo_path),
+            "REPOSITORY_OWNER": self.repo_config.organization_name,
+            "REPOSITORY_LANGUAGE": self.repo_config.language.value,
             "GITHUB_TOKEN": SecretsConfig().github_token,
         }
 

src/codegen/runner/sandbox/middlewares.py

@@ -1,16 +1,14 @@
 import traceback
-from http import HTTPStatus  # Add this import
+from http import HTTPStatus
 from typing import Callable, TypeVar
 
-from starlette.background import BackgroundTasks
 from starlette.middleware.base import BaseHTTPMiddleware, RequestResponseEndpoint
 from starlette.requests import Request
 from starlette.responses import JSONResponse, Response
 
 from codegen.runner.sandbox.runner import SandboxRunner
 from codegen.shared.exceptions.compilation import UserCodeException
 from codegen.shared.logging.get_logger import get_logger
-from codegen.shared.performance.stopwatch_utils import stopwatch
 
 logger = get_logger(__name__)
 
@@ -34,13 +32,10 @@ async def dispatch(self, request: TRequest, call_next: RequestResponseEndpoint)
         return await call_next(request)
 
     async def process_request(self, request: TRequest, call_next: RequestResponseEndpoint) -> TResponse:
-        background_tasks = BackgroundTasks()
         try:
             logger.info(f"> (CodemodRunMiddleware) Request: {request.url.path}")
             self.runner.codebase.viz.clear_graphviz_data()
             response = await call_next(request)
-            background_tasks.add_task(self.cleanup_after_codemod, is_exception=False)
-            response.background = background_tasks
             return response
 
         except UserCodeException as e:
@@ -52,21 +47,4 @@ async def process_request(self, request: TRequest, call_next: RequestResponseEnd
             message = f"Unexpected error for {request.url.path}"
             logger.exception(message)
             res = JSONResponse(status_code=HTTPStatus.INTERNAL_SERVER_ERROR, content={"detail": message, "error": str(e), "traceback": traceback.format_exc()})
-            background_tasks.add_task(self.cleanup_after_codemod, is_exception=True)
-            res.background = background_tasks
             return res
-
-    async def cleanup_after_codemod(self, is_exception: bool = False):
-        if is_exception:
-            # TODO: instead of committing transactions, we should just rollback
-            logger.info("Committing pending transactions due to exception")
-            self.runner.codebase.ctx.commit_transactions(sync_graph=False)
-        await self.reset_runner()
-
-    @stopwatch
-    async def reset_runner(self):
-        logger.info("=====[ reset_runner ]=====")
-        logger.info(f"Syncing runner to commit: {self.runner.commit} ...")
-        self.runner.codebase.checkout(commit=self.runner.commit)
-        self.runner.codebase.clean_repo()
-        self.runner.codebase.checkout(branch=self.runner.codebase.default_branch, create_if_missing=True)

src/codegen/runner/sandbox/server.py

@@ -31,10 +31,10 @@ async def lifespan(server: FastAPI):
     global server_info
     global runner
 
+    default_repo_config = RepositoryConfig()
+    repo_name = default_repo_config.full_name or default_repo_config.name
+    server_info = ServerInfo(repo_name=repo_name)
     try:
-        default_repo_config = RepositoryConfig()
-        repo_name = default_repo_config.full_name or default_repo_config.name
-        server_info = ServerInfo(repo_name=repo_name)
         logger.info(f"Starting up sandbox fastapi server for repo_name={repo_name}")
         repo_config = RepoConfig(
             name=default_repo_config.name,