Skip to content

Commit e866a52

Browse files
committed
Add video on PR reviews
1 parent 40114d1 commit e866a52

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

CONTRIBUTING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ A few things:
2323
- 🌎 Avoid hard coding text in JSX, use [the i18n mechanism](https://react-dsfr.etalab.studio/i18n) instead. [Here is an example](https://github.com/codegouvfr/react-dsfr/blob/bbaf4a81d78de08d6fdcb059a9f4cb8a78ce4d5a/src/DarkModeSwitch.tsx#L162-L199). (Don't worry about providing translations other than French.)
2424
- 🍳 If you have to arbitrate between ease of use and customisability I'd encourage you to favor ease of use. People that would need a greater level of customizability can always fall back to making their own wrapper from the reference documentation using [`fr.cx()`](https://react-dsfr.etalab.studio/cx).
2525

26+
## PR Reviews
27+
28+
[Here is a video](https://youtu.be/RI6jEPvgKJ4) to show you how I review PRs. Please have a look at it, it's full of valuable information
29+
that will save you and I time.
30+
2631
## Getting TypeScript error in VSCode but the console says everything's right?
2732

2833
Because of how this project is setup TypeScript unaware that files have changed.

0 commit comments

Comments
 (0)