Merge pull request #338 from m-maillot/fix/html-semantic-errors

fix: W3C html semantic errors

Author: garronej

src/Header/Header.tsx

@@ -375,7 +375,7 @@ export const Header = memo(
                                                     )}
                                                 >
                                                     <button
-                                                        id={`${id}-search-button`}
+                                                        id={`${id}-search-close-button`}
                                                         className={fr.cx("fr-btn--close", "fr-btn")}
                                                         aria-controls={searchModalId}
                                                         title={t("close")}

src/Input.tsx

@@ -160,7 +160,7 @@ export const Input = memo(
                                 classes.nativeInputOrTextArea
                             )}
                             disabled={disabled || undefined}
-                            aria-describedby={messageId}
+                            aria-describedby={state !== "default" ? messageId : undefined}
                             type={textArea ? undefined : nativeInputProps?.type ?? "text"}
                             id={inputId}
                         />

src/Modal/Modal.tsx

@@ -62,7 +62,6 @@ const Modal = memo(
         return (
             <dialog
                 aria-labelledby={titleId}
-                role="dialog"
                 id={id}
                 className={cx(fr.cx("fr-modal", topAnchor && "fr-modal--top"), className)}
                 style={style}