refactor: extract startLogin(), completeLogin() methods

Author: kenjis

src/Authentication/Authenticators/Session.php

@@ -102,8 +102,7 @@ public function attempt(array $credentials): Result
         if (! empty($actionClass)) {
             session()->set('auth_action', $actionClass);
         } else {
-            // a successful login
-            Events::trigger('login', $user);
+            $this->completeLogin($user);
         }
 
         return $result;
@@ -140,12 +139,17 @@ public function checkAction(string $type, string $token): bool
 
         $this->user = $user;
 
-        // a successful login
-        Events::trigger('login', $user);
+        $this->completeLogin($user);
 
         return true;
     }
 
+    private function completeLogin(User $user): void
+    {
+        // a successful login
+        Events::trigger('login', $user);
+    }
+
     /**
      * Activate a User
      */
@@ -308,13 +312,8 @@ private function checkRememberMeToken(string $remember)
         return $token;
     }
 
-    /**
-     * Logs the given user in.
-     */
-    public function login(User $user): void
+    private function startLogin(User $user): void
     {
-        $this->user = $user;
-
         // Update the user's last used date on their password identity.
         $this->user->touchIdentity($this->user->getEmailIdentity());
 
@@ -331,7 +330,22 @@ public function login(User $user): void
 
         // When logged in, ensure cache control headers are in place
         $response->noCache();
+    }
+
+    /**
+     * Logs the given user in.
+     */
+    public function login(User $user): void
+    {
+        $this->user = $user;
+
+        $this->startLogin($user);
 
+        $this->processRemember();
+    }
+
+    private function processRemember()
+    {
         if ($this->shouldRemember && setting('Auth.sessionConfig')['allowRemembering']) {
             $this->rememberUser($this->user->getAuthId());