Skip to content

Commit 5d80aa0

Browse files
authored
Merge pull request #350 from datamweb/fildename-validate-error
2 parents 342a368 + 90955ea commit 5d80aa0

File tree

4 files changed

+68
-32
lines changed

4 files changed

+68
-32
lines changed

docs/customization.md

Lines changed: 36 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -95,35 +95,47 @@ Shield has the following rules for registration:
9595

9696
```php
9797
[
98-
'username' => [
99-
'required',
100-
'max_length[30]',
101-
'min_length[3]',
102-
'regex_match[/\A[a-zA-Z0-9\.]+\z/]',
103-
'is_unique[users.username]',
104-
],
105-
'email' => 'required|max_length[254]|valid_email|is_unique[auth_identities.secret]',
106-
'password' => 'required|strong_password',
107-
'password_confirm' => 'required|matches[password]',
98+
'username' => [
99+
'label' => 'Auth.username',
100+
'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]|is_unique[users.username]',
101+
],
102+
'email' => [
103+
'label' => 'Auth.email',
104+
'rules' => 'required|max_length[254]|valid_email|is_unique[auth_identities.secret]',
105+
],
106+
'password' => [
107+
'label' => 'Auth.password',
108+
'rules' => 'required|strong_password',
109+
],
110+
'password_confirm' => [
111+
'label' => 'Auth.passwordConfirm',
112+
'rules' => 'required|matches[password]',
113+
],
108114
];
109115
```
110116

111117
If you need a different set of rules for registration, you can specify them in your `Validation` configuration (**app/Config/Validation.php**) like:
112118

113119
```php
114-
//--------------------------------------------------------------------
115-
// Rules
116-
//--------------------------------------------------------------------
117-
public $registration = [
118-
'username' => [
119-
'required',
120-
'max_length[30]',
121-
'min_length[3]',
122-
'regex_match[/\A[a-zA-Z0-9\.]+\z/]',
123-
'is_unique[users.username]',
120+
//--------------------------------------------------------------------
121+
// Rules
122+
//--------------------------------------------------------------------
123+
public $registration = [
124+
'username' => [
125+
'label' => 'Auth.username',
126+
'rules' => 'required|max_length[30]|min_length[3]|regex_match[/\A[a-zA-Z0-9\.]+\z/]|is_unique[users.username]',
124127
],
125-
'email' => 'required|max_length[254]|valid_email|is_unique[auth_identities.secret]',
126-
'password' => 'required|strong_password',
127-
'password_confirm' => 'required|matches[password]',
128-
];
128+
'email' => [
129+
'label' => 'Auth.email',
130+
'rules' => 'required|max_length[254]|valid_email|is_unique[auth_identities.secret]',
131+
],
132+
'password' => [
133+
'label' => 'Auth.password',
134+
'rules' => 'required|strong_password',
135+
],
136+
'password_confirm' => [
137+
'label' => 'Auth.passwordConfirm',
138+
'rules' => 'required|matches[password]',
139+
],
140+
];
129141
```

src/Controllers/LoginController.php

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,18 @@ public function loginAction(): RedirectResponse
7070
protected function getValidationRules(): array
7171
{
7272
return setting('Validation.login') ?? [
73-
//'username' => config('AuthSession')->usernameValidationRules,
74-
'email' => config('AuthSession')->emailValidationRules,
75-
'password' => 'required',
73+
// 'username' => [
74+
// 'label' => 'Auth.username',
75+
// 'rules' => config('AuthSession')->usernameValidationRules,
76+
// ],
77+
'email' => [
78+
'label' => 'Auth.email',
79+
'rules' => config('AuthSession')->emailValidationRules,
80+
],
81+
'password' => [
82+
'label' => 'Auth.password',
83+
'rules' => 'required',
84+
],
7685
];
7786
}
7887

src/Controllers/MagicLinkController.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,10 @@ private function recordLoginAttempt(
191191
protected function getValidationRules(): array
192192
{
193193
return [
194-
'email' => config('AuthSession')->emailValidationRules,
194+
'email' => [
195+
'label' => 'Auth.email',
196+
'rules' => config('AuthSession')->emailValidationRules,
197+
],
195198
];
196199
}
197200
}

src/Controllers/RegisterController.php

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,22 @@ protected function getValidationRules(): array
151151
);
152152

153153
return setting('Validation.registration') ?? [
154-
'username' => $registrationUsernameRules,
155-
'email' => $registrationEmailRules,
156-
'password' => 'required|strong_password',
157-
'password_confirm' => 'required|matches[password]',
154+
'username' => [
155+
'label' => 'Auth.username',
156+
'rules' => $registrationUsernameRules,
157+
],
158+
'email' => [
159+
'label' => 'Auth.email',
160+
'rules' => $registrationEmailRules,
161+
],
162+
'password' => [
163+
'label' => 'Auth.password',
164+
'rules' => 'required|strong_password',
165+
],
166+
'password_confirm' => [
167+
'label' => 'Auth.passwordConfirm',
168+
'rules' => 'required|matches[password]',
169+
],
158170
];
159171
}
160172
}

0 commit comments

Comments
 (0)