refactor: add redirectToDeniedUrl() for able inherit from AbstractAuthFilter

Author: datamweb

src/Filters/AbstractAuthFilter.php

@@ -8,15 +8,12 @@
 use CodeIgniter\HTTP\RedirectResponse;
 use CodeIgniter\HTTP\RequestInterface;
 use CodeIgniter\HTTP\ResponseInterface;
-use CodeIgniter\Shield\Config\Auth;
 
 /**
  * Group Authorization Filter.
  */
 abstract class AbstractAuthFilter implements FilterInterface
 {
-    protected string $filterName;
-
     /**
      * Ensures the user is logged in and a member of one or
      * more groups as specified in the filter.
@@ -45,15 +42,7 @@ public function before(RequestInterface $request, $arguments = null)
             return;
         }
 
-        switch ($this->filterName) {
-            case 'group':
-                return redirect()->to(config(Auth::class)->afterGroupDeniedRedirect())
-                    ->with('error', lang('Auth.notEnoughPrivilege'));
-
-            case 'permission':
-                return redirect()->to(config(Auth::class)->afterPermissionDeniedRedirect())
-                    ->with('error', lang('Auth.notEnoughPrivilege'));
-        }
+        return $this->redirectToDeniedUrl();
     }
 
     /**
@@ -67,4 +56,6 @@ public function after(RequestInterface $request, ResponseInterface $response, $a
     }
 
     abstract protected function isAuthorized(array $arguments): bool;
+
+    abstract protected function redirectToDeniedUrl(): RedirectResponse;
 }

src/Filters/GroupFilter.php

@@ -4,13 +4,14 @@
 
 namespace CodeIgniter\Shield\Filters;
 
+use CodeIgniter\HTTP\RedirectResponse;
+use CodeIgniter\Shield\Config\Auth;
+
 /**
  * Group Authorization Filter.
  */
 class GroupFilter extends AbstractAuthFilter
 {
-    protected string $filterName = 'group';
-
     /**
      * Ensures the user is logged in and a member of one or
      * more groups as specified in the filter.
@@ -19,4 +20,14 @@ protected function isAuthorized(array $arguments): bool
     {
         return auth()->user()->inGroup(...$arguments);
     }
+
+    /**
+     * If there is no necessary access to the group,
+     * it will redirect the user to the set URL with an error message.
+     */
+    protected function redirectToDeniedUrl(): RedirectResponse
+    {
+        return redirect()->to(config(Auth::class)->groupDeniedRedirect())
+            ->with('error', lang('Auth.notEnoughPrivilege'));
+    }
 }

src/Filters/PermissionFilter.php

@@ -4,13 +4,14 @@
 
 namespace CodeIgniter\Shield\Filters;
 
+use CodeIgniter\HTTP\RedirectResponse;
+use CodeIgniter\Shield\Config\Auth;
+
 /**
  * Permission Authorization Filter.
  */
 class PermissionFilter extends AbstractAuthFilter
 {
-    protected string $filterName = 'permission';
-
     /**
      * Ensures the user is logged in and has one or more
      * of the permissions as specified in the filter.
@@ -25,4 +26,14 @@ protected function isAuthorized(array $arguments): bool
 
         return false;
     }
+
+    /**
+     * If there is no necessary access to the permission,
+     * it will redirect the user to the set URL with an error message.
+     */
+    protected function redirectToDeniedUrl(): RedirectResponse
+    {
+        return redirect()->to(config(Auth::class)->permissionDeniedRedirect())
+            ->with('error', lang('Auth.notEnoughPrivilege'));
+    }
 }