Merge pull request #298 from parisiam/fix-register-when-logged

Fix: register when logged in

Author: kenjis

src/Controllers/RegisterController.php

@@ -27,6 +27,10 @@ class RegisterController extends BaseController
      */
     public function registerView()
     {
+        if (auth()->loggedIn()) {
+            return redirect()->to(config('Auth')->registerRedirect());
+        }
+
         // Check if registration is allowed
         if (! setting('Auth.allowRegistration')) {
             return redirect()->back()->withInput()
@@ -41,6 +45,10 @@ public function registerView()
      */
     public function registerAction(): RedirectResponse
     {
+        if (auth()->loggedIn()) {
+            return redirect()->to(config('Auth')->registerRedirect());
+        }
+
         // Check if registration is allowed
         if (! setting('Auth.allowRegistration')) {
             return redirect()->back()->withInput()

tests/Controllers/RegisterTest.php

@@ -11,13 +11,15 @@
 use CodeIgniter\Test\FeatureTestTrait;
 use Config\Services;
 use Tests\Support\DatabaseTestCase;
+use Tests\Support\FakeUser;
 
 /**
  * @internal
  */
 final class RegisterTest extends DatabaseTestCase
 {
     use FeatureTestTrait;
+    use FakeUser;
 
     protected $namespace;
 
@@ -146,6 +148,35 @@ public function testRegisterRedirectsToActionIfDefined(): void
         ]);
     }
 
+    public function testRegisterRedirectsIfLoggedIn(): void
+    {
+        // log them in
+        session()->set('user', ['id' => $this->user->id]);
+
+        $result = $this->withSession()->get('/register');
+
+        $result->assertStatus(302);
+        $result->assertRedirect();
+        $result->assertRedirectTo(config('Auth')->registerRedirect());
+    }
+
+    public function testRegisterActionRedirectsIfLoggedIn(): void
+    {
+        // log them in
+        session()->set('user', ['id' => $this->user->id]);
+
+        $result = $this->withSession()->post('/register', [
+            'username'         => 'JohnDoe',
+            'email'            => 'john.doe@example.com',
+            'password'         => 'secret things might happen here',
+            'password_confirm' => 'secret things might happen here',
+        ]);
+
+        $result->assertStatus(302);
+        $result->assertRedirect();
+        $result->assertRedirectTo(config('Auth')->registerRedirect());
+    }
+
     protected function setupConfig(): void
     {
         $config             = config('Validation');