refator: remove code that loads setting helper

Author: kenjis

src/Authentication/Authenticators/Session.php

@@ -73,8 +73,6 @@ class Session implements AuthenticatorInterface
 
     public function __construct(UserModel $provider)
     {
-        helper('setting');
-
         $this->provider = $provider;
 
         $this->loginModel        = model(LoginModel::class);

src/Authorization/Groups.php

@@ -13,13 +13,6 @@
  */
 class Groups
 {
-    public function __construct()
-    {
-        if (! function_exists('setting')) {
-            helper('setting');
-        }
-    }
-
     /**
      * Grabs a group info from settings.
      */

src/Authorization/Traits/Authorizable.php

@@ -259,9 +259,7 @@ public function can(string ...$permissions): bool
                 return false;
             }
 
-            $matrix = function_exists('setting')
-                ? setting('AuthGroups.matrix')
-                : config('AuthGroups')->matrix;
+            $matrix = setting('AuthGroups.matrix');
 
             foreach ($this->groupCache as $group) {
                 // Check exact match
@@ -396,18 +394,14 @@ private function saveGroupsOrPermissions(string $type, $model, array $cache): vo
      */
     private function getConfigGroups(): array
     {
-        return function_exists('setting')
-            ? array_keys(setting('AuthGroups.groups'))
-            : array_keys(config('AuthGroups')->groups);
+        return array_keys(setting('AuthGroups.groups'));
     }
 
     /**
      * @return string[]
      */
     private function getConfigPermissions(): array
     {
-        return function_exists('setting')
-            ? array_keys(setting('AuthGroups.permissions'))
-            : array_keys(config('AuthGroups')->permissions);
+        return array_keys(setting('AuthGroups.permissions'));
     }
 }

src/Controllers/ActionController.php

@@ -18,7 +18,6 @@
 class ActionController extends BaseController
 {
     protected ?ActionInterface $action = null;
-    protected $helpers                 = ['setting'];
 
     /**
      * Perform an initial check if we have a valid action or not.

src/Controllers/LoginController.php

@@ -14,8 +14,6 @@ class LoginController extends BaseController
 {
     use Viewable;
 
-    protected $helpers = ['setting'];
-
     /**
      * Displays the form the login to the site.
      *

src/Controllers/MagicLinkController.php

@@ -34,8 +34,6 @@ class MagicLinkController extends BaseController
 
     public function __construct()
     {
-        helper('setting');
-
         /** @var class-string<UserModel> $providerClass */
         $providerClass = setting('Auth.userProvider');
 

src/Controllers/RegisterController.php

@@ -27,8 +27,6 @@ class RegisterController extends BaseController
 {
     use Viewable;
 
-    protected $helpers = ['setting'];
-
     public function initController(
         RequestInterface $request,
         ResponseInterface $response,

src/Filters/ForcePasswordResetFilter.php

@@ -32,8 +32,6 @@ public function before(RequestInterface $request, $arguments = null)
             return;
         }
 
-        helper('setting');
-
         /** @var Session $authenticator */
         $authenticator = auth('session')->getAuthenticator();
 

src/Filters/HmacAuth.php

@@ -23,8 +23,6 @@ public function before(RequestInterface $request, $arguments = null)
     {
         $authenticator = auth('hmac')->getAuthenticator();
 
-        helper('setting');
-
         $requestParams = [
             'token' => $request->getHeaderLine(setting('Auth.authenticatorHeader')['hmac'] ?? 'Authorization'),
             'body'  => $request->getBody() ?? '',

src/Filters/JWTAuth.php

@@ -33,8 +33,6 @@ public function before(RequestInterface $request, $arguments = null)
             return;
         }
 
-        helper('setting');
-
         /** @var JWT $authenticator */
         $authenticator = auth('jwt')->getAuthenticator();