Merge branch 'develop'

Author: codejsha

.github/workflows/cmake.yml

@@ -41,12 +41,13 @@ jobs:
         run: ./vcpkg install gsl:x64-linux gtest:x64-linux benchmark:x64-linux fmt:x64-linux
 
       - name: Configure CMake
-        run: cmake --preset linux-${{env.BUILD_TYPE_LOWERCASE}} -S ${{github.workspace}}/cpp-algorithm -B ${{github.workspace}}/cpp-algorithm/out/build/linux-x64-${{env.BUILD_TYPE_LOWERCASE}}
+        working-directory: ${{github.workspace}}/cpp-algorithm
+        run: make configure
 
       - name: Build
-        working-directory: ${{github.workspace}}/cpp-algorithm/out/build/linux-x64-${{env.BUILD_TYPE_LOWERCASE}}
-        run: cmake --build . --config ${{env.BUILD_TYPE}} --target all --parallel 6
+        working-directory: ${{github.workspace}}/cpp-algorithm
+        run: make build
 
       - name: Test
-        working-directory: ${{github.workspace}}/cpp-algorithm/out/build/linux-x64-${{env.BUILD_TYPE_LOWERCASE}}
-        run: ctest -C ${{env.BUILD_TYPE}} --output-on-failure
+        working-directory: ${{github.workspace}}/cpp-algorithm
+        run: make test

README.md

@@ -2,11 +2,11 @@
 
 <!-- markdownlint-disable MD033 MD036 -->
 
-![C++ CMake Test](https://github.com/codejsha/algorithm-examples/actions/workflows/cmake.yml/badge.svg) ![Python Poetry Test](https://github.com/codejsha/algorithm-examples/actions/workflows/poetry.yml/badge.svg) ![Java Gradle Test](https://github.com/codejsha/algorithm-examples/actions/workflows/gradle.yml/badge.svg) ![Go Test](https://github.com/codejsha/algorithm-examples/actions/workflows/go.yml/badge.svg)
+![C++ CMake Test](https://github.com/codejsha/algorithm-examples/actions/workflows/cmake.yml/badge.svg) ![Python Poetry Test](https://github.com/codejsha/algorithm-examples/actions/workflows/poetry.yml/badge.svg) ![Go Test](https://github.com/codejsha/algorithm-examples/actions/workflows/go.yml/badge.svg) ![Java Gradle Test](https://github.com/codejsha/algorithm-examples/actions/workflows/gradle.yml/badge.svg)
 
 [English](README.md) | [Korean](README_ko-KR.md)
 
-이 리포지토리는 알고리즘, 데이터 구조, 문제 해결에 대한 구현 예제들로 구성되어 있습니다. 예제들은 C++, Python, Java, Go로 작성되었으며, 각 언어는 다음과 같은 테스트 프레임워크를 사용합니다: [Google Test](https://google.github.io/googletest/)(C++), [pytest](https://docs.pytest.org/)(Python), [JUnit](https://junit.org/)(Java), [go test](https://pkg.go.dev/cmd/go)(Go). 테스트를 실행하여 알고리즘 로직에 대한 메서드/함수를 수행합니다.
+이 리포지토리는 알고리즘, 데이터 구조, 문제 해결 접근방식의 예제들을 제공하며 실제 응용을 위한 목적으로 구현되었습니다. 예제들은 C++, Python, Go, Java로 구현되었으며, 각 언어는 테스트 프레임워크를 활용합니다. 테스트를 실행하여 알고리즘 로직에 대한 메서드/함수를 수행할 수 있습니다.
 
 ## Project Environments
 
@@ -16,5 +16,5 @@
 | -------- | ------- | ------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------- |
 | C++      | C++20   | [CMake](https://cmake.org/)          | [GNU Scientific Library (GSL)](https://www.gnu.org/software/gsl/), [Google Test](https://google.github.io/googletest/), [Google Benchmark](https://github.com/google/benchmark), [fmt](https://github.com/fmtlib/fmt) | [vcpkg](https://github.com/microsoft/vcpkg) |
 | Python   | 3.12    | [Poetry](https://python-poetry.org/) | [NumPy](https://numpy.org/), [SciPy](https://www.scipy.org/), [NetworkX](https://networkx.org/), [pytest](https://docs.pytest.org/), [pytest-benchmark](https://pytest-benchmark.readthedocs.io/en/latest/)           |                                             |
+| Go       | 1.22    | [Go](https://pkg.go.dev/cmd/go)      | [Gonum](https://github.com/gonum/gonum), [Testify](https://github.com/stretchr/testify)                                                                                                                               |                                             |
 | Java     | 21      | [Gradle](https://gradle.org/)        | [Google Guava](https://github.com/google/guava), [JUnit](https://junit.org/), [Java Microbenchmark Harness (JMH)](https://github.com/openjdk/jmh)                                                                     |                                             |
-| Go       | 1.22    | [Go](https://pkg.go.dev/cmd/go)      | [Testify](https://github.com/stretchr/testify)                                                                                                                                                                        |                                             |

README_ko-KR.md

@@ -346,7 +346,7 @@ ij_java_wrap_long_lines = false
 ij_java_wrap_semicolon_after_call_chain = false
 
 [*.less]
-indent_size = 2
+ij_less_indent_size = 2
 ij_less_align_closing_brace_with_properties = false
 ij_less_blank_lines_around_nested_selector = 1
 ij_less_blank_lines_between_blocks = 1
@@ -369,9 +369,9 @@ ij_less_use_double_quotes = true
 ij_less_value_alignment = 0
 
 [*.proto]
-indent_size = 2
-tab_width = 2
-ij_continuation_indent_size = 4
+ij_protobuf_indent_size = 2
+ij_protobuf_continuation_indent_size = 4
+ij_protobuf_tab_width = 2
 ij_protobuf_keep_blank_lines_in_code = 1
 ij_protobuf_keep_indents_on_empty_lines = false
 ij_protobuf_keep_line_breaks = true
@@ -382,7 +382,7 @@ ij_protobuf_spaces_within_braces = false
 ij_protobuf_spaces_within_brackets = false
 
 [*.sass]
-indent_size = 2
+ij_sass_indent_size = 2
 ij_sass_align_closing_brace_with_properties = false
 ij_sass_blank_lines_around_nested_selector = 1
 ij_sass_blank_lines_between_blocks = 1
@@ -404,9 +404,9 @@ ij_sass_use_double_quotes = true
 ij_sass_value_alignment = 0
 
 [*.scala]
-indent_size = 2
-tab_width = 2
-ij_continuation_indent_size = 2
+ij_scala_indent_size = 2
+ij_scala_continuation_indent_size = 2
+ij_scala_tab_width = 2
 ij_scala_align_composite_pattern = true
 ij_scala_align_extends_with = 0
 ij_scala_align_group_field_declarations = false
@@ -605,7 +605,7 @@ ij_scala_wrap_first_method_in_call_chain = false
 ij_scala_wrap_long_lines = false
 
 [*.scss]
-indent_size = 2
+ij_scss_indent_size = 2
 ij_scss_align_closing_brace_with_properties = false
 ij_scss_blank_lines_around_nested_selector = 1
 ij_scss_blank_lines_between_blocks = 1
@@ -628,9 +628,9 @@ ij_scss_use_double_quotes = true
 ij_scss_value_alignment = 0
 
 [*.vue]
-indent_size = 2
-tab_width = 2
-ij_continuation_indent_size = 4
+ij_vue_indent_size = 2
+ij_vue_continuation_indent_size = 4
+ij_vue_tab_width = 2
 ij_vue_indent_children_of_top_level = template
 ij_vue_interpolation_new_line_after_start_delimiter = true
 ij_vue_interpolation_new_line_before_end_delimiter = true
@@ -666,7 +666,8 @@ ij_xml_space_inside_empty_tag = false
 ij_xml_text_wrap = normal
 
 [{*.ats,*.cts,*.mts,*.ts}]
-ij_continuation_indent_size = 4
+ij_typescript_indent_size = 2
+ij_typescript_continuation_indent_size = 4
 ij_typescript_align_imports = false
 ij_typescript_align_multiline_array_initializer_expression = false
 ij_typescript_align_multiline_binary_operation = false
@@ -812,7 +813,7 @@ ij_typescript_spaces_within_brackets = false
 ij_typescript_spaces_within_catch_parentheses = false
 ij_typescript_spaces_within_for_parentheses = false
 ij_typescript_spaces_within_if_parentheses = false
-ij_typescript_spaces_within_imports = false
+ij_typescript_spaces_within_imports = true
 ij_typescript_spaces_within_interpolation_expressions = false
 ij_typescript_spaces_within_method_call_parentheses = false
 ij_typescript_spaces_within_method_parentheses = false
@@ -840,8 +841,8 @@ ij_typescript_while_on_new_line = false
 ij_typescript_wrap_comments = false
 
 [{*.bash,*.sh,*.zsh}]
-indent_size = 2
-tab_width = 2
+ij_shell_indent_size = 2
+ij_shell_tab_width = 2
 ij_shell_binary_ops_start_line = false
 ij_shell_keep_column_alignment_padding = false
 ij_shell_minify_program = false
@@ -850,7 +851,8 @@ ij_shell_switch_cases_indented = false
 ij_shell_use_unix_line_separator = true
 
 [{*.cjs,*.js}]
-ij_continuation_indent_size = 4
+ij_javascript_indent_size = 2
+ij_javascript_continuation_indent_size = 4
 ij_javascript_align_imports = false
 ij_javascript_align_multiline_array_initializer_expression = false
 ij_javascript_align_multiline_binary_operation = false
@@ -992,7 +994,7 @@ ij_javascript_spaces_within_brackets = false
 ij_javascript_spaces_within_catch_parentheses = false
 ij_javascript_spaces_within_for_parentheses = false
 ij_javascript_spaces_within_if_parentheses = false
-ij_javascript_spaces_within_imports = false
+ij_javascript_spaces_within_imports = true
 ij_javascript_spaces_within_interpolation_expressions = false
 ij_javascript_spaces_within_method_call_parentheses = false
 ij_javascript_spaces_within_method_parentheses = false
@@ -1250,22 +1252,22 @@ ij_dts_wrap_long_lines = false
 
 [{*.go,*.go2}]
 indent_style = tab
-ij_continuation_indent_size = 4
-ij_go_GROUP_CURRENT_PROJECT_IMPORTS = false
+ij_go_continuation_indent_size = 4
+ij_go_GROUP_CURRENT_PROJECT_IMPORTS = true
 ij_go_add_leading_space_to_comments = true
-ij_go_add_parentheses_for_single_import = false
+ij_go_add_parentheses_for_single_import = true
 ij_go_call_parameters_new_line_after_left_paren = true
 ij_go_call_parameters_right_paren_on_new_line = true
 ij_go_call_parameters_wrap = off
 ij_go_fill_paragraph_width = 80
-ij_go_group_stdlib_imports = false
-ij_go_import_sorting = gofmt
+ij_go_group_stdlib_imports = true
+ij_go_import_sorting = goimports
 ij_go_keep_indents_on_empty_lines = false
 ij_go_local_group_mode = project
 ij_go_local_package_prefixes =
-ij_go_move_all_imports_in_one_declaration = false
-ij_go_move_all_stdlib_imports_in_one_group = false
-ij_go_remove_redundant_import_aliases = false
+ij_go_move_all_imports_in_one_declaration = true
+ij_go_move_all_stdlib_imports_in_one_group = true
+ij_go_remove_redundant_import_aliases = true
 ij_go_run_go_fmt_on_reformat = true
 ij_go_use_back_quotes_for_imports = false
 ij_go_wrap_comp_lit = off
@@ -1283,7 +1285,7 @@ ij_go_wrap_func_result_newline_before_rparen = true
 [{*.gql,*.graphql,*.graphqls}]
 
 [{*.graphqlconfig,*.graphqlrc,*.har,*.jsb2,*.jsb3,*.json,*.jsonc,*.postman_collection,*.postman_collection.json,*.postman_environment,*.postman_environment.json,.babelrc,.eslintrc,.prettierrc,.stylelintrc,.ws-context,bowerrc,jest.config}]
-indent_size = 2
+ij_json_indent_size = 2
 ij_json_array_wrapping = split_into_lines
 ij_json_keep_blank_lines_in_code = 0
 ij_json_keep_indents_on_empty_lines = false
@@ -1328,8 +1330,8 @@ ij_html_space_inside_empty_tag = false
 ij_html_text_wrap = normal
 
 [{*.http,*.rest}]
-indent_size = 0
-ij_continuation_indent_size = 4
+ij_http-request_indent_size = 0
+ij_http-request_continuation_indent_size = 4
 ij_http-request_call_parameters_wrap = normal
 ij_http-request_method_parameters_wrap = split_into_lines
 ij_http-request_space_before_comma = true
@@ -1428,8 +1430,8 @@ ij_kotlin_wrap_expression_body_functions = 1
 ij_kotlin_wrap_first_method_in_call_chain = false
 
 [{*.markdown,*.md}]
-indent_size = 2
-tab_width = 2
+ij_markdown_indent_size = 2
+ij_markdown_tab_width = 2
 ij_markdown_force_one_space_after_blockquote_symbol = true
 ij_markdown_force_one_space_after_header_symbol = true
 ij_markdown_force_one_space_after_list_bullet = true
@@ -1483,9 +1485,9 @@ ij_mermaid_within_round = false
 ij_mermaid_within_square = false
 
 [{*.pb,*.textproto,*.txtpb}]
-indent_size = 2
-tab_width = 2
-ij_continuation_indent_size = 4
+ij_prototext_indent_size = 2
+ij_prototext_continuation_indent_size = 4
+ij_prototext_tab_width = 2
 ij_prototext_keep_blank_lines_in_code = 1
 ij_prototext_keep_indents_on_empty_lines = false
 ij_prototext_keep_line_breaks = true
@@ -1569,7 +1571,7 @@ ij_python_use_continuation_indent_for_parameters = true
 ij_python_wrap_long_lines = false
 
 [{*.qml,*.qmltypes}]
-ij_continuation_indent_size = 4
+ij_qmllang_continuation_indent_size = 4
 ij_qmllang_align_imports = false
 ij_qmllang_align_multiline_array_initializer_expression = false
 ij_qmllang_align_multiline_binary_operation = false
@@ -1751,7 +1753,7 @@ ij_qute_keep_indents_on_empty_lines = false
 ij_toml_keep_indents_on_empty_lines = false
 
 [{*.yaml,*.yml,.clang-format,.clang-tidy,_clang-format}]
-indent_size = 2
+ij_yaml_indent_size = 2
 ij_yaml_align_values_properties = do_not_align
 ij_yaml_autoinsert_sequence_marker = true
 ij_yaml_block_mapping_on_new_line = false

cpp-algorithm/.editorconfig

@@ -128,10 +128,5 @@ fabric.properties
 .idea/
 .vs/
 .vscode/
-out/
-cmake-build-debug/
-cmake-build-debug-visual-studio/
-cmake-build-release/
-cmake-build-release-visual-studio/
-Folder.DotSettings.user
 README_link.md
+!/Makefile

cpp-algorithm/.gitignore

@@ -0,0 +1,34 @@
+BUILD_TYPE:=debug
+
+UNAME_S:=$(shell uname -s)
+ifeq ($(UNAME_S),Linux)
+	PRESET_NAME:=linux-$(BUILD_TYPE)
+else ifeq ($(UNAME_S),Darwin)
+	PRESET_NAME:=macos-$(BUILD_TYPE)
+else ifeq ($(UNAME_S),Windows_NT)
+	PRESET_NAME:=windows-$(BUILD_TYPE)
+else
+	$(error Unsupported platform: $(UNAME_S))
+endif
+
+BUILD_DIR:=$(PWD)/out/build/$(PRESET_NAME)
+
+.PHONY: default
+default:
+	@echo "Please specify the target"
+
+.PHONY: clean
+clean:
+	rm -rf $(BUILD_DIR)
+
+.PHONY: configure
+configure:
+	cmake --preset $(PRESET_NAME)
+
+.PHONY: build
+build:
+	cmake --build $(BUILD_DIR) --target all --parallel 6
+
+.PHONY: test
+test:
+	ctest --test-dir $(BUILD_DIR)

cpp-algorithm/Makefile

@@ -2,7 +2,7 @@
 
 auto DutchFlag::DutchFlagPartition1(const int pivot_index, std::vector<Color>& arr) -> std::vector<Color>
 {
-    const auto pivot = arr[pivot_index];
+    const Color pivot = arr[pivot_index];
 
     for (int i = 0; i < static_cast<Color>(arr.size()); ++i)
     {
@@ -32,7 +32,7 @@ auto DutchFlag::DutchFlagPartition1(const int pivot_index, std::vector<Color>& a
 
 auto DutchFlag::DutchFlagPartition2(const int pivot_index, std::vector<Color>& arr) -> std::vector<Color>
 {
-    const auto pivot = arr[pivot_index];
+    const Color pivot = arr[pivot_index];
 
     int smaller = 0;
     for (int i = 0; i < static_cast<Color>(arr.size()); ++i)
@@ -57,7 +57,7 @@ auto DutchFlag::DutchFlagPartition2(const int pivot_index, std::vector<Color>& a
 
 auto DutchFlag::DutchFlagPartition3(const int pivot_index, std::vector<Color>& arr) -> std::vector<Color>
 {
-    const auto pivot = arr[pivot_index];
+    const Color pivot = arr[pivot_index];
 
     int smaller = 0;
     int equal = 0;

cpp-algorithm/src/array/dutch_national_flag.cpp

@@ -14,6 +14,37 @@ auto RandomDataSampling::OfflineRandomSampling(const int k, std::vector<int>& ar
     return std::vector<int>{arr.begin(), arr.begin() + k};
 }
 
+auto RandomDataSampling::OnlineRandomSampling(std::vector<int>::const_iterator begin,
+                                              const std::vector<int>::const_iterator end,
+                                              const int k)
+    -> std::vector<int>
+{
+    std::vector<int> running_sample;
+    // save the first k elements
+    for (int i = 0; i < k; ++i)
+    {
+        running_sample.emplace_back(*begin++);
+    }
+
+    std::default_random_engine seed((std::random_device())());
+    int num_seen_so_far = k;
+    while (begin != end)
+    {
+        int x = *begin++;
+        ++num_seen_so_far;
+
+        // generate a random number in [0, num_seen_so_far].
+        // if the generated number exists in [0, k), replace the element with x.
+        const int idx_to_replace = std::uniform_int_distribution<int>{0, num_seen_so_far - 1}(seed);
+        if (idx_to_replace < k)
+        {
+            running_sample[idx_to_replace] = x;
+        }
+    }
+
+    return running_sample;
+}
+
 auto RandomDataSampling::ComputeRandomPermutation(const int n) -> std::vector<int>
 {
     auto permutation = std::vector<int>(n);

cpp-algorithm/src/array/random_data_sampling.cpp

@@ -6,23 +6,25 @@
 namespace RandomDataSampling
 {
     /**
-     * \brief Randomly select k elements from the array.
+     * \brief Select the k elements randomly from the array with uniform probability.
+     * Let A be an array with n distinct elements. Design an algorithm to return a random subset of k elements from A, where every subset has an equal chance of being chosen.
      * \param k sample size
      * \param arr input array
      * \return result array
      */
     auto OfflineRandomSampling(int k, std::vector<int>& arr) -> std::vector<int>;
 
-    // TODO: Implement OnlineRandomSampling
     /**
-     * \brief Randomly select k elements from the array.
+     * \brief Select the k elements randomly from the array with uniform probability.
+     * Design an algorithm that reads data and creates a random subset of size k, where each item has an equal chance of being included.
      * \param begin begin iterator
      * \param end end iterator
      * \param k sample size
      * \return result array
      */
-    auto OnlineRandomSampling(const std::vector<int>::const_iterator& begin,
-                              const std::vector<int>::const_iterator& end, int k)
+    auto OnlineRandomSampling(std::vector<int>::const_iterator begin,
+                              std::vector<int>::const_iterator end,
+                              int k)
         -> std::vector<int>;
 
     /**

cpp-algorithm/src/array/random_data_sampling.h

@@ -27,7 +27,7 @@ auto StockTrading::BuyAndSellStockOnce(const std::vector<int>& prices) -> double
 
     for (double price : prices)
     {
-        auto max_profit_sell_today = price - min_price_so_far;
+        double max_profit_sell_today = price - min_price_so_far;
         max_profit = std::max(max_profit, max_profit_sell_today);
         min_price_so_far = std::min(min_price_so_far, price);
     }