Skip to content

Commit eb86709

Browse files
committed
Remove defunct tests
1 parent 9aeb866 commit eb86709

File tree

4 files changed

+2
-34
lines changed

4 files changed

+2
-34
lines changed

cli/root.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ func (r *RootCmd) Root() *serpent.Command {
8080

8181
ctx := i.Context()
8282

83-
presets, _ := preview.PreviewPresets(ctx, dfs)
83+
output, _ := preview.Preview(ctx, preview.Input{}, dfs)
84+
presets := output.Presets
8485
chosenPresetIndex := slices.IndexFunc(presets, func(p types.Preset) bool {
8586
return p.Name == preset
8687
})

preview_test.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -243,21 +243,6 @@ func Test_Extract(t *testing.T) {
243243
errorDiagnostics("Required"),
244244
},
245245
},
246-
{
247-
name: "empty preset",
248-
dir: "emptypreset",
249-
expTags: map[string]string{},
250-
input: preview.Input{},
251-
unknownTags: []string{},
252-
presets: func(t *testing.T, presets []types.Preset) {
253-
require.Len(t, presets, 1)
254-
preset := presets[0]
255-
require.Len(t, preset.Diagnostics, 1)
256-
require.Equal(t, preset.Diagnostics[0].Summary, "Invalid \"name\" attribute for block coder_workspace_preset.test")
257-
require.Equal(t, preset.Diagnostics[0].Detail, "Expected a string, got \"<nil>\"")
258-
},
259-
failPreview: false,
260-
},
261246
{
262247
name: "invalid presets",
263248
dir: "invalidpresets",
@@ -270,9 +255,6 @@ func Test_Extract(t *testing.T) {
270255
},
271256
presets: func(t *testing.T, presets []types.Preset) {
272257
presetMap := map[string]func(t *testing.T, preset types.Preset){
273-
"": func(t *testing.T, preset types.Preset) {
274-
require.Len(t, preset.Diagnostics, 0)
275-
},
276258
"empty_parameters": func(t *testing.T, preset types.Preset) {
277259
require.Len(t, preset.Diagnostics, 0)
278260
},

testdata/emptypreset/main.tf

Lines changed: 0 additions & 11 deletions
This file was deleted.

testdata/invalidpresets/main.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ data "coder_parameter" "valid_parameter" {
1616
}
1717
}
1818

19-
data "coder_workspace_preset" "invalid_preset_name" {
20-
name = ""
21-
}
22-
2319
data "coder_workspace_preset" "no_parameters" {
2420
name = "no_parameters"
2521
}

0 commit comments

Comments
 (0)