-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): update dependency urllib3 to v1.26.19 [security] #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 83.31% 83.31%
=======================================
Files 47 47
Lines 1139 1139
=======================================
Hits 949 949
Misses 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8c8d99a to
9134657
Compare
9134657 to
6dc00fd
Compare
6dc00fd to
c11d368
Compare
c11d368 to
2ee2b18
Compare
2ee2b18 to
ae4f075
Compare
ae4f075 to
f9c5352
Compare
This PR contains the following updates:
==1.26.10->==1.26.19GitHub Vulnerability Alerts
CVE-2023-43804
urllib3 doesn't treat the
CookieHTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookieheader and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookieheader, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Cookieheader on requests, which is mostly typical for impersonating a browser.Remediation
redirects=Falsewhen sending requests.Cookieheader.CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like
POST) toGETas is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.From RFC 9110 Section 9.3.1:
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
Remediation
You can remediate this vulnerability with any of the following steps:
redirects=False.redirects=Falseand handle 303 redirects manually by stripping the HTTP request body.CVE-2024-37891
When using urllib3's proxy support with
ProxyManager, theProxy-Authorizationheader is only sent to the configured proxy, as expected.However, when sending HTTP requests without using urllib3's proxy support, it's possible to accidentally configure the
Proxy-Authorizationheader even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat theProxy-AuthorizationHTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects.Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the
Proxy-Authorizationheader during cross-origin redirects to avoid the small chance that users are doing this on accident.Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the
Proxy-Authorizationheader, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Proxy-Authorizationheader without using urllib3's built-in proxy support.Remediation
Proxy-Authorizationheader with urllib3'sProxyManager.redirects=Falsewhen sending requests.Proxy-Authorizationheader.Release Notes
urllib3/urllib3 (urllib3)
v1.26.19Compare Source
====================
Proxy-Authorizationheader to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect.#​3405 <https://github.com/urllib3/urllib3/issues/3405>__)v1.26.18Compare Source
====================
v1.26.17Compare Source
====================
Cookieheader to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect. (#​3139 <https://github.com/urllib3/urllib3/pull/3139>_)v1.26.16Compare Source
====================
PoolManagerwith many distinct originswould cause connection pools to be closed while requests are in progress (
#​2954 <https://github.com/urllib3/urllib3/pull/2954>_)v1.26.15Compare Source
====================
HTTPConnectionis reused (#​2645 <https://github.com/urllib3/urllib3/issues/2645>__)(
#​2899 <https://github.com/urllib3/urllib3/issues/2899>__)#​2901 <https://github.com/urllib3/urllib3/issues/2901>__)v1.26.14Compare Source
====================
#​2850 <https://github.com/urllib3/urllib3/issues/2850>__)PoolKey.key_retriesby addingboolto the union. (#​2865 <https://github.com/urllib3/urllib3/issues/2865>__)v1.26.13Compare Source
====================
HTTPResponse.getheaders()andHTTPResponse.getheader()methods.even when the port number after removing the zeroes was valid.
<4in theRequires-Pythonpackaging metadata field.v1.26.12Compare Source
====================
urllib3[secure]extra and theurllib3.contrib.pyopensslmodule.Both will be removed in v2.x. See this
GitHub issue <https://github.com/urllib3/urllib3/issues/2680>_for justification and info on how to migrate.
v1.26.11Compare Source
====================
HTTPResponse.readwouldraise an
OverflowErroron Python 3.9 and earlier.Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.