Skip to content

fix: cloud search download #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imantsk merged 2 commits into from
Feb 5, 2026
+54 −16
Merged

fix: cloud search download #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c19faf
fix: improve validation and sanitization for cloud search download ac…
imantsk Feb 3, 2026
ecb3647
fix: enhance nonce handling for cloud snippet download and update act…
imantsk Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions src/php/cloud/class-cloud-search-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,33 @@ public function process_actions() {
);

// Check request is coming from the cloud search page.
if ( isset( $_REQUEST['type'] ) && 'cloud_search' === $_REQUEST['type'] ) {
if ( isset( $_REQUEST['action'], $_REQUEST['snippet'], $_REQUEST['source'] ) ) {
cloud_lts_process_download_action(
sanitize_key( wp_unslash( $_REQUEST['action'] ) ),
sanitize_key( wp_unslash( $_REQUEST['source'] ) ),
sanitize_key( wp_unslash( $_REQUEST['snippet'] ) ),
);
}
if ( ! isset( $_REQUEST['type'] ) || 'cloud_search' !== sanitize_key( wp_unslash( $_REQUEST['type'] ) ) ) {
return;
}

if ( ! isset( $_REQUEST['action'], $_REQUEST['snippet'], $_REQUEST['source'] ) ) {
return;
}

$action = sanitize_key( wp_unslash( $_REQUEST['action'] ) );
$source = sanitize_key( wp_unslash( $_REQUEST['source'] ) );
$snippet_id = absint( wp_unslash( $_REQUEST['snippet'] ) );

if ( ! in_array( $action, [ 'download', 'update' ], true ) ) {
return;
}

if ( ! $snippet_id ) {
return;
}

check_admin_referer( cloud_lts_get_snippet_action_nonce_action( $action, $snippet_id, $source ) );

cloud_lts_process_download_action(
$action,
$source,
(string) $snippet_id,
);
}

/**
Expand Down
36 changes: 28 additions & 8 deletions src/php/cloud/list-table-shared-ops.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,19 @@

use function Code_Snippets\code_snippets;

/**
* Build the nonce action string for cloud snippet state-changing operations.
*
* @param string $action Action - 'download' or 'update'.
* @param int $snippet_id Cloud snippet ID.
* @param string $source Source - 'search' or 'cloud'.
*
* @return string
*/
function cloud_lts_get_snippet_action_nonce_action( string $action, int $snippet_id, string $source ): string {
return sprintf( 'cloud-snippet-action|%s|%s|%d', $action, $source, $snippet_id );
}

/**
* Display a hidden input field for a certain column and snippet value.
*
Expand Down Expand Up @@ -82,15 +95,19 @@ function cloud_lts_build_action_links( Cloud_Snippet $cloud_snippet, string $sou
$link = code_snippets()->cloud_api->get_link_for_cloud_snippet( $cloud_snippet );
$is_licensed = code_snippets()->licensing->is_licensed();
$download = $is_licensed || ! in_array( $lang, [ 'css', 'js' ], true );
$snippet_id = (int) $cloud_snippet->id;

if ( $link ) {
if ( $is_licensed && $link->update_available ) {
$update_url = add_query_arg(
[
'action' => 'update',
'snippet' => $cloud_snippet->id,
'source' => $source,
]
$update_url = wp_nonce_url(
add_query_arg(
[
'action' => 'update',
'snippet' => $snippet_id,
'source' => $source,
]
),
cloud_lts_get_snippet_action_nonce_action( 'update', $snippet_id, $source )
);
return sprintf(
'<li><a class="button button-primary" href="%s">%s</a></li>',
Expand All @@ -109,7 +126,7 @@ function cloud_lts_build_action_links( Cloud_Snippet $cloud_snippet, string $sou
if ( $download ) {
$download_query = [
'action' => 'download',
'snippet' => $cloud_snippet->id,
'snippet' => $snippet_id,
'source' => $source,
];

Expand All @@ -118,7 +135,10 @@ function cloud_lts_build_action_links( Cloud_Snippet $cloud_snippet, string $sou
$download_query['cloud_page'] = (int) wp_unslash( $_REQUEST['cloud_page'] );
}

$download_url = add_query_arg( $download_query );
$download_url = wp_nonce_url(
add_query_arg( $download_query ),
cloud_lts_get_snippet_action_nonce_action( 'download', $snippet_id, $source )
);

$download_button = sprintf(
'<li><a class="button button-primary" href="%s">%s</a></li>',
Expand Down