Skip to content

Commit d94065e

Browse files
author
Zaydek Michels-Gualtieri
committed
Prototyped new testKeyDown API and test suite
1 parent d315c90 commit d94065e

File tree

9 files changed

+423
-192
lines changed

9 files changed

+423
-192
lines changed

‎src/RichTextEditor/utils/keyDownTypeFor/applyFormat.test.js‎

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,20 @@ import { // Unsorted
1212
test("em(...); non-macOS", () => {
1313
mockNonMacOS()
1414
expect(applyFormat.em({
15-
shiftKey: false,
16-
ctrlKey: true,
17-
altKey: false,
18-
metaKey: false,
15+
shiftKey: 0,
16+
ctrlKey: 1,
17+
altKey: 0,
18+
metaKey: 0,
1919
keyCode: keyCodeFor("I"),
2020
})).toBeTruthy()
2121
})
2222
test("em(...); macOS", () => {
2323
mockMacOS()
2424
expect(applyFormat.em({
25-
shiftKey: false,
26-
ctrlKey: false,
27-
altKey: false,
28-
metaKey: true,
25+
shiftKey: 0,
26+
ctrlKey: 0,
27+
altKey: 0,
28+
metaKey: 1,
2929
keyCode: keyCodeFor("I"),
3030
})).toBeTruthy()
3131
})
@@ -36,20 +36,20 @@ test("em(...); macOS", () => {
3636
test("strong(...); non-macOS", () => {
3737
mockNonMacOS()
3838
expect(applyFormat.strong({
39-
shiftKey: false,
40-
ctrlKey: true,
41-
altKey: false,
42-
metaKey: false,
39+
shiftKey: 0,
40+
ctrlKey: 1,
41+
altKey: 0,
42+
metaKey: 0,
4343
keyCode: keyCodeFor("B"),
4444
})).toBeTruthy()
4545
})
4646
test("strong(...); macOS", () => {
4747
mockMacOS()
4848
expect(applyFormat.strong({
49-
shiftKey: false,
50-
ctrlKey: false,
51-
altKey: false,
52-
metaKey: true,
49+
shiftKey: 0,
50+
ctrlKey: 0,
51+
altKey: 0,
52+
metaKey: 1,
5353
keyCode: keyCodeFor("B"),
5454
})).toBeTruthy()
5555
})
@@ -60,20 +60,20 @@ test("strong(...); macOS", () => {
6060
test("code(...); non-macOS", () => {
6161
mockNonMacOS()
6262
expect(applyFormat.code({
63-
shiftKey: true,
64-
ctrlKey: true,
65-
altKey: false,
66-
metaKey: false,
63+
shiftKey: 1,
64+
ctrlKey: 1,
65+
altKey: 0,
66+
metaKey: 0,
6767
keyCode: keyCodeFor("C"),
6868
})).toBeTruthy()
6969
})
7070
test("code(...); macOS", () => {
7171
mockMacOS()
7272
expect(applyFormat.code({
73-
shiftKey: true,
74-
ctrlKey: false,
75-
altKey: false,
76-
metaKey: true,
73+
shiftKey: 1,
74+
ctrlKey: 0,
75+
altKey: 0,
76+
metaKey: 1,
7777
keyCode: keyCodeFor("C"),
7878
})).toBeTruthy()
7979
})
@@ -84,20 +84,20 @@ test("code(...); macOS", () => {
8484
test("strike(...); non-macOS", () => {
8585
mockNonMacOS()
8686
expect(applyFormat.strike({
87-
shiftKey: true,
88-
ctrlKey: true,
89-
altKey: false,
90-
metaKey: false,
87+
shiftKey: 1,
88+
ctrlKey: 1,
89+
altKey: 0,
90+
metaKey: 0,
9191
keyCode: keyCodeFor("X"),
9292
})).toBeTruthy()
9393
})
9494
test("strike(...); macOS", () => {
9595
mockMacOS()
9696
expect(applyFormat.strike({
97-
shiftKey: true,
98-
ctrlKey: false,
99-
altKey: false,
100-
metaKey: true,
97+
shiftKey: 1,
98+
ctrlKey: 0,
99+
altKey: 0,
100+
metaKey: 1,
101101
keyCode: keyCodeFor("X"),
102102
})).toBeTruthy()
103103
})
@@ -108,20 +108,20 @@ test("strike(...); macOS", () => {
108108
test("a(...); non-macOS", () => {
109109
mockNonMacOS()
110110
expect(applyFormat.a({
111-
shiftKey: false,
112-
ctrlKey: true,
113-
altKey: false,
114-
metaKey: false,
111+
shiftKey: 0,
112+
ctrlKey: 1,
113+
altKey: 0,
114+
metaKey: 0,
115115
keyCode: keyCodeFor("K"),
116116
})).toBeTruthy()
117117
})
118118
test("a(...); macOS", () => {
119119
mockMacOS()
120120
expect(applyFormat.a({
121-
shiftKey: false,
122-
ctrlKey: false,
123-
altKey: false,
124-
metaKey: true,
121+
shiftKey: 0,
122+
ctrlKey: 0,
123+
altKey: 0,
124+
metaKey: 1,
125125
keyCode: keyCodeFor("K"),
126126
})).toBeTruthy()
127127
})

‎src/RichTextEditor/utils/keyDownTypeFor/applyFormatMarkdown.test.js‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,60 +3,60 @@ import keyCodeFor from "lib/Client/keyCodeFor"
33

44
test("em(...)", () => {
55
expect(applyFormatMarkdown.em({
6-
shiftKey: true,
7-
ctrlKey: false,
8-
altKey: false,
9-
metaKey: false,
6+
shiftKey: 1,
7+
ctrlKey: 0,
8+
altKey: 0,
9+
metaKey: 0,
1010
keyCode: keyCodeFor("_"),
1111
})).toBeTruthy()
1212
})
1313

1414
test("strong(...)", () => {
1515
expect(applyFormatMarkdown.strong({
16-
shiftKey: true,
17-
ctrlKey: false,
18-
altKey: false,
19-
metaKey: false,
16+
shiftKey: 1,
17+
ctrlKey: 0,
18+
altKey: 0,
19+
metaKey: 0,
2020
keyCode: keyCodeFor("*"),
2121
})).toBeTruthy()
2222
})
2323

2424
test("code(...)", () => {
2525
expect(applyFormatMarkdown.code({
26-
shiftKey: false,
27-
ctrlKey: false,
28-
altKey: false,
29-
metaKey: false,
26+
shiftKey: 0,
27+
ctrlKey: 0,
28+
altKey: 0,
29+
metaKey: 0,
3030
keyCode: keyCodeFor("`"),
3131
})).toBeTruthy()
3232
})
3333

3434
test("strike(...)", () => {
3535
expect(applyFormatMarkdown.strike({
36-
shiftKey: true,
37-
ctrlKey: false,
38-
altKey: false,
39-
metaKey: false,
36+
shiftKey: 1,
37+
ctrlKey: 0,
38+
altKey: 0,
39+
metaKey: 0,
4040
keyCode: keyCodeFor("~"),
4141
})).toBeTruthy()
4242
})
4343

4444
test("a(...)", () => {
4545
expect(applyFormatMarkdown.a({
46-
shiftKey: false,
47-
ctrlKey: false,
48-
altKey: false,
49-
metaKey: false,
46+
shiftKey: 0,
47+
ctrlKey: 0,
48+
altKey: 0,
49+
metaKey: 0,
5050
keyCode: keyCodeFor("["),
5151
})).toBeTruthy()
5252
})
5353

5454
test("a(...)", () => {
5555
expect(applyFormatMarkdown.a({
56-
shiftKey: false,
57-
ctrlKey: false,
58-
altKey: false,
59-
metaKey: false,
56+
shiftKey: 0,
57+
ctrlKey: 0,
58+
altKey: 0,
59+
metaKey: 0,
6060
keyCode: keyCodeFor("]"),
6161
})).toBeTruthy()
6262
})

‎src/RichTextEditor/utils/keyDownTypeFor/deleteLTR.test.js‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,20 @@ import { // Unsorted
1111
*/
1212
test("rune(...); non-macOS and macOS", () => {
1313
expect(deleteLTR.rune({
14-
shiftKey: false,
15-
ctrlKey: false,
16-
altKey: false,
17-
metaKey: false,
14+
shiftKey: 0,
15+
ctrlKey: 0,
16+
altKey: 0,
17+
metaKey: 0,
1818
keyCode: keyCodeFor("Delete"),
1919
})).toBeTruthy()
2020
})
2121
test("rune(...); macOS", () => {
2222
mockMacOS()
2323
expect(deleteLTR.rune({
24-
shiftKey: false,
25-
ctrlKey: true,
26-
altKey: false,
27-
metaKey: false,
24+
shiftKey: 0,
25+
ctrlKey: 1,
26+
altKey: 0,
27+
metaKey: 0,
2828
keyCode: keyCodeFor("D"),
2929
})).toBeTruthy()
3030
})
@@ -35,20 +35,20 @@ test("rune(...); macOS", () => {
3535
test("word(...); non-macOS", () => {
3636
mockNonMacOS()
3737
expect(deleteLTR.word({
38-
shiftKey: false,
39-
ctrlKey: true,
40-
altKey: false,
41-
metaKey: false,
38+
shiftKey: 0,
39+
ctrlKey: 1,
40+
altKey: 0,
41+
metaKey: 0,
4242
keyCode: keyCodeFor("Delete"),
4343
})).toBeTruthy()
4444
})
4545
test("word(...); macOS", () => {
4646
mockMacOS()
4747
expect(deleteLTR.word({
48-
shiftKey: false,
49-
ctrlKey: true,
50-
altKey: true,
51-
metaKey: false,
48+
shiftKey: 0,
49+
ctrlKey: 1,
50+
altKey: 1,
51+
metaKey: 0,
5252
keyCode: keyCodeFor("Delete"),
5353
})).toBeTruthy()
5454
})

‎src/RichTextEditor/utils/keyDownTypeFor/deleteRTL.test.js‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ import { // Unsorted
1111
*/
1212
test("rune(...)", () => {
1313
expect(deleteRTL.rune({
14-
shiftKey: false,
15-
ctrlKey: false,
16-
altKey: false,
17-
metaKey: false,
14+
shiftKey: 0,
15+
ctrlKey: 0,
16+
altKey: 0,
17+
metaKey: 0,
1818
keyCode: keyCodeFor("Backspace"),
1919
})).toBeTruthy()
2020
})
@@ -25,20 +25,20 @@ test("rune(...)", () => {
2525
test("word(...); non-macOS", () => {
2626
mockNonMacOS()
2727
expect(deleteRTL.word({
28-
shiftKey: false,
29-
ctrlKey: true,
30-
altKey: false,
31-
metaKey: false,
28+
shiftKey: 0,
29+
ctrlKey: 1,
30+
altKey: 0,
31+
metaKey: 0,
3232
keyCode: keyCodeFor("Backspace"),
3333
})).toBeTruthy()
3434
})
3535
test("word(...); macOS", () => {
3636
mockMacOS()
3737
expect(deleteRTL.word({
38-
shiftKey: false,
39-
ctrlKey: false,
40-
altKey: true,
41-
metaKey: false,
38+
shiftKey: 0,
39+
ctrlKey: 0,
40+
altKey: 1,
41+
metaKey: 0,
4242
keyCode: keyCodeFor("Backspace"),
4343
})).toBeTruthy()
4444
})
@@ -49,10 +49,10 @@ test("word(...); macOS", () => {
4949
test("line(...); macOS", () => {
5050
mockMacOS()
5151
expect(deleteRTL.line({
52-
shiftKey: false,
53-
ctrlKey: false,
54-
altKey: false,
55-
metaKey: true,
52+
shiftKey: 0,
53+
ctrlKey: 0,
54+
altKey: 0,
55+
metaKey: 1,
5656
keyCode: keyCodeFor("Backspace"),
5757
})).toBeTruthy()
5858
})

0 commit comments

Comments
 (0)