Skip to content

Commit 8095f73

Browse files
committed
indicate all custom managed resources on sync:network
1 parent 730bfe9 commit 8095f73

12 files changed

+41
-6
lines changed

src/Concerns/UsesEc2.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ public static function rdsSecurityGroup(): array
144144
return static::$rdsSecurityGroup;
145145
}
146146

147-
static::$rdsSecurityGroup = static::securityGroupByName(SecurityGroup::RDS_SECURITY_GROUP);
147+
static::$rdsSecurityGroup = static::securityGroupByName(Manifest::get('aws.rds.security-group', SecurityGroup::RDS_SECURITY_GROUP));
148148

149149
return static::$rdsSecurityGroup;
150150
}

src/Concerns/UsesRds.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ trait UsesRds
1212
{
1313
public static function dbSubnetGroup(): array
1414
{
15-
$name = Manifest::has('aws.database-subnet')
16-
? Manifest::get('aws.database-subnet')
15+
$name = Manifest::has('aws.rds.subnet')
16+
? Manifest::get('aws.rds.subnet')
1717
: Helpers::keyedResourceName(Rds::PUBLIC_SUBNET_GROUP);
1818

1919
$dbSubnetGroups = Aws::rds()->describeDBSubnetGroups();

src/Enums/StepResult.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,9 @@ enum StepResult
99
case WOULD_CREATE;
1010

1111
case SYNCED;
12-
case IN_SYNC;
1312
case OUT_OF_SYNC;
1413
case WOULD_SYNC;
1514

16-
case CONDITIONAL;
1715
case CUSTOM_MANAGED;
1816
case TIMEOUT;
1917
case SKIPPED;

src/Steps/Network/SyncEc2SecurityGroupStep.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function __invoke(array $options): StepResult
2626
try {
2727
$securityGroup = AwsResources::ec2SecurityGroup();
2828

29-
if (Manifest::get('aws.ec2.security-group')) {
29+
if (Manifest::has('aws.ec2.security-group')) {
3030
return StepResult::CUSTOM_MANAGED;
3131
}
3232

src/Steps/Network/SyncInternetGatewayStep.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Codinglabs\Yolo\Aws;
66
use Illuminate\Support\Arr;
77
use Codinglabs\Yolo\Helpers;
8+
use Codinglabs\Yolo\Manifest;
89
use Codinglabs\Yolo\AwsResources;
910
use Codinglabs\Yolo\Contracts\Step;
1011
use Codinglabs\Yolo\Enums\StepResult;
@@ -17,6 +18,10 @@ public function __invoke(array $options): StepResult
1718
try {
1819
AwsResources::internetGateway();
1920

21+
if (Manifest::has('aws.internet-gateway')) {
22+
return StepResult::CUSTOM_MANAGED;
23+
}
24+
2025
return StepResult::SYNCED;
2126
} catch (ResourceDoesNotExistException $e) {
2227
if (! Arr::get($options, 'dry-run')) {

src/Steps/Network/SyncPublicSubnetAStep.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ public function __invoke(array $options): StepResult
2424
try {
2525
AwsResources::subnetByName($publicSubnetName, relative: Manifest::doesntHave('aws.public-subnets'));
2626

27+
if (Manifest::has('aws.public-subnets')) {
28+
return StepResult::CUSTOM_MANAGED;
29+
}
30+
2731
return StepResult::SYNCED;
2832
} catch (ResourceDoesNotExistException $e) {
2933
if (! Arr::get($options, 'dry-run')) {

src/Steps/Network/SyncPublicSubnetBStep.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ public function __invoke(array $options): StepResult
2424
try {
2525
AwsResources::subnetByName($publicSubnetName, relative: Manifest::doesntHave('aws.public-subnets'));
2626

27+
if (Manifest::has('aws.public-subnets')) {
28+
return StepResult::CUSTOM_MANAGED;
29+
}
30+
2731
return StepResult::SYNCED;
2832
} catch (ResourceDoesNotExistException $e) {
2933
if (! Arr::get($options, 'dry-run')) {

src/Steps/Network/SyncPublicSubnetCStep.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ public function __invoke(array $options): StepResult
2424
try {
2525
AwsResources::subnetByName($publicSubnetName, relative: Manifest::doesntHave('aws.public-subnets'));
2626

27+
if (Manifest::has('aws.public-subnets')) {
28+
return StepResult::CUSTOM_MANAGED;
29+
}
30+
2731
return StepResult::SYNCED;
2832
} catch (ResourceDoesNotExistException $e) {
2933
if (! Arr::get($options, 'dry-run')) {

src/Steps/Network/SyncRdsSecurityGroupStep.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Codinglabs\Yolo\Aws;
66
use Illuminate\Support\Arr;
77
use Codinglabs\Yolo\Helpers;
8+
use Codinglabs\Yolo\Manifest;
89
use Codinglabs\Yolo\AwsResources;
910
use Codinglabs\Yolo\Contracts\Step;
1011
use Codinglabs\Yolo\Enums\StepResult;
@@ -18,6 +19,10 @@ public function __invoke(array $options): StepResult
1819
try {
1920
AwsResources::rdsSecurityGroup();
2021

22+
if (Manifest::has('aws.rds.security-group')) {
23+
return StepResult::CUSTOM_MANAGED;
24+
}
25+
2126
return StepResult::SYNCED;
2227
} catch (ResourceDoesNotExistException) {
2328
if (! Arr::get($options, 'dry-run')) {

src/Steps/Network/SyncRdsSubnetStep.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Codinglabs\Yolo\Aws;
66
use Illuminate\Support\Arr;
77
use Codinglabs\Yolo\Helpers;
8+
use Codinglabs\Yolo\Manifest;
89
use Codinglabs\Yolo\Enums\Rds;
910
use Codinglabs\Yolo\AwsResources;
1011
use Codinglabs\Yolo\Contracts\Step;
@@ -18,6 +19,10 @@ public function __invoke(array $options): StepResult
1819
try {
1920
AwsResources::dbSubnetGroup();
2021

22+
if (Manifest::has('aws.rds.subnet')) {
23+
return StepResult::CUSTOM_MANAGED;
24+
}
25+
2126
return StepResult::SYNCED;
2227
} catch (ResourceDoesNotExistException $e) {
2328
if (! Arr::get($options, 'dry-run')) {

0 commit comments

Comments
 (0)