Steve/lpx 369 increase yolo queue depth alarm settings (#8)

* expose queue configuration in manifest and change to Average statistic

* update tenant queue alarm

* fix key

* rename keys

Author: stevethomas

README.md

@@ -245,6 +245,10 @@ environments:
         security-group:
       codedeploy:
         strategy: without-load-balancing|with-load-balancing
+      queue:
+        depth-alarm-evaluation-periods: 3
+        depth-alarm-period: 300
+        depth-alarm-threshold: 100
 
     asset-url: # defaults to aws.cloudfront
     mysqldump: false

src/Steps/Standalone/SyncQueueAlarmStep.php

@@ -5,6 +5,7 @@
 use Codinglabs\Yolo\Aws;
 use Illuminate\Support\Arr;
 use Codinglabs\Yolo\Helpers;
+use Codinglabs\Yolo\Manifest;
 use Codinglabs\Yolo\AwsResources;
 use Codinglabs\Yolo\Contracts\Step;
 use Codinglabs\Yolo\Enums\StepResult;
@@ -40,12 +41,12 @@ public function __invoke(array $options): StepResult
                     'Value' => Helpers::keyedResourceName(),
                 ],
             ],
-            'EvaluationPeriods' => 3, // number of breached of Period before alarm
+            'EvaluationPeriods' => Manifest::get('aws.queue.depth-alarm-evaluation-periods', 3), // number of breaches of the Period before alarm
             'MetricName' => 'ApproximateNumberOfMessagesVisible',
             'Namespace' => 'AWS/SQS',
-            'Period' => 300, // time to evaluate the metric
-            'Statistic' => 'Sum',
-            'Threshold' => 100,
+            'Period' => Manifest::get('aws.queue.depth-alarm-period', 300), // time to evaluate the metric
+            'Statistic' => 'Average',
+            'Threshold' => Manifest::get('aws.queue.depth-alarm-threshold', 100),
             'TreatMissingData' => 'notBreaching',
             'AlarmActions' => [$snsTopic['TopicArn']],
             'OKActions' => [$snsTopic['TopicArn']],

src/Steps/Tenant/SyncQueueAlarmStep.php

@@ -5,6 +5,7 @@
 use Codinglabs\Yolo\Aws;
 use Illuminate\Support\Arr;
 use Codinglabs\Yolo\Helpers;
+use Codinglabs\Yolo\Manifest;
 use Codinglabs\Yolo\AwsResources;
 use Codinglabs\Yolo\Enums\StepResult;
 use Codinglabs\Yolo\Steps\TenantStep;
@@ -40,12 +41,12 @@ public function __invoke(array $options): StepResult
                     'Value' => Helpers::keyedResourceName($this->tenantId()),
                 ],
             ],
-            'EvaluationPeriods' => 3, // number of breached of Period before alarm
+            'EvaluationPeriods' => Manifest::get('aws.queue.depth-alarm-evaluation-periods', 3), // number of breaches of the Period before alarm
             'MetricName' => 'ApproximateNumberOfMessagesVisible',
             'Namespace' => 'AWS/SQS',
-            'Period' => 300, // time to evaluate the metric
-            'Statistic' => 'Sum',
-            'Threshold' => 100,
+            'Period' => Manifest::get('aws.queue.depth-alarm-period', 300), // time to evaluate the metric
+            'Statistic' => 'Average',
+            'Threshold' => Manifest::get('aws.queue.depth-alarm-threshold', 100),
             'TreatMissingData' => 'notBreaching',
             'AlarmActions' => [$snsTopic['TopicArn']],
             'OKActions' => [$snsTopic['TopicArn']],