Implemented TicTacToe feature #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| export class Game { | ||
| private _lastSymbol: string = ' '; | ||
| private _board: Board = new Board(); | ||
|
|
||
| public Play(symbol: string, x: number, y: number) : void { | ||
| //if first move | ||
| if (this._lastSymbol == ' ') { | ||
| //if player is X | ||
| if (symbol == 'O') { | ||
| throw new Error("Invalid first player"); | ||
| } | ||
| } | ||
| //if not first move but player repeated | ||
| else if (symbol == this._lastSymbol) { | ||
| throw new Error("Invalid next player"); | ||
| } | ||
| //if not first move but play on an already played tile | ||
| else if (this._board.TileAt(x, y).Symbol != ' ') { | ||
| throw new Error("Invalid position"); | ||
| } | ||
|
|
||
| // update game state | ||
| this._lastSymbol = symbol; | ||
| this._board.AddTileAt(symbol, x, y); | ||
| } | ||
|
There was a problem hiding this comment. This function is breaking rule one of the SOLID Princple (single responsibility)
Author
There was a problem hiding this comment. You can list the responsibilities with a name, you can never go bad with an apporach like that, I've came with this two, surely there can be better ones. Responsibilites in this class: |
||
|
|
||
| public Winner() : string { | ||
| //if the positions in first row are taken | ||
| if (this._board.TileAt(0, 0)!.Symbol != ' ' && | ||
|
Author
There was a problem hiding this comment. The internal content is exposed so it can be modified by external classes We not only can access to the internals of the board but also we have to learn a protocol to interpret it. The convention |
||
| this._board.TileAt(0, 1)!.Symbol != ' ' && | ||
| this._board.TileAt(0, 2)!.Symbol != ' ') { | ||
| //if first row is full with same symbol | ||
| if (this._board.TileAt(0, 0)!.Symbol == | ||
| this._board.TileAt(0, 1)!.Symbol && | ||
| this._board.TileAt(0, 2)!.Symbol == this._board.TileAt(0, 1)!.Symbol) { | ||
| return this._board.TileAt(0, 0)!.Symbol; | ||
| } | ||
| } | ||
|
|
||
| //if the positions in first row are taken | ||
| if (this._board.TileAt(1, 0)!.Symbol != ' ' && | ||
| this._board.TileAt(1, 1)!.Symbol != ' ' && | ||
| this._board.TileAt(1, 2)!.Symbol != ' ') { | ||
| //if middle row is full with same symbol | ||
| if (this._board.TileAt(1, 0)!.Symbol == | ||
| this._board.TileAt(1, 1)!.Symbol && | ||
| this._board.TileAt(1, 2)!.Symbol == | ||
| this._board.TileAt(1, 1)!.Symbol) { | ||
| return this._board.TileAt(1, 0)!.Symbol; | ||
| } | ||
| } | ||
|
|
||
| //if the positions in first row are taken | ||
| if (this._board.TileAt(2, 0)!.Symbol != ' ' && | ||
| this._board.TileAt(2, 1)!.Symbol != ' ' && | ||
| this._board.TileAt(2, 2)!.Symbol != ' ') { | ||
| //if middle row is full with same symbol | ||
| if (this._board.TileAt(2, 0)!.Symbol == | ||
| this._board.TileAt(2, 1)!.Symbol && | ||
| this._board.TileAt(2, 2)!.Symbol == | ||
| this._board.TileAt(2, 1)!.Symbol) { | ||
| return this._board.TileAt(2, 0)!.Symbol; | ||
| } | ||
| } | ||
|
|
||
| return ' '; | ||
| } | ||
| } | ||
|
|
||
| interface Tile | ||
| { | ||
| X: number; | ||
| Y: number; | ||
| Symbol: string; | ||
| } | ||
|
|
||
| class Board | ||
| { | ||
| private _plays : Tile[] = []; | ||
|
|
||
| constructor() | ||
| { | ||
| for (let i = 0; i < 3; i++) | ||
| { | ||
| for (let j = 0; j < 3; j++) | ||
| { | ||
| const tile : Tile = {X :i, Y:j, Symbol:" "}; | ||
| this._plays.push(tile); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public TileAt(x: number, y: number): Tile { | ||
| return this._plays.find((t:Tile) => t.X == x && t.Y == y)! | ||
| } | ||
|
|
||
| public AddTileAt(symbol: string, x: number, y: number) : void | ||
| { | ||
| const tile : Tile = {X :x, Y:y, Symbol:symbol}; | ||
|
|
||
| this._plays.find((t:Tile) => t.X == x && t.Y == y)!.Symbol = symbol; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this._board.TileAt(x, y).Symbolcontent coupling