From a8a5a5317297dc6665cd3633e803b135a1d070f0 Mon Sep 17 00:00:00 2001 From: Edouard Gouilliard Date: Sun, 19 Apr 2026 12:14:21 +0100 Subject: [PATCH] fix(workflow): close-fixed-issues also catches out-of-scope + orphaned done The close-fixed-issues node now checks for three categories: 1. Issues inadvertently fixed by code changes 2. Issues with scope constraint comments (no-LLM, out of scope) 3. Issues with "Implementation Complete" comments but not closed Co-Authored-By: Claude Opus 4.6 (1M context) --- .archon/workflows/dev-pipeline.yaml | 33 ++++++++++++++++++++++------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/.archon/workflows/dev-pipeline.yaml b/.archon/workflows/dev-pipeline.yaml index b25c022..41a32a0 100644 --- a/.archon/workflows/dev-pipeline.yaml +++ b/.archon/workflows/dev-pipeline.yaml @@ -950,27 +950,44 @@ nodes: git diff --name-only hotfix.."$BRANCH" ``` - 3. For each open issue, check if it was ALREADY FIXED by the changes: + 3. For each open issue, check TWO things: + + **A. Already fixed?** Check if the issue was resolved by the changes: - Does the issue mention a file that was modified? - Does the issue describe a bug in a function that was changed? - Read the relevant code to verify the fix is actually in place - Only close if you are CONFIDENT (>90%) the issue is resolved + **B. Out of scope / has constraint comments?** Check the issue comments: + ```bash + gh issue view --json comments --jq '.comments[].body' + ``` + Look for comments containing: + - "no-LLM" or "no-llm" — feature requires LLM which codegraph doesn't use + - "out of scope" or "not in scope" + - "will not implement" or "won't implement" + - "Scope note" with a constraint that makes the issue invalid + - "Implementation Complete" — issue was already done but not closed + + If any of these are found, the issue should be closed. + 4. For each issue that was inadvertently fixed: ```bash - gh issue close --comment "$(cat <<'EOF' - This issue was resolved as a side effect of the changes in PR #. + gh issue close --comment "This issue was resolved as a side effect of the changes in PR #. The fix was applied in commit which modified ." + ``` - The fix was applied in commit which modified . - EOF - )" + 5. For each issue with scope constraints or "Implementation Complete": + ```bash + gh issue close --comment "Closing — this issue has been marked as out of scope or already completed. See prior comments." ``` - 5. Output a summary: + 6. Output a summary: - Issues scanned: N - Issues closed as already fixed: list with numbers and reasons + - Issues closed as out of scope: list with numbers and reasons + - Issues closed as already implemented: list with numbers - Issues still open: count - If no issues were inadvertently fixed, say "No additional issues resolved." + If nothing to close, say "No additional issues resolved." Workflow complete.