From d5a919b7e2a898e4ca4036a5087ce2eceeef7e58 Mon Sep 17 00:00:00 2001 From: Dan Jensen Date: Tue, 21 Jun 2022 18:23:40 -0500 Subject: [PATCH] Fix TypeError when converting back to password After the password input has been converted to text, there is no input matching type=password. However, the JS assumed there is which resuled in a TypeError due to a null result when it looked for the input. This fixes the problem by selecting by class instead. --- js/show-password-toggle.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/js/show-password-toggle.js b/js/show-password-toggle.js index a65e3ce..de41ceb 100644 --- a/js/show-password-toggle.js +++ b/js/show-password-toggle.js @@ -5,12 +5,11 @@ */ var ShowPasswordToggle = document.querySelector("[type='password']"); +ShowPasswordToggle.classList.add("input-password"); +document.getElementById("toggle-password").classList.remove("d-none"); ShowPasswordToggle.onclick = function () { - document.querySelector("[type='password']").classList.add("input-password"); - document.getElementById("toggle-password").classList.remove("d-none"); - - const passwordInput = document.querySelector("[type='password']"); - const togglePasswordButton = document.getElementById("toggle-password"); + var passwordInput = document.querySelector(".input-password"); + var togglePasswordButton = document.getElementById("toggle-password"); togglePasswordButton.addEventListener("click", togglePassword); function togglePassword() {