Library needs to be updated to latest ThreeJS version

[kujukuju]

Getting the error: "Octree.js:2094 Uncaught TypeError: Cannot read property 'faces' of undefined".
I'm pretty sure this is because the library is out of date.

My temporary fix (to help anyone else affected by this) is to change line 2085 to be:
if ( object.object instanceof THREE.Object3D ) { return this.intersectOctreeObject(object.object, recursive);

The "return this.intersectOctreeObject" forces it to keep recursing until it finds the type of non-octree object it's looking for.

Anyways, thought I'd let you know. I'd also like an updated version of the library in case I run into some weird edge cases in the future.

[collinhover]

Line 2085 is https://github.com/collinhover/threeoctree/blob/master/threeoctree.js#L2085. Are you sure you're using the latest version?

/ping @Wilt you're the most familiar with the latest THREE + Octree, any thoughts?

[kujukuju]

Mine is also "threeoctree.js (r60)" so I assume I am.

I did copy the raw file text and paste it into a new js file though (as opposed to downloading it), so maybe some things in the ifle we're moved around when I did that.

In the file you linked, the line I changed was 2150.

[collinhover]

The fix needs to check for intersections on the THREE object. I believe this line is the problem: https://github.com/collinhover/threeoctree/blob/master/threeoctree.js#L2158. Internally THREE must have changed how the geometry/faces are accessed on an object.

[Wilt]

Probably you have a buffer geometry and buffer geometries don't have faces.

[Wilt]

I was working on adding support for buffer geometries but I have lots of other work waiting for me...

[kujukuju]

I am using buffered geometry, you're right. In the meantime hopefully people will see my hacky fix and use that.