Skip to content

fix: permission check for public share deployment runs #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicholasKao1029 merged 1 commit into from
Oct 2, 2025
Merged

fix: permission check for public share deployment runs #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/api/routes/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,15 @@ async def get_run(request: Request, run_id: UUID, queue_position: bool = False,

# Permission check
if deployment is not None and (deployment.environment == "public-share" or deployment.environment == "community-share"):
# Public share, no permission check
if run.user_id == user_id:
# Public share - check if current user owns the deployment
if org_id is not None and deployment.org_id == org_id:
# Current user's org owns the deployment
pass
elif org_id is not None and run.org_id == org_id:
elif deployment.user_id == user_id:
# Current user owns the deployment
pass
else:
# Not the owner, check public access permissions
apply_org_check_direct(deployment, request)
else:
apply_org_check_direct(run, request)
Expand Down