From acd4a58417c0d2c218e0849c1b39a889cbc91a14 Mon Sep 17 00:00:00 2001 From: Dima Shevtsov Date: Tue, 2 Sep 2025 16:17:13 -0500 Subject: [PATCH 1/4] Update ruby dependencies --- CHANGELOG.md | 55 +++++++++++++++ Gemfile.lock | 128 ++++++++++++++++++---------------- lib/whatsup_github/version.rb | 2 +- whatsup_github.gemspec | 4 +- 4 files changed, 127 insertions(+), 62 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3b91f28..9ab6ab6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,60 @@ # Changelog +## 1.2.0 + +Maintenance: + +- Upgraded octokit dependency from ~> 8.0 to ~> 10.0 +- Upgraded cucumber dependency from ~> 9.1 to ~> 10.1 +- Updated all dependencies to their latest compatible versions + +## 1.0.1 + +Fixes: + +- Fixed bug with missing whatsnew in enterprise repos + +## 1.0.0 + +### General + +- Major version release with significant updates +- Updated gemspec dependencies +- Updated Ruby requirement to >= 2.7.0 +- Updated octokit to ~> 6.0 +- Updated thor to ~> 1.2 + +### CLI improvements + +- Added version CLI option +- Removed default option to make 'help' option default + +### Testing + +- Added test for 'version' CLI option +- Updated tests to run with rake by default +- Added code testing workflow +- Removed Travis CI workflow + +### Bug fixes + +- Fixed GitHub API query requirement to include 'is:pull-request' +- Updated search query as required by GitHub API + +## 0.5.0 + +Fixes: + +- Fixed bug "422 - Query must include 'is:issue' or 'is:pull-request'" + +Maintenance: + +- Updated gemspec dependencies +- Updated Ruby requirement to >= 2.7.0 +- Updated octokit to ~> 6.0 +- Updated thor to ~> 1.2 +- Updated development dependencies (aruba, bundler, cucumber, rspec, fileutils, faraday-retry) + ## 0.4.2 Fixes: diff --git a/Gemfile.lock b/Gemfile.lock index d87ec4e..5935c9e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -3,85 +3,95 @@ PATH specs: whatsup_github (1.1.0) netrc (~> 0.11) - octokit (~> 8.0) + octokit (~> 10.0) thor (~> 1.3) GEM remote: https://rubygems.org/ specs: - addressable (2.8.6) - public_suffix (>= 2.0.2, < 6.0) - aruba (2.2.0) + addressable (2.8.7) + public_suffix (>= 2.0.2, < 7.0) + aruba (2.3.1) bundler (>= 1.17, < 3.0) contracts (>= 0.16.0, < 0.18.0) - cucumber (>= 8.0, < 10.0) + cucumber (>= 8.0, < 11.0) rspec-expectations (~> 3.4) thor (~> 1.0) - base64 (0.2.0) - builder (3.2.4) - contracts (0.17) - cucumber (9.1.0) - builder (~> 3.2, >= 3.2.4) - cucumber-ci-environment (~> 9.2, >= 9.2.0) - cucumber-core (~> 12.0) - cucumber-cucumber-expressions (~> 17.0) - cucumber-gherkin (>= 24, < 27) - cucumber-html-formatter (~> 20.4, >= 20.4.0) - cucumber-messages (>= 19, < 23) - diff-lcs (~> 1.5, >= 1.5.0) - mini_mime (~> 1.1, >= 1.1.5) - multi_test (~> 1.1, >= 1.1.0) - sys-uname (~> 1.2, >= 1.2.3) - cucumber-ci-environment (9.2.0) - cucumber-core (12.0.0) - cucumber-gherkin (>= 25, < 27) - cucumber-messages (>= 20, < 23) - cucumber-tag-expressions (~> 5.0, >= 5.0.4) - cucumber-cucumber-expressions (17.0.1) - cucumber-gherkin (26.2.0) - cucumber-messages (>= 19.1.4, < 22.1) - cucumber-html-formatter (20.4.0) - cucumber-messages (>= 18.0, < 22.1) - cucumber-messages (22.0.0) - cucumber-tag-expressions (5.0.6) - diff-lcs (1.5.0) - faraday (2.8.1) - base64 - faraday-net_http (>= 2.0, < 3.1) - ruby2_keywords (>= 0.0.4) - faraday-net_http (3.0.2) - faraday-retry (2.2.0) + base64 (0.3.0) + bigdecimal (3.2.2) + builder (3.3.0) + contracts (0.17.2) + cucumber (10.1.0) + base64 (~> 0.2) + builder (~> 3.2) + cucumber-ci-environment (> 9, < 11) + cucumber-core (> 15, < 17) + cucumber-cucumber-expressions (> 17, < 19) + cucumber-html-formatter (> 20.3, < 22) + diff-lcs (~> 1.5) + logger (~> 1.6) + mini_mime (~> 1.1) + multi_test (~> 1.1) + sys-uname (~> 1.3) + cucumber-ci-environment (10.0.1) + cucumber-core (15.2.1) + cucumber-gherkin (> 27, < 33) + cucumber-messages (> 26, < 30) + cucumber-tag-expressions (> 5, < 7) + cucumber-cucumber-expressions (18.0.1) + bigdecimal + cucumber-gherkin (32.2.0) + cucumber-messages (> 25, < 28) + cucumber-html-formatter (21.14.0) + cucumber-messages (> 19, < 28) + cucumber-messages (27.2.0) + cucumber-tag-expressions (6.1.2) + diff-lcs (1.6.2) + faraday (2.13.4) + faraday-net_http (>= 2.0, < 3.5) + json + logger + faraday-net_http (3.4.1) + net-http (>= 0.5.0) + faraday-retry (2.3.2) faraday (~> 2.0) - ffi (1.16.3) - fileutils (1.7.2) + ffi (1.17.2) + ffi (1.17.2-arm64-darwin) + fileutils (1.7.3) + json (2.13.2) + logger (1.7.0) + memoist3 (1.0.0) mini_mime (1.1.5) multi_test (1.1.0) + net-http (0.6.0) + uri netrc (0.11.0) - octokit (8.0.0) + octokit (10.0.0) faraday (>= 1, < 3) sawyer (~> 0.9) - public_suffix (5.0.4) - rake (13.1.0) - rspec (3.12.0) - rspec-core (~> 3.12.0) - rspec-expectations (~> 3.12.0) - rspec-mocks (~> 3.12.0) - rspec-core (3.12.2) - rspec-support (~> 3.12.0) - rspec-expectations (3.12.3) + public_suffix (6.0.2) + rake (13.3.0) + rspec (3.13.1) + rspec-core (~> 3.13.0) + rspec-expectations (~> 3.13.0) + rspec-mocks (~> 3.13.0) + rspec-core (3.13.5) + rspec-support (~> 3.13.0) + rspec-expectations (3.13.5) diff-lcs (>= 1.2.0, < 2.0) - rspec-support (~> 3.12.0) - rspec-mocks (3.12.6) + rspec-support (~> 3.13.0) + rspec-mocks (3.13.5) diff-lcs (>= 1.2.0, < 2.0) - rspec-support (~> 3.12.0) - rspec-support (3.12.1) - ruby2_keywords (0.0.5) + rspec-support (~> 3.13.0) + rspec-support (3.13.5) sawyer (0.9.2) addressable (>= 2.3.5) faraday (>= 0.17.3, < 3) - sys-uname (1.2.3) + sys-uname (1.4.1) ffi (~> 1.1) - thor (1.3.0) + memoist3 (~> 1.0.0) + thor (1.4.0) + uri (1.0.3) PLATFORMS arm64-darwin-22 @@ -90,7 +100,7 @@ PLATFORMS DEPENDENCIES aruba (~> 2.2) bundler (~> 2.5) - cucumber (~> 9.1) + cucumber (~> 10.1) faraday-retry (~> 2.2) fileutils (~> 1.7) rake (~> 13.1) diff --git a/lib/whatsup_github/version.rb b/lib/whatsup_github/version.rb index 12ca3da..6b8de13 100644 --- a/lib/whatsup_github/version.rb +++ b/lib/whatsup_github/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module WhatsupGithub - VERSION = '1.1.0' + VERSION = '1.2.0' end diff --git a/whatsup_github.gemspec b/whatsup_github.gemspec index 95e66c8..17d697f 100644 --- a/whatsup_github.gemspec +++ b/whatsup_github.gemspec @@ -37,12 +37,12 @@ Gem::Specification.new do |spec| spec.required_ruby_version = '>= 3.0' spec.add_dependency 'netrc', '~> 0.11' - spec.add_dependency 'octokit', '~> 8.0' + spec.add_dependency 'octokit', '~> 10.0' spec.add_dependency 'thor', '~> 1.3' spec.add_development_dependency 'aruba', '~> 2.2' spec.add_development_dependency 'bundler', '~> 2.5' - spec.add_development_dependency 'cucumber', '~> 9.1' + spec.add_development_dependency 'cucumber', '~> 10.1' spec.add_development_dependency 'rake', '~> 13.1' spec.add_development_dependency 'rspec', '~> 3.12' spec.add_development_dependency 'fileutils', '~> 1.7' From 4841dd0afed33bcc2cf57b5c3cfb58479112c2df Mon Sep 17 00:00:00 2001 From: Dima Shevtsov Date: Tue, 2 Sep 2025 16:29:43 -0500 Subject: [PATCH 2/4] Update GitHub actions --- .github/workflows/linter.yml | 8 ++++++-- .github/workflows/tests.yml | 5 ++++- Gemfile.lock | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index c01c3b5..8859aad 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -17,6 +17,10 @@ name: Lint Code Base on: pull_request +permissions: + contents: read + pull-requests: read + ############### # Set the Job # ############### @@ -33,7 +37,7 @@ jobs: # Checkout the code base # ########################## - name: Checkout Code - uses: actions/checkout@v4 + uses: actions/checkout@v5 with: # Full git history is needed to get a proper list of changed files within `super-linter` fetch-depth: 0 @@ -42,7 +46,7 @@ jobs: # Run Linter against code base # ################################ - name: Lint Code Base - uses: github/super-linter/slim@v5 + uses: github/super-linter/slim@v7 env: DEFAULT_BRANCH: main GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 677ef2e..8f7bf88 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -1,10 +1,13 @@ name: Test the code on: [pull_request] +permissions: + contents: read + pull-requests: read jobs: test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v5 - uses: ruby/setup-ruby@v1 with: bundler-cache: true # runs 'bundle install' and caches installed gems automatically diff --git a/Gemfile.lock b/Gemfile.lock index 5935c9e..f955501 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - whatsup_github (1.1.0) + whatsup_github (1.2.0) netrc (~> 0.11) octokit (~> 10.0) thor (~> 1.3) From 94df9f0965b5998ffa07aad066df423de63e4397 Mon Sep 17 00:00:00 2001 From: Dima Shevtsov Date: Tue, 2 Sep 2025 16:50:59 -0500 Subject: [PATCH 3/4] Disable MD024 --- .github/linters/.markdown-lint.yml | 36 ++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 .github/linters/.markdown-lint.yml diff --git a/.github/linters/.markdown-lint.yml b/.github/linters/.markdown-lint.yml new file mode 100644 index 0000000..e89dcfa --- /dev/null +++ b/.github/linters/.markdown-lint.yml @@ -0,0 +1,36 @@ +--- + ########################### + ########################### + ## Markdown Linter rules ## + ########################### + ########################### + + # Linter rules doc: + # - https://github.com/DavidAnson/markdownlint + # + # Note: + # To comment out a single error: + # + # any violations you want + # + # + + ############### + # Rules by id # + ############### + MD004: false # Unordered list style + MD007: + indent: 2 # Unordered list indentation + MD013: + line_length: 400 # Line length 80 is far too short + MD024: false # Multiple headers with the same content + MD026: + punctuation: ".,;:!。，；:" # List of not allowed + MD029: false # Ordered list item prefix + MD033: false # Allow inline HTML + MD036: false # Emphasis used instead of a heading + + ################# + # Rules by tags # + ################# + blank_lines: false # Error on blank lines From 25f6bcfda48a793c8400276a69a32cac40e7c65f Mon Sep 17 00:00:00 2001 From: Dima Shevtsov Date: Tue, 2 Sep 2025 16:58:45 -0500 Subject: [PATCH 4/4] Disable problematic linters --- .github/workflows/linter.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index 8859aad..6615ba3 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -52,3 +52,6 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} VALIDATE_ALL_CODEBASE: false VALIDATE_GITLEAKS: false + VALIDATE_MARKDOWN_PRETTIER: false + VALIDATE_NATURAL_LANGUAGE: false + VALIDATE_YAML_PRETTIER: false