From 07e04ed55bedf371fe614d299685c9716fc7844c Mon Sep 17 00:00:00 2001 From: Kota-Jagadeesh Date: Tue, 25 Nov 2025 17:52:07 +0530 Subject: [PATCH 1/2] fix(upload): Add presenter initialization checks to prevent crash in PendingUploadsFragment --- .../commons/upload/PendingUploadsFragment.kt | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt b/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt index 45e9d90a3e..7187209f38 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt +++ b/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsFragment.kt @@ -119,6 +119,8 @@ class PendingUploadsFragment : * Cancels a specific upload after getting a confirmation from the user using Dialog. */ override fun deleteUpload(contribution: Contribution?) { + if (!::pendingUploadsPresenter.isInitialized) return // defensive Check + val activity = requireActivity() val locale = Locale.getDefault() showAlertDialog( @@ -140,19 +142,29 @@ class PendingUploadsFragment : /** * Restarts all the paused uploads. */ - fun restartUploads() = pendingUploadsPresenter.restartUploads( - contributionsList, 0, requireContext().applicationContext - ) + fun restartUploads() { + if (::pendingUploadsPresenter.isInitialized) { + pendingUploadsPresenter.restartUploads( + contributionsList, 0, requireContext().applicationContext + ) + } + } /** * Pauses all the ongoing uploads. */ - fun pauseUploads() = pendingUploadsPresenter.pauseUploads() + fun pauseUploads() { + if (::pendingUploadsPresenter.isInitialized) { + pendingUploadsPresenter.pauseUploads() + } + } /** * Cancels all the uploads after getting a confirmation from the user using Dialog. */ fun deleteUploads() { + if (!::pendingUploadsPresenter.isInitialized) return + val activity = requireActivity() val locale = Locale.getDefault() showAlertDialog( From 030e99983666dc30a208c4a7ca1f9ec73e2c923f Mon Sep 17 00:00:00 2001 From: Kota-Jagadeesh Date: Tue, 25 Nov 2025 17:52:48 +0530 Subject: [PATCH 2/2] fix(upload): Add config changes to UploadProgressActivity to prevent restart on resize --- app/src/main/AndroidManifest.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 5d264a8f9a..75562fbafa 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -63,6 +63,7 @@ android:exported="false" />