[cleanup] replace offensive terminology in gdb server support

Author: andrurogerz

BUILD

@@ -190,7 +190,6 @@ filegroup(
         "Headers/DebugServer2/GDBRemote/Session.h",
         "Headers/DebugServer2/GDBRemote/SessionBase.h",
         "Headers/DebugServer2/GDBRemote/SessionDelegate.h",
-        "Headers/DebugServer2/GDBRemote/SlaveSessionImpl.h",
         "Headers/DebugServer2/GDBRemote/Types.h",
         "Headers/DebugServer2/Host/Channel.h",
         "Headers/DebugServer2/Host/File.h",
@@ -339,7 +338,6 @@ filegroup(
         "Sources/GDBRemote/ProtocolInterpreter.cpp",
         "Sources/GDBRemote/Session.cpp",
         "Sources/GDBRemote/SessionBase.cpp",
-        "Sources/GDBRemote/SlaveSessionImpl.cpp",
         "Sources/GDBRemote/Structures.cpp",
         "Sources/Host/Common/Channel.cpp",
         "Sources/Host/Common/Platform.cpp",

CMakeLists.txt

@@ -189,7 +189,6 @@ add_executable(ds2
   Sources/GDBRemote/ProtocolInterpreter.cpp
   Sources/GDBRemote/Session.cpp
   Sources/GDBRemote/SessionBase.cpp
-  Sources/GDBRemote/SlaveSessionImpl.cpp
   Sources/GDBRemote/Structures.cpp
 
   Sources/Host/Common/Channel.cpp

Headers/DebugServer2/GDBRemote/SlaveSessionImpl.h

@@ -101,7 +101,7 @@ ErrorCode PlatformSessionImplBase::onLaunchDebugServer(Session &session,
   StringCollection args;
 
   ps.setExecutable(Platform::GetSelfExecutablePath());
-  args.push_back("slave");
+  args.push_back("server");
   if (GetLogLevel() == kLogLevelDebug) {
     args.push_back("--debug");
   } else if (GetLogLevel() == kLogLevelPacket) {

Sources/GDBRemote/PlatformSessionImpl.cpp

@@ -13,7 +13,6 @@
 #include "DebugServer2/GDBRemote/DebugSessionImpl.h"
 #include "DebugServer2/GDBRemote/PlatformSessionImpl.h"
 #include "DebugServer2/GDBRemote/ProtocolHelpers.h"
-#include "DebugServer2/GDBRemote/SlaveSessionImpl.h"
 #include "DebugServer2/Host/Platform.h"
 #include "DebugServer2/Host/QueueChannel.h"
 #include "DebugServer2/Host/Socket.h"
@@ -47,7 +46,6 @@ using ds2::GDBRemote::DebugSessionImpl;
 using ds2::GDBRemote::PlatformSessionImpl;
 using ds2::GDBRemote::Session;
 using ds2::GDBRemote::SessionDelegate;
-using ds2::GDBRemote::SlaveSessionImpl;
 using ds2::Host::Platform;
 using ds2::Host::QueueChannel;
 using ds2::Host::Socket;
@@ -564,7 +562,7 @@ static int PlatformMain(int argc, char **argv) {
   } while (true);
 }
 
-static int SlaveMain(int argc, char **argv) {
+static int ServerMain(int argc, char **argv) {
   DS2ASSERT(argv[1][0] == 's');
 
   ds2::OptParse opts;
@@ -581,7 +579,7 @@ static int SlaveMain(int argc, char **argv) {
   }
 
   if (pid == 0) {
-    // When in slave mode, output is suppressed but for standard error.
+    // When in server mode, output is suppressed but for standard error.
     close(0);
     close(1);
 
@@ -590,7 +588,7 @@ static int SlaveMain(int argc, char **argv) {
 
     std::unique_ptr<Socket> client = server->accept();
 
-    SlaveSessionImpl impl;
+    DebugSessionImpl impl;
     return RunDebugServer(client.get(), &impl);
   } else {
     // Write to the standard output to let our parent know
@@ -667,7 +665,7 @@ int main(int argc, char **argv) {
   case 'p':
     return PlatformMain(argc, argv);
   case 's':
-    return SlaveMain(argc, argv);
+    return ServerMain(argc, argv);
 #endif
   case 'v':
     return VersionMain(argc, argv);