libpod: Remove network-cmd-path

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>

Author: lsm5

docs/source/markdown/podman.1.md

@@ -104,11 +104,6 @@ Load the specified `containers.conf(5)` module.  Can be an absolute or relative
 This flag is not supported on the remote client, including Mac and Windows (excluding WSL2) machines.
 Further note that the flag is a root-level flag and must be specified before any Podman sub-command.
 
-#### **--network-cmd-path**=*path*
-Path to the `slirp4netns(1)` command binary to use for setting up a slirp4netns network.
-If "" is used, then the binary will first be searched using the `helper_binaries_dir` option in `containers.conf`, and second using the `$PATH` environment variable.
-**Note:** This option is deprecated and will be removed with Podman 6.0. Use the `helper_binaries_dir` option in `containers.conf` instead.
-
 #### **--network-config-dir**=*directory*
 
 Path to the directory where network configuration files are located.

libpod/options.go

@@ -180,20 +180,6 @@ func WithConmonPath(path string) RuntimeOption {
 	}
 }
 
-// WithNetworkCmdPath specifies the path to the slirp4netns binary which manages the
-// runtime.
-func WithNetworkCmdPath(path string) RuntimeOption {
-	return func(rt *Runtime) error {
-		if rt.valid {
-			return define.ErrRuntimeFinalized
-		}
-
-		rt.config.Engine.NetworkCmdPath = path
-
-		return nil
-	}
-}
-
 // WithNetworkBackend specifies the name of the network backend.
 func WithNetworkBackend(name string) RuntimeOption {
 	return func(rt *Runtime) error {

pkg/domain/infra/runtime_libpod.go

@@ -164,9 +164,6 @@ func getRuntime(ctx context.Context, fs *flag.FlagSet, opts *engineOpts) (*libpo
 	if fs.Changed("tmpdir") {
 		options = append(options, libpod.WithTmpDir(cfg.ContainersConf.Engine.TmpDir))
 	}
-	if fs.Changed("network-cmd-path") {
-		options = append(options, libpod.WithNetworkCmdPath(cfg.ContainersConf.Engine.NetworkCmdPath))
-	}
 	if fs.Changed("network-backend") {
 		options = append(options, libpod.WithNetworkBackend(cfg.ContainersConf.Network.NetworkBackend))
 	}