add tests that should error

Signed-off-by: iTrooz <hey@itrooz.fr>

Author: iTrooz

test/e2e/build_test.go

@@ -1435,4 +1435,44 @@ COPY --from=img2 /etc/alpine-release /prefix-test/container-prefix.txt`
 		Expect(session.OutputToString()).To(ContainSubstring("ustar"))
 	})
 
+	// Should error because no type
+	FIt("podman build --output dest=./folder", func() {
+		// Capture output to buffer manually, to avoid binary output leaking into test logs
+		session := podmanTest.PodmanWithOptions(utils.PodmanExecOptions{
+			FullOutputWriter: io.Discard,
+		}, "build", "-f", "build/basicalpine/Containerfile", "--output", fmt.Sprintf("dest=%v", podmanTest.TempDir))
+		session.WaitWithDefaultTimeout()
+		Expect(session).Should(ExitWithError(125, `missing required key "type"`))
+	})
+
+	// Should error because invalid type
+	FIt("podman build --output type=INVALID", func() {
+		// Capture output to buffer manually, to avoid binary output leaking into test logs
+		session := podmanTest.PodmanWithOptions(utils.PodmanExecOptions{
+			FullOutputWriter: io.Discard,
+		}, "build", "-f", "build/basicalpine/Containerfile", "--output", "type=INVALID")
+		session.WaitWithDefaultTimeout()
+		Expect(session).Should(ExitWithError(125, `invalid type "INVALID"`))
+	})
+
+	// Should error because no dest specified
+	FIt("podman build --output type=local", func() {
+		// Capture output to buffer manually, to avoid binary output leaking into test logs
+		session := podmanTest.PodmanWithOptions(utils.PodmanExecOptions{
+			FullOutputWriter: io.Discard,
+		}, "build", "-f", "build/basicalpine/Containerfile", "--output", "type=local")
+		session.WaitWithDefaultTimeout()
+		Expect(session).Should(ExitWithError(125, `missing required key "dest"`))
+	})
+
+	// Should error because invalid dest for local type
+	FIt("podman build --output type=local,dest=-", func() {
+		// Capture output to buffer manually, to avoid binary output leaking into test logs
+		session := podmanTest.PodmanWithOptions(utils.PodmanExecOptions{
+			FullOutputWriter: io.Discard,
+		}, "build", "-f", "build/basicalpine/Containerfile", "--output", "type=local,dest=-")
+		session.WaitWithDefaultTimeout()
+		Expect(session).Should(ExitWithError(125, `only "type=tar" can be used with "dest=-"`))
+	})
+
 })