Skip to content

Slirp: Remove for Podman6 #27338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 58 commits into
base: main
Choose a base branch
from
Draft

Slirp: Remove for Podman6 #27338

wants to merge 58 commits into from

Conversation

@lsm5
Copy link
Member

@lsm5 lsm5 commented Oct 21, 2025

Does this PR introduce a user-facing change?

Slirp support has been removed.

@lsm5 lsm5 added the 6.0 Breaking changes for Podman 6.0 label Oct 21, 2025
@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Oct 21, 2025
@lsm5 lsm5 added No New Tests Allow PR to proceed without adding regression tests and removed kind/api-change Change to remote API; merits scrutiny labels Oct 21, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2025
@github-actions github-actions bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/api-change Change to remote API; merits scrutiny labels Nov 10, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2025
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 10, 2025

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

1 similar comment
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 10, 2025

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@lsm5 lsm5 force-pushed the podman6-no-slirp branch 2 times, most recently from 583764c to d7744ec Compare November 10, 2025 21:20
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 10, 2025

tmt tests failed for commit d7744ec. @lsm5, @psss, @thrix please check.

@psss
Copy link

psss commented Nov 11, 2025

Yeah, that sounds like a genuine problem on the podman side:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x48 pc=0x55dadaac0a55]

@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 12, 2025

tmt tests failed for commit a55c778. @lsm5, @psss, @thrix please check.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 12, 2025

tmt tests failed for commit f36cb63. @lsm5, @psss, @thrix please check.

lsm5 added 4 commits November 13, 2025 10:12
@lsm5
TMT: Exclude podman packages from podman-next repo for tests
e2bf2ff 
podman-next copr repo packages have a much higher Epoch than packit copr
packages, We should exclude the former from the testing environment as
we intend to test the latter.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Packit: Bump podman-next repo priority for cockpit tests
8b5e108 
TMT_TREE envvar is ok to use in this case as it will only be used on
upstream packit tests.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Packit: move scripts to contrib/packit-tmt
6b92c44 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
cmd/podman.persistentRunE(): Fatal linux check if no Cgroups v2
c615f39 
Will log and proceed on non-linux env.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
lsm5 added 24 commits November 13, 2025 10:23
@lsm5
pkg/specgen/generate/pod_create.go: Remove slirp
109493d 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/namespaces.go: Remove slirp
e382c9e 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/pod_validate.go: Remove slirp
0943ebd 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/podspecgen.go: Remove slirp
76153d7 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/specgen/specgen.go: Remove slirp
56ae374 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container.go: Remove slirp
367be81 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container_api.go: Remove slirp
14bddbd 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container_internal_common.go: Remove slirp
18258c2 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container_internal_freebsd.go: Remove slirp
b17d8a9 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/container_internal_linux.go: Remove slirp
9a00479 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/define/info.go: Remove slirp
858b355 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/info_linux.go: Remove slirp
a4330bb 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_common.go: Remove slirp
64f7392 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/oci_conmon_common.go: Remove slirp
9d37da5 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/e2e: Remove slirp
3e97e2d 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
test/system: Remove slirp
7ecc4a2 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
TMT: remove slirp4netns dependency
a7f57ab 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
RPM: remove slirp4netns
cef226b 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_linux.go: Remove slirp
47b8edd 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_slirp4netns.go: Remove Slirp4netns
d8de4d9 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
pkg/namespaces/namespaces.go: Remove slirp
4b3e975 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod: Remove network-cmd-path
35ca345 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
Cirrus: Remove slirp4netns from logcollector script
8733df8 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
libpod/networking_freebsd.go: Remove getSlirp4netnsIP()
2e7738c 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
docs/tutorials: Remove slirp
c7767a5 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 13, 2025

tmt tests failed for commit 2e7738c. @lsm5, @psss, @thrix please check.

lsm5 added 2 commits November 13, 2025 10:57
@lsm5
docs/source/markdown: Remove slirp
4b6c3c5 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@lsm5
docs/source/locale: Remove slirp
d9d63e6 
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@packit-as-a-service
Copy link

packit-as-a-service bot commented Nov 13, 2025

tmt tests failed for commit d9d63e6. @lsm5, @psss, @thrix please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.0 Breaking changes for Podman 6.0 approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Change to remote API; merits scrutiny machine No New Tests Allow PR to proceed without adding regression tests release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsm5 @psss @openshift-merge-robot