mediabox bug for iOS devices

[Toflar]

Hey Leo

I've just tracked down a bug in the mediabox script. Vimeo videos did not display on iOS (iPad in my case) devices.

Probably you wanna patch the mediabox script like we did last time as it seems that no one is supporting the script anymore :-(

iaian7/mediaboxAdvanced#17

[leofeyer]

The pull request is for version 1.5.4, however, we are using version 1.4.6 in Contao. Does the error occur there as well?

[Toflar]

I had to tackle this issue in 2.11.5 so I guess, yes it does ;-)

[andreasisaak]

@Toflar In the latest contao installation, the mediabox doesn't work on iOS. None of the images or videos open in the lightbox.

[Toflar]

Yeah I know, that's what I said?

[andreasisaak]

Nope? You mentioned only vimeos videos!

[Toflar]

Ah yes, that was the issue that forced me to do the pull request ;) But it might also fix other issues - have you tested?

[leofeyer]

Can you please confirm that these changes fix your issue?

[Toflar]

Are you asking @andreasisaak ? Because that's exactly the code of my pull request which obviously does fix my issue :D

[leofeyer]

My changes are based on version 1.4.6, not 1.5.4 (see above). Can you not just say "yes" or "no"?

[andreasisaak]

@Toflar You simply change the order?

[Toflar]

@leofeyer: "yes"
@andreasisaak: yes, that's all what's needed

[andreasisaak]

@leofeyer Why do you choose the 3.0 milestone? This is a critical bug on 2.11.5 too :(

[kikmedia]

2.11.x, please. Seems that lots of people will stay for a while on that.

[leofeyer]

Don't worry, I'll backport it.

[andreasisaak]

Thank you!!!