chore: remove lifecycles scripts (#2839)

elylucasctfl · elylucas · web-flow · commit db8c8e341ced · 2025-12-03T11:52:32.000-07:00
* chore: remove lifecycles scripts

* chore: manually install chrome for puppeteer

* chore: typo in yaml

* chore: update test scripts

* chore: update script

* chore: update format script

* fix: add cooldown

* fix: remove github token

* chore: pr feedback

* chore: reworking app definition tests to fix tests

* chore: add gh token back into release

* chore: remove test branch from release

---------

Co-authored-by: Ely Lucas &lt;ely.lucas@contentful.com&gt;
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -24,3 +24,5 @@ updates:
     - dependency-name: webpack
       versions:
         - '>= 5.0.0'
+    cooldown:
+      default-days: 15
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -71,6 +71,14 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Publish Docs
+        if: github.ref == 'refs/heads/master'
+        run: |
+          echo "Publishing Documentation"
+          npm run docs:publish
+        env:
+          GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }}
+
       - name: Get latest release tag
         id: get-tag
         run: |
diff --git a/.github/workflows/test-demo-projects.yaml b/.github/workflows/test-demo-projects.yaml
@@ -34,7 +34,7 @@ jobs:
           path: |
             dist 
           key: build-cache-${{ github.run_id }}-${{ github.run_attempt }}
-
+          
       - name: Run integration tests
         run: npm run test:demo-projects
         env:
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -1 +1 @@
-lint-staged
+lint-staged
diff --git a/.prettierignore b/.prettierignore
@@ -3,3 +3,4 @@ dist
 coverage
 out
 typings
+test/output-integration/browser/public
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -35,7 +35,7 @@
     "docs:watch": "nodemon --exec npm run docs:dev -w lib typings",
     "docs:publish": "npm run build:docs && ./node_modules/contentful-sdk-jsdoc/bin/publish-docs.sh contentful-management.js contentful-management",
     "lint": "eslint lib test",
-    "pretest": "rimraf coverage && npm run lint",
+    "lint:fix": "eslint lib test --fix",
     "test": "npm run test:unit:cover && npm run test:types && npm run test:integration:cover && npm run test:size",
     "test:unit:cover": "npm run test:unit -- --coverage",
     "test:unit": "npx vitest --project unit --run",
@@ -48,16 +48,12 @@
     "test:version": "grep -r \"0.0.0-determined-by-semantic-release\" ./dist > /dev/null && echo \"version 0.0.0-determined-by-semantic-release found in output\" && exit 1 || exit 0",
     "test:size": "size-limit",
     "test:demo-projects": "npm run test:demo-node && npm run test:demo-browser",
-    "test:demo-node": "rimraf ./test/output-integration/node/node-modules && npm --prefix ./test/output-integration/node ci && vitest --run ./test/output-integration/node",
-    "test:demo-browser": "rimraf ./test/output-integration/browser/node-modules && npm --prefix ./test/output-integration/browser ci && npm --prefix ./test/output-integration/browser run test",
-    "test:prepush": "npm run build && npm run test:unit && npm run test:size",
-    "format:fix": "prettier --write '**/*.{jsx,js,ts,tsx}'",
+    "test:demo-node": "npm ci --prefix ./test/output-integration/node && npm run test --prefix ./test/output-integration/node",
+    "test:demo-browser": "npm ci --prefix ./test/output-integration/browser && npm run setup-test-env --prefix ./test/output-integration/browser && npm run test --prefix ./test/output-integration/browser",
+    "format:fix": "npm run format:check -- --write",
     "format:check": "prettier --check '**/*.{jsx,js,ts,tsx}'",
     "semantic-release": "semantic-release",
-    "precommit": "npm run lint",
-    "postpublish": "if [ \"$(git rev-parse --abbrev-ref HEAD)\" = master ] ; then npm run docs:publish && npm run clean ; else exit 0 ; fi",
-    "prepush": "npm run test:prepush",
-    "prepublishOnly": "npm run build && npm run test:version"
+    "prepare": "husky"
   },
   "files": [
     "dist",
@@ -125,9 +121,9 @@
     }
   },
   "lint-staged": {
-    "*.{js,ts}": [
+    "./{lib,test}/*.{js,ts}": [
       "prettier --write",
-      "eslint"
+      "eslint --fix"
     ],
     "*.md": [
       "prettier --write"
diff --git a/test/helpers.ts b/test/helpers.ts
@@ -120,7 +120,7 @@ export async function createAppDefinition() {
     throw new Error(`Unable to load test organization`)
   }
   const appDefinition = await organization.createAppDefinition({
-    name: 'Test App',
+    name: 'Test App Definition for helpers.ts (delete if stale)',
     src: 'http://localhost:3000',
     locations: [
       {
diff --git a/test/integration/app-access-token-integration.test.ts b/test/integration/app-access-token-integration.test.ts
@@ -32,7 +32,7 @@ describe('AppAccessToken api', { sequential: true }, () => {
     organization = await getTestOrganization()
 
     appDefinition = await organization.createAppDefinition({
-      name: 'Test AppAccessToken',
+      name: 'Test AppAccessToken in CMA (delete if stale)',
     })
 
     entityId = {
diff --git a/test/integration/app-action-call-structured-integration.test.ts b/test/integration/app-action-call-structured-integration.test.ts
@@ -26,7 +26,7 @@ describe('AppActionCall structured endpoints', function () {
 
     // Create an app definition for installation context
     appDefinition = await organization.createAppDefinition({
-      name: 'Structured AppActionCall Test',
+      name: 'Structured AppActionCall Test in CMA (delete if stale)',
     })
 
     client = initPlainClient({
diff --git a/test/integration/app-action-integration.test.ts b/test/integration/app-action-integration.test.ts
@@ -21,7 +21,7 @@ describe('AppAction api', function () {
     space = await getDefaultSpace()
 
     appDefinition = await organization.createAppDefinition({
-      name: 'Test AppAction',
+      name: 'Test AppAction in CMA (delete if stale)',
     })
 
     client = initPlainClient({
diff --git a/test/integration/app-bundle-integration.test.ts b/test/integration/app-bundle-integration.test.ts
@@ -1,47 +1,32 @@
 import { expect, describe, test, beforeAll, afterAll } from 'vitest'
 import { readFileSync } from 'fs'
-import { getTestOrganization, getDefaultSpace, timeoutToCalmRateLimiting } from '../helpers'
-import type {
-  Organization,
-  AppDefinition,
-  AppUpload,
-  Space,
-  Environment,
-} from '../../lib/contentful-management'
+import { getTestOrganization, timeoutToCalmRateLimiting } from '../helpers'
+import type { Organization, AppDefinition, AppUpload } from '../../lib/contentful-management'
 
 describe('AppBundle api', { sequential: true }, () => {
   let organization: Organization
   let appDefinition: AppDefinition
   let appUpload: AppUpload
-  let space: Space
-  let env: Environment
 
   beforeAll(async () => {
-    space = await getDefaultSpace()
-    env = await space.getEnvironment('master')
     organization = await getTestOrganization()
 
     appDefinition = await organization.createAppDefinition({
-      name: 'Test AppBundle',
+      name: 'Test AppBundle Integration in CMA (delete if stale)',
     })
 
     appUpload = await organization.createAppUpload(readFileSync(`${__dirname}/fixtures/build.zip`))
   })
 
   afterAll(async () => {
-    const { items: appDefinitions } = await organization.getAppDefinitions()
-    const { items: appInstallations } = await env.getAppInstallations()
-
-    for (const appInstallation of appInstallations) {
-      await appInstallation.delete()
+    if (appUpload) {
+      await appUpload.delete()
     }
-    for (const appDefinition of appDefinitions) {
+
+    if (appDefinition) {
       await appDefinition.delete()
     }
 
-    if (appUpload) {
-      await appUpload.delete()
-    }
     await timeoutToCalmRateLimiting()
   })
 
diff --git a/test/integration/app-definition-integration.test.ts b/test/integration/app-definition-integration.test.ts
@@ -4,43 +4,24 @@ import {
   getAppDefinition,
   getTestOrganization,
   createAppInstallation,
-  getDefaultSpace,
   timeoutToCalmRateLimiting,
 } from '../helpers'
-import type {
-  Organization,
-  Space,
-  Environment,
-  AppInstallation,
-} from '../../lib/contentful-management'
+import type { Organization, AppInstallation } from '../../lib/contentful-management'
 
 describe('AppDefinition api', { sequential: true }, () => {
   let organization: Organization
-  let space: Space
-  let env: Environment
 
   beforeAll(async () => {
     organization = await getTestOrganization()
-    space = await getDefaultSpace()
-    env = await space.getEnvironment('master')
   })
 
   afterAll(async () => {
-    const { items: appDefinitions } = await organization.getAppDefinitions()
-    const { items: appInstallations } = await env.getAppInstallations()
-
-    for (const appInstallation of appInstallations) {
-      await appInstallation.delete()
-    }
-    for (const appDefinition of appDefinitions) {
-      await appDefinition.delete()
-    }
     await timeoutToCalmRateLimiting()
   })
 
   test('createAppDefinition', async () => {
     const appDefinition = await organization.createAppDefinition({
-      name: 'Test App',
+      name: 'Test createAppDefinition in CMA (delete if stale)',
       src: 'http://localhost:3000',
       locations: [
         {
@@ -50,12 +31,15 @@ describe('AppDefinition api', { sequential: true }, () => {
     })
 
     expect(appDefinition.sys.type).toBe('AppDefinition')
-    expect(appDefinition.name).toBe('Test App')
+    expect(appDefinition.name).toBe('Test createAppDefinition in CMA (delete if stale)')
+
+    //cleanup
+    await appDefinition.delete()
   })
 
   test('createAppDefinition with secret installation param', async () => {
     const appDefinition = await organization.createAppDefinition({
-      name: 'Test App',
+      name: 'Test createAppDefinition with secret param in CMA (delete if stale)',
       src: 'http://localhost:3000',
       locations: [
         {
@@ -74,18 +58,23 @@ describe('AppDefinition api', { sequential: true }, () => {
     })
 
     expect(appDefinition.sys.type).toBe('AppDefinition')
-    expect(appDefinition.name).toBe('Test App')
+    expect(appDefinition.name).toBe(
+      'Test createAppDefinition with secret param in CMA (delete if stale)',
+    )
     if (!appDefinition.parameters || !appDefinition.parameters.installation) {
       throw new Error(
         `appDefinition.parameters or appDefinition.parameters.installation is not defined`,
       )
     }
     expect(appDefinition.parameters.installation[0].id).toBe('secret')
+
+    //cleanup
+    await appDefinition.delete()
   })
 
   test('getAppDefinition', async () => {
     const appDefinition = await organization.createAppDefinition({
-      name: 'Test App',
+      name: 'Test getAppDefinition in CMA (delete if stale)',
       src: 'http://localhost:3000',
       locations: [
         {
@@ -97,6 +86,9 @@ describe('AppDefinition api', { sequential: true }, () => {
     const fetchedAppDefinition = await organization.getAppDefinition(appDefinition.sys.id)
 
     expect(appDefinition.sys.id).toBe(fetchedAppDefinition.sys.id)
+
+    //cleanup
+    await appDefinition.delete()
   })
 
   test('getAppDefinitions', async () => {
@@ -108,7 +100,7 @@ describe('AppDefinition api', { sequential: true }, () => {
 
   test('delete', async () => {
     const appDefinition = await organization.createAppDefinition({
-      name: 'Test App',
+      name: 'Test Delete AppDefinition in CMA (delete if stale)',
       src: 'http://localhost:3000',
       locations: [
         {
@@ -126,7 +118,7 @@ describe('AppDefinition api', { sequential: true }, () => {
 
   test('update', async () => {
     const appDefinition = await organization.createAppDefinition({
-      name: 'Test App',
+      name: 'Test Update AppDefinition in CMA (delete if stale)',
       src: 'http://localhost:3000',
       locations: [
         {
@@ -139,6 +131,9 @@ describe('AppDefinition api', { sequential: true }, () => {
     await appDefinition.update()
 
     expect(appDefinition.name).toBe('Test App Updated')
+
+    //cleanup
+    await appDefinition.delete()
   })
 
   test('getAppDefinition (top level)', async () => {
@@ -147,13 +142,19 @@ describe('AppDefinition api', { sequential: true }, () => {
 
     expect(appDefinition.sys.organization.sys.id).toBe(orgId)
     expect(appDefinition.sys.id).toBe(appId)
+
+    //cleanup
+    await appDefinition.delete()
   })
 
   test('getInstallationsForOrg returns', async () => {
     const { orgId, appId } = await createAppDefinition()
     const appDefinition = await getAppDefinition(orgId, appId)
     const installationsForOrg = await appDefinition.getInstallationsForOrg()
     expect(installationsForOrg.sys.type).toBe('Array')
+
+    //cleanup
+    await appDefinition.delete()
   })
 
   test('getInstallationsForOrg returns installations', async () => {
@@ -164,5 +165,8 @@ describe('AppDefinition api', { sequential: true }, () => {
 
     expect(appInstallationsForOrg.items.length).toBe(1)
     await appInstallation.delete()
+
+    //cleanup
+    await appDefinition.delete()
   })
 })
diff --git a/test/integration/app-event-subscription-integration.test.ts b/test/integration/app-event-subscription-integration.test.ts
@@ -14,7 +14,7 @@ describe('AppEventSubscription api', { sequential: true }, () => {
     organization = await getTestOrganization()
 
     appDefinition = await organization.createAppDefinition({
-      name: 'Test AppEventSubscription',
+      name: 'Test AppEventSubscription in CMA (delete if stale)',
     })
 
     entityId = { organizationId: organization.sys.id, appDefinitionId: appDefinition.sys.id }
diff --git a/test/integration/app-key-integration.test.ts b/test/integration/app-key-integration.test.ts
@@ -12,7 +12,7 @@ describe('AppKey api', { sequential: true }, () => {
     organization = await getTestOrganization()
 
     appDefinition = await organization.createAppDefinition({
-      name: 'Test AppKey',
+      name: 'Test AppKey in CMA (delete if stale)',
     })
 
     entityId = {
diff --git a/test/integration/app-signed-request-integration.test.ts b/test/integration/app-signed-request-integration.test.ts
@@ -12,7 +12,7 @@ describe('AppKey api', { sequential: true }, () => {
     organization = await getTestOrganization()
 
     appDefinition = await organization.createAppDefinition({
-      name: 'Test AppKey',
+      name: 'Test AppKey in CMA (delete if stale)',
     })
 
     entityId = {
diff --git a/test/integration/app-signing-secret-integration.test.ts b/test/integration/app-signing-secret-integration.test.ts
@@ -11,7 +11,7 @@ describe('AppSigningSecret api', { sequential: true }, () => {
     organization = await getTestOrganization()
 
     appDefinition = await organization.createAppDefinition({
-      name: 'Test AppSignedRequest',
+      name: 'Test AppSignedRequest in CMA (delete if stale)',
     })
 
     client = initPlainClient()
diff --git a/test/integration/environment-integration.test.ts b/test/integration/environment-integration.test.ts
@@ -78,7 +78,7 @@ describe('Environment Api', () => {
     beforeAll(async () => {
       organization = await getTestOrganization()
       appDefinition = await organization.createAppDefinition({
-        name: 'Test',
+        name: 'Test Environment Integration CMA (delete if stale)',
         src: 'http://localhost:2222',
         locations: [{ location: 'app-config' }],
         parameters: {
diff --git a/test/integration/resource-integration.test.ts b/test/integration/resource-integration.test.ts
@@ -41,7 +41,7 @@ describe('Resource API', () => {
   beforeAll(async () => {
     organization = await getTestOrganization()
     appDefinition = await organization.createAppDefinition({
-      name: 'Test',
+      name: 'Test Resource Integration in CMA (delete if stale)',
       src: 'http://localhost:2222',
       locations: [{ location: 'app-config' }],
       parameters: {
diff --git a/test/integration/resource-provider-integration.test.ts b/test/integration/resource-provider-integration.test.ts
diff --git a/test/integration/resource-type-integration.test.ts b/test/integration/resource-type-integration.test.ts
diff --git a/test/output-integration/browser/package.json b/test/output-integration/browser/package.json
diff --git a/test/output-integration/node/package.json b/test/output-integration/node/package.json
diff --git a/test/output-integration/node/vitest.config.ts b/test/output-integration/node/vitest.config.ts

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ export async function createAppDefinition() {`
`120`	`120`	throw new Error(`Unable to load test organization`)
`121`	`121`	`}`
`122`	`122`	`const appDefinition = await organization.createAppDefinition({`
`123`		`- name: 'Test App',`
	`123`	`+ name: 'Test App Definition for helpers.ts (delete if stale)',`
`124`	`124`	`src: 'http://localhost:3000',`
`125`	`125`	`locations: [`
`126`	`126`	`{`