review changes

Author: Dinesh

dist/util/index.js

@@ -112,15 +112,13 @@ exports.groupItems = (items) => {
  * @param {Object} config - Application config
  */
 exports.formatItems = (items, config) => {
-    // const time = new Date().toISOString()
     for (let i = 0, j = items.length; i < j; i++) {
         switch (items[i].type) {
             case 'asset_published':
                 delete items[i].type;
                 items[i]._content_type_uid = formattedAssetType;
                 items[i]._type = config.contentstack.actions.publish;
                 // extra keys
-                // items[i]._synced_at = time
                 items[i] = lodash_1.merge(items[i], items[i].data);
                 items[i].locale = items[i].data.publish_details.locale;
                 break;
@@ -141,7 +139,6 @@ exports.formatItems = (items, config) => {
                 items[i]._type = config.contentstack.actions.publish;
                 items[i]._content_type_uid = items[i].content_type_uid;
                 // extra keys
-                // items[i]._synced_at = time
                 items[i] = lodash_1.merge(items[i], items[i].data);
                 items[i].locale = items[i].data.publish_details.locale;
                 break;

src/util/index.ts

@@ -134,15 +134,13 @@ export const groupItems = (items) => {
  * @param {Object} config - Application config
  */
 export const formatItems = (items, config) => {
-  // const time = new Date().toISOString()
   for (let i = 0, j = items.length; i < j; i++) {
     switch (items[i].type) {
       case 'asset_published':
         delete items[i].type
         items[i]._content_type_uid = formattedAssetType
         items[i]._type = config.contentstack.actions.publish
         // extra keys
-        // items[i]._synced_at = time
         items[i] = merge(items[i], items[i].data)
         items[i].locale = items[i].data.publish_details.locale
         break
@@ -163,7 +161,6 @@ export const formatItems = (items, config) => {
         items[i]._type = config.contentstack.actions.publish
         items[i]._content_type_uid = items[i].content_type_uid
         // extra keys
-        // items[i]._synced_at = time
         items[i] = merge(items[i], items[i].data)
         items[i].locale = items[i].data.publish_details.locale
         break
@@ -478,6 +475,5 @@ export const getSchema = (action, data) => {
     schema._synced_at = data._synced_at
     schema.locale = data.locale
   }
-
   return { schema }
 }

src/util/validations.ts

@@ -209,7 +209,7 @@ const assetPublishedStructure = (asset) => {
 
 export const validatePlugin = (plugin) => {
   if (!plugin.name || typeof plugin.name !== 'string' || plugin.name.length < 1) {
-    throw new Error("Invalid plugin config, 'plugin.name' is a required property!")
+    throw new Error(`Invalid plugin config, 'plugin.name' is a required property!`)
   }
 }
 

test/util/index.ts

@@ -55,7 +55,6 @@ describe('core-utilities', () => {
       const formattedItem = formatItems(items, configs)[0]
       expect(formattedItem).toHaveProperty('_content_type_uid')
       // expect(formattedItem).not.toHaveProperty('content_type_uid')
-      // expect(formattedItem).not.toHaveProperty('_synced_at')
       expect(formattedItem).toHaveProperty('action')
     })
 
@@ -76,7 +75,6 @@ describe('core-utilities', () => {
       const formattedItem = formatItems(items, configs)[0]
       expect(formattedItem).toHaveProperty('_content_type_uid')
       // expect(formattedItem).not.toHaveProperty('content_type_uid')
-      // expect(formattedItem).not.toHaveProperty('_synced_at')
       expect(formattedItem).toHaveProperty('action')
     })