refactor: ♻️ Refactor the cli tool type to align with core

Author: chezsmithy

extensions/cli/src/stream/handleToolCalls.ts

@@ -189,7 +189,7 @@ export async function getRequestTools(isHeadless: boolean) {
   const allowedTools: Tool[] = [];
   for (const tool of availableTools) {
     const result = checkToolPermission(
-      { name: tool.name, arguments: {} },
+      { name: tool.function.name, arguments: {} },
       permissionsState.permissions,
     );
 

extensions/cli/src/tools/edit.ts

@@ -50,7 +50,7 @@ export function validateAndResolveFilePath(args: any): {
   if (!readFilesSet.has(resolvedPath)) {
     throw new ContinueError(
       ContinueErrorReason.EditToolFileNotRead,
-      `You must use the ${readFileTool.name} tool to read ${file_path} before editing it.`,
+      `You must use the ${readFileTool.function.name} tool to read ${file_path} before editing it.`,
     );
   }
 
@@ -62,47 +62,51 @@ export interface EditArgs extends EditOperation {
 }
 
 export const editTool: Tool = {
-  name: "Edit",
-  displayName: "Edit",
-  readonly: false,
-  isBuiltIn: true,
-  description: `Performs exact string replacements in a file.
+  type: "function",
+  function: {
+    name: "Edit",
+    description: `Performs exact string replacements in a file.
 
 USAGE: 
-- ALWAYS use the \`${readFileTool.name}\` tool just before making edits, to understand the file's up-to-date contents and context.
-- When editing text from ${readFileTool.name} tool output, ensure you preserve exact whitespace/indentation.
+- ALWAYS use the \`${readFileTool.function.name}\` tool just before making edits, to understand the file's up-to-date contents and context.
+- When editing text from ${readFileTool.function.name} tool output, ensure you preserve exact whitespace/indentation.
 - Always prefer editing existing files in the codebase. NEVER write new files unless explicitly required.
 - Only use emojis if the user explicitly requests it. Avoid adding emojis to files unless asked.
 - Use \`replace_all\` for replacing and renaming strings across the file. This parameter is useful if you want to rename a variable, for instance.
 
 WARNINGS:
 - When not using \`replace_all\`, the edit will FAIL if \`old_string\` is not unique in the file. Either provide a larger string with more surrounding context to make it unique or use \`replace_all\` to change every instance of \`old_string\`.
-- The edit will FAIL if you have not recently used the \`${readFileTool.name}\` tool to view up-to-date file contents.`,
-  parameters: {
-    type: "object",
-    required: ["file_path", "old_string", "new_string"],
-    properties: {
-      file_path: {
-        type: "string",
-        description:
-          "Absolute or relative path to the file to modify. Absolute preferred",
-      },
-      old_string: {
-        type: "string",
-        description:
-          "The text to replace - must be exact including whitespace/indentation",
-      },
-      new_string: {
-        type: "string",
-        description:
-          "The text to replace it with (MUST be different from old_string)",
-      },
-      replace_all: {
-        type: "boolean",
-        description: "Replace all occurrences of old_string (default false)",
+- The edit will FAIL if you have not recently used the \`${readFileTool.function.name}\` tool to view up-to-date file contents.`,
+    parameters: {
+      type: "object",
+      required: ["file_path", "old_string", "new_string"],
+      properties: {
+        file_path: {
+          type: "string",
+          description:
+            "Absolute or relative path to the file to modify. Absolute preferred",
+        },
+        old_string: {
+          type: "string",
+          description:
+            "The text to replace - must be exact including whitespace/indentation",
+        },
+        new_string: {
+          type: "string",
+          description:
+            "The text to replace it with (MUST be different from old_string)",
+        },
+        replace_all: {
+          type: "boolean",
+          description: "Replace all occurrences of old_string (default false)",
+        },
       },
     },
   },
+  displayTitle: "Edit",
+  readonly: false,
+  group: "Built-In",
+  isBuiltIn: true,
   preprocess: async (args) => {
     const { old_string, new_string, replace_all } = args as EditArgs;
 

extensions/cli/src/tools/exit.ts

@@ -1,15 +1,19 @@
 import { Tool } from "./types.js";
 
 export const exitTool: Tool = {
-  name: "Exit",
-  displayName: "Exit",
-  description:
-    "Exit the current process with status code 1, indicating a failure or error",
-  parameters: {
-    type: "object",
-    properties: {},
+  type: "function",
+  function: {
+    name: "Exit",
+    description:
+      "Exit the current process with status code 1, indicating a failure or error",
+    parameters: {
+      type: "object",
+      properties: {},
+    },
   },
+  displayTitle: "Exit",
   readonly: false,
+  group: "Built-In",
   isBuiltIn: true,
   run: async (): Promise<string> => {
     const { gracefulExit } = await import("../util/exit.js");

extensions/cli/src/tools/fetch.ts

@@ -4,21 +4,25 @@ import { fetchUrlContentImpl } from "core/tools/implementations/fetchUrlContent.
 import { Tool } from "./types.js";
 
 export const fetchTool: Tool = {
-  name: "Fetch",
-  displayName: "Fetch",
-  description:
-    "Fetches content from a URL, converts to markdown, and handles long content with truncation",
-  parameters: {
-    type: "object",
-    required: ["url"],
-    properties: {
-      url: {
-        type: "string",
-        description: "The URL to fetch content from",
+  type: "function",
+  function: {
+    name: "Fetch",
+    description:
+      "Fetches content from a URL, converts to markdown, and handles long content with truncation",
+    parameters: {
+      type: "object",
+      required: ["url"],
+      properties: {
+        url: {
+          type: "string",
+          description: "The URL to fetch content from",
+        },
       },
     },
   },
+  displayTitle: "Fetch",
   readonly: true,
+  group: "Built-In",
   isBuiltIn: true,
   preprocess: async (args) => {
     return {

extensions/cli/src/tools/index.tsx

@@ -101,8 +101,8 @@ export async function getAllAvailableTools(
 }
 
 export function getToolDisplayName(toolName: string): string {
-  const tool = ALL_BUILT_IN_TOOLS.find((t) => t.name === toolName);
-  return tool?.displayName || toolName;
+  const tool = ALL_BUILT_IN_TOOLS.find((t) => t.function.name === toolName);
+  return tool?.displayTitle || toolName;
 }
 
 export function extractToolCalls(
@@ -136,31 +136,35 @@ export function convertToolToChatCompletionTool(
   return {
     type: "function" as const,
     function: {
-      name: tool.name,
-      description: tool.description,
-      parameters: {
+      name: tool.function.name,
+      description: tool.function.description,
+      parameters: tool.function.parameters || {
         type: "object",
-        required: tool.parameters.required,
-        properties: tool.parameters.properties,
+        properties: {},
+        required: [],
       },
     },
   };
 }
 
 export function convertMcpToolToContinueTool(mcpTool: MCPTool): Tool {
   return {
-    name: mcpTool.name,
-    displayName: mcpTool.name.replace("mcp__", "").replace("ide__", ""),
-    description: mcpTool.description ?? "",
-    parameters: {
-      type: "object",
-      properties: (mcpTool.inputSchema.properties ?? {}) as Record<
-        string,
-        ParameterSchema
-      >,
-      required: mcpTool.inputSchema.required,
+    type: "function" as const,
+    function: {
+      name: mcpTool.name,
+      description: mcpTool.description ?? "",
+      parameters: {
+        type: "object",
+        properties: (mcpTool.inputSchema.properties ?? {}) as Record<
+          string,
+          ParameterSchema
+        >,
+        required: mcpTool.inputSchema.required,
+      },
     },
-    readonly: undefined, // MCP tools don't have readonly property
+    displayTitle: mcpTool.name.replace("mcp__", "").replace("ide__", ""),
+    readonly: false,
+    group: "MCP",
     isBuiltIn: false,
     run: async (args: any) => {
       const result = await services.mcp?.runTool(mcpTool.name, args);
@@ -234,12 +238,22 @@ export async function executeToolCall(
 
 // Only checks top-level required
 export function validateToolCallArgsPresent(toolCall: ToolCall, tool: Tool) {
-  const requiredParams = tool.parameters.required ?? [];
-  for (const [paramName] of Object.entries(tool.parameters)) {
+  const parameters = tool.function.parameters;
+  if (
+    !parameters ||
+    typeof parameters !== "object" ||
+    !("required" in parameters)
+  ) {
+    return; // No parameter validation if schema is missing
+  }
+
+  const requiredParams = parameters.required ?? [];
+  const properties = parameters.properties ?? {};
+
+  for (const paramName of requiredParams) {
     if (
-      requiredParams.includes(paramName) &&
-      (toolCall.arguments[paramName] === undefined ||
-        toolCall.arguments[paramName] === null)
+      toolCall.arguments[paramName] === undefined ||
+      toolCall.arguments[paramName] === null
     ) {
       throw new Error(
         `Required parameter "${paramName}" missing for tool "${toolCall.name}"`,

extensions/cli/src/tools/listFiles.ts

@@ -6,20 +6,24 @@ import { Tool } from "./types.js";
 
 // List files in a directory
 export const listFilesTool: Tool = {
-  name: "List",
-  displayName: "List",
-  description: "List files in a directory",
-  parameters: {
-    type: "object",
-    required: ["dirpath"],
-    properties: {
-      dirpath: {
-        type: "string",
-        description: "The path to the directory to list",
+  type: "function",
+  function: {
+    name: "List",
+    description: "List files in a directory",
+    parameters: {
+      type: "object",
+      required: ["dirpath"],
+      properties: {
+        dirpath: {
+          type: "string",
+          description: "The path to the directory to list",
+        },
       },
     },
   },
+  displayTitle: "List",
   readonly: true,
+  group: "Built-In",
   isBuiltIn: true,
   preprocess: async (args) => {
     // Resolve relative paths