Merge pull request #70 from coreruleset/chore/validate-byte-range-op

refactor: validate byte range operator

Author: airween

g4/SecLangLexer.g4

@@ -630,7 +630,7 @@ OPERATOR_UNCONDITIONAL_MATCH
 	;
 
 OPERATOR_VALIDATE_BYTE_RANGE
-	: 'validateByteRange'
+	: 'validateByteRange' -> pushMode(REMOVE_SPACE_MODE)
 	;
 
 OPERATOR_VALIDATE_DTD
@@ -1393,4 +1393,32 @@ HASH_COMMENT_BLOCK
 
 BLOCK_COMMENT_END
    : '\r'? '\n' '\r'? '\n' -> popMode
+   ;
+
+mode REMOVE_SPACE_MODE;
+
+WS_REMOVE_SPACE
+   : ' '  -> skip, pushMode(INT_RANGE_MODE)
+   ;
+
+mode INT_RANGE_MODE;
+
+INT_RANGE_VALUE 
+   : DIGIT+
+   ;
+
+MINUS_INT_RANGE
+   : '-'
+   ;
+
+WS_INT_RANGE
+   : ' '+
+   ;
+
+QUOTE_INT_RANGE
+   : '"' -> type(QUOTE), pushMode(DEFAULT_MODE)
+   ;
+
+COMMA_INT_RANGE
+   : ',' -> type(COMMA)
    ;

g4/SecLangParser.g4

@@ -138,6 +138,10 @@ remove_rule_by_id_values:
     | int_range # remove_rule_by_id_int_range
     ;
 
+operator_int_range:
+    INT_RANGE_VALUE MINUS_INT_RANGE INT_RANGE_VALUE
+    ;
+
 int_range:
     range_start MINUS range_end
     ;
@@ -305,7 +309,7 @@ operator_name:
 operator_value:
     variable_enum
     | STRING
-    | (INT | int_range) (COMMA (INT | int_range))*
+    | WS_INT_RANGE* (INT_RANGE_VALUE | operator_int_range) (COMMA WS_INT_RANGE* (INT_RANGE_VALUE | operator_int_range))*
     | OPERATOR_UNQUOTED_STRING
     | OPERATOR_QUOTED_STRING
     ;

listener.go

@@ -86,6 +86,20 @@ func (l *TreeShapeListener) EnterRange_end(ctx *parser.Range_endContext) {
 	l.results.RangeEndEvents = append(l.results.RangeEndEvents, i)
 }
 
+func (l *TreeShapeListener) EnterOperator_int_range(ctx *parser.Operator_int_rangeContext) {
+	l.results.RangeEvents = append(l.results.RangeEvents, ctx.GetText())
+	i, err := strconv.Atoi(ctx.INT_RANGE_VALUE(0).GetText())
+	if err != nil {
+		panic(err)
+	}
+	l.results.RangeStartEvents = append(l.results.RangeStartEvents, i)
+	i, err = strconv.Atoi(ctx.INT_RANGE_VALUE(1).GetText())
+	if err != nil {
+		panic(err)
+	}
+	l.results.RangeEndEvents = append(l.results.RangeEndEvents, i)
+}
+
 func (l *TreeShapeListener) EnterRemove_rule_by_id(ctx *parser.Remove_rule_by_idContext) {
 	l.results.DirectiveList = append(l.results.DirectiveList, ctx.GetText())
 }

parser/seclang_lexer.go

@@ -134,6 +134,15 @@ def exitRemove_rule_by_id_int_range(self, ctx:SecLangParser.Remove_rule_by_id_in
         pass
 
 
+    # Enter a parse tree produced by SecLangParser#operator_int_range.
+    def enterOperator_int_range(self, ctx:SecLangParser.Operator_int_rangeContext):
+        pass
+
+    # Exit a parse tree produced by SecLangParser#operator_int_range.
+    def exitOperator_int_range(self, ctx:SecLangParser.Operator_int_rangeContext):
+        pass
+
+
     # Enter a parse tree produced by SecLangParser#int_range.
     def enterInt_range(self, ctx:SecLangParser.Int_rangeContext):
         pass