diff --git a/.classpath b/.classpath index d8e84c1c..a76b8432 100644 --- a/.classpath +++ b/.classpath @@ -1,12 +1,15 @@ - - - - - - - + + + + + + + + + + diff --git a/.metadata/.lock b/.metadata/.lock new file mode 100644 index 00000000..e69de29b diff --git a/.metadata/.log b/.metadata/.log new file mode 100644 index 00000000..9362e6bb --- /dev/null +++ b/.metadata/.log @@ -0,0 +1,190 @@ +!SESSION 2017-04-18 14:49:18.467 ----------------------------------------------- +eclipse.buildId=4.6.2.M20161124-1400 +java.version=1.8.0_101 +java.vendor=Oracle Corporation +BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US +Framework arguments: -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product +Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.java.product -data C:\Users\ringo\Documents\GitHub\A_Team-finalproject -product org.eclipse.epp.package.java.product + +!ENTRY org.eclipse.egit.ui 2 0 2017-04-18 14:49:41.480 +!MESSAGE Warning: The environment variable HOME is not set. The following directory will be used to store the Git +user global configuration and to define the default location to store repositories: 'C:\Users\ringo'. If this is +not correct please set the HOME environment variable and restart Eclipse. Otherwise Git for Windows and +EGit might behave differently since they see different configuration options. +This warning can be switched off on the Team > Git > Confirmations and Warnings preference page. + +!ENTRY com.instantiations.eclipse 1 0 2017-04-18 14:49:44.385 +!MESSAGE StartupPlugin: could not add workbench property change listener (1) ... compatibility layer might not be installed. + +!ENTRY com.instantiations.eclipse 1 0 2017-04-18 14:55:37.759 +!MESSAGE StartupPlugin: could not remove workbench property change listener (1) ... workbench might already be shut down. +!SESSION 2017-04-18 14:58:28.002 ----------------------------------------------- +eclipse.buildId=4.6.2.M20161124-1400 +java.version=1.8.0_101 +java.vendor=Oracle Corporation +BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US +Framework arguments: -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product +Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -data C:\Users\ringo\Documents\GitHub\A_Team-finalproject -product org.eclipse.epp.package.java.product + +!ENTRY org.eclipse.egit.ui 2 0 2017-04-18 14:58:55.403 +!MESSAGE Warning: The environment variable HOME is not set. The following directory will be used to store the Git +user global configuration and to define the default location to store repositories: 'C:\Users\ringo'. If this is +not correct please set the HOME environment variable and restart Eclipse. Otherwise Git for Windows and +EGit might behave differently since they see different configuration options. +This warning can be switched off on the Team > Git > Confirmations and Warnings preference page. + +!ENTRY com.instantiations.eclipse 1 0 2017-04-18 14:58:58.590 +!MESSAGE StartupPlugin: could not add workbench property change listener (1) ... compatibility layer might not be installed. + +!ENTRY com.instantiations.eclipse 1 0 2017-04-18 15:09:04.658 +!MESSAGE StartupPlugin: could not remove workbench property change listener (1) ... workbench might already be shut down. +!SESSION 2017-04-18 15:09:05.688 ----------------------------------------------- +eclipse.buildId=4.6.2.M20161124-1400 +java.version=1.8.0_101 +java.vendor=Oracle Corporation +BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US +Framework arguments: -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product +Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -data file:/C:/Users/ringo/Documents/GitHub/A_Team-finalproject/ -product org.eclipse.epp.package.java.product + +!ENTRY org.eclipse.egit.ui 2 0 2017-04-18 15:09:27.940 +!MESSAGE Warning: The environment variable HOME is not set. The following directory will be used to store the Git +user global configuration and to define the default location to store repositories: 'C:\Users\ringo'. If this is +not correct please set the HOME environment variable and restart Eclipse. Otherwise Git for Windows and +EGit might behave differently since they see different configuration options. +This warning can be switched off on the Team > Git > Confirmations and Warnings preference page. + +!ENTRY com.instantiations.eclipse 1 0 2017-04-18 15:09:29.763 +!MESSAGE StartupPlugin: could not add workbench property change listener (1) ... compatibility layer might not be installed. + +!ENTRY com.instantiations.eclipse 1 0 2017-04-18 15:11:49.140 +!MESSAGE StartupPlugin: could not remove workbench property change listener (1) ... workbench might already be shut down. +!SESSION 2017-05-16 17:57:16.056 ----------------------------------------------- +eclipse.buildId=4.6.3.M20170301-0400 +java.version=1.8.0_77 +java.vendor=Oracle Corporation +BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US +Framework arguments: -product org.eclipse.epp.package.java.product +Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.java.product + +!ENTRY org.eclipse.core.resources 4 567 2017-05-16 17:58:11.429 +!MESSAGE Workspace restored, but some problems occurred. +!SUBENTRY 1 org.eclipse.core.resources 4 567 2017-05-16 17:58:11.429 +!MESSAGE Could not read metadata for 'FreeCol'. +!STACK 1 +org.eclipse.core.internal.resources.ResourceException: The project description file (.project) for 'FreeCol' is missing. This file contains important information about the project. The project will not function properly until this file is restored. + at org.eclipse.core.internal.localstore.FileSystemResourceManager.read(FileSystemResourceManager.java:907) + at org.eclipse.core.internal.resources.SaveManager.restoreMetaInfo(SaveManager.java:904) + at org.eclipse.core.internal.resources.SaveManager.restoreMetaInfo(SaveManager.java:884) + at org.eclipse.core.internal.resources.SaveManager.restore(SaveManager.java:735) + at org.eclipse.core.internal.resources.SaveManager.startup(SaveManager.java:1587) + at org.eclipse.core.internal.resources.Workspace.startup(Workspace.java:2399) + at org.eclipse.core.internal.resources.Workspace.open(Workspace.java:2156) + at org.eclipse.core.resources.ResourcesPlugin.start(ResourcesPlugin.java:464) + at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:774) + at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1) + at java.security.AccessController.doPrivileged(Native Method) + at org.eclipse.osgi.internal.framework.BundleContextImpl.startActivator(BundleContextImpl.java:767) + at org.eclipse.osgi.internal.framework.BundleContextImpl.start(BundleContextImpl.java:724) + at org.eclipse.osgi.internal.framework.EquinoxBundle.startWorker0(EquinoxBundle.java:932) + at org.eclipse.osgi.internal.framework.EquinoxBundle$EquinoxModule.startWorker(EquinoxBundle.java:309) + at org.eclipse.osgi.container.Module.doStart(Module.java:581) + at org.eclipse.osgi.container.Module.start(Module.java:449) + at org.eclipse.osgi.framework.util.SecureAction.start(SecureAction.java:470) + at org.eclipse.osgi.internal.hooks.EclipseLazyStarter.postFindLocalClass(EclipseLazyStarter.java:107) + at org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:529) + at org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:325) + at org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:345) + at org.eclipse.osgi.internal.loader.sources.SingleSourcePackage.loadClass(SingleSourcePackage.java:36) + at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:419) + at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:372) + at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:364) + at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:161) + at java.lang.ClassLoader.loadClass(Unknown Source) + at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139) + at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) + at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) + at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) + at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) + at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) + at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) + at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) + at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) + at java.lang.reflect.Method.invoke(Unknown Source) + at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673) + at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610) + at org.eclipse.equinox.launcher.Main.run(Main.java:1519) +!SUBENTRY 2 org.eclipse.core.resources 4 567 2017-05-16 17:58:11.429 +!MESSAGE The project description file (.project) for 'FreeCol' is missing. This file contains important information about the project. The project will not function properly until this file is restored. + +!ENTRY org.eclipse.egit.ui 2 0 2017-05-16 17:58:19.072 +!MESSAGE Warning: The environment variable HOME is not set. The following directory will be used to store the Git +user global configuration and to define the default location to store repositories: 'C:\Users\Russell'. If this is +not correct please set the HOME environment variable and restart Eclipse. Otherwise Git for Windows and +EGit might behave differently since they see different configuration options. +This warning can be switched off on the Team > Git > Confirmations and Warnings preference page. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.742 +!MESSAGE Removing part descriptor with the 'com.mountainminds.eclemma.ui.CoverageView' id and the 'Coverage' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.753 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.analysis.dependencyView' id and the 'Dependencies' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.770 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.analysis.auditView' id and the 'Audit' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.786 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.metricsView' id and the 'Metrics' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.797 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.analysis.auditExplorerView' id and the 'Audit Explorer' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.816 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.coverage.codeCoverageView' id and the 'Code Coverage' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.826 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.junit.testCaseView' id and the 'TestCase Outline' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.861 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.junit.testGenerationView' id and the 'Generation Results' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.876 +!MESSAGE Removing part descriptor with the 'com.instantiations.assist.eclipse.schedulerView' id and the 'Scheduler' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.889 +!MESSAGE Removing part descriptor with the 'com.instantiations.eclipse.deadcode.deadCode' id and the 'Dead Code' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.905 +!MESSAGE Removing part descriptor with the 'com.instantiations.eclipse.analysis.similarCodeView' id and the 'Similar Code' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.918 +!MESSAGE Removing part descriptor with the 'org.eclipse.pde.api.tools.ui.views.apitooling.views.apitoolingview' id and the 'API Tools' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.928 +!MESSAGE Removing part descriptor with the 'org.eclipse.pde.runtime.RegistryBrowser' id and the 'Plug-in Registry' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.939 +!MESSAGE Removing part descriptor with the 'org.eclipse.pde.ui.PluginsView' id and the 'Plug-ins' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.949 +!MESSAGE Removing part descriptor with the 'org.eclipse.pde.ui.DependenciesView' id and the 'Plug-in Dependencies' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.958 +!MESSAGE Removing part descriptor with the 'org.eclipse.pde.ui.TargetPlatformState' id and the 'Target Platform State' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.966 +!MESSAGE Removing part descriptor with the 'org.eclipse.pde.ui.ImageBrowserView' id and the 'Plug-in Image Browser' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.974 +!MESSAGE Removing part descriptor with the 'org.pitest.pitclipse.ui.view.PitView' id and the 'PIT Summary' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.e4.ui.workbench 2 0 2017-05-16 17:58:20.982 +!MESSAGE Removing part descriptor with the 'org.pitest.pitclipse.ui.view.mutations.PitMutationsView' id and the 'PIT Mutations' description. Points to the invalid 'bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView' class. + +!ENTRY org.eclipse.core.resources 4 567 2017-05-16 17:59:12.762 +!MESSAGE The project description file (.project) for 'FreeCol' is missing. This file contains important information about the project. The project will not function properly until this file is restored. + +!ENTRY org.eclipse.core.resources 4 567 2017-05-16 18:04:54.137 +!MESSAGE The project description file (.project) for 'FreeCol' is missing. This file contains important information about the project. The project will not function properly until this file is restored. + +!ENTRY org.eclipse.core.resources 4 567 2017-05-16 18:06:48.752 +!MESSAGE The project description file (.project) for 'FreeCol' is missing. This file contains important information about the project. The project will not function properly until this file is restored. diff --git a/.metadata/.mylyn/.taskListIndex/segments.gen b/.metadata/.mylyn/.taskListIndex/segments.gen new file mode 100644 index 00000000..63a7ec9a Binary files /dev/null and b/.metadata/.mylyn/.taskListIndex/segments.gen differ diff --git a/.metadata/.mylyn/.taskListIndex/segments_1 b/.metadata/.mylyn/.taskListIndex/segments_1 new file mode 100644 index 00000000..b47261ee Binary files /dev/null and b/.metadata/.mylyn/.taskListIndex/segments_1 differ diff --git a/.metadata/.mylyn/.tasks.xml.zip b/.metadata/.mylyn/.tasks.xml.zip new file mode 100644 index 00000000..1f869647 Binary files /dev/null and b/.metadata/.mylyn/.tasks.xml.zip differ diff --git a/.metadata/.mylyn/repositories.xml.zip b/.metadata/.mylyn/repositories.xml.zip new file mode 100644 index 00000000..5088177d Binary files /dev/null and b/.metadata/.mylyn/repositories.xml.zip differ diff --git a/.metadata/.mylyn/tasks.xml.zip b/.metadata/.mylyn/tasks.xml.zip new file mode 100644 index 00000000..a44f2ccc Binary files /dev/null and b/.metadata/.mylyn/tasks.xml.zip differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.history/58/d0586ab9692400171766c3d1721026ad b/.metadata/.plugins/org.eclipse.core.resources/.history/58/d0586ab9692400171766c3d1721026ad new file mode 100644 index 00000000..57e0e36f --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.resources/.history/58/d0586ab9692400171766c3d1721026ad @@ -0,0 +1,2 @@ +/MANIFEST.MF +/net/ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.history/7e/f0e97d72692400171766c3d1721026ad b/.metadata/.plugins/org.eclipse.core.resources/.history/7e/f0e97d72692400171766c3d1721026ad new file mode 100644 index 00000000..e238b865 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.resources/.history/7e/f0e97d72692400171766c3d1721026ad @@ -0,0 +1,11 @@ + + + FreeCol + + + + + + + + diff --git a/.metadata/.plugins/org.eclipse.core.resources/.history/a7/d00563b9692400171766c3d1721026ad b/.metadata/.plugins/org.eclipse.core.resources/.history/a7/d00563b9692400171766c3d1721026ad new file mode 100644 index 00000000..4854a41b --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.resources/.history/a7/d00563b9692400171766c3d1721026ad @@ -0,0 +1 @@ +/MANIFEST.MF diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/7/history.index b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/7/history.index new file mode 100644 index 00000000..8b53e074 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/7/history.index differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/history.index b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/history.index new file mode 100644 index 00000000..9d1296fb Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/history.index differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/properties.index b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/properties.index new file mode 100644 index 00000000..1e099f3b Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.indexes/properties.index differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.markers b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.markers new file mode 100644 index 00000000..e6e55110 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/.markers differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/1.tree b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/1.tree new file mode 100644 index 00000000..68632fdc Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/1.tree differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/2.tree b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/2.tree new file mode 100644 index 00000000..68632fdc Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/2.tree differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/3.tree b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/3.tree new file mode 100644 index 00000000..68632fdc Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/3.tree differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/4.tree b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/4.tree new file mode 100644 index 00000000..68632fdc Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/4.tree differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/org.eclipse.egit.core/GitProjectData.properties b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/org.eclipse.egit.core/GitProjectData.properties new file mode 100644 index 00000000..78631259 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/org.eclipse.egit.core/GitProjectData.properties @@ -0,0 +1,3 @@ +#GitProjectData +#Tue Apr 18 15:03:15 EDT 2017 +.gitdir=.git diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/org.eclipse.jdt.core/state.dat b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/org.eclipse.jdt.core/state.dat new file mode 100644 index 00000000..22b4b519 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/FreeCol/org.eclipse.jdt.core/state.dat differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.indexes/properties.index b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.indexes/properties.index new file mode 100644 index 00000000..1e099f3b Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.indexes/properties.index differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.location b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.location new file mode 100644 index 00000000..838c8d80 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.location differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.markers b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.markers new file mode 100644 index 00000000..337ce735 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/.markers differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/1.tree b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/1.tree new file mode 100644 index 00000000..f5340802 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/1.tree differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/org.eclipse.egit.core/GitProjectData.properties b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/org.eclipse.egit.core/GitProjectData.properties new file mode 100644 index 00000000..0fd186fa --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/org.eclipse.egit.core/GitProjectData.properties @@ -0,0 +1,3 @@ +#GitProjectData +#Tue Apr 18 14:52:14 EDT 2017 +.gitdir=.git diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/org.eclipse.jdt.core/state.dat b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/org.eclipse.jdt.core/state.dat new file mode 100644 index 00000000..a718cce0 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/OLI/org.eclipse.jdt.core/state.dat differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/.location b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/.location new file mode 100644 index 00000000..0f072d7a Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/.location differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/.markers b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/.markers new file mode 100644 index 00000000..ee71d420 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/.markers differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/1.tree b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/1.tree new file mode 100644 index 00000000..84e8ac68 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/1.tree differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/org.eclipse.jdt.core/state.dat b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/org.eclipse.jdt.core/state.dat new file mode 100644 index 00000000..0e35a374 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.projects/ObjectLabSoftwaree/org.eclipse.jdt.core/state.dat differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/history.version b/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/history.version new file mode 100644 index 00000000..25cb955b --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/history.version @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/properties.index b/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/properties.index new file mode 100644 index 00000000..a274f703 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/properties.index differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/properties.version b/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/properties.version new file mode 100644 index 00000000..6b2aaa76 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.resources/.root/.indexes/properties.version @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.core.resources/.root/.markers.snap b/.metadata/.plugins/org.eclipse.core.resources/.root/.markers.snap new file mode 100644 index 00000000..91d6c541 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.root/.markers.snap differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.root/3.tree b/.metadata/.plugins/org.eclipse.core.resources/.root/3.tree new file mode 100644 index 00000000..6869816b Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.root/3.tree differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/.safetable/org.eclipse.core.resources b/.metadata/.plugins/org.eclipse.core.resources/.safetable/org.eclipse.core.resources new file mode 100644 index 00000000..d913000d Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/.safetable/org.eclipse.core.resources differ diff --git a/.metadata/.plugins/org.eclipse.core.resources/3.snap b/.metadata/.plugins/org.eclipse.core.resources/3.snap new file mode 100644 index 00000000..17978c77 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.core.resources/3.snap differ diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ant.ui.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ant.ui.prefs new file mode 100644 index 00000000..565f933d --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ant.ui.prefs @@ -0,0 +1,3 @@ +eclipse.preferences.version=1 +useAnnotationsPrefPage=true +useQuickDiffPrefPage=true diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.core.net.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.core.net.prefs new file mode 100644 index 00000000..27744201 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.core.net.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +org.eclipse.core.net.hasMigrated=true diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.core.resources.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.core.resources.prefs new file mode 100644 index 00000000..dffc6b51 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.core.resources.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +version=1 diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.debug.ui.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.debug.ui.prefs new file mode 100644 index 00000000..9dd00d66 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.debug.ui.prefs @@ -0,0 +1,3 @@ +eclipse.preferences.version=1 +org.eclipse.debug.ui.PREF_LAUNCH_PERSPECTIVES=\r\n\r\n +preferredTargets=default\:default| diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.egit.core.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.egit.core.prefs new file mode 100644 index 00000000..1ed3f5cd --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.egit.core.prefs @@ -0,0 +1,3 @@ +GitRepositoriesView.GitDirectories=C\:\\Users\\ringo\\Documents\\GitHub\\Object-Lab-Interface\\.git;C\:\\Users\\ringo\\Documents\\GitHub\\A_Team-finalproject\\.git; +GitRepositoriesView.GitDirectories.relative=C\:\\Users\\ringo\\Documents\\GitHub\\Object-Lab-Interface\\.git;.git; +eclipse.preferences.version=1 diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.epp.logging.aeri.ide.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.epp.logging.aeri.ide.prefs new file mode 100644 index 00000000..c186df87 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.epp.logging.aeri.ide.prefs @@ -0,0 +1,4 @@ +eclipse.preferences.version=1 +resetSendMode=KEEP +resetSendModeOn=0 +sendMode=NOTIFY diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.core.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.core.prefs new file mode 100644 index 00000000..0c68a61d --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.core.prefs @@ -0,0 +1,7 @@ +eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled +org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.8 +org.eclipse.jdt.core.compiler.compliance=1.8 +org.eclipse.jdt.core.compiler.problem.assertIdentifier=error +org.eclipse.jdt.core.compiler.problem.enumIdentifier=error +org.eclipse.jdt.core.compiler.source=1.8 diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.launching.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.launching.prefs new file mode 100644 index 00000000..69f2dedc --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.launching.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +org.eclipse.jdt.launching.PREF_VM_XML=\r\n\r\n\r\n\r\n\r\n\r\n diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.ui.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.ui.prefs new file mode 100644 index 00000000..c8fd235a --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.jdt.ui.prefs @@ -0,0 +1,13 @@ +content_assist_proposals_background=255,255,255 +content_assist_proposals_foreground=0,0,0 +eclipse.preferences.version=1 +fontPropagated=true +org.eclipse.jdt.ui.editor.tab.width= +org.eclipse.jdt.ui.formatterprofiles.version=12 +org.eclipse.jdt.ui.javadoclocations.migrated=true +org.eclipse.jface.textfont=1|Consolas|10.0|0|WINDOWS|1|0|0|0|0|0|0|0|0|1|0|0|0|0|Consolas; +proposalOrderMigrated=true +spelling_locale_initialized=true +tabWidthPropagated=true +useAnnotationsPrefPage=true +useQuickDiffPrefPage=true diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.m2e.discovery.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.m2e.discovery.prefs new file mode 100644 index 00000000..67b1d96c --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.m2e.discovery.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +org.eclipse.m2e.discovery.pref.projects= diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.context.core.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.context.core.prefs new file mode 100644 index 00000000..43e97e40 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.context.core.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +mylyn.attention.migrated=true diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.monitor.ui.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.monitor.ui.prefs new file mode 100644 index 00000000..8d462a6c --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.monitor.ui.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +org.eclipse.mylyn.monitor.activity.tracking.enabled.checked=true diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.tasks.ui.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.tasks.ui.prefs new file mode 100644 index 00000000..2b60c21d --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.mylyn.tasks.ui.prefs @@ -0,0 +1,5 @@ +eclipse.preferences.version=1 +migrated.task.repositories.secure.store=true +org.eclipse.mylyn.tasks.ui.filters.nonmatching=true +org.eclipse.mylyn.tasks.ui.filters.nonmatching.encouraged=true +org.eclipse.mylyn.tasks.ui.welcome.message=true diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.oomph.workingsets.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.oomph.workingsets.prefs new file mode 100644 index 00000000..a9ca0a11 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.oomph.workingsets.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +working.set.group=\n\n diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.pde.api.tools.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.pde.api.tools.prefs new file mode 100644 index 00000000..d2ed6037 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.pde.api.tools.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +knownEEFragments= diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.team.ui.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.team.ui.prefs new file mode 100644 index 00000000..56cd496f --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.team.ui.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +org.eclipse.team.ui.first_time=false diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.editors.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.editors.prefs new file mode 100644 index 00000000..61f3bb8b --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.editors.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +overviewRuler_migration=migrated_3.1 diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.ide.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.ide.prefs new file mode 100644 index 00000000..00ea3a48 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.ide.prefs @@ -0,0 +1,5 @@ +PROBLEMS_FILTERS_MIGRATE=true +eclipse.preferences.version=1 +platformState=1486669427153 +quickStart=false +tipsAndTricks=true diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.prefs new file mode 100644 index 00000000..08076f23 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.prefs @@ -0,0 +1,2 @@ +eclipse.preferences.version=1 +showIntro=false diff --git a/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.workbench.prefs b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.workbench.prefs new file mode 100644 index 00000000..dd774965 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.workbench.prefs @@ -0,0 +1,3 @@ +//org.eclipse.ui.commands/state/org.eclipse.ui.navigator.resources.nested.changeProjectPresentation/org.eclipse.ui.commands.radioState=false +PLUGINS_NOT_ACTIVATED_ON_STARTUP=org.eclipse.m2e.discovery; +eclipse.preferences.version=1 diff --git a/.metadata/.plugins/org.eclipse.debug.core/.launches/FreeCol build.xml.launch b/.metadata/.plugins/org.eclipse.debug.core/.launches/FreeCol build.xml.launch new file mode 100644 index 00000000..a4327e7b --- /dev/null +++ b/.metadata/.plugins/org.eclipse.debug.core/.launches/FreeCol build.xml.launch @@ -0,0 +1,15 @@ + + + + + + + + + + + + + + + diff --git a/.metadata/.plugins/org.eclipse.debug.ui/launchConfigurationHistory.xml b/.metadata/.plugins/org.eclipse.debug.ui/launchConfigurationHistory.xml new file mode 100644 index 00000000..aa6ab569 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.debug.ui/launchConfigurationHistory.xml @@ -0,0 +1,21 @@ + + + + + + + + + + + + + + + + + + + + + diff --git a/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi b/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi new file mode 100644 index 00000000..92a5ffba --- /dev/null +++ b/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi @@ -0,0 +1,2538 @@ + + + + activeSchemeId:org.eclipse.ui.defaultAcceleratorConfiguration + ModelMigrationProcessor.001 + + + + + + + + topLevel + shellMaximized + + + + + persp.actionSet:org.eclipse.mylyn.doc.actionSet + persp.actionSet:org.eclipse.mylyn.tasks.ui.navigation + persp.actionSet:org.eclipse.ui.cheatsheets.actionSet + persp.actionSet:org.eclipse.search.searchActionSet + persp.actionSet:org.eclipse.ui.edit.text.actionSet.annotationNavigation + persp.actionSet:org.eclipse.ui.edit.text.actionSet.navigation + persp.actionSet:org.eclipse.ui.edit.text.actionSet.convertLineDelimitersTo + persp.actionSet:org.eclipse.ui.externaltools.ExternalToolsSet + persp.actionSet:org.eclipse.ui.actionSet.keyBindings + persp.actionSet:org.eclipse.ui.actionSet.openFiles + persp.actionSet:com.instantiations.assist.eclipse.codeproMenu + persp.actionSet:com.instantiations.assist.eclipse.codeproMenu.dependency + persp.actionSet:com.instantiations.assist.eclipse.codeproMenu.audit + persp.actionSet:com.instantiations.assist.eclipse.codeproMenu.doc + persp.actionSet:com.instantiations.eclipse.analysis.similarcode.ui.ActionSet + persp.actionSet:com.instantiations.assist.eclipse.codeproMenu.test + persp.actionSet:org.eclipse.debug.ui.launchActionSet + persp.actionSet:org.eclipse.jdt.ui.JavaActionSet + persp.actionSet:org.eclipse.jdt.ui.JavaElementCreationActionSet + persp.actionSet:org.eclipse.ui.NavigateActionSet + persp.viewSC:org.eclipse.jdt.ui.PackageExplorer + persp.viewSC:org.eclipse.jdt.ui.TypeHierarchy + persp.viewSC:org.eclipse.jdt.ui.SourceView + persp.viewSC:org.eclipse.jdt.ui.JavadocView + persp.viewSC:org.eclipse.search.ui.views.SearchView + persp.viewSC:org.eclipse.ui.console.ConsoleView + persp.viewSC:org.eclipse.ui.views.ContentOutline + persp.viewSC:org.eclipse.ui.views.ProblemView + persp.viewSC:org.eclipse.ui.views.ResourceNavigator + persp.viewSC:org.eclipse.ui.views.TaskList + persp.viewSC:org.eclipse.ui.views.ProgressView + persp.viewSC:org.eclipse.ui.navigator.ProjectExplorer + persp.viewSC:org.eclipse.ui.texteditor.TemplatesView + persp.viewSC:org.eclipse.pde.runtime.LogView + persp.newWizSC:org.eclipse.jdt.ui.wizards.JavaProjectWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewPackageCreationWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewClassCreationWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewInterfaceCreationWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewEnumCreationWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewAnnotationCreationWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewSourceFolderCreationWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewSnippetFileCreationWizard + persp.newWizSC:org.eclipse.jdt.ui.wizards.NewJavaWorkingSetWizard + persp.newWizSC:org.eclipse.ui.wizards.new.folder + persp.newWizSC:org.eclipse.ui.wizards.new.file + persp.newWizSC:org.eclipse.ui.editors.wizards.UntitledTextFileWizard + persp.perspSC:org.eclipse.jdt.ui.JavaBrowsingPerspective + persp.perspSC:org.eclipse.debug.ui.DebugPerspective + persp.viewSC:com.instantiations.assist.eclipse.analysis.dependencyView + persp.viewSC:com.instantiations.assist.eclipse.analysis.auditView + persp.viewSC:com.instantiations.assist.eclipse.metricsView + persp.viewSC:com.instantiations.assist.eclipse.coverage.codeCoverageView + persp.newWizSC:com.instantiations.assist.eclipse.junit.wizard.testCaseWizard + persp.viewSC:com.instantiations.assist.eclipse.schedulerView + persp.actionSet:com.mountainminds.eclemma.ui.CoverageActionSet + persp.showIn:com.mountainminds.eclemma.ui.CoverageView + persp.viewSC:org.eclipse.ant.ui.views.AntView + persp.showIn:org.eclipse.egit.ui.RepositoriesView + persp.actionSet:org.eclipse.debug.ui.breakpointActionSet + persp.actionSet:org.eclipse.jdt.debug.ui.JDTDebugActionSet + persp.newWizSC:org.eclipse.jdt.junit.wizards.NewTestCaseCreationWizard + persp.actionSet:org.eclipse.jdt.junit.JUnitActionSet + persp.showIn:org.eclipse.jdt.ui.PackageExplorer + persp.showIn:org.eclipse.team.ui.GenericHistoryView + persp.showIn:org.eclipse.ui.views.ResourceNavigator + persp.showIn:org.eclipse.ui.navigator.ProjectExplorer + persp.viewSC:org.eclipse.mylyn.tasks.ui.views.tasks + persp.newWizSC:org.eclipse.mylyn.tasks.ui.wizards.new.repository.task + + + + org.eclipse.e4.primaryNavigationStack + active + noFocus + + + + + + + + + + + + + + + + + + + org.eclipse.e4.secondaryNavigationStack + + + + + + + + + org.eclipse.e4.secondaryDataStack + + + + + + + + + + + + + + + + + + + + + + + + + + + + View + categoryTag:Help + + + + + + View + categoryTag:General + + ViewMenu + menuContribution:menu + + + + + + + View + categoryTag:Help + + + + org.eclipse.e4.primaryDataStack + EditorStack + + + Editor + org.eclipse.ant.ui.internal.editor.AntEditor + removeOnHide + + menuContribution:popup + popup:#AntEditorContext + popup:#AbstractTextEditorContext + + + menuContribution:popup + popup:#AntEditorRulerContext + popup:#AbstractTextEditorRulerContext + + + menuContribution:popup + popup:#OverviewRulerContext + + + + + + + + + View + categoryTag:Java + active + + ViewMenu + menuContribution:menu + + + menuContribution:popup + popup:org.eclipse.jdt.ui.PackageExplorer + + + + + + + View + categoryTag:Java + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + + View + categoryTag:General + + ViewMenu + menuContribution:menu + + + menuContribution:popup + popup:org.eclipse.ui.views.ProblemView + popup:org.eclipse.ui.ide.MarkersView + + + + + + + View + categoryTag:Java + + + + + View + categoryTag:Java + + + + + View + categoryTag:General + + + + + + View + categoryTag:General + + ViewMenu + menuContribution:menu + + + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + + View + categoryTag:General + + ViewMenu + menuContribution:menu + + + menuContribution:popup + popup:org.eclipse.ant.ui.antEditorOutline + + + + + + + View + categoryTag:General + + + + + View + categoryTag:CodePro Views + + + + + View + categoryTag:CodePro Views + + + + + View + categoryTag:CodePro Views + + + + + View + categoryTag:Code Coverage + + + + + View + categoryTag:CodePro Views + + + + + View + categoryTag:CodePro Views + + + + + View + categoryTag:CodePro Views + + + + + View + categoryTag:Ant + + + + + View + categoryTag:Git + + + + + View + categoryTag:Java + + + + + + View + categoryTag:Mylyn + + ViewMenu + menuContribution:menu + + + menuContribution:popup + popup:org.eclipse.mylyn.tasks.ui.menus.activeTask + + + menuContribution:popup + popup:org.eclipse.mylyn.tasks.ui.views.tasks + + + + + + toolbarSeparator + + + + Draggable + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + + toolbarSeparator + + + + Draggable + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + + Draggable + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + + Draggable + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + + Draggable + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + + toolbarSeparator + + + + Draggable + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + Opaque + + + + Opaque + + + Opaque + + + Opaque + + + + Draggable + + + toolbarSeparator + + + + toolbarSeparator + + + + Draggable + + Opaque + + + Opaque + + + + stretch + SHOW_RESTORE_MENU + + + Draggable + HIDEABLE + SHOW_RESTORE_MENU + + + + + stretch + + + Draggable + + + Draggable + + + + + TrimStack + Draggable + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + platform:win32 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + platform:win32 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Editor + + + + + View + categoryTag:Ant + + + + + View + categoryTag:Gradle + + + + + View + categoryTag:Gradle + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Git + + + + + View + categoryTag:Git + + + + + View + categoryTag:Git + + + + + View + categoryTag:Git + + + + + View + categoryTag:Git + + + + + View + categoryTag:General + + + + + View + categoryTag:Help + + + + + View + categoryTag:Debug + + + + + View + categoryTag:Java + + + + + View + categoryTag:Java + + + + + View + categoryTag:Java + + + + + View + categoryTag:Java Browsing + + + + + View + categoryTag:Java Browsing + + + + + View + categoryTag:Java Browsing + + + + + View + categoryTag:Java Browsing + + + + + View + categoryTag:Java + + + + + View + categoryTag:General + + + + + View + categoryTag:Java + + + + + View + categoryTag:Java + + + + + View + categoryTag:Maven + + + + + View + categoryTag:Maven + + + + + View + categoryTag:Mylyn + + + + + View + categoryTag:Mylyn + + + + + View + categoryTag:Mylyn + + + + + View + categoryTag:Mylyn + + + + + View + categoryTag:Oomph + + + + + View + categoryTag:Code Recommenders + + + + + View + categoryTag:Code Recommenders + + + + + View + categoryTag:Code Recommenders + + + + + View + categoryTag:Code Recommenders + + + + + View + categoryTag:Code Recommenders + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:Team + + + + + View + categoryTag:Team + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:Help + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:General + + + + + View + categoryTag:XML + + + + + View + categoryTag:XML + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/segments.gen b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/segments.gen new file mode 100644 index 00000000..63a7ec9a Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/segments.gen differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/segments_1 b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/segments_1 new file mode 100644 index 00000000..6bb47a55 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/segments_1 differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/write.lock b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/http-cache/write.lock new file mode 100644 index 00000000..e69de29b diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fdt b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fdt new file mode 100644 index 00000000..d5abf41c Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fdt differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fdx b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fdx new file mode 100644 index 00000000..b8ee8095 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fdx differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fnm b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fnm new file mode 100644 index 00000000..523c92e2 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.fnm @@ -0,0 +1 @@ +ýÿÿÿversion \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.frq b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.frq new file mode 100644 index 00000000..e69de29b diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.nrm b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.nrm new file mode 100644 index 00000000..cf8dc752 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.nrm @@ -0,0 +1 @@ +NRMÿ \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.tii b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.tii new file mode 100644 index 00000000..ebd518d6 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.tii differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.tis b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.tis new file mode 100644 index 00000000..ebd518d6 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/_0.tis differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/segments.gen b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/segments.gen new file mode 100644 index 00000000..63a7ec9a Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/segments.gen differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/segments_1 b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/segments_1 new file mode 100644 index 00000000..93b72ba9 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/segments_1 differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/write.lock b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/local-history/write.lock new file mode 100644 index 00000000..e69de29b diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fdt b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fdt new file mode 100644 index 00000000..d5abf41c Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fdt differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fdx b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fdx new file mode 100644 index 00000000..b8ee8095 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fdx differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fnm b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fnm new file mode 100644 index 00000000..523c92e2 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.fnm @@ -0,0 +1 @@ +ýÿÿÿversion \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.frq b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.frq new file mode 100644 index 00000000..e69de29b diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.nrm b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.nrm new file mode 100644 index 00000000..cf8dc752 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.nrm @@ -0,0 +1 @@ +NRMÿ \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.tii b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.tii new file mode 100644 index 00000000..ebd518d6 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.tii differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.tis b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.tis new file mode 100644 index 00000000..ebd518d6 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/_0.tis differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/segments.gen b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/segments.gen new file mode 100644 index 00000000..63a7ec9a Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/segments.gen differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/segments_1 b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/segments_1 new file mode 100644 index 00000000..c66c16fa Binary files /dev/null and b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/remote-history/segments_1 differ diff --git a/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/server-config.json b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/server-config.json new file mode 100644 index 00000000..50589fc7 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.epp.logging.aeri.ide/org.eclipse.epp.logging.aeri.ide.server/server-config.json @@ -0,0 +1,72 @@ +{ + "version": "v1", + "title": "Eclipse", + "timestamp": 1494971900103, + "ttl": 10080, + "helpUrl": "https://dev.eclipse.org/recommenders/community/aeri/v2/help/", + "feedbackUrl": "http://ctrlflow.com/automated-error-reporting", + "aboutUrl": "https://wiki.eclipse.org/EPP/Logging", + "submitUrl": "https://dev.eclipse.org/recommenders/community/confess/0.6/reports/", + "maxReportSize": 262144, + "problemsUrl": "https://www.eclipse.org/downloads/download.php?r\u003d1\u0026file\u003d/technology/epp/logging/problems.zip", + "problemsTtl": 20160, + "interestUrl": "https://dev.eclipse.org/recommenders/community/confess/v2/interest", + "connectTimeout": 10, + "socketTimeout": 10, + "acceptedProducts": [ + "org.eclipse.*", + "org.fordiac.*" + ], + "acceptedPlugins": [ + "org.apache.log4j.*", + "org.eclipse.*", + "org.fordiac.*" + ], + "acceptedPackages": [ + "ch.qos.*", + "com.cforcoding.*", + "com.google.*", + "com.gradleware.tooling.*", + "com.mountainminds.eclemma.*", + "com.naef.*", + "com.sun.*", + "java.*", + "javafx.*", + "javax.*", + "org.apache.*", + "org.eclipse.*", + "org.fordiac.*", + "org.gradle.*", + "org.jacoco.*", + "org.osgi.*", + "org.slf4j.*", + "sun.*" + ], + "requiredPackages": [ + "com.cforcoding.*", + "com.gradleware.tooling.*", + "com.mountainminds.eclemma.*", + "com.naef.*", + "org.eclipse.*", + "org.fordiac.*", + "org.gradle.*", + "org.jacoco.*" + ], + "acceptOtherPackages": false, + "acceptUiFreezes": true, + "ignoredStatuses": [ + ":java.io.IOException:There is not enough space on the disk", + ":java.net.*:", + "org.eclipse.core.filesystem::Could not delete*", + "org.eclipse.core.filesystem::Could not move*", + "org.eclipse.core.resources:org.eclipse.core.internal.resources.ResourceException:Resource is out of sync with the file system*", + "org.eclipse.core.runtime::Invalid input url*", + "org.eclipse.epp.mpc.ui:java.io.IOException:", + "org.eclipse.equinox.p2.*::", + "org.eclipse.jface:java.io.IOException:Unable to resolve plug-in*", + "org.eclipse.oomph.setup.core:$org.apache.http.ConnectionClosedException:", + "org.eclipse.pde.core::The current target platform contains errors*", + "org.eclipse.ui::Conflicting handlers for*" + ], + "problemsZipLastDownloadTimestamp": 0 +} \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.jdt.core/1075794691.index b/.metadata/.plugins/org.eclipse.jdt.core/1075794691.index new file mode 100644 index 00000000..a0dfad9b Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/1075794691.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/1644702904.index b/.metadata/.plugins/org.eclipse.jdt.core/1644702904.index new file mode 100644 index 00000000..9a0b96d7 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/1644702904.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/2019903893.index b/.metadata/.plugins/org.eclipse.jdt.core/2019903893.index new file mode 100644 index 00000000..83d3a830 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/2019903893.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/2133282975.index b/.metadata/.plugins/org.eclipse.jdt.core/2133282975.index new file mode 100644 index 00000000..73019a12 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/2133282975.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/2400011239.index b/.metadata/.plugins/org.eclipse.jdt.core/2400011239.index new file mode 100644 index 00000000..8ff52607 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/2400011239.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/2637943071.index b/.metadata/.plugins/org.eclipse.jdt.core/2637943071.index new file mode 100644 index 00000000..7d482668 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/2637943071.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/2800558102.index b/.metadata/.plugins/org.eclipse.jdt.core/2800558102.index new file mode 100644 index 00000000..18789630 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/2800558102.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/2809250744.index b/.metadata/.plugins/org.eclipse.jdt.core/2809250744.index new file mode 100644 index 00000000..c995ea08 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/2809250744.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/2855899100.index b/.metadata/.plugins/org.eclipse.jdt.core/2855899100.index new file mode 100644 index 00000000..97607a66 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/2855899100.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/3159853280.index b/.metadata/.plugins/org.eclipse.jdt.core/3159853280.index new file mode 100644 index 00000000..9fd3fcc2 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/3159853280.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/3193805135.index b/.metadata/.plugins/org.eclipse.jdt.core/3193805135.index new file mode 100644 index 00000000..981c9a7f Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/3193805135.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/3407430047.index b/.metadata/.plugins/org.eclipse.jdt.core/3407430047.index new file mode 100644 index 00000000..97af37de Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/3407430047.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/3417200662.index b/.metadata/.plugins/org.eclipse.jdt.core/3417200662.index new file mode 100644 index 00000000..2fccec61 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/3417200662.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/351221734.index b/.metadata/.plugins/org.eclipse.jdt.core/351221734.index new file mode 100644 index 00000000..9afca209 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/351221734.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/3909004621.index b/.metadata/.plugins/org.eclipse.jdt.core/3909004621.index new file mode 100644 index 00000000..a00854d9 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/3909004621.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/3932020233.index b/.metadata/.plugins/org.eclipse.jdt.core/3932020233.index new file mode 100644 index 00000000..95ee7520 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/3932020233.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/3968205022.index b/.metadata/.plugins/org.eclipse.jdt.core/3968205022.index new file mode 100644 index 00000000..36cf4666 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/3968205022.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/414978335.index b/.metadata/.plugins/org.eclipse.jdt.core/414978335.index new file mode 100644 index 00000000..d8292fc1 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/414978335.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/4184201189.index b/.metadata/.plugins/org.eclipse.jdt.core/4184201189.index new file mode 100644 index 00000000..9f3693da Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/4184201189.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/471236001.index b/.metadata/.plugins/org.eclipse.jdt.core/471236001.index new file mode 100644 index 00000000..66762af6 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/471236001.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/618723895.index b/.metadata/.plugins/org.eclipse.jdt.core/618723895.index new file mode 100644 index 00000000..08b8b997 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/618723895.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/651039533.index b/.metadata/.plugins/org.eclipse.jdt.core/651039533.index new file mode 100644 index 00000000..6055db7d Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/651039533.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/781808.index b/.metadata/.plugins/org.eclipse.jdt.core/781808.index new file mode 100644 index 00000000..2fe05cc0 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/781808.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/808374113.index b/.metadata/.plugins/org.eclipse.jdt.core/808374113.index new file mode 100644 index 00000000..db726f87 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/808374113.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/985286902.index b/.metadata/.plugins/org.eclipse.jdt.core/985286902.index new file mode 100644 index 00000000..202b68bd Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/985286902.index differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/assumedExternalFilesCache b/.metadata/.plugins/org.eclipse.jdt.core/assumedExternalFilesCache new file mode 100644 index 00000000..593f4708 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/assumedExternalFilesCache differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/externalFilesCache b/.metadata/.plugins/org.eclipse.jdt.core/externalFilesCache new file mode 100644 index 00000000..bbdccbf5 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/externalFilesCache differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/externalLibsTimeStamps b/.metadata/.plugins/org.eclipse.jdt.core/externalLibsTimeStamps new file mode 100644 index 00000000..fe8ffef5 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/externalLibsTimeStamps differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/indexNamesMap.txt b/.metadata/.plugins/org.eclipse.jdt.core/indexNamesMap.txt new file mode 100644 index 00000000..ef541361 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.core/indexNamesMap.txt @@ -0,0 +1 @@ +INDEX VERSION 1.129 diff --git a/.metadata/.plugins/org.eclipse.jdt.core/javaLikeNames.txt b/.metadata/.plugins/org.eclipse.jdt.core/javaLikeNames.txt new file mode 100644 index 00000000..85863977 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.core/javaLikeNames.txt @@ -0,0 +1 @@ +java \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.jdt.core/nonChainingJarsCache b/.metadata/.plugins/org.eclipse.jdt.core/nonChainingJarsCache new file mode 100644 index 00000000..5c0729fb Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/nonChainingJarsCache differ diff --git a/.metadata/.plugins/org.eclipse.jdt.core/savedIndexNames.txt b/.metadata/.plugins/org.eclipse.jdt.core/savedIndexNames.txt new file mode 100644 index 00000000..baf7ebe4 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.core/savedIndexNames.txt @@ -0,0 +1,26 @@ +INDEX VERSION 1.129+C:\Users\ringo\Documents\GitHub\A_Team-finalproject\.metadata\.plugins\org.eclipse.jdt.core +2400011239.index +3968205022.index +351221734.index +808374113.index +2133282975.index +2637943071.index +4184201189.index +3159853280.index +1075794691.index +3193805135.index +3417200662.index +985286902.index +3932020233.index +414978335.index +2019903893.index +471236001.index +2809250744.index +3407430047.index +781808.index +2855899100.index +618723895.index +2800558102.index +1644702904.index +3909004621.index +651039533.index diff --git a/.metadata/.plugins/org.eclipse.jdt.core/variablesAndContainers.dat b/.metadata/.plugins/org.eclipse.jdt.core/variablesAndContainers.dat new file mode 100644 index 00000000..0edae4b2 Binary files /dev/null and b/.metadata/.plugins/org.eclipse.jdt.core/variablesAndContainers.dat differ diff --git a/.metadata/.plugins/org.eclipse.jdt.launching/.install.xml b/.metadata/.plugins/org.eclipse.jdt.launching/.install.xml new file mode 100644 index 00000000..e18c1d42 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.launching/.install.xml @@ -0,0 +1,4 @@ + + + + diff --git a/.metadata/.plugins/org.eclipse.jdt.launching/libraryInfos.xml b/.metadata/.plugins/org.eclipse.jdt.launching/libraryInfos.xml new file mode 100644 index 00000000..0adfd02b --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.launching/libraryInfos.xml @@ -0,0 +1,22 @@ + + + + + + + + + + + + + + + + + + + + + + diff --git a/.metadata/.plugins/org.eclipse.jdt.ui/OpenTypeHistory.xml b/.metadata/.plugins/org.eclipse.jdt.ui/OpenTypeHistory.xml new file mode 100644 index 00000000..a4ee3cbc --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.ui/OpenTypeHistory.xml @@ -0,0 +1,2 @@ + + diff --git a/.metadata/.plugins/org.eclipse.jdt.ui/QualifiedTypeNameHistory.xml b/.metadata/.plugins/org.eclipse.jdt.ui/QualifiedTypeNameHistory.xml new file mode 100644 index 00000000..9e390f50 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.ui/QualifiedTypeNameHistory.xml @@ -0,0 +1,2 @@ + + diff --git a/.metadata/.plugins/org.eclipse.jdt.ui/dialog_settings.xml b/.metadata/.plugins/org.eclipse.jdt.ui/dialog_settings.xml new file mode 100644 index 00000000..13cd96f1 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.jdt.ui/dialog_settings.xml @@ -0,0 +1,15 @@ + +
+
+ + + + + +
+
+ +
+
+
+
diff --git a/.metadata/.plugins/org.eclipse.m2e.logback.configuration/0.log b/.metadata/.plugins/org.eclipse.m2e.logback.configuration/0.log new file mode 100644 index 00000000..6f8c18ff --- /dev/null +++ b/.metadata/.plugins/org.eclipse.m2e.logback.configuration/0.log @@ -0,0 +1,4 @@ +2017-04-18 14:49:40,725 [Worker-2] INFO c.g.t.t.d.PublishedGradleVersions - Gradle version information cache is up-to-date. Trying to read. +2017-04-18 14:58:54,985 [Worker-2] INFO c.g.t.t.d.PublishedGradleVersions - Gradle version information cache is up-to-date. Trying to read. +2017-04-18 15:09:27,563 [Worker-1] INFO c.g.t.t.d.PublishedGradleVersions - Gradle version information cache is up-to-date. Trying to read. +2017-05-16 17:58:18,778 [Worker-0] INFO c.g.t.t.d.PublishedGradleVersions - Gradle version information cache is up-to-date. Trying to read. diff --git a/.metadata/.plugins/org.eclipse.m2e.logback.configuration/logback.1.7.0.20160603-1933.xml b/.metadata/.plugins/org.eclipse.m2e.logback.configuration/logback.1.7.0.20160603-1933.xml new file mode 100644 index 00000000..e33758c3 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.m2e.logback.configuration/logback.1.7.0.20160603-1933.xml @@ -0,0 +1,43 @@ + + + + %date [%thread] %-5level %logger{35} - %msg%n + + + OFF + + + + + ${org.eclipse.m2e.log.dir}/0.log + + ${org.eclipse.m2e.log.dir}/%i.log + 1 + 10 + + + 100MB + + + %date [%thread] %-5level %logger{35} - %msg%n + + + + + + WARN + + + + + + + + + + + + + + + diff --git a/.metadata/.plugins/org.eclipse.oomph.setup/workspace.setup b/.metadata/.plugins/org.eclipse.oomph.setup/workspace.setup new file mode 100644 index 00000000..1f73e14c --- /dev/null +++ b/.metadata/.plugins/org.eclipse.oomph.setup/workspace.setup @@ -0,0 +1,6 @@ + + diff --git a/.metadata/.plugins/org.eclipse.pde.core/.cache/clean-cache.properties b/.metadata/.plugins/org.eclipse.pde.core/.cache/clean-cache.properties new file mode 100644 index 00000000..dd72b1e8 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.pde.core/.cache/clean-cache.properties @@ -0,0 +1,2 @@ +#Cached timestamps +#Tue Apr 18 15:11:48 EDT 2017 diff --git a/.metadata/.plugins/org.eclipse.ui.editors/dialog_settings.xml b/.metadata/.plugins/org.eclipse.ui.editors/dialog_settings.xml new file mode 100644 index 00000000..50f1edb3 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.ui.editors/dialog_settings.xml @@ -0,0 +1,5 @@ + +
+
+
+
diff --git a/.metadata/.plugins/org.eclipse.ui.ide/dialog_settings.xml b/.metadata/.plugins/org.eclipse.ui.ide/dialog_settings.xml new file mode 100644 index 00000000..a1d3fb29 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.ui.ide/dialog_settings.xml @@ -0,0 +1,19 @@ + +
+ + + +
+ + + + + + + + + + + +
+
diff --git a/.metadata/.plugins/org.eclipse.ui.intro/dialog_settings.xml b/.metadata/.plugins/org.eclipse.ui.intro/dialog_settings.xml new file mode 100644 index 00000000..f118f021 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.ui.intro/dialog_settings.xml @@ -0,0 +1,4 @@ + +
+ +
diff --git a/.metadata/.plugins/org.eclipse.ui.intro/introstate b/.metadata/.plugins/org.eclipse.ui.intro/introstate new file mode 100644 index 00000000..236d56cb --- /dev/null +++ b/.metadata/.plugins/org.eclipse.ui.intro/introstate @@ -0,0 +1,2 @@ + + \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.ui.workbench/dialog_settings.xml b/.metadata/.plugins/org.eclipse.ui.workbench/dialog_settings.xml new file mode 100644 index 00000000..5593325b --- /dev/null +++ b/.metadata/.plugins/org.eclipse.ui.workbench/dialog_settings.xml @@ -0,0 +1,21 @@ + +
+
+ + + + + + + + + + +
+
+ + + + +
+
diff --git a/.metadata/.plugins/org.eclipse.ui.workbench/workingsets.xml b/.metadata/.plugins/org.eclipse.ui.workbench/workingsets.xml new file mode 100644 index 00000000..abbd39b4 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.ui.workbench/workingsets.xml @@ -0,0 +1,4 @@ + + + + \ No newline at end of file diff --git a/.metadata/.plugins/org.eclipse.wst.sse.core/task-tags.properties b/.metadata/.plugins/org.eclipse.wst.sse.core/task-tags.properties new file mode 100644 index 00000000..b1c3cdf1 --- /dev/null +++ b/.metadata/.plugins/org.eclipse.wst.sse.core/task-tags.properties @@ -0,0 +1,3 @@ +# +#Tue May 16 17:58:22 EDT 2017 +task-tag-projects-already-scanned=FreeCol diff --git a/.metadata/version.ini b/.metadata/version.ini new file mode 100644 index 00000000..eca44020 --- /dev/null +++ b/.metadata/version.ini @@ -0,0 +1,3 @@ +#Tue May 16 17:58:11 EDT 2017 +org.eclipse.core.runtime=2 +org.eclipse.platform=4.6.3.v20170301-0400 diff --git a/.project b/.project index 20c340d5..f8ff01d5 100644 --- a/.project +++ b/.project @@ -10,8 +10,14 @@ + + edu.umd.cs.findbugs.plugin.eclipse.findbugsBuilder + + + org.eclipse.jdt.core.javanature + edu.umd.cs.findbugs.plugin.eclipse.findbugsNature diff --git a/DefaultNumberRuleTest.java b/DefaultNumberRuleTest.java new file mode 100644 index 00000000..37a019dc --- /dev/null +++ b/DefaultNumberRuleTest.java @@ -0,0 +1,161 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class DefaultNumberRuleTest contains tests for the class {@link DefaultNumberRule}. + * + * @generatedBy CodePro at 5/15/17 8:35 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class DefaultNumberRuleTest { + /** + * Run the DefaultNumberRule() constructor test. + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testDefaultNumberRule_1() + throws Exception { + DefaultNumberRule result = new DefaultNumberRule(); + assertNotNull(result); + // add additional test code here + } + + /** + * Run the void addRule(Category,String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testAddRule_1() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + Number.Category number = Number.Category.two; + String input = "Test"; + + fixture.addRule(number, input); + + } + + /** + * Run the void addRule(Category,Rule) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testAddRule_2() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + Number.Category number = Number.Category.one; + Rule rule = new Rule("Test"); + + fixture.addRule(number, rule); + + + } + + /** + * Run the int countRules() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testCountRules_1() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + + int result = fixture.countRules(); + + // add additional test code here + assertEquals(0, result); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testGetCategory_1() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + double input = 1.0; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Run the Rule getRule(Category) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testGetRule_1() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + Number.Category category = Number.Category.few; + + Rule result = fixture.getRule(category); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(DefaultNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/DualNumberRuleTest.java b/DualNumberRuleTest.java new file mode 100644 index 00000000..95ba776b --- /dev/null +++ b/DualNumberRuleTest.java @@ -0,0 +1,118 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class DualNumberRuleTest contains tests for the class {@link DualNumberRule}. + * + * @generatedBy CodePro at 5/15/17 8:10 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class DualNumberRuleTest { + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Test + public void testGetCategory_1() + throws Exception { + DualNumberRule fixture = new DualNumberRule(); + double input = 1; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("one", result.name()); + assertEquals("one", result.toString()); + assertEquals(1, result.ordinal()); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Test + public void testGetCategory_2() + throws Exception { + DualNumberRule fixture = new DualNumberRule(); + double input = 2; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("two", result.name()); + assertEquals("two", result.toString()); + assertEquals(2, result.ordinal()); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Test + public void testGetCategory_3() + throws Exception { + DualNumberRule fixture = new DualNumberRule(); + double input = 5; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(DualNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/FreeCol.jar b/FreeCol.jar index ed0bb8bf..9edd8e2b 100644 Binary files a/FreeCol.jar and b/FreeCol.jar differ diff --git a/FreeColTest/.classpath b/FreeColTest/.classpath new file mode 100644 index 00000000..7c1519cd --- /dev/null +++ b/FreeColTest/.classpath @@ -0,0 +1,15 @@ + + + + + + + + + + + + + + + diff --git a/FreeColTest/.project b/FreeColTest/.project new file mode 100644 index 00000000..f2d575d2 --- /dev/null +++ b/FreeColTest/.project @@ -0,0 +1,17 @@ + + + FreeColTest + + + + + + org.eclipse.jdt.core.javabuilder + + + + + + org.eclipse.jdt.core.javanature + + diff --git a/FreeColTest/.settings/org.eclipse.jdt.core.prefs b/FreeColTest/.settings/org.eclipse.jdt.core.prefs new file mode 100644 index 00000000..88790ff4 --- /dev/null +++ b/FreeColTest/.settings/org.eclipse.jdt.core.prefs @@ -0,0 +1,3 @@ +eclipse.preferences.version=1 +org.eclipse.jdt.core.compiler.compliance=1.8 +org.eclipse.jdt.core.compiler.source=1.8 diff --git a/FreeColTest/bin/net/sf/freecol/common/TestAll.class b/FreeColTest/bin/net/sf/freecol/common/TestAll.class new file mode 100644 index 00000000..9977fa69 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/TestAll.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/DefaultNumberRuleTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/DefaultNumberRuleTest.class new file mode 100644 index 00000000..8885ce57 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/DefaultNumberRuleTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/DualNumberRuleTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/DualNumberRuleTest.class new file mode 100644 index 00000000..9ab42334 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/DualNumberRuleTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/NameCacheTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/NameCacheTest.class new file mode 100644 index 00000000..59945c48 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/NameCacheTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/NumberRulesTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/NumberRulesTest.class new file mode 100644 index 00000000..1ca137a4 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/NumberRulesTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/NumberTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/NumberTest.class new file mode 100644 index 00000000..1fbab9de Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/NumberTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/OtherNumberRuleTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/OtherNumberRuleTest.class new file mode 100644 index 00000000..81f99961 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/OtherNumberRuleTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/PluralNumberRuleTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/PluralNumberRuleTest.class new file mode 100644 index 00000000..eb61028c Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/PluralNumberRuleTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/RelationTest.class b/FreeColTest/bin/net/sf/freecol/common/i18n/RelationTest.class new file mode 100644 index 00000000..97dd5d13 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/RelationTest.class differ diff --git a/FreeColTest/bin/net/sf/freecol/common/i18n/TestAll.class b/FreeColTest/bin/net/sf/freecol/common/i18n/TestAll.class new file mode 100644 index 00000000..13d3e415 Binary files /dev/null and b/FreeColTest/bin/net/sf/freecol/common/i18n/TestAll.class differ diff --git a/FreeColTest/src/net/sf/freecol/common/TestAll.java b/FreeColTest/src/net/sf/freecol/common/TestAll.java new file mode 100644 index 00000000..50072795 --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/TestAll.java @@ -0,0 +1,32 @@ +package net.sf.freecol.common; + +import org.junit.runner.JUnitCore; +import org.junit.runner.RunWith; +import org.junit.runners.Suite; + +/** + * The class TestAll builds a suite that can be used to run all + * of the tests within its package as well as within any subpackages of its + * package. + * + * @generatedBy CodePro at 5/15/17 8:35 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +@RunWith(Suite.class) +@Suite.SuiteClasses({ + net.sf.freecol.common.i18n.TestAll.class, +}) +public class TestAll { + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + public static void main(String[] args) { + JUnitCore.runClasses(new Class[] { TestAll.class }); + } +} diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/DefaultNumberRuleTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/DefaultNumberRuleTest.java new file mode 100644 index 00000000..7c68322d --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/DefaultNumberRuleTest.java @@ -0,0 +1,126 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class DefaultNumberRuleTest contains tests for the class {@link DefaultNumberRule}. + * + * @generatedBy CodePro at 5/15/17 8:35 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class DefaultNumberRuleTest { + /** + * Run the DefaultNumberRule() constructor test. + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testDefaultNumberRule_1() + throws Exception { + DefaultNumberRule result = new DefaultNumberRule(); + assertNotNull(result); + // add additional test code here + } + + + + /** + * Run the int countRules() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testCountRules_1() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + + int result = fixture.countRules(); + + // add additional test code here + assertEquals(0, result); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testGetCategory_1() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + double input = 1.0; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Run the Rule getRule(Category) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Test + public void testGetRule_1() + throws Exception { + DefaultNumberRule fixture = new DefaultNumberRule(); + Number.Category category = Number.Category.few; + + Rule result = fixture.getRule(category); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 8:35 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(DefaultNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/DualNumberRuleTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/DualNumberRuleTest.java new file mode 100644 index 00000000..95ba776b --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/DualNumberRuleTest.java @@ -0,0 +1,118 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class DualNumberRuleTest contains tests for the class {@link DualNumberRule}. + * + * @generatedBy CodePro at 5/15/17 8:10 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class DualNumberRuleTest { + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Test + public void testGetCategory_1() + throws Exception { + DualNumberRule fixture = new DualNumberRule(); + double input = 1; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("one", result.name()); + assertEquals("one", result.toString()); + assertEquals(1, result.ordinal()); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Test + public void testGetCategory_2() + throws Exception { + DualNumberRule fixture = new DualNumberRule(); + double input = 2; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("two", result.name()); + assertEquals("two", result.toString()); + assertEquals(2, result.ordinal()); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Test + public void testGetCategory_3() + throws Exception { + DualNumberRule fixture = new DualNumberRule(); + double input = 5; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 8:10 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(DualNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/NameCacheTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/NameCacheTest.java new file mode 100644 index 00000000..5b79b987 --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/NameCacheTest.java @@ -0,0 +1,399 @@ +package net.sf.freecol.common.i18n; + +import java.util.List; +import java.util.Random; +import javax.imageio.metadata.IIOMetadataNode; +import net.sf.freecol.common.model.Specification; +import org.junit.*; +import net.sf.freecol.common.model.Game; +import net.sf.freecol.common.FreeColSeed; +import net.sf.freecol.common.ServerInfo; +import net.sf.freecol.common.model.Colony; +import net.sf.freecol.common.model.Settlement; +import net.sf.freecol.common.model.UnitType; +import static org.junit.Assert.*; +import org.w3c.dom.Element; +import net.sf.freecol.common.model.Player; +import net.sf.freecol.common.model.Region; + +/** + * The class NameCacheTest contains tests for the class {@link NameCache}. + * + * @generatedBy CodePro at 5/15/17 9:03 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class NameCacheTest { + /** + * Run the NameCache() constructor test. + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testNameCache_1() + throws Exception { + NameCache result = new NameCache(); + assertNotNull(result); + // add additional test code here + } + + /** + * Run the void addCityOfCibola(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testAddCityOfCibola_1() + throws Exception { + String key = "Test"; + + NameCache.addCityOfCibola(key); + + // add additional test code here + } + + /** + * Run the void addCityOfCibola(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testAddCityOfCibola_2() + throws Exception { + String key = "Test"; + + NameCache.addCityOfCibola(key); + + // add additional test code here + } + + /** + * Run the void clearCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testClearCitiesOfCibola_1() + throws Exception { + + NameCache.clearCitiesOfCibola(); + + // add additional test code here + } + + /** + * Run the void clearCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testClearCitiesOfCibola_2() + throws Exception { + + NameCache.clearCitiesOfCibola(); + + // add additional test code here + } + + + /** + * Run the List getCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetCitiesOfCibola_1() + throws Exception { + + List result = NameCache.getCitiesOfCibola(); + + // add additional test code here + assertNotNull(result); + assertEquals(0, result.size()); + } + + /** + * Run the List getCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetCitiesOfCibola_2() + throws Exception { + + List result = NameCache.getCitiesOfCibola(); + + // add additional test code here + assertNotNull(result); + assertEquals(0, result.size()); + } + + + + + + + + /** + * Run the String getNextCityOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetNextCityOfCibola_1() + throws Exception { + + String result = NameCache.getNextCityOfCibola(); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Run the String getNextCityOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetNextCityOfCibola_2() + throws Exception { + + String result = NameCache.getNextCityOfCibola(); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Run the String getNextCityOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetNextCityOfCibola_3() + throws Exception { + + String result = NameCache.getNextCityOfCibola(); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Run the String getSeasonName(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetSeasonName_1() + throws Exception { + int index = -1; + + String result = NameCache.getSeasonName(index); + + // add additional test code here + assertEquals("", result); + } + + /** + * Run the String getSeasonName(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetSeasonName_2() + throws Exception { + int index = 1; + + String result = NameCache.getSeasonName(index); + + // add additional test code here + assertEquals("model.season.autumn.name", result); + } + + + + + + /** + * Run the void requireCitiesOfCibola(Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testRequireCitiesOfCibola_1() + throws Exception { + Random random = new Random(); + + NameCache.requireCitiesOfCibola(random); + + // add additional test code here + } + + /** + * Run the void requireCitiesOfCibola(Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testRequireCitiesOfCibola_2() + throws Exception { + Random random = new Random(); + + NameCache.requireCitiesOfCibola(random); + + // add additional test code here + } + + /** + * Run the void requireCitiesOfCibola(Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testRequireCitiesOfCibola_3() + throws Exception { + Random random = new Random(); + + NameCache.requireCitiesOfCibola(random); + + // add additional test code here + } + + public void testFreeColSeed_1() + throws Exception { + FreeColSeed result = new FreeColSeed(); + assertNotNull(result); + // add additional test code here + } + + + + public void testGetFreeColSeed_1() + throws Exception { + boolean generate = true; + + long result = FreeColSeed.getFreeColSeed(generate); + + + assertNotNull(result); + } + + public void testServerInfo_1() + throws Exception { + + ServerInfo result = new ServerInfo(); + + // add additional test code here + assertNotNull(result); + assertEquals("null(null:0) 0, 0, false, null, 0", result.toString()); + assertEquals(null, result.getAddress()); + assertEquals(null, result.getName()); + assertEquals(0, result.getPort()); + assertEquals(null, result.getVersion()); + assertEquals(0, result.getGameState()); + assertEquals(0, result.getSlotsAvailable()); + assertEquals(0, result.getCurrentlyPlaying()); + } + + public void testGetAddress_1() + throws Exception { + ServerInfo fixture = new ServerInfo(); + fixture.update("", "", 1, 1, 1, true, "", 1); + + String result = fixture.getAddress(); + + + assertEquals("", result); + } + + public void testGetCurrentlyPlaying_1() + throws Exception { + ServerInfo fixture = new ServerInfo(); + fixture.update("", "", 1, 1, 1, true, "", 1); + + int result = fixture.getCurrentlyPlaying(); + + // add additional test code here + assertEquals(1, result); + } + + public void testGetCurrentlyPlaying_2() + throws Exception { + ServerInfo fixture = new ServerInfo(); + fixture.update("", "", 1, 1, 1, true, "", 1); + + String result = ServerInfo.getXMLElementTagName(); + + + // add additional test code here + assertNotNull(result); + } + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Before + public void setUp() + throws Exception { + + } + + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(NameCacheTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/NumberRulesTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/NumberRulesTest.java new file mode 100644 index 00000000..57f4055e --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/NumberRulesTest.java @@ -0,0 +1,127 @@ +package net.sf.freecol.common.i18n; + +import java.io.InputStream; +import java.io.PipedInputStream; +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class NumberRulesTest contains tests for the class {@link NumberRules}. + * + * @generatedBy CodePro at 5/15/17 11:45 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class NumberRulesTest { + + + /** + * Run the Number getNumberForLanguage(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testGetNumberForLanguage_1() + throws Exception { + String lang = "Test"; + + Number result = NumberRules.getNumberForLanguage(lang); + + // add additional test code here + assertNotNull(result); + } + + /** + * Run the Number getNumberForLanguage(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testGetNumberForLanguage_2() + throws Exception { + String lang = ""; + + Number result = NumberRules.getNumberForLanguage(lang); + + // add additional test code here + assertNotNull(result); + } + + /** + * Run the boolean isInitialized() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testIsInitialized_1() + throws Exception { + + boolean result = NumberRules.isInitialized(); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the boolean isInitialized() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testIsInitialized_2() + throws Exception { + + boolean result = NumberRules.isInitialized(); + + // add additional test code here + assertEquals(false, result); + } + + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(NumberRulesTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/NumberTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/NumberTest.java new file mode 100644 index 00000000..df374913 --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/NumberTest.java @@ -0,0 +1,111 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class NumberTest contains tests for the class {@link Number}. + * + * @generatedBy CodePro at 5/15/17 10:02 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class NumberTest { + /** + * Run the String getKey(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Test + public void testGetKey_1() + throws Exception { + Number fixture = new DefaultNumberRule(); + double selector = 1.0; + + String result = fixture.getKey(selector); + + // add additional test code here + assertEquals("other", result); + } + + /** + * Run the String getKey(String,String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Test + public void testGetKey_2() + throws Exception { + Number fixture = new DefaultNumberRule(); + String selector = ""; + String template = ""; + + String result = fixture.getKey(selector, template); + + // add additional test code here + assertEquals("other", result); + } + + /** + * Run the String getKey(String,String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Test + public void testGetKey_3() + throws Exception { + Number fixture = new DefaultNumberRule(); + String selector = ""; + String template = ""; + + String result = fixture.getKey(selector, template); + + // add additional test code here + assertEquals("other", result); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(NumberTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/OtherNumberRuleTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/OtherNumberRuleTest.java new file mode 100644 index 00000000..732fcef6 --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/OtherNumberRuleTest.java @@ -0,0 +1,74 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class OtherNumberRuleTest contains tests for the class {@link OtherNumberRule}. + * + * @generatedBy CodePro at 5/15/17 12:16 PM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class OtherNumberRuleTest { + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + @Test + public void testGetCategory_1() + throws Exception { + OtherNumberRule fixture = new OtherNumberRule(); + double input = 1.0; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(OtherNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/PluralNumberRuleTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/PluralNumberRuleTest.java new file mode 100644 index 00000000..721b55c0 --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/PluralNumberRuleTest.java @@ -0,0 +1,96 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class PluralNumberRuleTest contains tests for the class {@link PluralNumberRule}. + * + * @generatedBy CodePro at 5/15/17 6:39 PM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class PluralNumberRuleTest { + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @Test + public void testGetCategory_1() + throws Exception { + PluralNumberRule fixture = new PluralNumberRule(); + double input = 1; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("one", result.name()); + assertEquals("one", result.toString()); + assertEquals(1, result.ordinal()); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @Test + public void testGetCategory_2() + throws Exception { + PluralNumberRule fixture = new PluralNumberRule(); + double input = 2; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(PluralNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/RelationTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/RelationTest.java new file mode 100644 index 00000000..88c2e20e --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/RelationTest.java @@ -0,0 +1,267 @@ +package net.sf.freecol.common.i18n; + +import java.util.LinkedList; +import java.util.List; +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class RelationTest contains tests for the class {@link Relation}. + * + * @generatedBy CodePro at 5/15/17 6:41 PM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class RelationTest { + + + /** + * Run the Relation(int,int) constructor test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testRelation_2() + throws Exception { + int low = 1; + int high = 1; + + Relation result = new Relation(low, high); + + // add additional test code here + assertNotNull(result); + assertEquals("n is 1", result.toString()); + } + + /** + * Run the boolean matches(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testMatches_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + double number = 1.0; + + boolean result = fixture.matches(number); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the boolean matches(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testMatches_2() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(false); + fixture.setMod(2); + double number = 1.0; + + boolean result = fixture.matches(number); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the void setInteger(boolean) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testSetInteger_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + boolean value = true; + + fixture.setInteger(value); + + // add additional test code here + } + + /** + * Run the void setMod(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testSetMod_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + int mod = 1; + + fixture.setMod(mod); + + // add additional test code here + } + + /** + * Run the void setNegated(boolean) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testSetNegated_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + boolean value = true; + + fixture.setNegated(value); + + // add additional test code here + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(false); + fixture.setMod(1); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n is not 1", result); + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_2() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(false); + fixture.setInteger(true); + fixture.setMod(1); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n is 1", result); + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_3() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(2); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n mod 2 is not 1", result); + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_4() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(false); + fixture.setInteger(true); + fixture.setMod(2); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n mod 2 is 1", result); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(RelationTest.class); + } +} \ No newline at end of file diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/TestAll.java b/FreeColTest/src/net/sf/freecol/common/i18n/TestAll.java new file mode 100644 index 00000000..7fb7c523 --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/TestAll.java @@ -0,0 +1,39 @@ +package net.sf.freecol.common.i18n; + +import org.junit.runner.JUnitCore; +import org.junit.runner.RunWith; +import org.junit.runners.Suite; + +/** + * The class TestAll builds a suite that can be used to run all + * of the tests within its package as well as within any subpackages of its + * package. + * + * @generatedBy CodePro at 5/15/17 6:48 PM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +@RunWith(Suite.class) +@Suite.SuiteClasses({ + PluralNumberRuleTest.class, + DefaultNumberRuleTest.class, + NumberTest.class, + DualNumberRuleTest.class, + NameCacheTest.class, + OtherNumberRuleTest.class, + NumberRulesTest.class, + RelationTest.class, +}) +public class TestAll { + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 6:48 PM + */ + public static void main(String[] args) { + JUnitCore.runClasses(new Class[] { TestAll.class }); + } +} diff --git a/FreeColTest/src/net/sf/freecol/common/i18n/cldrTest.java b/FreeColTest/src/net/sf/freecol/common/i18n/cldrTest.java new file mode 100644 index 00000000..8b137891 --- /dev/null +++ b/FreeColTest/src/net/sf/freecol/common/i18n/cldrTest.java @@ -0,0 +1 @@ + diff --git a/NameCacheTest.java b/NameCacheTest.java new file mode 100644 index 00000000..54c12166 --- /dev/null +++ b/NameCacheTest.java @@ -0,0 +1,818 @@ +package net.sf.freecol.common.i18n; + +import java.util.List; +import java.util.Random; +import javax.imageio.metadata.IIOMetadataNode; +import net.sf.freecol.common.model.Specification; +import org.junit.*; +import net.sf.freecol.common.model.Game; +import net.sf.freecol.common.model.Colony; +import net.sf.freecol.common.model.Settlement; +import net.sf.freecol.common.model.UnitType; +import static org.junit.Assert.*; +import org.w3c.dom.Element; +import net.sf.freecol.common.model.Player; +import net.sf.freecol.common.model.Region; + +/** + * The class NameCacheTest contains tests for the class {@link NameCache}. + * + * @generatedBy CodePro at 5/15/17 9:03 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class NameCacheTest { + /** + * Run the NameCache() constructor test. + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testNameCache_1() + throws Exception { + NameCache result = new NameCache(); + assertNotNull(result); + // add additional test code here + } + + /** + * Run the void addCityOfCibola(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testAddCityOfCibola_1() + throws Exception { + String key = "Test"; + + NameCache.addCityOfCibola(key); + + // add additional test code here + } + + /** + * Run the void addCityOfCibola(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testAddCityOfCibola_2() + throws Exception { + String key = "Test"; + + NameCache.addCityOfCibola(key); + + // add additional test code here + } + + /** + * Run the void clearCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testClearCitiesOfCibola_1() + throws Exception { + + NameCache.clearCitiesOfCibola(); + + // add additional test code here + } + + /** + * Run the void clearCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testClearCitiesOfCibola_2() + throws Exception { + + NameCache.clearCitiesOfCibola(); + + // add additional test code here + } + + /** + * Run the String getCapitalName(Player,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetCapitalName_1() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), "Test"), new IIOMetadataNode()); + Random random = new Random(); + + String result = NameCache.getCapitalName(player, random); + + assertNotNull(result); + } + + /** + * Run the List getCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetCitiesOfCibola_1() + throws Exception { + + List result = NameCache.getCitiesOfCibola(); + + // add additional test code here + assertNotNull(result); + assertEquals(0, result.size()); + } + + /** + * Run the List getCitiesOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetCitiesOfCibola_2() + throws Exception { + + List result = NameCache.getCitiesOfCibola(); + + // add additional test code here + assertNotNull(result); + assertEquals(0, result.size()); + } + + /** + * Run the int getMercenaryLeaderIndex(Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetMercenaryLeaderIndex_1() + throws Exception { + Random random = new Random(); + + int result = NameCache.getMercenaryLeaderIndex(random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.IllegalArgumentException: bound must be positive + // at java.util.Random.nextInt(Random.java:388) + // at net.sf.freecol.common.util.RandomUtils.randomInt(RandomUtils.java:46) + // at net.sf.freecol.common.i18n.NameCache.getMercenaryLeaderIndex(NameCache.java:355) + assertEquals(1, result); + } + + /** + * Run the String getMercenaryLeaderName(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetMercenaryLeaderName_1() + throws Exception { + int index = 1; + + String result = NameCache.getMercenaryLeaderName(index); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.IndexOutOfBoundsException: Index: 1, Size: 0 + // at java.util.ArrayList.rangeCheck(ArrayList.java:653) + // at java.util.ArrayList.get(ArrayList.java:429) + // at net.sf.freecol.common.i18n.NameCache.getMercenaryLeaderName(NameCache.java:367) + assertNotNull(result); + } + + /** + * Run the String getNewLandName(Player) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetNewLandName_1() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + player.setNewLandName((String) null); + + String result = NameCache.getNewLandName(player); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getNextCityOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetNextCityOfCibola_1() + throws Exception { + + String result = NameCache.getNextCityOfCibola(); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Run the String getNextCityOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetNextCityOfCibola_2() + throws Exception { + + String result = NameCache.getNextCityOfCibola(); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Run the String getNextCityOfCibola() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetNextCityOfCibola_3() + throws Exception { + + String result = NameCache.getNextCityOfCibola(); + + // add additional test code here + assertEquals(null, result); + } + + /** + * Run the String getRegionName(Player,Region) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetRegionName_1() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + Region region = new Region(new Game(new IIOMetadataNode(), "")); + + String result = NameCache.getRegionName(player, region); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getRegionName(Player,Region) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetRegionName_2() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + Region region = new Region(new Game(new IIOMetadataNode(), "")); + + String result = NameCache.getRegionName(player, region); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getRegionName(Player,Region) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetRegionName_3() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + Region region = new Region(new Game(new IIOMetadataNode(), "")); + + String result = NameCache.getRegionName(player, region); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getRegionName(Player,Region) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetRegionName_4() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + Region region = new Region(new Game(new IIOMetadataNode(), "")); + + String result = NameCache.getRegionName(player, region); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getRegionName(Player,Region) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetRegionName_5() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + Region region = new Region(new Game(new IIOMetadataNode(), "")); + + String result = NameCache.getRegionName(player, region); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getRegionName(Player,Region) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetRegionName_6() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + Region region = new Region(new Game(new IIOMetadataNode(), "")); + + String result = NameCache.getRegionName(player, region); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getSeasonName(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetSeasonName_1() + throws Exception { + int index = -1; + + String result = NameCache.getSeasonName(index); + + // add additional test code here + assertEquals("", result); + } + + /** + * Run the String getSeasonName(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetSeasonName_2() + throws Exception { + int index = 1; + + String result = NameCache.getSeasonName(index); + + // add additional test code here + assertEquals("model.season.autumn.name", result); + } + + /** + * Run the String getSettlementName(Player,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetSettlementName_1() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + Random random = new Random(); + + String result = NameCache.getSettlementName(player, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getSettlementName(Player,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetSettlementName_2() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + player.addSettlement(new Colony(new Game(new IIOMetadataNode(), ""), "")); + Random random = new Random(); + + String result = NameCache.getSettlementName(player, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getSettlementName(Player,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetSettlementName_3() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + player.addSettlement(new Colony(new Game(new IIOMetadataNode(), ""), "")); + Random random = new Random(); + + String result = NameCache.getSettlementName(player, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getTradeRouteName(Player) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetTradeRouteName_1() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + + String result = NameCache.getTradeRouteName(player); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getTradeRouteName(Player) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetTradeRouteName_2() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + + String result = NameCache.getTradeRouteName(player); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getTradeRouteName(Player) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetTradeRouteName_3() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + + String result = NameCache.getTradeRouteName(player); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getUnitName(Player,UnitType,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetUnitName_1() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + UnitType type = new UnitType("", new Specification()); + Random random = new Random(); + + String result = NameCache.getUnitName(player, type, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getUnitName(Player,UnitType,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetUnitName_2() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + UnitType type = new UnitType("", new Specification()); + Random random = new Random(); + + String result = NameCache.getUnitName(player, type, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getUnitName(Player,UnitType,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetUnitName_3() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + UnitType type = new UnitType("", new Specification()); + Random random = new Random(); + + String result = NameCache.getUnitName(player, type, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the String getUnitName(Player,UnitType,Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testGetUnitName_4() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + UnitType type = new UnitType("", new Specification()); + Random random = new Random(); + + String result = NameCache.getUnitName(player, type, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the void putSettlementName(Player,String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testPutSettlementName_1() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), ""), new IIOMetadataNode()); + String name = ""; + + NameCache.putSettlementName(player, name); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + } + + /** + * Run the void putSettlementName(Player,String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testPutSettlementName_2() + throws Exception { + Player player = new Player(new Game(new IIOMetadataNode(), "Test"), new IIOMetadataNode()); + String name = "Test"; + + NameCache.putSettlementName(player, name); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + } + + /** + * Run the void requireCitiesOfCibola(Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testRequireCitiesOfCibola_1() + throws Exception { + Random random = new Random(); + + NameCache.requireCitiesOfCibola(random); + + // add additional test code here + } + + /** + * Run the void requireCitiesOfCibola(Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testRequireCitiesOfCibola_2() + throws Exception { + Random random = new Random(); + + NameCache.requireCitiesOfCibola(random); + + // add additional test code here + } + + /** + * Run the void requireCitiesOfCibola(Random) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Test + public void testRequireCitiesOfCibola_3() + throws Exception { + Random random = new Random(); + + NameCache.requireCitiesOfCibola(random); + + // add additional test code here + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 9:03 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(NameCacheTest.class); + } +} \ No newline at end of file diff --git a/NumberRulesTest copy.java b/NumberRulesTest copy.java new file mode 100644 index 00000000..8ce51f94 --- /dev/null +++ b/NumberRulesTest copy.java @@ -0,0 +1,157 @@ +package net.sf.freecol.common.i18n; + +import java.io.InputStream; +import java.io.PipedInputStream; +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class NumberRulesTest contains tests for the class {@link NumberRules}. + * + * @generatedBy CodePro at 5/15/17 11:45 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class NumberRulesTest { + /** + * Run the NumberRules(InputStream) constructor test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testNumberRules_1() + throws Exception { + InputStream in = new PipedInputStream(); + + NumberRules result = new NumberRules(in); + assertNotNull(result); + } + + /** + * Run the Number getNumberForLanguage(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testGetNumberForLanguage_1() + throws Exception { + String lang = "Test"; + + Number result = NumberRules.getNumberForLanguage(lang); + + // add additional test code here + assertNotNull(result); + } + + /** + * Run the Number getNumberForLanguage(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testGetNumberForLanguage_2() + throws Exception { + String lang = ""; + + Number result = NumberRules.getNumberForLanguage(lang); + + // add additional test code here + assertNotNull(result); + } + + /** + * Run the boolean isInitialized() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testIsInitialized_1() + throws Exception { + + boolean result = NumberRules.isInitialized(); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the boolean isInitialized() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testIsInitialized_2() + throws Exception { + + boolean result = NumberRules.isInitialized(); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the void load(InputStream) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testLoad_1() + throws Exception { + InputStream in = new PipedInputStream(); + + NumberRules.load(in); + + + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(NumberRulesTest.class); + } +} \ No newline at end of file diff --git a/NumberRulesTest.java b/NumberRulesTest.java new file mode 100644 index 00000000..8ce51f94 --- /dev/null +++ b/NumberRulesTest.java @@ -0,0 +1,157 @@ +package net.sf.freecol.common.i18n; + +import java.io.InputStream; +import java.io.PipedInputStream; +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class NumberRulesTest contains tests for the class {@link NumberRules}. + * + * @generatedBy CodePro at 5/15/17 11:45 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class NumberRulesTest { + /** + * Run the NumberRules(InputStream) constructor test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testNumberRules_1() + throws Exception { + InputStream in = new PipedInputStream(); + + NumberRules result = new NumberRules(in); + assertNotNull(result); + } + + /** + * Run the Number getNumberForLanguage(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testGetNumberForLanguage_1() + throws Exception { + String lang = "Test"; + + Number result = NumberRules.getNumberForLanguage(lang); + + // add additional test code here + assertNotNull(result); + } + + /** + * Run the Number getNumberForLanguage(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testGetNumberForLanguage_2() + throws Exception { + String lang = ""; + + Number result = NumberRules.getNumberForLanguage(lang); + + // add additional test code here + assertNotNull(result); + } + + /** + * Run the boolean isInitialized() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testIsInitialized_1() + throws Exception { + + boolean result = NumberRules.isInitialized(); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the boolean isInitialized() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testIsInitialized_2() + throws Exception { + + boolean result = NumberRules.isInitialized(); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the void load(InputStream) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Test + public void testLoad_1() + throws Exception { + InputStream in = new PipedInputStream(); + + NumberRules.load(in); + + + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 11:45 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(NumberRulesTest.class); + } +} \ No newline at end of file diff --git a/NumberTest.java b/NumberTest.java new file mode 100644 index 00000000..df374913 --- /dev/null +++ b/NumberTest.java @@ -0,0 +1,111 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class NumberTest contains tests for the class {@link Number}. + * + * @generatedBy CodePro at 5/15/17 10:02 AM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class NumberTest { + /** + * Run the String getKey(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Test + public void testGetKey_1() + throws Exception { + Number fixture = new DefaultNumberRule(); + double selector = 1.0; + + String result = fixture.getKey(selector); + + // add additional test code here + assertEquals("other", result); + } + + /** + * Run the String getKey(String,String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Test + public void testGetKey_2() + throws Exception { + Number fixture = new DefaultNumberRule(); + String selector = ""; + String template = ""; + + String result = fixture.getKey(selector, template); + + // add additional test code here + assertEquals("other", result); + } + + /** + * Run the String getKey(String,String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Test + public void testGetKey_3() + throws Exception { + Number fixture = new DefaultNumberRule(); + String selector = ""; + String template = ""; + + String result = fixture.getKey(selector, template); + + // add additional test code here + assertEquals("other", result); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 10:02 AM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(NumberTest.class); + } +} \ No newline at end of file diff --git a/OtherNumberRuleTest.java b/OtherNumberRuleTest.java new file mode 100644 index 00000000..732fcef6 --- /dev/null +++ b/OtherNumberRuleTest.java @@ -0,0 +1,74 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class OtherNumberRuleTest contains tests for the class {@link OtherNumberRule}. + * + * @generatedBy CodePro at 5/15/17 12:16 PM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class OtherNumberRuleTest { + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + @Test + public void testGetCategory_1() + throws Exception { + OtherNumberRule fixture = new OtherNumberRule(); + double input = 1.0; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 12:16 PM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(OtherNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/PluralNumberRuleTest.java b/PluralNumberRuleTest.java new file mode 100644 index 00000000..721b55c0 --- /dev/null +++ b/PluralNumberRuleTest.java @@ -0,0 +1,96 @@ +package net.sf.freecol.common.i18n; + +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class PluralNumberRuleTest contains tests for the class {@link PluralNumberRule}. + * + * @generatedBy CodePro at 5/15/17 6:39 PM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class PluralNumberRuleTest { + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @Test + public void testGetCategory_1() + throws Exception { + PluralNumberRule fixture = new PluralNumberRule(); + double input = 1; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("one", result.name()); + assertEquals("one", result.toString()); + assertEquals(1, result.ordinal()); + } + + /** + * Run the Number.Category getCategory(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @Test + public void testGetCategory_2() + throws Exception { + PluralNumberRule fixture = new PluralNumberRule(); + double input = 2; + + Number.Category result = fixture.getCategory(input); + + // add additional test code here + assertNotNull(result); + assertEquals("other", result.name()); + assertEquals("other", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 6:39 PM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(PluralNumberRuleTest.class); + } +} \ No newline at end of file diff --git a/RelationTest.java b/RelationTest.java new file mode 100644 index 00000000..7833efe3 --- /dev/null +++ b/RelationTest.java @@ -0,0 +1,283 @@ +package net.sf.freecol.common.i18n; + +import java.util.LinkedList; +import java.util.List; +import org.junit.*; +import static org.junit.Assert.*; + +/** + * The class RelationTest contains tests for the class {@link Relation}. + * + * @generatedBy CodePro at 5/15/17 6:41 PM + * @author michaeldavies + * @version $Revision: 1.0 $ + */ +public class RelationTest { + /** + * Run the Relation(List) constructor test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testRelation_1() + throws Exception { + LinkedList tokens = new LinkedList(); + + Relation result = new Relation(tokens); + + + assertNotNull(result); + } + + /** + * Run the Relation(int,int) constructor test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testRelation_2() + throws Exception { + int low = 1; + int high = 1; + + Relation result = new Relation(low, high); + + // add additional test code here + assertNotNull(result); + assertEquals("n is 1", result.toString()); + } + + /** + * Run the boolean matches(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testMatches_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + double number = 1.0; + + boolean result = fixture.matches(number); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the boolean matches(double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testMatches_2() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(false); + fixture.setMod(2); + double number = 1.0; + + boolean result = fixture.matches(number); + + // add additional test code here + assertEquals(false, result); + } + + /** + * Run the void setInteger(boolean) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testSetInteger_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + boolean value = true; + + fixture.setInteger(value); + + // add additional test code here + } + + /** + * Run the void setMod(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testSetMod_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + int mod = 1; + + fixture.setMod(mod); + + // add additional test code here + } + + /** + * Run the void setNegated(boolean) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testSetNegated_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(1); + boolean value = true; + + fixture.setNegated(value); + + // add additional test code here + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_1() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(false); + fixture.setMod(1); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n is not 1", result); + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_2() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(false); + fixture.setInteger(true); + fixture.setMod(1); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n is 1", result); + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_3() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(true); + fixture.setInteger(true); + fixture.setMod(2); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n mod 2 is not 1", result); + } + + /** + * Run the String toString() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Test + public void testToString_4() + throws Exception { + Relation fixture = new Relation(1, 1); + fixture.setNegated(false); + fixture.setInteger(true); + fixture.setMod(2); + + String result = fixture.toString(); + + // add additional test code here + assertEquals("n mod 2 is 1", result); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/15/17 6:41 PM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(RelationTest.class); + } +} \ No newline at end of file diff --git a/_config.yml b/_config.yml new file mode 100644 index 00000000..c7418817 --- /dev/null +++ b/_config.yml @@ -0,0 +1 @@ +theme: jekyll-theme-slate \ No newline at end of file diff --git a/bin/.gitignore b/bin/.gitignore new file mode 100644 index 00000000..57e0e36f --- /dev/null +++ b/bin/.gitignore @@ -0,0 +1,2 @@ +/MANIFEST.MF +/net/ diff --git a/bin/MANIFEST.MF b/bin/MANIFEST.MF new file mode 100644 index 00000000..0aa7793b --- /dev/null +++ b/bin/MANIFEST.MF @@ -0,0 +1,12 @@ +Manifest-Version: 1.0 +Ant-Version: Apache Ant 1.9.6 +Created-By: FreeCol Team +Main-Class: net.sf.freecol.FreeCol +Product-Name: FreeCol +Package-Title: FreeCol +Package-Version: ${FreeCol.Revision} +Package-Vendor: FreeCol Team +Class-Path: jars/miglayout-swing-4.2.jar jars/miglayout-core-4.2.jar j + ars/commons-cli-1.1.jar jars/cortado-0.6.0.jar jars/jogg-0.0.17.jar j + ars/jorbis-0.0.17.jar + diff --git a/bin/net/sf/freecol/client/control/ConnectController.class b/bin/net/sf/freecol/client/control/ConnectController.class index aa191f2d..8074f5ba 100644 Binary files a/bin/net/sf/freecol/client/control/ConnectController.class and b/bin/net/sf/freecol/client/control/ConnectController.class differ diff --git a/bin/net/sf/freecol/client/control/InGameController.class b/bin/net/sf/freecol/client/control/InGameController.class index b5af7c8d..b6954b27 100644 Binary files a/bin/net/sf/freecol/client/control/InGameController.class and b/bin/net/sf/freecol/client/control/InGameController.class differ diff --git a/bin/net/sf/freecol/client/control/InGameInputHandler.class b/bin/net/sf/freecol/client/control/InGameInputHandler.class index 8b212d58..8db707c8 100644 Binary files a/bin/net/sf/freecol/client/control/InGameInputHandler.class and b/bin/net/sf/freecol/client/control/InGameInputHandler.class differ diff --git a/bin/net/sf/freecol/client/control/InputHandler.class b/bin/net/sf/freecol/client/control/InputHandler.class index ba067c65..593122b6 100644 Binary files a/bin/net/sf/freecol/client/control/InputHandler.class and b/bin/net/sf/freecol/client/control/InputHandler.class differ diff --git a/bin/net/sf/freecol/client/control/MapEditorController$1.class b/bin/net/sf/freecol/client/control/MapEditorController$1.class index 6960ee7d..279d2270 100644 Binary files a/bin/net/sf/freecol/client/control/MapEditorController$1.class and b/bin/net/sf/freecol/client/control/MapEditorController$1.class differ diff --git a/bin/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class b/bin/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class index 64b695d3..bace0f34 100644 Binary files a/bin/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class and b/bin/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class differ diff --git a/bin/net/sf/freecol/client/control/MapEditorController.class b/bin/net/sf/freecol/client/control/MapEditorController.class index 68f18c94..fe5bd37c 100644 Binary files a/bin/net/sf/freecol/client/control/MapEditorController.class and b/bin/net/sf/freecol/client/control/MapEditorController.class differ diff --git a/bin/net/sf/freecol/client/control/PreGameController.class b/bin/net/sf/freecol/client/control/PreGameController.class index 99aff99b..72896f55 100644 Binary files a/bin/net/sf/freecol/client/control/PreGameController.class and b/bin/net/sf/freecol/client/control/PreGameController.class differ diff --git a/bin/net/sf/freecol/client/control/PreGameInputHandler.class b/bin/net/sf/freecol/client/control/PreGameInputHandler.class index e5af3a04..ef69de31 100644 Binary files a/bin/net/sf/freecol/client/control/PreGameInputHandler.class and b/bin/net/sf/freecol/client/control/PreGameInputHandler.class differ diff --git a/bin/net/sf/freecol/client/control/SoundController.class b/bin/net/sf/freecol/client/control/SoundController.class index d7b6067b..f3c1f3cd 100644 Binary files a/bin/net/sf/freecol/client/control/SoundController.class and b/bin/net/sf/freecol/client/control/SoundController.class differ diff --git a/bin/net/sf/freecol/client/gui/MapViewer.class b/bin/net/sf/freecol/client/gui/MapViewer.class index 061c0da0..344cb0fa 100644 Binary files a/bin/net/sf/freecol/client/gui/MapViewer.class and b/bin/net/sf/freecol/client/gui/MapViewer.class differ diff --git a/bin/net/sf/freecol/common/ServerInfo.class b/bin/net/sf/freecol/common/ServerInfo.class index 04013834..3c169546 100644 Binary files a/bin/net/sf/freecol/common/ServerInfo.class and b/bin/net/sf/freecol/common/ServerInfo.class differ diff --git a/bin/net/sf/freecol/common/i18n/Relation.class b/bin/net/sf/freecol/common/i18n/Relation.class index e82a00b6..12c34966 100644 Binary files a/bin/net/sf/freecol/common/i18n/Relation.class and b/bin/net/sf/freecol/common/i18n/Relation.class differ diff --git a/bin/net/sf/freecol/server/generator/ColonizationMapLoader.class b/bin/net/sf/freecol/server/generator/ColonizationMapLoader.class deleted file mode 100644 index 2f999e4e..00000000 Binary files a/bin/net/sf/freecol/server/generator/ColonizationMapLoader.class and /dev/null differ diff --git a/bin/net/sf/freecol/server/generator/FreeColMapLoader.class b/bin/net/sf/freecol/server/generator/FreeColMapLoader.class deleted file mode 100644 index 34bb354c..00000000 Binary files a/bin/net/sf/freecol/server/generator/FreeColMapLoader.class and /dev/null differ diff --git a/bin/net/sf/freecol/server/generator/MapLayerGenerator.class b/bin/net/sf/freecol/server/generator/MapLayerGenerator.class deleted file mode 100644 index f5bf3926..00000000 Binary files a/bin/net/sf/freecol/server/generator/MapLayerGenerator.class and /dev/null differ diff --git a/bin/net/sf/freecol/server/generator/MapLoader.class b/bin/net/sf/freecol/server/generator/MapLoader.class index d3e060db..3f54853f 100644 Binary files a/bin/net/sf/freecol/server/generator/MapLoader.class and b/bin/net/sf/freecol/server/generator/MapLoader.class differ diff --git a/bin/net/sf/freecol/server/generator/River.class b/bin/net/sf/freecol/server/generator/River.class index 653a0c7f..7daaa45a 100644 Binary files a/bin/net/sf/freecol/server/generator/River.class and b/bin/net/sf/freecol/server/generator/River.class differ diff --git a/bin/net/sf/freecol/server/generator/RiverSection.class b/bin/net/sf/freecol/server/generator/RiverSection.class index c922a49d..0f07097e 100644 Binary files a/bin/net/sf/freecol/server/generator/RiverSection.class and b/bin/net/sf/freecol/server/generator/RiverSection.class differ diff --git a/bin/net/sf/freecol/server/generator/SimpleMapGenerator$1.class b/bin/net/sf/freecol/server/generator/SimpleMapGenerator$1.class index 6b0f61ec..e0066e3d 100644 Binary files a/bin/net/sf/freecol/server/generator/SimpleMapGenerator$1.class and b/bin/net/sf/freecol/server/generator/SimpleMapGenerator$1.class differ diff --git a/bin/net/sf/freecol/server/generator/SimpleMapGenerator.class b/bin/net/sf/freecol/server/generator/SimpleMapGenerator.class index f847558e..721ee0da 100644 Binary files a/bin/net/sf/freecol/server/generator/SimpleMapGenerator.class and b/bin/net/sf/freecol/server/generator/SimpleMapGenerator.class differ diff --git a/bin/net/sf/freecol/server/generator/TerrainGenerator.class b/bin/net/sf/freecol/server/generator/TerrainGenerator.class index bd0a5a00..5342aa33 100644 Binary files a/bin/net/sf/freecol/server/generator/TerrainGenerator.class and b/bin/net/sf/freecol/server/generator/TerrainGenerator.class differ diff --git a/build/net/sf/freecol/FreeCol.class b/build/net/sf/freecol/FreeCol.class index de527b4f..ee1f973b 100644 Binary files a/build/net/sf/freecol/FreeCol.class and b/build/net/sf/freecol/FreeCol.class differ diff --git a/build/net/sf/freecol/client/ClientOptions.class b/build/net/sf/freecol/client/ClientOptions.class index 26afafd0..43c10429 100644 Binary files a/build/net/sf/freecol/client/ClientOptions.class and b/build/net/sf/freecol/client/ClientOptions.class differ diff --git a/build/net/sf/freecol/client/FreeColClient.class b/build/net/sf/freecol/client/FreeColClient.class index 9c100f85..24b6b5e5 100644 Binary files a/build/net/sf/freecol/client/FreeColClient.class and b/build/net/sf/freecol/client/FreeColClient.class differ diff --git a/build/net/sf/freecol/client/control/ConnectController.class b/build/net/sf/freecol/client/control/ConnectController.class index 8ebff03d..1b3f4478 100644 Binary files a/build/net/sf/freecol/client/control/ConnectController.class and b/build/net/sf/freecol/client/control/ConnectController.class differ diff --git a/build/net/sf/freecol/client/control/InGameController$1.class b/build/net/sf/freecol/client/control/InGameController$1.class index 2049fb2f..71462711 100644 Binary files a/build/net/sf/freecol/client/control/InGameController$1.class and b/build/net/sf/freecol/client/control/InGameController$1.class differ diff --git a/build/net/sf/freecol/client/control/InGameController.class b/build/net/sf/freecol/client/control/InGameController.class index b52e410e..b06fed7c 100644 Binary files a/build/net/sf/freecol/client/control/InGameController.class and b/build/net/sf/freecol/client/control/InGameController.class differ diff --git a/build/net/sf/freecol/client/control/InGameInputHandler.class b/build/net/sf/freecol/client/control/InGameInputHandler.class index 795802c6..f77ea061 100644 Binary files a/build/net/sf/freecol/client/control/InGameInputHandler.class and b/build/net/sf/freecol/client/control/InGameInputHandler.class differ diff --git a/build/net/sf/freecol/client/control/InputHandler.class b/build/net/sf/freecol/client/control/InputHandler.class index cf9eae16..646260e6 100644 Binary files a/build/net/sf/freecol/client/control/InputHandler.class and b/build/net/sf/freecol/client/control/InputHandler.class differ diff --git a/build/net/sf/freecol/client/control/MapEditorController$1.class b/build/net/sf/freecol/client/control/MapEditorController$1.class index 044d6919..eb1d8806 100644 Binary files a/build/net/sf/freecol/client/control/MapEditorController$1.class and b/build/net/sf/freecol/client/control/MapEditorController$1.class differ diff --git a/build/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class b/build/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class index 111c7d76..1448d666 100644 Binary files a/build/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class and b/build/net/sf/freecol/client/control/MapEditorController$1ErrorJob.class differ diff --git a/build/net/sf/freecol/client/control/MapEditorController.class b/build/net/sf/freecol/client/control/MapEditorController.class index 835e9e32..ed6a5fa7 100644 Binary files a/build/net/sf/freecol/client/control/MapEditorController.class and b/build/net/sf/freecol/client/control/MapEditorController.class differ diff --git a/build/net/sf/freecol/client/control/PreGameController.class b/build/net/sf/freecol/client/control/PreGameController.class index 7fdd2764..3f3e0967 100644 Binary files a/build/net/sf/freecol/client/control/PreGameController.class and b/build/net/sf/freecol/client/control/PreGameController.class differ diff --git a/build/net/sf/freecol/client/control/PreGameInputHandler$1.class b/build/net/sf/freecol/client/control/PreGameInputHandler$1.class index e4094077..9e8b1993 100644 Binary files a/build/net/sf/freecol/client/control/PreGameInputHandler$1.class and b/build/net/sf/freecol/client/control/PreGameInputHandler$1.class differ diff --git a/build/net/sf/freecol/client/control/PreGameInputHandler.class b/build/net/sf/freecol/client/control/PreGameInputHandler.class index e04023cf..8dd7bd00 100644 Binary files a/build/net/sf/freecol/client/control/PreGameInputHandler.class and b/build/net/sf/freecol/client/control/PreGameInputHandler.class differ diff --git a/build/net/sf/freecol/client/control/SoundController.class b/build/net/sf/freecol/client/control/SoundController.class index 4f2be8cc..af46455b 100644 Binary files a/build/net/sf/freecol/client/control/SoundController.class and b/build/net/sf/freecol/client/control/SoundController.class differ diff --git a/build/net/sf/freecol/client/gui/Canvas.class b/build/net/sf/freecol/client/gui/Canvas.class index 96d89651..e47894ab 100644 Binary files a/build/net/sf/freecol/client/gui/Canvas.class and b/build/net/sf/freecol/client/gui/Canvas.class differ diff --git a/build/net/sf/freecol/client/gui/ImageLibrary.class b/build/net/sf/freecol/client/gui/ImageLibrary.class index 8d1cd1e1..935d565c 100644 Binary files a/build/net/sf/freecol/client/gui/ImageLibrary.class and b/build/net/sf/freecol/client/gui/ImageLibrary.class differ diff --git a/build/net/sf/freecol/client/gui/MapViewer$1.class b/build/net/sf/freecol/client/gui/MapViewer$1.class index ae3ab6bc..bfb8873e 100644 Binary files a/build/net/sf/freecol/client/gui/MapViewer$1.class and b/build/net/sf/freecol/client/gui/MapViewer$1.class differ diff --git a/build/net/sf/freecol/client/gui/MapViewer.class b/build/net/sf/freecol/client/gui/MapViewer.class index c7af7ec8..510d4fd2 100644 Binary files a/build/net/sf/freecol/client/gui/MapViewer.class and b/build/net/sf/freecol/client/gui/MapViewer.class differ diff --git a/build/net/sf/freecol/client/gui/RoadPainter.class b/build/net/sf/freecol/client/gui/RoadPainter.class index c8463543..4bac85f7 100644 Binary files a/build/net/sf/freecol/client/gui/RoadPainter.class and b/build/net/sf/freecol/client/gui/RoadPainter.class differ diff --git a/build/net/sf/freecol/client/gui/ScrollThread.class b/build/net/sf/freecol/client/gui/ScrollThread.class index 1677d008..7a534bd9 100644 Binary files a/build/net/sf/freecol/client/gui/ScrollThread.class and b/build/net/sf/freecol/client/gui/ScrollThread.class differ diff --git a/build/net/sf/freecol/client/gui/SwingGUI.class b/build/net/sf/freecol/client/gui/SwingGUI.class index d27c889a..fd6ba27e 100644 Binary files a/build/net/sf/freecol/client/gui/SwingGUI.class and b/build/net/sf/freecol/client/gui/SwingGUI.class differ diff --git a/build/net/sf/freecol/client/gui/TilePopup.class b/build/net/sf/freecol/client/gui/TilePopup.class index d86f5d24..54e25b25 100644 Binary files a/build/net/sf/freecol/client/gui/TilePopup.class and b/build/net/sf/freecol/client/gui/TilePopup.class differ diff --git a/build/net/sf/freecol/client/gui/animation/UnitImageAnimation.class b/build/net/sf/freecol/client/gui/animation/UnitImageAnimation.class index abb187b2..2aac00a0 100644 Binary files a/build/net/sf/freecol/client/gui/animation/UnitImageAnimation.class and b/build/net/sf/freecol/client/gui/animation/UnitImageAnimation.class differ diff --git a/build/net/sf/freecol/client/gui/animation/UnitMoveAnimation.class b/build/net/sf/freecol/client/gui/animation/UnitMoveAnimation.class index 0b27f15a..9f5638b5 100644 Binary files a/build/net/sf/freecol/client/gui/animation/UnitMoveAnimation.class and b/build/net/sf/freecol/client/gui/animation/UnitMoveAnimation.class differ diff --git a/build/net/sf/freecol/client/gui/menu/DebugMenu.class b/build/net/sf/freecol/client/gui/menu/DebugMenu.class index ad767f0d..6ddeadb8 100644 Binary files a/build/net/sf/freecol/client/gui/menu/DebugMenu.class and b/build/net/sf/freecol/client/gui/menu/DebugMenu.class differ diff --git a/build/net/sf/freecol/client/gui/menu/FreeColMenuTest.class b/build/net/sf/freecol/client/gui/menu/FreeColMenuTest.class index 9cc7c1c9..925a863b 100644 Binary files a/build/net/sf/freecol/client/gui/menu/FreeColMenuTest.class and b/build/net/sf/freecol/client/gui/menu/FreeColMenuTest.class differ diff --git a/build/net/sf/freecol/client/gui/menu/MapEditorMenuBar.class b/build/net/sf/freecol/client/gui/menu/MapEditorMenuBar.class index d98a0eb2..bae2161b 100644 Binary files a/build/net/sf/freecol/client/gui/menu/MapEditorMenuBar.class and b/build/net/sf/freecol/client/gui/menu/MapEditorMenuBar.class differ diff --git a/build/net/sf/freecol/client/gui/option/AudioMixerOptionUI.class b/build/net/sf/freecol/client/gui/option/AudioMixerOptionUI.class index 54e38482..9bfb1e2a 100644 Binary files a/build/net/sf/freecol/client/gui/option/AudioMixerOptionUI.class and b/build/net/sf/freecol/client/gui/option/AudioMixerOptionUI.class differ diff --git a/build/net/sf/freecol/client/gui/option/FileOptionUI.class b/build/net/sf/freecol/client/gui/option/FileOptionUI.class index 84e7be36..1fae5905 100644 Binary files a/build/net/sf/freecol/client/gui/option/FileOptionUI.class and b/build/net/sf/freecol/client/gui/option/FileOptionUI.class differ diff --git a/build/net/sf/freecol/client/gui/option/ListOptionUI.class b/build/net/sf/freecol/client/gui/option/ListOptionUI.class index a588db8b..500ddd5e 100644 Binary files a/build/net/sf/freecol/client/gui/option/ListOptionUI.class and b/build/net/sf/freecol/client/gui/option/ListOptionUI.class differ diff --git a/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable.class b/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable.class index 9501f934..1005e2c7 100644 Binary files a/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable.class and b/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable.class differ diff --git a/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler.class b/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler.class index dcf56473..9bc3e83b 100644 Binary files a/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler.class and b/build/net/sf/freecol/client/gui/panel/BuildQueuePanel$BuildQueueTransferHandler.class differ diff --git a/build/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.class b/build/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.class index d8470978..a7c07b98 100644 Binary files a/build/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.class and b/build/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ColonyPanel.class b/build/net/sf/freecol/client/gui/panel/ColonyPanel.class index 80291e9d..dae9076d 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ColonyPanel.class and b/build/net/sf/freecol/client/gui/panel/ColonyPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/CompactLabourReport.class b/build/net/sf/freecol/client/gui/panel/CompactLabourReport.class index 703d7b2e..e1672522 100644 Binary files a/build/net/sf/freecol/client/gui/panel/CompactLabourReport.class and b/build/net/sf/freecol/client/gui/panel/CompactLabourReport.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ConceptDetailPanel.class b/build/net/sf/freecol/client/gui/panel/ConceptDetailPanel.class index 4c8e326f..7446b4f3 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ConceptDetailPanel.class and b/build/net/sf/freecol/client/gui/panel/ConceptDetailPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/DeclarationPanel$SignaturePanel.class b/build/net/sf/freecol/client/gui/panel/DeclarationPanel$SignaturePanel.class index ff5cd742..1391e4cb 100644 Binary files a/build/net/sf/freecol/client/gui/panel/DeclarationPanel$SignaturePanel.class and b/build/net/sf/freecol/client/gui/panel/DeclarationPanel$SignaturePanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/DeclarationPanel.class b/build/net/sf/freecol/client/gui/panel/DeclarationPanel.class index f329dac5..2f930f6f 100644 Binary files a/build/net/sf/freecol/client/gui/panel/DeclarationPanel.class and b/build/net/sf/freecol/client/gui/panel/DeclarationPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/DefaultTransferHandler.class b/build/net/sf/freecol/client/gui/panel/DefaultTransferHandler.class index d48de284..cabb53d8 100644 Binary files a/build/net/sf/freecol/client/gui/panel/DefaultTransferHandler.class and b/build/net/sf/freecol/client/gui/panel/DefaultTransferHandler.class differ diff --git a/build/net/sf/freecol/client/gui/panel/DifficultyDialog.class b/build/net/sf/freecol/client/gui/panel/DifficultyDialog.class index 8484b0f7..a21b565a 100644 Binary files a/build/net/sf/freecol/client/gui/panel/DifficultyDialog.class and b/build/net/sf/freecol/client/gui/panel/DifficultyDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/EditSettlementDialog.class b/build/net/sf/freecol/client/gui/panel/EditSettlementDialog.class index 81f00007..87aaec41 100644 Binary files a/build/net/sf/freecol/client/gui/panel/EditSettlementDialog.class and b/build/net/sf/freecol/client/gui/panel/EditSettlementDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/InformationPanel.class b/build/net/sf/freecol/client/gui/panel/InformationPanel.class index aad9d11c..23b382fa 100644 Binary files a/build/net/sf/freecol/client/gui/panel/InformationPanel.class and b/build/net/sf/freecol/client/gui/panel/InformationPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/LabourData.class b/build/net/sf/freecol/client/gui/panel/LabourData.class index 1ed6072c..87b1f283 100644 Binary files a/build/net/sf/freecol/client/gui/panel/LabourData.class and b/build/net/sf/freecol/client/gui/panel/LabourData.class differ diff --git a/build/net/sf/freecol/client/gui/panel/LoadDialog.class b/build/net/sf/freecol/client/gui/panel/LoadDialog.class index c9c91c7a..ffa4df6b 100644 Binary files a/build/net/sf/freecol/client/gui/panel/LoadDialog.class and b/build/net/sf/freecol/client/gui/panel/LoadDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/MapEditorTransformPanel.class b/build/net/sf/freecol/client/gui/panel/MapEditorTransformPanel.class index a139754f..d2f6d596 100644 Binary files a/build/net/sf/freecol/client/gui/panel/MapEditorTransformPanel.class and b/build/net/sf/freecol/client/gui/panel/MapEditorTransformPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.class b/build/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.class index b3ef6a81..5c20f29a 100644 Binary files a/build/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.class and b/build/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ModifierFormat.class b/build/net/sf/freecol/client/gui/panel/ModifierFormat.class index 7e251a4a..44772058 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ModifierFormat.class and b/build/net/sf/freecol/client/gui/panel/ModifierFormat.class differ diff --git a/build/net/sf/freecol/client/gui/panel/MonarchDialog.class b/build/net/sf/freecol/client/gui/panel/MonarchDialog.class index 63ebd5d8..5637bd3d 100644 Binary files a/build/net/sf/freecol/client/gui/panel/MonarchDialog.class and b/build/net/sf/freecol/client/gui/panel/MonarchDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/NewPanel.class b/build/net/sf/freecol/client/gui/panel/NewPanel.class index fe5f11dd..a9b6aec4 100644 Binary files a/build/net/sf/freecol/client/gui/panel/NewPanel.class and b/build/net/sf/freecol/client/gui/panel/NewPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/NewUnitPanel.class b/build/net/sf/freecol/client/gui/panel/NewUnitPanel.class index 427e90d3..a7df9a3b 100644 Binary files a/build/net/sf/freecol/client/gui/panel/NewUnitPanel.class and b/build/net/sf/freecol/client/gui/panel/NewUnitPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ParametersDialog.class b/build/net/sf/freecol/client/gui/panel/ParametersDialog.class index a0b0e545..45cb9219 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ParametersDialog.class and b/build/net/sf/freecol/client/gui/panel/ParametersDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/PlayersTable$AvailableCellEditor.class b/build/net/sf/freecol/client/gui/panel/PlayersTable$AvailableCellEditor.class index aff2c4c4..5eb8249c 100644 Binary files a/build/net/sf/freecol/client/gui/panel/PlayersTable$AvailableCellEditor.class and b/build/net/sf/freecol/client/gui/panel/PlayersTable$AvailableCellEditor.class differ diff --git a/build/net/sf/freecol/client/gui/panel/PlayersTable$PlayerCellEditor.class b/build/net/sf/freecol/client/gui/panel/PlayersTable$PlayerCellEditor.class index bab4e47b..881c845a 100644 Binary files a/build/net/sf/freecol/client/gui/panel/PlayersTable$PlayerCellEditor.class and b/build/net/sf/freecol/client/gui/panel/PlayersTable$PlayerCellEditor.class differ diff --git a/build/net/sf/freecol/client/gui/panel/PlayersTable.class b/build/net/sf/freecol/client/gui/panel/PlayersTable.class index 5af41fd6..0310172b 100644 Binary files a/build/net/sf/freecol/client/gui/panel/PlayersTable.class and b/build/net/sf/freecol/client/gui/panel/PlayersTable.class differ diff --git a/build/net/sf/freecol/client/gui/panel/QuickActionMenu.class b/build/net/sf/freecol/client/gui/panel/QuickActionMenu.class index f4758320..9f8b2ec2 100644 Binary files a/build/net/sf/freecol/client/gui/panel/QuickActionMenu.class and b/build/net/sf/freecol/client/gui/panel/QuickActionMenu.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.class b/build/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.class index 2d67ff0f..6c3c5e8a 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.class and b/build/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel$ColonySummary.class b/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel$ColonySummary.class index 94d492ce..97bab0b7 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel$ColonySummary.class and b/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel$ColonySummary.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.class b/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.class index f2cf4f88..89c4c5a1 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.class and b/build/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.class b/build/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.class index 07e9098b..a679d05f 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.class and b/build/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ReportProductionPanel.class b/build/net/sf/freecol/client/gui/panel/ReportProductionPanel.class index e7f8bb43..34d16778 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ReportProductionPanel.class and b/build/net/sf/freecol/client/gui/panel/ReportProductionPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ReportTurnPanel.class b/build/net/sf/freecol/client/gui/panel/ReportTurnPanel.class index f1718374..a476c2c9 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ReportTurnPanel.class and b/build/net/sf/freecol/client/gui/panel/ReportTurnPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.class b/build/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.class index 94b20b50..ff4600a8 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.class and b/build/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/SaveDialog.class b/build/net/sf/freecol/client/gui/panel/SaveDialog.class index 37b0bbef..5d0f9d86 100644 Binary files a/build/net/sf/freecol/client/gui/panel/SaveDialog.class and b/build/net/sf/freecol/client/gui/panel/SaveDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.class b/build/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.class index 8b0e1a4f..f2fcbea2 100644 Binary files a/build/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.class and b/build/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog$Destination.class b/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog$Destination.class index ff8b3026..f64675a7 100644 Binary files a/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog$Destination.class and b/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog$Destination.class differ diff --git a/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog.class b/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog.class index 92246377..c16d70af 100644 Binary files a/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog.class and b/build/net/sf/freecol/client/gui/panel/SelectDestinationDialog.class differ diff --git a/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$CargoHandler.class b/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$CargoHandler.class index 476a267a..ebdbb3a9 100644 Binary files a/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$CargoHandler.class and b/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$CargoHandler.class differ diff --git a/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$StopListHandler.class b/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$StopListHandler.class index 9b4e2e95..78186cd5 100644 Binary files a/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$StopListHandler.class and b/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel$StopListHandler.class differ diff --git a/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.class b/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.class index cb8501d7..567df240 100644 Binary files a/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.class and b/build/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/TradeRoutePanel.class b/build/net/sf/freecol/client/gui/panel/TradeRoutePanel.class index ac67af76..ac48c299 100644 Binary files a/build/net/sf/freecol/client/gui/panel/TradeRoutePanel.class and b/build/net/sf/freecol/client/gui/panel/TradeRoutePanel.class differ diff --git a/build/net/sf/freecol/client/gui/panel/UnitDetailPanel.class b/build/net/sf/freecol/client/gui/panel/UnitDetailPanel.class index 6ce43c98..fefe6436 100644 Binary files a/build/net/sf/freecol/client/gui/panel/UnitDetailPanel.class and b/build/net/sf/freecol/client/gui/panel/UnitDetailPanel.class differ diff --git a/build/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.class b/build/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.class index bb083e67..110455f1 100644 Binary files a/build/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.class and b/build/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.class differ diff --git a/build/net/sf/freecol/common/ServerInfo.class b/build/net/sf/freecol/common/ServerInfo.class index 4721060b..d48b28d4 100644 Binary files a/build/net/sf/freecol/common/ServerInfo.class and b/build/net/sf/freecol/common/ServerInfo.class differ diff --git a/build/net/sf/freecol/common/debug/DebugUtils.class b/build/net/sf/freecol/common/debug/DebugUtils.class index 90e3579a..7b3b1a2d 100644 Binary files a/build/net/sf/freecol/common/debug/DebugUtils.class and b/build/net/sf/freecol/common/debug/DebugUtils.class differ diff --git a/build/net/sf/freecol/common/debug/FreeColDebugger.class b/build/net/sf/freecol/common/debug/FreeColDebugger.class index e911c6e8..746a81c6 100644 Binary files a/build/net/sf/freecol/common/debug/FreeColDebugger.class and b/build/net/sf/freecol/common/debug/FreeColDebugger.class differ diff --git a/build/net/sf/freecol/common/i18n/DefaultNumberRule.class b/build/net/sf/freecol/common/i18n/DefaultNumberRule.class index 168065cf..410282e5 100644 Binary files a/build/net/sf/freecol/common/i18n/DefaultNumberRule.class and b/build/net/sf/freecol/common/i18n/DefaultNumberRule.class differ diff --git a/build/net/sf/freecol/common/i18n/Messages.class b/build/net/sf/freecol/common/i18n/Messages.class index c9e00766..eccb420c 100644 Binary files a/build/net/sf/freecol/common/i18n/Messages.class and b/build/net/sf/freecol/common/i18n/Messages.class differ diff --git a/build/net/sf/freecol/common/i18n/Relation.class b/build/net/sf/freecol/common/i18n/Relation.class index a7df57f1..709d35f5 100644 Binary files a/build/net/sf/freecol/common/i18n/Relation.class and b/build/net/sf/freecol/common/i18n/Relation.class differ diff --git a/build/net/sf/freecol/common/i18n/Rule.class b/build/net/sf/freecol/common/i18n/Rule.class index 9f51572a..613cf87f 100644 Binary files a/build/net/sf/freecol/common/i18n/Rule.class and b/build/net/sf/freecol/common/i18n/Rule.class differ diff --git a/build/net/sf/freecol/common/io/FreeColDataFile.class b/build/net/sf/freecol/common/io/FreeColDataFile.class index 7077d0df..0cf1d5aa 100644 Binary files a/build/net/sf/freecol/common/io/FreeColDataFile.class and b/build/net/sf/freecol/common/io/FreeColDataFile.class differ diff --git a/build/net/sf/freecol/common/model/AbstractGoods.class b/build/net/sf/freecol/common/model/AbstractGoods.class index 54bd25d0..6ccf9438 100644 Binary files a/build/net/sf/freecol/common/model/AbstractGoods.class and b/build/net/sf/freecol/common/model/AbstractGoods.class differ diff --git a/build/net/sf/freecol/common/model/AbstractUnit.class b/build/net/sf/freecol/common/model/AbstractUnit.class index d5d81355..a5a98024 100644 Binary files a/build/net/sf/freecol/common/model/AbstractUnit.class and b/build/net/sf/freecol/common/model/AbstractUnit.class differ diff --git a/build/net/sf/freecol/common/model/BuildableType.class b/build/net/sf/freecol/common/model/BuildableType.class index f7e02f9e..0009bdee 100644 Binary files a/build/net/sf/freecol/common/model/BuildableType.class and b/build/net/sf/freecol/common/model/BuildableType.class differ diff --git a/build/net/sf/freecol/common/model/Building.class b/build/net/sf/freecol/common/model/Building.class index 758e19d3..6c9f2b63 100644 Binary files a/build/net/sf/freecol/common/model/Building.class and b/build/net/sf/freecol/common/model/Building.class differ diff --git a/build/net/sf/freecol/common/model/BuildingType.class b/build/net/sf/freecol/common/model/BuildingType.class index d6acbdb6..434f2161 100644 Binary files a/build/net/sf/freecol/common/model/BuildingType.class and b/build/net/sf/freecol/common/model/BuildingType.class differ diff --git a/build/net/sf/freecol/common/model/Colony.class b/build/net/sf/freecol/common/model/Colony.class index 6a28f8d3..83ceb312 100644 Binary files a/build/net/sf/freecol/common/model/Colony.class and b/build/net/sf/freecol/common/model/Colony.class differ diff --git a/build/net/sf/freecol/common/model/ColonyTile.class b/build/net/sf/freecol/common/model/ColonyTile.class index 90aa68b9..1003dd89 100644 Binary files a/build/net/sf/freecol/common/model/ColonyTile.class and b/build/net/sf/freecol/common/model/ColonyTile.class differ diff --git a/build/net/sf/freecol/common/model/CombatModel.class b/build/net/sf/freecol/common/model/CombatModel.class index d83bdad8..82ae7a77 100644 Binary files a/build/net/sf/freecol/common/model/CombatModel.class and b/build/net/sf/freecol/common/model/CombatModel.class differ diff --git a/build/net/sf/freecol/common/model/DiplomaticTrade.class b/build/net/sf/freecol/common/model/DiplomaticTrade.class index 386784d0..d05fbb74 100644 Binary files a/build/net/sf/freecol/common/model/DiplomaticTrade.class and b/build/net/sf/freecol/common/model/DiplomaticTrade.class differ diff --git a/build/net/sf/freecol/common/model/Effect.class b/build/net/sf/freecol/common/model/Effect.class index 73a83d62..bf72e1c4 100644 Binary files a/build/net/sf/freecol/common/model/Effect.class and b/build/net/sf/freecol/common/model/Effect.class differ diff --git a/build/net/sf/freecol/common/model/Feature.class b/build/net/sf/freecol/common/model/Feature.class index 3dd99a8a..190b75b7 100644 Binary files a/build/net/sf/freecol/common/model/Feature.class and b/build/net/sf/freecol/common/model/Feature.class differ diff --git a/build/net/sf/freecol/common/model/FoundingFather.class b/build/net/sf/freecol/common/model/FoundingFather.class index 3aabbec6..f1f487be 100644 Binary files a/build/net/sf/freecol/common/model/FoundingFather.class and b/build/net/sf/freecol/common/model/FoundingFather.class differ diff --git a/build/net/sf/freecol/common/model/Game.class b/build/net/sf/freecol/common/model/Game.class index c21db19e..3ca86ef7 100644 Binary files a/build/net/sf/freecol/common/model/Game.class and b/build/net/sf/freecol/common/model/Game.class differ diff --git a/build/net/sf/freecol/common/model/GoodsContainer.class b/build/net/sf/freecol/common/model/GoodsContainer.class index 184ca7c6..a69eab86 100644 Binary files a/build/net/sf/freecol/common/model/GoodsContainer.class and b/build/net/sf/freecol/common/model/GoodsContainer.class differ diff --git a/build/net/sf/freecol/common/model/GoodsLocation.class b/build/net/sf/freecol/common/model/GoodsLocation.class index efad5a75..0706034c 100644 Binary files a/build/net/sf/freecol/common/model/GoodsLocation.class and b/build/net/sf/freecol/common/model/GoodsLocation.class differ diff --git a/build/net/sf/freecol/common/model/IndianSettlement.class b/build/net/sf/freecol/common/model/IndianSettlement.class index 09eaf74b..ced7c19b 100644 Binary files a/build/net/sf/freecol/common/model/IndianSettlement.class and b/build/net/sf/freecol/common/model/IndianSettlement.class differ diff --git a/build/net/sf/freecol/common/model/LandMap.class b/build/net/sf/freecol/common/model/LandMap.class index 40ab5e1b..bbcc960d 100644 Binary files a/build/net/sf/freecol/common/model/LandMap.class and b/build/net/sf/freecol/common/model/LandMap.class differ diff --git a/build/net/sf/freecol/common/model/Map$Position.class b/build/net/sf/freecol/common/model/Map$Position.class index 33c35fea..3c0ed45a 100644 Binary files a/build/net/sf/freecol/common/model/Map$Position.class and b/build/net/sf/freecol/common/model/Map$Position.class differ diff --git a/build/net/sf/freecol/common/model/Map.class b/build/net/sf/freecol/common/model/Map.class index 901bebf0..8293306d 100644 Binary files a/build/net/sf/freecol/common/model/Map.class and b/build/net/sf/freecol/common/model/Map.class differ diff --git a/build/net/sf/freecol/common/model/Market.class b/build/net/sf/freecol/common/model/Market.class index 3c987e0a..49cb0170 100644 Binary files a/build/net/sf/freecol/common/model/Market.class and b/build/net/sf/freecol/common/model/Market.class differ diff --git a/build/net/sf/freecol/common/model/Monarch$Force.class b/build/net/sf/freecol/common/model/Monarch$Force.class index f44d82df..664f6509 100644 Binary files a/build/net/sf/freecol/common/model/Monarch$Force.class and b/build/net/sf/freecol/common/model/Monarch$Force.class differ diff --git a/build/net/sf/freecol/common/model/Monarch.class b/build/net/sf/freecol/common/model/Monarch.class index ab15dad8..eb740519 100644 Binary files a/build/net/sf/freecol/common/model/Monarch.class and b/build/net/sf/freecol/common/model/Monarch.class differ diff --git a/build/net/sf/freecol/common/model/Nation.class b/build/net/sf/freecol/common/model/Nation.class index 622a0ddb..28851abe 100644 Binary files a/build/net/sf/freecol/common/model/Nation.class and b/build/net/sf/freecol/common/model/Nation.class differ diff --git a/build/net/sf/freecol/common/model/NationType.class b/build/net/sf/freecol/common/model/NationType.class index 6acdddf0..c328621c 100644 Binary files a/build/net/sf/freecol/common/model/NationType.class and b/build/net/sf/freecol/common/model/NationType.class differ diff --git a/build/net/sf/freecol/common/model/Player$UnitIterator.class b/build/net/sf/freecol/common/model/Player$UnitIterator.class index 931dd558..2a8e4339 100644 Binary files a/build/net/sf/freecol/common/model/Player$UnitIterator.class and b/build/net/sf/freecol/common/model/Player$UnitIterator.class differ diff --git a/build/net/sf/freecol/common/model/Player.class b/build/net/sf/freecol/common/model/Player.class index 74bdd521..104d06e2 100644 Binary files a/build/net/sf/freecol/common/model/Player.class and b/build/net/sf/freecol/common/model/Player.class differ diff --git a/build/net/sf/freecol/common/model/ProductionCache.class b/build/net/sf/freecol/common/model/ProductionCache.class index c5e5d9fb..24ffee1f 100644 Binary files a/build/net/sf/freecol/common/model/ProductionCache.class and b/build/net/sf/freecol/common/model/ProductionCache.class differ diff --git a/build/net/sf/freecol/common/model/ProductionType.class b/build/net/sf/freecol/common/model/ProductionType.class index 759fe4ae..72799ec5 100644 Binary files a/build/net/sf/freecol/common/model/ProductionType.class and b/build/net/sf/freecol/common/model/ProductionType.class differ diff --git a/build/net/sf/freecol/common/model/RandomRange.class b/build/net/sf/freecol/common/model/RandomRange.class index 4e8a0bc9..3ed51bd3 100644 Binary files a/build/net/sf/freecol/common/model/RandomRange.class and b/build/net/sf/freecol/common/model/RandomRange.class differ diff --git a/build/net/sf/freecol/common/model/Role.class b/build/net/sf/freecol/common/model/Role.class index eb1f214e..798b0020 100644 Binary files a/build/net/sf/freecol/common/model/Role.class and b/build/net/sf/freecol/common/model/Role.class differ diff --git a/build/net/sf/freecol/common/model/Settlement.class b/build/net/sf/freecol/common/model/Settlement.class index 11f6494b..dcf526d6 100644 Binary files a/build/net/sf/freecol/common/model/Settlement.class and b/build/net/sf/freecol/common/model/Settlement.class differ diff --git a/build/net/sf/freecol/common/model/SettlementType.class b/build/net/sf/freecol/common/model/SettlementType.class index e9863a64..77046ee9 100644 Binary files a/build/net/sf/freecol/common/model/SettlementType.class and b/build/net/sf/freecol/common/model/SettlementType.class differ diff --git a/build/net/sf/freecol/common/model/SimpleCombatModel.class b/build/net/sf/freecol/common/model/SimpleCombatModel.class index 868901a9..577a289c 100644 Binary files a/build/net/sf/freecol/common/model/SimpleCombatModel.class and b/build/net/sf/freecol/common/model/SimpleCombatModel.class differ diff --git a/build/net/sf/freecol/common/model/Specification.class b/build/net/sf/freecol/common/model/Specification.class index 848995e6..a06dd433 100644 Binary files a/build/net/sf/freecol/common/model/Specification.class and b/build/net/sf/freecol/common/model/Specification.class differ diff --git a/build/net/sf/freecol/common/model/Tension.class b/build/net/sf/freecol/common/model/Tension.class index 0b456597..8027a830 100644 Binary files a/build/net/sf/freecol/common/model/Tension.class and b/build/net/sf/freecol/common/model/Tension.class differ diff --git a/build/net/sf/freecol/common/model/Tile.class b/build/net/sf/freecol/common/model/Tile.class index bcf59965..116d22ed 100644 Binary files a/build/net/sf/freecol/common/model/Tile.class and b/build/net/sf/freecol/common/model/Tile.class differ diff --git a/build/net/sf/freecol/common/model/TileImprovementType.class b/build/net/sf/freecol/common/model/TileImprovementType.class index 450bb401..0a804476 100644 Binary files a/build/net/sf/freecol/common/model/TileImprovementType.class and b/build/net/sf/freecol/common/model/TileImprovementType.class differ diff --git a/build/net/sf/freecol/common/model/TileItemContainer.class b/build/net/sf/freecol/common/model/TileItemContainer.class index 07d6cd77..49b71873 100644 Binary files a/build/net/sf/freecol/common/model/TileItemContainer.class and b/build/net/sf/freecol/common/model/TileItemContainer.class differ diff --git a/build/net/sf/freecol/common/model/TradeRoute.class b/build/net/sf/freecol/common/model/TradeRoute.class index cfcccffd..80f38413 100644 Binary files a/build/net/sf/freecol/common/model/TradeRoute.class and b/build/net/sf/freecol/common/model/TradeRoute.class differ diff --git a/build/net/sf/freecol/common/model/TradeRouteStop.class b/build/net/sf/freecol/common/model/TradeRouteStop.class index e2218060..fe5a33d7 100644 Binary files a/build/net/sf/freecol/common/model/TradeRouteStop.class and b/build/net/sf/freecol/common/model/TradeRouteStop.class differ diff --git a/build/net/sf/freecol/common/model/Unit.class b/build/net/sf/freecol/common/model/Unit.class index fd06f1ae..803f483b 100644 Binary files a/build/net/sf/freecol/common/model/Unit.class and b/build/net/sf/freecol/common/model/Unit.class differ diff --git a/build/net/sf/freecol/common/model/UnitLocation.class b/build/net/sf/freecol/common/model/UnitLocation.class index fc5cc269..44f1e823 100644 Binary files a/build/net/sf/freecol/common/model/UnitLocation.class and b/build/net/sf/freecol/common/model/UnitLocation.class differ diff --git a/build/net/sf/freecol/common/model/UnitType.class b/build/net/sf/freecol/common/model/UnitType.class index f0779a19..e565475b 100644 Binary files a/build/net/sf/freecol/common/model/UnitType.class and b/build/net/sf/freecol/common/model/UnitType.class differ diff --git a/build/net/sf/freecol/common/model/UnitTypeChange.class b/build/net/sf/freecol/common/model/UnitTypeChange.class index 5770963f..9b141586 100644 Binary files a/build/net/sf/freecol/common/model/UnitTypeChange.class and b/build/net/sf/freecol/common/model/UnitTypeChange.class differ diff --git a/build/net/sf/freecol/common/model/WorkLocation.class b/build/net/sf/freecol/common/model/WorkLocation.class index f5afedd2..39ff8f9e 100644 Binary files a/build/net/sf/freecol/common/model/WorkLocation.class and b/build/net/sf/freecol/common/model/WorkLocation.class differ diff --git a/build/net/sf/freecol/common/model/mission/ImprovementMission.class b/build/net/sf/freecol/common/model/mission/ImprovementMission.class index b2b35bc5..f22f62fc 100644 Binary files a/build/net/sf/freecol/common/model/mission/ImprovementMission.class and b/build/net/sf/freecol/common/model/mission/ImprovementMission.class differ diff --git a/build/net/sf/freecol/common/option/AudioMixerOption.class b/build/net/sf/freecol/common/option/AudioMixerOption.class index 77ca9c83..0167043e 100644 Binary files a/build/net/sf/freecol/common/option/AudioMixerOption.class and b/build/net/sf/freecol/common/option/AudioMixerOption.class differ diff --git a/build/net/sf/freecol/common/option/LanguageOption.class b/build/net/sf/freecol/common/option/LanguageOption.class index 539f3e4c..73b47f8e 100644 Binary files a/build/net/sf/freecol/common/option/LanguageOption.class and b/build/net/sf/freecol/common/option/LanguageOption.class differ diff --git a/build/net/sf/freecol/common/option/ListOption.class b/build/net/sf/freecol/common/option/ListOption.class index 1244c6bd..c48827a6 100644 Binary files a/build/net/sf/freecol/common/option/ListOption.class and b/build/net/sf/freecol/common/option/ListOption.class differ diff --git a/build/net/sf/freecol/common/option/OptionGroup.class b/build/net/sf/freecol/common/option/OptionGroup.class index 2268af9e..9dacf1dd 100644 Binary files a/build/net/sf/freecol/common/option/OptionGroup.class and b/build/net/sf/freecol/common/option/OptionGroup.class differ diff --git a/build/net/sf/freecol/common/resources/ResourceMapping.class b/build/net/sf/freecol/common/resources/ResourceMapping.class index 8300c353..ce098dc8 100644 Binary files a/build/net/sf/freecol/common/resources/ResourceMapping.class and b/build/net/sf/freecol/common/resources/ResourceMapping.class differ diff --git a/build/net/sf/freecol/common/sound/SoundPlayer.class b/build/net/sf/freecol/common/sound/SoundPlayer.class index 007a0439..dca0116b 100644 Binary files a/build/net/sf/freecol/common/sound/SoundPlayer.class and b/build/net/sf/freecol/common/sound/SoundPlayer.class differ diff --git a/build/net/sf/freecol/common/util/RandomChoice.class b/build/net/sf/freecol/common/util/RandomChoice.class index 7ae58039..40046cf4 100644 Binary files a/build/net/sf/freecol/common/util/RandomChoice.class and b/build/net/sf/freecol/common/util/RandomChoice.class differ diff --git a/build/net/sf/freecol/server/FreeColServer.class b/build/net/sf/freecol/server/FreeColServer.class index e2876add..8dddeda4 100644 Binary files a/build/net/sf/freecol/server/FreeColServer.class and b/build/net/sf/freecol/server/FreeColServer.class differ diff --git a/build/net/sf/freecol/server/ai/AIColony.class b/build/net/sf/freecol/server/ai/AIColony.class index 1091c47b..bf6b2763 100644 Binary files a/build/net/sf/freecol/server/ai/AIColony.class and b/build/net/sf/freecol/server/ai/AIColony.class differ diff --git a/build/net/sf/freecol/server/ai/Cargo.class b/build/net/sf/freecol/server/ai/Cargo.class index f0bad09f..46c197fa 100644 Binary files a/build/net/sf/freecol/server/ai/Cargo.class and b/build/net/sf/freecol/server/ai/Cargo.class differ diff --git a/build/net/sf/freecol/server/ai/ColonyPlan.class b/build/net/sf/freecol/server/ai/ColonyPlan.class index 4611a103..9f5bed70 100644 Binary files a/build/net/sf/freecol/server/ai/ColonyPlan.class and b/build/net/sf/freecol/server/ai/ColonyPlan.class differ diff --git a/build/net/sf/freecol/server/ai/EuropeanAIPlayer.class b/build/net/sf/freecol/server/ai/EuropeanAIPlayer.class index c52a484d..cf84d501 100644 Binary files a/build/net/sf/freecol/server/ai/EuropeanAIPlayer.class and b/build/net/sf/freecol/server/ai/EuropeanAIPlayer.class differ diff --git a/build/net/sf/freecol/server/ai/NativeAIPlayer.class b/build/net/sf/freecol/server/ai/NativeAIPlayer.class index 6da2ca46..ce8242b8 100644 Binary files a/build/net/sf/freecol/server/ai/NativeAIPlayer.class and b/build/net/sf/freecol/server/ai/NativeAIPlayer.class differ diff --git a/build/net/sf/freecol/server/ai/REFAIPlayer.class b/build/net/sf/freecol/server/ai/REFAIPlayer.class index 5bddaf02..053f0944 100644 Binary files a/build/net/sf/freecol/server/ai/REFAIPlayer.class and b/build/net/sf/freecol/server/ai/REFAIPlayer.class differ diff --git a/build/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.class b/build/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.class index b3025318..400bb7a5 100644 Binary files a/build/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.class and b/build/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.class differ diff --git a/build/net/sf/freecol/server/ai/mission/TransportMission.class b/build/net/sf/freecol/server/ai/mission/TransportMission.class index cc7049ae..82d974b0 100644 Binary files a/build/net/sf/freecol/server/ai/mission/TransportMission.class and b/build/net/sf/freecol/server/ai/mission/TransportMission.class differ diff --git a/build/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.class b/build/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.class index 16ac6326..6a7de177 100644 Binary files a/build/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.class and b/build/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.class differ diff --git a/build/net/sf/freecol/server/control/InGameController.class b/build/net/sf/freecol/server/control/InGameController.class index f3cf2577..ef551934 100644 Binary files a/build/net/sf/freecol/server/control/InGameController.class and b/build/net/sf/freecol/server/control/InGameController.class differ diff --git a/build/net/sf/freecol/server/control/InGameInputHandler.class b/build/net/sf/freecol/server/control/InGameInputHandler.class index 50722406..58f2660d 100644 Binary files a/build/net/sf/freecol/server/control/InGameInputHandler.class and b/build/net/sf/freecol/server/control/InGameInputHandler.class differ diff --git a/build/net/sf/freecol/server/control/InputHandler.class b/build/net/sf/freecol/server/control/InputHandler.class index 68f721f0..02c9f5ca 100644 Binary files a/build/net/sf/freecol/server/control/InputHandler.class and b/build/net/sf/freecol/server/control/InputHandler.class differ diff --git a/build/net/sf/freecol/server/control/PreGameInputHandler.class b/build/net/sf/freecol/server/control/PreGameInputHandler.class index 7cd4ba4f..bafceb9a 100644 Binary files a/build/net/sf/freecol/server/control/PreGameInputHandler.class and b/build/net/sf/freecol/server/control/PreGameInputHandler.class differ diff --git a/build/net/sf/freecol/server/generator/River.class b/build/net/sf/freecol/server/generator/River.class index 4bade02f..86290ef0 100644 Binary files a/build/net/sf/freecol/server/generator/River.class and b/build/net/sf/freecol/server/generator/River.class differ diff --git a/build/net/sf/freecol/server/generator/SimpleMapGenerator.class b/build/net/sf/freecol/server/generator/SimpleMapGenerator.class index 4befa6c4..49b1cc23 100644 Binary files a/build/net/sf/freecol/server/generator/SimpleMapGenerator.class and b/build/net/sf/freecol/server/generator/SimpleMapGenerator.class differ diff --git a/build/net/sf/freecol/server/generator/TerrainGenerator.class b/build/net/sf/freecol/server/generator/TerrainGenerator.class index eea99677..95af8465 100644 Binary files a/build/net/sf/freecol/server/generator/TerrainGenerator.class and b/build/net/sf/freecol/server/generator/TerrainGenerator.class differ diff --git a/build/net/sf/freecol/server/model/ServerColony.class b/build/net/sf/freecol/server/model/ServerColony.class index abc71647..7e06d5f1 100644 Binary files a/build/net/sf/freecol/server/model/ServerColony.class and b/build/net/sf/freecol/server/model/ServerColony.class differ diff --git a/build/net/sf/freecol/server/model/ServerGame.class b/build/net/sf/freecol/server/model/ServerGame.class index 645e0bf7..d26c370d 100644 Binary files a/build/net/sf/freecol/server/model/ServerGame.class and b/build/net/sf/freecol/server/model/ServerGame.class differ diff --git a/build/net/sf/freecol/server/model/ServerPlayer.class b/build/net/sf/freecol/server/model/ServerPlayer.class index 5cc631ef..c55cf9ba 100644 Binary files a/build/net/sf/freecol/server/model/ServerPlayer.class and b/build/net/sf/freecol/server/model/ServerPlayer.class differ diff --git a/build/net/sf/freecol/server/model/ServerUnit.class b/build/net/sf/freecol/server/model/ServerUnit.class index e2730af0..251d50f2 100644 Binary files a/build/net/sf/freecol/server/model/ServerUnit.class and b/build/net/sf/freecol/server/model/ServerUnit.class differ diff --git a/build/net/sf/freecol/tools/MergeTranslations.class b/build/net/sf/freecol/tools/MergeTranslations.class index df1e5a47..fe2e5148 100644 Binary files a/build/net/sf/freecol/tools/MergeTranslations.class and b/build/net/sf/freecol/tools/MergeTranslations.class differ diff --git a/doc/Dependencies.html b/doc/Dependencies.html new file mode 100644 index 00000000..ba0a194f --- /dev/null +++ b/doc/Dependencies.html @@ -0,0 +1,29172 @@ + + + + +Dependency analysis of A_Team-finalproject-3c34732ca41925ce8300b7051cc05707ac4c330d at 5/14/17 7:59 PM + + + + + +

CodePro Dependency Analysis

+

of A_Team-finalproject-3c34732ca41925ce8300b7051cc05707ac4c330d +
at 5/14/17 7:59 PM

+

Powered by + CodePro Server and + Eclipse +

+ +
+ + +

Project Analysis

+

Project Dependency Graph

+
+ + + +A_Team-finalproject-3c34732ca41925ce8300b7051cc05707ac4c330d + +
+

Project Summary

+
+ + + + + + + + + + + + +
ProjectTotal ClassesAbstract ClassesConcrete ClassesAfferent CouplingEfferent CouplingAbstractnessInstabilityDistance
+A_Team-finalproject-3c34732ca41925ce8300b7051cc05707ac4c330d + +1034 + +92 + +942 + +0 + +891 + +0.09 + +1.0 + +0.09 +
+
+

Project Details

+
+

A_Team-finalproject-3c34732ca41925ce8300b7051cc05707ac4c330d

+ + + + + + +
Afferent Couplings: 0Efferent Couplings: 891Abstractness: 0.09Instability: 1.0Distance: 0.09
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing ProjectsReferenced Projects
+net.sf.freecol.client.control.InputHandler +
net.sf.freecol.client.control.MapEditorController$IMapTransform +
net.sf.freecol.client.gui.DialogHandler +
net.sf.freecol.client.gui.OutForAnimationCallback +
net.sf.freecol.client.gui.action.FreeColAction +
net.sf.freecol.client.gui.action.MapboardAction +
net.sf.freecol.client.gui.action.SelectableAction +
net.sf.freecol.client.gui.action.UnitAction +
net.sf.freecol.client.gui.menu.FreeColMenuBar +
net.sf.freecol.client.gui.option.OptionOneUI +
net.sf.freecol.client.gui.option.OptionUI +
net.sf.freecol.client.gui.option.OptionUpdater +
net.sf.freecol.client.gui.panel.ColopediaDetailPanel +
net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
net.sf.freecol.client.gui.panel.Draggable +
net.sf.freecol.client.gui.panel.DropTarget +
net.sf.freecol.client.gui.panel.FreeColInputDialog +
net.sf.freecol.client.gui.panel.FreeColPanel +
net.sf.freecol.client.gui.panel.InPortPanel +
net.sf.freecol.client.gui.panel.LabourData$LocationData$Getter +
net.sf.freecol.client.gui.panel.MapControls +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$MapTransform +
net.sf.freecol.client.gui.panel.OptionsDialog +
net.sf.freecol.client.gui.panel.PortPanel +
net.sf.freecol.client.gui.panel.ReportUnitPanel +
net.sf.freecol.client.gui.panel.UnitPanel +
net.sf.freecol.client.gui.video.VideoListener +
net.sf.freecol.common.ObjectWithId +
net.sf.freecol.common.i18n.Number +
net.sf.freecol.common.i18n.Selector +
net.sf.freecol.common.io.sza.AnimationEvent +
net.sf.freecol.common.io.sza.ImageAnimationEvent +
net.sf.freecol.common.model.BuildableType +
net.sf.freecol.common.model.CombatModel +
net.sf.freecol.common.model.Consumer +
net.sf.freecol.common.model.Feature +
net.sf.freecol.common.model.FreeColGameObject +
net.sf.freecol.common.model.FreeColGameObjectListener +
net.sf.freecol.common.model.FreeColGameObjectType +
net.sf.freecol.common.model.FreeColObject +
net.sf.freecol.common.model.GoodsLocation +
net.sf.freecol.common.model.Locatable +
net.sf.freecol.common.model.Location +
net.sf.freecol.common.model.Map$SearchHeuristic +
net.sf.freecol.common.model.Movable +
net.sf.freecol.common.model.Nameable +
net.sf.freecol.common.model.Named +
net.sf.freecol.common.model.NationType +
net.sf.freecol.common.model.Ownable +
net.sf.freecol.common.model.Player$UnitPredicate +
net.sf.freecol.common.model.Settlement +
net.sf.freecol.common.model.Specification$ChildReader +
net.sf.freecol.common.model.TileItem +
net.sf.freecol.common.model.TradeItem +
net.sf.freecol.common.model.TradeLocation +
net.sf.freecol.common.model.TransactionListener +
net.sf.freecol.common.model.UnitLocation +
net.sf.freecol.common.model.WorkLocation +
net.sf.freecol.common.model.mission.AbstractMission +
net.sf.freecol.common.model.mission.Mission +
net.sf.freecol.common.model.pathfinding.CostDecider +
net.sf.freecol.common.model.pathfinding.GoalDecider +
net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler +
net.sf.freecol.common.networking.MessageHandler +
net.sf.freecol.common.networking.NetworkConstants +
net.sf.freecol.common.networking.NetworkRequestHandler +
net.sf.freecol.common.networking.ServerAPI +
net.sf.freecol.common.option.AbstractOption +
net.sf.freecol.common.option.ListOption +
net.sf.freecol.common.option.Option +
net.sf.freecol.common.resources.Resource +
net.sf.freecol.common.resources.Resource$Cleanable +
net.sf.freecol.common.resources.Resource$Preloadable +
net.sf.freecol.common.resources.ResourceFactory$ResourceSink +
net.sf.freecol.common.util.Xml$Method +
net.sf.freecol.server.ai.AIObject +
net.sf.freecol.server.ai.AIPlayer +
net.sf.freecol.server.ai.TransportableAIObject +
net.sf.freecol.server.ai.ValuedAIObject +
net.sf.freecol.server.ai.Wish +
net.sf.freecol.server.ai.goal.Goal +
net.sf.freecol.server.ai.goal.GoalConstants +
net.sf.freecol.server.ai.mission.Mission +
net.sf.freecol.server.control.ChangeSet$Change +
net.sf.freecol.server.control.Controller +
net.sf.freecol.server.control.InGameController$DOMMessageHandler +
net.sf.freecol.server.control.InputHandler +
net.sf.freecol.server.generator.MapGenerator +
net.sf.freecol.server.generator.MapLayerGenerator +
net.sf.freecol.server.generator.MapLoader +
net.sf.freecol.server.model.ServerModelObject +
net.sf.freecol.server.model.TransactionSession +
+net.sf.freecol.AllTests +
net.sf.freecol.FreeCol +
net.sf.freecol.client.AllTests +
net.sf.freecol.client.ClientOptions +
net.sf.freecol.client.ClientOptions$MessageSourceComparator +
net.sf.freecol.client.ClientTestHelper +
net.sf.freecol.client.FreeColClient +
net.sf.freecol.client.Worker +
net.sf.freecol.client.WorkerCheck +
net.sf.freecol.client.WorkerCheck$TestJob +
net.sf.freecol.client.control.AllTests +
net.sf.freecol.client.control.ConnectController +
net.sf.freecol.client.control.ConnectController$ErrorJob +
net.sf.freecol.client.control.InGameController +
net.sf.freecol.client.control.InGameController$ArmedUnitSettlementAction +
net.sf.freecol.client.control.InGameController$BoycottAction +
net.sf.freecol.client.control.InGameController$BuyAction +
net.sf.freecol.client.control.InGameController$ClaimAction +
net.sf.freecol.client.control.InGameController$MissionaryAction +
net.sf.freecol.client.control.InGameController$MoveMode +
net.sf.freecol.client.control.InGameController$ScoutColonyAction +
net.sf.freecol.client.control.InGameController$ScoutIndianSettlementAction +
net.sf.freecol.client.control.InGameController$SellAction +
net.sf.freecol.client.control.InGameController$TradeAction +
net.sf.freecol.client.control.InGameInputHandler +
net.sf.freecol.client.control.MapEditorController +
net.sf.freecol.client.control.MapEditorController$ErrorJob +
net.sf.freecol.client.control.MoveTest +
net.sf.freecol.client.control.PreGameController +
net.sf.freecol.client.control.PreGameInputHandler +
net.sf.freecol.client.control.SoundController +
net.sf.freecol.client.gui.AbstractCanvasListener +
net.sf.freecol.client.gui.AllTests +
net.sf.freecol.client.gui.Canvas +
net.sf.freecol.client.gui.Canvas$DialogCallback +
net.sf.freecol.client.gui.Canvas$ToolBoxFrame +
net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
net.sf.freecol.client.gui.CanvasMouseListener +
net.sf.freecol.client.gui.CanvasMouseMotionListener +
net.sf.freecol.client.gui.ChatDisplay +
net.sf.freecol.client.gui.ChoiceItem +
net.sf.freecol.client.gui.FontLibrary +
net.sf.freecol.client.gui.FontLibrary$FontSize +
net.sf.freecol.client.gui.FontLibrary$FontType +
net.sf.freecol.client.gui.FontTest +
net.sf.freecol.client.gui.FrameMotionListener +
net.sf.freecol.client.gui.FreeColFrame +
net.sf.freecol.client.gui.FullScreenFrameListener +
net.sf.freecol.client.gui.GUI +
net.sf.freecol.client.gui.GUIMessage +
net.sf.freecol.client.gui.GrayLayer +
net.sf.freecol.client.gui.ImageLibrary +
net.sf.freecol.client.gui.ImageLibrary$PathType +
net.sf.freecol.client.gui.LoadingSavegameInfo +
net.sf.freecol.client.gui.MapViewer +
net.sf.freecol.client.gui.MapViewer$BorderType +
net.sf.freecol.client.gui.MapViewer$TextSpecification +
net.sf.freecol.client.gui.RoadPainter +
net.sf.freecol.client.gui.ScrollThread +
net.sf.freecol.client.gui.SwingGUI +
net.sf.freecol.client.gui.SwingGUI$AbortListener +
net.sf.freecol.client.gui.TerrainCursor +
net.sf.freecol.client.gui.TilePopup +
net.sf.freecol.client.gui.TileViewer +
net.sf.freecol.client.gui.TileViewer$SortableImage +
net.sf.freecol.client.gui.WindowedFrameListener +
net.sf.freecol.client.gui.action.AboutAction +
net.sf.freecol.client.gui.action.ActionManager +
net.sf.freecol.client.gui.action.AssignTradeRouteAction +
net.sf.freecol.client.gui.action.BuildColonyAction +
net.sf.freecol.client.gui.action.CenterAction +
net.sf.freecol.client.gui.action.ChangeAction +
net.sf.freecol.client.gui.action.ChangeWindowedModeAction +
net.sf.freecol.client.gui.action.ChatAction +
net.sf.freecol.client.gui.action.ClearOrdersAction +
net.sf.freecol.client.gui.action.ColopediaAction +
net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
net.sf.freecol.client.gui.action.ContinueAction +
net.sf.freecol.client.gui.action.DebugAction +
net.sf.freecol.client.gui.action.DeclareIndependenceAction +
net.sf.freecol.client.gui.action.DetermineHighSeasAction +
net.sf.freecol.client.gui.action.DisbandUnitAction +
net.sf.freecol.client.gui.action.DisplayBordersAction +
net.sf.freecol.client.gui.action.DisplayGridAction +
net.sf.freecol.client.gui.action.DisplayTileTextAction +
net.sf.freecol.client.gui.action.DisplayTileTextAction$DisplayText +
net.sf.freecol.client.gui.action.EndTurnAction +
net.sf.freecol.client.gui.action.EuropeAction +
net.sf.freecol.client.gui.action.ExecuteGotoOrdersAction +
net.sf.freecol.client.gui.action.FindSettlementAction +
net.sf.freecol.client.gui.action.FortifyAction +
net.sf.freecol.client.gui.action.FreeColAction$InnerMenuKeyListener +
net.sf.freecol.client.gui.action.GotoAction +
net.sf.freecol.client.gui.action.GotoTileAction +
net.sf.freecol.client.gui.action.ImprovementAction +
net.sf.freecol.client.gui.action.LoadAction +
net.sf.freecol.client.gui.action.MapControlsAction +
net.sf.freecol.client.gui.action.MapEditorAction +
net.sf.freecol.client.gui.action.MiniMapToggleFogOfWarAction +
net.sf.freecol.client.gui.action.MiniMapToggleViewAction +
net.sf.freecol.client.gui.action.MiniMapZoomInAction +
net.sf.freecol.client.gui.action.MiniMapZoomOutAction +
net.sf.freecol.client.gui.action.MoveAction +
net.sf.freecol.client.gui.action.NewAction +
net.sf.freecol.client.gui.action.NewEmptyMapAction +
net.sf.freecol.client.gui.action.OpenAction +
net.sf.freecol.client.gui.action.PreferencesAction +
net.sf.freecol.client.gui.action.QuitAction +
net.sf.freecol.client.gui.action.ReconnectAction +
net.sf.freecol.client.gui.action.RenameAction +
net.sf.freecol.client.gui.action.ReportCargoAction +
net.sf.freecol.client.gui.action.ReportColonyAction +
net.sf.freecol.client.gui.action.ReportContinentalCongressAction +
net.sf.freecol.client.gui.action.ReportEducationAction +
net.sf.freecol.client.gui.action.ReportExplorationAction +
net.sf.freecol.client.gui.action.ReportForeignAction +
net.sf.freecol.client.gui.action.ReportHighScoresAction +
net.sf.freecol.client.gui.action.ReportHistoryAction +
net.sf.freecol.client.gui.action.ReportIndianAction +
net.sf.freecol.client.gui.action.ReportLabourAction +
net.sf.freecol.client.gui.action.ReportMilitaryAction +
net.sf.freecol.client.gui.action.ReportNavalAction +
net.sf.freecol.client.gui.action.ReportProductionAction +
net.sf.freecol.client.gui.action.ReportReligionAction +
net.sf.freecol.client.gui.action.ReportRequirementsAction +
net.sf.freecol.client.gui.action.ReportTradeAction +
net.sf.freecol.client.gui.action.ReportTurnAction +
net.sf.freecol.client.gui.action.RetireAction +
net.sf.freecol.client.gui.action.SaveAction +
net.sf.freecol.client.gui.action.SaveAndQuitAction +
net.sf.freecol.client.gui.action.ScaleMapAction +
net.sf.freecol.client.gui.action.SentryAction +
net.sf.freecol.client.gui.action.ShowDifficultyAction +
net.sf.freecol.client.gui.action.ShowGameOptionsAction +
net.sf.freecol.client.gui.action.ShowMainAction +
net.sf.freecol.client.gui.action.ShowMapGeneratorOptionsAction +
net.sf.freecol.client.gui.action.SkipUnitAction +
net.sf.freecol.client.gui.action.TilePopupAction +
net.sf.freecol.client.gui.action.ToggleViewModeAction +
net.sf.freecol.client.gui.action.TradeRouteAction +
net.sf.freecol.client.gui.action.UnloadAction +
net.sf.freecol.client.gui.action.WaitAction +
net.sf.freecol.client.gui.action.ZoomInAction +
net.sf.freecol.client.gui.action.ZoomOutAction +
net.sf.freecol.client.gui.animation.Animations +
net.sf.freecol.client.gui.animation.UnitAttackAnimation +
net.sf.freecol.client.gui.animation.UnitImageAnimation +
net.sf.freecol.client.gui.animation.UnitMoveAnimation +
net.sf.freecol.client.gui.menu.DebugMenu +
net.sf.freecol.client.gui.menu.FreeColMenuTest +
net.sf.freecol.client.gui.menu.InGameMenuBar +
net.sf.freecol.client.gui.menu.MapEditorMenuBar +
net.sf.freecol.client.gui.menu.MenuMouseMotionListener +
net.sf.freecol.client.gui.option.AbstractUnitOptionUI +
net.sf.freecol.client.gui.option.AbstractUnitOptionUI$AbstractUnitRenderer +
net.sf.freecol.client.gui.option.AbstractUnitOptionUI$RoleRenderer +
net.sf.freecol.client.gui.option.AudioMixerOptionUI +
net.sf.freecol.client.gui.option.BooleanOptionUI +
net.sf.freecol.client.gui.option.FileOptionUI +
net.sf.freecol.client.gui.option.FreeColActionUI +
net.sf.freecol.client.gui.option.FreeColActionUI$BlinkingLabel +
net.sf.freecol.client.gui.option.IntegerOptionUI +
net.sf.freecol.client.gui.option.LanguageOptionUI +
net.sf.freecol.client.gui.option.ListOptionUI +
net.sf.freecol.client.gui.option.ModOptionUI +
net.sf.freecol.client.gui.option.ModOptionUI$BoxRenderer +
net.sf.freecol.client.gui.option.ModOptionUI$ModOptionRenderer +
net.sf.freecol.client.gui.option.OptionGroupUI +
net.sf.freecol.client.gui.option.PercentageOptionUI +
net.sf.freecol.client.gui.option.RangeOptionUI +
net.sf.freecol.client.gui.option.SelectOptionUI +
net.sf.freecol.client.gui.option.SliderOptionUI +
net.sf.freecol.client.gui.option.StringOptionUI +
net.sf.freecol.client.gui.option.TextOptionUI +
net.sf.freecol.client.gui.option.UnitTypeOptionUI +
net.sf.freecol.client.gui.option.UnitTypeOptionUI$ChoiceRenderer +
net.sf.freecol.client.gui.panel.AboutPanel +
net.sf.freecol.client.gui.panel.AbstractGoodsLabel +
net.sf.freecol.client.gui.panel.BuildQueuePanel +
net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueMouseAdapter +
net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueTransferHandler +
net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable +
net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer +
net.sf.freecol.client.gui.panel.BuildingDetailPanel +
net.sf.freecol.client.gui.panel.BuildingPanel +
net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel +
net.sf.freecol.client.gui.panel.BuildingToolTip +
net.sf.freecol.client.gui.panel.CaptureGoodsDialog +
net.sf.freecol.client.gui.panel.CaptureGoodsDialog$CheckBoxRenderer +
net.sf.freecol.client.gui.panel.CaptureGoodsDialog$GoodsItem +
net.sf.freecol.client.gui.panel.CargoPanel +
net.sf.freecol.client.gui.panel.ChatPanel +
net.sf.freecol.client.gui.panel.ChooseFoundingFatherDialog +
net.sf.freecol.client.gui.panel.ClassicMapControls +
net.sf.freecol.client.gui.panel.ClientOptionsDialog +
net.sf.freecol.client.gui.panel.ColonyPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$ColonyCargoPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$ColonyInPortPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
net.sf.freecol.client.gui.panel.ColopediaPanel +
net.sf.freecol.client.gui.panel.ColopediaTreeCellRenderer +
net.sf.freecol.client.gui.panel.ColopediaTreeItem +
net.sf.freecol.client.gui.panel.ColorCellEditor +
net.sf.freecol.client.gui.panel.ColorCellRenderer +
net.sf.freecol.client.gui.panel.ColorChooserPanel +
net.sf.freecol.client.gui.panel.CompactLabourReport +
net.sf.freecol.client.gui.panel.ConceptDetailPanel +
net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog +
net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog$ColorButton +
net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog$EnumRenderer +
net.sf.freecol.client.gui.panel.ConstructionPanel +
net.sf.freecol.client.gui.panel.CornerMapControls +
net.sf.freecol.client.gui.panel.CornerMapControls$MiniMapPanel +
net.sf.freecol.client.gui.panel.DeclarationPanel +
net.sf.freecol.client.gui.panel.DeclarationPanel$SignaturePanel +
net.sf.freecol.client.gui.panel.DefaultTransferHandler +
net.sf.freecol.client.gui.panel.DefaultTransferHandler$FreeColDragGestureRecognizer +
net.sf.freecol.client.gui.panel.DefaultTransferHandler$FreeColDragHandler +
net.sf.freecol.client.gui.panel.DifficultyDialog +
net.sf.freecol.client.gui.panel.DragListener +
net.sf.freecol.client.gui.panel.DropListener +
net.sf.freecol.client.gui.panel.DumpCargoDialog +
net.sf.freecol.client.gui.panel.EditOptionDialog +
net.sf.freecol.client.gui.panel.EditSettlementDialog +
net.sf.freecol.client.gui.panel.EmigrationDialog +
net.sf.freecol.client.gui.panel.EndTurnDialog +
net.sf.freecol.client.gui.panel.EndTurnDialog$UnitCellRenderer +
net.sf.freecol.client.gui.panel.EndTurnDialog$UnitWrapper +
net.sf.freecol.client.gui.panel.ErrorPanel +
net.sf.freecol.client.gui.panel.EuropePanel +
net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
net.sf.freecol.client.gui.panel.EuropePanel$DocksPanel +
net.sf.freecol.client.gui.panel.EuropePanel$EuropeButton +
net.sf.freecol.client.gui.panel.EuropePanel$EuropeInPortPanel +
net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel +
net.sf.freecol.client.gui.panel.EuropePanel$TransactionLog +
net.sf.freecol.client.gui.panel.EventPanel +
net.sf.freecol.client.gui.panel.FatherDetailPanel +
net.sf.freecol.client.gui.panel.FindSettlementPanel +
net.sf.freecol.client.gui.panel.FindSettlementPanel$SettlementRenderer +
net.sf.freecol.client.gui.panel.FirstContactDialog +
net.sf.freecol.client.gui.panel.Flag +
net.sf.freecol.client.gui.panel.Flag$Alignment +
net.sf.freecol.client.gui.panel.Flag$Background +
net.sf.freecol.client.gui.panel.Flag$Decoration +
net.sf.freecol.client.gui.panel.Flag$UnionPosition +
net.sf.freecol.client.gui.panel.Flag$UnionShape +
net.sf.freecol.client.gui.panel.FreeColChoiceDialog +
net.sf.freecol.client.gui.panel.FreeColConfirmDialog +
net.sf.freecol.client.gui.panel.FreeColDialog +
net.sf.freecol.client.gui.panel.FreeColDialog$DialogType +
net.sf.freecol.client.gui.panel.FreeColImageBorder +
net.sf.freecol.client.gui.panel.FreeColProgressBar +
net.sf.freecol.client.gui.panel.FreeColStringInputDialog +
net.sf.freecol.client.gui.panel.GameOptionsDialog +
net.sf.freecol.client.gui.panel.GoodsDetailPanel +
net.sf.freecol.client.gui.panel.GoodsLabel +
net.sf.freecol.client.gui.panel.ImageSelection +
net.sf.freecol.client.gui.panel.IndianSettlementPanel +
net.sf.freecol.client.gui.panel.InfoPanel +
net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel +
net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
net.sf.freecol.client.gui.panel.InformationPanel +
net.sf.freecol.client.gui.panel.LabourData +
net.sf.freecol.client.gui.panel.LabourData$LocationData +
net.sf.freecol.client.gui.panel.LabourData$ProductionData +
net.sf.freecol.client.gui.panel.LabourData$UnitData +
net.sf.freecol.client.gui.panel.LoadDialog +
net.sf.freecol.client.gui.panel.LoadingSavegameDialog +
net.sf.freecol.client.gui.panel.MainPanel +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$LostCityRumourTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$ResourceTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$RiverTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$TileTypeTransform +
net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
net.sf.freecol.client.gui.panel.MapSizeDialog +
net.sf.freecol.client.gui.panel.MarketLabel +
net.sf.freecol.client.gui.panel.MigPanel +
net.sf.freecol.client.gui.panel.MiniMap +
net.sf.freecol.client.gui.panel.ModifierFormat +
net.sf.freecol.client.gui.panel.MonarchDialog +
net.sf.freecol.client.gui.panel.NationDetailPanel +
net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog +
net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$GoodsTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$GoodsTradeItemPanel$GoodsBoxRenderer +
net.sf.freecol.client.gui.panel.NegotiationDialog$InciteTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$InciteTradeItemPanel$InciteBoxRenderer +
net.sf.freecol.client.gui.panel.NegotiationDialog$RemoveAction +
net.sf.freecol.client.gui.panel.NegotiationDialog$StanceTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$StanceTradeItemPanel$StanceBoxRenderer +
net.sf.freecol.client.gui.panel.NegotiationDialog$UnitTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$UnitTradeItemPanel$UnitBoxRenderer +
net.sf.freecol.client.gui.panel.NewPanel +
net.sf.freecol.client.gui.panel.NewPanel$NewPanelAction +
net.sf.freecol.client.gui.panel.NewUnitPanel +
net.sf.freecol.client.gui.panel.Parameters +
net.sf.freecol.client.gui.panel.ParametersDialog +
net.sf.freecol.client.gui.panel.PlayersTable +
net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellEditor +
net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellEditor +
net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$HeaderListener +
net.sf.freecol.client.gui.panel.PlayersTable$HeaderRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$NationCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$NationStateRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellEditor +
net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
net.sf.freecol.client.gui.panel.PreCombatDialog +
net.sf.freecol.client.gui.panel.ProductionLabel +
net.sf.freecol.client.gui.panel.PurchasePanel +
net.sf.freecol.client.gui.panel.QuickActionMenu +
net.sf.freecol.client.gui.panel.RebelToolTip +
net.sf.freecol.client.gui.panel.RecruitPanel +
net.sf.freecol.client.gui.panel.ReportCargoPanel +
net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel$ColonySummary +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel$ColonySummary$GoodsProduction +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel$ColonySummary$ProductionStatus +
net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
net.sf.freecol.client.gui.panel.ReportEducationPanel +
net.sf.freecol.client.gui.panel.ReportExplorationPanel +
net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
net.sf.freecol.client.gui.panel.ReportHistoryPanel +
net.sf.freecol.client.gui.panel.ReportIndianPanel +
net.sf.freecol.client.gui.panel.ReportLabourDetailPanel +
net.sf.freecol.client.gui.panel.ReportLabourPanel +
net.sf.freecol.client.gui.panel.ReportLabourPanel$LabourUnitPanel +
net.sf.freecol.client.gui.panel.ReportLabourPanel$LabourUnitPanelRenderer +
net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
net.sf.freecol.client.gui.panel.ReportNavalPanel +
net.sf.freecol.client.gui.panel.ReportPanel +
net.sf.freecol.client.gui.panel.ReportProductionPanel +
net.sf.freecol.client.gui.panel.ReportReligiousPanel +
net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
net.sf.freecol.client.gui.panel.ReportTradePanel +
net.sf.freecol.client.gui.panel.ReportTurnPanel +
net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
net.sf.freecol.client.gui.panel.RiverStyleDialog +
net.sf.freecol.client.gui.panel.SaveDialog +
net.sf.freecol.client.gui.panel.ScaleMapSizeDialog +
net.sf.freecol.client.gui.panel.SelectAmountDialog +
net.sf.freecol.client.gui.panel.SelectDestinationDialog +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$DestinationComparator +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$DistanceComparator +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$LocationRenderer +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$NameComparator +
net.sf.freecol.client.gui.panel.SelectTributeAmountDialog +
net.sf.freecol.client.gui.panel.ServerListPanel +
net.sf.freecol.client.gui.panel.ServerListTableModel +
net.sf.freecol.client.gui.panel.StartGamePanel +
net.sf.freecol.client.gui.panel.StatisticsPanel +
net.sf.freecol.client.gui.panel.StatisticsPanel$StatisticsModel +
net.sf.freecol.client.gui.panel.StatusPanel +
net.sf.freecol.client.gui.panel.TerrainDetailPanel +
net.sf.freecol.client.gui.panel.TilePanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoHandler +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoLabel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoPanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$DestinationCellRenderer +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$GoodsPanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListHandler +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListTransferable +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
net.sf.freecol.client.gui.panel.TradeRoutePanel +
net.sf.freecol.client.gui.panel.TrainPanel +
net.sf.freecol.client.gui.panel.UnitButton +
net.sf.freecol.client.gui.panel.UnitButton$UnitButtonActionPropertyChangeListener +
net.sf.freecol.client.gui.panel.UnitDetailPanel +
net.sf.freecol.client.gui.panel.UnitLabel +
net.sf.freecol.client.gui.panel.UnitLabel$UnitAction +
net.sf.freecol.client.gui.panel.Utility +
net.sf.freecol.client.gui.panel.VictoryDialog +
net.sf.freecol.client.gui.panel.WarehouseDialog +
net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
net.sf.freecol.client.gui.panel.WorkProductionPanel +
net.sf.freecol.client.gui.plaf.FreeColBrightPanelUI +
net.sf.freecol.client.gui.plaf.FreeColButtonUI +
net.sf.freecol.client.gui.plaf.FreeColCheckBoxUI +
net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer +
net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer$NormalComponent +
net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer$SelectedComponent +
net.sf.freecol.client.gui.plaf.FreeColComboBoxUI +
net.sf.freecol.client.gui.plaf.FreeColFileChooserUI +
net.sf.freecol.client.gui.plaf.FreeColLabelUI +
net.sf.freecol.client.gui.plaf.FreeColListUI +
net.sf.freecol.client.gui.plaf.FreeColLookAndFeel +
net.sf.freecol.client.gui.plaf.FreeColMenuBarUI +
net.sf.freecol.client.gui.plaf.FreeColMenuItemUI +
net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI +
net.sf.freecol.client.gui.plaf.FreeColPanelUI +
net.sf.freecol.client.gui.plaf.FreeColPopupMenuUI +
net.sf.freecol.client.gui.plaf.FreeColRadioButtonUI +
net.sf.freecol.client.gui.plaf.FreeColScrollPaneUI +
net.sf.freecol.client.gui.plaf.FreeColSelectedPanelUI +
net.sf.freecol.client.gui.plaf.FreeColTableHeaderUI +
net.sf.freecol.client.gui.plaf.FreeColTableUI +
net.sf.freecol.client.gui.plaf.FreeColTextAreaUI +
net.sf.freecol.client.gui.plaf.FreeColTextFieldUI +
net.sf.freecol.client.gui.plaf.FreeColToolTipUI +
net.sf.freecol.client.gui.plaf.FreeColTransparentPanelUI +
net.sf.freecol.client.gui.plaf.LAFUtilities +
net.sf.freecol.client.gui.video.VideoComponent +
net.sf.freecol.client.networking.UserServerAPI +
net.sf.freecol.common.AllTests +
net.sf.freecol.common.FreeColException +
net.sf.freecol.common.FreeColSeed +
net.sf.freecol.common.ServerInfo +
net.sf.freecol.common.debug.DebugUtils +
net.sf.freecol.common.debug.FreeColDebugger +
net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
net.sf.freecol.common.i18n.AllTests +
net.sf.freecol.common.i18n.CLDRTest +
net.sf.freecol.common.i18n.DefaultNumberRule +
net.sf.freecol.common.i18n.DualNumberRule +
net.sf.freecol.common.i18n.Merge +
net.sf.freecol.common.i18n.MergeTableCellRenderer +
net.sf.freecol.common.i18n.MergeTableModel +
net.sf.freecol.common.i18n.MessageMerge +
net.sf.freecol.common.i18n.Messages +
net.sf.freecol.common.i18n.MessagesTest +
net.sf.freecol.common.i18n.NameCache +
net.sf.freecol.common.i18n.Number$Category +
net.sf.freecol.common.i18n.NumberRules +
net.sf.freecol.common.i18n.OtherNumberRule +
net.sf.freecol.common.i18n.PluralNumberRule +
net.sf.freecol.common.i18n.Relation +
net.sf.freecol.common.i18n.Rule +
net.sf.freecol.common.i18n.ZeroOneNumberRule +
net.sf.freecol.common.io.AllTests +
net.sf.freecol.common.io.FreeColDataFile +
net.sf.freecol.common.io.FreeColDirectories +
net.sf.freecol.common.io.FreeColModFile +
net.sf.freecol.common.io.FreeColSavegameFile +
net.sf.freecol.common.io.FreeColTcFile +
net.sf.freecol.common.io.FreeColXMLReader +
net.sf.freecol.common.io.FreeColXMLReader$ReadScope +
net.sf.freecol.common.io.FreeColXMLWriter +
net.sf.freecol.common.io.FreeColXMLWriter$WriteScope +
net.sf.freecol.common.io.ModTest +
net.sf.freecol.common.io.Mods +
net.sf.freecol.common.io.sza.SimpleZippedAnimation +
net.sf.freecol.common.io.sza.SimpleZippedAnimation$ImageAnimationEventImpl +
net.sf.freecol.common.logging.DefaultHandler +
net.sf.freecol.common.logging.TextFormatter +
net.sf.freecol.common.model.Ability +
net.sf.freecol.common.model.AbstractGoods +
net.sf.freecol.common.model.AbstractUnit +
net.sf.freecol.common.model.AllTests +
net.sf.freecol.common.model.BaseCostDeciderTest +
net.sf.freecol.common.model.BuildQueue +
net.sf.freecol.common.model.BuildQueue$CompletionAction +
net.sf.freecol.common.model.Building +
net.sf.freecol.common.model.BuildingTest +
net.sf.freecol.common.model.BuildingType +
net.sf.freecol.common.model.Colony +
net.sf.freecol.common.model.Colony$ColonyChangeEvent +
net.sf.freecol.common.model.Colony$NoBuildReason +
net.sf.freecol.common.model.Colony$TileImprovementSuggestion +
net.sf.freecol.common.model.ColonyProductionTest +
net.sf.freecol.common.model.ColonyTest +
net.sf.freecol.common.model.ColonyTile +
net.sf.freecol.common.model.ColonyTradeItem +
net.sf.freecol.common.model.ColonyWas +
net.sf.freecol.common.model.CombatModel$CombatOdds +
net.sf.freecol.common.model.CombatModel$CombatResult +
net.sf.freecol.common.model.CombatTest +
net.sf.freecol.common.model.DiplomaticTrade +
net.sf.freecol.common.model.DiplomaticTrade$TradeContext +
net.sf.freecol.common.model.DiplomaticTrade$TradeStatus +
net.sf.freecol.common.model.Direction +
net.sf.freecol.common.model.Disaster +
net.sf.freecol.common.model.Disaster$Effects +
net.sf.freecol.common.model.DisasterTest +
net.sf.freecol.common.model.Effect +
net.sf.freecol.common.model.EquipmentType +
net.sf.freecol.common.model.Europe +
net.sf.freecol.common.model.Europe$MigrationType +
net.sf.freecol.common.model.EuropeTest +
net.sf.freecol.common.model.EuropeWas +
net.sf.freecol.common.model.EuropeanNationType +
net.sf.freecol.common.model.Event +
net.sf.freecol.common.model.ExportData +
net.sf.freecol.common.model.FeatureContainer +
net.sf.freecol.common.model.FoundingFather +
net.sf.freecol.common.model.FoundingFather$FoundingFatherType +
net.sf.freecol.common.model.FoundingFatherTest +
net.sf.freecol.common.model.Game +
net.sf.freecol.common.model.Game$FcgoState +
net.sf.freecol.common.model.GameOptions +
net.sf.freecol.common.model.GameTest +
net.sf.freecol.common.model.GoldTradeItem +
net.sf.freecol.common.model.Goods +
net.sf.freecol.common.model.GoodsContainer +
net.sf.freecol.common.model.GoodsContainerTest +
net.sf.freecol.common.model.GoodsTest +
net.sf.freecol.common.model.GoodsTradeItem +
net.sf.freecol.common.model.GoodsType +
net.sf.freecol.common.model.HighScore +
net.sf.freecol.common.model.HighScore$ScoreLevel +
net.sf.freecol.common.model.HighSeas +
net.sf.freecol.common.model.HighSeasTest +
net.sf.freecol.common.model.HistoryEvent +
net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
net.sf.freecol.common.model.InciteTradeItem +
net.sf.freecol.common.model.IndianNationType +
net.sf.freecol.common.model.IndianSettlement +
net.sf.freecol.common.model.IndianSettlement$ContactLevel +
net.sf.freecol.common.model.IndianSettlementTest +
net.sf.freecol.common.model.IndividualFatherTest +
net.sf.freecol.common.model.LandMap +
net.sf.freecol.common.model.LastSale +
net.sf.freecol.common.model.Limit +
net.sf.freecol.common.model.Limit$Operator +
net.sf.freecol.common.model.LimitTest +
net.sf.freecol.common.model.LostCityRumour +
net.sf.freecol.common.model.LostCityRumour$RumourType +
net.sf.freecol.common.model.Map +
net.sf.freecol.common.model.Map$CircleIterator +
net.sf.freecol.common.model.Map$Layer +
net.sf.freecol.common.model.Map$MoveCandidate +
net.sf.freecol.common.model.Map$MoveStep +
net.sf.freecol.common.model.Map$Position +
net.sf.freecol.common.model.Map$WholeMapIterator +
net.sf.freecol.common.model.MapTest +
net.sf.freecol.common.model.Market +
net.sf.freecol.common.model.Market$Access +
net.sf.freecol.common.model.MarketData +
net.sf.freecol.common.model.MarketTest +
net.sf.freecol.common.model.MarketWas +
net.sf.freecol.common.model.ModelMessage +
net.sf.freecol.common.model.ModelMessage$MessageType +
net.sf.freecol.common.model.ModelMessageTest +
net.sf.freecol.common.model.Modifier +
net.sf.freecol.common.model.Modifier$ModifierType +
net.sf.freecol.common.model.ModifierTest +
net.sf.freecol.common.model.Monarch +
net.sf.freecol.common.model.Monarch$Force +
net.sf.freecol.common.model.Monarch$MonarchAction +
net.sf.freecol.common.model.MonarchTest +
net.sf.freecol.common.model.MovementTest +
net.sf.freecol.common.model.Nation +
net.sf.freecol.common.model.NationOptions +
net.sf.freecol.common.model.NationOptions$Advantages +
net.sf.freecol.common.model.NationOptions$NationState +
net.sf.freecol.common.model.NationSummary +
net.sf.freecol.common.model.NationType$AggressionLevel +
net.sf.freecol.common.model.NationType$SettlementNumber +
net.sf.freecol.common.model.NationTypeTest +
net.sf.freecol.common.model.Occupation +
net.sf.freecol.common.model.Operand +
net.sf.freecol.common.model.Operand$OperandType +
net.sf.freecol.common.model.Operand$ScopeLevel +
net.sf.freecol.common.model.PathNode +
net.sf.freecol.common.model.PathfindingTest +
net.sf.freecol.common.model.Player +
net.sf.freecol.common.model.Player$ActivePredicate +
net.sf.freecol.common.model.Player$ColonyValueCategory +
net.sf.freecol.common.model.Player$GoingToPredicate +
net.sf.freecol.common.model.Player$NoClaimReason +
net.sf.freecol.common.model.Player$NoValueType +
net.sf.freecol.common.model.Player$PlayerType +
net.sf.freecol.common.model.Player$UnitIterator +
net.sf.freecol.common.model.PlayerExploredTile +
net.sf.freecol.common.model.PlayerTest +
net.sf.freecol.common.model.ProductionCache +
net.sf.freecol.common.model.ProductionInfo +
net.sf.freecol.common.model.ProductionMap +
net.sf.freecol.common.model.ProductionMap$ProductionTree +
net.sf.freecol.common.model.ProductionType +
net.sf.freecol.common.model.ProductionTypeTest +
net.sf.freecol.common.model.RandomRange +
net.sf.freecol.common.model.RandomRangeTest +
net.sf.freecol.common.model.Region +
net.sf.freecol.common.model.Region$RegionType +
net.sf.freecol.common.model.Resource +
net.sf.freecol.common.model.ResourceType +
net.sf.freecol.common.model.Role +
net.sf.freecol.common.model.Role$RoleChange +
net.sf.freecol.common.model.RoleTest +
net.sf.freecol.common.model.SchoolTest +
net.sf.freecol.common.model.SchoolTest$SchoolLevel +
net.sf.freecol.common.model.Scope +
net.sf.freecol.common.model.ScopeTest +
net.sf.freecol.common.model.SerializationTest +
net.sf.freecol.common.model.SettlementTest +
net.sf.freecol.common.model.SettlementType +
net.sf.freecol.common.model.SimpleCombatModel +
net.sf.freecol.common.model.SoLTest +
net.sf.freecol.common.model.Specification +
net.sf.freecol.common.model.Specification$ModifierReader +
net.sf.freecol.common.model.Specification$OptionReader +
net.sf.freecol.common.model.Specification$Source +
net.sf.freecol.common.model.Specification$TypeReader +
net.sf.freecol.common.model.SpecificationTest +
net.sf.freecol.common.model.Stance +
net.sf.freecol.common.model.StanceTradeItem +
net.sf.freecol.common.model.StringTemplate +
net.sf.freecol.common.model.StringTemplate$TemplateType +
net.sf.freecol.common.model.Tension +
net.sf.freecol.common.model.Tension$Level +
net.sf.freecol.common.model.Tile +
net.sf.freecol.common.model.Tile$IndianSettlementInternals +
net.sf.freecol.common.model.TileImprovement +
net.sf.freecol.common.model.TileImprovementStyle +
net.sf.freecol.common.model.TileImprovementTest +
net.sf.freecol.common.model.TileImprovementType +
net.sf.freecol.common.model.TileItemContainer +
net.sf.freecol.common.model.TileItemContainerTest +
net.sf.freecol.common.model.TileTest +
net.sf.freecol.common.model.TileTest$Work +
net.sf.freecol.common.model.TileType +
net.sf.freecol.common.model.TileType$RangeType +
net.sf.freecol.common.model.TileTypeChange +
net.sf.freecol.common.model.TradeRoute +
net.sf.freecol.common.model.TradeRouteStop +
net.sf.freecol.common.model.TradeRouteTest +
net.sf.freecol.common.model.Turn +
net.sf.freecol.common.model.TypeCountMap +
net.sf.freecol.common.model.Unit +
net.sf.freecol.common.model.Unit$MoveType +
net.sf.freecol.common.model.Unit$UnitLabelType +
net.sf.freecol.common.model.Unit$UnitState +
net.sf.freecol.common.model.UnitLocation$NoAddReason +
net.sf.freecol.common.model.UnitTest +
net.sf.freecol.common.model.UnitTradeItem +
net.sf.freecol.common.model.UnitType +
net.sf.freecol.common.model.UnitTypeChange +
net.sf.freecol.common.model.UnitTypeChange$ChangeType +
net.sf.freecol.common.model.UnitTypeChangeTest +
net.sf.freecol.common.model.UnitWas +
net.sf.freecol.common.model.WorkLocation$Suggestion +
net.sf.freecol.common.model.mission.CompoundMission +
net.sf.freecol.common.model.mission.GoToMission +
net.sf.freecol.common.model.mission.ImprovementMission +
net.sf.freecol.common.model.mission.Mission$MissionState +
net.sf.freecol.common.model.mission.MissionManager +
net.sf.freecol.common.model.pathfinding.BaseCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders +
net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsAndBlockingUnitsCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders$ServerBaseCostDecider +
net.sf.freecol.common.model.pathfinding.GoalDeciders +
net.sf.freecol.common.model.pathfinding.GoalDeciders$MultipleAdjacentDecider +
net.sf.freecol.common.networking.AbandonColonyMessage +
net.sf.freecol.common.networking.AskSkillMessage +
net.sf.freecol.common.networking.AssignTeacherMessage +
net.sf.freecol.common.networking.AssignTradeRouteMessage +
net.sf.freecol.common.networking.AttackMessage +
net.sf.freecol.common.networking.BuildColonyMessage +
net.sf.freecol.common.networking.BuyMessage +
net.sf.freecol.common.networking.BuyPropositionMessage +
net.sf.freecol.common.networking.CashInTreasureTrainMessage +
net.sf.freecol.common.networking.ChangeStateMessage +
net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
net.sf.freecol.common.networking.ChangeWorkTypeMessage +
net.sf.freecol.common.networking.ChatMessage +
net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
net.sf.freecol.common.networking.ClaimLandMessage +
net.sf.freecol.common.networking.ClearSpecialityMessage +
net.sf.freecol.common.networking.Client +
net.sf.freecol.common.networking.CloseTransactionMessage +
net.sf.freecol.common.networking.Connection +
net.sf.freecol.common.networking.DOMMessage +
net.sf.freecol.common.networking.DeclareIndependenceMessage +
net.sf.freecol.common.networking.DeclineMoundsMessage +
net.sf.freecol.common.networking.DeliverGiftMessage +
net.sf.freecol.common.networking.DemandTributeMessage +
net.sf.freecol.common.networking.DiplomacyMessage +
net.sf.freecol.common.networking.DisbandUnitMessage +
net.sf.freecol.common.networking.DisembarkMessage +
net.sf.freecol.common.networking.EmbarkMessage +
net.sf.freecol.common.networking.EmigrateUnitMessage +
net.sf.freecol.common.networking.EquipForRoleMessage +
net.sf.freecol.common.networking.FirstContactMessage +
net.sf.freecol.common.networking.GetNationSummaryMessage +
net.sf.freecol.common.networking.GetTransactionMessage +
net.sf.freecol.common.networking.GoodsForSaleMessage +
net.sf.freecol.common.networking.InciteMessage +
net.sf.freecol.common.networking.IndianDemandMessage +
net.sf.freecol.common.networking.JoinColonyMessage +
net.sf.freecol.common.networking.LearnSkillMessage +
net.sf.freecol.common.networking.LoadGoodsMessage +
net.sf.freecol.common.networking.LoginMessage +
net.sf.freecol.common.networking.LootCargoMessage +
net.sf.freecol.common.networking.Message +
net.sf.freecol.common.networking.MissionaryMessage +
net.sf.freecol.common.networking.MonarchActionMessage +
net.sf.freecol.common.networking.MoveMessage +
net.sf.freecol.common.networking.MoveToMessage +
net.sf.freecol.common.networking.NetworkReplyObject +
net.sf.freecol.common.networking.NewLandNameMessage +
net.sf.freecol.common.networking.NewRegionNameMessage +
net.sf.freecol.common.networking.PayArrearsMessage +
net.sf.freecol.common.networking.PayForBuildingMessage +
net.sf.freecol.common.networking.PutOutsideColonyMessage +
net.sf.freecol.common.networking.RearrangeColonyMessage +
net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange +
net.sf.freecol.common.networking.ReceivingThread +
net.sf.freecol.common.networking.ReceivingThread$FreeColNetworkInputStream +
net.sf.freecol.common.networking.RenameMessage +
net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
net.sf.freecol.common.networking.SellMessage +
net.sf.freecol.common.networking.SellPropositionMessage +
net.sf.freecol.common.networking.SetBuildQueueMessage +
net.sf.freecol.common.networking.SetCurrentStopMessage +
net.sf.freecol.common.networking.SetDestinationMessage +
net.sf.freecol.common.networking.SetGoodsLevelsMessage +
net.sf.freecol.common.networking.SetTradeRoutesMessage +
net.sf.freecol.common.networking.SpySettlementMessage +
net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
net.sf.freecol.common.networking.TrivialMessage +
net.sf.freecol.common.networking.UnloadGoodsMessage +
net.sf.freecol.common.networking.UpdateTradeRouteMessage +
net.sf.freecol.common.networking.WorkMessage +
net.sf.freecol.common.option.AbstractUnitOption +
net.sf.freecol.common.option.AllTests +
net.sf.freecol.common.option.AudioMixerOption +
net.sf.freecol.common.option.AudioMixerOption$MixerWrapper +
net.sf.freecol.common.option.BooleanOption +
net.sf.freecol.common.option.FileOption +
net.sf.freecol.common.option.IntegerOption +
net.sf.freecol.common.option.LanguageOption +
net.sf.freecol.common.option.LanguageOption$Language +
net.sf.freecol.common.option.MapGeneratorOptions +
net.sf.freecol.common.option.ModListOption +
net.sf.freecol.common.option.ModOption +
net.sf.freecol.common.option.OptionGroup +
net.sf.freecol.common.option.OptionTest +
net.sf.freecol.common.option.PercentageOption +
net.sf.freecol.common.option.RangeOption +
net.sf.freecol.common.option.SelectOption +
net.sf.freecol.common.option.StringOption +
net.sf.freecol.common.option.TextOption +
net.sf.freecol.common.option.UnitListOption +
net.sf.freecol.common.option.UnitTypeOption +
net.sf.freecol.common.option.UnitTypeOption$TypeSelector +
net.sf.freecol.common.resources.AudioResource +
net.sf.freecol.common.resources.ColorResource +
net.sf.freecol.common.resources.FAFile +
net.sf.freecol.common.resources.FAFile$CREatingInputStream +
net.sf.freecol.common.resources.FAFile$FALetter +
net.sf.freecol.common.resources.FAFile$FAName +
net.sf.freecol.common.resources.FAFileResource +
net.sf.freecol.common.resources.FontResource +
net.sf.freecol.common.resources.ImageResource +
net.sf.freecol.common.resources.ResourceFactory +
net.sf.freecol.common.resources.ResourceManager +
net.sf.freecol.common.resources.ResourceMapper +
net.sf.freecol.common.resources.ResourceMapping +
net.sf.freecol.common.resources.SZAResource +
net.sf.freecol.common.resources.StringResource +
net.sf.freecol.common.resources.Video +
net.sf.freecol.common.resources.VideoResource +
net.sf.freecol.common.sound.AllTests +
net.sf.freecol.common.sound.OggVorbisDecoderFactory +
net.sf.freecol.common.sound.OggVorbisDecoderFactory$OggStream +
net.sf.freecol.common.sound.OggVorbisDecoderFactory$OggVorbisAudioInputStream +
net.sf.freecol.common.sound.Playlist +
net.sf.freecol.common.sound.SoundPlayer +
net.sf.freecol.common.sound.SoundPlayer$SoundPlayerThread +
net.sf.freecol.common.sound.SoundTest +
net.sf.freecol.common.util.CollectionUtils +
net.sf.freecol.common.util.Introspector +
net.sf.freecol.common.util.LogBuilder +
net.sf.freecol.common.util.RandomChoice +
net.sf.freecol.common.util.RandomUtils +
net.sf.freecol.common.util.StringUtils +
net.sf.freecol.common.util.Utils +
net.sf.freecol.common.util.Xml +
net.sf.freecol.common.util.Xml$Exception +
net.sf.freecol.common.utils.AllTests +
net.sf.freecol.common.utils.UtilsTest +
net.sf.freecol.metaserver.MetaItem +
net.sf.freecol.metaserver.MetaRegister +
net.sf.freecol.metaserver.MetaServer +
net.sf.freecol.metaserver.NetworkHandler +
net.sf.freecol.server.AllTests +
net.sf.freecol.server.FreeColServer +
net.sf.freecol.server.FreeColServer$GameState +
net.sf.freecol.server.SaveLoadTest +
net.sf.freecol.server.ServerTestHelper +
net.sf.freecol.server.ai.AIColony +
net.sf.freecol.server.ai.AIColonyTest +
net.sf.freecol.server.ai.AIGoods +
net.sf.freecol.server.ai.AIInGameInputHandler +
net.sf.freecol.server.ai.AIMain +
net.sf.freecol.server.ai.AIMessage +
net.sf.freecol.server.ai.AIUnit +
net.sf.freecol.server.ai.AllTests +
net.sf.freecol.server.ai.CacheEntryComparator +
net.sf.freecol.server.ai.Cargo +
net.sf.freecol.server.ai.Cargo$CargoMode +
net.sf.freecol.server.ai.Cargo$CargoPlan +
net.sf.freecol.server.ai.ColonyPlan +
net.sf.freecol.server.ai.ColonyPlan$BuildPlan +
net.sf.freecol.server.ai.ColonyPlan$ProfileType +
net.sf.freecol.server.ai.ColonyPlanTest +
net.sf.freecol.server.ai.ContactTest +
net.sf.freecol.server.ai.EuropeanAIPlayer +
net.sf.freecol.server.ai.GoodsWish +
net.sf.freecol.server.ai.MissionAssignmentTest +
net.sf.freecol.server.ai.NativeAIPlayer +
net.sf.freecol.server.ai.ProductionCache +
net.sf.freecol.server.ai.ProductionCache$Entry +
net.sf.freecol.server.ai.REFAIPlayer +
net.sf.freecol.server.ai.REFAIPlayer$TargetTuple +
net.sf.freecol.server.ai.REFTest +
net.sf.freecol.server.ai.StandardAIPlayerTest +
net.sf.freecol.server.ai.TensionTest +
net.sf.freecol.server.ai.TileImprovementPlan +
net.sf.freecol.server.ai.WorkLocationPlan +
net.sf.freecol.server.ai.WorkerWish +
net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
net.sf.freecol.server.ai.mission.AllTests +
net.sf.freecol.server.ai.mission.BuildColonyMission +
net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
net.sf.freecol.server.ai.mission.DefendSettlementMission +
net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
net.sf.freecol.server.ai.mission.IndianBringGiftMission +
net.sf.freecol.server.ai.mission.IndianDemandMission +
net.sf.freecol.server.ai.mission.MissionaryMission +
net.sf.freecol.server.ai.mission.PioneeringMission +
net.sf.freecol.server.ai.mission.PioneeringMissionTest +
net.sf.freecol.server.ai.mission.PrivateerMission +
net.sf.freecol.server.ai.mission.PrivateerMissionTest +
net.sf.freecol.server.ai.mission.ScoutingMission +
net.sf.freecol.server.ai.mission.ScoutingMissionTest +
net.sf.freecol.server.ai.mission.TransportMission +
net.sf.freecol.server.ai.mission.TransportMission$CargoResult +
net.sf.freecol.server.ai.mission.TransportMissionTest +
net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
net.sf.freecol.server.ai.mission.UnitWanderMission +
net.sf.freecol.server.ai.mission.WishRealizationMission +
net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
net.sf.freecol.server.control.AllTests +
net.sf.freecol.server.control.ChangeSet +
net.sf.freecol.server.control.ChangeSet$AttackChange +
net.sf.freecol.server.control.ChangeSet$AttributeChange +
net.sf.freecol.server.control.ChangeSet$ChangePriority +
net.sf.freecol.server.control.ChangeSet$FeatureChange +
net.sf.freecol.server.control.ChangeSet$MessageChange +
net.sf.freecol.server.control.ChangeSet$MoveChange +
net.sf.freecol.server.control.ChangeSet$ObjectChange +
net.sf.freecol.server.control.ChangeSet$OwnedChange +
net.sf.freecol.server.control.ChangeSet$PartialObjectChange +
net.sf.freecol.server.control.ChangeSet$PlayerChange +
net.sf.freecol.server.control.ChangeSet$RemoveChange +
net.sf.freecol.server.control.ChangeSet$See +
net.sf.freecol.server.control.ChangeSet$SpyChange +
net.sf.freecol.server.control.ChangeSet$StanceChange +
net.sf.freecol.server.control.ChangeSet$TrivialChange +
net.sf.freecol.server.control.FreeColServerHolder +
net.sf.freecol.server.control.InGameController +
net.sf.freecol.server.control.InGameController$DOMMessageCallable +
net.sf.freecol.server.control.InGameControllerTest +
net.sf.freecol.server.control.InGameInputHandler +
net.sf.freecol.server.control.InputHandler$DisconnectHandler +
net.sf.freecol.server.control.PreGameController +
net.sf.freecol.server.control.PreGameInputHandler +
net.sf.freecol.server.control.UserConnectionHandler +
net.sf.freecol.server.generator.AllTests +
net.sf.freecol.server.generator.ColonizationMapLoader +
net.sf.freecol.server.generator.FreeColMapLoader +
net.sf.freecol.server.generator.MapGeneratorTest +
net.sf.freecol.server.generator.River +
net.sf.freecol.server.generator.River$DirectionChange +
net.sf.freecol.server.generator.RiverSection +
net.sf.freecol.server.generator.SimpleMapGenerator +
net.sf.freecol.server.generator.SimpleMapGenerator$Territory +
net.sf.freecol.server.generator.TerrainGenerator +
net.sf.freecol.server.model.AllTests +
net.sf.freecol.server.model.DiplomacySession +
net.sf.freecol.server.model.LootSession +
net.sf.freecol.server.model.MonarchSession +
net.sf.freecol.server.model.ServerBuilding +
net.sf.freecol.server.model.ServerBuildingTest +
net.sf.freecol.server.model.ServerBuildingTest$SchoolLevel +
net.sf.freecol.server.model.ServerColony +
net.sf.freecol.server.model.ServerColonyTest +
net.sf.freecol.server.model.ServerColonyTile +
net.sf.freecol.server.model.ServerEurope +
net.sf.freecol.server.model.ServerGame +
net.sf.freecol.server.model.ServerIndianSettlement +
net.sf.freecol.server.model.ServerIndianSettlementTest +
net.sf.freecol.server.model.ServerPlayer +
net.sf.freecol.server.model.ServerPlayerTest +
net.sf.freecol.server.model.ServerRegion +
net.sf.freecol.server.model.ServerUnit +
net.sf.freecol.server.model.ServerUnitTest +
net.sf.freecol.server.model.TradeSession +
net.sf.freecol.server.networking.DummyConnection +
net.sf.freecol.server.networking.Server +
net.sf.freecol.tools.ColonizationMapReader +
net.sf.freecol.tools.ColonizationSaveGameReader +
net.sf.freecol.tools.ColonizationSaveGameReader$Colonist +
net.sf.freecol.tools.ColonizationSaveGameReader$ColonyData +
net.sf.freecol.tools.ColonizationSaveGameReader$GameData +
net.sf.freecol.tools.ColonizationSaveGameReader$PlayerData +
net.sf.freecol.tools.DesktopEntry +
net.sf.freecol.tools.FSGConverter +
net.sf.freecol.tools.FlagTest +
net.sf.freecol.tools.ForestMaker +
net.sf.freecol.tools.ForestMaker$ImageLocation +
net.sf.freecol.tools.GenerateDocumentation +
net.sf.freecol.tools.InstallerTranslations +
net.sf.freecol.tools.MapConverter +
net.sf.freecol.tools.MergeTranslations +
net.sf.freecol.tools.RiverMaker +
net.sf.freecol.tools.SaveGameValidator +
net.sf.freecol.tools.TranslationReport +
net.sf.freecol.tools.TranslationReport$LanguageStatsRecord +
net.sf.freecol.util.test.FreeColTestCase +
net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
net.sf.freecol.util.test.FreeColTestUtils +
net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
net.sf.freecol.util.test.MockMapGenerator +
net.sf.freecol.util.test.MockPseudoRandom +
+None + +commons-cli-1.1.jar +
+cortado-0.6.0.jar +
+jogg-0.0.17.jar +
+jorbis-0.0.17.jar +
+junit-4.12.jar +
+miglayout-swing-4.2.jar +
+rt.jar + +
+
+ + +

Package Analysis

+

Package Dependency Graph

+
+ + + +net.sf.freecol +net.sf.freecol.client +net.sf.freecol.client.control +net.sf.freecol.client.gui +net.sf.freecol.client.gui.action +net.sf.freecol.client.gui.animation +net.sf.freecol.client.gui.menu +net.sf.freecol.client.gui.option +net.sf.freecol.client.gui.panel +net.sf.freecol.client.gui.plaf +net.sf.freecol.client.gui.video +net.sf.freecol.client.networking +net.sf.freecol.common +net.sf.freecol.common.debug +net.sf.freecol.common.i18n +net.sf.freecol.common.io +net.sf.freecol.common.io.sza +net.sf.freecol.common.logging +net.sf.freecol.common.model +net.sf.freecol.common.model.mission +net.sf.freecol.common.model.pathfinding +net.sf.freecol.common.networking +net.sf.freecol.common.option +net.sf.freecol.common.resources +net.sf.freecol.common.sound +net.sf.freecol.common.util +net.sf.freecol.common.utils +net.sf.freecol.metaserver +net.sf.freecol.server +net.sf.freecol.server.ai +net.sf.freecol.server.ai.goal +net.sf.freecol.server.ai.mission +net.sf.freecol.server.control +net.sf.freecol.server.generator +net.sf.freecol.server.model +net.sf.freecol.server.networking +net.sf.freecol.tools +net.sf.freecol.util.test + +
+

Package Summary

+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
PackageTotal ClassesAbstract ClassesConcrete ClassesAfferent CouplingEfferent CouplingAbstractnessInstabilityDistance
+net.sf.freecol + +2 + +0 + +2 + +18 + +2 + +0.0 + +0.1 + +-0.9 +
+net.sf.freecol.client + +8 + +0 + +8 + +10 + +8 + +0.0 + +0.44 + +-0.56 +
+net.sf.freecol.client.control + +23 + +2 + +21 + +4 + +13 + +0.09 + +0.76 + +-0.15 +
+net.sf.freecol.client.gui + +37 + +2 + +35 + +11 + +32 + +0.05 + +0.74 + +-0.2 +
+net.sf.freecol.client.gui.action + +82 + +4 + +78 + +5 + +80 + +0.05 + +0.94 + +-0.01 +
+net.sf.freecol.client.gui.animation + +4 + +0 + +4 + +0 + +4 + +0.0 + +1.0 + +0.0 +
+net.sf.freecol.client.gui.menu + +6 + +1 + +5 + +1 + +6 + +0.17 + +0.86 + +0.02 +
+net.sf.freecol.client.gui.option + +26 + +3 + +23 + +2 + +24 + +0.12 + +0.92 + +0.04 +
+net.sf.freecol.client.gui.panel + +231 + +14 + +217 + +8 + +214 + +0.06 + +0.96 + +0.02 +
+net.sf.freecol.client.gui.plaf + +26 + +0 + +26 + +2 + +26 + +0.0 + +0.93 + +-0.07 +
+net.sf.freecol.client.gui.video + +2 + +1 + +1 + +1 + +1 + +0.5 + +0.5 + +0.0 +
+net.sf.freecol.client.networking + +1 + +0 + +1 + +1 + +1 + +0.0 + +0.5 + +-0.5 +
+net.sf.freecol.common + +5 + +1 + +4 + +18 + +5 + +0.2 + +0.22 + +-0.58 +
+net.sf.freecol.common.debug + +3 + +0 + +3 + +15 + +2 + +0.0 + +0.12 + +-0.88 +
+net.sf.freecol.common.i18n + +20 + +2 + +18 + +17 + +19 + +0.1 + +0.53 + +-0.37 +
+net.sf.freecol.common.io + +12 + +0 + +12 + +23 + +10 + +0.0 + +0.3 + +-0.7 +
+net.sf.freecol.common.io.sza + +4 + +2 + +2 + +2 + +3 + +0.5 + +0.6 + +0.1 +
+net.sf.freecol.common.logging + +2 + +0 + +2 + +1 + +2 + +0.0 + +0.67 + +-0.33 +
+net.sf.freecol.common.model + +213 + +26 + +187 + +28 + +158 + +0.12 + +0.85 + +-0.03 +
+net.sf.freecol.common.model.mission + +7 + +2 + +5 + +0 + +6 + +0.29 + +1.0 + +0.29 +
+net.sf.freecol.common.model.pathfinding + +10 + +2 + +8 + +4 + +10 + +0.2 + +0.71 + +-0.09 +
+net.sf.freecol.common.networking + +77 + +5 + +72 + +12 + +75 + +0.06 + +0.86 + +-0.07 +
+net.sf.freecol.common.option + +25 + +3 + +22 + +17 + +24 + +0.12 + +0.59 + +-0.29 +
+net.sf.freecol.common.resources + +21 + +4 + +17 + +9 + +17 + +0.19 + +0.65 + +-0.16 +
+net.sf.freecol.common.sound + +8 + +0 + +8 + +3 + +7 + +0.0 + +0.7 + +-0.3 +
+net.sf.freecol.common.util + +10 + +1 + +9 + +17 + +10 + +0.1 + +0.37 + +-0.53 +
+net.sf.freecol.common.utils + +2 + +0 + +2 + +1 + +2 + +0.0 + +0.67 + +-0.33 +
+net.sf.freecol.metaserver + +4 + +0 + +4 + +0 + +4 + +0.0 + +1.0 + +0.0 +
+net.sf.freecol.server + +5 + +0 + +5 + +13 + +4 + +0.0 + +0.24 + +-0.76 +
+net.sf.freecol.server.ai + +36 + +5 + +31 + +5 + +34 + +0.14 + +0.87 + +0.01 +
+net.sf.freecol.server.ai.goal + +5 + +2 + +3 + +1 + +4 + +0.4 + +0.8 + +0.2 +
+net.sf.freecol.server.ai.mission + +24 + +1 + +23 + +2 + +23 + +0.04 + +0.92 + +-0.04 +
+net.sf.freecol.server.control + +30 + +4 + +26 + +6 + +29 + +0.13 + +0.83 + +-0.04 +
+net.sf.freecol.server.generator + +13 + +3 + +10 + +4 + +12 + +0.23 + +0.75 + +-0.02 +
+net.sf.freecol.server.model + +22 + +2 + +20 + +12 + +21 + +0.09 + +0.64 + +-0.27 +
+net.sf.freecol.server.networking + +2 + +0 + +2 + +3 + +2 + +0.0 + +0.4 + +-0.6 +
+net.sf.freecol.tools + +19 + +0 + +19 + +0 + +18 + +0.0 + +1.0 + +0.0 +
+net.sf.freecol.util.test + +7 + +0 + +7 + +14 + +7 + +0.0 + +0.33 + +-0.67 +
+
+

Package Cycles

+
+ + + +net.sf.freecol +net.sf.freecol.client +net.sf.freecol.client.control +net.sf.freecol.client.gui +net.sf.freecol.client.gui.action +net.sf.freecol.client.gui.menu +net.sf.freecol.client.gui.option +net.sf.freecol.client.gui.panel +net.sf.freecol.client.gui.plaf +net.sf.freecol.client.gui.video +net.sf.freecol.client.networking +net.sf.freecol.common +net.sf.freecol.common.debug +net.sf.freecol.common.i18n +net.sf.freecol.common.io +net.sf.freecol.common.logging +net.sf.freecol.common.model +net.sf.freecol.common.model.pathfinding +net.sf.freecol.common.networking +net.sf.freecol.common.option +net.sf.freecol.common.resources +net.sf.freecol.common.sound +net.sf.freecol.common.util +net.sf.freecol.common.utils +net.sf.freecol.server +net.sf.freecol.server.ai +net.sf.freecol.server.ai.goal +net.sf.freecol.server.ai.mission +net.sf.freecol.server.control +net.sf.freecol.server.generator +net.sf.freecol.server.model +net.sf.freecol.server.networking +net.sf.freecol.util.test + +

net.sf.freecol

+ + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.AllTests + +None + +net.sf.freecol.client.gui.AllTests +
+net.sf.freecol.common.AllTests +
+net.sf.freecol.server.AllTests +
+net.sf.freecol.server.generator.AllTests + +
+net.sf.freecol.FreeCol + +net.sf.freecol.client.gui.panel.ServerListPanel +
+net.sf.freecol.client.gui.panel.DifficultyDialog +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.client.gui.action.AboutAction +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.client.gui.panel.OptionsDialog +
+net.sf.freecol.client.gui.ScrollThread +
+net.sf.freecol.client.gui.panel.LoadingSavegameDialog +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.common.sound.SoundPlayer$SoundPlayerThread +
+net.sf.freecol.client.Worker +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.client.gui.FreeColFrame +
+net.sf.freecol.client.gui.panel.AboutPanel +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.logging.DefaultHandler +
+net.sf.freecol.server.control.UserConnectionHandler + +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.io.Mods +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.NationOptions$Advantages +
+net.sf.freecol.common.logging.DefaultHandler +
+net.sf.freecol.common.io.FreeColTcFile +
+net.sf.freecol.common.FreeColSeed +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.client.FreeColClient + +
+

net.sf.freecol.client

+ + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.AllTests + +None + +net.sf.freecol.client.gui.AllTests +
+net.sf.freecol.client.control.AllTests + +
+net.sf.freecol.client.ClientOptions + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.client.gui.action.ReportLabourAction +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.client.control.SoundController +
+net.sf.freecol.common.sound.SoundTest +
+net.sf.freecol.client.gui.action.DisplayBordersAction +
+net.sf.freecol.client.gui.AbstractCanvasListener +
+net.sf.freecol.client.gui.action.MapControlsAction +
+net.sf.freecol.client.gui.action.DisplayTileTextAction +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.client.gui.panel.ClientOptionsDialog +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.client.gui.action.SelectableAction +
+net.sf.freecol.client.gui.action.MiniMapToggleViewAction +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.action.MiniMapToggleFogOfWarAction +
+net.sf.freecol.client.gui.action.DisplayGridAction +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.GrayLayer + +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator + +None + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.ClientTestHelper + +net.sf.freecol.client.control.MoveTest + + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.client.FreeColClient + +net.sf.freecol.client.gui.action.ToggleViewModeAction +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.EventPanel +
+net.sf.freecol.client.gui.action.SkipUnitAction +
+net.sf.freecol.client.gui.panel.PurchasePanel +
+net.sf.freecol.client.control.SoundController +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.action.EuropeAction +
+net.sf.freecol.client.gui.AbstractCanvasListener +
+net.sf.freecol.client.gui.action.ReportHighScoresAction +
+net.sf.freecol.client.gui.action.FindSettlementAction +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.gui.action.ReconnectAction +
+net.sf.freecol.client.gui.action.LoadAction +
+net.sf.freecol.client.gui.action.DebugAction +
+net.sf.freecol.client.gui.action.ReportColonyAction +
+net.sf.freecol.client.gui.action.DeclareIndependenceAction +
+net.sf.freecol.client.gui.action.OpenAction +
+net.sf.freecol.client.gui.action.AssignTradeRouteAction +
+net.sf.freecol.client.gui.panel.VictoryDialog +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
+net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
+net.sf.freecol.client.gui.panel.ColonyPanel$ColonyCargoPanel +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.action.GotoTileAction +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
+net.sf.freecol.client.gui.action.UnitAction +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.client.gui.panel.PortPanel +
+net.sf.freecol.client.gui.panel.LoadingSavegameDialog +
+net.sf.freecol.client.gui.action.DisbandUnitAction +
+net.sf.freecol.client.gui.action.BuildColonyAction +
+net.sf.freecol.client.gui.CanvasMouseMotionListener +
+net.sf.freecol.client.gui.action.ShowDifficultyAction +
+net.sf.freecol.client.gui.panel.ColorChooserPanel +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.client.gui.panel.MonarchDialog +
+net.sf.freecol.client.gui.FullScreenFrameListener +
+net.sf.freecol.client.gui.action.MapboardAction +
+net.sf.freecol.client.gui.action.SaveAndQuitAction +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.action.ReportEducationAction +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.client.gui.action.PreferencesAction +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.client.gui.GrayLayer +
+net.sf.freecol.client.gui.panel.PreCombatDialog +
+net.sf.freecol.client.gui.action.ReportTurnAction +
+net.sf.freecol.client.gui.action.ShowGameOptionsAction +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.client.gui.panel.ColopediaPanel +
+net.sf.freecol.client.gui.panel.EmigrationDialog +
+net.sf.freecol.client.gui.action.ZoomOutAction +
+net.sf.freecol.client.gui.action.DisplayBordersAction +
+net.sf.freecol.client.gui.action.ReportNavalAction +
+net.sf.freecol.client.gui.action.ChangeAction +
+net.sf.freecol.client.gui.action.MapControlsAction +
+net.sf.freecol.client.gui.action.DisplayTileTextAction +
+net.sf.freecol.client.gui.action.MoveAction +
+net.sf.freecol.client.gui.panel.RecruitPanel +
+net.sf.freecol.client.gui.panel.ChooseFoundingFatherDialog +
+net.sf.freecol.client.gui.action.RetireAction +
+net.sf.freecol.client.gui.action.GotoAction +
+net.sf.freecol.client.gui.action.ColopediaAction +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.action.ImprovementAction +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.client.gui.action.ReportCargoAction +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.client.gui.FreeColFrame +
+net.sf.freecol.client.gui.panel.AboutPanel +
+net.sf.freecol.client.gui.panel.SaveDialog +
+net.sf.freecol.client.gui.menu.MenuMouseMotionListener +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConceptDetailPanel +
+net.sf.freecol.client.gui.action.ReportLabourAction +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.OptionsDialog +
+net.sf.freecol.client.gui.panel.ReportCargoPanel +
+net.sf.freecol.client.gui.action.TilePopupAction +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.client.control.MapEditorController +
+net.sf.freecol.client.gui.panel.ReportExplorationPanel +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
+net.sf.freecol.client.gui.action.SentryAction +
+net.sf.freecol.client.gui.panel.ClientOptionsDialog +
+net.sf.freecol.client.control.InputHandler +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.action.NewAction +
+net.sf.freecol.client.gui.action.QuitAction +
+net.sf.freecol.client.gui.panel.DumpCargoDialog +
+net.sf.freecol.client.gui.action.ShowMainAction +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.action.DisplayGridAction +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.panel.ServerListPanel +
+net.sf.freecol.client.gui.panel.DifficultyDialog +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.client.gui.panel.CargoPanel +
+net.sf.freecol.client.gui.action.ReportHistoryAction +
+net.sf.freecol.client.gui.panel.ReportLabourDetailPanel +
+net.sf.freecol.client.gui.action.ReportRequirementsAction +
+net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.client.gui.action.ChangeWindowedModeAction +
+net.sf.freecol.client.gui.panel.LoadDialog +
+net.sf.freecol.client.gui.action.ReportForeignAction +
+net.sf.freecol.client.gui.panel.FreeColChoiceDialog +
+net.sf.freecol.client.gui.panel.SelectAmountDialog +
+net.sf.freecol.client.gui.panel.TradeRoutePanel +
+net.sf.freecol.client.gui.action.MiniMapZoomInAction +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.client.gui.action.ExecuteGotoOrdersAction +
+net.sf.freecol.client.gui.panel.DragListener +
+net.sf.freecol.client.gui.action.ShowMapGeneratorOptionsAction +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.client.gui.panel.MapSizeDialog +
+net.sf.freecol.client.gui.panel.FreeColStringInputDialog +
+net.sf.freecol.client.gui.action.ZoomInAction +
+net.sf.freecol.client.gui.panel.ReportHistoryPanel +
+net.sf.freecol.client.gui.action.TradeRouteAction +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.client.gui.action.ReportIndianAction +
+net.sf.freecol.client.gui.action.ReportTradeAction +
+net.sf.freecol.client.gui.action.DetermineHighSeasAction +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.CanvasMouseListener +
+net.sf.freecol.client.gui.action.EndTurnAction +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.client.gui.action.WaitAction +
+net.sf.freecol.client.gui.action.MiniMapToggleViewAction +
+net.sf.freecol.client.gui.action.ScaleMapAction +
+net.sf.freecol.client.gui.action.UnloadAction +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.action.ClearOrdersAction +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.ColorCellEditor +
+net.sf.freecol.client.gui.action.RenameAction +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.client.gui.panel.WarehouseDialog +
+net.sf.freecol.client.gui.panel.ParametersDialog +
+net.sf.freecol.client.gui.action.ChatAction +
+net.sf.freecol.client.gui.panel.SelectTributeAmountDialog +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.client.gui.panel.ScaleMapSizeDialog +
+net.sf.freecol.client.gui.action.SelectableAction +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
+net.sf.freecol.client.gui.panel.EditOptionDialog +
+net.sf.freecol.client.gui.action.NewEmptyMapAction +
+net.sf.freecol.client.gui.action.ReportProductionAction +
+net.sf.freecol.client.gui.panel.NewUnitPanel +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.client.gui.panel.GameOptionsDialog +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.client.gui.panel.RiverStyleDialog +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.DeclarationPanel +
+net.sf.freecol.client.gui.panel.ReportEducationPanel +
+net.sf.freecol.client.gui.action.ContinueAction +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.action.MapEditorAction +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.client.gui.action.ReportMilitaryAction +
+net.sf.freecol.client.gui.panel.FreeColConfirmDialog +
+net.sf.freecol.client.gui.panel.StatusPanel +
+net.sf.freecol.client.gui.panel.NationDetailPanel +
+net.sf.freecol.client.gui.action.AboutAction +
+net.sf.freecol.client.gui.WindowedFrameListener +
+net.sf.freecol.client.gui.panel.ChatPanel +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.action.ReportContinentalCongressAction +
+net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.FreeColInputDialog +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.gui.panel.TrainPanel +
+net.sf.freecol.client.gui.action.ReportExplorationAction +
+net.sf.freecol.client.gui.menu.FreeColMenuTest +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.action.MiniMapToggleFogOfWarAction +
+net.sf.freecol.client.gui.action.SaveAction +
+net.sf.freecol.client.gui.action.MiniMapZoomOutAction +
+net.sf.freecol.client.gui.action.CenterAction +
+net.sf.freecol.client.gui.panel.ClassicMapControls +
+net.sf.freecol.client.gui.action.ReportReligionAction +
+net.sf.freecol.client.gui.action.FortifyAction +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.client.gui.panel.ReportProductionPanel +
+net.sf.freecol.client.gui.panel.ErrorPanel + +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.control.SoundController +
+net.sf.freecol.common.model.Player$PlayerType +
+net.sf.freecol.client.control.MapEditorController +
+net.sf.freecol.client.networking.UserServerAPI +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.server.FreeColServer$GameState +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.io.FreeColDataFile +
+net.sf.freecol.common.io.FreeColTcFile +
+net.sf.freecol.common.resources.ResourceMapping +
+net.sf.freecol.common.FreeColSeed +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.control.InGameInputHandler + +
+net.sf.freecol.client.Worker + +None + +net.sf.freecol.FreeCol + +
+

net.sf.freecol.client.control

+ + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.control.AllTests + +net.sf.freecol.client.AllTests + + +None +
+net.sf.freecol.client.control.ConnectController + +net.sf.freecol.client.gui.panel.ServerListPanel +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.ClientTestHelper + +
+net.sf.freecol.server.FreeColServer$GameState +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.networking.LoginMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.client.control.ConnectController$ErrorJob + +None + +net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.control.InGameController + +net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.LostCityRumour$RumourType +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Player$PlayerType +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.TradeRouteStop +
+net.sf.freecol.common.model.UnitWas +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.common.model.EuropeWas +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.client.gui.option.FreeColActionUI +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.MarketWas +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.Europe$MigrationType +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.model.DiplomaticTrade$TradeStatus +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.GoldTradeItem +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Nameable +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.ColonyWas +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.TradeLocation +
+net.sf.freecol.common.model.DiplomaticTrade$TradeContext +
+net.sf.freecol.common.model.Player$NoClaimReason +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.client.control.InGameController$ArmedUnitSettlementAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameController$BoycottAction + +net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel + +
+None +
+net.sf.freecol.client.control.InGameController$BuyAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameController$ClaimAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameController$MissionaryAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameController$ScoutColonyAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameController$ScoutIndianSettlementAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameController$SellAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameController$TradeAction + +net.sf.freecol.client.gui.GUI + + +None +
+net.sf.freecol.client.control.InGameInputHandler + +net.sf.freecol.client.FreeColClient + + +net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.networking.ChatMessage +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.LastSale +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.client.control.InputHandler + +None + +net.sf.freecol.common.networking.MessageHandler +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.client.control.MapEditorController + +net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.control.MapEditorController$ErrorJob + +None + +net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.control.MapEditorController$IMapTransform + +net.sf.freecol.client.gui.panel.MapEditorTransformPanel$MapTransform + + +net.sf.freecol.common.model.Tile + +
+net.sf.freecol.client.control.MoveTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.ClientTestHelper +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.client.control.PreGameController + +net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.control.PreGameInputHandler + +net.sf.freecol.client.FreeColClient + + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.MapGeneratorOptions +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.networking.ChatMessage +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.networking.Connection +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.control.SoundController + +net.sf.freecol.client.FreeColClient + + +net.sf.freecol.common.option.Option +
+net.sf.freecol.common.option.PercentageOption +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.sound.SoundPlayer +
+net.sf.freecol.common.option.AudioMixerOption +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient + +
+

net.sf.freecol.client.gui

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.gui.AbstractCanvasListener + +net.sf.freecol.client.gui.menu.MenuMouseMotionListener + + +net.sf.freecol.common.model.Direction +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.AllTests + +net.sf.freecol.AllTests +
+net.sf.freecol.client.AllTests + +
+None +
+net.sf.freecol.client.gui.Canvas + +net.sf.freecol.client.gui.panel.ClassicMapControls +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.client.gui.menu.MenuMouseMotionListener + +
+None +
+net.sf.freecol.client.gui.Canvas$DialogCallback + +None + +net.sf.freecol.common.model.Tile + +
+net.sf.freecol.client.gui.CanvasMapEditorMouseListener + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.client.gui.panel.RiverStyleDialog +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$TileTypeTransform +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.client.control.MapEditorController +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.CanvasMouseListener + +None + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.CanvasMouseMotionListener + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.ChatDisplay + +None + +net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.ChoiceItem + +net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI + + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.AbstractUnit + +
+net.sf.freecol.client.gui.FontLibrary + +net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.EventPanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.ReportExplorationPanel +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.AboutPanel +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.ClassicMapControls +
+net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel +
+net.sf.freecol.client.gui.panel.FreeColProgressBar +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.FontLibrary$FontSize + +net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ConceptDetailPanel +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.NationDetailPanel +
+net.sf.freecol.client.gui.panel.EventPanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.LoadingSavegameDialog +
+net.sf.freecol.client.gui.panel.ReportExplorationPanel +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.MonarchDialog +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.client.gui.panel.AboutPanel +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.ClassicMapControls +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel +
+net.sf.freecol.client.gui.panel.FreeColProgressBar +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+None +
+net.sf.freecol.client.gui.FontLibrary$FontType + +net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.EventPanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.ReportExplorationPanel +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.AboutPanel +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.ClassicMapControls +
+net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel +
+net.sf.freecol.client.gui.panel.FreeColProgressBar +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+None +
+net.sf.freecol.client.gui.FontTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.client.gui.FreeColFrame + +net.sf.freecol.client.gui.menu.FreeColMenuTest + + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar +
+net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.menu.MenuMouseMotionListener + +
+net.sf.freecol.client.gui.FullScreenFrameListener + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.GUI + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.client.gui.option.ListOptionUI +
+net.sf.freecol.client.gui.option.OptionGroupUI +
+net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.client.gui.action.ChangeWindowedModeAction +
+net.sf.freecol.client.control.MapEditorController +
+net.sf.freecol.client.networking.UserServerAPI +
+net.sf.freecol.client.gui.action.MoveAction +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.control.InputHandler +
+net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.client.gui.option.FileOptionUI +
+net.sf.freecol.client.gui.option.AudioMixerOptionUI +
+net.sf.freecol.client.control.InGameController + +
+net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.control.InGameController$MissionaryAction +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.client.control.InGameController$BuyAction +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.client.control.InGameController$ScoutIndianSettlementAction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.client.control.InGameController$ArmedUnitSettlementAction +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.option.Option +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.client.control.InGameController$ClaimAction +
+net.sf.freecol.client.control.InGameController$TradeAction +
+net.sf.freecol.common.model.Nation +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.client.gui.panel.Parameters +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.control.InGameController$ScoutColonyAction +
+net.sf.freecol.client.control.InGameController$SellAction +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.client.control.InGameController$BoycottAction +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.GrayLayer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.gui.panel.InfoPanel +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.ImageLibrary + +net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.EmigrationDialog +
+net.sf.freecol.client.gui.plaf.FreeColToolTipUI +
+net.sf.freecol.client.gui.panel.FindSettlementPanel$SettlementRenderer +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.RiverStyleDialog +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.client.gui.plaf.FreeColPanelUI +
+net.sf.freecol.client.gui.panel.FreeColImageBorder +
+net.sf.freecol.client.gui.panel.DefaultTransferHandler$FreeColDragHandler +
+net.sf.freecol.client.gui.plaf.FreeColListUI +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.FreeColProgressBar +
+net.sf.freecol.client.gui.plaf.FreeColBrightPanelUI +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.client.gui.panel.NationDetailPanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.client.gui.plaf.FreeColTextAreaUI +
+net.sf.freecol.client.gui.panel.MonarchDialog +
+net.sf.freecol.client.gui.plaf.FreeColPopupMenuUI +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.client.gui.plaf.FreeColTextFieldUI +
+net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.panel.AbstractGoodsLabel +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.plaf.FreeColMenuBarUI +
+net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.client.gui.plaf.FreeColButtonUI +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.SettlementType +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.FreeColGameObjectType +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.common.model.TileImprovementStyle +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.LoadingSavegameInfo + +net.sf.freecol.client.gui.panel.LoadingSavegameDialog + + +None +
+net.sf.freecol.client.gui.RoadPainter + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.ScrollThread + +None + +net.sf.freecol.common.model.Direction +
+net.sf.freecol.FreeCol + +
+net.sf.freecol.client.gui.SwingGUI + +net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.client.gui.panel.DragListener +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.panel.ColorCellEditor +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel + +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.client.gui.plaf.FreeColLookAndFeel +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.resources.Video +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.video.VideoComponent +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.SwingGUI$AbortListener + +None + +net.sf.freecol.client.gui.video.VideoListener + +
+net.sf.freecol.client.gui.TilePopup + +None + +net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.gui.action.UnloadAction +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.TileViewer$SortableImage + +None + +net.sf.freecol.common.util.Utils + +
+net.sf.freecol.client.gui.WindowedFrameListener + +None + +net.sf.freecol.client.FreeColClient + +
+

net.sf.freecol.client.gui.action

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.gui.action.AboutAction + +net.sf.freecol.client.gui.menu.FreeColMenuBar + + +net.sf.freecol.FreeCol +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ActionManager + +net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.client.gui.panel.UnitButton +
+net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.client.gui.panel.ClassicMapControls +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.Option +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.client.gui.action.AssignTradeRouteAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.BuildColonyAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.MapControls + +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.CenterAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ChangeAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ChangeWindowedModeAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ChatAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ClearOrdersAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ColopediaAction + +net.sf.freecol.client.gui.menu.FreeColMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType + +net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConceptDetailPanel +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.NationDetailPanel +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
+net.sf.freecol.client.gui.panel.FatherDetailPanel + +
+None +
+net.sf.freecol.client.gui.action.ContinueAction + +net.sf.freecol.client.gui.panel.MainPanel + + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.client.gui.action.DebugAction + +None + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.DeclareIndependenceAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.common.model.Player$PlayerType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.DetermineHighSeasAction + +net.sf.freecol.client.gui.menu.MapEditorMenuBar + + +net.sf.freecol.common.model.Map +
+net.sf.freecol.client.gui.panel.Parameters +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.DisbandUnitAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.MapControls + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.DisplayBordersAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.DisplayGridAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.DisplayTileTextAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.DisplayTileTextAction$DisplayText + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+None +
+net.sf.freecol.client.gui.action.EndTurnAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.EuropeAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ExecuteGotoOrdersAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.FindSettlementAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.FortifyAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.MapControls + +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.FreeColAction + +net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.option.FreeColActionUI +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.client.gui.panel.UnitButton$UnitButtonActionPropertyChangeListener +
+net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.client.gui.panel.UnitButton + +
+None +
+net.sf.freecol.client.gui.action.GotoAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.GotoTileAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ImprovementAction + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.LoadAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MapControlsAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MapEditorAction + +net.sf.freecol.client.gui.panel.MainPanel + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MapboardAction + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MiniMapToggleFogOfWarAction + +net.sf.freecol.client.gui.panel.MapControls + + +net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MiniMapToggleViewAction + +net.sf.freecol.client.gui.panel.MapControls + + +net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MiniMapZoomInAction + +net.sf.freecol.client.gui.panel.MapControls + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MiniMapZoomOutAction + +net.sf.freecol.client.gui.panel.MapControls + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.MoveAction + +None + +net.sf.freecol.common.model.Direction +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.NewAction + +net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.NewEmptyMapAction + +net.sf.freecol.client.gui.menu.MapEditorMenuBar + + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.OpenAction + +net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.PreferencesAction + +net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.QuitAction + +net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReconnectAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.RenameAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportCargoAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportColonyAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportContinentalCongressAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportEducationAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportExplorationAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportForeignAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportHighScoresAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportHistoryAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportIndianAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportLabourAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportMilitaryAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportNavalAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportProductionAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportReligionAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportRequirementsAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportTradeAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ReportTurnAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.RetireAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.common.model.Player$PlayerType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.SaveAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.SaveAndQuitAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ScaleMapAction + +net.sf.freecol.client.gui.menu.MapEditorMenuBar + + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.SelectableAction + +net.sf.freecol.client.gui.menu.FreeColMenuBar + + +net.sf.freecol.common.model.Player +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.SentryAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.MapControls + +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ShowDifficultyAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ShowGameOptionsAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ShowMainAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ShowMapGeneratorOptionsAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.SkipUnitAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.MapControls + +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.TilePopupAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ToggleViewModeAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.TradeRouteAction + +net.sf.freecol.client.gui.menu.InGameMenuBar + + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.UnitAction + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.UnloadAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.TilePopup + +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.WaitAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.MapControls + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ZoomInAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.action.ZoomOutAction + +net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +
+net.sf.freecol.client.FreeColClient + +
+

net.sf.freecol.client.gui.menu

+ + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.gui.menu.DebugMenu + +None + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.menu.FreeColMenuBar + +net.sf.freecol.client.gui.FreeColFrame + + +net.sf.freecol.client.gui.panel.FreeColImageBorder +
+net.sf.freecol.client.gui.action.FreeColAction +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.action.ColopediaAction +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.client.gui.action.AboutAction +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.action.SelectableAction + +
+net.sf.freecol.client.gui.menu.FreeColMenuTest + +None + +net.sf.freecol.client.gui.FreeColFrame +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.menu.InGameMenuBar + +net.sf.freecol.client.gui.FreeColFrame + + +net.sf.freecol.client.gui.action.ReportTurnAction +
+net.sf.freecol.client.gui.action.ToggleViewModeAction +
+net.sf.freecol.client.gui.action.RenameAction +
+net.sf.freecol.client.gui.action.ShowGameOptionsAction +
+net.sf.freecol.client.gui.action.SkipUnitAction +
+net.sf.freecol.client.gui.action.ReportHistoryAction +
+net.sf.freecol.client.gui.action.ZoomOutAction +
+net.sf.freecol.client.gui.action.ReportRequirementsAction +
+net.sf.freecol.client.gui.action.DisplayBordersAction +
+net.sf.freecol.client.gui.action.ChangeWindowedModeAction +
+net.sf.freecol.client.gui.action.EuropeAction +
+net.sf.freecol.client.gui.action.ReportForeignAction +
+net.sf.freecol.client.gui.action.ReportNavalAction +
+net.sf.freecol.client.gui.action.ReportHighScoresAction +
+net.sf.freecol.client.gui.action.MapControlsAction +
+net.sf.freecol.client.gui.action.ChangeAction +
+net.sf.freecol.client.gui.action.ChatAction +
+net.sf.freecol.client.gui.action.DisplayTileTextAction +
+net.sf.freecol.client.gui.action.FindSettlementAction +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.action.ReconnectAction +
+net.sf.freecol.client.gui.action.LoadAction +
+net.sf.freecol.client.gui.action.ReportProductionAction +
+net.sf.freecol.client.gui.action.RetireAction +
+net.sf.freecol.client.gui.action.GotoAction +
+net.sf.freecol.client.gui.action.ReportColonyAction +
+net.sf.freecol.client.gui.action.ExecuteGotoOrdersAction +
+net.sf.freecol.client.gui.action.DeclareIndependenceAction +
+net.sf.freecol.client.gui.action.ShowMapGeneratorOptionsAction +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.client.gui.action.ReportCargoAction +
+net.sf.freecol.client.gui.action.OpenAction +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.client.gui.action.AssignTradeRouteAction +
+net.sf.freecol.client.gui.action.ZoomInAction +
+net.sf.freecol.client.gui.action.ReportMilitaryAction +
+net.sf.freecol.client.gui.action.GotoTileAction +
+net.sf.freecol.client.gui.action.ReportLabourAction +
+net.sf.freecol.client.gui.action.TradeRouteAction +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.action.ReportIndianAction +
+net.sf.freecol.client.gui.action.TilePopupAction +
+net.sf.freecol.client.gui.action.DisbandUnitAction +
+net.sf.freecol.client.gui.action.BuildColonyAction +
+net.sf.freecol.client.gui.action.ReportTradeAction +
+net.sf.freecol.client.gui.action.DisplayTileTextAction$DisplayText +
+net.sf.freecol.client.gui.action.ShowDifficultyAction +
+net.sf.freecol.client.gui.action.ReportContinentalCongressAction +
+net.sf.freecol.client.gui.action.EndTurnAction +
+net.sf.freecol.client.gui.action.SentryAction +
+net.sf.freecol.client.gui.action.SaveAndQuitAction +
+net.sf.freecol.client.gui.action.WaitAction +
+net.sf.freecol.client.gui.action.ReportExplorationAction +
+net.sf.freecol.client.gui.action.NewAction +
+net.sf.freecol.client.gui.action.QuitAction +
+net.sf.freecol.client.gui.action.UnloadAction +
+net.sf.freecol.client.gui.action.ReportEducationAction +
+net.sf.freecol.client.gui.action.ShowMainAction +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.action.DisplayGridAction +
+net.sf.freecol.client.gui.action.ClearOrdersAction +
+net.sf.freecol.client.gui.action.SaveAction +
+net.sf.freecol.client.gui.action.CenterAction +
+net.sf.freecol.client.gui.action.PreferencesAction +
+net.sf.freecol.client.gui.action.FortifyAction +
+net.sf.freecol.client.gui.action.ReportReligionAction +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar + +net.sf.freecol.client.gui.FreeColFrame + + +net.sf.freecol.client.gui.action.ZoomInAction +
+net.sf.freecol.client.gui.action.NewEmptyMapAction +
+net.sf.freecol.client.gui.action.NewAction +
+net.sf.freecol.client.gui.action.ScaleMapAction +
+net.sf.freecol.client.gui.action.QuitAction +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.action.ShowMainAction +
+net.sf.freecol.client.gui.action.ZoomOutAction +
+net.sf.freecol.client.gui.action.ChangeWindowedModeAction +
+net.sf.freecol.client.gui.action.DisplayTileTextAction$DisplayText +
+net.sf.freecol.client.gui.action.OpenAction +
+net.sf.freecol.client.gui.action.DetermineHighSeasAction +
+net.sf.freecol.client.gui.action.DisplayGridAction +
+net.sf.freecol.client.gui.action.MapControlsAction +
+net.sf.freecol.client.gui.action.DisplayTileTextAction +
+net.sf.freecol.client.gui.action.SaveAction +
+net.sf.freecol.client.gui.action.PreferencesAction +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.menu.MenuMouseMotionListener + +net.sf.freecol.client.gui.FreeColFrame + + +net.sf.freecol.client.gui.AbstractCanvasListener +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.Canvas + +
+

net.sf.freecol.client.gui.option

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.gui.option.AbstractUnitOptionUI + +None + +net.sf.freecol.common.option.AbstractUnitOption + +
+net.sf.freecol.client.gui.option.AbstractUnitOptionUI$AbstractUnitRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.option.AbstractUnitOption + +
+net.sf.freecol.client.gui.option.AbstractUnitOptionUI$RoleRenderer + +None + +net.sf.freecol.common.i18n.Messages + +
+net.sf.freecol.client.gui.option.AudioMixerOptionUI + +None + +net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.option.AudioMixerOption +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.common.option.AudioMixerOption$MixerWrapper + +
+net.sf.freecol.client.gui.option.BooleanOptionUI + +net.sf.freecol.client.gui.panel.GameOptionsDialog +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog + +
+net.sf.freecol.common.option.BooleanOption + +
+net.sf.freecol.client.gui.option.FileOptionUI + +net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog + + +net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.option.FileOption +
+net.sf.freecol.client.gui.panel.Utility + +
+net.sf.freecol.client.gui.option.FreeColActionUI + +net.sf.freecol.client.control.InGameController + + +net.sf.freecol.client.gui.action.FreeColAction + +
+net.sf.freecol.client.gui.option.FreeColActionUI$BlinkingLabel + +None + +net.sf.freecol.client.gui.panel.Utility + +
+net.sf.freecol.client.gui.option.IntegerOptionUI + +None + +net.sf.freecol.common.option.IntegerOption + +
+net.sf.freecol.client.gui.option.LanguageOptionUI + +None + +net.sf.freecol.common.option.LanguageOption$Language +
+net.sf.freecol.common.option.LanguageOption + +
+net.sf.freecol.client.gui.option.ListOptionUI + +None + +net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.Utility + +
+net.sf.freecol.client.gui.option.ModOptionUI + +None + +net.sf.freecol.common.option.ModOption + +
+net.sf.freecol.client.gui.option.ModOptionUI$BoxRenderer + +None + +net.sf.freecol.common.io.FreeColModFile + +
+net.sf.freecol.client.gui.option.ModOptionUI$ModOptionRenderer + +None + +net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.common.option.ModOption + +
+net.sf.freecol.client.gui.option.OptionGroupUI + +net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
+net.sf.freecol.client.gui.panel.OptionsDialog + +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.Option +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.panel.MigPanel +
+net.sf.freecol.client.gui.GUI + +
+net.sf.freecol.client.gui.option.OptionUI + +net.sf.freecol.client.gui.panel.EditOptionDialog +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog + +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.common.option.UnitListOption +
+net.sf.freecol.common.option.FileOption +
+net.sf.freecol.common.option.LanguageOption +
+net.sf.freecol.common.option.ModOption +
+net.sf.freecol.common.option.ModListOption +
+net.sf.freecol.client.gui.action.FreeColAction +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.option.Option +
+net.sf.freecol.common.option.PercentageOption +
+net.sf.freecol.common.option.AbstractUnitOption +
+net.sf.freecol.common.option.IntegerOption +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.option.RangeOption +
+net.sf.freecol.common.option.SelectOption +
+net.sf.freecol.common.option.AudioMixerOption +
+net.sf.freecol.common.option.StringOption +
+net.sf.freecol.common.option.TextOption + +
+net.sf.freecol.client.gui.option.PercentageOptionUI + +None + +net.sf.freecol.common.option.PercentageOption + +
+net.sf.freecol.client.gui.option.RangeOptionUI + +None + +net.sf.freecol.common.option.RangeOption +
+net.sf.freecol.client.gui.panel.Utility + +
+net.sf.freecol.client.gui.option.SelectOptionUI + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.option.SelectOption + +
+net.sf.freecol.client.gui.option.SliderOptionUI + +None + +net.sf.freecol.client.gui.panel.Utility + +
+net.sf.freecol.client.gui.option.StringOptionUI + +None + +net.sf.freecol.common.option.StringOption + +
+net.sf.freecol.client.gui.option.TextOptionUI + +None + +net.sf.freecol.common.option.TextOption + +
+net.sf.freecol.client.gui.option.UnitTypeOptionUI + +None + +net.sf.freecol.common.option.UnitTypeOption + +
+net.sf.freecol.client.gui.option.UnitTypeOptionUI$ChoiceRenderer + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages + +
+

net.sf.freecol.client.gui.panel

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.gui.panel.AboutPanel + +None + +net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.AbstractGoodsLabel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType + +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueMouseAdapter + +None + +net.sf.freecol.common.model.BuildableType + +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable + +None + +net.sf.freecol.common.model.BuildableType + +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.plaf.FreeColSelectedPanelUI + +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.ProductionType +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.BuildingPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.ProductionInfo + +
+net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize + +
+net.sf.freecol.client.gui.panel.BuildingToolTip + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.ProductionInfo + +
+net.sf.freecol.client.gui.panel.CaptureGoodsDialog + +None + +net.sf.freecol.common.model.Goods + +
+net.sf.freecol.client.gui.panel.CaptureGoodsDialog$GoodsItem + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Goods + +
+net.sf.freecol.client.gui.panel.CargoPanel + +None + +net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ChatPanel + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ChooseFoundingFatherDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ClassicMapControls + +None + +net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.Canvas + +
+net.sf.freecol.client.gui.panel.ClientOptionsDialog + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.client.gui.panel.ColonyPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Colony$ColonyChangeEvent +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel + +None + +net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel + +None + +net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.UnitLocation$NoAddReason + +
+net.sf.freecol.client.gui.panel.ColonyPanel$ColonyCargoPanel + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ColonyPanel$ColonyInPortPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel + +None + +net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.Player$NoClaimReason +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.UnitLocation$NoAddReason +
+net.sf.freecol.common.model.ProductionInfo + +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel + +None + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.FreeColGameObjectType +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.ColopediaPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ColopediaTreeCellRenderer + +None + +net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.panel.ColorCellEditor + +None + +net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.ColorCellRenderer + +None + +net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.ColorChooserPanel + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.CompactLabourReport + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ConceptDetailPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog$EnumRenderer + +None + +net.sf.freecol.common.i18n.Messages + +
+net.sf.freecol.client.gui.panel.ConstructionPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Colony$ColonyChangeEvent +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.DeclarationPanel + +None + +net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.DeclarationPanel$SignaturePanel + +None + +net.sf.freecol.common.resources.FAFile +
+net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.panel.DefaultTransferHandler$FreeColDragHandler + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.panel.DifficultyDialog + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.client.gui.panel.DragListener + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.DropTarget + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Goods + +
+net.sf.freecol.client.gui.panel.DumpCargoDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.EditOptionDialog + +None + +net.sf.freecol.common.option.Option +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.EditSettlementDialog + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.SettlementType +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.EmigrationDialog + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Europe$MigrationType +
+net.sf.freecol.common.model.LostCityRumour$RumourType +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.EndTurnDialog$UnitCellRenderer + +None + +net.sf.freecol.client.gui.plaf.FreeColSelectedPanelUI + +
+net.sf.freecol.client.gui.panel.EndTurnDialog$UnitWrapper + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Unit$UnitLabelType + +
+net.sf.freecol.client.gui.panel.ErrorPanel + +None + +net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.HighSeas +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.EuropePanel$DocksPanel + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Goods + +
+net.sf.freecol.client.gui.panel.EuropePanel$EuropeInPortPanel + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Unit$UnitState + +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel + +None + +net.sf.freecol.client.control.InGameController$BoycottAction +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.MarketData +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Market + +
+net.sf.freecol.client.gui.panel.EuropePanel$TransactionLog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.TransactionListener +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.EventPanel + +None + +net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.FatherDetailPanel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.FoundingFather$FoundingFatherType + +
+net.sf.freecol.client.gui.panel.FindSettlementPanel$SettlementRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.FirstContactDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.FreeColChoiceDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.FreeColConfirmDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.FreeColDialog + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.FreeColImageBorder + +net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.client.gui.video.VideoComponent + +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.panel.FreeColInputDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.FreeColPanel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.FreeColProgressBar + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.FreeColStringInputDialog + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.GameOptionsDialog + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.client.gui.option.BooleanOptionUI +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.common.model.GameOptions + +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.client.gui.panel.GoodsLabel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.GameOptions + +
+net.sf.freecol.client.gui.panel.InPortPanel + +None + +net.sf.freecol.common.model.Unit + +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.InfoPanel + +net.sf.freecol.client.gui.GrayLayer + + +None +
+net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.action.EndTurnAction +
+net.sf.freecol.client.gui.FontLibrary$FontSize + +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel + +None + +net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.client.gui.FontLibrary$FontSize + +
+net.sf.freecol.client.gui.panel.InformationPanel + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.LabourData$UnitData + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.LoadDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.LoadingSavegameDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.LoadingSavegameInfo +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.MainPanel + +None + +net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.action.OpenAction +
+net.sf.freecol.client.gui.action.NewAction +
+net.sf.freecol.client.gui.action.ContinueAction +
+net.sf.freecol.client.gui.action.QuitAction +
+net.sf.freecol.client.gui.action.PreferencesAction +
+net.sf.freecol.client.gui.action.MapEditorAction +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.client.gui.panel.MapControls + +net.sf.freecol.client.gui.SwingGUI + + +net.sf.freecol.client.gui.action.MiniMapZoomInAction +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.client.gui.action.WaitAction +
+net.sf.freecol.client.gui.action.MiniMapToggleViewAction +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.gui.action.SkipUnitAction +
+net.sf.freecol.client.gui.action.DisbandUnitAction +
+net.sf.freecol.client.gui.action.BuildColonyAction +
+net.sf.freecol.client.gui.action.FreeColAction +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.action.MiniMapToggleFogOfWarAction +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.action.MiniMapZoomOutAction +
+net.sf.freecol.client.gui.action.SentryAction +
+net.sf.freecol.client.gui.action.FortifyAction +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.client.gui.Canvas + +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel + +None + +net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.SettlementType +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$LostCityRumourTransform + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.LostCityRumour + +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$MapTransform + +None + +net.sf.freecol.client.control.MapEditorController$IMapTransform +
+net.sf.freecol.common.model.Tile + +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$ResourceTransform + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Resource +
+net.sf.freecol.common.model.ResourceType + +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$RiverTransform + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.server.model.ServerIndianSettlement + +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$TileTypeTransform + +net.sf.freecol.client.gui.CanvasMapEditorMouseListener + + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.TileType + +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.MapGeneratorOptions +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.client.gui.option.FileOptionUI +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.option.BooleanOptionUI +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.option.OptionGroupUI +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.client.gui.panel.MapSizeDialog + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.MarketLabel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.Market + +
+net.sf.freecol.client.gui.panel.MigPanel + +net.sf.freecol.client.gui.option.OptionGroupUI +
+net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI + +
+None +
+net.sf.freecol.client.gui.panel.MiniMap + +net.sf.freecol.client.gui.GUI + + +net.sf.freecol.common.model.Map +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ModifierFormat + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.FreeColGameObjectType +
+net.sf.freecol.common.model.Modifier$ModifierType +
+net.sf.freecol.common.model.Named +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Nameable +
+net.sf.freecol.common.model.Feature + +
+net.sf.freecol.client.gui.panel.MonarchDialog + +None + +net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.NationDetailPanel + +None + +net.sf.freecol.common.model.NationType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.EuropeanNationType +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.NegotiationDialog + +None + +net.sf.freecol.common.model.DiplomaticTrade + +
+net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel + +None + +net.sf.freecol.common.model.ColonyTradeItem +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.GoldTradeItem + +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoodsTradeItemPanel$GoodsBoxRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Goods + +
+net.sf.freecol.client.gui.panel.NegotiationDialog$InciteTradeItemPanel$InciteBoxRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player + +
+net.sf.freecol.client.gui.panel.NegotiationDialog$RemoveAction + +None + +net.sf.freecol.common.model.TradeItem + +
+net.sf.freecol.client.gui.panel.NegotiationDialog$StanceTradeItemPanel$StanceBoxRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Stance + +
+net.sf.freecol.client.gui.panel.NegotiationDialog$UnitTradeItemPanel$UnitBoxRenderer + +None + +net.sf.freecol.common.model.Unit + +
+net.sf.freecol.client.gui.panel.NewPanel + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.ServerInfo +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.model.NationOptions$Advantages +
+net.sf.freecol.common.io.FreeColTcFile +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.io.Mods +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.NewUnitPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.OptionsDialog + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.option.OptionGroupUI +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.client.gui.panel.Parameters + +net.sf.freecol.client.gui.action.DetermineHighSeasAction +
+net.sf.freecol.client.gui.GUI + +
+None +
+net.sf.freecol.client.gui.panel.ParametersDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellEditor + +None + +net.sf.freecol.common.model.EuropeanNationType + +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer + +None + +net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.NationOptions$Advantages +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellEditor + +None + +net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.EuropeanNationType +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellRenderer + +None + +net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.PlayersTable$NationCellRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.PlayersTable$NationStateRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.NationOptions$NationState + +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer + +None + +net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.EuropeanNationType +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel + +None + +net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.common.model.EuropeanNationType +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.PortPanel + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.FeatureContainer +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.CombatModel +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ProductionLabel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.PurchasePanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.QuickActionMenu + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.common.model.UnitLocation$NoAddReason +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.UnitLocation +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.RebelToolTip + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.FeatureContainer +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.GameOptions + +
+net.sf.freecol.client.gui.panel.RecruitPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Europe$MigrationType +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportCargoPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel + +None + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.FoundingFather$FoundingFatherType + +
+net.sf.freecol.client.gui.panel.ReportEducationPanel + +None + +net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportExplorationPanel + +None + +net.sf.freecol.common.model.Region +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportHistoryPanel + +None + +net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportIndianPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportLabourDetailPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportLabourPanel$LabourUnitPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages + +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.ReportNavalPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.ReportPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportProductionPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel + +None + +net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Colony$TileImprovementSuggestion +
+net.sf.freecol.common.model.ProductionInfo + +
+net.sf.freecol.client.gui.panel.ReportTradePanel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.ExportData +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ReportTurnPanel + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Nameable + +
+net.sf.freecol.client.gui.panel.ReportUnitPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.RiverStyleDialog + +net.sf.freecol.client.gui.CanvasMapEditorMouseListener + + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.SaveDialog + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ScaleMapSizeDialog + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.SelectAmountDialog + +None + +net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog + +None + +net.sf.freecol.common.model.Location + +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$DestinationComparator + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location + +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$DistanceComparator + +None + +net.sf.freecol.common.model.Player + +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$NameComparator + +None + +net.sf.freecol.common.model.Player + +
+net.sf.freecol.client.gui.panel.SelectTributeAmountDialog + +None + +net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ServerListPanel + +None + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.ServerInfo +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.ServerListTableModel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.ServerInfo + +
+net.sf.freecol.client.gui.panel.StartGamePanel + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.MapGeneratorOptions +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.client.gui.panel.StatisticsPanel$StatisticsModel + +None + +net.sf.freecol.common.i18n.Messages + +
+net.sf.freecol.client.gui.panel.StatusPanel + +None + +net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.TilePanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.ProductionType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.Player$ColonyValueCategory + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel + +None + +net.sf.freecol.common.model.TradeRouteStop + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoHandler + +None + +net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.TradeRouteStop + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoLabel + +None + +net.sf.freecol.common.model.GoodsType + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoPanel + +None + +net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.TradeRouteStop + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$DestinationCellRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColGameObject + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$GoodsPanel + +None + +net.sf.freecol.common.model.GoodsType + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListHandler + +None + +net.sf.freecol.common.model.TradeRouteStop + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListTransferable + +None + +net.sf.freecol.common.model.TradeRouteStop + +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer + +None + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.TradeRouteStop +
+net.sf.freecol.client.gui.plaf.FreeColSelectedPanelUI +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.client.gui.panel.TradeRoutePanel + +None + +net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.TrainPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.UnitButton + +None + +net.sf.freecol.client.gui.action.FreeColAction +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.panel.UnitButton$UnitButtonActionPropertyChangeListener + +None + +net.sf.freecol.client.gui.action.FreeColAction +
+net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.panel.UnitDetailPanel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.UnitLabel + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI + +
+net.sf.freecol.client.gui.panel.UnitPanel + +None + +net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Unit$UnitLabelType + +
+net.sf.freecol.client.gui.panel.Utility + +net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.option.FileOptionUI +
+net.sf.freecol.client.gui.option.FreeColActionUI$BlinkingLabel +
+net.sf.freecol.client.gui.menu.MapEditorMenuBar +
+net.sf.freecol.client.gui.option.ListOptionUI +
+net.sf.freecol.client.gui.option.RangeOptionUI +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.menu.FreeColMenuBar +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.client.gui.option.SliderOptionUI +
+net.sf.freecol.client.gui.option.AudioMixerOptionUI + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Named +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.client.gui.panel.VictoryDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.WarehouseDialog + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.ExportData +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.client.gui.panel.WorkProductionPanel + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.client.gui.FontLibrary$FontType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.client.gui.FontLibrary$FontSize +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.client.FreeColClient + +
+

net.sf.freecol.client.gui.plaf

+ + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.gui.plaf.FreeColBrightPanelUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColButtonUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.option.LanguageOption$Language +
+net.sf.freecol.common.ObjectWithId +
+net.sf.freecol.common.model.Named +
+net.sf.freecol.common.model.Nameable + +
+net.sf.freecol.client.gui.plaf.FreeColListUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColLookAndFeel + +net.sf.freecol.client.gui.SwingGUI + + +net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.resources.ResourceManager + +
+net.sf.freecol.client.gui.plaf.FreeColMenuBarUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI + +net.sf.freecol.client.gui.panel.FreeColDialog + + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.panel.MigPanel +
+net.sf.freecol.client.gui.ChoiceItem + +
+net.sf.freecol.client.gui.plaf.FreeColPanelUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColPopupMenuUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColSelectedPanelUI + +net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
+net.sf.freecol.client.gui.panel.EndTurnDialog$UnitCellRenderer + +
+None +
+net.sf.freecol.client.gui.plaf.FreeColTextAreaUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColTextFieldUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+net.sf.freecol.client.gui.plaf.FreeColToolTipUI + +None + +net.sf.freecol.client.gui.ImageLibrary + +
+

net.sf.freecol.client.gui.video

+ + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.gui.video.VideoComponent + +net.sf.freecol.client.gui.SwingGUI + + +net.sf.freecol.client.gui.panel.FreeColImageBorder +
+net.sf.freecol.common.resources.Video + +
+net.sf.freecol.client.gui.video.VideoListener + +net.sf.freecol.client.gui.SwingGUI$AbortListener + + +None +
+

net.sf.freecol.client.networking

+ + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.client.networking.UserServerAPI + +net.sf.freecol.client.FreeColClient + + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode + +
+

net.sf.freecol.common

+ + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.AllTests + +net.sf.freecol.AllTests + + +net.sf.freecol.common.i18n.AllTests +
+net.sf.freecol.common.model.AllTests +
+net.sf.freecol.common.option.AllTests +
+net.sf.freecol.common.sound.AllTests +
+net.sf.freecol.common.io.AllTests +
+net.sf.freecol.common.utils.AllTests + +
+net.sf.freecol.common.FreeColException + +net.sf.freecol.server.SaveLoadTest +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.common.model.SettlementTest +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.gui.plaf.FreeColLookAndFeel +
+net.sf.freecol.common.model.GameTest +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.networking.MessageHandler +
+net.sf.freecol.server.networking.DummyConnection +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.logging.DefaultHandler +
+net.sf.freecol.FreeCol +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.networking.Client +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.common.networking.Connection +
+net.sf.freecol.server.ServerTestHelper + +
+None +
+net.sf.freecol.common.FreeColSeed + +net.sf.freecol.FreeCol +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.server.FreeColServer + +
+None +
+net.sf.freecol.common.ObjectWithId + +net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.option.Option +
+net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColObject + +
+None +
+net.sf.freecol.common.ServerInfo + +net.sf.freecol.client.gui.panel.ServerListPanel +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.gui.panel.ServerListTableModel + +
+None +
+

net.sf.freecol.common.debug

+ + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.debug.DebugUtils + +net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.ColonyPanel + +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.model.Colony$NoBuildReason +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.LostCityRumour$RumourType +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Disaster +
+net.sf.freecol.common.model.Player$NoValueType +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.io.FreeColXMLWriter$WriteScope +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.common.debug.FreeColDebugger + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.common.networking.Message +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.networking.UserServerAPI +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.CanvasMouseListener +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.gui.action.DebugAction +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.logging.DefaultHandler +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.action.DebugAction +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.networking.Message +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.networking.UserServerAPI +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.CanvasMouseListener +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.networking.Connection + +
+None +
+

net.sf.freecol.common.i18n

+ + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.i18n.AllTests + +net.sf.freecol.common.AllTests + + +None +
+net.sf.freecol.common.i18n.CLDRTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.i18n.Messages + +net.sf.freecol.common.model.ColonyTradeItem +
+net.sf.freecol.client.gui.panel.DifficultyDialog +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.client.gui.panel.PurchasePanel +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$DestinationCellRenderer +
+net.sf.freecol.client.gui.panel.ReportLabourDetailPanel +
+net.sf.freecol.client.control.SoundController +
+net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog$EnumRenderer +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.client.gui.panel.LoadDialog +
+net.sf.freecol.client.gui.panel.FreeColChoiceDialog +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.panel.TradeRoutePanel +
+net.sf.freecol.client.gui.panel.LabourData$UnitData +
+net.sf.freecol.client.gui.option.SelectOptionUI +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.VictoryDialog +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
+net.sf.freecol.common.model.UnitLocation +
+net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.option.OptionGroupUI +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.client.gui.panel.LoadingSavegameDialog +
+net.sf.freecol.common.model.GoldTradeItem +
+net.sf.freecol.common.option.LanguageOption$Language +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$ResourceTransform +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.client.gui.panel.ReportLabourPanel$LabourUnitPanel +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.panel.MonarchDialog +
+net.sf.freecol.client.gui.option.AbstractUnitOptionUI$RoleRenderer +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.client.gui.panel.NegotiationDialog$StanceTradeItemPanel$StanceBoxRenderer +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.ChoiceItem +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.common.model.UnitTradeItem +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.GrayLayer +
+net.sf.freecol.client.gui.panel.EndTurnDialog$UnitWrapper +
+net.sf.freecol.client.gui.panel.PlayersTable$NationStateRenderer +
+net.sf.freecol.common.model.InciteTradeItem +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.client.gui.panel.ColopediaPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.EmigrationDialog +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.client.gui.panel.WarehouseDialog +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoodsTradeItemPanel$GoodsBoxRenderer +
+net.sf.freecol.client.gui.action.ChangeAction +
+net.sf.freecol.client.gui.panel.FindSettlementPanel$SettlementRenderer +
+net.sf.freecol.client.gui.panel.ParametersDialog +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.client.gui.panel.RecruitPanel +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.panel.ScaleMapSizeDialog +
+net.sf.freecol.client.gui.panel.ChooseFoundingFatherDialog +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
+net.sf.freecol.client.gui.panel.PlayersTable$NationCellRenderer +
+net.sf.freecol.client.gui.panel.NewUnitPanel +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.client.gui.panel.CaptureGoodsDialog$GoodsItem +
+net.sf.freecol.common.model.FreeColGameObjectType +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.common.model.ModelMessageTest +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$DestinationComparator +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.client.gui.panel.EuropePanel$TransactionLog +
+net.sf.freecol.client.gui.action.ContinueAction +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.ServerListTableModel +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.client.gui.panel.FreeColProgressBar +
+net.sf.freecol.common.model.Nation +
+net.sf.freecol.common.model.GoodsTradeItem +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConceptDetailPanel +
+net.sf.freecol.client.gui.panel.FreeColConfirmDialog +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.option.AbstractUnitOptionUI$AbstractUnitRenderer +
+net.sf.freecol.client.gui.panel.ColonyPanel$ColonyInPortPanel +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.panel.OptionsDialog +
+net.sf.freecol.client.gui.panel.NegotiationDialog$InciteTradeItemPanel$InciteBoxRenderer +
+net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI +
+net.sf.freecol.common.model.GoodsTest +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.FreeColInputDialog +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.client.gui.panel.TrainPanel +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.StatisticsPanel$StatisticsModel +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer +
+net.sf.freecol.client.gui.panel.DumpCargoDialog +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.panel.AbstractGoodsLabel +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.client.gui.option.UnitTypeOptionUI$ChoiceRenderer +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.client.gui.panel.ReportProductionPanel +
+net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel +
+net.sf.freecol.common.model.Feature + +
+net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.common.ObjectWithId +
+net.sf.freecol.common.model.StringTemplate$TemplateType +
+net.sf.freecol.common.io.FreeColDataFile +
+net.sf.freecol.common.io.Mods +
+net.sf.freecol.common.model.Named +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.common.i18n.MessagesTest + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.StringTemplate$TemplateType +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.common.i18n.NameCache + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Region$RegionType +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.common.i18n.NumberRules + +None + +net.sf.freecol.common.io.FreeColXMLReader + +
+

net.sf.freecol.common.io

+ + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.io.AllTests + +net.sf.freecol.common.AllTests + + +None +
+net.sf.freecol.common.io.FreeColDataFile + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.sound.SoundTest + +
+net.sf.freecol.common.resources.ResourceMapper +
+net.sf.freecol.common.resources.ResourceFactory +
+net.sf.freecol.common.resources.ResourceMapping +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.common.io.FreeColDirectories + +net.sf.freecol.client.gui.panel.DifficultyDialog +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.client.gui.panel.GameOptionsDialog +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
+net.sf.freecol.client.gui.panel.OptionsDialog +
+net.sf.freecol.common.sound.SoundTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.action.ContinueAction +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.panel.ClientOptionsDialog +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.panel.ErrorPanel + +
+net.sf.freecol.FreeCol + +
+net.sf.freecol.common.io.FreeColModFile + +net.sf.freecol.client.gui.option.ModOptionUI$BoxRenderer +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.model.SpecificationTest +
+net.sf.freecol.common.option.ListOption +
+net.sf.freecol.common.option.ModOption +
+net.sf.freecol.common.option.ModListOption +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.option.ModOptionUI$ModOptionRenderer + +
+net.sf.freecol.common.ObjectWithId +
+net.sf.freecol.common.model.Specification + +
+net.sf.freecol.common.io.FreeColSavegameFile + +net.sf.freecol.server.SaveLoadTest +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
+net.sf.freecol.FreeCol +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.SerializationTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol.server.generator.MapGeneratorTest + +
+net.sf.freecol.FreeCol + +
+net.sf.freecol.common.io.FreeColTcFile + +net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.common.model.SpecificationTest +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.model.SerializationTest +
+net.sf.freecol.common.sound.SoundTest + +
+net.sf.freecol.common.resources.ResourceMapping + +
+net.sf.freecol.common.io.FreeColXMLReader + +net.sf.freecol.common.model.ColonyTradeItem +
+net.sf.freecol.common.model.RandomRange +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.option.AbstractOption +
+net.sf.freecol.common.model.Specification$ModifierReader +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.option.AbstractUnitOption +
+net.sf.freecol.common.model.EquipmentType +
+net.sf.freecol.common.model.ExportData +
+net.sf.freecol.common.model.TradeRouteStop +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.model.Scope +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.ai.mission.UnitWanderMission +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.server.ai.AIObject +
+net.sf.freecol.common.i18n.NumberRules +
+net.sf.freecol.common.option.UnitTypeOption +
+net.sf.freecol.common.model.TileItemContainer +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.common.model.UnitLocation +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.common.model.TileTypeChange +
+net.sf.freecol.common.model.EuropeanNationType +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.common.model.GoldTradeItem +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Operand +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.model.ProductionType +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.model.Limit +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.common.model.Disaster +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.model.UnitTradeItem +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.common.option.SelectOption +
+net.sf.freecol.common.option.StringOption +
+net.sf.freecol.common.model.Effect +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.common.networking.Connection +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.TradeItem +
+net.sf.freecol.common.model.HighSeas +
+net.sf.freecol.common.model.InciteTradeItem +
+net.sf.freecol.common.model.MarketData +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Event +
+net.sf.freecol.common.option.IntegerOption +
+net.sf.freecol.common.model.Specification$OptionReader +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.model.FreeColGameObjectType +
+net.sf.freecol.common.model.LastSale +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.option.Option +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.common.model.PlayerExploredTile +
+net.sf.freecol.common.model.Specification$TypeReader +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.model.Nation +
+net.sf.freecol.common.model.GoodsTradeItem +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.UnitTypeChange +
+net.sf.freecol.server.ai.Wish +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.common.model.SettlementType +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Resource +
+net.sf.freecol.server.ai.ValuedAIObject +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.common.option.ListOption +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.NationType +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.TileItem +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.common.model.Monarch$Force +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.common.model.Specification$ChildReader +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.common.model.GoodsLocation +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.common.model.Feature +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColGameObjectType +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.server.ai.AIObject +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Role + +
+net.sf.freecol.common.io.FreeColXMLReader$ReadScope + +net.sf.freecol.server.FreeColServer + + +None +
+net.sf.freecol.common.io.FreeColXMLWriter + +net.sf.freecol.common.model.ColonyTradeItem +
+net.sf.freecol.common.model.RandomRange +
+net.sf.freecol.common.model.IndianNationType +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.model.MonarchTest +
+net.sf.freecol.common.option.AbstractUnitOption +
+net.sf.freecol.common.model.EquipmentType +
+net.sf.freecol.common.model.ExportData +
+net.sf.freecol.common.model.TradeRouteStop +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.model.Scope +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.common.option.UnitTypeOption +
+net.sf.freecol.common.model.TileItemContainer +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.common.model.UnitLocation +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.common.model.TileTypeChange +
+net.sf.freecol.common.option.FileOption +
+net.sf.freecol.common.model.EuropeanNationType +
+net.sf.freecol.common.option.ModOption +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.common.model.GoldTradeItem +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Operand +
+net.sf.freecol.common.model.ProductionType +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.model.Limit +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.common.model.Disaster +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.model.UnitTradeItem +
+net.sf.freecol.common.model.SerializationTest +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Specification$Source +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.common.option.SelectOption +
+net.sf.freecol.common.option.StringOption +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.model.Effect +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.TradeItem +
+net.sf.freecol.common.model.HighSeas +
+net.sf.freecol.common.model.InciteTradeItem +
+net.sf.freecol.common.model.MarketData +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Event +
+net.sf.freecol.common.option.IntegerOption +
+net.sf.freecol.common.option.TextOption +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.model.FreeColGameObjectType +
+net.sf.freecol.common.model.LastSale +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.option.Option +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.PlayerExploredTile +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.model.Nation +
+net.sf.freecol.common.model.GoodsTradeItem +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.UnitTypeChange +
+net.sf.freecol.server.ai.Wish +
+net.sf.freecol.common.model.BuildingTest +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.common.model.SettlementType +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Resource +
+net.sf.freecol.server.ai.ValuedAIObject +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.common.option.ListOption +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.NationType +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.common.model.Monarch$Force +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.common.model.GoodsLocation +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.common.model.Feature +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.io.FreeColXMLWriter$WriteScope + +net.sf.freecol.common.model.MonarchTest +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.model.BuildingTest +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.SerializationTest +
+net.sf.freecol.server.FreeColServer + +
+None +
+net.sf.freecol.common.io.ModTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.io.Mods + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.common.option.ListOption +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.option.ModOption + +
+net.sf.freecol.common.util.LogBuilder + +
+

net.sf.freecol.common.logging

+ + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.logging.DefaultHandler + +net.sf.freecol.FreeCol + + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.networking.DOMMessage + +
+

net.sf.freecol.common.model

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.model.Ability + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.common.option.UnitTypeOption +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.AbstractGoods + +net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.ChoiceItem +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.panel.AbstractGoodsLabel +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.AbstractUnit + +net.sf.freecol.common.option.OptionTest +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.common.option.UnitListOption +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.server.model.MonarchSession +
+net.sf.freecol.client.gui.ChoiceItem +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.client.gui.panel.ReportCargoPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.common.option.AbstractUnitOption +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.AllTests + +net.sf.freecol.common.AllTests + + +None +
+net.sf.freecol.common.model.BaseCostDeciderTest + +None + +net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.common.model.BuildQueue$CompletionAction + +net.sf.freecol.server.model.ServerColony + + +None +
+net.sf.freecol.common.model.BuildableType + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueMouseAdapter +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.server.ai.ColonyPlan$BuildPlan +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.control.InGameController + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Building + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.ProductionCache$Entry +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.panel.ReportEducationPanel +
+net.sf.freecol.client.gui.panel.ReportProductionPanel +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.BuildingTest + +None + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.io.FreeColXMLWriter$WriteScope + +
+net.sf.freecol.common.model.BuildingType + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.client.gui.panel.ReportProductionPanel +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Colony + +net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.server.ai.ColonyPlan +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.client.gui.panel.ReportLabourDetailPanel +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.client.gui.panel.LabourData$UnitData +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.client.gui.action.LoadAction +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.common.networking.SetGoodsLevelsMessage +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.CanvasMouseListener +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.REFAIPlayer$TargetTuple +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.client.gui.panel.WarehouseDialog +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.networking.AbandonColonyMessage +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.common.networking.JoinColonyMessage +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.client.gui.panel.ReportEducationPanel +
+net.sf.freecol.common.networking.PayForBuildingMessage +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.ColonyPanel$ColonyInPortPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.server.ai.Wish +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.client.gui.panel.ReportProductionPanel +
+net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.common.model.Colony$ColonyChangeEvent + +net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel + +
+None +
+net.sf.freecol.common.model.Colony$NoBuildReason + +net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.model.ServerColony + +
+None +
+net.sf.freecol.common.model.Colony$TileImprovementSuggestion + +net.sf.freecol.client.gui.panel.ReportRequirementsPanel + + +None +
+net.sf.freecol.common.model.ColonyProductionTest + +None + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerColony + +
+net.sf.freecol.common.model.ColonyTest + +None + +net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.model.ColonyTile + +net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.ProductionCache$Entry +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.ColonyTradeItem + +net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel + + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.ColonyWas + +net.sf.freecol.client.control.InGameController + + +None +
+net.sf.freecol.common.model.CombatModel + +net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+None +
+net.sf.freecol.common.model.CombatModel$CombatOdds + +net.sf.freecol.server.ai.mission.PrivateerMission + + +None +
+net.sf.freecol.common.model.CombatModel$CombatResult + +net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.model.CombatTest + +None + +net.sf.freecol.util.test.MockPseudoRandom +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.option.IntegerOption +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.common.model.DiplomaticTrade + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.server.model.DiplomacySession +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.client.gui.panel.NegotiationDialog +
+net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.DiplomaticTrade$TradeContext + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.networking.DiplomacyMessage + +
+None +
+net.sf.freecol.common.model.DiplomaticTrade$TradeStatus + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+None +
+net.sf.freecol.common.model.Direction + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.server.generator.RiverSection +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.client.gui.ScrollThread +
+net.sf.freecol.client.gui.AbstractCanvasListener +
+net.sf.freecol.client.gui.action.MoveAction +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.client.gui.RoadPainter +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.server.generator.River +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$RiverTransform +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.model.Disaster + +net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Disaster$Effects + +net.sf.freecol.server.model.ServerPlayer + + +None +
+net.sf.freecol.common.model.DisasterTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.Effect + +net.sf.freecol.server.model.ServerPlayer + + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.EquipmentType + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Europe + +net.sf.freecol.common.model.pathfinding.CostDeciders$ServerBaseCostDecider +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.EmigrationDialog +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.server.ai.Cargo$CargoPlan +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.client.gui.panel.RecruitPanel +
+net.sf.freecol.common.model.pathfinding.BaseCostDecider +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.client.gui.panel.NewUnitPanel +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Europe$MigrationType + +net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.EmigrationDialog +
+net.sf.freecol.client.gui.panel.RecruitPanel +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.model.EuropeTest + +None + +net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.EuropeWas + +net.sf.freecol.client.control.InGameController + + +None +
+net.sf.freecol.common.model.EuropeanNationType + +net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellEditor +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellEditor +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Event + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.ExportData + +net.sf.freecol.common.networking.SetGoodsLevelsMessage +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
+net.sf.freecol.server.model.ServerColony + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Feature + +net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.server.control.ChangeSet$FeatureChange + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.FeatureContainer + +net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+None +
+net.sf.freecol.common.model.FoundingFather + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.client.gui.panel.ChooseFoundingFatherDialog +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.FoundingFather$FoundingFatherType + +net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.model.FoundingFatherTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.FreeColGameObject + +net.sf.freecol.server.control.ChangeSet$Change +
+net.sf.freecol.server.model.TransactionSession +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$DestinationCellRenderer +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.server.control.ChangeSet$PartialObjectChange +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.control.ChangeSet$RemoveChange +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.ai.Wish +
+net.sf.freecol.server.control.ChangeSet$FeatureChange +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.control.ChangeSet$ObjectChange +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.networking.RenameMessage +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.common.model.FreeColGameObjectListener + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.ai.AIMain + +
+None +
+net.sf.freecol.common.model.FreeColGameObjectType + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.common.io.FreeColXMLReader + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.FreeColObject + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.pathfinding.CostDeciders$ServerBaseCostDecider +
+net.sf.freecol.common.option.AbstractOption +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.networking.SetTradeRoutesMessage +
+net.sf.freecol.common.option.AbstractUnitOption +
+net.sf.freecol.common.option.RangeOption +
+net.sf.freecol.server.control.ChangeSet$OwnedChange +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.AIObject +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsAndBlockingUnitsCostDecider +
+net.sf.freecol.common.option.UnitTypeOption +
+net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.common.option.FileOption +
+net.sf.freecol.common.option.ModOption +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.option.SelectOption +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.option.StringOption +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.ColopediaPanel +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsCostDecider +
+net.sf.freecol.common.option.IntegerOption +
+net.sf.freecol.common.option.TextOption +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
+net.sf.freecol.client.gui.panel.ReportEducationPanel +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.control.ChangeSet$FeatureChange +
+net.sf.freecol.server.ai.ValuedAIObject +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.common.option.ListOption +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.ObjectWithId +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.io.FreeColXMLWriter$WriteScope +
+net.sf.freecol.common.util.Introspector +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.common.model.Game + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.networking.SetTradeRoutesMessage +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.common.networking.PutOutsideColonyMessage +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.common.networking.GetNationSummaryMessage +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.common.networking.SetGoodsLevelsMessage +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.common.networking.PayArrearsMessage +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.networking.SetCurrentStopMessage +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.PreCombatDialog +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.server.control.InGameController$DOMMessageCallable +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.common.networking.AbandonColonyMessage +
+net.sf.freecol.server.control.ChangeSet$AttackChange +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.client.control.InputHandler +
+net.sf.freecol.common.networking.LoginMessage +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.networking.RenameMessage +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.generator.MapLoader +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.common.networking.ClearSpecialityMessage +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.common.networking.SetDestinationMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.server.ai.AIObject +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler +
+net.sf.freecol.common.networking.ChatMessage +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.client.gui.action.ScaleMapAction +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.AssignTeacherMessage +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol.server.control.UserConnectionHandler +
+net.sf.freecol.server.control.ChangeSet$PlayerChange +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.common.networking.UpdateTradeRouteMessage +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.action.NewEmptyMapAction +
+net.sf.freecol.common.networking.AssignTradeRouteMessage +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.JoinColonyMessage +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.common.networking.PayForBuildingMessage +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.server.generator.MapLayerGenerator +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.common.networking.DeclareIndependenceMessage +
+net.sf.freecol.common.networking.DisbandUnitMessage +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.common.networking.MissionaryMessage + +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.model.ServerIndianSettlement + +
+net.sf.freecol.common.model.GameOptions + +net.sf.freecol.common.option.OptionTest +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.client.gui.panel.GameOptionsDialog +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.model.GameTest + +None + +net.sf.freecol.common.FreeColException +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.model.GoldTradeItem + +net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.control.InGameController + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Goods + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.client.gui.panel.CargoPanel +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoodsTradeItemPanel$GoodsBoxRenderer +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.client.gui.action.LoadAction +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.CaptureGoodsDialog$GoodsItem +
+net.sf.freecol.client.gui.panel.CaptureGoodsDialog +
+net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.client.gui.panel.EuropePanel$DocksPanel +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.model.LootSession +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.DropTarget +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.MonarchSession +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.client.gui.panel.DumpCargoDialog +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.ReportProductionPanel +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.GoodsContainer + +net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.client.gui.action.LoadAction +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.GoodsContainerTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.GoodsLocation + +net.sf.freecol.server.control.InGameController + + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.GoodsTest + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.networking.DOMMessage + +
+net.sf.freecol.common.model.GoodsTradeItem + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.GoodsType + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.client.gui.panel.CargoPanel +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.client.gui.panel.SelectAmountDialog +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.client.gui.panel.LabourData$UnitData +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.gui.action.LoadAction +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoPanel +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.ai.goal.Goal +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$GoodsPanel +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.common.networking.PayArrearsMessage +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoLabel +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.WorkLocationPlan +
+net.sf.freecol.client.gui.panel.WarehouseDialog +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.server.ai.ProductionCache$Entry +
+net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
+net.sf.freecol.client.gui.panel.ProductionLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.client.gui.panel.EuropePanel$TransactionLog +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.FreeColProgressBar +
+net.sf.freecol.client.gui.panel.EuropePanel$DocksPanel +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoHandler +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.DropTarget +
+net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.gui.panel.AbstractGoodsLabel +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.panel.ReportProductionPanel + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.HighScore + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.client.control.InGameController + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.io.FreeColDirectories + +
+net.sf.freecol.common.model.HighSeas + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.HighSeasTest + +None + +net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.HistoryEvent + +net.sf.freecol.client.gui.panel.ReportHistoryPanel +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.HistoryEvent$HistoryEventType + +net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.model.InciteTradeItem + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.IndianNationType + +net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.EditSettlementDialog + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.IndianSettlement + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.CollectionUtils + +
+net.sf.freecol.common.model.IndianSettlementTest + +None + +net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.IndividualFatherTest + +None + +net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.control.ChangeSet + +
+net.sf.freecol.common.model.LandMap + +net.sf.freecol.server.generator.TerrainGenerator + + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.MapGeneratorOptions +
+net.sf.freecol.common.option.SelectOption + +
+net.sf.freecol.common.model.LastSale + +net.sf.freecol.client.control.InGameInputHandler + + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Limit + +net.sf.freecol.server.model.ServerGame + + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.LimitTest + +None + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.option.IntegerOption +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.Locatable + +net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.Mission + +
+None +
+net.sf.freecol.common.model.Location + +net.sf.freecol.common.model.pathfinding.CostDeciders$ServerBaseCostDecider +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$DestinationCellRenderer +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsCostDecider +
+net.sf.freecol.client.gui.panel.ReportLabourDetailPanel +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.server.ai.Cargo$CargoPlan +
+net.sf.freecol.client.gui.panel.TradeRoutePanel +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.networking.SetDestinationMessage +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.control.ChangeSet$MoveChange +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$DestinationComparator +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
+net.sf.freecol.server.ai.mission.UnitWanderMission +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsAndBlockingUnitsCostDecider +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.control.ChangeSet$RemoveChange +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.server.ai.Wish +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.pathfinding.BaseCostDecider +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.common.model.pathfinding.GoalDeciders$MultipleAdjacentDecider +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.control.ChangeSet$ObjectChange +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.common.model.pathfinding.CostDecider +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.ObjectWithId + +
+net.sf.freecol.common.model.LostCityRumour + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$LostCityRumourTransform +
+net.sf.freecol.common.networking.DeclineMoundsMessage + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.RandomChoice + +
+net.sf.freecol.common.model.LostCityRumour$RumourType + +net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.client.gui.panel.EmigrationDialog + +
+None +
+net.sf.freecol.common.model.Map + +net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.ScaleMapSizeDialog +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.client.gui.action.NewEmptyMapAction +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.RoadPainter +
+net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.generator.River +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.client.gui.action.DetermineHighSeasAction +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.client.gui.action.ScaleMapAction +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.generator.SimpleMapGenerator$Territory +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.server.generator.MapGenerator +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.model.Map$Layer + +net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.server.generator.MapLoader +
+net.sf.freecol.server.generator.MapLayerGenerator +
+net.sf.freecol.server.generator.FreeColMapLoader + +
+None +
+net.sf.freecol.common.model.Map$MoveCandidate + +None + +net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.common.model.MapTest + +None + +net.sf.freecol.common.FreeColException +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.common.model.Market + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Market$Access + +net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.model.ServerColony + +
+None +
+net.sf.freecol.common.model.MarketData + +net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.MarketTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.MarketWas + +net.sf.freecol.client.control.InGameController + + +None +
+net.sf.freecol.common.model.ModelMessage + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerIndianSettlement + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.client.gui.panel.Utility + +
+net.sf.freecol.common.model.ModelMessage$MessageType + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel + +
+None +
+net.sf.freecol.common.model.ModelMessageTest + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.Modifier + +net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.Modifier$ModifierType + +net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.server.control.InGameControllerTest + +
+None +
+net.sf.freecol.common.model.ModifierTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.Monarch + +net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.model.Monarch$Force + +net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.option.UnitListOption +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Monarch$MonarchAction + +net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.MonarchSession +
+net.sf.freecol.client.gui.panel.MonarchDialog +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+None +
+net.sf.freecol.common.model.MonarchTest + +None + +net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.io.FreeColXMLWriter$WriteScope + +
+net.sf.freecol.common.model.MovementTest + +None + +net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.Nameable + +net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer +
+net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.networking.RenameMessage + +
+None +
+net.sf.freecol.common.model.Named + +net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer +
+net.sf.freecol.common.i18n.Messages + +
+None +
+net.sf.freecol.common.model.Nation + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.NationDetailPanel +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
+net.sf.freecol.client.gui.panel.PlayersTable$NationCellRenderer +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellEditor +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.NationOptions + +net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.generator.MapGeneratorTest + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.FreeCol + +
+net.sf.freecol.common.model.NationOptions$Advantages + +net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer + +
+None +
+net.sf.freecol.common.model.NationOptions$NationState + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
+net.sf.freecol.client.gui.panel.PlayersTable$NationStateRenderer +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellEditor +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellRenderer + +
+None +
+net.sf.freecol.common.model.NationSummary + +net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.networking.GetNationSummaryMessage + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.NationType + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
+net.sf.freecol.client.gui.panel.NationDetailPanel +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellEditor +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.NationTypeTest + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.Occupation + +None + +net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.common.model.Operand + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.Ownable + +net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.control.ChangeSet$ObjectChange +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.control.ChangeSet$RemoveChange +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.mission.Mission + +
+None +
+net.sf.freecol.common.model.PathNode + +net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.client.gui.CanvasMouseMotionListener +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.client.gui.CanvasMouseListener +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.server.ai.Cargo$CargoPlan +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.common.model.pathfinding.GoalDeciders$MultipleAdjacentDecider +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.REFAIPlayer$TargetTuple +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.common.model.PathfindingTest + +None + +net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.pathfinding.GoalDecider + +
+net.sf.freecol.common.model.Player + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$NameComparator +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.networking.PutOutsideColonyMessage +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.client.gui.action.DeclareIndependenceAction +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.common.networking.GetNationSummaryMessage +
+net.sf.freecol.common.networking.SetGoodsLevelsMessage +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.generator.SimpleMapGenerator$Territory +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.common.networking.PayArrearsMessage +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.GrayLayer +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.client.gui.panel.RecruitPanel +
+net.sf.freecol.common.networking.AbandonColonyMessage +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.client.gui.action.RetireAction +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$DestinationComparator +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.panel.ReportCargoPanel +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.control.ChangeSet$StanceChange +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer +
+net.sf.freecol.common.networking.LoginMessage +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.common.networking.RenameMessage +
+net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.panel.CargoPanel +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.client.gui.panel.SelectAmountDialog +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.common.networking.ClearSpecialityMessage +
+net.sf.freecol.client.gui.panel.TradeRoutePanel +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler +
+net.sf.freecol.common.networking.ChatMessage +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.ChoiceItem +
+net.sf.freecol.client.gui.action.UnloadAction +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.common.networking.AssignTeacherMessage +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$DistanceComparator +
+net.sf.freecol.server.control.UserConnectionHandler +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.action.SelectableAction +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.client.gui.panel.NewUnitPanel +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.JoinColonyMessage +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
+net.sf.freecol.common.networking.PayForBuildingMessage +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.client.gui.panel.NationDetailPanel +
+net.sf.freecol.client.gui.panel.NegotiationDialog$InciteTradeItemPanel$InciteBoxRenderer +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.MarketLabel +
+net.sf.freecol.common.networking.DeclareIndependenceMessage +
+net.sf.freecol.common.networking.DisbandUnitMessage +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.model.Player$ColonyValueCategory + +net.sf.freecol.client.gui.panel.TilePanel + + +None +
+net.sf.freecol.common.model.Player$NoClaimReason + +net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.networking.ClaimLandMessage + +
+None +
+net.sf.freecol.common.model.Player$NoValueType + +net.sf.freecol.common.debug.DebugUtils + + +None +
+net.sf.freecol.common.model.Player$PlayerType + +net.sf.freecol.client.gui.action.RetireAction +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.action.DeclareIndependenceAction +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.FreeColClient + +
+None +
+net.sf.freecol.common.model.PlayerExploredTile + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.PlayerTest + +None + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.model.ProductionInfo + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel + +
+None +
+net.sf.freecol.common.model.ProductionType + +net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.ProductionTypeTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.RandomRange + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.RandomRangeTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.Region + +net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.client.gui.panel.ReportExplorationPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.control.InGameInputHandler + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Region$RegionType + +net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.model.ServerRegion + +
+None +
+net.sf.freecol.common.model.Resource + +net.sf.freecol.client.gui.panel.MapEditorTransformPanel$ResourceTransform +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerColonyTile + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.ResourceType + +net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$ResourceTransform +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Role + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.common.option.AbstractUnitOption +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.model.RoleTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.SchoolTest + +None + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder + +
+net.sf.freecol.common.model.Scope + +net.sf.freecol.server.control.InGameControllerTest + + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.ScopeTest + +None + +net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.SerializationTest + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.io.FreeColTcFile +
+net.sf.freecol.common.io.FreeColXMLWriter$WriteScope +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.common.model.Settlement + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsCostDecider +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.server.control.ChangeSet$SpyChange +
+net.sf.freecol.client.gui.panel.FindSettlementPanel$SettlementRenderer +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.server.model.TradeSession +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$DestinationComparator +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.control.ChangeSet$RemoveChange +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.model.DiplomacySession +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.SettlementTest + +None + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.SettlementType + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.SimpleCombatModel + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.control.InGameControllerTest + +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.common.model.SoLTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.Specification + +net.sf.freecol.client.gui.panel.DifficultyDialog +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.client.gui.panel.ReportReligiousPanel +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.common.option.AbstractOption +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.option.AbstractUnitOption +
+net.sf.freecol.common.option.RangeOption +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.server.ai.AIObject +
+net.sf.freecol.common.option.UnitTypeOption +
+net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.option.UnitListOption +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.common.option.FileOption +
+net.sf.freecol.client.gui.panel.FreeColPanel +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.common.option.ModOption +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.FreeCol +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.option.PercentageOption +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.option.SelectOption +
+net.sf.freecol.common.option.StringOption +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.common.option.IntegerOption +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
+net.sf.freecol.common.option.TextOption +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.common.option.ModListOption +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.OptionsDialog +
+net.sf.freecol.client.gui.panel.ReportCargoPanel +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.common.option.ListOption +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.panel.FatherDetailPanel + +
+None +
+net.sf.freecol.common.model.Specification$ChildReader + +None + +net.sf.freecol.common.io.FreeColXMLReader + +
+net.sf.freecol.common.model.Specification$ModifierReader + +None + +net.sf.freecol.common.io.FreeColXMLReader + +
+net.sf.freecol.common.model.Specification$OptionReader + +None + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.io.FreeColXMLReader + +
+net.sf.freecol.common.model.Specification$Source + +None + +net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.Specification$TypeReader + +None + +net.sf.freecol.common.io.FreeColXMLReader + +
+net.sf.freecol.common.model.SpecificationTest + +None + +net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.io.FreeColTcFile + +
+net.sf.freecol.common.model.Stance + +net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.control.ChangeSet$StanceChange +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.client.gui.panel.NegotiationDialog$StanceTradeItemPanel$StanceBoxRenderer +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler + +
+None +
+net.sf.freecol.common.model.StanceTradeItem + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.StringTemplate + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.client.control.MapEditorController$ErrorJob +
+net.sf.freecol.client.gui.panel.CargoPanel +
+net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
+net.sf.freecol.client.gui.menu.DebugMenu +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel +
+net.sf.freecol.client.gui.panel.FindSettlementPanel$SettlementRenderer +
+net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
+net.sf.freecol.client.gui.panel.SelectTributeAmountDialog +
+net.sf.freecol.client.gui.panel.RecruitPanel +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.gui.panel.PlayersTable$NationCellRenderer +
+net.sf.freecol.client.gui.panel.NewUnitPanel +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.client.gui.panel.EuropePanel$TransactionLog +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.FreeColProgressBar +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.ColorCellRenderer +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.control.ConnectController$ErrorJob +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.MonarchDialog +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.common.networking.DeclareIndependenceMessage +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer +
+net.sf.freecol.client.gui.panel.FreeColDialog +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellRenderer +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.StringTemplate$TemplateType + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.i18n.MessagesTest + +
+None +
+net.sf.freecol.common.model.Tension + +net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.model.ServerIndianSettlement + +
+net.sf.freecol.common.i18n.Messages + +
+net.sf.freecol.common.model.Tension$Level + +net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.mission.Mission + +
+None +
+net.sf.freecol.common.model.Tile + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.client.gui.Canvas$DialogCallback +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel +
+net.sf.freecol.server.control.ChangeSet$MoveChange +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$TileTypeTransform +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsAndBlockingUnitsCostDecider +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.client.gui.RoadPainter +
+net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.server.generator.River +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.CanvasMouseMotionListener +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$ResourceTransform +
+net.sf.freecol.client.gui.CanvasMouseListener +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.common.model.pathfinding.BaseCostDecider +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.client.gui.action.ScaleMapAction +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.REFAIPlayer$TargetTuple +
+net.sf.freecol.server.generator.SimpleMapGenerator$Territory +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.generator.RiverSection +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.client.control.MapEditorController$IMapTransform +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.control.ChangeSet$SpyChange +
+net.sf.freecol.client.gui.action.ChangeAction +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.client.gui.action.NewEmptyMapAction +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.client.gui.action.ImprovementAction +
+net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$MapTransform +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.server.control.ChangeSet$RemoveChange +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$LostCityRumourTransform +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.common.model.pathfinding.GoalDeciders$MultipleAdjacentDecider +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$RiverTransform +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.control.ChangeSet$ObjectChange +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.model.TileImprovement + +net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
+net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.server.generator.RiverSection +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.generator.River +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$RiverTransform +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.TileImprovementStyle + +net.sf.freecol.client.gui.ImageLibrary + + +None +
+net.sf.freecol.common.model.TileImprovementTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.TileImprovementType + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.generator.River +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.client.gui.menu.InGameMenuBar +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.client.gui.action.ImprovementAction +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$RiverTransform +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.TileItem + +None + +net.sf.freecol.common.io.FreeColXMLReader + +
+net.sf.freecol.common.model.TileItemContainer + +net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.generator.FreeColMapLoader + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.TileItemContainerTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.TileTest + +None + +net.sf.freecol.util.test.FreeColTestCase + +
+net.sf.freecol.common.model.TileType + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.server.generator.ColonizationMapLoader +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$TileTypeTransform +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.generator.River +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.client.gui.panel.TerrainDetailPanel +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.TileType$RangeType + +net.sf.freecol.server.generator.TerrainGenerator + + +None +
+net.sf.freecol.common.model.TileTypeChange + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.TradeItem + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.NegotiationDialog$RemoveAction + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.TradeLocation + +net.sf.freecol.client.control.InGameController + + +None +
+net.sf.freecol.common.model.TradeRoute + +net.sf.freecol.common.networking.AssignTradeRouteMessage +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.UnitPanel +
+net.sf.freecol.common.networking.SetTradeRoutesMessage +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.TradeRoutePanel +
+net.sf.freecol.common.networking.UpdateTradeRouteMessage +
+net.sf.freecol.common.networking.SetCurrentStopMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.TradeRouteStop + +net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListHandler +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoHandler +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoPanel +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
+net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListTransferable + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.TradeRouteTest + +None + +net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.TransactionListener + +net.sf.freecol.client.gui.panel.EuropePanel$TransactionLog + + +None +
+net.sf.freecol.common.model.Turn + +net.sf.freecol.client.gui.panel.ModifierFormat +
+net.sf.freecol.client.gui.panel.ConstructionPanel +
+net.sf.freecol.client.gui.panel.RebelToolTip +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.common.i18n.Messages + +
+net.sf.freecol.common.model.Unit + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.common.networking.PutOutsideColonyMessage +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.client.gui.action.LoadAction +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.server.model.TradeSession +
+net.sf.freecol.server.control.ChangeSet$MoveChange +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.client.gui.action.AssignTradeRouteAction +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsAndBlockingUnitsCostDecider +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.client.gui.panel.PortPanel +
+net.sf.freecol.client.gui.action.BuildColonyAction +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.client.gui.CanvasMouseMotionListener +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.common.model.pathfinding.BaseCostDecider +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.common.networking.SetCurrentStopMessage +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.PreCombatDialog +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsCostDecider +
+net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.client.gui.action.ChangeAction +
+net.sf.freecol.server.control.ChangeSet$AttackChange +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.client.gui.action.GotoAction +
+net.sf.freecol.client.gui.action.ImprovementAction +
+net.sf.freecol.server.ai.ProductionCache$Entry +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.gui.panel.ReportCargoPanel +
+net.sf.freecol.client.gui.panel.BuildingPanel +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.EuropePanel$EuropeInPortPanel +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.client.gui.panel.UnitPanel +
+net.sf.freecol.common.networking.LoginMessage +
+net.sf.freecol.client.gui.panel.DumpCargoDialog +
+net.sf.freecol.server.model.DiplomacySession +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.server.control.ChangeSet$ObjectChange +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.model.pathfinding.CostDeciders$ServerBaseCostDecider +
+net.sf.freecol.client.gui.panel.NegotiationDialog$UnitTradeItemPanel$UnitBoxRenderer +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.client.gui.panel.CargoPanel +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.common.networking.ClearSpecialityMessage +
+net.sf.freecol.client.gui.panel.TradeRoutePanel +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.common.networking.SetDestinationMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.client.gui.panel.DragListener +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui.panel.InPortPanel +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.panel.MapControls +
+net.sf.freecol.server.model.LootSession +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.CanvasMouseListener +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.gui.action.UnloadAction +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.common.networking.AssignTeacherMessage +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.model.pathfinding.CostDecider +
+net.sf.freecol.server.control.UserConnectionHandler +
+net.sf.freecol.client.gui.panel.EndTurnDialog$UnitWrapper +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.server.ai.Cargo$CargoPlan +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.common.networking.AssignTradeRouteMessage +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
+net.sf.freecol.common.networking.JoinColonyMessage +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
+net.sf.freecol.client.gui.panel.ReportEducationPanel +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.client.gui.panel.EuropePanel$DocksPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$ColonyInPortPanel +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.client.gui.panel.DropTarget +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.common.model.pathfinding.GoalDeciders$MultipleAdjacentDecider +
+net.sf.freecol.common.networking.DisbandUnitMessage +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.common.model.Unit$MoveType + +net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
+net.sf.freecol.common.model.pathfinding.BaseCostDecider +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.model.Unit$UnitLabelType + +net.sf.freecol.client.gui.panel.EndTurnDialog$UnitWrapper +
+net.sf.freecol.client.gui.panel.UnitPanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.CargoPanel +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.TradeRoutePanel +
+net.sf.freecol.client.gui.panel.PreCombatDialog + +
+None +
+net.sf.freecol.common.model.Unit$UnitState + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.action.SkipUnitAction +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.action.ChangeAction +
+net.sf.freecol.client.gui.TilePopup +
+net.sf.freecol.client.gui.panel.EuropePanel$EuropeInPortPanel +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.action.SentryAction +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.action.ImprovementAction +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.action.FortifyAction +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.model.UnitLocation + +net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.UnitLocation$NoAddReason + +net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.server.ai.mission.TransportMission + +
+None +
+net.sf.freecol.common.model.UnitTest + +None + +net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerColony + +
+net.sf.freecol.common.model.UnitTradeItem + +None + +net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.UnitType + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.client.gui.panel.ReportLabourDetailPanel +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.client.gui.panel.LabourData$UnitData +
+net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.client.gui.panel.TilePanel +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.common.option.UnitTypeOption +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.ai.goal.Goal +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.panel.ReportLabourPanel$LabourUnitPanel +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.gui.panel.ReportNavalPanel +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.panel.ReportPanel +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
+net.sf.freecol.client.gui.panel.EmigrationDialog +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.client.gui.panel.ReportUnitPanel +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.RecruitPanel +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.client.gui.panel.NewUnitPanel +
+net.sf.freecol.client.gui.panel.UnitDetailPanel +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.BuildingDetailPanel +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.gui.panel.ReportCargoPanel +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
+net.sf.freecol.client.gui.panel.GoodsDetailPanel +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.gui.option.UnitTypeOptionUI$ChoiceRenderer + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.UnitTypeChange + +net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.ai.ProductionCache$Entry + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter + +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType + +net.sf.freecol.server.ai.ProductionCache$Entry +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.model.UnitTypeChangeTest + +None + +net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.model.ServerUnit + +
+net.sf.freecol.common.model.UnitWas + +net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.ai.AIColony + +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.model.WorkLocation + +net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
+net.sf.freecol.server.ai.ProductionCache +
+net.sf.freecol.client.gui.panel.UnitLabel +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.ai.WorkLocationPlan +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.client.gui.panel.CompactLabourReport +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.client.gui.panel.ColonyPanel +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.ProductionCache$Entry +
+net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.control.ChangeSet$ObjectChange +
+net.sf.freecol.client.gui.panel.QuickActionMenu +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+

net.sf.freecol.common.model.pathfinding

+ + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.model.pathfinding.BaseCostDecider + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Unit$MoveType + +
+net.sf.freecol.common.model.pathfinding.CostDecider + +net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.model.BaseCostDeciderTest +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.common.model.Map$MoveCandidate +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location + +
+net.sf.freecol.common.model.pathfinding.CostDeciders + +net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.model.BaseCostDeciderTest +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Europe + +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Ability + +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsAndBlockingUnitsCostDecider + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsCostDecider + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.model.pathfinding.CostDeciders$ServerBaseCostDecider + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.model.pathfinding.GoalDecider + +net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.common.model.PathfindingTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.PathNode + +
+net.sf.freecol.common.model.pathfinding.GoalDeciders + +net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.common.model.PathfindingTest +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.PathNode + +
+net.sf.freecol.common.model.pathfinding.GoalDeciders$MultipleAdjacentDecider + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.PathNode + +
+

net.sf.freecol.common.networking

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.networking.AbandonColonyMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.AskSkillMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.AssignTeacherMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.AssignTradeRouteMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.AttackMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.BuildColonyMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.BuyMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.BuyPropositionMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ChangeStateMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ChatMessage + +net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.client.control.InGameInputHandler + +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.FoundingFather$FoundingFatherType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ClaimLandMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Player$NoClaimReason +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ClearSpecialityMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.Client + +None + +net.sf.freecol.common.FreeColException + +
+net.sf.freecol.common.networking.CloseTransactionMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.Connection + +net.sf.freecol.server.control.InputHandler$DisconnectHandler +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.server.control.InGameController$DOMMessageCallable +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.control.InputHandler +
+net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.networking.DummyConnection +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.client.control.InputHandler +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.control.UserConnectionHandler + +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode + +
+net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.server.control.FreeColServerHolder +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.DOMMessage + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.server.control.InGameController$DOMMessageCallable +
+net.sf.freecol.server.control.InGameController$DOMMessageHandler +
+net.sf.freecol.server.control.ChangeSet$MessageChange +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.control.InputHandler +
+net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.common.model.GoodsTest +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.logging.DefaultHandler +
+net.sf.freecol.server.control.UserConnectionHandler + +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.util.Introspector + +
+net.sf.freecol.common.networking.DeclareIndependenceMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.DeclineMoundsMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.common.model.LostCityRumour$RumourType +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.DeliverGiftMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.DemandTributeMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.DiplomacyMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.DiplomaticTrade$TradeContext +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.DisbandUnitMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.DisembarkMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.EmbarkMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.EmigrateUnitMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Europe$MigrationType +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.EquipForRoleMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.FirstContactMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.GetNationSummaryMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.GetTransactionMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.GoodsForSaleMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.InciteMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.IndianDemandMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.JoinColonyMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.LearnSkillMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.LoadGoodsMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.LoginMessage + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.server.control.UserConnectionHandler + +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.LootCargoMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.Message + +None + +net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode + +
+net.sf.freecol.common.networking.MessageHandler + +net.sf.freecol.client.control.InputHandler +
+net.sf.freecol.server.control.InputHandler +
+net.sf.freecol.server.networking.DummyConnection +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.server.control.UserConnectionHandler + +
+net.sf.freecol.common.FreeColException + +
+net.sf.freecol.common.networking.MissionaryMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.MonarchActionMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.MoveMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.MoveToMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.NetworkConstants + +net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+None +
+net.sf.freecol.common.networking.NetworkRequestHandler + +net.sf.freecol.server.control.InputHandler +
+net.sf.freecol.server.control.InputHandler$DisconnectHandler + +
+None +
+net.sf.freecol.common.networking.NewLandNameMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.NewRegionNameMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.client.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIInGameInputHandler + +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.PayArrearsMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.PayForBuildingMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.PutOutsideColonyMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.RearrangeColonyMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+None +
+net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange + +None + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Role + +
+net.sf.freecol.common.networking.RenameMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.model.Nameable + +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.SellMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.SellPropositionMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.ServerAPI + +net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.networking.UserServerAPI +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.ExportData +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.HighScore +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.common.networking.SetBuildQueueMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.SetCurrentStopMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.SetDestinationMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.SetGoodsLevelsMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.ExportData +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.SetTradeRoutesMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.SpySettlementMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.UnloadGoodsMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.UpdateTradeRouteMessage + +net.sf.freecol.server.control.InGameInputHandler + + +net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.networking.WorkMessage + +net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.server.ai.AIMessage + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+

net.sf.freecol.common.option

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.option.AbstractOption + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.AbstractUnitOption + +net.sf.freecol.client.gui.option.AbstractUnitOptionUI$AbstractUnitRenderer +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.option.AbstractUnitOptionUI + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.AllTests + +net.sf.freecol.common.AllTests + + +None +
+net.sf.freecol.common.option.AudioMixerOption + +net.sf.freecol.client.gui.option.AudioMixerOptionUI +
+net.sf.freecol.common.sound.SoundPlayer +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.control.SoundController +
+net.sf.freecol.common.sound.SoundTest + +
+None +
+net.sf.freecol.common.option.AudioMixerOption$MixerWrapper + +net.sf.freecol.client.gui.option.AudioMixerOptionUI +
+net.sf.freecol.common.sound.SoundPlayer + +
+None +
+net.sf.freecol.common.option.BooleanOption + +net.sf.freecol.common.model.BaseCostDeciderTest +
+net.sf.freecol.client.gui.panel.ReportTurnPanel +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.client.gui.option.BooleanOptionUI +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.FileOption + +net.sf.freecol.server.SaveLoadTest +
+net.sf.freecol.client.gui.option.FileOptionUI +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.server.generator.MapGeneratorTest + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.IntegerOption + +net.sf.freecol.common.model.LimitTest +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.option.IntegerOptionUI + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.LanguageOption + +net.sf.freecol.client.gui.option.LanguageOptionUI +
+net.sf.freecol.client.gui.option.OptionUI + +
+None +
+net.sf.freecol.common.option.LanguageOption$Language + +net.sf.freecol.client.gui.option.LanguageOptionUI +
+net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.util.Utils + +
+net.sf.freecol.common.option.ListOption + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.io.Mods +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.MapGeneratorOptions + +net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.server.SaveLoadTest +
+net.sf.freecol.common.model.LandMap +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
+net.sf.freecol.server.generator.MapGeneratorTest + +
+None +
+net.sf.freecol.common.option.ModListOption + +net.sf.freecol.client.gui.option.OptionUI + + +net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.common.model.Specification + +
+net.sf.freecol.common.option.ModOption + +net.sf.freecol.client.gui.option.ModOptionUI +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.option.ModOptionUI$ModOptionRenderer + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.io.FreeColModFile +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.io.Mods +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.Option + +net.sf.freecol.client.gui.panel.EditOptionDialog +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.gui.option.OptionGroupUI +
+net.sf.freecol.client.control.SoundController + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.ObjectWithId + +
+net.sf.freecol.common.option.OptionGroup + +net.sf.freecol.client.gui.panel.DifficultyDialog +
+net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
+net.sf.freecol.client.gui.panel.OptionsDialog +
+net.sf.freecol.client.gui.option.OptionGroupUI +
+net.sf.freecol.common.model.NationTypeTest +
+net.sf.freecol.common.model.Specification$OptionReader +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.gui.panel.ClientOptionsDialog +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.LandMap +
+net.sf.freecol.client.gui.panel.StartGamePanel +
+net.sf.freecol.client.gui.panel.GameOptionsDialog +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.client.control.PreGameController +
+net.sf.freecol.common.model.SerializationTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.client.control.PreGameInputHandler +
+net.sf.freecol.client.gui.action.ActionManager +
+net.sf.freecol.client.gui.panel.NewPanel +
+net.sf.freecol.client.gui.GUI + +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification + +
+net.sf.freecol.common.option.OptionTest + +None + +net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.GameOptions + +
+net.sf.freecol.common.option.PercentageOption + +net.sf.freecol.common.sound.SoundPlayer +
+net.sf.freecol.client.gui.option.PercentageOptionUI +
+net.sf.freecol.client.gui.option.OptionUI +
+net.sf.freecol.client.control.SoundController +
+net.sf.freecol.common.sound.SoundTest + +
+net.sf.freecol.common.model.Specification + +
+net.sf.freecol.common.option.RangeOption + +net.sf.freecol.client.gui.option.RangeOptionUI +
+net.sf.freecol.client.gui.option.OptionUI + +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.SelectOption + +net.sf.freecol.client.gui.option.SelectOptionUI +
+net.sf.freecol.common.model.LandMap +
+net.sf.freecol.client.gui.option.OptionUI + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.StringOption + +net.sf.freecol.client.gui.option.StringOptionUI +
+net.sf.freecol.client.gui.option.OptionUI + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.TextOption + +net.sf.freecol.client.gui.option.TextOptionUI +
+net.sf.freecol.client.gui.option.OptionUI + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.common.option.UnitListOption + +net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.common.model.Monarch$Force +
+net.sf.freecol.client.gui.option.OptionUI + +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.AbstractUnit + +
+net.sf.freecol.common.option.UnitTypeOption + +net.sf.freecol.client.gui.option.UnitTypeOptionUI + + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.FreeColObject + +
+

net.sf.freecol.common.resources

+ + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.resources.AudioResource + +None + +net.sf.freecol.common.sound.SoundPlayer + +
+net.sf.freecol.common.resources.FAFile + +net.sf.freecol.client.gui.panel.DeclarationPanel$SignaturePanel + + +None +
+net.sf.freecol.common.resources.ResourceFactory + +net.sf.freecol.common.io.FreeColDataFile + + +None +
+net.sf.freecol.common.resources.ResourceManager + +net.sf.freecol.client.gui.ImageLibrary +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.client.gui.panel.EventPanel +
+net.sf.freecol.client.gui.panel.BuildingToolTip +
+net.sf.freecol.client.gui.ChatDisplay +
+net.sf.freecol.client.gui.panel.Utility +
+net.sf.freecol.client.control.SoundController +
+net.sf.freecol.client.gui.panel.UnitButton$UnitButtonActionPropertyChangeListener +
+net.sf.freecol.common.sound.SoundTest +
+net.sf.freecol.client.gui.panel.MainPanel +
+net.sf.freecol.client.gui.panel.DeclarationPanel$SignaturePanel +
+net.sf.freecol.client.gui.plaf.FreeColLookAndFeel +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.client.gui.panel.IndianSettlementPanel +
+net.sf.freecol.client.gui.FontLibrary +
+net.sf.freecol.client.gui.panel.MiniMap +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.client.gui.SwingGUI +
+net.sf.freecol.client.gui.panel.FirstContactDialog +
+net.sf.freecol.client.gui.panel.GoodsLabel +
+net.sf.freecol.client.gui.panel.ColopediaTreeCellRenderer +
+net.sf.freecol.client.gui.panel.RiverStyleDialog +
+net.sf.freecol.client.gui.panel.InformationPanel +
+net.sf.freecol.client.gui.panel.ReportIndianPanel +
+net.sf.freecol.client.gui.panel.FreeColImageBorder +
+net.sf.freecol.client.gui.panel.DeclarationPanel +
+net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
+net.sf.freecol.client.gui.FreeColFrame +
+net.sf.freecol.client.gui.panel.AboutPanel +
+net.sf.freecol.client.gui.panel.ReportTradePanel +
+net.sf.freecol.client.gui.panel.UnitButton +
+net.sf.freecol.client.gui.GUI +
+net.sf.freecol.client.gui.panel.VictoryDialog +
+net.sf.freecol.client.gui.panel.ClassicMapControls +
+net.sf.freecol.client.gui.panel.FatherDetailPanel +
+net.sf.freecol.client.gui.RoadPainter + +
+net.sf.freecol.FreeCol +
+net.sf.freecol.client.FreeColClient + +
+net.sf.freecol.common.resources.ResourceMapper + +net.sf.freecol.common.io.FreeColDataFile + + +None +
+net.sf.freecol.common.resources.ResourceMapping + +net.sf.freecol.common.io.FreeColDataFile +
+net.sf.freecol.common.io.FreeColTcFile +
+net.sf.freecol.client.FreeColClient + +
+None +
+net.sf.freecol.common.resources.Video + +net.sf.freecol.client.gui.video.VideoComponent +
+net.sf.freecol.client.gui.SwingGUI + +
+None +
+

net.sf.freecol.common.sound

+ + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.sound.AllTests + +net.sf.freecol.common.AllTests + + +None +
+net.sf.freecol.common.sound.SoundPlayer + +net.sf.freecol.common.resources.AudioResource +
+net.sf.freecol.client.control.SoundController + +
+net.sf.freecol.common.option.PercentageOption +
+net.sf.freecol.common.option.AudioMixerOption +
+net.sf.freecol.common.option.AudioMixerOption$MixerWrapper + +
+net.sf.freecol.common.sound.SoundPlayer$SoundPlayerThread + +None + +net.sf.freecol.FreeCol + +
+net.sf.freecol.common.sound.SoundTest + +None + +net.sf.freecol.common.option.PercentageOption +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.client.ClientOptions +
+net.sf.freecol.common.io.FreeColDataFile +
+net.sf.freecol.common.option.AudioMixerOption +
+net.sf.freecol.common.io.FreeColTcFile +
+net.sf.freecol.common.resources.ResourceManager +
+net.sf.freecol.common.io.FreeColDirectories + +
+

net.sf.freecol.common.util

+ + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.util.CollectionUtils + +net.sf.freecol.common.utils.UtilsTest +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.model.IndianSettlement + +
+None +
+net.sf.freecol.common.util.Introspector + +net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.model.FreeColObject + +
+None +
+net.sf.freecol.common.util.LogBuilder + +net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.common.io.Mods +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.ai.mission.UnitWanderMission +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
+net.sf.freecol.common.model.SimpleCombatModel +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.generator.MapGenerator +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.io.FreeColDataFile +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Occupation +
+net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol.server.ai.mission.PioneeringMission +
+net.sf.freecol.server.model.ServerModelObject + +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.Location + +
+net.sf.freecol.common.util.RandomChoice + +net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.common.util.Utils + +net.sf.freecol.common.model.ColonyTradeItem +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.TradeItem +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.TileTypeChange +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.common.model.InciteTradeItem +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.option.ModOption +
+net.sf.freecol.common.model.Operand +
+net.sf.freecol.client.gui.TileViewer$SortableImage +
+net.sf.freecol.common.model.ProductionType +
+net.sf.freecol.common.option.LanguageOption$Language +
+net.sf.freecol.common.model.UnitWas +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.option.TextOption +
+net.sf.freecol.client.ClientOptions$MessageSourceComparator +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.server.ai.REFAIPlayer$TargetTuple +
+net.sf.freecol.common.model.UnitTradeItem +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.Scope +
+net.sf.freecol.common.logging.DefaultHandler +
+net.sf.freecol.common.option.StringOption +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.GoodsTradeItem +
+net.sf.freecol.common.model.Feature + +
+None +
+

net.sf.freecol.common.utils

+ + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.common.utils.AllTests + +net.sf.freecol.common.AllTests + + +None +
+net.sf.freecol.common.utils.UtilsTest + +None + +net.sf.freecol.common.util.CollectionUtils +
+net.sf.freecol.util.test.FreeColTestCase + +
+

net.sf.freecol.server

+ + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.AllTests + +net.sf.freecol.AllTests + + +net.sf.freecol.server.control.AllTests +
+net.sf.freecol.server.ai.AllTests +
+net.sf.freecol.server.model.AllTests + +
+net.sf.freecol.server.FreeColServer + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.server.control.Controller +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.networking.SetTradeRoutesMessage +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.common.networking.ClearSpecialityMessage +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.common.networking.PutOutsideColonyMessage +
+net.sf.freecol.common.networking.UpdateTradeRouteMessage +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.common.networking.AbandonColonyMessage +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.common.networking.AssignTradeRouteMessage +
+net.sf.freecol.common.networking.SetDestinationMessage +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.JoinColonyMessage +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.common.networking.GetNationSummaryMessage +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.common.networking.PayForBuildingMessage +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.common.networking.SetGoodsLevelsMessage +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.server.control.InputHandler +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage +
+net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler +
+net.sf.freecol.common.networking.ChatMessage +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.common.networking.DeclareIndependenceMessage +
+net.sf.freecol.common.networking.DisbandUnitMessage +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.common.networking.LoginMessage +
+net.sf.freecol.common.networking.PayArrearsMessage +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.server.control.FreeColServerHolder +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.common.networking.AssignTeacherMessage +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.client.control.InGameController +
+net.sf.freecol.common.networking.RenameMessage +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.common.networking.SetCurrentStopMessage +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.client.ClientTestHelper +
+net.sf.freecol.server.control.UserConnectionHandler + +
+net.sf.freecol.server.model.TransactionSession +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.common.io.FreeColXMLReader$ReadScope +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.server.control.Controller +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.io.FreeColDirectories +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.io.FreeColXMLWriter$WriteScope +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.model.Nation +
+net.sf.freecol.server.generator.SimpleMapGenerator +
+net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.networking.DummyConnection +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.option.BooleanOption +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.server.generator.MapGenerator +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.FreeColSeed +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.control.UserConnectionHandler +
+net.sf.freecol.common.networking.Connection +
+net.sf.freecol.server.model.ServerModelObject + +
+net.sf.freecol.server.FreeColServer$GameState + +net.sf.freecol.client.control.ConnectController +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.client.FreeColClient +
+net.sf.freecol.server.control.UserConnectionHandler + +
+None +
+net.sf.freecol.server.SaveLoadTest + +None + +net.sf.freecol.common.option.MapGeneratorOptions +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.common.option.FileOption +
+net.sf.freecol.server.control.Controller + +
+net.sf.freecol.server.ServerTestHelper + +net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.common.model.SerializationTest +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest + +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.server.control.Controller +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.server.control.InGameController + +
+

net.sf.freecol.server.ai

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.ai.AIColony + +net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.UnitWas +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.server.ai.mission.PioneeringMission +
+net.sf.freecol.common.model.ProductionInfo + +
+net.sf.freecol.server.ai.AIColonyTest + +None + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.AIGoods + +net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.mission.TransportMission + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Locatable +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.ai.mission.Mission + +
+net.sf.freecol.server.ai.AIInGameInputHandler + +net.sf.freecol.server.FreeColServer + + +net.sf.freecol.common.model.DiplomaticTrade$TradeStatus +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.networking.MessageHandler +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.ai.AIMain + +net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.mission.UnitWanderMission +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColGameObjectListener +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.server.ai.AIMessage + +net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.common.networking.ClearSpecialityMessage +
+net.sf.freecol.common.networking.PutOutsideColonyMessage +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.common.networking.RearrangeColonyMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.common.networking.GetNationSummaryMessage +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.networking.DisbandUnitMessage +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.ai.AIObject + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.goal.Goal +
+net.sf.freecol.server.ai.mission.Mission + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.server.ai.AIPlayer + +net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.ai.goal.Goal +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
+net.sf.freecol.server.ai.mission.Mission + +
+net.sf.freecol.common.model.DiplomaticTrade$TradeStatus +
+net.sf.freecol.server.networking.DummyConnection +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.ai.AIUnit + +net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.mission.UnitWanderMission +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.ai.goal.Goal +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Locatable +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.mission.UnitWanderMission +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.common.model.UnitLocation +
+net.sf.freecol.server.ai.goal.Goal +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.server.ai.AllTests + +net.sf.freecol.server.AllTests + + +net.sf.freecol.server.ai.mission.AllTests + +
+net.sf.freecol.server.ai.Cargo + +net.sf.freecol.server.ai.mission.TransportMission + + +None +
+net.sf.freecol.server.ai.Cargo$CargoMode + +net.sf.freecol.server.ai.mission.TransportMission + + +None +
+net.sf.freecol.server.ai.Cargo$CargoPlan + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.PathNode + +
+net.sf.freecol.server.ai.ColonyPlan + +None + +net.sf.freecol.common.model.Colony + +
+net.sf.freecol.server.ai.ColonyPlan$BuildPlan + +None + +net.sf.freecol.common.model.BuildableType + +
+net.sf.freecol.server.ai.ColonyPlanTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.ContactTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.goal.Goal +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.EuropeanAIPlayer + +net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.TradeItem +
+net.sf.freecol.common.util.CollectionUtils +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
+net.sf.freecol.common.model.Player$PlayerType +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.common.util.RandomChoice +
+net.sf.freecol.server.ai.mission.BuildColonyMission +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.common.model.Europe$MigrationType +
+net.sf.freecol.server.ai.mission.ScoutingMission +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.common.model.DiplomaticTrade$TradeStatus +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.FeatureContainer +
+net.sf.freecol.common.model.GoldTradeItem +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.ai.mission.PrivateerMission +
+net.sf.freecol.server.ai.mission.MissionaryMission +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.server.ai.mission.WishRealizationMission +
+net.sf.freecol.common.model.DiplomaticTrade$TradeContext +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.server.ai.GoodsWish + +net.sf.freecol.server.ai.mission.WishRealizationMission + + +net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.server.ai.MissionAssignmentTest + +None + +net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.NativeAIPlayer + +None + +net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.model.FeatureContainer +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.ai.mission.Mission +
+net.sf.freecol.common.util.RandomChoice +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.server.ai.mission.DefendSettlementMission +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.server.ai.mission.IndianDemandMission +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.CombatModel +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.pathfinding.CostDecider +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission + +
+net.sf.freecol.server.ai.ProductionCache + +None + +net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.Market + +
+net.sf.freecol.server.ai.ProductionCache$Entry + +None + +net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.UnitTypeChange + +
+net.sf.freecol.server.ai.REFAIPlayer$TargetTuple + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.util.Utils +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode + +
+net.sf.freecol.server.ai.REFTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.StandardAIPlayerTest + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.TensionTest + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.TileImprovementPlan + +net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.server.ai.mission.PioneeringMission + +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.server.ai.TransportableAIObject + +net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.server.ai.mission.Mission + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Locatable +
+net.sf.freecol.server.ai.mission.TransportMission +
+net.sf.freecol.common.model.PathNode + +
+net.sf.freecol.server.ai.ValuedAIObject + +None + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.FreeColObject + +
+net.sf.freecol.server.ai.Wish + +net.sf.freecol.server.ai.mission.WishRealizationMission + + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Colony + +
+net.sf.freecol.server.ai.WorkLocationPlan + +None + +net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.WorkLocation + +
+net.sf.freecol.server.ai.WorkerWish + +net.sf.freecol.server.ai.mission.WishRealizationMission + + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.util.LogBuilder + +
+

net.sf.freecol.server.ai.goal

+ + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal + +net.sf.freecol.server.ai.ContactTest + + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.PathNode + +
+net.sf.freecol.server.ai.goal.Goal + +net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.ai.AIObject +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.server.ai.goal.GotoAdjacentGoal + +None + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.PathNode + +
+net.sf.freecol.server.ai.goal.ManageMissionariesGoal + +None + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.PathNode + +
+

net.sf.freecol.server.ai.mission

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.ai.mission.AllTests + +net.sf.freecol.server.ai.AllTests + + +None +
+net.sf.freecol.server.ai.mission.BuildColonyMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Player$NoClaimReason +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.server.ai.mission.CashInTreasureTrainMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.server.ai.mission.DefendSettlementMission + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.CombatModel +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType + +
+net.sf.freecol.server.ai.mission.IdleAtSettlementMission + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.server.ai.mission.IndianBringGiftMission + +net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Unit$MoveType + +
+net.sf.freecol.server.ai.mission.IndianDemandMission + +net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.GameOptions + +
+net.sf.freecol.server.ai.mission.Mission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.AIGoods + +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Locatable +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.server.ai.AIObject +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.server.ai.mission.MissionaryMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.server.ai.mission.PioneeringMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.TileImprovementPlan +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.mission.PrivateerMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.CombatModel$CombatOdds +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType + +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.mission.ScoutingMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.mission.TransportMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.ai.Cargo$CargoMode +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.UnitLocation$NoAddReason +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.Locatable +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.server.ai.Cargo +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.CombatModel +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.common.model.pathfinding.CostDecider + +
+net.sf.freecol.server.ai.mission.TransportMissionTest + +None + +net.sf.freecol.common.model.CombatModel$CombatResult +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.ai.AIGoods +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.ai.TransportableAIObject +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.PathNode +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.AIMessage +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.CombatModel +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType + +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.ai.mission.UnitWanderHostileMission + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.server.ai.mission.UnitWanderMission + +net.sf.freecol.server.ai.AIUnit + + +net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.server.ai.mission.WishRealizationMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.ai.GoodsWish +
+net.sf.freecol.server.ai.Wish +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.common.model.Unit$MoveType + +
+net.sf.freecol.server.ai.mission.WorkInsideColonyMission + +net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit + +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.io.FreeColXMLWriter +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.pathfinding.CostDeciders +
+net.sf.freecol.server.ai.AIColony +
+net.sf.freecol.server.ai.AIUnit +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.util.LogBuilder + +
+

net.sf.freecol.server.control

+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.control.AllTests + +net.sf.freecol.server.AllTests + + +None +
+net.sf.freecol.server.control.ChangeSet + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.model.TransactionSession +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.server.model.LootSession +
+net.sf.freecol.server.model.TradeSession +
+net.sf.freecol.server.model.MonarchSession +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.common.model.IndividualFatherTest +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.DiplomacySession +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol.server.model.ServerModelObject + +
+None +
+net.sf.freecol.server.control.ChangeSet$AttackChange + +None + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$AttributeChange + +None + +net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$Change + +None + +net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$ChangePriority + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+None +
+net.sf.freecol.server.control.ChangeSet$FeatureChange + +None + +net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Feature + +
+net.sf.freecol.server.control.ChangeSet$MessageChange + +None + +net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$MoveChange + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$ObjectChange + +None + +net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$OwnedChange + +None + +net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$PartialObjectChange + +None + +net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$PlayerChange + +None + +net.sf.freecol.common.model.Game +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$RemoveChange + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$See + +net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.server.model.ServerEurope +
+net.sf.freecol.server.model.ServerColonyTile +
+net.sf.freecol.server.model.DiplomacySession +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$SpyChange + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$StanceChange + +None + +net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.ChangeSet$TrivialChange + +None + +net.sf.freecol.server.model.ServerPlayer + +
+net.sf.freecol.server.control.Controller + +net.sf.freecol.server.SaveLoadTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.server.control.FreeColServerHolder + +net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler + + +net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.server.control.InGameController + +net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.common.model.Monarch +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Disaster +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol.common.model.Monarch$Force +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.NationSummary +
+net.sf.freecol.common.model.GoodsLocation +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.server.control.InGameController$DOMMessageCallable + +None + +net.sf.freecol.common.model.Game +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.control.InGameController$DOMMessageHandler + +None + +net.sf.freecol.common.networking.DOMMessage + +
+net.sf.freecol.server.control.InGameControllerTest + +None + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.CombatModel$CombatResult +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.common.model.Event +
+net.sf.freecol.common.model.Player$PlayerType +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.Modifier$ModifierType +
+net.sf.freecol.common.model.Unit$MoveType +
+net.sf.freecol.common.model.FoundingFather$FoundingFatherType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Scope +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.Nation +
+net.sf.freecol.server.model.ServerBuilding +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.UnitTypeChange +
+net.sf.freecol.server.model.ServerColony +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.SimpleCombatModel +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.control.InGameInputHandler + +net.sf.freecol.server.FreeColServer + + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.networking.SetTradeRoutesMessage +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.common.networking.ClearSpecialityMessage +
+net.sf.freecol.common.networking.PutOutsideColonyMessage +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.common.networking.UpdateTradeRouteMessage +
+net.sf.freecol.common.networking.AbandonColonyMessage +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.common.networking.RearrangeColonyMessage +
+net.sf.freecol.common.networking.AssignTradeRouteMessage +
+net.sf.freecol.common.networking.SetDestinationMessage +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.JoinColonyMessage +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.common.networking.GetNationSummaryMessage +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.common.networking.NetworkConstants +
+net.sf.freecol.common.networking.PayForBuildingMessage +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.SetGoodsLevelsMessage +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.common.networking.DeclareIndependenceMessage +
+net.sf.freecol.common.networking.DisbandUnitMessage +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.common.networking.PayArrearsMessage +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.common.networking.AssignTeacherMessage +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.common.networking.RenameMessage +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.networking.MissionaryMessage +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.common.networking.SetCurrentStopMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.control.InputHandler + +None + +net.sf.freecol.common.networking.MessageHandler +
+net.sf.freecol.common.networking.NetworkRequestHandler +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.control.InputHandler$DisconnectHandler + +None + +net.sf.freecol.common.networking.NetworkRequestHandler +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.control.PreGameController + +net.sf.freecol.server.SaveLoadTest +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.FreeColServer$GameState +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.control.PreGameInputHandler + +net.sf.freecol.server.FreeColServer + + +net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.NationType +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.NationOptions$Advantages +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.Connection +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.server.control.UserConnectionHandler + +net.sf.freecol.server.FreeColServer + + +net.sf.freecol.server.FreeColServer$GameState +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.networking.MessageHandler +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.networking.Server +
+net.sf.freecol.common.networking.DOMMessage +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.networking.LoginMessage +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.Connection + +
+

net.sf.freecol.server.generator

+ + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.generator.AllTests + +net.sf.freecol.AllTests + + +None +
+net.sf.freecol.server.generator.ColonizationMapLoader + +None + +net.sf.freecol.common.model.Map$Layer +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.TileItemContainer +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.server.generator.FreeColMapLoader + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Map$Layer +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.TileItemContainer +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.server.model.ServerIndianSettlement +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.server.generator.MapGenerator + +net.sf.freecol.util.test.MockMapGenerator +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.server.generator.MapGeneratorTest + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.option.MapGeneratorOptions +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.option.FileOption +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.io.FreeColSavegameFile +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.server.generator.MapLayerGenerator + +None + +net.sf.freecol.common.model.Map$Layer +
+net.sf.freecol.common.model.Game + +
+net.sf.freecol.server.generator.MapLoader + +None + +net.sf.freecol.common.model.Map$Layer +
+net.sf.freecol.common.model.Game + +
+net.sf.freecol.server.generator.River + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.server.generator.RiverSection + +None + +net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.TileImprovement + +
+net.sf.freecol.server.generator.SimpleMapGenerator + +net.sf.freecol.server.FreeColServer + + +None +
+net.sf.freecol.server.generator.SimpleMapGenerator$Territory + +None + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.server.model.ServerRegion + +
+net.sf.freecol.server.generator.TerrainGenerator + +net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.option.OptionGroup +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.option.MapGeneratorOptions +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.LandMap +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.model.TileType$RangeType +
+net.sf.freecol.server.model.ServerRegion +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.Region$RegionType +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.TileItemContainer +
+net.sf.freecol.common.model.Resource +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.common.util.RandomChoice + +
+

net.sf.freecol.server.model

+ + + + + + + + + + + + + + + + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.model.AllTests + +net.sf.freecol.server.AllTests + + +None +
+net.sf.freecol.server.model.DiplomacySession + +None + +net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.server.control.ChangeSet + +
+net.sf.freecol.server.model.LootSession + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.control.ChangeSet + +
+net.sf.freecol.server.model.MonarchSession + +None + +net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.server.control.ChangeSet + +
+net.sf.freecol.server.model.ServerBuilding + +net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.model.SchoolTest +
+net.sf.freecol.common.model.ColonyProductionTest +
+net.sf.freecol.common.model.BuildingTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.model.LimitTest +
+net.sf.freecol.common.model.SettlementTest + +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.ProductionInfo + +
+net.sf.freecol.server.model.ServerBuildingTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.model.ServerColony + +net.sf.freecol.common.model.UnitTest +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.model.ColonyProductionTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.server.control.InGameController + +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.Market$Access +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Colony$NoBuildReason +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.BuildableType +
+net.sf.freecol.common.model.ExportData +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.BuildQueue$CompletionAction +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.ProductionInfo + +
+net.sf.freecol.server.model.ServerColonyTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.util.test.FreeColTestUtils +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.model.ServerColonyTile + +net.sf.freecol.common.model.Game + + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Resource +
+net.sf.freecol.common.model.ModelMessage + +
+net.sf.freecol.server.model.ServerEurope + +net.sf.freecol.common.model.Game + + +net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Market$Access +
+net.sf.freecol.common.option.UnitListOption +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Europe$MigrationType +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.util.RandomChoice + +
+net.sf.freecol.server.model.ServerGame + +net.sf.freecol.server.control.FreeColServerHolder +
+net.sf.freecol.common.model.GameTest +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.PlayerTest +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol.server.generator.MapGeneratorTest + +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.HighSeas +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.model.Event +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.FreeColGameObjectListener +
+net.sf.freecol.common.model.SimpleCombatModel +
+net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
+net.sf.freecol.common.model.Limit +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.server.control.ChangeSet$ChangePriority +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.io.FreeColXMLReader +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Ownable +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.StringTemplate + +
+net.sf.freecol.server.model.ServerIndianSettlement + +net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.networking.MissionaryMessage + +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.ModelMessage + +
+net.sf.freecol.server.model.ServerIndianSettlementTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.model.ServerModelObject + +net.sf.freecol.server.FreeColServer + + +net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.server.control.ChangeSet + +
+net.sf.freecol.server.model.ServerPlayer + +net.sf.freecol.common.networking.BuyMessage +
+net.sf.freecol.server.control.InputHandler$DisconnectHandler +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.common.networking.SellMessage +
+net.sf.freecol.common.networking.ChangeStateMessage +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.networking.SetTradeRoutesMessage +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.common.networking.IndianDemandMessage +
+net.sf.freecol.common.model.PlayerTest +
+net.sf.freecol.common.networking.LoadGoodsMessage +
+net.sf.freecol.common.networking.ClearSpecialityMessage +
+net.sf.freecol.common.networking.PutOutsideColonyMessage +
+net.sf.freecol.server.control.ChangeSet$OwnedChange +
+net.sf.freecol.common.networking.GetTransactionMessage +
+net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.networking.SetDestinationMessage +
+net.sf.freecol.server.ai.EuropeanAIPlayer +
+net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
+net.sf.freecol.common.networking.CloseTransactionMessage +
+net.sf.freecol.common.networking.DeclineMoundsMessage +
+net.sf.freecol.common.model.IndividualFatherTest +
+net.sf.freecol.server.generator.FreeColMapLoader +
+net.sf.freecol.common.networking.GetNationSummaryMessage +
+net.sf.freecol.common.model.GameTest +
+net.sf.freecol.server.control.ChangeSet$MoveChange +
+net.sf.freecol.common.networking.LearnSkillMessage +
+net.sf.freecol.common.networking.SpySettlementMessage +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.networking.SetGoodsLevelsMessage +
+net.sf.freecol.common.networking.CashInTreasureTrainMessage +
+net.sf.freecol.common.model.ColonyTest +
+net.sf.freecol.common.networking.UnloadGoodsMessage +
+net.sf.freecol.common.networking.AskSkillMessage +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.common.networking.ClaimLandMessage +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.networking.DeliverGiftMessage +
+net.sf.freecol.common.networking.GoodsForSaleMessage +
+net.sf.freecol.common.networking.EmigrateUnitMessage +
+net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler +
+net.sf.freecol.common.networking.ChatMessage +
+net.sf.freecol.common.networking.ChangeWorkTypeMessage +
+net.sf.freecol.common.networking.SellPropositionMessage +
+net.sf.freecol.server.ai.AIInGameInputHandler +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.common.networking.PayArrearsMessage +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.AssignTeacherMessage +
+net.sf.freecol.server.ai.AIMain +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.networking.SetCurrentStopMessage +
+net.sf.freecol.common.networking.BuyPropositionMessage +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.control.UserConnectionHandler +
+net.sf.freecol.server.control.ChangeSet$Change +
+net.sf.freecol.server.control.ChangeSet$AttributeChange +
+net.sf.freecol.server.control.ChangeSet$PlayerChange +
+net.sf.freecol.common.networking.EquipForRoleMessage +
+net.sf.freecol.server.control.PreGameController +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.server.control.ChangeSet$SpyChange +
+net.sf.freecol.common.networking.SetBuildQueueMessage +
+net.sf.freecol.common.networking.UpdateTradeRouteMessage +
+net.sf.freecol.common.networking.AbandonColonyMessage +
+net.sf.freecol.server.control.ChangeSet$AttackChange +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.common.networking.AssignTradeRouteMessage +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.networking.InciteMessage +
+net.sf.freecol.common.networking.JoinColonyMessage +
+net.sf.freecol.server.control.ChangeSet$TrivialChange +
+net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.ai.NativeAIPlayer +
+net.sf.freecol.server.control.ChangeSet$PartialObjectChange +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.control.ChangeSet$MessageChange +
+net.sf.freecol.common.networking.PayForBuildingMessage +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.server.control.ChangeSet$RemoveChange +
+net.sf.freecol.common.networking.MoveToMessage +
+net.sf.freecol.common.networking.DemandTributeMessage +
+net.sf.freecol.server.control.InGameInputHandler +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.server.control.ChangeSet$StanceChange +
+net.sf.freecol.server.control.ChangeSet$FeatureChange +
+net.sf.freecol.common.networking.AttackMessage +
+net.sf.freecol.common.networking.DeclareIndependenceMessage +
+net.sf.freecol.common.networking.DisbandUnitMessage +
+net.sf.freecol.server.control.PreGameInputHandler +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
+net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.common.networking.BuildColonyMessage +
+net.sf.freecol.server.control.ChangeSet$ObjectChange +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.common.networking.RenameMessage +
+net.sf.freecol.common.networking.MissionaryMessage + +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.Monarch +
+net.sf.freecol.common.model.TradeRoute +
+net.sf.freecol.common.model.CombatModel$CombatResult +
+net.sf.freecol.common.model.Tension +
+net.sf.freecol.common.model.StanceTradeItem +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Event +
+net.sf.freecol.common.model.Player$PlayerType +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.networking.FirstContactMessage +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.TradeRouteStop +
+net.sf.freecol.common.model.FoundingFather +
+net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
+net.sf.freecol.common.model.FoundingFather$FoundingFatherType +
+net.sf.freecol.common.util.RandomChoice +
+net.sf.freecol.common.networking.LootCargoMessage +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.server.control.ChangeSet$ChangePriority +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.debug.FreeColDebugger +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.model.DiplomaticTrade +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.CombatModel +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Europe$MigrationType +
+net.sf.freecol.common.model.Nation +
+net.sf.freecol.common.model.Building +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.FreeColObject +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.Goods +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Monarch$MonarchAction +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.Disaster +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Disaster$Effects +
+net.sf.freecol.common.model.AbstractUnit +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.networking.DiplomacyMessage +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.networking.MonarchActionMessage +
+net.sf.freecol.common.model.Monarch$Force +
+net.sf.freecol.common.model.pathfinding.GoalDeciders +
+net.sf.freecol.common.model.DiplomaticTrade$TradeContext +
+net.sf.freecol.common.model.Effect +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.model.ServerPlayerTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.util.test.MockPseudoRandom +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.model.ServerRegion + +net.sf.freecol.common.model.Game +
+net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol.server.generator.River +
+net.sf.freecol.server.generator.SimpleMapGenerator$Territory +
+net.sf.freecol.server.generator.FreeColMapLoader + +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Region$RegionType +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
+net.sf.freecol.common.model.GameOptions + +
+net.sf.freecol.server.model.ServerUnit + +net.sf.freecol.common.model.TradeRouteTest +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.common.model.ScopeTest +
+net.sf.freecol.common.model.PlayerTest +
+net.sf.freecol.common.model.MovementTest +
+net.sf.freecol.common.model.EuropeTest +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.common.model.UnitTest +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.BaseCostDeciderTest +
+net.sf.freecol.common.model.IndividualFatherTest +
+net.sf.freecol.common.networking.MoveMessage +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.common.networking.EmbarkMessage +
+net.sf.freecol.client.gui.panel.EditSettlementDialog +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.model.PathfindingTest +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.common.debug.DebugUtils +
+net.sf.freecol.common.model.ColonyTest +
+net.sf.freecol.common.model.ColonyProductionTest +
+net.sf.freecol.common.model.LimitTest +
+net.sf.freecol.common.model.HighSeasTest +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.model.GoodsTest +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.common.model.BuildingTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.networking.DisembarkMessage +
+net.sf.freecol.common.model.UnitTypeChangeTest +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.common.networking.SetCurrentStopMessage +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest + +
+net.sf.freecol.common.model.AbstractGoods +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.common.model.HighSeas +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.common.model.LostCityRumour$RumourType +
+net.sf.freecol.common.model.Unit$UnitLabelType +
+net.sf.freecol.common.model.ResourceType +
+net.sf.freecol.common.model.Location +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
+net.sf.freecol.common.util.RandomChoice +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.HistoryEvent +
+net.sf.freecol.server.control.ChangeSet$ChangePriority +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.Ability +
+net.sf.freecol.common.model.Tension$Level +
+net.sf.freecol.common.util.LogBuilder +
+net.sf.freecol.common.model.ModelMessage$MessageType +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Turn +
+net.sf.freecol.common.model.CombatModel +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.server.control.ChangeSet +
+net.sf.freecol.common.model.GoodsContainer +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.ModelMessage +
+net.sf.freecol.common.model.Resource +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.i18n.NameCache +
+net.sf.freecol.server.control.ChangeSet$See +
+net.sf.freecol.common.model.Stance +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.networking.NewRegionNameMessage +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.LostCityRumour +
+net.sf.freecol.common.networking.NewLandNameMessage +
+net.sf.freecol.common.model.StringTemplate +
+net.sf.freecol.common.model.TileImprovementType + +
+net.sf.freecol.server.model.ServerUnitTest + +None + +net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.util.test.MockPseudoRandom +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Modifier +
+net.sf.freecol.common.model.TileImprovement +
+net.sf.freecol.util.test.FreeColTestCase +
+net.sf.freecol.common.model.UnitTypeChange$ChangeType +
+net.sf.freecol.common.model.Role +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.common.model.ColonyTile +
+net.sf.freecol.common.model.BuildingType +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Direction +
+net.sf.freecol.common.model.GoodsType +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Unit$UnitState +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.control.InGameController +
+net.sf.freecol.common.model.TileImprovementType +
+net.sf.freecol.common.model.GameOptions +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.server.model.TradeSession + +None + +net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.Settlement +
+net.sf.freecol.server.control.ChangeSet + +
+net.sf.freecol.server.model.TransactionSession + +net.sf.freecol.server.FreeColServer + + +net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.control.ChangeSet + +
+

net.sf.freecol.server.networking

+ + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.server.networking.DummyConnection + +net.sf.freecol.server.ai.AIPlayer +
+net.sf.freecol.server.FreeColServer + +
+net.sf.freecol.common.FreeColException +
+net.sf.freecol.common.networking.MessageHandler +
+net.sf.freecol.common.networking.Connection + +
+net.sf.freecol.server.networking.Server + +net.sf.freecol.server.control.InputHandler$DisconnectHandler +
+net.sf.freecol.server.control.Controller +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.server.control.UserConnectionHandler + +
+net.sf.freecol.common.networking.MessageHandler +
+net.sf.freecol.FreeCol +
+net.sf.freecol.server.FreeColServer +
+net.sf.freecol.common.networking.Connection + +
+

net.sf.freecol.util.test

+ + + + + + + + + + + + +
TypeReferencing TypesReferenced Types
+net.sf.freecol.util.test.FreeColTestCase + +net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.common.model.ProductionTypeTest +
+net.sf.freecol.common.model.SettlementTest +
+net.sf.freecol.server.ai.REFTest +
+net.sf.freecol.common.model.GoodsContainerTest +
+net.sf.freecol.common.sound.SoundTest +
+net.sf.freecol.common.io.ModTest +
+net.sf.freecol.common.model.TradeRouteTest +
+net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.PioneeringMissionTest +
+net.sf.freecol.common.i18n.MessagesTest +
+net.sf.freecol.common.model.NationTypeTest +
+net.sf.freecol.common.model.MonarchTest +
+net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
+net.sf.freecol.common.model.ScopeTest +
+net.sf.freecol.common.model.PlayerTest +
+net.sf.freecol.common.model.MovementTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.common.model.TileImprovementTest +
+net.sf.freecol.common.model.EuropeTest +
+net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.common.model.UnitTest +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.model.BaseCostDeciderTest +
+net.sf.freecol.server.SaveLoadTest +
+net.sf.freecol.common.model.ModelMessageTest +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.common.model.RandomRangeTest +
+net.sf.freecol.common.model.MarketTest +
+net.sf.freecol.common.model.IndividualFatherTest +
+net.sf.freecol.common.model.IndianSettlementTest +
+net.sf.freecol.common.model.GameTest +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.common.model.SchoolTest +
+net.sf.freecol.client.gui.FontTest +
+net.sf.freecol.common.model.SoLTest +
+net.sf.freecol.common.model.PathfindingTest +
+net.sf.freecol.common.option.OptionTest +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.common.model.ColonyTest +
+net.sf.freecol.common.model.ColonyProductionTest +
+net.sf.freecol.common.model.LimitTest +
+net.sf.freecol.common.model.FoundingFatherTest +
+net.sf.freecol.common.model.HighSeasTest +
+net.sf.freecol.common.model.TileItemContainerTest +
+net.sf.freecol.server.generator.MapGeneratorTest +
+net.sf.freecol.common.model.RoleTest +
+net.sf.freecol.common.model.GoodsTest +
+net.sf.freecol.common.utils.UtilsTest +
+net.sf.freecol.server.ai.ColonyPlanTest +
+net.sf.freecol.common.model.BuildingTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.model.UnitTypeChangeTest +
+net.sf.freecol.common.model.DisasterTest +
+net.sf.freecol.common.model.TileTest +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.common.model.SpecificationTest +
+net.sf.freecol.server.model.ServerPlayerTest +
+net.sf.freecol.client.control.MoveTest +
+net.sf.freecol.common.model.SerializationTest +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.common.i18n.CLDRTest +
+net.sf.freecol.common.model.ModifierTest +
+net.sf.freecol.server.ai.mission.PrivateerMissionTest +
+net.sf.freecol.server.ServerTestHelper + +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.NationOptions +
+net.sf.freecol.common.model.Specification +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerGame +
+net.sf.freecol.common.i18n.Messages +
+net.sf.freecol.common.model.NationOptions$NationState +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.io.FreeColTcFile +
+net.sf.freecol.FreeCol +
+net.sf.freecol.common.model.TileType +
+net.sf.freecol.server.model.ServerPlayer +
+net.sf.freecol.common.model.Nation + +
+net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder + +net.sf.freecol.server.ai.ContactTest +
+net.sf.freecol.server.ai.TensionTest +
+net.sf.freecol.common.model.UnitTest +
+net.sf.freecol.common.model.BaseCostDeciderTest +
+net.sf.freecol.server.ai.mission.ScoutingMissionTest +
+net.sf.freecol.server.model.ServerIndianSettlementTest +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.common.model.ColonyTest +
+net.sf.freecol.common.model.SettlementTest +
+net.sf.freecol.server.ai.StandardAIPlayerTest +
+net.sf.freecol.common.model.IndividualFatherTest +
+net.sf.freecol.common.model.IndianSettlementTest +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.common.model.MovementTest +
+net.sf.freecol.common.model.PathfindingTest + +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.common.model.IndianSettlement +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.server.model.ServerIndianSettlement + +
+net.sf.freecol.util.test.FreeColTestCase$MapBuilder + +net.sf.freecol.common.model.MapTest +
+net.sf.freecol.server.ai.ColonyPlanTest + +
+net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Region +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.TileType + +
+net.sf.freecol.util.test.FreeColTestUtils + +net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.model.MapTest +
+net.sf.freecol.server.ai.MissionAssignmentTest +
+net.sf.freecol.server.model.ServerBuildingTest +
+net.sf.freecol.common.model.SchoolTest +
+net.sf.freecol.server.control.InGameControllerTest +
+net.sf.freecol.server.model.ServerColonyTest +
+net.sf.freecol.common.model.PathfindingTest + +
+net.sf.freecol.common.model.Game + +
+net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder + +net.sf.freecol.server.ai.AIColonyTest +
+net.sf.freecol.server.ai.mission.TransportMissionTest +
+net.sf.freecol.common.model.SchoolTest + +
+net.sf.freecol.common.model.UnitType +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.Tile +
+net.sf.freecol.common.model.Unit +
+net.sf.freecol.server.model.ServerUnit +
+net.sf.freecol.common.model.Colony +
+net.sf.freecol.server.model.ServerColony + +
+net.sf.freecol.util.test.MockMapGenerator + +net.sf.freecol.server.ServerTestHelper + + +net.sf.freecol.common.model.Map +
+net.sf.freecol.common.model.Monarch +
+net.sf.freecol.common.model.Game +
+net.sf.freecol.common.model.Player +
+net.sf.freecol.common.model.HighSeas +
+net.sf.freecol.common.model.Europe +
+net.sf.freecol.common.model.MarketData +
+net.sf.freecol.common.model.FreeColGameObject +
+net.sf.freecol.server.generator.MapGenerator +
+net.sf.freecol.common.model.Market +
+net.sf.freecol.common.util.LogBuilder + +
+net.sf.freecol.util.test.MockPseudoRandom + +net.sf.freecol.common.model.CombatTest +
+net.sf.freecol.server.model.ServerUnitTest +
+net.sf.freecol.server.model.ServerPlayerTest + +
+None +
+
+

Package Details

+
+

net.sf.freecol

+ + + + + + +
Afferent Couplings: 18Efferent Couplings: 2Abstractness: 0.0Instability: 0.1Distance: -0.9
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.AllTests +
net.sf.freecol.FreeCol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.io +
+net.sf.freecol.common.logging +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.resources +
+net.sf.freecol.common.sound +
+net.sf.freecol.metaserver +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.control +
+net.sf.freecol.server.networking +
+net.sf.freecol.tools +
+net.sf.freecol.util.test + +
+java.awt +
+java.io +
+java.lang +
+java.net +
+java.util +
+java.util.jar +
+java.util.logging +
+java.util.stream +
+java.util.zip +
+junit.extensions +
+junit.framework +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.logging +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.server +
+net.sf.freecol.server.generator +
+org.apache.commons.cli + +
+

net.sf.freecol.client

+ + + + + + +
Afferent Couplings: 10Efferent Couplings: 8Abstractness: 0.0Instability: 0.44Distance: -0.56
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.client.AllTests +
net.sf.freecol.client.ClientOptions +
net.sf.freecol.client.ClientOptions$MessageSourceComparator +
net.sf.freecol.client.ClientTestHelper +
net.sf.freecol.client.FreeColClient +
net.sf.freecol.client.Worker +
net.sf.freecol.client.WorkerCheck +
net.sf.freecol.client.WorkerCheck$TestJob +
+net.sf.freecol +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.animation +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.resources +
+net.sf.freecol.common.sound + +
+java.awt +
+java.awt.event +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+javax.swing +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.networking +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.resources +
+net.sf.freecol.common.util +
+net.sf.freecol.server + +
+

net.sf.freecol.client.control

+ + + + + + +
Afferent Couplings: 4Efferent Couplings: 13Abstractness: 0.09Instability: 0.76Distance: -0.15
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.client.control.InputHandler +
net.sf.freecol.client.control.MapEditorController$IMapTransform +
+net.sf.freecol.client.control.AllTests +
net.sf.freecol.client.control.ConnectController +
net.sf.freecol.client.control.ConnectController$ErrorJob +
net.sf.freecol.client.control.InGameController +
net.sf.freecol.client.control.InGameController$ArmedUnitSettlementAction +
net.sf.freecol.client.control.InGameController$BoycottAction +
net.sf.freecol.client.control.InGameController$BuyAction +
net.sf.freecol.client.control.InGameController$ClaimAction +
net.sf.freecol.client.control.InGameController$MissionaryAction +
net.sf.freecol.client.control.InGameController$MoveMode +
net.sf.freecol.client.control.InGameController$ScoutColonyAction +
net.sf.freecol.client.control.InGameController$ScoutIndianSettlementAction +
net.sf.freecol.client.control.InGameController$SellAction +
net.sf.freecol.client.control.InGameController$TradeAction +
net.sf.freecol.client.control.InGameInputHandler +
net.sf.freecol.client.control.MapEditorController +
net.sf.freecol.client.control.MapEditorController$ErrorJob +
net.sf.freecol.client.control.MoveTest +
net.sf.freecol.client.control.PreGameController +
net.sf.freecol.client.control.PreGameInputHandler +
net.sf.freecol.client.control.SoundController +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.panel + +
+java.awt +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.sound.sampled +
+javax.swing +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.resources +
+net.sf.freecol.common.sound +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.model +
+net.sf.freecol.util.test +
+org.junit +
+org.w3c.dom + +
+

net.sf.freecol.client.gui

+ + + + + + +
Afferent Couplings: 11Efferent Couplings: 32Abstractness: 0.05Instability: 0.74Distance: -0.2
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.client.gui.DialogHandler +
net.sf.freecol.client.gui.OutForAnimationCallback +
+net.sf.freecol.client.gui.AbstractCanvasListener +
net.sf.freecol.client.gui.AllTests +
net.sf.freecol.client.gui.Canvas +
net.sf.freecol.client.gui.Canvas$DialogCallback +
net.sf.freecol.client.gui.Canvas$ToolBoxFrame +
net.sf.freecol.client.gui.CanvasMapEditorMouseListener +
net.sf.freecol.client.gui.CanvasMouseListener +
net.sf.freecol.client.gui.CanvasMouseMotionListener +
net.sf.freecol.client.gui.ChatDisplay +
net.sf.freecol.client.gui.ChoiceItem +
net.sf.freecol.client.gui.FontLibrary +
net.sf.freecol.client.gui.FontLibrary$FontSize +
net.sf.freecol.client.gui.FontLibrary$FontType +
net.sf.freecol.client.gui.FontTest +
net.sf.freecol.client.gui.FrameMotionListener +
net.sf.freecol.client.gui.FreeColFrame +
net.sf.freecol.client.gui.FullScreenFrameListener +
net.sf.freecol.client.gui.GUI +
net.sf.freecol.client.gui.GUIMessage +
net.sf.freecol.client.gui.GrayLayer +
net.sf.freecol.client.gui.ImageLibrary +
net.sf.freecol.client.gui.ImageLibrary$PathType +
net.sf.freecol.client.gui.LoadingSavegameInfo +
net.sf.freecol.client.gui.MapViewer +
net.sf.freecol.client.gui.MapViewer$BorderType +
net.sf.freecol.client.gui.MapViewer$TextSpecification +
net.sf.freecol.client.gui.RoadPainter +
net.sf.freecol.client.gui.ScrollThread +
net.sf.freecol.client.gui.SwingGUI +
net.sf.freecol.client.gui.SwingGUI$AbortListener +
net.sf.freecol.client.gui.TerrainCursor +
net.sf.freecol.client.gui.TilePopup +
net.sf.freecol.client.gui.TileViewer +
net.sf.freecol.client.gui.TileViewer$SortableImage +
net.sf.freecol.client.gui.WindowedFrameListener +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.animation +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.client.networking +
+net.sf.freecol.common.debug + +
+java.awt +
+java.awt.event +
+java.awt.geom +
+java.awt.image +
+java.io +
+java.lang +
+java.lang.reflect +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.imageio +
+javax.swing +
+javax.swing.event +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.client.gui.video +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.resources +
+net.sf.freecol.common.util +
+net.sf.freecol.server.generator +
+net.sf.freecol.util.test + +
+

net.sf.freecol.client.gui.action

+ + + + + + +
Afferent Couplings: 5Efferent Couplings: 80Abstractness: 0.05Instability: 0.94Distance: -0.01
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.client.gui.action.FreeColAction +
net.sf.freecol.client.gui.action.MapboardAction +
net.sf.freecol.client.gui.action.SelectableAction +
net.sf.freecol.client.gui.action.UnitAction +
+net.sf.freecol.client.gui.action.AboutAction +
net.sf.freecol.client.gui.action.ActionManager +
net.sf.freecol.client.gui.action.AssignTradeRouteAction +
net.sf.freecol.client.gui.action.BuildColonyAction +
net.sf.freecol.client.gui.action.CenterAction +
net.sf.freecol.client.gui.action.ChangeAction +
net.sf.freecol.client.gui.action.ChangeWindowedModeAction +
net.sf.freecol.client.gui.action.ChatAction +
net.sf.freecol.client.gui.action.ClearOrdersAction +
net.sf.freecol.client.gui.action.ColopediaAction +
net.sf.freecol.client.gui.action.ColopediaAction$PanelType +
net.sf.freecol.client.gui.action.ContinueAction +
net.sf.freecol.client.gui.action.DebugAction +
net.sf.freecol.client.gui.action.DeclareIndependenceAction +
net.sf.freecol.client.gui.action.DetermineHighSeasAction +
net.sf.freecol.client.gui.action.DisbandUnitAction +
net.sf.freecol.client.gui.action.DisplayBordersAction +
net.sf.freecol.client.gui.action.DisplayGridAction +
net.sf.freecol.client.gui.action.DisplayTileTextAction +
net.sf.freecol.client.gui.action.DisplayTileTextAction$DisplayText +
net.sf.freecol.client.gui.action.EndTurnAction +
net.sf.freecol.client.gui.action.EuropeAction +
net.sf.freecol.client.gui.action.ExecuteGotoOrdersAction +
net.sf.freecol.client.gui.action.FindSettlementAction +
net.sf.freecol.client.gui.action.FortifyAction +
net.sf.freecol.client.gui.action.FreeColAction$InnerMenuKeyListener +
net.sf.freecol.client.gui.action.GotoAction +
net.sf.freecol.client.gui.action.GotoTileAction +
net.sf.freecol.client.gui.action.ImprovementAction +
net.sf.freecol.client.gui.action.LoadAction +
net.sf.freecol.client.gui.action.MapControlsAction +
net.sf.freecol.client.gui.action.MapEditorAction +
net.sf.freecol.client.gui.action.MiniMapToggleFogOfWarAction +
net.sf.freecol.client.gui.action.MiniMapToggleViewAction +
net.sf.freecol.client.gui.action.MiniMapZoomInAction +
net.sf.freecol.client.gui.action.MiniMapZoomOutAction +
net.sf.freecol.client.gui.action.MoveAction +
net.sf.freecol.client.gui.action.NewAction +
net.sf.freecol.client.gui.action.NewEmptyMapAction +
net.sf.freecol.client.gui.action.OpenAction +
net.sf.freecol.client.gui.action.PreferencesAction +
net.sf.freecol.client.gui.action.QuitAction +
net.sf.freecol.client.gui.action.ReconnectAction +
net.sf.freecol.client.gui.action.RenameAction +
net.sf.freecol.client.gui.action.ReportCargoAction +
net.sf.freecol.client.gui.action.ReportColonyAction +
net.sf.freecol.client.gui.action.ReportContinentalCongressAction +
net.sf.freecol.client.gui.action.ReportEducationAction +
net.sf.freecol.client.gui.action.ReportExplorationAction +
net.sf.freecol.client.gui.action.ReportForeignAction +
net.sf.freecol.client.gui.action.ReportHighScoresAction +
net.sf.freecol.client.gui.action.ReportHistoryAction +
net.sf.freecol.client.gui.action.ReportIndianAction +
net.sf.freecol.client.gui.action.ReportLabourAction +
net.sf.freecol.client.gui.action.ReportMilitaryAction +
net.sf.freecol.client.gui.action.ReportNavalAction +
net.sf.freecol.client.gui.action.ReportProductionAction +
net.sf.freecol.client.gui.action.ReportReligionAction +
net.sf.freecol.client.gui.action.ReportRequirementsAction +
net.sf.freecol.client.gui.action.ReportTradeAction +
net.sf.freecol.client.gui.action.ReportTurnAction +
net.sf.freecol.client.gui.action.RetireAction +
net.sf.freecol.client.gui.action.SaveAction +
net.sf.freecol.client.gui.action.SaveAndQuitAction +
net.sf.freecol.client.gui.action.ScaleMapAction +
net.sf.freecol.client.gui.action.SentryAction +
net.sf.freecol.client.gui.action.ShowDifficultyAction +
net.sf.freecol.client.gui.action.ShowGameOptionsAction +
net.sf.freecol.client.gui.action.ShowMainAction +
net.sf.freecol.client.gui.action.ShowMapGeneratorOptionsAction +
net.sf.freecol.client.gui.action.SkipUnitAction +
net.sf.freecol.client.gui.action.TilePopupAction +
net.sf.freecol.client.gui.action.ToggleViewModeAction +
net.sf.freecol.client.gui.action.TradeRouteAction +
net.sf.freecol.client.gui.action.UnloadAction +
net.sf.freecol.client.gui.action.WaitAction +
net.sf.freecol.client.gui.action.ZoomInAction +
net.sf.freecol.client.gui.action.ZoomOutAction +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.panel + +
+java.awt +
+java.awt.event +
+java.io +
+java.lang +
+java.util.logging +
+javax.swing +
+javax.swing.event +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option + +
+

net.sf.freecol.client.gui.animation

+ + + + + + +
Afferent Couplings: 0Efferent Couplings: 4Abstractness: 0.0Instability: 1.0Distance: 0.0
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.client.gui.animation.Animations +
net.sf.freecol.client.gui.animation.UnitAttackAnimation +
net.sf.freecol.client.gui.animation.UnitImageAnimation +
net.sf.freecol.client.gui.animation.UnitMoveAnimation +
+None + +java.awt +
+java.lang +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.common.io.sza +
+net.sf.freecol.common.model +
+net.sf.freecol.common.resources + +
+

net.sf.freecol.client.gui.menu

+ + + + + + +
Afferent Couplings: 1Efferent Couplings: 6Abstractness: 0.17Instability: 0.86Distance: 0.02
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.client.gui.menu.FreeColMenuBar + +net.sf.freecol.client.gui.menu.DebugMenu +
net.sf.freecol.client.gui.menu.FreeColMenuTest +
net.sf.freecol.client.gui.menu.InGameMenuBar +
net.sf.freecol.client.gui.menu.MapEditorMenuBar +
net.sf.freecol.client.gui.menu.MenuMouseMotionListener +
+net.sf.freecol.client.gui + + +java.awt +
+java.awt.event +
+java.awt.geom +
+java.lang +
+java.net +
+java.util.logging +
+javax.swing +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.model + +
+

net.sf.freecol.client.gui.option

+ + + + + + +
Afferent Couplings: 2Efferent Couplings: 24Abstractness: 0.12Instability: 0.92Distance: 0.04
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.client.gui.option.OptionOneUI +
net.sf.freecol.client.gui.option.OptionUI +
net.sf.freecol.client.gui.option.OptionUpdater +
+net.sf.freecol.client.gui.option.AbstractUnitOptionUI +
net.sf.freecol.client.gui.option.AbstractUnitOptionUI$AbstractUnitRenderer +
net.sf.freecol.client.gui.option.AbstractUnitOptionUI$RoleRenderer +
net.sf.freecol.client.gui.option.AudioMixerOptionUI +
net.sf.freecol.client.gui.option.BooleanOptionUI +
net.sf.freecol.client.gui.option.FileOptionUI +
net.sf.freecol.client.gui.option.FreeColActionUI +
net.sf.freecol.client.gui.option.FreeColActionUI$BlinkingLabel +
net.sf.freecol.client.gui.option.IntegerOptionUI +
net.sf.freecol.client.gui.option.LanguageOptionUI +
net.sf.freecol.client.gui.option.ListOptionUI +
net.sf.freecol.client.gui.option.ModOptionUI +
net.sf.freecol.client.gui.option.ModOptionUI$BoxRenderer +
net.sf.freecol.client.gui.option.ModOptionUI$ModOptionRenderer +
net.sf.freecol.client.gui.option.OptionGroupUI +
net.sf.freecol.client.gui.option.PercentageOptionUI +
net.sf.freecol.client.gui.option.RangeOptionUI +
net.sf.freecol.client.gui.option.SelectOptionUI +
net.sf.freecol.client.gui.option.SliderOptionUI +
net.sf.freecol.client.gui.option.StringOptionUI +
net.sf.freecol.client.gui.option.TextOptionUI +
net.sf.freecol.client.gui.option.UnitTypeOptionUI +
net.sf.freecol.client.gui.option.UnitTypeOptionUI$ChoiceRenderer +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui.panel + +
+java.awt +
+java.awt.event +
+java.awt.image +
+java.io +
+java.lang +
+java.util.logging +
+javax.swing +
+javax.swing.event +
+javax.swing.tree +
+net.miginfocom.swing +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option + +
+

net.sf.freecol.client.gui.panel

+ + + + + + +
Afferent Couplings: 8Efferent Couplings: 214Abstractness: 0.06Instability: 0.96Distance: 0.02
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.client.gui.panel.ColopediaDetailPanel +
net.sf.freecol.client.gui.panel.ColopediaGameObjectTypePanel +
net.sf.freecol.client.gui.panel.Draggable +
net.sf.freecol.client.gui.panel.DropTarget +
net.sf.freecol.client.gui.panel.FreeColInputDialog +
net.sf.freecol.client.gui.panel.FreeColPanel +
net.sf.freecol.client.gui.panel.InPortPanel +
net.sf.freecol.client.gui.panel.LabourData$LocationData$Getter +
net.sf.freecol.client.gui.panel.MapControls +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$MapTransform +
net.sf.freecol.client.gui.panel.OptionsDialog +
net.sf.freecol.client.gui.panel.PortPanel +
net.sf.freecol.client.gui.panel.ReportUnitPanel +
net.sf.freecol.client.gui.panel.UnitPanel +
+net.sf.freecol.client.gui.panel.AboutPanel +
net.sf.freecol.client.gui.panel.AbstractGoodsLabel +
net.sf.freecol.client.gui.panel.BuildQueuePanel +
net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueMouseAdapter +
net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueTransferHandler +
net.sf.freecol.client.gui.panel.BuildQueuePanel$BuildQueueTransferHandler$BuildablesTransferable +
net.sf.freecol.client.gui.panel.BuildQueuePanel$DefaultBuildQueueCellRenderer +
net.sf.freecol.client.gui.panel.BuildingDetailPanel +
net.sf.freecol.client.gui.panel.BuildingPanel +
net.sf.freecol.client.gui.panel.BuildingPanel$UpkeepLabel +
net.sf.freecol.client.gui.panel.BuildingToolTip +
net.sf.freecol.client.gui.panel.CaptureGoodsDialog +
net.sf.freecol.client.gui.panel.CaptureGoodsDialog$CheckBoxRenderer +
net.sf.freecol.client.gui.panel.CaptureGoodsDialog$GoodsItem +
net.sf.freecol.client.gui.panel.CargoPanel +
net.sf.freecol.client.gui.panel.ChatPanel +
net.sf.freecol.client.gui.panel.ChooseFoundingFatherDialog +
net.sf.freecol.client.gui.panel.ClassicMapControls +
net.sf.freecol.client.gui.panel.ClientOptionsDialog +
net.sf.freecol.client.gui.panel.ColonyPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$BuildingsPanel$ASingleBuildingPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$ColonyCargoPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$ColonyInPortPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$OutsideColonyPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$PopulationPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel +
net.sf.freecol.client.gui.panel.ColonyPanel$TilesPanel$ASingleTilePanel +
net.sf.freecol.client.gui.panel.ColonyPanel$WarehousePanel +
net.sf.freecol.client.gui.panel.ColopediaPanel +
net.sf.freecol.client.gui.panel.ColopediaTreeCellRenderer +
net.sf.freecol.client.gui.panel.ColopediaTreeItem +
net.sf.freecol.client.gui.panel.ColorCellEditor +
net.sf.freecol.client.gui.panel.ColorCellRenderer +
net.sf.freecol.client.gui.panel.ColorChooserPanel +
net.sf.freecol.client.gui.panel.CompactLabourReport +
net.sf.freecol.client.gui.panel.ConceptDetailPanel +
net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog +
net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog$ColorButton +
net.sf.freecol.client.gui.panel.ConfirmDeclarationDialog$EnumRenderer +
net.sf.freecol.client.gui.panel.ConstructionPanel +
net.sf.freecol.client.gui.panel.CornerMapControls +
net.sf.freecol.client.gui.panel.CornerMapControls$MiniMapPanel +
net.sf.freecol.client.gui.panel.DeclarationPanel +
net.sf.freecol.client.gui.panel.DeclarationPanel$SignaturePanel +
net.sf.freecol.client.gui.panel.DefaultTransferHandler +
net.sf.freecol.client.gui.panel.DefaultTransferHandler$FreeColDragGestureRecognizer +
net.sf.freecol.client.gui.panel.DefaultTransferHandler$FreeColDragHandler +
net.sf.freecol.client.gui.panel.DifficultyDialog +
net.sf.freecol.client.gui.panel.DragListener +
net.sf.freecol.client.gui.panel.DropListener +
net.sf.freecol.client.gui.panel.DumpCargoDialog +
net.sf.freecol.client.gui.panel.EditOptionDialog +
net.sf.freecol.client.gui.panel.EditSettlementDialog +
net.sf.freecol.client.gui.panel.EmigrationDialog +
net.sf.freecol.client.gui.panel.EndTurnDialog +
net.sf.freecol.client.gui.panel.EndTurnDialog$UnitCellRenderer +
net.sf.freecol.client.gui.panel.EndTurnDialog$UnitWrapper +
net.sf.freecol.client.gui.panel.ErrorPanel +
net.sf.freecol.client.gui.panel.EuropePanel +
net.sf.freecol.client.gui.panel.EuropePanel$DestinationPanel +
net.sf.freecol.client.gui.panel.EuropePanel$DocksPanel +
net.sf.freecol.client.gui.panel.EuropePanel$EuropeButton +
net.sf.freecol.client.gui.panel.EuropePanel$EuropeInPortPanel +
net.sf.freecol.client.gui.panel.EuropePanel$MarketPanel +
net.sf.freecol.client.gui.panel.EuropePanel$TransactionLog +
net.sf.freecol.client.gui.panel.EventPanel +
net.sf.freecol.client.gui.panel.FatherDetailPanel +
net.sf.freecol.client.gui.panel.FindSettlementPanel +
net.sf.freecol.client.gui.panel.FindSettlementPanel$SettlementRenderer +
net.sf.freecol.client.gui.panel.FirstContactDialog +
net.sf.freecol.client.gui.panel.Flag +
net.sf.freecol.client.gui.panel.Flag$Alignment +
net.sf.freecol.client.gui.panel.Flag$Background +
net.sf.freecol.client.gui.panel.Flag$Decoration +
net.sf.freecol.client.gui.panel.Flag$UnionPosition +
net.sf.freecol.client.gui.panel.Flag$UnionShape +
net.sf.freecol.client.gui.panel.FreeColChoiceDialog +
net.sf.freecol.client.gui.panel.FreeColConfirmDialog +
net.sf.freecol.client.gui.panel.FreeColDialog +
net.sf.freecol.client.gui.panel.FreeColDialog$DialogType +
net.sf.freecol.client.gui.panel.FreeColImageBorder +
net.sf.freecol.client.gui.panel.FreeColProgressBar +
net.sf.freecol.client.gui.panel.FreeColStringInputDialog +
net.sf.freecol.client.gui.panel.GameOptionsDialog +
net.sf.freecol.client.gui.panel.GoodsDetailPanel +
net.sf.freecol.client.gui.panel.GoodsLabel +
net.sf.freecol.client.gui.panel.ImageSelection +
net.sf.freecol.client.gui.panel.IndianSettlementPanel +
net.sf.freecol.client.gui.panel.InfoPanel +
net.sf.freecol.client.gui.panel.InfoPanel$EndTurnPanel +
net.sf.freecol.client.gui.panel.InfoPanel$TileInfoPanel +
net.sf.freecol.client.gui.panel.InfoPanel$UnitInfoPanel +
net.sf.freecol.client.gui.panel.InformationPanel +
net.sf.freecol.client.gui.panel.LabourData +
net.sf.freecol.client.gui.panel.LabourData$LocationData +
net.sf.freecol.client.gui.panel.LabourData$ProductionData +
net.sf.freecol.client.gui.panel.LabourData$UnitData +
net.sf.freecol.client.gui.panel.LoadDialog +
net.sf.freecol.client.gui.panel.LoadingSavegameDialog +
net.sf.freecol.client.gui.panel.MainPanel +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$LostCityRumourTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$ResourceTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$RiverTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$SettlementTransform +
net.sf.freecol.client.gui.panel.MapEditorTransformPanel$TileTypeTransform +
net.sf.freecol.client.gui.panel.MapGeneratorOptionsDialog +
net.sf.freecol.client.gui.panel.MapSizeDialog +
net.sf.freecol.client.gui.panel.MarketLabel +
net.sf.freecol.client.gui.panel.MigPanel +
net.sf.freecol.client.gui.panel.MiniMap +
net.sf.freecol.client.gui.panel.ModifierFormat +
net.sf.freecol.client.gui.panel.MonarchDialog +
net.sf.freecol.client.gui.panel.NationDetailPanel +
net.sf.freecol.client.gui.panel.NationTypeDetailPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog +
net.sf.freecol.client.gui.panel.NegotiationDialog$ColonyTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$GoldTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$GoodsTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$GoodsTradeItemPanel$GoodsBoxRenderer +
net.sf.freecol.client.gui.panel.NegotiationDialog$InciteTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$InciteTradeItemPanel$InciteBoxRenderer +
net.sf.freecol.client.gui.panel.NegotiationDialog$RemoveAction +
net.sf.freecol.client.gui.panel.NegotiationDialog$StanceTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$StanceTradeItemPanel$StanceBoxRenderer +
net.sf.freecol.client.gui.panel.NegotiationDialog$UnitTradeItemPanel +
net.sf.freecol.client.gui.panel.NegotiationDialog$UnitTradeItemPanel$UnitBoxRenderer +
net.sf.freecol.client.gui.panel.NewPanel +
net.sf.freecol.client.gui.panel.NewPanel$NewPanelAction +
net.sf.freecol.client.gui.panel.NewUnitPanel +
net.sf.freecol.client.gui.panel.Parameters +
net.sf.freecol.client.gui.panel.ParametersDialog +
net.sf.freecol.client.gui.panel.PlayersTable +
net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellEditor +
net.sf.freecol.client.gui.panel.PlayersTable$AdvantageCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellEditor +
net.sf.freecol.client.gui.panel.PlayersTable$AvailableCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$HeaderListener +
net.sf.freecol.client.gui.panel.PlayersTable$HeaderRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$NationCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$NationStateRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellEditor +
net.sf.freecol.client.gui.panel.PlayersTable$PlayerCellRenderer +
net.sf.freecol.client.gui.panel.PlayersTable$PlayersTableModel +
net.sf.freecol.client.gui.panel.PreCombatDialog +
net.sf.freecol.client.gui.panel.ProductionLabel +
net.sf.freecol.client.gui.panel.PurchasePanel +
net.sf.freecol.client.gui.panel.QuickActionMenu +
net.sf.freecol.client.gui.panel.RebelToolTip +
net.sf.freecol.client.gui.panel.RecruitPanel +
net.sf.freecol.client.gui.panel.ReportCargoPanel +
net.sf.freecol.client.gui.panel.ReportClassicColonyPanel +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel$ColonySummary +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel$ColonySummary$GoodsProduction +
net.sf.freecol.client.gui.panel.ReportCompactColonyPanel$ColonySummary$ProductionStatus +
net.sf.freecol.client.gui.panel.ReportContinentalCongressPanel +
net.sf.freecol.client.gui.panel.ReportEducationPanel +
net.sf.freecol.client.gui.panel.ReportExplorationPanel +
net.sf.freecol.client.gui.panel.ReportForeignAffairPanel +
net.sf.freecol.client.gui.panel.ReportHighScoresPanel +
net.sf.freecol.client.gui.panel.ReportHistoryPanel +
net.sf.freecol.client.gui.panel.ReportIndianPanel +
net.sf.freecol.client.gui.panel.ReportLabourDetailPanel +
net.sf.freecol.client.gui.panel.ReportLabourPanel +
net.sf.freecol.client.gui.panel.ReportLabourPanel$LabourUnitPanel +
net.sf.freecol.client.gui.panel.ReportLabourPanel$LabourUnitPanelRenderer +
net.sf.freecol.client.gui.panel.ReportMilitaryPanel +
net.sf.freecol.client.gui.panel.ReportNavalPanel +
net.sf.freecol.client.gui.panel.ReportPanel +
net.sf.freecol.client.gui.panel.ReportProductionPanel +
net.sf.freecol.client.gui.panel.ReportReligiousPanel +
net.sf.freecol.client.gui.panel.ReportRequirementsPanel +
net.sf.freecol.client.gui.panel.ReportTradePanel +
net.sf.freecol.client.gui.panel.ReportTurnPanel +
net.sf.freecol.client.gui.panel.ResourcesDetailPanel +
net.sf.freecol.client.gui.panel.RiverStyleDialog +
net.sf.freecol.client.gui.panel.SaveDialog +
net.sf.freecol.client.gui.panel.ScaleMapSizeDialog +
net.sf.freecol.client.gui.panel.SelectAmountDialog +
net.sf.freecol.client.gui.panel.SelectDestinationDialog +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$Destination +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$DestinationComparator +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$DistanceComparator +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$LocationRenderer +
net.sf.freecol.client.gui.panel.SelectDestinationDialog$NameComparator +
net.sf.freecol.client.gui.panel.SelectTributeAmountDialog +
net.sf.freecol.client.gui.panel.ServerListPanel +
net.sf.freecol.client.gui.panel.ServerListTableModel +
net.sf.freecol.client.gui.panel.StartGamePanel +
net.sf.freecol.client.gui.panel.StatisticsPanel +
net.sf.freecol.client.gui.panel.StatisticsPanel$StatisticsModel +
net.sf.freecol.client.gui.panel.StatusPanel +
net.sf.freecol.client.gui.panel.TerrainDetailPanel +
net.sf.freecol.client.gui.panel.TilePanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoHandler +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoLabel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$CargoPanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$DestinationCellRenderer +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$GoodsPanel +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListHandler +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopListTransferable +
net.sf.freecol.client.gui.panel.TradeRouteInputPanel$StopRenderer +
net.sf.freecol.client.gui.panel.TradeRoutePanel +
net.sf.freecol.client.gui.panel.TrainPanel +
net.sf.freecol.client.gui.panel.UnitButton +
net.sf.freecol.client.gui.panel.UnitButton$UnitButtonActionPropertyChangeListener +
net.sf.freecol.client.gui.panel.UnitDetailPanel +
net.sf.freecol.client.gui.panel.UnitLabel +
net.sf.freecol.client.gui.panel.UnitLabel$UnitAction +
net.sf.freecol.client.gui.panel.Utility +
net.sf.freecol.client.gui.panel.VictoryDialog +
net.sf.freecol.client.gui.panel.WarehouseDialog +
net.sf.freecol.client.gui.panel.WarehouseDialog$WarehouseGoodsPanel +
net.sf.freecol.client.gui.panel.WorkProductionPanel +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.client.gui.video +
+net.sf.freecol.common.model +
+net.sf.freecol.tools + +
+java.awt +
+java.awt.datatransfer +
+java.awt.dnd +
+java.awt.event +
+java.awt.geom +
+java.awt.image +
+java.beans +
+java.io +
+java.lang +
+java.text +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.imageio +
+javax.swing +
+javax.swing.border +
+javax.swing.event +
+javax.swing.filechooser +
+javax.swing.plaf +
+javax.swing.table +
+javax.swing.text +
+javax.swing.tree +
+net.miginfocom.swing +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.resources +
+net.sf.freecol.common.util +
+net.sf.freecol.server.model + +
+

net.sf.freecol.client.gui.plaf

+ + + + + + +
Afferent Couplings: 2Efferent Couplings: 26Abstractness: 0.0Instability: 0.93Distance: -0.07
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.client.gui.plaf.FreeColBrightPanelUI +
net.sf.freecol.client.gui.plaf.FreeColButtonUI +
net.sf.freecol.client.gui.plaf.FreeColCheckBoxUI +
net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer +
net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer$NormalComponent +
net.sf.freecol.client.gui.plaf.FreeColComboBoxRenderer$SelectedComponent +
net.sf.freecol.client.gui.plaf.FreeColComboBoxUI +
net.sf.freecol.client.gui.plaf.FreeColFileChooserUI +
net.sf.freecol.client.gui.plaf.FreeColLabelUI +
net.sf.freecol.client.gui.plaf.FreeColListUI +
net.sf.freecol.client.gui.plaf.FreeColLookAndFeel +
net.sf.freecol.client.gui.plaf.FreeColMenuBarUI +
net.sf.freecol.client.gui.plaf.FreeColMenuItemUI +
net.sf.freecol.client.gui.plaf.FreeColOptionPaneUI +
net.sf.freecol.client.gui.plaf.FreeColPanelUI +
net.sf.freecol.client.gui.plaf.FreeColPopupMenuUI +
net.sf.freecol.client.gui.plaf.FreeColRadioButtonUI +
net.sf.freecol.client.gui.plaf.FreeColScrollPaneUI +
net.sf.freecol.client.gui.plaf.FreeColSelectedPanelUI +
net.sf.freecol.client.gui.plaf.FreeColTableHeaderUI +
net.sf.freecol.client.gui.plaf.FreeColTableUI +
net.sf.freecol.client.gui.plaf.FreeColTextAreaUI +
net.sf.freecol.client.gui.plaf.FreeColTextFieldUI +
net.sf.freecol.client.gui.plaf.FreeColToolTipUI +
net.sf.freecol.client.gui.plaf.FreeColTransparentPanelUI +
net.sf.freecol.client.gui.plaf.LAFUtilities +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.panel + +
+java.awt +
+java.awt.event +
+java.awt.font +
+java.lang +
+java.text +
+java.util.logging +
+java.util.regex +
+javax.swing +
+javax.swing.plaf +
+javax.swing.plaf.basic +
+javax.swing.plaf.metal +
+javax.swing.table +
+net.miginfocom.swing +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.resources + +
+

net.sf.freecol.client.gui.video

+ + + + + + +
Afferent Couplings: 1Efferent Couplings: 1Abstractness: 0.5Instability: 0.5Distance: 0.0
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.client.gui.video.VideoListener + +net.sf.freecol.client.gui.video.VideoComponent + +net.sf.freecol.client.gui + + +com.fluendo.player +
+java.awt +
+java.awt.event +
+java.lang +
+java.util.logging +
+javax.swing +
+javax.swing.border +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.resources + +
+

net.sf.freecol.client.networking

+ + + + + + +
Afferent Couplings: 1Efferent Couplings: 1Abstractness: 0.0Instability: 0.5Distance: -0.5
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.client.networking.UserServerAPI + +net.sf.freecol.client + + +java.lang +
+net.sf.freecol.client.gui +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.networking +
+org.w3c.dom + +
+

net.sf.freecol.common

+ + + + + + +
Afferent Couplings: 18Efferent Couplings: 5Abstractness: 0.2Instability: 0.22Distance: -0.58
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.ObjectWithId + +net.sf.freecol.common.AllTests +
net.sf.freecol.common.FreeColException +
net.sf.freecol.common.FreeColSeed +
net.sf.freecol.common.ServerInfo +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.logging +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.metaserver +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.control +
+net.sf.freecol.server.model +
+net.sf.freecol.server.networking + +
+java.lang +
+java.security +
+java.util.logging +
+junit.framework +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.sound +
+net.sf.freecol.common.utils +
+org.w3c.dom + +
+

net.sf.freecol.common.debug

+ + + + + + +
Afferent Couplings: 15Efferent Couplings: 2Abstractness: 0.0Instability: 0.12Distance: -0.88
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.common.debug.DebugUtils +
net.sf.freecol.common.debug.FreeColDebugger +
net.sf.freecol.common.debug.FreeColDebugger$DebugMode +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.networking +
+net.sf.freecol.common.logging +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.control +
+net.sf.freecol.server.model + +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.swing +
+net.sf.freecol.client +
+net.sf.freecol.client.gui +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.model + +
+

net.sf.freecol.common.i18n

+ + + + + + +
Afferent Couplings: 17Efferent Couplings: 19Abstractness: 0.1Instability: 0.53Distance: -0.37
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.i18n.Number +
net.sf.freecol.common.i18n.Selector +
+net.sf.freecol.common.i18n.AllTests +
net.sf.freecol.common.i18n.CLDRTest +
net.sf.freecol.common.i18n.DefaultNumberRule +
net.sf.freecol.common.i18n.DualNumberRule +
net.sf.freecol.common.i18n.Merge +
net.sf.freecol.common.i18n.MergeTableCellRenderer +
net.sf.freecol.common.i18n.MergeTableModel +
net.sf.freecol.common.i18n.MessageMerge +
net.sf.freecol.common.i18n.Messages +
net.sf.freecol.common.i18n.MessagesTest +
net.sf.freecol.common.i18n.NameCache +
net.sf.freecol.common.i18n.Number$Category +
net.sf.freecol.common.i18n.NumberRules +
net.sf.freecol.common.i18n.OtherNumberRule +
net.sf.freecol.common.i18n.PluralNumberRule +
net.sf.freecol.common.i18n.Relation +
net.sf.freecol.common.i18n.Rule +
net.sf.freecol.common.i18n.ZeroOneNumberRule +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.model +
+net.sf.freecol.tools +
+net.sf.freecol.util.test + +
+java.awt +
+java.awt.event +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+javax.swing +
+javax.swing.table +
+javax.xml.stream +
+junit.framework +
+net.sf.freecol.common +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.server.model +
+net.sf.freecol.util.test + +
+

net.sf.freecol.common.io

+ + + + + + +
Afferent Couplings: 23Efferent Couplings: 10Abstractness: 0.0Instability: 0.3Distance: -0.7
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.common.io.AllTests +
net.sf.freecol.common.io.FreeColDataFile +
net.sf.freecol.common.io.FreeColDirectories +
net.sf.freecol.common.io.FreeColModFile +
net.sf.freecol.common.io.FreeColSavegameFile +
net.sf.freecol.common.io.FreeColTcFile +
net.sf.freecol.common.io.FreeColXMLReader +
net.sf.freecol.common.io.FreeColXMLReader$ReadScope +
net.sf.freecol.common.io.FreeColXMLWriter +
net.sf.freecol.common.io.FreeColXMLWriter$WriteScope +
net.sf.freecol.common.io.ModTest +
net.sf.freecol.common.io.Mods +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.model +
+net.sf.freecol.common.model.mission +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.sound +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.goal +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model +
+net.sf.freecol.tools +
+net.sf.freecol.util.test + +
+java.io +
+java.lang +
+java.net +
+java.nio.file +
+java.util +
+java.util.jar +
+java.util.logging +
+javax.swing.filechooser +
+javax.xml.namespace +
+javax.xml.stream +
+javax.xml.stream.util +
+javax.xml.transform +
+javax.xml.transform.stream +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.model +
+net.sf.freecol.common.resources +
+net.sf.freecol.common.util +
+net.sf.freecol.server.ai +
+net.sf.freecol.util.test + +
+

net.sf.freecol.common.io.sza

+ + + + + + +
Afferent Couplings: 2Efferent Couplings: 3Abstractness: 0.5Instability: 0.6Distance: 0.1
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.io.sza.AnimationEvent +
net.sf.freecol.common.io.sza.ImageAnimationEvent +
+net.sf.freecol.common.io.sza.SimpleZippedAnimation +
net.sf.freecol.common.io.sza.SimpleZippedAnimation$ImageAnimationEventImpl +
+net.sf.freecol.client.gui.animation +
+net.sf.freecol.common.resources + +
+java.awt +
+java.awt.image +
+java.io +
+java.lang +
+java.net +
+java.util +
+java.util.zip +
+javax.imageio + +
+

net.sf.freecol.common.logging

+ + + + + + +
Afferent Couplings: 1Efferent Couplings: 2Abstractness: 0.0Instability: 0.67Distance: -0.33
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.common.logging.DefaultHandler +
net.sf.freecol.common.logging.TextFormatter +
+net.sf.freecol + + +java.io +
+java.lang +
+java.util +
+java.util.logging +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.util + +
+

net.sf.freecol.common.model

+ + + + + + +
Afferent Couplings: 28Efferent Couplings: 158Abstractness: 0.12Instability: 0.85Distance: -0.03
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.model.BuildableType +
net.sf.freecol.common.model.CombatModel +
net.sf.freecol.common.model.Consumer +
net.sf.freecol.common.model.Feature +
net.sf.freecol.common.model.FreeColGameObject +
net.sf.freecol.common.model.FreeColGameObjectListener +
net.sf.freecol.common.model.FreeColGameObjectType +
net.sf.freecol.common.model.FreeColObject +
net.sf.freecol.common.model.GoodsLocation +
net.sf.freecol.common.model.Locatable +
net.sf.freecol.common.model.Location +
net.sf.freecol.common.model.Map$SearchHeuristic +
net.sf.freecol.common.model.Movable +
net.sf.freecol.common.model.Nameable +
net.sf.freecol.common.model.Named +
net.sf.freecol.common.model.NationType +
net.sf.freecol.common.model.Ownable +
net.sf.freecol.common.model.Player$UnitPredicate +
net.sf.freecol.common.model.Settlement +
net.sf.freecol.common.model.Specification$ChildReader +
net.sf.freecol.common.model.TileItem +
net.sf.freecol.common.model.TradeItem +
net.sf.freecol.common.model.TradeLocation +
net.sf.freecol.common.model.TransactionListener +
net.sf.freecol.common.model.UnitLocation +
net.sf.freecol.common.model.WorkLocation +
+net.sf.freecol.common.model.Ability +
net.sf.freecol.common.model.AbstractGoods +
net.sf.freecol.common.model.AbstractUnit +
net.sf.freecol.common.model.AllTests +
net.sf.freecol.common.model.BaseCostDeciderTest +
net.sf.freecol.common.model.BuildQueue +
net.sf.freecol.common.model.BuildQueue$CompletionAction +
net.sf.freecol.common.model.Building +
net.sf.freecol.common.model.BuildingTest +
net.sf.freecol.common.model.BuildingType +
net.sf.freecol.common.model.Colony +
net.sf.freecol.common.model.Colony$ColonyChangeEvent +
net.sf.freecol.common.model.Colony$NoBuildReason +
net.sf.freecol.common.model.Colony$TileImprovementSuggestion +
net.sf.freecol.common.model.ColonyProductionTest +
net.sf.freecol.common.model.ColonyTest +
net.sf.freecol.common.model.ColonyTile +
net.sf.freecol.common.model.ColonyTradeItem +
net.sf.freecol.common.model.ColonyWas +
net.sf.freecol.common.model.CombatModel$CombatOdds +
net.sf.freecol.common.model.CombatModel$CombatResult +
net.sf.freecol.common.model.CombatTest +
net.sf.freecol.common.model.DiplomaticTrade +
net.sf.freecol.common.model.DiplomaticTrade$TradeContext +
net.sf.freecol.common.model.DiplomaticTrade$TradeStatus +
net.sf.freecol.common.model.Direction +
net.sf.freecol.common.model.Disaster +
net.sf.freecol.common.model.Disaster$Effects +
net.sf.freecol.common.model.DisasterTest +
net.sf.freecol.common.model.Effect +
net.sf.freecol.common.model.EquipmentType +
net.sf.freecol.common.model.Europe +
net.sf.freecol.common.model.Europe$MigrationType +
net.sf.freecol.common.model.EuropeTest +
net.sf.freecol.common.model.EuropeWas +
net.sf.freecol.common.model.EuropeanNationType +
net.sf.freecol.common.model.Event +
net.sf.freecol.common.model.ExportData +
net.sf.freecol.common.model.FeatureContainer +
net.sf.freecol.common.model.FoundingFather +
net.sf.freecol.common.model.FoundingFather$FoundingFatherType +
net.sf.freecol.common.model.FoundingFatherTest +
net.sf.freecol.common.model.Game +
net.sf.freecol.common.model.Game$FcgoState +
net.sf.freecol.common.model.GameOptions +
net.sf.freecol.common.model.GameTest +
net.sf.freecol.common.model.GoldTradeItem +
net.sf.freecol.common.model.Goods +
net.sf.freecol.common.model.GoodsContainer +
net.sf.freecol.common.model.GoodsContainerTest +
net.sf.freecol.common.model.GoodsTest +
net.sf.freecol.common.model.GoodsTradeItem +
net.sf.freecol.common.model.GoodsType +
net.sf.freecol.common.model.HighScore +
net.sf.freecol.common.model.HighScore$ScoreLevel +
net.sf.freecol.common.model.HighSeas +
net.sf.freecol.common.model.HighSeasTest +
net.sf.freecol.common.model.HistoryEvent +
net.sf.freecol.common.model.HistoryEvent$HistoryEventType +
net.sf.freecol.common.model.InciteTradeItem +
net.sf.freecol.common.model.IndianNationType +
net.sf.freecol.common.model.IndianSettlement +
net.sf.freecol.common.model.IndianSettlement$ContactLevel +
net.sf.freecol.common.model.IndianSettlementTest +
net.sf.freecol.common.model.IndividualFatherTest +
net.sf.freecol.common.model.LandMap +
net.sf.freecol.common.model.LastSale +
net.sf.freecol.common.model.Limit +
net.sf.freecol.common.model.Limit$Operator +
net.sf.freecol.common.model.LimitTest +
net.sf.freecol.common.model.LostCityRumour +
net.sf.freecol.common.model.LostCityRumour$RumourType +
net.sf.freecol.common.model.Map +
net.sf.freecol.common.model.Map$CircleIterator +
net.sf.freecol.common.model.Map$Layer +
net.sf.freecol.common.model.Map$MoveCandidate +
net.sf.freecol.common.model.Map$MoveStep +
net.sf.freecol.common.model.Map$Position +
net.sf.freecol.common.model.Map$WholeMapIterator +
net.sf.freecol.common.model.MapTest +
net.sf.freecol.common.model.Market +
net.sf.freecol.common.model.Market$Access +
net.sf.freecol.common.model.MarketData +
net.sf.freecol.common.model.MarketTest +
net.sf.freecol.common.model.MarketWas +
net.sf.freecol.common.model.ModelMessage +
net.sf.freecol.common.model.ModelMessage$MessageType +
net.sf.freecol.common.model.ModelMessageTest +
net.sf.freecol.common.model.Modifier +
net.sf.freecol.common.model.Modifier$ModifierType +
net.sf.freecol.common.model.ModifierTest +
net.sf.freecol.common.model.Monarch +
net.sf.freecol.common.model.Monarch$Force +
net.sf.freecol.common.model.Monarch$MonarchAction +
net.sf.freecol.common.model.MonarchTest +
net.sf.freecol.common.model.MovementTest +
net.sf.freecol.common.model.Nation +
net.sf.freecol.common.model.NationOptions +
net.sf.freecol.common.model.NationOptions$Advantages +
net.sf.freecol.common.model.NationOptions$NationState +
net.sf.freecol.common.model.NationSummary +
net.sf.freecol.common.model.NationType$AggressionLevel +
net.sf.freecol.common.model.NationType$SettlementNumber +
net.sf.freecol.common.model.NationTypeTest +
net.sf.freecol.common.model.Occupation +
net.sf.freecol.common.model.Operand +
net.sf.freecol.common.model.Operand$OperandType +
net.sf.freecol.common.model.Operand$ScopeLevel +
net.sf.freecol.common.model.PathNode +
net.sf.freecol.common.model.PathfindingTest +
net.sf.freecol.common.model.Player +
net.sf.freecol.common.model.Player$ActivePredicate +
net.sf.freecol.common.model.Player$ColonyValueCategory +
net.sf.freecol.common.model.Player$GoingToPredicate +
net.sf.freecol.common.model.Player$NoClaimReason +
net.sf.freecol.common.model.Player$NoValueType +
net.sf.freecol.common.model.Player$PlayerType +
net.sf.freecol.common.model.Player$UnitIterator +
net.sf.freecol.common.model.PlayerExploredTile +
net.sf.freecol.common.model.PlayerTest +
net.sf.freecol.common.model.ProductionCache +
net.sf.freecol.common.model.ProductionInfo +
net.sf.freecol.common.model.ProductionMap +
net.sf.freecol.common.model.ProductionMap$ProductionTree +
net.sf.freecol.common.model.ProductionType +
net.sf.freecol.common.model.ProductionTypeTest +
net.sf.freecol.common.model.RandomRange +
net.sf.freecol.common.model.RandomRangeTest +
net.sf.freecol.common.model.Region +
net.sf.freecol.common.model.Region$RegionType +
net.sf.freecol.common.model.Resource +
net.sf.freecol.common.model.ResourceType +
net.sf.freecol.common.model.Role +
net.sf.freecol.common.model.Role$RoleChange +
net.sf.freecol.common.model.RoleTest +
net.sf.freecol.common.model.SchoolTest +
net.sf.freecol.common.model.SchoolTest$SchoolLevel +
net.sf.freecol.common.model.Scope +
net.sf.freecol.common.model.ScopeTest +
net.sf.freecol.common.model.SerializationTest +
net.sf.freecol.common.model.SettlementTest +
net.sf.freecol.common.model.SettlementType +
net.sf.freecol.common.model.SimpleCombatModel +
net.sf.freecol.common.model.SoLTest +
net.sf.freecol.common.model.Specification +
net.sf.freecol.common.model.Specification$ModifierReader +
net.sf.freecol.common.model.Specification$OptionReader +
net.sf.freecol.common.model.Specification$Source +
net.sf.freecol.common.model.Specification$TypeReader +
net.sf.freecol.common.model.SpecificationTest +
net.sf.freecol.common.model.Stance +
net.sf.freecol.common.model.StanceTradeItem +
net.sf.freecol.common.model.StringTemplate +
net.sf.freecol.common.model.StringTemplate$TemplateType +
net.sf.freecol.common.model.Tension +
net.sf.freecol.common.model.Tension$Level +
net.sf.freecol.common.model.Tile +
net.sf.freecol.common.model.Tile$IndianSettlementInternals +
net.sf.freecol.common.model.TileImprovement +
net.sf.freecol.common.model.TileImprovementStyle +
net.sf.freecol.common.model.TileImprovementTest +
net.sf.freecol.common.model.TileImprovementType +
net.sf.freecol.common.model.TileItemContainer +
net.sf.freecol.common.model.TileItemContainerTest +
net.sf.freecol.common.model.TileTest +
net.sf.freecol.common.model.TileTest$Work +
net.sf.freecol.common.model.TileType +
net.sf.freecol.common.model.TileType$RangeType +
net.sf.freecol.common.model.TileTypeChange +
net.sf.freecol.common.model.TradeRoute +
net.sf.freecol.common.model.TradeRouteStop +
net.sf.freecol.common.model.TradeRouteTest +
net.sf.freecol.common.model.Turn +
net.sf.freecol.common.model.TypeCountMap +
net.sf.freecol.common.model.Unit +
net.sf.freecol.common.model.Unit$MoveType +
net.sf.freecol.common.model.Unit$UnitLabelType +
net.sf.freecol.common.model.Unit$UnitState +
net.sf.freecol.common.model.UnitLocation$NoAddReason +
net.sf.freecol.common.model.UnitTest +
net.sf.freecol.common.model.UnitTradeItem +
net.sf.freecol.common.model.UnitType +
net.sf.freecol.common.model.UnitTypeChange +
net.sf.freecol.common.model.UnitTypeChange$ChangeType +
net.sf.freecol.common.model.UnitTypeChangeTest +
net.sf.freecol.common.model.UnitWas +
net.sf.freecol.common.model.WorkLocation$Suggestion +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.animation +
+net.sf.freecol.client.gui.menu +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model.mission +
+net.sf.freecol.common.model.pathfinding +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.goal +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.control +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model +
+net.sf.freecol.tools +
+net.sf.freecol.util.test + +
+java.awt +
+java.beans +
+java.io +
+java.lang +
+java.lang.reflect +
+java.text +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.xml.parsers +
+javax.xml.stream +
+javax.xml.transform +
+javax.xml.transform.dom +
+javax.xml.transform.stream +
+javax.xml.validation +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model.pathfinding +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.control +
+net.sf.freecol.server.model +
+net.sf.freecol.util.test +
+org.w3c.dom +
+org.xml.sax + +
+

net.sf.freecol.common.model.mission

+ + + + + + +
Afferent Couplings: 0Efferent Couplings: 6Abstractness: 0.29Instability: 1.0Distance: 0.29
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.model.mission.AbstractMission +
net.sf.freecol.common.model.mission.Mission +
+net.sf.freecol.common.model.mission.CompoundMission +
net.sf.freecol.common.model.mission.GoToMission +
net.sf.freecol.common.model.mission.ImprovementMission +
net.sf.freecol.common.model.mission.Mission$MissionState +
net.sf.freecol.common.model.mission.MissionManager +
+None + +java.lang +
+java.util.logging +
+javax.xml.stream +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+org.w3c.dom + +
+

net.sf.freecol.common.model.pathfinding

+ + + + + + +
Afferent Couplings: 4Efferent Couplings: 10Abstractness: 0.2Instability: 0.71Distance: -0.09
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.model.pathfinding.CostDecider +
net.sf.freecol.common.model.pathfinding.GoalDecider +
+net.sf.freecol.common.model.pathfinding.BaseCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders +
net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidNavalDangerCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsAndBlockingUnitsCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders$AvoidSettlementsCostDecider +
net.sf.freecol.common.model.pathfinding.CostDeciders$ServerBaseCostDecider +
net.sf.freecol.common.model.pathfinding.GoalDeciders +
net.sf.freecol.common.model.pathfinding.GoalDeciders$MultipleAdjacentDecider +
+net.sf.freecol.common.model +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.model + +
+java.lang +
+net.sf.freecol.common.model + +
+

net.sf.freecol.common.networking

+ + + + + + +
Afferent Couplings: 12Efferent Couplings: 75Abstractness: 0.06Instability: 0.86Distance: -0.07
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.networking.CurrentPlayerNetworkRequestHandler +
net.sf.freecol.common.networking.MessageHandler +
net.sf.freecol.common.networking.NetworkConstants +
net.sf.freecol.common.networking.NetworkRequestHandler +
net.sf.freecol.common.networking.ServerAPI +
+net.sf.freecol.common.networking.AbandonColonyMessage +
net.sf.freecol.common.networking.AskSkillMessage +
net.sf.freecol.common.networking.AssignTeacherMessage +
net.sf.freecol.common.networking.AssignTradeRouteMessage +
net.sf.freecol.common.networking.AttackMessage +
net.sf.freecol.common.networking.BuildColonyMessage +
net.sf.freecol.common.networking.BuyMessage +
net.sf.freecol.common.networking.BuyPropositionMessage +
net.sf.freecol.common.networking.CashInTreasureTrainMessage +
net.sf.freecol.common.networking.ChangeStateMessage +
net.sf.freecol.common.networking.ChangeWorkImprovementTypeMessage +
net.sf.freecol.common.networking.ChangeWorkTypeMessage +
net.sf.freecol.common.networking.ChatMessage +
net.sf.freecol.common.networking.ChooseFoundingFatherMessage +
net.sf.freecol.common.networking.ClaimLandMessage +
net.sf.freecol.common.networking.ClearSpecialityMessage +
net.sf.freecol.common.networking.Client +
net.sf.freecol.common.networking.CloseTransactionMessage +
net.sf.freecol.common.networking.Connection +
net.sf.freecol.common.networking.DOMMessage +
net.sf.freecol.common.networking.DeclareIndependenceMessage +
net.sf.freecol.common.networking.DeclineMoundsMessage +
net.sf.freecol.common.networking.DeliverGiftMessage +
net.sf.freecol.common.networking.DemandTributeMessage +
net.sf.freecol.common.networking.DiplomacyMessage +
net.sf.freecol.common.networking.DisbandUnitMessage +
net.sf.freecol.common.networking.DisembarkMessage +
net.sf.freecol.common.networking.EmbarkMessage +
net.sf.freecol.common.networking.EmigrateUnitMessage +
net.sf.freecol.common.networking.EquipForRoleMessage +
net.sf.freecol.common.networking.FirstContactMessage +
net.sf.freecol.common.networking.GetNationSummaryMessage +
net.sf.freecol.common.networking.GetTransactionMessage +
net.sf.freecol.common.networking.GoodsForSaleMessage +
net.sf.freecol.common.networking.InciteMessage +
net.sf.freecol.common.networking.IndianDemandMessage +
net.sf.freecol.common.networking.JoinColonyMessage +
net.sf.freecol.common.networking.LearnSkillMessage +
net.sf.freecol.common.networking.LoadGoodsMessage +
net.sf.freecol.common.networking.LoginMessage +
net.sf.freecol.common.networking.LootCargoMessage +
net.sf.freecol.common.networking.Message +
net.sf.freecol.common.networking.MissionaryMessage +
net.sf.freecol.common.networking.MonarchActionMessage +
net.sf.freecol.common.networking.MoveMessage +
net.sf.freecol.common.networking.MoveToMessage +
net.sf.freecol.common.networking.NetworkReplyObject +
net.sf.freecol.common.networking.NewLandNameMessage +
net.sf.freecol.common.networking.NewRegionNameMessage +
net.sf.freecol.common.networking.PayArrearsMessage +
net.sf.freecol.common.networking.PayForBuildingMessage +
net.sf.freecol.common.networking.PutOutsideColonyMessage +
net.sf.freecol.common.networking.RearrangeColonyMessage +
net.sf.freecol.common.networking.RearrangeColonyMessage$UnitChange +
net.sf.freecol.common.networking.ReceivingThread +
net.sf.freecol.common.networking.ReceivingThread$FreeColNetworkInputStream +
net.sf.freecol.common.networking.RenameMessage +
net.sf.freecol.common.networking.ScoutIndianSettlementMessage +
net.sf.freecol.common.networking.ScoutSpeakToChiefMessage +
net.sf.freecol.common.networking.SellMessage +
net.sf.freecol.common.networking.SellPropositionMessage +
net.sf.freecol.common.networking.SetBuildQueueMessage +
net.sf.freecol.common.networking.SetCurrentStopMessage +
net.sf.freecol.common.networking.SetDestinationMessage +
net.sf.freecol.common.networking.SetGoodsLevelsMessage +
net.sf.freecol.common.networking.SetTradeRoutesMessage +
net.sf.freecol.common.networking.SpySettlementMessage +
net.sf.freecol.common.networking.TrainUnitInEuropeMessage +
net.sf.freecol.common.networking.TrivialMessage +
net.sf.freecol.common.networking.UnloadGoodsMessage +
net.sf.freecol.common.networking.UpdateTradeRouteMessage +
net.sf.freecol.common.networking.WorkMessage +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.networking +
+net.sf.freecol.common.logging +
+net.sf.freecol.common.model +
+net.sf.freecol.metaserver +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.control +
+net.sf.freecol.server.model +
+net.sf.freecol.server.networking + +
+java.awt +
+java.io +
+java.lang +
+java.net +
+java.util +
+java.util.logging +
+javax.xml.parsers +
+javax.xml.stream +
+javax.xml.transform +
+javax.xml.transform.dom +
+javax.xml.transform.stream +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.control +
+net.sf.freecol.server.model +
+org.w3c.dom +
+org.xml.sax + +
+

net.sf.freecol.common.option

+ + + + + + +
Afferent Couplings: 17Efferent Couplings: 24Abstractness: 0.12Instability: 0.59Distance: -0.29
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.option.AbstractOption +
net.sf.freecol.common.option.ListOption +
net.sf.freecol.common.option.Option +
+net.sf.freecol.common.option.AbstractUnitOption +
net.sf.freecol.common.option.AllTests +
net.sf.freecol.common.option.AudioMixerOption +
net.sf.freecol.common.option.AudioMixerOption$MixerWrapper +
net.sf.freecol.common.option.BooleanOption +
net.sf.freecol.common.option.FileOption +
net.sf.freecol.common.option.IntegerOption +
net.sf.freecol.common.option.LanguageOption +
net.sf.freecol.common.option.LanguageOption$Language +
net.sf.freecol.common.option.MapGeneratorOptions +
net.sf.freecol.common.option.ModListOption +
net.sf.freecol.common.option.ModOption +
net.sf.freecol.common.option.OptionGroup +
net.sf.freecol.common.option.OptionTest +
net.sf.freecol.common.option.PercentageOption +
net.sf.freecol.common.option.RangeOption +
net.sf.freecol.common.option.SelectOption +
net.sf.freecol.common.option.StringOption +
net.sf.freecol.common.option.TextOption +
net.sf.freecol.common.option.UnitListOption +
net.sf.freecol.common.option.UnitTypeOption +
net.sf.freecol.common.option.UnitTypeOption$TypeSelector +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.action +
+net.sf.freecol.client.gui.option +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.sound +
+net.sf.freecol.server +
+net.sf.freecol.server.control +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model + +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+javax.sound.sampled +
+javax.xml.stream +
+junit.framework +
+net.sf.freecol.common +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.util +
+net.sf.freecol.util.test + +
+

net.sf.freecol.common.resources

+ + + + + + +
Afferent Couplings: 9Efferent Couplings: 17Abstractness: 0.19Instability: 0.65Distance: -0.16
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.resources.Resource +
net.sf.freecol.common.resources.Resource$Cleanable +
net.sf.freecol.common.resources.Resource$Preloadable +
net.sf.freecol.common.resources.ResourceFactory$ResourceSink +
+net.sf.freecol.common.resources.AudioResource +
net.sf.freecol.common.resources.ColorResource +
net.sf.freecol.common.resources.FAFile +
net.sf.freecol.common.resources.FAFile$CREatingInputStream +
net.sf.freecol.common.resources.FAFile$FALetter +
net.sf.freecol.common.resources.FAFile$FAName +
net.sf.freecol.common.resources.FAFileResource +
net.sf.freecol.common.resources.FontResource +
net.sf.freecol.common.resources.ImageResource +
net.sf.freecol.common.resources.ResourceFactory +
net.sf.freecol.common.resources.ResourceManager +
net.sf.freecol.common.resources.ResourceMapper +
net.sf.freecol.common.resources.ResourceMapping +
net.sf.freecol.common.resources.SZAResource +
net.sf.freecol.common.resources.StringResource +
net.sf.freecol.common.resources.Video +
net.sf.freecol.common.resources.VideoResource +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.animation +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.client.gui.plaf +
+net.sf.freecol.client.gui.video +
+net.sf.freecol.common.io +
+net.sf.freecol.common.sound + +
+java.awt +
+java.awt.color +
+java.awt.image +
+java.io +
+java.lang +
+java.lang.reflect +
+java.net +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.imageio +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.common.io.sza +
+net.sf.freecol.common.sound + +
+

net.sf.freecol.common.sound

+ + + + + + +
Afferent Couplings: 3Efferent Couplings: 7Abstractness: 0.0Instability: 0.7Distance: -0.3
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.common.sound.AllTests +
net.sf.freecol.common.sound.OggVorbisDecoderFactory +
net.sf.freecol.common.sound.OggVorbisDecoderFactory$OggStream +
net.sf.freecol.common.sound.OggVorbisDecoderFactory$OggVorbisAudioInputStream +
net.sf.freecol.common.sound.Playlist +
net.sf.freecol.common.sound.SoundPlayer +
net.sf.freecol.common.sound.SoundPlayer$SoundPlayerThread +
net.sf.freecol.common.sound.SoundTest +
+net.sf.freecol.client.control +
+net.sf.freecol.common +
+net.sf.freecol.common.resources + +
+com.jcraft.jogg +
+com.jcraft.jorbis +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+javax.sound.sampled +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.common.io +
+net.sf.freecol.common.option +
+net.sf.freecol.common.resources +
+net.sf.freecol.util.test + +
+

net.sf.freecol.common.util

+ + + + + + +
Afferent Couplings: 17Efferent Couplings: 10Abstractness: 0.1Instability: 0.37Distance: -0.53
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.common.util.Xml$Method + +net.sf.freecol.common.util.CollectionUtils +
net.sf.freecol.common.util.Introspector +
net.sf.freecol.common.util.LogBuilder +
net.sf.freecol.common.util.RandomChoice +
net.sf.freecol.common.util.RandomUtils +
net.sf.freecol.common.util.StringUtils +
net.sf.freecol.common.util.Utils +
net.sf.freecol.common.util.Xml +
net.sf.freecol.common.util.Xml$Exception +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.io +
+net.sf.freecol.common.logging +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.utils +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model +
+net.sf.freecol.util.test + +
+java.awt +
+java.io +
+java.lang +
+java.lang.reflect +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.xml.parsers +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.model +
+org.w3c.dom +
+org.xml.sax + +
+

net.sf.freecol.common.utils

+ + + + + + +
Afferent Couplings: 1Efferent Couplings: 2Abstractness: 0.0Instability: 0.67Distance: -0.33
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.common.utils.AllTests +
net.sf.freecol.common.utils.UtilsTest +
+net.sf.freecol.common + + +java.lang +
+java.util +
+junit.framework +
+net.sf.freecol.common.util +
+net.sf.freecol.util.test + +
+

net.sf.freecol.metaserver

+ + + + + + +
Afferent Couplings: 0Efferent Couplings: 4Abstractness: 0.0Instability: 1.0Distance: 0.0
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.metaserver.MetaItem +
net.sf.freecol.metaserver.MetaRegister +
net.sf.freecol.metaserver.MetaServer +
net.sf.freecol.metaserver.NetworkHandler +
+None + +java.io +
+java.lang +
+java.net +
+java.util +
+java.util.logging +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.networking +
+org.w3c.dom + +
+

net.sf.freecol.server

+ + + + + + +
Afferent Couplings: 13Efferent Couplings: 4Abstractness: 0.0Instability: 0.24Distance: -0.76
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.server.AllTests +
net.sf.freecol.server.FreeColServer +
net.sf.freecol.server.FreeColServer$GameState +
net.sf.freecol.server.SaveLoadTest +
net.sf.freecol.server.ServerTestHelper +
+net.sf.freecol +
+net.sf.freecol.client +
+net.sf.freecol.client.control +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.control +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model +
+net.sf.freecol.server.networking +
+net.sf.freecol.tools + +
+java.awt.image +
+java.io +
+java.lang +
+java.net +
+java.util +
+java.util.jar +
+java.util.logging +
+javax.imageio +
+javax.xml.stream +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.util +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.control +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model +
+net.sf.freecol.server.networking +
+net.sf.freecol.util.test +
+org.w3c.dom + +
+

net.sf.freecol.server.ai

+ + + + + + +
Afferent Couplings: 5Efferent Couplings: 34Abstractness: 0.14Instability: 0.87Distance: 0.01
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.server.ai.AIObject +
net.sf.freecol.server.ai.AIPlayer +
net.sf.freecol.server.ai.TransportableAIObject +
net.sf.freecol.server.ai.ValuedAIObject +
net.sf.freecol.server.ai.Wish +
+net.sf.freecol.server.ai.AIColony +
net.sf.freecol.server.ai.AIColonyTest +
net.sf.freecol.server.ai.AIGoods +
net.sf.freecol.server.ai.AIInGameInputHandler +
net.sf.freecol.server.ai.AIMain +
net.sf.freecol.server.ai.AIMessage +
net.sf.freecol.server.ai.AIUnit +
net.sf.freecol.server.ai.AllTests +
net.sf.freecol.server.ai.CacheEntryComparator +
net.sf.freecol.server.ai.Cargo +
net.sf.freecol.server.ai.Cargo$CargoMode +
net.sf.freecol.server.ai.Cargo$CargoPlan +
net.sf.freecol.server.ai.ColonyPlan +
net.sf.freecol.server.ai.ColonyPlan$BuildPlan +
net.sf.freecol.server.ai.ColonyPlan$ProfileType +
net.sf.freecol.server.ai.ColonyPlanTest +
net.sf.freecol.server.ai.ContactTest +
net.sf.freecol.server.ai.EuropeanAIPlayer +
net.sf.freecol.server.ai.GoodsWish +
net.sf.freecol.server.ai.MissionAssignmentTest +
net.sf.freecol.server.ai.NativeAIPlayer +
net.sf.freecol.server.ai.ProductionCache +
net.sf.freecol.server.ai.ProductionCache$Entry +
net.sf.freecol.server.ai.REFAIPlayer +
net.sf.freecol.server.ai.REFAIPlayer$TargetTuple +
net.sf.freecol.server.ai.REFTest +
net.sf.freecol.server.ai.StandardAIPlayerTest +
net.sf.freecol.server.ai.TensionTest +
net.sf.freecol.server.ai.TileImprovementPlan +
net.sf.freecol.server.ai.WorkLocationPlan +
net.sf.freecol.server.ai.WorkerWish +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.io +
+net.sf.freecol.server +
+net.sf.freecol.server.ai.goal +
+net.sf.freecol.server.ai.mission + +
+java.beans +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.xml.stream +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.model.pathfinding +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.ai.goal +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.control +
+net.sf.freecol.server.model +
+net.sf.freecol.server.networking +
+net.sf.freecol.util.test +
+org.w3c.dom + +
+

net.sf.freecol.server.ai.goal

+ + + + + + +
Afferent Couplings: 1Efferent Couplings: 4Abstractness: 0.4Instability: 0.8Distance: 0.2
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.server.ai.goal.Goal +
net.sf.freecol.server.ai.goal.GoalConstants +
+net.sf.freecol.server.ai.goal.CreateMissionAtSettlementGoal +
net.sf.freecol.server.ai.goal.GotoAdjacentGoal +
net.sf.freecol.server.ai.goal.ManageMissionariesGoal +
+net.sf.freecol.server.ai + + +java.lang +
+java.util.logging +
+javax.xml.stream +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.server.ai + +
+

net.sf.freecol.server.ai.mission

+ + + + + + +
Afferent Couplings: 2Efferent Couplings: 23Abstractness: 0.04Instability: 0.92Distance: -0.04
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.server.ai.mission.Mission + +net.sf.freecol.server.ai.mission.AllTests +
net.sf.freecol.server.ai.mission.BuildColonyMission +
net.sf.freecol.server.ai.mission.CashInTreasureTrainMission +
net.sf.freecol.server.ai.mission.DefendSettlementMission +
net.sf.freecol.server.ai.mission.IdleAtSettlementMission +
net.sf.freecol.server.ai.mission.IndianBringGiftMission +
net.sf.freecol.server.ai.mission.IndianDemandMission +
net.sf.freecol.server.ai.mission.MissionaryMission +
net.sf.freecol.server.ai.mission.PioneeringMission +
net.sf.freecol.server.ai.mission.PioneeringMissionTest +
net.sf.freecol.server.ai.mission.PrivateerMission +
net.sf.freecol.server.ai.mission.PrivateerMissionTest +
net.sf.freecol.server.ai.mission.ScoutingMission +
net.sf.freecol.server.ai.mission.ScoutingMissionTest +
net.sf.freecol.server.ai.mission.TransportMission +
net.sf.freecol.server.ai.mission.TransportMission$CargoResult +
net.sf.freecol.server.ai.mission.TransportMissionTest +
net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMission +
net.sf.freecol.server.ai.mission.UnitSeekAndDestroyMissionTest +
net.sf.freecol.server.ai.mission.UnitWanderHostileMission +
net.sf.freecol.server.ai.mission.UnitWanderMission +
net.sf.freecol.server.ai.mission.WishRealizationMission +
net.sf.freecol.server.ai.mission.WorkInsideColonyMission +
+net.sf.freecol.common.debug +
+net.sf.freecol.server.ai + +
+java.lang +
+java.util +
+java.util.logging +
+javax.xml.stream +
+junit.framework +
+net.sf.freecol.common +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.model.pathfinding +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.control +
+net.sf.freecol.server.model +
+net.sf.freecol.util.test + +
+

net.sf.freecol.server.control

+ + + + + + +
Afferent Couplings: 6Efferent Couplings: 29Abstractness: 0.13Instability: 0.83Distance: -0.04
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.server.control.ChangeSet$Change +
net.sf.freecol.server.control.Controller +
net.sf.freecol.server.control.InGameController$DOMMessageHandler +
net.sf.freecol.server.control.InputHandler +
+net.sf.freecol.server.control.AllTests +
net.sf.freecol.server.control.ChangeSet +
net.sf.freecol.server.control.ChangeSet$AttackChange +
net.sf.freecol.server.control.ChangeSet$AttributeChange +
net.sf.freecol.server.control.ChangeSet$ChangePriority +
net.sf.freecol.server.control.ChangeSet$FeatureChange +
net.sf.freecol.server.control.ChangeSet$MessageChange +
net.sf.freecol.server.control.ChangeSet$MoveChange +
net.sf.freecol.server.control.ChangeSet$ObjectChange +
net.sf.freecol.server.control.ChangeSet$OwnedChange +
net.sf.freecol.server.control.ChangeSet$PartialObjectChange +
net.sf.freecol.server.control.ChangeSet$PlayerChange +
net.sf.freecol.server.control.ChangeSet$RemoveChange +
net.sf.freecol.server.control.ChangeSet$See +
net.sf.freecol.server.control.ChangeSet$SpyChange +
net.sf.freecol.server.control.ChangeSet$StanceChange +
net.sf.freecol.server.control.ChangeSet$TrivialChange +
net.sf.freecol.server.control.FreeColServerHolder +
net.sf.freecol.server.control.InGameController +
net.sf.freecol.server.control.InGameController$DOMMessageCallable +
net.sf.freecol.server.control.InGameControllerTest +
net.sf.freecol.server.control.InGameInputHandler +
net.sf.freecol.server.control.InputHandler$DisconnectHandler +
net.sf.freecol.server.control.PreGameController +
net.sf.freecol.server.control.PreGameInputHandler +
net.sf.freecol.server.control.UserConnectionHandler +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.model + +
+java.awt +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.server +
+net.sf.freecol.server.model +
+net.sf.freecol.server.networking +
+net.sf.freecol.util.test +
+org.w3c.dom + +
+

net.sf.freecol.server.generator

+ + + + + + +
Afferent Couplings: 4Efferent Couplings: 12Abstractness: 0.23Instability: 0.75Distance: -0.02
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.server.generator.MapGenerator +
net.sf.freecol.server.generator.MapLayerGenerator +
net.sf.freecol.server.generator.MapLoader +
+net.sf.freecol.server.generator.AllTests +
net.sf.freecol.server.generator.ColonizationMapLoader +
net.sf.freecol.server.generator.FreeColMapLoader +
net.sf.freecol.server.generator.MapGeneratorTest +
net.sf.freecol.server.generator.River +
net.sf.freecol.server.generator.River$DirectionChange +
net.sf.freecol.server.generator.RiverSection +
net.sf.freecol.server.generator.SimpleMapGenerator +
net.sf.freecol.server.generator.SimpleMapGenerator$Territory +
net.sf.freecol.server.generator.TerrainGenerator +
+net.sf.freecol +
+net.sf.freecol.client.gui +
+net.sf.freecol.server +
+net.sf.freecol.util.test + +
+java.io +
+java.lang +
+java.util +
+java.util.logging +
+java.util.stream +
+junit.framework +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.model +
+net.sf.freecol.util.test + +
+

net.sf.freecol.server.model

+ + + + + + +
Afferent Couplings: 12Efferent Couplings: 21Abstractness: 0.09Instability: 0.64Distance: -0.27
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+net.sf.freecol.server.model.ServerModelObject +
net.sf.freecol.server.model.TransactionSession +
+net.sf.freecol.server.model.AllTests +
net.sf.freecol.server.model.DiplomacySession +
net.sf.freecol.server.model.LootSession +
net.sf.freecol.server.model.MonarchSession +
net.sf.freecol.server.model.ServerBuilding +
net.sf.freecol.server.model.ServerBuildingTest +
net.sf.freecol.server.model.ServerBuildingTest$SchoolLevel +
net.sf.freecol.server.model.ServerColony +
net.sf.freecol.server.model.ServerColonyTest +
net.sf.freecol.server.model.ServerColonyTile +
net.sf.freecol.server.model.ServerEurope +
net.sf.freecol.server.model.ServerGame +
net.sf.freecol.server.model.ServerIndianSettlement +
net.sf.freecol.server.model.ServerIndianSettlementTest +
net.sf.freecol.server.model.ServerPlayer +
net.sf.freecol.server.model.ServerPlayerTest +
net.sf.freecol.server.model.ServerRegion +
net.sf.freecol.server.model.ServerUnit +
net.sf.freecol.server.model.ServerUnitTest +
net.sf.freecol.server.model.TradeSession +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.model +
+net.sf.freecol.common.networking +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.control +
+net.sf.freecol.server.generator +
+net.sf.freecol.util.test + +
+java.awt +
+java.io +
+java.lang +
+java.lang.reflect +
+java.net +
+java.util +
+java.util.logging +
+java.util.stream +
+javax.xml.stream +
+junit.framework +
+net.sf.freecol.common +
+net.sf.freecol.common.debug +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.model.pathfinding +
+net.sf.freecol.common.networking +
+net.sf.freecol.common.option +
+net.sf.freecol.common.util +
+net.sf.freecol.server +
+net.sf.freecol.server.control +
+net.sf.freecol.util.test +
+org.w3c.dom + +
+

net.sf.freecol.server.networking

+ + + + + + +
Afferent Couplings: 3Efferent Couplings: 2Abstractness: 0.0Instability: 0.4Distance: -0.6
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.server.networking.DummyConnection +
net.sf.freecol.server.networking.Server +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.control + +
+java.io +
+java.lang +
+java.net +
+java.util.logging +
+net.sf.freecol +
+net.sf.freecol.common +
+net.sf.freecol.common.networking +
+net.sf.freecol.server +
+org.w3c.dom + +
+

net.sf.freecol.tools

+ + + + + + +
Afferent Couplings: 0Efferent Couplings: 18Abstractness: 0.0Instability: 1.0Distance: 0.0
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.tools.ColonizationMapReader +
net.sf.freecol.tools.ColonizationSaveGameReader +
net.sf.freecol.tools.ColonizationSaveGameReader$Colonist +
net.sf.freecol.tools.ColonizationSaveGameReader$ColonyData +
net.sf.freecol.tools.ColonizationSaveGameReader$GameData +
net.sf.freecol.tools.ColonizationSaveGameReader$PlayerData +
net.sf.freecol.tools.DesktopEntry +
net.sf.freecol.tools.FSGConverter +
net.sf.freecol.tools.FlagTest +
net.sf.freecol.tools.ForestMaker +
net.sf.freecol.tools.ForestMaker$ImageLocation +
net.sf.freecol.tools.GenerateDocumentation +
net.sf.freecol.tools.InstallerTranslations +
net.sf.freecol.tools.MapConverter +
net.sf.freecol.tools.MergeTranslations +
net.sf.freecol.tools.RiverMaker +
net.sf.freecol.tools.SaveGameValidator +
net.sf.freecol.tools.TranslationReport +
net.sf.freecol.tools.TranslationReport$LanguageStatsRecord +
+None + +java.awt +
+java.awt.event +
+java.awt.geom +
+java.awt.image +
+java.io +
+java.lang +
+java.text +
+java.util +
+java.util.stream +
+java.util.zip +
+javax.imageio +
+javax.swing +
+javax.xml.transform +
+javax.xml.transform.stream +
+javax.xml.validation +
+net.miginfocom.swing +
+net.sf.freecol +
+net.sf.freecol.client.gui.panel +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.server +
+org.xml.sax + +
+

net.sf.freecol.util.test

+ + + + + + +
Afferent Couplings: 14Efferent Couplings: 7Abstractness: 0.0Instability: 0.33Distance: -0.67
+ + + + + + +
Abstract ClassesConcrete ClassesReferencing PackagesReferenced Packages
+ +net.sf.freecol.util.test.FreeColTestCase +
net.sf.freecol.util.test.FreeColTestCase$IndianSettlementBuilder +
net.sf.freecol.util.test.FreeColTestCase$MapBuilder +
net.sf.freecol.util.test.FreeColTestUtils +
net.sf.freecol.util.test.FreeColTestUtils$ColonyBuilder +
net.sf.freecol.util.test.MockMapGenerator +
net.sf.freecol.util.test.MockPseudoRandom +
+net.sf.freecol.client.control +
+net.sf.freecol.client.gui +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.option +
+net.sf.freecol.common.sound +
+net.sf.freecol.common.utils +
+net.sf.freecol.server +
+net.sf.freecol.server.ai +
+net.sf.freecol.server.ai.mission +
+net.sf.freecol.server.control +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model + +
+java.lang +
+java.util +
+junit.framework +
+net.sf.freecol +
+net.sf.freecol.common.i18n +
+net.sf.freecol.common.io +
+net.sf.freecol.common.model +
+net.sf.freecol.common.util +
+net.sf.freecol.server.generator +
+net.sf.freecol.server.model + +
+
+ + +

Explanations

+

Terms

+
+

+The following are definitions of some of the terms used +in this report. For the most part, these definitions +are taken from the paper +OO Design Quality Metrics +by Robert Martin. +

+
+
Scope +
+Anything that can contain types; either a package or project. +
+
+
Number of Types +
+The total number of types defined within a scope. +
+
+
Afferent Coupling +
+The number of types outside a scope that depend on +types defined in the scope. (Sometimes abreviated as +Ca.) +
+
+
Efferent Coupling +
+The number of types in a scope that depend on types +defined outside the scope. (Sometimes abreviated as +Ce.) +
+
+
Abstractness +
+The number of abstract types (abstract classes and +interfaces) divided by the total number of types. +It ranges between zero (0.0) and one (1.0), +where zero indicates a completely concrete scope +and one indicates a completely abstract scope. +
+
+
Instability +
+The ratio of efferent coupling to the total coupling. +This value is computed as Ce / (Ca + Ce) +and represents the resiliance of the scope to change. +It ranges between zero (0.0) and one (1.0), +where zero indicates a maximally stable scope +and one indicates a maximally instable scope. +
+
+
Distance +
+The normalized distance of a scope (computed as +| A + I - 1 |) from the main sequence +(A + I = 1). This value represents the +degree to which stability and abstractness are balanced. +It ranges between zero (0.0) and one (1.0), +where zero indicates a maximally balanced scope +and one indicates a maximally unbalanced scope. +
+
+ + + + diff --git a/doc/Dependencies_files/Dependencies-cycle1.gif b/doc/Dependencies_files/Dependencies-cycle1.gif new file mode 100644 index 00000000..cd7c7d3e Binary files /dev/null and b/doc/Dependencies_files/Dependencies-cycle1.gif differ diff --git a/doc/Dependencies_files/Dependencies-package.gif b/doc/Dependencies_files/Dependencies-package.gif new file mode 100644 index 00000000..b6c54685 Binary files /dev/null and b/doc/Dependencies_files/Dependencies-package.gif differ diff --git a/doc/Dependencies_files/Dependencies-project.gif b/doc/Dependencies_files/Dependencies-project.gif new file mode 100644 index 00000000..a936c2b5 Binary files /dev/null and b/doc/Dependencies_files/Dependencies-project.gif differ diff --git a/reports/AuditViolations1.html b/reports/AuditViolations1.html new file mode 100644 index 00000000..0be8c968 --- /dev/null +++ b/reports/AuditViolations1.html @@ -0,0 +1,8410 @@ + + + + + + + CodePro Code Audit for A_Team-finalproject + + + + + + + + + + + + +
+

This document contains the results of auditing A_Team-finalproject at 5/13/17 12:43 PM, using the default audit rule set CodePro Core.

+
+ + + + + + +
+
+ +
+

Violations by Audit Rule

+
+ +
+ +
+ +
+ +
+

Violation Counts by Severity

+
+ +
+
+ + + + + +
Violation SeverityViolation Count
High12
Medium794
Low49
+
+
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
  +
+ + + +
+
ViolationRecommendationSeverityResourceLine
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +646
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +647
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +649
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +650
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +657
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +658
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +659
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +667
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +668
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +669
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +672
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyPanel.java +673
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ReportTradePanel.java +197
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +DebugUtils.java +864
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Relation.java +90
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FreeColXMLReader.java +262
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FreeColXMLReader.java +263
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Ability.java +555
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +AbstractUnit.java +259
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +AbstractUnit.java +260
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Building.java +650
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Building.java +651
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Building.java +653
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Building.java +654
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +BuildQueue.java +239
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +BuildQueue.java +241
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +BuildQueue.java +243
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyTile.java +527
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyTile.java +528
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyTile.java +529
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyTile.java +530
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyTradeItem.java +189
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyTradeItem.java +190
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonyTradeItem.java +190
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +DiplomaticTrade.java +522
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +DiplomaticTrade.java +523
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +DiplomaticTrade.java +524
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +DiplomaticTrade.java +529
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Disaster.java +208
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Disaster.java +210
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Disaster.java +212
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Effect.java +209
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Effect.java +210
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Effect.java +211
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Effect.java +212
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FeatureContainer.java +490
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FeatureContainer.java +492
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FeatureContainer.java +498
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FeatureContainer.java +500
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FeatureContainer.java +502
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoldTradeItem.java +174
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoldTradeItem.java +174
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoldTradeItem.java +174
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoodsContainer.java +612
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoodsContainer.java +615
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoodsContainer.java +621
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoodsTradeItem.java +204
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoodsTradeItem.java +205
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoodsTradeItem.java +205
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +GoodsTradeItem.java +206
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +HistoryEvent.java +320
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +HistoryEvent.java +321
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +HistoryEvent.java +322
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +HistoryEvent.java +327
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +HistoryEvent.java +327
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +InciteTradeItem.java +180
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +InciteTradeItem.java +181
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +InciteTradeItem.java +181
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +IndianSettlement.java +1,585
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +IndianSettlement.java +1,585
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +LastSale.java +173
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +LastSale.java +176
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Limit.java +367
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Limit.java +368
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Map.java +1,322
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Market.java +566
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Market.java +569
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Market.java +571
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +MarketData.java +465
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +MarketData.java +466
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +MarketData.java +477
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Modifier.java +658
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Modifier.java +659
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Modifier.java +666
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Modifier.java +669
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +NationOptions.java +329
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +NationOptions.java +331
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +NationOptions.java +332
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +NationOptions.java +333
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Occupation.java +184
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Occupation.java +185
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionInfo.java +169
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionMap.java +130
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionMap.java +130
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionMap.java +132
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionMap.java +212
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionMap.java +214
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionMap.java +215
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionType.java +511
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionType.java +511
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionType.java +513
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionType.java +534
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Region.java +628
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Region.java +629
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Region.java +631
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Region.java +632
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Region.java +633
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Role.java +397
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Role.java +397
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Role.java +399
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Scope.java +383
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Scope.java +383
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Scope.java +386
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Scope.java +386
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Scope.java +390
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StanceTradeItem.java +179
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StanceTradeItem.java +180
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StanceTradeItem.java +180
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StringTemplate.java +584
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StringTemplate.java +589
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StringTemplate.java +590
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StringTemplate.java +593
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StringTemplate.java +598
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Tile.java +2,247
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Tile.java +2,248
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Tile.java +2,749
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Tile.java +2,750
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Tile.java +2,751
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Tile.java +2,751
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Tile.java +2,753
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovement.java +669
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovement.java +673
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovement.java +674
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovementStyle.java +127
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileItemContainer.java +662
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileItemContainer.java +663
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileItemContainer.java +664
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRoute.java +403
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRoute.java +404
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRoute.java +407
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRoute.java +408
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRouteStop.java +322
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRouteStop.java +323
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRouteStop.java +325
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TradeRouteStop.java +327
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TypeCountMap.java +99
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TypeCountMap.java +102
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TypeCountMap.java +102
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TypeCountMap.java +104
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +2,366
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +2,368
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +3,937
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +3,939
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +3,941
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +4,547
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +4,553
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +4,554
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +4,556
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +4,558
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +4,560
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +Unit.java +4,562
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTradeItem.java +167
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTradeItem.java +168
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTradeItem.java +168
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTypeChange.java +351
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTypeChange.java +352
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTypeChange.java +354
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTypeChange.java +355
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTypeChange.java +357
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +AbstractUnitOption.java +273
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +AbstractUnitOption.java +274
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +AbstractUnitOption.java +274
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +BooleanOption.java +129
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +BooleanOption.java +131
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FileOption.java +134
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +FileOption.java +136
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +IntegerOption.java +212
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +IntegerOption.java +214
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ListOption.java +296
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ListOption.java +300
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ListOption.java +304
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ModOption.java +178
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ModOption.java +178
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +OptionGroup.java +609
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +OptionGroup.java +611
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +PercentageOption.java +57
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +PercentageOption.java +58
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +SelectOption.java +227
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +SelectOption.java +230
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StringOption.java +201
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +StringOption.java +205
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TextOption.java +130
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TextOption.java +132
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTypeOption.java +315
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UnitTypeOption.java +319
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +LogBuilder.java +199
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +RandomUtils.java +70
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionCache.java +418
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ProductionCache.java +425
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovementPlan.java +369
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovementPlan.java +370
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovementPlan.java +373
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TileImprovementPlan.java +374
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +WorkLocationPlan.java +130
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +WorkLocationPlan.java +131
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +WorkLocationPlan.java +133
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +204
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +207
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +210
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +431
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +432
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +434
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +435
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +436
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +437
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +438
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +439
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +513
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +514
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +516
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +517
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +518
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +579
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +580
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +582
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +583
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +705
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +706
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +708
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +709
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +710
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +711
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +812
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +813
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +815
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +816
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +872
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +873
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +875
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +876
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +877
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +940
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +941
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +943
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +944
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,037
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,038
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,040
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,042
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,044
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,044
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,105
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,106
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,108
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,109
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,178
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,179
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,181
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,182
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,183
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,184
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,185
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,248
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,249
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,251
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,252
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,319
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,320
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,322
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,323
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,324
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,325
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ChangeSet.java +1,926
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UserConnectionHandler.java +228
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +UserConnectionHandler.java +230
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +1,168
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +1,171
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +1,604
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +1,610
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +1,617
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +1,624
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +4,341
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +4,342
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerPlayer.java +4,343
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerRegion.java +543
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerRegion.java +543
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ServerRegion.java +544
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonizationMapReader.java +171
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +ColonizationMapReader.java +173
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TranslationReport.java +259
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TranslationReport.java +261
String literal can be replaced by a character literal +Replace the string literal with a character literal. Medium +TranslationReport.java +263
  + +
ViolationRecommendationSeverityResourceLine
Octal literal +Remove all leading zeros so that it will no longer be an octal representation. Low +ColonizationMapLoader.java +133
Octal literal +Remove all leading zeros so that it will no longer be an octal representation. Low +ColonizationMapLoader.java +144
  +
+ + + +
+
ViolationRecommendationSeverityResourceLine
Do not use Runtime.exec() to execute commands +Find a platform independent way of causing the same behavior. Medium +AboutPanel.java +189
  + +
ViolationRecommendationSeverityResourceLine
Duplicate import: import static net.sf.freecol.common.util.CollectionUtils.*; +Delete the duplicate import. Medium +WorkLocation.java +36
  + +
ViolationRecommendationSeverityResourceLine
Duplicate property name: model.option.landUnitCheat.shortDescription +Delete the duplicate property. High +FreeColMessages.properties +665
Duplicate property name: mapGeneratorOptions.terrainGenerator.name +Delete the duplicate property. High +FreeColMessages.properties +866
Duplicate property name: mapGeneratorOptions.terrainGenerator.shortDescription +Delete the duplicate property. High +FreeColMessages.properties +867
  + +
ViolationRecommendationSeverityResourceLine
Empty catch clause for exception e +Delete the empty catch clause. Medium +InGameController.java +1,626
Empty catch clause for exception ex +Delete the empty catch clause. Medium +PreGameInputHandler.java +283
Empty catch clause for exception e +Delete the empty catch clause. Medium +Canvas.java +153
Empty catch clause for exception e +Delete the empty catch clause. Medium +Canvas.java +560
Empty catch clause for exception e +Delete the empty catch clause. Medium +Canvas.java +817
Empty catch clause for exception e +Delete the empty catch clause. Medium +Canvas.java +842
Empty catch clause for exception e +Delete the empty catch clause. Medium +Canvas.java +937
Empty catch clause for exception e +Delete the empty catch clause. Medium +Canvas.java +954
Empty catch clause for exception cce +Delete the empty catch clause. Medium +Canvas.java +1,173
Empty catch clause for exception x +Delete the empty catch clause. Medium +AboutPanel.java +190
Empty catch clause for exception e +Delete the empty catch clause. Medium +BuildingDetailPanel.java +159
Empty catch clause for exception e +Delete the empty catch clause. Medium +RecruitPanel.java +136
Empty catch clause for exception e +Delete the empty catch clause. Medium +UnitDetailPanel.java +187
Empty catch clause for exception he +Delete the empty catch clause. Medium +SwingGUI.java +353
Empty catch clause for exception he +Delete the empty catch clause. Medium +SwingGUI.java +359
Empty catch clause for exception npe +Delete the empty catch clause. Medium +DebugUtils.java +595
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +FreeColDebugger.java +164
Empty catch clause for exception e +Delete the empty catch clause. Medium +FreeColDebugger.java +271
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +FreeColSeed.java +60
Empty catch clause for exception e +Delete the empty catch clause. Medium +Messages.java +271
Empty catch clause for exception e +Delete the empty catch clause. Medium +Messages.java +290
Empty catch clause for exception e +Delete the empty catch clause. Medium +SimpleZippedAnimation.java +112
Empty catch clause for exception cce +Delete the empty catch clause. Medium +Colony.java +626
Empty catch clause for exception cce +Delete the empty catch clause. Medium +Colony.java +655
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +EuropeWas.java +64
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +FreeColObject.java +202
Empty catch clause for exception e +Delete the empty catch clause. Medium +ClaimLandMessage.java +103
Empty catch clause for exception e +Delete the empty catch clause. Medium +ClaimLandMessage.java +108
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +FirstContactMessage.java +111
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +IndianDemandMessage.java +128
Empty catch clause for exception ie +Delete the empty catch clause. Medium +NetworkReplyObject.java +72
Empty catch clause for exception e +Delete the empty catch clause. Medium +ServerAPI.java +523
Empty catch clause for exception e +Delete the empty catch clause. Medium +ServerAPI.java +979
Empty catch clause for exception e +Delete the empty catch clause. Medium +ServerAPI.java +1,262
Empty catch clause for exception e +Delete the empty catch clause. Medium +AudioMixerOption.java +108
Empty catch clause for exception e +Delete the empty catch clause. Medium +SoundPlayer.java +221
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +FreeCol.java +1,078
Empty catch clause for exception ioe +Delete the empty catch clause. Medium +FreeCol.java +1,193
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +FreeCol.java +1,225
Empty catch clause for exception nfe +Delete the empty catch clause. Medium +FreeCol.java +1,255
Empty catch clause for exception e +Delete the empty catch clause. Medium +NetworkHandler.java +155
Empty catch clause for exception e +Delete the empty catch clause. Medium +UserConnectionHandler.java +190
Empty catch clause for exception e +Delete the empty catch clause. Medium +DummyConnection.java +104
Empty catch clause for exception e +Delete the empty catch clause. Medium +GenerateDocumentation.java +143
Empty catch clause for exception e +Delete the empty catch clause. Medium +InstallerTranslations.java +203
Empty catch clause for exception e +Delete the empty catch clause. Medium +MergeTranslations.java +120
  + +
ViolationRecommendationSeverityResourceLine
Empty for loop +Restructure the for loop so that it is more obvious what is suppose to be happening each time through the loop. Medium +PathNode.java +229
Empty for loop +Restructure the for loop so that it is more obvious what is suppose to be happening each time through the loop. Medium +PathNode.java +240
  +
+ + + +
+
ViolationRecommendationSeverityResourceLine
Empty statement +Delete the empty statement. High +NameCache.java +489
Empty statement +Delete the empty statement. High +NameCache.java +520
Empty statement +Delete the empty statement. High +NameCache.java +553
Empty statement +Delete the empty statement. High +PathNode.java +229
Empty statement +Delete the empty statement. High +PathNode.java +240
Empty statement +Delete the empty statement. High +AIMain.java +623
Empty statement +Delete the empty statement. High +Mission.java +591
Empty statement +Delete the empty statement. High +ServerPlayer.java +1,813
  + +
ViolationRecommendationSeverityResourceLine
Empty while statement +Remove the while statement or fix the code so that its body is no longer empty. Medium +NameCache.java +489
Empty while statement +Remove the while statement or fix the code so that its body is no longer empty. Medium +NameCache.java +520
Empty while statement +Remove the while statement or fix the code so that its body is no longer empty. Medium +NameCache.java +553
Empty while statement +Remove the while statement or fix the code so that its body is no longer empty. Medium +AIColony.java +786
Empty while statement +Remove the while statement or fix the code so that its body is no longer empty. Medium +AIMain.java +623
Empty while statement +Remove the while statement or fix the code so that its body is no longer empty. Medium +Mission.java +591
Empty while statement +Remove the while statement or fix the code so that its body is no longer empty. Medium +ServerPlayer.java +1,813
  + +
ViolationRecommendationSeverityResourceLine
Do not use System.getenv() to access environment variables +Use system properties instead of environment variables. High +FreeColDirectories.java +253
  + +
ViolationRecommendationSeverityResourceLine
Equality test with boolean literal: false +Remove the comparison with false. Medium +ListOptionUI.java +224
Equality test with boolean literal: true +Remove the comparison with true. Medium +LandMap.java +442
  +
+ + + +
+
ViolationRecommendationSeverityResourceLine
Extra semicolon +Delete the extra semicolon. Low +InGameController.java +327
Extra semicolon +Delete the extra semicolon. Low +InGameController.java +330
Extra semicolon +Delete the extra semicolon. Low +InGameController.java +1,020
Extra semicolon +Delete the extra semicolon. Low +InGameController.java +2,935
Extra semicolon +Delete the extra semicolon. Low +InGameController.java +4,580
Extra semicolon +Delete the extra semicolon. Low +ErrorPanel.java +85
Extra semicolon +Delete the extra semicolon. Low +LabourData.java +542
Extra semicolon +Delete the extra semicolon. Low +SelectDestinationDialog.java +183
Extra semicolon +Delete the extra semicolon. Low +DebugUtils.java +618
Extra semicolon +Delete the extra semicolon. Low +DebugUtils.java +628
Extra semicolon +Delete the extra semicolon. Low +FreeColDebugger.java +380
Extra semicolon +Delete the extra semicolon. Low +FreeColModFile.java +77
Extra semicolon +Delete the extra semicolon. Low +FreeColSavegameFile.java +91
Extra semicolon +Delete the extra semicolon. Low +Colony.java +626
Extra semicolon +Delete the extra semicolon. Low +Game.java +374
Extra semicolon +Delete the extra semicolon. Low +Game.java +1,272
Extra semicolon +Delete the extra semicolon. Low +CostDeciders.java +98
Extra semicolon +Delete the extra semicolon. Low +Player.java +1,364
Extra semicolon +Delete the extra semicolon. Low +Player.java +2,935
Extra semicolon +Delete the extra semicolon. Low +Resource.java +166
Extra semicolon +Delete the extra semicolon. Low +SimpleCombatModel.java +270
Extra semicolon +Delete the extra semicolon. Low +SimpleCombatModel.java +364
Extra semicolon +Delete the extra semicolon. Low +Specification.java +2,010
Extra semicolon +Delete the extra semicolon. Low +Unit.java +2,521
Extra semicolon +Delete the extra semicolon. Low +Unit.java +2,533
Extra semicolon +Delete the extra semicolon. Low +Unit.java +3,778
Extra semicolon +Delete the extra semicolon. Low +AttackMessage.java +106
Extra semicolon +Delete the extra semicolon. Low +BuildColonyMessage.java +101
Extra semicolon +Delete the extra semicolon. Low +Connection.java +322
Extra semicolon +Delete the extra semicolon. Low +DemandTributeMessage.java +98
Extra semicolon +Delete the extra semicolon. Low +EquipForRoleMessage.java +98
Extra semicolon +Delete the extra semicolon. Low +FirstContactMessage.java +141
Extra semicolon +Delete the extra semicolon. Low +FreeCol.java +626
Extra semicolon +Delete the extra semicolon. Low +FreeCol.java +629
Extra semicolon +Delete the extra semicolon. Low +ColonyPlan.java +802
Extra semicolon +Delete the extra semicolon. Low +EuropeanAIPlayer.java +839
Extra semicolon +Delete the extra semicolon. Low +EuropeanAIPlayer.java +1,566
Extra semicolon +Delete the extra semicolon. Low +BuildColonyMission.java +470
Extra semicolon +Delete the extra semicolon. Low +NativeAIPlayer.java +287
Extra semicolon +Delete the extra semicolon. Low +NativeAIPlayer.java +294
Extra semicolon +Delete the extra semicolon. Low +NativeAIPlayer.java +304
Extra semicolon +Delete the extra semicolon. Low +ServerColony.java +213
Extra semicolon +Delete the extra semicolon. Low +ServerPlayer.java +2,712
Extra semicolon +Delete the extra semicolon. Low +ServerUnit.java +683
Extra semicolon +Delete the extra semicolon. Low +ServerUnit.java +874
Extra semicolon +Delete the extra semicolon. Low +ServerUnit.java +990
Extra semicolon +Delete the extra semicolon. Low +ColonizationMapReader.java +167
  +
+ + + +
+
ViolationRecommendationSeverityResourceLine
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +MapViewer.java +1,193
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +MapViewer.java +1,197
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +ModifierFormat.java +52
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +ModifierFormat.java +64
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +Colony.java +803
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +FeatureContainer.java +290
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +Modifier.java +559
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +Modifier.java +560
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +Player.java +3,094
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +SimpleCombatModel.java +101
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +SimpleCombatModel.java +101
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +Unit.java +405
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +ImageResource.java +117
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +SZAResource.java +101
Cannot compare floating-point values using the equals (==) operator +Compare the two float values to see if they are close in value. Medium +EuropeanAIPlayer.java +1,671
  + +
ViolationRecommendationSeverityResourceLine
Explicit import of type from "net.sf.freecol.common.io": "FreeColModFile" +Delete the import. Medium +Mods.java +32
Explicit import of type from "net.sf.freecol.common.model": "GoodsType" +Delete the import. Medium +AbstractGoods.java +29
Explicit import of type from "net.sf.freecol.common.model": "StringTemplate" +Delete the import. Medium +BuildableType.java +35
Explicit import of type from "net.sf.freecol.common.model": "Occupation" +Delete the import. Medium +Colony.java +40
Explicit import of type from "net.sf.freecol.common.model": "Stance" +Delete the import. Medium +Colony.java +41
Explicit import of type from "net.sf.freecol.common.model": "Stance" +Delete the import. Medium +DiplomaticTrade.java +31
Explicit import of type from "net.sf.freecol.common.model": "Stance" +Delete the import. Medium +HistoryEvent.java +27
Explicit import of type from "net.sf.freecol.common.model": "Player" +Delete the import. Medium +InciteTradeItem.java +27
Explicit import of type from "net.sf.freecol.common.model": "Direction" +Delete the import. Medium +LandMap.java +28
Explicit import of type from "net.sf.freecol.common.model": "ModelMessage" +Delete the import. Medium +LostCityRumour.java +33
Explicit import of type from "net.sf.freecol.common.model": "AbstractGoods" +Delete the import. Medium +MarketWas.java +27
Explicit import of type from "net.sf.freecol.common.model": "GoodsType" +Delete the import. Medium +MarketWas.java +28
Explicit import of type from "net.sf.freecol.common.model": "Market" +Delete the import. Medium +MarketWas.java +29
Explicit import of type from "net.sf.freecol.common.model": "MarketData" +Delete the import. Medium +MarketWas.java +30
Explicit import of type from "net.sf.freecol.common.model": "Player" +Delete the import. Medium +MarketWas.java +31
Explicit import of type from "net.sf.freecol.common.model": "TransactionListener" +Delete the import. Medium +MarketWas.java +32
Explicit import of type from "net.sf.freecol.common.model": "Stance" +Delete the import. Medium +NationSummary.java +26
Explicit import of type from "net.sf.freecol.common.model": "Direction" +Delete the import. Medium +PathNode.java +23
Explicit import of type from "net.sf.freecol.common.model": "Named" +Delete the import. Medium +Stance.java +23
Explicit import of type from "net.sf.freecol.common.model": "Tension" +Delete the import. Medium +Stance.java +24
Explicit import of type from "net.sf.freecol.common.model": "Stance" +Delete the import. Medium +StanceTradeItem.java +27
Explicit import of type from "net.sf.freecol.common.model": "Direction" +Delete the import. Medium +Tile.java +40
Explicit import of type from "net.sf.freecol.common.model": "Direction" +Delete the import. Medium +TileImprovement.java +33
Explicit import of type from "net.sf.freecol.common.model": "Direction" +Delete the import. Medium +TileItemContainer.java +32
Explicit import of type from "net.sf.freecol.common.model": "Stance" +Delete the import. Medium +TradeItem.java +26
Explicit import of type from "net.sf.freecol.common.model": "CombatModel" +Delete the import. Medium +Unit.java +39
Explicit import of type from "net.sf.freecol.common.model": "Direction" +Delete the import. Medium +Unit.java +40
Explicit import of type from "net.sf.freecol.server.model": "ServerPlayer" +Delete the import. Medium +ServerColony.java +60
  + +
ViolationRecommendationSeverityResourceLine
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +656
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +664
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +728
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +806
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +807
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +822
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,053
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,055
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,058
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,065
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,067
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,070
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,076
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,077
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,080
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,081
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,084
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +Flag.java +1,085
Integer division in a floating-point expression +Cast one of the integers to a float. This will prevent round off error. Medium +FreeCol.java +1,043
  +
+ + + +
+
ViolationRecommendationSeverityResourceLine
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ConnectController.java +533
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ConnectController.java +735
Caught exception not logged +Use one of the logging methods to log the exception. Medium +InGameController.java +643
Caught exception not logged +Use one of the logging methods to log the exception. Medium +InGameController.java +1,626
Caught exception not logged +Use one of the logging methods to log the exception. Medium +InGameInputHandler.java +149
Caught exception not logged +Use one of the logging methods to log the exception. Medium +MapEditorController.java +118
Caught exception not logged +Use one of the logging methods to log the exception. Medium +MapEditorController.java +223
Caught exception not logged +Use one of the logging methods to log the exception. Medium +PreGameInputHandler.java +316
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColClient.java +826
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +560
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +817
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +823
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +842
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +848
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +937
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +954
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +1,173
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Canvas.java +2,613
Caught exception not logged +Use one of the logging methods to log the exception. Medium +AboutPanel.java +190
Caught exception not logged +Use one of the logging methods to log the exception. Medium +BuildingDetailPanel.java +159
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ChatPanel.java +111
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ColonyPanel.java +964
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ColopediaGameObjectTypePanel.java +229
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DefaultTransferHandler.java +131
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DefaultTransferHandler.java +141
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ErrorPanel.java +84
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FatherDetailPanel.java +112
Caught exception not logged +Use one of the logging methods to log the exception. Medium +MapSizeDialog.java +83
Caught exception not logged +Use one of the logging methods to log the exception. Medium +NewPanel.java +424
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ParametersDialog.java +121
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ParametersDialog.java +127
Caught exception not logged +Use one of the logging methods to log the exception. Medium +RecruitPanel.java +136
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ScaleMapSizeDialog.java +121
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ScaleMapSizeDialog.java +127
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SelectTributeAmountDialog.java +84
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ServerListPanel.java +202
Caught exception not logged +Use one of the logging methods to log the exception. Medium +StartGamePanel.java +353
Caught exception not logged +Use one of the logging methods to log the exception. Medium +UnitDetailPanel.java +187
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ScrollThread.java +83
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ScrollThread.java +89
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SwingGUI.java +353
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SwingGUI.java +359
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DebugUtils.java +213
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DebugUtils.java +242
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DebugUtils.java +269
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DebugUtils.java +395
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DebugUtils.java +595
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DebugUtils.java +957
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DebugUtils.java +1,045
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColDebugger.java +164
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColDebugger.java +172
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColDebugger.java +191
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColDebugger.java +271
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColDebugger.java +379
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColSeed.java +60
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Messages.java +226
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Messages.java +271
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Messages.java +290
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Number.java +54
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColDataFile.java +221
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColModFile.java +76
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColSavegameFile.java +90
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColXMLReader.java +306
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColXMLReader.java +327
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColXMLReader.java +348
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColXMLReader.java +387
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SimpleZippedAnimation.java +112
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Colony.java +626
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Colony.java +655
Caught exception not logged +Use one of the logging methods to log the exception. Medium +EuropeWas.java +64
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColObject.java +202
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Game.java +320
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Game.java +1,004
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Game.java +1,271
Caught exception not logged +Use one of the logging methods to log the exception. Medium +NationOptions.java +275
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Specification.java +664
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Specification.java +1,894
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Tile.java +2,577
Caught exception not logged +Use one of the logging methods to log the exception. Medium +TileImprovementStyle.java +122
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Unit.java +1,434
Caught exception not logged +Use one of the logging methods to log the exception. Medium +BuyMessage.java +98
Caught exception not logged +Use one of the logging methods to log the exception. Medium +BuyPropositionMessage.java +98
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ClaimLandMessage.java +103
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ClaimLandMessage.java +108
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ClaimLandMessage.java +127
Caught exception not logged +Use one of the logging methods to log the exception. Medium +Connection.java +321
Caught exception not logged +Use one of the logging methods to log the exception. Medium +EmigrateUnitMessage.java +86
Caught exception not logged +Use one of the logging methods to log the exception. Medium +EquipForRoleMessage.java +114
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FirstContactMessage.java +111
Caught exception not logged +Use one of the logging methods to log the exception. Medium +InciteMessage.java +143
Caught exception not logged +Use one of the logging methods to log the exception. Medium +IndianDemandMessage.java +128
Caught exception not logged +Use one of the logging methods to log the exception. Medium +LoadGoodsMessage.java +126
Caught exception not logged +Use one of the logging methods to log the exception. Medium +MonarchActionMessage.java +134
Caught exception not logged +Use one of the logging methods to log the exception. Medium +NetworkReplyObject.java +72
Caught exception not logged +Use one of the logging methods to log the exception. Medium +RearrangeColonyMessage.java +81
Caught exception not logged +Use one of the logging methods to log the exception. Medium +RearrangeColonyMessage.java +179
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ReceivingThread.java +300
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SellMessage.java +98
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SellPropositionMessage.java +97
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ServerAPI.java +182
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ServerAPI.java +523
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ServerAPI.java +979
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ServerAPI.java +1,262
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SetBuildQueueMessage.java +79
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SetBuildQueueMessage.java +123
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SetCurrentStopMessage.java +99
Caught exception not logged +Use one of the logging methods to log the exception. Medium +UnloadGoodsMessage.java +110
Caught exception not logged +Use one of the logging methods to log the exception. Medium +AudioMixerOption.java +108
Caught exception not logged +Use one of the logging methods to log the exception. Medium +ColorResource.java +99
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SoundPlayer.java +205
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SoundPlayer.java +221
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SoundPlayer.java +238
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeCol.java +793
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeCol.java +1,044
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeCol.java +1,078
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeCol.java +1,159
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeCol.java +1,193
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeCol.java +1,225
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeCol.java +1,255
Caught exception not logged +Use one of the logging methods to log the exception. Medium +MetaServer.java +79
Caught exception not logged +Use one of the logging methods to log the exception. Medium +NetworkHandler.java +128
Caught exception not logged +Use one of the logging methods to log the exception. Medium +NetworkHandler.java +155
Caught exception not logged +Use one of the logging methods to log the exception. Medium +AIInGameInputHandler.java +268
Caught exception not logged +Use one of the logging methods to log the exception. Medium +AIMain.java +262
Caught exception not logged +Use one of the logging methods to log the exception. Medium +AIUnit.java +307
Caught exception not logged +Use one of the logging methods to log the exception. Medium +TransportMission.java +1,169
Caught exception not logged +Use one of the logging methods to log the exception. Medium +InGameController.java +443
Caught exception not logged +Use one of the logging methods to log the exception. Medium +InGameController.java +493
Caught exception not logged +Use one of the logging methods to log the exception. Medium +PreGameInputHandler.java +227
Caught exception not logged +Use one of the logging methods to log the exception. Medium +UserConnectionHandler.java +190
Caught exception not logged +Use one of the logging methods to log the exception. Medium +FreeColServer.java +615
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DummyConnection.java +104
Caught exception not logged +Use one of the logging methods to log the exception. Medium +DummyConnection.java +140
Caught exception not logged +Use one of the logging methods to log the exception. Medium +GenerateDocumentation.java +143
Caught exception not logged +Use one of the logging methods to log the exception. Medium +InstallerTranslations.java +203
Caught exception not logged +Use one of the logging methods to log the exception. Medium +MapConverter.java +60
Caught exception not logged +Use one of the logging methods to log the exception. Medium +MergeTranslations.java +120
Caught exception not logged +Use one of the logging methods to log the exception. Medium +SaveGameValidator.java +76
  + +
ViolationRecommendationSeverityResourceLine
Missing inheritance check +Add an instanceof test. Medium +TileViewer.java +96
Missing inheritance check +Add an instanceof test. Medium +ColonyTradeItem.java +133
Missing inheritance check +Add an instanceof test. Medium +EquipmentType.java +201
Missing inheritance check +Add an instanceof test. Medium +GoldTradeItem.java +125
Missing identity check +Add a test for object identity. Medium +Goods.java +211
Missing inheritance check +Add an instanceof test. Medium +GoodsTradeItem.java +141
Missing inheritance check +Add an instanceof test. Medium +InciteTradeItem.java +130
Missing inheritance check +Add an instanceof test. Medium +StanceTradeItem.java +140
Missing inheritance check +Add an instanceof test. Medium +TileTypeChange.java +126
Missing inheritance check +Add an instanceof test. Medium +TradeItem.java +241
Missing identity check +Add a test for object identity. Medium +Turn.java +266
Missing inheritance check +Add an instanceof test. Medium +UnitTradeItem.java +128
Missing inheritance check +Add an instanceof test. Medium +UnitWas.java +220
Missing inheritance check +Add an instanceof test. Medium +REFAIPlayer.java +116
Missing inheritance check +Add an instanceof test. Medium +ServerGame.java +457
Missing inheritance check +Add an instanceof test. Medium +ForestMaker.java +99
  + +
ViolationRecommendationSeverityResourceLine
Missing implementation of the method hashCode() +Add the missing hashCode() method. Medium +HistoryEvent.java +261
Missing implementation of the method hashCode() +Add the missing hashCode() method. Medium +Operand.java +321
Missing implementation of the method hashCode() +Add the missing hashCode() method. Medium +ServerGame.java +457
  + +
ViolationRecommendationSeverityResourceLine
Non-synchronized method should not override a synchronized method +Make the method synchronized. Medium +FreeColCheckBoxUI.java +47
Non-synchronized method should not override a synchronized method +Make the method synchronized. Medium +FreeColRadioButtonUI.java +47
Non-synchronized method should not override a synchronized method +Make the method synchronized. Medium +VideoComponent.java +122
Non-synchronized method should not override a synchronized method +Make the method synchronized. Medium +VideoComponent.java +129
Non-synchronized method should not override a synchronized method +Make the method synchronized. Medium +OggVorbisDecoderFactory.java +195
  + +
ViolationRecommendationSeverityResourceLine
An if-statement always return true or false +Replace the if-statement with a return-statement whose return value is the expression tested in the if-statement. Medium +Playlist.java +241
An if-statement always return true or false +Replace the if-statement with a return-statement whose return value is the expression tested in the if-statement. Medium +Playlist.java +252
  +
+ + + +
+
ViolationRecommendationSeverityResourceLine
Cannot compare strings using the not equals (!=) operator +Replace the comparison with equals(). Medium +Scope.java +235
  + +
ViolationRecommendationSeverityResourceLine
Unnecessary instanceof test comparing to FreeColObject +Remove the "instanceof" test. Medium +Scope.java +182
  + +
ViolationRecommendationSeverityResourceLine
Unnecessary import: import net.sf.freecol.common.model.Location; +Delete the import. Medium +ClientOptions.java +45
Unnecessary import: import net.sf.freecol.common.FreeColException; +Delete the import. Medium +ConnectController.java +42
Unnecessary import: import net.sf.freecol.common.io.FreeColXMLReader; +Delete the import. Medium +ConnectController.java +48
Unnecessary import: import java.io.FileNotFoundException; +Delete the import. Medium +MapEditorController.java +24
Unnecessary import: import javax.xml.stream.XMLStreamException; +Delete the import. Medium +MapEditorController.java +29
Unnecessary import: import net.sf.freecol.common.FreeColException; +Delete the import. Medium +MapEditorController.java +34
Unnecessary import: import net.sf.freecol.common.io.FreeColSavegameFile; +Delete the import. Medium +MapEditorController.java +37
Unnecessary import: import net.sf.freecol.client.gui.action.ColopediaAction.PanelType; +Delete the import. Medium +ActionManager.java +27
Unnecessary import: import net.sf.freecol.client.gui.action.DisplayTileTextAction.DisplayText; +Delete the import. Medium +ActionManager.java +28
Unnecessary import: import java.awt.Image; +Delete the import. Medium +UnitImageAnimation.java +22
Unnecessary import: import javax.swing.ImageIcon; +Delete the import. Medium +UnitImageAnimation.java +25
Unnecessary import: import javax.swing.JLabel; +Delete the import. Medium +UnitImageAnimation.java +26
Unnecessary import: import net.sf.freecol.client.gui.ImageLibrary; +Delete the import. Medium +UnitImageAnimation.java +28
Unnecessary import: import net.sf.freecol.common.io.sza.AnimationEvent; +Delete the import. Medium +UnitImageAnimation.java +30
Unnecessary import: import net.sf.freecol.common.io.sza.ImageAnimationEvent; +Delete the import. Medium +UnitImageAnimation.java +31
Unnecessary import: import javax.swing.JLabel; +Delete the import. Medium +UnitMoveAnimation.java +25
Unnecessary import: import net.sf.freecol.client.gui.ImageLibrary; +Delete the import. Medium +UnitMoveAnimation.java +28
Unnecessary import: import java.lang.reflect.InvocationTargetException; +Delete the import. Medium +GUI.java +28
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +MapViewer.java +31
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +DebugMenu.java +23
Unnecessary import: import java.util.Map; +Delete the import. Medium +DebugMenu.java +26
Unnecessary import: import java.util.Map.Entry; +Delete the import. Medium +DebugMenu.java +27
Unnecessary import: import net.sf.freecol.common.model.Monarch; +Delete the import. Medium +DebugMenu.java +44
Unnecessary import: import net.sf.freecol.common.resources.ImageResource; +Delete the import. Medium +DebugMenu.java +47
Unnecessary import: import net.sf.freecol.common.resources.ResourceManager; +Delete the import. Medium +DebugMenu.java +48
Unnecessary import: import static net.sf.freecol.common.util.CollectionUtils.*; +Delete the import. Medium +DebugMenu.java +50
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +MapEditorMenuBar.java +22
Unnecessary import: import java.io.File; +Delete the import. Medium +MapEditorMenuBar.java +25
Unnecessary import: import java.io.FileNotFoundException; +Delete the import. Medium +MapEditorMenuBar.java +26
Unnecessary import: import net.sf.freecol.common.io.FreeColDirectories; +Delete the import. Medium +MapEditorMenuBar.java +37
Unnecessary import: import net.sf.freecol.common.option.FileOption; +Delete the import. Medium +MapEditorMenuBar.java +38
Unnecessary import: import net.sf.freecol.common.option.MapGeneratorOptions; +Delete the import. Medium +MapEditorMenuBar.java +39
Unnecessary import: import net.sf.freecol.common.option.OptionGroup; +Delete the import. Medium +MapEditorMenuBar.java +40
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +AudioMixerOptionUI.java +23
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +FileOptionUI.java +22
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +ListOptionUI.java +22
Unnecessary import: import net.sf.freecol.common.option.Option; +Delete the import. Medium +ListOptionUI.java +44
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +CaptureGoodsDialog.java +23
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +CompactLabourReport.java +24
Unnecessary import: import net.sf.freecol.client.gui.panel.Flag.Background; +Delete the import. Medium +ConfirmDeclarationDialog.java +46
Unnecessary import: import net.sf.freecol.client.gui.panel.Flag.Decoration; +Delete the import. Medium +ConfirmDeclarationDialog.java +47
Unnecessary import: import net.sf.freecol.client.gui.panel.Flag.UnionPosition; +Delete the import. Medium +ConfirmDeclarationDialog.java +48
Unnecessary import: import net.sf.freecol.client.gui.panel.Flag.UnionShape; +Delete the import. Medium +ConfirmDeclarationDialog.java +49
Unnecessary import: import java.util.Arrays; +Delete the import. Medium +DefaultTransferHandler.java +40
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +DifficultyDialog.java +22
Unnecessary import: import java.io.File; +Delete the import. Medium +DifficultyDialog.java +23
Unnecessary import: import java.io.BufferedInputStream; +Delete the import. Medium +ErrorPanel.java +23
Unnecessary import: import java.io.FileInputStream; +Delete the import. Medium +ErrorPanel.java +25
Unnecessary import: import net.sf.freecol.client.gui.panel.MapEditorTransformPanel.MapTransform; +Delete the import. Medium +InfoPanel.java +48
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +InformationPanel.java +24
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +LoadDialog.java +22
Unnecessary import: import net.sf.freecol.client.gui.panel.MapEditorTransformPanel.MapTransform; +Delete the import. Medium +MapControls.java +43
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +MapEditorTransformPanel.java +27
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +MapGeneratorOptionsDialog.java +24
Unnecessary import: import net.sf.freecol.common.model.Scope; +Delete the import. Medium +ModifierFormat.java +36
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +MonarchDialog.java +22
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +ParametersDialog.java +23
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +PlayersTable.java +24
Unnecessary import: import net.sf.freecol.client.gui.action.ColopediaAction.PanelType; +Delete the import. Medium +PlayersTable.java +54
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +QuickActionMenu.java +23
Unnecessary import: import net.sf.freecol.client.gui.panel.ColonyPanel.TilesPanel.ASingleTilePanel; +Delete the import. Medium +QuickActionMenu.java +47
Unnecessary import: import net.sf.freecol.client.gui.panel.UnitLabel.UnitAction; +Delete the import. Medium +QuickActionMenu.java +48
Unnecessary import: import java.util.Comparator; +Delete the import. Medium +ReportPanel.java +25
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +ReportProductionPanel.java +22
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +ReportTurnPanel.java +24
Unnecessary import: import java.util.ArrayList; +Delete the import. Medium +ResourcesDetailPanel.java +22
Unnecessary import: import net.sf.freecol.common.model.FreeColGameObjectType; +Delete the import. Medium +ResourcesDetailPanel.java +36
Unnecessary import: import net.sf.freecol.common.model.Scope; +Delete the import. Medium +ResourcesDetailPanel.java +40
Unnecessary import: import static net.sf.freecol.common.util.StringUtils.*; +Delete the import. Medium +ResourcesDetailPanel.java +42
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +SaveDialog.java +22
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +ScaleMapSizeDialog.java +24
Unnecessary import: import java.awt.event.ItemEvent; +Delete the import. Medium +SelectDestinationDialog.java +23
Unnecessary import: import javax.swing.event.ChangeEvent; +Delete the import. Medium +SelectDestinationDialog.java +42
Unnecessary import: import java.awt.datatransfer.UnsupportedFlavorException; +Delete the import. Medium +TradeRouteInputPanel.java +27
Unnecessary import: import java.util.Arrays; +Delete the import. Medium +TradeRouteInputPanel.java +34
Unnecessary import: import javax.swing.event.ListSelectionEvent; +Delete the import. Medium +TradeRoutePanel.java +39
Unnecessary import: import net.sf.freecol.common.model.StringTemplate; +Delete the import. Medium +TradeRoutePanel.java +47
Unnecessary import: import static net.sf.freecol.common.util.CollectionUtils.*; +Delete the import. Medium +UnitDetailPanel.java +53
Unnecessary import: import net.sf.freecol.common.util.RandomChoice; +Delete the import. Medium +UnitDetailPanel.java +54
Unnecessary import: import java.awt.event.HierarchyEvent; +Delete the import. Medium +FreeColOptionPaneUI.java +27
Unnecessary import: import net.sf.freecol.common.model.TileImprovement; +Delete the import. Medium +RoadPainter.java +39
Unnecessary import: import java.beans.PropertyChangeEvent; +Delete the import. Medium +SwingGUI.java +40
Unnecessary import: import java.util.Locale; +Delete the import. Medium +SwingGUI.java +44
Unnecessary import: import net.sf.freecol.common.option.LanguageOption.Language; +Delete the import. Medium +SwingGUI.java +101
Unnecessary import: import java.awt.event.ActionEvent; +Delete the import. Medium +TilePopup.java +25
Unnecessary import: import java.util.Collections; +Delete the import. Medium +TilePopup.java +26
Unnecessary import: import net.sf.freecol.client.gui.panel.ReportPanel; +Delete the import. Medium +TilePopup.java +39
Unnecessary import: import net.sf.freecol.common.debug.DebugUtils; +Delete the import. Medium +TilePopup.java +41
Unnecessary import: import net.sf.freecol.common.model.Map; +Delete the import. Medium +TilePopup.java +47
Unnecessary import: import net.sf.freecol.common.model.PathNode; +Delete the import. Medium +TilePopup.java +48
Unnecessary import: import net.sf.freecol.common.util.LogBuilder; +Delete the import. Medium +TilePopup.java +55
Unnecessary import: import javax.swing.event.ChangeEvent; +Delete the import. Medium +DebugUtils.java +33
Unnecessary import: import java.io.FileOutputStream; +Delete the import. Medium +FreeColDebugger.java +23
Unnecessary import: import java.io.PrintStream; +Delete the import. Medium +FreeColDebugger.java +25
Unnecessary import: import net.sf.freecol.common.i18n.Number.Category; +Delete the import. Medium +NumberRules.java +31
Unnecessary import: import java.io.InputStream; +Delete the import. Medium +FreeColDataFile.java +27
Unnecessary import: import java.util.Arrays; +Delete the import. Medium +FreeColDataFile.java +32
Unnecessary import: import java.util.jar.JarFile; +Delete the import. Medium +FreeColDataFile.java +38
Unnecessary import: import static net.sf.freecol.common.util.CollectionUtils.*; +Delete the import. Medium +FreeColDataFile.java +46
Unnecessary import: import java.io.FileInputStream; +Delete the import. Medium +FreeColDirectories.java +22
Unnecessary import: import java.io.FileOutputStream; +Delete the import. Medium +FreeColDirectories.java +23
Unnecessary import: import java.lang.reflect.InvocationTargetException; +Delete the import. Medium +FreeColXMLReader.java +27
Unnecessary import: import net.sf.freecol.common.io.FreeColModFile; +Delete the import. Medium +Mods.java +32
Unnecessary import: import net.sf.freecol.common.model.GoodsType; +Delete the import. Medium +AbstractGoods.java +29
Unnecessary import: import java.util.Arrays; +Delete the import. Medium +BuildableType.java +23
Unnecessary import: import java.util.stream.Collectors; +Delete the import. Medium +BuildableType.java +29
Unnecessary import: import net.sf.freecol.common.model.StringTemplate; +Delete the import. Medium +BuildableType.java +35
Unnecessary import: import net.sf.freecol.common.model.UnitLocation.NoAddReason; +Delete the import. Medium +BuildingType.java +30
Unnecessary import: import net.sf.freecol.common.model.Occupation; +Delete the import. Medium +Colony.java +40
Unnecessary import: import net.sf.freecol.common.model.Stance; +Delete the import. Medium +Colony.java +41
Unnecessary import: import net.sf.freecol.common.model.Player.NoClaimReason; +Delete the import. Medium +ColonyTile.java +31
Unnecessary import: import net.sf.freecol.common.model.Colony.ColonyChangeEvent; +Delete the import. Medium +ColonyWas.java +26
Unnecessary import: import net.sf.freecol.common.model.Stance; +Delete the import. Medium +DiplomaticTrade.java +31
Unnecessary import: import net.sf.freecol.common.model.Unit.UnitState; +Delete the import. Medium +Europe.java +33
Unnecessary import: import java.io.FileOutputStream; +Delete the import. Medium +FreeColObject.java +27
Unnecessary import: import javax.xml.parsers.ParserConfigurationException; +Delete the import. Medium +FreeColObject.java +44
Unnecessary import: import javax.xml.transform.TransformerException; +Delete the import. Medium +FreeColObject.java +48
Unnecessary import: import org.xml.sax.SAXException; +Delete the import. Medium +FreeColObject.java +65
Unnecessary import: import net.sf.freecol.common.model.NationOptions.NationState; +Delete the import. Medium +Game.java +42
Unnecessary import: import java.io.FileInputStream; +Delete the import. Medium +HighScore.java +23
Unnecessary import: import java.io.FileOutputStream; +Delete the import. Medium +HighScore.java +25
Unnecessary import: import net.sf.freecol.common.model.Stance; +Delete the import. Medium +HistoryEvent.java +27
Unnecessary import: import net.sf.freecol.common.model.Player; +Delete the import. Medium +InciteTradeItem.java +27
Unnecessary import: import java.util.Arrays; +Delete the import. Medium +LandMap.java +23
Unnecessary import: import net.sf.freecol.common.model.Direction; +Delete the import. Medium +LandMap.java +28
Unnecessary import: import net.sf.freecol.common.model.Map.Position; +Delete the import. Medium +LandMap.java +29
Unnecessary import: import net.sf.freecol.common.model.Operand.OperandType; +Delete the import. Medium +Limit.java +26
Unnecessary import: import net.sf.freecol.common.model.ModelMessage; +Delete the import. Medium +LostCityRumour.java +33
Unnecessary import: import net.sf.freecol.common.model.AbstractGoods; +Delete the import. Medium +MarketWas.java +27
Unnecessary import: import net.sf.freecol.common.model.GoodsType; +Delete the import. Medium +MarketWas.java +28
Unnecessary import: import net.sf.freecol.common.model.Market; +Delete the import. Medium +MarketWas.java +29
Unnecessary import: import net.sf.freecol.common.model.MarketData; +Delete the import. Medium +MarketWas.java +30
Unnecessary import: import net.sf.freecol.common.model.Player; +Delete the import. Medium +MarketWas.java +31
Unnecessary import: import net.sf.freecol.common.model.TransactionListener; +Delete the import. Medium +MarketWas.java +32
Unnecessary import: import net.sf.freecol.common.model.Player.PlayerType; +Delete the import. Medium +Monarch.java +35
Unnecessary import: import net.sf.freecol.common.model.Stance; +Delete the import. Medium +NationSummary.java +26
Unnecessary import: import net.sf.freecol.common.model.Direction; +Delete the import. Medium +PathNode.java +23
Unnecessary import: import net.sf.freecol.common.model.NationOptions.NationState; +Delete the import. Medium +Player.java +44
Unnecessary import: import net.sf.freecol.common.model.Modifier.ModifierType; +Delete the import. Medium +SimpleCombatModel.java +31
Unnecessary import: import net.sf.freecol.common.model.UnitTypeChange.ChangeType; +Delete the import. Medium +SimpleCombatModel.java +32
Unnecessary import: import java.io.FileInputStream; +Delete the import. Medium +Specification.java +23
Unnecessary import: import java.util.Arrays; +Delete the import. Medium +Specification.java +28
Unnecessary import: import net.sf.freecol.common.model.NationOptions.Advantages; +Delete the import. Medium +Specification.java +50
Unnecessary import: import static net.sf.freecol.common.util.StringUtils.*; +Delete the import. Medium +Specification.java +63
Unnecessary import: import net.sf.freecol.common.model.Named; +Delete the import. Medium +Stance.java +23
Unnecessary import: import net.sf.freecol.common.model.Tension; +Delete the import. Medium +Stance.java +24
Unnecessary import: import net.sf.freecol.common.model.Stance; +Delete the import. Medium +StanceTradeItem.java +27
Unnecessary import: import net.sf.freecol.common.model.Direction; +Delete the import. Medium +Tile.java +40
Unnecessary import: import net.sf.freecol.common.model.Direction; +Delete the import. Medium +TileImprovement.java +33
Unnecessary import: import net.sf.freecol.common.model.Direction; +Delete the import. Medium +TileItemContainer.java +32
Unnecessary import: import net.sf.freecol.common.model.Map.Layer; +Delete the import. Medium +TileItemContainer.java +33
Unnecessary import: import net.sf.freecol.common.model.Stance; +Delete the import. Medium +TradeItem.java +26
Unnecessary import: import net.sf.freecol.common.model.CombatModel; +Delete the import. Medium +Unit.java +39
Unnecessary import: import net.sf.freecol.common.model.Direction; +Delete the import. Medium +Unit.java +40
Unnecessary import: import net.sf.freecol.common.model.UnitTypeChange.ChangeType; +Delete the import. Medium +Unit.java +45
Unnecessary import: import net.sf.freecol.common.model.UnitTypeChange.ChangeType; +Delete the import. Medium +UnitType.java +32
Unnecessary import: import net.sf.freecol.common.model.Colony.ColonyChangeEvent; +Delete the import. Medium +UnitWas.java +26
Unnecessary import: import net.sf.freecol.common.option.UnitTypeOption.TypeSelector; +Delete the import. Medium +AbstractUnitOption.java +33
Unnecessary import: import java.beans.PropertyChangeEvent; +Delete the import. Medium +SoundPlayer.java +22
Unnecessary import: import java.lang.reflect.InvocationTargetException; +Delete the import. Medium +Introspector.java +23
Unnecessary import: import org.xml.sax.SAXException; +Delete the import. Medium +Xml.java +37
Unnecessary import: import net.sf.freecol.FreeCol; +Delete the import. Medium +MetaRegister.java +27
Unnecessary import: import net.sf.freecol.common.networking.Connection; +Delete the import. Medium +MetaRegister.java +28
Unnecessary import: import java.util.concurrent.ExecutionException; +Delete the import. Medium +InGameController.java +34
Unnecessary import: import net.sf.freecol.server.control.ChangeSet.ChangePriority; +Delete the import. Medium +InGameController.java +128
Unnecessary import: import net.sf.freecol.server.control.ChangeSet.See; +Delete the import. Medium +InGameController.java +129
Unnecessary import: import net.sf.freecol.common.networking.ChatMessage; +Delete the import. Medium +InputHandler.java +31
Unnecessary import: import java.util.logging.Level; +Delete the import. Medium +UserConnectionHandler.java +22
Unnecessary import: import java.io.FileOutputStream; +Delete the import. Medium +FreeColServer.java +24
Unnecessary import: import java.util.jar.JarOutputStream; +Delete the import. Medium +FreeColServer.java +37
Unnecessary import: import net.sf.freecol.server.model.ServerPlayer; +Delete the import. Medium +ServerColony.java +60
Unnecessary import: import java.util.Arrays; +Delete the import. Medium +ServerGame.java +24
Unnecessary import: import java.io.RandomAccessFile; +Delete the import. Medium +ColonizationSaveGameReader.java +22
Unnecessary import: import java.io.FileWriter; +Delete the import. Medium +DesktopEntry.java +25
Unnecessary import: import java.io.FileInputStream; +Delete the import. Medium +FSGConverter.java +25
Unnecessary import: import java.io.FileOutputStream; +Delete the import. Medium +FSGConverter.java +27
Unnecessary import: import java.io.BufferedReader; +Delete the import. Medium +GenerateDocumentation.java +22
Unnecessary import: import java.io.FileReader; +Delete the import. Medium +GenerateDocumentation.java +24
Unnecessary import: import java.io.FileWriter; +Delete the import. Medium +GenerateDocumentation.java +25
Unnecessary import: import java.io.BufferedReader; +Delete the import. Medium +InstallerTranslations.java +22
Unnecessary import: import java.io.FileReader; +Delete the import. Medium +InstallerTranslations.java +24
Unnecessary import: import java.io.FileWriter; +Delete the import. Medium +InstallerTranslations.java +25
Unnecessary import: import javax.xml.stream.XMLStreamException; +Delete the import. Medium +MapConverter.java +28
Unnecessary import: import net.sf.freecol.common.FreeColException; +Delete the import. Medium +MapConverter.java +31
Unnecessary import: import java.io.BufferedReader; +Delete the import. Medium +MergeTranslations.java +22
Unnecessary import: import java.io.FileReader; +Delete the import. Medium +MergeTranslations.java +25
Unnecessary import: import org.xml.sax.SAXException; +Delete the import. Medium +SaveGameValidator.java +35
  + +
ViolationRecommendationSeverityResourceLine
Unnecessary Override: installUI +Delete the unused method. Medium +FreeColListUI.java +42
Unnecessary Override: complete +Delete the unused method. Medium +LootSession.java +47
Unnecessary Override: complete +Delete the unused method. Medium +TradeSession.java +68
  + +
ViolationRecommendationSeverityResourceLine
Unnecessary return +Recommendation... Medium +EuropeanAIPlayer.java +807
Unnecessary return +Recommendation... Medium +EuropeanAIPlayer.java +818
  + +
ViolationRecommendationSeverityResourceLine
Unnecessary type cast from null to T +Delete the unnecessary cast. Medium +FreeColChoiceDialog.java +80
Unnecessary type cast from null to T +Delete the unnecessary cast. Medium +FreeColInputDialog.java +87
Unnecessary type cast from null to T +Delete the unnecessary cast. Medium +FreeColInputDialog.java +89
Unnecessary type cast from Class<> to Class<T> +Delete the unnecessary cast. Medium +Game.java +1,071
Unnecessary type cast from Unit to FreeColGameObject +Delete the unnecessary cast. Medium +DiplomacyMessage.java +89
Unnecessary type cast from Unit to FreeColGameObject +Delete the unnecessary cast. Medium +DiplomacyMessage.java +89
Unnecessary type cast from Unit to FreeColGameObject +Delete the unnecessary cast. Medium +DiplomacyMessage.java +101
Unnecessary type cast from Colony to FreeColGameObject +Delete the unnecessary cast. Medium +DiplomacyMessage.java +101
Unnecessary type cast from Colony to FreeColGameObject +Delete the unnecessary cast. Medium +DiplomacyMessage.java +113
Unnecessary type cast from Unit to FreeColGameObject +Delete the unnecessary cast. Medium +DiplomacyMessage.java +113
Unnecessary type cast from ServerPlayer to Player +Delete the unnecessary cast. Medium +DiplomacyMessage.java +285
Unnecessary type cast from AbstractOption to AbstractOption<T> +Delete the unnecessary cast. Medium +ListOption.java +275
Unnecessary type cast from AbstractOption to AbstractOption<T> +Delete the unnecessary cast. Medium +ListOption.java +281
Unnecessary type cast from TransportableAIObject to AIObject +Delete the unnecessary cast. Medium +Cargo.java +671
  + +
ViolationRecommendationSeverityResourceLine
Loop used to copy an array +Use the method arraycopy defined in java.lang.System instead. Medium +DeclarationPanel.java +185
Loop used to copy an array +Use the method arraycopy defined in java.lang.System instead. Medium +ColonizationMapReader.java +116
  + +
ViolationRecommendationSeverityResourceLine
Use charAt() rather than startsWith() +Replace with a call to charAt(). Medium +Messages.java +792
Use charAt() rather than startsWith() +Replace with a call to charAt(). Medium +Messages.java +818
Use charAt() rather than startsWith() +Replace with a call to charAt(). Medium +LanguageOption.java +213
  + +
ViolationRecommendationSeverityResourceLine
Use of instanceof with this +Distribute the conditional code to the subclasses being tested for. Medium +FreeColGameObject.java +71
Use of instanceof with this +Distribute the conditional code to the subclasses being tested for. Medium +FreeColGameObject.java +257
Use of instanceof with this +Distribute the conditional code to the subclasses being tested for. Medium +WorkLocation.java +355
Use of instanceof with this +Distribute the conditional code to the subclasses being tested for. Medium +WorkLocation.java +360
+
+
+ +
+
+ Generated at 5/13/17 12:43 PM + + Powered by CodePro Server
+
+ +
+ + + + diff --git a/reports/MetricResults1.html b/reports/MetricResults1.html new file mode 100644 index 00000000..24a3b677 --- /dev/null +++ b/reports/MetricResults1.html @@ -0,0 +1,4185 @@ + + + + + + + CodePro Metrics for A_Team-finalproject + + + + + + + + + + +
+

This document contains the results of running metrics for A_Team-finalproject at 5/13/17 2:09 PM.

+ + +
+   +
+ +
+

Global Results

+
+ +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Abstractness8.1%
Average Block Depth1.21
Average Cyclomatic Complexity2.54
Average Lines Of Code Per Method10.20
Average Number of Constructors Per Type0.96
Average Number of Fields Per Type2.50
Average Number of Methods Per Type8.07
Average Number of Parameters0.96
Comments Ratio16%
Efferent Couplings808
Lines of Code117,634
Number of Characters7,650,206
Number of Comments18,886
Number of Constructors1,070
Number of Fields4,815
Number of Lines217,219
Number of Methods8,976
Number of Packages39
Number of Semicolons59,198
Number of Types1,111
Weighted Methods25,554
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Abstractness8.1%
Average Block Depth1.21
Average Cyclomatic Complexity2.54
Average Lines Of Code Per Method10.20
Average Number of Constructors Per Type0.96
Average Number of Fields Per Type2.50
Average Number of Methods Per Type8.07
Average Number of Parameters0.96
Comments Ratio16%
Efferent Couplings808
Lines of Code117,634
Number of Characters7,650,206
Number of Comments18,886
Number of Constructors1,070
Number of Fields4,815
Number of Lines217,219
Number of Methods8,976
Number of Packages39
Number of Semicolons59,198
Number of Types1,111
Weighted Methods25,554
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code917
Number of Fields56
Average Block Depth1.57
Average Number of Constructors Per Type0.50
Efferent Couplings1
Average Number of Parameters0.70
Number of Types2
Number of Lines1,403
Number of Methods48
Average Lines Of Code Per Method16.67
Number of Constructors1
Number of Comments123
Number of Semicolons383
Abstractness0%
Weighted Methods183
Average Number of Fields Per Type13.00
Average Cyclomatic Complexity3.73
Average Number of Methods Per Type24.00
Comments Ratio13.4%
Number of Characters55,035
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code861
Number of Fields121
Average Block Depth1.12
Average Number of Constructors Per Type1.00
Efferent Couplings4
Average Number of Parameters0.62
Number of Types5
Number of Lines1,755
Number of Methods70
Average Lines Of Code Per Method7.79
Number of Constructors5
Number of Comments219
Number of Semicolons436
Abstractness0%
Weighted Methods168
Average Number of Fields Per Type4.59
Average Cyclomatic Complexity2.24
Average Number of Methods Per Type14.00
Comments Ratio25.4%
Number of Characters60,146
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code4,830
Number of Fields56
Average Block Depth1.73
Average Number of Constructors Per Type0.47
Efferent Couplings11
Average Number of Parameters1.41
Number of Types23
Number of Lines7,991
Number of Methods248
Average Lines Of Code Per Method17.51
Number of Constructors11
Number of Comments660
Number of Semicolons2,532
Abstractness8.6%
Weighted Methods1,241
Average Number of Fields Per Type2.00
Average Cyclomatic Complexity4.79
Average Number of Methods Per Type10.78
Comments Ratio13.6%
Number of Characters301,948
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code7,931
Number of Fields214
Average Block Depth1.15
Average Number of Constructors Per Type0.81
Efferent Couplings30
Average Number of Parameters1.24
Number of Types38
Number of Lines13,242
Number of Methods828
Average Lines Of Code Per Method8.36
Number of Constructors31
Number of Comments894
Number of Semicolons3,763
Abstractness5.2%
Weighted Methods1,749
Average Number of Fields Per Type4.13
Average Cyclomatic Complexity2.03
Average Number of Methods Per Type21.78
Comments Ratio11.2%
Number of Characters473,720
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,837
Number of Fields107
Average Block Depth1.09
Average Number of Constructors Per Type1.04
Efferent Couplings80
Average Number of Parameters0.62
Number of Types82
Number of Lines5,700
Number of Methods148
Average Lines Of Code Per Method5.27
Number of Constructors86
Number of Comments507
Number of Semicolons912
Abstractness4.8%
Weighted Methods359
Average Number of Fields Per Type0.28
Average Cyclomatic Complexity1.53
Average Number of Methods Per Type1.80
Comments Ratio27.5%
Number of Characters165,769
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code254
Number of Fields17
Average Block Depth0.51
Average Number of Constructors Per Type0.75
Efferent Couplings4
Average Number of Parameters1.87
Number of Types4
Number of Lines462
Number of Methods8
Average Lines Of Code Per Method17.81
Number of Constructors3
Number of Comments24
Number of Semicolons150
Abstractness0%
Weighted Methods29
Average Number of Fields Per Type4.00
Average Cyclomatic Complexity2.63
Average Number of Methods Per Type2.00
Comments Ratio9.4%
Number of Characters18,070
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code791
Number of Fields11
Average Block Depth1.17
Average Number of Constructors Per Type0.83
Efferent Couplings6
Average Number of Parameters0.53
Number of Types6
Number of Lines1,314
Number of Methods30
Average Lines Of Code Per Method18.65
Number of Constructors5
Number of Comments99
Number of Semicolons574
Abstractness16.6%
Weighted Methods45
Average Number of Fields Per Type1.00
Average Cyclomatic Complexity1.28
Average Number of Methods Per Type5.00
Comments Ratio12.5%
Number of Characters47,534
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,237
Number of Fields50
Average Block Depth0.89
Average Number of Constructors Per Type0.73
Efferent Couplings24
Average Number of Parameters0.48
Number of Types26
Number of Lines2,499
Number of Methods105
Average Lines Of Code Per Method7.60
Number of Constructors19
Number of Comments165
Number of Semicolons701
Abstractness7.6%
Weighted Methods183
Average Number of Fields Per Type1.84
Average Cyclomatic Complexity1.47
Average Number of Methods Per Type4.03
Comments Ratio13.3%
Number of Characters77,482
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code21,723
Number of Fields849
Average Block Depth1.12
Average Number of Constructors Per Type0.82
Efferent Couplings214
Average Number of Parameters0.94
Number of Types273
Number of Lines34,838
Number of Methods1,026
Average Lines Of Code Per Method14.25
Number of Constructors225
Number of Comments2,189
Number of Semicolons12,432
Abstractness5.1%
Weighted Methods3,487
Average Number of Fields Per Type2.36
Average Cyclomatic Complexity2.78
Average Number of Methods Per Type3.75
Comments Ratio10%
Number of Characters1,271,062
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code976
Number of Fields27
Average Block Depth1.22
Average Number of Constructors Per Type0.44
Efferent Couplings26
Average Number of Parameters1.14
Number of Types27
Number of Lines1,937
Number of Methods81
Average Lines Of Code Per Method7.63
Number of Constructors12
Number of Comments84
Number of Semicolons538
Abstractness0%
Weighted Methods171
Average Number of Fields Per Type0.40
Average Cyclomatic Complexity1.83
Average Number of Methods Per Type3.00
Comments Ratio8.6%
Number of Characters63,582
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code70
Number of Fields2
Average Block Depth0.88
Average Number of Constructors Per Type0.50
Efferent Couplings1
Average Number of Parameters0.28
Number of Types2
Number of Lines212
Number of Methods7
Average Lines Of Code Per Method6.62
Number of Constructors1
Number of Comments57
Number of Semicolons45
Abstractness50%
Weighted Methods10
Average Number of Fields Per Type0.50
Average Cyclomatic Complexity1.25
Average Number of Methods Per Type3.50
Comments Ratio81.4%
Number of Characters6,442
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code25
Number of Fields1
Average Block Depth1.25
Average Number of Constructors Per Type1.00
Efferent Couplings1
Average Number of Parameters1.00
Number of Types1
Number of Lines55
Number of Methods2
Average Lines Of Code Per Method5.66
Number of Constructors1
Number of Comments2
Number of Semicolons11
Abstractness0%
Weighted Methods6
Average Number of Fields Per Type1.00
Average Cyclomatic Complexity2.00
Average Number of Methods Per Type2.00
Comments Ratio8%
Number of Characters1,655
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code127
Number of Fields11
Average Block Depth0.76
Average Number of Constructors Per Type1.25
Efferent Couplings4
Average Number of Parameters0.76
Number of Types4
Number of Lines392
Number of Methods17
Average Lines Of Code Per Method4.50
Number of Constructors5
Number of Comments30
Number of Semicolons60
Abstractness25%
Weighted Methods24
Average Number of Fields Per Type2.25
Average Cyclomatic Complexity1.09
Average Number of Methods Per Type4.25
Comments Ratio23.6%
Number of Characters12,305
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,004
Number of Fields15
Average Block Depth1.74
Average Number of Constructors Per Type0.00
Efferent Couplings2
Average Number of Parameters1.14
Number of Types3
Number of Lines1,585
Number of Methods55
Average Lines Of Code Per Method16.58
Number of Comments99
Number of Semicolons541
Abstractness0%
Weighted Methods160
Average Number of Fields Per Type4.33
Average Cyclomatic Complexity2.90
Average Number of Methods Per Type18.33
Comments Ratio9.8%
Number of Characters61,592
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,289
Number of Fields59
Average Block Depth1.87
Average Number of Constructors Per Type0.30
Efferent Couplings12
Average Number of Parameters1.17
Number of Types13
Number of Lines2,308
Number of Methods87
Average Lines Of Code Per Method12.47
Number of Constructors4
Number of Comments155
Number of Semicolons560
Abstractness15.3%
Weighted Methods276
Average Number of Fields Per Type1.38
Average Cyclomatic Complexity3.03
Average Number of Methods Per Type6.69
Comments Ratio12%
Number of Characters83,571
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,545
Number of Fields75
Average Block Depth1.41
Average Number of Constructors Per Type1.00
Efferent Couplings8
Average Number of Parameters1.05
Number of Types10
Number of Lines3,125
Number of Methods157
Average Lines Of Code Per Method7.91
Number of Constructors10
Number of Comments233
Number of Semicolons738
Abstractness0%
Weighted Methods382
Average Number of Fields Per Type2.79
Average Cyclomatic Complexity2.28
Average Number of Methods Per Type15.69
Comments Ratio15%
Number of Characters108,822
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code149
Number of Fields7
Average Block Depth0.94
Average Number of Constructors Per Type1.00
Efferent Couplings3
Average Number of Parameters0.22
Number of Types5
Number of Lines299
Number of Methods9
Average Lines Of Code Per Method7.85
Number of Constructors5
Number of Comments15
Number of Semicolons82
Abstractness40%
Weighted Methods25
Average Number of Fields Per Type1.00
Average Cyclomatic Complexity1.78
Average Number of Methods Per Type1.80
Comments Ratio10%
Number of Characters10,350
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code139
Number of Fields2
Average Block Depth1.50
Average Number of Constructors Per Type1.00
Efferent Couplings2
Average Number of Parameters0.50
Number of Types2
Number of Lines239
Number of Methods4
Average Lines Of Code Per Method19.16
Number of Constructors2
Number of Comments13
Number of Semicolons55
Abstractness0%
Weighted Methods21
Average Number of Fields Per Type1.00
Average Cyclomatic Complexity3.50
Average Number of Methods Per Type2.00
Comments Ratio9.3%
Number of Characters8,043
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code29,732
Number of Fields1,952
Average Block Depth1.15
Average Number of Constructors Per Type1.24
Efferent Couplings118
Average Number of Parameters0.71
Number of Types186
Number of Lines61,845
Number of Methods3,239
Average Lines Of Code Per Method7.53
Number of Constructors232
Number of Comments6,650
Number of Semicolons13,486
Abstractness13.9%
Weighted Methods7,685
Average Number of Fields Per Type5.31
Average Cyclomatic Complexity2.21
Average Number of Methods Per Type17.41
Comments Ratio22.3%
Number of Characters2,042,015
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code368
Number of Fields21
Average Block Depth0.92
Average Number of Constructors Per Type2.28
Efferent Couplings6
Average Number of Parameters0.53
Number of Types7
Number of Lines1,037
Number of Methods47
Average Lines Of Code Per Method4.30
Number of Constructors16
Number of Comments97
Number of Semicolons172
Abstractness28.5%
Weighted Methods80
Average Number of Fields Per Type1.71
Average Cyclomatic Complexity1.26
Average Number of Methods Per Type6.71
Comments Ratio26.3%
Number of Characters29,276
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code631
Number of Fields32
Average Block Depth1.08
Average Number of Constructors Per Type0.04
Efferent Couplings10
Average Number of Parameters0.90
Number of Types25
Number of Lines1,145
Number of Methods80
Average Lines Of Code Per Method10.17
Number of Constructors1
Number of Comments66
Number of Semicolons284
Abstractness8%
Weighted Methods205
Average Number of Fields Per Type1.00
Average Cyclomatic Complexity2.53
Average Number of Methods Per Type3.20
Comments Ratio10.4%
Number of Characters42,229
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code5,954
Number of Fields218
Average Block Depth0.99
Average Number of Constructors Per Type1.91
Efferent Couplings75
Average Number of Parameters1.05
Number of Types79
Number of Lines13,331
Number of Methods444
Average Lines Of Code Per Method8.20
Number of Constructors151
Number of Comments1,046
Number of Semicolons2,963
Abstractness6.3%
Weighted Methods1,152
Average Number of Fields Per Type2.41
Average Cyclomatic Complexity1.93
Average Number of Methods Per Type5.62
Comments Ratio17.5%
Number of Characters451,410
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,930
Number of Fields113
Average Block Depth1.11
Average Number of Constructors Per Type1.47
Efferent Couplings22
Average Number of Parameters0.50
Number of Types23
Number of Lines4,365
Number of Methods228
Average Lines Of Code Per Method5.94
Number of Constructors34
Number of Comments444
Number of Semicolons903
Abstractness13%
Weighted Methods432
Average Number of Fields Per Type1.69
Average Cyclomatic Complexity1.64
Average Number of Methods Per Type9.91
Comments Ratio23%
Number of Characters125,456
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,261
Number of Fields59
Average Block Depth1.13
Average Number of Constructors Per Type0.86
Efferent Couplings17
Average Number of Parameters0.92
Number of Types22
Number of Lines2,433
Number of Methods113
Average Lines Of Code Per Method8.19
Number of Constructors19
Number of Comments142
Number of Semicolons679
Abstractness18.1%
Weighted Methods292
Average Number of Fields Per Type1.77
Average Cyclomatic Complexity2.11
Average Number of Methods Per Type5.13
Comments Ratio11.2%
Number of Characters82,380
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code657
Number of Fields38
Average Block Depth1.08
Average Number of Constructors Per Type1.16
Efferent Couplings5
Average Number of Parameters0.52
Number of Types6
Number of Lines1,045
Number of Methods46
Average Lines Of Code Per Method10.73
Number of Constructors7
Number of Comments103
Number of Semicolons334
Abstractness0%
Weighted Methods155
Average Number of Fields Per Type4.50
Average Cyclomatic Complexity2.92
Average Number of Methods Per Type7.66
Comments Ratio15.6%
Number of Characters35,011
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,024
Number of Fields20
Average Block Depth1.45
Average Number of Constructors Per Type0.41
Efferent Couplings10
Average Number of Parameters1.80
Number of Types12
Number of Lines1,890
Number of Methods110
Average Lines Of Code Per Method8.42
Number of Constructors5
Number of Comments95
Number of Semicolons481
Abstractness8.3%
Weighted Methods267
Average Number of Fields Per Type0.83
Average Cyclomatic Complexity2.32
Average Number of Methods Per Type9.16
Comments Ratio9.2%
Number of Characters66,036
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code300
Number of Fields15
Average Block Depth1.21
Average Number of Constructors Per Type0.60
Efferent Couplings4
Average Number of Parameters2.16
Number of Types5
Number of Lines697
Number of Methods25
Average Lines Of Code Per Method9.03
Number of Constructors3
Number of Comments40
Number of Semicolons164
Abstractness0%
Weighted Methods53
Average Number of Fields Per Type1.80
Average Cyclomatic Complexity1.89
Average Number of Methods Per Type5.00
Comments Ratio13.3%
Number of Characters24,762
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code678
Number of Fields32
Average Block Depth1.21
Average Number of Constructors Per Type0.66
Efferent Couplings1
Average Number of Parameters0.72
Number of Types3
Number of Lines1,287
Number of Methods51
Average Lines Of Code Per Method10.92
Number of Constructors2
Number of Comments124
Number of Semicolons376
Abstractness0%
Weighted Methods117
Average Number of Fields Per Type6.33
Average Cyclomatic Complexity2.20
Average Number of Methods Per Type17.00
Comments Ratio18.2%
Number of Characters46,370
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code8,845
Number of Fields229
Average Block Depth1.41
Average Number of Constructors Per Type1.20
Efferent Couplings26
Average Number of Parameters1.03
Number of Types48
Number of Lines15,182
Number of Methods552
Average Lines Of Code Per Method13.20
Number of Constructors58
Number of Comments1,447
Number of Semicolons4,504
Abstractness10.4%
Weighted Methods2,231
Average Number of Fields Per Type2.56
Average Cyclomatic Complexity3.65
Average Number of Methods Per Type11.50
Comments Ratio16.3%
Number of Characters560,690
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code549
Number of Fields15
Average Block Depth1.45
Average Number of Constructors Per Type1.00
Efferent Couplings4
Average Number of Parameters0.46
Number of Types5
Number of Lines1,249
Number of Methods49
Average Lines Of Code Per Method8.77
Number of Constructors5
Number of Comments162
Number of Semicolons270
Abstractness40%
Weighted Methods136
Average Number of Fields Per Type2.00
Average Cyclomatic Complexity2.51
Average Number of Methods Per Type9.80
Comments Ratio29.5%
Number of Characters47,159
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code4,825
Number of Fields108
Average Block Depth1.27
Average Number of Constructors Per Type1.30
Efferent Couplings17
Average Number of Parameters0.97
Number of Types26
Number of Lines8,983
Number of Methods406
Average Lines Of Code Per Method10.17
Number of Constructors34
Number of Comments839
Number of Semicolons2,292
Abstractness3.8%
Weighted Methods1,438
Average Number of Fields Per Type1.61
Average Cyclomatic Complexity3.26
Average Number of Methods Per Type15.61
Comments Ratio17.3%
Number of Characters315,873
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code5,012
Number of Fields67
Average Block Depth1.35
Average Number of Constructors Per Type0.31
Efferent Couplings27
Average Number of Parameters2.15
Number of Types85
Number of Lines8,001
Number of Methods292
Average Lines Of Code Per Method15.50
Number of Constructors27
Number of Comments732
Number of Semicolons2,429
Abstractness4.7%
Weighted Methods843
Average Number of Fields Per Type0.65
Average Cyclomatic Complexity2.64
Average Number of Methods Per Type3.43
Comments Ratio14.6%
Number of Characters333,599
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code2,099
Number of Fields48
Average Block Depth1.61
Average Number of Constructors Per Type0.75
Efferent Couplings10
Average Number of Parameters1.58
Number of Types12
Number of Lines3,174
Number of Methods70
Average Lines Of Code Per Method23.46
Number of Constructors9
Number of Comments247
Number of Semicolons1,198
Abstractness25%
Weighted Methods396
Average Number of Fields Per Type2.83
Average Cyclomatic Complexity5.01
Average Number of Methods Per Type5.83
Comments Ratio11.7%
Number of Characters126,219
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code6,155
Number of Fields56
Average Block Depth1.81
Average Number of Constructors Per Type2.06
Efferent Couplings15
Average Number of Parameters1.74
Number of Types15
Number of Lines9,226
Number of Methods222
Average Lines Of Code Per Method22.60
Number of Constructors31
Number of Comments908
Number of Semicolons3,082
Abstractness13.3%
Weighted Methods1,271
Average Number of Fields Per Type1.73
Average Cyclomatic Complexity5.02
Average Number of Methods Per Type14.80
Comments Ratio14.7%
Number of Characters385,653
+
+ +   + +
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code175
Number of Fields11
Average Block Depth1.06
Average Number of Constructors Per Type1.00
Efferent Couplings2
Average Number of Parameters0.68
Number of Types2
Number of Lines430
Number of Methods19
Average Lines Of Code Per Method6.66
Number of Constructors2
Number of Comments49
Number of Semicolons83
Abstractness0%
Weighted Methods33
Average Number of Fields Per Type4.50
Average Cyclomatic Complexity1.57
Average Number of Methods Per Type9.50
Comments Ratio28%
Number of Characters14,006
+
+ +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Lines of Code1,734
Number of Fields101
Average Block Depth1.49
Average Number of Constructors Per Type0.33
Efferent Couplings18
Average Number of Parameters1.07
Number of Types24
Number of Lines2,543
Number of Methods53
Average Lines Of Code Per Method21.19
Number of Constructors8
Number of Comments127
Number of Semicolons985
Abstractness0%
Weighted Methods249
Average Number of Fields Per Type1.83
Average Cyclomatic Complexity3.71
Average Number of Methods Per Type2.20
Comments Ratio7.3%
Number of Characters94,934
+
+
   + +   +
+ + + +
+
+ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
Metric NameValue
Efferent Couplings for net.sf.freecol.client.gui30
    Exceeds the maximum value of 20 +
Number of Types for net.sf.freecol.client.gui38
    Exceeds the maximum value of 30 +
Efferent Couplings for net.sf.freecol.client.gui.action80
    Exceeds the maximum value of 20 +
Number of Types for net.sf.freecol.client.gui.action82
    Exceeds the maximum value of 30 +
Efferent Couplings for net.sf.freecol.client.gui.option24
    Exceeds the maximum value of 20 +
Efferent Couplings for net.sf.freecol.client.gui.panel214
    Exceeds the maximum value of 20 +
Number of Types for net.sf.freecol.client.gui.panel273
    Exceeds the maximum value of 30 +
Efferent Couplings for net.sf.freecol.client.gui.plaf26
    Exceeds the maximum value of 20 +
Efferent Couplings for net.sf.freecol.common.model118
    Exceeds the maximum value of 20 +
Number of Types for net.sf.freecol.common.model186
    Exceeds the maximum value of 30 +
Efferent Couplings for net.sf.freecol.common.networking75
    Exceeds the maximum value of 20 +
Number of Types for net.sf.freecol.common.networking79
    Exceeds the maximum value of 30 +
Efferent Couplings for net.sf.freecol.common.option22
    Exceeds the maximum value of 20 +
Efferent Couplings for net.sf.freecol.server.ai26
    Exceeds the maximum value of 20 +
Number of Types for net.sf.freecol.server.ai48
    Exceeds the maximum value of 30 +
Efferent Couplings for net.sf.freecol.server.control27
    Exceeds the maximum value of 20 +
Number of Types for net.sf.freecol.server.control85
    Exceeds the maximum value of 30 +
+
+
+
+ +
+
+ Generated at 5/13/17 2:09 PM + + Powered by CodePro Server
+
+ +
+ + + + diff --git a/reports/pmd-report.txt b/reports/pmd-report.txt new file mode 100644 index 00000000..d4059b56 --- /dev/null +++ b/reports/pmd-report.txt @@ -0,0 +1,56097 @@ +src/net/sf/freecol/FreeCol.java:1: Comment is too large: Too many lines +src/net/sf/freecol/FreeCol.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/FreeCol.java:20: Possible God class (WMC=180, ATFD=107, TCC=0.04040404040404041) +src/net/sf/freecol/FreeCol.java:75: Avoid really long classes. +src/net/sf/freecol/FreeCol.java:75: Class contains more than one logger. +src/net/sf/freecol/FreeCol.java:75: The class 'FreeCol' has a Cyclomatic Complexity of 4 (Highest = 60). +src/net/sf/freecol/FreeCol.java:75: The class 'FreeCol' has a Modified Cyclomatic Complexity of 4 (Highest = 58). +src/net/sf/freecol/FreeCol.java:75: The class 'FreeCol' has a Standard Cyclomatic Complexity of 4 (Highest = 58). +src/net/sf/freecol/FreeCol.java:75: This class has too many methods, consider refactoring it. +src/net/sf/freecol/FreeCol.java:75: Too many fields +src/net/sf/freecol/FreeCol.java:77: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/FreeCol.java:77: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:88: Avoid excessively long variable names like FREECOL_SAVE_EXTENSION +src/net/sf/freecol/FreeCol.java:97: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:98: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:99: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:101: Avoid excessively long variable names like META_SERVER_ADDRESS +src/net/sf/freecol/FreeCol.java:101: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:102: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:105: Avoid using redundant field initializer for 'freeColRevision' +src/net/sf/freecol/FreeCol.java:108: Avoid using redundant field initializer for 'locale' +src/net/sf/freecol/FreeCol.java:112: Avoid excessively long variable names like ADVANTAGES_DEFAULT +src/net/sf/freecol/FreeCol.java:112: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:113: Avoid excessively long variable names like DIFFICULTY_DEFAULT +src/net/sf/freecol/FreeCol.java:113: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:114: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:115: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:116: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:117: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:118: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:119: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:120: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:121: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:122: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:123: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:124: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:125: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:126: Avoid excessively long variable names like GUI_SCALE_STEP_PCT +src/net/sf/freecol/FreeCol.java:126: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:127: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:128: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:129: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:130: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:135: Avoid using redundant field initializer for 'checkIntegrity' +src/net/sf/freecol/FreeCol.java:135: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:136: Avoid using redundant field initializer for 'consoleLogging' +src/net/sf/freecol/FreeCol.java:137: Avoid using redundant field initializer for 'debugStart' +src/net/sf/freecol/FreeCol.java:138: Avoid using redundant field initializer for 'fastStart' +src/net/sf/freecol/FreeCol.java:139: Avoid using redundant field initializer for 'headless' +src/net/sf/freecol/FreeCol.java:145: Avoid using redundant field initializer for 'standAloneServer' +src/net/sf/freecol/FreeCol.java:148: Avoid using redundant field initializer for 'advantages' +src/net/sf/freecol/FreeCol.java:151: Avoid using redundant field initializer for 'difficulty' +src/net/sf/freecol/FreeCol.java:157: Avoid using redundant field initializer for 'fontName' +src/net/sf/freecol/FreeCol.java:163: Avoid using redundant field initializer for 'name' +src/net/sf/freecol/FreeCol.java:167: Avoid using redundant field initializer for 'serverName' +src/net/sf/freecol/FreeCol.java:167: fieldCommentRequirement Required +src/net/sf/freecol/FreeCol.java:173: Avoid using redundant field initializer for 'tc' +src/net/sf/freecol/FreeCol.java:173: Avoid variables with short names like tc +src/net/sf/freecol/FreeCol.java:195: Avoid really long methods. +src/net/sf/freecol/FreeCol.java:195: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/FreeCol.java:195: Found 'UR'-anomaly for variable 'handler' (lines '195'-'271'). +src/net/sf/freecol/FreeCol.java:195: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:195: The method 'main' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/FreeCol.java:195: The method 'main' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/FreeCol.java:195: The method 'main' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/FreeCol.java:195: The method main() has an NPath complexity of 60480 +src/net/sf/freecol/FreeCol.java:199: Found 'DD'-anomaly for variable 'juc' (lines '199'-'201'). +src/net/sf/freecol/FreeCol.java:201: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/FreeCol.java:202: System.err.println is used +src/net/sf/freecol/FreeCol.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:207: Local variable 'revision' could be declared final +src/net/sf/freecol/FreeCol.java:211: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/FreeCol.java:212: System.err.println is used +src/net/sf/freecol/FreeCol.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:217: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/FreeCol.java:218: System.err.println is used +src/net/sf/freecol/FreeCol.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:230: Local variable 'dataDirectoryArg' could be declared final +src/net/sf/freecol/FreeCol.java:231: Local variable 'err' could be declared final +src/net/sf/freecol/FreeCol.java:232: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:240: Local variable 'index' could be declared final +src/net/sf/freecol/FreeCol.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:241: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:265: Local variable 'userMsg' could be declared final +src/net/sf/freecol/FreeCol.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:270: Local variable 'handler' could be declared final +src/net/sf/freecol/FreeCol.java:271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:273: Local variable 'logFile' could be declared final +src/net/sf/freecol/FreeCol.java:276: Local variable 'freecolLogger' could be declared final +src/net/sf/freecol/FreeCol.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:279: System.err.println is used +src/net/sf/freecol/FreeCol.java:280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:281: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/FreeCol.java:281: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:283: Avoid variables with short names like e +src/net/sf/freecol/FreeCol.java:283: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/FreeCol.java:284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:284: There is log block not surrounded by if +src/net/sf/freecol/FreeCol.java:295: Local variable 'clientLanguage' could be declared final +src/net/sf/freecol/FreeCol.java:297: Avoid assignments in operands +src/net/sf/freecol/FreeCol.java:297: Found 'DU'-anomaly for variable 'clientLocale' (lines '297'-'321'). +src/net/sf/freecol/FreeCol.java:298: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/FreeCol.java:302: There is log block not surrounded by if +src/net/sf/freecol/FreeCol.java:302: There is log block not surrounded by if +src/net/sf/freecol/FreeCol.java:312: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:313: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:313: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:329: Avoid variables with short names like c +src/net/sf/freecol/FreeCol.java:329: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:330: Local variable 'resourceName' could be declared final +src/net/sf/freecol/FreeCol.java:330: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:331: Local variable 'url' could be declared final +src/net/sf/freecol/FreeCol.java:332: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:341: Parameter 'juc' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:342: Avoid variables with short names like mf +src/net/sf/freecol/FreeCol.java:342: Local variable 'mf' could be declared final +src/net/sf/freecol/FreeCol.java:343: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/FreeCol.java:344: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:347: Comment is too large: Too many lines +src/net/sf/freecol/FreeCol.java:356: Parameter 'juc' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:357: Avoid variables with short names like jf +src/net/sf/freecol/FreeCol.java:357: Local variable 'jf' could be declared final +src/net/sf/freecol/FreeCol.java:358: Avoid variables with short names like ze +src/net/sf/freecol/FreeCol.java:358: Local variable 'ze' could be declared final +src/net/sf/freecol/FreeCol.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:359: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:367: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:376: Avoid reassigning parameters such as 'err' +src/net/sf/freecol/FreeCol.java:381: System.err.println is used +src/net/sf/freecol/FreeCol.java:382: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/FreeCol.java:390: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:391: System.err.println is used +src/net/sf/freecol/FreeCol.java:399: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:400: System.err.println is used +src/net/sf/freecol/FreeCol.java:411: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/FreeCol.java:411: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:411: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:413: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:414: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/FreeCol.java:426: Avoid really long methods. +src/net/sf/freecol/FreeCol.java:426: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/FreeCol.java:426: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:426: The method 'handleArgs' has a Cyclomatic Complexity of 60. +src/net/sf/freecol/FreeCol.java:426: The method 'handleArgs' has a Modified Cyclomatic Complexity of 58. +src/net/sf/freecol/FreeCol.java:426: The method 'handleArgs' has a Standard Cyclomatic Complexity of 58. +src/net/sf/freecol/FreeCol.java:426: The method handleArgs() has an NCSS line count of 175 +src/net/sf/freecol/FreeCol.java:426: The method handleArgs() has an NPath complexity of 1241513986 +src/net/sf/freecol/FreeCol.java:427: Local variable 'options' could be declared final +src/net/sf/freecol/FreeCol.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:453: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:465: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:470: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:471: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:471: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:477: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:482: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:485: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:498: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:503: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:506: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:507: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:507: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:513: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:516: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:526: The String literal "cli.arg.name" appears 4 times in this file; the first occurrence is on line 526 +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:529: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:529: The String literal "log-level" appears 4 times in this file; the first occurrence is on line 529 +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:534: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:539: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:539: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:539: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:539: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:539: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:542: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:542: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:542: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:542: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:545: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:545: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:545: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:545: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:548: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:551: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:551: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:551: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:551: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:554: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:554: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:554: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:554: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:554: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:562: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:562: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:562: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:562: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:562: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:570: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:575: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:580: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:590: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:596: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:608: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:608: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:608: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:608: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:608: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:611: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:617: Local variable 'parser' could be declared final +src/net/sf/freecol/FreeCol.java:618: Found 'DD'-anomaly for variable 'usageError' (lines '618'-'851'). +src/net/sf/freecol/FreeCol.java:620: Local variable 'line' could be declared final +src/net/sf/freecol/FreeCol.java:620: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:621: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:621: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:626: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/FreeCol.java:626: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/FreeCol.java:628: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:629: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/FreeCol.java:629: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/FreeCol.java:632: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:633: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:633: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:634: Avoid variables with short names like a +src/net/sf/freecol/FreeCol.java:634: Local variable 'a' could be declared final +src/net/sf/freecol/FreeCol.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:642: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:643: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:643: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:645: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:645: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:646: The String literal "%string%" appears 8 times in this file; the first occurrence is on line 646 +src/net/sf/freecol/FreeCol.java:652: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:653: Local variable 'fileName' could be declared final +src/net/sf/freecol/FreeCol.java:653: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:656: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:656: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:661: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:663: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:666: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/FreeCol.java:669: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:669: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:673: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:673: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:675: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:677: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:679: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:684: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:685: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:685: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:686: Local variable 'difficulty' could be declared final +src/net/sf/freecol/FreeCol.java:688: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:688: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:688: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:688: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:694: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:695: Avoid variables with short names like e +src/net/sf/freecol/FreeCol.java:695: Local variable 'e' could be declared final +src/net/sf/freecol/FreeCol.java:695: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:697: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:697: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:702: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:708: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:711: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:712: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/FreeCol.java:715: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:716: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:716: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:718: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:718: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:718: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:718: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:724: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:728: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:729: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:729: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:731: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:731: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:736: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:739: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:740: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:743: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:746: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:747: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:750: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:753: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:756: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:759: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:762: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:763: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/FreeCol.java:766: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:773: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:774: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:776: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:777: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:777: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:779: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:779: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:784: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:785: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:788: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:789: Local variable 'splash' could be declared final +src/net/sf/freecol/FreeCol.java:789: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:791: Local variable 'fis' could be declared final +src/net/sf/freecol/FreeCol.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:799: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:800: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:803: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:804: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:804: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:806: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:806: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:806: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:806: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:812: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:813: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:814: Local variable 'errMsg' could be declared final +src/net/sf/freecol/FreeCol.java:816: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:816: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:821: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:822: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:822: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:823: Local variable 'errMsg' could be declared final +src/net/sf/freecol/FreeCol.java:825: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:825: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:831: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:831: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:832: Local variable 'errMsg' could be declared final +src/net/sf/freecol/FreeCol.java:834: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:834: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:839: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:840: System.out.println is used +src/net/sf/freecol/FreeCol.java:841: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/FreeCol.java:844: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:845: Local variable 'arg' could be declared final +src/net/sf/freecol/FreeCol.java:845: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:850: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:850: System.err.println is used +src/net/sf/freecol/FreeCol.java:853: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:862: Parameter 'options' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:862: Parameter 'status' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:863: Local variable 'formatter' could be declared final +src/net/sf/freecol/FreeCol.java:866: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/FreeCol.java:877: Parameter 'tcf' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:878: Parameter 'advantages' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:879: Parameter 'difficulty' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:880: Found 'DD'-anomaly for variable 'spec' (lines '880'-'882'). +src/net/sf/freecol/FreeCol.java:882: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:884: System.err.println is used +src/net/sf/freecol/FreeCol.java:885: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:887: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:897: Local variable 'spec' could be declared final +src/net/sf/freecol/FreeCol.java:900: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:900: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:927: Parameter 'advantages' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:928: Local variable 'adv' could be declared final +src/net/sf/freecol/FreeCol.java:928: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:929: Avoid variables with short names like a +src/net/sf/freecol/FreeCol.java:929: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:929: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:930: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:939: Parameter 'advantages' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:949: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:949: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:950: Avoid variables with short names like a +src/net/sf/freecol/FreeCol.java:968: Parameter 'arg' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:969: Avoid variables with short names like d +src/net/sf/freecol/FreeCol.java:969: Local variable 'difficulty' could be declared final +src/net/sf/freecol/FreeCol.java:969: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:970: Avoid variables with short names like k +src/net/sf/freecol/FreeCol.java:970: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:970: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:971: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:981: Parameter 'difficulty' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:990: Parameter 'difficulty' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1000: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1000: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1001: Avoid variables with short names like d +src/net/sf/freecol/FreeCol.java:1017: Avoid variables with short names like n +src/net/sf/freecol/FreeCol.java:1017: Parameter 'n' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1027: Parameter 'arg' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1028: Found 'DD'-anomaly for variable 'valid' (lines '1,028'-'1,035'). +src/net/sf/freecol/FreeCol.java:1028: Found 'DD'-anomaly for variable 'valid' (lines '1,028'-'1,038'). +src/net/sf/freecol/FreeCol.java:1028: Found 'DD'-anomaly for variable 'valid' (lines '1,028'-'1,041'). +src/net/sf/freecol/FreeCol.java:1028: Found 'DD'-anomaly for variable 'valid' (lines '1,028'-'1,045'). +src/net/sf/freecol/FreeCol.java:1033: Avoid variables with short names like n +src/net/sf/freecol/FreeCol.java:1035: Found 'DD'-anomaly for variable 'valid' (lines '1,035'-'1,045'). +src/net/sf/freecol/FreeCol.java:1038: Found 'DD'-anomaly for variable 'valid' (lines '1,038'-'1,045'). +src/net/sf/freecol/FreeCol.java:1041: Found 'DD'-anomaly for variable 'valid' (lines '1,041'-'1,045'). +src/net/sf/freecol/FreeCol.java:1059: Avoid using for statements without curly braces +src/net/sf/freecol/FreeCol.java:1060: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/FreeCol.java:1061: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/FreeCol.java:1071: Parameter 'arg' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1073: Avoid variables with short names like n +src/net/sf/freecol/FreeCol.java:1073: Local variable 'n' could be declared final +src/net/sf/freecol/FreeCol.java:1076: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/FreeCol.java:1078: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1078: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1087: Parameter 'arg' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1088: When doing a String.toLowerCase()/toUpperCase() call, use a Locale +src/net/sf/freecol/FreeCol.java:1098: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/FreeCol.java:1108: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1110: There is log block not surrounded by if +src/net/sf/freecol/FreeCol.java:1110: There is log block not surrounded by if +src/net/sf/freecol/FreeCol.java:1137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1146: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1146: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1155: Parameter 'arg' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1156: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/FreeCol.java:1156: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:1160: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/FreeCol.java:1181: Avoid variables with short names like tc +src/net/sf/freecol/FreeCol.java:1181: Parameter 'tc' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1192: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/FreeCol.java:1193: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1193: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1197: Comment is too large: Too many lines +src/net/sf/freecol/FreeCol.java:1206: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1207: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1207: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1218: Parameter 'timeout' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1220: Local variable 'result' could be declared final +src/net/sf/freecol/FreeCol.java:1223: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/FreeCol.java:1225: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1225: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1247: Parameter 'arg' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1248: Avoid variables with short names like xy +src/net/sf/freecol/FreeCol.java:1249: Avoid assignments in operands +src/net/sf/freecol/FreeCol.java:1253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1255: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1255: Avoid empty catch blocks +src/net/sf/freecol/FreeCol.java:1257: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:1257: Singleton is not thread safe +src/net/sf/freecol/FreeCol.java:1267: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1278: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1279: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1290: The method getConfiguration() has an NPath complexity of 15625 +src/net/sf/freecol/FreeCol.java:1291: Local variable 'autosave' could be declared final +src/net/sf/freecol/FreeCol.java:1292: Local variable 'clientOptionsFile' could be declared final +src/net/sf/freecol/FreeCol.java:1293: Local variable 'save' could be declared final +src/net/sf/freecol/FreeCol.java:1294: Local variable 'userConfig' could be declared final +src/net/sf/freecol/FreeCol.java:1295: Local variable 'userData' could be declared final +src/net/sf/freecol/FreeCol.java:1296: Local variable 'userMods' could be declared final +src/net/sf/freecol/FreeCol.java:1297: Avoid variables with short names like sb +src/net/sf/freecol/FreeCol.java:1297: Local variable 'sb' could be declared final +src/net/sf/freecol/FreeCol.java:1298: StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. +src/net/sf/freecol/FreeCol.java:1304: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/FreeCol.java:1306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:1306: The String literal "NONE" appears 6 times in this file; the first occurrence is on line 1,306 +src/net/sf/freecol/FreeCol.java:1308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:1310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:1315: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:1317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:1319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/FreeCol.java:1331: Parameter 'userMsg' is not assigned and could be declared final +src/net/sf/freecol/FreeCol.java:1332: Found 'DD'-anomaly for variable 'spec' (lines '1,332'-'1,335'). +src/net/sf/freecol/FreeCol.java:1332: Found 'DD'-anomaly for variable 'spec' (lines '1,332'-'1,342'). +src/net/sf/freecol/FreeCol.java:1337: These nested if statements could be combined +src/net/sf/freecol/FreeCol.java:1356: The method 'startServer' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/FreeCol.java:1356: The method 'startServer' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/FreeCol.java:1356: The method 'startServer' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/FreeCol.java:1358: Avoid using final local variables, turn them into fields +src/net/sf/freecol/FreeCol.java:1359: Local variable 'saveGame' could be declared final +src/net/sf/freecol/FreeCol.java:1360: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/FreeCol.java:1364: Found 'DU'-anomaly for variable 'freeColServer' (lines '1,364'-'1,402'). +src/net/sf/freecol/FreeCol.java:1364: Found 'DU'-anomaly for variable 'freeColServer' (lines '1,364'-'1,402'). +src/net/sf/freecol/FreeCol.java:1367: Local variable 'integrityOK' could be declared final +src/net/sf/freecol/FreeCol.java:1368: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1368: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1371: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/FreeCol.java:1371: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1371: Useless parentheses. +src/net/sf/freecol/FreeCol.java:1373: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/FreeCol.java:1374: Avoid using if statements without curly braces +src/net/sf/freecol/FreeCol.java:1377: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/FreeCol.java:1380: Local variable 'spec' could be declared final +src/net/sf/freecol/FreeCol.java:1382: Found 'DU'-anomaly for variable 'freeColServer' (lines '1,382'-'1,402'). +src/net/sf/freecol/FreeCol.java:1382: Found 'DU'-anomaly for variable 'freeColServer' (lines '1,382'-'1,402'). +src/net/sf/freecol/FreeCol.java:1384: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/FreeCol.java:1395: Local variable 'quit' could be declared final +src/net/sf/freecol/FreeCol.java:1396: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/FreeCol.java:1398: publicMethodCommentRequirement Required +src/net/sf/freecol/FreeCol.java:1399: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/FreeColClient.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/FreeColClient.java:20: Possible God class (WMC=94, ATFD=34, TCC=0.03333333333333333) +src/net/sf/freecol/client/FreeColClient.java:69: The class 'FreeColClient' has a Cyclomatic Complexity of 2 (Highest = 13). +src/net/sf/freecol/client/FreeColClient.java:69: The class 'FreeColClient' has a Modified Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/client/FreeColClient.java:69: The class 'FreeColClient' has a Standard Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/client/FreeColClient.java:69: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/FreeColClient.java:69: Too many fields +src/net/sf/freecol/client/FreeColClient.java:71: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/FreeColClient.java:71: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:73: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:75: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:77: Avoid excessively long variable names like preGameInputHandler +src/net/sf/freecol/client/FreeColClient.java:77: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:79: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:81: Avoid excessively long variable names like inGameInputHandler +src/net/sf/freecol/client/FreeColClient.java:81: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:83: Avoid excessively long variable names like mapEditorController +src/net/sf/freecol/client/FreeColClient.java:83: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:85: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/FreeColClient.java:85: fieldCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:88: Avoid using redundant field initializer for 'freeColServer' +src/net/sf/freecol/client/FreeColClient.java:91: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/FreeColClient.java:95: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/FreeColClient.java:104: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/FreeColClient.java:107: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/FreeColClient.java:110: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/FreeColClient.java:116: Avoid using redundant field initializer for 'inGame' +src/net/sf/freecol/client/FreeColClient.java:130: Avoid using redundant field initializer for 'loggedIn' +src/net/sf/freecol/client/FreeColClient.java:136: publicMethodCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:141: Comment is too large: Too many lines +src/net/sf/freecol/client/FreeColClient.java:150: The constructor 'FreeColClient' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/client/FreeColClient.java:150: The constructor 'FreeColClient' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/FreeColClient.java:150: The constructor 'FreeColClient' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/client/FreeColClient.java:151: Parameter 'headless' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:156: These nested if statements could be combined +src/net/sf/freecol/client/FreeColClient.java:163: Useless parentheses. +src/net/sf/freecol/client/FreeColClient.java:163: Useless parentheses. +src/net/sf/freecol/client/FreeColClient.java:168: Local variable 'baseDirectory' could be declared final +src/net/sf/freecol/client/FreeColClient.java:214: Local variable 'tcData' could be declared final +src/net/sf/freecol/client/FreeColClient.java:224: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/FreeColClient.java:232: Comment is too large: Too many lines +src/net/sf/freecol/client/FreeColClient.java:243: Found 'UR'-anomaly for variable 'f' (lines '243'-'261'). +src/net/sf/freecol/client/FreeColClient.java:243: Found 'UR'-anomaly for variable 'f' (lines '243'-'261'). +src/net/sf/freecol/client/FreeColClient.java:243: The method 'startClient' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/client/FreeColClient.java:243: The method 'startClient' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/FreeColClient.java:243: The method 'startClient' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/FreeColClient.java:259: Local variable 'modMappings' could be declared final +src/net/sf/freecol/client/FreeColClient.java:260: Local variable 'f' could be declared final +src/net/sf/freecol/client/FreeColClient.java:265: Avoid using if statements without curly braces +src/net/sf/freecol/client/FreeColClient.java:283: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/FreeColClient.java:290: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/FreeColClient.java:308: Local variable 'quit' could be declared final +src/net/sf/freecol/client/FreeColClient.java:309: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/FreeColClient.java:311: publicMethodCommentRequirement Required +src/net/sf/freecol/client/FreeColClient.java:312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:317: Comment is too large: Too many lines +src/net/sf/freecol/client/FreeColClient.java:334: Parameter 'savedGameFile' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:335: Local variable 'clop' could be declared final +src/net/sf/freecol/client/FreeColClient.java:346: Local variable 'fcsf' could be declared final +src/net/sf/freecol/client/FreeColClient.java:348: There is log block not surrounded by if +src/net/sf/freecol/client/FreeColClient.java:348: There is log block not surrounded by if +src/net/sf/freecol/client/FreeColClient.java:352: There is log block not surrounded by if +src/net/sf/freecol/client/FreeColClient.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/FreeColClient.java:359: There is log block not surrounded by if +src/net/sf/freecol/client/FreeColClient.java:359: There is log block not surrounded by if +src/net/sf/freecol/client/FreeColClient.java:360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/FreeColClient.java:373: Parameter 'err' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:463: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:511: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:532: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:570: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/client/FreeColClient.java:570: Parameter 'inGame' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:588: Parameter 'mapEditor' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:608: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:626: Parameter 'loggedIn' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:655: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:669: Comment is too large: Too many lines +src/net/sf/freecol/client/FreeColClient.java:701: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:702: Local variable 'key' could be declared final +src/net/sf/freecol/client/FreeColClient.java:705: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:714: Useless parentheses. +src/net/sf/freecol/client/FreeColClient.java:714: Useless parentheses. +src/net/sf/freecol/client/FreeColClient.java:715: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:724: Parameter 'runnable' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:724: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/FreeColClient.java:730: Comment is too large: Too many lines +src/net/sf/freecol/client/FreeColClient.java:741: Parameter 'prompt' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:742: Found 'DD'-anomaly for variable 'specification' (lines '742'-'745'). +src/net/sf/freecol/client/FreeColClient.java:742: Found 'DU'-anomaly for variable 'specification' (lines '742'-'755'). +src/net/sf/freecol/client/FreeColClient.java:745: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:747: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:761: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:769: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/client/FreeColClient.java:770: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/FreeColClient.java:770: Avoid using if statements without curly braces +src/net/sf/freecol/client/FreeColClient.java:772: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:776: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:777: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:784: Avoid using if statements without curly braces +src/net/sf/freecol/client/FreeColClient.java:792: Local variable 'player' could be declared final +src/net/sf/freecol/client/FreeColClient.java:793: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/FreeColClient.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:795: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:795: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:802: Found 'UR'-anomaly for variable 'f' (lines '802'-'813'). +src/net/sf/freecol/client/FreeColClient.java:803: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/FreeColClient.java:805: Local variable 'validPeriod' could be declared final +src/net/sf/freecol/client/FreeColClient.java:807: Found 'DU'-anomaly for variable 'timeNow' (lines '807'-'830'). +src/net/sf/freecol/client/FreeColClient.java:807: Local variable 'timeNow' could be declared final +src/net/sf/freecol/client/FreeColClient.java:808: Local variable 'autoSave' could be declared final +src/net/sf/freecol/client/FreeColClient.java:810: Avoid assignments in operands +src/net/sf/freecol/client/FreeColClient.java:810: Found 'DU'-anomaly for variable 'flist' (lines '810'-'830'). +src/net/sf/freecol/client/FreeColClient.java:811: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/FreeColClient.java:812: Local variable 'f' could be declared final +src/net/sf/freecol/client/FreeColClient.java:813: Avoid using if statements without curly braces +src/net/sf/freecol/client/FreeColClient.java:815: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/FreeColClient.java:815: Local variable 'saveGameFile' could be declared final +src/net/sf/freecol/client/FreeColClient.java:821: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/FreeColClient.java:826: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/FreeColClient.java:827: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/client/FreeColClient.java:829: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/client/Worker.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/Worker.java:34: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/Worker.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/Worker.java:36: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/Worker.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/Worker.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/Worker.java:38: Use of modifier volatile is not recommended. +src/net/sf/freecol/client/Worker.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/Worker.java:40: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/Worker.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/Worker.java:42: publicMethodCommentRequirement Required +src/net/sf/freecol/client/Worker.java:49: publicMethodCommentRequirement Required +src/net/sf/freecol/client/Worker.java:53: Local variable 'job' could be declared final +src/net/sf/freecol/client/Worker.java:53: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/Worker.java:55: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/Worker.java:56: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/Worker.java:70: Parameter 'job' is not assigned and could be declared final +src/net/sf/freecol/client/Worker.java:70: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/control/InGameInputHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/control/InGameInputHandler.java:20: Possible God class (WMC=153, ATFD=147, TCC=0.0) +src/net/sf/freecol/client/control/InGameInputHandler.java:66: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:84: Avoid really long classes. +src/net/sf/freecol/client/control/InGameInputHandler.java:84: The class 'InGameInputHandler' has a Cyclomatic Complexity of 4 (Highest = 34). +src/net/sf/freecol/client/control/InGameInputHandler.java:84: The class 'InGameInputHandler' has a Standard Cyclomatic Complexity of 4 (Highest = 33). +src/net/sf/freecol/client/control/InGameInputHandler.java:84: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/control/InGameInputHandler.java:86: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/control/InGameInputHandler.java:86: fieldCommentRequirement Required +src/net/sf/freecol/client/control/InGameInputHandler.java:89: Avoid excessively long variable names like closeMenusRunnable +src/net/sf/freecol/client/control/InGameInputHandler.java:89: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/control/InGameInputHandler.java:89: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/control/InGameInputHandler.java:89: fieldCommentRequirement Required +src/net/sf/freecol/client/control/InGameInputHandler.java:92: Avoid excessively long variable names like displayModelMessagesRunnable +src/net/sf/freecol/client/control/InGameInputHandler.java:92: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/control/InGameInputHandler.java:92: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/control/InGameInputHandler.java:92: fieldCommentRequirement Required +src/net/sf/freecol/client/control/InGameInputHandler.java:95: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/control/InGameInputHandler.java:95: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/control/InGameInputHandler.java:95: fieldCommentRequirement Required +src/net/sf/freecol/client/control/InGameInputHandler.java:105: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:124: Parameter 'runnable' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:124: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/control/InGameInputHandler.java:125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:133: Parameter 'runnable' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:133: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/control/InGameInputHandler.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:145: Parameter 'attrib' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:145: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:146: Avoid variables with short names like n +src/net/sf/freecol/client/control/InGameInputHandler.java:148: Found 'DD'-anomaly for variable 'n' (lines '148'-'150'). +src/net/sf/freecol/client/control/InGameInputHandler.java:155: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:164: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:164: Parameter 'parent' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:165: Local variable 'nodes' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:167: Avoid variables with short names like e +src/net/sf/freecol/client/control/InGameInputHandler.java:167: Local variable 'e' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:168: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:168: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/InGameInputHandler.java:173: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:184: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:184: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:185: Avoid variables with short names like id +src/net/sf/freecol/client/control/InGameInputHandler.java:185: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:186: Avoid variables with short names like e +src/net/sf/freecol/client/control/InGameInputHandler.java:186: Local variable 'e' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:187: Avoid variables with short names like u +src/net/sf/freecol/client/control/InGameInputHandler.java:187: Found 'DD'-anomaly for variable 'u' (lines '187'-'189'). +src/net/sf/freecol/client/control/InGameInputHandler.java:191: Avoid throwing raw exception types. +src/net/sf/freecol/client/control/InGameInputHandler.java:204: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:204: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:204: The method 'handle' has a Cyclomatic Complexity of 34. +src/net/sf/freecol/client/control/InGameInputHandler.java:204: The method 'handle' has a Standard Cyclomatic Complexity of 33. +src/net/sf/freecol/client/control/InGameInputHandler.java:204: The method handle() has an NCSS line count of 102 +src/net/sf/freecol/client/control/InGameInputHandler.java:204: The method handle() has an NPath complexity of 900 +src/net/sf/freecol/client/control/InGameInputHandler.java:206: Avoid throwing raw exception types. +src/net/sf/freecol/client/control/InGameInputHandler.java:210: Local variable 'type' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:211: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:272: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:273: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:275: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:282: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:282: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/control/InGameInputHandler.java:283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:299: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:301: Found 'DU'-anomaly for variable 'spec' (lines '301'-'336'). +src/net/sf/freecol/client/control/InGameInputHandler.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:302: Local variable 'nodes' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:304: Avoid variables with short names like e +src/net/sf/freecol/client/control/InGameInputHandler.java:304: Local variable 'e' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:305: Local variable 'owner' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:306: Local variable 'player' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:308: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:313: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:314: Local variable 'father' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:315: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:316: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/InGameInputHandler.java:316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:319: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:320: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:323: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:325: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:326: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:329: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:332: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:345: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:346: Found 'DU'-anomaly for variable 'game' (lines '346'-'359'). +src/net/sf/freecol/client/control/InGameInputHandler.java:347: Local variable 'nodes' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:349: Local variable 'playerElement' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:350: Avoid variables with short names like id +src/net/sf/freecol/client/control/InGameInputHandler.java:350: Local variable 'id' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:351: Avoid variables with short names like p +src/net/sf/freecol/client/control/InGameInputHandler.java:351: Local variable 'p' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:351: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:353: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:361: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:371: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:371: The method 'animateAttack' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/control/InGameInputHandler.java:371: The method animateAttack() has an NPath complexity of 576 +src/net/sf/freecol/client/control/InGameInputHandler.java:373: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:373: Found 'DU'-anomaly for variable 'game' (lines '373'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:374: Found 'DU'-anomaly for variable 'player' (lines '374'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:376: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:376: Avoid variables with short names like u +src/net/sf/freecol/client/control/InGameInputHandler.java:378: Avoid assignments in operands +src/net/sf/freecol/client/control/InGameInputHandler.java:378: Found 'DU'-anomaly for variable 'str' (lines '378'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:379: The String literal "Attack animation for: " appears 8 times in this file; the first occurrence is on line 379 +src/net/sf/freecol/client/control/InGameInputHandler.java:380: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:382: Avoid assignments in operands +src/net/sf/freecol/client/control/InGameInputHandler.java:382: Found 'DD'-anomaly for variable 'u' (lines '382'-'382'). +src/net/sf/freecol/client/control/InGameInputHandler.java:382: Found 'DU'-anomaly for variable 'u' (lines '382'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:385: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:387: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:387: Found 'DU'-anomaly for variable 'attacker' (lines '387'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:389: Avoid assignments in operands +src/net/sf/freecol/client/control/InGameInputHandler.java:389: Found 'DU'-anomaly for variable 'str' (lines '389'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:393: Avoid assignments in operands +src/net/sf/freecol/client/control/InGameInputHandler.java:393: Found 'DD'-anomaly for variable 'u' (lines '393'-'393'). +src/net/sf/freecol/client/control/InGameInputHandler.java:393: Found 'DU'-anomaly for variable 'u' (lines '393'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:398: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:398: Found 'DU'-anomaly for variable 'defender' (lines '398'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:400: Avoid assignments in operands +src/net/sf/freecol/client/control/InGameInputHandler.java:400: Found 'DU'-anomaly for variable 'str' (lines '400'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:410: Avoid assignments in operands +src/net/sf/freecol/client/control/InGameInputHandler.java:410: Found 'DU'-anomaly for variable 'str' (lines '410'-'429'). +src/net/sf/freecol/client/control/InGameInputHandler.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:417: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:424: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:424: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:425: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:431: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:442: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:444: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:444: Found 'DU'-anomaly for variable 'game' (lines '444'-'493'). +src/net/sf/freecol/client/control/InGameInputHandler.java:445: Found 'DU'-anomaly for variable 'player' (lines '445'-'493'). +src/net/sf/freecol/client/control/InGameInputHandler.java:445: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:447: Local variable 'unitId' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:449: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:449: The String literal "Animation for: " appears 6 times in this file; the first occurrence is on line 449 +src/net/sf/freecol/client/control/InGameInputHandler.java:449: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:451: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:453: Avoid variables with short names like u +src/net/sf/freecol/client/control/InGameInputHandler.java:453: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:459: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:459: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:461: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:463: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:463: Found 'DU'-anomaly for variable 'unit' (lines '463'-'493'). +src/net/sf/freecol/client/control/InGameInputHandler.java:465: Local variable 'oldTileId' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:466: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:467: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:467: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:469: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:471: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:473: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:473: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:475: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:478: Local variable 'newTileId' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:480: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:482: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:484: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:486: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:486: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:488: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:491: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:491: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:491: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:502: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:507: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:520: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:529: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:544: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InGameInputHandler.java:554: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:558: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:558: Found 'DU'-anomaly for variable 'agreement' (lines '558'-'577'). +src/net/sf/freecol/client/control/InGameInputHandler.java:563: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:569: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:572: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:572: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:573: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:573: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:575: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/control/InGameInputHandler.java:587: Avoid unused private methods such as 'disposeUnits(Element)'. +src/net/sf/freecol/client/control/InGameInputHandler.java:587: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:588: Found 'DU'-anomaly for variable 'game' (lines '588'-'606'). +src/net/sf/freecol/client/control/InGameInputHandler.java:588: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:589: Local variable 'nodes' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:596: Avoid variables with short names like e +src/net/sf/freecol/client/control/InGameInputHandler.java:596: Local variable 'e' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:596: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:597: Avoid variables with short names like id +src/net/sf/freecol/client/control/InGameInputHandler.java:597: Local variable 'id' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:598: Avoid variables with short names like u +src/net/sf/freecol/client/control/InGameInputHandler.java:598: Local variable 'u' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:615: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:619: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:619: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:619: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:630: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:632: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:632: Found 'DU'-anomaly for variable 'spec' (lines '632'-'665'). +src/net/sf/freecol/client/control/InGameInputHandler.java:632: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:633: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:633: Found 'DU'-anomaly for variable 'add' (lines '633'-'665'). +src/net/sf/freecol/client/control/InGameInputHandler.java:633: Local variable 'add' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:634: Avoid variables with short names like id +src/net/sf/freecol/client/control/InGameInputHandler.java:634: Local variable 'id' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:635: Local variable 'object' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:635: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:638: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:641: Local variable 'nodes' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:642: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:643: Avoid variables with short names like e +src/net/sf/freecol/client/control/InGameInputHandler.java:643: Local variable 'e' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:643: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:645: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:646: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:648: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:650: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:655: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:657: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/control/InGameInputHandler.java:661: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:674: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:680: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:681: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:682: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:685: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:685: Use equals() to compare object references. +src/net/sf/freecol/client/control/InGameInputHandler.java:686: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:687: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:690: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:691: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:692: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:694: Avoid variables with short names like n +src/net/sf/freecol/client/control/InGameInputHandler.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:707: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:708: Avoid variables with short names like n +src/net/sf/freecol/client/control/InGameInputHandler.java:710: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:712: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:715: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:715: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:715: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:726: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:727: Local variable 'freeColClient' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:730: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:734: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:736: Found 'DU'-anomaly for variable 'highScore' (lines '736'-'742'). +src/net/sf/freecol/client/control/InGameInputHandler.java:738: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:752: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:754: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:754: Found 'DU'-anomaly for variable 'player' (lines '754'-'777'). +src/net/sf/freecol/client/control/InGameInputHandler.java:754: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:759: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:761: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:765: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:767: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:768: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:772: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:772: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:786: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:790: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:790: Found 'DU'-anomaly for variable 'defenderId' (lines '790'-'796'). +src/net/sf/freecol/client/control/InGameInputHandler.java:792: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:792: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/InGameInputHandler.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:805: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:810: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:810: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:811: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:824: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:824: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:825: Local variable 'nodes' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:826: Local variable 'results' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:828: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:830: Local variable 'reply' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:831: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/InGameInputHandler.java:832: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/control/InGameInputHandler.java:833: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:847: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:849: Local variable 'message' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:850: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:850: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:852: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/InGameInputHandler.java:853: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:853: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:855: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:855: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:855: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:866: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:868: Local variable 'message' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:869: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:869: Found 'DU'-anomaly for variable 'tile' (lines '869'-'879'). +src/net/sf/freecol/client/control/InGameInputHandler.java:870: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:870: Found 'DU'-anomaly for variable 'unit' (lines '870'-'879'). +src/net/sf/freecol/client/control/InGameInputHandler.java:870: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:870: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:873: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:873: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/InGameInputHandler.java:875: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:875: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:876: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:888: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:889: Avoid variables with short names like n +src/net/sf/freecol/client/control/InGameInputHandler.java:892: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:895: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:895: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:895: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:906: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:920: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:922: Found 'DU'-anomaly for variable 'divert' (lines '922'-'944'). +src/net/sf/freecol/client/control/InGameInputHandler.java:923: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:925: Local variable 'nodeList' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:926: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:927: Avoid variables with short names like e +src/net/sf/freecol/client/control/InGameInputHandler.java:927: Local variable 'e' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:927: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:928: Local variable 'idString' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:929: Local variable 'fcgo' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:929: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:941: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:941: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:941: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:953: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:955: Avoid variables with short names like p +src/net/sf/freecol/client/control/InGameInputHandler.java:955: Local variable 'p' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:955: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:957: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:969: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:971: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:975: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:978: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:989: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:990: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:994: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:997: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:997: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:997: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1008: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1009: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/control/InGameInputHandler.java:1009: Found 'DU'-anomaly for variable 'game' (lines '1,009'-'1,031'). +src/net/sf/freecol/client/control/InGameInputHandler.java:1014: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:1016: Avoid variables with short names like p1 +src/net/sf/freecol/client/control/InGameInputHandler.java:1016: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1020: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:1022: Avoid variables with short names like p2 +src/net/sf/freecol/client/control/InGameInputHandler.java:1022: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1026: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:1029: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1029: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1029: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1040: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1048: Local variable 'nodeList' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1049: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/control/InGameInputHandler.java:1049: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1050: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1050: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:1051: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:1056: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1058: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:1059: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/InGameInputHandler.java:1066: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1067: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1068: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1069: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1069: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1070: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1070: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1071: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1084: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1085: Found 'DU'-anomaly for variable 'player' (lines '1,085'-'1,107'). +src/net/sf/freecol/client/control/InGameInputHandler.java:1085: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1086: Found 'DD'-anomaly for variable 'visibilityChange' (lines '1,086'-'1,101'). +src/net/sf/freecol/client/control/InGameInputHandler.java:1088: Local variable 'nodeList' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1089: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1090: Avoid variables with short names like e +src/net/sf/freecol/client/control/InGameInputHandler.java:1090: Local variable 'e' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1090: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1091: Avoid variables with short names like id +src/net/sf/freecol/client/control/InGameInputHandler.java:1091: Local variable 'id' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1092: Local variable 'fcgo' could be declared final +src/net/sf/freecol/client/control/InGameInputHandler.java:1092: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InGameInputHandler.java:1094: There is log block not surrounded by if +src/net/sf/freecol/client/control/InGameInputHandler.java:1096: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1098: Use equals() to compare object references. +src/net/sf/freecol/client/control/InGameInputHandler.java:1098: Useless parentheses. +src/net/sf/freecol/client/control/InGameInputHandler.java:1098: Useless parentheses. +src/net/sf/freecol/client/control/InGameInputHandler.java:1098: Useless parentheses. +src/net/sf/freecol/client/control/InGameInputHandler.java:1098: Useless parentheses. +src/net/sf/freecol/client/control/InGameInputHandler.java:1099: Useless parentheses. +src/net/sf/freecol/client/control/InGameInputHandler.java:1099: Useless parentheses. +src/net/sf/freecol/client/control/InGameInputHandler.java:1100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InGameInputHandler.java:1101: Found 'DD'-anomaly for variable 'visibilityChange' (lines '1,101'-'1,101'). +src/net/sf/freecol/client/control/InGameInputHandler.java:1104: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/InGameInputHandler.java:1104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/InputHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/control/InputHandler.java:36: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/control/InputHandler.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/control/InputHandler.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/control/InputHandler.java:49: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/control/InputHandler.java:102: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InputHandler.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InputHandler.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InputHandler.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InputHandler.java:104: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/control/InputHandler.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InputHandler.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InputHandler.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/InputHandler.java:124: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/InputHandler.java:125: There is log block not surrounded by if +src/net/sf/freecol/client/control/PreGameController.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/control/PreGameController.java:45: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/control/PreGameController.java:45: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/control/PreGameController.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/control/PreGameController.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/control/PreGameController.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/control/PreGameController.java:59: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:70: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:80: Parameter 'ready' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:106: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:106: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:119: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:119: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:130: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:141: Parameter 'nationType' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameController.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameController.java:164: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameController.java:170: Found 'DU'-anomaly for variable 'igc' (lines '170'-'187'). +src/net/sf/freecol/client/control/PreGameController.java:170: Local variable 'igc' could be declared final +src/net/sf/freecol/client/control/PreGameController.java:171: Avoid using if statements without curly braces +src/net/sf/freecol/client/control/PreGameController.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameController.java:178: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/PreGameController.java:181: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/control/PreGameController.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameController.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameController.java:194: Local variable 'gameOptions' could be declared final +src/net/sf/freecol/client/control/PreGameController.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:198: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:206: Local variable 'mgo' could be declared final +src/net/sf/freecol/client/control/PreGameController.java:206: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameController.java:208: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/control/PreGameInputHandler.java:50: The class 'PreGameInputHandler' has a Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/client/control/PreGameInputHandler.java:50: The class 'PreGameInputHandler' has a Modified Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/client/control/PreGameInputHandler.java:50: The class 'PreGameInputHandler' has a Standard Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/client/control/PreGameInputHandler.java:50: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/control/PreGameInputHandler.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/control/PreGameInputHandler.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/control/PreGameInputHandler.java:60: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:74: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:74: The method 'handle' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/client/control/PreGameInputHandler.java:74: The method 'handle' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/client/control/PreGameInputHandler.java:74: The method 'handle' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/client/control/PreGameInputHandler.java:74: The method handle() has an NPath complexity of 325 +src/net/sf/freecol/client/control/PreGameInputHandler.java:74: Use block level rather than method level synchronization +src/net/sf/freecol/client/control/PreGameInputHandler.java:75: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:76: Local variable 'type' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:77: Useless parentheses. +src/net/sf/freecol/client/control/PreGameInputHandler.java:77: Useless parentheses. +src/net/sf/freecol/client/control/PreGameInputHandler.java:119: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:120: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:122: Local variable 'playerElement' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:124: Avoid variables with short names like id +src/net/sf/freecol/client/control/PreGameInputHandler.java:124: Local variable 'id' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:125: Local variable 'fcgo' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:143: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:144: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:145: Local variable 'chatMessage' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:159: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:160: Useless parentheses. +src/net/sf/freecol/client/control/PreGameInputHandler.java:160: Useless parentheses. +src/net/sf/freecol/client/control/PreGameInputHandler.java:162: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/control/PreGameInputHandler.java:174: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:175: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:177: Local variable 'playerId' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:177: The String literal "player" appears 4 times in this file; the first occurrence is on line 177 +src/net/sf/freecol/client/control/PreGameInputHandler.java:178: Local variable 'reason' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:180: There is log block not surrounded by if +src/net/sf/freecol/client/control/PreGameInputHandler.java:180: There is log block not surrounded by if +src/net/sf/freecol/client/control/PreGameInputHandler.java:183: Local variable 'player' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:198: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:198: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:199: Local variable 'nodes' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:200: Found 'DD'-anomaly for variable 'reply' (lines '200'-'203'). +src/net/sf/freecol/client/control/PreGameInputHandler.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:203: Found 'DD'-anomaly for variable 'reply' (lines '203'-'203'). +src/net/sf/freecol/client/control/PreGameInputHandler.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:215: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:216: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:218: Local variable 'player' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:220: Local variable 'ready' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:222: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:234: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:235: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:235: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:237: Local variable 'playerElement' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:239: Local variable 'player' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:254: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:255: Local variable 'nation' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:257: Local variable 'state' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:265: Comment is too large: Too many lines +src/net/sf/freecol/client/control/PreGameInputHandler.java:276: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:277: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/control/PreGameInputHandler.java:279: publicMethodCommentRequirement Required +src/net/sf/freecol/client/control/PreGameInputHandler.java:280: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:280: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:283: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/control/PreGameInputHandler.java:283: Avoid empty catch blocks +src/net/sf/freecol/client/control/PreGameInputHandler.java:283: Avoid empty catch blocks +src/net/sf/freecol/client/control/PreGameInputHandler.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:302: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:303: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:303: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:304: Local variable 'spec' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:306: Local variable 'nation' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:308: There is log block not surrounded by if +src/net/sf/freecol/client/control/PreGameInputHandler.java:309: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/PreGameInputHandler.java:314: Local variable 'rgb' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:315: Found 'DU'-anomaly for variable 'color' (lines '315'-'323'). +src/net/sf/freecol/client/control/PreGameInputHandler.java:317: There is log block not surrounded by if +src/net/sf/freecol/client/control/PreGameInputHandler.java:318: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/control/PreGameInputHandler.java:321: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:321: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:332: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:333: Local variable 'children' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:334: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/control/PreGameInputHandler.java:334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:335: Local variable 'fcc' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:336: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:340: There is log block not surrounded by if +src/net/sf/freecol/client/control/PreGameInputHandler.java:352: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:353: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:353: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:355: Local variable 'mgoElement' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:355: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:357: Local variable 'spec' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:357: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:358: Local variable 'gameOptions' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:359: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:362: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:374: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:375: Local variable 'mgoElement' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:375: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:378: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:378: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:378: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:381: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:393: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:394: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:394: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:396: Local variable 'player' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:398: Local variable 'nation' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:398: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:398: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:402: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:414: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:415: Local variable 'game' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:415: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:417: Local variable 'player' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:417: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:419: Local variable 'nationType' could be declared final +src/net/sf/freecol/client/control/PreGameInputHandler.java:419: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:419: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/PreGameInputHandler.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/control/PreGameInputHandler.java:423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/SoundController.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/control/SoundController.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/control/SoundController.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/control/SoundController.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/control/SoundController.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/control/SoundController.java:54: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/control/SoundController.java:54: Parameter 'sound' is not assigned and could be declared final +src/net/sf/freecol/client/control/SoundController.java:57: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/control/SoundController.java:58: Local variable 'amo' could be declared final +src/net/sf/freecol/client/control/SoundController.java:59: Avoid variables with short names like vo +src/net/sf/freecol/client/control/SoundController.java:59: Local variable 'vo' could be declared final +src/net/sf/freecol/client/control/SoundController.java:60: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/control/SoundController.java:61: There is log block not surrounded by if +src/net/sf/freecol/client/control/SoundController.java:62: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/control/SoundController.java:63: There is log block not surrounded by if +src/net/sf/freecol/client/control/SoundController.java:66: There is log block not surrounded by if +src/net/sf/freecol/client/control/SoundController.java:72: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/control/SoundController.java:76: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/control/SoundController.java:97: Parameter 'sound' is not assigned and could be declared final +src/net/sf/freecol/client/control/SoundController.java:104: Local variable 'file' could be declared final +src/net/sf/freecol/client/control/SoundController.java:108: There is log block not surrounded by if +src/net/sf/freecol/client/control/SoundController.java:123: Local variable 'text' could be declared final +src/net/sf/freecol/client/control/SoundController.java:127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/control/SoundController.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:33: The class 'AbstractCanvasListener' has a Cyclomatic Complexity of 5 (Highest = 16). +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:33: The class 'AbstractCanvasListener' has a Modified Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:33: The class 'AbstractCanvasListener' has a Standard Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:47: Avoid using redundant field initializer for 'scrollThread' +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:55: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:55: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:58: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:67: Avoid variables with short names like e +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:67: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:81: Avoid variables with short names like e +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:81: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:96: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: Avoid variables with short names like x +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: Avoid variables with short names like y +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: Parameter 'scrollSpace' is not assigned and could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: The method 'scroll' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: The method 'scroll' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:107: The method 'scroll' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:109: Found 'DU'-anomaly for variable 'size' (lines '109'-'142'). +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:109: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/AbstractCanvasListener.java:130: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/Canvas.java:20: High amount of different objects as members denotes a high coupling +src/net/sf/freecol/client/gui/Canvas.java:20: Possible God class (WMC=380, ATFD=267, TCC=0.2959159302603296) +src/net/sf/freecol/client/gui/Canvas.java:100: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:112: Avoid really long classes. +src/net/sf/freecol/client/gui/Canvas.java:112: The class 'Canvas' has a Cyclomatic Complexity of 2 (Highest = 19). +src/net/sf/freecol/client/gui/Canvas.java:112: The class 'Canvas' has a Modified Cyclomatic Complexity of 2 (Highest = 19). +src/net/sf/freecol/client/gui/Canvas.java:112: The class 'Canvas' has a Standard Cyclomatic Complexity of 2 (Highest = 19). +src/net/sf/freecol/client/gui/Canvas.java:112: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/Canvas.java:112: Too many fields +src/net/sf/freecol/client/gui/Canvas.java:114: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/Canvas.java:114: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:117: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/Canvas.java:120: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:126: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:132: Parameter 'fcd' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:132: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:133: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:143: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:147: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/Canvas.java:149: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:162: enumCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:170: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:176: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:176: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:179: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:179: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:181: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:181: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:181: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:184: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:184: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:186: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:186: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:186: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:188: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:188: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:188: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:190: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:190: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:190: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:192: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:192: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:192: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:194: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:194: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:194: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:196: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:196: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:196: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:198: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:198: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:198: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:200: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:200: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:200: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:202: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:202: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:202: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:204: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:204: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:204: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:207: Avoid using redundant field initializer for 'oldSize' +src/net/sf/freecol/client/gui/Canvas.java:207: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:207: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:209: Avoid excessively long variable names like clientOptionsDialogShowing +src/net/sf/freecol/client/gui/Canvas.java:209: Avoid using redundant field initializer for 'clientOptionsDialogShowing' +src/net/sf/freecol/client/gui/Canvas.java:209: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:209: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:209: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:211: Avoid excessively long variable names like loadingSavegameDialog +src/net/sf/freecol/client/gui/Canvas.java:211: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:211: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:211: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/Canvas.java:214: Avoid using redundant field initializer for 'fileFilters' +src/net/sf/freecol/client/gui/Canvas.java:214: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:214: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:217: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/Canvas.java:217: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/Canvas.java:220: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:230: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/Canvas.java:234: Parameter 'mapViewer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:250: System.err.println is used +src/net/sf/freecol/client/gui/Canvas.java:256: There is log block not surrounded by if +src/net/sf/freecol/client/gui/Canvas.java:256: There is log block not surrounded by if +src/net/sf/freecol/client/gui/Canvas.java:281: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:288: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:290: Found 'DD'-anomaly for variable 'menuBar' (lines '290'-'293'). +src/net/sf/freecol/client/gui/Canvas.java:291: Found 'DD'-anomaly for variable 'windowBounds' (lines '291'-'295'). +src/net/sf/freecol/client/gui/Canvas.java:300: Use bitwise inversion to invert boolean values +src/net/sf/freecol/client/gui/Canvas.java:305: Parameter 'menuBar' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:305: Parameter 'windowBounds' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:318: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:319: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:327: Local variable 'listener' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:336: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/client/gui/Canvas.java:336: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:345: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:346: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:353: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:354: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:361: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:362: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:372: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:372: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:384: Avoid variables with short names like x +src/net/sf/freecol/client/gui/Canvas.java:384: Avoid variables with short names like y +src/net/sf/freecol/client/gui/Canvas.java:384: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:384: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:384: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:402: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:411: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:411: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:418: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:427: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:437: Avoid variables with short names like x +src/net/sf/freecol/client/gui/Canvas.java:437: Avoid variables with short names like y +src/net/sf/freecol/client/gui/Canvas.java:437: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:437: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:437: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:446: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:456: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:466: Parameter 'gotoPath' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:466: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:474: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:483: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:492: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:503: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:503: Parameter 'toolBox' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:503: The method addAsFrame() has an NPath complexity of 480 +src/net/sf/freecol/client/gui/Canvas.java:504: Parameter 'popupPosition' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:505: Parameter 'resizable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:506: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/Canvas.java:508: Avoid variables with short names like f +src/net/sf/freecol/client/gui/Canvas.java:508: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:508: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:510: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:511: Avoid variables with short names like c +src/net/sf/freecol/client/gui/Canvas.java:511: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:511: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:512: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:513: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:516: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/Canvas.java:518: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:520: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:530: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:531: Local variable 'biu' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:531: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:532: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:533: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:534: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:535: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:538: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:538: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:539: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:541: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:549: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:550: Avoid variables with short names like p +src/net/sf/freecol/client/gui/Canvas.java:550: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:553: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:553: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:553: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:555: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:556: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:559: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:560: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:560: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:571: Avoid variables with short names like i +src/net/sf/freecol/client/gui/Canvas.java:571: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:571: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:585: Avoid variables with short names like i +src/net/sf/freecol/client/gui/Canvas.java:585: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:585: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:586: Use equals() to compare object references. +src/net/sf/freecol/client/gui/Canvas.java:593: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:594: There is log block not surrounded by if +src/net/sf/freecol/client/gui/Canvas.java:599: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:608: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:608: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:608: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:608: The method 'chooseLocation' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/client/gui/Canvas.java:608: The method 'chooseLocation' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/Canvas.java:608: The method chooseLocation() has an NPath complexity of 252 +src/net/sf/freecol/client/gui/Canvas.java:609: Parameter 'popupPosition' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:610: Avoid variables with short names like p +src/net/sf/freecol/client/gui/Canvas.java:610: Found 'DD'-anomaly for variable 'p' (lines '610'-'611'). +src/net/sf/freecol/client/gui/Canvas.java:611: Avoid assignments in operands +src/net/sf/freecol/client/gui/Canvas.java:611: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:611: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:614: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:614: These nested if statements could be combined +src/net/sf/freecol/client/gui/Canvas.java:615: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:616: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:617: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:618: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:621: Avoid variables with short names like x +src/net/sf/freecol/client/gui/Canvas.java:621: Avoid variables with short names like y +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'x' (lines '621'-'623'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'x' (lines '621'-'628'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'x' (lines '621'-'632'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'x' (lines '621'-'636'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'x' (lines '621'-'640'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'y' (lines '621'-'624'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'y' (lines '621'-'629'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'y' (lines '621'-'633'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'y' (lines '621'-'637'). +src/net/sf/freecol/client/gui/Canvas.java:621: Found 'DD'-anomaly for variable 'y' (lines '621'-'640'). +src/net/sf/freecol/client/gui/Canvas.java:621: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/Canvas.java:622: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/Canvas.java:623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:624: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:626: Switch statements should have a default label +src/net/sf/freecol/client/gui/Canvas.java:644: Avoid assignments in operands +src/net/sf/freecol/client/gui/Canvas.java:656: Found 'UR'-anomaly for variable 'option' (lines '656'-'658'). +src/net/sf/freecol/client/gui/Canvas.java:657: Local variable 'option' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:657: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:658: Local variable 'action' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:659: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:659: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:659: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:660: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:660: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:664: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:675: Avoid variables with short names like x +src/net/sf/freecol/client/gui/Canvas.java:675: Avoid variables with short names like y +src/net/sf/freecol/client/gui/Canvas.java:675: Found 'UR'-anomaly for variable 'c' (lines '675'-'705'). +src/net/sf/freecol/client/gui/Canvas.java:675: Found 'UR'-anomaly for variable 'fcd' (lines '675'-'688'). +src/net/sf/freecol/client/gui/Canvas.java:675: The method 'getClearSpace' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/Canvas.java:675: The method 'getClearSpace' has a Modified Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/Canvas.java:675: The method 'getClearSpace' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/Canvas.java:675: The method getClearSpace() has an NPath complexity of 1679620 +src/net/sf/freecol/client/gui/Canvas.java:676: Avoid reassigning parameters such as 'tries' +src/net/sf/freecol/client/gui/Canvas.java:676: Avoid reassigning parameters such as 'tries' +src/net/sf/freecol/client/gui/Canvas.java:676: Avoid variables with short names like h +src/net/sf/freecol/client/gui/Canvas.java:676: Avoid variables with short names like w +src/net/sf/freecol/client/gui/Canvas.java:678: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:678: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:678: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:681: Local variable 'todo' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:682: Avoid variables with short names like p +src/net/sf/freecol/client/gui/Canvas.java:683: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:685: Local variable 'allComponents' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:685: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:685: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:685: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:686: Avoid variables with short names like c +src/net/sf/freecol/client/gui/Canvas.java:688: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:688: Local variable 'fcd' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:688: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:691: Found 'DU'-anomaly for variable 'bestScore' (lines '691'-'745'). +src/net/sf/freecol/client/gui/Canvas.java:692: Found 'DD'-anomaly for variable 'best' (lines '692'-'719'). +src/net/sf/freecol/client/gui/Canvas.java:692: Found 'DU'-anomaly for variable 'best' (lines '692'-'745'). +src/net/sf/freecol/client/gui/Canvas.java:693: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:694: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:695: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/Canvas.java:695: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:695: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:696: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:702: Found 'DU'-anomaly for variable 'foundScore' (lines '702'-'745'). +src/net/sf/freecol/client/gui/Canvas.java:703: Found 'DD'-anomaly for variable 'found' (lines '703'-'710'). +src/net/sf/freecol/client/gui/Canvas.java:704: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:705: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:705: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:706: Avoid variables with short names like rr +src/net/sf/freecol/client/gui/Canvas.java:706: Local variable 'rr' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:706: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:707: Local variable 'score' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:709: Found 'DU'-anomaly for variable 'foundScore' (lines '709'-'745'). +src/net/sf/freecol/client/gui/Canvas.java:710: Found 'DD'-anomaly for variable 'found' (lines '710'-'710'). +src/net/sf/freecol/client/gui/Canvas.java:715: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:718: Found 'DU'-anomaly for variable 'bestScore' (lines '718'-'745'). +src/net/sf/freecol/client/gui/Canvas.java:719: Found 'DD'-anomaly for variable 'best' (lines '719'-'719'). +src/net/sf/freecol/client/gui/Canvas.java:719: Found 'DU'-anomaly for variable 'best' (lines '719'-'745'). +src/net/sf/freecol/client/gui/Canvas.java:722: Avoid assignments in operands +src/net/sf/freecol/client/gui/Canvas.java:722: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:724: Avoid variables with short names like n +src/net/sf/freecol/client/gui/Canvas.java:724: Local variable 'n' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:724: Local variable 'x0' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:724: Local variable 'x1' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:724: Local variable 'x2' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:724: Local variable 'y0' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:724: Local variable 'y1' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:724: Local variable 'y2' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:724: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:729: Avoid variables with short names like x0 +src/net/sf/freecol/client/gui/Canvas.java:729: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:729: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:730: Avoid variables with short names like y0 +src/net/sf/freecol/client/gui/Canvas.java:730: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:730: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:731: Avoid variables with short names like x1 +src/net/sf/freecol/client/gui/Canvas.java:732: Avoid variables with short names like y1 +src/net/sf/freecol/client/gui/Canvas.java:733: Avoid variables with short names like x2 +src/net/sf/freecol/client/gui/Canvas.java:734: Avoid variables with short names like y2 +src/net/sf/freecol/client/gui/Canvas.java:735: Local variable 'x0ok' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:735: Local variable 'x1ok' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:735: Local variable 'y0ok' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:735: Local variable 'y1ok' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:735: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:736: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:737: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:738: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:739: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/Canvas.java:739: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:739: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:740: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:740: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:741: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/Canvas.java:741: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:741: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:742: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/Canvas.java:742: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:742: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:747: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:756: Found 'UR'-anomaly for variable 'c1' (lines '756'-'758'). +src/net/sf/freecol/client/gui/Canvas.java:756: Found 'UR'-anomaly for variable 'c2' (lines '756'-'761'). +src/net/sf/freecol/client/gui/Canvas.java:756: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:757: Local variable 'c1' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:759: Local variable 'c2' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:759: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:759: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:762: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:763: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:779: Avoid variables with short names like c +src/net/sf/freecol/client/gui/Canvas.java:783: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:795: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:796: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:796: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:797: Local variable 'where' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:798: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:798: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:810: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:811: Avoid variables with short names like co +src/net/sf/freecol/client/gui/Canvas.java:812: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:812: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:814: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:815: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:817: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:817: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:817: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:819: Local variable 'className' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:819: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:821: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:821: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:822: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:823: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:835: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:836: Avoid variables with short names like co +src/net/sf/freecol/client/gui/Canvas.java:837: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:837: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:839: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:840: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:842: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:842: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:842: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:844: Local variable 'className' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:844: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:846: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:846: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:847: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:848: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:860: Avoid variables with short names like s +src/net/sf/freecol/client/gui/Canvas.java:860: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:865: Returning 'fileFilters' may expose an internal array. +src/net/sf/freecol/client/gui/Canvas.java:875: Avoid variables with short names like c +src/net/sf/freecol/client/gui/Canvas.java:875: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:875: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:876: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:879: Local variable 'fcp' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:880: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:883: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:892: Avoid assignments in operands +src/net/sf/freecol/client/gui/Canvas.java:892: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:892: Found 'DD'-anomaly for variable 'panel' (lines '892'-'894'). +src/net/sf/freecol/client/gui/Canvas.java:894: Avoid assignments in operands +src/net/sf/freecol/client/gui/Canvas.java:894: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:894: Found 'DD'-anomaly for variable 'panel' (lines '894'-'896'). +src/net/sf/freecol/client/gui/Canvas.java:896: Avoid assignments in operands +src/net/sf/freecol/client/gui/Canvas.java:896: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:896: Found 'DU'-anomaly for variable 'panel' (lines '896'-'898'). +src/net/sf/freecol/client/gui/Canvas.java:900: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:909: Parameter 'className' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:909: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:909: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:912: Avoid variables with short names like o +src/net/sf/freecol/client/gui/Canvas.java:912: Local variable 'o' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:912: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:915: Local variable 'specification' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:916: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:916: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:917: Avoid variables with short names like io +src/net/sf/freecol/client/gui/Canvas.java:917: Local variable 'io' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:920: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:933: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:933: Parameter 'position' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:935: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:935: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:937: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:937: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:937: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:939: Local variable 'className' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:939: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:950: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:950: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:952: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:952: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:954: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:954: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:954: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:956: Local variable 'className' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:956: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:965: Found 'UR'-anomaly for variable 'f' (lines '965'-'968'). +src/net/sf/freecol/client/gui/Canvas.java:966: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:966: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:967: Local variable 'f' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:968: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:980: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:989: Parameter 'freeColDialog' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:990: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:992: Local variable 'response' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:995: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1006: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1006: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1007: Parameter 'resizable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1017: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1017: Parameter 'resizable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1029: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1029: Parameter 'popupPosition' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1030: Parameter 'resizable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1046: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1057: Avoid variables with short names like i +src/net/sf/freecol/client/gui/Canvas.java:1057: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1057: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1065: Found 'UR'-anomaly for variable 'c' (lines '1,065'-'1,068'). +src/net/sf/freecol/client/gui/Canvas.java:1065: Found 'UR'-anomaly for variable 'frame' (lines '1,065'-'1,067'). +src/net/sf/freecol/client/gui/Canvas.java:1065: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1066: Local variable 'frame' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1067: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1067: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1073: Local variable 'dialog' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1074: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1081: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1084: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:1093: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1104: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1105: Local variable 'keyListeners' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:1110: Local variable 'mouseListeners' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:1115: Avoid excessively long variable names like mouseMotionListeners +src/net/sf/freecol/client/gui/Canvas.java:1115: Local variable 'mouseMotionListeners' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1117: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:1128: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1128: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1138: Parameter 'fcd' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1147: Parameter 'fcd' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1147: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1158: Found 'UR'-anomaly for variable 'c1' (lines '1,158'-'1,160'). +src/net/sf/freecol/client/gui/Canvas.java:1158: Found 'UR'-anomaly for variable 'c2' (lines '1,158'-'1,164'). +src/net/sf/freecol/client/gui/Canvas.java:1158: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1159: Local variable 'c1' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1161: Local variable 'c2' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1164: Local variable 'ret' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1171: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:1173: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:1173: Avoid empty catch blocks +src/net/sf/freecol/client/gui/Canvas.java:1187: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1197: Found 'UR'-anomaly for variable 'c' (lines '1,197'-'1,199'). +src/net/sf/freecol/client/gui/Canvas.java:1197: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1198: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1203: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:1205: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:1216: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1225: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1229: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1238: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1245: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1254: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1255: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1260: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/Canvas.java:1260: Use equals() to compare object references. +src/net/sf/freecol/client/gui/Canvas.java:1261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1269: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:1280: Found 'UR'-anomaly for variable 'c' (lines '1,280'-'1,298'). +src/net/sf/freecol/client/gui/Canvas.java:1280: Found 'UR'-anomaly for variable 'keyListener' (lines '1,280'-'1,284'). +src/net/sf/freecol/client/gui/Canvas.java:1280: Found 'UR'-anomaly for variable 'mouseListener' (lines '1,280'-'1,289'). +src/net/sf/freecol/client/gui/Canvas.java:1280: Found 'UR'-anomaly for variable 'mouseMotionListener' (lines '1,280'-'1,294'). +src/net/sf/freecol/client/gui/Canvas.java:1280: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1282: Local variable 'keyListeners' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1283: Local variable 'keyListener' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1287: Local variable 'mouseListeners' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1288: Local variable 'mouseListener' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1292: Avoid excessively long variable names like mouseMotionListeners +src/net/sf/freecol/client/gui/Canvas.java:1292: Local variable 'mouseMotionListeners' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1293: Avoid excessively long variable names like mouseMotionListener +src/net/sf/freecol/client/gui/Canvas.java:1293: Local variable 'mouseMotionListener' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1297: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1302: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1311: Avoid variables with short names like d +src/net/sf/freecol/client/gui/Canvas.java:1311: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1311: Parameter 'd' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1311: The method restoreSavedSize() has an NPath complexity of 640 +src/net/sf/freecol/client/gui/Canvas.java:1311: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1314: Found 'DD'-anomaly for variable 'save' (lines '1,314'-'1,319'). +src/net/sf/freecol/client/gui/Canvas.java:1314: Found 'DD'-anomaly for variable 'save' (lines '1,314'-'1,325'). +src/net/sf/freecol/client/gui/Canvas.java:1314: Found 'DD'-anomaly for variable 'save' (lines '1,314'-'1,329'). +src/net/sf/freecol/client/gui/Canvas.java:1314: Found 'DD'-anomaly for variable 'save' (lines '1,314'-'1,333'). +src/net/sf/freecol/client/gui/Canvas.java:1314: Found 'DD'-anomaly for variable 'save' (lines '1,314'-'1,337'). +src/net/sf/freecol/client/gui/Canvas.java:1319: Found 'DD'-anomaly for variable 'save' (lines '1,319'-'1,325'). +src/net/sf/freecol/client/gui/Canvas.java:1319: Found 'DD'-anomaly for variable 'save' (lines '1,319'-'1,329'). +src/net/sf/freecol/client/gui/Canvas.java:1319: Found 'DD'-anomaly for variable 'save' (lines '1,319'-'1,333'). +src/net/sf/freecol/client/gui/Canvas.java:1319: Found 'DD'-anomaly for variable 'save' (lines '1,319'-'1,337'). +src/net/sf/freecol/client/gui/Canvas.java:1325: Found 'DD'-anomaly for variable 'save' (lines '1,325'-'1,329'). +src/net/sf/freecol/client/gui/Canvas.java:1325: Found 'DD'-anomaly for variable 'save' (lines '1,325'-'1,333'). +src/net/sf/freecol/client/gui/Canvas.java:1325: Found 'DD'-anomaly for variable 'save' (lines '1,325'-'1,337'). +src/net/sf/freecol/client/gui/Canvas.java:1329: Found 'DD'-anomaly for variable 'save' (lines '1,329'-'1,333'). +src/net/sf/freecol/client/gui/Canvas.java:1329: Found 'DD'-anomaly for variable 'save' (lines '1,329'-'1,337'). +src/net/sf/freecol/client/gui/Canvas.java:1333: Found 'DD'-anomaly for variable 'save' (lines '1,333'-'1,337'). +src/net/sf/freecol/client/gui/Canvas.java:1344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1352: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1362: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1388: Avoid variables with short names like g +src/net/sf/freecol/client/gui/Canvas.java:1388: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1388: The method 'paintComponent' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/Canvas.java:1390: Local variable 'g2d' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1393: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1394: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1394: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1395: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1395: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1395: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1396: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1396: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1404: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/Canvas.java:1413: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1413: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1424: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/Canvas.java:1429: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/Canvas.java:1439: Local variable 'versionStr' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1440: Local variable 'oldFont' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1441: Local variable 'oldColor' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1442: Local variable 'newFont' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1442: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1443: Local variable 'layout' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1445: Local variable 'bounds' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1446: Avoid variables with short names like x +src/net/sf/freecol/client/gui/Canvas.java:1446: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1447: Avoid variables with short names like y +src/net/sf/freecol/client/gui/Canvas.java:1447: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1447: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1472: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1475: Use equals() to compare object references. +src/net/sf/freecol/client/gui/Canvas.java:1487: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1494: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1501: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1508: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1521: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1521: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1521: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1521: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1522: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1522: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1523: Local variable 'fcd' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1529: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1540: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1540: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1540: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1540: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1541: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1541: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1542: Local variable 'fcd' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1548: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1559: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1559: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1559: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1560: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1561: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1561: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1562: Local variable 'fcd' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1577: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1578: Avoid variables with short names like pp +src/net/sf/freecol/client/gui/Canvas.java:1578: Found 'DU'-anomaly for variable 'pp' (lines '1,578'-'1,601'). +src/net/sf/freecol/client/gui/Canvas.java:1578: Local variable 'pp' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1583: Local variable 'canvasWidth' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1584: Local variable 'dialogWidth' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1586: Found 'DU'-anomaly for variable 'location' (lines '1,586'-'1,601'). +src/net/sf/freecol/client/gui/Canvas.java:1586: Local variable 'location' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1598: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1606: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1606: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1608: Local variable 'trip' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1610: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1616: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1625: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1625: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1626: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1639: Parameter 'callBack' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1639: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1639: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/Canvas.java:1639: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1640: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1652: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/Canvas.java:1652: Parameter 'gl' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1652: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1652: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1653: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1665: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1667: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1677: Parameter 'ffs' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1677: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1678: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1690: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1691: Local variable 'dialog' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1692: Found 'DD'-anomaly for variable 'group' (lines '1,692'-'1,695'). +src/net/sf/freecol/client/gui/Canvas.java:1702: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1713: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1713: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1721: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1730: Parameter 'nodeId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1730: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1741: Avoid variables with short names like al +src/net/sf/freecol/client/gui/Canvas.java:1741: Parameter 'al' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1741: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1742: Local variable 'ccp' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1750: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1751: Local variable 'details' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1762: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1762: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1763: Local variable 'details' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1774: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1783: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1796: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1796: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1797: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1797: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1809: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1809: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1809: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1822: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1822: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1832: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1832: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1837: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1846: Parameter 'fountainOfYouth' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1846: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1846: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1847: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1861: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1861: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1862: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1874: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1874: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1886: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1886: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1886: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1887: Found 'DD'-anomaly for variable 'display' (lines '1,887'-'1,889'). +src/net/sf/freecol/client/gui/Canvas.java:1891: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:1892: Local variable 'errorPanel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1901: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1902: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:1905: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1905: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:1918: Parameter 'footer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1918: Parameter 'header' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1918: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1918: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1926: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1931: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:1943: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1943: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1943: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1944: Parameter 'settlementCount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1944: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1945: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1958: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1958: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1960: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:1973: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1973: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1974: Parameter 'custom' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1975: Local variable 'god' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1986: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1986: Parameter 'scores' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1986: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1996: Parameter 'indianSettlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:1996: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:1997: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2009: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2010: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:2019: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2020: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:2021: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2021: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2030: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2030: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2031: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2032: Found 'DD'-anomaly for variable 'icon' (lines '2,032'-'2,035'). +src/net/sf/freecol/client/gui/Canvas.java:2033: Found 'DD'-anomaly for variable 'tile' (lines '2,033'-'2,036'). +src/net/sf/freecol/client/gui/Canvas.java:2036: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2036: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2037: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2038: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:2051: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2051: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2052: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2052: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2053: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2054: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2067: Avoid reassigning parameters such as 'filters' +src/net/sf/freecol/client/gui/Canvas.java:2067: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/Canvas.java:2067: Parameter 'directory' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2067: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2068: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2069: Found 'DD'-anomaly for variable 'response' (lines '2,069'-'2,071'). +src/net/sf/freecol/client/gui/Canvas.java:2071: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/Canvas.java:2074: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2080: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2090: Parameter 'publicServer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2090: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2091: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2099: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2110: Parameter 'userMsg' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2110: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2115: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2122: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2123: Avoid variables with short names like f +src/net/sf/freecol/client/gui/Canvas.java:2123: Local variable 'f' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2135: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2135: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2136: Local variable 'mgod' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2146: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2155: Parameter 'messages' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2155: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2156: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2157: Found 'DU'-anomaly for variable 'game' (lines '2,157'-'2,176'). +src/net/sf/freecol/client/gui/Canvas.java:2158: Avoid variables with short names like n +src/net/sf/freecol/client/gui/Canvas.java:2158: Local variable 'n' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2159: Found 'DD'-anomaly for variable 'texts' (lines '2,159'-'2,165'). +src/net/sf/freecol/client/gui/Canvas.java:2160: Found 'DD'-anomaly for variable 'fcos' (lines '2,160'-'2,166'). +src/net/sf/freecol/client/gui/Canvas.java:2161: Found 'DD'-anomaly for variable 'icons' (lines '2,161'-'2,167'). +src/net/sf/freecol/client/gui/Canvas.java:2164: Avoid variables with short names like m +src/net/sf/freecol/client/gui/Canvas.java:2164: Local variable 'm' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2165: Found 'DD'-anomaly for variable 'texts' (lines '2,165'-'2,165'). +src/net/sf/freecol/client/gui/Canvas.java:2166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:2167: Found 'DD'-anomaly for variable 'icons' (lines '2,167'-'2,167'). +src/net/sf/freecol/client/gui/Canvas.java:2167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:2169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2178: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2187: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2187: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2188: Parameter 'monarchKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2188: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2189: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2196: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2205: Parameter 'defaultName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2205: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2205: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2206: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2206: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2215: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2225: Parameter 'our' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2225: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2226: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2227: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2228: Parameter 'comment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2229: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2229: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2230: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2230: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2231: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2231: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2232: Avoid throwing raw exception types. +src/net/sf/freecol/client/gui/Canvas.java:2234: Local variable 'dtd' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2236: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2236: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2244: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2244: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2255: Avoid variables with short names like vp +src/net/sf/freecol/client/gui/Canvas.java:2255: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2256: Avoid variables with short names like ml +src/net/sf/freecol/client/gui/Canvas.java:2257: Avoid variables with short names like kl +src/net/sf/freecol/client/gui/Canvas.java:2268: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2281: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2281: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2282: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2283: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2292: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2293: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2302: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2303: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2317: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2317: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2318: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2319: Parameter 'colonies' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2319: Parameter 'unitCount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2320: Local variable 'details' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2333: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2333: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2337: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2346: Avoid reassigning parameters such as 'filters' +src/net/sf/freecol/client/gui/Canvas.java:2346: Parameter 'directory' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2347: Parameter 'defaultName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2348: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2359: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2364: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2373: Parameter 'available' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2373: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2373: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2374: Parameter 'defaultAmount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2374: Parameter 'needToPay' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2375: Local variable 'fcd' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2378: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2390: Parameter 'question' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2390: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2391: Parameter 'maximum' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2392: Local variable 'fcd' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2394: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2405: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2405: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2417: Parameter 'serverList' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2417: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2432: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2432: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2433: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2434: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/Canvas.java:2434: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2435: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2448: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2448: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2448: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2449: Parameter 'singlePlayerMode' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2464: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2468: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2478: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2478: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2488: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2488: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2489: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2493: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/Canvas.java:2503: Avoid variables with short names like x +src/net/sf/freecol/client/gui/Canvas.java:2503: Avoid variables with short names like y +src/net/sf/freecol/client/gui/Canvas.java:2503: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2503: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2503: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2503: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2504: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2506: Avoid variables with short names like tp +src/net/sf/freecol/client/gui/Canvas.java:2506: Local variable 'tp' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2520: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2520: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2522: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/Canvas.java:2532: Parameter 'newRoute' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2532: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2533: Parameter 'callBack' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2533: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/Canvas.java:2534: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2542: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2543: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2554: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2554: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2568: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2568: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2578: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2578: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2585: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2586: Avoid variables with short names like rp +src/net/sf/freecol/client/gui/Canvas.java:2586: Local variable 'rp' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2588: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2588: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:2589: Avoid variables with short names like pp +src/net/sf/freecol/client/gui/Canvas.java:2589: Local variable 'pp' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2591: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:2592: Avoid variables with short names like tp +src/net/sf/freecol/client/gui/Canvas.java:2592: Local variable 'tp' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2594: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/Canvas.java:2594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/Canvas.java:2599: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2600: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2600: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2607: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2610: Found 'DD'-anomaly for variable 'compact' (lines '2,610'-'2,614'). +src/net/sf/freecol/client/gui/Canvas.java:2610: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/Canvas.java:2613: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/Canvas.java:2616: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2616: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2616: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2616: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2620: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2620: Useless parentheses. +src/net/sf/freecol/client/gui/Canvas.java:2627: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2628: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2629: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2636: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2637: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2637: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2644: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2645: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2645: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2652: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2653: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2653: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2660: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2661: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2661: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2668: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2669: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2669: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2676: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2677: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2677: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2684: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2685: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2685: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2692: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2693: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2693: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2700: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2701: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2701: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2708: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2709: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2709: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2716: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2717: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2717: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2724: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2725: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2725: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2737: Parameter 'messages' is not assigned and could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2737: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/Canvas.java:2738: Avoid variables with short names like r +src/net/sf/freecol/client/gui/Canvas.java:2738: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/Canvas.java:2742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:20: Possible God class (WMC=48, ATFD=65, TCC=0.13333333333333333) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:46: The class 'CanvasMapEditorMouseListener' has a Cyclomatic Complexity of 5 (Highest = 19). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:46: The class 'CanvasMapEditorMouseListener' has a Modified Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:46: The class 'CanvasMapEditorMouseListener' has a Standard Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:60: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:60: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:79: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:90: Parameter 'component' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:91: Parameter 'endPoint' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:91: Parameter 'startPoint' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:92: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:97: Local variable 'graphics' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:99: Avoid variables with short names like x +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:99: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:100: Avoid variables with short names like y +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:100: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:101: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:102: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:113: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:113: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:114: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:117: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:122: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:131: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:131: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:131: The method 'mousePressed' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:131: The method 'mousePressed' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:131: The method 'mousePressed' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:132: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:136: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:137: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:142: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:148: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:149: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:151: Found 'DU'-anomaly for variable 'river' (lines '151'-'171'). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:151: Local variable 'river' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:152: Local variable 'style' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:153: Avoid empty if statements +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:153: Avoid empty if statements +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:155: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:156: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:168: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:177: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:177: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:177: The method 'mouseReleased' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:177: The method 'mouseReleased' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:177: The method 'mouseReleased' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:177: The method mouseReleased() has an NPath complexity of 15360 +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:178: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:180: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:180: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:187: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:189: Local variable 'start' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:190: Local variable 'end' could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:190: Use equals() to compare object references. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:198: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:203: Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'max_x' is not final. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:203: Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'max_y' is not final. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:203: Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'min_x' is not final. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:203: Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'min_y' is not final. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:203: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:212: Found 'DU'-anomaly for variable 'min_y' (lines '212'-'241'). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:213: Found 'DU'-anomaly for variable 'max_y' (lines '213'-'241'). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:220: Avoid variables with short names like t +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:220: Found 'DD'-anomaly for variable 't' (lines '220'-'223'). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:220: Found 'DD'-anomaly for variable 't' (lines '220'-'232'). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:220: Found 'DU'-anomaly for variable 't' (lines '220'-'241'). +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:223: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:247: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:247: Document empty method +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:247: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:253: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:253: Document empty method +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:253: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:262: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:262: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:263: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:272: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:279: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:279: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMapEditorMouseListener.java:280: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMouseListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/CanvasMouseListener.java:42: The class 'CanvasMouseListener' has a Cyclomatic Complexity of 5 (Highest = 13). +src/net/sf/freecol/client/gui/CanvasMouseListener.java:42: The class 'CanvasMouseListener' has a Modified Cyclomatic Complexity of 4 (Highest = 10). +src/net/sf/freecol/client/gui/CanvasMouseListener.java:42: The class 'CanvasMouseListener' has a Standard Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/client/gui/CanvasMouseListener.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMouseListener.java:46: Variables that are final and static should be all capitals, 'doubleClickDelay' is not all capitals. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMouseListener.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMouseListener.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMouseListener.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMouseListener.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMouseListener.java:63: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:63: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:74: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMouseListener.java:74: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:76: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/CanvasMouseListener.java:77: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:78: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:78: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/CanvasMouseListener.java:100: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMouseListener.java:100: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:110: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMouseListener.java:110: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:120: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMouseListener.java:120: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:120: The method 'mousePressed' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:120: The method 'mousePressed' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:120: The method 'mousePressed' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/CanvasMouseListener.java:121: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMouseListener.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:123: Avoid variables with short names like me +src/net/sf/freecol/client/gui/CanvasMouseListener.java:123: Found 'DD'-anomaly for variable 'me' (lines '123'-'124'). +src/net/sf/freecol/client/gui/CanvasMouseListener.java:124: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMouseListener.java:125: Found 'DU'-anomaly for variable 'tile' (lines '125'-'167'). +src/net/sf/freecol/client/gui/CanvasMouseListener.java:125: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:132: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:151: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:153: Local variable 'dragPath' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:161: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/CanvasMouseListener.java:175: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMouseListener.java:175: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:177: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/CanvasMouseListener.java:178: Local variable 'temp' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:188: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/CanvasMouseListener.java:200: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/CanvasMouseListener.java:200: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:202: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:205: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseListener.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseListener.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:39: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:39: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:56: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:56: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:67: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:67: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:77: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:80: These nested if statements could be combined +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:80: Use equals() to compare object references. +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:81: Local variable 'active' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:83: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:83: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:84: Local variable 'dragPath' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:100: Avoid variables with short names like e +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:100: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:104: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:106: Useless parentheses. +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:106: Useless parentheses. +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:110: Local variable 'active' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:113: Use equals() to compare object references. +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:115: Local variable 'dragPath' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:120: Local variable 'dragPoint' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:121: Local variable 'deltaX' could be declared final +src/net/sf/freecol/client/gui/CanvasMouseMotionListener.java:122: Local variable 'deltaY' could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ChatDisplay.java:42: Avoid using implementation types like 'ArrayList'; use the interface instead +src/net/sf/freecol/client/gui/ChatDisplay.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ChatDisplay.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChatDisplay.java:54: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:54: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/ChatDisplay.java:61: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ChatDisplay.java:70: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:92: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ChatDisplay.java:92: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:92: Parameter 'lib' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:92: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:92: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/ChatDisplay.java:95: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:98: Avoid variables with short names like si +src/net/sf/freecol/client/gui/ChatDisplay.java:98: Local variable 'si' could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:100: Avoid variables with short names like yy +src/net/sf/freecol/client/gui/ChatDisplay.java:100: Found 'DU'-anomaly for variable 'yy' (lines '100'-'120'). +src/net/sf/freecol/client/gui/ChatDisplay.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:101: Avoid variables with short names like xx +src/net/sf/freecol/client/gui/ChatDisplay.java:101: Found 'DU'-anomaly for variable 'xx' (lines '101'-'120'). +src/net/sf/freecol/client/gui/ChatDisplay.java:101: Local variable 'xx' could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:111: Found 'DU'-anomaly for variable 'width' (lines '111'-'120'). +src/net/sf/freecol/client/gui/ChatDisplay.java:111: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ChatDisplay.java:130: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/ChatDisplay.java:131: Found 'DU'-anomaly for variable 'currentTime' (lines '131'-'145'). +src/net/sf/freecol/client/gui/ChatDisplay.java:131: Local variable 'currentTime' could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:132: Found 'DD'-anomaly for variable 'result' (lines '132'-'138'). +src/net/sf/freecol/client/gui/ChatDisplay.java:134: Avoid variables with short names like i +src/net/sf/freecol/client/gui/ChatDisplay.java:136: Local variable 'creationTime' could be declared final +src/net/sf/freecol/client/gui/ChatDisplay.java:136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ChatDisplay.java:138: Found 'DD'-anomaly for variable 'result' (lines '138'-'138'). +src/net/sf/freecol/client/gui/ChoiceItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ChoiceItem.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ChoiceItem.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChoiceItem.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChoiceItem.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChoiceItem.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChoiceItem.java:40: Avoid using redundant field initializer for 'optionOK' +src/net/sf/freecol/client/gui/ChoiceItem.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ChoiceItem.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChoiceItem.java:41: Avoid using redundant field initializer for 'optionCancel' +src/net/sf/freecol/client/gui/ChoiceItem.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ChoiceItem.java:41: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChoiceItem.java:42: Avoid using redundant field initializer for 'optionDefault' +src/net/sf/freecol/client/gui/ChoiceItem.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ChoiceItem.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ChoiceItem.java:53: Parameter 'enable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChoiceItem.java:53: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChoiceItem.java:53: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChoiceItem.java:56: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/ChoiceItem.java:68: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChoiceItem.java:68: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChoiceItem.java:78: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChoiceItem.java:144: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ChoiceItem.java:212: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/DialogHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/DialogHandler.java:28: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FontLibrary.java:32: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/FontLibrary.java:34: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/FontLibrary.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:36: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FontLibrary.java:52: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FontLibrary.java:75: Avoid using redundant field initializer for 'mainFont' +src/net/sf/freecol/client/gui/FontLibrary.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/FontLibrary.java:97: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:108: Parameter 'fontName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:108: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:108: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/FontLibrary.java:110: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/FontLibrary.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/FontLibrary.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/FontLibrary.java:118: There is log block not surrounded by if +src/net/sf/freecol/client/gui/FontLibrary.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FontLibrary.java:123: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:123: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:123: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:135: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:135: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:136: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:140: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:140: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:140: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:141: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:146: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:146: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:146: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:147: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:147: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:152: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:152: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:152: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:156: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FontLibrary.java:168: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:168: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:169: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:173: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:173: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:173: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:174: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:178: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:178: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:178: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:179: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:183: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:183: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:183: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:184: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:184: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:188: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:188: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:188: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FontLibrary.java:189: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:190: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:195: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FontLibrary.java:209: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:209: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:210: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:210: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:211: Local variable 'scaledSize' could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:212: Local variable 'fontKey' could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:213: Found 'DD'-anomaly for variable 'font' (lines '213'-'216'). +src/net/sf/freecol/client/gui/FontLibrary.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/FontLibrary.java:220: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FontLibrary.java:234: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:234: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:235: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:236: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:236: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:240: Local variable 'scaledSize' could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:241: Found 'DD'-anomaly for variable 'fontKey' (lines '241'-'249'). +src/net/sf/freecol/client/gui/FontLibrary.java:241: Found 'DU'-anomaly for variable 'fontKey' (lines '241'-'256'). +src/net/sf/freecol/client/gui/FontLibrary.java:242: Found 'DD'-anomaly for variable 'font' (lines '242'-'244'). +src/net/sf/freecol/client/gui/FontLibrary.java:245: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/FontLibrary.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/FontLibrary.java:246: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/FontLibrary.java:250: Found 'DD'-anomaly for variable 'font' (lines '250'-'254'). +src/net/sf/freecol/client/gui/FontLibrary.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/FontLibrary.java:258: Found 'UR'-anomaly for variable 'pixelSize' (lines '258'-'278'). +src/net/sf/freecol/client/gui/FontLibrary.java:258: Parameter 'fontSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:258: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:260: A switch statement does not contain a break +src/net/sf/freecol/client/gui/FontLibrary.java:260: The default label should be the last label in a switch statement +src/net/sf/freecol/client/gui/FontLibrary.java:281: Found 'UR'-anomaly for variable 'fontName' (lines '281'-'295'). +src/net/sf/freecol/client/gui/FontLibrary.java:281: Parameter 'fontType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FontLibrary.java:283: A switch statement does not contain a break +src/net/sf/freecol/client/gui/FontLibrary.java:283: The default label should be the last label in a switch statement +src/net/sf/freecol/client/gui/FontLibrary.java:287: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/FontLibrary.java:287: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/FrameMotionListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FrameMotionListener.java:37: Avoid variables with short names like f +src/net/sf/freecol/client/gui/FrameMotionListener.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/FrameMotionListener.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/FrameMotionListener.java:39: Avoid using redundant field initializer for 'loc' +src/net/sf/freecol/client/gui/FrameMotionListener.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/FrameMotionListener.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/FrameMotionListener.java:42: Avoid variables with short names like f +src/net/sf/freecol/client/gui/FrameMotionListener.java:42: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/FrameMotionListener.java:42: Parameter 'f' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FrameMotionListener.java:47: Avoid variables with short names like e +src/net/sf/freecol/client/gui/FrameMotionListener.java:47: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FrameMotionListener.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FrameMotionListener.java:48: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:52: Avoid variables with short names like p +src/net/sf/freecol/client/gui/FrameMotionListener.java:52: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/FrameMotionListener.java:53: Local variable 'moveX' could be declared final +src/net/sf/freecol/client/gui/FrameMotionListener.java:54: Local variable 'moveY' could be declared final +src/net/sf/freecol/client/gui/FrameMotionListener.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:64: Avoid variables with short names like e +src/net/sf/freecol/client/gui/FrameMotionListener.java:64: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FrameMotionListener.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FrameMotionListener.java:65: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:73: Avoid variables with short names like e +src/net/sf/freecol/client/gui/FrameMotionListener.java:73: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FrameMotionListener.java:73: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FrameMotionListener.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FrameMotionListener.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FreeColFrame.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FreeColFrame.java:48: The class 'FreeColFrame' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/client/gui/FreeColFrame.java:50: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/FreeColFrame.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/FreeColFrame.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/FreeColFrame.java:59: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FreeColFrame.java:69: Avoid variables with short names like gd +src/net/sf/freecol/client/gui/FreeColFrame.java:69: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:69: Parameter 'gd' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:69: The constructor 'FreeColFrame' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/FreeColFrame.java:70: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:70: Parameter 'menuBar' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:70: Parameter 'windowed' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:71: Avoid reassigning parameters such as 'bounds' +src/net/sf/freecol/client/gui/FreeColFrame.java:71: Avoid reassigning parameters such as 'bounds' +src/net/sf/freecol/client/gui/FreeColFrame.java:91: Local variable 'insets' could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:100: Local variable 'screenInsets' could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:110: There is log block not surrounded by if +src/net/sf/freecol/client/gui/FreeColFrame.java:110: There is log block not surrounded by if +src/net/sf/freecol/client/gui/FreeColFrame.java:114: Avoid variables with short names like e +src/net/sf/freecol/client/gui/FreeColFrame.java:114: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:114: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:115: There is log block not surrounded by if +src/net/sf/freecol/client/gui/FreeColFrame.java:115: There is log block not surrounded by if +src/net/sf/freecol/client/gui/FreeColFrame.java:121: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:122: Local variable 'GraphicsConf' could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:122: Variables should start with a lowercase character, 'GraphicsConf' starts with uppercase character. +src/net/sf/freecol/client/gui/FreeColFrame.java:123: Avoid variables with short names like gd +src/net/sf/freecol/client/gui/FreeColFrame.java:123: Local variable 'gd' could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/FreeColFrame.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/FreeColFrame.java:127: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:133: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:138: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:143: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:144: Local variable 'menuBar' could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FreeColFrame.java:150: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/FreeColFrame.java:151: Local variable 'menuBar' could be declared final +src/net/sf/freecol/client/gui/FreeColFrame.java:153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FreeColFrame.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/FreeColFrame.java:179: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:44: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:45: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:56: Document empty method +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:56: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:65: Document empty method +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:65: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:74: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:88: Document empty method +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:88: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:97: Document empty method +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:97: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:106: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:123: Document empty method +src/net/sf/freecol/client/gui/FullScreenFrameListener.java:123: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/GUI.java:20: High amount of different objects as members denotes a high coupling +src/net/sf/freecol/client/gui/GUI.java:20: Possible God class (WMC=237, ATFD=119, TCC=0.0) +src/net/sf/freecol/client/gui/GUI.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/client/gui/GUI.java:83: Avoid really long classes. +src/net/sf/freecol/client/gui/GUI.java:83: Avoid short class names like GUI +src/net/sf/freecol/client/gui/GUI.java:83: The class 'GUI' has a Cyclomatic Complexity of 1 (Highest = 10). +src/net/sf/freecol/client/gui/GUI.java:83: The class 'GUI' has a Standard Cyclomatic Complexity of 1 (Highest = 10). +src/net/sf/freecol/client/gui/GUI.java:83: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/GUI.java:85: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/GUI.java:85: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:88: Variables that are final and static should be all capitals, 'levels' is not all capitals. +src/net/sf/freecol/client/gui/GUI.java:94: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:97: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/GUI.java:109: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:109: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:117: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:121: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:125: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:136: Document empty method +src/net/sf/freecol/client/gui/GUI.java:136: Parameter 'fontName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:142: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/client/gui/GUI.java:142: Document empty method +src/net/sf/freecol/client/gui/GUI.java:151: Document empty method +src/net/sf/freecol/client/gui/GUI.java:151: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:157: Document empty method +src/net/sf/freecol/client/gui/GUI.java:165: Document empty method +src/net/sf/freecol/client/gui/GUI.java:171: Document empty method +src/net/sf/freecol/client/gui/GUI.java:179: Document empty method +src/net/sf/freecol/client/gui/GUI.java:194: Document empty method +src/net/sf/freecol/client/gui/GUI.java:200: Document empty method +src/net/sf/freecol/client/gui/GUI.java:209: Document empty method +src/net/sf/freecol/client/gui/GUI.java:215: Document empty method +src/net/sf/freecol/client/gui/GUI.java:218: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:228: Local variable 'miniMap' could be declared final +src/net/sf/freecol/client/gui/GUI.java:230: Local variable 'game' could be declared final +src/net/sf/freecol/client/gui/GUI.java:231: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/GUI.java:231: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:233: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/GUI.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:234: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/GUI.java:236: Avoid variables with short names like g1 +src/net/sf/freecol/client/gui/GUI.java:236: Local variable 'g1' could be declared final +src/net/sf/freecol/client/gui/GUI.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:240: Local variable 'scaledWidth' could be declared final +src/net/sf/freecol/client/gui/GUI.java:241: Local variable 'scaledImage' could be declared final +src/net/sf/freecol/client/gui/GUI.java:243: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/GUI.java:243: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/GUI.java:244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:249: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:258: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:258: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:259: Document empty method +src/net/sf/freecol/client/gui/GUI.java:259: Parameter 'privateChat' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:265: Document empty method +src/net/sf/freecol/client/gui/GUI.java:271: Document empty method +src/net/sf/freecol/client/gui/GUI.java:274: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:278: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:282: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:286: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:290: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:300: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:307: Document empty method +src/net/sf/freecol/client/gui/GUI.java:319: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:323: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:332: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:332: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:333: Parameter 'attackerTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:333: Parameter 'defenderTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:334: Document empty method +src/net/sf/freecol/client/gui/GUI.java:334: Parameter 'success' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:344: Document empty method +src/net/sf/freecol/client/gui/GUI.java:344: Parameter 'dstTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:344: Parameter 'srcTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:344: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:357: Document empty method +src/net/sf/freecol/client/gui/GUI.java:357: Parameter 'enable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:360: Document empty method +src/net/sf/freecol/client/gui/GUI.java:360: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:363: Document empty method +src/net/sf/freecol/client/gui/GUI.java:363: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:366: Document empty method +src/net/sf/freecol/client/gui/GUI.java:366: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:369: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:373: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:377: Document empty method +src/net/sf/freecol/client/gui/GUI.java:377: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:380: Document empty method +src/net/sf/freecol/client/gui/GUI.java:380: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:394: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:394: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:394: Parameter 'textKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:398: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:407: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:407: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:408: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:408: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:412: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:422: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:422: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:422: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:423: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:423: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:427: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:427: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:427: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:428: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:429: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:429: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:433: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:433: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:433: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:434: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:435: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:435: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:447: Parameter 'leaveColony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:447: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:447: The method confirmAbandonEducation() has an NPath complexity of 390 +src/net/sf/freecol/client/gui/GUI.java:448: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:448: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/GUI.java:449: Local variable 'teacher' could be declared final +src/net/sf/freecol/client/gui/GUI.java:452: Local variable 'student' could be declared final +src/net/sf/freecol/client/gui/GUI.java:453: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:453: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/GUI.java:455: Local variable 'school' could be declared final +src/net/sf/freecol/client/gui/GUI.java:455: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:455: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:455: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:456: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:457: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/GUI.java:458: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:458: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:458: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:460: The String literal "%unit%" appears 4 times in this file; the first occurrence is on line 460 +src/net/sf/freecol/client/gui/GUI.java:461: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:463: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:463: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:467: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:467: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:470: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/GUI.java:483: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:484: Avoid variables with short names like tr +src/net/sf/freecol/client/gui/GUI.java:484: Local variable 'tr' could be declared final +src/net/sf/freecol/client/gui/GUI.java:485: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:485: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/GUI.java:486: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:500: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:503: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:512: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:512: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:513: Avoid variables with short names like ns +src/net/sf/freecol/client/gui/GUI.java:513: Parameter 'ns' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:514: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/GUI.java:515: Local variable 'other' could be declared final +src/net/sf/freecol/client/gui/GUI.java:516: Local variable 'strength' could be declared final +src/net/sf/freecol/client/gui/GUI.java:516: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:517: Local variable 'otherStrength' could be declared final +src/net/sf/freecol/client/gui/GUI.java:518: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/GUI.java:518: Found 'DU'-anomaly for variable 'mil' (lines '518'-'539'). +src/net/sf/freecol/client/gui/GUI.java:518: Local variable 'mil' could be declared final +src/net/sf/freecol/client/gui/GUI.java:518: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:518: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:522: Avoid variables with short names like t +src/net/sf/freecol/client/gui/GUI.java:523: Local variable 'gold' could be declared final +src/net/sf/freecol/client/gui/GUI.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:526: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:526: The String literal "%nation%" appears 7 times in this file; the first occurrence is on line 526 +src/net/sf/freecol/client/gui/GUI.java:528: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:531: Local variable 'fin' could be declared final +src/net/sf/freecol/client/gui/GUI.java:531: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:531: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:533: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:535: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:537: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:549: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:549: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:549: The method 'confirmHostileAction' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/GUI.java:549: The method 'confirmHostileAction' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/GUI.java:552: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:561: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:561: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/GUI.java:563: Local variable 'defender' could be declared final +src/net/sf/freecol/client/gui/GUI.java:566: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:568: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:570: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:572: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:576: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:579: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:593: The String literal "cancel" appears 10 times in this file; the first occurrence is on line 593 +src/net/sf/freecol/client/gui/GUI.java:604: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:605: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/GUI.java:606: Local variable 'message' could be declared final +src/net/sf/freecol/client/gui/GUI.java:606: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:609: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:614: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:623: Avoid variables with short names like is +src/net/sf/freecol/client/gui/GUI.java:623: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:623: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:624: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/GUI.java:625: Local variable 'other' could be declared final +src/net/sf/freecol/client/gui/GUI.java:626: Local variable 'strength' could be declared final +src/net/sf/freecol/client/gui/GUI.java:626: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:627: Local variable 'messageId' could be declared final +src/net/sf/freecol/client/gui/GUI.java:627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:627: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:627: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:631: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:631: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:634: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:634: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:634: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:634: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:634: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:634: Useless parentheses. +src/net/sf/freecol/client/gui/GUI.java:636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:649: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:649: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:650: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:652: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/GUI.java:654: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/GUI.java:654: Local variable 'defender' could be declared final +src/net/sf/freecol/client/gui/GUI.java:656: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:678: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:681: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:692: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:701: Parameter 'europe' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:701: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:702: Local variable 'arrears' could be declared final +src/net/sf/freecol/client/gui/GUI.java:702: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:703: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:703: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:703: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:703: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:705: The String literal "%goods%" appears 4 times in this file; the first occurrence is on line 705 +src/net/sf/freecol/client/gui/GUI.java:709: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:719: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:729: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:729: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:730: Parameter 'canBuy' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:730: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:730: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:731: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:731: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:731: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:731: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:731: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:732: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:736: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:746: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:755: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:755: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:755: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:756: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:757: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:760: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:762: Local variable 'pay' could be declared final +src/net/sf/freecol/client/gui/GUI.java:762: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:778: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:789: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:790: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:791: Parameter 'canBuy' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:792: Parameter 'canSell' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:793: Parameter 'canGift' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:795: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:808: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:808: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/GUI.java:814: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:825: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:826: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:827: Parameter 'canEstablish' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:828: Parameter 'canDenounce' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:829: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:829: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:829: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:829: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:835: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:860: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:860: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:861: Local variable 'suggested' could be declared final +src/net/sf/freecol/client/gui/GUI.java:862: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/GUI.java:865: Avoid empty if statements +src/net/sf/freecol/client/gui/GUI.java:865: Avoid empty if statements +src/net/sf/freecol/client/gui/GUI.java:867: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:869: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/GUI.java:871: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:871: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:875: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/GUI.java:889: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:890: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:891: Parameter 'neg' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:892: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:892: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:892: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:896: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:917: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:918: Parameter 'numberString' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:922: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:925: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:925: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:925: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:925: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:925: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:927: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:931: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:931: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:931: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:934: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:934: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:934: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:935: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:940: Local variable 'wantedGoods' could be declared final +src/net/sf/freecol/client/gui/GUI.java:943: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/GUI.java:946: Avoid variables with short names like t +src/net/sf/freecol/client/gui/GUI.java:946: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/GUI.java:949: Local variable 'tradeKey' could be declared final +src/net/sf/freecol/client/gui/GUI.java:950: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:950: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:952: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:952: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:955: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:968: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:977: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:977: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:978: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:978: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:979: Local variable 'goodsTemplate' could be declared final +src/net/sf/freecol/client/gui/GUI.java:980: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/GUI.java:980: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:980: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:980: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:980: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:981: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:985: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/GUI.java:990: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:990: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:1000: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:1010: Parameter 'explain' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1010: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1011: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1011: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1015: Parameter 'explain' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1015: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1015: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1015: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1016: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1016: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1020: Parameter 'explain' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1020: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1020: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1020: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1021: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1021: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1025: Parameter 'explain' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1025: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1025: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1025: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1026: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1026: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1030: Parameter 'explain' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1030: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1030: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1030: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1031: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1031: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1035: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUI.java:1045: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1045: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1046: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1047: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1047: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1051: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1051: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1054: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1054: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1057: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1057: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1060: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1064: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1068: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1072: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1076: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1080: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1080: Parameter 'rectangle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1080: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1083: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1083: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1086: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1086: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1089: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1089: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1092: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1092: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1095: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1099: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1099: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1102: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1102: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1105: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/GUI.java:1105: Parameter 'gl' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1105: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1106: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1106: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1109: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1109: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1112: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1113: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1113: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1116: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1116: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1124: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1124: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/GUI.java:1126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:1138: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1138: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1138: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1141: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1141: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1141: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1141: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1144: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1144: Parameter 'nodeId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1144: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1147: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1147: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1150: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1150: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1153: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1157: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1157: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1158: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1158: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1161: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1161: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1165: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1167: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1167: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1170: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1171: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1171: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1174: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1174: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1174: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1177: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1177: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1177: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1180: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1180: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1180: Parameter 'messageID' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1180: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1183: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1183: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1186: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1186: Parameter 'footer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1186: Parameter 'header' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1186: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1186: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1189: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1189: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1192: Parameter 'custom' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1192: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1192: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1196: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1196: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1196: Parameter 'scores' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1196: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1199: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1199: Parameter 'indianSettlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1199: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1202: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1202: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1206: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1206: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1210: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1210: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1211: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1215: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1215: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1216: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1220: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1220: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1221: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1225: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1225: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1226: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1230: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1230: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1231: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1235: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1235: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1236: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1240: Parameter 'displayObject' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1240: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1241: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1245: Parameter 'directory' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1245: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1249: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GUI.java:1253: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/GUI.java:1258: Parameter 'publicServer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1258: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1259: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1263: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1263: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1266: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1266: Parameter 'userMsg' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1266: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1269: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1269: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1273: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1277: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1277: Parameter 'modelMessages' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1277: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1280: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1281: Parameter 'monarchKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1281: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1282: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1282: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1285: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1285: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1288: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1288: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1291: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1292: Parameter 'settlementCount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1293: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1293: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1296: Parameter 'our' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1296: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1297: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1298: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1299: Parameter 'comment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1303: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1303: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1306: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1306: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1306: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1309: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1309: Parameter 'callback' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1309: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/GUI.java:1309: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1312: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1316: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1316: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1317: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1317: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1321: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1321: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1324: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1324: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1327: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1327: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1330: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1330: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1333: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1333: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1336: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1336: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1339: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1339: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1342: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1342: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1345: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1345: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1348: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1348: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1351: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1351: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1354: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1354: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1357: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1357: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1360: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1360: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1363: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1363: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1366: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1366: Parameter 'messages' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1366: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1369: Parameter 'defaultName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1369: Parameter 'directory' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1369: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1373: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1377: Parameter 'available' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1377: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1377: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1378: Parameter 'defaultAmount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1378: Parameter 'needToPay' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1382: Parameter 'question' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1382: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1383: Parameter 'maximum' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1387: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1387: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1391: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1391: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1391: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1392: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1392: Parameter 'singlePlayerMode' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1395: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1395: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1398: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1398: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1398: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1401: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1401: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1404: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1404: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1404: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1407: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1407: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1407: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1410: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1410: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1413: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1413: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1416: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1416: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1419: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1419: Parameter 'newViewMode' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1419: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1422: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1426: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1430: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1434: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1438: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1438: Parameter 'tileToFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1438: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1441: Parameter 'newTileToSelect' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1441: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1445: Document empty method +src/net/sf/freecol/client/gui/GUI.java:1445: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/GUI.java:1456: Parameter 'sound' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1457: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:1465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:1467: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:1480: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GUI.java:1491: Parameter 'runnable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1491: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/GUI.java:1505: Parameter 'runnable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUI.java:1505: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/GUIMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GUIMessage.java:34: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/GUIMessage.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/GUIMessage.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/GUIMessage.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/GUIMessage.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/GUIMessage.java:48: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GUIMessage.java:48: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GrayLayer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/GrayLayer.java:52: Avoid excessively long variable names like FONT_SIZE_DECREMENT +src/net/sf/freecol/client/gui/GrayLayer.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/GrayLayer.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/GrayLayer.java:70: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/GrayLayer.java:70: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GrayLayer.java:82: Avoid variables with short names like g +src/net/sf/freecol/client/gui/GrayLayer.java:82: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GrayLayer.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:98: Found 'DD'-anomaly for variable 'coatOfArmsIcon' (lines '98'-'108'). +src/net/sf/freecol/client/gui/GrayLayer.java:99: Found 'DD'-anomaly for variable 'message' (lines '99'-'103'). +src/net/sf/freecol/client/gui/GrayLayer.java:99: Found 'DD'-anomaly for variable 'message' (lines '99'-'110'). +src/net/sf/freecol/client/gui/GrayLayer.java:100: Found 'DD'-anomaly for variable 'colour' (lines '100'-'105'). +src/net/sf/freecol/client/gui/GrayLayer.java:100: Found 'DD'-anomaly for variable 'colour' (lines '100'-'111'). +src/net/sf/freecol/client/gui/GrayLayer.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:105: Found 'DU'-anomaly for variable 'colour' (lines '105'-'150'). +src/net/sf/freecol/client/gui/GrayLayer.java:111: Found 'DU'-anomaly for variable 'colour' (lines '111'-'150'). +src/net/sf/freecol/client/gui/GrayLayer.java:115: Found 'DD'-anomaly for variable 'nameFontMetrics' (lines '115'-'121'). +src/net/sf/freecol/client/gui/GrayLayer.java:118: Local variable 'maxWidth' could be declared final +src/net/sf/freecol/client/gui/GrayLayer.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/GrayLayer.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:127: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/GrayLayer.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:140: Local variable 'iconBounds' could be declared final +src/net/sf/freecol/client/gui/GrayLayer.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/GrayLayer.java:158: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/GrayLayer.java:159: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/ImageLibrary.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/ImageLibrary.java:20: Possible God class (WMC=178, ATFD=213, TCC=0.0880503144654088) +src/net/sf/freecol/client/gui/ImageLibrary.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/client/gui/ImageLibrary.java:77: Avoid really long classes. +src/net/sf/freecol/client/gui/ImageLibrary.java:77: The class 'ImageLibrary' has a Cyclomatic Complexity of 2 (Highest = 17). +src/net/sf/freecol/client/gui/ImageLibrary.java:77: The class 'ImageLibrary' has a Modified Cyclomatic Complexity of 2 (Highest = 17). +src/net/sf/freecol/client/gui/ImageLibrary.java:77: The class 'ImageLibrary' has a Standard Cyclomatic Complexity of 2 (Highest = 17). +src/net/sf/freecol/client/gui/ImageLibrary.java:77: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/ImageLibrary.java:79: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/ImageLibrary.java:79: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:81: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:96: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:100: Avoid excessively long variable names like TILE_OWNED_BY_INDIANS +src/net/sf/freecol/client/gui/ImageLibrary.java:107: enumCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:122: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:126: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:136: Avoid variables with short names like u +src/net/sf/freecol/client/gui/ImageLibrary.java:136: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:153: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ImageLibrary.java:153: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ImageLibrary.java:153: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ImageLibrary.java:153: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/ImageLibrary.java:153: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:155: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/client/gui/ImageLibrary.java:155: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ImageLibrary.java:155: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:164: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:177: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:196: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:196: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:200: Parameter 'scaleFactor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:200: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:200: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:205: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:214: Parameter 'background' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:215: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:215: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:216: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:216: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:229: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:230: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:230: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:239: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:249: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:249: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:249: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:249: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:250: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:250: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:250: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:250: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:261: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:261: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:261: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:261: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:261: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:263: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:263: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:275: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:275: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:275: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:275: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:275: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:277: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:277: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:281: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:292: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:292: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:293: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:293: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:293: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:293: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:294: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:306: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:310: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:310: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:310: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:315: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:315: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:316: Parameter 'riverStyle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:320: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:320: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:321: Parameter 'riverStyle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:322: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:324: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:332: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/ImageLibrary.java:334: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:346: Parameter 'father' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:346: Parameter 'grey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:347: Local variable 'resource' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:353: Parameter 'buildable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:353: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:353: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:355: Local variable 'scale' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:356: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:356: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:356: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:363: Parameter 'buildable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:363: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:363: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:364: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:364: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:364: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:370: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:370: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:375: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:375: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:380: Parameter 'buildingType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:380: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:381: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:381: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:382: The String literal "image.buildingicon." appears 4 times in this file; the first occurrence is on line 382 +src/net/sf/freecol/client/gui/ImageLibrary.java:390: Parameter 'buildingType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:390: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:391: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:396: Parameter 'buildingType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:396: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:397: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:402: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:402: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:407: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:407: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:412: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:412: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:417: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:417: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:421: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:421: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:425: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:425: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:429: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:429: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:429: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:433: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:433: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:433: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:443: Avoid variables with short names like id +src/net/sf/freecol/client/gui/ImageLibrary.java:443: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:447: Avoid variables with short names like id +src/net/sf/freecol/client/gui/ImageLibrary.java:447: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:447: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:447: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:451: Avoid variables with short names like id +src/net/sf/freecol/client/gui/ImageLibrary.java:451: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:451: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:451: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:463: Avoid reassigning parameters such as 'display' +src/net/sf/freecol/client/gui/ImageLibrary.java:463: Avoid reassigning parameters such as 'display' +src/net/sf/freecol/client/gui/ImageLibrary.java:463: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:463: The method 'getObjectImage' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/ImageLibrary.java:463: The method 'getObjectImage' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/ImageLibrary.java:463: The method 'getObjectImage' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/ImageLibrary.java:466: Found 'DU'-anomaly for variable 'size' (lines '466'-'508'). +src/net/sf/freecol/client/gui/ImageLibrary.java:469: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:471: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:475: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:478: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:481: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:486: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:489: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:492: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:495: There is log block not surrounded by if +src/net/sf/freecol/client/gui/ImageLibrary.java:496: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:500: There is log block not surrounded by if +src/net/sf/freecol/client/gui/ImageLibrary.java:501: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:503: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:504: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/ImageLibrary.java:516: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:526: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:530: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:539: Avoid variables with short names like id +src/net/sf/freecol/client/gui/ImageLibrary.java:539: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:539: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:540: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:541: Local variable 'prefix' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:542: Local variable 'keys' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:546: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:550: Parameter 'overlayCache' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:550: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:550: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:555: Avoid variables with short names like id +src/net/sf/freecol/client/gui/ImageLibrary.java:555: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:555: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:555: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:556: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:557: Parameter 'overlayCache' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:559: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:559: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:560: Avoid variables with short names like k +src/net/sf/freecol/client/gui/ImageLibrary.java:565: Parameter 'keys' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:566: Avoid variables with short names like id +src/net/sf/freecol/client/gui/ImageLibrary.java:566: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:566: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:567: Local variable 'count' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:570: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:572: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:586: Avoid variables with short names like pt +src/net/sf/freecol/client/gui/ImageLibrary.java:586: Parameter 'pt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:587: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/ImageLibrary.java:597: Avoid variables with short names like u +src/net/sf/freecol/client/gui/ImageLibrary.java:597: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:598: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/ImageLibrary.java:608: Avoid variables with short names like pt +src/net/sf/freecol/client/gui/ImageLibrary.java:608: Parameter 'pt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:609: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/ImageLibrary.java:619: Avoid variables with short names like u +src/net/sf/freecol/client/gui/ImageLibrary.java:619: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:620: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/ImageLibrary.java:630: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:641: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:641: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:646: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:657: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:657: Parameter 'magnitude' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:658: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:658: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:658: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:658: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:659: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:664: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:664: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:674: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:685: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:685: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:689: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:689: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:689: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:700: Parameter 'settlementType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:704: Parameter 'settlementType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:704: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:705: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:710: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:720: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:720: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:720: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:720: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:720: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:724: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:724: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:724: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:724: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:724: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:724: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:725: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:726: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:731: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:731: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:732: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:732: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:736: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:736: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:737: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:737: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:741: Parameter 'grayscale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:741: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:741: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:742: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:742: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:746: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:746: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:747: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:747: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:751: Parameter 'grayscale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:751: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:751: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:752: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:752: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:756: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:756: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:756: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:757: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:757: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:761: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:761: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:766: Parameter 'grayscale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:766: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:766: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:771: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:771: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:776: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:776: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:781: Parameter 'grayscale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:781: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:781: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:786: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:786: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:786: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:787: Parameter 'grayscale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:792: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:792: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:797: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:797: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:797: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:802: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:812: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:812: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:812: The method getUnitImage() has an NPath complexity of 750 +src/net/sf/freecol/client/gui/ImageLibrary.java:813: Avoid reassigning parameters such as 'nativeEthnicity' +src/net/sf/freecol/client/gui/ImageLibrary.java:814: Parameter 'grayscale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:814: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:821: Local variable 'roleQual' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:821: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:821: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:823: The String literal "image.unit." appears 5 times in this file; the first occurrence is on line 823 +src/net/sf/freecol/client/gui/ImageLibrary.java:824: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:824: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:828: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:828: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:828: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:834: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:834: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:834: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:839: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:839: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:839: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:840: Local variable 'roleId' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:841: Local variable 'roleQual' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:841: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:841: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:843: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:847: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:847: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:847: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:848: Avoid reassigning parameters such as 'nativeEthnicity' +src/net/sf/freecol/client/gui/ImageLibrary.java:849: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:856: Local variable 'roleQual' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:856: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:856: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:859: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:859: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:863: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:864: Consider simply returning the value vs storing it in local variable 'image' +src/net/sf/freecol/client/gui/ImageLibrary.java:870: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:881: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:881: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:881: Parameter 'resource' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:882: Avoid variables with short names like c +src/net/sf/freecol/client/gui/ImageLibrary.java:882: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:882: Parameter 'insets' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:885: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/ImageLibrary.java:897: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:898: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/ImageLibrary.java:898: Found 'DU'-anomaly for variable 'dx' (lines '898'-'911'). +src/net/sf/freecol/client/gui/ImageLibrary.java:898: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:898: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:899: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/ImageLibrary.java:899: Found 'DU'-anomaly for variable 'dy' (lines '899'-'911'). +src/net/sf/freecol/client/gui/ImageLibrary.java:899: Local variable 'dy' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:899: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:900: Local variable 'xmax' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:901: Found 'DU'-anomaly for variable 'ymax' (lines '901'-'911'). +src/net/sf/freecol/client/gui/ImageLibrary.java:901: Local variable 'ymax' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:913: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:923: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/ImageLibrary.java:923: Parameter 'g2' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:923: Parameter 'img' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:924: Avoid variables with short names like x +src/net/sf/freecol/client/gui/ImageLibrary.java:924: Avoid variables with short names like y +src/net/sf/freecol/client/gui/ImageLibrary.java:924: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:924: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:924: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:924: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:925: Local variable 'anchor' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:927: Local variable 'paint' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:939: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:940: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/ImageLibrary.java:941: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:942: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:944: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:944: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:945: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:946: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:950: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:950: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:951: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/ImageLibrary.java:952: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:955: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:957: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:957: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:958: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:959: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:963: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:963: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/ImageLibrary.java:964: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:964: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:965: Local variable 'scaled' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:967: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:967: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:968: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:970: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:971: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:983: Parameter 'fade' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:983: Parameter 'img' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:983: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:984: Avoid variables with short names like w +src/net/sf/freecol/client/gui/ImageLibrary.java:984: Local variable 'w' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:985: Avoid variables with short names like h +src/net/sf/freecol/client/gui/ImageLibrary.java:985: Local variable 'h' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:986: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/ImageLibrary.java:986: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:987: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:987: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:988: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:990: Local variable 'offset' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:991: Local variable 'scales' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:992: Local variable 'offsets' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:993: Local variable 'rop' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:995: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:997: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1001: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:1011: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:1011: Parameter 'border' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1011: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1011: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1012: Parameter 'background' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1012: Parameter 'foreground' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1013: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1015: Avoid variables with short names like fm +src/net/sf/freecol/client/gui/ImageLibrary.java:1015: Local variable 'fm' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1016: Local variable 'padding' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1017: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/ImageLibrary.java:1017: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1017: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1018: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1018: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1020: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/ImageLibrary.java:1020: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1021: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1022: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1023: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1024: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1025: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1026: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1028: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1029: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1029: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1030: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1034: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:1046: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:1046: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1046: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1047: Parameter 'background' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1047: Parameter 'border' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1048: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1048: Parameter 'fill' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1049: Parameter 'foreground' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1050: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1052: Avoid variables with short names like fm +src/net/sf/freecol/client/gui/ImageLibrary.java:1052: Local variable 'fm' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1053: Local variable 'padding' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1054: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/ImageLibrary.java:1054: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1054: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1055: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1055: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1057: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/ImageLibrary.java:1057: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1058: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1059: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1060: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1061: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1062: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1063: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1064: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1066: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1067: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1069: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1070: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1070: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1071: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1078: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:1088: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:1088: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1088: The method getAlarmChip() has an NPath complexity of 900 +src/net/sf/freecol/client/gui/ImageLibrary.java:1089: Avoid variables with short names like is +src/net/sf/freecol/client/gui/ImageLibrary.java:1089: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1089: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1090: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:1090: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/ImageLibrary.java:1091: Local variable 'ownerColor' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1091: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1092: Local variable 'enemy' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1093: Local variable 'enemyColor' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1094: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1099: Found 'DD'-anomaly for variable 'amount' (lines '1,099'-'1,101'). +src/net/sf/freecol/client/gui/ImageLibrary.java:1099: Found 'DD'-anomaly for variable 'amount' (lines '1,099'-'1,104'). +src/net/sf/freecol/client/gui/ImageLibrary.java:1102: Use equals() to compare object references. +src/net/sf/freecol/client/gui/ImageLibrary.java:1103: Local variable 'alarm' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1105: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/ImageLibrary.java:1107: Local variable 'foreground' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1108: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1108: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1108: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1122: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:1122: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1123: Avoid variables with short names like is +src/net/sf/freecol/client/gui/ImageLibrary.java:1123: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1124: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1125: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1125: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1126: Local variable 'background' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1139: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:1139: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1140: Parameter 'expert' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1140: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1141: Local variable 'background' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1142: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1143: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1143: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1148: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1148: Useless parentheses. +src/net/sf/freecol/client/gui/ImageLibrary.java:1154: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:1163: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:1163: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1164: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1164: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1165: Local variable 'backgroundColor' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1166: Local variable 'foregroundColor' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1171: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: Avoid reassigning parameters such as 'color' +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: Avoid variables with short names like g +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: The method 'getStringImage' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: The method 'getStringImage' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: The method 'getStringImage' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/ImageLibrary.java:1181: The method getStringImage() has an NPath complexity of 576 +src/net/sf/freecol/client/gui/ImageLibrary.java:1182: Parameter 'font' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1189: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1193: Local variable 'img' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1195: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/ImageLibrary.java:1198: Avoid variables with short names like fm +src/net/sf/freecol/client/gui/ImageLibrary.java:1198: Local variable 'fm' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1199: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1200: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1201: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/ImageLibrary.java:1201: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1204: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/ImageLibrary.java:1204: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1210: Local variable 'borderWidth' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1211: Local variable 'borderColor' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/ImageLibrary.java:1212: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/ImageLibrary.java:1215: Local variable 'biXI' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1222: These nested if statements could be combined +src/net/sf/freecol/client/gui/ImageLibrary.java:1223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1232: These nested if statements could be combined +src/net/sf/freecol/client/gui/ImageLibrary.java:1233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1242: Found 'DU'-anomaly for variable 'biYI' (lines '1,242'-'1,274'). +src/net/sf/freecol/client/gui/ImageLibrary.java:1242: Local variable 'biYI' could be declared final +src/net/sf/freecol/client/gui/ImageLibrary.java:1245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1246: Found 'DD'-anomaly for variable 'srcA' (lines '1,246'-'1,256'). +src/net/sf/freecol/client/gui/ImageLibrary.java:1247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1249: These nested if statements could be combined +src/net/sf/freecol/client/gui/ImageLibrary.java:1250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1255: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1256: Found 'DD'-anomaly for variable 'srcA' (lines '1,256'-'1,246'). +src/net/sf/freecol/client/gui/ImageLibrary.java:1256: Found 'DU'-anomaly for variable 'srcA' (lines '1,256'-'1,274'). +src/net/sf/freecol/client/gui/ImageLibrary.java:1257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1259: These nested if statements could be combined +src/net/sf/freecol/client/gui/ImageLibrary.java:1260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ImageLibrary.java:1270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:27: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:28: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:29: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:31: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:31: Parameter 'serverName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:31: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/LoadingSavegameInfo.java:31: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/MapViewer.java:20: Possible God class (WMC=303, ATFD=510, TCC=0.10855094726062468) +src/net/sf/freecol/client/gui/MapViewer.java:81: Avoid really long classes. +src/net/sf/freecol/client/gui/MapViewer.java:81: The class 'MapViewer' has a Cyclomatic Complexity of 5 (Highest = 32). +src/net/sf/freecol/client/gui/MapViewer.java:81: The class 'MapViewer' has a Modified Cyclomatic Complexity of 4 (Highest = 25). +src/net/sf/freecol/client/gui/MapViewer.java:81: The class 'MapViewer' has a Standard Cyclomatic Complexity of 4 (Highest = 26). +src/net/sf/freecol/client/gui/MapViewer.java:81: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/MapViewer.java:81: Too many fields +src/net/sf/freecol/client/gui/MapViewer.java:83: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/MapViewer.java:83: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:85: enumCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:87: headerCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:89: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:89: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:90: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:90: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:92: Parameter 'newFont' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:92: Parameter 'newText' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:92: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:99: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:99: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:99: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:101: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:101: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:101: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:103: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:103: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:103: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:106: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:106: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:108: Avoid variables with short names like tv +src/net/sf/freecol/client/gui/MapViewer.java:108: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:108: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:108: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:110: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:110: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:110: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:112: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:112: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:113: Avoid using redundant field initializer for 'focus' +src/net/sf/freecol/client/gui/MapViewer.java:113: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:113: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:114: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:114: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:117: Avoid using redundant field initializer for 'viewMode' +src/net/sf/freecol/client/gui/MapViewer.java:117: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:117: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:120: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:120: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:123: Avoid using redundant field initializer for 'gotoPath' +src/net/sf/freecol/client/gui/MapViewer.java:123: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:124: Avoid using redundant field initializer for 'gotoStarted' +src/net/sf/freecol/client/gui/MapViewer.java:124: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:124: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:124: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:127: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:127: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:128: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:128: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:128: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:128: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:128: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:131: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:131: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:131: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:134: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:134: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:134: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:138: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:138: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:138: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:142: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:142: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:142: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:145: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:145: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:145: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:148: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:148: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:148: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:152: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:152: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:152: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:155: Avoid using redundant field initializer for 'alignedBottom' +src/net/sf/freecol/client/gui/MapViewer.java:155: Avoid using redundant field initializer for 'alignedTop' +src/net/sf/freecol/client/gui/MapViewer.java:155: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:155: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:155: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:155: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:156: Avoid using redundant field initializer for 'alignedLeft' +src/net/sf/freecol/client/gui/MapViewer.java:156: Avoid using redundant field initializer for 'alignedRight' +src/net/sf/freecol/client/gui/MapViewer.java:156: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:156: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:159: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:159: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:160: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:160: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:161: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:161: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:164: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:164: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:165: Avoid excessively long variable names like OTHER_UNITS_OFFSET_X +src/net/sf/freecol/client/gui/MapViewer.java:166: Avoid excessively long variable names like OTHER_UNITS_OFFSET_Y +src/net/sf/freecol/client/gui/MapViewer.java:170: Avoid excessively long variable names like unitsOutForAnimation +src/net/sf/freecol/client/gui/MapViewer.java:170: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:170: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:170: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:171: Avoid excessively long variable names like unitsOutForAnimationLabels +src/net/sf/freecol/client/gui/MapViewer.java:171: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:171: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:171: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:174: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:174: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:174: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:177: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:177: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:177: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:180: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:180: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:180: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:182: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/MapViewer.java:182: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/MapViewer.java:182: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/MapViewer.java:190: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:193: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:198: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:210: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:219: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:226: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:235: Parameter 'newViewMode' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:235: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:237: There is log block not surrounded by if +src/net/sf/freecol/client/gui/MapViewer.java:241: Avoid using if...else statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:243: Avoid using if...else statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:244: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:245: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:246: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:248: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:248: Use equals() to compare object references. +src/net/sf/freecol/client/gui/MapViewer.java:250: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:259: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:273: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:273: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:273: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:273: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:273: The method 'convertToMapTile' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/MapViewer.java:273: The method 'convertToMapTile' has a Modified Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/MapViewer.java:273: The method 'convertToMapTile' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/MapViewer.java:273: The method convertToMapTile() has an NPath complexity of 21600 +src/net/sf/freecol/client/gui/MapViewer.java:273: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:275: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:275: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:285: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:285: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:290: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:294: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:294: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:304: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:304: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:306: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:306: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:308: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:308: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:318: Local variable 'dcol' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:320: Local variable 'drow' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:322: Avoid variables with short names like px +src/net/sf/freecol/client/gui/MapViewer.java:322: Local variable 'px' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:323: Avoid variables with short names like py +src/net/sf/freecol/client/gui/MapViewer.java:323: Local variable 'py' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:325: Local variable 'newCol' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:326: Local variable 'newRow' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:327: There is log block not surrounded by if +src/net/sf/freecol/client/gui/MapViewer.java:332: Found 'DD'-anomaly for variable 'direction' (lines '332'-'338'). +src/net/sf/freecol/client/gui/MapViewer.java:332: Found 'DD'-anomaly for variable 'direction' (lines '332'-'343'). +src/net/sf/freecol/client/gui/MapViewer.java:332: Found 'DD'-anomaly for variable 'direction' (lines '332'-'352'). +src/net/sf/freecol/client/gui/MapViewer.java:332: Found 'DD'-anomaly for variable 'direction' (lines '332'-'357'). +src/net/sf/freecol/client/gui/MapViewer.java:361: Found 'DD'-anomaly for variable 'col' (lines '361'-'365'). +src/net/sf/freecol/client/gui/MapViewer.java:362: Found 'DD'-anomaly for variable 'row' (lines '362'-'366'). +src/net/sf/freecol/client/gui/MapViewer.java:364: Local variable 'step' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:364: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:368: There is log block not surrounded by if +src/net/sf/freecol/client/gui/MapViewer.java:370: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:370: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:374: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:384: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:386: Avoid variables with short names like r +src/net/sf/freecol/client/gui/MapViewer.java:397: Avoid variables with short names like i +src/net/sf/freecol/client/gui/MapViewer.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:406: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:415: Avoid variables with short names like i +src/net/sf/freecol/client/gui/MapViewer.java:419: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/MapViewer.java:421: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:444: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:447: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:449: Local variable 'img' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:451: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:451: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:453: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:456: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:457: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:463: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:467: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:477: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:477: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:480: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:480: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:481: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:481: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:491: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:500: Avoid variables with short names like t +src/net/sf/freecol/client/gui/MapViewer.java:500: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:500: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:502: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:502: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:504: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:504: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:504: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:505: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:505: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:505: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:505: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:506: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:510: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:522: Parameter 'labelHeight' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:522: Parameter 'labelWidth' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:522: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:523: Parameter 'tileP' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:524: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:525: Local variable 'labelX' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:527: Local variable 'labelY' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:530: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:536: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:546: Parameter 'tileToCheck' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:546: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:547: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:547: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:558: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:560: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/MapViewer.java:561: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:563: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:564: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:570: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:574: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:585: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:596: Parameter 'focus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:596: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:601: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:612: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:612: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:613: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:613: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:615: Found 'DU'-anomaly for variable 'map' (lines '615'-'649'). +src/net/sf/freecol/client/gui/MapViewer.java:615: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:616: Avoid variables with short names like tx +src/net/sf/freecol/client/gui/MapViewer.java:616: Avoid variables with short names like ty +src/net/sf/freecol/client/gui/MapViewer.java:616: Found 'DU'-anomaly for variable 'ty' (lines '616'-'649'). +src/net/sf/freecol/client/gui/MapViewer.java:616: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:618: Found 'DD'-anomaly for variable 'moveX' (lines '618'-'627'). +src/net/sf/freecol/client/gui/MapViewer.java:618: Found 'DD'-anomaly for variable 'moveX' (lines '618'-'636'). +src/net/sf/freecol/client/gui/MapViewer.java:618: Found 'DD'-anomaly for variable 'moveX' (lines '618'-'640'). +src/net/sf/freecol/client/gui/MapViewer.java:644: Local variable 'other' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:644: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:654: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:659: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:667: Parameter 'pos' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:668: Found 'DU'-anomaly for variable 'game' (lines '668'-'758'). +src/net/sf/freecol/client/gui/MapViewer.java:669: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:669: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:669: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:669: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:669: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:670: Found 'DU'-anomaly for variable 'rightColumns' (lines '670'-'758'). +src/net/sf/freecol/client/gui/MapViewer.java:670: Local variable 'leftColumns' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:670: Local variable 'rightColumns' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:670: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:672: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:686: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:686: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:687: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:687: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:693: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:693: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:693: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:693: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:696: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:702: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:702: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:714: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:738: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:738: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:738: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:738: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:740: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:740: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:766: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:766: The method 'scrollMap' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/MapViewer.java:766: The method 'scrollMap' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/MapViewer.java:766: The method 'scrollMap' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/MapViewer.java:766: The method scrollMap() has an NPath complexity of 2028 +src/net/sf/freecol/client/gui/MapViewer.java:766: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:767: Avoid variables with short names like t +src/net/sf/freecol/client/gui/MapViewer.java:768: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:768: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:769: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/MapViewer.java:769: Avoid variables with short names like fx +src/net/sf/freecol/client/gui/MapViewer.java:769: Avoid variables with short names like fy +src/net/sf/freecol/client/gui/MapViewer.java:769: Found 'DU'-anomaly for variable 'fx' (lines '769'-'796'). +src/net/sf/freecol/client/gui/MapViewer.java:769: Found 'DU'-anomaly for variable 'fy' (lines '769'-'796'). +src/net/sf/freecol/client/gui/MapViewer.java:769: Local variable 'fx' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:769: Local variable 'fy' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:769: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:769: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:769: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:770: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:770: Avoid assignments in operands +src/net/sf/freecol/client/gui/MapViewer.java:770: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:771: Avoid variables with short names like tx +src/net/sf/freecol/client/gui/MapViewer.java:771: Avoid variables with short names like ty +src/net/sf/freecol/client/gui/MapViewer.java:771: Local variable 'tx' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:771: Local variable 'ty' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:771: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:771: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:771: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:772: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:772: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:772: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:777: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:777: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:779: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:779: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:779: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:779: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:785: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:785: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:787: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:787: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:787: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:787: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:793: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:793: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:804: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:804: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:805: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:805: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:815: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:815: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:815: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:815: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:826: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:826: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:826: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:826: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:827: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:827: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:850: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:850: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:851: Found 'DD'-anomaly for variable 'leftColumns' (lines '851'-'855'). +src/net/sf/freecol/client/gui/MapViewer.java:851: Found 'DD'-anomaly for variable 'leftColumns' (lines '851'-'859'). +src/net/sf/freecol/client/gui/MapViewer.java:854: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/MapViewer.java:858: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:858: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:885: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:885: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:886: Found 'DD'-anomaly for variable 'rightColumns' (lines '886'-'890'). +src/net/sf/freecol/client/gui/MapViewer.java:886: Found 'DD'-anomaly for variable 'rightColumns' (lines '886'-'894'). +src/net/sf/freecol/client/gui/MapViewer.java:889: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:889: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:893: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/MapViewer.java:907: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:907: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:911: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:912: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:912: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:922: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:926: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:945: Parameter 'newTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:945: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:946: Found 'DU'-anomaly for variable 'oldTile' (lines '946'-'979'). +src/net/sf/freecol/client/gui/MapViewer.java:946: Local variable 'oldTile' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:947: Found 'DD'-anomaly for variable 'ret' (lines '947'-'955'). +src/net/sf/freecol/client/gui/MapViewer.java:947: Found 'DD'-anomaly for variable 'ret' (lines '947'-'959'). +src/net/sf/freecol/client/gui/MapViewer.java:947: Found 'DD'-anomaly for variable 'ret' (lines '947'-'968'). +src/net/sf/freecol/client/gui/MapViewer.java:951: These nested if statements could be combined +src/net/sf/freecol/client/gui/MapViewer.java:953: Local variable 'unitInFront' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:954: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:955: Found 'DD'-anomaly for variable 'ret' (lines '955'-'968'). +src/net/sf/freecol/client/gui/MapViewer.java:959: Found 'DD'-anomaly for variable 'ret' (lines '959'-'968'). +src/net/sf/freecol/client/gui/MapViewer.java:966: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:987: Found 'UR'-anomaly for variable 'c' (lines '987'-'1,037'). +src/net/sf/freecol/client/gui/MapViewer.java:987: Found 'UR'-anomaly for variable 'c' (lines '987'-'1,041'). +src/net/sf/freecol/client/gui/MapViewer.java:987: Found 'UR'-anomaly for variable 'u' (lines '987'-'1,013'). +src/net/sf/freecol/client/gui/MapViewer.java:987: Parameter 'unitTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:987: The method 'findUnitInFront' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/MapViewer.java:987: The method 'findUnitInFront' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/MapViewer.java:987: The method 'findUnitInFront' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/MapViewer.java:991: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:997: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:1005: Local variable 'units' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1006: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1007: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1008: Found 'DD'-anomaly for variable 'carrier' (lines '1,008'-'1,011'). +src/net/sf/freecol/client/gui/MapViewer.java:1009: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1010: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1011: Found 'DD'-anomaly for variable 'carrier' (lines '1,011'-'1,019'). +src/net/sf/freecol/client/gui/MapViewer.java:1011: Found 'DD'-anomaly for variable 'carrier' (lines '1,011'-'1,030'). +src/net/sf/freecol/client/gui/MapViewer.java:1013: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1015: Found 'DD'-anomaly for variable 'best' (lines '1,015'-'1,043'). +src/net/sf/freecol/client/gui/MapViewer.java:1015: Found 'DU'-anomaly for variable 'best' (lines '1,015'-'1,051'). +src/net/sf/freecol/client/gui/MapViewer.java:1015: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1016: Found 'DD'-anomaly for variable 'result' (lines '1,016'-'1,016'). +src/net/sf/freecol/client/gui/MapViewer.java:1016: Found 'DD'-anomaly for variable 'result' (lines '1,016'-'1,024'). +src/net/sf/freecol/client/gui/MapViewer.java:1016: Found 'DD'-anomaly for variable 'result' (lines '1,016'-'1,028'). +src/net/sf/freecol/client/gui/MapViewer.java:1016: Found 'DD'-anomaly for variable 'result' (lines '1,016'-'1,039'). +src/net/sf/freecol/client/gui/MapViewer.java:1016: Found 'DD'-anomaly for variable 'result' (lines '1,016'-'1,044'). +src/net/sf/freecol/client/gui/MapViewer.java:1019: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1019: Use bitwise inversion to invert boolean values +src/net/sf/freecol/client/gui/MapViewer.java:1021: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1022: Found 'DU'-anomaly for variable 'active' (lines '1,022'-'1,051'). +src/net/sf/freecol/client/gui/MapViewer.java:1023: Found 'DD'-anomaly for variable 'best' (lines '1,023'-'1,043'). +src/net/sf/freecol/client/gui/MapViewer.java:1023: Found 'DU'-anomaly for variable 'best' (lines '1,023'-'1,051'). +src/net/sf/freecol/client/gui/MapViewer.java:1023: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1024: Found 'DD'-anomaly for variable 'result' (lines '1,024'-'1,039'). +src/net/sf/freecol/client/gui/MapViewer.java:1024: Found 'DD'-anomaly for variable 'result' (lines '1,024'-'1,044'). +src/net/sf/freecol/client/gui/MapViewer.java:1026: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1027: Found 'DD'-anomaly for variable 'best' (lines '1,027'-'1,043'). +src/net/sf/freecol/client/gui/MapViewer.java:1027: Found 'DU'-anomaly for variable 'best' (lines '1,027'-'1,051'). +src/net/sf/freecol/client/gui/MapViewer.java:1027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1028: Found 'DD'-anomaly for variable 'result' (lines '1,028'-'1,039'). +src/net/sf/freecol/client/gui/MapViewer.java:1028: Found 'DD'-anomaly for variable 'result' (lines '1,028'-'1,044'). +src/net/sf/freecol/client/gui/MapViewer.java:1030: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1030: Use bitwise inversion to invert boolean values +src/net/sf/freecol/client/gui/MapViewer.java:1035: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1035: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1037: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1038: Found 'DD'-anomaly for variable 'best' (lines '1,038'-'1,023'). +src/net/sf/freecol/client/gui/MapViewer.java:1038: Found 'DD'-anomaly for variable 'best' (lines '1,038'-'1,043'). +src/net/sf/freecol/client/gui/MapViewer.java:1038: Found 'DU'-anomaly for variable 'best' (lines '1,038'-'1,051'). +src/net/sf/freecol/client/gui/MapViewer.java:1038: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1039: Found 'DD'-anomaly for variable 'result' (lines '1,039'-'1,016'). +src/net/sf/freecol/client/gui/MapViewer.java:1039: Found 'DD'-anomaly for variable 'result' (lines '1,039'-'1,024'). +src/net/sf/freecol/client/gui/MapViewer.java:1039: Found 'DD'-anomaly for variable 'result' (lines '1,039'-'1,028'). +src/net/sf/freecol/client/gui/MapViewer.java:1039: Found 'DD'-anomaly for variable 'result' (lines '1,039'-'1,039'). +src/net/sf/freecol/client/gui/MapViewer.java:1039: Found 'DD'-anomaly for variable 'result' (lines '1,039'-'1,044'). +src/net/sf/freecol/client/gui/MapViewer.java:1041: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1042: Found 'DU'-anomaly for variable 'active' (lines '1,042'-'1,051'). +src/net/sf/freecol/client/gui/MapViewer.java:1043: Found 'DD'-anomaly for variable 'best' (lines '1,043'-'1,023'). +src/net/sf/freecol/client/gui/MapViewer.java:1043: Found 'DD'-anomaly for variable 'best' (lines '1,043'-'1,043'). +src/net/sf/freecol/client/gui/MapViewer.java:1043: Found 'DU'-anomaly for variable 'best' (lines '1,043'-'1,051'). +src/net/sf/freecol/client/gui/MapViewer.java:1043: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1044: Found 'DD'-anomaly for variable 'result' (lines '1,044'-'1,016'). +src/net/sf/freecol/client/gui/MapViewer.java:1044: Found 'DD'-anomaly for variable 'result' (lines '1,044'-'1,024'). +src/net/sf/freecol/client/gui/MapViewer.java:1044: Found 'DD'-anomaly for variable 'result' (lines '1,044'-'1,028'). +src/net/sf/freecol/client/gui/MapViewer.java:1044: Found 'DD'-anomaly for variable 'result' (lines '1,044'-'1,039'). +src/net/sf/freecol/client/gui/MapViewer.java:1044: Found 'DD'-anomaly for variable 'result' (lines '1,044'-'1,044'). +src/net/sf/freecol/client/gui/MapViewer.java:1059: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1069: Parameter 'activeUnit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1069: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1072: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:1072: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1081: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1085: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1088: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:1099: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1108: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1118: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1130: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1142: Parameter 'gotoPath' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1142: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1150: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1157: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:1160: Found 'DD'-anomaly for variable 'path' (lines '1,160'-'1,163'). +src/net/sf/freecol/client/gui/MapViewer.java:1161: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/MapViewer.java:1163: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:1175: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1175: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1179: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1179: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1187: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1192: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1196: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1200: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1202: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1208: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1210: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1220: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:1220: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1220: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1236: Parameter 'lib' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1240: Local variable 'tileSize' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1246: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/MapViewer.java:1246: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1247: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/MapViewer.java:1247: Local variable 'dy' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1248: Local variable 'ddx' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1249: Local variable 'ddy' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1280: Avoid really long methods. +src/net/sf/freecol/client/gui/MapViewer.java:1280: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1280: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1280: The method 'displayMap' has a Cyclomatic Complexity of 32. +src/net/sf/freecol/client/gui/MapViewer.java:1280: The method 'displayMap' has a Modified Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/MapViewer.java:1280: The method 'displayMap' has a Standard Cyclomatic Complexity of 26. +src/net/sf/freecol/client/gui/MapViewer.java:1280: The method displayMap() has an NPath complexity of 2889216 +src/net/sf/freecol/client/gui/MapViewer.java:1280: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/MapViewer.java:1282: Local variable 'game' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1283: Local variable 'map' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1286: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/MapViewer.java:1286: Found 'DU'-anomaly for variable 'originTransform' (lines '1,286'-'1,571'). +src/net/sf/freecol/client/gui/MapViewer.java:1286: Local variable 'originTransform' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1287: Local variable 'clipBounds' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1294: Local variable 'clipTopY' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1298: Local variable 'clipLeftX' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1301: Found 'DD'-anomaly for variable 'lastRow' (lines '1,301'-'1,303'). +src/net/sf/freecol/client/gui/MapViewer.java:1305: Found 'DD'-anomaly for variable 'lastColumn' (lines '1,305'-'1,307'). +src/net/sf/freecol/client/gui/MapViewer.java:1316: Local variable 'baseTransform' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1322: Avoid variables with short names like x0 +src/net/sf/freecol/client/gui/MapViewer.java:1323: Avoid variables with short names like y0 +src/net/sf/freecol/client/gui/MapViewer.java:1324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1326: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1327: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1328: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1329: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1341: Local variable 'gridPath' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1342: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1346: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1356: Local variable 'rowTransform' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1357: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/MapViewer.java:1367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1371: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1372: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1373: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1374: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1385: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1386: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1387: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1388: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1396: Found 'DU'-anomaly for variable 'overlayCache' (lines '1,396'-'1,571'). +src/net/sf/freecol/client/gui/MapViewer.java:1396: Local variable 'overlayCache' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1397: Local variable 'colonyLabels' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1397: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1398: Found 'DU'-anomaly for variable 'withNumbers' (lines '1,398'-'1,571'). +src/net/sf/freecol/client/gui/MapViewer.java:1398: Local variable 'withNumbers' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1403: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1404: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:1406: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1407: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1408: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1409: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1412: Local variable 'overlayImage' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1427: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1429: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1430: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1431: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1432: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1440: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1443: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1444: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1445: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1446: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1454: Found 'DD'-anomaly for variable 'cursorTile' (lines '1,454'-'1,459'). +src/net/sf/freecol/client/gui/MapViewer.java:1454: Found 'DD'-anomaly for variable 'cursorTile' (lines '1,454'-'1,463'). +src/net/sf/freecol/client/gui/MapViewer.java:1455: A switch statement does not contain a break +src/net/sf/freecol/client/gui/MapViewer.java:1455: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/client/gui/MapViewer.java:1455: Switch statements should have a default label +src/net/sf/freecol/client/gui/MapViewer.java:1457: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1462: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1466: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1466: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1467: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1467: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1469: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1470: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1479: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:1479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1483: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1484: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1485: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:1487: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1488: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1489: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1490: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1500: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1503: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1504: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1505: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:1507: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1508: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1509: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1510: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1513: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1515: Local variable 'darkness' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1518: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1527: Found 'DU'-anomaly for variable 'player' (lines '1,527'-'1,571'). +src/net/sf/freecol/client/gui/MapViewer.java:1528: Local variable 'fontLibrary' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1529: Found 'DU'-anomaly for variable 'font' (lines '1,529'-'1,571'). +src/net/sf/freecol/client/gui/MapViewer.java:1529: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1532: Found 'DU'-anomaly for variable 'italicFont' (lines '1,532'-'1,571'). +src/net/sf/freecol/client/gui/MapViewer.java:1532: Local variable 'italicFont' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1535: Found 'DU'-anomaly for variable 'productionFont' (lines '1,535'-'1,571'). +src/net/sf/freecol/client/gui/MapViewer.java:1535: Local variable 'productionFont' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1544: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1545: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1548: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1549: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1550: Avoid variables with short names like xt +src/net/sf/freecol/client/gui/MapViewer.java:1551: Avoid variables with short names like yt +src/net/sf/freecol/client/gui/MapViewer.java:1573: Avoid really long methods. +src/net/sf/freecol/client/gui/MapViewer.java:1573: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1573: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1573: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1573: The method 'displaySettlementLabels' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/client/gui/MapViewer.java:1573: The method 'displaySettlementLabels' has a Modified Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/MapViewer.java:1573: The method 'displaySettlementLabels' has a Standard Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/MapViewer.java:1573: The method displaySettlementLabels() has an NPath complexity of 128048 +src/net/sf/freecol/client/gui/MapViewer.java:1574: Parameter 'colonyLabels' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1574: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1575: Parameter 'font' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1575: Parameter 'italicFont' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1576: Parameter 'productionFont' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1578: There is log block not surrounded by if +src/net/sf/freecol/client/gui/MapViewer.java:1580: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/MapViewer.java:1582: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1583: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1586: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1586: Found 'DD'-anomaly for variable 'backgroundColor' (lines '1,586'-'1,598'). +src/net/sf/freecol/client/gui/MapViewer.java:1588: Found 'DU'-anomaly for variable 'yOffset' (lines '1,588'-'1,688'). +src/net/sf/freecol/client/gui/MapViewer.java:1589: A high ratio of statements to labels in a switch statement. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:1591: Local variable 'img' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1599: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1601: Found 'DD'-anomaly for variable 'specs' (lines '1,601'-'1,607'). +src/net/sf/freecol/client/gui/MapViewer.java:1601: Found 'DD'-anomaly for variable 'specs' (lines '1,601'-'1,613'). +src/net/sf/freecol/client/gui/MapViewer.java:1604: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1605: Local variable 'buildable' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1605: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1607: Found 'DD'-anomaly for variable 'specs' (lines '1,607'-'1,610'). +src/net/sf/freecol/client/gui/MapViewer.java:1608: Avoid variables with short names like t +src/net/sf/freecol/client/gui/MapViewer.java:1608: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1609: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1610: Found 'DD'-anomaly for variable 'specs' (lines '1,610'-'1,613'). +src/net/sf/freecol/client/gui/MapViewer.java:1615: Local variable 'nameImage' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1617: Local variable 'spacing' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1618: Found 'DD'-anomaly for variable 'leftImage' (lines '1,618'-'1,624'). +src/net/sf/freecol/client/gui/MapViewer.java:1618: Found 'DD'-anomaly for variable 'leftImage' (lines '1,618'-'1,641'). +src/net/sf/freecol/client/gui/MapViewer.java:1619: Found 'DD'-anomaly for variable 'rightImage' (lines '1,619'-'1,634'). +src/net/sf/freecol/client/gui/MapViewer.java:1619: Found 'DD'-anomaly for variable 'rightImage' (lines '1,619'-'1,655'). +src/net/sf/freecol/client/gui/MapViewer.java:1621: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1622: Local variable 'string' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1625: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1625: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1629: Local variable 'bonusProduction' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1631: Local variable 'bonus' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1631: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1631: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1639: Avoid variables with short names like is +src/net/sf/freecol/client/gui/MapViewer.java:1639: Local variable 'is' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1640: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1642: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1645: Local variable 'missionary' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1645: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1647: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1649: Found 'DD'-anomaly for variable 'backgroundColor' (lines '1,649'-'1,651'). +src/net/sf/freecol/client/gui/MapViewer.java:1649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1652: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1653: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1654: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1656: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1661: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1661: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1661: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1661: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1661: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1663: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:1664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1664: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1664: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1667: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:1668: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1668: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1668: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1668: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1676: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1676: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1676: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1676: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1681: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1681: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1681: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1681: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1693: Parameter 'extent' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1693: Parameter 'padding' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1694: Parameter 'backgroundColor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1696: Local variable 'deg2rad' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1698: Local variable 'offset' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1699: Local variable 'size1' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1701: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1710: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/MapViewer.java:1710: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1711: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1711: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1712: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1713: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1714: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1716: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1719: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1720: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1721: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1725: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:1735: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1735: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1735: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1736: Parameter 'backgroundColor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1736: Parameter 'font' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1737: Found 'DD'-anomaly for variable 'specs' (lines '1,737'-'1,738'). +src/net/sf/freecol/client/gui/MapViewer.java:1742: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:1751: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1751: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1752: Parameter 'textSpecs' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1753: Parameter 'backgroundColor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1754: Local variable 'hPadding' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1755: Local variable 'vPadding' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1756: Found 'DU'-anomaly for variable 'linePadding' (lines '1,756'-'1,796'). +src/net/sf/freecol/client/gui/MapViewer.java:1756: Local variable 'linePadding' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1757: Found 'DD'-anomaly for variable 'width' (lines '1,757'-'1,770'). +src/net/sf/freecol/client/gui/MapViewer.java:1759: Avoid variables with short names like i +src/net/sf/freecol/client/gui/MapViewer.java:1762: Found 'DD'-anomaly for variable 'labels' (lines '1,762'-'1,768'). +src/net/sf/freecol/client/gui/MapViewer.java:1767: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/MapViewer.java:1768: Found 'DD'-anomaly for variable 'labels' (lines '1,768'-'1,768'). +src/net/sf/freecol/client/gui/MapViewer.java:1769: Local variable 'textRectangle' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1769: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1771: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1772: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1772: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1772: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1775: Local variable 'radius' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1777: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/MapViewer.java:1777: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1778: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/MapViewer.java:1778: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1778: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1779: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1780: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1781: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1783: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1785: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1786: Avoid variables with short names like y +src/net/sf/freecol/client/gui/MapViewer.java:1786: Found 'DU'-anomaly for variable 'y' (lines '1,786'-'1,796'). +src/net/sf/freecol/client/gui/MapViewer.java:1788: Local variable 'textRectangle' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1788: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1788: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1789: Avoid variables with short names like x +src/net/sf/freecol/client/gui/MapViewer.java:1789: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1790: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1790: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1791: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1791: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1792: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1792: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1802: Parameter 'extent' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1803: Parameter 'backgroundColor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1803: Parameter 'expertMissionary' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1803: Parameter 'padding' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1806: Local variable 'size1' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1807: Found 'DD'-anomaly for variable 'bar' (lines '1,807'-'1,817'). +src/net/sf/freecol/client/gui/MapViewer.java:1808: Found 'DD'-anomaly for variable 'inset' (lines '1,808'-'1,816'). +src/net/sf/freecol/client/gui/MapViewer.java:1809: Found 'DD'-anomaly for variable 'kludge' (lines '1,809'-'1,819'). +src/net/sf/freecol/client/gui/MapViewer.java:1811: Found 'DU'-anomaly for variable 'circle' (lines '1,811'-'1,845'). +src/net/sf/freecol/client/gui/MapViewer.java:1811: Local variable 'circle' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1812: Local variable 'cross' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1822: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1823: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1824: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1828: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/MapViewer.java:1828: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1829: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1829: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1831: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1832: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1834: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1837: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1842: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1843: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1854: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1854: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1854: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1854: The method 'displayPath' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/MapViewer.java:1854: The method 'displayPath' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/MapViewer.java:1854: The method 'displayPath' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/MapViewer.java:1854: The method displayPath() has an NPath complexity of 8101 +src/net/sf/freecol/client/gui/MapViewer.java:1861: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1861: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1862: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1863: Local variable 'point' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1864: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:1866: Found 'DD'-anomaly for variable 'image' (lines '1,866'-'1,879'). +src/net/sf/freecol/client/gui/MapViewer.java:1866: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1866: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1866: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1866: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1868: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:1870: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:1872: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/MapViewer.java:1872: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1872: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1872: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1873: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1881: Found 'DD'-anomaly for variable 'turns' (lines '1,881'-'1,872'). +src/net/sf/freecol/client/gui/MapViewer.java:1881: Found 'DU'-anomaly for variable 'turns' (lines '1,881'-'1,899'). +src/net/sf/freecol/client/gui/MapViewer.java:1881: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1882: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1908: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1908: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1908: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1908: The method 'displayUnit' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/MapViewer.java:1913: Local variable 'fade' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1913: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1913: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1914: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1914: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1915: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1916: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1917: Avoid variables with short names like p +src/net/sf/freecol/client/gui/MapViewer.java:1917: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1921: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1933: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1935: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/MapViewer.java:1938: Avoid variables with short names like x1 +src/net/sf/freecol/client/gui/MapViewer.java:1938: Local variable 'x1' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1940: Avoid variables with short names like x2 +src/net/sf/freecol/client/gui/MapViewer.java:1940: Local variable 'x2' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1949: Avoid variables with short names like au +src/net/sf/freecol/client/gui/MapViewer.java:1950: Avoid assignments in operands +src/net/sf/freecol/client/gui/MapViewer.java:1952: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1953: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1955: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1955: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1955: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1955: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1959: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/MapViewer.java:1959: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1959: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1959: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1959: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1959: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1959: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:1960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1960: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1963: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1965: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1965: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:1965: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:1976: Parameter 'unitImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1977: Local variable 'unitX' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1978: Local variable 'unitY' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1984: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1984: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1985: Local variable 'cursorImage' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1989: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/MapViewer.java:1998: Avoid variables with short names like g +src/net/sf/freecol/client/gui/MapViewer.java:1998: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1998: Parameter 'opaque' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1998: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1998: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:1998: The method 'displayTerritorialBorders' has a Cyclomatic Complexity of 32. +src/net/sf/freecol/client/gui/MapViewer.java:1998: The method 'displayTerritorialBorders' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/MapViewer.java:1998: The method 'displayTerritorialBorders' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/MapViewer.java:1998: The method displayTerritorialBorders() has an NPath complexity of 1224 +src/net/sf/freecol/client/gui/MapViewer.java:1999: Local variable 'owner' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2000: Local variable 'region' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2001: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2001: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2002: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2002: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2003: Local variable 'oldStroke' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2005: Local variable 'oldColor' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2006: Avoid variables with short names like c +src/net/sf/freecol/client/gui/MapViewer.java:2007: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:2008: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2009: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/MapViewer.java:2011: Local variable 'newColor' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2012: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2012: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2014: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2015: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2015: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2015: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2015: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2015: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/MapViewer.java:2016: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2016: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/MapViewer.java:2017: Local variable 'd' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2018: Local variable 'otherTile' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2019: Local variable 'next' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2019: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2020: Local variable 'next2' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2020: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2022: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2022: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2022: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2023: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2023: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2023: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2024: Local variable 'tile1' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2025: Local variable 'tile2' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2027: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2027: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2028: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2028: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2028: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2030: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2030: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2030: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2030: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2031: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2032: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2033: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2034: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2035: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2037: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/MapViewer.java:2037: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/MapViewer.java:2037: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:2046: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2046: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2046: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2047: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2047: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2047: Useless parentheses. +src/net/sf/freecol/client/gui/MapViewer.java:2049: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2049: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2049: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2049: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2050: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2052: Local variable 'previous' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2052: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2053: Local variable 'previous2' could be declared final +src/net/sf/freecol/client/gui/MapViewer.java:2053: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2054: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/MapViewer.java:2062: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2062: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2062: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2062: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2062: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2062: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2063: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2064: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2065: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2068: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2068: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2068: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2068: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2069: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2073: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2073: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2073: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/MapViewer.java:2073: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/MapViewer.java:2074: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/OutForAnimationCallback.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/OutForAnimationCallback.java:27: Comment is too large: Line too long +src/net/sf/freecol/client/gui/RoadPainter.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/RoadPainter.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/RoadPainter.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/RoadPainter.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/RoadPainter.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/RoadPainter.java:48: Private field 'halfHeight' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/RoadPainter.java:48: Private field 'halfWidth' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/RoadPainter.java:48: Private field 'tileHeight' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/RoadPainter.java:48: Private field 'tileWidth' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/RoadPainter.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/RoadPainter.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/RoadPainter.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/RoadPainter.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/RoadPainter.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/RoadPainter.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/RoadPainter.java:55: Private field 'roadStroke' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/RoadPainter.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/RoadPainter.java:57: Parameter 'tileSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:57: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/RoadPainter.java:63: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/RoadPainter.java:63: Local variable 'dy' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:96: Avoid variables with short names like g +src/net/sf/freecol/client/gui/RoadPainter.java:96: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:96: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:97: Found 'DU'-anomaly for variable 'oldColor' (lines '97'-'158'). +src/net/sf/freecol/client/gui/RoadPainter.java:97: Local variable 'oldColor' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:102: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/RoadPainter.java:102: Found 'DU'-anomaly for variable 'path' (lines '102'-'158'). +src/net/sf/freecol/client/gui/RoadPainter.java:102: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:103: Local variable 'map' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:104: Avoid variables with short names like x +src/net/sf/freecol/client/gui/RoadPainter.java:104: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:105: Avoid variables with short names like y +src/net/sf/freecol/client/gui/RoadPainter.java:105: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:106: Local variable 'points' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:107: Found 'DU'-anomaly for variable 'directions' (lines '107'-'158'). +src/net/sf/freecol/client/gui/RoadPainter.java:107: Local variable 'directions' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:107: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/RoadPainter.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:110: Avoid variables with short names like r +src/net/sf/freecol/client/gui/RoadPainter.java:111: Useless parentheses. +src/net/sf/freecol/client/gui/RoadPainter.java:111: Useless parentheses. +src/net/sf/freecol/client/gui/RoadPainter.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:118: A switch statement does not contain a break +src/net/sf/freecol/client/gui/RoadPainter.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:136: Avoid variables with short names like p +src/net/sf/freecol/client/gui/RoadPainter.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:138: Local variable 'd' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/RoadPainter.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:150: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/RoadPainter.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/RoadPainter.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/ScrollThread.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/ScrollThread.java:35: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/ScrollThread.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/ScrollThread.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/ScrollThread.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ScrollThread.java:46: Avoid using redundant field initializer for 'direction' +src/net/sf/freecol/client/gui/ScrollThread.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/ScrollThread.java:54: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ScrollThread.java:65: Avoid variables with short names like d +src/net/sf/freecol/client/gui/ScrollThread.java:65: Parameter 'd' is not assigned and could be declared final +src/net/sf/freecol/client/gui/ScrollThread.java:78: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/ScrollThread.java:78: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/TerrainCursor.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TerrainCursor.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:35: Avoid variables with short names like ON +src/net/sf/freecol/client/gui/TerrainCursor.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TerrainCursor.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TerrainCursor.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:48: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/TerrainCursor.java:69: Parameter 'newState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TerrainCursor.java:73: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:74: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/TerrainCursor.java:77: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:78: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/TerrainCursor.java:81: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TerrainCursor.java:81: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:85: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TerrainCursor.java:85: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:89: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/TerrainCursor.java:89: Found 'UR'-anomaly for variable 'al' (lines '89'-'92'). +src/net/sf/freecol/client/gui/TerrainCursor.java:89: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TerrainCursor.java:89: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/TerrainCursor.java:90: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/TerrainCursor.java:103: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/TerrainCursor.java:103: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TerrainCursor.java:104: Use bitwise inversion to invert boolean values +src/net/sf/freecol/client/gui/TerrainCursor.java:105: Local variable 'eventId' could be declared final +src/net/sf/freecol/client/gui/TerrainCursor.java:106: Local variable 'blinkEvent' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TileViewer.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/TileViewer.java:20: Possible God class (WMC=114, ATFD=198, TCC=0.057971014492753624) +src/net/sf/freecol/client/gui/TileViewer.java:68: The class 'TileViewer' has a Cyclomatic Complexity of 5 (Highest = 20). +src/net/sf/freecol/client/gui/TileViewer.java:68: The class 'TileViewer' has a Modified Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/TileViewer.java:68: The class 'TileViewer' has a Standard Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/TileViewer.java:68: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/TileViewer.java:70: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/TileViewer.java:70: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:73: headerCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:75: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:75: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:76: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:78: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:78: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:78: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:86: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:86: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:96: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:98: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/TileViewer.java:108: Found 'DD'-anomaly for variable 'hash' (lines '108'-'109'). +src/net/sf/freecol/client/gui/TileViewer.java:114: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/TileViewer.java:114: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:114: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:116: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/TileViewer.java:116: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:116: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:118: Avoid variables with short names like rp +src/net/sf/freecol/client/gui/TileViewer.java:118: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/TileViewer.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:118: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:121: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/TileViewer.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:121: Perhaps 'halfWidth' could be replaced by a local variable. +src/net/sf/freecol/client/gui/TileViewer.java:121: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:124: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/TileViewer.java:124: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:124: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:127: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/TileViewer.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/TileViewer.java:127: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/TileViewer.java:135: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:147: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:158: The method createTileImageWithOverlayAndForest() has an NPath complexity of 450 +src/net/sf/freecol/client/gui/TileViewer.java:158: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:159: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:159: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:160: Local variable 'size2' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:161: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:161: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:163: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:163: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:166: Local variable 'terrainImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:168: Local variable 'overlayImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:170: Local variable 'forestImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:172: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/TileViewer.java:174: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/TileViewer.java:176: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:177: Found 'DD'-anomaly for variable 'height' (lines '177'-'179'). +src/net/sf/freecol/client/gui/TileViewer.java:177: Found 'DD'-anomaly for variable 'height' (lines '177'-'182'). +src/net/sf/freecol/client/gui/TileViewer.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:184: Local variable 'compositeImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:186: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:186: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:206: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:206: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:207: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/TileViewer.java:208: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/TileViewer.java:210: Local variable 'terrainTileSize' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:211: Local variable 'overlayImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:212: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/TileViewer.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:217: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:219: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:219: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:233: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:233: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:235: Local variable 'terrainTileSize' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:236: Local variable 'overlayImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:237: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/TileViewer.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:242: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:244: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:244: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:251: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TileViewer.java:263: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:263: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:263: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:265: Local variable 'terrainTileSize' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:266: Local variable 'overlayImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:267: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/TileViewer.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:272: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:274: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:274: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:281: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TileViewer.java:290: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:290: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:290: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:290: Parameter 'tiles' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:290: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:291: Found 'DU'-anomaly for variable 'overlayCache' (lines '291'-'306'). +src/net/sf/freecol/client/gui/TileViewer.java:291: Local variable 'overlayCache' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:292: Found 'DU'-anomaly for variable 'tileSize' (lines '292'-'306'). +src/net/sf/freecol/client/gui/TileViewer.java:292: Local variable 'tileSize' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:296: Avoid variables with short names like xx +src/net/sf/freecol/client/gui/TileViewer.java:296: Local variable 'xx' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:297: Avoid variables with short names like yy +src/net/sf/freecol/client/gui/TileViewer.java:297: Local variable 'yy' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:299: Local variable 'overlayImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:299: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:299: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:301: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:301: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:308: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TileViewer.java:321: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:321: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:321: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:321: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:322: Parameter 'overlayImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:325: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:326: A switch statement does not contain a break +src/net/sf/freecol/client/gui/TileViewer.java:326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:333: Local variable 'price' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:333: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:335: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:340: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:342: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:347: Local variable 'owner' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:348: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:362: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:362: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:362: Parameter 'overlayImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:362: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:378: Parameter 'lib' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:378: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:381: Local variable 'tileSize' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:402: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:402: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:402: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:402: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:416: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:416: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:416: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:416: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:417: Avoid variables with short names like y +src/net/sf/freecol/client/gui/TileViewer.java:418: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/TileViewer.java:430: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:430: Found 'UR'-anomaly for variable 'direction' (lines '430'-'455'). +src/net/sf/freecol/client/gui/TileViewer.java:430: Found 'UR'-anomaly for variable 'sorted' (lines '430'-'490'). +src/net/sf/freecol/client/gui/TileViewer.java:430: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:430: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:430: The method 'displayTileWithBeachAndBorder' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/TileViewer.java:430: The method 'displayTileWithBeachAndBorder' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/TileViewer.java:430: The method 'displayTileWithBeachAndBorder' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/TileViewer.java:430: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:432: Local variable 'tileType' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:433: Avoid variables with short names like x +src/net/sf/freecol/client/gui/TileViewer.java:433: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:434: Avoid variables with short names like y +src/net/sf/freecol/client/gui/TileViewer.java:434: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:440: Local variable 'edgeStyle' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:441: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/TileViewer.java:445: Local variable 'cornerStyle' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:446: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/TileViewer.java:452: Local variable 'imageBorders' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:453: Avoid variables with short names like si +src/net/sf/freecol/client/gui/TileViewer.java:454: Local variable 'direction' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:455: Local variable 'borderingTile' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:457: Local variable 'borderingTileType' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:458: Use equals() to compare object references. +src/net/sf/freecol/client/gui/TileViewer.java:459: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/TileViewer.java:461: Comment is too large: Line too long +src/net/sf/freecol/client/gui/TileViewer.java:462: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/TileViewer.java:466: Local variable 'river' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:468: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/TileViewer.java:469: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:475: These nested if statements could be combined +src/net/sf/freecol/client/gui/TileViewer.java:476: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:479: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/TileViewer.java:489: Local variable 'sorted' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:496: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:496: Found 'UR'-anomaly for variable 'direction' (lines '496'-'498'). +src/net/sf/freecol/client/gui/TileViewer.java:496: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:496: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:496: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:497: Local variable 'direction' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:498: Local variable 'borderingTile' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:499: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:507: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TileViewer.java:516: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:516: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:516: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:516: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:518: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:518: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:523: Local variable 'oldComposite' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:538: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:538: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:538: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:538: The method 'displayOptionalTileText' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/TileViewer.java:538: The method 'displayOptionalTileText' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/TileViewer.java:538: The method 'displayOptionalTileText' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/TileViewer.java:538: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:539: Found 'DD'-anomaly for variable 'text' (lines '539'-'544'). +src/net/sf/freecol/client/gui/TileViewer.java:539: Found 'DD'-anomaly for variable 'text' (lines '539'-'548'). +src/net/sf/freecol/client/gui/TileViewer.java:539: Found 'DD'-anomaly for variable 'text' (lines '539'-'555'). +src/net/sf/freecol/client/gui/TileViewer.java:539: Found 'DD'-anomaly for variable 'text' (lines '539'-'557'). +src/net/sf/freecol/client/gui/TileViewer.java:540: Avoid variables with short names like op +src/net/sf/freecol/client/gui/TileViewer.java:540: Local variable 'op' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:540: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:554: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:555: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:564: There is log block not surrounded by if +src/net/sf/freecol/client/gui/TileViewer.java:572: Avoid variables with short names like b +src/net/sf/freecol/client/gui/TileViewer.java:572: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:574: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:574: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:576: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:576: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:578: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:578: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:578: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:579: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:579: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:581: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:581: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:581: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:582: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:582: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:583: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:590: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/TileViewer.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:593: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:593: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:594: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:594: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:596: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:599: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:599: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:600: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:600: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:604: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TileViewer.java:613: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:614: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:614: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:614: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:614: Parameter 'withNumber' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:615: Found 'DU'-anomaly for variable 'player' (lines '615'-'684'). +src/net/sf/freecol/client/gui/TileViewer.java:620: Found 'DU'-anomaly for variable 'colony' (lines '620'-'684'). +src/net/sf/freecol/client/gui/TileViewer.java:620: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:623: Local variable 'colonyImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:627: Local variable 'populationString' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:628: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:629: Local variable 'bonus' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:630: Local variable 'theColor' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:634: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:634: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:634: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:634: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:641: Local variable 'stringImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:647: Avoid variables with short names like is +src/net/sf/freecol/client/gui/TileViewer.java:647: Local variable 'is' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:648: Local variable 'settlementImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:654: Found 'DU'-anomaly for variable 'xOffset' (lines '654'-'684'). +src/net/sf/freecol/client/gui/TileViewer.java:655: Found 'DU'-anomaly for variable 'yOffset' (lines '655'-'684'). +src/net/sf/freecol/client/gui/TileViewer.java:655: Local variable 'yOffset' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:656: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:665: Local variable 'missionary' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:665: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:667: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:668: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:669: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:677: Avoid assignments in operands +src/net/sf/freecol/client/gui/TileViewer.java:677: Found 'DU'-anomaly for variable 'chip' (lines '677'-'684'). +src/net/sf/freecol/client/gui/TileViewer.java:681: There is log block not surrounded by if +src/net/sf/freecol/client/gui/TileViewer.java:686: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/TileViewer.java:695: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:695: Found 'UR'-anomaly for variable 'ti' (lines '695'-'737'). +src/net/sf/freecol/client/gui/TileViewer.java:695: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:695: Parameter 'overlayImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:695: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:695: The method displayTileItems() has an NPath complexity of 360 +src/net/sf/freecol/client/gui/TileViewer.java:695: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/TileViewer.java:700: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/TileViewer.java:700: Local variable 'tileItems' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:701: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:705: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:705: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:707: Found 'DD'-anomaly for variable 'startIndex' (lines '707'-'707'). +src/net/sf/freecol/client/gui/TileViewer.java:707: Found 'DD'-anomaly for variable 'startIndex' (lines '707'-'709'). +src/net/sf/freecol/client/gui/TileViewer.java:716: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:716: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:719: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:719: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:720: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:721: Found 'DD'-anomaly for variable 'startIndex' (lines '721'-'721'). +src/net/sf/freecol/client/gui/TileViewer.java:721: Found 'DD'-anomaly for variable 'startIndex' (lines '721'-'723'). +src/net/sf/freecol/client/gui/TileViewer.java:729: Local variable 'forestImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:732: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:732: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:732: Useless parentheses. +src/net/sf/freecol/client/gui/TileViewer.java:736: Local variable 'ti' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:736: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:736: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/TileViewer.java:744: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:744: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:744: Parameter 'item' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:744: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:754: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:754: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:754: Parameter 'item' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:755: Local variable 'bonusImage' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:755: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:756: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:760: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:760: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:765: Avoid variables with short names like g +src/net/sf/freecol/client/gui/TileViewer.java:765: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:766: Avoid variables with short names like ti +src/net/sf/freecol/client/gui/TileViewer.java:766: Parameter 'ti' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:766: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:774: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/TileViewer.java:778: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/TileViewer.java:778: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/TileViewer.java:781: Local variable 'overlay' could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/WindowedFrameListener.java:33: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/WindowedFrameListener.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/WindowedFrameListener.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:50: Document empty method +src/net/sf/freecol/client/gui/WindowedFrameListener.java:50: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:59: Document empty method +src/net/sf/freecol/client/gui/WindowedFrameListener.java:59: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:68: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:82: Document empty method +src/net/sf/freecol/client/gui/WindowedFrameListener.java:82: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:91: Document empty method +src/net/sf/freecol/client/gui/WindowedFrameListener.java:91: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:100: Document empty method +src/net/sf/freecol/client/gui/WindowedFrameListener.java:100: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/WindowedFrameListener.java:109: Document empty method +src/net/sf/freecol/client/gui/WindowedFrameListener.java:109: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/AboutAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/AboutAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/AboutAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/AboutAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/AboutAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/AboutAction.java:54: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/AboutAction.java:54: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/AboutAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ActionManager.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ActionManager.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/action/ActionManager.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ActionManager.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/ActionManager.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ActionManager.java:52: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:59: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ActionManager.java:68: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/client/gui/action/ActionManager.java:68: Found 'UR'-anomaly for variable 'd' (lines '68'-'117'). +src/net/sf/freecol/client/gui/action/ActionManager.java:68: Found 'UR'-anomaly for variable 'panelType' (lines '68'-'86'). +src/net/sf/freecol/client/gui/action/ActionManager.java:68: Found 'UR'-anomaly for variable 'type' (lines '68'-'96'). +src/net/sf/freecol/client/gui/action/ActionManager.java:68: Parameter 'inGameController' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:69: Parameter 'connectController' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:85: Local variable 'panelType' could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:86: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/action/ActionManager.java:95: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:96: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/action/ActionManager.java:116: Local variable 'd' could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:117: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/action/ActionManager.java:118: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/action/ActionManager.java:170: Found 'UR'-anomaly for variable 'type' (lines '170'-'173'). +src/net/sf/freecol/client/gui/action/ActionManager.java:170: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:172: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:174: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/action/ActionManager.java:187: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ActionManager.java:187: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:196: Found 'UR'-anomaly for variable 'o' (lines '196'-'197'). +src/net/sf/freecol/client/gui/action/ActionManager.java:197: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/action/ActionManager.java:197: Local variable 'o' could be declared final +src/net/sf/freecol/client/gui/action/ActionManager.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:54: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:55: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:55: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:55: Useless parentheses. +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:55: Useless parentheses. +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:67: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:67: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:68: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:69: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/AssignTradeRouteAction.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:55: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:55: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:56: Local variable 'selectedOne' could be declared final +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:56: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:57: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:58: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:59: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:59: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:59: Useless parentheses. +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:59: Useless parentheses. +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:61: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:61: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:71: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:71: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:72: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:72: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/BuildColonyAction.java:72: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/CenterAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/CenterAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/CenterAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/CenterAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/CenterAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/CenterAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/CenterAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/CenterAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ChangeAction.java:39: The class 'ChangeAction' has a Cyclomatic Complexity of 5 (Highest = 12). +src/net/sf/freecol/client/gui/action/ChangeAction.java:41: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ChangeAction.java:41: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ChangeAction.java:41: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ChangeAction.java:49: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ChangeAction.java:63: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:63: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:74: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:75: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/action/ChangeAction.java:75: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:77: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:92: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ChangeAction.java:92: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ChangeAction.java:92: The method 'actionPerformed' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/action/ChangeAction.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:96: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/action/ChangeAction.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:97: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:102: Found 'DD'-anomaly for variable 'activeUnitFound' (lines '102'-'106'). +src/net/sf/freecol/client/gui/action/ChangeAction.java:102: Found 'DU'-anomaly for variable 'activeUnitFound' (lines '102'-'126'). +src/net/sf/freecol/client/gui/action/ChangeAction.java:104: Avoid variables with short names like u +src/net/sf/freecol/client/gui/action/ChangeAction.java:104: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/action/ChangeAction.java:105: Use equals() to compare object references. +src/net/sf/freecol/client/gui/action/ChangeAction.java:106: Found 'DD'-anomaly for variable 'activeUnitFound' (lines '106'-'106'). +src/net/sf/freecol/client/gui/action/ChangeAction.java:106: Found 'DU'-anomaly for variable 'activeUnitFound' (lines '106'-'126'). +src/net/sf/freecol/client/gui/action/ChangeAction.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeAction.java:111: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/ChangeAction.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:116: Avoid variables with short names like u +src/net/sf/freecol/client/gui/action/ChangeAction.java:116: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/action/ChangeAction.java:117: Use equals() to compare object references. +src/net/sf/freecol/client/gui/action/ChangeAction.java:118: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/ChangeAction.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeAction.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:55: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:68: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:78: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:78: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:79: Local variable 'gui' could be declared final +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:80: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/ChangeWindowedModeAction.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ChatAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ChatAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ChatAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ChatAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ChatAction.java:42: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ChatAction.java:56: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ChatAction.java:67: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ChatAction.java:67: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ChatAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ClearOrdersAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ColopediaAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ColopediaAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ColopediaAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ColopediaAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ColopediaAction.java:37: enumCommentRequirement Required +src/net/sf/freecol/client/gui/action/ColopediaAction.java:42: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/ColopediaAction.java:47: Variables that are final and static should be all capitals, 'mnemonics' is not all capitals. +src/net/sf/freecol/client/gui/action/ColopediaAction.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ColopediaAction.java:66: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ColopediaAction.java:66: Parameter 'panelType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ColopediaAction.java:79: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ColopediaAction.java:79: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ColopediaAction.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ContinueAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ContinueAction.java:35: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ContinueAction.java:35: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ContinueAction.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ContinueAction.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ContinueAction.java:58: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ContinueAction.java:58: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ContinueAction.java:59: Local variable 'lastSave' could be declared final +src/net/sf/freecol/client/gui/action/ContinueAction.java:61: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ContinueAction.java:62: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DebugAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/DebugAction.java:36: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/DebugAction.java:36: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/DebugAction.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DebugAction.java:44: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DebugAction.java:69: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/DebugAction.java:69: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DebugAction.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DebugAction.java:72: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:42: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:54: Avoid variables with short names like p +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:54: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:56: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:66: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:66: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DeclareIndependenceAction.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:42: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:67: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:67: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:68: Found 'DU'-anomaly for variable 'map' (lines '68'-'74'). +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:70: Avoid variables with short names like p +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:70: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:70: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DetermineHighSeasAction.java:72: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:53: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:53: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisbandUnitAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:35: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:35: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:54: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:54: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayBordersAction.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:35: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:35: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:54: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:54: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayGridAction.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:39: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:39: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:42: enumCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:45: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:50: Variables that are final and static should be all capitals, 'accelerators' is not all capitals. +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:57: Avoid using redundant field initializer for 'display' +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:57: Private field 'display' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:66: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:67: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:97: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:97: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/DisplayTileTextAction.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/EndTurnAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/EndTurnAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/EndTurnAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/EndTurnAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/EndTurnAction.java:42: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/EndTurnAction.java:53: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/EndTurnAction.java:53: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/EndTurnAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/EuropeAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/EuropeAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/EuropeAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/EuropeAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/EuropeAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/EuropeAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/EuropeAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/EuropeAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/EuropeAction.java:65: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/EuropeAction.java:65: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/EuropeAction.java:66: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ExecuteGotoOrdersAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FindSettlementAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FortifyAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/FortifyAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/FortifyAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/FortifyAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FortifyAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FortifyAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FortifyAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FortifyAction.java:66: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/FortifyAction.java:66: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FortifyAction.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FortifyAction.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FortifyAction.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FreeColAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/FreeColAction.java:50: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/action/FreeColAction.java:51: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/action/FreeColAction.java:54: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/action/FreeColAction.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/FreeColAction.java:66: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/action/FreeColAction.java:66: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:69: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:74: Avoid variables with short names like e +src/net/sf/freecol/client/gui/action/FreeColAction.java:74: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:74: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:77: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/FreeColAction.java:77: Local variable 'ae' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:86: Avoid variables with short names like e +src/net/sf/freecol/client/gui/action/FreeColAction.java:86: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:86: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:91: Avoid variables with short names like e +src/net/sf/freecol/client/gui/action/FreeColAction.java:91: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:91: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:96: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:96: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:97: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:97: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:98: Avoid excessively long variable names like BUTTON_ROLLOVER_IMAGE +src/net/sf/freecol/client/gui/action/FreeColAction.java:98: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:98: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:99: Avoid excessively long variable names like BUTTON_PRESSED_IMAGE +src/net/sf/freecol/client/gui/action/FreeColAction.java:99: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:99: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:100: Avoid excessively long variable names like BUTTON_DISABLED_IMAGE +src/net/sf/freecol/client/gui/action/FreeColAction.java:100: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:100: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:102: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:102: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:104: Avoid excessively long variable names like orderButtonImageCount +src/net/sf/freecol/client/gui/action/FreeColAction.java:104: Avoid using redundant field initializer for 'orderButtonImageCount' +src/net/sf/freecol/client/gui/action/FreeColAction.java:104: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:104: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/FreeColAction.java:104: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:113: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/FreeColAction.java:113: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:113: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:120: Local variable 'shortDescription' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:125: Local variable 'acceleratorKey' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:126: Local variable 'accelerator' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:200: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/client/gui/action/FreeColAction.java:214: Parameter 'mnemonic' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:214: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:232: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:232: The method addImageIcons() has an NPath complexity of 1250 +src/net/sf/freecol/client/gui/action/FreeColAction.java:233: Local variable 'normalKey' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:234: Local variable 'highlightedKey' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:235: Local variable 'pressedKey' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:236: Local variable 'disabledKey' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:247: There is log block not surrounded by if +src/net/sf/freecol/client/gui/action/FreeColAction.java:258: Parameter 'accelerator' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:301: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/FreeColAction.java:311: Parameter 'keyStroke' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:337: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:341: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/FreeColAction.java:360: Avoid variables with short names like b +src/net/sf/freecol/client/gui/action/FreeColAction.java:360: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:361: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/FreeColAction.java:369: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/action/FreeColAction.java:369: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/FreeColAction.java:380: Avoid variables with short names like xw +src/net/sf/freecol/client/gui/action/FreeColAction.java:380: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:397: Avoid variables with short names like xr +src/net/sf/freecol/client/gui/action/FreeColAction.java:397: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:399: Local variable 'acc' could be declared final +src/net/sf/freecol/client/gui/action/FreeColAction.java:400: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/action/FreeColAction.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/FreeColAction.java:400: Useless parentheses. +src/net/sf/freecol/client/gui/action/FreeColAction.java:400: Useless parentheses. +src/net/sf/freecol/client/gui/action/GotoAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/GotoAction.java:35: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/GotoAction.java:35: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/GotoAction.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/GotoAction.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/GotoAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/GotoAction.java:65: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/GotoAction.java:65: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/GotoAction.java:66: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/action/GotoAction.java:66: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/GotoAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/GotoTileAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/GotoTileAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/GotoTileAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/GotoTileAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/GotoTileAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/GotoTileAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/GotoTileAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/GotoTileAction.java:63: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/GotoTileAction.java:63: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/GotoTileAction.java:64: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ImprovementAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ImprovementAction.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/ImprovementAction.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ImprovementAction.java:47: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ImprovementAction.java:48: Parameter 'improvement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ImprovementAction.java:64: Local variable 'selectedUnit' could be declared final +src/net/sf/freecol/client/gui/action/ImprovementAction.java:64: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ImprovementAction.java:65: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/action/ImprovementAction.java:65: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ImprovementAction.java:66: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/ImprovementAction.java:66: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ImprovementAction.java:68: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ImprovementAction.java:81: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ImprovementAction.java:81: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ImprovementAction.java:82: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/action/ImprovementAction.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ImprovementAction.java:83: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/ImprovementAction.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/LoadAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/LoadAction.java:37: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/LoadAction.java:37: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/LoadAction.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/LoadAction.java:45: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/LoadAction.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/LoadAction.java:60: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/LoadAction.java:61: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/LoadAction.java:71: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/LoadAction.java:71: Found 'UR'-anomaly for variable 'goods' (lines '71'-'79'). +src/net/sf/freecol/client/gui/action/LoadAction.java:71: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/LoadAction.java:72: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/LoadAction.java:73: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/LoadAction.java:73: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/LoadAction.java:75: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/LoadAction.java:76: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/LoadAction.java:78: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/action/LoadAction.java:78: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/LoadAction.java:80: Local variable 'loadable' could be declared final +src/net/sf/freecol/client/gui/action/LoadAction.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/LoadAction.java:81: Local variable 'present' could be declared final +src/net/sf/freecol/client/gui/action/LoadAction.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/LoadAction.java:83: Avoid variables with short names like n +src/net/sf/freecol/client/gui/action/LoadAction.java:83: Local variable 'n' could be declared final +src/net/sf/freecol/client/gui/action/LoadAction.java:85: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/action/MapControlsAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MapControlsAction.java:35: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MapControlsAction.java:35: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/MapControlsAction.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MapControlsAction.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MapControlsAction.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MapControlsAction.java:67: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/MapControlsAction.java:67: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MapControlsAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MapControlsAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MapEditorAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MapEditorAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MapEditorAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/MapEditorAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MapEditorAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MapEditorAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/MapEditorAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MapEditorAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MapboardAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MapboardAction.java:29: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/action/MapboardAction.java:37: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MapboardAction.java:37: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MapboardAction.java:37: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MapboardAction.java:50: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:53: Avoid unused constructor parameters such as 'b'. +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:53: Avoid variables with short names like b +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:53: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:53: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:65: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:65: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:66: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapToggleFogOfWarAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:53: Avoid unused constructor parameters such as 'b'. +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:53: Avoid variables with short names like b +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:53: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:53: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:65: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:65: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:66: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapToggleViewAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:52: Avoid unused constructor parameters such as 'b'. +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:52: Avoid variables with short names like b +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:52: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:52: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:66: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:76: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:76: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomInAction.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:52: Avoid unused constructor parameters such as 'b'. +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:52: Avoid variables with short names like b +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:52: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:52: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:66: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:76: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:76: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MiniMapZoomOutAction.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MoveAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/MoveAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/MoveAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/MoveAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MoveAction.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/MoveAction.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/MoveAction.java:45: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MoveAction.java:45: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MoveAction.java:58: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MoveAction.java:58: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MoveAction.java:59: Avoid unused constructor parameters such as 'secondary'. +src/net/sf/freecol/client/gui/action/MoveAction.java:59: Parameter 'secondary' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MoveAction.java:72: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/MoveAction.java:72: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/MoveAction.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MoveAction.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MoveAction.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MoveAction.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/MoveAction.java:78: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/NewAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/NewAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/NewAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/NewAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/NewAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/NewAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/NewAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/NewAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:36: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:36: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:44: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:66: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:66: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:67: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:68: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:70: Local variable 'map' could be declared final +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:70: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:70: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:72: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:73: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:73: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/NewEmptyMapAction.java:76: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/OpenAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/OpenAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/OpenAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/OpenAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/OpenAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/OpenAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/OpenAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/OpenAction.java:52: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/action/OpenAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/OpenAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/PreferencesAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/PreferencesAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/PreferencesAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/PreferencesAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/PreferencesAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/PreferencesAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/PreferencesAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/PreferencesAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/QuitAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/QuitAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/QuitAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/QuitAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/QuitAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/QuitAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/QuitAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReconnectAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReconnectAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReconnectAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReconnectAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReconnectAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReconnectAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReconnectAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReconnectAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/RenameAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/RenameAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/RenameAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/RenameAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/RenameAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/RenameAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/RenameAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/RenameAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/RenameAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/RenameAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportCargoAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportColonyAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportContinentalCongressAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportEducationAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportExplorationAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportForeignAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportHighScoresAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportHistoryAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportIndianAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:52: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:52: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportLabourAction.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportMilitaryAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportNavalAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportProductionAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportReligionAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportRequirementsAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportTradeAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ReportTurnAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/RetireAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/RetireAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/RetireAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/RetireAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/RetireAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/RetireAction.java:53: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/action/RetireAction.java:56: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/RetireAction.java:66: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/RetireAction.java:66: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SaveAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/SaveAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/SaveAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/SaveAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/SaveAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SaveAction.java:52: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/SaveAction.java:52: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/SaveAction.java:55: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/SaveAction.java:55: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/SaveAction.java:56: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SaveAction.java:66: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/SaveAction.java:66: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SaveAction.java:67: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/action/SaveAction.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SaveAction.java:70: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:55: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/SaveAndQuitAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:36: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:36: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:44: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:57: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:68: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:70: Found 'DU'-anomaly for variable 'oldWidth' (lines '70'-'101'). +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:70: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:71: Found 'DU'-anomaly for variable 'oldHeight' (lines '71'-'101'). +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:71: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:73: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:73: Local variable 'map' could be declared final +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:80: Local variable 'importTile' could be declared final +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:81: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:81: Avoid variables with short names like t +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:81: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:82: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:124: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:124: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:125: Avoid variables with short names like ms +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:125: Local variable 'ms' could be declared final +src/net/sf/freecol/client/gui/action/ScaleMapAction.java:125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SelectableAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/SelectableAction.java:32: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/action/SelectableAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/SelectableAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/SelectableAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/SelectableAction.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/SelectableAction.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/SelectableAction.java:38: Avoid using redundant field initializer for 'selected' +src/net/sf/freecol/client/gui/action/SelectableAction.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/SelectableAction.java:48: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SelectableAction.java:49: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/SelectableAction.java:49: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SelectableAction.java:49: Parameter 'optionId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SelectableAction.java:53: Overridable method 'shouldBeSelected' called during object construction +src/net/sf/freecol/client/gui/action/SelectableAction.java:62: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/client/gui/action/SelectableAction.java:63: Avoid variables with short names like co +src/net/sf/freecol/client/gui/action/SelectableAction.java:63: Local variable 'co' could be declared final +src/net/sf/freecol/client/gui/action/SelectableAction.java:66: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/SelectableAction.java:66: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/SelectableAction.java:67: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/action/SelectableAction.java:68: There is log block not surrounded by if +src/net/sf/freecol/client/gui/action/SelectableAction.java:79: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SelectableAction.java:80: Avoid variables with short names like co +src/net/sf/freecol/client/gui/action/SelectableAction.java:80: Local variable 'co' could be declared final +src/net/sf/freecol/client/gui/action/SelectableAction.java:81: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/SelectableAction.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/SelectableAction.java:98: Avoid variables with short names like b +src/net/sf/freecol/client/gui/action/SelectableAction.java:98: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SelectableAction.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SelectableAction.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SelectableAction.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SelectableAction.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/SentryAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/SentryAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/SentryAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/SentryAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/SentryAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SentryAction.java:54: Parameter 'actionEvent' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SentryAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SentryAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SentryAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowDifficultyAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowGameOptionsAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ShowMainAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ShowMainAction.java:35: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ShowMainAction.java:35: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ShowMainAction.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ShowMainAction.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowMainAction.java:54: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ShowMainAction.java:54: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowMainAction.java:55: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/ShowMainAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ShowMainAction.java:56: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ShowMainAction.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ShowMainAction.java:60: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ShowMapGeneratorOptionsAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:54: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:54: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/SkipUnitAction.java:55: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/TilePopupAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/TilePopupAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/TilePopupAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/TilePopupAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/TilePopupAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/TilePopupAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/TilePopupAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/TilePopupAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:33: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:33: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:52: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:52: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ToggleViewModeAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:51: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:51: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/TradeRouteAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/UnitAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/UnitAction.java:29: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/action/UnitAction.java:38: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/UnitAction.java:38: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/UnitAction.java:38: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/UnitAction.java:51: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/UnitAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/UnitAction.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/UnitAction.java:53: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/UnloadAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/UnloadAction.java:34: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/UnloadAction.java:34: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/UnloadAction.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/UnloadAction.java:36: Avoid using redundant field initializer for 'unit' +src/net/sf/freecol/client/gui/action/UnloadAction.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/action/UnloadAction.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/UnloadAction.java:44: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/UnloadAction.java:48: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/UnloadAction.java:57: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/UnloadAction.java:57: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/UnloadAction.java:65: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/action/UnloadAction.java:65: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/UnloadAction.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/UnloadAction.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/UnloadAction.java:82: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/action/UnloadAction.java:92: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/UnloadAction.java:92: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/UnloadAction.java:93: Local variable 'carrier' could be declared final +src/net/sf/freecol/client/gui/action/UnloadAction.java:94: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/UnloadAction.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/WaitAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/WaitAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/WaitAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/WaitAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/WaitAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/WaitAction.java:53: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/WaitAction.java:53: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/WaitAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomInAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ZoomInAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ZoomInAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ZoomInAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ZoomInAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ZoomInAction.java:52: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/ZoomInAction.java:52: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/ZoomInAction.java:54: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/ZoomInAction.java:54: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/ZoomInAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomInAction.java:56: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomInAction.java:66: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ZoomInAction.java:66: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ZoomInAction.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomInAction.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomInAction.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:32: Variables that are final and static should be all capitals, 'id' is not all capitals. +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:52: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:52: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:54: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:54: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:54: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:56: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:66: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:66: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/action/ZoomOutAction.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/Animations.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/animation/Animations.java:30: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/client/gui/animation/Animations.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:40: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:41: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:41: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:46: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/animation/Animations.java:56: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:57: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:57: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:58: Parameter 'attackerTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:58: Parameter 'defenderTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/Animations.java:59: Parameter 'success' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:41: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:42: Avoid using redundant field initializer for 'mirror' +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:44: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:54: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:55: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:55: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:56: Parameter 'attackerTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:56: Parameter 'defenderTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:57: Parameter 'success' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:66: Parameter 'startStr' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:67: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:68: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:70: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:74: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:81: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:93: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:93: The method getAnimation() has an NPath complexity of 640 +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:94: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:95: Local variable 'scale' could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:96: Local variable 'roleStr' could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:96: Useless parentheses. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:96: Useless parentheses. +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:98: Local variable 'startStr' could be declared final +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:103: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:106: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:106: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:108: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:112: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:113: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:113: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:115: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:120: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:120: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:124: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:134: Found 'DU'-anomaly for variable 'gui' (lines '134'-'153'). +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:135: Found 'DD'-anomaly for variable 'direction' (lines '135'-'147'). +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:135: Found 'DU'-anomaly for variable 'direction' (lines '135'-'153'). +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:139: Avoid assignments in operands +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:139: Found 'DD'-anomaly for variable 'sza' (lines '139'-'148'). +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:139: Found 'DU'-anomaly for variable 'sza' (lines '139'-'153'). +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:139: These nested if statements could be combined +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:148: Avoid assignments in operands +src/net/sf/freecol/client/gui/animation/UnitAttackAnimation.java:148: Found 'DU'-anomaly for variable 'sza' (lines '148'-'153'). +src/net/sf/freecol/client/gui/menu/DebugMenu.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/DebugMenu.java:59: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/menu/DebugMenu.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/DebugMenu.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/DebugMenu.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/menu/DebugMenu.java:66: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/DebugMenu.java:74: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:84: Avoid really long methods. +src/net/sf/freecol/client/gui/menu/DebugMenu.java:84: Found 'UR'-anomaly for variable 'en' (lines '84'-'354'). +src/net/sf/freecol/client/gui/menu/DebugMenu.java:84: Found 'UR'-anomaly for variable 'p' (lines '84'-'160'). +src/net/sf/freecol/client/gui/menu/DebugMenu.java:84: The method buildDebugMenu() has an NCSS line count of 161 +src/net/sf/freecol/client/gui/menu/DebugMenu.java:94: Avoid variables with short names like sc +src/net/sf/freecol/client/gui/menu/DebugMenu.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:100: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:101: Local variable 'val' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:113: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:125: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:137: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:138: Local variable 'val' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:145: Avoid variables with short names like bg +src/net/sf/freecol/client/gui/menu/DebugMenu.java:145: Local variable 'bg' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:153: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:159: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:167: Avoid variables with short names like fp +src/net/sf/freecol/client/gui/menu/DebugMenu.java:168: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:180: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:190: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:191: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:199: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:208: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:217: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:226: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:235: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:245: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:251: Avoid variables with short names like du +src/net/sf/freecol/client/gui/menu/DebugMenu.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:254: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:265: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:268: Avoid variables with short names like b +src/net/sf/freecol/client/gui/menu/DebugMenu.java:268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:274: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:282: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:285: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:299: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:299: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:299: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:299: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:300: Local variable 'val' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:300: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:311: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:314: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:314: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:322: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:323: Local variable 'val' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:336: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:339: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:342: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:348: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:349: Local variable 'builder' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:350: Local variable 'resources' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:352: Local variable 'en' could be declared final +src/net/sf/freecol/client/gui/menu/DebugMenu.java:356: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:357: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/menu/DebugMenu.java:357: StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. +src/net/sf/freecol/client/gui/menu/DebugMenu.java:358: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/menu/DebugMenu.java:360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:362: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:366: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:369: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:370: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:375: Avoid variables with short names like gc +src/net/sf/freecol/client/gui/menu/DebugMenu.java:376: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:379: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/DebugMenu.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/DebugMenu.java:380: Do not explicitly trigger a garbage collection. +src/net/sf/freecol/client/gui/menu/DebugMenu.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:50: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:56: Avoid variables with short names like am +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:65: Avoid variables with short names like f +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:65: Parameter 'f' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:110: Parameter 'actionId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:111: Found 'DD'-anomaly for variable 'rtn' (lines '111'-'115'). +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:112: Local variable 'action' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:114: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:123: There is log block not surrounded by if +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:129: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:138: Parameter 'actionId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:139: Parameter 'actionListener' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:140: Local variable 'rtn' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:154: Parameter 'actionId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:156: Found 'DD'-anomaly for variable 'rtn' (lines '156'-'160'). +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:157: Local variable 'action' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:159: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:164: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:164: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:166: Avoid using if...else statements without curly braces +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:166: There is log block not surrounded by if +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:180: Parameter 'actionId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:181: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:182: Found 'DD'-anomaly for variable 'rtn' (lines '182'-'186'). +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:183: Local variable 'action' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:185: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:193: There is log block not surrounded by if +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:212: Parameter 'enabled' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:218: Found 'UR'-anomaly for variable 'type' (lines '218'-'226'). +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:218: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:221: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:225: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:238: Avoid variables with short names like g +src/net/sf/freecol/client/gui/menu/FreeColMenuBar.java:238: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:47: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:48: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:49: This final field could be made static +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:49: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:51: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:52: Found 'DD'-anomaly for variable 'menuBar' (lines '52'-'58'). +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:54: Local variable 'client' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:60: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:65: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:67: Local variable 'contentPane' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:82: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:82: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:82: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:83: Local variable 'source' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:84: Avoid variables with short names like s +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:84: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:93: Avoid variables with short names like e +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:93: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:93: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:94: Local variable 'source' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:95: Avoid variables with short names like s +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:95: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:108: Avoid variables with short names like o +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:108: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:108: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:109: Local variable 'classString' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:110: Local variable 'dotIndex' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:119: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:120: Local variable 'imgURL' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:121: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:122: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:124: System.err.println is used +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:137: Local variable 'client' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:139: Local variable 'frame' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:145: Local variable 'demo' could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:154: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:154: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:154: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/menu/FreeColMenuTest.java:157: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:43: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:66: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:66: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:114: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:144: Found 'UR'-anomaly for variable 'type' (lines '144'-'159'). +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:146: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:157: Found 'DU'-anomaly for variable 'group' (lines '157'-'176'). +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:157: Local variable 'group' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:158: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:178: Found 'UR'-anomaly for variable 'type' (lines '178'-'200'). +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:180: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:191: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:198: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:198: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:198: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:227: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:260: Avoid variables with short names like g +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:260: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:264: Local variable 'g2d' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:270: Local variable 'displayString' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:277: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:277: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:278: Avoid excessively long variable names like displayStringBounds +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:278: Local variable 'displayStringBounds' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:279: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:279: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:280: Avoid variables with short names like y +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:280: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:280: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:280: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:280: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:280: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:282: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/InGameMenuBar.java:282: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:43: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:66: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:92: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:103: Local variable 'playItem' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:104: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:105: Local variable 'startFile' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:107: Local variable 'options' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:109: Local variable 'fileOption' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:112: Local variable 'mapOptionsFile' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:116: Avoid empty catch blocks +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:116: Avoid empty catch blocks +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:132: Found 'UR'-anomaly for variable 'type' (lines '132'-'145'). +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:134: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:143: Found 'DU'-anomaly for variable 'tileTextGroup' (lines '143'-'154'). +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:143: Local variable 'tileTextGroup' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:144: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:158: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MapEditorMenuBar.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:30: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:50: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:50: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:59: Avoid variables with short names like e +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:59: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:67: Avoid variables with short names like e +src/net/sf/freecol/client/gui/menu/MenuMouseMotionListener.java:67: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:55: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:55: headerCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:59: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:59: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:59: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:60: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:60: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:60: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:64: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:64: headerCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:68: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:68: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:68: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:73: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:73: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:74: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:74: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:75: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:75: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:75: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:76: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:76: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:77: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:77: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:88: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:94: Local variable 'numberOption' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:95: Local variable 'typeOption' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:96: Local variable 'roleOption' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:98: Local variable 'numberEditable' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:99: Useless parentheses. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:99: Useless parentheses. +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:104: Local variable 'typeEditable' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:124: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:124: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:124: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:125: Local variable 'box' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:127: Found 'DD'-anomaly for variable 'enable' (lines '127'-'132'). +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:128: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:168: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:169: Local variable 'roleId' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:170: Local variable 'number' could be declared final +src/net/sf/freecol/client/gui/option/AbstractUnitOptionUI.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:48: Perhaps 'button1' could be replaced by a local variable. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:49: Perhaps 'button2' could be replaced by a local variable. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:53: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:62: Parameter 'gui' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:63: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:68: Local variable 'layout' could be declared final +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:91: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:91: Local variable 'aHandler' could be declared final +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:122: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:122: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/AudioMixerOptionUI.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:45: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:55: Avoid variables with short names like b +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:55: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/BooleanOptionUI.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FileOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/FileOptionUI.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FileOptionUI.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FileOptionUI.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FileOptionUI.java:43: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FileOptionUI.java:52: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:57: Local variable 'file' could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:58: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/option/FileOptionUI.java:59: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/option/FileOptionUI.java:63: Local variable 'browse' could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:65: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/option/FileOptionUI.java:66: Avoid variables with short names like f +src/net/sf/freecol/client/gui/option/FileOptionUI.java:66: Local variable 'f' could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:67: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/option/FileOptionUI.java:72: Local variable 'remove' could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:74: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/option/FileOptionUI.java:84: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/FileOptionUI.java:105: Avoid variables with short names like f +src/net/sf/freecol/client/gui/option/FileOptionUI.java:105: Parameter 'f' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FileOptionUI.java:126: Avoid variables with short names like f +src/net/sf/freecol/client/gui/option/FileOptionUI.java:126: Local variable 'f' could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:126: Useless parentheses. +src/net/sf/freecol/client/gui/option/FileOptionUI.java:126: Useless parentheses. +src/net/sf/freecol/client/gui/option/FileOptionUI.java:127: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/option/FileOptionUI.java:127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FileOptionUI.java:129: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FileOptionUI.java:137: Local variable 'file' could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FileOptionUI.java:138: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/option/FileOptionUI.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:49: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:55: Avoid variables with short names like bl +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:67: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:67: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:70: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:95: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:95: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:96: Avoid variables with short names like g +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:96: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:111: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:111: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:112: Avoid variables with short names like g +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:112: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:132: Parameter 'keyStroke' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:134: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:137: Avoid variables with short names like s +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:138: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:138: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:151: Avoid variables with short names like k +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:151: Parameter 'k' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:155: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:160: Avoid variables with short names like ui +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:160: Parameter 'ui' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:160: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:171: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:171: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:178: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:186: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:188: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:188: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:189: Avoid using redundant field initializer for 'blinkOn' +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:189: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:189: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:201: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:201: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:201: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:202: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:210: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:210: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:210: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:212: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:212: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:212: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:214: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:214: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:214: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:216: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:216: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:216: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:220: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:225: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:230: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:235: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:242: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:242: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:242: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:245: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:245: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:245: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:248: Avoid variables with short names like e +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:248: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:248: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:249: Avoid variables with short names like ks +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:249: Local variable 'ks' could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:254: Comment is too large: Line too long +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:267: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:267: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:268: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:299: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/FreeColActionUI.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:39: Comment is too large: Line too long +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:43: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:46: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:51: Local variable 'tmp' could be declared final +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:55: Local variable 'stepSize' could be declared final +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/IntegerOptionUI.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:48: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:51: Local variable 'languages' could be declared final +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/LanguageOptionUI.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/ModOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/ModOptionUI.java:41: headerCommentRequirement Required +src/net/sf/freecol/client/gui/option/ModOptionUI.java:48: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:48: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:55: headerCommentRequirement Required +src/net/sf/freecol/client/gui/option/ModOptionUI.java:62: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:62: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:63: Local variable 'modFile' could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:74: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/option/ModOptionUI.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/ModOptionUI.java:84: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:87: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:89: Local variable 'choice' could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:108: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:108: Parameter 'modFile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:109: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/option/ModOptionUI.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/ModOptionUI.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/ModOptionUI.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/ModOptionUI.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:54: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:58: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:63: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:67: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:69: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:79: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:79: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:79: Parameter 'gui' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:89: Local variable 'root' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:92: Local variable 'treeModel' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:95: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:99: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:99: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:100: Parameter 'expanded' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:100: Parameter 'selected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:101: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:101: Parameter 'leaf' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:101: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:102: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:104: Local variable 'option' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:111: Local variable 'renderer' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:122: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:130: Found 'UR'-anomaly for variable 'option' (lines '130'-'132'). +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:130: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:130: Parameter 'parent' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:131: Local variable 'option' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:133: Local variable 'branch' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:134: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:149: Found 'UR'-anomaly for variable 'option' (lines '149'-'157'). +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:149: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:151: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:155: Local variable 'group' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:156: Local variable 'option' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:173: Found 'UR'-anomaly for variable 'optionUpdater' (lines '173'-'175'). +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:173: Parameter 'keyStroke' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:174: Local variable 'optionUpdater' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:181: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:181: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:185: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:185: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:186: Avoid variables with short names like ui +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:190: There is log block not surrounded by if +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:200: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:219: Found 'UR'-anomaly for variable 'optionUpdater' (lines '219'-'221'). +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:220: Local variable 'optionUpdater' could be declared final +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:229: Found 'UR'-anomaly for variable 'optionUpdater' (lines '229'-'231'). +src/net/sf/freecol/client/gui/option/OptionGroupUI.java:230: Local variable 'optionUpdater' could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/OptionUI.java:49: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/option/OptionUI.java:49: The class 'OptionUI' has a Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/client/gui/option/OptionUI.java:49: The class 'OptionUI' has a Modified Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/client/gui/option/OptionUI.java:49: The class 'OptionUI' has a Standard Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/client/gui/option/OptionUI.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/OptionUI.java:67: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:67: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:71: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:72: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:82: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionUI.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionUI.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/option/OptionUI.java:88: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionUI.java:92: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionUI.java:96: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionUI.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionUI.java:112: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:112: Parameter 'gui' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:112: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:112: The method 'getOptionUI' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/option/OptionUI.java:112: The method 'getOptionUI' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/option/OptionUI.java:112: The method 'getOptionUI' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/option/OptionUI.java:114: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:118: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:120: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:122: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:126: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:130: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:132: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:134: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:136: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:138: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:142: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/option/OptionUI.java:151: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionUI.java:155: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/OptionUI.java:155: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/option/OptionUI.java:164: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/client/gui/option/OptionUpdater.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/OptionUpdater.java:35: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/option/OptionUpdater.java:40: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/option/PercentageOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/PercentageOptionUI.java:47: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/PercentageOptionUI.java:50: Local variable 'slider' could be declared final +src/net/sf/freecol/client/gui/option/PercentageOptionUI.java:53: Consider replacing this Hashtable with the newer java.util.Map +src/net/sf/freecol/client/gui/option/PercentageOptionUI.java:53: Local variable 'labels' could be declared final +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:47: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:50: Local variable 'slider' could be declared final +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:55: Consider replacing this Hashtable with the newer java.util.Map +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:55: Local variable 'labels' could be declared final +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:58: Local variable 'string' could be declared final +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:62: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/RangeOptionUI.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:48: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:51: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:52: Local variable 'string' could be declared final +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/SelectOptionUI.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/SliderOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/SliderOptionUI.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/SliderOptionUI.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/SliderOptionUI.java:49: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/SliderOptionUI.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/SliderOptionUI.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/SliderOptionUI.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/StringOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/StringOptionUI.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/StringOptionUI.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/StringOptionUI.java:49: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/StringOptionUI.java:52: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/option/StringOptionUI.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/StringOptionUI.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/StringOptionUI.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/TextOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/TextOptionUI.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/TextOptionUI.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/TextOptionUI.java:44: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/TextOptionUI.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/TextOptionUI.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/TextOptionUI.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:41: headerCommentRequirement Required +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:48: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:48: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:54: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:65: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:68: Local variable 'choices' could be declared final +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/option/UnitTypeOptionUI.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/AboutPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/AboutPanel.java:44: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/AboutPanel.java:74: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/AboutPanel.java:74: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/AboutPanel.java:74: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/AboutPanel.java:76: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/AboutPanel.java:78: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/AboutPanel.java:80: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/AboutPanel.java:89: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:93: Local variable 'tempImage' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:94: Local variable 'apLogoLabel' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:101: Local variable 'fontBold' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:104: Local variable 'fontNormal' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:108: Local variable 'apVersion' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:110: Local variable 'apRevision' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:113: The String literal "newline" appears 4 times in this file; the first occurrence is on line 113 +src/net/sf/freecol/client/gui/panel/AboutPanel.java:119: The String literal "newline 10" appears 4 times in this file; the first occurrence is on line 119 +src/net/sf/freecol/client/gui/panel/AboutPanel.java:120: Local variable 'apSiteURL' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:130: Local variable 'apProjectURL' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:136: Local variable 'apManual' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:139: Local variable 'apManualURL' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:145: Local variable 'apLegal' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:151: Local variable 'apCopyright' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:164: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/AboutPanel.java:164: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:168: Avoid variables with short names like os +src/net/sf/freecol/client/gui/panel/AboutPanel.java:168: Local variable 'os' could be declared final +src/net/sf/freecol/client/gui/panel/AboutPanel.java:170: Found 'DD'-anomaly for variable 'cmd' (lines '170'-'176'). +src/net/sf/freecol/client/gui/panel/AboutPanel.java:170: Found 'DD'-anomaly for variable 'cmd' (lines '170'-'179'). +src/net/sf/freecol/client/gui/panel/AboutPanel.java:170: Found 'DD'-anomaly for variable 'cmd' (lines '170'-'184'). +src/net/sf/freecol/client/gui/panel/AboutPanel.java:170: Found 'DD'-anomaly for variable 'cmd' (lines '170'-'186'). +src/net/sf/freecol/client/gui/panel/AboutPanel.java:170: Found 'DU'-anomaly for variable 'cmd' (lines '170'-'196'). +src/net/sf/freecol/client/gui/panel/AboutPanel.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/AboutPanel.java:174: When doing a String.toLowerCase()/toUpperCase() call, use a Locale +src/net/sf/freecol/client/gui/panel/AboutPanel.java:177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/AboutPanel.java:177: When doing a String.toLowerCase()/toUpperCase() call, use a Locale +src/net/sf/freecol/client/gui/panel/AboutPanel.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/AboutPanel.java:181: When doing a String.toLowerCase()/toUpperCase() call, use a Locale +src/net/sf/freecol/client/gui/panel/AboutPanel.java:189: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/AboutPanel.java:190: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/AboutPanel.java:190: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:39: Avoid using redundant field initializer for 'partialChosen' +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:41: Avoid using redundant field initializer for 'fullChosen' +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:41: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:50: Parameter 'abstractGoods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:50: Parameter 'lib' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:73: Parameter 'partialChosen' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:91: Parameter 'fullChosen' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/AbstractGoodsLabel.java:127: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:20: Possible God class (WMC=182, ATFD=145, TCC=0.01) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:35: Avoid unused imports such as 'java.util.Arrays' +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:96: Avoid really long classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:96: The class 'BuildQueuePanel' has a Cyclomatic Complexity of 8 (Highest = 24). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:96: The class 'BuildQueuePanel' has a Modified Cyclomatic Complexity of 7 (Highest = 18). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:96: The class 'BuildQueuePanel' has a Standard Cyclomatic Complexity of 7 (Highest = 18). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:96: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:98: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:98: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:101: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:109: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:109: The class 'BuildQueueTransferHandler' has a Cyclomatic Complexity of 8 (Highest = 33). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:109: The class 'BuildQueueTransferHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 25). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:109: The class 'BuildQueueTransferHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 25). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:116: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:118: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:128: Parameter 'buildables' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:149: Parameter 'flavor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:151: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:160: Returning 'supportedFlavors' may expose an internal array. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:167: Parameter 'flavor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:168: Avoid variables with short names like f +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:172: Avoid using redundant field initializer for 'source' +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:172: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:172: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:172: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:174: Avoid unused private fields such as 'numberOfItems'. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:174: Avoid using redundant field initializer for 'numberOfItems' +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:174: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:174: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:174: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:183: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:183: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:183: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:183: The method 'importData' has a Cyclomatic Complexity of 33. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:183: The method 'importData' has a Modified Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:183: The method 'importData' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:183: The method importData() has an NPath complexity of 1875456 +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:184: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:184: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:187: Local variable 'target' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:189: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:190: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:196: Found 'DU'-anomaly for variable 'transferData' (lines '196'-'321'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:199: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:201: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:201: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:204: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:206: Local variable 'queue' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:207: Local variable 'object' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:213: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:214: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:214: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:215: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:216: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:216: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:217: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:219: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:226: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:229: Local variable 'sourceModel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:231: Local variable 'obj' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:234: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:241: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:241: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:241: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:246: Local variable 'targetModel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:251: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:251: Local variable 'maxIndex' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:255: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:265: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:269: Local variable 'maximumIndex' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:272: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:278: Local variable 'bt' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:279: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:290: Local variable 'toBuild' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:296: Local variable 'maximumIndex' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:327: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:327: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:328: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:338: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:338: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:338: Parameter 'flavors' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:340: Avoid variables with short names like f +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:347: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:349: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:349: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:350: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:350: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:359: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:360: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:364: The class 'BuildQueueMouseAdapter' has a Cyclomatic Complexity of 8 (Highest = 14). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:364: The class 'BuildQueueMouseAdapter' has a Modified Cyclomatic Complexity of 6 (Highest = 10). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:364: The class 'BuildQueueMouseAdapter' has a Standard Cyclomatic Complexity of 6 (Highest = 10). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:364: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:366: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:366: Private field 'add' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:366: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:368: Avoid using redundant field initializer for 'enabled' +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:368: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:368: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:371: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:371: Parameter 'add' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:371: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: Found 'UR'-anomaly for variable 'bt' (lines '380'-'406'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: Found 'UR'-anomaly for variable 'bt' (lines '380'-'408'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: The method 'mousePressed' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: The method 'mousePressed' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: The method 'mousePressed' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:380: The method mousePressed() has an NPath complexity of 800 +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:384: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:384: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:386: Local variable 'source' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:387: Local variable 'jlist' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:388: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:388: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:390: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:391: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:394: Local variable 'index' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:395: Avoid variables with short names like bt +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:395: Local variable 'bt' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:395: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:396: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:398: Local variable 'bql' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:399: Found 'DU'-anomaly for variable 'model' (lines '399'-'413'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:399: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:404: Local variable 'bt' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:420: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:420: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:421: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:421: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:422: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:422: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:423: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:423: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:425: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:425: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:428: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:428: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:431: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:444: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:445: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:446: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:447: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:448: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:449: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:449: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:449: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:450: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:452: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:455: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:456: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:464: Found 'DU'-anomaly for variable 'lib' (lines '464'-'478'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:464: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:465: Local variable 'required' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:466: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:466: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:468: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:468: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:469: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:469: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:470: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:470: Local variable 'goodsLabel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:470: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:472: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:474: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:482: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:482: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:483: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:483: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:486: Avoid using redundant field initializer for 'defaultCompact' +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:486: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:489: Avoid using redundant field initializer for 'defaultShowAll' +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:489: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:492: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:495: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:495: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:498: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:498: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:502: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:502: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:505: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:505: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:508: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:508: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:511: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:511: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:514: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:514: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:517: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:517: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:520: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:520: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:522: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:522: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:522: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:522: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:523: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:523: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:523: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:533: Found 'UR'-anomaly for variable 'bt' (lines '533'-'563'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:533: Found 'UR'-anomaly for variable 'bt' (lines '533'-'563'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:533: Found 'UR'-anomaly for variable 'type' (lines '533'-'543'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:533: Found 'UR'-anomaly for variable 'type' (lines '533'-'543'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:533: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:533: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:540: Local variable 'current' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:542: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:547: Local variable 'adapter' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:548: Local variable 'addAction' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:550: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:550: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:550: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:553: Found 'DU'-anomaly for variable 'model' (lines '553'-'672'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:553: Found 'DU'-anomaly for variable 'model' (lines '553'-'672'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:554: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:558: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:558: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:560: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:562: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:571: Local variable 'fontSubHead' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:576: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:581: Local variable 'bqpUnits' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:583: Local variable 'bpqBuildQueue' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:586: Local variable 'bqpBuildings' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:589: Local variable 'units' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:597: The String literal "add" appears 4 times in this file; the first occurrence is on line 597 +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:617: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:617: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:617: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:618: Local variable 'bql' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:620: Local variable 'bt' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:620: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:627: Local variable 'buildings' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:692: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:696: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:699: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:700: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:702: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: Found 'UR'-anomaly for variable 'ability' (lines '705'-'738'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: Found 'UR'-anomaly for variable 'entry' (lines '705'-'758'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: Found 'UR'-anomaly for variable 'limit' (lines '705'-'727'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: Found 'UR'-anomaly for variable 'unitType' (lines '705'-'715'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: The method 'updateUnitList' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: The method 'updateUnitList' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: The method 'updateUnitList' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:705: The method updateUnitList() has an NPath complexity of 7681 +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:707: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:709: Local variable 'units' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:711: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:712: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:712: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:714: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:714: Local variable 'lockReason' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:719: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:720: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:721: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:722: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:725: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:726: Local variable 'limit' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:726: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:727: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:727: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:728: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:736: Found 'DD'-anomaly for variable 'builderFound' (lines '736'-'743'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:737: Local variable 'ability' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:737: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:738: Local variable 'source' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:738: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:739: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:740: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:745: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:756: Local variable 'entry' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:757: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:757: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:758: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:758: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:759: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:761: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:762: Local variable 'sources' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:763: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:763: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:764: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:765: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:774: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:777: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:781: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:782: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:787: Found 'UR'-anomaly for variable 'buildingType' (lines '787'-'799'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:787: Found 'UR'-anomaly for variable 'entry' (lines '787'-'830'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:787: Found 'UR'-anomaly for variable 'limit' (lines '787'-'848'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:787: The method 'updateBuildingList' has a Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:787: The method 'updateBuildingList' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:787: The method 'updateBuildingList' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:787: The method updateBuildingList() has an NPath complexity of 21601 +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:796: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:796: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:798: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:798: Local variable 'lockReason' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:799: Found 'DU'-anomaly for variable 'colonyBuilding' (lines '799'-'874'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:799: Local variable 'colonyBuilding' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:800: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:806: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:806: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:809: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:815: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:821: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:823: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:824: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:828: Local variable 'entry' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:829: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:831: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:833: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:834: Local variable 'sources' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:834: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:835: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:835: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:836: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:841: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:841: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:846: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:847: Local variable 'limit' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:847: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:848: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:848: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:849: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:854: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:855: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:855: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:856: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:857: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:857: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:859: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:859: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:863: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:866: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:870: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:871: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:881: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:881: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:882: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:883: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:883: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:897: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:899: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:899: Avoid variables with short names like bt +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:899: Local variable 'bt' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:899: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:899: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:899: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:900: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:906: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:907: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:908: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:913: Parameter 'buildable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:914: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:914: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:915: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:918: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:922: Parameter 'buildingType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:924: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:925: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:926: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:927: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:928: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:934: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:935: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:936: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:936: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:937: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:938: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:939: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:944: Parameter 'buildableType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:944: The method 'getMinimumIndex' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:944: The method 'getMinimumIndex' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:944: The method 'getMinimumIndex' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:945: Found 'DU'-anomaly for variable 'buildQueue' (lines '945'-'968'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:945: Local variable 'buildQueue' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:947: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:947: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:948: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:949: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:949: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:949: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:950: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:953: Local variable 'upgradesFrom' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:953: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:955: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:955: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:956: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:958: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:958: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:959: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:960: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:960: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:960: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:961: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:962: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:962: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:963: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:970: Parameter 'buildableType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:970: The method 'getMaximumIndex' has a Cyclomatic Complexity of 22. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:970: The method 'getMaximumIndex' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:970: The method 'getMaximumIndex' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:970: The method getMaximumIndex() has an NPath complexity of 16060 +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:971: Local variable 'buildQueue' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:972: Found 'DU'-anomaly for variable 'buildQueueLastPos' (lines '972'-'1,037'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:972: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:974: Found 'DD'-anomaly for variable 'canBuild' (lines '974'-'976'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:974: Found 'DU'-anomaly for variable 'canBuild' (lines '974'-'1,037'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:976: Found 'DU'-anomaly for variable 'canBuild' (lines '976'-'1,037'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:982: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:982: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:984: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:985: Local variable 'toBuild' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:986: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:986: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:987: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:988: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:991: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:995: Local variable 'upgradesFrom' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:995: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:997: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:997: Found 'DU'-anomaly for variable 'upgradesTo' (lines '997'-'1,037'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:997: Local variable 'upgradesTo' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:997: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1001: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1007: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1012: Found 'DU'-anomaly for variable 'foundUpgradesFrom' (lines '1,012'-'1,037'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1013: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1014: Local variable 'toBuild' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1016: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1016: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1019: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1020: Found 'DU'-anomaly for variable 'foundUpgradesFrom' (lines '1,020'-'1,037'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1022: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1022: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1026: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1027: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1031: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1034: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1043: Local variable 'cellRenderer' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1044: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1044: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1044: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1044: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1059: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1059: Found 'UR'-anomaly for variable 'FAIL' (lines '1,059'-'1,059'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1059: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1060: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1060: Found 'DU'-anomaly for variable 'FAIL' (lines '1,060'-'1,089'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1062: Found 'DD'-anomaly for variable 'command' (lines '1,062'-'1,069'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1063: Local variable 'buildables' could be declared final +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1063: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1065: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1066: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1067: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1067: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1067: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1067: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1068: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1069: Found 'DD'-anomaly for variable 'command' (lines '1,069'-'1,069'). +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1070: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1072: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1072: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1073: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1081: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1081: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1088: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildQueuePanel.java:1098: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:60: The class 'BuildingDetailPanel' has a Cyclomatic Complexity of 11 (Highest = 26). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:60: The class 'BuildingDetailPanel' has a Modified Cyclomatic Complexity of 11 (Highest = 24). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:60: The class 'BuildingDetailPanel' has a Standard Cyclomatic Complexity of 11 (Highest = 24). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:69: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:70: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:81: Found 'UR'-anomaly for variable 'buildingType' (lines '81'-'91'). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:81: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:82: Local variable 'parent' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:86: Local variable 'buildingTypes' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:87: Found 'DU'-anomaly for variable 'buildingHash' (lines '87'-'123'). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:87: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:87: Local variable 'buildingHash' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:89: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:90: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:92: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:93: Local variable 'item' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:94: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:106: Local variable 'iterator' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:107: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:108: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:110: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:111: Local variable 'item' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:112: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: Found 'UR'-anomaly for variable 'ability' (lines '129'-'246'). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: Found 'UR'-anomaly for variable 'productionBonus' (lines '129'-'237'). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: Found 'UR'-anomaly for variable 'unitType2' (lines '129'-'188'). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: The method 'buildDetail' has a Cyclomatic Complexity of 26. +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: The method 'buildDetail' has a Modified Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: The method 'buildDetail' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:129: The method buildDetail() has an NPath complexity of 54000 +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:130: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:132: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:135: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:139: Local variable 'textPane' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:140: Local variable 'doc' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:149: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:159: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:159: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:165: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:166: The String literal "span" appears 5 times in this file; the first occurrence is on line 166 +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:168: Local variable 'required' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:170: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:187: Local variable 'unitType2' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:194: Found 'DU'-anomaly for variable 'count' (lines '194'-'273'). +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:199: Local variable 'pt' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:201: Local variable 'inputs' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:202: Local variable 'outputs' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:208: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:208: Local variable 'arrow' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:219: Local variable 'workplaces' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:235: Local variable 'labels' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:236: Local variable 'productionBonus' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:237: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:245: Local variable 'ability' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:246: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingDetailPanel.java:258: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:55: The class 'BuildingPanel' has a Cyclomatic Complexity of 2 (Highest = 13). +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:55: The class 'BuildingPanel' has a Modified Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:55: The class 'BuildingPanel' has a Standard Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:57: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:75: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:75: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:124: Found 'UR'-anomaly for variable 'unit' (lines '124'-'165'). +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:124: The method 'update' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:124: The method 'update' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:124: The method 'update' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:124: The method update() has an NPath complexity of 432 +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:128: Found 'DU'-anomaly for variable 'colony' (lines '128'-'176'). +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:129: Found 'DD'-anomaly for variable 'productionOutput' (lines '129'-'144'). +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:130: Local variable 'info' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:134: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:135: Local variable 'stored' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:136: Local variable 'capacity' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:142: Local variable 'maximum' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:148: Found 'DD'-anomaly for variable 'upkeep' (lines '148'-'151'). +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:164: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:165: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:165: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:170: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:171: Local variable 'buildingImage' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:204: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:205: Local variable 'property' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:206: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:227: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:227: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:228: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:239: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:246: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:256: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:256: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:258: Local variable 'gui' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:259: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:260: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:267: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/BuildingPanel.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:52: The class 'BuildingToolTip' has a Cyclomatic Complexity of 15 (Highest = 28). +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:52: The class 'BuildingToolTip' has a Modified Cyclomatic Complexity of 14 (Highest = 25). +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:52: The class 'BuildingToolTip' has a Standard Cyclomatic Complexity of 14 (Highest = 25). +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:54: Avoid using redundant field initializer for 'arrow' +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:54: Possible unsafe assignment to a non-final static field in a constructor. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:63: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:63: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:63: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:63: The constructor 'BuildingToolTip' has a Cyclomatic Complexity of 28. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:63: The constructor 'BuildingToolTip' has a Modified Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:63: The constructor 'BuildingToolTip' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:67: Local variable 'outputs' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:69: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:69: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:69: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:80: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:83: Local variable 'layout' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:87: Local variable 'buildingName' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:92: Local variable 'info' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:93: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:94: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:94: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:94: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:96: Local variable 'consumption' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:97: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:97: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:97: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:102: Local variable 'maxProduction' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:102: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:102: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:103: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:105: Local variable 'productionOutput' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:112: Local variable 'maxConsumption' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:112: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:112: Useless parentheses. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:113: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:115: Local variable 'productionInput' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:134: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:135: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:135: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:136: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:139: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:139: Local variable 'pLabel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:142: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:144: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:144: Local variable 'progress' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:146: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:146: Local variable 'sLabel' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:157: Local variable 'diff' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:159: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:163: Local variable 'breedingNumber' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:174: Local variable 'modifiers' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:179: Local variable 'm' could be declared final +src/net/sf/freecol/client/gui/panel/BuildingToolTip.java:180: Local variable 'mLabels' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:51: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:54: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:59: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:59: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:59: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:77: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:80: Avoid unnecessary constructors - the compiler will generate these for you +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:80: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:80: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:89: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:90: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:91: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:92: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:93: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:102: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:102: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:105: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:105: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:108: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:108: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:108: Perhaps 'noneButton' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:111: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:111: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:111: Private field 'goodsList' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:122: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:122: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:123: Parameter 'loot' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:123: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:129: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:130: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:130: Local variable 'gl' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:133: Avoid variables with short names like gi +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:133: Local variable 'gi' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:142: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:143: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:143: Local variable 'gl' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:145: Avoid variables with short names like gi +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:145: Local variable 'gi' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:153: Found 'DD'-anomaly for variable 'goods' (lines '153'-'155'). +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:155: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:155: Found 'DD'-anomaly for variable 'goods' (lines '155'-'155'). +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:162: Avoid variables with short names like me +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:162: Parameter 'me' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:162: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:163: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:163: Local variable 'gl' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:164: Local variable 'index' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:165: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:166: Local variable 'item' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:166: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:167: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:172: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:180: Local variable 'fake' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:181: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:181: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:193: Found 'DD'-anomaly for variable 'selectedCount' (lines '193'-'196'). +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:195: Avoid variables with short names like gi +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:195: Local variable 'gi' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:196: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:196: Found 'DD'-anomaly for variable 'selectedCount' (lines '196'-'196'). +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:202: Avoid variables with short names like gi +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:202: Local variable 'gi' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:203: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:208: Avoid variables with short names like gi +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:208: Local variable 'gi' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:209: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:224: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:225: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:225: Local variable 'gl' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:228: Avoid variables with short names like gi +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:228: Local variable 'gi' could be declared final +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:229: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CaptureGoodsDialog.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/CargoPanel.java:43: The class 'CargoPanel' has a Cyclomatic Complexity of 2 (Highest = 12). +src/net/sf/freecol/client/gui/panel/CargoPanel.java:43: The class 'CargoPanel' has a Modified Cyclomatic Complexity of 2 (Highest = 12). +src/net/sf/freecol/client/gui/panel/CargoPanel.java:43: The class 'CargoPanel' has a Standard Cyclomatic Complexity of 2 (Highest = 12). +src/net/sf/freecol/client/gui/panel/CargoPanel.java:44: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:46: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CargoPanel.java:51: Avoid excessively long variable names like defaultTransferHandler +src/net/sf/freecol/client/gui/panel/CargoPanel.java:51: Avoid using redundant field initializer for 'defaultTransferHandler' +src/net/sf/freecol/client/gui/panel/CargoPanel.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CargoPanel.java:60: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:60: Parameter 'withTitle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:63: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:67: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CargoPanel.java:86: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CargoPanel.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:93: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CargoPanel.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:107: Avoid variables with short names like dl +src/net/sf/freecol/client/gui/panel/CargoPanel.java:107: Found 'DU'-anomaly for variable 'dl' (lines '107'-'135'). +src/net/sf/freecol/client/gui/panel/CargoPanel.java:107: Local variable 'dl' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:108: Local variable 'unitIterator' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:110: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:112: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/CargoPanel.java:112: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:120: Local variable 'goodsIterator' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:122: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/CargoPanel.java:122: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:124: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/CargoPanel.java:124: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:162: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:187: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:194: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:201: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:201: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:201: The method 'add' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:201: The method 'add' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:201: The method 'add' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/CargoPanel.java:202: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/CargoPanel.java:202: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CargoPanel.java:206: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:206: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:208: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/CargoPanel.java:208: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CargoPanel.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:212: Local variable 'toAdd' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:217: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/CargoPanel.java:220: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:221: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:223: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:224: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/CargoPanel.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:227: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:229: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/CargoPanel.java:232: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:234: Found 'DU'-anomaly for variable 'oldParent' (lines '234'-'247'). +src/net/sf/freecol/client/gui/panel/CargoPanel.java:234: Local variable 'oldParent' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:235: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/panel/CargoPanel.java:235: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:236: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:237: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CargoPanel.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:239: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/CargoPanel.java:252: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:260: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:260: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CargoPanel.java:261: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/CargoPanel.java:285: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:287: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:291: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/CargoPanel.java:291: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/CargoPanel.java:291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:292: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CargoPanel.java:310: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ChatPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ChatPanel.java:39: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ChatPanel.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ChatPanel.java:41: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ChatPanel.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ChatPanel.java:43: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ChatPanel.java:51: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ChatPanel.java:54: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ChatPanel.java:86: Local variable 'message' could be declared final +src/net/sf/freecol/client/gui/panel/ChatPanel.java:98: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ChatPanel.java:98: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ChatPanel.java:101: A switch statement does not contain a break +src/net/sf/freecol/client/gui/panel/ChatPanel.java:101: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/client/gui/panel/ChatPanel.java:103: Local variable 'message' could be declared final +src/net/sf/freecol/client/gui/panel/ChatPanel.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ChatPanel.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ChatPanel.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ChatPanel.java:112: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:48: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:50: Avoid variables with short names like tb +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:55: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:66: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:66: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:67: Avoid excessively long variable names like possibleFoundingFathers +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:67: Parameter 'possibleFoundingFathers' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:73: Local variable 'helpButton' could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:77: Local variable 'details' could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:79: Local variable 'father' could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:80: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:80: Avoid variables with short names like jp +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:80: Local variable 'jp' could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:87: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:93: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:93: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:105: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ChooseFoundingFatherDialog.java:107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:36: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:49: Avoid variables with short names like am +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:84: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:97: Parameter 'component' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:102: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:109: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:119: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:131: Parameter 'arrow' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:131: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ClassicMapControls.java:132: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ClientOptionsDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ClientOptionsDialog.java:41: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ClientOptionsDialog.java:41: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ClientOptionsDialog.java:60: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:20: Possible God class (WMC=280, ATFD=287, TCC=0.0429732868757259) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:96: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:105: Avoid really long classes. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:105: The class 'ColonyPanel' has a Cyclomatic Complexity of 4 (Highest = 20). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:105: The class 'ColonyPanel' has a Modified Cyclomatic Complexity of 4 (Highest = 13). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:105: The class 'ColonyPanel' has a Standard Cyclomatic Complexity of 4 (Highest = 17). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:105: Too many fields +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:106: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:108: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:108: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:110: Avoid unused private fields such as 'EXIT'. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:110: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:120: Avoid excessively long variable names like SCROLL_AREA_HEIGHT +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:126: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:126: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:129: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:129: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:132: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:132: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:135: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:135: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:138: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:138: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:142: Avoid using redundant field initializer for 'setGoodsButton' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:142: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:142: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:143: Avoid using redundant field initializer for 'traceWorkButton' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:143: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:143: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:146: Avoid using redundant field initializer for 'colony' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:152: Avoid using redundant field initializer for 'releaseListener' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:152: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:152: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:155: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:155: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:157: Avoid excessively long variable names like netProductionPanel +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:157: Avoid using redundant field initializer for 'netProductionPanel' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:157: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:157: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:159: Avoid using redundant field initializer for 'buildingsScroll' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:159: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:159: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:160: Avoid using redundant field initializer for 'buildingsPanel' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:160: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:160: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:162: Avoid using redundant field initializer for 'cargoScroll' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:162: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:162: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:165: Avoid using redundant field initializer for 'constructionPanel' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:165: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:165: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:167: Avoid using redundant field initializer for 'inPortScroll' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:167: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:167: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:170: Avoid excessively long variable names like outsideColonyScroll +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:170: Avoid using redundant field initializer for 'outsideColonyScroll' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:170: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:170: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:171: Avoid excessively long variable names like outsideColonyPanel +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:171: Avoid using redundant field initializer for 'outsideColonyPanel' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:171: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:171: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:173: Avoid using redundant field initializer for 'populationPanel' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:173: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:173: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:175: Avoid using redundant field initializer for 'tilesScroll' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:175: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:175: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:176: Avoid using redundant field initializer for 'tilesPanel' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:176: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:176: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:178: Avoid using redundant field initializer for 'warehouseScroll' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:178: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:178: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:179: Avoid using redundant field initializer for 'warehousePanel' +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:179: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:179: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:188: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:188: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:188: The constructor 'ColonyPanel' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:209: Local variable 'closeIM' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:211: The String literal "pressed" appears 6 times in this file; the first occurrence is on line 211 +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:213: The String literal "released" appears 6 times in this file; the first occurrence is on line 213 +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:218: Local variable 'unloadIM' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:227: Local variable 'fillIM' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:236: Local variable 'warehouseIM' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:245: Local variable 'buildQueueIM' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:254: Local variable 'colonyUnitsIM' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:274: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:281: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:290: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:351: Local variable 'nameIM' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:358: Local variable 'scale' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:368: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:368: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:372: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:381: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:381: The method initialize() has an NPath complexity of 256 +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:417: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:434: Local variable 'tmp' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:434: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:434: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:435: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:446: Found 'DD'-anomaly for variable 'buttonFields' (lines '446'-'447'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:446: Found 'DD'-anomaly for variable 'buttonFields' (lines '446'-'448'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:447: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:447: Found 'DD'-anomaly for variable 'buttonFields' (lines '447'-'448'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:448: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:455: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:456: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:465: Found 'UR'-anomaly for variable 'listener' (lines '465'-'484'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:480: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:483: Local variable 'listener' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:516: Parameter 'enable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:517: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:517: Local variable 'dth' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:517: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:517: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:530: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:531: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:531: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:532: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:543: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:544: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:548: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:558: Found 'UR'-anomaly for variable 'u' (lines '558'-'566'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:558: Found 'UR'-anomaly for variable 'wl' (lines '558'-'564'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:560: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:563: Local variable 'wl' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:564: Found 'DD'-anomaly for variable 'change' (lines '564'-'571'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:564: Found 'DD'-anomaly for variable 'check' (lines '564'-'564'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:564: Found 'DU'-anomaly for variable 'check' (lines '564'-'581'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:564: Local variable 'check' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:564: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:565: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:566: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:566: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:567: Local variable 'workType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:567: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:568: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:569: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:571: Found 'DD'-anomaly for variable 'change' (lines '571'-'571'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:574: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:574: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:601: Found 'UR'-anomaly for variable 'goods' (lines '601'-'610'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:602: Found 'DU'-anomaly for variable 'colony' (lines '602'-'617'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:606: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:607: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:607: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:609: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:609: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:623: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:623: Found 'UR'-anomaly for variable 'innerUnit' (lines '623'-'699'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:623: Found 'UR'-anomaly for variable 'unit' (lines '623'-'637'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:623: The method 'generateColonyUnitsMenu' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:623: The method 'generateColonyUnitsMenu' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:623: The method 'generateColonyUnitsMenu' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:625: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:627: Local variable 'colonyUnitsMenu' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:629: Found 'DD'-anomaly for variable 'unitIcon' (lines '629'-'642'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:632: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:633: Avoid unused local variables such as 'unitNumber'. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:633: Found 'DD'-anomaly for variable 'unitNumber' (lines '633'-'681'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:634: Found 'DD'-anomaly for variable 'subMenu' (lines '634'-'676'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:637: Found 'DD'-anomaly for variable 'workingInBuilding' (lines '637'-'637'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:637: Found 'DU'-anomaly for variable 'workingInBuilding' (lines '637'-'736'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:637: Local variable 'workingInBuilding' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:638: Found 'DD'-anomaly for variable 'workingOnLand' (lines '638'-'638'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:638: Found 'DU'-anomaly for variable 'workingOnLand' (lines '638'-'736'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:638: Local variable 'workingOnLand' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:639: Found 'DD'-anomaly for variable 'goodsType' (lines '639'-'639'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:639: Found 'DU'-anomaly for variable 'goodsType' (lines '639'-'736'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:639: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:640: Local variable 'student' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:642: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:643: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:643: Avoid variables with short names like sb +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:643: Local variable 'sb' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:644: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:646: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:646: The String literal "colonyPanel.producing" appears 4 times in this file; the first occurrence is on line 646 +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:647: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:647: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:647: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:649: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:650: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:651: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:652: Local variable 'producing' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:653: Local variable 'nominative' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:657: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:658: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:659: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:660: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:661: Local variable 'producing' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:663: Local variable 'nominative' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:663: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:663: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:667: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:668: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:669: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:672: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:673: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:675: Local variable 'menuTitle' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:676: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:677: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:678: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:679: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:679: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:681: Found 'DD'-anomaly for variable 'unitNumber' (lines '681'-'681'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:681: Found 'DD'-anomaly for variable 'unitNumber' (lines '681'-'695'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:681: Found 'DD'-anomaly for variable 'unitNumber' (lines '681'-'721'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:681: Found 'DU'-anomaly for variable 'unitNumber' (lines '681'-'736'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:687: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:690: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:691: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:692: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:693: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:693: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:695: Found 'DD'-anomaly for variable 'unitNumber' (lines '695'-'695'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:695: Found 'DD'-anomaly for variable 'unitNumber' (lines '695'-'708'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:695: Found 'DD'-anomaly for variable 'unitNumber' (lines '695'-'721'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:695: Found 'DU'-anomaly for variable 'unitNumber' (lines '695'-'736'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:699: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:703: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:704: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:705: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:706: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:706: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:708: Found 'DD'-anomaly for variable 'unitNumber' (lines '708'-'695'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:708: Found 'DD'-anomaly for variable 'unitNumber' (lines '708'-'708'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:708: Found 'DD'-anomaly for variable 'unitNumber' (lines '708'-'721'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:708: Found 'DU'-anomaly for variable 'unitNumber' (lines '708'-'736'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:713: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:714: Local variable 'menuTitle' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:716: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:717: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:718: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:719: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:719: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:721: Found 'DD'-anomaly for variable 'unitNumber' (lines '721'-'695'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:721: Found 'DD'-anomaly for variable 'unitNumber' (lines '721'-'721'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:721: Found 'DU'-anomaly for variable 'unitNumber' (lines '721'-'736'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:727: Local variable 'elements' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:727: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:729: Local variable 'lastIndex' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:735: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:735: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:745: Avoid variables with short names like wl +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:745: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:745: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:747: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:747: Found 'DU'-anomaly for variable 'workType' (lines '747'-'763'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:747: Local variable 'workType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:752: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:755: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:755: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:760: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:768: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:777: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:777: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:777: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:786: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:786: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:795: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:795: Unnecessary final modifier in final class +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:806: Parameter 'unitLabel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:811: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:819: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:832: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:833: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:833: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:833: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:840: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:844: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:848: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:852: Found 'UR'-anomaly for variable 'goodsType' (lines '852'-'860'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:852: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:854: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:856: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:859: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:859: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:860: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:860: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:862: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:870: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:874: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:878: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:882: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:890: The method 'closeColonyPanel' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:890: The method closeColonyPanel() has an NPath complexity of 240 +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:892: Found 'DD'-anomaly for variable 'abandon' (lines '892'-'898'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:892: Found 'DU'-anomaly for variable 'abandon' (lines '892'-'930'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:893: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:893: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:894: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:894: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:897: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:901: Local variable 'buildable' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:901: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:903: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:903: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:906: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:907: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:907: The String literal "%number%" appears 5 times in this file; the first occurrence is on line 907 +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:916: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:920: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:920: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:921: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:922: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:923: Local variable 'activeUnit' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:923: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:924: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:925: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:925: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:925: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:925: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:925: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:926: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:927: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:943: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:943: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:953: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:953: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:953: The method 'actionPerformed' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:953: The method 'actionPerformed' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:953: The method 'actionPerformed' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:954: Found 'DU'-anomaly for variable 'colony' (lines '954'-'1,020'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:956: Found 'DU'-anomaly for variable 'unit' (lines '956'-'1,020'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:963: Found 'DU'-anomaly for variable 'cmd' (lines '963'-'1,020'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:965: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:970: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:970: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:971: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:971: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:971: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:972: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:974: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:974: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:975: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:983: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:988: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:992: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:992: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:993: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:993: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:995: Local variable 'space' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:995: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:996: Local variable 'count' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:996: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:998: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:998: Local variable 'n' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:999: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1029: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1029: The method 'propertyChange' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1029: The method 'propertyChange' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1029: The method 'propertyChange' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1031: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1032: Local variable 'property' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1033: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1033: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1039: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1042: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1042: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1045: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1045: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1046: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1047: Local variable 'msg' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1047: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1049: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1053: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1053: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1055: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1055: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1056: Local variable 'object' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1057: Local variable 'oldType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1058: Local variable 'newType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1061: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1065: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1070: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1075: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1081: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1094: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1096: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1101: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1102: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1103: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1104: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1105: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1106: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1107: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1108: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1109: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1110: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1111: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1112: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1113: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1114: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1115: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1116: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1117: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1118: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1119: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1120: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1122: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1145: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1168: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1168: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1169: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1169: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1170: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1170: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1171: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1171: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1172: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1172: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1173: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1173: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1174: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1174: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1175: Avoid excessively long variable names like royalistMemberLabel +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1175: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1175: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1209: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1213: Avoid variables with short names like uc +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1219: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1227: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1261: Local variable 'other' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1261: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1261: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1263: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1268: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1269: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1277: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1355: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1367: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1380: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1387: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1394: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1394: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1395: Found 'DU'-anomaly for variable 'oldParent' (lines '1,395'-'1,424'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1395: Local variable 'oldParent' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1398: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1399: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1402: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1407: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1410: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1413: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1415: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1417: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1418: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1421: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1429: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1478: Local variable 'selected' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1489: Local variable 'selected' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1491: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1502: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1522: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1527: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1555: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1555: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1572: Found 'UR'-anomaly for variable 'goodsType' (lines '1,572'-'1,584'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1574: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1577: Local variable 'options' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1578: Found 'DU'-anomaly for variable 'threshold' (lines '1,578'-'1,598'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1578: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1578: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1580: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1581: Found 'DU'-anomaly for variable 'game' (lines '1,581'-'1,598'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1581: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1582: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1583: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1583: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1584: Local variable 'count' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1584: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1586: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1586: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1587: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1587: Local variable 'goodsLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1588: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1588: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1595: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1595: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1606: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1613: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1620: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1620: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1623: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1624: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1626: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1627: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1636: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1637: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1648: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1651: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1651: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1689: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1694: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1702: Found 'UR'-anomaly for variable 'building' (lines '1,702'-'1,710'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1704: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1707: Local variable 'buildings' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1709: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1710: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1710: Local variable 'aSBP' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1721: Found 'UR'-anomaly for variable 'component' (lines '1,721'-'1,723'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1722: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1724: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1733: Found 'UR'-anomaly for variable 'component' (lines '1,733'-'1,735'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1734: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1736: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1776: Avoid excessively long variable names like buildQueueListener +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1776: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1776: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1778: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1778: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1778: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1779: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1790: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1802: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1802: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1828: Found 'UR'-anomaly for variable 'unitLabel' (lines '1,828'-'1,833'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1832: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1845: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1846: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1847: Local variable 'reason' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1847: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1849: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1849: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1850: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1853: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1853: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1862: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1869: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1876: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1876: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1879: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1879: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1879: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1879: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1881: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1883: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1893: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1902: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1905: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1905: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1915: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1918: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1924: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1936: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1939: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1939: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1940: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1941: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1942: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1943: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1945: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1946: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1947: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1948: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1950: Found 'DU'-anomaly for variable 'layer' (lines '1,950'-'1,963'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1953: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1954: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1954: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1954: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1954: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1955: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1955: Local variable 'aSTP' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1968: Found 'UR'-anomaly for variable 'component' (lines '1,968'-'1,970'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1969: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1971: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1980: Found 'UR'-anomaly for variable 'component' (lines '1,980'-'1,982'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1981: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1983: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1996: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:1996: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2000: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2002: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2010: The class 'ASingleTilePanel' has a Cyclomatic Complexity of 3 (Highest = 13). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2011: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2024: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2024: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2024: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2024: Parameter 'colonyTile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2024: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2024: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2030: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2033: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2033: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2042: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2042: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2063: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2069: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2078: Found 'UR'-anomaly for variable 'ag' (lines '2,078'-'2,097'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2078: Found 'UR'-anomaly for variable 'unit' (lines '2,078'-'2,083'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2081: Found 'DD'-anomaly for variable 'label' (lines '2,081'-'2,083'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2082: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2083: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2085: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2085: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2094: Local variable 'info' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2096: Local variable 'ag' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2096: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2097: Local variable 'productionLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2098: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2099: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2124: Parameter 'toAdd' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2124: Parameter 'unitLabel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2125: Found 'DU'-anomaly for variable 'tileMsg' (lines '2,125'-'2,134'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2125: Local variable 'tileMsg' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2129: Found 'DD'-anomaly for variable 'unitMsg' (lines '2,129'-'2,131'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2129: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2131: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2131: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2142: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2142: The method 'tryWork' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2142: The method tryWork() has an NPath complexity of 264 +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2144: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2145: Found 'DU'-anomaly for variable 'player' (lines '2,145'-'2,203'). +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2145: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2149: Local variable 'claim' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2155: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2155: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2159: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2162: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2166: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2167: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2176: Local variable 'reason' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2180: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2183: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2183: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2185: Local variable 'workType' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2188: Local variable 'best' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2190: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2191: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2191: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2193: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2193: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2193: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2193: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2211: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2218: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2225: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2225: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2228: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2229: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2229: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2232: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2234: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2245: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2254: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2255: Local variable 'property' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2256: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2273: Avoid variables with short names like px +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2273: Avoid variables with short names like py +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2273: Parameter 'px' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2273: Parameter 'py' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2274: Avoid variables with short names like w +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2274: Local variable 'w' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2275: Avoid variables with short names like h +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2275: Local variable 'h' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2276: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2276: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2277: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/panel/ColonyPanel.java:2277: Local variable 'dy' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColopediaDetailPanel.java:38: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/panel/ColopediaDetailPanel.java:46: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/panel/ColopediaDetailPanel.java:46: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:58: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:66: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:76: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:77: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:78: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:78: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:112: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:112: Parameter 'types' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:123: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:123: Found 'UR'-anomaly for variable 'type' (lines '123'-'131'). +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:123: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:123: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:124: Parameter 'types' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:125: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:126: Local variable 'cti' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:127: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:128: Found 'DU'-anomaly for variable 'width' (lines '128'-'154'). +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:128: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:129: Found 'DU'-anomaly for variable 'height' (lines '129'-'154'). +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:129: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:130: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:131: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:131: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:131: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:144: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:144: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:145: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:145: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:146: Local variable 'centeredImage' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:147: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:148: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:148: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:151: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:156: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:156: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:157: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:158: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:163: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:163: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:163: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:164: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:165: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:165: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:171: Parameter 'panelType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:171: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:171: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:172: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:173: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:179: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:179: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:183: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:188: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:192: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:192: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:196: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:200: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:200: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:201: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:207: Avoid variables with short names like au +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:207: Parameter 'au' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:207: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:211: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:211: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:212: Local variable 'unitIcon' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:214: Local variable 'unitButton' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:219: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:223: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:223: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:225: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:227: Local variable 'bonus' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:228: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:229: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:231: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:238: Parameter 'ability' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:238: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:240: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:242: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:248: Found 'UR'-anomaly for variable 'entry' (lines '248'-'253'). +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:248: Found 'UR'-anomaly for variable 'type' (lines '248'-'259'). +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:248: Parameter 'buildableType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:248: Parameter 'doc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:248: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:250: Found 'DU'-anomaly for variable 'requiredTypes' (lines '250'-'277'). +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:250: Local variable 'requiredTypes' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:251: Local variable 'entry' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:255: The String literal "regular" appears 5 times in this file; the first occurrence is on line 255 +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:257: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:259: Local variable 'typeButton' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:265: The String literal "button" appears 4 times in this file; the first occurrence is on line 265 +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:268: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaGameObjectTypePanel.java:289: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:53: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:61: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:70: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:70: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:70: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:79: Avoid variables with short names like sl +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:79: Local variable 'sl' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:88: Local variable 'detail' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:97: Local variable 'scale' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:112: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:123: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:124: Local variable 'root' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:127: Local variable 'fcc' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:138: Local variable 'treeModel' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:141: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:153: Local variable 'allNodes' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:155: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:156: Local variable 'item' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:170: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:171: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:178: Parameter 'nodeItem' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:187: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:187: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:188: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:190: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:192: Local variable 'oldPath' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:196: Local variable 'newPath' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:204: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:204: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:204: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:205: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:207: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:208: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:208: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:208: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:226: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:226: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:246: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:247: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:248: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColopediaPanel.java:249: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:42: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:51: Parameter 'tree' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:51: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:52: Parameter 'expanded' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:52: Parameter 'leaf' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:52: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:52: Parameter 'selected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:53: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:54: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:58: Local variable 'nodeItem' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:58: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:59: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:59: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:60: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:62: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:63: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColopediaTreeCellRenderer.java:63: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:31: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:32: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:32: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:37: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:46: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:46: Parameter 'detailPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:46: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:46: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:47: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:63: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColopediaTreeItem.java:67: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:50: Avoid using redundant field initializer for 'colorChooserPanel' +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:60: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:60: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:76: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:76: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:77: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:77: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:77: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:99: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:99: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:101: Found 'DU'-anomaly for variable 'gui' (lines '101'-'121'). +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:101: Local variable 'gui' could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:102: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColorCellEditor.java:118: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:44: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:44: Parameter 'useBorder' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:45: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:54: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:54: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:55: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:55: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:55: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:55: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:58: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:58: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:58: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:58: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:58: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:58: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:60: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:61: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColorCellRenderer.java:62: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:50: Avoid variables with short names like l +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:50: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:50: Parameter 'l' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:59: Local variable 'cancelButton' could be declared final +src/net/sf/freecol/client/gui/panel/ColorChooserPanel.java:70: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:20: Possible God class (WMC=98, ATFD=128, TCC=0.13725490196078433) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:54: The class 'CompactLabourReport' has a Cyclomatic Complexity of 5 (Highest = 29). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:54: The class 'CompactLabourReport' has a Modified Cyclomatic Complexity of 4 (Highest = 22). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:54: The class 'CompactLabourReport' has a Standard Cyclomatic Complexity of 4 (Highest = 22). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:54: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:54: Too many fields +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:56: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:57: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:58: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:59: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:60: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:60: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:61: Avoid excessively long variable names like COLONIST_SUMMARY_COLUMN +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:61: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:62: Avoid excessively long variable names like PRODUCTION_SYMBOL_COLUMN +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:62: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:62: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:63: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:63: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:64: Avoid excessively long variable names like PRODUCTION_SUMMARY_COLUMN +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:64: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:64: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:65: Avoid excessively long variable names like NETPRODUCTION_SUMMARY_COLUMN +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:65: This final field could be made static +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:67: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:69: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:71: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:73: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:74: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:75: Avoid excessively long variable names like showProductionSymbols +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:75: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:75: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:77: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:79: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:87: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:99: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:100: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:113: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:114: Found 'DD'-anomaly for variable 'text' (lines '114'-'127'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:116: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:126: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:127: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:131: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:138: The method initialize() has an NPath complexity of 12500 +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:138: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:149: Local variable 'expertProduction' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:150: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:150: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:154: Local variable 'layoutConstraints' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:155: Local variable 'widths' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:155: StringBuffer constructor is initialized with size 16, but has at least 42 characters appended. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:156: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:157: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:157: The String literal "[0!]" appears 4 times in this file; the first occurrence is on line 157 +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:158: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:159: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:160: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:161: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:162: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:164: Local variable 'columnConstraints' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:165: Local variable 'rowConstraints' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:179: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:186: The method 'addHeader' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:186: The method addHeader() has an NPath complexity of 204 +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:188: Local variable 'empty' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:190: The String literal "cell " appears 30 times in this file; the first occurrence is on line 190 +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:193: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:198: Local variable 'workingAs' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:203: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:208: Local variable 'colonists' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:213: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:215: The String literal " 1 " appears 18 times in this file; the first occurrence is on line 215 +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:217: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:218: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:220: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:221: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:227: Local variable 'netProduction' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:234: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:235: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Found 'UR'-anomaly for variable 'teacher' (lines '248'-'352'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: The method 'addLocationData' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: The method 'addLocationData' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: The method 'addLocationData' has a Standard Cyclomatic Complexity of 22. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:248: The method addLocationData() has an NPath complexity of 54432000 +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:249: Local variable 'allColonists' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:249: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:251: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:252: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:253: Local variable 'unitName' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:255: Found 'DD'-anomaly for variable 'workingAs' (lines '255'-'259'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:256: Found 'DD'-anomaly for variable 'productionWL' (lines '256'-'263'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:261: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:263: Found 'DU'-anomaly for variable 'productionWL' (lines '263'-'389'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:272: Local variable 'otherAmateurs' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:272: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:274: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:278: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:290: Avoid excessively long variable names like notProducingStartRow +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:290: Local variable 'notProducingStartRow' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:294: Local variable 'buildingLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:294: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:319: Local variable 'school' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:319: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:319: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:321: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:339: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:344: Local variable 'studentCount' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:349: Local variable 'resultOfTraining' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:351: Local variable 'teacher' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:352: Local variable 'student' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:359: Local variable 'student' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:362: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:364: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:365: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:374: Local variable 'buildingLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:375: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:382: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:391: Found 'UR'-anomaly for variable 'colony' (lines '391'-'403'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:392: Local variable 'unitTotal' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:395: Local variable 'summaryLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:402: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:402: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:403: Local variable 'colonyData' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:404: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:412: Local variable 'europe' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:413: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:414: Local variable 'nam' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:414: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:414: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:415: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:415: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:416: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:416: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:416: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:437: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:452: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:452: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:452: The method 'addLocationSummary' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:452: The method 'addLocationSummary' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:452: The method 'addLocationSummary' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:452: The method addLocationSummary() has an NPath complexity of 648 +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:453: Found 'DU'-anomaly for variable 'rows' (lines '453'-'506'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:453: Local variable 'rows' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:455: Local variable 'colonistsLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:456: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:461: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:461: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:461: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:461: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:463: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:468: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:474: Local variable 'productionLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:483: Local variable 'net' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:484: Avoid excessively long variable names like netProductionLabel +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:484: Local variable 'netProductionLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:486: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:486: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:487: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:488: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:492: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:498: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:500: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:500: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:502: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:508: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:508: Parameter 'messageKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:508: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:509: Local variable 'rows' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:511: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:512: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:513: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:515: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:520: Avoid reassigning parameters such as 'row' +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:520: Parameter 'activity' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:520: Parameter 'colonists' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:520: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:520: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:520: Parameter 'typeName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:528: Parameter 'activity' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:528: Parameter 'colonistLabel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:528: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:528: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:528: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:528: Parameter 'typeName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:530: Local variable 'typeLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:535: Local variable 'activityLabel' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:546: Found 'UR'-anomaly for variable 'unitType' (lines '546'-'555'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:549: Avoid excessively long variable names like allColonistsButton +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:549: Local variable 'allColonistsButton' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:550: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:550: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:554: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:555: Local variable 'unitData' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:557: Local variable 'unitButton' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:558: Local variable 'rows' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:558: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:562: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:566: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:569: Found 'DU'-anomaly for variable 'row' (lines '569'-'572'). +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:574: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:574: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:575: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:586: Local variable 'empty' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:591: Parameter 'otherAmateurs' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:592: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:598: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:598: Parameter 'toolTipKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:599: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:602: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:606: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:607: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:608: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:608: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:608: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:608: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:609: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:614: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:621: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:621: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:621: Useless parentheses. +src/net/sf/freecol/client/gui/panel/CompactLabourReport.java:622: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:63: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:63: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:68: Avoid using redundant field initializer for 'color' +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:68: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:71: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:71: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:71: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:75: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:79: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:79: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:98: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:98: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:101: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:101: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:101: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:110: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:110: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:110: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:118: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:118: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:129: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:129: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:137: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:137: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:145: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:145: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:154: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:154: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:163: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:163: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:170: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:170: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:177: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:177: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:186: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:186: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:186: Variables that are final and static should be all capitals, 'defaultFlags' is not all capitals. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:199: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:199: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:202: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:202: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:205: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:205: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:208: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:208: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:211: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:211: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:215: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:215: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:219: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:219: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:223: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:223: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:227: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:227: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:231: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:231: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:235: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:235: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:238: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:238: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:241: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:241: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:244: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:244: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:256: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:256: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:261: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:263: Local variable 'sure' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:267: Local variable 'country' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:272: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:281: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:283: The String literal "span" appears 6 times in this file; the first occurrence is on line 283 +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:326: Local variable 'flagColors' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:327: Local variable 'colors' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:330: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:331: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:345: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:347: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:348: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:348: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:357: Parameter 'box' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:357: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:358: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:358: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:366: Found 'UR'-anomaly for variable 'button' (lines '366'-'372'). +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:370: Found 'DU'-anomaly for variable 'colors' (lines '370'-'378'). +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:370: Local variable 'colors' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:371: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:372: Local variable 'color' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:380: Parameter 'count' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:381: Found 'DD'-anomaly for variable 'result' (lines '381'-'383'). +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:383: Found 'DD'-anomaly for variable 'result' (lines '383'-'383'). +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:395: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:395: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:396: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:397: Local variable 'color' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:411: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:411: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:412: Local variable 'newBackground' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:414: Local variable 'newDecoration' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:416: Local variable 'newPosition' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:418: Local variable 'newShape' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:436: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:437: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:438: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConfirmDeclarationDialog.java:442: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:73: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:82: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:83: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:83: Parameter 'openBuildQueue' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:96: Parameter 'newColony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:96: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:97: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:104: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:113: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:113: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:113: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:122: Found 'UR'-anomaly for variable 'listener' (lines '122'-'127'). +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:122: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:126: Local variable 'listener' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:131: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:132: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:135: Found 'UR'-anomaly for variable 'ag' (lines '135'-'174'). +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:135: Parameter 'buildable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:135: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:143: Local variable 'clickToBuild' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:144: Local variable 'breakingPoint' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:146: Local variable 'label0' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:150: Local variable 'label1' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:155: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:160: Local variable 'turns' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:161: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:164: Local variable 'label0' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:167: Local variable 'label1' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:173: Local variable 'ag' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:174: Local variable 'amountNeeded' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:175: Local variable 'amountAvailable' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:176: Local variable 'amountProduced' could be declared final +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:177: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:188: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:192: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ConstructionPanel.java:203: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:43: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:52: The class 'CornerMapControls' has a Cyclomatic Complexity of 4 (Highest = 10). +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:54: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:56: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:56: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:62: Parameter 'graphics' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:70: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:70: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:72: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:72: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:74: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:74: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:94: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:94: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:94: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:95: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:96: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:97: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:97: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:98: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:98: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:125: Local variable 'miniMapSkinKey' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:141: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:161: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:161: Parameter 'component' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:164: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:165: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:180: Found 'UR'-anomaly for variable 'button' (lines '180'-'224'). +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:180: Found 'UR'-anomaly for variable 'ub' (lines '180'-'204'). +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:180: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:180: The method 'addToComponent' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:186: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:192: Avoid variables with short names like cw +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:193: Avoid variables with short names like ch +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:201: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:202: Found 'DD'-anomaly for variable 'height' (lines '202'-'204'). +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:202: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:203: Local variable 'ub' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:207: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:207: Found 'DU'-anomaly for variable 'x' (lines '207'-'228'). +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:209: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:209: Found 'DU'-anomaly for variable 'y' (lines '209'-'228'). +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:209: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:210: Local variable 'ub' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:221: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:223: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:246: Found 'UR'-anomaly for variable 'button' (lines '246'-'252'). +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:246: Parameter 'canvas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:251: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/CornerMapControls.java:257: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:20: Possible God class (WMC=83, ATFD=97, TCC=0.011695906432748537) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:40: Avoid unused imports such as 'java.util.Arrays' +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:70: The class 'DefaultTransferHandler' has a Cyclomatic Complexity of 7 (Highest = 38). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:70: The class 'DefaultTransferHandler' has a Modified Cyclomatic Complexity of 6 (Highest = 34). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:70: The class 'DefaultTransferHandler' has a Standard Cyclomatic Complexity of 6 (Highest = 34). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:70: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:72: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:72: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:81: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:81: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:90: Parameter 'dge' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:91: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:91: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:92: Avoid variables with short names like th +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:92: Local variable 'th' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:94: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:94: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:102: Avoid variables with short names like tk +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:102: Local variable 'tk' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:103: Local variable 'imageIcon' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:104: Local variable 'bestSize' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:109: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:121: Local variable 'scaled' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:125: Local variable 'point' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:129: Found 'DD'-anomaly for variable 'cursor' (lines '129'-'132'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:131: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:132: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:141: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:155: Document empty method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:155: Parameter 'dsde' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:161: Document empty method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:161: Parameter 'dsde' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:167: Document empty method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:167: Parameter 'dsde' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:173: Parameter 'dsde' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:174: Local variable 'dsc' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:175: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:175: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:188: Parameter 'dsde' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:188: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:189: Local variable 'dsc' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:190: Local variable 'comp' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:194: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:194: Parameter 'partial' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:196: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:201: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:203: Parameter 'dgl' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:207: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:207: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:207: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:207: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:207: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:207: Parameter 'srcActions' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:207: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:220: Document empty method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:229: Document empty method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:233: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:233: Variables that are final and static should be all capitals, 'flavor' is not all capitals. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:233: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:236: Avoid using redundant field initializer for 'recognizer' +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:236: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:236: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:238: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:238: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:238: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:240: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:240: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:240: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:242: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:242: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:242: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:251: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:251: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:252: Parameter 'parentPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:267: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:281: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:281: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:281: Parameter 'flavor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:283: Avoid variables with short names like f +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:295: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:297: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: Avoid reassigning parameters such as 'comp' +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: Avoid reassigning parameters such as 'comp' +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: Avoid reassigning parameters such as 'comp' +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: Avoid reassigning parameters such as 'comp' +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: The method 'importData' has a Cyclomatic Complexity of 38. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: The method 'importData' has a Modified Cyclomatic Complexity of 34. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: The method 'importData' has a Standard Cyclomatic Complexity of 34. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: The method importData() has an NCSS line count of 105 +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:312: The method importData() has an NPath complexity of 13321 +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:318: Found 'DD'-anomaly for variable 'oldSelectedUnit' (lines '318'-'350'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:318: Found 'DU'-anomaly for variable 'oldSelectedUnit' (lines '318'-'465'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:324: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:325: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:329: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:329: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:329: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:333: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:334: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:344: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:347: Local variable 'portPanel' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:349: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:350: Found 'DU'-anomaly for variable 'oldSelectedUnit' (lines '350'-'465'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:350: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:352: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:354: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:354: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:363: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:363: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:363: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:367: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:368: Found 'DU'-anomaly for variable 'goods' (lines '368'-'465'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:368: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:368: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:371: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:372: Found 'DD'-anomaly for variable 'defaultAmount' (lines '372'-'378'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:373: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:374: Local variable 'loc' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:375: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:375: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:383: Local variable 'alt' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:383: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:388: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:390: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:390: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:392: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:392: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:398: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:401: Local variable 'target' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:402: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:402: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:406: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:409: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:413: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:415: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:415: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:415: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:417: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:417: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:421: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:422: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:427: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:431: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:433: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:435: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:436: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:438: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:444: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:444: Found 'DU'-anomaly for variable 'unit' (lines '444'-'465'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:444: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:444: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:445: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:445: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:447: Local variable 'target' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:448: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:448: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:449: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:456: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:459: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:461: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:467: Parameter 'component' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:467: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:468: Useless parentheses. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:468: Useless parentheses. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:472: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:475: Parameter 'oldSelectedUnit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:482: Found 'UR'-anomaly for variable 'role' (lines '482'-'494'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:482: Parameter 'unitLabel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:482: The method 'equipUnitIfPossible' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:483: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:485: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:486: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:490: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:493: Local variable 'role' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:493: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:494: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:494: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:495: Local variable 'required' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:497: Avoid assignments in operands +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:497: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:498: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:499: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:499: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:500: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:500: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:501: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:501: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:502: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:505: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:515: Parameter 'available' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:515: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:516: Parameter 'defaultAmount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:516: Parameter 'needToPay' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:522: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:522: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:522: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:522: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:522: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:523: Local variable 'srcActions' could be declared final +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:524: Found 'DD'-anomaly for variable 'dragAction' (lines '524'-'526'). +src/net/sf/freecol/client/gui/panel/DefaultTransferHandler.java:529: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:51: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:51: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:54: Variables that are final and static should be all capitals, 'filters' is not all capitals. +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:57: Avoid unused private fields such as 'selected'. +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:66: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:78: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:78: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:79: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:79: Parameter 'level' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:79: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:92: Local variable 'resetButton' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:95: Local variable 'loadButton' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:98: Local variable 'saveButton' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:127: Parameter 'button' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:128: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:129: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:138: Parameter 'button' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:140: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:141: Local variable 'dir' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:142: Local variable 'file' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:156: Parameter 'button' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:158: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:159: Local variable 'dir' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:160: Local variable 'file' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:175: Local variable 'desc' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:185: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:185: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:186: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:187: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:188: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DifficultyDialog.java:202: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DragListener.java:42: The class 'DragListener' has a Cyclomatic Complexity of 10 (Highest = 19). +src/net/sf/freecol/client/gui/panel/DragListener.java:42: The class 'DragListener' has a Modified Cyclomatic Complexity of 8 (Highest = 13). +src/net/sf/freecol/client/gui/panel/DragListener.java:42: The class 'DragListener' has a Standard Cyclomatic Complexity of 8 (Highest = 13). +src/net/sf/freecol/client/gui/panel/DragListener.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/DragListener.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DragListener.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DragListener.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DragListener.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DragListener.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DragListener.java:58: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/DragListener.java:58: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:59: Parameter 'parentPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:72: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/DragListener.java:72: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:72: The method 'mousePressed' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/panel/DragListener.java:72: The method 'mousePressed' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/DragListener.java:72: The method 'mousePressed' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/DragListener.java:73: Found 'DU'-anomaly for variable 'comp' (lines '73'-'136'). +src/net/sf/freecol/client/gui/panel/DragListener.java:73: Local variable 'comp' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:79: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/DragListener.java:81: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/DragListener.java:83: Local variable 'menu' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:86: Local variable 'lastIdx' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:87: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DragListener.java:90: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DragListener.java:93: Local variable 'windows' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:94: Found 'DU'-anomaly for variable 'small' (lines '94'-'136'). +src/net/sf/freecol/client/gui/panel/DragListener.java:94: Local variable 'small' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:112: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:122: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:123: Avoid variables with short names like u +src/net/sf/freecol/client/gui/panel/DragListener.java:123: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DragListener.java:131: Local variable 'handler' could be declared final +src/net/sf/freecol/client/gui/panel/DragListener.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DragListener.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Draggable.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Draggable.java:30: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/panel/DropListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DropListener.java:38: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/DropListener.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/DropListener.java:41: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DropListener.java:50: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/DropListener.java:50: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DropListener.java:51: Local variable 'clipboard' could be declared final +src/net/sf/freecol/client/gui/panel/DropListener.java:51: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DropListener.java:52: Local variable 'clipData' could be declared final +src/net/sf/freecol/client/gui/panel/DropListener.java:52: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DropListener.java:54: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DropListener.java:54: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/DropListener.java:55: Local variable 'comp' could be declared final +src/net/sf/freecol/client/gui/panel/DropListener.java:56: Local variable 'handler' could be declared final +src/net/sf/freecol/client/gui/panel/DropListener.java:56: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DropListener.java:57: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/DropTarget.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DropTarget.java:38: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/panel/DropTarget.java:47: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/panel/DropTarget.java:49: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DropTarget.java:62: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/panel/DropTarget.java:71: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:45: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:61: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:61: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:61: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:67: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:70: Local variable 'checkBox' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:71: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:77: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:79: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:79: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:82: Local variable 'fake' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:83: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:83: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:98: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:99: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:99: Local variable 'gl' could be declared final +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:102: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/DumpCargoDialog.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:36: Avoid variables with short names like ui +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:46: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:46: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:46: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:51: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:52: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EditOptionDialog.java:64: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:61: The class 'EditSettlementDialog' has a Cyclomatic Complexity of 4 (Highest = 18). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:61: The class 'EditSettlementDialog' has a Modified Cyclomatic Complexity of 3 (Highest = 16). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:61: The class 'EditSettlementDialog' has a Standard Cyclomatic Complexity of 3 (Highest = 16). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:65: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:83: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:93: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:93: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:101: Local variable 'nationModel' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:103: Local variable 'n' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:118: Local variable 'unitCount' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:119: Local variable 'spinnerModel' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:124: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:136: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:137: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:137: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:151: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:151: Local variable 'n' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:152: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:156: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:158: Avoid variables with short names like p +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:165: Avoid unused private methods such as 'getAverageSize()'. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:166: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:166: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:170: Found 'UR'-anomaly for variable 'skill' (lines '170'-'175'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:171: Local variable 'ownerType' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:172: Local variable 'skillModel' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:174: Local variable 'skill' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:187: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:187: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:188: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:190: Useless parentheses. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:190: Useless parentheses. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:191: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:196: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: Found 'UR'-anomaly for variable 'indianSettlement' (lines '206'-'236'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: Found 'UR'-anomaly for variable 't' (lines '206'-'228'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: Found 'UR'-anomaly for variable 'u' (lines '206'-'223'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: Found 'UR'-anomaly for variable 'unit' (lines '206'-'256'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: The method 'getResponse' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: The method 'getResponse' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: The method 'getResponse' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:206: The method getResponse() has an NPath complexity of 310 +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:207: Found 'DU'-anomaly for variable 'spec' (lines '207'-'277'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:208: Found 'DU'-anomaly for variable 'gui' (lines '208'-'277'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:209: Found 'DD'-anomaly for variable 'ret' (lines '209'-'263'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:209: Found 'DU'-anomaly for variable 'ret' (lines '209'-'277'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:210: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:210: Found 'DU'-anomaly for variable 'tiles' (lines '210'-'277'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:210: Local variable 'tiles' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:211: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:214: Local variable 'newNation' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:216: Local variable 'newPlayer' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:220: Avoid variables with short names like ul +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:220: Local variable 'ul' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:222: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:227: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:234: Local variable 'indianSettlement' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:235: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:243: Local variable 'numberOfUnits' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:246: Local variable 'owner' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:247: Found 'DU'-anomaly for variable 'brave' (lines '247'-'277'). +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:247: Local variable 'brave' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:249: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:253: Local variable 'unitList' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:255: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:259: Local variable 'oldType' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:260: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:262: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:268: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:271: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:272: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:272: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:275: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:275: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/EditSettlementDialog.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:45: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:54: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:54: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:55: Parameter 'europe' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:55: Parameter 'foy' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:62: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:69: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:73: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:73: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:74: Avoid variables with short names like i +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:75: Avoid variables with short names like u0 +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:75: Local variable 'u0' could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:78: Local variable 'ut' could be declared final +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:79: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/EmigrationDialog.java:80: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:60: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:60: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:70: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:71: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:72: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:75: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:75: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:91: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:93: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:93: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:94: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:94: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:95: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:95: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:96: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:96: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:97: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:97: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:115: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:116: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:117: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:118: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:119: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:125: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:125: Useless parentheses. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:125: Useless parentheses. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:136: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:136: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:146: Found 'UR'-anomaly for variable 'unit' (lines '146'-'158'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:146: Found 'UR'-anomaly for variable 'unit' (lines '146'-'158'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:146: Found 'UR'-anomaly for variable 'unit' (lines '146'-'158'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:146: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:146: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:146: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:149: Found 'DU'-anomaly for variable 'player' (lines '149'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:149: Found 'DU'-anomaly for variable 'player' (lines '149'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:149: Found 'DU'-anomaly for variable 'player' (lines '149'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:151: Found 'DU'-anomaly for variable 'header' (lines '151'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:151: Found 'DU'-anomaly for variable 'header' (lines '151'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:151: Found 'DU'-anomaly for variable 'header' (lines '151'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:151: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:152: Found 'DU'-anomaly for variable 'text' (lines '152'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:152: Found 'DU'-anomaly for variable 'text' (lines '152'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:152: Found 'DU'-anomaly for variable 'text' (lines '152'-'199'). +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:152: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:156: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:157: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:158: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:168: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:168: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:168: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:176: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:176: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:176: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:182: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:182: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:182: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:183: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:187: Local variable 'listScroller' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:189: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:196: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:205: Local variable 'wrapper' could be declared final +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:207: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:208: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:211: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:211: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:212: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:214: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EndTurnDialog.java:215: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:55: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:55: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:58: Local variable 'showButton' could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:72: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:75: Local variable 'logFile' could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:76: Local variable 'buffer' could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:84: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:85: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:85: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:88: Local variable 'textArea' could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:92: Local variable 'scrollPane' could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:108: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:108: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ErrorPanel.java:111: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/EuropePanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:20: Possible God class (WMC=94, ATFD=84, TCC=0.0) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:71: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:73: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:73: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:79: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/EuropePanel.java:79: The class 'DestinationPanel' has a Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:79: The class 'DestinationPanel' has a Modified Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:79: The class 'DestinationPanel' has a Standard Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:81: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:81: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:87: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:95: Document empty method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:100: Found 'UR'-anomaly for variable 'unit' (lines '100'-'108'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:100: Found 'UR'-anomaly for variable 'unit' (lines '100'-'110'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:100: Found 'UR'-anomaly for variable 'unit' (lines '100'-'116'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:103: Local variable 'highSeas' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:105: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:111: Useless parentheses. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:111: Useless parentheses. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:112: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:113: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:113: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:116: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/EuropePanel.java:122: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:123: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/EuropePanel.java:143: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:150: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:157: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:157: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:157: The method 'add' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:157: The method 'add' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:157: The method 'add' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:157: The method add() has an NPath complexity of 337 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:160: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/EuropePanel.java:161: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:166: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EuropePanel.java:166: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:166: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/EuropePanel.java:167: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:170: Found 'DD'-anomaly for variable 'dest' (lines '170'-'172'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:170: Found 'DU'-anomaly for variable 'dest' (lines '170'-'204'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:173: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:173: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EuropePanel.java:176: Avoid variables with short names like co +src/net/sf/freecol/client/gui/panel/EuropePanel.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:182: Local variable 'locName' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:184: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EuropePanel.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:187: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:200: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/EuropePanel.java:200: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:209: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:218: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:226: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:231: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:241: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:248: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:255: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:255: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:256: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/EuropePanel.java:256: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:264: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:273: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:278: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:280: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/EuropePanel.java:280: Parameter 'command' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:280: Parameter 'keyEvent' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:280: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:280: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:281: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:286: Local variable 'closeInputMap' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:303: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:328: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:329: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:329: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EuropePanel.java:330: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/EuropePanel.java:333: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:349: Avoid unused constructor parameters such as 'europePanel'. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:349: Parameter 'europePanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:357: Found 'UR'-anomaly for variable 'goodsType' (lines '357'-'363'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:360: Found 'DU'-anomaly for variable 'market' (lines '360'-'370'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:361: Found 'DU'-anomaly for variable 'lib' (lines '361'-'370'). +src/net/sf/freecol/client/gui/panel/EuropePanel.java:361: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:362: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:362: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:363: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/EuropePanel.java:363: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:366: Avoid variables with short names like md +src/net/sf/freecol/client/gui/panel/EuropePanel.java:366: Local variable 'md' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:366: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:367: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EuropePanel.java:367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:375: Document empty method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:383: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:390: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:397: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:397: Parameter 'editState' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:400: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/EuropePanel.java:401: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/EuropePanel.java:404: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:404: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:405: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:406: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:408: Local variable 'act' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:408: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:413: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:413: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:416: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:419: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/EuropePanel.java:427: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:429: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:429: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:436: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:447: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:461: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/EuropePanel.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:486: Avoid reassigning parameters such as 'text' +src/net/sf/freecol/client/gui/panel/EuropePanel.java:487: Local variable 'doc' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:489: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/EuropePanel.java:489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:491: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/EuropePanel.java:502: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:502: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:502: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:503: Local variable 'total' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:504: Avoid variables with short names like t1 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:504: Local variable 't1' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:504: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:504: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:504: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:507: The String literal "%gold%" appears 6 times in this file; the first occurrence is on line 507 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:508: Avoid variables with short names like t2 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:508: Local variable 't2' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:508: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:517: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:517: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:518: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:518: Parameter 'tax' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:519: Local variable 'totalBeforeTax' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:520: Local variable 'totalTax' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:521: Local variable 'totalAfterTax' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:523: Avoid variables with short names like t1 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:523: Local variable 't1' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:523: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:523: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:523: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:527: Avoid variables with short names like t2 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:527: Local variable 't2' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:527: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:529: Avoid variables with short names like t3 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:529: Local variable 't3' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:532: Avoid variables with short names like t4 +src/net/sf/freecol/client/gui/panel/EuropePanel.java:532: Local variable 't4' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:540: enumCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:549: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:549: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:549: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:551: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:551: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:551: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:553: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:553: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:553: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:555: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:555: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:555: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:557: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:557: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:557: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:559: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:559: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:559: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:559: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:559: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:560: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:560: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:560: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:562: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:562: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:562: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EuropePanel.java:571: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:571: Parameter 'header' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:597: Local variable 'attributes' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:613: Local variable 'releaseListener' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:627: Local variable 'toAmericaScroll' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:631: Local variable 'toEuropeScroll' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:635: Local variable 'inPortScroll' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:639: Local variable 'cargoScroll' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:643: Local variable 'docksScroll' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:647: Local variable 'marketScroll' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:650: Local variable 'logScroll' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:700: Local variable 'scale' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:709: Parameter 'europe' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:711: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:711: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:756: Parameter 'unitLabel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:778: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:779: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:786: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:787: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:788: Local variable 'goodsIterator' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:788: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:790: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:791: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:791: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:792: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:797: Local variable 'unitIterator' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:797: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:799: Local variable 'newUnit' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:800: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:812: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:814: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:840: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/EuropePanel.java:840: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:842: Local variable 'act' could be declared final +src/net/sf/freecol/client/gui/panel/EuropePanel.java:848: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:851: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:857: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/EuropePanel.java:879: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:880: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:881: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:882: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/EuropePanel.java:883: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/EventPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/EventPanel.java:39: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/EventPanel.java:39: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/EventPanel.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/EventPanel.java:50: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EventPanel.java:50: Parameter 'header' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EventPanel.java:50: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EventPanel.java:51: Parameter 'footer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/EventPanel.java:54: Local variable 'headerLabel' could be declared final +src/net/sf/freecol/client/gui/panel/EventPanel.java:58: Local variable 'imageLabel' could be declared final +src/net/sf/freecol/client/gui/panel/EventPanel.java:61: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/EventPanel.java:61: Local variable 'footerLabel' could be declared final +src/net/sf/freecol/client/gui/panel/EventPanel.java:65: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:63: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:64: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:75: Found 'UR'-anomaly for variable 'father' (lines '75'-'98'). +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:75: Found 'UR'-anomaly for variable 'fatherType' (lines '75'-'84'). +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:75: Found 'UR'-anomaly for variable 'fatherType' (lines '75'-'91'). +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:75: Found 'UR'-anomaly for variable 'foundingFather' (lines '75'-'87'). +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:75: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:77: Local variable 'parent' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:81: Found 'DU'-anomaly for variable 'fathersByType' (lines '81'-'102'). +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:81: Local variable 'fathersByType' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:83: Local variable 'fatherType' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:84: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:86: Local variable 'foundingFather' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:89: Found 'DU'-anomaly for variable 'icon' (lines '89'-'102'). +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:89: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:90: Local variable 'fatherType' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:91: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:91: Local variable 'id' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:92: Local variable 'typeName' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:93: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:94: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:97: Local variable 'father' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:108: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:108: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:108: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:110: Local variable 'father' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:116: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:121: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:124: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:136: Parameter 'father' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:136: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:139: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:140: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:141: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:142: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:146: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:147: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:149: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:166: Local variable 'description' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:169: Local variable 'dSize' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:169: Local variable 'hSize' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:169: Local variable 'lSize' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:169: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:169: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FatherDetailPanel.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:64: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:64: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:66: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:66: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:73: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:73: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:74: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:77: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:77: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:86: enumCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:93: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:93: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:96: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:96: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:104: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:112: Local variable 'selectAction' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:114: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:114: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:114: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:121: Local variable 'quitAction' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:123: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:123: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:123: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:132: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:132: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:132: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:133: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:138: Local variable 'listScroller' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:158: Found 'UR'-anomaly for variable 'player' (lines '158'-'167'). +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:158: Found 'UR'-anomaly for variable 'player' (lines '158'-'170'). +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:158: Found 'UR'-anomaly for variable 'player' (lines '158'-'180'). +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:158: Found 'UR'-anomaly for variable 's' (lines '158'-'181'). +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:158: Parameter 'displayListOption' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:159: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:161: Local variable 'selected' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:163: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:164: Avoid variables with short names like ok +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:180: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:194: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:198: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:209: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:209: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:210: A switch statement does not contain a break +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:210: The default label should be the last label in a switch statement +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:230: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:230: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:231: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FindSettlementPanel.java:256: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:51: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:62: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:62: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:63: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:63: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:63: Parameter 'settlementCount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:63: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:66: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:76: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:78: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:87: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:87: Local variable 'messageId' could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:90: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:92: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:99: Local variable 'columns' could be declared final +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:111: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FirstContactDialog.java:115: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Flag.java:20: Possible God class (WMC=176, ATFD=160, TCC=0.2292358803986711) +src/net/sf/freecol/client/gui/panel/Flag.java:34: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Flag.java:45: Avoid really long classes. +src/net/sf/freecol/client/gui/panel/Flag.java:45: Avoid short class names like Flag +src/net/sf/freecol/client/gui/panel/Flag.java:45: The class 'Flag' has a Cyclomatic Complexity of 3 (Highest = 29). +src/net/sf/freecol/client/gui/panel/Flag.java:45: The class 'Flag' has a Modified Cyclomatic Complexity of 3 (Highest = 16). +src/net/sf/freecol/client/gui/panel/Flag.java:45: The class 'Flag' has a Standard Cyclomatic Complexity of 3 (Highest = 26). +src/net/sf/freecol/client/gui/panel/Flag.java:81: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:104: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:105: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:107: Parameter 'positions' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:109: Local variable 'position' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:114: Parameter 'positions' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:114: Parameter 'shape' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:148: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:149: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:151: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:151: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:163: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:164: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:169: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:179: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:180: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:182: Variables that are final and static should be all capitals, 'star' is not all capitals. +src/net/sf/freecol/client/gui/panel/Flag.java:182: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:189: Variables that are final and static should be all capitals, 'layout' is not all capitals. +src/net/sf/freecol/client/gui/panel/Flag.java:192: Local variable 'bars' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:218: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:220: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:220: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:221: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:221: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:222: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:222: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:224: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:224: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:225: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:225: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:226: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:226: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:227: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:227: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:233: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:240: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/Flag.java:243: Parameter 'background' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:243: Parameter 'decoration' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:243: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:244: Parameter 'unionPosition' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:248: Parameter 'background' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:248: Parameter 'decoration' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:248: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:249: Parameter 'unionPosition' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:249: Parameter 'unionShape' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:271: Parameter 'background' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:291: Parameter 'decoration' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:312: Parameter 'position' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:332: Parameter 'shape' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:353: Parameter 'backgroundColors' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:365: Found 'UR'-anomaly for variable 'color' (lines '365'-'368'). +src/net/sf/freecol/client/gui/panel/Flag.java:365: Parameter 'colors' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:367: Local variable 'color' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:390: Parameter 'unionColor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:411: Parameter 'decorationColor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:431: Parameter 'starColor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:452: Parameter 'stars' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:473: Parameter 'stripes' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:483: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/Flag.java:483: The method 'getImage' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/client/gui/panel/Flag.java:483: The method 'getImage' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/Flag.java:483: The method 'getImage' has a Standard Cyclomatic Complexity of 26. +src/net/sf/freecol/client/gui/panel/Flag.java:483: The method getImage() has an NCSS line count of 106 +src/net/sf/freecol/client/gui/panel/Flag.java:483: The method getImage() has an NPath complexity of 116640 +src/net/sf/freecol/client/gui/panel/Flag.java:484: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:486: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/Flag.java:486: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:486: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:487: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:497: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Flag.java:523: Found 'DD'-anomaly for variable 'decorationShape' (lines '523'-'528'). +src/net/sf/freecol/client/gui/panel/Flag.java:523: Found 'DD'-anomaly for variable 'decorationShape' (lines '523'-'531'). +src/net/sf/freecol/client/gui/panel/Flag.java:523: Found 'DD'-anomaly for variable 'decorationShape' (lines '523'-'534'). +src/net/sf/freecol/client/gui/panel/Flag.java:523: Found 'DD'-anomaly for variable 'decorationShape' (lines '523'-'537'). +src/net/sf/freecol/client/gui/panel/Flag.java:523: Found 'DD'-anomaly for variable 'decorationShape' (lines '523'-'540'). +src/net/sf/freecol/client/gui/panel/Flag.java:523: Found 'DD'-anomaly for variable 'decorationShape' (lines '523'-'543'). +src/net/sf/freecol/client/gui/panel/Flag.java:523: Found 'DD'-anomaly for variable 'decorationShape' (lines '523'-'547'). +src/net/sf/freecol/client/gui/panel/Flag.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:548: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:549: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:555: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:556: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:561: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/Flag.java:564: Found 'DD'-anomaly for variable 'union' (lines '564'-'573'). +src/net/sf/freecol/client/gui/panel/Flag.java:564: Found 'DD'-anomaly for variable 'union' (lines '564'-'577'). +src/net/sf/freecol/client/gui/panel/Flag.java:564: Found 'DD'-anomaly for variable 'union' (lines '564'-'581'). +src/net/sf/freecol/client/gui/panel/Flag.java:564: Found 'DD'-anomaly for variable 'union' (lines '564'-'588'). +src/net/sf/freecol/client/gui/panel/Flag.java:564: Found 'DD'-anomaly for variable 'union' (lines '564'-'592'). +src/net/sf/freecol/client/gui/panel/Flag.java:565: Found 'DD'-anomaly for variable 'starShape' (lines '565'-'574'). +src/net/sf/freecol/client/gui/panel/Flag.java:565: Found 'DD'-anomaly for variable 'starShape' (lines '565'-'578'). +src/net/sf/freecol/client/gui/panel/Flag.java:565: Found 'DD'-anomaly for variable 'starShape' (lines '565'-'583'). +src/net/sf/freecol/client/gui/panel/Flag.java:565: Found 'DD'-anomaly for variable 'starShape' (lines '565'-'589'). +src/net/sf/freecol/client/gui/panel/Flag.java:565: Found 'DD'-anomaly for variable 'starShape' (lines '565'-'593'). +src/net/sf/freecol/client/gui/panel/Flag.java:572: Local variable 'rectangle' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:581: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:581: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:582: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:582: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:601: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:605: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:606: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:608: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:620: Parameter 'union' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:622: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/Flag.java:622: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/Flag.java:625: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Flag.java:626: Local variable 'radius' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:631: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:631: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:632: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:632: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:637: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/Flag.java:637: Parameter 'isosceles' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:637: The method 'getUnionTriangle' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/client/gui/panel/Flag.java:637: The method 'getUnionTriangle' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/Flag.java:637: The method 'getUnionTriangle' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/Flag.java:638: Local variable 'small' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:638: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:638: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:642: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:642: Found 'DD'-anomaly for variable 'x' (lines '642'-'646'). +src/net/sf/freecol/client/gui/panel/Flag.java:642: Found 'DD'-anomaly for variable 'x' (lines '642'-'656'). +src/net/sf/freecol/client/gui/panel/Flag.java:642: Found 'DD'-anomaly for variable 'x' (lines '642'-'664'). +src/net/sf/freecol/client/gui/panel/Flag.java:642: Found 'DD'-anomaly for variable 'x' (lines '642'-'676'). +src/net/sf/freecol/client/gui/panel/Flag.java:643: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:643: Found 'DD'-anomaly for variable 'y' (lines '643'-'647'). +src/net/sf/freecol/client/gui/panel/Flag.java:643: Found 'DD'-anomaly for variable 'y' (lines '643'-'657'). +src/net/sf/freecol/client/gui/panel/Flag.java:643: Found 'DD'-anomaly for variable 'y' (lines '643'-'665'). +src/net/sf/freecol/client/gui/panel/Flag.java:643: Found 'DD'-anomaly for variable 'y' (lines '643'-'677'). +src/net/sf/freecol/client/gui/panel/Flag.java:644: Avoid variables with short names like r +src/net/sf/freecol/client/gui/panel/Flag.java:644: Found 'DD'-anomaly for variable 'r' (lines '644'-'652'). +src/net/sf/freecol/client/gui/panel/Flag.java:644: Found 'DD'-anomaly for variable 'r' (lines '644'-'662'). +src/net/sf/freecol/client/gui/panel/Flag.java:644: Found 'DD'-anomaly for variable 'r' (lines '644'-'672'). +src/net/sf/freecol/client/gui/panel/Flag.java:644: Found 'DD'-anomaly for variable 'r' (lines '644'-'684'). +src/net/sf/freecol/client/gui/panel/Flag.java:646: Found 'DU'-anomaly for variable 'x' (lines '646'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:656: Found 'DU'-anomaly for variable 'x' (lines '656'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:670: Avoid variables with short names like h +src/net/sf/freecol/client/gui/panel/Flag.java:670: Local variable 'h' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:671: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/Flag.java:671: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:682: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/Flag.java:682: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:683: Avoid variables with short names like A +src/net/sf/freecol/client/gui/panel/Flag.java:683: Local variable 'A' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:683: Variables should start with a lowercase character, 'A' starts with uppercase character. +src/net/sf/freecol/client/gui/panel/Flag.java:687: Found 'DU'-anomaly for variable 'radius' (lines '687'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:687: Local variable 'radius' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:689: Found 'DD'-anomaly for variable 'unionPath' (lines '689'-'691'). +src/net/sf/freecol/client/gui/panel/Flag.java:690: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Flag.java:710: Found 'DU'-anomaly for variable 'missing' (lines '710'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:711: Local variable 'slope' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:712: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/panel/Flag.java:712: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:713: Avoid variables with short names like xx +src/net/sf/freecol/client/gui/panel/Flag.java:715: Found 'DD'-anomaly for variable 'offset' (lines '715'-'722'). +src/net/sf/freecol/client/gui/panel/Flag.java:715: Found 'DU'-anomaly for variable 'offset' (lines '715'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:717: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/panel/Flag.java:717: Found 'DD'-anomaly for variable 'dy' (lines '717'-'721'). +src/net/sf/freecol/client/gui/panel/Flag.java:717: Found 'DU'-anomaly for variable 'dy' (lines '717'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:722: Found 'DD'-anomaly for variable 'offset' (lines '722'-'722'). +src/net/sf/freecol/client/gui/panel/Flag.java:722: Found 'DU'-anomaly for variable 'offset' (lines '722'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:724: Avoid variables with short names like yy +src/net/sf/freecol/client/gui/panel/Flag.java:724: Found 'DD'-anomaly for variable 'yy' (lines '724'-'724'). +src/net/sf/freecol/client/gui/panel/Flag.java:724: Found 'DU'-anomaly for variable 'yy' (lines '724'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:725: Found 'DD'-anomaly for variable 'count' (lines '725'-'727'). +src/net/sf/freecol/client/gui/panel/Flag.java:729: Found 'DU'-anomaly for variable 'missing' (lines '729'-'739'). +src/net/sf/freecol/client/gui/panel/Flag.java:732: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:748: Parameter 'triangle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:753: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/Flag.java:753: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/Flag.java:774: Parameter 'triangle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:795: Found 'DD'-anomaly for variable 'unionPath' (lines '795'-'813'). +src/net/sf/freecol/client/gui/panel/Flag.java:797: Found 'DD'-anomaly for variable 'count' (lines '797'-'800'). +src/net/sf/freecol/client/gui/panel/Flag.java:804: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/Flag.java:804: Found 'DU'-anomaly for variable 'rows' (lines '804'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:805: Found 'DD'-anomaly for variable 'starCount' (lines '805'-'825'). +src/net/sf/freecol/client/gui/panel/Flag.java:805: Found 'DU'-anomaly for variable 'starCount' (lines '805'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:806: Avoid variables with short names like a +src/net/sf/freecol/client/gui/panel/Flag.java:806: Local variable 'a' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:807: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/Flag.java:807: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:809: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Flag.java:810: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/Flag.java:810: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:811: Avoid variables with short names like r +src/net/sf/freecol/client/gui/panel/Flag.java:811: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:812: Local variable 'radius' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:816: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/panel/Flag.java:816: Found 'DU'-anomaly for variable 'dx' (lines '816'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:816: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:817: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/panel/Flag.java:817: Found 'DU'-anomaly for variable 'dy' (lines '817'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:817: Local variable 'dy' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:818: Found 'DU'-anomaly for variable 'dx1' (lines '818'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:818: Local variable 'dx1' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:819: Found 'DU'-anomaly for variable 'dy1' (lines '819'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:819: Local variable 'dy1' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:821: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:821: Found 'DD'-anomaly for variable 'x' (lines '821'-'821'). +src/net/sf/freecol/client/gui/panel/Flag.java:821: Found 'DU'-anomaly for variable 'x' (lines '821'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:822: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:822: Found 'DD'-anomaly for variable 'y' (lines '822'-'822'). +src/net/sf/freecol/client/gui/panel/Flag.java:822: Found 'DU'-anomaly for variable 'y' (lines '822'-'837'). +src/net/sf/freecol/client/gui/panel/Flag.java:824: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:847: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:859: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:864: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/Flag.java:864: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:869: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/Flag.java:869: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:869: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:869: Parameter 'stripes' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:870: Found 'DU'-anomaly for variable 'colors' (lines '870'-'883'). +src/net/sf/freecol/client/gui/panel/Flag.java:870: Local variable 'colors' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:871: Local variable 'stripeWidth' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:872: Local variable 'stripeHeight' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:873: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:873: Found 'DU'-anomaly for variable 'x' (lines '873'-'883'). +src/net/sf/freecol/client/gui/panel/Flag.java:873: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:875: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:875: Found 'DU'-anomaly for variable 'y' (lines '875'-'883'). +src/net/sf/freecol/client/gui/panel/Flag.java:875: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:877: Found 'DU'-anomaly for variable 'rectangle' (lines '877'-'883'). +src/net/sf/freecol/client/gui/panel/Flag.java:877: Local variable 'rectangle' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:885: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/Flag.java:885: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:886: Found 'DU'-anomaly for variable 'colors' (lines '886'-'900'). +src/net/sf/freecol/client/gui/panel/Flag.java:886: Local variable 'colors' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:887: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:887: Found 'DU'-anomaly for variable 'x' (lines '887'-'900'). +src/net/sf/freecol/client/gui/panel/Flag.java:887: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:888: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:888: Found 'DU'-anomaly for variable 'y' (lines '888'-'900'). +src/net/sf/freecol/client/gui/panel/Flag.java:888: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:889: Found 'DU'-anomaly for variable 'halfWidth' (lines '889'-'900'). +src/net/sf/freecol/client/gui/panel/Flag.java:889: Local variable 'halfWidth' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:890: Found 'DU'-anomaly for variable 'halfHeight' (lines '890'-'900'). +src/net/sf/freecol/client/gui/panel/Flag.java:890: Local variable 'halfHeight' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:891: Found 'DU'-anomaly for variable 'offset' (lines '891'-'900'). +src/net/sf/freecol/client/gui/panel/Flag.java:891: Local variable 'offset' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:893: Found 'DU'-anomaly for variable 'rectangle' (lines '893'-'900'). +src/net/sf/freecol/client/gui/panel/Flag.java:893: Local variable 'rectangle' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:896: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:896: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:896: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:902: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/Flag.java:902: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:902: Parameter 'sinister' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:904: Local variable 'colors' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:905: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:913: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/Flag.java:913: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:914: Found 'DU'-anomaly for variable 'colors' (lines '914'-'929'). +src/net/sf/freecol/client/gui/panel/Flag.java:914: Local variable 'colors' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:915: Found 'DU'-anomaly for variable 'path' (lines '915'-'929'). +src/net/sf/freecol/client/gui/panel/Flag.java:915: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:916: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:916: Found 'DU'-anomaly for variable 'x' (lines '916'-'929'). +src/net/sf/freecol/client/gui/panel/Flag.java:916: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:917: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:917: Found 'DU'-anomaly for variable 'y' (lines '917'-'929'). +src/net/sf/freecol/client/gui/panel/Flag.java:917: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:918: Found 'DU'-anomaly for variable 'halfWidth' (lines '918'-'929'). +src/net/sf/freecol/client/gui/panel/Flag.java:918: Local variable 'halfWidth' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:919: Found 'DU'-anomaly for variable 'halfHeight' (lines '919'-'929'). +src/net/sf/freecol/client/gui/panel/Flag.java:919: Local variable 'halfHeight' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:921: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:921: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:923: Local variable 'nextIndex' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:924: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:924: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:931: Parameter 'decoration' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:932: Local variable 'quarterWidth' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:933: Local variable 'quarterHeight' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:934: Found 'DD'-anomaly for variable 'offset' (lines '934'-'939'). +src/net/sf/freecol/client/gui/panel/Flag.java:935: Found 'DD'-anomaly for variable 'width' (lines '935'-'942'). +src/net/sf/freecol/client/gui/panel/Flag.java:936: Found 'DD'-anomaly for variable 'height' (lines '936'-'942'). +src/net/sf/freecol/client/gui/panel/Flag.java:947: Local variable 'cross' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:955: Parameter 'sinister' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:956: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:976: Avoid variables with short names like y1 +src/net/sf/freecol/client/gui/panel/Flag.java:976: Local variable 'y1' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:977: Avoid variables with short names like y2 +src/net/sf/freecol/client/gui/panel/Flag.java:977: Local variable 'y2' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:978: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:978: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:979: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:999: Parameter 'small' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:999: Parameter 'unionShape' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1000: Local variable 'path' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1001: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:1001: Found 'DD'-anomaly for variable 'x' (lines '1,001'-'1,004'). +src/net/sf/freecol/client/gui/panel/Flag.java:1001: Found 'DU'-anomaly for variable 'x' (lines '1,001'-'1,034'). +src/net/sf/freecol/client/gui/panel/Flag.java:1002: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:1002: Found 'DD'-anomaly for variable 'y' (lines '1,002'-'1,005'). +src/net/sf/freecol/client/gui/panel/Flag.java:1002: Found 'DU'-anomaly for variable 'y' (lines '1,002'-'1,034'). +src/net/sf/freecol/client/gui/panel/Flag.java:1004: Found 'DU'-anomaly for variable 'x' (lines '1,004'-'1,034'). +src/net/sf/freecol/client/gui/panel/Flag.java:1005: Found 'DU'-anomaly for variable 'y' (lines '1,005'-'1,034'). +src/net/sf/freecol/client/gui/panel/Flag.java:1009: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1010: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1015: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1016: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1021: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1022: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1023: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1025: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1026: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1037: Local variable 'rhombus' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1045: The method 'getRectangle' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/panel/Flag.java:1045: The method 'getRectangle' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/Flag.java:1045: The method 'getRectangle' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/Flag.java:1047: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/Flag.java:1049: Local variable 'union' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1079: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:1079: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:1083: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:1083: Useless parentheses. +src/net/sf/freecol/client/gui/panel/Flag.java:1106: Found 'UR'-anomaly for variable 'i' (lines '1,106'-'1,115'). +src/net/sf/freecol/client/gui/panel/Flag.java:1107: Local variable 'star' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1108: Found 'DU'-anomaly for variable 'angle' (lines '1,108'-'1,122'). +src/net/sf/freecol/client/gui/panel/Flag.java:1108: Local variable 'angle' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1109: Local variable 'radius' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1110: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:1111: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:1112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1113: Local variable 'vertex' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1114: Local variable 'i' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1115: Local variable 'phi' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1130: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:1130: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:1130: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1130: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1141: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:1141: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:1141: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1141: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1141: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1142: Local variable 'newStar' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1157: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:1157: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:1157: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1157: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1157: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1158: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/panel/Flag.java:1158: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:1158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:1159: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/panel/Flag.java:1159: Local variable 'dy' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:1159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:1170: Parameter 'radius' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1171: Found 'DU'-anomaly for variable 'phi' (lines '1,171'-'1,191'). +src/net/sf/freecol/client/gui/panel/Flag.java:1171: Local variable 'phi' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1172: Found 'DD'-anomaly for variable 'unionPath' (lines '1,172'-'1,177'). +src/net/sf/freecol/client/gui/panel/Flag.java:1173: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/Flag.java:1173: Avoid empty if statements +src/net/sf/freecol/client/gui/panel/Flag.java:1175: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Flag.java:1178: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Flag.java:1180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1185: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:1185: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1186: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:1186: Local variable 'y' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Flag.java:1194: Parameter 'union' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1194: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Flag.java:1195: Found 'DD'-anomaly for variable 'bars' (lines '1,195'-'1,198'). +src/net/sf/freecol/client/gui/panel/Flag.java:1202: Local variable 'maxCols' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:1202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Flag.java:1209: Found 'DU'-anomaly for variable 'hSpace' (lines '1,209'-'1,228'). +src/net/sf/freecol/client/gui/panel/Flag.java:1209: Local variable 'hSpace' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1210: Found 'DU'-anomaly for variable 'vSpace' (lines '1,210'-'1,228'). +src/net/sf/freecol/client/gui/panel/Flag.java:1210: Local variable 'vSpace' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1211: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/Flag.java:1211: Found 'DU'-anomaly for variable 'y' (lines '1,211'-'1,228'). +src/net/sf/freecol/client/gui/panel/Flag.java:1212: Local variable 'grid' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1213: Found 'DU'-anomaly for variable 'count' (lines '1,213'-'1,228'). +src/net/sf/freecol/client/gui/panel/Flag.java:1215: Local variable 'cols' could be declared final +src/net/sf/freecol/client/gui/panel/Flag.java:1216: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/Flag.java:1216: Found 'DD'-anomaly for variable 'x' (lines '1,216'-'1,216'). +src/net/sf/freecol/client/gui/panel/Flag.java:1216: Found 'DU'-anomaly for variable 'x' (lines '1,216'-'1,228'). +src/net/sf/freecol/client/gui/panel/Flag.java:1223: Found 'DU'-anomaly for variable 'count' (lines '1,223'-'1,228'). +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:43: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:47: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:59: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:60: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:60: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:60: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:60: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:61: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:76: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:76: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:77: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:77: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:77: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColChoiceDialog.java:78: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:43: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:43: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:47: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:59: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:60: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:60: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:60: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:61: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:61: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:68: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:78: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:78: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:79: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:79: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:79: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:79: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:80: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/FreeColConfirmDialog.java:80: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:20: Possible God class (WMC=65, ATFD=43, TCC=0.005291005291005291) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:64: The class 'FreeColDialog' has a Cyclomatic Complexity of 3 (Highest = 15). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:64: The class 'FreeColDialog' has a Modified Cyclomatic Complexity of 2 (Highest = 14). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:64: The class 'FreeColDialog' has a Standard Cyclomatic Complexity of 2 (Highest = 15). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:64: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:66: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:66: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:68: enumCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:83: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:92: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:92: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:98: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:114: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:114: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:115: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:115: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:115: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:115: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:116: Parameter 'options' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:129: Found 'UR'-anomaly for variable 'ci' (lines '129'-'132'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:129: Parameter 'options' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Avoid variables with short names like i +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Avoid variables with short names like ok +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Found 'DD'-anomaly for variable 'can' (lines '130'-'133'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Found 'DD'-anomaly for variable 'def' (lines '130'-'132'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Found 'DD'-anomaly for variable 'i' (lines '130'-'135'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'134'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Found 'DU'-anomaly for variable 'i' (lines '130'-'139'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:130: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:131: Local variable 'ci' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:132: Avoid using if...else statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:132: Found 'DD'-anomaly for variable 'def' (lines '132'-'132'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:133: Avoid using if...else statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:133: Found 'DD'-anomaly for variable 'can' (lines '133'-'133'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:134: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:134: Found 'DD'-anomaly for variable 'ok' (lines '134'-'134'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:135: Found 'DD'-anomaly for variable 'i' (lines '135'-'135'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:135: Found 'DU'-anomaly for variable 'i' (lines '135'-'139'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:137: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:137: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:151: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:163: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:163: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:163: The method 'initializeDialog' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:163: The method 'initializeDialog' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:163: The method 'initializeDialog' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:163: The method initializeDialog() has an NPath complexity of 480 +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:164: Avoid reassigning parameters such as 'obj' +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:164: Avoid reassigning parameters such as 'obj' +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:164: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:164: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:164: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:165: Parameter 'options' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'170'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'170'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'170'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'170'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'170'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'170'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'171'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'171'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'171'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'171'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'171'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:168: Found 'DD'-anomaly for variable 'paneType' (lines '168'-'171'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:169: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:169: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:173: Local variable 'def' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:174: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:174: Avoid variables with short names like ci +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:174: Local variable 'ci' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:174: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:174: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:190: Local variable 'contentPane' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:191: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:200: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:205: Local variable 'adapter' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: Avoid using redundant field initializer for 'gotFocus' +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: Found 'DU'-anomaly for variable 'gotFocus' (lines '206'-'263'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: Found 'DU'-anomaly for variable 'gotFocus' (lines '206'-'263'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: Found 'DU'-anomaly for variable 'gotFocus' (lines '206'-'263'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: Found 'DU'-anomaly for variable 'gotFocus' (lines '206'-'263'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: Found 'DU'-anomaly for variable 'gotFocus' (lines '206'-'263'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: Found 'DU'-anomaly for variable 'gotFocus' (lines '206'-'263'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:206: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:209: Avoid variables with short names like we +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:209: Parameter 'we' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:209: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:215: Avoid variables with short names like we +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:215: Parameter 'we' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:215: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:227: Avoid variables with short names like ce +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:227: Parameter 'ce' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:227: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:235: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:244: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:244: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:244: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:251: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:251: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:251: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:252: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:253: Local variable 'now' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:256: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:256: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:257: Avoid variables with short names like dy +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:257: Local variable 'dy' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:258: Avoid variables with short names like p +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:258: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:260: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:265: Avoid variables with short names like j +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:265: Parameter 'j' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:265: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:271: Avoid variables with short names like j +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:271: Found 'UR'-anomaly for variable 'componente' (lines '271'-'275'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:271: Parameter 'j' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:273: Local variable 'componentes' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:274: Local variable 'componente' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:280: Parameter 'opaqueComponent' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:284: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:287: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:346: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:365: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:375: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:375: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:384: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:394: Found 'UR'-anomaly for variable 'ci' (lines '394'-'398'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:396: Found 'DU'-anomaly for variable 'value' (lines '396'-'402'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:396: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:397: Local variable 'ci' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:398: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:398: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:430: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:430: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:436: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:436: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:437: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:451: Parameter 'val' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:452: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:463: Found 'UR'-anomaly for variable 'listener' (lines '463'-'475'). +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:466: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:466: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:471: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:474: Local variable 'listener' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:486: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:486: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColDialog.java:489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:40: Variables that are final and static should be all capitals, 'imageBorder' is not all capitals. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:44: Avoid excessively long variable names like topLeftCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:46: Avoid excessively long variable names like topRightCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:48: Avoid excessively long variable names like bottomRightCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:50: Avoid excessively long variable names like bottomLeftCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:69: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:82: Avoid excessively long variable names like topLeftCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:82: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:82: Parameter 'topLeftCornerImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:83: Parameter 'topImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:84: Avoid excessively long variable names like topRightCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:84: Parameter 'topRightCornerImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:85: Parameter 'rightImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:86: Avoid excessively long variable names like bottomRightCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:86: Parameter 'bottomRightCornerImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:87: Parameter 'bottomImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:88: Avoid excessively long variable names like bottomLeftCornerImage +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:88: Parameter 'bottomLeftCornerImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:89: Parameter 'leftImage' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:107: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:107: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:120: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:120: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:120: Parameter 'insets' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:121: Found 'DD'-anomaly for variable 'top' (lines '121'-'127'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:122: Found 'DD'-anomaly for variable 'left' (lines '122'-'130'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:123: Found 'DD'-anomaly for variable 'bottom' (lines '123'-'133'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:124: Found 'DD'-anomaly for variable 'right' (lines '124'-'136'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:150: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:161: The method paintBorder() has an NPath complexity of 256 +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:162: Found 'DU'-anomaly for variable 'insets' (lines '162'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:162: Local variable 'insets' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:163: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:163: Found 'DU'-anomaly for variable 'g2' (lines '163'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:163: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:166: Found 'DU'-anomaly for variable 'topHeight' (lines '166'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:166: Local variable 'topHeight' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:167: Found 'DU'-anomaly for variable 'leftWidth' (lines '167'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:167: Local variable 'leftWidth' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:168: Found 'DU'-anomaly for variable 'bottomHeight' (lines '168'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:168: Local variable 'bottomHeight' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:169: Found 'DU'-anomaly for variable 'rightWidth' (lines '169'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:169: Local variable 'rightWidth' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:170: Avoid excessively long variable names like topLeftCornerWidth +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:170: Found 'DU'-anomaly for variable 'topLeftCornerWidth' (lines '170'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:170: Local variable 'topLeftCornerWidth' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:171: Avoid excessively long variable names like topLeftCornerHeight +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:171: Found 'DU'-anomaly for variable 'topLeftCornerHeight' (lines '171'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:171: Local variable 'topLeftCornerHeight' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:172: Avoid excessively long variable names like topRightCornerWidth +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:172: Found 'DU'-anomaly for variable 'topRightCornerWidth' (lines '172'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:172: Local variable 'topRightCornerWidth' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:173: Avoid excessively long variable names like topRightCornerHeight +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:173: Found 'DU'-anomaly for variable 'topRightCornerHeight' (lines '173'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:173: Local variable 'topRightCornerHeight' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:174: Avoid excessively long variable names like bottomLeftCornerWidth +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:174: Found 'DU'-anomaly for variable 'bottomLeftCornerWidth' (lines '174'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:174: Local variable 'bottomLeftCornerWidth' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:175: Avoid excessively long variable names like bottomLeftCornerHeight +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:175: Found 'DU'-anomaly for variable 'bottomLeftCornerHeight' (lines '175'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:175: Local variable 'bottomLeftCornerHeight' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:176: Avoid excessively long variable names like bottomRightCornerWidth +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:176: Found 'DU'-anomaly for variable 'bottomRightCornerWidth' (lines '176'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:176: Local variable 'bottomRightCornerWidth' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:177: Avoid excessively long variable names like bottomRightCornerHeight +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:177: Found 'DU'-anomaly for variable 'bottomRightCornerHeight' (lines '177'-'236'). +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:177: Local variable 'bottomRightCornerHeight' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:243: Avoid variables with short names like im +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:243: Parameter 'im' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:252: Avoid variables with short names like im +src/net/sf/freecol/client/gui/panel/FreeColImageBorder.java:252: Parameter 'im' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:36: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:38: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:47: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:47: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:51: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:64: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:65: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:65: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:65: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:66: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:66: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:73: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:84: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:84: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:85: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:85: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:85: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:85: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:86: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:86: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:101: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:102: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/FreeColInputDialog.java:102: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:53: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:55: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:58: Avoid variables with short names like OK +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:62: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:64: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:66: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:68: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:76: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:86: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:86: Parameter 'layout' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:141: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:168: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:187: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:188: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:199: Parameter 'cancelButton' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:200: Avoid throwing null pointer exceptions. +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:200: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:202: Local variable 'inputMap' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:207: Local variable 'cancelAction' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:208: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:217: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:220: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:220: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:220: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:224: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:224: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:236: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:236: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:241: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:252: Found 'UR'-anomaly for variable 'listener' (lines '252'-'269'). +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:259: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:266: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:268: Local variable 'listener' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColPanel.java:279: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:44: The class 'FreeColProgressBar' has a Cyclomatic Complexity of 4 (Highest = 16). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:44: The class 'FreeColProgressBar' has a Modified Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:44: The class 'FreeColProgressBar' has a Standard Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:47: Avoid using redundant field initializer for 'min' +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:53: Avoid using redundant field initializer for 'value' +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:56: Avoid using redundant field initializer for 'step' +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:60: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:66: Avoid using redundant field initializer for 'goodsType' +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:69: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:77: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:88: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:88: Parameter 'max' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:88: Parameter 'min' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:92: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:101: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:101: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:101: Parameter 'max' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:101: Parameter 'min' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:101: Parameter 'step' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:101: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:124: Parameter 'step' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:124: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:136: Parameter 'max' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:136: Parameter 'min' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:136: Parameter 'step' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:136: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:145: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:145: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:145: The method 'paintComponent' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:145: The method 'paintComponent' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:145: The method 'paintComponent' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:145: The method paintComponent() has an NPath complexity of 8640 +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:145: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:147: Local variable 'g2d' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:150: Found 'DU'-anomaly for variable 'width' (lines '150'-'218'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:150: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:151: Found 'DU'-anomaly for variable 'height' (lines '151'-'218'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:151: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:161: Found 'DD'-anomaly for variable 'dvalue' (lines '161'-'163'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:161: Found 'DD'-anomaly for variable 'dvalue' (lines '161'-'165'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:175: Found 'DD'-anomaly for variable 'dstep' (lines '175'-'177'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:175: Found 'DU'-anomaly for variable 'dstep' (lines '175'-'218'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:187: Local variable 'stepSignal' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:187: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:187: Useless parentheses. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:188: No need to call String.valueOf to append to a string. +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:189: Found 'DD'-anomaly for variable 'turnsString' (lines '189'-'191'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:189: Found 'DD'-anomaly for variable 'turnsString' (lines '189'-'198'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:194: Found 'DD'-anomaly for variable 'turns' (lines '194'-'196'). +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:200: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:204: Local variable 'stringWidth' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:204: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:205: Local variable 'stringHeight' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColProgressBar.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:40: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:51: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:51: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:52: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:52: Parameter 'modal' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:52: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:53: Parameter 'cancelKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:53: Parameter 'okKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:58: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/FreeColStringInputDialog.java:60: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:45: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:45: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:46: Avoid unused constructor parameters such as 'custom'. +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:46: Parameter 'custom' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:46: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:53: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:59: Local variable 'comp' could be declared final +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:78: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:80: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/GameOptionsDialog.java:80: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:51: The class 'GoodsDetailPanel' has a Cyclomatic Complexity of 8 (Highest = 27). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:51: The class 'GoodsDetailPanel' has a Modified Cyclomatic Complexity of 8 (Highest = 24). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:51: The class 'GoodsDetailPanel' has a Standard Cyclomatic Complexity of 8 (Highest = 24). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:60: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:61: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:72: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Found 'UR'-anomaly for variable 'building' (lines '80'-'147'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Found 'UR'-anomaly for variable 'improvementType' (lines '80'-'94'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Found 'UR'-anomaly for variable 'role' (lines '80'-'164'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Found 'UR'-anomaly for variable 'unit' (lines '80'-'186'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: The method 'buildDetail' has a Cyclomatic Complexity of 27. +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: The method 'buildDetail' has a Modified Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: The method 'buildDetail' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:80: The method buildDetail() has an NPath complexity of 49956 +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:81: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:83: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:86: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:89: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:90: Local variable 'improvements' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:91: Local variable 'modifiers' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:92: Local variable 'improvementType' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:94: Avoid excessively long variable names like productionModifier +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:94: Local variable 'productionModifier' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:104: The String literal "span" appears 9 times in this file; the first occurrence is on line 104 +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:107: Local variable 'constraints' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:116: The String literal "newline 20" appears 7 times in this file; the first occurrence is on line 116 +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:127: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:134: Local variable 'buildingTypes' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:135: Found 'DD'-anomaly for variable 'allTypes' (lines '135'-'158'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:140: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:145: Found 'DU'-anomaly for variable 'count' (lines '145'-'208'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:146: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:147: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:153: Found 'DU'-anomaly for variable 'count' (lines '153'-'208'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:157: Local variable 'roles' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:158: Found 'DD'-anomaly for variable 'allTypes' (lines '158'-'174'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:163: Local variable 'role' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:164: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:173: Local variable 'unitTypes' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:174: Found 'DU'-anomaly for variable 'allTypes' (lines '174'-'208'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:179: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:185: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:186: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:211: Found 'UR'-anomaly for variable 'bt' (lines '211'-'215'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:211: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:212: Parameter 'output' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:212: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:213: Found 'DD'-anomaly for variable 'result' (lines '213'-'219'). +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:214: Local variable 'bt' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsDetailPanel.java:219: Found 'DD'-anomaly for variable 'result' (lines '219'-'219'). +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:50: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:57: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:57: Parameter 'gui' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:65: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:74: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:74: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:75: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:76: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:76: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:76: Useless parentheses. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:76: Useless parentheses. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:78: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:97: Useless parentheses. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:97: Useless parentheses. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:99: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:103: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:108: Useless parentheses. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:108: Useless parentheses. +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:139: Parameter 'partialChosen' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:141: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:142: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:156: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/GoodsLabel.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ImageSelection.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ImageSelection.java:36: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ImageSelection.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ImageSelection.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ImageSelection.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ImageSelection.java:47: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ImageSelection.java:60: Parameter 'flavor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ImageSelection.java:62: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ImageSelection.java:85: Parameter 'flavor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/InPortPanel.java:32: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/InPortPanel.java:41: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:41: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:41: Parameter 'portPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:50: Found 'UR'-anomaly for variable 'component' (lines '50'-'58'). +src/net/sf/freecol/client/gui/panel/InPortPanel.java:53: Local variable 'portPanel' could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:54: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/InPortPanel.java:54: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/InPortPanel.java:55: Found 'DU'-anomaly for variable 'selectedUnit' (lines '55'-'74'). +src/net/sf/freecol/client/gui/panel/InPortPanel.java:55: Local variable 'selectedUnit' could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:55: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InPortPanel.java:56: Found 'DD'-anomaly for variable 'lastCarrier' (lines '56'-'66'). +src/net/sf/freecol/client/gui/panel/InPortPanel.java:56: Found 'DU'-anomaly for variable 'lastCarrier' (lines '56'-'74'). +src/net/sf/freecol/client/gui/panel/InPortPanel.java:57: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:59: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:60: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/InPortPanel.java:60: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InPortPanel.java:61: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/InPortPanel.java:62: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InPortPanel.java:65: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InPortPanel.java:65: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InPortPanel.java:66: Found 'DD'-anomaly for variable 'lastCarrier' (lines '66'-'66'). +src/net/sf/freecol/client/gui/panel/InPortPanel.java:66: Found 'DU'-anomaly for variable 'lastCarrier' (lines '66'-'74'). +src/net/sf/freecol/client/gui/panel/InPortPanel.java:71: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:45: The class 'IndianSettlementPanel' has a Cyclomatic Complexity of 12 (Highest = 11). +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:45: The class 'IndianSettlementPanel' has a Modified Cyclomatic Complexity of 12 (Highest = 11). +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:45: The class 'IndianSettlementPanel' has a Standard Cyclomatic Complexity of 12 (Highest = 11). +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:48: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:57: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:57: The constructor 'IndianSettlementPanel' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:57: The constructor 'IndianSettlementPanel' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:57: The constructor 'IndianSettlementPanel' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:58: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:61: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:62: Local variable 'settlementLabel' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:64: Local variable 'indian' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:65: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:66: Local variable 'contacted' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:67: Local variable 'visited' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:75: Local variable 'tension' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:76: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:76: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:78: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:90: The String literal "newline" appears 4 times in this file; the first occurrence is on line 90 +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:93: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:93: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:95: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:101: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:101: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:103: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:106: Local variable 'wantedGoods' could be declared final +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:107: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:107: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:107: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:110: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:110: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:112: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:115: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:118: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:118: Useless parentheses. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:119: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:120: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/IndianSettlementPanel.java:123: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/InfoPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:20: Possible God class (WMC=56, ATFD=78, TCC=0.0) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:63: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/InfoPanel.java:75: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:78: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:78: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:80: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:87: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:91: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:94: Local variable 'labelString' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:95: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:97: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:97: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:102: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:116: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:118: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:140: Found 'UR'-anomaly for variable 'ag' (lines '140'-'190'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:140: Found 'UR'-anomaly for variable 's' (lines '140'-'155'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:140: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:146: Found 'DU'-anomaly for variable 'font' (lines '146'-'208'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:149: Found 'DU'-anomaly for variable 'width' (lines '149'-'208'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:150: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:152: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:153: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:155: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:155: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:164: The String literal "span " appears 5 times in this file; the first occurrence is on line 164 +src/net/sf/freecol/client/gui/panel/InfoPanel.java:166: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/InfoPanel.java:166: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:170: Local variable 'defenceLabel' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:176: Local variable 'moveLabel' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:182: Local variable 'produce' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:189: Local variable 'ag' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:190: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:191: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/InfoPanel.java:191: Local variable 'n' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:192: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:192: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:229: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:257: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:257: The method update() has an NPath complexity of 226 +src/net/sf/freecol/client/gui/panel/InfoPanel.java:261: Avoid variables with short names like gc +src/net/sf/freecol/client/gui/panel/InfoPanel.java:261: Local variable 'gc' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:262: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/InfoPanel.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:266: Avoid variables with short names like gc +src/net/sf/freecol/client/gui/panel/InfoPanel.java:266: Local variable 'gc' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:267: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/InfoPanel.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/InfoPanel.java:269: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/InfoPanel.java:271: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:271: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:275: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:275: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:285: Found 'UR'-anomaly for variable 'carriedUnit' (lines '285'-'335'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:285: Found 'UR'-anomaly for variable 'goods' (lines '285'-'318'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:285: Found 'UR'-anomaly for variable 's' (lines '285'-'301'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:289: Found 'DU'-anomaly for variable 'font' (lines '289'-'345'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:289: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:294: Avoid variables with short names like ii +src/net/sf/freecol/client/gui/panel/InfoPanel.java:294: Local variable 'ii' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:294: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:295: Local variable 'imageLabel' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:297: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:299: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:301: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:306: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:306: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:311: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:317: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:318: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:319: Avoid variables with short names like gt +src/net/sf/freecol/client/gui/panel/InfoPanel.java:319: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:321: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/InfoPanel.java:322: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:323: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:325: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:326: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:329: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:331: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:334: Local variable 'carriedUnit' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:335: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:336: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InfoPanel.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:354: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:359: enumCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:363: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:363: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:365: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:365: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:367: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:367: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:367: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:369: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:369: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:369: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:371: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:371: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:371: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:373: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:373: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:373: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:375: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:375: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:375: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:377: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:377: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:377: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:395: Parameter 'useSkin' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:404: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:404: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:405: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:408: Found 'DD'-anomaly for variable 'internalPanelTop' (lines '408'-'414'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:409: Avoid excessively long variable names like internalPanelHeight +src/net/sf/freecol/client/gui/panel/InfoPanel.java:409: Found 'DD'-anomaly for variable 'internalPanelHeight' (lines '409'-'415'). +src/net/sf/freecol/client/gui/panel/InfoPanel.java:410: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/InfoPanel.java:427: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/InfoPanel.java:427: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:427: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/InfoPanel.java:428: Local variable 'activeUnit' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:429: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:430: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:430: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:439: Parameter 'internalHeight' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:439: Parameter 'internalTop' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:439: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:452: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:452: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:452: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:452: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:468: Parameter 'mapTransform' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:469: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/InfoPanel.java:469: Avoid variables with short names like p +src/net/sf/freecol/client/gui/panel/InfoPanel.java:472: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:473: Avoid variables with short names like d +src/net/sf/freecol/client/gui/panel/InfoPanel.java:473: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:474: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:489: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:501: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:511: Local variable 'newMode' could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InfoPanel.java:517: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/InfoPanel.java:517: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/InfoPanel.java:561: Parameter 'graphics' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InfoPanel.java:562: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/InfoPanel.java:562: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/InformationPanel.java:57: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:58: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:58: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:58: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:63: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/InformationPanel.java:72: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:72: Parameter 'texts' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:73: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/panel/InformationPanel.java:73: Parameter 'fcos' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:73: Parameter 'images' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:78: Local variable 'textPanel' could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:82: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/InformationPanel.java:83: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InformationPanel.java:85: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InformationPanel.java:88: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/InformationPanel.java:90: Local variable 'disp' could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:91: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/InformationPanel.java:92: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:96: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/InformationPanel.java:102: Local variable 'scrollPane' could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:120: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:121: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InformationPanel.java:121: Useless parentheses. +src/net/sf/freecol/client/gui/panel/InformationPanel.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/InformationPanel.java:130: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/InformationPanel.java:137: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/InformationPanel.java:137: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/InformationPanel.java:137: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/LabourData.java:20: Possible God class (WMC=102, ATFD=70, TCC=0.05641025641025641) +src/net/sf/freecol/client/gui/panel/LabourData.java:46: The class 'LabourData' has a Cyclomatic Complexity of 4 (Highest = 13). +src/net/sf/freecol/client/gui/panel/LabourData.java:46: The class 'LabourData' has a Modified Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/client/gui/panel/LabourData.java:46: The class 'LabourData' has a Standard Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/client/gui/panel/LabourData.java:46: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/LabourData.java:48: Avoid excessively long variable names like UNITS_IN_EUROPE_GETTER +src/net/sf/freecol/client/gui/panel/LabourData.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:50: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:50: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:55: Avoid excessively long variable names like UNITS_AT_SEA_GETTER +src/net/sf/freecol/client/gui/panel/LabourData.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:57: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:57: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:62: Avoid excessively long variable names like UNITS_ON_LAND_GETTER +src/net/sf/freecol/client/gui/panel/LabourData.java:62: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:64: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:69: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:78: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:80: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:80: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:85: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:89: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:93: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:99: The class 'LocationData' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/client/gui/panel/LabourData.java:99: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:101: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:102: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:108: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:113: Field isTotal has the same name as a method +src/net/sf/freecol/client/gui/panel/LabourData.java:113: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:113: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:118: Avoid excessively long variable names like workingProfessionals +src/net/sf/freecol/client/gui/panel/LabourData.java:118: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:123: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:128: Avoid excessively long variable names like otherWorkingAmateurs +src/net/sf/freecol/client/gui/panel/LabourData.java:128: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:133: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:133: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:138: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:138: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:143: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:143: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:148: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:148: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:153: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:153: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:158: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:158: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:160: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:160: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:164: Parameter 'total' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:164: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:164: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:169: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:173: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:177: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:177: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:182: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:186: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:190: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:194: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:201: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:210: The method 'getRowCount' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/LabourData.java:210: The method getRowCount() has an NPath complexity of 288 +src/net/sf/freecol/client/gui/panel/LabourData.java:211: Local variable 'isSummary' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:213: Found 'DD'-anomaly for variable 'rows' (lines '213'-'214'). +src/net/sf/freecol/client/gui/panel/LabourData.java:213: Found 'DD'-anomaly for variable 'rows' (lines '213'-'215'). +src/net/sf/freecol/client/gui/panel/LabourData.java:213: Found 'DD'-anomaly for variable 'rows' (lines '213'-'216'). +src/net/sf/freecol/client/gui/panel/LabourData.java:213: Found 'DD'-anomaly for variable 'rows' (lines '213'-'217'). +src/net/sf/freecol/client/gui/panel/LabourData.java:213: Found 'DD'-anomaly for variable 'rows' (lines '213'-'218'). +src/net/sf/freecol/client/gui/panel/LabourData.java:213: Found 'DD'-anomaly for variable 'rows' (lines '213'-'219'). +src/net/sf/freecol/client/gui/panel/LabourData.java:213: Found 'DD'-anomaly for variable 'rows' (lines '213'-'220'). +src/net/sf/freecol/client/gui/panel/LabourData.java:214: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:214: Found 'DD'-anomaly for variable 'rows' (lines '214'-'215'). +src/net/sf/freecol/client/gui/panel/LabourData.java:214: Found 'DD'-anomaly for variable 'rows' (lines '214'-'216'). +src/net/sf/freecol/client/gui/panel/LabourData.java:214: Found 'DD'-anomaly for variable 'rows' (lines '214'-'217'). +src/net/sf/freecol/client/gui/panel/LabourData.java:214: Found 'DD'-anomaly for variable 'rows' (lines '214'-'218'). +src/net/sf/freecol/client/gui/panel/LabourData.java:214: Found 'DD'-anomaly for variable 'rows' (lines '214'-'219'). +src/net/sf/freecol/client/gui/panel/LabourData.java:214: Found 'DD'-anomaly for variable 'rows' (lines '214'-'220'). +src/net/sf/freecol/client/gui/panel/LabourData.java:215: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:215: Found 'DD'-anomaly for variable 'rows' (lines '215'-'216'). +src/net/sf/freecol/client/gui/panel/LabourData.java:215: Found 'DD'-anomaly for variable 'rows' (lines '215'-'217'). +src/net/sf/freecol/client/gui/panel/LabourData.java:215: Found 'DD'-anomaly for variable 'rows' (lines '215'-'218'). +src/net/sf/freecol/client/gui/panel/LabourData.java:215: Found 'DD'-anomaly for variable 'rows' (lines '215'-'219'). +src/net/sf/freecol/client/gui/panel/LabourData.java:215: Found 'DD'-anomaly for variable 'rows' (lines '215'-'220'). +src/net/sf/freecol/client/gui/panel/LabourData.java:216: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:216: Found 'DD'-anomaly for variable 'rows' (lines '216'-'217'). +src/net/sf/freecol/client/gui/panel/LabourData.java:216: Found 'DD'-anomaly for variable 'rows' (lines '216'-'218'). +src/net/sf/freecol/client/gui/panel/LabourData.java:216: Found 'DD'-anomaly for variable 'rows' (lines '216'-'219'). +src/net/sf/freecol/client/gui/panel/LabourData.java:216: Found 'DD'-anomaly for variable 'rows' (lines '216'-'220'). +src/net/sf/freecol/client/gui/panel/LabourData.java:217: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:217: Found 'DD'-anomaly for variable 'rows' (lines '217'-'218'). +src/net/sf/freecol/client/gui/panel/LabourData.java:217: Found 'DD'-anomaly for variable 'rows' (lines '217'-'219'). +src/net/sf/freecol/client/gui/panel/LabourData.java:217: Found 'DD'-anomaly for variable 'rows' (lines '217'-'220'). +src/net/sf/freecol/client/gui/panel/LabourData.java:218: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:218: Found 'DD'-anomaly for variable 'rows' (lines '218'-'219'). +src/net/sf/freecol/client/gui/panel/LabourData.java:218: Found 'DD'-anomaly for variable 'rows' (lines '218'-'220'). +src/net/sf/freecol/client/gui/panel/LabourData.java:219: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:219: Found 'DD'-anomaly for variable 'rows' (lines '219'-'220'). +src/net/sf/freecol/client/gui/panel/LabourData.java:220: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:225: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:229: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:233: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:237: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:241: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:245: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:249: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:253: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:270: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:272: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:274: Avoid using redundant field initializer for 'summary' +src/net/sf/freecol/client/gui/panel/LabourData.java:274: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:274: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:279: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/LabourData.java:281: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:282: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:283: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:284: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:286: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:286: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:300: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:309: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:310: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/LabourData.java:310: Useless parentheses. +src/net/sf/freecol/client/gui/panel/LabourData.java:310: Useless parentheses. +src/net/sf/freecol/client/gui/panel/LabourData.java:313: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:314: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:317: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:319: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:319: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:322: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:326: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:330: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:334: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:338: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:342: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:346: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:350: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:354: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:355: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:358: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:360: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/LabourData.java:362: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:366: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:366: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:366: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/LabourData.java:366: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:368: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:368: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:368: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/LabourData.java:368: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:370: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:370: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:372: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:372: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:372: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:374: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:374: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:374: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:376: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:376: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:376: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:378: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/LabourData.java:378: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LabourData.java:378: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:380: Parameter 'client' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:380: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:381: Local variable 'spec' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:382: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:386: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:405: Found 'UR'-anomaly for variable 'colony' (lines '405'-'441'). +src/net/sf/freecol/client/gui/panel/LabourData.java:405: Found 'UR'-anomaly for variable 'unitData' (lines '405'-'436'). +src/net/sf/freecol/client/gui/panel/LabourData.java:405: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:405: The method 'gatherData' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/LabourData.java:405: The method 'gatherData' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/LabourData.java:405: The method 'gatherData' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/LabourData.java:406: Local variable 'labourTypes' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:408: Local variable 'units' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:410: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:415: Local variable 'location' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:415: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:417: Local variable 'data' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:417: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:424: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:435: Local variable 'unitData' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:436: Found 'DD'-anomaly for variable 'total' (lines '436'-'436'). +src/net/sf/freecol/client/gui/panel/LabourData.java:436: Found 'DU'-anomaly for variable 'total' (lines '436'-'451'). +src/net/sf/freecol/client/gui/panel/LabourData.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:438: Local variable 'expertProduction' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:438: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:438: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:440: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:441: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/LabourData.java:441: Local variable 'data' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:441: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/LabourData.java:443: Local variable 'netProduction' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:453: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:453: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:455: Avoid variables with short names like ut +src/net/sf/freecol/client/gui/panel/LabourData.java:459: Found 'UR'-anomaly for variable 'colony' (lines '459'-'469'). +src/net/sf/freecol/client/gui/panel/LabourData.java:459: Found 'UR'-anomaly for variable 'colony' (lines '459'-'469'). +src/net/sf/freecol/client/gui/panel/LabourData.java:459: Found 'UR'-anomaly for variable 'unitData' (lines '459'-'461'). +src/net/sf/freecol/client/gui/panel/LabourData.java:459: Found 'UR'-anomaly for variable 'unitData' (lines '459'-'461'). +src/net/sf/freecol/client/gui/panel/LabourData.java:460: Local variable 'unitData' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:465: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/LabourData.java:466: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/LabourData.java:468: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:468: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:476: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:476: Parameter 'getter' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:477: Local variable 'unitLocation' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:478: Local variable 'summaryLocation' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:480: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/LabourData.java:481: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:482: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/LabourData.java:485: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:485: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:487: Avoid unused local variables such as 'roleId'. +src/net/sf/freecol/client/gui/panel/LabourData.java:487: Found 'DU'-anomaly for variable 'roleId' (lines '487'-'503'). +src/net/sf/freecol/client/gui/panel/LabourData.java:487: Local variable 'roleId' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:487: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:488: Found 'DD'-anomaly for variable 'workingAs' (lines '488'-'490'). +src/net/sf/freecol/client/gui/panel/LabourData.java:488: Found 'DD'-anomaly for variable 'workingAs' (lines '488'-'492'). +src/net/sf/freecol/client/gui/panel/LabourData.java:488: Found 'DD'-anomaly for variable 'workingAs' (lines '488'-'494'). +src/net/sf/freecol/client/gui/panel/LabourData.java:488: Found 'DD'-anomaly for variable 'workingAs' (lines '488'-'496'). +src/net/sf/freecol/client/gui/panel/LabourData.java:499: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:505: Parameter 'expert' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:505: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:505: Parameter 'workingAs' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:507: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:507: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:509: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:511: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:511: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:515: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:515: Parameter 'unitData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:519: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:519: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LabourData.java:525: Avoid variables with short names like wl +src/net/sf/freecol/client/gui/panel/LabourData.java:525: Local variable 'wl' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:526: Found 'DU'-anomaly for variable 'colonyData' (lines '526'-'550'). +src/net/sf/freecol/client/gui/panel/LabourData.java:526: Found 'DU'-anomaly for variable 'colonyData' (lines '526'-'550'). +src/net/sf/freecol/client/gui/panel/LabourData.java:527: Local variable 'teacher' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:531: Local variable 'learning' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:531: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:532: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:534: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/LabourData.java:534: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:536: Local variable 'currentlyWorking' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:537: Found 'DU'-anomaly for variable 'production' (lines '537'-'550'). +src/net/sf/freecol/client/gui/panel/LabourData.java:537: Found 'DU'-anomaly for variable 'production' (lines '537'-'550'). +src/net/sf/freecol/client/gui/panel/LabourData.java:537: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:538: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:540: Local variable 'workingAs' could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:542: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/client/gui/panel/LabourData.java:542: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/client/gui/panel/LabourData.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:544: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/LabourData.java:548: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/LabourData.java:558: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LabourData.java:567: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LoadDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/LoadDialog.java:41: Variables that are final and static should be all capitals, 'cancelFile' is not all capitals. +src/net/sf/freecol/client/gui/panel/LoadDialog.java:52: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:52: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:53: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/panel/LoadDialog.java:53: Parameter 'directory' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:53: Parameter 'fileFilters' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:58: Local variable 'fileFilter' could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:70: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/LoadDialog.java:72: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:72: Useless parentheses. +src/net/sf/freecol/client/gui/panel/LoadDialog.java:72: Useless parentheses. +src/net/sf/freecol/client/gui/panel/LoadDialog.java:78: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/LoadDialog.java:78: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:88: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/LoadDialog.java:89: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/LoadDialog.java:89: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:47: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:47: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:51: Avoid excessively long variable names like privateMultiplayer +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:66: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:66: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:69: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:74: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:79: Avoid variables with short names like p1 +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:79: Local variable 'p1' could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:84: Avoid variables with short names like p2 +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:84: Local variable 'p2' could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:89: Avoid variables with short names like bg +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:89: Local variable 'bg' could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:165: Parameter 'publicServer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/LoadingSavegameDialog.java:165: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MainPanel.java:51: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/MainPanel.java:51: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/MainPanel.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MainPanel.java:59: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:63: Local variable 'canContinue' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:66: Avoid variables with short names like am +src/net/sf/freecol/client/gui/panel/MainPanel.java:66: Local variable 'am' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:67: Local variable 'newButton' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:68: Local variable 'openButton' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:69: Local variable 'mapEditorButton' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:70: Local variable 'optionsButton' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:71: Local variable 'quitButton' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:74: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MainPanel.java:74: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MainPanel.java:78: Local variable 'tempImage' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:79: Local variable 'logoLabel' could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:85: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MainPanel.java:85: The String literal "width 70%" appears 5 times in this file; the first occurrence is on line 85 +src/net/sf/freecol/client/gui/panel/MainPanel.java:101: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/MainPanel.java:101: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MainPanel.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapControls.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MapControls.java:51: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MapControls.java:60: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/MapControls.java:60: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/MapControls.java:62: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:63: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:64: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:67: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:68: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:69: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:70: Avoid excessively long variable names like miniMapToggleBorders +src/net/sf/freecol/client/gui/panel/MapControls.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:70: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:71: Avoid excessively long variable names like miniMapToggleFogOfWarButton +src/net/sf/freecol/client/gui/panel/MapControls.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:71: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:72: Avoid excessively long variable names like miniMapZoomOutButton +src/net/sf/freecol/client/gui/panel/MapControls.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:72: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:73: Avoid excessively long variable names like miniMapZoomInButton +src/net/sf/freecol/client/gui/panel/MapControls.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:73: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapControls.java:74: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:82: Parameter 'useSkin' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapControls.java:87: Avoid variables with short names like am +src/net/sf/freecol/client/gui/panel/MapControls.java:99: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/MapControls.java:100: Local variable 'action' could be declared final +src/net/sf/freecol/client/gui/panel/MapControls.java:102: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/panel/MapControls.java:104: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/MapControls.java:126: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/MapControls.java:139: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:143: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:147: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:156: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:158: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapControls.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapControls.java:164: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapControls.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapControls.java:173: Found 'UR'-anomaly for variable 'ub' (lines '173'-'188'). +src/net/sf/freecol/client/gui/panel/MapControls.java:175: Found 'DU'-anomaly for variable 'unit' (lines '175'-'190'). +src/net/sf/freecol/client/gui/panel/MapControls.java:175: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/MapControls.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapControls.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapControls.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapControls.java:187: Local variable 'ub' could be declared final +src/net/sf/freecol/client/gui/panel/MapControls.java:197: Parameter 'mapTransform' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapControls.java:203: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapControls.java:208: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:59: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:69: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:69: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:70: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:80: Local variable 'mapDirectory' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:82: Local variable 'files' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:85: Avoid variables with short names like f1 +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:85: Avoid variables with short names like f2 +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:85: Parameter 'f1' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:85: Parameter 'f2' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:85: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:89: Local variable 'mapPanel' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:91: Local variable 'mapButton' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:92: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:92: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:93: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:99: Local variable 'scrollPane' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:114: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:123: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:124: Found 'DU'-anomaly for variable 'mgo' (lines '124'-'162'). +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:126: Found 'DU'-anomaly for variable 'gui' (lines '126'-'162'). +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:130: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:137: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:144: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:151: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:158: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:171: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:172: Local variable 'mapName' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:174: Local variable 'mapButton' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:176: Local variable 'savegame' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:177: Local variable 'thumbnail' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:181: Local variable 'properties' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:187: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:189: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:191: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:193: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:207: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:209: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MapGeneratorOptionsDialog.java:209: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:39: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:54: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:54: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:57: Local variable 'widthLabel' could be declared final +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:59: Local variable 'heightLabel' could be declared final +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:62: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:79: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:81: Found 'DU'-anomaly for variable 'width' (lines '81'-'88'). +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:82: Found 'DU'-anomaly for variable 'height' (lines '82'-'88'). +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:84: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:86: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:86: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MapSizeDialog.java:86: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MarketLabel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MarketLabel.java:52: Parameter 'lib' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MarketLabel.java:52: Parameter 'market' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MarketLabel.java:52: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MarketLabel.java:55: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MarketLabel.java:79: Found 'DD'-anomaly for variable 'toolTipText' (lines '79'-'83'). +src/net/sf/freecol/client/gui/panel/MarketLabel.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MarketLabel.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MarketLabel.java:87: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/MarketLabel.java:132: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MigPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MigPanel.java:33: Avoid using redundant field initializer for 'uiClassId' +src/net/sf/freecol/client/gui/panel/MigPanel.java:33: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MigPanel.java:33: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MigPanel.java:36: Document empty constructor +src/net/sf/freecol/client/gui/panel/MigPanel.java:36: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/MigPanel.java:36: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MigPanel.java:38: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/MigPanel.java:38: Parameter 'uiClassId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MigPanel.java:38: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MigPanel.java:42: Parameter 'layout' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MigPanel.java:42: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MigPanel.java:54: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/MiniMap.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MiniMap.java:20: Possible God class (WMC=54, ATFD=72, TCC=0.11052631578947368) +src/net/sf/freecol/client/gui/panel/MiniMap.java:52: The class 'MiniMap' has a Cyclomatic Complexity of 2 (Highest = 28). +src/net/sf/freecol/client/gui/panel/MiniMap.java:52: The class 'MiniMap' has a Modified Cyclomatic Complexity of 2 (Highest = 25). +src/net/sf/freecol/client/gui/panel/MiniMap.java:52: The class 'MiniMap' has a Standard Cyclomatic Complexity of 2 (Highest = 25). +src/net/sf/freecol/client/gui/panel/MiniMap.java:52: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/MiniMap.java:55: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/MiniMap.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MiniMap.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MiniMap.java:63: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MiniMap.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MiniMap.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MiniMap.java:77: Avoid using redundant field initializer for 'adjustX' +src/net/sf/freecol/client/gui/panel/MiniMap.java:77: Avoid using redundant field initializer for 'adjustY' +src/net/sf/freecol/client/gui/panel/MiniMap.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MiniMap.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/MiniMap.java:85: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/MiniMap.java:85: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:121: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:133: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:133: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:144: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:144: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:149: Parameter 'tileSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:150: Local variable 'zoom' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:155: Parameter 'toggle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:155: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:156: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:160: Parameter 'toggle' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:160: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:171: Parameter 'graphics' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:181: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:185: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:194: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/MiniMap.java:194: Parameter 'graphics' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:194: The method 'paintMap' has a Cyclomatic Complexity of 28. +src/net/sf/freecol/client/gui/panel/MiniMap.java:194: The method 'paintMap' has a Modified Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/MiniMap.java:194: The method 'paintMap' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/MiniMap.java:194: The method paintMap() has an NCSS line count of 131 +src/net/sf/freecol/client/gui/panel/MiniMap.java:194: The method paintMap() has an NPath complexity of 604296 +src/net/sf/freecol/client/gui/panel/MiniMap.java:198: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/MiniMap.java:199: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/MiniMap.java:199: Found 'DU'-anomaly for variable 'originTransform' (lines '199'-'390'). +src/net/sf/freecol/client/gui/panel/MiniMap.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:216: Local variable 'xSize' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:217: Local variable 'ySize' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:243: Found 'DU'-anomaly for variable 'width' (lines '243'-'390'). +src/net/sf/freecol/client/gui/panel/MiniMap.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:251: Found 'DU'-anomaly for variable 'height' (lines '251'-'390'). +src/net/sf/freecol/client/gui/panel/MiniMap.java:251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:256: Local variable 'lastRow' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:257: Local variable 'lastColumn' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:258: Local variable 'tileWidth' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:259: Local variable 'tileHeight' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:260: Local variable 'halfWidth' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:261: Local variable 'halfHeight' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:265: Local variable 'tilePath' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:272: Local variable 'settlementPath' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:276: Local variable 'unitPath' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:280: Local variable 'paintFull' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:281: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:285: Local variable 'baseTransform' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:286: Found 'DD'-anomaly for variable 'rowTransform' (lines '286'-'293'). +src/net/sf/freecol/client/gui/panel/MiniMap.java:288: Found 'DU'-anomaly for variable 'library' (lines '288'-'390'). +src/net/sf/freecol/client/gui/panel/MiniMap.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:294: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/MiniMap.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:300: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:307: Local variable 'nationOwner' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:307: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:308: Local variable 'colorTransparent' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:309: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/MiniMap.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:311: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:314: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:314: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:315: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:317: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/MiniMap.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:318: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:323: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:327: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:329: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:332: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:334: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/MiniMap.java:334: Local variable 'blackTransparent' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:342: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:353: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:353: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:354: Local variable 'mapTileSize' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:355: Local variable 'miniRectWidth' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:355: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:356: Local variable 'miniRectHeight' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:356: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:368: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:372: Local variable 'miniRectMinWidth' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:373: Local variable 'miniRectMinHeight' could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:385: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:389: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/MiniMap.java:393: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/MiniMap.java:393: Avoid variables with short names like y +src/net/sf/freecol/client/gui/panel/MiniMap.java:393: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:393: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:394: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/MiniMap.java:396: Comment is too large: Line too long +src/net/sf/freecol/client/gui/panel/MiniMap.java:399: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:399: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:400: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:400: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:402: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:402: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:403: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:403: Useless parentheses. +src/net/sf/freecol/client/gui/panel/MiniMap.java:406: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:406: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:406: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:406: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:409: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:409: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/MiniMap.java:416: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:416: Document empty method +src/net/sf/freecol/client/gui/panel/MiniMap.java:416: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:416: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:425: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:425: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:430: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:430: Document empty method +src/net/sf/freecol/client/gui/panel/MiniMap.java:430: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:430: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:434: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:434: Document empty method +src/net/sf/freecol/client/gui/panel/MiniMap.java:434: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:434: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:438: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:438: Document empty method +src/net/sf/freecol/client/gui/panel/MiniMap.java:438: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:438: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:442: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:442: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:442: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/MiniMap.java:447: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/MiniMap.java:447: Document empty method +src/net/sf/freecol/client/gui/panel/MiniMap.java:447: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MiniMap.java:447: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:36: Avoid unused imports such as 'net.sf.freecol.common.model.Scope' +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:40: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:40: The class 'ModifierFormat' has a Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:43: It is somewhat confusing to have a field name matching the declaring class name +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:43: Variables that are final and static should be all capitals, 'modifierFormat' is not all capitals. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:51: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:51: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:57: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:57: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:61: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:61: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:62: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:63: Local variable 'bonus' could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:65: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:67: Found 'DD'-anomaly for variable 'result' (lines '67'-'73'). +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:67: Found 'DD'-anomaly for variable 'result' (lines '67'-'76'). +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:67: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:67: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:68: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:84: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:84: The method 'getSourceName' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:85: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:85: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:90: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:90: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:94: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:94: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:96: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:100: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:101: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:102: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:105: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:107: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:108: Local variable 'bonus' could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:109: Found 'DD'-anomaly for variable 'result' (lines '109'-'110'). +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:110: Found 'DD'-anomaly for variable 'result' (lines '110'-'111'). +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:111: Found 'DD'-anomaly for variable 'result' (lines '111'-'112'). +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:112: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:116: Parameter 'feature' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:116: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:117: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:118: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:118: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:118: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:120: Avoid variables with short names like k +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:125: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:125: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:131: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:131: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ModifierFormat.java:133: Avoid variables with short names like s +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:51: The class 'MonarchDialog' has a Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:53: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:62: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:62: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:63: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:63: Parameter 'monarchKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:63: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:66: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:73: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:73: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:75: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:81: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:84: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:89: Local variable 'helpButton' could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:90: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:95: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:101: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/MonarchDialog.java:101: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:53: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:54: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:65: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:66: Local variable 'nations' could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:76: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:76: Found 'UR'-anomaly for variable 'player' (lines '76'-'82'). +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:76: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:76: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:77: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:79: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:80: Found 'DD'-anomaly for variable 'currentNationType' (lines '80'-'83'). +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:81: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:82: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:90: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:93: Local variable 'artLabel' could be declared final +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationDetailPanel.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:65: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:66: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:77: Found 'UR'-anomaly for variable 'type' (lines '77'-'88'). +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:77: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:78: Local variable 'parent' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:82: Local variable 'nations' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:84: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:84: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:86: Found 'DU'-anomaly for variable 'icon' (lines '86'-'91'). +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:86: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:87: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:97: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:97: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:97: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:98: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:100: Local variable 'nationType' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:115: Found 'UR'-anomaly for variable 'ability' (lines '115'-'152'). +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:115: Found 'UR'-anomaly for variable 'modifier' (lines '115'-'161'). +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:115: Parameter 'nationType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:116: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:117: Local variable 'boldFont' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:120: Local variable 'abilities' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:121: Local variable 'modifiers' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:132: Local variable 'startingUnits' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:135: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:151: Local variable 'ability' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:160: Local variable 'modifier' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:172: Found 'UR'-anomaly for variable 'choice' (lines '172'-'207'). +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:172: Found 'UR'-anomaly for variable 'regionName' (lines '172'-'196'). +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:172: Parameter 'nationType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:173: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:174: Local variable 'skills' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:178: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:186: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:186: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:194: Local variable 'regionNames' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:195: Local variable 'regionName' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:202: Local variable 'gridLayout' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:204: Local variable 'unitPanel' could be declared final +src/net/sf/freecol/client/gui/panel/NationTypeDetailPanel.java:206: Local variable 'choice' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:20: Possible God class (WMC=150, ATFD=128, TCC=0.1503267973856209) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:80: Avoid really long classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:80: The class 'NegotiationDialog' has a Cyclomatic Complexity of 5 (Highest = 29). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:80: The class 'NegotiationDialog' has a Modified Cyclomatic Complexity of 4 (Highest = 25). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:80: The class 'NegotiationDialog' has a Standard Cyclomatic Complexity of 5 (Highest = 28). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:80: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:82: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:82: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:84: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:86: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:87: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:90: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:91: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:91: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:93: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:93: Parameter 'item' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:93: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:103: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:103: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:109: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:112: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:112: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:113: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:113: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:114: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:114: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:115: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:115: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:116: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:116: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:117: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:117: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:125: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:125: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:128: The String literal "negotiationDialog.clear" appears 6 times in this file; the first occurrence is on line 128 +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:131: The String literal "negotiationDialog.add" appears 6 times in this file; the first occurrence is on line 131 +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:137: The String literal "wrap 1" appears 7 times in this file; the first occurrence is on line 137 +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:142: The String literal "split 2" appears 6 times in this file; the first occurrence is on line 142 +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:154: Avoid variables with short names like dt +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:154: Found 'UR'-anomaly for variable 'al' (lines '154'-'161'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:154: Found 'UR'-anomaly for variable 'c' (lines '154'-'166'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:154: Found 'UR'-anomaly for variable 'c' (lines '154'-'176'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:154: Parameter 'dt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:155: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:159: Local variable 'listeners' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:160: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:164: Local variable 'available' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:165: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:176: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:176: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:178: Local variable 'enable' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:184: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:196: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:196: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:198: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:204: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:204: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:208: The String literal "Bad command: " appears 6 times in this file; the first occurrence is on line 208 +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:208: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:214: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:217: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:217: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:218: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:218: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:227: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:227: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:227: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:230: Local variable 'clearButton' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:233: Local variable 'addButton' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:260: Avoid variables with short names like dt +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:260: Parameter 'dt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:261: Local variable 'gold' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:263: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:276: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:276: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:278: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:280: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:284: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:284: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:288: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:294: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:297: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:297: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:304: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:305: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:305: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:305: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:306: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:313: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:313: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:313: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:314: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:314: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:314: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:315: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:315: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:315: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:316: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:316: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:316: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:317: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:317: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:317: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:318: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:318: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:318: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:328: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:328: Parameter 'allGoods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:328: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:358: Avoid variables with short names like dt +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:358: Found 'UR'-anomaly for variable 'al' (lines '358'-'363'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:358: Found 'UR'-anomaly for variable 'g' (lines '358'-'383'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:358: Found 'UR'-anomaly for variable 'goods' (lines '358'-'371'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:358: Parameter 'dt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:361: Local variable 'listeners' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:362: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:366: Local variable 'available' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:367: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:370: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:370: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:383: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:383: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:385: Local variable 'enable' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:391: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:403: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:403: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:405: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:407: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:407: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:411: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:411: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:415: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:421: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:424: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:424: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:431: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:432: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:432: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:432: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:433: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:440: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:440: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:440: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:441: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:441: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:441: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:442: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:442: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:442: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:443: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:443: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:443: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:444: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:444: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:444: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:445: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:445: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:445: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:446: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:446: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:446: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:455: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:455: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:455: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:472: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:473: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:493: Avoid variables with short names like dt +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:493: Found 'UR'-anomaly for variable 'al' (lines '493'-'498'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:493: Found 'UR'-anomaly for variable 'p' (lines '493'-'502'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:493: Parameter 'dt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:496: Local variable 'listeners' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:497: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:502: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:502: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:504: Local variable 'enable' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:510: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:522: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:522: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:524: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:526: Local variable 'victim' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:536: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:549: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:549: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:556: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:557: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:557: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:557: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:558: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:564: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:564: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:564: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:565: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:565: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:565: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:566: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:566: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:566: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:567: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:567: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:567: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:568: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:568: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:568: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:577: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:577: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:577: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:604: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:617: Avoid variables with short names like dt +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:617: Parameter 'dt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:620: Local variable 'stance' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:621: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:633: Local variable 'select' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:634: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:644: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:644: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:646: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:648: Local variable 'stance' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:652: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:652: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:656: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:662: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:665: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:665: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:672: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:673: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:673: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:673: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:674: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:680: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:680: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:680: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:681: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:681: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:681: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:682: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:682: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:682: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:683: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:683: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:683: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:684: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:684: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:684: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:685: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:685: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:685: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:695: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:695: Parameter 'allUnits' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:695: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:725: Avoid variables with short names like dt +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:725: Found 'UR'-anomaly for variable 'al' (lines '725'-'730'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:725: Found 'UR'-anomaly for variable 'u' (lines '725'-'736'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:725: Found 'UR'-anomaly for variable 'u' (lines '725'-'744'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:725: Parameter 'dt' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:728: Local variable 'listeners' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:729: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:733: Local variable 'available' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:734: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:744: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:744: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:746: Local variable 'enable' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:752: Local variable 'al' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:764: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:764: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:766: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:768: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:768: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:772: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:772: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:776: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:784: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:784: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:787: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:787: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:790: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:790: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:793: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:793: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:794: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:794: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:794: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:794: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:795: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:795: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:795: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:795: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:796: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:796: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:796: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:796: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:797: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:797: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:797: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:797: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:798: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:798: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:798: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:798: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:801: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:801: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:804: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:804: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:804: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:805: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:805: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:805: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:808: Avoid using redundant field initializer for 'accept' +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:808: Avoid using redundant field initializer for 'send' +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:808: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:808: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:808: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:808: Private field 'send' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:811: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:823: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:823: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:823: The constructor 'NegotiationDialog' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:823: The constructor 'NegotiationDialog' has a Modified Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:823: The constructor 'NegotiationDialog' has a Standard Cyclomatic Complexity of 28. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:823: The constructor with 6 parameters has an NCSS line count of 121 +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:824: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:824: Parameter 'our' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:825: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:825: Parameter 'comment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:829: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:829: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:829: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:830: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:830: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:830: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:831: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:831: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:831: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:832: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:832: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:833: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:839: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:839: Local variable 'otherNation' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:849: Avoid variables with short names like ns +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:849: Local variable 'ns' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:850: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:850: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:860: Local variable 'context' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:880: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:882: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:882: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:885: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:886: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:888: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:899: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:921: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:929: Avoid excessively long variable names like labelDemandMessage +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:929: Local variable 'labelDemandMessage' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:930: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:935: Local variable 'blank' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:938: Local variable 'labelOfferMessage' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:945: Local variable 'centerPanel' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:950: Local variable 'tutArea' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:981: Local variable 'bogus' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:983: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:983: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:996: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:996: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1008: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1009: Avoid variables with short names like s +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1009: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1017: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1026: Avoid variables with short names like gl +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1026: Found 'UR'-anomaly for variable 'type' (lines '1,026'-'1,029'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1026: Parameter 'gl' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1027: Local variable 'goodsList' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1028: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1028: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1029: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1029: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1029: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1043: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1044: Avoid variables with short names like ul +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1044: Local variable 'ul' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1049: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1049: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1060: The method 'updateDialog' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1060: The method 'updateDialog' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1060: The method 'updateDialog' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1060: The method updateDialog() has an NPath complexity of 1024 +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1101: Parameter 'item' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1102: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1115: Found 'UR'-anomaly for variable 'item' (lines '1,115'-'1,126'). +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1122: Local variable 'offers' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1125: Local variable 'item' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1130: Local variable 'demands' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1137: Local variable 'item' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1149: Parameter 'itemClass' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1160: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1160: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1163: Local variable 'destination' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1163: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1175: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1175: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1178: Local variable 'destination' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1178: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1190: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1190: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1193: Local variable 'destination' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1193: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1204: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1204: Parameter 'victim' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1207: Local variable 'destination' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1207: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1218: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1232: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1232: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1235: Local variable 'destination' could be declared final +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1235: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1253: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1259: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NegotiationDialog.java:1261: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NewPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/NewPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/NewPanel.java:20: Possible God class (WMC=58, ATFD=40, TCC=0.0) +src/net/sf/freecol/client/gui/panel/NewPanel.java:62: The class 'NewPanel' has a Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/client/gui/panel/NewPanel.java:62: The class 'NewPanel' has a Standard Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/client/gui/panel/NewPanel.java:62: Too many fields +src/net/sf/freecol/client/gui/panel/NewPanel.java:65: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/NewPanel.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/NewPanel.java:84: Avoid excessively long variable names like fixedSpecification +src/net/sf/freecol/client/gui/panel/NewPanel.java:84: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:89: Avoid using redundant field initializer for 'specification' +src/net/sf/freecol/client/gui/panel/NewPanel.java:89: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:97: Avoid using redundant field initializer for 'difficulty' +src/net/sf/freecol/client/gui/panel/NewPanel.java:97: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:100: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:103: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:106: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:106: Perhaps 'advantagesLabel' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/NewPanel.java:109: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:112: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:112: Perhaps 'serverPortLabel' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/NewPanel.java:115: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:118: Perhaps 'rulesLabel' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/NewPanel.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:124: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:127: Perhaps 'difficultyLabel' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/NewPanel.java:130: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:133: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:136: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:136: Perhaps 'joinNameLabel' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/NewPanel.java:139: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:142: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:142: Perhaps 'joinPortLabel' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/NewPanel.java:145: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:148: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:151: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:154: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/NewPanel.java:162: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:173: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:173: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:180: Local variable 'join' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:180: Local variable 'meta' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:180: Local variable 'single' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:180: Local variable 'start' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:204: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:220: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NewPanel.java:227: Local variable 'selectTC' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:228: Local variable 'tc' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:235: Local variable 'selectTC' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:236: Local variable 'tc' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:264: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NewPanel.java:270: Local variable 'cancel' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:277: The String literal "newline, span 3" appears 4 times in this file; the first occurrence is on line 277 +src/net/sf/freecol/client/gui/panel/NewPanel.java:280: The String literal "growx" appears 4 times in this file; the first occurrence is on line 280 +src/net/sf/freecol/client/gui/panel/NewPanel.java:314: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/NewPanel.java:325: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:325: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:332: Local variable 'oldId' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:343: Found 'UR'-anomaly for variable 'og' (lines '343'-'347'). +src/net/sf/freecol/client/gui/panel/NewPanel.java:346: Local variable 'og' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:353: Local variable 'index' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:370: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:370: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:370: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:370: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NewPanel.java:370: Useless parentheses. +src/net/sf/freecol/client/gui/panel/NewPanel.java:420: Parameter 'field' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:423: Found 'DD'-anomaly for variable 'port' (lines '423'-'425'). +src/net/sf/freecol/client/gui/panel/NewPanel.java:427: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/NewPanel.java:427: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:436: Local variable 'action' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:442: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:447: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:448: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:452: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:459: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:474: Found 'UR'-anomaly for variable 'c' (lines '474'-'476'). +src/net/sf/freecol/client/gui/panel/NewPanel.java:474: Parameter 'components' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:474: Parameter 'enable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:475: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:491: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/NewPanel.java:491: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:502: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/NewPanel.java:502: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:502: The method 'actionPerformed' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/NewPanel.java:502: The method 'actionPerformed' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/NewPanel.java:503: Avoid variables with short names like cc +src/net/sf/freecol/client/gui/panel/NewPanel.java:503: Found 'DU'-anomaly for variable 'cc' (lines '503'-'559'). +src/net/sf/freecol/client/gui/panel/NewPanel.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:504: Found 'DU'-anomaly for variable 'gui' (lines '504'-'559'). +src/net/sf/freecol/client/gui/panel/NewPanel.java:511: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:511: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:513: Local variable 'action' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:514: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:519: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/NewPanel.java:519: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:519: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:519: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:522: Local variable 'joinPort' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:522: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:523: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:524: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:525: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/NewPanel.java:528: Local variable 'serverPort' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:529: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:532: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:532: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:532: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:536: Local variable 'servers' could be declared final +src/net/sf/freecol/client/gui/panel/NewPanel.java:536: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:537: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/NewPanel.java:537: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:548: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/NewPanel.java:548: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/NewPanel.java:568: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/NewPanel.java:568: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:45: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:47: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:47: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:51: Avoid variables with short names like ui +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:66: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:66: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:67: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:67: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:68: Parameter 'defaultFileName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:68: Parameter 'headerKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:68: Parameter 'optionGroupId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:128: Avoid variables with short names like ui +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:128: Parameter 'headerKey' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:128: Parameter 'ui' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:148: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:153: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:153: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:165: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:181: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:182: Avoid variables with short names like og +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:182: Local variable 'og' could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:184: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:184: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:196: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:197: Avoid variables with short names like og +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:197: Local variable 'og' could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:198: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:198: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:209: Avoid variables with short names like f +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:209: Local variable 'f' could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:210: Useless parentheses. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:210: Useless parentheses. +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:219: Avoid variables with short names like f +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:219: Local variable 'f' could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:231: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/OptionsDialog.java:235: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Parameters.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Parameters.java:24: Avoid excessively long variable names like distToLandFromHighSeas +src/net/sf/freecol/client/gui/panel/Parameters.java:24: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/Parameters.java:24: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Parameters.java:26: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/Parameters.java:26: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Parameters.java:29: Avoid excessively long variable names like distToLandFromHighSeas +src/net/sf/freecol/client/gui/panel/Parameters.java:29: Parameter 'distToLandFromHighSeas' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Parameters.java:29: Parameter 'maxDistanceToEdge' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:46: Avoid excessively long variable names like DEFAULT_distToLandFromHighSeas +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:46: Variables that are final and static should be all capitals, 'DEFAULT_distToLandFromHighSeas' is not all capitals. +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:48: Avoid excessively long variable names like DEFAULT_maxDistanceToEdge +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:48: Variables that are final and static should be all capitals, 'DEFAULT_maxDistanceToEdge' is not all capitals. +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:61: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:61: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:71: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:72: Local variable 'widthPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:73: Local variable 'heightPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:82: Local variable 'widthLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:85: Local variable 'heightLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:99: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:99: Avoid variables with short names like al +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:105: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:106: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:106: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:119: Avoid variables with short names like d +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:119: Local variable 'd' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:120: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:125: Avoid variables with short names like m +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:125: Local variable 'm' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:126: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:137: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ParametersDialog.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/PlayersTable.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:20: Possible God class (WMC=75, ATFD=93, TCC=0.10476190476190476) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:78: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:78: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:85: Parameter 'box' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:96: Parameter 'nationTypes' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:97: This call to Collection.toArray() may be optimizable +src/net/sf/freecol/client/gui/panel/PlayersTable.java:111: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:115: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:119: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:127: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/PlayersTable.java:127: Parameter 'advantages' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:138: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:139: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:139: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:139: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:140: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:140: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:143: Found 'DU'-anomaly for variable 'nationType' (lines '143'-'166'). +src/net/sf/freecol/client/gui/panel/PlayersTable.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:148: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:159: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:159: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:169: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:172: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:172: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:179: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/PlayersTable.java:190: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:191: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:191: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:191: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:192: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:192: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:201: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:204: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:204: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:209: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:209: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:211: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:211: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:213: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/PlayersTable.java:213: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:213: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:218: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/PlayersTable.java:218: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:232: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:233: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:233: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:233: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:233: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:234: Local variable 'nationType' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:234: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:236: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:236: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:243: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:248: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:250: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:250: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:252: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:252: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:255: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/PlayersTable.java:255: Parameter 'header' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:255: Parameter 'renderer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:255: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:261: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/PlayersTable.java:261: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:261: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:262: Local variable 'col' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:268: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/PlayersTable.java:268: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:268: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:274: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:276: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:277: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:277: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:278: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:278: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:280: Parameter 'components' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:280: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:291: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:292: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:292: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:292: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:293: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:293: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:295: Local variable 'isPressed' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:295: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:295: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:296: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:296: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:296: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:297: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:297: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:297: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:302: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:302: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:307: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/PlayersTable.java:307: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:316: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:317: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:317: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:317: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:318: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:318: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:319: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:320: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:320: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:320: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:328: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:337: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:338: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:339: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:340: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:341: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:347: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:349: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:349: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:350: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:350: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:353: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:365: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:366: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:366: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:366: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:367: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:367: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:368: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:370: Local variable 'nationType' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:373: Local variable 'nationState' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:376: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:379: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:380: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:388: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:391: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:391: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:394: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/PlayersTable.java:394: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:395: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/PlayersTable.java:405: Parameter 'table' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:406: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:406: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:406: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:406: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:411: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:419: The class 'PlayersTableModel' has a Cyclomatic Complexity of 5 (Highest = 11). +src/net/sf/freecol/client/gui/panel/PlayersTable.java:421: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:421: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:423: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:423: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:425: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:425: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:427: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:427: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:429: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:429: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:440: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/PlayersTable.java:440: Parameter 'preGameController' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:441: Parameter 'nationOptions' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:442: Parameter 'thisPlayer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:448: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:449: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/PlayersTable.java:450: Local variable 'state' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:459: Found 'UR'-anomaly for variable 'nation' (lines '459'-'461'). +src/net/sf/freecol/client/gui/panel/PlayersTable.java:459: Found 'UR'-anomaly for variable 'player' (lines '459'-'464'). +src/net/sf/freecol/client/gui/panel/PlayersTable.java:459: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:460: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:463: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:463: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:476: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:477: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/PlayersTable.java:479: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:481: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:483: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:485: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:487: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:509: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:531: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:531: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:531: The method 'getValueAt' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:534: Found 'DU'-anomaly for variable 'nation' (lines '534'-'550'). +src/net/sf/freecol/client/gui/panel/PlayersTable.java:534: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:535: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/PlayersTable.java:537: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:539: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:541: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:541: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:542: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:544: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:546: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:560: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:560: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:562: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:563: Found 'DU'-anomaly for variable 'ownRow' (lines '563'-'584'). +src/net/sf/freecol/client/gui/panel/PlayersTable.java:563: Local variable 'ownRow' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:565: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/PlayersTable.java:567: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:569: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:577: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:577: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:579: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PlayersTable.java:579: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:594: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:594: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:594: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:594: The method 'setValueAt' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:598: Found 'DU'-anomaly for variable 'nation' (lines '598'-'624'). +src/net/sf/freecol/client/gui/panel/PlayersTable.java:598: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:615: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PlayersTable.java:628: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:628: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:629: Avoid excessively long variable names like AVAILABILITY_COLUMN +src/net/sf/freecol/client/gui/panel/PlayersTable.java:634: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:634: Variables that are final and static should be all capitals, 'columnNames' is not all capitals. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:634: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:643: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:643: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:654: Parameter 'myPlayer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:654: Parameter 'nationOptions' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:664: Local variable 'nationButton' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:665: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/PlayersTable.java:669: Local variable 'availabilityLabel' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:670: Local variable 'advantageButton' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:671: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/PlayersTable.java:675: Local variable 'colorLabel' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:676: Local variable 'playerLabel' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:678: Local variable 'dtcr' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:681: Local variable 'renderer' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:683: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:688: Local variable 'nationColumn' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:694: Local variable 'availableColumn' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:698: Local variable 'advantagesColumn' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:701: Avoid instantiation through private constructors from outside of the constructors class. +src/net/sf/freecol/client/gui/panel/PlayersTable.java:715: Local variable 'colorsColumn' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:719: Local variable 'playerColumn' could be declared final +src/net/sf/freecol/client/gui/panel/PlayersTable.java:724: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PlayersTable.java:725: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PortPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/PortPanel.java:40: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/PortPanel.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PortPanel.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PortPanel.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PortPanel.java:43: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PortPanel.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PortPanel.java:45: Avoid excessively long variable names like defaultTransferHandler +src/net/sf/freecol/client/gui/panel/PortPanel.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PortPanel.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PortPanel.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/PortPanel.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/PortPanel.java:55: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PortPanel.java:55: Parameter 'layout' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PortPanel.java:58: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PortPanel.java:77: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PortPanel.java:87: Found 'UR'-anomaly for variable 'component' (lines '87'-'89'). +src/net/sf/freecol/client/gui/panel/PortPanel.java:87: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PortPanel.java:88: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/PortPanel.java:90: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/PortPanel.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/PortPanel.java:93: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/PortPanel.java:114: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PortPanel.java:156: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PortPanel.java:157: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PortPanel.java:158: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PortPanel.java:159: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PortPanel.java:160: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:55: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:64: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:64: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:65: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:65: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:71: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:81: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:81: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:86: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:86: Local variable 'attackerName' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:88: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:88: Local variable 'attackerLabel' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:93: Local variable 'defenderUnit' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:100: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:109: The String literal "span 3, align center" appears 4 times in this file; the first occurrence is on line 109 +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:118: Local variable 'offenceI' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:119: Local variable 'defenceI' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:122: Local variable 'hasOffence' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:124: Local variable 'labels' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:131: Local variable 'labels' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:137: Local variable 'bigFont' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:139: Local variable 'offenceResult' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:141: Local variable 'finalOffenceLabel' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:147: Avoid excessively long variable names like finalOffenceResult +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:147: Local variable 'finalOffenceResult' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:152: Local variable 'defenceResult' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:154: Local variable 'finalDefenceLabel' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:157: Avoid excessively long variable names like finalDefenceResult +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:157: Local variable 'finalDefenceResult' could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:166: Parameter 'labels' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:166: Parameter 'newline' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:166: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:167: Parameter 'skip' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:169: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:169: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:171: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:171: Found 'DU'-anomaly for variable 'constraint' (lines '171'-'188'). +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:171: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:171: Useless parentheses. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:174: Found 'DU'-anomaly for variable 'constraint' (lines '174'-'188'). +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:176: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:180: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:182: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:182: Found 'DU'-anomaly for variable 'constraint' (lines '182'-'188'). +src/net/sf/freecol/client/gui/panel/PreCombatDialog.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:47: The class 'ProductionLabel' has a Cyclomatic Complexity of 6 (Highest = 18). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:47: The class 'ProductionLabel' has a Modified Cyclomatic Complexity of 5 (Highest = 12). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:47: The class 'ProductionLabel' has a Standard Cyclomatic Complexity of 5 (Highest = 12). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:55: Avoid using redundant field initializer for 'drawPlus' +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:58: Private field 'centered' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:67: Avoid unused private fields such as 'maximumProduction'. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:67: Perhaps 'maximumProduction' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:70: Perhaps 'displayNumber' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:76: Avoid unused private fields such as 'stockNumber'. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:76: Perhaps 'stockNumber' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:79: Avoid using redundant field initializer for 'stringImage' +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:88: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:88: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:88: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:99: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:99: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:99: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:100: Parameter 'maximumProduction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:112: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:112: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:112: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:113: Parameter 'maximumProduction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:113: Parameter 'stockNumber' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:125: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:125: Parameter 'lib' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:126: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:126: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:130: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:139: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:139: Parameter 'lib' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:139: The constructor 'ProductionLabel' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:139: The constructor 'ProductionLabel' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:139: The constructor 'ProductionLabel' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:140: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:140: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:141: Parameter 'maximumProduction' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:141: Parameter 'stockNumber' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:145: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:148: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:164: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:171: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:171: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:172: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:172: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:172: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:176: Local variable 'showMax' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:184: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:184: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:185: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:186: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:186: No need to call String.valueOf to append to a string. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:186: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:188: Local variable 'dummy' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:190: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:190: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:195: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:206: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:206: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:206: The method 'paintComponent' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:206: The method 'paintComponent' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:206: The method 'paintComponent' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:206: The method paintComponent() has an NPath complexity of 6240 +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:207: Local variable 'stringWidth' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:210: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:211: Local variable 'iconWidth' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:216: Local variable 'maxSpacing' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:220: Local variable 'iconsTooFarApart' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:221: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:222: Local variable 'coverage' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:223: Found 'DD'-anomaly for variable 'leftOffset' (lines '223'-'225'). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:223: Found 'DU'-anomaly for variable 'leftOffset' (lines '223'-'243'). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:224: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:225: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:225: Found 'DU'-anomaly for variable 'leftOffset' (lines '225'-'243'). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:226: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:236: Found 'DD'-anomaly for variable 'textOffset' (lines '236'-'238'). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:236: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:236: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:238: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:238: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:253: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:253: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:255: Local variable 'drawImageCount' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:257: Local variable 'iconWidth' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:262: Local variable 'maxSpacing' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:266: Local variable 'iconsTooFarApart' could be declared final +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:267: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:268: Found 'DD'-anomaly for variable 'width' (lines '268'-'270'). +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:270: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:270: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ProductionLabel.java:272: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/PurchasePanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/PurchasePanel.java:38: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:20: Possible God class (WMC=155, ATFD=214, TCC=0.015789473684210527) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:80: The class 'QuickActionMenu' has a Cyclomatic Complexity of 7 (Highest = 28). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:80: The class 'QuickActionMenu' has a Modified Cyclomatic Complexity of 6 (Highest = 22). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:80: The class 'QuickActionMenu' has a Standard Cyclomatic Complexity of 6 (Highest = 24). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:80: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:82: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:82: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:82: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:84: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:84: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:86: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:86: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:88: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:97: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:97: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:98: Parameter 'freeColPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:111: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:136: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:136: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:137: Local variable 'ret' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:140: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:147: The method 'createUnitMenu' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:147: The method 'createUnitMenu' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:147: The method 'createUnitMenu' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:147: The method createUnitMenu() has an NPath complexity of 330 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:151: Local variable 'unitIcon' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:152: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:154: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:159: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:162: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:167: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:168: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:169: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:170: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:171: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:173: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:174: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:180: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:186: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:191: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:191: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:195: Found 'UR'-anomaly for variable 'unit' (lines '195'-'202'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:195: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:196: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:196: Found 'DU'-anomaly for variable 'igc' (lines '196'-'217'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:199: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:199: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:200: Found 'DD'-anomaly for variable 'added' (lines '200'-'213'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:205: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:206: The String literal "%unit%" appears 5 times in this file; the first occurrence is on line 206 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:208: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:209: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:213: Found 'DD'-anomaly for variable 'added' (lines '213'-'213'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:219: Found 'UR'-anomaly for variable 'unit' (lines '219'-'224'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:219: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:220: Found 'DU'-anomaly for variable 'igc' (lines '220'-'241'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:222: Found 'DD'-anomaly for variable 'added' (lines '222'-'237'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:226: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:229: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:230: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:237: Found 'DD'-anomaly for variable 'added' (lines '237'-'237'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:243: Found 'UR'-anomaly for variable 'goods' (lines '243'-'257'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:243: Found 'UR'-anomaly for variable 'passenger' (lines '243'-'251'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:245: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:245: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:247: Local variable 'cargo' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:250: Local variable 'passenger' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:251: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:251: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:256: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:257: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:257: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:266: Local variable 'ret' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:269: Avoid variables with short names like m1 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:269: Avoid variables with short names like m2 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:269: Parameter 'm1' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:269: Parameter 'm2' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:269: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:270: Avoid variables with short names like i1 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:270: Local variable 'i1' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:271: Avoid variables with short names like i2 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:271: Local variable 'i2' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:273: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:280: Avoid variables with short names like wl +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:280: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:280: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:281: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:281: Parameter 'unitLabel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:282: Parameter 'claim' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:283: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:283: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:286: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:292: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:293: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:301: Found 'UR'-anomaly for variable 'j' (lines '301'-'374'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:301: Found 'UR'-anomaly for variable 'type' (lines '301'-'326'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:301: Found 'UR'-anomaly for variable 'wl' (lines '301'-'324'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:301: The method 'addWorkItems' has a Cyclomatic Complexity of 28. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:301: The method 'addWorkItems' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:301: The method 'addWorkItems' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:301: The method addWorkItems() has an NPath complexity of 1156800 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:303: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:303: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:307: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:308: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:310: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:311: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:311: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:314: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:314: Local variable 'items' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:315: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:315: Local variable 'extras' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:316: Found 'DD'-anomaly for variable 'expertOwned' (lines '316'-'354'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:317: Found 'DD'-anomaly for variable 'expertUnowned' (lines '317'-'364'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:318: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:321: Found 'DD'-anomaly for variable 'bestOwned' (lines '321'-'329'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:321: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:322: Local variable 'wl' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:323: Found 'DD'-anomaly for variable 'prod' (lines '323'-'326'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:336: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:351: Avoid variables with short names like ji +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:351: Local variable 'ji' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:353: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:354: Found 'DD'-anomaly for variable 'expertOwned' (lines '354'-'354'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:356: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:361: Avoid variables with short names like ji +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:361: Local variable 'ji' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:363: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:364: Found 'DD'-anomaly for variable 'expertUnowned' (lines '364'-'364'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:366: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:371: Local variable 'container' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:372: Local variable 'owned' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:373: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:373: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:374: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:374: Local variable 'j' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:375: Local variable 'unowned' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:376: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:376: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:377: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:378: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:379: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:379: Local variable 'j' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:381: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:381: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:384: Avoid variables with short names like ji +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:384: Local variable 'ji' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:385: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:385: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:393: Found 'UR'-anomaly for variable 'teacher' (lines '393'-'400'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:393: The method 'addEducationItems' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:394: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '394'-'426'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:394: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '394'-'440'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:394: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '394'-'469'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:395: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:397: Found 'DU'-anomaly for variable 'lib' (lines '397'-'473'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:397: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:398: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:399: Local variable 'teacher' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:399: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:401: Found 'DD'-anomaly for variable 'menuItem' (lines '401'-'404'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:401: Found 'DD'-anomaly for variable 'menuItem' (lines '401'-'415'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:402: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:402: Local variable 'teacherIcon' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:403: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:413: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:415: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:415: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:421: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:426: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '426'-'426'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:426: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '426'-'440'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:426: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '426'-'469'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:430: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:431: Local variable 'student' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:431: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:432: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:432: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:432: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:434: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:437: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:438: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:440: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '440'-'469'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:442: Local variable 'experience' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:442: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:443: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:445: Local variable 'expertType' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:445: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:445: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:447: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:447: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:448: Local variable 'maxExperience' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:448: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:449: Local variable 'probability' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:449: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:451: Local variable 'jobName' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:451: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:452: Local variable 'experiencePanel' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:455: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:457: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:457: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:457: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:460: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:465: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:477: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:480: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:480: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:480: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:481: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:487: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:492: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:492: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:493: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:494: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:494: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:494: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:494: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:496: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:500: Local variable 'unitState' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:500: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:502: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:502: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:503: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:504: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:508: Local variable 'hasTradeRoute' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:508: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:510: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:510: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:511: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:512: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:517: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:519: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:519: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:520: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:527: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:527: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:527: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:527: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:531: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:535: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:537: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:537: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:538: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:539: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:545: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:547: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:547: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:564: Avoid variables with short names like to +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:575: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:576: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:576: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:582: Found 'DD'-anomaly for variable 'change' (lines '582'-'589'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:582: Found 'DD'-anomaly for variable 'change' (lines '582'-'592'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:583: Local variable 'need' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:589: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:592: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:595: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:595: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:596: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:598: Local variable 'item' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:600: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:600: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:600: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:601: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:611: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:620: Found 'UR'-anomaly for variable 'r' (lines '620'-'630'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:620: The method 'addRoleItems' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:620: The method 'addRoleItems' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:620: The method 'addRoleItems' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:620: The method addRoleItems() has an NPath complexity of 1750 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:622: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:622: Found 'DU'-anomaly for variable 'role' (lines '622'-'670'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:622: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:623: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:623: Found 'DU'-anomaly for variable 'roleCount' (lines '623'-'670'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:624: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:624: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '624'-'649'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:624: Found 'DU'-anomaly for variable 'separatorNeeded' (lines '624'-'670'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:626: Local variable 'uloc' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:626: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:626: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:626: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:626: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:626: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:626: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:628: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:628: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:629: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:630: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:630: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:632: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:635: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:635: Found 'DD'-anomaly for variable 'newItem' (lines '635'-'641'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:637: Local variable 'req' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:637: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:638: Local variable 'price' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:639: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:640: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:649: Found 'DD'-anomaly for variable 'separatorNeeded' (lines '649'-'649'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:653: Local variable 'newUnitType' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:653: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:654: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:656: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:657: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:659: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:660: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:660: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:661: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:663: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:664: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:665: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:676: The method 'createGoodsMenu' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:676: The method 'createGoodsMenu' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:676: The method 'createGoodsMenu' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:676: The method createGoodsMenu() has an NPath complexity of 400 +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:677: Found 'DU'-anomaly for variable 'igc' (lines '677'-'748'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:682: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:685: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:685: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:686: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:686: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:686: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:687: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:687: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:687: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:691: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:692: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:692: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:692: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:693: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:694: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:694: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:696: Local variable 'price' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:702: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:703: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:703: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:707: Local variable 'europe' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:709: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:709: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:710: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:713: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:714: Local variable 'carrier' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:714: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:716: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:716: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:717: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:717: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:717: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:717: Useless parentheses. +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:719: Local variable 'unload' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:720: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:720: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:724: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:728: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:729: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:729: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:730: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:733: Local variable 'dump' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:734: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:734: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:734: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:738: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:758: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:759: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:759: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:759: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:760: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:763: Local variable 'cargoPanel' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:764: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:777: Parameter 'marketLabel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:778: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:782: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:785: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:785: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:786: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:787: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:787: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:787: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:799: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:799: Found 'UR'-anomaly for variable 'unit' (lines '799'-'805'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:799: Parameter 'europe' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:800: Found 'DU'-anomaly for variable 'igc' (lines '800'-'822'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:801: Found 'DU'-anomaly for variable 'goods' (lines '801'-'822'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:803: Found 'DD'-anomaly for variable 'added' (lines '803'-'818'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:805: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:805: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:806: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:807: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:807: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:809: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:810: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:811: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:811: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:815: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:818: Found 'DD'-anomaly for variable 'added' (lines '818'-'818'). +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:830: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:843: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:844: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:844: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:846: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:858: Local variable 'menuItem' could be declared final +src/net/sf/freecol/client/gui/panel/QuickActionMenu.java:859: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:46: The class 'RebelToolTip' has a Cyclomatic Complexity of 8 (Highest = 14). +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:46: The class 'RebelToolTip' has a Modified Cyclomatic Complexity of 8 (Highest = 13). +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:46: The class 'RebelToolTip' has a Standard Cyclomatic Complexity of 8 (Highest = 13). +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:54: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:54: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:54: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:54: The constructor 'RebelToolTip' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:54: The constructor 'RebelToolTip' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:54: The constructor 'RebelToolTip' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:60: Avoid unused local variables such as 't'. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:60: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:60: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:82: Local variable 'modifiers' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:85: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:86: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:87: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:89: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:95: Local variable 'm' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:96: Local variable 'labels' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:97: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:97: Local variable 'j' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:100: Local variable 'capped' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:105: Local variable 'progress' could be declared final +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:108: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:108: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:133: Avoid variables with short names like na +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:135: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:135: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:136: The String literal "skip" appears 5 times in this file; the first occurrence is on line 136 +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:139: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:139: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:143: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RebelToolTip.java:143: Useless parentheses. +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:50: Avoid using redundant field initializer for 'shouldEnable' +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:58: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:63: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:76: Found 'UR'-anomaly for variable 'ut' (lines '76'-'101'). +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:82: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:82: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:83: Found 'DD'-anomaly for variable 'turns' (lines '83'-'87'). +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:85: Avoid excessively long variable names like immigrationRequired +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:85: Local variable 'immigrationRequired' could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:87: Found 'DD'-anomaly for variable 'turns' (lines '87'-'88'). +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:88: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:90: Local variable 'recruitPrice' could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:98: Avoid variables with short names like i +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:98: Found 'DU'-anomaly for variable 'i' (lines '98'-'114'). +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:99: Local variable 'ut' could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:100: Local variable 'enable' could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:102: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:106: Found 'DU'-anomaly for variable 'i' (lines '106'-'114'). +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:123: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:123: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:129: Local variable 'index' could be declared final +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:130: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:133: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:136: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:136: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/RecruitPanel.java:137: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:42: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:48: Document empty method +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:48: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:51: Found 'UR'-anomaly for variable 'unitType' (lines '51'-'58'). +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:51: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:53: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:57: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:57: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:60: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:60: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:69: Found 'UR'-anomaly for variable 'unit' (lines '69'-'71'). +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:69: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:70: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCargoPanel.java:70: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:53: The class 'ReportClassicColonyPanel' has a Cyclomatic Complexity of 8 (Highest = 15). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:53: The class 'ReportClassicColonyPanel' has a Modified Cyclomatic Complexity of 7 (Highest = 12). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:53: The class 'ReportClassicColonyPanel' has a Standard Cyclomatic Complexity of 7 (Highest = 12). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:61: Variables that are final and static should be all capitals, 'colonies' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:69: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: Found 'UR'-anomaly for variable 'building' (lines '76'-'158'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: Found 'UR'-anomaly for variable 'colony' (lines '76'-'86'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: Found 'UR'-anomaly for variable 'gt' (lines '76'-'132'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: Found 'UR'-anomaly for variable 'u' (lines '76'-'109'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: The method 'update' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: The method 'update' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: The method 'update' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:76: The method update() has an NPath complexity of 1081 +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:84: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:86: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:90: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:93: Local variable 'currentType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:94: Found 'DD'-anomaly for variable 'buildableLabel' (lines '94'-'96'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:96: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:104: Local variable 'colonistsPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:105: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:107: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:109: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:112: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:112: Local variable 'unitsPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:114: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:116: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:127: Local variable 'goodsTypes' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:128: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:130: Found 'DU'-anomaly for variable 'count' (lines '130'-'170'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:131: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:132: Local variable 'newValue' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:133: Local variable 'stockValue' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:135: Local variable 'maxProduction' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:136: Avoid variables with short names like wl +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:137: Local variable 'productionLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:138: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:147: Found 'DD'-anomaly for variable 'count' (lines '147'-'130'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:147: Found 'DU'-anomaly for variable 'count' (lines '147'-'170'). +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:152: Local variable 'buildingsPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:153: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:155: Local variable 'buildingList' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:157: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:158: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:159: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:159: Local variable 'buildingLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportClassicColonyPanel.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:20: Possible God class (WMC=186, ATFD=266, TCC=0.058333333333333334) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:78: Avoid really long classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:78: The class 'ReportCompactColonyPanel' has a Cyclomatic Complexity of 9 (Highest = 56). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:78: The class 'ReportCompactColonyPanel' has a Modified Cyclomatic Complexity of 8 (Highest = 44). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:78: The class 'ReportCompactColonyPanel' has a Standard Cyclomatic Complexity of 9 (Highest = 53). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:79: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:82: The class 'ColonySummary' has a Cyclomatic Complexity of 16 (Highest = 22). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:82: The class 'ColonySummary' has a Modified Cyclomatic Complexity of 14 (Highest = 19). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:82: The class 'ColonySummary' has a Standard Cyclomatic Complexity of 14 (Highest = 19). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:82: Too many fields +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:98: Avoid excessively long variable names like goodsProductionAccumulator +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:98: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:99: Avoid variables with short names like g1 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:99: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:99: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:99: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:101: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:101: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:114: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:114: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:115: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:115: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:116: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:116: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:118: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:118: Parameter 'status' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:118: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:119: Parameter 'extra' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:128: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:128: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:131: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:131: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:134: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:134: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:138: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:138: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:144: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:144: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:147: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:147: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:150: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:150: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:153: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:153: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:153: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:157: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:157: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:157: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:159: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:159: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:161: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:161: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:163: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:163: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:163: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:165: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:165: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:165: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:168: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:168: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:169: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:169: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:169: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:170: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:170: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:170: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:180: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:180: Parameter 'goodsTypes' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:180: The constructor 'ColonySummary' has a Cyclomatic Complexity of 22. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:180: The constructor 'ColonySummary' has a Modified Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:180: The constructor 'ColonySummary' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:183: Local variable 'school' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:185: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:185: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:189: Avoid unused local variables such as 'owner'. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:190: Avoid unused local variables such as 'foodType'. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:195: Local variable 'starve' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:208: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:208: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:210: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:226: Local variable 'wl' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:227: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:229: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:237: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:244: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:246: Avoid variables with short names like u +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:246: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:247: Avoid variables with short names like s +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:247: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:248: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:259: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:260: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:260: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:261: Avoid variables with short names like wl +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:261: Local variable 'wl' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:262: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:263: Avoid variables with short names like w +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:263: Local variable 'w' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:264: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:264: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:270: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:272: Local variable 'needed' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:274: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:274: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:274: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:283: Found 'UR'-anomaly for variable 'wl' (lines '283'-'306'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:283: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:283: The method 'produce' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:283: The method 'produce' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:283: The method 'produce' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:287: Found 'DU'-anomaly for variable 'low' (lines '287'-'345'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:287: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:288: Found 'DU'-anomaly for variable 'high' (lines '288'-'345'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:289: Found 'DU'-anomaly for variable 'amount' (lines '289'-'345'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:290: Avoid variables with short names like p +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:290: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:294: Found 'DD'-anomaly for variable 'extra' (lines '294'-'298'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:294: Found 'DD'-anomaly for variable 'extra' (lines '294'-'303'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:294: Found 'DD'-anomaly for variable 'extra' (lines '294'-'318'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:294: Found 'DD'-anomaly for variable 'extra' (lines '294'-'323'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:294: Found 'DD'-anomaly for variable 'extra' (lines '294'-'326'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:294: Found 'DD'-anomaly for variable 'extra' (lines '294'-'329'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:296: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:302: Found 'DD'-anomaly for variable 'status' (lines '302'-'311'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:303: Found 'DD'-anomaly for variable 'extra' (lines '303'-'312'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:304: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:304: Found 'DD'-anomaly for variable 'deficit' (lines '304'-'308'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:304: Found 'DU'-anomaly for variable 'deficit' (lines '304'-'345'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:305: Local variable 'wl' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:306: Avoid variables with short names like pi +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:306: Local variable 'pi' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:307: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:311: Found 'DD'-anomaly for variable 'status' (lines '311'-'317'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:311: Found 'DD'-anomaly for variable 'status' (lines '311'-'320'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:311: Found 'DD'-anomaly for variable 'status' (lines '311'-'322'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:311: Found 'DD'-anomaly for variable 'status' (lines '311'-'325'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:311: Found 'DD'-anomaly for variable 'status' (lines '311'-'328'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:312: Found 'DD'-anomaly for variable 'extra' (lines '312'-'318'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:312: Found 'DD'-anomaly for variable 'extra' (lines '312'-'323'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:312: Found 'DD'-anomaly for variable 'extra' (lines '312'-'326'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:312: Found 'DD'-anomaly for variable 'extra' (lines '312'-'329'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:328: Found 'DD'-anomaly for variable 'status' (lines '328'-'337'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:329: Found 'DD'-anomaly for variable 'extra' (lines '329'-'338'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:330: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:330: Found 'DD'-anomaly for variable 'deficit' (lines '330'-'334'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:330: Found 'DU'-anomaly for variable 'deficit' (lines '330'-'345'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:331: Local variable 'wl' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:332: Avoid variables with short names like pi +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:332: Local variable 'pi' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:333: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:347: Parameter 'suggestions' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:348: Parameter 'expert' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:348: Parameter 'suggestion' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:349: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:350: Local variable 'now' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:357: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:357: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:358: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:358: Variables that are final and static should be all capitals, 'cAlarmKey' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:358: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:359: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:359: Variables that are final and static should be all capitals, 'cWarnKey' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:359: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:360: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:360: Variables that are final and static should be all capitals, 'cPlainKey' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:360: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:361: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:361: Variables that are final and static should be all capitals, 'cExportKey' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:361: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:362: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:362: Variables that are final and static should be all capitals, 'cGoodKey' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:362: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:363: Avoid using redundant field initializer for 'cAlarm' +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:363: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:363: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:364: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:364: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:365: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:365: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:366: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:366: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:367: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:367: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:369: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:369: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:369: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:370: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:370: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:370: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:371: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:371: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:371: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:372: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:372: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:372: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:373: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:373: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:373: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:381: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:384: Found 'DU'-anomaly for variable 'player' (lines '384'-'425'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:387: Avoid excessively long variable names like firstColonyComparator +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:387: Found 'DU'-anomaly for variable 'firstColonyComparator' (lines '387'-'425'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:390: Avoid variables with short names like l1 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:390: Avoid variables with short names like l2 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:390: Parameter 'l1' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:390: Parameter 'l2' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:390: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:399: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:400: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:407: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:415: Local variable 'gti' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:417: Avoid variables with short names like gt +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:417: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:418: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:427: The method loadResources() has an NPath complexity of 6250 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:427: Use block level rather than method level synchronization +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:428: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:430: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:430: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:433: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:433: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:436: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:436: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:439: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:439: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:442: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:442: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:448: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:449: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:449: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:451: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:454: Avoid reassigning parameters such as 'messageId' +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:459: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:459: Avoid variables with short names like h +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:459: Avoid variables with short names like i +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:459: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:459: Parameter 'h' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:459: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:460: Avoid variables with short names like l +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:460: Local variable 'l' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Avoid reassigning parameters such as 'h' +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Avoid variables with short names like h +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Avoid variables with short names like i +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:465: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:466: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:467: Avoid variables with short names like l +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:467: Local variable 'l' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:468: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:472: Avoid reassigning parameters such as 'h' +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:472: Avoid variables with short names like h +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:472: Avoid variables with short names like i +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:472: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:472: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:473: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:473: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:473: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:473: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:474: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:475: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:475: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:477: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:478: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:482: Found 'UR'-anomaly for variable 'jc' (lines '482'-'490'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:482: Parameter 'components' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:487: Found 'DU'-anomaly for variable 'layout' (lines '487'-'493'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:487: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:487: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:488: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:489: Local variable 'jc' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:491: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:491: Found 'DU'-anomaly for variable 'layout' (lines '491'-'493'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Avoid variables with short names like s +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Found 'UR'-anomaly for variable 'e' (lines '500'-'763'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Found 'UR'-anomaly for variable 'gt' (lines '500'-'612'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Found 'UR'-anomaly for variable 'ti' (lines '500'-'565'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Found 'UR'-anomaly for variable 'tis' (lines '500'-'548'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Found 'UR'-anomaly for variable 'u' (lines '500'-'579'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Found 'UR'-anomaly for variable 'ut' (lines '500'-'806'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: Parameter 's' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: The method 'updateColony' has a Cyclomatic Complexity of 56. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: The method 'updateColony' has a Modified Cyclomatic Complexity of 44. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: The method 'updateColony' has a Standard Cyclomatic Complexity of 53. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:500: The method updateColony() has an NCSS line count of 177 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:501: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:502: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:502: Found 'DU'-anomaly for variable 'defaultUnitType' (lines '502'-'812'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:503: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:504: Local variable 'buttons' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:505: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:506: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:507: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:512: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:512: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:517: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:518: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:518: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:518: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:518: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:518: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:529: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:529: The String literal "%colony%" appears 24 times in this file; the first occurrence is on line 529 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:530: The String literal "%amount%" appears 16 times in this file; the first occurrence is on line 530 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:534: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:535: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:539: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:546: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:546: Found 'DD'-anomaly for variable 'n' (lines '546'-'548'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:547: Local variable 'tis' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:548: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:548: Found 'DD'-anomaly for variable 'n' (lines '548'-'548'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:548: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:551: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:551: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:552: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:556: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:564: Local variable 'ti' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:565: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:566: Found 'DD'-anomaly for variable 'n' (lines '566'-'570'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:567: Found 'DD'-anomaly for variable 'center' (lines '567'-'571'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:568: Local variable 'tis' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:570: Found 'DD'-anomaly for variable 'n' (lines '570'-'570'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:571: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:571: Found 'DD'-anomaly for variable 'center' (lines '571'-'571'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:571: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:575: Found 'DD'-anomaly for variable 'c' (lines '575'-'583'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:576: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:577: Local variable 'tis' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:577: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:578: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:578: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:579: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:580: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:581: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:581: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:587: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:587: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:587: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:587: The String literal "report.colony.tile." appears 4 times in this file; the first occurrence is on line 587 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:589: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:591: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:593: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:593: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:593: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:594: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:598: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:600: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:602: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:611: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:612: Avoid variables with short names like gp +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:612: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:616: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:616: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:616: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:616: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:617: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:618: The String literal "%goods%" appears 15 times in this file; the first occurrence is on line 618 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:620: The String literal "%turns%" appears 7 times in this file; the first occurrence is on line 620 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:624: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:624: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:624: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:625: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:630: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:631: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:635: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:635: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:635: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:636: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:643: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:650: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:657: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:657: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:657: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:657: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:658: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:665: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:665: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:665: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:665: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:666: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:673: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:673: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:673: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:673: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:674: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:682: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:690: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:698: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:698: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:698: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:699: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:705: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:705: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:706: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:706: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:707: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:711: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:711: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:711: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:711: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:711: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:713: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:724: Found 'DU'-anomaly for variable 'qac' (lines '724'-'812'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:727: Found 'DU'-anomaly for variable 'name' (lines '727'-'812'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:727: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:729: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:730: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:733: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:733: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:733: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:734: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:742: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:743: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:744: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:749: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:749: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:749: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:749: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:749: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:751: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:757: Found 'DD'-anomaly for variable 'empty' (lines '757'-'760'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:757: Found 'DD'-anomaly for variable 'empty' (lines '757'-'782'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:758: Local variable 'school' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:758: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:760: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:760: Found 'DD'-anomaly for variable 'empty' (lines '760'-'782'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:760: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:760: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:761: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:763: Avoid variables with short names like u +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:763: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:763: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:764: Avoid variables with short names like ii +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:764: Local variable 'ii' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:765: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:765: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:766: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:767: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:767: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:768: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:774: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:776: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:777: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:778: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:781: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:782: Found 'DD'-anomaly for variable 'empty' (lines '782'-'782'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:786: Found 'DU'-anomaly for variable 'emptyIcon' (lines '786'-'812'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:788: Found 'DU'-anomaly for variable 't' (lines '788'-'812'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:788: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:788: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:789: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:792: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:799: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:799: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:802: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:803: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:806: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:806: Local variable 'ut' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:806: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:806: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:807: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:815: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:815: Parameter 'have' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:816: Found 'DU'-anomaly for variable 'cac' (lines '816'-'856'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:816: Found 'DU'-anomaly for variable 'cac' (lines '816'-'856'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:817: Found 'DU'-anomaly for variable 'result' (lines '817'-'856'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:817: Found 'DU'-anomaly for variable 'result' (lines '817'-'856'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:817: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:818: Local variable 'types' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:822: Avoid variables with short names like t1 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:822: Avoid variables with short names like t2 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:822: Parameter 't1' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:822: Parameter 't2' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:822: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:823: Avoid variables with short names like s1 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:823: Local variable 's1' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:824: Avoid variables with short names like s2 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:824: Local variable 's2' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:825: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:828: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:829: Local variable 'present' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:830: Local variable 'suggestion' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:831: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:832: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:833: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:834: Local variable 'tip' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:839: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:842: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:842: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:842: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:842: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:842: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:842: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:847: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:850: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:850: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:851: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:851: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:852: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:852: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:852: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:852: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:852: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Found 'UR'-anomaly for variable 'e' (lines '863'-'999'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Found 'UR'-anomaly for variable 'gt' (lines '863'-'965'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Found 'UR'-anomaly for variable 's' (lines '863'-'885'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Found 'UR'-anomaly for variable 'ti' (lines '863'-'946'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Found 'UR'-anomaly for variable 'tis' (lines '863'-'934'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Found 'UR'-anomaly for variable 'u' (lines '863'-'896'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Found 'UR'-anomaly for variable 'ut' (lines '863'-'902'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: Parameter 'summaries' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: The method 'updateCombinedColonies' has a Cyclomatic Complexity of 28. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: The method 'updateCombinedColonies' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: The method 'updateCombinedColonies' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:863: The method updateCombinedColonies() has an NPath complexity of 103402000 +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:864: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:864: Avoid unused local variables such as 'l'. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:864: Avoid variables with short names like l +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:864: Local variable 'l' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:865: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:866: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:872: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:872: Local variable 'rRegionMap' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:873: Local variable 'rTileSuggestions' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:874: Avoid unused local variables such as 'rFamine'. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:874: Found 'DD'-anomaly for variable 'rFamine' (lines '874'-'888'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:874: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:875: Found 'DD'-anomaly for variable 'improveLen' (lines '875'-'900'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:875: Found 'DD'-anomaly for variable 'teacherLen' (lines '875'-'894'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:877: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:877: Local variable 'rProduction' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:879: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:879: Local variable 'rTeachers' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:880: Local variable 'rNotWorking' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:881: Local variable 'rCouldWork' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:882: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:882: Local variable 'rImprove' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:883: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:883: Local variable 'rNeeded' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:884: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:885: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:885: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:885: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:888: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:888: Found 'DD'-anomaly for variable 'rFamine' (lines '888'-'888'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:888: Found 'DU'-anomaly for variable 'rFamine' (lines '888'-'1,017'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:889: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:894: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:895: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:895: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:898: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:899: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:900: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:900: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:901: Local variable 'ut' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:901: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:904: Local variable 'ut' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:904: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:907: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:907: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:908: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:909: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:926: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:926: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:932: Local variable 'tiles' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:933: Local variable 'tis' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:934: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:934: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:935: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:938: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:938: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:938: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:938: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:939: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:945: Local variable 'ti' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:946: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:946: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:947: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:948: Local variable 'tis' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:950: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:951: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:954: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:954: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:954: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:954: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:954: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:955: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:956: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:964: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:965: Avoid variables with short names like gp +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:965: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:971: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:982: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:983: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:984: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:991: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:991: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:996: Local variable 'labels' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:997: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:999: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:999: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:999: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:999: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1000: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1002: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1003: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1009: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1019: Found 'UR'-anomaly for variable 'e' (lines '1,019'-'1,025'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1019: Parameter 'unitTypeMap' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1020: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1020: Parameter 'maxSize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1020: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1021: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1022: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1022: Found 'DU'-anomaly for variable 'n' (lines '1,022'-'1,033'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1023: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1025: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1026: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1029: Avoid assignments in operands +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1029: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1041: Found 'UR'-anomaly for variable 'gt' (lines '1,041'-'1,058'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1041: Found 'UR'-anomaly for variable 'ti' (lines '1,041'-'1,053'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1041: Parameter 'market' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1052: Local variable 'ti' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1053: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1054: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1057: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1058: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1058: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1059: Avoid variables with short names like l +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1059: Local variable 'l' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1059: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1060: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1062: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1067: Local variable 'colonistIcon' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1083: Found 'UR'-anomaly for variable 'c' (lines '1,083'-'1,098'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1083: Found 'UR'-anomaly for variable 'cs' (lines '1,083'-'1,097'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1088: Avoid using for statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1088: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1089: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1093: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1094: Found 'DU'-anomaly for variable 'summaries' (lines '1,094'-'1,107'). +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1094: Local variable 'summaries' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1095: Local variable 'cs' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1097: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1098: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1098: Avoid variables with short names like s +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1098: Local variable 's' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1102: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1116: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1116: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1121: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1127: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1129: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportCompactColonyPanel.java:1129: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:50: The class 'ReportContinentalCongressPanel' has a Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:50: The class 'ReportContinentalCongressPanel' has a Modified Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:50: The class 'ReportContinentalCongressPanel' has a Standard Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:52: Variables that are final and static should be all capitals, 'none' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:61: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:64: Local variable 'tabs' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:70: Local variable 'recruitingPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:75: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:76: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:80: Avoid excessively long variable names like currentFatherLabel +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:80: Local variable 'currentFatherLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:85: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:86: Local variable 'total' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:87: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:88: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:88: Local variable 'progressBar' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:97: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:97: Local variable 'panels' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:99: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:100: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:100: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:101: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:103: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:103: Local variable 'imageScrollPane' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:110: Local variable 'electionTurns' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:111: Local variable 'father' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:112: Avoid unused local variables such as 'name'. +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:112: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:113: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:122: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:123: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:127: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:131: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/ReportContinentalCongressPanel.java:135: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:46: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:51: Local variable 'colonies' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:52: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:53: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:57: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:57: Avoid variables with short names like bp +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:57: Local variable 'bp' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:60: Local variable 'teacherPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:61: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:63: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:68: Local variable 'studentPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:69: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:71: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:80: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportEducationPanel.java:81: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:43: Variables that are final and static should be all capitals, 'regionComparator' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:43: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:45: Parameter 'region1' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:45: Parameter 'region2' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:45: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:46: Local variable 'number1' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:46: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:47: Local variable 'number2' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:47: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:49: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:61: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:67: Local variable 'regions' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:68: Local variable 'region' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:80: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:82: Local variable 'nameOfRegion' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:85: Local variable 'typeOfRegion' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:88: Local variable 'discoveredIn' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:91: Local variable 'discoveredBy' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:94: Local variable 'valueOfRegion' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:103: Local variable 'region' could be declared final +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:104: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportExplorationPanel.java:110: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:50: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:68: Avoid excessively long variable names like continentalCongress_title +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:80: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:81: Local variable 'enemy' could be declared final +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:82: Avoid variables with short names like ns +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:82: Local variable 'ns' could be declared final +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:83: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:85: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:85: Local variable 'enemyPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:89: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:89: Local variable 'coatLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:92: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:97: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:97: The String literal "newline" appears 8 times in this file; the first occurrence is on line 97 +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:101: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:102: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:105: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:106: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:109: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:110: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:113: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:114: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:117: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:118: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:122: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:124: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:129: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:130: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:131: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:136: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:137: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportForeignAffairPanel.java:138: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:51: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:51: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:52: Parameter 'highScores' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:63: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:65: Local variable 'highScore' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:66: Local variable 'scoreValue' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:67: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:71: Local variable 'messageId' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:71: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:71: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:74: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:77: Local variable 'headline' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:83: The String literal "skip" appears 9 times in this file; the first occurrence is on line 83 +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:84: Local variable 'retirementTurn' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:85: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:85: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:91: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:99: Local variable 'independenceTurn' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:100: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:100: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:106: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:106: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:116: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:120: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:124: Local variable 'format' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHighScoresPanel.java:126: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportHistoryPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportHistoryPanel.java:40: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportHistoryPanel.java:43: Local variable 'history' could be declared final +src/net/sf/freecol/client/gui/panel/ReportHistoryPanel.java:47: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportHistoryPanel.java:51: Local variable 'event' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:54: The class 'ReportIndianPanel' has a Cyclomatic Complexity of 11 (Highest = 17). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:54: The class 'ReportIndianPanel' has a Modified Cyclomatic Complexity of 10 (Highest = 14). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:54: The class 'ReportIndianPanel' has a Standard Cyclomatic Complexity of 10 (Highest = 14). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:56: Variables that are final and static should be all capitals, 'headlines' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:71: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:74: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:78: Local variable 'opponent' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:81: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: Found 'UR'-anomaly for variable 'key' (lines '93'-'139'). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: Found 'UR'-anomaly for variable 'settlement' (lines '93'-'146'). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: Parameter 'opponent' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: The method 'buildIndianAdvisorPanel' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: The method 'buildIndianAdvisorPanel' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: The method 'buildIndianAdvisorPanel' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:93: The method buildIndianAdvisorPanel() has an NPath complexity of 21607 +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:94: Avoid variables with short names like ns +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:95: Local variable 'nativeSettlements' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:97: Local variable 'numSettlements' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:97: No need to call String.valueOf to append to a string. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:98: No need to call String.valueOf to append to a string. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:100: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:101: Local variable 'villageLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:106: Local variable 'headline' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:111: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:138: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:139: Local variable 'head' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:143: Local variable 'settlements' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:145: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:152: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:161: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:165: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:168: Local variable 'settlementButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:176: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:176: Local variable 'missionLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:178: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:178: Local variable 'dummy' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:180: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:180: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:181: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:198: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:199: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:212: Found 'DD'-anomaly for variable 'wantedGoods' (lines '212'-'212'). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:212: Found 'DU'-anomaly for variable 'wantedGoods' (lines '212'-'233'). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:212: Local variable 'wantedGoods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:213: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:213: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:213: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:215: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:215: Avoid variables with short names like x +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:215: Found 'DD'-anomaly for variable 'x' (lines '215'-'215'). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:215: Found 'DU'-anomaly for variable 'x' (lines '215'-'233'). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:215: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:215: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:219: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:220: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:229: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:229: Found 'DD'-anomaly for variable 'x' (lines '229'-'215'). +src/net/sf/freecol/client/gui/panel/ReportIndianPanel.java:229: Found 'DU'-anomaly for variable 'x' (lines '229'-'233'). +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:53: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:62: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:63: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:64: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:65: Parameter 'unitCount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:66: Parameter 'colonies' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:77: Found 'UR'-anomaly for variable 'colony' (lines '77'-'91'). +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:77: Found 'UR'-anomaly for variable 'entry' (lines '77'-'107'). +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:77: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:78: Local variable 'detailPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:88: Found 'DD'-anomaly for variable 'canTrain' (lines '88'-'94'). +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:89: Local variable 'unitLocations' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:90: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:94: Found 'DD'-anomaly for variable 'canTrain' (lines '94'-'94'). +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:95: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:97: Local variable 'colonyButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:101: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:101: Local variable 'countLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:106: Local variable 'entry' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:108: Local variable 'locationName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:110: Local variable 'linkButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:111: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:114: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:114: Local variable 'countLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourDetailPanel.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:60: The class 'ReportLabourPanel' has a Cyclomatic Complexity of 6 (Highest = 15). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:60: The class 'ReportLabourPanel' has a Modified Cyclomatic Complexity of 6 (Highest = 14). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:60: The class 'ReportLabourPanel' has a Standard Cyclomatic Complexity of 6 (Highest = 14). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:66: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:69: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:69: Parameter 'count' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:69: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:69: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:74: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:74: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:82: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:82: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:82: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:84: Local variable 'g2d' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:85: Local variable 'oldComposite' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:86: Local variable 'oldColor' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:89: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:105: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:106: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:107: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:108: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:109: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:117: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:117: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:120: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:120: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:123: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:126: Avoid using redundant field initializer for 'panelList' +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:126: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:126: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:126: Private field 'panelList' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: Found 'UR'-anomaly for variable 'unit' (lines '132'-'138'). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: Found 'UR'-anomaly for variable 'unit' (lines '132'-'138'). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: Found 'UR'-anomaly for variable 'unit' (lines '132'-'138'). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: Found 'UR'-anomaly for variable 'unitType' (lines '132'-'169'). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: Found 'UR'-anomaly for variable 'unitType' (lines '132'-'169'). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: Found 'UR'-anomaly for variable 'unitType' (lines '132'-'169'). +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: The constructor 'ReportLabourPanel' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: The constructor 'ReportLabourPanel' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:132: The constructor 'ReportLabourPanel' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:137: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:138: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:142: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:148: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:149: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:156: Local variable 'count' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:166: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:168: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:170: Local variable 'count' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:171: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:174: Local variable 'selectAction' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:176: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:176: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:176: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:180: Local variable 'quitAction' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:182: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:182: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:182: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:197: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:197: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:197: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:198: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:213: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:226: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:226: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:231: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:231: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportLabourPanel.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:48: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:53: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:60: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:66: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:66: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:67: Local variable 'count' could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:69: Avoid variables with short names like au +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:69: Local variable 'au' could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:81: Found 'UR'-anomaly for variable 'unit' (lines '81'-'83'). +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:82: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:84: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:84: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:93: Found 'UR'-anomaly for variable 'au' (lines '93'-'103'). +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:94: Found 'DU'-anomaly for variable 'spec' (lines '94'-'108'). +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:100: Local variable 'refUnits' could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:102: Local variable 'au' could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:114: Found 'UR'-anomaly for variable 'r' (lines '114'-'131'). +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:114: Found 'UR'-anomaly for variable 'unitType' (lines '114'-'127'). +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:117: Avoid unused local variables such as 'defaultType'. +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:117: Found 'DU'-anomaly for variable 'defaultType' (lines '117'-'134'). +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:125: Found 'DU'-anomaly for variable 'militaryRoles' (lines '125'-'134'). +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:125: Local variable 'militaryRoles' could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:126: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportMilitaryPanel.java:130: Local variable 'r' could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:48: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:53: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:58: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:68: Found 'UR'-anomaly for variable 'unit' (lines '68'-'70'). +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:69: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:80: Found 'UR'-anomaly for variable 'au' (lines '80'-'91'). +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:81: Found 'DU'-anomaly for variable 'spec' (lines '81'-'96'). +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:88: Local variable 'refUnits' could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:90: Local variable 'au' could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:102: Found 'UR'-anomaly for variable 'unitType' (lines '102'-'111'). +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:103: Avoid unused local variables such as 'spec'. +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:103: Found 'DU'-anomaly for variable 'spec' (lines '103'-'117'). +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:110: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:111: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:112: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:112: Avoid variables with short names like au +src/net/sf/freecol/client/gui/panel/ReportNavalPanel.java:112: Local variable 'au' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportPanel.java:25: Avoid unused imports such as 'java.util.Comparator' +src/net/sf/freecol/client/gui/panel/ReportPanel.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportPanel.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportPanel.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportPanel.java:54: It is somewhat confusing to have a field name matching the declaring class name +src/net/sf/freecol/client/gui/panel/ReportPanel.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportPanel.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportPanel.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportPanel.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportPanel.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportPanel.java:67: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:67: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:85: Local variable 'scale' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:102: Avoid variables with short names like au +src/net/sf/freecol/client/gui/panel/ReportPanel.java:102: Parameter 'au' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:102: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportPanel.java:103: Local variable 'unitType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:104: Local variable 'roleId' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:105: Local variable 'count' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:106: Local variable 'unitIcon' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportPanel.java:107: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportPanel.java:107: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportPanel.java:108: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:117: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:117: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportPanel.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ReportPanel.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ReportPanel.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportPanel.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportPanel.java:128: Parameter 'main' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:128: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportPanel.java:140: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportPanel.java:140: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportPanel.java:145: Local variable 'fco' could be declared final +src/net/sf/freecol/client/gui/panel/ReportPanel.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportPanel.java:146: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ReportPanel.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportPanel.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportPanel.java:164: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:45: The class 'ReportProductionPanel' has a Cyclomatic Complexity of 10 (Highest = 15). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:45: The class 'ReportProductionPanel' has a Modified Cyclomatic Complexity of 10 (Highest = 14). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:45: The class 'ReportProductionPanel' has a Standard Cyclomatic Complexity of 10 (Highest = 14). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:64: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:69: Local variable 'goodsNames' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:71: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:77: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:77: This call to Collection.toArray() may be optimizable +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:79: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:79: Local variable 'newBox' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:89: Found 'UR'-anomaly for variable 'buildingType' (lines '89'-'117'). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:89: Found 'UR'-anomaly for variable 'colony' (lines '89'-'149'). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:89: Found 'UR'-anomaly for variable 'goodsType' (lines '89'-'117'). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:89: The method 'update' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:89: The method 'update' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:89: The method 'update' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:89: The method update() has an NPath complexity of 273 +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:91: Local variable 'selectLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:94: Local variable 'selectButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:95: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:100: Local variable 'selectedTypes' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:102: Local variable 'box' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:104: Local variable 'selectedIndex' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:110: Found 'DU'-anomaly for variable 'buildingCount' (lines '110'-'187'). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:110: Local variable 'buildingCount' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:112: Avoid excessively long variable names like basicBuildingTypes +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:112: Local variable 'basicBuildingTypes' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:113: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:114: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:114: Local variable 'buildingTypes' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:115: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:119: Local variable 'firstLevel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:120: Deeply nested if..then statements are hard to read +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:139: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:146: Found 'DU'-anomaly for variable 'totalProduction' (lines '146'-'187'). +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:147: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:149: Local variable 'colonyButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:157: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:158: Local variable 'newValue' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:160: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:160: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:161: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:161: Local variable 'goodsLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:166: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:167: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:169: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:174: Local variable 'buildingPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportProductionPanel.java:175: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:47: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:58: Local variable 'gt' could be declared final +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:59: Local variable 'crosses' could be declared final +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:62: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:62: Local variable 'progressBar' could be declared final +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:67: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:68: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:72: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:72: Avoid variables with short names like bp +src/net/sf/freecol/client/gui/panel/ReportReligiousPanel.java:72: Local variable 'bp' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:20: Possible God class (WMC=60, ATFD=106, TCC=0.14285714285714285) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:59: The class 'ReportRequirementsPanel' has a Cyclomatic Complexity of 8 (Highest = 32). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:59: The class 'ReportRequirementsPanel' has a Modified Cyclomatic Complexity of 6 (Highest = 20). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:59: The class 'ReportRequirementsPanel' has a Standard Cyclomatic Complexity of 6 (Highest = 20). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:61: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:71: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:76: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:84: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:92: Local variable 'textPane' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:93: Local variable 'doc' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:96: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:97: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:97: Local variable 'newUnitCount' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:98: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:98: Local variable 'newCanTrain' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:99: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:109: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:113: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Found 'UR'-anomaly for variable 'building' (lines '119'-'162'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Found 'UR'-anomaly for variable 'colonyTile' (lines '119'-'150'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Found 'UR'-anomaly for variable 'expert' (lines '119'-'140'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Found 'UR'-anomaly for variable 'input' (lines '119'-'183'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Found 'UR'-anomaly for variable 'output' (lines '119'-'163'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Found 'UR'-anomaly for variable 'tis' (lines '119'-'193'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Found 'UR'-anomaly for variable 'unit' (lines '119'-'151'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: Parameter 'doc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: The method 'checkColony' has a Cyclomatic Complexity of 32. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: The method 'checkColony' has a Modified Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: The method 'checkColony' has a Standard Cyclomatic Complexity of 20. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:119: The method checkColony() has an NPath complexity of 110880 +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:124: The String literal "\n\n" appears 6 times in this file; the first occurrence is on line 124 +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:125: The String literal "regular" appears 12 times in this file; the first occurrence is on line 125 +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:127: The String literal "button" appears 8 times in this file; the first occurrence is on line 127 +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:130: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:134: Avoid excessively long variable names like missingExpertWarning +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:134: Local variable 'missingExpertWarning' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:135: Avoid excessively long variable names like badAssignmentWarning +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:135: Local variable 'badAssignmentWarning' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:136: Local variable 'productionWarning' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:139: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:140: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:141: Local variable 'better' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:149: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:150: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:151: Local variable 'workType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:152: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:161: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:162: Local variable 'output' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:163: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:164: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:172: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:177: Local variable 'info' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:182: Local variable 'input' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:190: Local variable 'tileSuggestions' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:192: Local variable 'tis' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:197: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:198: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:213: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:219: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:219: Parameter 'doc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:220: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:220: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:221: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:222: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:222: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:222: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:228: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:233: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:233: Parameter 'doc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:234: Parameter 'expert' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:234: Parameter 'nonExpert' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:235: Local variable 'expertGoods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:236: Local variable 'nonExpertGoods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:237: Local variable 'colonyName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:238: Local variable 'expertName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:239: Local variable 'nonExpertName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:240: Avoid excessively long variable names like expertProductionName +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:240: Local variable 'expertProductionName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:241: Avoid excessively long variable names like nonExpertProductionName +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:241: Local variable 'nonExpertProductionName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Local variable 'newMessage' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:252: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: Found 'UR'-anomaly for variable 'colony' (lines '257'-'271'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: Found 'UR'-anomaly for variable 'unit' (lines '257'-'272'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: Parameter 'doc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: The method 'addExpertWarning' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: The method 'addExpertWarning' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: The method 'addExpertWarning' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:257: The method addExpertWarning() has an NPath complexity of 233 +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:258: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:258: Parameter 'workType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:259: Local variable 'newMessage' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:263: The String literal "%unit%" appears 4 times in this file; the first occurrence is on line 263 +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:267: Local variable 'misusedExperts' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:268: Local variable 'severalExperts' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:269: Local variable 'canTrainExperts' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:270: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:271: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:272: Local variable 'expertise' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:272: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:273: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:273: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:273: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:273: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:273: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:283: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:292: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:292: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:293: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:293: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:293: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:293: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:302: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:303: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:303: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:311: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:319: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:325: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:325: Found 'UR'-anomaly for variable 'colony' (lines '325'-'327'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:325: Parameter 'colonies' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:325: Parameter 'doc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:326: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:334: Found 'UR'-anomaly for variable 'col' (lines '334'-'352'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:334: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:334: Parameter 'doc' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:335: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:335: Parameter 'output' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:336: Local variable 'colonyName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:337: Local variable 'newMessage' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:347: Local variable 'withSurplus' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:348: Found 'DU'-anomaly for variable 'theSurplus' (lines '348'-'382'). +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:348: Local variable 'theSurplus' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:349: Local variable 'col' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:350: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:358: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:359: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:359: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:364: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:370: Local variable 'lastColony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:371: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:378: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:384: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:384: Parameter 'headline' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:388: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:388: Parameter 'headline' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:388: Parameter 'info' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:389: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:390: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportRequirementsPanel.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:55: The class 'ReportTradePanel' has a Cyclomatic Complexity of 5 (Highest = 16). +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:55: The class 'ReportTradePanel' has a Modified Cyclomatic Complexity of 5 (Highest = 16). +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:55: The class 'ReportTradePanel' has a Standard Cyclomatic Complexity of 5 (Highest = 16). +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:57: Perhaps 'colonies' could be replaced by a local variable. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:65: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:65: The constructor 'ReportTradePanel' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:65: The constructor 'ReportTradePanel' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:65: The constructor 'ReportTradePanel' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:65: The constructor with 1 parameters has an NCSS line count of 106 +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:69: Local variable 'warnColor' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:73: Local variable 'goodsHeader' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:78: Local variable 'storableGoods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:79: Local variable 'market' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:85: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:87: Local variable 'layoutConstraints' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:88: Local variable 'columnConstraints' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:92: Local variable 'rowConstraints' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:100: Local variable 'emptyLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:107: Avoid variables with short names like jl +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:116: Local variable 'totalUnits' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:117: Local variable 'deltaUnits' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:118: Local variable 'cargoUnits' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:120: Local variable 'iterator' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:122: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:124: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:132: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:134: Local variable 'sales' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:135: Local variable 'beforeTaxes' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:136: Local variable 'afterTaxes' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:137: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:142: The String literal "cell " appears 8 times in this file; the first occurrence is on line 142 +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:153: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:154: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:157: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:160: Local variable 'colonyButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:164: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:164: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:169: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:171: Local variable 'amount' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:172: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:172: Local variable 'goodsLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:174: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:174: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:178: Avoid variables with short names like ed +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:178: Local variable 'ed' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:187: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:188: Local variable 'productionLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:191: Local variable 'warnings' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:194: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:194: Avoid variables with short names like sb +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:194: Local variable 'sb' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:195: Local variable 'warning' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:197: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:215: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:224: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:225: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:230: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:234: Parameter 'alwaysAddSign' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:234: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:235: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTradePanel.java:245: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:67: The class 'ReportTurnPanel' has a Cyclomatic Complexity of 7 (Highest = 18). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:67: The class 'ReportTurnPanel' has a Modified Cyclomatic Complexity of 6 (Highest = 16). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:67: The class 'ReportTurnPanel' has a Standard Cyclomatic Complexity of 7 (Highest = 17). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:69: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:69: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:74: Avoid excessively long variable names like textPanesByMessage +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:74: Avoid using implementation types like 'Hashtable'; use the interface instead +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:74: Consider replacing this Hashtable with the newer java.util.Map +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:74: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:76: Avoid using implementation types like 'Hashtable'; use the interface instead +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:76: Consider replacing this Hashtable with the newer java.util.Map +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:76: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:86: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:87: Parameter 'messages' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:102: Parameter 'messages' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:104: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:107: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:107: Found 'UR'-anomaly for variable 'message' (lines '107'-'123'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:107: The method 'displayMessages' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:107: The method 'displayMessages' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:107: The method 'displayMessages' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:107: The method displayMessages() has an NPath complexity of 10082 +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:115: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:118: Found 'DU'-anomaly for variable 'type' (lines '118'-'230'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:119: Local variable 'message' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:123: Local variable 'messageSource' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:124: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:125: Found 'DU'-anomaly for variable 'source' (lines '125'-'230'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:131: Found 'DU'-anomaly for variable 'type' (lines '131'-'230'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:132: Local variable 'headline' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:141: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:141: Found 'DD'-anomaly for variable 'component' (lines '141'-'152'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:141: Found 'DD'-anomaly for variable 'component' (lines '141'-'157'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:141: Found 'DD'-anomaly for variable 'component' (lines '141'-'159'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:142: Local variable 'messageDisplay' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:143: Found 'DU'-anomaly for variable 'lib' (lines '143'-'230'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:145: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:146: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:146: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:146: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:149: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:154: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:159: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:174: Found 'DD'-anomaly for variable 'ignore' (lines '174'-'189'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:174: Found 'DU'-anomaly for variable 'ignore' (lines '174'-'230'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:176: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:178: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:178: Local variable 'ignoreButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:181: Avoid variables with short names like m +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:182: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:183: Local variable 'flag' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:189: Found 'DD'-anomaly for variable 'ignore' (lines '189'-'174'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:189: Found 'DU'-anomaly for variable 'ignore' (lines '189'-'230'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:198: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:198: Use ArrayList instead of Vector +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:203: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:203: Use ArrayList instead of Vector +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:206: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:211: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:211: Local variable 'filterButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:215: Avoid variables with short names like m +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:216: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:217: Local variable 'flag' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:232: Found 'UR'-anomaly for variable 'label' (lines '232'-'240'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:232: Found 'UR'-anomaly for variable 'm' (lines '232'-'235'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:232: Found 'UR'-anomaly for variable 'textPane' (lines '232'-'237'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:232: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:233: Parameter 'enabled' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:234: Local variable 'm' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:236: Local variable 'textPane' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:239: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:246: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:246: The method 'getHeadline' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:246: The method 'getHeadline' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:246: The method 'getHeadline' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:248: Found 'DD'-anomaly for variable 'commandId' (lines '248'-'261'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:248: Found 'DD'-anomaly for variable 'commandId' (lines '248'-'266'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:248: Found 'DD'-anomaly for variable 'commandId' (lines '248'-'270'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:248: Found 'DD'-anomaly for variable 'commandId' (lines '248'-'274'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:248: Found 'DD'-anomaly for variable 'commandId' (lines '248'-'279'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:252: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:253: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:259: Local variable 'europe' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:263: Local variable 'market' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:264: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:264: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:274: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:277: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:286: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:289: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:290: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:304: Found 'UR'-anomaly for variable 'o' (lines '304'-'307'). +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:304: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:304: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:305: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:306: Local variable 'o' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:311: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:311: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/panel/ReportTurnPanel.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:54: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:54: The class 'ReportUnitPanel' has a Cyclomatic Complexity of 3 (Highest = 11). +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:64: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:69: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:74: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:79: Avoid using redundant field initializer for 'showColonies' +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:79: Private field 'showColonies' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:89: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:89: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:90: Parameter 'showColonies' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:104: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:109: Local variable 'europe' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:115: Local variable 'otherNames' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:117: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:126: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:126: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:126: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:127: Local variable 'map' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:131: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:131: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:131: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:131: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:140: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:140: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:140: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:146: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:148: Local variable 'locationName' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:167: Found 'UR'-anomaly for variable 'goods' (lines '167'-'194'). +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:167: Found 'UR'-anomaly for variable 'u' (lines '167'-'190'). +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:167: Found 'UR'-anomaly for variable 'unitLoaded' (lines '167'-'198'). +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:167: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:167: Parameter 'locationName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:167: The method 'handleLocation' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:167: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:168: Parameter 'unitList' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:177: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:188: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:190: Local variable 'unitButton' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:193: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:194: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:194: Local variable 'goodsLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:197: Local variable 'unitLoaded' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:198: Local variable 'unitLoadedLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:199: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:209: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:209: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:210: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:211: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:213: Local variable 'tip' could be declared final +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ReportUnitPanel.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:22: Avoid unused imports such as 'java.util.ArrayList' +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:36: Avoid unused imports such as 'net.sf.freecol.common.model.FreeColGameObjectType' +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:40: Avoid unused imports such as 'net.sf.freecol.common.model.Scope' +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:58: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:59: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:70: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:78: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:78: Found 'UR'-anomaly for variable 'modifier' (lines '78'-'91'). +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:78: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:78: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:79: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:81: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:84: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:88: Local variable 'goodsPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:90: Local variable 'modifier' could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:94: Local variable 'scopeStrings' could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:95: Avoid variables with short names like s +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:96: Avoid variables with short names like s +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:98: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:98: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:101: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ResourcesDetailPanel.java:102: Local variable 'goodsButton' could be declared final +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:44: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:57: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:57: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:60: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:64: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:64: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:67: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:68: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/RiverStyleDialog.java:69: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/SaveDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/SaveDialog.java:43: Variables that are final and static should be all capitals, 'cancelFile' is not all capitals. +src/net/sf/freecol/client/gui/panel/SaveDialog.java:46: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/SaveDialog.java:55: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:55: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:56: Parameter 'defaultName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:56: Parameter 'directory' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:56: Parameter 'fileFilters' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:61: Local variable 'fileFilter' could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:71: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/SaveDialog.java:72: Useless parentheses. +src/net/sf/freecol/client/gui/panel/SaveDialog.java:72: Useless parentheses. +src/net/sf/freecol/client/gui/panel/SaveDialog.java:76: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/SaveDialog.java:76: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:87: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/SaveDialog.java:88: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/SaveDialog.java:88: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/SaveDialog.java:88: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:48: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:50: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:52: Use explicit scoping instead of the default package private level +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:61: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:72: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:73: Local variable 'widthPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:74: Local variable 'heightPanel' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:83: Local variable 'widthLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:85: Local variable 'heightLabel' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:99: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:99: Avoid variables with short names like al +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:106: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:107: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:107: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:119: Avoid variables with short names like w +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:119: Local variable 'w' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:120: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:125: Avoid variables with short names like h +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:125: Local variable 'h' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:126: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:137: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ScaleMapSizeDialog.java:150: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:40: The class 'SelectAmountDialog' has a Cyclomatic Complexity of 5 (Highest = 11). +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:40: The class 'SelectAmountDialog' has a Modified Cyclomatic Complexity of 5 (Highest = 10). +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:40: The class 'SelectAmountDialog' has a Standard Cyclomatic Complexity of 5 (Highest = 10). +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:43: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:45: Avoid unused private fields such as 'SELECT_CANCEL'. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:45: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:48: Variables that are final and static should be all capitals, 'amounts' is not all capitals. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:54: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:64: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:64: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:64: The constructor 'SelectAmountDialog' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:64: The constructor 'SelectAmountDialog' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:64: The constructor 'SelectAmountDialog' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:65: Avoid reassigning parameters such as 'available' +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:65: Parameter 'defaultAmount' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:65: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:65: Parameter 'pay' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:71: Local variable 'price' could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:75: Local variable 'question' could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:79: Local variable 'values' could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:82: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:85: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:99: This call to Collection.toArray() may be optimizable +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:101: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:103: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:116: Local variable 'value' could be declared final +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:117: Useless parentheses. +src/net/sf/freecol/client/gui/panel/SelectAmountDialog.java:117: Useless parentheses. +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:40: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:40: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:42: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:51: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:60: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:60: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:61: Parameter 'maximum' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:61: Parameter 'question' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:67: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:83: Found 'DU'-anomaly for variable 'result' (lines '83'-'88'). +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:85: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:87: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:87: Useless parentheses. +src/net/sf/freecol/client/gui/panel/SelectTributeAmountDialog.java:87: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:49: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:69: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:70: Parameter 'connectController' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:75: Local variable 'cancel' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:85: Found 'DU'-anomaly for variable 'dtcr' (lines '85'-'120'). +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:85: Local variable 'dtcr' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:87: Avoid variables with short names like o +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:87: Avoid variables with short names like t +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:87: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:87: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:87: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:87: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:87: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:88: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:88: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:124: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:134: Parameter 'servers' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:137: Avoid variables with short names like it +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:137: Local variable 'it' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:139: Avoid variables with short names like si +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:139: Local variable 'si' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:162: Found 'UR'-anomaly for variable 'component' (lines '162'-'167'). +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:162: Parameter 'enabled' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:165: Local variable 'components' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:166: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:187: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:187: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:190: A switch statement does not contain a break +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:192: Avoid variables with short names like si +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:192: Local variable 'si' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:196: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:203: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:208: The class 'ServerListTableModel' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:208: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:210: Variables that are final and static should be all capitals, 'columnNames' is not all capitals. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:210: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:218: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:218: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:221: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:221: Parameter 'items' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:221: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:230: Parameter 'items' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:240: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:260: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:282: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:282: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:282: The method 'getValueAt' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:283: Useless parentheses. +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:284: Avoid variables with short names like si +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:284: Found 'DU'-anomaly for variable 'si' (lines '284'-'302'). +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:284: Local variable 'si' could be declared final +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:287: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:287: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:289: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:291: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:291: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:293: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:294: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:294: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:296: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/ServerListPanel.java:298: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:20: Possible God class (WMC=48, ATFD=39, TCC=0.17777777777777778) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:54: The class 'StartGamePanel' has a Cyclomatic Complexity of 5 (Highest = 15). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:54: The class 'StartGamePanel' has a Modified Cyclomatic Complexity of 4 (Highest = 10). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:54: The class 'StartGamePanel' has a Standard Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:58: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:59: Avoid excessively long variable names like MAP_GENERATOR_OPTIONS +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:61: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:63: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:65: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:67: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:69: Avoid excessively long variable names like mapGeneratorOptions +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:69: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:71: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:79: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:84: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:84: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:84: The method 'initialize' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:84: The method 'initialize' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:84: The method 'initialize' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:84: The method initialize() has an NPath complexity of 10032 +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:84: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:89: Local variable 'spec' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:91: Local variable 'gtag' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:92: Local variable 'gof' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:94: Found 'DD'-anomaly for variable 'gog' (lines '94'-'96'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:94: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:94: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:95: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:96: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:100: Local variable 'mtag' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:101: Local variable 'mof' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:103: Found 'DD'-anomaly for variable 'mog' (lines '103'-'105'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:103: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:103: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:104: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:105: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:110: Local variable 'nationOptions' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:115: Found 'DD'-anomaly for variable 'chatScroll' (lines '115'-'140'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:115: Found 'DD'-anomaly for variable 'tableScroll' (lines '115'-'145'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:115: Found 'DU'-anomaly for variable 'chatScroll' (lines '115'-'184'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:115: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:140: Found 'DU'-anomaly for variable 'chatScroll' (lines '140'-'184'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:187: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:216: Found 'UR'-anomaly for variable 'component' (lines '216'-'221'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:216: Parameter 'enabled' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:219: Local variable 'components' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:220: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:241: Found 'UR'-anomaly for variable 'e' (lines '241'-'249'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:242: Local variable 'spec' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:246: Avoid variables with short names like n +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:246: Found 'DD'-anomaly for variable 'n' (lines '246'-'251'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:247: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:248: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:248: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:248: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:249: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:249: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:249: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:251: Found 'DD'-anomaly for variable 'n' (lines '251'-'251'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:255: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:261: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:270: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:270: Parameter 'privateChat' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:270: Parameter 'senderName' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:296: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:296: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:296: The method 'actionPerformed' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:296: The method 'actionPerformed' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:298: Found 'DU'-anomaly for variable 'fcc' (lines '298'-'356'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:299: Found 'DU'-anomaly for variable 'gui' (lines '299'-'356'). +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:303: Local variable 'row' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:304: Local variable 'col' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:306: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:308: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:314: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:320: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:325: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:329: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:330: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:331: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:331: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:337: Avoid variables with short names like go +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:337: Local variable 'go' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:339: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:340: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:344: Local variable 'mgo' could be declared final +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:346: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:346: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:354: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/StartGamePanel.java:374: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:51: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:53: Variables that are final and static should be all capitals, 'memoryKeys' is not all capitals. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:57: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:59: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:60: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:62: Avoid using redundant field initializer for 'data' +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:62: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:68: Avoid unnecessary constructors - the compiler will generate these for you +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:68: Document empty constructor +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:68: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:76: Found 'UR'-anomaly for variable 'e' (lines '76'-'80'). +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:76: Parameter 'statsData' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:76: Unnecessary use of fully qualified name 'java.util.Map' due to existing import 'java.util.Map' +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:78: Avoid variables with short names like i +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:78: Found 'DU'-anomaly for variable 'i' (lines '78'-'84'). +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:79: Local variable 'e' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:82: Found 'DU'-anomaly for variable 'i' (lines '82'-'84'). +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:92: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:100: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:135: Parameter 'column' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:135: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:136: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:136: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:136: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:136: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:137: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:137: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:137: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:137: Useless parentheses. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:138: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:138: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:142: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:155: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:159: Local variable 'serverStatistics' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:160: Local variable 'clientStatistics' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:164: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:169: Local variable 'statsPanel' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:170: Local variable 'scrollPane' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:187: Found 'UR'-anomaly for variable 'k' (lines '187'-'196'). +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:187: Found 'UR'-anomaly for variable 'k' (lines '187'-'200'). +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:187: Parameter 'title' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:188: Parameter 'stats' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:189: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:191: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:191: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:193: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:193: Local variable 'memory' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:194: Avoid variables with short names like ai +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:194: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:194: Local variable 'ai' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:195: Local variable 'k' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:199: Local variable 'k' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:214: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:214: Parameter 'title' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:215: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:218: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:220: Local variable 'table' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:224: Local variable 'scrollPane' could be declared final +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StatisticsPanel.java:227: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/StatusPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/StatusPanel.java:36: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/StatusPanel.java:36: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatusPanel.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/StatusPanel.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/StatusPanel.java:46: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/StatusPanel.java:64: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:61: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:62: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:73: Found 'UR'-anomaly for variable 't' (lines '73'-'78'). +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:73: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:74: Local variable 'node' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:77: Local variable 't' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:78: Local variable 'tile' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:79: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:80: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:80: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:82: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:82: Local variable 'g' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:85: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:85: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:95: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:95: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:95: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:96: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:98: Local variable 'tileType' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:101: Local variable 'movementCost' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:102: Found 'DD'-anomaly for variable 'defenseBonus' (lines '102'-'105'). +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:103: Local variable 'defenceModifiers' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:108: Local variable 'nameLabel' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:112: Local variable 'terrainImage' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:116: Local variable 'resourceList' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:117: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:119: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:148: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:148: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:153: Avoid variables with short names like it +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:153: Local variable 'it' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:155: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:155: Local variable 'ag' could be declared final +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:156: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:159: Avoid variables with short names like ag +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:160: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TerrainDetailPanel.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TilePanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/TilePanel.java:57: The class 'TilePanel' has a Cyclomatic Complexity of 8 (Highest = 21). +src/net/sf/freecol/client/gui/panel/TilePanel.java:57: The class 'TilePanel' has a Modified Cyclomatic Complexity of 8 (Highest = 21). +src/net/sf/freecol/client/gui/panel/TilePanel.java:57: The class 'TilePanel' has a Standard Cyclomatic Complexity of 8 (Highest = 21). +src/net/sf/freecol/client/gui/panel/TilePanel.java:60: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/TilePanel.java:60: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TilePanel.java:62: Avoid unused private fields such as 'COLOPEDIA'. +src/net/sf/freecol/client/gui/panel/TilePanel.java:62: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TilePanel.java:71: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:71: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:71: The constructor 'TilePanel' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/client/gui/panel/TilePanel.java:71: The constructor 'TilePanel' has a Modified Cyclomatic Complexity of 21. +src/net/sf/freecol/client/gui/panel/TilePanel.java:71: The constructor 'TilePanel' has a Standard Cyclomatic Complexity of 21. +src/net/sf/freecol/client/gui/panel/TilePanel.java:77: Local variable 'colopediaButton' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:82: Local variable 'inputMap' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:87: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:94: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:103: Local variable 'ownerName' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:111: Local variable 'settlementName' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:119: Local variable 'defenceBonus' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:125: Local variable 'movementCost' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:130: Local variable 'colonist' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:133: Local variable 'productionType' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:135: Local variable 'output' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:136: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:143: Local variable 'expert' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:149: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TilePanel.java:163: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TilePanel.java:171: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TilePanel.java:175: No need to call String.valueOf to append to a string. +src/net/sf/freecol/client/gui/panel/TilePanel.java:176: No need to call String.valueOf to append to a string. +src/net/sf/freecol/client/gui/panel/TilePanel.java:185: Local variable 'debugPlayer' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:187: Local variable 'values' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:188: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:191: The String literal "newline 5, span, align center" appears 4 times in this file; the first occurrence is on line 191 +src/net/sf/freecol/client/gui/panel/TilePanel.java:193: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:195: Local variable 'cat' could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:196: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TilePanel.java:201: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TilePanel.java:222: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/TilePanel.java:222: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TilePanel.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TilePanel.java:227: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:20: Possible God class (WMC=83, ATFD=67, TCC=0.03985507246376811) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:34: Avoid unused imports such as 'java.util.Arrays' +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:79: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:81: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:81: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:83: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:91: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:91: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:94: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:94: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:103: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:117: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:125: Found 'UR'-anomaly for variable 'goodsType' (lines '125'-'130'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:125: Parameter 'newStop' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:125: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:129: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:130: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:144: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:150: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:150: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:158: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:158: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:166: Found 'UR'-anomaly for variable 'index' (lines '166'-'178'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:166: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:166: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:167: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:168: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:170: Found 'DU'-anomaly for variable 'label' (lines '170'-'190'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:170: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:172: Local variable 'newLabel' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:175: Local variable 'indices' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:177: Local variable 'index' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:178: Local variable 'stop' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:182: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:185: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:196: Found 'UR'-anomaly for variable 'stopIndex' (lines '196'-'205'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:196: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:196: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:197: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:199: Found 'DU'-anomaly for variable 'label' (lines '199'-'224'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:199: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:202: Local variable 'indices' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:204: Local variable 'stopIndex' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:205: Local variable 'stop' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:207: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:207: Local variable 'cargo' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:218: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:218: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:218: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:227: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:227: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:227: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:227: Parameter 'flavors' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:227: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:228: Avoid variables with short names like f +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:232: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:235: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:235: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:243: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:244: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:245: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:246: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:247: Parameter 'cellHasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:248: Local variable 'fcgo' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:248: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:254: Useless parentheses. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:254: Useless parentheses. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:256: Useless parentheses. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:256: Useless parentheses. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:267: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:270: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:272: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:272: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:285: Found 'UR'-anomaly for variable 'child' (lines '285'-'288'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:285: Parameter 'enable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:287: Local variable 'child' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:295: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:297: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:300: Parameter 'stops' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:300: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:304: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:314: Parameter 'flavor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:315: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:315: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:330: Parameter 'flavor' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:331: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:338: Each class should declare at least one constructor +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:344: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:344: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:344: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:344: Parameter 'flavors' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:345: Avoid variables with short names like f +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:352: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:352: Found 'UR'-anomaly for variable 'index' (lines '352'-'357'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:352: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:353: Local variable 'list' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:354: Found 'DU'-anomaly for variable 'model' (lines '354'-'360'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:354: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:355: Local variable 'stops' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:356: Local variable 'index' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:356: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:357: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:366: Avoid variables with short names like c +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:366: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:374: Found 'UR'-anomaly for variable 'stop' (lines '374'-'386'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:374: Found 'UR'-anomaly for variable 'stop' (lines '374'-'389'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:374: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:374: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:375: Local variable 'stl' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:377: Use equals() to compare object references. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:379: Local variable 'stops' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:380: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:381: Local variable 'model' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:383: Found 'DU'-anomaly for variable 'index' (lines '383'-'396'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:384: Local variable 'stop' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:393: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:402: Found 'UR'-anomaly for variable 'o' (lines '402'-'410'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:402: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:402: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:403: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:406: Local variable 'stopList' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:407: Found 'DU'-anomaly for variable 'listModel' (lines '407'-'416'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:407: Local variable 'listModel' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:409: Local variable 'o' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:410: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:413: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:419: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:421: Avoid excessively long variable names like SELECTED_COMPONENT +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:421: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:421: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:422: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:422: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:424: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:438: Found 'UR'-anomaly for variable 'cargo' (lines '438'-'468'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:438: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:439: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:440: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:441: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:442: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:443: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:443: Useless parentheses. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:443: Useless parentheses. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:448: Local variable 'location' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:449: Found 'DU'-anomaly for variable 'lib' (lines '449'-'472'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:449: Local variable 'lib' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:450: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:452: Local variable 'europe' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:453: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:458: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:467: Local variable 'cargo' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:468: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:480: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:480: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:483: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:483: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:486: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:486: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:486: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:489: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:489: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:492: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:492: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:495: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:495: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:498: Avoid excessively long variable names like destinationSelector +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:498: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:498: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:501: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:501: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:504: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:504: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:507: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:507: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:510: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:510: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:513: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:513: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:522: Found 'UR'-anomaly for variable 'colony' (lines '522'-'576'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:522: Found 'UR'-anomaly for variable 'colony' (lines '522'-'576'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:522: Found 'UR'-anomaly for variable 'colony' (lines '522'-'576'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:522: Found 'UR'-anomaly for variable 'stop' (lines '522'-'537'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:522: Found 'UR'-anomaly for variable 'stop' (lines '522'-'537'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:522: Found 'UR'-anomaly for variable 'stop' (lines '522'-'537'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:522: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:523: Parameter 'newRoute' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:536: Local variable 'stop' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:548: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:548: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:548: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:555: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:555: Document empty method +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:555: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:555: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:558: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:558: Document empty method +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:558: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:558: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:561: Local variable 'tradeRouteView' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:563: Local variable 'nameLabel' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:566: Local variable 'destinationLabel' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:570: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:575: Local variable 'colony' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:582: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:587: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:592: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:602: Local variable 'cancelButton' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:611: The String literal "span" appears 4 times in this file; the first occurrence is on line 611 +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:625: Local variable 'selectedStop' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:638: Found 'UR'-anomaly for variable 'comp' (lines '638'-'651'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:639: Found 'DD'-anomaly for variable 'startIndex' (lines '639'-'643'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:639: Found 'DD'-anomaly for variable 'startIndex' (lines '639'-'646'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:640: Found 'DD'-anomaly for variable 'endIndex' (lines '640'-'644'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:640: Found 'DD'-anomaly for variable 'endIndex' (lines '640'-'647'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:641: Local variable 'sel' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:649: Found 'DU'-anomaly for variable 'cargo' (lines '649'-'670'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:649: Local variable 'cargo' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:650: Local variable 'comp' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:651: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:652: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:654: Found 'DU'-anomaly for variable 'maxIndex' (lines '654'-'670'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:656: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:656: Local variable 'id' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:657: Local variable 'fcgo' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:657: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:659: Local variable 'stop' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:660: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:675: Found 'UR'-anomaly for variable 'index' (lines '675'-'679'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:676: Found 'DU'-anomaly for variable 'count' (lines '676'-'693'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:677: Found 'DD'-anomaly for variable 'lastIndex' (lines '677'-'681'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:677: Found 'DU'-anomaly for variable 'lastIndex' (lines '677'-'693'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:678: Local variable 'index' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:680: Found 'DU'-anomaly for variable 'count' (lines '680'-'693'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:681: Found 'DD'-anomaly for variable 'lastIndex' (lines '681'-'681'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:681: Found 'DU'-anomaly for variable 'lastIndex' (lines '681'-'693'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:704: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:724: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:724: Avoid unused local variables such as 'player'. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:724: Found 'DU'-anomaly for variable 'player' (lines '724'-'741'). +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:724: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:734: Local variable 'err' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:736: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:738: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:750: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:750: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:752: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:752: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:755: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:776: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:776: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:777: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:778: Local variable 'idx' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:780: Local variable 'stop' could be declared final +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:797: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:798: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:799: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:801: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:802: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:803: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:804: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:805: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:806: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:807: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TradeRouteInputPanel.java:808: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/TrainPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/TrainPanel.java:38: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/UnitButton.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitButton.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitButton.java:47: Avoid variables with short names like am +src/net/sf/freecol/client/gui/panel/UnitButton.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitButton.java:47: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitButton.java:55: Avoid variables with short names like am +src/net/sf/freecol/client/gui/panel/UnitButton.java:55: Parameter 'actionId' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:55: Parameter 'am' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:72: Avoid variables with short names like a +src/net/sf/freecol/client/gui/panel/UnitButton.java:72: Parameter 'a' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:72: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitButton.java:78: Avoid variables with short names like bi +src/net/sf/freecol/client/gui/panel/UnitButton.java:78: Local variable 'bi' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitButton.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitButton.java:97: Avoid variables with short names like a +src/net/sf/freecol/client/gui/panel/UnitButton.java:97: Parameter 'a' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:97: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitButton.java:101: The class 'UnitButtonActionPropertyChangeListener' has a Cyclomatic Complexity of 6 (Highest = 11). +src/net/sf/freecol/client/gui/panel/UnitButton.java:101: The class 'UnitButtonActionPropertyChangeListener' has a Modified Cyclomatic Complexity of 6 (Highest = 10). +src/net/sf/freecol/client/gui/panel/UnitButton.java:101: The class 'UnitButtonActionPropertyChangeListener' has a Standard Cyclomatic Complexity of 6 (Highest = 10). +src/net/sf/freecol/client/gui/panel/UnitButton.java:101: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitButton.java:102: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitButton.java:102: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitButton.java:104: Parameter 'button' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:109: Avoid variables with short names like e +src/net/sf/freecol/client/gui/panel/UnitButton.java:109: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:109: The method 'propertyChange' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/client/gui/panel/UnitButton.java:109: The method 'propertyChange' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/UnitButton.java:109: The method 'propertyChange' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/UnitButton.java:109: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitButton.java:110: Found 'DU'-anomaly for variable 'propertyName' (lines '110'-'146'). +src/net/sf/freecol/client/gui/panel/UnitButton.java:110: Local variable 'propertyName' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:111: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:112: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:113: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:116: Local variable 'enabledState' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:119: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:120: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:123: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:124: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:127: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:128: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:131: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:132: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:135: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:136: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:139: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitButton.java:140: Avoid variables with short names like mn +src/net/sf/freecol/client/gui/panel/UnitButton.java:140: Local variable 'mn' could be declared final +src/net/sf/freecol/client/gui/panel/UnitButton.java:143: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:54: Avoid unused imports such as 'net.sf.freecol.common.util.RandomChoice' +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:60: The class 'UnitDetailPanel' has a Cyclomatic Complexity of 11 (Highest = 29). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:60: The class 'UnitDetailPanel' has a Modified Cyclomatic Complexity of 9 (Highest = 24). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:60: The class 'UnitDetailPanel' has a Standard Cyclomatic Complexity of 9 (Highest = 24). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:72: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:73: Parameter 'colopediaPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:84: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Avoid really long methods. +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Avoid variables with short names like id +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Found 'UR'-anomaly for variable 'buildingType' (lines '93'-'139'). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Found 'UR'-anomaly for variable 'goodsType' (lines '93'-'194'). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Found 'UR'-anomaly for variable 'nation' (lines '93'-'166'). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Found 'UR'-anomaly for variable 'productionBonus' (lines '93'-'205'). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Found 'UR'-anomaly for variable 'school' (lines '93'-'149'). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: Parameter 'panel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: The method 'buildDetail' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: The method 'buildDetail' has a Modified Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: The method 'buildDetail' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:93: The method buildDetail() has an NPath complexity of 1745280 +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:94: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:97: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:100: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:104: The String literal "right" appears 6 times in this file; the first occurrence is on line 104 +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:117: Local variable 'player' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:119: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:119: Local variable 'europe' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:121: Found 'DD'-anomaly for variable 'price' (lines '121'-'123'). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:137: Local variable 'schools' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:138: Local variable 'buildingType' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:148: Local variable 'school' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:149: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:155: Found 'DU'-anomaly for variable 'count' (lines '155'-'233'). +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:159: Local variable 'nations' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:160: Avoid variables with short names like nt +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:160: Avoid variables with short names like ut +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:165: Local variable 'nation' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:166: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:179: Local variable 'abilities' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:183: Local variable 'textPane' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:184: Local variable 'doc' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:187: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:187: Avoid empty catch blocks +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:192: Local variable 'bonusList' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:193: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:196: Local variable 'bonusNumber' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:198: Local variable 'template' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:198: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:202: Local variable 'productionPanel' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:204: Local variable 'productionBonus' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:205: Local variable 'goodsType' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:206: Local variable 'bonus' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:215: Local variable 'required' could be declared final +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:217: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitDetailPanel.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/UnitLabel.java:20: Possible God class (WMC=54, ATFD=71, TCC=0.19696969696969696) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:60: The class 'UnitLabel' has a Cyclomatic Complexity of 4 (Highest = 25). +src/net/sf/freecol/client/gui/panel/UnitLabel.java:60: The class 'UnitLabel' has a Modified Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/client/gui/panel/UnitLabel.java:60: The class 'UnitLabel' has a Standard Cyclomatic Complexity of 3 (Highest = 22). +src/net/sf/freecol/client/gui/panel/UnitLabel.java:64: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:64: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:66: enumCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:82: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:82: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:84: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:84: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:86: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:88: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:90: Avoid using redundant field initializer for 'isSmall' +src/net/sf/freecol/client/gui/panel/UnitLabel.java:90: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:90: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:92: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:92: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:94: Avoid excessively long variable names like useTileImageLibrary +src/net/sf/freecol/client/gui/panel/UnitLabel.java:94: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:94: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitLabel.java:103: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:103: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:114: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:114: Parameter 'isSmall' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:114: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:118: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/UnitLabel.java:127: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:127: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:128: Parameter 'ignoreLocation' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:128: Parameter 'isSmall' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:133: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/UnitLabel.java:144: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/UnitLabel.java:144: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:144: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:145: Parameter 'ignoreLocation' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:145: Parameter 'isSmall' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:146: Avoid excessively long variable names like useTileImageLibrary +src/net/sf/freecol/client/gui/panel/UnitLabel.java:146: Parameter 'useTileImageLibrary' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:174: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/UnitLabel.java:174: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:185: Avoid variables with short names like b +src/net/sf/freecol/client/gui/panel/UnitLabel.java:185: Parameter 'b' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:194: Parameter 'isSmall' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:199: Local variable 'imageIcon' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:200: Local variable 'disabledImageIcon' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:208: Local variable 'imageIcon' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:209: Local variable 'disabledImageIcon' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:221: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:221: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:248: Parameter 'label' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:258: Avoid variables with short names like g +src/net/sf/freecol/client/gui/panel/UnitLabel.java:258: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:258: The method 'paintComponent' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:258: The method paintComponent() has an NPath complexity of 560 +src/net/sf/freecol/client/gui/panel/UnitLabel.java:259: Found 'DU'-anomaly for variable 'player' (lines '259'-'316'). +src/net/sf/freecol/client/gui/panel/UnitLabel.java:260: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:260: Found 'DU'-anomaly for variable 'lib' (lines '260'-'316'). +src/net/sf/freecol/client/gui/panel/UnitLabel.java:264: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:264: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:274: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitLabel.java:278: Local variable 'workType' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:280: Local variable 'production' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:280: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:282: Avoid variables with short names like pl +src/net/sf/freecol/client/gui/panel/UnitLabel.java:282: Local variable 'pl' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:292: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:296: Local variable 'underRepair' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:297: Local variable 'underRepair1' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:297: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:298: Local variable 'underRepair2' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:298: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:299: Local variable 'font' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:301: Local variable 'repairImage1' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:302: Local variable 'repairImage2' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:303: Local variable 'textHeight' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:304: Local variable 'leftIndent' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:308: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:308: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:312: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:312: Useless parentheses. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:334: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:346: Avoid variables with short names like wl +src/net/sf/freecol/client/gui/panel/UnitLabel.java:346: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:369: Avoid variables with short names like ae +src/net/sf/freecol/client/gui/panel/UnitLabel.java:369: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:369: The method 'actionPerformed' has a Cyclomatic Complexity of 25. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:369: The method 'actionPerformed' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:369: The method 'actionPerformed' has a Standard Cyclomatic Complexity of 22. +src/net/sf/freecol/client/gui/panel/UnitLabel.java:371: Found 'DU'-anomaly for variable 'spec' (lines '371'-'439'). +src/net/sf/freecol/client/gui/panel/UnitLabel.java:371: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:372: Found 'DU'-anomaly for variable 'igc' (lines '372'-'439'). +src/net/sf/freecol/client/gui/panel/UnitLabel.java:373: Local variable 'args' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:373: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:374: Avoid variables with short names like gt +src/net/sf/freecol/client/gui/panel/UnitLabel.java:375: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:375: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:375: Switch statements should have a default label +src/net/sf/freecol/client/gui/panel/UnitLabel.java:376: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:376: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:378: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:379: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:382: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/UnitLabel.java:382: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitLabel.java:383: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:384: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:384: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:385: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/UnitLabel.java:387: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitLabel.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:387: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/UnitLabel.java:390: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitLabel.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:391: Avoid assignments in operands +src/net/sf/freecol/client/gui/panel/UnitLabel.java:391: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:397: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/UnitLabel.java:397: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitLabel.java:398: Local variable 'building' could be declared final +src/net/sf/freecol/client/gui/panel/UnitLabel.java:399: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:400: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitLabel.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:401: Avoid assignments in operands +src/net/sf/freecol/client/gui/panel/UnitLabel.java:401: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:417: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:417: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:426: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:432: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitLabel.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/UnitPanel.java:35: Abstract classes should be named AbstractXXX +src/net/sf/freecol/client/gui/panel/UnitPanel.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/UnitPanel.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/UnitPanel.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/UnitPanel.java:54: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/panel/UnitPanel.java:54: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:54: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:54: Parameter 'portPanel' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:55: Avoid throwing raw exception types. +src/net/sf/freecol/client/gui/panel/UnitPanel.java:55: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitPanel.java:69: Local variable 'active' could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitPanel.java:70: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitPanel.java:70: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitPanel.java:83: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/client/gui/panel/UnitPanel.java:90: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/client/gui/panel/UnitPanel.java:97: Found 'UR'-anomaly for variable 'unit' (lines '97'-'102'). +src/net/sf/freecol/client/gui/panel/UnitPanel.java:101: Local variable 'unit' could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:102: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/UnitPanel.java:104: Local variable 'unitLabel' could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:105: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/UnitPanel.java:106: Local variable 'tradeRoute' could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitPanel.java:155: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/client/gui/panel/UnitPanel.java:165: Found 'UR'-anomaly for variable 'component' (lines '165'-'167'). +src/net/sf/freecol/client/gui/panel/UnitPanel.java:165: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:166: Local variable 'component' could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:168: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/UnitPanel.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/UnitPanel.java:171: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/panel/UnitPanel.java:185: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/UnitPanel.java:186: There is log block not surrounded by if +src/net/sf/freecol/client/gui/panel/UnitPanel.java:203: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/Utility.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Utility.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/client/gui/panel/Utility.java:20: Possible God class (WMC=53, ATFD=50, TCC=0.005263157894736842) +src/net/sf/freecol/client/gui/panel/Utility.java:64: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/client/gui/panel/Utility.java:64: The class 'Utility' has a Cyclomatic Complexity of 1 (Highest = 14). +src/net/sf/freecol/client/gui/panel/Utility.java:64: The class 'Utility' has a Modified Cyclomatic Complexity of 1 (Highest = 10). +src/net/sf/freecol/client/gui/panel/Utility.java:64: The class 'Utility' has a Standard Cyclomatic Complexity of 1 (Highest = 10). +src/net/sf/freecol/client/gui/panel/Utility.java:64: This class has too many methods, consider refactoring it. +src/net/sf/freecol/client/gui/panel/Utility.java:81: Avoid excessively long variable names like TRIVIAL_LINE_BORDER +src/net/sf/freecol/client/gui/panel/Utility.java:84: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:87: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:93: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:96: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:99: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:104: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:107: Avoid excessively long variable names like SIMPLE_LINE_BORDER +src/net/sf/freecol/client/gui/panel/Utility.java:107: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:111: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:116: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:121: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:126: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:133: Avoid excessively long variable names like DEFAULT_TEXT_COLUMNS +src/net/sf/freecol/client/gui/panel/Utility.java:139: Avoid using redundant field initializer for 'STYLE_CONTEXT' +src/net/sf/freecol/client/gui/panel/Utility.java:139: Only variables that are final should contain underscores (except for underscores in standard prefix/suffix), 'STYLE_CONTEXT' is not final. +src/net/sf/freecol/client/gui/panel/Utility.java:139: The field name indicates a constant but its modifiers do not +src/net/sf/freecol/client/gui/panel/Utility.java:139: Variables should start with a lowercase character, 'STYLE_CONTEXT' starts with uppercase character. +src/net/sf/freecol/client/gui/panel/Utility.java:141: Parameter 'font' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:141: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:142: Local variable 'defaultStyle' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Utility.java:146: Local variable 'regular' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:150: Local variable 'buttonStyle' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:153: Local variable 'right' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:158: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Utility.java:167: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:167: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:167: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:168: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:179: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Utility.java:193: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:193: Parameter 'val' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:193: The method 'getMessageButton' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/panel/Utility.java:193: The method 'getMessageButton' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/Utility.java:193: The method 'getMessageButton' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/client/gui/panel/Utility.java:194: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:194: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:195: Found 'DD'-anomaly for variable 'link' (lines '195'-'198'). +src/net/sf/freecol/client/gui/panel/Utility.java:195: Found 'DD'-anomaly for variable 'link' (lines '195'-'202'). +src/net/sf/freecol/client/gui/panel/Utility.java:195: Found 'DD'-anomaly for variable 'link' (lines '195'-'205'). +src/net/sf/freecol/client/gui/panel/Utility.java:195: Found 'DD'-anomaly for variable 'link' (lines '195'-'209'). +src/net/sf/freecol/client/gui/panel/Utility.java:196: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Utility.java:197: Local variable 'settlement' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/Utility.java:198: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/Utility.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:201: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Utility.java:201: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Utility.java:203: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Utility.java:207: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/Utility.java:208: These nested if statements could be combined +src/net/sf/freecol/client/gui/panel/Utility.java:212: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/Utility.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:223: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:224: Local variable 'textArea' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:239: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:251: Parameter 'columns' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:251: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:252: Local variable 'textArea' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:266: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:266: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:267: Local variable 'textArea' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:278: Local variable 'document' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:281: Local variable 'textPane' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:294: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:295: Local variable 'textPane' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:300: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/Utility.java:309: Parameter 'bottom' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:309: Parameter 'left' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:309: Parameter 'right' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:309: Parameter 'top' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:313: Parameter 'component' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:313: Parameter 'left' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:313: Parameter 'top' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:313: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:314: Parameter 'bottom' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:314: Parameter 'right' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:326: Parameter 'component' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:327: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:328: Avoid variables with short names like tb +src/net/sf/freecol/client/gui/panel/Utility.java:328: Local variable 'tb' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:329: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:338: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:348: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:361: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:361: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:372: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:382: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:393: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:394: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:405: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:405: Parameter 'small' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:406: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/Utility.java:420: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:420: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:421: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:422: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:423: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:430: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:430: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:431: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:432: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:433: Local variable 'text' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:434: Local variable 'header' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:441: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:441: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/Utility.java:442: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:453: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:463: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:473: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:474: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:487: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:487: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:488: Parameter 'alignment' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:489: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:500: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:510: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:520: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:531: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:531: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:541: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:552: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:553: Parameter 'icon' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:564: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:565: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:575: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:586: Parameter 'columns' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:586: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:596: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:607: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:608: Parameter 'columns' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:619: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:619: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:631: Parameter 'comp' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/Utility.java:632: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/VictoryDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/VictoryDialog.java:46: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/VictoryDialog.java:46: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/VictoryDialog.java:49: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/VictoryDialog.java:53: Local variable 'image' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:50: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:50: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:52: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:62: Parameter 'frame' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:62: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:63: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:68: Local variable 'type' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:70: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:74: Local variable 'scrollPane' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:81: Local variable 'panel' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:87: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:97: Found 'UR'-anomaly for variable 'c' (lines '97'-'101'). +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:98: Local variable 'result' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:100: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:106: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:111: headerCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:113: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:113: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:115: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:115: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:117: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:117: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:119: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:119: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:121: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:123: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:126: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:126: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:126: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:127: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:133: Avoid using final local variables, turn them into fields +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:140: Local variable 'exportData' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:143: Local variable 'goods' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:145: Local variable 'goodsLabel' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:151: Avoid unused local variables such as 'str'. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:151: Local variable 'str' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:152: Local variable 'lowLevelModel' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:160: Local variable 'highLevelModel' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:178: Local variable 'exportLevelModel' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:180: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:180: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:189: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:190: Local variable 'lowLevelValue' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:192: Local variable 'highLevelValue' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:192: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:192: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:194: Local variable 'exportLevelValue' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:196: Local variable 'exportData' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:197: Local variable 'changed' could be declared final +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:197: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:197: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:198: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:198: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:199: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:199: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:200: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:200: Useless parentheses. +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/panel/WarehouseDialog.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:65: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:65: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:72: Avoid variables with short names like wl +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:75: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:75: Local variable 'attendedModifiers' could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:77: Avoid excessively long variable names like unattendedModifiers +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:77: Local variable 'unattendedModifiers' could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:82: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:114: Avoid using Literals in Conditional Statements +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:120: Local variable 'bigFont' could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:122: Local variable 'finalLabel' could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:126: Local variable 'finalResult' could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:145: Found 'UR'-anomaly for variable 'm' (lines '145'-'147'). +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:145: Parameter 'modifiers' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:145: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:146: Local variable 'm' could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:147: Local variable 'mLabels' could be declared final +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:150: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/panel/WorkProductionPanel.java:154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:38: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:45: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:45: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:45: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:45: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:45: Unnecessary use of fully qualified name 'javax.swing.JComponent' due to existing import 'javax.swing.JComponent' +src/net/sf/freecol/client/gui/plaf/FreeColBrightPanelUI.java:45: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:46: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:49: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:49: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:49: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:54: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:54: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:54: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:61: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:61: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:61: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:61: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:61: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:69: Avoid variables with short names like a +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:69: Local variable 'a' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:70: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:71: Avoid variables with short names like p +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:71: Local variable 'p' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:73: Local variable 'rollover' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:81: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:81: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:81: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:81: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:81: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:83: Local variable 'g2d' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:84: Local variable 'size' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:85: Local variable 'oldComposite' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:86: Local variable 'oldColor' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:89: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColButtonUI.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:34: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:34: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:34: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:47: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:47: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:47: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:47: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColCheckBoxUI.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:48: The class 'FreeColComboBoxRenderer' has a Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:48: The class 'FreeColComboBoxRenderer' has a Modified Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:48: The class 'FreeColComboBoxRenderer' has a Standard Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:51: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:51: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:53: Avoid excessively long variable names like SELECTED_COMPONENT +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:56: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:74: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:86: Parameter 'localize' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:86: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:92: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:104: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:105: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:105: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:106: Parameter 'isSelected' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:107: Parameter 'hasFocus' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:108: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:108: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:121: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:121: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:121: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:121: The method 'setLabelValues' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:121: The method 'setLabelValues' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:121: The method 'setLabelValues' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:130: Local variable 'string' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:132: Avoid variables with short names like nd +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:132: Local variable 'nd' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:134: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:139: Local variable 'named' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:140: Local variable 'nad' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:141: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:142: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:144: Avoid variables with short names like id +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:144: Local variable 'id' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:146: Avoid variables with short names like nd +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:146: Found 'DD'-anomaly for variable 'nd' (lines '146'-'149'). +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:148: Local variable 'realname' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:149: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:152: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:154: There is log block not surrounded by if +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:159: headerCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:161: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:161: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:166: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:166: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:166: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:167: Local variable 'g2d' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:168: Local variable 'oldComposite' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:169: Local variable 'oldColor' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:181: headerCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:183: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxRenderer.java:183: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:33: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:33: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:33: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:39: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:39: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:39: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColComboBoxUI.java:46: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:36: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:36: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:36: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:41: Parameter 'filechooser' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:41: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:46: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:47: Local variable 'buttonPanel' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:48: Local variable 'buttons' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:48: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:49: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:51: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColFileChooserUI.java:51: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:34: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:34: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:34: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:47: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:47: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:47: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:47: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLabelUI.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:37: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:37: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:37: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:43: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:43: Overriding method merely calls super +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:43: Overriding method merely calls super +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:43: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:43: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:48: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:48: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:48: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:48: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColListUI.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:20: High amount of different objects as members denotes a high coupling +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:46: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:48: Variables that are final and static should be all capitals, 'uiClasses' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:48: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:81: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:86: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:91: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:96: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:101: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:106: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:111: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:123: Found 'UR'-anomaly for variable 'uiClass' (lines '123'-'129'). +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:124: Avoid variables with short names like u +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:124: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:127: Found 'DU'-anomaly for variable 'offset' (lines '127'-'187'). +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:127: Local variable 'offset' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:128: Local variable 'uiClass' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:129: Local variable 'name' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:133: Local variable 'shortName' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:140: Local variable 'brightPanelUI' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:156: Avoid excessively long variable names like transparentPanelUI +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:156: Local variable 'transparentPanelUI' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:170: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:172: Avoid variables with short names like im +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:172: Local variable 'im' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:183: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:195: Parameter 'fclaf' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:210: Parameter 'defaultFont' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:211: Avoid variables with short names like u +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:211: Local variable 'u' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:212: Local variable 'keys' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:214: Local variable 'key' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColLookAndFeel.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:35: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:35: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:38: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:38: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:38: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:43: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:43: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:43: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:43: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:43: Unnecessary use of fully qualified name 'javax.swing.JComponent' due to existing import 'javax.swing.JComponent' +src/net/sf/freecol/client/gui/plaf/FreeColMenuBarUI.java:43: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:34: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:34: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:34: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:47: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:47: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:47: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:47: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColMenuItemUI.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:20: Possible God class (WMC=49, ATFD=33, TCC=0.07142857142857142) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:51: A class which only has private constructors should be final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:51: The class 'FreeColOptionPaneUI' has a Cyclomatic Complexity of 5 (Highest = 15). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:51: The class 'FreeColOptionPaneUI' has a Modified Cyclomatic Complexity of 5 (Highest = 15). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:51: The class 'FreeColOptionPaneUI' has a Standard Cyclomatic Complexity of 5 (Highest = 15). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:53: Avoid excessively long variable names like initialFocusComponent +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:53: Avoid using redundant field initializer for 'initialFocusComponent' +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:57: Avoid using redundant field initializer for 'newButtons' +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:60: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:62: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:62: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:62: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:66: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:76: Parameter 'nButtons' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:77: Useless parentheses. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:77: Useless parentheses. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:90: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:90: Parameter 'buttons' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:90: The method 'prepareButtons' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:90: The method 'prepareButtons' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:90: The method 'prepareButtons' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:90: The method prepareButtons() has an NPath complexity of 504 +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:91: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:93: Found 'DU'-anomaly for variable 'okLabel' (lines '93'-'134'). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:94: Found 'DU'-anomaly for variable 'cancelLabel' (lines '94'-'134'). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:97: Found 'DD'-anomaly for variable 'maxHeight' (lines '97'-'121'). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:97: Found 'DD'-anomaly for variable 'maxWidth' (lines '97'-'120'). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:97: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:99: Avoid variables with short names like b +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:101: Avoid variables with short names like ci +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:101: Local variable 'ci' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:102: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:103: Local variable 'icon' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:104: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:105: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:106: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:108: Avoid using if...else statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:109: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:111: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:114: Local variable 'label' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:115: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:117: Avoid using if...else statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:118: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:122: Local variable 'buttonListener' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:123: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:127: Found 'DU'-anomaly for variable 'dimension' (lines '127'-'134'). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:127: Local variable 'dimension' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:129: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:144: Local variable 'buttons' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:165: Parameter 'buttons' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:165: Parameter 'container' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:165: The method 'addButtonComponents' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:165: The method 'addButtonComponents' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:165: The method 'addButtonComponents' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:166: Parameter 'initialIndex' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:167: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:170: Avoid variables with short names like b +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:170: Local variable 'b' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:172: Avoid variables with short names like e +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:174: Local variable 'button' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:175: Local variable 'root' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:176: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:189: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:196: Avoid using if statements without curly braces +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:205: Found 'DD'-anomaly for variable 'prefer' (lines '205'-'206'). +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:216: Avoid variables with short names like op +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:216: Parameter 'op' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:221: Local variable 'root' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:236: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:236: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:236: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColOptionPaneUI.java:236: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:32: A class which only has private constructors should be final +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:34: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:37: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:39: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:39: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:39: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:44: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:44: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:44: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:44: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:44: Unnecessary use of fully qualified name 'javax.swing.JComponent' due to existing import 'javax.swing.JComponent' +src/net/sf/freecol/client/gui/plaf/FreeColPanelUI.java:44: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:37: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:45: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:45: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:45: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:45: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:45: Unnecessary use of fully qualified name 'javax.swing.JComponent' due to existing import 'javax.swing.JComponent' +src/net/sf/freecol/client/gui/plaf/FreeColPopupMenuUI.java:45: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:34: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:34: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:34: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:47: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:47: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:47: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:47: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColRadioButtonUI.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:34: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:34: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:34: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:47: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:47: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:47: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:47: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColScrollPaneUI.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:38: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:38: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:41: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:41: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:41: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:46: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:46: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:46: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:46: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:46: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:47: Local variable 'g2d' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:48: Local variable 'oldComposite' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:48: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:49: Local variable 'oldColor' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:49: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:50: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:51: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:52: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:53: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColSelectedPanelUI.java:54: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:36: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:36: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:36: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:42: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:42: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:42: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:45: Avoid variables with short names like j +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:45: Local variable 'j' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:46: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:48: Local variable 'dtcr' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:48: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:49: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:53: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:53: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:53: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:53: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableHeaderUI.java:53: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:34: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:34: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:34: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:47: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:47: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:47: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:47: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTableUI.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:37: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:40: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:44: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:44: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:44: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:49: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:49: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:49: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:55: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:55: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:55: Unnecessary use of fully qualified name 'java.awt.Graphics' due to existing import 'java.awt.Graphics' +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:55: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:56: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:56: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextAreaUI.java:57: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:37: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:40: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:44: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:44: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:44: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:49: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:49: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:49: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:55: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:55: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:55: Unnecessary use of fully qualified name 'java.awt.Graphics' due to existing import 'java.awt.Graphics' +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:55: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:56: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:56: Local variable 'c' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTextFieldUI.java:58: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:44: A class which only has private constructors should be final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:46: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:50: Variables that are final and static should be all capitals, 'frc' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:50: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:53: Variables that are final and static should be all capitals, 'margin' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:53: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:54: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:55: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:57: Variables that are final and static should be all capitals, 'lineBreak' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:57: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:64: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:64: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:68: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:68: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:73: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:73: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:73: Found 'UR'-anomaly for variable 'line' (lines '73'-'84'). +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:73: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:73: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:73: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:80: Found 'DU'-anomaly for variable 'graphics' (lines '80'-'105'). +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:80: Local variable 'graphics' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:81: Avoid variables with short names like x +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:81: Found 'DU'-anomaly for variable 'x' (lines '81'-'105'). +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:81: Local variable 'x' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:82: Avoid variables with short names like y +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:82: Found 'DU'-anomaly for variable 'y' (lines '82'-'105'). +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:83: Local variable 'line' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:88: Local variable 'styledText' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:89: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:91: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:91: Local variable 'measurer' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:95: Local variable 'layout' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:97: This statement may have some unnecessary parentheses +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:97: Useless parentheses. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:97: Useless parentheses. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:98: Avoid variables with short names like dx +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:98: Local variable 'dx' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:99: Useless parentheses. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:99: Useless parentheses. +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:108: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:108: Found 'UR'-anomaly for variable 'line' (lines '108'-'117'). +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:108: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:108: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:109: Local variable 'tipText' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:111: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:114: Avoid variables with short names like x +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:114: Found 'DD'-anomaly for variable 'x' (lines '114'-'129'). +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:115: Avoid variables with short names like y +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:116: Local variable 'line' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:121: Local variable 'styledText' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:122: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:123: Avoid instantiating new objects inside loops +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:123: Local variable 'measurer' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:127: Local variable 'layout' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:140: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:140: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:140: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:145: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:145: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColToolTipUI.java:145: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:37: Variables that are final and static should be all capitals, 'sharedInstance' is not all capitals. +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:37: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:40: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:40: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:45: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:45: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:45: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:45: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:45: Unnecessary use of fully qualified name 'javax.swing.JComponent' due to existing import 'javax.swing.JComponent' +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:45: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:50: Local variable 'width' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:51: Local variable 'height' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:53: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:53: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:54: Local variable 'oldComposite' could be declared final +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:54: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:55: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:56: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:57: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/FreeColTransparentPanelUI.java:58: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:32: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:36: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:48: Avoid variables with short names like c +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:48: Avoid variables with short names like g +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:48: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:48: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:49: Avoid variables with short names like g2 +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:49: Found 'DU'-anomaly for variable 'g2' (lines '49'-'58'). +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:49: Local variable 'g2' could be declared final +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:50: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:51: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:54: Local variable 'textAA' could be declared final +src/net/sf/freecol/client/gui/plaf/LAFUtilities.java:56: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/client/gui/video/VideoComponent.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/video/VideoComponent.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/client/gui/video/VideoComponent.java:41: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/video/VideoComponent.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/gui/video/VideoComponent.java:46: fieldCommentRequirement Required +src/net/sf/freecol/client/gui/video/VideoComponent.java:55: It is a good practice to call super() in a constructor +src/net/sf/freecol/client/gui/video/VideoComponent.java:55: Parameter 'mute' is not assigned and could be declared final +src/net/sf/freecol/client/gui/video/VideoComponent.java:55: Parameter 'video' is not assigned and could be declared final +src/net/sf/freecol/client/gui/video/VideoComponent.java:122: Avoid variables with short names like l +src/net/sf/freecol/client/gui/video/VideoComponent.java:122: Parameter 'l' is not assigned and could be declared final +src/net/sf/freecol/client/gui/video/VideoComponent.java:122: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/video/VideoComponent.java:129: Avoid variables with short names like l +src/net/sf/freecol/client/gui/video/VideoComponent.java:129: Parameter 'l' is not assigned and could be declared final +src/net/sf/freecol/client/gui/video/VideoComponent.java:129: publicMethodCommentRequirement Required +src/net/sf/freecol/client/gui/video/VideoComponent.java:177: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/client/gui/video/VideoListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/gui/video/VideoListener.java:30: Avoid modifiers which are implied by the context +src/net/sf/freecol/client/networking/UserServerAPI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/client/networking/UserServerAPI.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/client/networking/UserServerAPI.java:34: fieldCommentRequirement Required +src/net/sf/freecol/client/networking/UserServerAPI.java:36: Parameter 'gui' is not assigned and could be declared final +src/net/sf/freecol/client/networking/UserServerAPI.java:36: publicMethodCommentRequirement Required +src/net/sf/freecol/client/networking/UserServerAPI.java:42: Parameter 'complaint' is not assigned and could be declared final +src/net/sf/freecol/client/networking/UserServerAPI.java:42: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/networking/UserServerAPI.java:49: Parameter 'reply' is not assigned and could be declared final +src/net/sf/freecol/client/networking/UserServerAPI.java:49: protectedMethodCommentRequirement Required +src/net/sf/freecol/client/networking/UserServerAPI.java:50: Local variable 'sound' could be declared final +src/net/sf/freecol/client/networking/UserServerAPI.java:51: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/FreeColException.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/FreeColException.java:33: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/FreeColException.java:43: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/FreeColException.java:43: Parameter 'throwable' is not assigned and could be declared final +src/net/sf/freecol/common/FreeColSeed.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/FreeColSeed.java:29: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/FreeColSeed.java:31: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/FreeColSeed.java:31: fieldCommentRequirement Required +src/net/sf/freecol/common/FreeColSeed.java:33: fieldCommentRequirement Required +src/net/sf/freecol/common/FreeColSeed.java:35: It is somewhat confusing to have a field name matching the declaring class name +src/net/sf/freecol/common/FreeColSeed.java:35: fieldCommentRequirement Required +src/net/sf/freecol/common/FreeColSeed.java:44: Parameter 'generate' is not assigned and could be declared final +src/net/sf/freecol/common/FreeColSeed.java:47: There is log block not surrounded by if +src/net/sf/freecol/common/FreeColSeed.java:47: There is log block not surrounded by if +src/net/sf/freecol/common/FreeColSeed.java:57: Parameter 'arg' is not assigned and could be declared final +src/net/sf/freecol/common/FreeColSeed.java:60: Avoid empty catch blocks +src/net/sf/freecol/common/FreeColSeed.java:60: Avoid empty catch blocks +src/net/sf/freecol/common/FreeColSeed.java:68: There is log block not surrounded by if +src/net/sf/freecol/common/FreeColSeed.java:68: There is log block not surrounded by if +src/net/sf/freecol/common/ObjectWithId.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/ObjectWithId.java:34: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/ServerInfo.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/ServerInfo.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:36: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/ServerInfo.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/ServerInfo.java:50: Document empty constructor +src/net/sf/freecol/common/ServerInfo.java:52: Comment is too large: Too many lines +src/net/sf/freecol/common/ServerInfo.java:64: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:64: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:64: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:65: Parameter 'currentlyPlaying' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:65: Parameter 'slotsAvailable' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:66: Parameter 'gameState' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:66: Parameter 'isGameStarted' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:66: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:78: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:83: Comment is too large: Too many lines +src/net/sf/freecol/common/ServerInfo.java:95: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:95: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:95: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:96: Parameter 'currentlyPlaying' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:96: Parameter 'slotsAvailable' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:97: Parameter 'gameState' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:97: Parameter 'isGameStarted' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:97: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:113: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:196: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:197: Local variable 'element' could be declared final +src/net/sf/freecol/common/ServerInfo.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/ServerInfo.java:217: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/ServerInfo.java:232: Comment is too large: Line too long +src/net/sf/freecol/common/debug/DebugUtils.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/debug/DebugUtils.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/common/debug/DebugUtils.java:20: Possible God class (WMC=141, ATFD=305, TCC=0.0) +src/net/sf/freecol/common/debug/DebugUtils.java:84: Comment is too large: Too many lines +src/net/sf/freecol/common/debug/DebugUtils.java:99: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/debug/DebugUtils.java:99: Avoid really long classes. +src/net/sf/freecol/common/debug/DebugUtils.java:99: The class 'DebugUtils' has a Cyclomatic Complexity of 5 (Highest = 19). +src/net/sf/freecol/common/debug/DebugUtils.java:99: The class 'DebugUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 16). +src/net/sf/freecol/common/debug/DebugUtils.java:99: The class 'DebugUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 16). +src/net/sf/freecol/common/debug/DebugUtils.java:99: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/debug/DebugUtils.java:101: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/debug/DebugUtils.java:101: fieldCommentRequirement Required +src/net/sf/freecol/common/debug/DebugUtils.java:113: Parameter 'buildingTitle' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:114: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:114: Found 'DU'-anomaly for variable 'server' (lines '114'-'156'). +src/net/sf/freecol/common/debug/DebugUtils.java:117: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:117: Found 'DU'-anomaly for variable 'player' (lines '117'-'156'). +src/net/sf/freecol/common/debug/DebugUtils.java:119: Found 'DU'-anomaly for variable 'buildingType' (lines '119'-'156'). +src/net/sf/freecol/common/debug/DebugUtils.java:119: Local variable 'buildingType' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:120: The String literal "cancel" appears 18 times in this file; the first occurrence is on line 120 +src/net/sf/freecol/common/debug/DebugUtils.java:122: Avoid variables with short names like bt +src/net/sf/freecol/common/debug/DebugUtils.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:127: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:134: Local variable 'results' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:136: Local variable 'sColony' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:137: Local variable 'reason' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:144: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/debug/DebugUtils.java:144: Local variable 'sBuilding' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:167: Parameter 'fatherTitle' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:176: Found 'DU'-anomaly for variable 'father' (lines '176'-'189'). +src/net/sf/freecol/common/debug/DebugUtils.java:176: Local variable 'father' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:179: Avoid variables with short names like f +src/net/sf/freecol/common/debug/DebugUtils.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:180: Avoid variables with short names like f +src/net/sf/freecol/common/debug/DebugUtils.java:186: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:203: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:203: Found 'DU'-anomaly for variable 'sPlayer' (lines '203'-'218'). +src/net/sf/freecol/common/debug/DebugUtils.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:206: Local variable 'response' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:209: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:209: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:212: Found 'DU'-anomaly for variable 'gold' (lines '212'-'218'). +src/net/sf/freecol/common/debug/DebugUtils.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:232: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:232: Found 'DU'-anomaly for variable 'sPlayer' (lines '232'-'247'). +src/net/sf/freecol/common/debug/DebugUtils.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:235: Local variable 'response' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:238: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:238: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:241: Found 'DU'-anomaly for variable 'crosses' (lines '241'-'247'). +src/net/sf/freecol/common/debug/DebugUtils.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:259: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:259: Found 'DU'-anomaly for variable 'player' (lines '259'-'277'). +src/net/sf/freecol/common/debug/DebugUtils.java:260: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:260: Found 'DU'-anomaly for variable 'sGame' (lines '260'-'277'). +src/net/sf/freecol/common/debug/DebugUtils.java:260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:262: Local variable 'response' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:265: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:265: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:268: Found 'DU'-anomaly for variable 'liberty' (lines '268'-'277'). +src/net/sf/freecol/common/debug/DebugUtils.java:272: Local variable 'c' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:274: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:288: Parameter 'menu' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:290: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:292: Avoid variables with short names like e +src/net/sf/freecol/common/debug/DebugUtils.java:292: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:293: Local variable 'skipping' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:293: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:295: Useless parentheses. +src/net/sf/freecol/common/debug/DebugUtils.java:295: Useless parentheses. +src/net/sf/freecol/common/debug/DebugUtils.java:310: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:315: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:315: Found 'DU'-anomaly for variable 'sPlayer' (lines '315'-'351'). +src/net/sf/freecol/common/debug/DebugUtils.java:315: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:315: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:317: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:317: Found 'DU'-anomaly for variable 'sTile' (lines '317'-'351'). +src/net/sf/freecol/common/debug/DebugUtils.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:320: Found 'DU'-anomaly for variable 'unitChoice' (lines '320'-'351'). +src/net/sf/freecol/common/debug/DebugUtils.java:320: Local variable 'unitChoice' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:323: Avoid variables with short names like ut +src/net/sf/freecol/common/debug/DebugUtils.java:325: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:328: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:330: Avoid unused local variables such as 'carrier'. +src/net/sf/freecol/common/debug/DebugUtils.java:330: Local variable 'carrier' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:330: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/debug/DebugUtils.java:331: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:331: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:332: Avoid variables with short names like u +src/net/sf/freecol/common/debug/DebugUtils.java:332: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:335: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/debug/DebugUtils.java:335: Local variable 'loc' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:336: Local variable 'sUnit' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:338: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:342: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:344: Local variable 'unit' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:344: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:361: Found 'UR'-anomaly for variable 't' (lines '361'-'370'). +src/net/sf/freecol/common/debug/DebugUtils.java:364: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:368: Local variable 'gtl' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:369: Local variable 't' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:370: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:370: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:370: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:371: Local variable 'msg' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:372: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/debug/DebugUtils.java:375: Found 'DU'-anomaly for variable 'goodsType' (lines '375'-'404'). +src/net/sf/freecol/common/debug/DebugUtils.java:375: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:379: Avoid variables with short names like gt +src/net/sf/freecol/common/debug/DebugUtils.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:380: Avoid variables with short names like gt +src/net/sf/freecol/common/debug/DebugUtils.java:382: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:385: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:385: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:387: Local variable 'amount' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:390: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:390: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:392: Avoid variables with short names like a +src/net/sf/freecol/common/debug/DebugUtils.java:398: Local variable 'sGoodsType' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:399: Local variable 'ugc' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:400: Local variable 'sgc' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:417: Local variable 'disasters' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:419: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:419: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:419: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:422: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:424: Found 'DU'-anomaly for variable 'disaster' (lines '424'-'449'). +src/net/sf/freecol/common/debug/DebugUtils.java:424: Local variable 'disaster' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:427: Avoid variables with short names like rc +src/net/sf/freecol/common/debug/DebugUtils.java:430: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:433: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:437: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:439: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:439: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:443: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:443: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:443: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:443: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:448: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:462: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:463: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:463: Found 'DU'-anomaly for variable 'sColony' (lines '463'-'489'). +src/net/sf/freecol/common/debug/DebugUtils.java:463: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:468: Found 'DU'-anomaly for variable 'player' (lines '468'-'489'). +src/net/sf/freecol/common/debug/DebugUtils.java:468: Local variable 'player' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:471: Avoid variables with short names like p +src/net/sf/freecol/common/debug/DebugUtils.java:473: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:476: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:478: Local variable 'sPlayer' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:478: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:480: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:482: Local variable 'myPlayer' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:484: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:484: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:487: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:488: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:501: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:501: Found 'DU'-anomaly for variable 'server' (lines '501'-'531'). +src/net/sf/freecol/common/debug/DebugUtils.java:505: Found 'DU'-anomaly for variable 'player' (lines '505'-'531'). +src/net/sf/freecol/common/debug/DebugUtils.java:505: Local variable 'player' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:508: Avoid variables with short names like p +src/net/sf/freecol/common/debug/DebugUtils.java:508: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:508: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:509: Avoid variables with short names like p +src/net/sf/freecol/common/debug/DebugUtils.java:511: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:514: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:516: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:517: Local variable 'sUnit' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:517: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:519: Local variable 'sPlayer' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:519: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:523: Local variable 'myPlayer' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:527: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:529: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:530: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:545: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:545: Found 'DU'-anomaly for variable 'sUnit' (lines '545'-'557'). +src/net/sf/freecol/common/debug/DebugUtils.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:548: Local variable 'roleChoice' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:551: Avoid variables with short names like r +src/net/sf/freecol/common/debug/DebugUtils.java:553: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:555: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:559: Comment is too large: Too many lines +src/net/sf/freecol/common/debug/DebugUtils.java:568: Found 'UR'-anomaly for variable 'sg' (lines '568'-'639'). +src/net/sf/freecol/common/debug/DebugUtils.java:568: Found 'UR'-anomaly for variable 't' (lines '568'-'582'). +src/net/sf/freecol/common/debug/DebugUtils.java:568: Found 'UR'-anomaly for variable 'u' (lines '568'-'584'). +src/net/sf/freecol/common/debug/DebugUtils.java:568: The method 'checkDesyncAction' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/common/debug/DebugUtils.java:568: The method 'checkDesyncAction' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/common/debug/DebugUtils.java:568: The method 'checkDesyncAction' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/debug/DebugUtils.java:568: The method checkDesyncAction() has an NPath complexity of 2532 +src/net/sf/freecol/common/debug/DebugUtils.java:571: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:573: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:574: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:575: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:575: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:578: Found 'DD'-anomaly for variable 'problemDetected' (lines '578'-'596'). +src/net/sf/freecol/common/debug/DebugUtils.java:579: Avoid variables with short names like lb +src/net/sf/freecol/common/debug/DebugUtils.java:579: Local variable 'lb' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:580: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:581: Local variable 't' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:581: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:582: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:582: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:583: Local variable 'u' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:583: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:584: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:584: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:586: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:586: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:587: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:587: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:588: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:589: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:590: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:593: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:593: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:595: Avoid catching NullPointerException; consider removing the cause of the NPE. +src/net/sf/freecol/common/debug/DebugUtils.java:595: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/debug/DebugUtils.java:595: Avoid empty catch blocks +src/net/sf/freecol/common/debug/DebugUtils.java:595: Avoid empty catch blocks +src/net/sf/freecol/common/debug/DebugUtils.java:596: Found 'DD'-anomaly for variable 'problemDetected' (lines '596'-'596'). +src/net/sf/freecol/common/debug/DebugUtils.java:596: Found 'DD'-anomaly for variable 'problemDetected' (lines '596'-'609'). +src/net/sf/freecol/common/debug/DebugUtils.java:596: Found 'DD'-anomaly for variable 'problemDetected' (lines '596'-'621'). +src/net/sf/freecol/common/debug/DebugUtils.java:596: Found 'DD'-anomaly for variable 'problemDetected' (lines '596'-'626'). +src/net/sf/freecol/common/debug/DebugUtils.java:596: Found 'DD'-anomaly for variable 'problemDetected' (lines '596'-'650'). +src/net/sf/freecol/common/debug/DebugUtils.java:598: Local variable 'cUnit' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:601: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:601: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:601: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:601: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:601: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:601: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:603: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:604: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:605: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:606: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:607: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:608: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:608: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:609: Found 'DD'-anomaly for variable 'problemDetected' (lines '609'-'596'). +src/net/sf/freecol/common/debug/DebugUtils.java:609: Found 'DD'-anomaly for variable 'problemDetected' (lines '609'-'609'). +src/net/sf/freecol/common/debug/DebugUtils.java:609: Found 'DD'-anomaly for variable 'problemDetected' (lines '609'-'621'). +src/net/sf/freecol/common/debug/DebugUtils.java:609: Found 'DD'-anomaly for variable 'problemDetected' (lines '609'-'626'). +src/net/sf/freecol/common/debug/DebugUtils.java:609: Found 'DD'-anomaly for variable 'problemDetected' (lines '609'-'650'). +src/net/sf/freecol/common/debug/DebugUtils.java:613: Avoid variables with short names like ct +src/net/sf/freecol/common/debug/DebugUtils.java:613: Local variable 'ct' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:613: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:613: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:614: Local variable 'sSettlement' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:614: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:615: Local variable 'cSettlement' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:615: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:618: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/debug/DebugUtils.java:618: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/debug/DebugUtils.java:620: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:621: Found 'DD'-anomaly for variable 'problemDetected' (lines '621'-'596'). +src/net/sf/freecol/common/debug/DebugUtils.java:621: Found 'DD'-anomaly for variable 'problemDetected' (lines '621'-'609'). +src/net/sf/freecol/common/debug/DebugUtils.java:621: Found 'DD'-anomaly for variable 'problemDetected' (lines '621'-'650'). +src/net/sf/freecol/common/debug/DebugUtils.java:625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:626: Found 'DD'-anomaly for variable 'problemDetected' (lines '626'-'650'). +src/net/sf/freecol/common/debug/DebugUtils.java:627: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:628: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/debug/DebugUtils.java:628: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/debug/DebugUtils.java:630: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:631: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:632: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:637: Avoid excessively long variable names like goodsProblemDetected +src/net/sf/freecol/common/debug/DebugUtils.java:637: Found 'DD'-anomaly for variable 'goodsProblemDetected' (lines '637'-'644'). +src/net/sf/freecol/common/debug/DebugUtils.java:638: Local variable 'sg' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:638: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:639: Local variable 'sPrice' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:639: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:639: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:640: Avoid variables with short names like cg +src/net/sf/freecol/common/debug/DebugUtils.java:640: Local variable 'cg' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:640: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:641: Local variable 'cPrice' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:641: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:641: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:643: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:644: Found 'DD'-anomaly for variable 'goodsProblemDetected' (lines '644'-'644'). +src/net/sf/freecol/common/debug/DebugUtils.java:648: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:648: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:654: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:655: Local variable 'err' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:655: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:656: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:673: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:674: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:676: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:676: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:676: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:681: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:685: Comment is too large: Too many lines +src/net/sf/freecol/common/debug/DebugUtils.java:695: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:696: Local variable 'player' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:697: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:697: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:698: Local variable 'value' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:698: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:700: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:700: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:700: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/debug/DebugUtils.java:712: Found 'UR'-anomaly for variable 'entry' (lines '712'-'747'). +src/net/sf/freecol/common/debug/DebugUtils.java:712: Found 'UR'-anomaly for variable 'tp' (lines '712'-'723'). +src/net/sf/freecol/common/debug/DebugUtils.java:712: Found 'UR'-anomaly for variable 'u' (lines '712'-'735'). +src/net/sf/freecol/common/debug/DebugUtils.java:712: Found 'UR'-anomaly for variable 'unitType' (lines '712'-'771'). +src/net/sf/freecol/common/debug/DebugUtils.java:712: The method 'displayEurope' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/debug/DebugUtils.java:712: The method 'displayEurope' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/debug/DebugUtils.java:712: The method 'displayEurope' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/debug/DebugUtils.java:714: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:715: Found 'DU'-anomaly for variable 'aiMain' (lines '715'-'776'). +src/net/sf/freecol/common/debug/DebugUtils.java:715: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:717: Avoid variables with short names like lb +src/net/sf/freecol/common/debug/DebugUtils.java:717: Local variable 'lb' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:718: Local variable 'inEurope' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:719: Local variable 'toEurope' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:720: Local variable 'toAmerica' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:721: Local variable 'units' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:722: Local variable 'tp' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:722: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:723: Avoid variables with short names like p +src/net/sf/freecol/common/debug/DebugUtils.java:723: Local variable 'p' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:723: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:724: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:724: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:730: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:732: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:734: Local variable 'u' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:734: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:734: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:746: Local variable 'entry' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:749: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:749: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:751: Local variable 'u' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:758: Local variable 'aiu' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:758: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:759: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/debug/DebugUtils.java:759: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:762: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:762: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:762: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:762: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:762: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:770: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:770: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:775: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:789: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:790: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:791: Avoid variables with short names like m +src/net/sf/freecol/common/debug/DebugUtils.java:791: Local variable 'm' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:791: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:792: Local variable 'msg' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:793: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:795: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:808: Local variable 'all' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:808: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:809: Avoid variables with short names like lb +src/net/sf/freecol/common/debug/DebugUtils.java:809: Local variable 'lb' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:810: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:812: Avoid variables with short names like u +src/net/sf/freecol/common/debug/DebugUtils.java:812: Found 'DD'-anomaly for variable 'u' (lines '812'-'816'). +src/net/sf/freecol/common/debug/DebugUtils.java:812: Found 'DD'-anomaly for variable 'u' (lines '812'-'827'). +src/net/sf/freecol/common/debug/DebugUtils.java:812: Found 'DD'-anomaly for variable 'u' (lines '812'-'835'). +src/net/sf/freecol/common/debug/DebugUtils.java:812: Found 'DU'-anomaly for variable 'u' (lines '812'-'840'). +src/net/sf/freecol/common/debug/DebugUtils.java:812: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:812: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/debug/DebugUtils.java:814: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:814: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:814: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:814: The String literal "\nat " appears 5 times in this file; the first occurrence is on line 814 +src/net/sf/freecol/common/debug/DebugUtils.java:815: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:816: Avoid assignments in operands +src/net/sf/freecol/common/debug/DebugUtils.java:816: Found 'DD'-anomaly for variable 'u' (lines '816'-'827'). +src/net/sf/freecol/common/debug/DebugUtils.java:816: Found 'DD'-anomaly for variable 'u' (lines '816'-'835'). +src/net/sf/freecol/common/debug/DebugUtils.java:816: Found 'DU'-anomaly for variable 'u' (lines '816'-'840'). +src/net/sf/freecol/common/debug/DebugUtils.java:816: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:817: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:819: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:822: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:823: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:826: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:826: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:827: Avoid assignments in operands +src/net/sf/freecol/common/debug/DebugUtils.java:827: Found 'DD'-anomaly for variable 'u' (lines '827'-'835'). +src/net/sf/freecol/common/debug/DebugUtils.java:827: Found 'DU'-anomaly for variable 'u' (lines '827'-'840'). +src/net/sf/freecol/common/debug/DebugUtils.java:827: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:828: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:833: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:834: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:835: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:836: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:836: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:839: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:839: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:842: Comment is too large: Too many lines +src/net/sf/freecol/common/debug/DebugUtils.java:854: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:857: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:857: System.err.println is used +src/net/sf/freecol/common/debug/DebugUtils.java:859: System.err.println is used +src/net/sf/freecol/common/debug/DebugUtils.java:860: Local variable 'sTile' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:860: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:861: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:862: System.err.println is used +src/net/sf/freecol/common/debug/DebugUtils.java:863: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:864: System.err.println is used +src/net/sf/freecol/common/debug/DebugUtils.java:875: Found 'UR'-anomaly for variable 'u' (lines '875'-'883'). +src/net/sf/freecol/common/debug/DebugUtils.java:875: Found 'UR'-anomaly for variable 'u2' (lines '875'-'891'). +src/net/sf/freecol/common/debug/DebugUtils.java:876: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:878: Found 'DU'-anomaly for variable 'sGame' (lines '878'-'898'). +src/net/sf/freecol/common/debug/DebugUtils.java:878: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:881: Found 'DU'-anomaly for variable 'first' (lines '881'-'898'). +src/net/sf/freecol/common/debug/DebugUtils.java:882: Local variable 'u' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:883: Avoid variables with short names like su +src/net/sf/freecol/common/debug/DebugUtils.java:883: Local variable 'su' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:883: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:883: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:884: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:884: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:885: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:885: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:888: Found 'DU'-anomaly for variable 'first' (lines '888'-'898'). +src/net/sf/freecol/common/debug/DebugUtils.java:890: Local variable 'u2' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:890: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:891: Local variable 'su2' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:893: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:893: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:897: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:909: Parameter 'reveal' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:913: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:917: Local variable 'fogOfWarSetting' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:917: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:920: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:921: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:923: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:938: Found 'DU'-anomaly for variable 'goodsType' (lines '938'-'970'). +src/net/sf/freecol/common/debug/DebugUtils.java:938: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:941: Avoid variables with short names like gt +src/net/sf/freecol/common/debug/DebugUtils.java:941: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:942: Avoid variables with short names like gt +src/net/sf/freecol/common/debug/DebugUtils.java:944: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:947: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:947: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:949: Local variable 'response' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:949: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:953: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/DebugUtils.java:953: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:953: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:954: Avoid variables with short names like a +src/net/sf/freecol/common/debug/DebugUtils.java:962: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:963: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:964: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:964: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:965: Local variable 'cgc' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:966: Local variable 'sgc' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:966: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:966: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:968: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:969: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:981: Parameter 'monarchTitle' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:983: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:985: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:985: Found 'DU'-anomaly for variable 'sPlayer' (lines '985'-'997'). +src/net/sf/freecol/common/debug/DebugUtils.java:985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:989: Local variable 'action' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:992: Avoid variables with short names like a +src/net/sf/freecol/common/debug/DebugUtils.java:994: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:996: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:996: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1010: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1011: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/debug/DebugUtils.java:1011: Found 'DU'-anomaly for variable 'sTile' (lines '1,011'-'1,026'). +src/net/sf/freecol/common/debug/DebugUtils.java:1011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1014: Local variable 'rumourChoice' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1018: Avoid variables with short names like r +src/net/sf/freecol/common/debug/DebugUtils.java:1019: Avoid variables with short names like r +src/net/sf/freecol/common/debug/DebugUtils.java:1021: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:1023: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1023: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1024: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1024: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1024: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1035: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1038: Local variable 'response' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1038: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1041: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:1041: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1044: Found 'DD'-anomaly for variable 'skip' (lines '1,044'-'1,046'). +src/net/sf/freecol/common/debug/DebugUtils.java:1048: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:1058: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1059: Found 'DU'-anomaly for variable 'server' (lines '1,059'-'1,070'). +src/net/sf/freecol/common/debug/DebugUtils.java:1060: Found 'DU'-anomaly for variable 'gui' (lines '1,060'-'1,070'). +src/net/sf/freecol/common/debug/DebugUtils.java:1064: Local variable 'val' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1064: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1064: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1065: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1065: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1065: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1072: Comment is too large: Too many lines +src/net/sf/freecol/common/debug/DebugUtils.java:1082: Found 'UR'-anomaly for variable 'goods' (lines '1,082'-'1,106'). +src/net/sf/freecol/common/debug/DebugUtils.java:1082: Found 'UR'-anomaly for variable 'p' (lines '1,082'-'1,095'). +src/net/sf/freecol/common/debug/DebugUtils.java:1082: Found 'UR'-anomaly for variable 't' (lines '1,082'-'1,153'). +src/net/sf/freecol/common/debug/DebugUtils.java:1082: Found 'UR'-anomaly for variable 'type' (lines '1,082'-'1,111'). +src/net/sf/freecol/common/debug/DebugUtils.java:1082: Found 'UR'-anomaly for variable 'u' (lines '1,082'-'1,135'). +src/net/sf/freecol/common/debug/DebugUtils.java:1082: The method 'summarizeSettlement' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/common/debug/DebugUtils.java:1082: The method 'summarizeSettlement' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/common/debug/DebugUtils.java:1082: The method 'summarizeSettlement' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/debug/DebugUtils.java:1082: The method summarizeSettlement() has an NPath complexity of 44928 +src/net/sf/freecol/common/debug/DebugUtils.java:1083: Avoid variables with short names like is +src/net/sf/freecol/common/debug/DebugUtils.java:1085: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1086: Found 'DU'-anomaly for variable 'aiMain' (lines '1,086'-'1,159'). +src/net/sf/freecol/common/debug/DebugUtils.java:1086: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1087: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1088: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1091: Avoid variables with short names like lb +src/net/sf/freecol/common/debug/DebugUtils.java:1091: Local variable 'lb' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1092: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1092: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1093: Local variable 'mostHated' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1093: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1094: Local variable 'p' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1094: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1095: Local variable 'tension' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1095: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1096: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1096: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1098: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1099: Use equals() to compare object references. +src/net/sf/freecol/common/debug/DebugUtils.java:1100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1105: Local variable 'goods' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1110: Local variable 'type' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1111: Local variable 'prod' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1118: Found 'DU'-anomaly for variable 'wanted' (lines '1,118'-'1,159'). +src/net/sf/freecol/common/debug/DebugUtils.java:1118: Local variable 'wanted' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1119: Local variable 'type' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1120: Avoid variables with short names like i +src/net/sf/freecol/common/debug/DebugUtils.java:1122: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:1124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1129: Useless parentheses. +src/net/sf/freecol/common/debug/DebugUtils.java:1129: Useless parentheses. +src/net/sf/freecol/common/debug/DebugUtils.java:1133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1134: Local variable 'u' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1135: Avoid variables with short names like m +src/net/sf/freecol/common/debug/DebugUtils.java:1135: Local variable 'm' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1143: Local variable 'u' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1144: Avoid variables with short names like m +src/net/sf/freecol/common/debug/DebugUtils.java:1144: Local variable 'm' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1153: Avoid using for statements without curly braces +src/net/sf/freecol/common/debug/DebugUtils.java:1153: Local variable 't' could be declared final +src/net/sf/freecol/common/debug/DebugUtils.java:1153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1172: Avoid variables with short names like ap +src/net/sf/freecol/common/debug/DebugUtils.java:1172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/DebugUtils.java:1174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/debug/DebugUtils.java:1176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/FreeColDebugger.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/debug/FreeColDebugger.java:20: Possible God class (WMC=49, ATFD=17, TCC=0.021538461538461538) +src/net/sf/freecol/common/debug/FreeColDebugger.java:41: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/debug/FreeColDebugger.java:41: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/debug/FreeColDebugger.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/debug/FreeColDebugger.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/debug/FreeColDebugger.java:60: Avoid using redundant field initializer for 'debugMode' +src/net/sf/freecol/common/debug/FreeColDebugger.java:60: fieldCommentRequirement Required +src/net/sf/freecol/common/debug/FreeColDebugger.java:70: Avoid using redundant field initializer for 'debugRunSave' +src/net/sf/freecol/common/debug/FreeColDebugger.java:76: Avoid excessively long variable names like normalGameFogOfWar +src/net/sf/freecol/common/debug/FreeColDebugger.java:76: Avoid using redundant field initializer for 'normalGameFogOfWar' +src/net/sf/freecol/common/debug/FreeColDebugger.java:79: Avoid excessively long variable names like displayCoordinates +src/net/sf/freecol/common/debug/FreeColDebugger.java:79: Avoid using redundant field initializer for 'displayCoordinates' +src/net/sf/freecol/common/debug/FreeColDebugger.java:82: Avoid excessively long variable names like displayColonyValuePlayer +src/net/sf/freecol/common/debug/FreeColDebugger.java:82: Avoid using redundant field initializer for 'displayColonyValuePlayer' +src/net/sf/freecol/common/debug/FreeColDebugger.java:85: Avoid using redundant field initializer for 'showMission' +src/net/sf/freecol/common/debug/FreeColDebugger.java:88: Avoid using redundant field initializer for 'showMissionInfo' +src/net/sf/freecol/common/debug/FreeColDebugger.java:106: Parameter 'mode' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:115: Avoid unused private methods such as 'setDebugMode(int)'. +src/net/sf/freecol/common/debug/FreeColDebugger.java:115: Parameter 'mode' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:124: Parameter 'mode' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/FreeColDebugger.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/FreeColDebugger.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/debug/FreeColDebugger.java:135: Avoid variables with short names like m +src/net/sf/freecol/common/debug/FreeColDebugger.java:136: Avoid variables with short names like m +src/net/sf/freecol/common/debug/FreeColDebugger.java:145: Parameter 'optionValue' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:146: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/FreeColDebugger.java:146: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/FreeColDebugger.java:147: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/FreeColDebugger.java:147: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/FreeColDebugger.java:150: Avoid variables with short names like i +src/net/sf/freecol/common/debug/FreeColDebugger.java:150: Local variable 'i' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:151: A switch statement does not contain a break +src/net/sf/freecol/common/debug/FreeColDebugger.java:160: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/FreeColDebugger.java:162: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/FreeColDebugger.java:164: Avoid empty catch blocks +src/net/sf/freecol/common/debug/FreeColDebugger.java:164: Avoid empty catch blocks +src/net/sf/freecol/common/debug/FreeColDebugger.java:167: Local variable 's' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:169: Local variable 'mode' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:172: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/debug/FreeColDebugger.java:173: There is log block not surrounded by if +src/net/sf/freecol/common/debug/FreeColDebugger.java:174: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/FreeColDebugger.java:185: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:186: Local variable 'comma' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:187: Local variable 'turns' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:187: Useless parentheses. +src/net/sf/freecol/common/debug/FreeColDebugger.java:187: Useless parentheses. +src/net/sf/freecol/common/debug/FreeColDebugger.java:194: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/FreeColDebugger.java:211: Parameter 'debugRunTurns' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:229: Parameter 'debugRunSave' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:238: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/debug/FreeColDebugger.java:247: Avoid excessively long variable names like normalGameFogOfWar +src/net/sf/freecol/common/debug/FreeColDebugger.java:247: Parameter 'normalGameFogOfWar' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:258: Parameter 'freeColClient' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:259: Parameter 'force' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:260: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/FreeColDebugger.java:260: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/FreeColDebugger.java:261: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/debug/FreeColDebugger.java:261: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/FreeColDebugger.java:266: Local variable 'fcs' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:271: Avoid empty catch blocks +src/net/sf/freecol/common/debug/FreeColDebugger.java:271: Avoid empty catch blocks +src/net/sf/freecol/common/debug/FreeColDebugger.java:283: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/FreeColDebugger.java:300: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:319: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:337: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:355: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:363: Avoid using if statements without curly braces +src/net/sf/freecol/common/debug/FreeColDebugger.java:373: Parameter 'msg' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:379: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/debug/FreeColDebugger.java:380: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/debug/FreeColDebugger.java:380: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/debug/FreeColDebugger.java:391: Avoid variables with short names like lb +src/net/sf/freecol/common/debug/FreeColDebugger.java:391: Local variable 'lb' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:401: Avoid variables with short names like lb +src/net/sf/freecol/common/debug/FreeColDebugger.java:401: Found 'UR'-anomaly for variable 's' (lines '401'-'403'). +src/net/sf/freecol/common/debug/FreeColDebugger.java:401: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:402: Local variable 's' could be declared final +src/net/sf/freecol/common/debug/FreeColDebugger.java:402: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:31: Each class should declare at least one constructor +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:33: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:33: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:33: Use explicit scoping instead of the default package private level +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:33: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:42: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:42: Parameter 'rule' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:52: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:52: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:62: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:71: Parameter 'category' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:79: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/DefaultNumberRule.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/DualNumberRule.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/DualNumberRule.java:27: Each class should declare at least one constructor +src/net/sf/freecol/common/i18n/DualNumberRule.java:33: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/DualNumberRule.java:34: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/DualNumberRule.java:35: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/DualNumberRule.java:36: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/DualNumberRule.java:37: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:20: Possible God class (WMC=140, ATFD=52, TCC=0.003076923076923077) +src/net/sf/freecol/common/i18n/Messages.java:51: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:81: Comment is too large: Line too long +src/net/sf/freecol/common/i18n/Messages.java:82: Comment is too large: Line too long +src/net/sf/freecol/common/i18n/Messages.java:88: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/i18n/Messages.java:88: The class 'Messages' has a Cyclomatic Complexity of 4 (Highest = 30). +src/net/sf/freecol/common/i18n/Messages.java:88: The class 'Messages' has a Modified Cyclomatic Complexity of 4 (Highest = 23). +src/net/sf/freecol/common/i18n/Messages.java:88: The class 'Messages' has a Standard Cyclomatic Complexity of 4 (Highest = 23). +src/net/sf/freecol/common/i18n/Messages.java:88: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/i18n/Messages.java:90: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/i18n/Messages.java:90: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:92: Avoid excessively long variable names like MESSAGE_FILE_PREFIX +src/net/sf/freecol/common/i18n/Messages.java:92: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:93: Avoid excessively long variable names like MOD_MESSAGE_FILE_PREFIX +src/net/sf/freecol/common/i18n/Messages.java:93: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:94: Avoid excessively long variable names like MESSAGE_FILE_SUFFIX +src/net/sf/freecol/common/i18n/Messages.java:94: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:96: Avoid excessively long variable names like DESCRIPTION_SUFFIX +src/net/sf/freecol/common/i18n/Messages.java:96: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:97: Avoid excessively long variable names like SHORT_DESCRIPTION_SUFFIX +src/net/sf/freecol/common/i18n/Messages.java:97: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:98: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:99: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:101: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:112: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/Messages.java:112: Variables that are final and static should be all capitals, 'messageBundle' is not all capitals. +src/net/sf/freecol/common/i18n/Messages.java:118: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/Messages.java:118: Variables that are final and static should be all capitals, 'tagMap' is not all capitals. +src/net/sf/freecol/common/i18n/Messages.java:129: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:138: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:148: Parameter 'locale' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:159: Parameter 'locale' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:172: Found 'UR'-anomaly for variable 'cldr' (lines '172'-'172'). +src/net/sf/freecol/common/i18n/Messages.java:172: Found 'UR'-anomaly for variable 'name' (lines '172'-'203'). +src/net/sf/freecol/common/i18n/Messages.java:172: Parameter 'locale' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:172: The method loadMessageBundle() has an NPath complexity of 250 +src/net/sf/freecol/common/i18n/Messages.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:179: Found 'DU'-anomaly for variable 'i18nDirectory' (lines '179'-'212'). +src/net/sf/freecol/common/i18n/Messages.java:179: Local variable 'i18nDirectory' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:182: Local variable 'cldr' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:185: Avoid variables with short names like in +src/net/sf/freecol/common/i18n/Messages.java:189: System.err.println is used +src/net/sf/freecol/common/i18n/Messages.java:193: System.err.println is used +src/net/sf/freecol/common/i18n/Messages.java:198: Local variable 'loc' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:198: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:198: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:202: Local variable 'name' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:203: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/i18n/Messages.java:203: Local variable 'file' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:204: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Messages.java:206: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/i18n/Messages.java:208: System.err.println is used +src/net/sf/freecol/common/i18n/Messages.java:222: Avoid variables with short names like is +src/net/sf/freecol/common/i18n/Messages.java:222: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:225: Found 'DU'-anomaly for variable 'inputReader' (lines '225'-'247'). +src/net/sf/freecol/common/i18n/Messages.java:229: Avoid variables with short names like in +src/net/sf/freecol/common/i18n/Messages.java:229: Local variable 'in' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:232: Avoid assignments in operands +src/net/sf/freecol/common/i18n/Messages.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:235: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Messages.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:238: Local variable 'key' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:238: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:239: Local variable 'value' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:249: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:261: Found 'UR'-anomaly for variable 'fcmf' (lines '261'-'270'). +src/net/sf/freecol/common/i18n/Messages.java:261: Found 'UR'-anomaly for variable 'name' (lines '261'-'270'). +src/net/sf/freecol/common/i18n/Messages.java:261: Parameter 'locale' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:262: Local variable 'allMods' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:266: Found 'DU'-anomaly for variable 'filenames' (lines '266'-'274'). +src/net/sf/freecol/common/i18n/Messages.java:266: Local variable 'filenames' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:267: Local variable 'fcmf' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:268: Local variable 'name' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:271: Avoid empty catch blocks +src/net/sf/freecol/common/i18n/Messages.java:271: Avoid empty catch blocks +src/net/sf/freecol/common/i18n/Messages.java:284: Found 'UR'-anomaly for variable 'fcmf' (lines '284'-'289'). +src/net/sf/freecol/common/i18n/Messages.java:284: Found 'UR'-anomaly for variable 'name' (lines '284'-'289'). +src/net/sf/freecol/common/i18n/Messages.java:284: Parameter 'mods' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:285: Parameter 'locale' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:286: Local variable 'fcmf' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:287: Local variable 'name' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:290: Avoid empty catch blocks +src/net/sf/freecol/common/i18n/Messages.java:290: Avoid empty catch blocks +src/net/sf/freecol/common/i18n/Messages.java:295: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:304: Parameter 'languageID' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:305: Found 'DD'-anomaly for variable 'country' (lines '305'-'315'). +src/net/sf/freecol/common/i18n/Messages.java:305: Found 'DD'-anomaly for variable 'language' (lines '305'-'307'). +src/net/sf/freecol/common/i18n/Messages.java:305: Found 'DD'-anomaly for variable 'variant' (lines '305'-'323'). +src/net/sf/freecol/common/i18n/Messages.java:305: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/i18n/Messages.java:306: Avoid variables with short names like st +src/net/sf/freecol/common/i18n/Messages.java:306: Local variable 'st' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:307: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:314: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/Messages.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:319: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/Messages.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:322: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/Messages.java:333: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:333: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:333: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:337: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:337: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:341: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:341: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:341: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:345: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:345: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:349: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:349: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:349: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:353: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:353: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:357: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:357: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:357: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:361: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:361: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:366: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:366: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:366: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:370: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:370: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:370: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:374: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:374: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:379: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:379: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:379: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:383: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:383: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:383: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:393: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:397: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:406: Parameter 'defaultKey' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:406: Parameter 'preferredKey' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:408: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:414: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:414: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:418: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:418: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:418: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Messages.java:419: Avoid variables with short names like s +src/net/sf/freecol/common/i18n/Messages.java:419: Local variable 'key' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:420: Avoid variables with short names like k +src/net/sf/freecol/common/i18n/Messages.java:424: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:433: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:437: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:446: Avoid reassigning parameters such as 'id' +src/net/sf/freecol/common/i18n/Messages.java:446: Avoid variables with short names like id +src/net/sf/freecol/common/i18n/Messages.java:450: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/i18n/Messages.java:450: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:450: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:451: Found 'DD'-anomaly for variable 'desc' (lines '451'-'456'). +src/net/sf/freecol/common/i18n/Messages.java:453: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/i18n/Messages.java:453: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:453: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:454: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Messages.java:457: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/i18n/Messages.java:457: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Messages.java:465: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:477: Avoid really long methods. +src/net/sf/freecol/common/i18n/Messages.java:477: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:477: Parameter 'typeId' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:477: Rather than using a lot of String arguments, consider using a container object for those values. +src/net/sf/freecol/common/i18n/Messages.java:477: The method 'getUnitLabel' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/i18n/Messages.java:477: The method 'getUnitLabel' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/common/i18n/Messages.java:477: The method 'getUnitLabel' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/common/i18n/Messages.java:478: Parameter 'nationId' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:478: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:479: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:480: Parameter 'extra' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:486: Local variable 'baseKey' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:488: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:490: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/i18n/Messages.java:492: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:494: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/i18n/Messages.java:494: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:494: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:515: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:515: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:515: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:515: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:522: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:522: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:522: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:522: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:522: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:522: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:535: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:535: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:535: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:578: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:578: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:578: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:578: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:642: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:652: Comment is too large: Line too long +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:682: Parameter 'messageId' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:685: Avoid throwing null pointer exceptions. +src/net/sf/freecol/common/i18n/Messages.java:690: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:690: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Messages.java:694: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:703: Found 'UR'-anomaly for variable 'key' (lines '703'-'730'). +src/net/sf/freecol/common/i18n/Messages.java:703: Found 'UR'-anomaly for variable 'other' (lines '703'-'713'). +src/net/sf/freecol/common/i18n/Messages.java:703: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:703: The method 'message' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/i18n/Messages.java:703: The method 'message' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/i18n/Messages.java:703: The method 'message' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/i18n/Messages.java:704: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:704: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Messages.java:705: Found 'DD'-anomaly for variable 'result' (lines '705'-'710'). +src/net/sf/freecol/common/i18n/Messages.java:705: Found 'DD'-anomaly for variable 'result' (lines '705'-'724'). +src/net/sf/freecol/common/i18n/Messages.java:705: Found 'DD'-anomaly for variable 'result' (lines '705'-'726'). +src/net/sf/freecol/common/i18n/Messages.java:705: Found 'DD'-anomaly for variable 'result' (lines '705'-'728'). +src/net/sf/freecol/common/i18n/Messages.java:705: Found 'DD'-anomaly for variable 'result' (lines '705'-'736'). +src/net/sf/freecol/common/i18n/Messages.java:705: Found 'DD'-anomaly for variable 'result' (lines '705'-'741'). +src/net/sf/freecol/common/i18n/Messages.java:708: Local variable 'replacements' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:709: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:712: Local variable 'other' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:713: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/i18n/Messages.java:715: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:715: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:716: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:716: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/Messages.java:716: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:718: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:724: Found 'DD'-anomaly for variable 'result' (lines '724'-'728'). +src/net/sf/freecol/common/i18n/Messages.java:726: Found 'DD'-anomaly for variable 'result' (lines '726'-'728'). +src/net/sf/freecol/common/i18n/Messages.java:729: Local variable 'key' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:730: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:735: Local variable 'key' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:747: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Messages.java:764: Avoid really long methods. +src/net/sf/freecol/common/i18n/Messages.java:764: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:764: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:764: The method 'replaceChoices' has a Cyclomatic Complexity of 30. +src/net/sf/freecol/common/i18n/Messages.java:764: The method 'replaceChoices' has a Modified Cyclomatic Complexity of 23. +src/net/sf/freecol/common/i18n/Messages.java:764: The method 'replaceChoices' has a Standard Cyclomatic Complexity of 23. +src/net/sf/freecol/common/i18n/Messages.java:764: The method replaceChoices() has an NPath complexity of 6049 +src/net/sf/freecol/common/i18n/Messages.java:765: Found 'DD'-anomaly for variable 'openChoice' (lines '765'-'769'). +src/net/sf/freecol/common/i18n/Messages.java:766: Found 'DD'-anomaly for variable 'closeChoice' (lines '766'-'771'). +src/net/sf/freecol/common/i18n/Messages.java:768: Local variable 'result' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:769: Avoid assignments in operands +src/net/sf/freecol/common/i18n/Messages.java:769: Found 'DU'-anomaly for variable 'openChoice' (lines '769'-'889'). +src/net/sf/freecol/common/i18n/Messages.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:774: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:775: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:775: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:778: Local variable 'colonIndex' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:780: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:783: Found 'DD'-anomaly for variable 'tag' (lines '783'-'783'). +src/net/sf/freecol/common/i18n/Messages.java:783: Found 'DU'-anomaly for variable 'tag' (lines '783'-'889'). +src/net/sf/freecol/common/i18n/Messages.java:783: Local variable 'tag' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:784: Local variable 'pipeIndex' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:786: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:790: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:792: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:792: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:792: This call to String.startsWith can be rewritten using String.charAt(0) +src/net/sf/freecol/common/i18n/Messages.java:796: Local variable 'replacement' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:798: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:801: Found 'DD'-anomaly for variable 'selector' (lines '801'-'804'). +src/net/sf/freecol/common/i18n/Messages.java:802: Local variable 'taggedSelector' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:804: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:809: Local variable 'taggedSelector' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:811: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:818: This call to String.startsWith can be rewritten using String.charAt(0) +src/net/sf/freecol/common/i18n/Messages.java:820: Local variable 'replacement' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:822: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:824: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:826: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:831: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:833: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:834: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:837: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:841: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:842: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:847: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:849: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:852: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:855: Local variable 'defaultEnd' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:855: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:858: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:860: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:862: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:869: Local variable 'start' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:869: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:871: Local variable 'nextOpenIndex' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:876: Local variable 'end' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:876: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:876: Useless parentheses. +src/net/sf/freecol/common/i18n/Messages.java:879: Local variable 'replacement' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:880: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/i18n/Messages.java:880: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:881: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:883: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:888: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Messages.java:899: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:899: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:900: Local variable 'keyIndex' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:902: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:904: Local variable 'start' could be declared final +src/net/sf/freecol/common/i18n/Messages.java:909: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Messages.java:911: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:926: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:926: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Messages.java:927: Found 'DU'-anomaly for variable 'last' (lines '927'-'957'). +src/net/sf/freecol/common/i18n/Messages.java:928: Found 'DD'-anomaly for variable 'level' (lines '928'-'934'). +src/net/sf/freecol/common/i18n/Messages.java:928: Found 'DU'-anomaly for variable 'level' (lines '928'-'957'). +src/net/sf/freecol/common/i18n/Messages.java:932: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/Messages.java:933: Found 'DU'-anomaly for variable 'last' (lines '933'-'957'). +src/net/sf/freecol/common/i18n/Messages.java:934: Found 'DU'-anomaly for variable 'level' (lines '934'-'957'). +src/net/sf/freecol/common/i18n/Messages.java:936: Found 'DU'-anomaly for variable 'last' (lines '936'-'957'). +src/net/sf/freecol/common/i18n/Messages.java:940: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/Messages.java:942: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Messages.java:944: Found 'DU'-anomaly for variable 'last' (lines '944'-'957'). +src/net/sf/freecol/common/i18n/Messages.java:945: Found 'DU'-anomaly for variable 'level' (lines '945'-'957'). +src/net/sf/freecol/common/i18n/Messages.java:948: Found 'DU'-anomaly for variable 'last' (lines '948'-'957'). +src/net/sf/freecol/common/i18n/NameCache.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/NameCache.java:20: Possible God class (WMC=67, ATFD=51, TCC=0.10507246376811594) +src/net/sf/freecol/common/i18n/NameCache.java:41: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/NameCache.java:50: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/i18n/NameCache.java:50: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/i18n/NameCache.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:55: Avoid excessively long variable names like DEFAULT_SEASON_IDS +src/net/sf/freecol/common/i18n/NameCache.java:58: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:62: Avoid using redundant field initializer for 'cibolaKeys' +src/net/sf/freecol/common/i18n/NameCache.java:63: Variables that are final and static should be all capitals, 'cibolaLock' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:66: Avoid using redundant field initializer for 'mercenaryLeaders' +src/net/sf/freecol/common/i18n/NameCache.java:67: Variables that are final and static should be all capitals, 'mercenaryLock' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:70: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/NameCache.java:70: Variables that are final and static should be all capitals, 'regionNames' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:72: Variables that are final and static should be all capitals, 'regionNameLock' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:72: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:73: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/NameCache.java:73: Variables that are final and static should be all capitals, 'regionIndex' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:73: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:76: Avoid using redundant field initializer for 'riverNames' +src/net/sf/freecol/common/i18n/NameCache.java:77: Variables that are final and static should be all capitals, 'riverNameLock' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:77: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:80: Avoid using redundant field initializer for 'seasonNames' +src/net/sf/freecol/common/i18n/NameCache.java:81: Variables that are final and static should be all capitals, 'seasonNamesLock' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:81: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:82: Avoid using redundant field initializer for 'seasonNumber' +src/net/sf/freecol/common/i18n/NameCache.java:82: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:85: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/NameCache.java:85: Variables that are final and static should be all capitals, 'capitalNames' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:87: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/NameCache.java:87: Variables that are final and static should be all capitals, 'settlementNames' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:87: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:89: Avoid excessively long variable names like settlementNameLock +src/net/sf/freecol/common/i18n/NameCache.java:89: Variables that are final and static should be all capitals, 'settlementNameLock' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:89: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:92: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/NameCache.java:92: Variables that are final and static should be all capitals, 'shipNames' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:93: Variables that are final and static should be all capitals, 'shipNameLock' is not all capitals. +src/net/sf/freecol/common/i18n/NameCache.java:93: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NameCache.java:104: Parameter 'names' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:104: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:106: Avoid assignments in operands +src/net/sf/freecol/common/i18n/NameCache.java:106: Found 'DD'-anomaly for variable 'name' (lines '106'-'110'). +src/net/sf/freecol/common/i18n/NameCache.java:109: Avoid variables with short names like i +src/net/sf/freecol/common/i18n/NameCache.java:110: Avoid assignments in operands +src/net/sf/freecol/common/i18n/NameCache.java:110: Found 'DU'-anomaly for variable 'name' (lines '110'-'114'). +src/net/sf/freecol/common/i18n/NameCache.java:123: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:128: Local variable 'count' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:158: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:158: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:169: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:169: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:178: Local variable 'index' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:179: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:202: Found 'UR'-anomaly for variable 's' (lines '202'-'211'). +src/net/sf/freecol/common/i18n/NameCache.java:208: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/NameCache.java:210: Local variable 's' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:226: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:228: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:228: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:240: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:240: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:243: Local variable 'names' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:264: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/i18n/NameCache.java:269: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/NameCache.java:281: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:281: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:305: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/i18n/NameCache.java:305: Useless parentheses. +src/net/sf/freecol/common/i18n/NameCache.java:305: Useless parentheses. +src/net/sf/freecol/common/i18n/NameCache.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:327: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:336: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:338: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:349: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:351: Avoid variables with short names like n +src/net/sf/freecol/common/i18n/NameCache.java:364: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:377: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:391: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:391: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:393: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:395: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:397: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/i18n/NameCache.java:403: Local variable 'names' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:406: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:406: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:417: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:417: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:417: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:426: Avoid variables with short names like nn +src/net/sf/freecol/common/i18n/NameCache.java:426: Local variable 'nn' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:447: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:448: Useless parentheses. +src/net/sf/freecol/common/i18n/NameCache.java:448: Useless parentheses. +src/net/sf/freecol/common/i18n/NameCache.java:460: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:460: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:474: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:474: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:478: Local variable 'names' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:480: Local variable 'name' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:481: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:481: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:481: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:487: Avoid variables with short names like i +src/net/sf/freecol/common/i18n/NameCache.java:487: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NameCache.java:488: Found 'DD'-anomaly for variable 'name' (lines '488'-'489'). +src/net/sf/freecol/common/i18n/NameCache.java:489: Avoid assignments in operands +src/net/sf/freecol/common/i18n/NameCache.java:489: Avoid empty while statements +src/net/sf/freecol/common/i18n/NameCache.java:489: Avoid empty while statements +src/net/sf/freecol/common/i18n/NameCache.java:489: Avoid using while statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:499: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:499: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:503: Local variable 'names' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:504: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:515: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:516: Local variable 'base' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:517: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:517: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:519: Avoid variables with short names like i +src/net/sf/freecol/common/i18n/NameCache.java:520: Avoid assignments in operands +src/net/sf/freecol/common/i18n/NameCache.java:520: Avoid empty while statements +src/net/sf/freecol/common/i18n/NameCache.java:520: Avoid empty while statements +src/net/sf/freecol/common/i18n/NameCache.java:520: Avoid using while statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:524: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/NameCache.java:535: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:535: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:536: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:537: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:537: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:543: Local variable 'names' could be declared final +src/net/sf/freecol/common/i18n/NameCache.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NameCache.java:546: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/NameCache.java:546: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NameCache.java:552: Avoid variables with short names like i +src/net/sf/freecol/common/i18n/NameCache.java:553: Avoid assignments in operands +src/net/sf/freecol/common/i18n/NameCache.java:553: Avoid empty while statements +src/net/sf/freecol/common/i18n/NameCache.java:553: Avoid empty while statements +src/net/sf/freecol/common/i18n/NameCache.java:553: Avoid using while statements without curly braces +src/net/sf/freecol/common/i18n/Number.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Number.java:33: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/i18n/Number.java:33: Each class should declare at least one constructor +src/net/sf/freecol/common/i18n/Number.java:35: enumCommentRequirement Required +src/net/sf/freecol/common/i18n/Number.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/i18n/Number.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Number.java:51: Parameter 'selector' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Number.java:51: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Number.java:53: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Number.java:55: There is log block not surrounded by if +src/net/sf/freecol/common/i18n/Number.java:56: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/i18n/Number.java:67: Parameter 'selector' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Number.java:68: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/i18n/NumberRules.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/NumberRules.java:40: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/i18n/NumberRules.java:40: The class 'NumberRules' has a Cyclomatic Complexity of 5 (Highest = 17). +src/net/sf/freecol/common/i18n/NumberRules.java:40: The class 'NumberRules' has a Modified Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/common/i18n/NumberRules.java:40: The class 'NumberRules' has a Standard Cyclomatic Complexity of 5 (Highest = 14). +src/net/sf/freecol/common/i18n/NumberRules.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/i18n/NumberRules.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:59: Avoid excessively long variable names like PLURAL_NUMBER_RULE +src/net/sf/freecol/common/i18n/NumberRules.java:65: Avoid excessively long variable names like ZERO_ONE_NUMBER_RULE +src/net/sf/freecol/common/i18n/NumberRules.java:68: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/i18n/NumberRules.java:68: Variables that are final and static should be all capitals, 'numberMap' is not all capitals. +src/net/sf/freecol/common/i18n/NumberRules.java:68: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:78: Avoid variables with short names like in +src/net/sf/freecol/common/i18n/NumberRules.java:78: Parameter 'in' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:90: Parameter 'lang' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:91: Local variable 'number' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:95: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:100: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/common/i18n/NumberRules.java:100: Avoid variables with short names like in +src/net/sf/freecol/common/i18n/NumberRules.java:100: Parameter 'in' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:102: Avoid variables with short names like xr +src/net/sf/freecol/common/i18n/NumberRules.java:105: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/i18n/NumberRules.java:107: Avoid throwing raw exception types. +src/net/sf/freecol/common/i18n/NumberRules.java:114: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/i18n/NumberRules.java:114: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:115: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/i18n/NumberRules.java:115: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:116: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/i18n/NumberRules.java:116: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:117: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/i18n/NumberRules.java:117: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:118: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/i18n/NumberRules.java:118: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:119: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/i18n/NumberRules.java:119: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:120: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/i18n/NumberRules.java:120: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/NumberRules.java:123: Avoid variables with short names like xr +src/net/sf/freecol/common/i18n/NumberRules.java:123: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:126: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NumberRules.java:126: Switch statements should have a default label +src/net/sf/freecol/common/i18n/NumberRules.java:144: Avoid variables with short names like xr +src/net/sf/freecol/common/i18n/NumberRules.java:144: Found 'UR'-anomaly for variable 'locale' (lines '144'-'189'). +src/net/sf/freecol/common/i18n/NumberRules.java:144: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:144: The method 'readChild' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/common/i18n/NumberRules.java:144: The method 'readChild' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/common/i18n/NumberRules.java:144: The method 'readChild' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/common/i18n/NumberRules.java:144: The method readChild() has an NPath complexity of 335 +src/net/sf/freecol/common/i18n/NumberRules.java:145: Local variable 'loc' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:146: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/i18n/NumberRules.java:146: Local variable 'locales' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:148: Local variable 'numberRule' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:151: Local variable 'plu' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:152: Local variable 'category' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:153: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/i18n/NumberRules.java:153: Local variable 'rule' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:157: Found 'DD'-anomaly for variable 'number' (lines '157'-'160'). +src/net/sf/freecol/common/i18n/NumberRules.java:157: Found 'DD'-anomaly for variable 'number' (lines '157'-'167'). +src/net/sf/freecol/common/i18n/NumberRules.java:157: Found 'DD'-anomaly for variable 'number' (lines '157'-'170'). +src/net/sf/freecol/common/i18n/NumberRules.java:157: Found 'DD'-anomaly for variable 'number' (lines '157'-'182'). +src/net/sf/freecol/common/i18n/NumberRules.java:157: Found 'DD'-anomaly for variable 'number' (lines '157'-'186'). +src/net/sf/freecol/common/i18n/NumberRules.java:157: Found 'DU'-anomaly for variable 'number' (lines '157'-'192'). +src/net/sf/freecol/common/i18n/NumberRules.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:160: Found 'DU'-anomaly for variable 'number' (lines '160'-'192'). +src/net/sf/freecol/common/i18n/NumberRules.java:163: Local variable 'rule' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:165: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/common/i18n/NumberRules.java:165: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/NumberRules.java:165: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/i18n/NumberRules.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:165: Switch statements should have a default label +src/net/sf/freecol/common/i18n/NumberRules.java:165: These nested if statements could be combined +src/net/sf/freecol/common/i18n/NumberRules.java:167: Found 'DU'-anomaly for variable 'number' (lines '167'-'192'). +src/net/sf/freecol/common/i18n/NumberRules.java:170: Found 'DU'-anomaly for variable 'number' (lines '170'-'192'). +src/net/sf/freecol/common/i18n/NumberRules.java:176: Local variable 'oneRule' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:177: Local variable 'twoRule' could be declared final +src/net/sf/freecol/common/i18n/NumberRules.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:179: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/NumberRules.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:181: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/NumberRules.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/NumberRules.java:182: Found 'DU'-anomaly for variable 'number' (lines '182'-'192'). +src/net/sf/freecol/common/i18n/NumberRules.java:186: Found 'DU'-anomaly for variable 'number' (lines '186'-'192'). +src/net/sf/freecol/common/i18n/NumberRules.java:188: Local variable 'locale' could be declared final +src/net/sf/freecol/common/i18n/OtherNumberRule.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/OtherNumberRule.java:27: Each class should declare at least one constructor +src/net/sf/freecol/common/i18n/OtherNumberRule.java:30: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/OtherNumberRule.java:30: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/PluralNumberRule.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/PluralNumberRule.java:27: Each class should declare at least one constructor +src/net/sf/freecol/common/i18n/PluralNumberRule.java:30: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/PluralNumberRule.java:30: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/PluralNumberRule.java:31: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/PluralNumberRule.java:32: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Relation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Relation.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/i18n/Relation.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/i18n/Relation.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/i18n/Relation.java:30: Use explicit scoping instead of the default package private level +src/net/sf/freecol/common/i18n/Relation.java:30: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Relation.java:31: Avoid using redundant field initializer for 'negated' +src/net/sf/freecol/common/i18n/Relation.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/i18n/Relation.java:31: Use explicit scoping instead of the default package private level +src/net/sf/freecol/common/i18n/Relation.java:31: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Relation.java:32: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/i18n/Relation.java:32: Use explicit scoping instead of the default package private level +src/net/sf/freecol/common/i18n/Relation.java:32: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Relation.java:34: Parameter 'tokens' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Relation.java:34: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Relation.java:38: Parameter 'high' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Relation.java:38: Parameter 'low' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Relation.java:38: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Relation.java:48: Parameter 'mod' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Relation.java:57: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Relation.java:67: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Relation.java:77: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Relation.java:78: Local variable 'value' could be declared final +src/net/sf/freecol/common/i18n/Relation.java:80: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/i18n/Relation.java:86: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Relation.java:87: Avoid variables with short names like sb +src/net/sf/freecol/common/i18n/Relation.java:87: Local variable 'sb' could be declared final +src/net/sf/freecol/common/i18n/Relation.java:89: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/i18n/Relation.java:90: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/i18n/Relation.java:94: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Relation.java:97: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Relation.java:98: Avoid using if statements without curly braces +src/net/sf/freecol/common/i18n/Relation.java:110: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Rule.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Rule.java:35: Avoid short class names like Rule +src/net/sf/freecol/common/i18n/Rule.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/i18n/Rule.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/i18n/Rule.java:40: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Rule.java:40: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Rule.java:50: Parameter 'condition' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Rule.java:54: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Rule.java:63: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Rule.java:65: Avoid variables with short names like r +src/net/sf/freecol/common/i18n/Rule.java:73: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Rule.java:74: Avoid variables with short names like st +src/net/sf/freecol/common/i18n/Rule.java:74: Local variable 'st' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:75: Local variable 'tokens' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:77: Local variable 'token' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:88: Found 'UR'-anomaly for variable 'token' (lines '88'-'92'). +src/net/sf/freecol/common/i18n/Rule.java:88: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/Rule.java:89: Local variable 'tokens' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:90: Local variable 'result' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:91: Local variable 'token' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:93: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/i18n/Rule.java:104: Found 'UR'-anomaly for variable 'andCondition' (lines '104'-'109'). +src/net/sf/freecol/common/i18n/Rule.java:104: Found 'UR'-anomaly for variable 'relation' (lines '104'-'110'). +src/net/sf/freecol/common/i18n/Rule.java:104: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/Rule.java:105: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/i18n/Rule.java:105: Found 'DU'-anomaly for variable 'andString' (lines '105'-'117'). +src/net/sf/freecol/common/i18n/Rule.java:106: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/i18n/Rule.java:107: Avoid variables with short names like sb +src/net/sf/freecol/common/i18n/Rule.java:107: Local variable 'sb' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:108: Local variable 'andCondition' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:109: Local variable 'relation' could be declared final +src/net/sf/freecol/common/i18n/Rule.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Rule.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/i18n/Selector.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Selector.java:24: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/Selector.java:33: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/i18n/ZeroOneNumberRule.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/i18n/ZeroOneNumberRule.java:27: Each class should declare at least one constructor +src/net/sf/freecol/common/i18n/ZeroOneNumberRule.java:30: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/i18n/ZeroOneNumberRule.java:30: publicMethodCommentRequirement Required +src/net/sf/freecol/common/i18n/ZeroOneNumberRule.java:32: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDataFile.java:32: Avoid unused imports such as 'java.util.Arrays' +src/net/sf/freecol/common/io/FreeColDataFile.java:54: The class 'FreeColDataFile' has a Cyclomatic Complexity of 5 (Highest = 13). +src/net/sf/freecol/common/io/FreeColDataFile.java:54: The class 'FreeColDataFile' has a Modified Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/io/FreeColDataFile.java:54: The class 'FreeColDataFile' has a Standard Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/io/FreeColDataFile.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/io/FreeColDataFile.java:56: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDataFile.java:58: Avoid excessively long variable names like ZIP_FILE_EXTENSION +src/net/sf/freecol/common/io/FreeColDataFile.java:58: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDataFile.java:59: Avoid excessively long variable names like RESOURCE_FILE_PREFIX +src/net/sf/freecol/common/io/FreeColDataFile.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDataFile.java:60: Avoid excessively long variable names like RESOURCE_FILE_SUFFIX +src/net/sf/freecol/common/io/FreeColDataFile.java:60: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDataFile.java:63: Variables that are final and static should be all capitals, 'resourceScheme' is not all capitals. +src/net/sf/freecol/common/io/FreeColDataFile.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColDataFile.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColDataFile.java:81: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:86: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDataFile.java:86: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDataFile.java:86: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDataFile.java:97: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:98: Found 'DU'-anomaly for variable 'expected' (lines '98'-'114'). +src/net/sf/freecol/common/io/FreeColDataFile.java:98: Local variable 'expected' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDataFile.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDataFile.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDataFile.java:100: Avoid variables with short names like jf +src/net/sf/freecol/common/io/FreeColDataFile.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDataFile.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:103: Avoid variables with short names like en +src/net/sf/freecol/common/io/FreeColDataFile.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:105: Found 'DD'-anomaly for variable 'name' (lines '105'-'107'). +src/net/sf/freecol/common/io/FreeColDataFile.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:109: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:110: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/io/FreeColDataFile.java:124: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:124: Parameter 'suffix' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:125: Parameter 'locale' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:130: Local variable 'result' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:132: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDataFile.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:132: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/io/FreeColDataFile.java:133: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDataFile.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:133: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/io/FreeColDataFile.java:134: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDataFile.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:134: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/io/FreeColDataFile.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:138: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDataFile.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:140: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDataFile.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:142: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDataFile.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:162: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:166: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:168: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColDataFile.java:170: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:173: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:175: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:179: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColDataFile.java:185: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDataFile.java:196: Parameter 'filename' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDataFile.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDataFile.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:210: Found 'UR'-anomaly for variable 'fileName' (lines '210'-'210'). +src/net/sf/freecol/common/io/FreeColDataFile.java:210: The method 'getResourceMapping' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/common/io/FreeColDataFile.java:210: The method 'getResourceMapping' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/io/FreeColDataFile.java:210: The method 'getResourceMapping' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/io/FreeColDataFile.java:210: The method getResourceMapping() has an NPath complexity of 400 +src/net/sf/freecol/common/io/FreeColDataFile.java:212: Avoid variables with short names like lb +src/net/sf/freecol/common/io/FreeColDataFile.java:212: Local variable 'lb' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:215: Local variable 'fileName' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:217: Avoid variables with short names like is +src/net/sf/freecol/common/io/FreeColDataFile.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:224: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColDataFile.java:226: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:230: Avoid variables with short names like rc +src/net/sf/freecol/common/io/FreeColDataFile.java:230: Local variable 'rc' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:231: Local variable 'todo' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:232: Avoid variables with short names like pn +src/net/sf/freecol/common/io/FreeColDataFile.java:232: Local variable 'pn' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:233: Avoid variables with short names like rm +src/net/sf/freecol/common/io/FreeColDataFile.java:233: Found 'DU'-anomaly for variable 'rm' (lines '233'-'270'). +src/net/sf/freecol/common/io/FreeColDataFile.java:233: Local variable 'rm' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:240: Local variable 'uri' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:248: Found 'DU'-anomaly for variable 'miss' (lines '248'-'270'). +src/net/sf/freecol/common/io/FreeColDataFile.java:248: Local variable 'miss' could be declared final +src/net/sf/freecol/common/io/FreeColDataFile.java:249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:251: Found 'DD'-anomaly for variable 'progress' (lines '251'-'259'). +src/net/sf/freecol/common/io/FreeColDataFile.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDataFile.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:256: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/io/FreeColDataFile.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:259: Found 'DD'-anomaly for variable 'progress' (lines '259'-'259'). +src/net/sf/freecol/common/io/FreeColDataFile.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:268: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDataFile.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:282: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDataFile.java:282: Avoid variables with short names like f +src/net/sf/freecol/common/io/FreeColDataFile.java:284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:284: This call to String.startsWith can be rewritten using String.charAt(0) +src/net/sf/freecol/common/io/FreeColDataFile.java:284: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDataFile.java:284: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDataFile.java:288: Avoid variables with short names like e +src/net/sf/freecol/common/io/FreeColDataFile.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDataFile.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDirectories.java:19: Possible God class (WMC=158, ATFD=35, TCC=0.03382663847780127) +src/net/sf/freecol/common/io/FreeColDirectories.java:22: Avoid unused imports such as 'java.io.FileInputStream' +src/net/sf/freecol/common/io/FreeColDirectories.java:23: Avoid unused imports such as 'java.io.FileOutputStream' +src/net/sf/freecol/common/io/FreeColDirectories.java:36: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/io/FreeColDirectories.java:36: The class 'FreeColDirectories' has a Cyclomatic Complexity of 4 (Highest = 26). +src/net/sf/freecol/common/io/FreeColDirectories.java:36: The class 'FreeColDirectories' has a Modified Cyclomatic Complexity of 3 (Highest = 22). +src/net/sf/freecol/common/io/FreeColDirectories.java:36: The class 'FreeColDirectories' has a Standard Cyclomatic Complexity of 3 (Highest = 22). +src/net/sf/freecol/common/io/FreeColDirectories.java:41: Avoid excessively long variable names like AUTOSAVE_DIRECTORY +src/net/sf/freecol/common/io/FreeColDirectories.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:47: Avoid unused private fields such as 'CONFIG_DIRS'. +src/net/sf/freecol/common/io/FreeColDirectories.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:54: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:56: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:58: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:60: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:62: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:64: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:66: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:68: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:70: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:72: Avoid excessively long variable names like XDG_CONFIG_HOME_ENV +src/net/sf/freecol/common/io/FreeColDirectories.java:72: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:73: Avoid excessively long variable names like XDG_CONFIG_HOME_DEFAULT +src/net/sf/freecol/common/io/FreeColDirectories.java:73: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:74: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:75: Avoid excessively long variable names like XDG_DATA_HOME_DEFAULT +src/net/sf/freecol/common/io/FreeColDirectories.java:75: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:76: Avoid excessively long variable names like XDG_CACHE_HOME_ENV +src/net/sf/freecol/common/io/FreeColDirectories.java:76: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:77: Avoid excessively long variable names like XDG_CACHE_HOME_DEFAULT +src/net/sf/freecol/common/io/FreeColDirectories.java:77: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:81: Avoid excessively long variable names like BASE_CLIENT_OPTIONS_FILE_NAME +src/net/sf/freecol/common/io/FreeColDirectories.java:81: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:83: Avoid excessively long variable names like CLIENT_OPTIONS_FILE_NAME +src/net/sf/freecol/common/io/FreeColDirectories.java:83: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:85: Avoid excessively long variable names like CUSTOM_DIFFICULTY_FILE_NAME +src/net/sf/freecol/common/io/FreeColDirectories.java:85: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:87: Avoid excessively long variable names like GAME_OPTIONS_FILE_NAME +src/net/sf/freecol/common/io/FreeColDirectories.java:87: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:89: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:91: Avoid excessively long variable names like MAP_GENERATOR_OPTIONS_FILE_NAME +src/net/sf/freecol/common/io/FreeColDirectories.java:91: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColDirectories.java:102: Avoid using redundant field initializer for 'autosaveDirectory' +src/net/sf/freecol/common/io/FreeColDirectories.java:109: Avoid using redundant field initializer for 'clientOptionsFile' +src/net/sf/freecol/common/io/FreeColDirectories.java:126: Avoid using redundant field initializer for 'logFilePath' +src/net/sf/freecol/common/io/FreeColDirectories.java:134: Avoid using redundant field initializer for 'saveDirectory' +src/net/sf/freecol/common/io/FreeColDirectories.java:141: Avoid using redundant field initializer for 'savegameFile' +src/net/sf/freecol/common/io/FreeColDirectories.java:146: Avoid excessively long variable names like userCacheDirectory +src/net/sf/freecol/common/io/FreeColDirectories.java:146: Avoid using redundant field initializer for 'userCacheDirectory' +src/net/sf/freecol/common/io/FreeColDirectories.java:154: Avoid excessively long variable names like userConfigDirectory +src/net/sf/freecol/common/io/FreeColDirectories.java:154: Avoid using redundant field initializer for 'userConfigDirectory' +src/net/sf/freecol/common/io/FreeColDirectories.java:162: Avoid using redundant field initializer for 'userDataDirectory' +src/net/sf/freecol/common/io/FreeColDirectories.java:167: Avoid using redundant field initializer for 'userModsDirectory' +src/net/sf/freecol/common/io/FreeColDirectories.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:203: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:212: Parameter 'dir' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:213: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:213: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:214: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/io/FreeColDirectories.java:215: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/io/FreeColDirectories.java:216: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/io/FreeColDirectories.java:217: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:220: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDirectories.java:242: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/io/FreeColDirectories.java:242: The method 'getXDGDirs' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/common/io/FreeColDirectories.java:242: The method 'getXDGDirs' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/common/io/FreeColDirectories.java:242: The method 'getXDGDirs' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/io/FreeColDirectories.java:242: The method getXDGDirs() has an NPath complexity of 16896 +src/net/sf/freecol/common/io/FreeColDirectories.java:243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:243: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:245: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/io/FreeColDirectories.java:245: Found 'DD'-anomaly for variable 'ret' (lines '245'-'259'). +src/net/sf/freecol/common/io/FreeColDirectories.java:245: Found 'DU'-anomaly for variable 'ret' (lines '245'-'292'). +src/net/sf/freecol/common/io/FreeColDirectories.java:246: Local variable 'home' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:247: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:247: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:248: Local variable 'xdg' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:251: Found 'DD'-anomaly for variable 'todo' (lines '251'-'266'). +src/net/sf/freecol/common/io/FreeColDirectories.java:251: Found 'DD'-anomaly for variable 'todo' (lines '251'-'270'). +src/net/sf/freecol/common/io/FreeColDirectories.java:251: Found 'DD'-anomaly for variable 'todo' (lines '251'-'274'). +src/net/sf/freecol/common/io/FreeColDirectories.java:251: Found 'DU'-anomaly for variable 'todo' (lines '251'-'292'). +src/net/sf/freecol/common/io/FreeColDirectories.java:253: Local variable 'env' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:254: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/io/FreeColDirectories.java:254: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/FreeColDirectories.java:254: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/FreeColDirectories.java:254: Avoid variables with short names like d +src/net/sf/freecol/common/io/FreeColDirectories.java:254: Local variable 'd' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:255: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:257: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:260: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/FreeColDirectories.java:260: Avoid variables with short names like f +src/net/sf/freecol/common/io/FreeColDirectories.java:260: Local variable 'f' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:263: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:266: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:266: Found 'DD'-anomaly for variable 'todo' (lines '266'-'266'). +src/net/sf/freecol/common/io/FreeColDirectories.java:266: Found 'DD'-anomaly for variable 'todo' (lines '266'-'270'). +src/net/sf/freecol/common/io/FreeColDirectories.java:266: Found 'DD'-anomaly for variable 'todo' (lines '266'-'274'). +src/net/sf/freecol/common/io/FreeColDirectories.java:266: Found 'DU'-anomaly for variable 'todo' (lines '266'-'292'). +src/net/sf/freecol/common/io/FreeColDirectories.java:267: Found 'DD'-anomaly for variable 'ret' (lines '267'-'259'). +src/net/sf/freecol/common/io/FreeColDirectories.java:267: Found 'DU'-anomaly for variable 'ret' (lines '267'-'292'). +src/net/sf/freecol/common/io/FreeColDirectories.java:270: Found 'DD'-anomaly for variable 'todo' (lines '270'-'266'). +src/net/sf/freecol/common/io/FreeColDirectories.java:270: Found 'DD'-anomaly for variable 'todo' (lines '270'-'270'). +src/net/sf/freecol/common/io/FreeColDirectories.java:270: Found 'DD'-anomaly for variable 'todo' (lines '270'-'274'). +src/net/sf/freecol/common/io/FreeColDirectories.java:270: Found 'DU'-anomaly for variable 'todo' (lines '270'-'292'). +src/net/sf/freecol/common/io/FreeColDirectories.java:273: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:274: Found 'DD'-anomaly for variable 'todo' (lines '274'-'266'). +src/net/sf/freecol/common/io/FreeColDirectories.java:274: Found 'DD'-anomaly for variable 'todo' (lines '274'-'270'). +src/net/sf/freecol/common/io/FreeColDirectories.java:274: Found 'DD'-anomaly for variable 'todo' (lines '274'-'274'). +src/net/sf/freecol/common/io/FreeColDirectories.java:274: Found 'DU'-anomaly for variable 'todo' (lines '274'-'292'). +src/net/sf/freecol/common/io/FreeColDirectories.java:277: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:277: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:278: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:278: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:284: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:284: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:284: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:284: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:285: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/FreeColDirectories.java:287: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:287: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:300: Avoid variables with short names like f +src/net/sf/freecol/common/io/FreeColDirectories.java:300: Parameter 'f' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:311: Parameter 'dir' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:313: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:313: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:315: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:315: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:320: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDirectories.java:334: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/io/FreeColDirectories.java:334: The method 'getMacOSXDirs' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/io/FreeColDirectories.java:334: The method 'getMacOSXDirs' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/common/io/FreeColDirectories.java:334: The method 'getMacOSXDirs' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/io/FreeColDirectories.java:334: The method getMacOSXDirs() has an NPath complexity of 4608 +src/net/sf/freecol/common/io/FreeColDirectories.java:335: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:335: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:336: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/io/FreeColDirectories.java:336: Found 'DD'-anomaly for variable 'ret' (lines '336'-'350'). +src/net/sf/freecol/common/io/FreeColDirectories.java:336: Found 'DD'-anomaly for variable 'ret' (lines '336'-'364'). +src/net/sf/freecol/common/io/FreeColDirectories.java:336: Found 'DU'-anomaly for variable 'ret' (lines '336'-'385'). +src/net/sf/freecol/common/io/FreeColDirectories.java:337: Local variable 'homeDir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:338: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:338: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:339: Local variable 'libDir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:340: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:340: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:343: Local variable 'prefsDir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:346: Avoid variables with short names like d +src/net/sf/freecol/common/io/FreeColDirectories.java:346: Local variable 'd' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:350: Found 'DD'-anomaly for variable 'ret' (lines '350'-'364'). +src/net/sf/freecol/common/io/FreeColDirectories.java:350: Found 'DU'-anomaly for variable 'ret' (lines '350'-'385'). +src/net/sf/freecol/common/io/FreeColDirectories.java:351: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:351: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:353: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:353: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:357: Local variable 'appsDir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:360: Avoid variables with short names like d +src/net/sf/freecol/common/io/FreeColDirectories.java:360: Local variable 'd' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:361: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:362: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:362: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:365: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:365: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:367: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:367: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:374: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:374: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/io/FreeColDirectories.java:374: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:376: Avoid variables with short names like d +src/net/sf/freecol/common/io/FreeColDirectories.java:377: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:377: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:381: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:381: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:388: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDirectories.java:402: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/io/FreeColDirectories.java:403: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:403: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:405: Local variable 'home' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:406: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:406: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:407: Avoid variables with short names like d +src/net/sf/freecol/common/io/FreeColDirectories.java:407: Local variable 'd' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:408: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:408: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:413: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDirectories.java:422: The method 'getOldUserDirectory' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/common/io/FreeColDirectories.java:423: Local variable 'home' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:425: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:425: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:427: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:427: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:431: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:431: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:444: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:444: Parameter 'newDir' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:444: Parameter 'oldDir' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:445: Local variable 'src' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:446: Local variable 'dst' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:452: System.err.println is used +src/net/sf/freecol/common/io/FreeColDirectories.java:464: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:466: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:466: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:467: System.err.println is used +src/net/sf/freecol/common/io/FreeColDirectories.java:469: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:472: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:473: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/io/FreeColDirectories.java:474: System.err.println is used +src/net/sf/freecol/common/io/FreeColDirectories.java:484: Singleton is not thread safe +src/net/sf/freecol/common/io/FreeColDirectories.java:486: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:486: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:495: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDirectories.java:504: Avoid reassigning parameters such as 'path' +src/net/sf/freecol/common/io/FreeColDirectories.java:505: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:506: Local variable 'dir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:507: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:507: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:507: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:508: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:508: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:508: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:511: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:515: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:521: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColDirectories.java:550: The method 'setUserDirectories' has a Cyclomatic Complexity of 26. +src/net/sf/freecol/common/io/FreeColDirectories.java:550: The method 'setUserDirectories' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/common/io/FreeColDirectories.java:550: The method 'setUserDirectories' has a Standard Cyclomatic Complexity of 22. +src/net/sf/freecol/common/io/FreeColDirectories.java:550: The method setUserDirectories() has an NPath complexity of 6741792 +src/net/sf/freecol/common/io/FreeColDirectories.java:550: Use block level rather than method level synchronization +src/net/sf/freecol/common/io/FreeColDirectories.java:551: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:553: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:554: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:556: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:557: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:559: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:565: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:565: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:565: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:566: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColDirectories.java:572: Local variable 'oldDir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:574: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:574: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:575: Found 'DD'-anomaly for variable 'dirs' (lines '575'-'575'). +src/net/sf/freecol/common/io/FreeColDirectories.java:575: Found 'DU'-anomaly for variable 'dirs' (lines '575'-'615'). +src/net/sf/freecol/common/io/FreeColDirectories.java:576: Found 'DD'-anomaly for variable 'migrate' (lines '576'-'583'). +src/net/sf/freecol/common/io/FreeColDirectories.java:576: Found 'DD'-anomaly for variable 'migrate' (lines '576'-'586'). +src/net/sf/freecol/common/io/FreeColDirectories.java:576: Found 'DD'-anomaly for variable 'migrate' (lines '576'-'589'). +src/net/sf/freecol/common/io/FreeColDirectories.java:583: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:583: Found 'DD'-anomaly for variable 'migrate' (lines '583'-'586'). +src/net/sf/freecol/common/io/FreeColDirectories.java:583: Found 'DD'-anomaly for variable 'migrate' (lines '583'-'589'). +src/net/sf/freecol/common/io/FreeColDirectories.java:586: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:586: Found 'DD'-anomaly for variable 'migrate' (lines '586'-'589'). +src/net/sf/freecol/common/io/FreeColDirectories.java:589: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:603: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:603: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:608: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:608: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:610: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:610: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:610: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:614: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:654: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/io/FreeColDirectories.java:664: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:665: Local variable 'file' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:666: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:666: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:666: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:668: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:714: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:733: Local variable 'dir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:734: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:734: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:734: Useless parentheses. +src/net/sf/freecol/common/io/FreeColDirectories.java:743: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:744: Local variable 'dir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:745: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColDirectories.java:790: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:792: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:792: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:792: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:794: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColDirectories.java:794: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:797: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:798: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:811: Found 'UR'-anomaly for variable 'directory' (lines '811'-'816'). +src/net/sf/freecol/common/io/FreeColDirectories.java:811: Found 'UR'-anomaly for variable 'savegame' (lines '811'-'817'). +src/net/sf/freecol/common/io/FreeColDirectories.java:813: Local variable 'directory' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:816: Local variable 'savegame' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:816: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColDirectories.java:861: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:862: Local variable 'dir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:863: Local variable 'ret' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:864: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:885: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:886: Local variable 'dir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:887: Local variable 'ret' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:888: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColDirectories.java:910: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:911: Local variable 'dir' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:912: Local variable 'ret' could be declared final +src/net/sf/freecol/common/io/FreeColDirectories.java:913: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColModFile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColModFile.java:39: Avoid excessively long variable names like SPECIFICATION_FILE +src/net/sf/freecol/common/io/FreeColModFile.java:39: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColModFile.java:40: Avoid excessively long variable names like MOD_DESCRIPTOR_FILE +src/net/sf/freecol/common/io/FreeColModFile.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColModFile.java:43: Variables that are final and static should be all capitals, 'fileFilter' is not all capitals. +src/net/sf/freecol/common/io/FreeColModFile.java:47: Avoid variables with short names like id +src/net/sf/freecol/common/io/FreeColModFile.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColModFile.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColModFile.java:62: Overridable method 'readModDescriptor' called during object construction +src/net/sf/freecol/common/io/FreeColModFile.java:75: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColModFile.java:77: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/io/FreeColModFile.java:77: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/io/FreeColModFile.java:89: Avoid variables with short names like si +src/net/sf/freecol/common/io/FreeColModFile.java:90: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColModFile.java:112: Avoid variables with short names like xr +src/net/sf/freecol/common/io/FreeColModFile.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColModFile.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColModFile.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColSavegameFile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColSavegameFile.java:48: Avoid excessively long variable names like SAVEGAME_PROPERTIES +src/net/sf/freecol/common/io/FreeColSavegameFile.java:66: Variables that are final and static should be all capitals, 'fileFilter' is not all capitals. +src/net/sf/freecol/common/io/FreeColSavegameFile.java:75: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColSavegameFile.java:86: Avoid variables with short names like xr +src/net/sf/freecol/common/io/FreeColSavegameFile.java:89: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColSavegameFile.java:90: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/io/FreeColSavegameFile.java:91: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/io/FreeColSavegameFile.java:91: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/io/FreeColTcFile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColTcFile.java:35: Variables that are final and static should be all capitals, 'fileFilter' is not all capitals. +src/net/sf/freecol/common/io/FreeColTcFile.java:55: Avoid variables with short names like id +src/net/sf/freecol/common/io/FreeColTcFile.java:65: Local variable 'result' could be declared final +src/net/sf/freecol/common/io/FreeColTcFile.java:76: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColTcFile.java:78: Avoid throwing raw exception types. +src/net/sf/freecol/common/io/FreeColXMLReader.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:20: Possible God class (WMC=103, ATFD=35, TCC=0.0) +src/net/sf/freecol/common/io/FreeColXMLReader.java:59: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/io/FreeColXMLReader.java:61: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/io/FreeColXMLReader.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLReader.java:63: enumCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLReader.java:70: Avoid using redundant field initializer for 'inputStream' +src/net/sf/freecol/common/io/FreeColXMLReader.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColXMLReader.java:76: Avoid using redundant field initializer for 'uninterned' +src/net/sf/freecol/common/io/FreeColXMLReader.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColXMLReader.java:87: Parameter 'inputStream' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:91: Local variable 'xif' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:108: Parameter 'reader' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:112: Local variable 'xif' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:117: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColXMLReader.java:146: Parameter 'readScope' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:148: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColXMLReader.java:148: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:148: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:160: Avoid variables with short names like id +src/net/sf/freecol/common/io/FreeColXMLReader.java:160: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:160: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:161: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColXMLReader.java:161: Local variable 'fco' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:161: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:161: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:162: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/io/FreeColXMLReader.java:186: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/io/FreeColXMLReader.java:191: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:205: Avoid variables with short names like id +src/net/sf/freecol/common/io/FreeColXMLReader.java:219: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:229: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLReader.java:243: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:258: Avoid variables with short names like sb +src/net/sf/freecol/common/io/FreeColXMLReader.java:258: Local variable 'sb' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:260: Avoid variables with short names like n +src/net/sf/freecol/common/io/FreeColXMLReader.java:260: Local variable 'n' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:262: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/io/FreeColXMLReader.java:263: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/io/FreeColXMLReader.java:274: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:285: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:285: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:299: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:299: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:300: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:302: Found 'DD'-anomaly for variable 'result' (lines '302'-'305'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:307: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:320: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:320: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:321: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:323: Found 'DD'-anomaly for variable 'result' (lines '323'-'326'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:328: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:341: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:341: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:342: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:344: Found 'DD'-anomaly for variable 'result' (lines '344'-'347'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:349: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:362: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:362: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:363: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:377: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:378: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:379: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:380: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:382: Found 'DD'-anomaly for variable 'result' (lines '382'-'385'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLReader.java:387: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/io/FreeColXMLReader.java:388: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:388: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:395: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:406: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:407: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:407: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:408: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:412: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:412: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:412: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:412: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:416: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:416: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColXMLReader.java:417: Local variable 'fco' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:425: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:434: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:435: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:435: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:435: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:438: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:438: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:438: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:438: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:446: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:455: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:455: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:456: Parameter 'make' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:458: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:458: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColXMLReader.java:462: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:462: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:462: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:462: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:469: Avoid variables with short names like c +src/net/sf/freecol/common/io/FreeColXMLReader.java:469: Local variable 'c' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:471: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/io/FreeColXMLReader.java:476: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:476: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColXMLReader.java:477: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:482: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:492: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:492: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:498: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:498: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColXMLReader.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:500: Local variable 'list' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:504: Found 'DD'-anomaly for variable 'object' (lines '504'-'507'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:506: Avoid variables with short names like c +src/net/sf/freecol/common/io/FreeColXMLReader.java:506: Local variable 'c' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:507: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/FreeColXMLReader.java:512: Avoid throwing raw exception types. +src/net/sf/freecol/common/io/FreeColXMLReader.java:520: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:532: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:533: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:533: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:538: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:538: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColXMLReader.java:538: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLReader.java:540: Local variable 'list' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:542: Local variable 'value' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:543: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColXMLReader.java:543: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:551: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:567: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:568: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:568: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:568: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:569: Parameter 'required' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:574: The String literal "Missing " appears 4 times in this file; the first occurrence is on line 574 +src/net/sf/freecol/common/io/FreeColXMLReader.java:575: The String literal " for " appears 5 times in this file; the first occurrence is on line 575 +src/net/sf/freecol/common/io/FreeColXMLReader.java:583: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:597: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:598: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:598: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:599: Parameter 'required' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:600: Avoid variables with short names like id +src/net/sf/freecol/common/io/FreeColXMLReader.java:602: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:602: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:602: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:602: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:612: Local variable 'fco' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:615: Local variable 'ret' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLReader.java:622: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:627: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:633: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:642: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:651: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:652: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:654: Local variable 'ret' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:656: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/FreeColXMLReader.java:656: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLReader.java:660: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:669: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:670: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:674: Found 'DU'-anomaly for variable 'ret' (lines '674'-'685'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:678: Avoid variables with short names like id +src/net/sf/freecol/common/io/FreeColXMLReader.java:678: Local variable 'id' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:683: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLReader.java:687: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:701: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:702: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:703: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:703: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:708: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:719: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:720: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:720: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:720: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:721: Parameter 'required' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:735: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:748: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:749: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:749: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:749: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:750: Parameter 'required' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:752: Avoid variables with short names like id +src/net/sf/freecol/common/io/FreeColXMLReader.java:754: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:754: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:754: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:754: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:758: Found 'DD'-anomaly for variable 'ret' (lines '758'-'765'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:758: Found 'DU'-anomaly for variable 'ret' (lines '758'-'790'). +src/net/sf/freecol/common/io/FreeColXMLReader.java:768: Avoid variables with short names like c +src/net/sf/freecol/common/io/FreeColXMLReader.java:768: Local variable 'c' could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLReader.java:783: There is log block not surrounded by if +src/net/sf/freecol/common/io/FreeColXMLReader.java:805: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:818: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:819: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:819: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:819: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:823: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:823: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:823: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:823: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:832: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:832: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLReader.java:833: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:833: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:833: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:836: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:836: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/io/FreeColXMLReader.java:836: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:836: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLReader.java:840: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/io/FreeColXMLReader.java:847: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLReader.java:857: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLReader.java:857: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLWriter.java:20: Possible God class (WMC=66, ATFD=23, TCC=0.0016806722689075631) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/io/FreeColXMLWriter.java:51: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLWriter.java:63: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:65: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:68: Variables that are final and static should be all capitals, 'indentProps' is not all capitals. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:79: Avoid using redundant field initializer for 'player' +src/net/sf/freecol/common/io/FreeColXMLWriter.java:79: fieldCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:82: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:86: Local variable 'ret' could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:91: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:95: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:99: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:100: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:100: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:100: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:100: Useless parentheses. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:103: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:107: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:107: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:111: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:121: Avoid using redundant field initializer for 'stringWriter' +src/net/sf/freecol/common/io/FreeColXMLWriter.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:121: Private field 'stringWriter' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:123: Avoid using redundant field initializer for 'outputWriter' +src/net/sf/freecol/common/io/FreeColXMLWriter.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:123: Private field 'outputWriter' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:129: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLWriter.java:140: Parameter 'outputStream' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:140: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:141: Parameter 'indent' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:145: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLWriter.java:155: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:155: Parameter 'writer' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:159: Comment is too large: Too many lines +src/net/sf/freecol/common/io/FreeColXMLWriter.java:168: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:168: Parameter 'writer' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:169: Parameter 'indent' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:210: Parameter 'writeScope' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:265: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:265: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:276: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:276: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:287: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:287: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:298: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:298: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:309: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:309: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:311: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/FreeColXMLWriter.java:321: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:321: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:332: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:332: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:345: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:345: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:357: Found 'UR'-anomaly for variable 't' (lines '357'-'365'). +src/net/sf/freecol/common/io/FreeColXMLWriter.java:357: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:358: Parameter 'members' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:363: Avoid variables with short names like i +src/net/sf/freecol/common/io/FreeColXMLWriter.java:363: Found 'DU'-anomaly for variable 'i' (lines '363'-'370'). +src/net/sf/freecol/common/io/FreeColXMLWriter.java:364: Local variable 't' could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:366: Found 'DU'-anomaly for variable 'i' (lines '366'-'370'). +src/net/sf/freecol/common/io/FreeColXMLWriter.java:374: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:382: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:386: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:386: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:394: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:399: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:404: Parameter 'uri' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:404: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:409: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:409: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:414: Parameter 'uri' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:414: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:419: Parameter 'context' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:419: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:424: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:424: Parameter 'uri' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:424: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:429: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:429: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:429: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:434: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:434: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:434: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:434: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:439: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:439: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:439: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:439: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:439: Rather than using a lot of String arguments, consider using a container object for those values. +src/net/sf/freecol/common/io/FreeColXMLWriter.java:439: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:444: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:444: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:449: Parameter 'len' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:449: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:449: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:449: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:454: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:454: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:459: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:459: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:464: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:464: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:469: Parameter 'dtd' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:469: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:474: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:474: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:479: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:479: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:479: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:484: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:484: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:484: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:484: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:489: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:494: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:499: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:499: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:504: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:504: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:504: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:509: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:509: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:514: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:514: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:514: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:519: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:524: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:524: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:529: Parameter 'encoding' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:529: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:529: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:534: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:534: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:539: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:539: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:539: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/FreeColXMLWriter.java:544: Parameter 'localName' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:544: Parameter 'namespaceURI' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:544: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/io/FreeColXMLWriter.java:544: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/Mods.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/Mods.java:32: No need to import a type that lives in the same package +src/net/sf/freecol/common/io/Mods.java:39: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/io/Mods.java:39: Avoid short class names like Mods +src/net/sf/freecol/common/io/Mods.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/io/Mods.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/io/Mods.java:44: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/io/Mods.java:44: Variables that are final and static should be all capitals, 'allMods' is not all capitals. +src/net/sf/freecol/common/io/Mods.java:52: Found 'UR'-anomaly for variable 'f' (lines '52'-'59'). +src/net/sf/freecol/common/io/Mods.java:52: Parameter 'directory' is not assigned and could be declared final +src/net/sf/freecol/common/io/Mods.java:54: Avoid variables with short names like lb +src/net/sf/freecol/common/io/Mods.java:54: Local variable 'lb' could be declared final +src/net/sf/freecol/common/io/Mods.java:57: Local variable 'f' could be declared final +src/net/sf/freecol/common/io/Mods.java:59: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/Mods.java:59: Local variable 'fcmf' could be declared final +src/net/sf/freecol/common/io/Mods.java:63: There is log block not surrounded by if +src/net/sf/freecol/common/io/Mods.java:66: Avoid using if statements without curly braces +src/net/sf/freecol/common/io/Mods.java:88: Avoid variables with short names like id +src/net/sf/freecol/common/io/Mods.java:88: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/io/Mods.java:108: Avoid variables with short names like id +src/net/sf/freecol/common/io/Mods.java:108: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/io/Mods.java:117: Found 'UR'-anomaly for variable 'f' (lines '117'-'122'). +src/net/sf/freecol/common/io/Mods.java:118: Local variable 'result' could be declared final +src/net/sf/freecol/common/io/Mods.java:119: Local variable 'directory' could be declared final +src/net/sf/freecol/common/io/Mods.java:120: Local variable 'f' could be declared final +src/net/sf/freecol/common/io/Mods.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/Mods.java:122: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/Mods.java:124: There is log block not surrounded by if +src/net/sf/freecol/common/io/sza/AnimationEvent.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/sza/ImageAnimationEvent.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/sza/ImageAnimationEvent.java:34: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/io/sza/ImageAnimationEvent.java:41: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:48: The class 'SimpleZippedAnimation' has a Cyclomatic Complexity of 3 (Highest = 12). +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:48: The class 'SimpleZippedAnimation' has a Modified Cyclomatic Complexity of 3 (Highest = 11). +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:48: The class 'SimpleZippedAnimation' has a Standard Cyclomatic Complexity of 3 (Highest = 11). +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:50: Avoid excessively long variable names like ANIMATION_DESCRIPTOR_FILE +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:53: fieldCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:54: fieldCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:85: The constructor 'SimpleZippedAnimation' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:85: The constructor 'SimpleZippedAnimation' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:85: The constructor 'SimpleZippedAnimation' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:93: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:97: Avoid assignments in operands +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:99: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:99: Avoid variables with short names like in +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:101: Avoid assignments in operands +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:112: Avoid empty catch blocks +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:112: Avoid empty catch blocks +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:121: Local variable 'line' could be declared final +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:128: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:133: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:133: Avoid instantiation through private constructors from outside of the constructors class. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:171: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:181: Found 'UR'-anomaly for variable 'event' (lines '181'-'184'). +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:181: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:183: Local variable 'event' could be declared final +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:193: headerCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:194: Avoid unused private fields such as '_c'. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:194: Avoid variables with short names like _c +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:194: Variables that are final and static should be all capitals, '_c' is not all capitals. +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:194: fieldCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:196: fieldCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:197: fieldCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:206: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:211: publicMethodCommentRequirement Required +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:215: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:219: Local variable 'scaled' could be declared final +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:221: Avoid variables with short names like g +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:221: Local variable 'g' could be declared final +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/io/sza/SimpleZippedAnimation.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/logging/DefaultHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/logging/DefaultHandler.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/logging/DefaultHandler.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/logging/DefaultHandler.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/logging/DefaultHandler.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/logging/DefaultHandler.java:54: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/logging/DefaultHandler.java:54: Parameter 'consoleLogging' is not assigned and could be declared final +src/net/sf/freecol/common/logging/DefaultHandler.java:54: Parameter 'fileName' is not assigned and could be declared final +src/net/sf/freecol/common/logging/DefaultHandler.java:57: Local variable 'file' could be declared final +src/net/sf/freecol/common/logging/DefaultHandler.java:78: Avoid assignments in operands +src/net/sf/freecol/common/logging/DefaultHandler.java:88: Avoid variables with short names like sb +src/net/sf/freecol/common/logging/DefaultHandler.java:88: Local variable 'sb' could be declared final +src/net/sf/freecol/common/logging/DefaultHandler.java:147: Parameter 'record' is not assigned and could be declared final +src/net/sf/freecol/common/logging/DefaultHandler.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/logging/DefaultHandler.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/logging/DefaultHandler.java:155: Local variable 'str' could be declared final +src/net/sf/freecol/common/logging/DefaultHandler.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/logging/DefaultHandler.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/logging/DefaultHandler.java:157: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/logging/DefaultHandler.java:158: System.err.println is used +src/net/sf/freecol/common/logging/DefaultHandler.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/logging/DefaultHandler.java:164: System.err.println is used +src/net/sf/freecol/common/logging/TextFormatter.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/logging/TextFormatter.java:37: Avoid unnecessary constructors - the compiler will generate these for you +src/net/sf/freecol/common/logging/TextFormatter.java:37: Document empty constructor +src/net/sf/freecol/common/logging/TextFormatter.java:37: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/logging/TextFormatter.java:47: Parameter 'record' is not assigned and could be declared final +src/net/sf/freecol/common/logging/TextFormatter.java:48: Local variable 'result' could be declared final +src/net/sf/freecol/common/logging/TextFormatter.java:48: StringBuffer constructor is initialized with size 16, but has at least 25 characters appended. +src/net/sf/freecol/common/logging/TextFormatter.java:51: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/logging/TextFormatter.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/logging/TextFormatter.java:57: Avoid variables with short names like sw +src/net/sf/freecol/common/logging/TextFormatter.java:57: Local variable 'sw' could be declared final +src/net/sf/freecol/common/logging/TextFormatter.java:58: Avoid variables with short names like pw +src/net/sf/freecol/common/logging/TextFormatter.java:58: Local variable 'pw' could be declared final +src/net/sf/freecol/common/logging/TextFormatter.java:60: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Ability.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Ability.java:45: Avoid excessively long variable names like ALWAYS_OFFERED_PEACE +src/net/sf/freecol/common/model/Ability.java:65: Avoid excessively long variable names like AUTOMATIC_EQUIPMENT +src/net/sf/freecol/common/model/Ability.java:69: Avoid excessively long variable names like AUTOMATIC_PROMOTION +src/net/sf/freecol/common/model/Ability.java:84: Avoid excessively long variable names like AVOID_EXCESS_PRODUCTION +src/net/sf/freecol/common/model/Ability.java:88: Avoid excessively long variable names like BETTER_FOREIGN_AFFAIRS_REPORT +src/net/sf/freecol/common/model/Ability.java:110: Avoid excessively long variable names like BORN_IN_INDIAN_SETTLEMENT +src/net/sf/freecol/common/model/Ability.java:123: Avoid excessively long variable names like BUILD_CUSTOM_HOUSE +src/net/sf/freecol/common/model/Ability.java:184: Avoid excessively long variable names like CONSUME_ALL_OR_NOTHING +src/net/sf/freecol/common/model/Ability.java:188: Avoid excessively long variable names like CUSTOM_HOUSE_TRADES_WITH_FOREIGN_COUNTRIES +src/net/sf/freecol/common/model/Ability.java:196: Avoid excessively long variable names like DEMOTE_ON_ALL_EQUIPMENT_LOST +src/net/sf/freecol/common/model/Ability.java:204: Avoid excessively long variable names like DISPOSE_ON_ALL_EQUIPMENT_LOST +src/net/sf/freecol/common/model/Ability.java:208: Avoid excessively long variable names like DISPOSE_ON_COMBAT_LOSS +src/net/sf/freecol/common/model/Ability.java:216: Avoid excessively long variable names like ELECT_FOUNDING_FATHER +src/net/sf/freecol/common/model/Ability.java:252: Avoid excessively long variable names like EXPERTS_USE_CONNECTIONS +src/net/sf/freecol/common/model/Ability.java:264: Avoid excessively long variable names like FOUND_IN_LOST_CITY +src/net/sf/freecol/common/model/Ability.java:276: Avoid excessively long variable names like IGNORE_EUROPEAN_WARS +src/net/sf/freecol/common/model/Ability.java:291: Avoid excessively long variable names like INDEPENDENCE_DECLARED +src/net/sf/freecol/common/model/Ability.java:299: Avoid excessively long variable names like INDEPENDENT_NATION +src/net/sf/freecol/common/model/Ability.java:335: Avoid excessively long variable names like PILLAGE_UNPROTECTED_COLONY +src/net/sf/freecol/common/model/Ability.java:365: Avoid excessively long variable names like ROYAL_EXPEDITIONARY_FORCE +src/net/sf/freecol/common/model/Ability.java:369: Avoid excessively long variable names like RUMOURS_ALWAYS_POSITIVE +src/net/sf/freecol/common/model/Ability.java:400: Avoid excessively long variable names like TRADE_WITH_FOREIGN_COLONIES +src/net/sf/freecol/common/model/Ability.java:417: Avoid variables with short names like id +src/net/sf/freecol/common/model/Ability.java:417: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:427: Avoid variables with short names like id +src/net/sf/freecol/common/model/Ability.java:427: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:427: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:438: Avoid variables with short names like id +src/net/sf/freecol/common/model/Ability.java:438: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Ability.java:438: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:438: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:438: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:449: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Ability.java:449: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:461: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Ability.java:461: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Ability.java:461: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:462: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:473: Avoid variables with short names like e +src/net/sf/freecol/common/model/Ability.java:473: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Ability.java:473: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:473: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:484: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Ability.java:504: Avoid variables with short names like o +src/net/sf/freecol/common/model/Ability.java:504: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:505: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Ability.java:505: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Ability.java:507: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Ability.java:519: Useless parentheses. +src/net/sf/freecol/common/model/Ability.java:519: Useless parentheses. +src/net/sf/freecol/common/model/Ability.java:531: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Ability.java:531: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:541: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Ability.java:541: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Ability.java:552: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Ability.java:552: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Ability.java:555: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Ability.java:555: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/AbstractGoods.java:29: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/AbstractGoods.java:40: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/AbstractGoods.java:46: Avoid excessively long variable names like abstractGoodsComparator +src/net/sf/freecol/common/model/AbstractGoods.java:46: Variables that are final and static should be all capitals, 'abstractGoodsComparator' is not all capitals. +src/net/sf/freecol/common/model/AbstractGoods.java:49: Avoid variables with short names like a1 +src/net/sf/freecol/common/model/AbstractGoods.java:49: Avoid variables with short names like a2 +src/net/sf/freecol/common/model/AbstractGoods.java:49: Parameter 'a1' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:49: Parameter 'a2' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:49: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/AbstractGoods.java:50: Local variable 'cmp' could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:51: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/AbstractGoods.java:52: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/AbstractGoods.java:67: Document empty constructor +src/net/sf/freecol/common/model/AbstractGoods.java:67: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/AbstractGoods.java:75: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/AbstractGoods.java:75: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:75: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:86: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/AbstractGoods.java:86: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:144: Parameter 'sellable' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:145: Useless parentheses. +src/net/sf/freecol/common/model/AbstractGoods.java:145: Useless parentheses. +src/net/sf/freecol/common/model/AbstractGoods.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:158: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:158: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:171: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:171: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:185: Found 'UR'-anomaly for variable 'ag' (lines '185'-'187'). +src/net/sf/freecol/common/model/AbstractGoods.java:185: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:186: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:187: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/AbstractGoods.java:187: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/AbstractGoods.java:187: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/AbstractGoods.java:187: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:199: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:200: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:201: Avoid variables with short names like ag +src/net/sf/freecol/common/model/AbstractGoods.java:201: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/AbstractGoods.java:212: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:213: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:214: Avoid variables with short names like ag +src/net/sf/freecol/common/model/AbstractGoods.java:223: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/AbstractGoods.java:237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:247: Avoid variables with short names like o +src/net/sf/freecol/common/model/AbstractGoods.java:247: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:248: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/AbstractGoods.java:248: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/AbstractGoods.java:250: Avoid variables with short names like ag +src/net/sf/freecol/common/model/AbstractGoods.java:250: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:251: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/AbstractGoods.java:261: Found 'DD'-anomaly for variable 'hash' (lines '261'-'262'). +src/net/sf/freecol/common/model/AbstractGoods.java:262: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractGoods.java:270: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/AbstractGoods.java:270: fieldCommentRequirement Required +src/net/sf/freecol/common/model/AbstractGoods.java:271: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/AbstractGoods.java:271: fieldCommentRequirement Required +src/net/sf/freecol/common/model/AbstractGoods.java:278: Avoid variables with short names like xw +src/net/sf/freecol/common/model/AbstractGoods.java:278: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:290: Avoid variables with short names like xr +src/net/sf/freecol/common/model/AbstractGoods.java:290: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:319: Avoid variables with short names like ag +src/net/sf/freecol/common/model/AbstractGoods.java:319: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:330: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractGoods.java:330: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/AbstractUnit.java:47: Document empty constructor +src/net/sf/freecol/common/model/AbstractUnit.java:47: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/AbstractUnit.java:56: Avoid variables with short names like id +src/net/sf/freecol/common/model/AbstractUnit.java:56: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/AbstractUnit.java:56: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:56: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:56: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:69: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:69: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:69: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:79: Avoid variables with short names like xr +src/net/sf/freecol/common/model/AbstractUnit.java:79: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/AbstractUnit.java:79: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:126: Local variable 'tmpl' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractUnit.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractUnit.java:148: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:158: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:169: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:170: Avoid variables with short names like n +src/net/sf/freecol/common/model/AbstractUnit.java:170: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:171: Local variable 'role' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:172: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/AbstractUnit.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/AbstractUnit.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/AbstractUnit.java:183: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:184: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:185: Avoid variables with short names like au +src/net/sf/freecol/common/model/AbstractUnit.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractUnit.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/AbstractUnit.java:194: Found 'UR'-anomaly for variable 'au' (lines '194'-'197'). +src/net/sf/freecol/common/model/AbstractUnit.java:194: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:195: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:196: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:197: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/AbstractUnit.java:210: Found 'UR'-anomaly for variable 'au' (lines '210'-'214'). +src/net/sf/freecol/common/model/AbstractUnit.java:210: Parameter 'base' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:211: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:212: Local variable 'template' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:213: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/AbstractUnit.java:222: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/AbstractUnit.java:222: fieldCommentRequirement Required +src/net/sf/freecol/common/model/AbstractUnit.java:223: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/AbstractUnit.java:223: fieldCommentRequirement Required +src/net/sf/freecol/common/model/AbstractUnit.java:230: Avoid variables with short names like xw +src/net/sf/freecol/common/model/AbstractUnit.java:230: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:242: Avoid variables with short names like xr +src/net/sf/freecol/common/model/AbstractUnit.java:242: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:258: Avoid variables with short names like sb +src/net/sf/freecol/common/model/AbstractUnit.java:258: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/AbstractUnit.java:259: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/AbstractUnit.java:260: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/BuildQueue.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/BuildQueue.java:33: enumCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildQueue.java:62: It is somewhat confusing to have a field name matching the declaring class name +src/net/sf/freecol/common/model/BuildQueue.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildQueue.java:67: Private field 'priority' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/common/model/BuildQueue.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildQueue.java:80: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:80: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:80: Parameter 'priority' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:93: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/BuildQueue.java:93: Useless parentheses. +src/net/sf/freecol/common/model/BuildQueue.java:93: Useless parentheses. +src/net/sf/freecol/common/model/BuildQueue.java:102: Parameter 'buildable' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:110: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:114: Parameter 'buildable' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:114: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:118: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:122: Parameter 'values' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:122: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:126: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:126: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:130: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:134: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:138: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:142: Avoid excessively long variable names like newCompletionAction +src/net/sf/freecol/common/model/BuildQueue.java:142: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildQueue.java:154: Local variable 'current' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildQueue.java:165: Found 'UR'-anomaly for variable 'ag' (lines '165'-'175'). +src/net/sf/freecol/common/model/BuildQueue.java:165: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:166: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:167: Local variable 'current' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:171: Found 'DU'-anomaly for variable 'overflow' (lines '171'-'190'). +src/net/sf/freecol/common/model/BuildQueue.java:171: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildQueue.java:173: Found 'DU'-anomaly for variable 'consumption' (lines '173'-'190'). +src/net/sf/freecol/common/model/BuildQueue.java:173: Local variable 'consumption' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:174: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildQueue.java:175: Local variable 'available' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildQueue.java:179: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:179: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildQueue.java:179: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildQueue.java:179: Useless parentheses. +src/net/sf/freecol/common/model/BuildQueue.java:179: Useless parentheses. +src/net/sf/freecol/common/model/BuildQueue.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildQueue.java:182: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/BuildQueue.java:184: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/BuildQueue.java:206: Comment is too large: Too many lines +src/net/sf/freecol/common/model/BuildQueue.java:220: Avoid variables with short names like id +src/net/sf/freecol/common/model/BuildQueue.java:220: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:221: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/BuildQueue.java:228: Avoid variables with short names like id +src/net/sf/freecol/common/model/BuildQueue.java:228: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildQueue.java:237: Found 'UR'-anomaly for variable 'item' (lines '237'-'241'). +src/net/sf/freecol/common/model/BuildQueue.java:238: Avoid variables with short names like sb +src/net/sf/freecol/common/model/BuildQueue.java:238: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:239: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/BuildQueue.java:240: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/BuildQueue.java:241: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/BuildQueue.java:243: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/BuildableType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/BuildableType.java:23: Avoid unused imports such as 'java.util.Arrays' +src/net/sf/freecol/common/model/BuildableType.java:28: Avoid unused imports such as 'java.util.Map.Entry' +src/net/sf/freecol/common/model/BuildableType.java:29: Avoid unused imports such as 'java.util.stream.Collectors' +src/net/sf/freecol/common/model/BuildableType.java:35: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/BuildableType.java:42: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/BuildableType.java:45: Avoid excessively long variable names like DEFAULT_REQUIRED_POPULATION +src/net/sf/freecol/common/model/BuildableType.java:51: Avoid excessively long variable names like requiredPopulation +src/net/sf/freecol/common/model/BuildableType.java:54: Avoid using redundant field initializer for 'requiredAbilities' +src/net/sf/freecol/common/model/BuildableType.java:57: Avoid using redundant field initializer for 'requiredGoods' +src/net/sf/freecol/common/model/BuildableType.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildableType.java:60: Avoid using redundant field initializer for 'limits' +src/net/sf/freecol/common/model/BuildableType.java:69: Avoid variables with short names like id +src/net/sf/freecol/common/model/BuildableType.java:69: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:69: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildableType.java:103: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:103: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/BuildableType.java:105: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/BuildableType.java:114: Parameter 'abilities' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:124: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:124: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:137: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:140: Avoid variables with short names like e +src/net/sf/freecol/common/model/BuildableType.java:140: Avoid variables with short names like o +src/net/sf/freecol/common/model/BuildableType.java:151: Found 'UR'-anomaly for variable 'ag' (lines '151'-'155'). +src/net/sf/freecol/common/model/BuildableType.java:152: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/BuildableType.java:152: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildableType.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildableType.java:153: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:154: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:155: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/BuildableType.java:167: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:176: Avoid variables with short names like ag +src/net/sf/freecol/common/model/BuildableType.java:176: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:177: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildableType.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildableType.java:196: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildableType.java:205: Parameter 'newLimits' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:214: Parameter 'limit' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:215: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildableType.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildableType.java:232: Avoid excessively long variable names like REQUIRED_ABILITY_TAG +src/net/sf/freecol/common/model/BuildableType.java:232: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildableType.java:232: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildableType.java:233: Avoid excessively long variable names like REQUIRED_GOODS_TAG +src/net/sf/freecol/common/model/BuildableType.java:233: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildableType.java:233: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildableType.java:235: Avoid excessively long variable names like REQUIRED_POPULATION_TAG +src/net/sf/freecol/common/model/BuildableType.java:235: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildableType.java:235: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildableType.java:242: Avoid variables with short names like xw +src/net/sf/freecol/common/model/BuildableType.java:242: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:245: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/BuildableType.java:254: Avoid variables with short names like xw +src/net/sf/freecol/common/model/BuildableType.java:254: Found 'UR'-anomaly for variable 'entry' (lines '254'-'262'). +src/net/sf/freecol/common/model/BuildableType.java:254: Found 'UR'-anomaly for variable 'goods' (lines '254'-'273'). +src/net/sf/freecol/common/model/BuildableType.java:254: Found 'UR'-anomaly for variable 'limit' (lines '254'-'280'). +src/net/sf/freecol/common/model/BuildableType.java:254: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:258: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:270: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:280: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/BuildableType.java:280: Local variable 'limit' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:287: Avoid variables with short names like xr +src/net/sf/freecol/common/model/BuildableType.java:287: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:298: Avoid variables with short names like xr +src/net/sf/freecol/common/model/BuildableType.java:298: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:300: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/BuildableType.java:301: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/BuildableType.java:302: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/BuildableType.java:312: Avoid variables with short names like xr +src/net/sf/freecol/common/model/BuildableType.java:312: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildableType.java:313: Found 'DU'-anomaly for variable 'spec' (lines '313'-'339'). +src/net/sf/freecol/common/model/BuildableType.java:317: Avoid variables with short names like id +src/net/sf/freecol/common/model/BuildableType.java:317: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildableType.java:323: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:325: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:329: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildableType.java:330: Local variable 'limit' could be declared final +src/net/sf/freecol/common/model/BuildableType.java:331: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildableType.java:332: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Building.java:20: Possible God class (WMC=82, ATFD=43, TCC=0.03333333333333333) +src/net/sf/freecol/common/model/Building.java:38: The class 'Building' has a Cyclomatic Complexity of 2 (Highest = 24). +src/net/sf/freecol/common/model/Building.java:38: The class 'Building' has a Modified Cyclomatic Complexity of 2 (Highest = 22). +src/net/sf/freecol/common/model/Building.java:38: The class 'Building' has a Standard Cyclomatic Complexity of 2 (Highest = 22). +src/net/sf/freecol/common/model/Building.java:39: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Building.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Building.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Building.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Building.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Building.java:57: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:57: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:57: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:74: Avoid variables with short names like id +src/net/sf/freecol/common/model/Building.java:74: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:74: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:88: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Building.java:99: Found 'UR'-anomaly for variable 'unit' (lines '99'-'116'). +src/net/sf/freecol/common/model/Building.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:103: Local variable 'eject' could be declared final +src/net/sf/freecol/common/model/Building.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:115: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Building.java:116: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:121: Found 'DU'-anomaly for variable 'extra' (lines '121'-'131'). +src/net/sf/freecol/common/model/Building.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:122: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Building.java:123: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:171: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Building.java:171: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:172: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/Building.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:186: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Building.java:186: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:187: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/Building.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:198: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:210: Parameter 'available' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:210: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:214: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Building.java:224: Avoid really long methods. +src/net/sf/freecol/common/model/Building.java:224: Found 'UR'-anomaly for variable 'input' (lines '224'-'283'). +src/net/sf/freecol/common/model/Building.java:224: Found 'UR'-anomaly for variable 'output' (lines '224'-'244'). +src/net/sf/freecol/common/model/Building.java:224: Parameter 'inputs' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:224: The method 'getAdjustedProductionInfo' has a Cyclomatic Complexity of 24. +src/net/sf/freecol/common/model/Building.java:224: The method 'getAdjustedProductionInfo' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/common/model/Building.java:224: The method 'getAdjustedProductionInfo' has a Standard Cyclomatic Complexity of 22. +src/net/sf/freecol/common/model/Building.java:224: The method getAdjustedProductionInfo() has an NPath complexity of 56700 +src/net/sf/freecol/common/model/Building.java:225: Parameter 'outputs' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:226: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Building.java:227: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Building.java:227: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:229: Found 'DU'-anomaly for variable 'turn' (lines '229'-'356'). +src/net/sf/freecol/common/model/Building.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:238: Found 'DD'-anomaly for variable 'maximumRatio' (lines '238'-'248'). +src/net/sf/freecol/common/model/Building.java:238: Found 'DD'-anomaly for variable 'minimumRatio' (lines '238'-'248'). +src/net/sf/freecol/common/model/Building.java:238: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Building.java:243: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/Building.java:244: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:246: Local variable 'available' could be declared final +src/net/sf/freecol/common/model/Building.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:248: Found 'DD'-anomaly for variable 'maximumRatio' (lines '248'-'248'). +src/net/sf/freecol/common/model/Building.java:248: Found 'DD'-anomaly for variable 'minimumRatio' (lines '248'-'248'). +src/net/sf/freecol/common/model/Building.java:250: Local variable 'divisor' could be declared final +src/net/sf/freecol/common/model/Building.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:252: Local variable 'factor' could be declared final +src/net/sf/freecol/common/model/Building.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:254: Local variable 'production' could be declared final +src/net/sf/freecol/common/model/Building.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:254: Useless parentheses. +src/net/sf/freecol/common/model/Building.java:254: Useless parentheses. +src/net/sf/freecol/common/model/Building.java:258: Local variable 'newRatio' could be declared final +src/net/sf/freecol/common/model/Building.java:264: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/Building.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:267: Avoid variables with short names like u +src/net/sf/freecol/common/model/Building.java:275: Local variable 'newRatio' could be declared final +src/net/sf/freecol/common/model/Building.java:282: Local variable 'input' could be declared final +src/net/sf/freecol/common/model/Building.java:283: Local variable 'required' could be declared final +src/net/sf/freecol/common/model/Building.java:284: Found 'DD'-anomaly for variable 'available' (lines '284'-'286'). +src/net/sf/freecol/common/model/Building.java:286: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:292: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:293: Local variable 'minimumGoodsInput' could be declared final +src/net/sf/freecol/common/model/Building.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:295: Avoid variables with short names like u +src/net/sf/freecol/common/model/Building.java:311: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/Building.java:313: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:314: Local variable 'headroom' could be declared final +src/net/sf/freecol/common/model/Building.java:329: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Building.java:329: Found 'DU'-anomaly for variable 'epsilon' (lines '329'-'356'). +src/net/sf/freecol/common/model/Building.java:330: Local variable 'input' could be declared final +src/net/sf/freecol/common/model/Building.java:331: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/Building.java:333: Local variable 'consumption' could be declared final +src/net/sf/freecol/common/model/Building.java:335: Avoid excessively long variable names like maximumConsumption +src/net/sf/freecol/common/model/Building.java:335: Local variable 'maximumConsumption' could be declared final +src/net/sf/freecol/common/model/Building.java:337: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Building.java:339: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Building.java:342: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/Building.java:343: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/Building.java:346: Local variable 'production' could be declared final +src/net/sf/freecol/common/model/Building.java:348: Local variable 'maximumProduction' could be declared final +src/net/sf/freecol/common/model/Building.java:350: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Building.java:352: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Building.java:365: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:367: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:367: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:367: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:367: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:368: Avoid variables with short names like ag +src/net/sf/freecol/common/model/Building.java:393: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:401: Avoid using short method names +src/net/sf/freecol/common/model/Building.java:410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:425: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:429: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:439: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:452: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Building.java:492: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:492: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:494: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:501: Parameter 'productionType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:502: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:502: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:505: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:512: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:513: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:514: Found 'DU'-anomaly for variable 'type' (lines '514'-'537'). +src/net/sf/freecol/common/model/Building.java:515: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Building.java:515: Avoid variables with short names like id +src/net/sf/freecol/common/model/Building.java:518: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:520: Local variable 'mods' could be declared final +src/net/sf/freecol/common/model/Building.java:522: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:529: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:532: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:543: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:544: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:545: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:564: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:585: Avoid variables with short names like id +src/net/sf/freecol/common/model/Building.java:585: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:585: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:586: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:588: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:595: Avoid variables with short names like id +src/net/sf/freecol/common/model/Building.java:595: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:595: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:596: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:605: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:606: Found 'DD'-anomaly for variable 'cmp' (lines '606'-'609'). +src/net/sf/freecol/common/model/Building.java:608: Local variable 'building' could be declared final +src/net/sf/freecol/common/model/Building.java:609: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:609: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Building.java:611: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Building.java:618: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Building.java:618: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Building.java:625: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Building.java:625: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:635: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Building.java:635: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Building.java:649: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Building.java:649: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Building.java:650: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Building.java:651: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Building.java:653: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Building.java:653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Building.java:654: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/BuildingType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/BuildingType.java:20: Possible God class (WMC=64, ATFD=57, TCC=0.046153846153846156) +src/net/sf/freecol/common/model/BuildingType.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:52: Avoid using redundant field initializer for 'upkeep' +src/net/sf/freecol/common/model/BuildingType.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:58: Avoid using redundant field initializer for 'upgradesFrom' +src/net/sf/freecol/common/model/BuildingType.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:61: Avoid using redundant field initializer for 'upgradesTo' +src/net/sf/freecol/common/model/BuildingType.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/BuildingType.java:73: Avoid variables with short names like id +src/net/sf/freecol/common/model/BuildingType.java:73: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:73: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:125: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:127: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/BuildingType.java:139: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:198: Parameter 'productionType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:199: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:209: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:213: Comment is too large: Too many lines +src/net/sf/freecol/common/model/BuildingType.java:225: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:226: Parameter 'level' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:227: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildingType.java:227: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildingType.java:228: Avoid variables with short names like pt +src/net/sf/freecol/common/model/BuildingType.java:240: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/BuildingType.java:240: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:241: Local variable 'inputs' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildingType.java:242: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/BuildingType.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildingType.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:242: Useless parentheses. +src/net/sf/freecol/common/model/BuildingType.java:242: Useless parentheses. +src/net/sf/freecol/common/model/BuildingType.java:252: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/BuildingType.java:252: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:253: Local variable 'outputs' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildingType.java:254: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/BuildingType.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildingType.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:254: Useless parentheses. +src/net/sf/freecol/common/model/BuildingType.java:254: Useless parentheses. +src/net/sf/freecol/common/model/BuildingType.java:275: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:275: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:281: Comment is too large: Too many lines +src/net/sf/freecol/common/model/BuildingType.java:292: Avoid reassigning parameters such as 'productionType' +src/net/sf/freecol/common/model/BuildingType.java:293: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:293: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:294: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/BuildingType.java:294: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:299: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/BuildingType.java:299: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:300: Local variable 'best' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:304: Comment is too large: Too many lines +src/net/sf/freecol/common/model/BuildingType.java:313: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:314: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:315: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/BuildingType.java:315: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:316: Found 'DD'-anomaly for variable 'amount' (lines '316'-'317'). +src/net/sf/freecol/common/model/BuildingType.java:319: Useless parentheses. +src/net/sf/freecol/common/model/BuildingType.java:319: Useless parentheses. +src/net/sf/freecol/common/model/BuildingType.java:329: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:330: Found 'DD'-anomaly for variable 'cmp' (lines '330'-'335'). +src/net/sf/freecol/common/model/BuildingType.java:332: Avoid variables with short names like bt +src/net/sf/freecol/common/model/BuildingType.java:332: Local variable 'bt' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:337: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:344: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:344: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:345: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:345: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:346: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:346: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:347: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:347: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:348: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:348: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:349: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:349: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:350: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:350: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:352: Avoid excessively long variable names like BASIC_PRODUCTION_TAG +src/net/sf/freecol/common/model/BuildingType.java:352: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:352: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:353: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:353: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:354: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:354: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:357: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:357: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:358: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:358: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:359: Avoid excessively long variable names like OLD_UPGRADES_FROM_TAG +src/net/sf/freecol/common/model/BuildingType.java:359: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/BuildingType.java:359: fieldCommentRequirement Required +src/net/sf/freecol/common/model/BuildingType.java:367: Avoid variables with short names like xw +src/net/sf/freecol/common/model/BuildingType.java:367: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:398: Avoid variables with short names like xw +src/net/sf/freecol/common/model/BuildingType.java:398: Found 'UR'-anomaly for variable 'productionType' (lines '398'-'402'). +src/net/sf/freecol/common/model/BuildingType.java:398: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:401: Local variable 'productionType' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:411: Avoid variables with short names like xr +src/net/sf/freecol/common/model/BuildingType.java:411: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:416: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:425: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:441: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:448: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/BuildingType.java:455: Local variable 'basicProduction' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:457: Local variable 'consumes' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:459: Local variable 'produces' could be declared final +src/net/sf/freecol/common/model/BuildingType.java:460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:468: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:472: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/BuildingType.java:473: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/BuildingType.java:482: Avoid variables with short names like xr +src/net/sf/freecol/common/model/BuildingType.java:482: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/BuildingType.java:483: Found 'DU'-anomaly for variable 'spec' (lines '483'-'498'). +src/net/sf/freecol/common/model/ColonyTile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ColonyTile.java:20: Possible God class (WMC=76, ATFD=72, TCC=0.09523809523809523) +src/net/sf/freecol/common/model/ColonyTile.java:41: The class 'ColonyTile' has a Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/common/model/ColonyTile.java:41: The class 'ColonyTile' has a Modified Cyclomatic Complexity of 2 (Highest = 13). +src/net/sf/freecol/common/model/ColonyTile.java:41: The class 'ColonyTile' has a Standard Cyclomatic Complexity of 2 (Highest = 13). +src/net/sf/freecol/common/model/ColonyTile.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/ColonyTile.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyTile.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyTile.java:68: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:68: Parameter 'workTile' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:84: Avoid variables with short names like id +src/net/sf/freecol/common/model/ColonyTile.java:84: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:84: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:115: Parameter 'workTile' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:139: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ColonyTile.java:154: Found 'UR'-anomaly for variable 'output' (lines '154'-'159'). +src/net/sf/freecol/common/model/ColonyTile.java:154: Found 'UR'-anomaly for variable 'output' (lines '154'-'175'). +src/net/sf/freecol/common/model/ColonyTile.java:155: Found 'DU'-anomaly for variable 'colony' (lines '155'-'184'). +src/net/sf/freecol/common/model/ColonyTile.java:156: Avoid variables with short names like pi +src/net/sf/freecol/common/model/ColonyTile.java:156: Local variable 'pi' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:158: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:159: Avoid excessively long variable names like onlyNaturalImprovements +src/net/sf/freecol/common/model/ColonyTile.java:159: Found 'DD'-anomaly for variable 'onlyNaturalImprovements' (lines '159'-'159'). +src/net/sf/freecol/common/model/ColonyTile.java:159: Found 'DU'-anomaly for variable 'onlyNaturalImprovements' (lines '159'-'184'). +src/net/sf/freecol/common/model/ColonyTile.java:159: Local variable 'onlyNaturalImprovements' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:162: Found 'DD'-anomaly for variable 'potential' (lines '162'-'164'). +src/net/sf/freecol/common/model/ColonyTile.java:164: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:169: Local variable 'production' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:170: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ColonyTile.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:174: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:176: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:177: Avoid variables with short names like u +src/net/sf/freecol/common/model/ColonyTile.java:179: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ColonyTile.java:192: Avoid variables with short names like ti +src/net/sf/freecol/common/model/ColonyTile.java:192: Found 'UR'-anomaly for variable 'ag' (lines '192'-'227'). +src/net/sf/freecol/common/model/ColonyTile.java:192: Parameter 'ti' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:192: The method 'improvedBy' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/ColonyTile.java:192: The method 'improvedBy' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/ColonyTile.java:192: The method 'improvedBy' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/ColonyTile.java:192: The method improvedBy() has an NPath complexity of 2704 +src/net/sf/freecol/common/model/ColonyTile.java:195: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ColonyTile.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:198: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTile.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:201: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTile.java:201: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ColonyTile.java:204: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTile.java:204: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ColonyTile.java:206: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/ColonyTile.java:206: Found 'DU'-anomaly for variable 'resource' (lines '206'-'258'). +src/net/sf/freecol/common/model/ColonyTile.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:213: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTile.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:214: Avoid variables with short names like gt +src/net/sf/freecol/common/model/ColonyTile.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:220: Found 'DU'-anomaly for variable 'food' (lines '220'-'258'). +src/net/sf/freecol/common/model/ColonyTile.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:221: Avoid variables with short names like ag +src/net/sf/freecol/common/model/ColonyTile.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:226: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:231: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:237: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTile.java:241: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTile.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:255: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:267: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:270: Avoid variables with short names like ag +src/net/sf/freecol/common/model/ColonyTile.java:295: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/ColonyTile.java:303: Avoid using short method names +src/net/sf/freecol/common/model/ColonyTile.java:312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:313: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:313: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:314: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:329: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:330: Local variable 'reason' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:331: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/ColonyTile.java:339: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:339: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:350: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/ColonyTile.java:358: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:366: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:373: The method 'getNoWorkReason' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/ColonyTile.java:373: The method 'getNoWorkReason' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/ColonyTile.java:373: The method 'getNoWorkReason' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/ColonyTile.java:374: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:377: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:377: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:379: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/ColonyTile.java:379: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:379: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:380: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:384: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:384: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:384: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:392: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:392: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:418: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:418: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:427: Parameter 'productionType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:428: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:428: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:429: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:431: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:438: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:439: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:441: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTile.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:445: Found 'DU'-anomaly for variable 'type' (lines '445'-'471'). +src/net/sf/freecol/common/model/ColonyTile.java:445: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:446: Avoid variables with short names like id +src/net/sf/freecol/common/model/ColonyTile.java:446: Found 'DU'-anomaly for variable 'id' (lines '446'-'471'). +src/net/sf/freecol/common/model/ColonyTile.java:448: Found 'DU'-anomaly for variable 'owner' (lines '448'-'471'). +src/net/sf/freecol/common/model/ColonyTile.java:448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:449: Found 'DU'-anomaly for variable 'turn' (lines '449'-'471'). +src/net/sf/freecol/common/model/ColonyTile.java:449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:451: Local variable 'mods' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:455: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:456: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:463: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:464: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:467: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTile.java:477: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:478: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:478: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:480: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:481: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:489: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:489: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:490: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:490: Useless parentheses. +src/net/sf/freecol/common/model/ColonyTile.java:491: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:497: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ColonyTile.java:497: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyTile.java:504: Avoid variables with short names like xw +src/net/sf/freecol/common/model/ColonyTile.java:504: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:514: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ColonyTile.java:514: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:526: Avoid variables with short names like sb +src/net/sf/freecol/common/model/ColonyTile.java:526: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/ColonyTile.java:527: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ColonyTile.java:528: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ColonyTile.java:529: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ColonyTile.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTile.java:530: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ColonyTradeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ColonyTradeItem.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ColonyTradeItem.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ColonyTradeItem.java:53: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:53: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:53: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:54: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:75: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ColonyTradeItem.java:75: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:75: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:111: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:118: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:120: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ColonyTradeItem.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTradeItem.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:122: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyTradeItem.java:133: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:135: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ColonyTradeItem.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:147: Found 'DD'-anomaly for variable 'hash' (lines '147'-'148'). +src/net/sf/freecol/common/model/ColonyTradeItem.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyTradeItem.java:155: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ColonyTradeItem.java:155: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyTradeItem.java:156: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ColonyTradeItem.java:156: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyTradeItem.java:163: Avoid variables with short names like xw +src/net/sf/freecol/common/model/ColonyTradeItem.java:163: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:175: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ColonyTradeItem.java:175: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:188: Avoid variables with short names like sb +src/net/sf/freecol/common/model/ColonyTradeItem.java:188: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/ColonyTradeItem.java:189: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ColonyTradeItem.java:190: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ColonyTradeItem.java:190: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ColonyWas.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ColonyWas.java:35: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/ColonyWas.java:35: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/ColonyWas.java:35: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyWas.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ColonyWas.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyWas.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ColonyWas.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyWas.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ColonyWas.java:39: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyWas.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ColonyWas.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ColonyWas.java:48: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/model/ColonyWas.java:65: Avoid unused local variables such as 'ret'. +src/net/sf/freecol/common/model/ColonyWas.java:65: Found 'DD'-anomaly for variable 'ret' (lines '65'-'70'). +src/net/sf/freecol/common/model/ColonyWas.java:65: Found 'DD'-anomaly for variable 'ret' (lines '65'-'77'). +src/net/sf/freecol/common/model/ColonyWas.java:65: Found 'DD'-anomaly for variable 'ret' (lines '65'-'83'). +src/net/sf/freecol/common/model/ColonyWas.java:65: Found 'DD'-anomaly for variable 'ret' (lines '65'-'87'). +src/net/sf/freecol/common/model/ColonyWas.java:65: Found 'DU'-anomaly for variable 'ret' (lines '65'-'90'). +src/net/sf/freecol/common/model/ColonyWas.java:66: Local variable 'newPopulation' could be declared final +src/net/sf/freecol/common/model/ColonyWas.java:68: Avoid variables with short names like pc +src/net/sf/freecol/common/model/ColonyWas.java:68: Local variable 'pc' could be declared final +src/net/sf/freecol/common/model/ColonyWas.java:68: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/ColonyWas.java:70: Found 'DD'-anomaly for variable 'ret' (lines '70'-'77'). +src/net/sf/freecol/common/model/ColonyWas.java:70: Found 'DD'-anomaly for variable 'ret' (lines '70'-'83'). +src/net/sf/freecol/common/model/ColonyWas.java:70: Found 'DD'-anomaly for variable 'ret' (lines '70'-'87'). +src/net/sf/freecol/common/model/ColonyWas.java:70: Found 'DU'-anomaly for variable 'ret' (lines '70'-'90'). +src/net/sf/freecol/common/model/ColonyWas.java:72: Avoid excessively long variable names like newProductionBonus +src/net/sf/freecol/common/model/ColonyWas.java:72: Local variable 'newProductionBonus' could be declared final +src/net/sf/freecol/common/model/ColonyWas.java:74: Avoid variables with short names like pc +src/net/sf/freecol/common/model/ColonyWas.java:74: Local variable 'pc' could be declared final +src/net/sf/freecol/common/model/ColonyWas.java:74: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/ColonyWas.java:77: Found 'DD'-anomaly for variable 'ret' (lines '77'-'83'). +src/net/sf/freecol/common/model/ColonyWas.java:77: Found 'DD'-anomaly for variable 'ret' (lines '77'-'87'). +src/net/sf/freecol/common/model/ColonyWas.java:77: Found 'DU'-anomaly for variable 'ret' (lines '77'-'90'). +src/net/sf/freecol/common/model/ColonyWas.java:79: Local variable 'newBuildQueue' could be declared final +src/net/sf/freecol/common/model/ColonyWas.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ColonyWas.java:81: Avoid variables with short names like pc +src/net/sf/freecol/common/model/ColonyWas.java:81: Local variable 'pc' could be declared final +src/net/sf/freecol/common/model/ColonyWas.java:81: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/ColonyWas.java:83: Found 'DD'-anomaly for variable 'ret' (lines '83'-'87'). +src/net/sf/freecol/common/model/ColonyWas.java:83: Found 'DU'-anomaly for variable 'ret' (lines '83'-'90'). +src/net/sf/freecol/common/model/ColonyWas.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ColonyWas.java:87: Found 'DU'-anomaly for variable 'ret' (lines '87'-'90'). +src/net/sf/freecol/common/model/CombatModel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/CombatModel.java:31: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/CombatModel.java:33: enumCommentRequirement Required +src/net/sf/freecol/common/model/CombatModel.java:70: fieldCommentRequirement Required +src/net/sf/freecol/common/model/CombatModel.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/CombatModel.java:72: fieldCommentRequirement Required +src/net/sf/freecol/common/model/CombatModel.java:74: Parameter 'win' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:74: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/CombatModel.java:83: Avoid unnecessary constructors - the compiler will generate these for you +src/net/sf/freecol/common/model/CombatModel.java:83: Document empty constructor +src/net/sf/freecol/common/model/CombatModel.java:93: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:94: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:105: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:106: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:117: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:118: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:122: Comment is too large: Too many lines +src/net/sf/freecol/common/model/CombatModel.java:132: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:133: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:144: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:145: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:157: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:158: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:164: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:164: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:172: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:173: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/CombatModel.java:176: Local variable 'aPlayer' could be declared final +src/net/sf/freecol/common/model/CombatModel.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:177: Local variable 'dPlayer' could be declared final +src/net/sf/freecol/common/model/CombatModel.java:177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:178: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/CombatModel.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/CombatModel.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/CombatModel.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/CombatModel.java:178: Useless parentheses. +src/net/sf/freecol/common/model/CombatModel.java:178: Useless parentheses. +src/net/sf/freecol/common/model/CombatModel.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/CombatModel.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/CombatModel.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/CombatModel.java:179: Useless parentheses. +src/net/sf/freecol/common/model/CombatModel.java:179: Useless parentheses. +src/net/sf/freecol/common/model/CombatModel.java:191: Avoid variables with short names like u1 +src/net/sf/freecol/common/model/CombatModel.java:191: Avoid variables with short names like u2 +src/net/sf/freecol/common/model/CombatModel.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:192: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/CombatModel.java:205: Comment is too large: Too many lines +src/net/sf/freecol/common/model/CombatModel.java:228: Comment is too large: Too many lines +src/net/sf/freecol/common/model/CombatModel.java:252: Comment is too large: Too many lines +src/net/sf/freecol/common/model/DiplomaticTrade.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/DiplomaticTrade.java:20: Possible God class (WMC=62, ATFD=31, TCC=0.08739495798319327) +src/net/sf/freecol/common/model/DiplomaticTrade.java:31: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/DiplomaticTrade.java:42: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/DiplomaticTrade.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/DiplomaticTrade.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/DiplomaticTrade.java:85: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/DiplomaticTrade.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/DiplomaticTrade.java:91: Comment is too large: Too many lines +src/net/sf/freecol/common/model/DiplomaticTrade.java:100: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/DiplomaticTrade.java:100: Parameter 'context' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:100: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:101: Parameter 'recipient' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:101: Parameter 'sender' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:102: Parameter 'items' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:102: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:110: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/DiplomaticTrade.java:120: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/DiplomaticTrade.java:120: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:120: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:150: Parameter 'status' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:196: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:197: Use equals() to compare object references. +src/net/sf/freecol/common/model/DiplomaticTrade.java:208: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:208: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:224: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:235: Parameter 'newItem' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:247: Parameter 'newItem' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:256: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:266: Parameter 'itemClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:267: Local variable 'itemIterator' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:315: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:317: Avoid variables with short names like ti +src/net/sf/freecol/common/model/DiplomaticTrade.java:327: Avoid variables with short names like i +src/net/sf/freecol/common/model/DiplomaticTrade.java:327: Avoid variables with short names like ti +src/net/sf/freecol/common/model/DiplomaticTrade.java:327: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:328: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/DiplomaticTrade.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/DiplomaticTrade.java:336: Found 'UR'-anomaly for variable 'ti' (lines '336'-'339'). +src/net/sf/freecol/common/model/DiplomaticTrade.java:336: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:337: Local variable 'colonyList' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:338: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:352: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:353: Avoid variables with short names like i +src/net/sf/freecol/common/model/DiplomaticTrade.java:353: Avoid variables with short names like ti +src/net/sf/freecol/common/model/DiplomaticTrade.java:353: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/DiplomaticTrade.java:363: Found 'UR'-anomaly for variable 'ti' (lines '363'-'366'). +src/net/sf/freecol/common/model/DiplomaticTrade.java:363: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:364: Local variable 'goodsList' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:365: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:379: Avoid variables with short names like i +src/net/sf/freecol/common/model/DiplomaticTrade.java:379: Avoid variables with short names like ti +src/net/sf/freecol/common/model/DiplomaticTrade.java:379: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:380: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/DiplomaticTrade.java:380: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/DiplomaticTrade.java:388: Found 'UR'-anomaly for variable 'ti' (lines '388'-'391'). +src/net/sf/freecol/common/model/DiplomaticTrade.java:388: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:389: Local variable 'unitList' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:390: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:417: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/DiplomaticTrade.java:417: fieldCommentRequirement Required +src/net/sf/freecol/common/model/DiplomaticTrade.java:418: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/DiplomaticTrade.java:418: fieldCommentRequirement Required +src/net/sf/freecol/common/model/DiplomaticTrade.java:419: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/DiplomaticTrade.java:419: fieldCommentRequirement Required +src/net/sf/freecol/common/model/DiplomaticTrade.java:420: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/DiplomaticTrade.java:420: fieldCommentRequirement Required +src/net/sf/freecol/common/model/DiplomaticTrade.java:421: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/DiplomaticTrade.java:421: fieldCommentRequirement Required +src/net/sf/freecol/common/model/DiplomaticTrade.java:428: Avoid variables with short names like xw +src/net/sf/freecol/common/model/DiplomaticTrade.java:428: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:446: Avoid variables with short names like xw +src/net/sf/freecol/common/model/DiplomaticTrade.java:446: Found 'UR'-anomaly for variable 'item' (lines '446'-'449'). +src/net/sf/freecol/common/model/DiplomaticTrade.java:446: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:449: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/DiplomaticTrade.java:449: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:456: Avoid variables with short names like xr +src/net/sf/freecol/common/model/DiplomaticTrade.java:456: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:478: Avoid variables with short names like xr +src/net/sf/freecol/common/model/DiplomaticTrade.java:478: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:489: Avoid variables with short names like xr +src/net/sf/freecol/common/model/DiplomaticTrade.java:489: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:492: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:501: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:504: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:507: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/DiplomaticTrade.java:520: Found 'UR'-anomaly for variable 'item' (lines '520'-'529'). +src/net/sf/freecol/common/model/DiplomaticTrade.java:521: Avoid variables with short names like sb +src/net/sf/freecol/common/model/DiplomaticTrade.java:521: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/DiplomaticTrade.java:522: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/DiplomaticTrade.java:523: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/DiplomaticTrade.java:524: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/DiplomaticTrade.java:529: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/DiplomaticTrade.java:529: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/DiplomaticTrade.java:529: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/Direction.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Direction.java:47: Avoid excessively long variable names like NUMBER_OF_DIRECTIONS +src/net/sf/freecol/common/model/Direction.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Direction.java:49: Variables that are final and static should be all capitals, 'allDirections' is not all capitals. +src/net/sf/freecol/common/model/Direction.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Direction.java:55: Variables that are final and static should be all capitals, 'longSides' is not all capitals. +src/net/sf/freecol/common/model/Direction.java:55: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Direction.java:59: Variables that are final and static should be all capitals, 'corners' is not all capitals. +src/net/sf/freecol/common/model/Direction.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Direction.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Direction.java:66: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Direction.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Direction.java:78: Parameter 'evenDX' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:78: Parameter 'evenDY' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:78: Parameter 'oddDX' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:78: Parameter 'oddDY' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:93: Avoid variables with short names like x +src/net/sf/freecol/common/model/Direction.java:93: Avoid variables with short names like y +src/net/sf/freecol/common/model/Direction.java:93: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:93: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:94: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Direction.java:106: Avoid variables with short names like n +src/net/sf/freecol/common/model/Direction.java:106: Parameter 'n' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Direction.java:145: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Direction.java:146: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Direction.java:147: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Direction.java:148: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Direction.java:149: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Direction.java:150: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Direction.java:163: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:163: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:164: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Direction.java:177: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:177: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:178: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:179: Local variable 'directions' could be declared final +src/net/sf/freecol/common/model/Direction.java:181: This call to Collection.toArray() may be optimizable +src/net/sf/freecol/common/model/Direction.java:184: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Direction.java:200: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:200: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:201: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:205: Avoid variables with short names like r +src/net/sf/freecol/common/model/Direction.java:205: Found 'DU'-anomaly for variable 'r' (lines '205'-'222'). +src/net/sf/freecol/common/model/Direction.java:207: Found 'DD'-anomaly for variable 'ret' (lines '207'-'208'). +src/net/sf/freecol/common/model/Direction.java:208: Found 'DD'-anomaly for variable 'ret' (lines '208'-'214'). +src/net/sf/freecol/common/model/Direction.java:208: Found 'DD'-anomaly for variable 'ret' (lines '208'-'220'). +src/net/sf/freecol/common/model/Direction.java:210: Found 'DU'-anomaly for variable 'mask' (lines '210'-'222'). +src/net/sf/freecol/common/model/Direction.java:210: Found 'DU'-anomaly for variable 'step' (lines '210'-'222'). +src/net/sf/freecol/common/model/Direction.java:210: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Direction.java:212: Avoid variables with short names like dr +src/net/sf/freecol/common/model/Direction.java:212: Local variable 'dr' could be declared final +src/net/sf/freecol/common/model/Direction.java:213: Avoid variables with short names like dl +src/net/sf/freecol/common/model/Direction.java:213: Local variable 'dl' could be declared final +src/net/sf/freecol/common/model/Direction.java:214: Found 'DD'-anomaly for variable 'ret' (lines '214'-'215'). +src/net/sf/freecol/common/model/Direction.java:215: Found 'DD'-anomaly for variable 'ret' (lines '215'-'214'). +src/net/sf/freecol/common/model/Direction.java:215: Found 'DD'-anomaly for variable 'ret' (lines '215'-'220'). +src/net/sf/freecol/common/model/Direction.java:230: Parameter 'angle' is not assigned and could be declared final +src/net/sf/freecol/common/model/Direction.java:231: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Disaster.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Disaster.java:49: Avoid using redundant field initializer for 'natural' +src/net/sf/freecol/common/model/Disaster.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Disaster.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Disaster.java:55: Avoid using redundant field initializer for 'effects' +src/net/sf/freecol/common/model/Disaster.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Disaster.java:64: Avoid variables with short names like id +src/net/sf/freecol/common/model/Disaster.java:64: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:64: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Disaster.java:103: Parameter 'effect' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:104: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Disaster.java:111: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Disaster.java:111: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Disaster.java:112: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Disaster.java:112: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Disaster.java:113: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Disaster.java:113: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Disaster.java:120: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Disaster.java:120: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:132: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Disaster.java:132: Found 'UR'-anomaly for variable 'choice' (lines '132'-'136'). +src/net/sf/freecol/common/model/Disaster.java:132: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:135: Local variable 'choice' could be declared final +src/net/sf/freecol/common/model/Disaster.java:136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Disaster.java:144: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Disaster.java:144: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:149: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/Disaster.java:153: Useless parentheses. +src/net/sf/freecol/common/model/Disaster.java:153: Useless parentheses. +src/net/sf/freecol/common/model/Disaster.java:162: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Disaster.java:162: Found 'UR'-anomaly for variable 'choice' (lines '162'-'174'). +src/net/sf/freecol/common/model/Disaster.java:162: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:165: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Disaster.java:169: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/Disaster.java:171: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Disaster.java:172: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Disaster.java:173: Local variable 'choice' could be declared final +src/net/sf/freecol/common/model/Disaster.java:174: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Disaster.java:174: Local variable 'effect' could be declared final +src/net/sf/freecol/common/model/Disaster.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Disaster.java:187: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Disaster.java:187: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Disaster.java:188: Found 'DU'-anomaly for variable 'spec' (lines '188'-'199'). +src/net/sf/freecol/common/model/Disaster.java:192: Local variable 'effect' could be declared final +src/net/sf/freecol/common/model/Disaster.java:193: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Disaster.java:206: Found 'UR'-anomaly for variable 'choice' (lines '206'-'210'). +src/net/sf/freecol/common/model/Disaster.java:207: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Disaster.java:207: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Disaster.java:208: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Disaster.java:209: Local variable 'choice' could be declared final +src/net/sf/freecol/common/model/Disaster.java:210: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Disaster.java:212: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Effect.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Effect.java:33: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Effect.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:48: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:54: Avoid excessively long variable names like LOSS_OF_TILE_PRODUCTION +src/net/sf/freecol/common/model/Effect.java:54: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:56: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:58: Avoid excessively long variable names like LOSS_OF_BUILDING_PRODUCTION +src/net/sf/freecol/common/model/Effect.java:58: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Effect.java:65: Avoid using redundant field initializer for 'scopes' +src/net/sf/freecol/common/model/Effect.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Effect.java:71: Document empty constructor +src/net/sf/freecol/common/model/Effect.java:71: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Effect.java:80: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Effect.java:80: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Effect.java:80: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:80: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:90: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Effect.java:90: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Effect.java:123: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:124: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Effect.java:135: Useless parentheses. +src/net/sf/freecol/common/model/Effect.java:135: Useless parentheses. +src/net/sf/freecol/common/model/Effect.java:136: Avoid variables with short names like s +src/net/sf/freecol/common/model/Effect.java:142: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Effect.java:142: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Effect.java:149: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Effect.java:149: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:159: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Effect.java:159: Found 'UR'-anomaly for variable 'scope' (lines '159'-'162'). +src/net/sf/freecol/common/model/Effect.java:159: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:162: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Effect.java:162: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/Effect.java:169: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Effect.java:169: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:179: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Effect.java:179: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:182: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Effect.java:192: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Effect.java:192: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Effect.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Effect.java:207: Found 'UR'-anomaly for variable 'scope' (lines '207'-'211'). +src/net/sf/freecol/common/model/Effect.java:208: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Effect.java:208: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Effect.java:209: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Effect.java:210: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Effect.java:211: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Effect.java:211: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Effect.java:211: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/Effect.java:212: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/EquipmentType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/EquipmentType.java:32: Comment is too large: Too many lines +src/net/sf/freecol/common/model/EquipmentType.java:41: The class 'EquipmentType' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/model/EquipmentType.java:41: The class 'EquipmentType' has a Modified Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/model/EquipmentType.java:41: The class 'EquipmentType' has a Standard Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/model/EquipmentType.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EquipmentType.java:53: Avoid excessively long variable names like combatLossPriority +src/net/sf/freecol/common/model/EquipmentType.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EquipmentType.java:59: Avoid excessively long variable names like captureEquipmentId +src/net/sf/freecol/common/model/EquipmentType.java:59: Avoid using redundant field initializer for 'captureEquipmentId' +src/net/sf/freecol/common/model/EquipmentType.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EquipmentType.java:60: Avoid excessively long variable names like captureEquipmentByIndians +src/net/sf/freecol/common/model/EquipmentType.java:60: Avoid using redundant field initializer for 'captureEquipmentByIndians' +src/net/sf/freecol/common/model/EquipmentType.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EquipmentType.java:60: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:63: Avoid using redundant field initializer for 'role' +src/net/sf/freecol/common/model/EquipmentType.java:66: Avoid using redundant field initializer for 'militaryEquipment' +src/net/sf/freecol/common/model/EquipmentType.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EquipmentType.java:72: Avoid excessively long variable names like compatibleEquipment +src/net/sf/freecol/common/model/EquipmentType.java:72: Avoid using redundant field initializer for 'compatibleEquipment' +src/net/sf/freecol/common/model/EquipmentType.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EquipmentType.java:81: Avoid variables with short names like id +src/net/sf/freecol/common/model/EquipmentType.java:81: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:81: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:121: Parameter 'byIndians' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:122: Useless parentheses. +src/net/sf/freecol/common/model/EquipmentType.java:122: Useless parentheses. +src/net/sf/freecol/common/model/EquipmentType.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/EquipmentType.java:134: Parameter 'otherType' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:137: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:141: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/EquipmentType.java:149: Parameter 'equipmentId' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:150: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:168: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:190: Found 'DD'-anomaly for variable 'result' (lines '190'-'191'). +src/net/sf/freecol/common/model/EquipmentType.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/EquipmentType.java:201: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:201: The method 'equals' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/EquipmentType.java:201: The method 'equals' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/EquipmentType.java:201: The method 'equals' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/EquipmentType.java:202: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:203: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:204: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:205: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:206: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:207: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:208: Local variable 'other' could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:210: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:211: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:212: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:213: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:215: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EquipmentType.java:216: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:217: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EquipmentType.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/EquipmentType.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EquipmentType.java:218: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EquipmentType.java:225: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EquipmentType.java:225: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:226: Avoid excessively long variable names like CAPTURE_EQUIPMENT_TAG +src/net/sf/freecol/common/model/EquipmentType.java:226: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EquipmentType.java:226: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:227: Avoid excessively long variable names like COMBAT_LOSS_PRIORITY_TAG +src/net/sf/freecol/common/model/EquipmentType.java:227: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EquipmentType.java:227: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:228: Avoid excessively long variable names like COMPATIBLE_EQUIPMENT_TAG +src/net/sf/freecol/common/model/EquipmentType.java:228: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EquipmentType.java:228: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:229: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EquipmentType.java:229: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:230: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EquipmentType.java:230: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:232: Avoid excessively long variable names like REQUIRED_LOCATION_ABILITY_TAG +src/net/sf/freecol/common/model/EquipmentType.java:232: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EquipmentType.java:232: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EquipmentType.java:240: Avoid variables with short names like xw +src/net/sf/freecol/common/model/EquipmentType.java:240: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:254: Avoid variables with short names like xw +src/net/sf/freecol/common/model/EquipmentType.java:254: Found 'UR'-anomaly for variable 'compatible' (lines '254'-'271'). +src/net/sf/freecol/common/model/EquipmentType.java:254: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:268: Local variable 'compatible' could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:282: Avoid variables with short names like xr +src/net/sf/freecol/common/model/EquipmentType.java:282: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:289: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/EquipmentType.java:290: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/EquipmentType.java:297: Avoid variables with short names like xr +src/net/sf/freecol/common/model/EquipmentType.java:297: Found 'UR'-anomaly for variable 'modifier' (lines '297'-'308'). +src/net/sf/freecol/common/model/EquipmentType.java:297: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:300: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/EquipmentType.java:302: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/EquipmentType.java:307: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EquipmentType.java:308: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/EquipmentType.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EquipmentType.java:309: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/EquipmentType.java:320: Avoid variables with short names like xr +src/net/sf/freecol/common/model/EquipmentType.java:320: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:321: Found 'DU'-anomaly for variable 'spec' (lines '321'-'346'). +src/net/sf/freecol/common/model/EquipmentType.java:335: Local variable 'abilityId' could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:336: Local variable 'required' could be declared final +src/net/sf/freecol/common/model/EquipmentType.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EquipmentType.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Europe.java:20: Possible God class (WMC=84, ATFD=40, TCC=0.026829268292682926) +src/net/sf/freecol/common/model/Europe.java:44: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Europe.java:46: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/Europe.java:46: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Europe.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:49: Avoid excessively long variable names like RECRUIT_PRICE_INITIAL +src/net/sf/freecol/common/model/Europe.java:54: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:56: Avoid excessively long variable names like ABILITY_DRESS_MISSIONARY +src/net/sf/freecol/common/model/Europe.java:56: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:59: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Europe.java:83: Avoid excessively long variable names like CHOOSE_MIGRANT_SLOT +src/net/sf/freecol/common/model/Europe.java:89: Avoid excessively long variable names like DEFAULT_MIGRANT_SLOT +src/net/sf/freecol/common/model/Europe.java:91: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:95: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:99: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:103: Avoid variables with short names like x +src/net/sf/freecol/common/model/Europe.java:103: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:103: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:107: Avoid variables with short names like x +src/net/sf/freecol/common/model/Europe.java:107: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:107: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:111: Avoid variables with short names like x +src/net/sf/freecol/common/model/Europe.java:111: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:111: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:115: Avoid variables with short names like i +src/net/sf/freecol/common/model/Europe.java:115: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:115: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:116: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:116: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:120: Avoid variables with short names like x +src/net/sf/freecol/common/model/Europe.java:120: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:120: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:124: Avoid variables with short names like x +src/net/sf/freecol/common/model/Europe.java:124: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:124: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:128: Avoid variables with short names like x +src/net/sf/freecol/common/model/Europe.java:128: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:128: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:140: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Europe.java:143: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Europe.java:146: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Europe.java:161: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:161: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:169: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Europe.java:178: Avoid variables with short names like id +src/net/sf/freecol/common/model/Europe.java:178: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:178: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:198: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:201: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Europe.java:213: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:214: Local variable 'price' could be declared final +src/net/sf/freecol/common/model/Europe.java:215: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Europe.java:224: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Europe.java:224: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:225: Local variable 'required' could be declared final +src/net/sf/freecol/common/model/Europe.java:226: Local variable 'immigration' could be declared final +src/net/sf/freecol/common/model/Europe.java:227: Local variable 'difference' could be declared final +src/net/sf/freecol/common/model/Europe.java:232: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Europe.java:243: Found 'UR'-anomaly for variable 'u' (lines '243'-'247'). +src/net/sf/freecol/common/model/Europe.java:243: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:245: Avoid variables with short names like n +src/net/sf/freecol/common/model/Europe.java:245: Found 'DD'-anomaly for variable 'n' (lines '245'-'247'). +src/net/sf/freecol/common/model/Europe.java:246: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/Europe.java:247: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:247: Found 'DD'-anomaly for variable 'n' (lines '247'-'247'). +src/net/sf/freecol/common/model/Europe.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:252: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:273: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:274: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Europe.java:301: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:302: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Europe.java:304: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Europe.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:305: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:305: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:315: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:316: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Europe.java:316: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:324: Avoid using short method names +src/net/sf/freecol/common/model/Europe.java:357: Found 'UR'-anomaly for variable 'ag' (lines '357'-'362'). +src/net/sf/freecol/common/model/Europe.java:357: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:358: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Europe.java:359: Found 'DU'-anomaly for variable 'market' (lines '359'-'372'). +src/net/sf/freecol/common/model/Europe.java:359: Local variable 'market' could be declared final +src/net/sf/freecol/common/model/Europe.java:359: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:360: Found 'DD'-anomaly for variable 'price' (lines '360'-'366'). +src/net/sf/freecol/common/model/Europe.java:361: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/Europe.java:362: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:362: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:363: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/Europe.java:363: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:378: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:378: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:378: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:379: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Europe.java:390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:408: Avoid variables with short names like p +src/net/sf/freecol/common/model/Europe.java:408: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:419: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:427: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:427: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:428: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:428: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:436: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:436: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:437: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:437: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:437: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:437: Useless parentheses. +src/net/sf/freecol/common/model/Europe.java:449: Local variable 'owner' could be declared final +src/net/sf/freecol/common/model/Europe.java:451: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:452: Local variable 'highSeas' could be declared final +src/net/sf/freecol/common/model/Europe.java:452: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:453: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:453: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:465: Avoid variables with short names like id +src/net/sf/freecol/common/model/Europe.java:465: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:465: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:466: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:467: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Europe.java:469: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Europe.java:470: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Europe.java:478: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:478: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:479: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:479: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:480: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:480: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:481: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:481: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:482: Avoid excessively long variable names like RECRUIT_LOWER_CAP_TAG +src/net/sf/freecol/common/model/Europe.java:482: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:482: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:483: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:483: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:484: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:484: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:485: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:485: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:487: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:487: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:495: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Europe.java:495: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:511: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Europe.java:511: Found 'UR'-anomaly for variable 'ability' (lines '511'-'517'). +src/net/sf/freecol/common/model/Europe.java:511: Found 'UR'-anomaly for variable 'modifier' (lines '511'-'521'). +src/net/sf/freecol/common/model/Europe.java:511: Found 'UR'-anomaly for variable 'unitType' (lines '511'-'527'). +src/net/sf/freecol/common/model/Europe.java:511: Found 'UR'-anomaly for variable 'unitType' (lines '511'-'536'). +src/net/sf/freecol/common/model/Europe.java:511: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:516: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/Europe.java:520: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/Europe.java:524: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Europe.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:529: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:534: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Europe.java:543: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Europe.java:543: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Europe.java:543: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Europe.java:549: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Europe.java:549: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:552: Found 'DU'-anomaly for variable 'spec' (lines '552'-'573'). +src/net/sf/freecol/common/model/Europe.java:556: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Europe.java:579: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Europe.java:579: Found 'UR'-anomaly for variable 'u' (lines '579'-'597'). +src/net/sf/freecol/common/model/Europe.java:579: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:596: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/Europe.java:597: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:606: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Europe.java:606: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Europe.java:607: Found 'DU'-anomaly for variable 'spec' (lines '607'-'641'). +src/net/sf/freecol/common/model/Europe.java:610: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:613: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Europe.java:617: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Europe.java:619: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Europe.java:623: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Europe.java:626: Local variable 'price' could be declared final +src/net/sf/freecol/common/model/EuropeWas.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/EuropeWas.java:31: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/EuropeWas.java:31: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/EuropeWas.java:31: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeWas.java:33: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EuropeWas.java:33: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeWas.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EuropeWas.java:34: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeWas.java:37: Parameter 'europe' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeWas.java:37: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/EuropeWas.java:50: Found 'UR'-anomaly for variable 'u' (lines '50'-'56'). +src/net/sf/freecol/common/model/EuropeWas.java:51: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EuropeWas.java:51: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EuropeWas.java:52: Found 'DD'-anomaly for variable 'newUnit' (lines '52'-'62'). +src/net/sf/freecol/common/model/EuropeWas.java:53: Found 'DU'-anomaly for variable 'idMax' (lines '53'-'67'). +src/net/sf/freecol/common/model/EuropeWas.java:54: Found 'DU'-anomaly for variable 'unitPrefix' (lines '54'-'67'). +src/net/sf/freecol/common/model/EuropeWas.java:55: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/EuropeWas.java:56: Local variable 'uid' could be declared final +src/net/sf/freecol/common/model/EuropeWas.java:56: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EuropeWas.java:57: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EuropeWas.java:57: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EuropeWas.java:59: Avoid variables with short names like id +src/net/sf/freecol/common/model/EuropeWas.java:59: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/EuropeWas.java:59: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EuropeWas.java:59: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EuropeWas.java:61: Found 'DU'-anomaly for variable 'idMax' (lines '61'-'67'). +src/net/sf/freecol/common/model/EuropeWas.java:62: Found 'DD'-anomaly for variable 'newUnit' (lines '62'-'62'). +src/net/sf/freecol/common/model/EuropeWas.java:64: Avoid empty catch blocks +src/net/sf/freecol/common/model/EuropeWas.java:64: Avoid empty catch blocks +src/net/sf/freecol/common/model/EuropeWas.java:75: Local variable 'newUnitCount' could be declared final +src/net/sf/freecol/common/model/EuropeWas.java:80: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/EuropeanNationType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/EuropeanNationType.java:40: Avoid using redundant field initializer for 'ref' +src/net/sf/freecol/common/model/EuropeanNationType.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EuropeanNationType.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/EuropeanNationType.java:46: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/EuropeanNationType.java:55: Avoid variables with short names like id +src/net/sf/freecol/common/model/EuropeanNationType.java:55: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:55: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:96: Avoid variables with short names like ex +src/net/sf/freecol/common/model/EuropeanNationType.java:96: Local variable 'ex' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/EuropeanNationType.java:107: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:108: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/EuropeanNationType.java:108: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:109: Local variable 'defaultMap' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:110: Local variable 'difficultyMap' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:127: Avoid variables with short names like id +src/net/sf/freecol/common/model/EuropeanNationType.java:127: Parameter 'expert' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:127: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:127: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:128: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/EuropeanNationType.java:128: Local variable 'exTag' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:128: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/EuropeanNationType.java:128: Useless parentheses. +src/net/sf/freecol/common/model/EuropeanNationType.java:128: Useless parentheses. +src/net/sf/freecol/common/model/EuropeanNationType.java:140: Avoid excessively long variable names like EXPERT_STARTING_UNITS_TAG +src/net/sf/freecol/common/model/EuropeanNationType.java:140: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EuropeanNationType.java:140: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeanNationType.java:141: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EuropeanNationType.java:141: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeanNationType.java:142: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EuropeanNationType.java:142: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeanNationType.java:143: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EuropeanNationType.java:143: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeanNationType.java:144: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/EuropeanNationType.java:144: fieldCommentRequirement Required +src/net/sf/freecol/common/model/EuropeanNationType.java:151: Avoid variables with short names like xw +src/net/sf/freecol/common/model/EuropeanNationType.java:151: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:161: Avoid variables with short names like xw +src/net/sf/freecol/common/model/EuropeanNationType.java:161: Found 'UR'-anomaly for variable 'entry' (lines '161'-'169'). +src/net/sf/freecol/common/model/EuropeanNationType.java:161: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:167: Avoid assignments in operands +src/net/sf/freecol/common/model/EuropeanNationType.java:167: Found 'DD'-anomaly for variable 'map' (lines '167'-'173'). +src/net/sf/freecol/common/model/EuropeanNationType.java:168: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EuropeanNationType.java:173: Avoid assignments in operands +src/net/sf/freecol/common/model/EuropeanNationType.java:173: Found 'DU'-anomaly for variable 'map' (lines '173'-'179'). +src/net/sf/freecol/common/model/EuropeanNationType.java:173: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/EuropeanNationType.java:174: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/EuropeanNationType.java:181: Avoid variables with short names like id +src/net/sf/freecol/common/model/EuropeanNationType.java:181: Avoid variables with short names like xw +src/net/sf/freecol/common/model/EuropeanNationType.java:181: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:181: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:182: Avoid variables with short names like au +src/net/sf/freecol/common/model/EuropeanNationType.java:182: Parameter 'au' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:183: Parameter 'expert' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:194: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/EuropeanNationType.java:203: Avoid variables with short names like xr +src/net/sf/freecol/common/model/EuropeanNationType.java:203: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:208: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:218: Avoid variables with short names like xr +src/net/sf/freecol/common/model/EuropeanNationType.java:218: Found 'UR'-anomaly for variable 'entry' (lines '218'-'230'). +src/net/sf/freecol/common/model/EuropeanNationType.java:218: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:225: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:228: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:229: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/EuropeanNationType.java:230: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/EuropeanNationType.java:241: Avoid variables with short names like xr +src/net/sf/freecol/common/model/EuropeanNationType.java:241: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:245: Avoid variables with short names like id +src/net/sf/freecol/common/model/EuropeanNationType.java:245: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:247: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/EuropeanNationType.java:249: Found 'DD'-anomaly for variable 'roleId' (lines '249'-'253'). +src/net/sf/freecol/common/model/EuropeanNationType.java:256: Avoid variables with short names like ex +src/net/sf/freecol/common/model/EuropeanNationType.java:256: Local variable 'ex' could be declared final +src/net/sf/freecol/common/model/Event.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Event.java:42: Avoid using redundant field initializer for 'scoreValue' +src/net/sf/freecol/common/model/Event.java:45: Avoid using redundant field initializer for 'limits' +src/net/sf/freecol/common/model/Event.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Event.java:54: Avoid variables with short names like id +src/net/sf/freecol/common/model/Event.java:54: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:54: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:65: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Event.java:65: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:65: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Event.java:106: Avoid variables with short names like id +src/net/sf/freecol/common/model/Event.java:106: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:107: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Event.java:115: Parameter 'limit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:116: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Event.java:141: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Event.java:141: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Event.java:143: Avoid excessively long variable names like OLD_SCORE_VALUE_TAG +src/net/sf/freecol/common/model/Event.java:143: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Event.java:143: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Event.java:151: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Event.java:151: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:167: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Event.java:167: Found 'UR'-anomaly for variable 'limit' (lines '167'-'170'). +src/net/sf/freecol/common/model/Event.java:167: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:170: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Event.java:170: Local variable 'limit' could be declared final +src/net/sf/freecol/common/model/Event.java:177: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Event.java:177: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:187: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Event.java:194: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Event.java:194: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:197: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Event.java:207: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Event.java:207: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Event.java:208: Found 'DU'-anomaly for variable 'spec' (lines '208'-'224'). +src/net/sf/freecol/common/model/Event.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Event.java:212: Local variable 'limit' could be declared final +src/net/sf/freecol/common/model/Event.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ExportData.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ExportData.java:36: Avoid excessively long variable names like HIGH_LEVEL_DEFAULT +src/net/sf/freecol/common/model/ExportData.java:36: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:38: Avoid excessively long variable names like EXPORT_LEVEL_DEFAULT +src/net/sf/freecol/common/model/ExportData.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:50: Avoid using redundant field initializer for 'exported' +src/net/sf/freecol/common/model/ExportData.java:58: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ExportData.java:58: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ExportData.java:68: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ExportData.java:68: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ExportData.java:68: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ExportData.java:77: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ExportData.java:77: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/ExportData.java:147: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/ExportData.java:151: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:158: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ExportData.java:158: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:159: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ExportData.java:159: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:160: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ExportData.java:160: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:161: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ExportData.java:161: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ExportData.java:168: Avoid variables with short names like xw +src/net/sf/freecol/common/model/ExportData.java:168: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/ExportData.java:184: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ExportData.java:184: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Feature.java:20: Possible God class (WMC=75, ATFD=34, TCC=0.14245014245014245) +src/net/sf/freecol/common/model/Feature.java:40: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/Feature.java:40: Each class should declare at least one constructor +src/net/sf/freecol/common/model/Feature.java:40: The class 'Feature' has a Cyclomatic Complexity of 2 (Highest = 20). +src/net/sf/freecol/common/model/Feature.java:40: The class 'Feature' has a Modified Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/common/model/Feature.java:40: The class 'Feature' has a Standard Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/common/model/Feature.java:40: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Feature.java:52: Avoid using redundant field initializer for 'duration' +src/net/sf/freecol/common/model/Feature.java:65: Avoid using redundant field initializer for 'scopes' +src/net/sf/freecol/common/model/Feature.java:73: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:89: Useless parentheses. +src/net/sf/freecol/common/model/Feature.java:89: Useless parentheses. +src/net/sf/freecol/common/model/Feature.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Feature.java:152: Parameter 'scopes' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:161: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:162: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:228: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Feature.java:228: Useless parentheses. +src/net/sf/freecol/common/model/Feature.java:228: Useless parentheses. +src/net/sf/freecol/common/model/Feature.java:229: Avoid variables with short names like s +src/net/sf/freecol/common/model/Feature.java:263: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:268: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Feature.java:278: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:281: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:303: Avoid variables with short names like o +src/net/sf/freecol/common/model/Feature.java:303: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:303: The method 'equals' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/common/model/Feature.java:303: The method 'equals' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/Feature.java:303: The method 'equals' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/Feature.java:303: The method equals() has an NPath complexity of 1502 +src/net/sf/freecol/common/model/Feature.java:304: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:304: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:306: Local variable 'feature' could be declared final +src/net/sf/freecol/common/model/Feature.java:307: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:311: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:313: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:313: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:315: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:316: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Feature.java:317: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:320: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:320: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:322: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:323: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Feature.java:324: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:328: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:331: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:334: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:334: Avoid variables with short names like s +src/net/sf/freecol/common/model/Feature.java:334: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Feature.java:334: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Feature.java:335: Avoid variables with short names like s +src/net/sf/freecol/common/model/Feature.java:336: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:338: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Feature.java:347: Found 'UR'-anomaly for variable 'scope' (lines '347'-'358'). +src/net/sf/freecol/common/model/Feature.java:347: The method hashCode() has an NPath complexity of 375 +src/net/sf/freecol/common/model/Feature.java:353: Useless parentheses. +src/net/sf/freecol/common/model/Feature.java:353: Useless parentheses. +src/net/sf/freecol/common/model/Feature.java:355: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/Feature.java:367: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Feature.java:367: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Feature.java:368: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Feature.java:368: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Feature.java:369: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Feature.java:369: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Feature.java:370: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Feature.java:370: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Feature.java:371: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Feature.java:371: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Feature.java:378: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Feature.java:378: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:386: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Feature.java:386: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Feature.java:390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Feature.java:390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Feature.java:406: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Feature.java:406: Found 'UR'-anomaly for variable 'scope' (lines '406'-'409'). +src/net/sf/freecol/common/model/Feature.java:406: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:409: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Feature.java:409: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/Feature.java:416: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Feature.java:416: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:419: Found 'DU'-anomaly for variable 'spec' (lines '419'-'437'). +src/net/sf/freecol/common/model/Feature.java:421: Local variable 'str' could be declared final +src/net/sf/freecol/common/model/Feature.java:425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Feature.java:428: Local variable 'firstTurn' could be declared final +src/net/sf/freecol/common/model/Feature.java:429: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:431: Local variable 'lastTurn' could be declared final +src/net/sf/freecol/common/model/Feature.java:432: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Feature.java:443: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Feature.java:443: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:445: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Feature.java:454: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Feature.java:454: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Feature.java:457: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FeatureContainer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FeatureContainer.java:36: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FeatureContainer.java:48: The class 'FeatureContainer' has a Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/common/model/FeatureContainer.java:48: The class 'FeatureContainer' has a Modified Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/model/FeatureContainer.java:48: The class 'FeatureContainer' has a Standard Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/model/FeatureContainer.java:48: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/FeatureContainer.java:50: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/FeatureContainer.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FeatureContainer.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FeatureContainer.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FeatureContainer.java:54: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FeatureContainer.java:57: Avoid using redundant field initializer for 'abilities' +src/net/sf/freecol/common/model/FeatureContainer.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FeatureContainer.java:60: Avoid using redundant field initializer for 'modifiers' +src/net/sf/freecol/common/model/FeatureContainer.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FeatureContainer.java:79: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:97: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/FeatureContainer.java:99: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:110: Parameter 'abilitySet' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:111: Useless parentheses. +src/net/sf/freecol/common/model/FeatureContainer.java:111: Useless parentheses. +src/net/sf/freecol/common/model/FeatureContainer.java:113: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FeatureContainer.java:116: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FeatureContainer.java:126: Avoid variables with short names like id +src/net/sf/freecol/common/model/FeatureContainer.java:126: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:126: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:127: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:137: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FeatureContainer.java:141: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FeatureContainer.java:151: Avoid variables with short names like id +src/net/sf/freecol/common/model/FeatureContainer.java:151: Found 'UR'-anomaly for variable 'aset' (lines '151'-'158'). +src/net/sf/freecol/common/model/FeatureContainer.java:151: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:151: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:152: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:153: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:157: Local variable 'aset' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:161: Local variable 'aset' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:162: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:165: Avoid variables with short names like it +src/net/sf/freecol/common/model/FeatureContainer.java:165: Local variable 'it' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:167: Avoid variables with short names like a +src/net/sf/freecol/common/model/FeatureContainer.java:167: Local variable 'a' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:168: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:180: Parameter 'ability' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:181: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FeatureContainer.java:181: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:200: Parameter 'ability' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:201: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FeatureContainer.java:201: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:204: Local variable 'abilitySet' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:205: Useless parentheses. +src/net/sf/freecol/common/model/FeatureContainer.java:205: Useless parentheses. +src/net/sf/freecol/common/model/FeatureContainer.java:206: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FeatureContainer.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:216: Avoid variables with short names like id +src/net/sf/freecol/common/model/FeatureContainer.java:216: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:217: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:225: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FeatureContainer.java:235: Avoid variables with short names like id +src/net/sf/freecol/common/model/FeatureContainer.java:235: Found 'UR'-anomaly for variable 'mset' (lines '235'-'242'). +src/net/sf/freecol/common/model/FeatureContainer.java:235: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:235: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:236: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:237: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:241: Local variable 'mset' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:245: Local variable 'mset' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:246: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:249: Avoid variables with short names like it +src/net/sf/freecol/common/model/FeatureContainer.java:249: Local variable 'it' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:251: Avoid variables with short names like m +src/net/sf/freecol/common/model/FeatureContainer.java:251: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:252: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:258: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FeatureContainer.java:269: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:269: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:269: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/FeatureContainer.java:269: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/FeatureContainer.java:270: Avoid variables with short names like id +src/net/sf/freecol/common/model/FeatureContainer.java:270: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:270: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:282: Found 'UR'-anomaly for variable 'm' (lines '282'-'289'). +src/net/sf/freecol/common/model/FeatureContainer.java:282: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:282: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:283: Parameter 'mods' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:284: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FeatureContainer.java:284: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:285: Local variable 'modifiers' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:287: Found 'DD'-anomaly for variable 'result' (lines '287'-'291'). +src/net/sf/freecol/common/model/FeatureContainer.java:287: Found 'DU'-anomaly for variable 'result' (lines '287'-'294'). +src/net/sf/freecol/common/model/FeatureContainer.java:288: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:289: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:290: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FeatureContainer.java:290: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:291: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:302: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:303: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FeatureContainer.java:303: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:322: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:323: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FeatureContainer.java:323: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:326: Local variable 'modifierSet' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:327: Useless parentheses. +src/net/sf/freecol/common/model/FeatureContainer.java:327: Useless parentheses. +src/net/sf/freecol/common/model/FeatureContainer.java:328: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FeatureContainer.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:338: Avoid variables with short names like id +src/net/sf/freecol/common/model/FeatureContainer.java:338: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:339: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:351: Found 'UR'-anomaly for variable 'c' (lines '351'-'351'). +src/net/sf/freecol/common/model/FeatureContainer.java:351: Found 'UR'-anomaly for variable 'e' (lines '351'-'363'). +src/net/sf/freecol/common/model/FeatureContainer.java:351: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:352: Avoid variables with short names like c +src/net/sf/freecol/common/model/FeatureContainer.java:352: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:353: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:357: Avoid variables with short names like ca +src/net/sf/freecol/common/model/FeatureContainer.java:362: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:365: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FeatureContainer.java:375: Avoid variables with short names like cm +src/net/sf/freecol/common/model/FeatureContainer.java:380: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:383: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FeatureContainer.java:398: Found 'UR'-anomaly for variable 'a' (lines '398'-'412'). +src/net/sf/freecol/common/model/FeatureContainer.java:398: Found 'UR'-anomaly for variable 'c' (lines '398'-'398'). +src/net/sf/freecol/common/model/FeatureContainer.java:398: Found 'UR'-anomaly for variable 'key' (lines '398'-'409'). +src/net/sf/freecol/common/model/FeatureContainer.java:398: Found 'UR'-anomaly for variable 'm' (lines '398'-'428'). +src/net/sf/freecol/common/model/FeatureContainer.java:398: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:398: The method 'removeFeatures' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/FeatureContainer.java:398: The method 'removeFeatures' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/FeatureContainer.java:398: The method 'removeFeatures' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/FeatureContainer.java:399: Avoid variables with short names like c +src/net/sf/freecol/common/model/FeatureContainer.java:399: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:400: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:403: Avoid variables with short names like ca +src/net/sf/freecol/common/model/FeatureContainer.java:403: Local variable 'ca' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:405: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/FeatureContainer.java:408: Local variable 'key' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:409: Local variable 'abilitySet' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:410: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:411: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FeatureContainer.java:411: Local variable 'a' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:412: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:419: Avoid variables with short names like cm +src/net/sf/freecol/common/model/FeatureContainer.java:419: Local variable 'cm' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:421: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/FeatureContainer.java:424: Local variable 'key' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:425: Local variable 'modifierSet' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:426: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:427: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FeatureContainer.java:427: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:428: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FeatureContainer.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:458: Found 'UR'-anomaly for variable 'ability' (lines '458'-'461'). +src/net/sf/freecol/common/model/FeatureContainer.java:458: Found 'UR'-anomaly for variable 'modifier' (lines '458'-'470'). +src/net/sf/freecol/common/model/FeatureContainer.java:458: Parameter 'oldSource' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:459: Parameter 'newSource' is not assigned and could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:460: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:463: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FeatureContainer.java:463: Local variable 'newAbility' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:469: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:472: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FeatureContainer.java:472: Local variable 'newModifier' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:483: Found 'UR'-anomaly for variable 'ability' (lines '483'-'490'). +src/net/sf/freecol/common/model/FeatureContainer.java:483: Found 'UR'-anomaly for variable 'modifier' (lines '483'-'498'). +src/net/sf/freecol/common/model/FeatureContainer.java:484: Avoid variables with short names like sb +src/net/sf/freecol/common/model/FeatureContainer.java:484: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:486: Local variable 'abilities' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:487: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:489: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:490: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/FeatureContainer.java:492: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/FeatureContainer.java:494: Local variable 'modifiers' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FeatureContainer.java:497: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/FeatureContainer.java:498: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/FeatureContainer.java:500: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/FeatureContainer.java:502: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/FoundingFather.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FoundingFather.java:20: Possible God class (WMC=50, ATFD=16, TCC=0.09) +src/net/sf/freecol/common/model/FoundingFather.java:43: enumCommentRequirement Required +src/net/sf/freecol/common/model/FoundingFather.java:73: Avoid using redundant field initializer for 'scopes' +src/net/sf/freecol/common/model/FoundingFather.java:76: Avoid using redundant field initializer for 'events' +src/net/sf/freecol/common/model/FoundingFather.java:79: Avoid using redundant field initializer for 'upgrades' +src/net/sf/freecol/common/model/FoundingFather.java:82: Avoid using redundant field initializer for 'units' +src/net/sf/freecol/common/model/FoundingFather.java:91: Avoid variables with short names like id +src/net/sf/freecol/common/model/FoundingFather.java:91: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:91: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:112: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:131: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:142: Parameter 'age' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:143: Useless parentheses. +src/net/sf/freecol/common/model/FoundingFather.java:143: Useless parentheses. +src/net/sf/freecol/common/model/FoundingFather.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:172: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:173: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FoundingFather.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:203: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:204: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FoundingFather.java:214: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:235: Parameter 'fromType' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:235: Parameter 'toType' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:236: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FoundingFather.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:266: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:267: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FoundingFather.java:279: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:280: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/FoundingFather.java:280: Useless parentheses. +src/net/sf/freecol/common/model/FoundingFather.java:280: Useless parentheses. +src/net/sf/freecol/common/model/FoundingFather.java:282: Avoid variables with short names like s +src/net/sf/freecol/common/model/FoundingFather.java:288: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FoundingFather.java:288: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FoundingFather.java:289: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FoundingFather.java:289: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FoundingFather.java:290: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FoundingFather.java:290: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FoundingFather.java:291: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FoundingFather.java:291: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FoundingFather.java:292: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FoundingFather.java:292: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FoundingFather.java:293: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FoundingFather.java:293: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FoundingFather.java:300: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FoundingFather.java:300: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:306: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:314: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FoundingFather.java:314: Found 'UR'-anomaly for variable 'entry' (lines '314'-'333'). +src/net/sf/freecol/common/model/FoundingFather.java:314: Found 'UR'-anomaly for variable 'event' (lines '314'-'317'). +src/net/sf/freecol/common/model/FoundingFather.java:314: Found 'UR'-anomaly for variable 'scope' (lines '314'-'319'). +src/net/sf/freecol/common/model/FoundingFather.java:314: Found 'UR'-anomaly for variable 'unit' (lines '314'-'324'). +src/net/sf/freecol/common/model/FoundingFather.java:314: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:317: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/FoundingFather.java:317: Local variable 'event' could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:319: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/FoundingFather.java:319: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:321: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:330: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:333: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:333: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:346: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FoundingFather.java:346: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:361: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FoundingFather.java:361: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:364: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FoundingFather.java:365: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FoundingFather.java:366: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FoundingFather.java:367: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FoundingFather.java:377: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FoundingFather.java:377: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:378: Found 'DU'-anomaly for variable 'spec' (lines '378'-'401'). +src/net/sf/freecol/common/model/FoundingFather.java:382: Local variable 'fromType' could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:384: Local variable 'toType' could be declared final +src/net/sf/freecol/common/model/FoundingFather.java:392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FoundingFather.java:395: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColGameObject.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObject.java:34: Avoid unused imports such as 'org.w3c.dom.Element' +src/net/sf/freecol/common/model/FreeColGameObject.java:43: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/FreeColGameObject.java:45: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/FreeColGameObject.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColGameObject.java:51: Avoid using redundant field initializer for 'disposed' +src/net/sf/freecol/common/model/FreeColGameObject.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FreeColGameObject.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FreeColGameObject.java:57: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObject.java:66: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/FreeColGameObject.java:66: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:67: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/FreeColGameObject.java:81: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObject.java:92: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColGameObject.java:92: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/FreeColGameObject.java:92: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:92: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:99: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObject.java:118: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:141: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObject.java:151: Local variable 'fcgos' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColGameObject.java:179: Found 'UR'-anomaly for variable 'fcgo' (lines '179'-'184'). +src/net/sf/freecol/common/model/FreeColGameObject.java:180: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObject.java:181: Avoid variables with short names like lb +src/net/sf/freecol/common/model/FreeColGameObject.java:181: Local variable 'lb' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:183: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:190: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObject.java:199: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:202: Found 'DD'-anomaly for variable 'xml' (lines '202'-'208'). +src/net/sf/freecol/common/model/FreeColGameObject.java:204: Local variable 'nextId' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:204: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColGameObject.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColGameObject.java:206: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColGameObject.java:206: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColGameObject.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColGameObject.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColGameObject.java:210: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColGameObject.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColGameObject.java:212: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/FreeColGameObject.java:213: There is log block not surrounded by if +src/net/sf/freecol/common/model/FreeColGameObject.java:218: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObject.java:229: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/FreeColGameObject.java:229: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:233: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObject.java:242: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:257: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/FreeColGameObject.java:259: Avoid unused local variables such as 'ret'. +src/net/sf/freecol/common/model/FreeColGameObject.java:259: Found 'DU'-anomaly for variable 'ret' (lines '259'-'270'). +src/net/sf/freecol/common/model/FreeColGameObject.java:259: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:279: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FreeColGameObject.java:289: Avoid variables with short names like o +src/net/sf/freecol/common/model/FreeColGameObject.java:289: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:290: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColGameObject.java:290: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObject.java:294: Local variable 'fco' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:295: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColGameObject.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColGameObject.java:306: Local variable 'hash' could be declared final +src/net/sf/freecol/common/model/FreeColGameObject.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColGameObject.java:321: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColGameObject.java:321: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObjectListener.java:36: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/FreeColGameObjectListener.java:36: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColGameObjectListener.java:43: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/FreeColGameObjectListener.java:43: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColGameObjectListener.java:52: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/FreeColGameObjectType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObjectType.java:29: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObjectType.java:45: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/FreeColGameObjectType.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FreeColGameObjectType.java:55: Avoid using redundant field initializer for 'featureContainer' +src/net/sf/freecol/common/model/FreeColGameObjectType.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FreeColGameObjectType.java:72: Document empty constructor +src/net/sf/freecol/common/model/FreeColGameObjectType.java:72: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/FreeColGameObjectType.java:79: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColGameObjectType.java:79: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:89: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:100: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColGameObjectType.java:100: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/FreeColGameObjectType.java:100: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:100: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:113: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObjectType.java:117: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColGameObjectType.java:177: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColGameObjectType.java:177: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColGameObjectType.java:179: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColGameObjectType.java:179: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColGameObjectType.java:181: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColGameObjectType.java:181: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColGameObjectType.java:183: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColGameObjectType.java:183: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColGameObjectType.java:190: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColGameObjectType.java:190: Found 'UR'-anomaly for variable 'ability' (lines '190'-'194'). +src/net/sf/freecol/common/model/FreeColGameObjectType.java:190: Found 'UR'-anomaly for variable 'modifier' (lines '190'-'198'). +src/net/sf/freecol/common/model/FreeColGameObjectType.java:190: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:193: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:197: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:206: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColGameObjectType.java:206: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:208: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObjectType.java:217: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColGameObjectType.java:217: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:220: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObjectType.java:220: These nested if statements could be combined +src/net/sf/freecol/common/model/FreeColGameObjectType.java:230: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColGameObjectType.java:230: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:231: Found 'DU'-anomaly for variable 'spec' (lines '231'-'261'). +src/net/sf/freecol/common/model/FreeColGameObjectType.java:234: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColGameObjectType.java:240: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:241: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObjectType.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColGameObjectType.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColGameObjectType.java:252: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/FreeColGameObjectType.java:253: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColGameObjectType.java:255: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/common/model/FreeColObject.java:20: Possible God class (WMC=168, ATFD=39, TCC=0.03551912568306011) +src/net/sf/freecol/common/model/FreeColObject.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/model/FreeColObject.java:72: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/FreeColObject.java:72: Avoid really long classes. +src/net/sf/freecol/common/model/FreeColObject.java:73: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/FreeColObject.java:75: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/FreeColObject.java:75: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:77: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:78: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:82: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:88: Avoid using redundant field initializer for 'pcs' +src/net/sf/freecol/common/model/FreeColObject.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/FreeColObject.java:129: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:130: Useless parentheses. +src/net/sf/freecol/common/model/FreeColObject.java:130: Useless parentheses. +src/net/sf/freecol/common/model/FreeColObject.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:142: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:142: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:143: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FreeColObject.java:162: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:174: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:174: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:176: Local variable 'col' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:177: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:177: Useless parentheses. +src/net/sf/freecol/common/model/FreeColObject.java:177: Useless parentheses. +src/net/sf/freecol/common/model/FreeColObject.java:198: Local variable 'col' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:201: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:202: Avoid empty catch blocks +src/net/sf/freecol/common/model/FreeColObject.java:202: Avoid empty catch blocks +src/net/sf/freecol/common/model/FreeColObject.java:215: Parameter 'fco1' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:215: Parameter 'fco2' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:217: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:219: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:221: Local variable 'id1' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:222: Local variable 'id2' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:224: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:226: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:229: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:230: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:241: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:251: Avoid variables with short names like c +src/net/sf/freecol/common/model/FreeColObject.java:251: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:261: Avoid variables with short names like c +src/net/sf/freecol/common/model/FreeColObject.java:261: Avoid variables with short names like lb +src/net/sf/freecol/common/model/FreeColObject.java:261: Found 'UR'-anomaly for variable 't' (lines '261'-'263'). +src/net/sf/freecol/common/model/FreeColObject.java:261: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:261: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:263: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:263: Local variable 't' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:268: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:277: Parameter 'methodName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:277: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:278: Parameter 'defaultValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:281: Local variable 'method' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:283: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:285: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/FreeColObject.java:286: There is log block not surrounded by if +src/net/sf/freecol/common/model/FreeColObject.java:295: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:295: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:302: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:302: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:302: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:309: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:309: Parameter 'newValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:309: Parameter 'oldValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:309: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:309: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:315: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:315: Parameter 'newValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:315: Parameter 'oldValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:315: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:315: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:321: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:321: Parameter 'newValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:321: Parameter 'oldValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:321: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:321: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:327: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:327: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:333: Parameter 'newValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:333: Parameter 'oldValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:333: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:333: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:339: Parameter 'newValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:339: Parameter 'oldValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:339: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:339: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:345: Parameter 'newValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:345: Parameter 'oldValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:345: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:345: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:351: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:353: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:359: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:359: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:361: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:367: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:367: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:369: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:375: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:375: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:381: Parameter 'listener' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:381: Parameter 'propertyName' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:381: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:396: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/FreeColObject.java:406: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:406: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:418: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:418: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:418: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:422: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:431: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:431: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:431: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:432: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:442: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:443: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:452: Local variable 'abilities' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:473: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:473: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:485: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:485: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:486: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:490: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:501: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:501: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:502: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:503: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:504: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:504: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:505: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:506: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:515: Parameter 'ability' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:516: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:516: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:517: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:526: Parameter 'ability' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:527: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:527: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:528: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/FreeColObject.java:528: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:536: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:536: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:537: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:537: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:538: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:538: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:548: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:548: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:560: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:560: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:560: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:564: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:573: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:573: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:573: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:574: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:584: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:585: Local variable 'set' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:586: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:595: Local variable 'modifiers' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:616: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:616: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:628: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:628: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:629: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:633: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:645: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:645: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:646: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:647: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:648: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:648: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:649: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:650: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:653: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:662: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:662: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:662: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:662: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:666: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:677: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:677: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:678: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:678: Parameter 'fcgot' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:678: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:690: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:690: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:691: Parameter 'mods' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:701: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:702: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:702: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:703: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:703: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:713: Parameter 'modifier' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:714: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:714: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:715: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:715: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:716: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:724: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:724: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:725: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:725: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:726: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:726: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:735: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:736: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:736: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:737: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:737: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:745: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:746: Avoid variables with short names like fc +src/net/sf/freecol/common/model/FreeColObject.java:746: Local variable 'fc' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:747: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:747: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:769: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:773: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:785: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:785: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:792: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:804: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:804: Parameter 'writeScope' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:820: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:820: Parameter 'fields' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:824: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:838: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:838: Parameter 'writeScope' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:839: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/model/FreeColObject.java:839: Parameter 'fields' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:840: Avoid variables with short names like sw +src/net/sf/freecol/common/model/FreeColObject.java:840: Local variable 'sw' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:841: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:841: Found 'DD'-anomaly for variable 'xw' (lines '841'-'843'). +src/net/sf/freecol/common/model/FreeColObject.java:843: Found 'DU'-anomaly for variable 'xw' (lines '843'-'870'). +src/net/sf/freecol/common/model/FreeColObject.java:846: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:857: Local variable 'factory' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:861: Local variable 'builder' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:865: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/FreeColObject.java:873: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:882: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:883: Avoid variables with short names like id +src/net/sf/freecol/common/model/FreeColObject.java:884: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:895: Found 'UR'-anomaly for variable 'xml' (lines '895'-'895'). +src/net/sf/freecol/common/model/FreeColObject.java:895: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:897: Local variable 'factory' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:898: Local variable 'xmlTransformer' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:899: Local variable 'stringWriter' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:902: Found 'DU'-anomaly for variable 'xml' (lines '902'-'914'). +src/net/sf/freecol/common/model/FreeColObject.java:902: Local variable 'xml' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:904: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColObject.java:912: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/FreeColObject.java:923: Avoid variables with short names like o +src/net/sf/freecol/common/model/FreeColObject.java:923: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:924: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:924: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:926: Local variable 'fco' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:927: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:927: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:937: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:944: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColObject.java:948: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColObject.java:952: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColObject.java:955: Avoid excessively long variable names like PARTIAL_ATTRIBUTE_TAG +src/net/sf/freecol/common/model/FreeColObject.java:955: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColObject.java:957: Avoid excessively long variable names like OLD_PARTIAL_ATTRIBUTE_TAG +src/net/sf/freecol/common/model/FreeColObject.java:957: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColObject.java:957: fieldCommentRequirement Required +src/net/sf/freecol/common/model/FreeColObject.java:961: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/FreeColObject.java:974: Found 'UR'-anomaly for variable 't' (lines '974'-'976'). +src/net/sf/freecol/common/model/FreeColObject.java:974: Parameter 'items' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:975: System.err.println is used +src/net/sf/freecol/common/model/FreeColObject.java:976: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:976: Local variable 't' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:977: System.err.println is used +src/net/sf/freecol/common/model/FreeColObject.java:987: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:999: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:999: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1003: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1012: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1012: Parameter 'pretty' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1012: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1016: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:1031: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/common/model/FreeColObject.java:1031: Parameter 'out' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1031: Parameter 'pretty' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1031: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1033: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:1043: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:1053: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1062: Found 'UR'-anomaly for variable 'sw' (lines '1,062'-'1,062'). +src/net/sf/freecol/common/model/FreeColObject.java:1062: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1063: Avoid variables with short names like sw +src/net/sf/freecol/common/model/FreeColObject.java:1063: Found 'DU'-anomaly for variable 'sw' (lines '1,063'-'1,074'). +src/net/sf/freecol/common/model/FreeColObject.java:1063: Local variable 'sw' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1065: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:1070: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/FreeColObject.java:1088: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1103: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1103: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1104: Found 'DD'-anomaly for variable 'ret' (lines '1,104'-'1,108'). +src/net/sf/freecol/common/model/FreeColObject.java:1106: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColObject.java:1108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:1109: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/FreeColObject.java:1110: There is log block not surrounded by if +src/net/sf/freecol/common/model/FreeColObject.java:1115: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1126: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:1126: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1130: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1146: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:1146: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1146: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1156: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1166: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:1166: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1168: There is log block not surrounded by if +src/net/sf/freecol/common/model/FreeColObject.java:1174: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1184: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/FreeColObject.java:1184: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:1184: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1188: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1202: Avoid variables with short names like xw +src/net/sf/freecol/common/model/FreeColObject.java:1202: Found 'UR'-anomaly for variable 'field' (lines '1,202'-'1,214'). +src/net/sf/freecol/common/model/FreeColObject.java:1202: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1203: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/model/FreeColObject.java:1203: Parameter 'fields' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1213: Local variable 'field' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1214: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FreeColObject.java:1214: Local variable 'intro' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1220: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/FreeColObject.java:1221: There is log block not surrounded by if +src/net/sf/freecol/common/model/FreeColObject.java:1222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/FreeColObject.java:1227: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1236: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColObject.java:1236: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1256: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColObject.java:1256: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1257: Local variable 'newId' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1273: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColObject.java:1273: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1274: Local variable 'tag' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1278: Found 'DD'-anomaly for variable 'next' (lines '1,278'-'1,281'). +src/net/sf/freecol/common/model/FreeColObject.java:1278: Found 'DU'-anomaly for variable 'next' (lines '1,278'-'1,290'). +src/net/sf/freecol/common/model/FreeColObject.java:1283: There is log block not surrounded by if +src/net/sf/freecol/common/model/FreeColObject.java:1286: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:1292: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1303: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColObject.java:1303: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1309: Comment is too large: Too many lines +src/net/sf/freecol/common/model/FreeColObject.java:1321: Avoid variables with short names like xr +src/net/sf/freecol/common/model/FreeColObject.java:1321: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1322: Found 'DU'-anomaly for variable 'theClass' (lines '1,322'-'1,347'). +src/net/sf/freecol/common/model/FreeColObject.java:1324: Avoid variables with short names like n +src/net/sf/freecol/common/model/FreeColObject.java:1324: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1329: Local variable 'name' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1331: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/FreeColObject.java:1338: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/FreeColObject.java:1338: Local variable 'intro' could be declared final +src/net/sf/freecol/common/model/FreeColObject.java:1341: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/FreeColObject.java:1342: There is log block not surrounded by if +src/net/sf/freecol/common/model/FreeColObject.java:1355: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/FreeColObject.java:1375: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/Game.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Game.java:20: High amount of different objects as members denotes a high coupling +src/net/sf/freecol/common/model/Game.java:20: Possible God class (WMC=172, ATFD=112, TCC=0.016650016650016652) +src/net/sf/freecol/common/model/Game.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/model/Game.java:55: Avoid really long classes. +src/net/sf/freecol/common/model/Game.java:55: Avoid short class names like Game +src/net/sf/freecol/common/model/Game.java:55: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Game.java:55: Too many fields +src/net/sf/freecol/common/model/Game.java:57: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Game.java:57: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:69: Variables that are final and static should be all capitals, 'serverClasses' is not all capitals. +src/net/sf/freecol/common/model/Game.java:95: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:96: Variables that are final and static should be all capitals, 'locationClasses' is not all capitals. +src/net/sf/freecol/common/model/Game.java:123: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Game.java:126: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:126: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Game.java:129: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:129: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Game.java:132: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:135: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:138: Avoid using redundant field initializer for 'map' +src/net/sf/freecol/common/model/Game.java:138: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:144: Avoid using redundant field initializer for 'nationOptions' +src/net/sf/freecol/common/model/Game.java:144: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:147: Avoid using redundant field initializer for 'currentPlayer' +src/net/sf/freecol/common/model/Game.java:147: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:150: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:153: Avoid using redundant field initializer for 'spanishSuccession' +src/net/sf/freecol/common/model/Game.java:153: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:158: Avoid using redundant field initializer for 'specification' +src/net/sf/freecol/common/model/Game.java:158: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:158: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Game.java:165: Avoid excessively long variable names like freeColGameObjects +src/net/sf/freecol/common/model/Game.java:165: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/model/Game.java:165: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:176: Avoid using redundant field initializer for 'combatModel' +src/net/sf/freecol/common/model/Game.java:176: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:179: Avoid excessively long variable names like REMOVE_GC_THRESHOLD +src/net/sf/freecol/common/model/Game.java:179: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:182: Avoid using redundant field initializer for 'removeCount' +src/net/sf/freecol/common/model/Game.java:182: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:182: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Game.java:189: Avoid excessively long variable names like freeColGameObjectListener +src/net/sf/freecol/common/model/Game.java:189: Avoid using redundant field initializer for 'freeColGameObjectListener' +src/net/sf/freecol/common/model/Game.java:189: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:189: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Game.java:197: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:201: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:211: Parameter 'clientUserName' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:211: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:255: Avoid variables with short names like go +src/net/sf/freecol/common/model/Game.java:255: Parameter 'go' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:275: Parameter 'mgo' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:295: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:295: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:296: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:296: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:297: Avoid variables with short names like ro +src/net/sf/freecol/common/model/Game.java:298: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:298: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:299: Avoid variables with short names like o +src/net/sf/freecol/common/model/Game.java:299: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:302: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:315: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:315: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:316: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:317: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/model/Game.java:319: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:325: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Game.java:335: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:335: Parameter 'fcgo' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:335: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:350: Avoid variables with short names like wr +src/net/sf/freecol/common/model/Game.java:364: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:364: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:364: Parameter 'reason' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:365: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:366: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:368: There is log block not surrounded by if +src/net/sf/freecol/common/model/Game.java:373: Avoid assignments in operands +src/net/sf/freecol/common/model/Game.java:374: Avoid unused local variables such as 'fcgo'. +src/net/sf/freecol/common/model/Game.java:374: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Game.java:374: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/model/Game.java:376: Do not explicitly trigger a garbage collection. +src/net/sf/freecol/common/model/Game.java:380: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Game.java:390: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:390: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:391: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/model/Game.java:392: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:392: Useless parentheses. +src/net/sf/freecol/common/model/Game.java:392: Useless parentheses. +src/net/sf/freecol/common/model/Game.java:395: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Game.java:412: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:413: Avoid variables with short names like it +src/net/sf/freecol/common/model/Game.java:414: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:417: Avoid using redundant field initializer for 'readAhead' +src/net/sf/freecol/common/model/Game.java:417: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:421: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:425: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:426: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:440: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:441: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:442: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/model/Game.java:448: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:455: There is log block not surrounded by if +src/net/sf/freecol/common/model/Game.java:469: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:501: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:512: Parameter 'nationId' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:513: Avoid variables with short names like p +src/net/sf/freecol/common/model/Game.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:522: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:523: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:523: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:524: Avoid variables with short names like p +src/net/sf/freecol/common/model/Game.java:534: Found 'UR'-anomaly for variable 'other' (lines '534'-'536'). +src/net/sf/freecol/common/model/Game.java:534: Parameter 'players' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:535: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Game.java:536: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Game.java:536: Local variable 'other' could be declared final +src/net/sf/freecol/common/model/Game.java:536: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:546: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:547: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:547: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:548: Avoid variables with short names like p +src/net/sf/freecol/common/model/Game.java:559: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:560: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:560: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:561: Avoid variables with short names like p +src/net/sf/freecol/common/model/Game.java:575: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Game.java:585: Parameter 'beforePlayer' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:586: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:586: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:591: Avoid assignments in operands +src/net/sf/freecol/common/model/Game.java:591: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:592: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Game.java:593: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:593: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:593: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:593: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:604: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:604: Useless parentheses. +src/net/sf/freecol/common/model/Game.java:604: Useless parentheses. +src/net/sf/freecol/common/model/Game.java:613: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:614: Avoid variables with short names like p +src/net/sf/freecol/common/model/Game.java:614: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:614: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:614: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:623: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:633: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:636: Local variable 'nation' could be declared final +src/net/sf/freecol/common/model/Game.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:637: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:638: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:639: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:641: There is log block not surrounded by if +src/net/sf/freecol/common/model/Game.java:652: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:653: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:653: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Game.java:653: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Game.java:653: Found 'DU'-anomaly for variable 'newCurrent' (lines '653'-'664'). +src/net/sf/freecol/common/model/Game.java:653: Local variable 'newCurrent' could be declared final +src/net/sf/freecol/common/model/Game.java:653: Use equals() to compare object references. +src/net/sf/freecol/common/model/Game.java:656: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:656: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:658: Local variable 'nation' could be declared final +src/net/sf/freecol/common/model/Game.java:658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:659: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:662: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:680: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:691: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:719: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:736: Parameter 'newCurrentPlayer' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:754: Found 'UR'-anomaly for variable 'player' (lines '754'-'757'). +src/net/sf/freecol/common/model/Game.java:754: Parameter 'newMap' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:756: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Game.java:757: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:758: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:758: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:758: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:759: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:759: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:790: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/Game.java:791: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:791: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:792: Avoid variables with short names like e +src/net/sf/freecol/common/model/Game.java:793: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:793: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:801: Found 'UR'-anomaly for variable 'entry' (lines '801'-'805'). +src/net/sf/freecol/common/model/Game.java:802: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Game.java:803: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/Game.java:804: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:835: Parameter 'newTurn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:845: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:871: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Game.java:889: Parameter 'fcgol' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:899: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:899: Parameter 'fcgo' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:899: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:910: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:910: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:923: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:924: Parameter 'newOwner' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:924: Parameter 'oldOwner' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:930: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Game.java:939: Avoid variables with short names like o +src/net/sf/freecol/common/model/Game.java:939: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:939: Parameter 'oldOwner' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:940: Local variable 'newOwner' could be declared final +src/net/sf/freecol/common/model/Game.java:941: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:941: Use equals() to compare object references. +src/net/sf/freecol/common/model/Game.java:946: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:947: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:971: Found 'UR'-anomaly for variable 'p' (lines '971'-'973'). +src/net/sf/freecol/common/model/Game.java:971: Found 'UR'-anomaly for variable 's' (lines '971'-'974'). +src/net/sf/freecol/common/model/Game.java:971: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:972: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/Game.java:973: Local variable 's' could be declared final +src/net/sf/freecol/common/model/Game.java:974: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Game.java:974: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:986: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:997: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:998: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:999: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:1000: Avoid variables with short names like o +src/net/sf/freecol/common/model/Game.java:1003: Found 'DD'-anomaly for variable 'o' (lines '1,003'-'1,005'). +src/net/sf/freecol/common/model/Game.java:1003: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1004: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/Game.java:1005: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:1016: Found 'UR'-anomaly for variable 'entry' (lines '1,016'-'1,045'). +src/net/sf/freecol/common/model/Game.java:1016: Found 'UR'-anomaly for variable 'fcgo' (lines '1,016'-'1,032'). +src/net/sf/freecol/common/model/Game.java:1017: Local variable 'stats' could be declared final +src/net/sf/freecol/common/model/Game.java:1020: Do not explicitly trigger a garbage collection. +src/net/sf/freecol/common/model/Game.java:1021: Local variable 'free' could be declared final +src/net/sf/freecol/common/model/Game.java:1021: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1022: Local variable 'total' could be declared final +src/net/sf/freecol/common/model/Game.java:1022: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1023: Local variable 'max' could be declared final +src/net/sf/freecol/common/model/Game.java:1023: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1029: Local variable 'objStats' could be declared final +src/net/sf/freecol/common/model/Game.java:1030: Found 'DD'-anomaly for variable 'disposed' (lines '1,030'-'1,041'). +src/net/sf/freecol/common/model/Game.java:1031: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/model/Game.java:1032: Local variable 'className' could be declared final +src/net/sf/freecol/common/model/Game.java:1032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1034: Found 'DD'-anomaly for variable 'count' (lines '1,034'-'1,035'). +src/net/sf/freecol/common/model/Game.java:1038: Local variable 'count' could be declared final +src/net/sf/freecol/common/model/Game.java:1041: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:1041: Found 'DD'-anomaly for variable 'disposed' (lines '1,041'-'1,041'). +src/net/sf/freecol/common/model/Game.java:1044: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/Game.java:1056: Avoid variables with short names like id +src/net/sf/freecol/common/model/Game.java:1056: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1057: Found 'DD'-anomaly for variable 'tag' (lines '1,057'-'1,058'). +src/net/sf/freecol/common/model/Game.java:1058: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1058: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1069: Avoid variables with short names like c +src/net/sf/freecol/common/model/Game.java:1069: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1070: Local variable 'rc' could be declared final +src/net/sf/freecol/common/model/Game.java:1071: Avoid variables with short names like rc +src/net/sf/freecol/common/model/Game.java:1083: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1084: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1085: Avoid variables with short names like rc +src/net/sf/freecol/common/model/Game.java:1085: Local variable 'rc' could be declared final +src/net/sf/freecol/common/model/Game.java:1085: Useless parentheses. +src/net/sf/freecol/common/model/Game.java:1085: Useless parentheses. +src/net/sf/freecol/common/model/Game.java:1087: Avoid variables with short names like c +src/net/sf/freecol/common/model/Game.java:1087: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/Game.java:1087: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1088: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1092: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/Game.java:1097: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Game.java:1106: Parameter 'xml' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1107: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1109: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Game.java:1109: Local variable 'xr' could be declared final +src/net/sf/freecol/common/model/Game.java:1111: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/Game.java:1112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1127: Found 'UR'-anomaly for variable 'player' (lines '1,127'-'1,160'). +src/net/sf/freecol/common/model/Game.java:1127: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1128: Found 'DD'-anomaly for variable 'result' (lines '1,128'-'1,145'). +src/net/sf/freecol/common/model/Game.java:1128: Found 'DD'-anomaly for variable 'result' (lines '1,128'-'1,147'). +src/net/sf/freecol/common/model/Game.java:1128: Found 'DD'-anomaly for variable 'result' (lines '1,128'-'1,157'). +src/net/sf/freecol/common/model/Game.java:1128: Found 'DD'-anomaly for variable 'result' (lines '1,128'-'1,160'). +src/net/sf/freecol/common/model/Game.java:1129: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Game.java:1129: Local variable 'lb' could be declared final +src/net/sf/freecol/common/model/Game.java:1130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1132: Local variable 'iterator' could be declared final +src/net/sf/freecol/common/model/Game.java:1134: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/model/Game.java:1136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1147: Found 'DD'-anomaly for variable 'result' (lines '1,147'-'1,145'). +src/net/sf/freecol/common/model/Game.java:1147: Found 'DD'-anomaly for variable 'result' (lines '1,147'-'1,147'). +src/net/sf/freecol/common/model/Game.java:1147: Found 'DD'-anomaly for variable 'result' (lines '1,147'-'1,157'). +src/net/sf/freecol/common/model/Game.java:1147: Found 'DD'-anomaly for variable 'result' (lines '1,147'-'1,160'). +src/net/sf/freecol/common/model/Game.java:1150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1151: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:1151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1155: Local variable 'map' could be declared final +src/net/sf/freecol/common/model/Game.java:1157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1159: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Game.java:1160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1177: Avoid variables with short names like o +src/net/sf/freecol/common/model/Game.java:1177: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1192: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:1192: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:1193: Avoid excessively long variable names like CURRENT_PLAYER_TAG +src/net/sf/freecol/common/model/Game.java:1193: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:1193: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:1194: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:1194: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:1195: Avoid excessively long variable names like SPANISH_SUCCESSION_TAG +src/net/sf/freecol/common/model/Game.java:1195: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:1195: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:1196: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:1196: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:1197: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:1197: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:1199: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Game.java:1199: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Game.java:1207: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Game.java:1207: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1230: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Game.java:1230: Found 'UR'-anomaly for variable 'cityName' (lines '1,230'-'1,239'). +src/net/sf/freecol/common/model/Game.java:1230: Found 'UR'-anomaly for variable 'p' (lines '1,230'-'1,249'). +src/net/sf/freecol/common/model/Game.java:1230: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1235: Local variable 'cityName' could be declared final +src/net/sf/freecol/common/model/Game.java:1246: Local variable 'players' could be declared final +src/net/sf/freecol/common/model/Game.java:1247: Local variable 'unknown' could be declared final +src/net/sf/freecol/common/model/Game.java:1248: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:1248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1249: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Game.java:1249: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/Game.java:1251: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:1258: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Game.java:1258: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1263: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:1266: Local variable 'str' could be declared final +src/net/sf/freecol/common/model/Game.java:1269: Avoid variables with short names like u +src/net/sf/freecol/common/model/Game.java:1269: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/Game.java:1272: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Game.java:1272: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Game.java:1285: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Game.java:1285: Found 'UR'-anomaly for variable 'player' (lines '1,285'-'1,300'). +src/net/sf/freecol/common/model/Game.java:1285: Found 'UR'-anomaly for variable 'unit' (lines '1,285'-'1,301'). +src/net/sf/freecol/common/model/Game.java:1285: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1289: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:1294: Local variable 'current' could be declared final +src/net/sf/freecol/common/model/Game.java:1299: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Game.java:1300: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Game.java:1300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1302: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Game.java:1308: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Game.java:1316: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Game.java:1316: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Game.java:1317: Found 'DU'-anomaly for variable 'game' (lines '1,317'-'1,352'). +src/net/sf/freecol/common/model/Game.java:1324: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Game.java:1325: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Game.java:1325: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/model/Game.java:1330: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1333: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1336: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1337: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Game.java:1344: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Game.java:1345: There is log block not surrounded by if +src/net/sf/freecol/common/model/Game.java:1345: There is log block not surrounded by if +src/net/sf/freecol/common/model/GameOptions.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GameOptions.java:28: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/model/GameOptions.java:39: Avoid excessively long variable names like SETTLEMENT_LIMIT_MODIFIER +src/net/sf/freecol/common/model/GameOptions.java:47: Avoid excessively long variable names like EXPLORATION_POINTS +src/net/sf/freecol/common/model/GameOptions.java:59: Avoid excessively long variable names like SETTLEMENT_ACTIONS_CONTACT_CHIEF +src/net/sf/freecol/common/model/GameOptions.java:63: Avoid excessively long variable names like ENHANCED_MISSIONARIES +src/net/sf/freecol/common/model/GameOptions.java:76: Avoid excessively long variable names like DEMAND_PROBABILITY +src/net/sf/freecol/common/model/GameOptions.java:80: Avoid excessively long variable names like CONTINUE_FOUNDING_FATHER_RECRUITMENT +src/net/sf/freecol/common/model/GameOptions.java:88: Avoid excessively long variable names like STARTING_POSITIONS +src/net/sf/freecol/common/model/GameOptions.java:90: Avoid excessively long variable names like STARTING_POSITIONS_CLASSIC +src/net/sf/freecol/common/model/GameOptions.java:90: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:91: Avoid excessively long variable names like STARTING_POSITIONS_RANDOM +src/net/sf/freecol/common/model/GameOptions.java:91: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:92: Avoid excessively long variable names like STARTING_POSITIONS_HISTORICAL +src/net/sf/freecol/common/model/GameOptions.java:92: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:99: Avoid excessively long variable names like INITIAL_IMMIGRATION +src/net/sf/freecol/common/model/GameOptions.java:103: Avoid excessively long variable names like EUROPEAN_UNIT_IMMIGRATION_PENALTY +src/net/sf/freecol/common/model/GameOptions.java:107: Avoid excessively long variable names like PLAYER_IMMIGRATION_BONUS +src/net/sf/freecol/common/model/GameOptions.java:111: Avoid excessively long variable names like EQUIP_EUROPEAN_RECRUITS +src/net/sf/freecol/common/model/GameOptions.java:116: Avoid excessively long variable names like GAMEOPTIONS_COLONY +src/net/sf/freecol/common/model/GameOptions.java:120: Avoid excessively long variable names like BELL_ACCUMULATION_CAPPED +src/net/sf/freecol/common/model/GameOptions.java:124: Avoid excessively long variable names like CAPTURE_UNITS_UNDER_REPAIR +src/net/sf/freecol/common/model/GameOptions.java:128: Avoid excessively long variable names like CUSTOM_IGNORE_BOYCOTT +src/net/sf/freecol/common/model/GameOptions.java:136: Avoid excessively long variable names like DISEMBARK_IN_COLONY +src/net/sf/freecol/common/model/GameOptions.java:143: Avoid excessively long variable names like EXPERTS_HAVE_CONNECTIONS +src/net/sf/freecol/common/model/GameOptions.java:147: Avoid excessively long variable names like FOUND_COLONY_DURING_REBELLION +src/net/sf/freecol/common/model/GameOptions.java:161: Avoid excessively long variable names like SAVE_PRODUCTION_OVERFLOW +src/net/sf/freecol/common/model/GameOptions.java:165: Avoid excessively long variable names like CLEAR_HAMMERS_ON_CONSTRUCTION_SWITCH +src/net/sf/freecol/common/model/GameOptions.java:173: Avoid excessively long variable names like ALLOW_STUDENT_SELECTION +src/net/sf/freecol/common/model/GameOptions.java:185: Avoid excessively long variable names like ONLY_NATURAL_IMPROVEMENTS +src/net/sf/freecol/common/model/GameOptions.java:198: Avoid excessively long variable names like GAMEOPTIONS_VICTORY_CONDITIONS +src/net/sf/freecol/common/model/GameOptions.java:205: Avoid excessively long variable names like VICTORY_DEFEAT_REF +src/net/sf/freecol/common/model/GameOptions.java:212: Avoid excessively long variable names like VICTORY_DEFEAT_EUROPEANS +src/net/sf/freecol/common/model/GameOptions.java:219: Avoid excessively long variable names like VICTORY_DEFEAT_HUMANS +src/net/sf/freecol/common/model/GameOptions.java:243: Avoid excessively long variable names like MANDATORY_COLONY_YEAR +src/net/sf/freecol/common/model/GameOptions.java:255: Avoid excessively long variable names like LAST_COLONIAL_YEAR +src/net/sf/freecol/common/model/GameOptions.java:258: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GameOptions.java:283: Avoid excessively long variable names like GAMEOPTIONS_PRICES +src/net/sf/freecol/common/model/GameOptions.java:290: Avoid excessively long variable names like DIFFICULTY_IMMIGRATION +src/net/sf/freecol/common/model/GameOptions.java:298: Avoid excessively long variable names like RECRUIT_PRICE_INCREASE +src/net/sf/freecol/common/model/GameOptions.java:302: Avoid excessively long variable names like LOWER_CAP_INCREASE +src/net/sf/freecol/common/model/GameOptions.java:310: Avoid excessively long variable names like PRICE_INCREASE_PER_TYPE +src/net/sf/freecol/common/model/GameOptions.java:314: Avoid excessively long variable names like EXPERT_STARTING_UNITS +src/net/sf/freecol/common/model/GameOptions.java:323: Avoid excessively long variable names like DIFFICULTY_NATIVES +src/net/sf/freecol/common/model/GameOptions.java:331: Avoid excessively long variable names like NATIVE_CONVERT_PROBABILITY +src/net/sf/freecol/common/model/GameOptions.java:347: Avoid excessively long variable names like SHIP_TRADE_PENALTY +src/net/sf/freecol/common/model/GameOptions.java:351: Avoid excessively long variable names like DESTROY_SETTLEMENT_SCORE +src/net/sf/freecol/common/model/GameOptions.java:355: Avoid excessively long variable names like BUILD_ON_NATIVE_LAND +src/net/sf/freecol/common/model/GameOptions.java:357: Avoid excessively long variable names like BUILD_ON_NATIVE_LAND_ALWAYS +src/net/sf/freecol/common/model/GameOptions.java:357: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:359: Avoid excessively long variable names like BUILD_ON_NATIVE_LAND_FIRST +src/net/sf/freecol/common/model/GameOptions.java:359: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:361: Avoid excessively long variable names like BUILD_ON_NATIVE_LAND_FIRST_AND_UNCONTACTED +src/net/sf/freecol/common/model/GameOptions.java:361: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:363: Avoid excessively long variable names like BUILD_ON_NATIVE_LAND_NEVER +src/net/sf/freecol/common/model/GameOptions.java:363: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:375: Avoid excessively long variable names like DIFFICULTY_MONARCH +src/net/sf/freecol/common/model/GameOptions.java:402: Avoid excessively long variable names like TREASURE_TRANSPORT_FEE +src/net/sf/freecol/common/model/GameOptions.java:406: Avoid excessively long variable names like INTERVENTION_BELLS +src/net/sf/freecol/common/model/GameOptions.java:410: Avoid excessively long variable names like INTERVENTION_TURNS +src/net/sf/freecol/common/model/GameOptions.java:418: Avoid excessively long variable names like INTERVENTION_FORCE +src/net/sf/freecol/common/model/GameOptions.java:434: Avoid excessively long variable names like DIFFICULTY_GOVERNMENT +src/net/sf/freecol/common/model/GameOptions.java:438: Avoid excessively long variable names like BAD_GOVERNMENT_LIMIT +src/net/sf/freecol/common/model/GameOptions.java:442: Avoid excessively long variable names like VERY_BAD_GOVERNMENT_LIMIT +src/net/sf/freecol/common/model/GameOptions.java:446: Avoid excessively long variable names like GOOD_GOVERNMENT_LIMIT +src/net/sf/freecol/common/model/GameOptions.java:450: Avoid excessively long variable names like VERY_GOOD_GOVERNMENT_LIMIT +src/net/sf/freecol/common/model/GameOptions.java:463: Avoid excessively long variable names like FOUNDING_FATHER_FACTOR +src/net/sf/freecol/common/model/GameOptions.java:471: Avoid excessively long variable names like UNITS_THAT_USE_NO_BELLS +src/net/sf/freecol/common/model/GameOptions.java:491: Avoid excessively long variable names like LIFT_BOYCOTT_CHEAT +src/net/sf/freecol/common/model/GameOptions.java:491: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:493: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:495: Avoid excessively long variable names like EQUIP_PIONEER_CHEAT +src/net/sf/freecol/common/model/GameOptions.java:495: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:497: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:499: Avoid excessively long variable names like OFFENSIVE_LAND_UNIT_CHEAT +src/net/sf/freecol/common/model/GameOptions.java:499: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:501: Avoid excessively long variable names like OFFENSIVE_NAVAL_UNIT_CHEAT +src/net/sf/freecol/common/model/GameOptions.java:501: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GameOptions.java:503: Avoid excessively long variable names like TRANSPORT_NAVAL_UNIT_CHEAT +src/net/sf/freecol/common/model/GameOptions.java:503: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoldTradeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoldTradeItem.java:46: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:46: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:46: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:47: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:60: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoldTradeItem.java:60: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:60: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:72: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoldTradeItem.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoldTradeItem.java:104: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:111: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:112: Local variable 'gold' could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:113: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/GoldTradeItem.java:113: Useless parentheses. +src/net/sf/freecol/common/model/GoldTradeItem.java:113: Useless parentheses. +src/net/sf/freecol/common/model/GoldTradeItem.java:125: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:127: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoldTradeItem.java:138: Local variable 'hash' could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:145: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoldTradeItem.java:145: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoldTradeItem.java:152: Avoid variables with short names like xw +src/net/sf/freecol/common/model/GoldTradeItem.java:152: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:162: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoldTradeItem.java:162: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:173: Avoid variables with short names like sb +src/net/sf/freecol/common/model/GoldTradeItem.java:173: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/GoldTradeItem.java:174: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoldTradeItem.java:174: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoldTradeItem.java:174: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Goods.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Goods.java:42: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/Goods.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Goods.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Goods.java:56: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Goods.java:71: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Goods.java:71: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:71: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:71: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:71: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:98: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Goods.java:98: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Goods.java:98: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:98: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:110: Avoid variables with short names like e +src/net/sf/freecol/common/model/Goods.java:110: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Goods.java:110: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:110: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:131: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Goods.java:132: Avoid variables with short names like gc +src/net/sf/freecol/common/model/Goods.java:132: Local variable 'gc' could be declared final +src/net/sf/freecol/common/model/Goods.java:134: Local variable 'maxAmount' could be declared final +src/net/sf/freecol/common/model/Goods.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Goods.java:135: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Goods.java:154: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:164: Useless parentheses. +src/net/sf/freecol/common/model/Goods.java:164: Useless parentheses. +src/net/sf/freecol/common/model/Goods.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Goods.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Goods.java:165: Useless parentheses. +src/net/sf/freecol/common/model/Goods.java:165: Useless parentheses. +src/net/sf/freecol/common/model/Goods.java:173: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Goods.java:192: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Goods.java:192: Useless parentheses. +src/net/sf/freecol/common/model/Goods.java:192: Useless parentheses. +src/net/sf/freecol/common/model/Goods.java:193: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Goods.java:200: Avoid variables with short names like p +src/net/sf/freecol/common/model/Goods.java:200: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:211: Avoid variables with short names like o +src/net/sf/freecol/common/model/Goods.java:211: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:213: Avoid variables with short names like g +src/net/sf/freecol/common/model/Goods.java:213: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/Goods.java:214: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Goods.java:224: Local variable 'hash' could be declared final +src/net/sf/freecol/common/model/Goods.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Goods.java:231: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Goods.java:231: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Goods.java:238: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Goods.java:238: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Goods.java:250: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Goods.java:250: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsContainer.java:20: Possible God class (WMC=64, ATFD=30, TCC=0.2850574712643678) +src/net/sf/freecol/common/model/GoodsContainer.java:44: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/GoodsContainer.java:47: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/GoodsContainer.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsContainer.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsContainer.java:66: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/GoodsContainer.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsContainer.java:76: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/GoodsContainer.java:79: Avoid using redundant field initializer for 'parent' +src/net/sf/freecol/common/model/GoodsContainer.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsContainer.java:89: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:89: Parameter 'parent' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:101: Avoid variables with short names like id +src/net/sf/freecol/common/model/GoodsContainer.java:101: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:101: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:105: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsContainer.java:115: Avoid variables with short names like e +src/net/sf/freecol/common/model/GoodsContainer.java:115: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:115: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:115: Parameter 'parent' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:129: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:143: Avoid variables with short names like g +src/net/sf/freecol/common/model/GoodsContainer.java:143: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:153: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:155: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:155: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:168: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:171: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:171: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:184: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:188: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsContainer.java:197: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:197: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:198: Local variable 'oldAmount' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:199: Local variable 'newAmount' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:223: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:233: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:245: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:245: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:246: Local variable 'oldAmount' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:247: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsContainer.java:247: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsContainer.java:249: Local variable 'newAmount' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:271: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:271: Parameter 'newAmount' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:310: Found 'UR'-anomaly for variable 'goodsType' (lines '310'-'317'). +src/net/sf/freecol/common/model/GoodsContainer.java:310: Parameter 'newAmount' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:316: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:332: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:334: Avoid variables with short names like gt +src/net/sf/freecol/common/model/GoodsContainer.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:362: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:372: Found 'UR'-anomaly for variable 'goodsType' (lines '372'-'376'). +src/net/sf/freecol/common/model/GoodsContainer.java:373: Local variable 'totalGoods' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:375: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:378: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/GoodsContainer.java:379: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:379: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:394: Found 'UR'-anomaly for variable 'entry' (lines '394'-'398'). +src/net/sf/freecol/common/model/GoodsContainer.java:395: Local variable 'totalGoods' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:397: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:399: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/GoodsContainer.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:441: Avoid variables with short names like gt +src/net/sf/freecol/common/model/GoodsContainer.java:450: Found 'UR'-anomaly for variable 'type' (lines '450'-'453'). +src/net/sf/freecol/common/model/GoodsContainer.java:451: Found 'DD'-anomaly for variable 'ret' (lines '451'-'457'). +src/net/sf/freecol/common/model/GoodsContainer.java:452: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:452: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:453: Local variable 'oldCount' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:454: Local variable 'newCount' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:456: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsContainer.java:457: Found 'DD'-anomaly for variable 'ret' (lines '457'-'457'). +src/net/sf/freecol/common/model/GoodsContainer.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:470: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:470: Useless parentheses. +src/net/sf/freecol/common/model/GoodsContainer.java:471: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/GoodsContainer.java:478: Avoid variables with short names like p +src/net/sf/freecol/common/model/GoodsContainer.java:478: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:496: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsContainer.java:496: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsContainer.java:497: Avoid excessively long variable names like OLD_STORED_GOODS_TAG +src/net/sf/freecol/common/model/GoodsContainer.java:497: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsContainer.java:497: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsContainer.java:498: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsContainer.java:498: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsContainer.java:499: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsContainer.java:499: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsContainer.java:506: Avoid variables with short names like xw +src/net/sf/freecol/common/model/GoodsContainer.java:506: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:517: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsContainer.java:526: Avoid variables with short names like xw +src/net/sf/freecol/common/model/GoodsContainer.java:526: Found 'UR'-anomaly for variable 'goodsType' (lines '526'-'536'). +src/net/sf/freecol/common/model/GoodsContainer.java:526: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:526: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:527: Parameter 'storage' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:528: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsContainer.java:532: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:550: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsContainer.java:550: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:561: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsContainer.java:561: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:583: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsContainer.java:583: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:584: Parameter 'storage' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:585: Found 'DU'-anomaly for variable 'spec' (lines '585'-'604'). +src/net/sf/freecol/common/model/GoodsContainer.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:588: Local variable 'tag' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsContainer.java:591: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:594: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:610: Found 'UR'-anomaly for variable 'entry' (lines '610'-'615'). +src/net/sf/freecol/common/model/GoodsContainer.java:611: Avoid variables with short names like sb +src/net/sf/freecol/common/model/GoodsContainer.java:611: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:612: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoodsContainer.java:614: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:615: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoodsContainer.java:620: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/GoodsContainer.java:621: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoodsLocation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsLocation.java:44: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/GoodsLocation.java:44: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/GoodsLocation.java:46: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/GoodsLocation.java:46: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/GoodsLocation.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsLocation.java:49: Avoid using redundant field initializer for 'goodsContainer' +src/net/sf/freecol/common/model/GoodsLocation.java:57: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:68: Avoid variables with short names like e +src/net/sf/freecol/common/model/GoodsLocation.java:68: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:78: Avoid variables with short names like id +src/net/sf/freecol/common/model/GoodsLocation.java:78: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:78: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:85: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/GoodsLocation.java:95: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:105: Found 'UR'-anomaly for variable 'ag' (lines '105'-'106'). +src/net/sf/freecol/common/model/GoodsLocation.java:105: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:106: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsLocation.java:106: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/GoodsLocation.java:106: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsLocation.java:106: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:117: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:127: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:137: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:149: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:150: Avoid variables with short names like ag +src/net/sf/freecol/common/model/GoodsLocation.java:160: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/GoodsLocation.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsLocation.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsLocation.java:205: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:206: Useless parentheses. +src/net/sf/freecol/common/model/GoodsLocation.java:206: Useless parentheses. +src/net/sf/freecol/common/model/GoodsLocation.java:215: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:216: Useless parentheses. +src/net/sf/freecol/common/model/GoodsLocation.java:216: Useless parentheses. +src/net/sf/freecol/common/model/GoodsLocation.java:225: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:226: Useless parentheses. +src/net/sf/freecol/common/model/GoodsLocation.java:226: Useless parentheses. +src/net/sf/freecol/common/model/GoodsLocation.java:253: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:255: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:256: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsLocation.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsLocation.java:258: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsLocation.java:259: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsLocation.java:282: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:282: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:297: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:297: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:298: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/GoodsLocation.java:310: Local variable 'objects' could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:314: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsLocation.java:326: Avoid variables with short names like xw +src/net/sf/freecol/common/model/GoodsLocation.java:326: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:329: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsLocation.java:336: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsLocation.java:336: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:338: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsLocation.java:347: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsLocation.java:347: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsLocation.java:350: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsTradeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsTradeItem.java:47: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:47: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:47: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:48: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:61: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsTradeItem.java:61: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:61: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:75: Useless parentheses. +src/net/sf/freecol/common/model/GoodsTradeItem.java:75: Useless parentheses. +src/net/sf/freecol/common/model/GoodsTradeItem.java:76: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsTradeItem.java:107: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:114: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:115: Found 'DU'-anomaly for variable 'market' (lines '115'-'133'). +src/net/sf/freecol/common/model/GoodsTradeItem.java:116: Found 'DU'-anomaly for variable 'goods' (lines '116'-'133'). +src/net/sf/freecol/common/model/GoodsTradeItem.java:118: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/GoodsTradeItem.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsTradeItem.java:121: Found 'DD'-anomaly for variable 'value' (lines '121'-'122'). +src/net/sf/freecol/common/model/GoodsTradeItem.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsTradeItem.java:122: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsTradeItem.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsTradeItem.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsTradeItem.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsTradeItem.java:127: Found 'DD'-anomaly for variable 'value' (lines '127'-'128'). +src/net/sf/freecol/common/model/GoodsTradeItem.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsTradeItem.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsTradeItem.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsTradeItem.java:141: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:143: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsTradeItem.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsTradeItem.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsTradeItem.java:154: Local variable 'hash' could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsTradeItem.java:165: Avoid variables with short names like xw +src/net/sf/freecol/common/model/GoodsTradeItem.java:165: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:175: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsTradeItem.java:175: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:177: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/GoodsTradeItem.java:186: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsTradeItem.java:186: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:187: Found 'DU'-anomaly for variable 'game' (lines '187'-'196'). +src/net/sf/freecol/common/model/GoodsTradeItem.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsTradeItem.java:203: Avoid variables with short names like sb +src/net/sf/freecol/common/model/GoodsTradeItem.java:203: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/GoodsTradeItem.java:204: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoodsTradeItem.java:205: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoodsTradeItem.java:205: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoodsTradeItem.java:206: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/GoodsType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsType.java:20: Possible God class (WMC=77, ATFD=52, TCC=0.06201550387596899) +src/net/sf/freecol/common/model/GoodsType.java:37: Too many fields +src/net/sf/freecol/common/model/GoodsType.java:39: Avoid excessively long variable names like DEFAULT_PRODUCTION_WEIGHT +src/net/sf/freecol/common/model/GoodsType.java:39: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:40: Avoid excessively long variable names like DEFAULT_LOW_PRODUCTION_THRESHOLD +src/net/sf/freecol/common/model/GoodsType.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:41: Avoid excessively long variable names like DEFAULT_ZERO_PRODUCTION_FACTOR +src/net/sf/freecol/common/model/GoodsType.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:44: Avoid excessively long variable names like goodsTypeComparator +src/net/sf/freecol/common/model/GoodsType.java:44: Variables that are final and static should be all capitals, 'goodsTypeComparator' is not all capitals. +src/net/sf/freecol/common/model/GoodsType.java:46: Avoid variables with short names like g +src/net/sf/freecol/common/model/GoodsType.java:46: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:47: Useless parentheses. +src/net/sf/freecol/common/model/GoodsType.java:47: Useless parentheses. +src/net/sf/freecol/common/model/GoodsType.java:58: Avoid variables with short names like g1 +src/net/sf/freecol/common/model/GoodsType.java:58: Avoid variables with short names like g2 +src/net/sf/freecol/common/model/GoodsType.java:58: Parameter 'g1' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:58: Parameter 'g2' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:58: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:59: Avoid variables with short names like r1 +src/net/sf/freecol/common/model/GoodsType.java:59: Local variable 'r1' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:60: Avoid variables with short names like r2 +src/net/sf/freecol/common/model/GoodsType.java:60: Local variable 'r2' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:61: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/GoodsType.java:62: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsType.java:67: Field isFarmed has the same name as a method +src/net/sf/freecol/common/model/GoodsType.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:82: Avoid using redundant field initializer for 'isMilitary' +src/net/sf/freecol/common/model/GoodsType.java:82: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:88: Avoid using redundant field initializer for 'buildingMaterial' +src/net/sf/freecol/common/model/GoodsType.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:91: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:94: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:97: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:100: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:103: Avoid using redundant field initializer for 'makes' +src/net/sf/freecol/common/model/GoodsType.java:103: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:106: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:109: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:112: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:130: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:136: Avoid excessively long variable names like lowProductionThreshold +src/net/sf/freecol/common/model/GoodsType.java:136: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:143: Avoid excessively long variable names like zeroProductionFactor +src/net/sf/freecol/common/model/GoodsType.java:143: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/GoodsType.java:152: Avoid variables with short names like id +src/net/sf/freecol/common/model/GoodsType.java:152: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:152: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:186: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:327: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsType.java:336: Use explicit scoping instead of the default package private level +src/net/sf/freecol/common/model/GoodsType.java:345: Use explicit scoping instead of the default package private level +src/net/sf/freecol/common/model/GoodsType.java:355: Use explicit scoping instead of the default package private level +src/net/sf/freecol/common/model/GoodsType.java:386: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:432: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/GoodsType.java:432: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/GoodsType.java:436: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsType.java:449: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:452: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsType.java:466: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsType.java:466: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsType.java:470: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/GoodsType.java:470: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsType.java:470: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsType.java:483: Found 'UR'-anomaly for variable 'type' (lines '483'-'486'). +src/net/sf/freecol/common/model/GoodsType.java:484: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:485: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:485: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsType.java:486: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsType.java:492: Comment is too large: Too many lines +src/net/sf/freecol/common/model/GoodsType.java:510: Found 'UR'-anomaly for variable 'ag' (lines '510'-'524'). +src/net/sf/freecol/common/model/GoodsType.java:510: Found 'UR'-anomaly for variable 'b' (lines '510'-'523'). +src/net/sf/freecol/common/model/GoodsType.java:510: Found 'UR'-anomaly for variable 'g' (lines '510'-'513'). +src/net/sf/freecol/common/model/GoodsType.java:510: Found 'UR'-anomaly for variable 'g' (lines '510'-'530'). +src/net/sf/freecol/common/model/GoodsType.java:510: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:512: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:514: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/GoodsType.java:518: Local variable 'buildableTypes' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:519: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsType.java:520: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsType.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsType.java:522: Local variable 'b' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:523: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:523: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsType.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/GoodsType.java:524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/GoodsType.java:529: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/GoodsType.java:530: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/GoodsType.java:537: Avoid excessively long variable names like BREEDING_NUMBER_TAG +src/net/sf/freecol/common/model/GoodsType.java:537: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:537: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:538: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:538: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:539: Avoid excessively long variable names like INITIAL_AMOUNT_TAG +src/net/sf/freecol/common/model/GoodsType.java:539: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:539: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:540: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:540: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:541: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:541: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:542: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:542: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:543: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:543: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:544: Avoid excessively long variable names like LOW_PRODUCTION_THRESHOLD_TAG +src/net/sf/freecol/common/model/GoodsType.java:544: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:544: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:545: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:545: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:546: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:546: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:547: Avoid excessively long variable names like NEW_WORLD_GOODS_TAG +src/net/sf/freecol/common/model/GoodsType.java:547: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:547: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:548: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:548: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:549: Avoid excessively long variable names like PRICE_DIFFERENCE_TAG +src/net/sf/freecol/common/model/GoodsType.java:549: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:549: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:550: Avoid excessively long variable names like PRODUCTION_WEIGHT_TAG +src/net/sf/freecol/common/model/GoodsType.java:550: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:550: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:551: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:551: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:552: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:552: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:553: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:553: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:554: Avoid excessively long variable names like ZERO_PRODUCTION_FACTOR_TAG +src/net/sf/freecol/common/model/GoodsType.java:554: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/GoodsType.java:554: fieldCommentRequirement Required +src/net/sf/freecol/common/model/GoodsType.java:561: Avoid variables with short names like xw +src/net/sf/freecol/common/model/GoodsType.java:561: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:611: Avoid variables with short names like xw +src/net/sf/freecol/common/model/GoodsType.java:611: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:631: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsType.java:631: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/GoodsType.java:680: Avoid variables with short names like xr +src/net/sf/freecol/common/model/GoodsType.java:680: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/HighScore.java:20: Possible God class (WMC=55, ATFD=44, TCC=0.10666666666666667) +src/net/sf/freecol/common/model/HighScore.java:50: The class 'HighScore' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/model/HighScore.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/HighScore.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:55: Avoid excessively long variable names like NUMBER_OF_HIGH_SCORES +src/net/sf/freecol/common/model/HighScore.java:83: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:86: Parameter 'minimumScore' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:90: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:96: Variables that are final and static should be all capitals, 'dateFormat' is not all capitals. +src/net/sf/freecol/common/model/HighScore.java:97: When instantiating a SimpleDateFormat object, specify a Locale +src/net/sf/freecol/common/model/HighScore.java:100: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:103: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:106: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:109: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:112: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:115: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:121: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:124: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:130: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:133: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:136: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HighScore.java:145: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/HighScore.java:145: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:145: Parameter 'theDate' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:146: Local variable 'game' could be declared final +src/net/sf/freecol/common/model/HighScore.java:150: Local variable 'someLevel' could be declared final +src/net/sf/freecol/common/model/HighScore.java:177: Avoid variables with short names like xr +src/net/sf/freecol/common/model/HighScore.java:177: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/HighScore.java:177: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:186: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/HighScore.java:186: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:321: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:321: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:329: Avoid reassigning parameters such as 'scores' +src/net/sf/freecol/common/model/HighScore.java:343: Parameter 'score' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:343: Parameter 'scores' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/HighScore.java:357: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:358: Local variable 'scores' could be declared final +src/net/sf/freecol/common/model/HighScore.java:359: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HighScore.java:359: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HighScore.java:360: Avoid variables with short names like hs +src/net/sf/freecol/common/model/HighScore.java:360: Local variable 'hs' could be declared final +src/net/sf/freecol/common/model/HighScore.java:361: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:371: Found 'UR'-anomaly for variable 'hsf' (lines '371'-'371'). +src/net/sf/freecol/common/model/HighScore.java:373: Local variable 'hsf' could be declared final +src/net/sf/freecol/common/model/HighScore.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:376: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:378: There is log block not surrounded by if +src/net/sf/freecol/common/model/HighScore.java:378: There is log block not surrounded by if +src/net/sf/freecol/common/model/HighScore.java:380: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/HighScore.java:381: There is log block not surrounded by if +src/net/sf/freecol/common/model/HighScore.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:384: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HighScore.java:389: Avoid variables with short names like xr +src/net/sf/freecol/common/model/HighScore.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:395: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/HighScore.java:396: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/HighScore.java:399: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/HighScore.java:412: Found 'UR'-anomaly for variable 'hsf' (lines '412'-'412'). +src/net/sf/freecol/common/model/HighScore.java:412: Found 'UR'-anomaly for variable 'score' (lines '412'-'428'). +src/net/sf/freecol/common/model/HighScore.java:412: Parameter 'scores' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:413: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/HighScore.java:413: Found 'DD'-anomaly for variable 'ret' (lines '413'-'423'). +src/net/sf/freecol/common/model/HighScore.java:413: Found 'DU'-anomaly for variable 'ret' (lines '413'-'445'). +src/net/sf/freecol/common/model/HighScore.java:414: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HighScore.java:414: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HighScore.java:417: Found 'DU'-anomaly for variable 'hsf' (lines '417'-'445'). +src/net/sf/freecol/common/model/HighScore.java:417: Local variable 'hsf' could be declared final +src/net/sf/freecol/common/model/HighScore.java:420: Avoid variables with short names like xw +src/net/sf/freecol/common/model/HighScore.java:421: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/HighScore.java:423: Found 'DD'-anomaly for variable 'ret' (lines '423'-'436'). +src/net/sf/freecol/common/model/HighScore.java:424: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:426: Avoid unused local variables such as 'count'. +src/net/sf/freecol/common/model/HighScore.java:426: Found 'DD'-anomaly for variable 'count' (lines '426'-'429'). +src/net/sf/freecol/common/model/HighScore.java:426: Found 'DU'-anomaly for variable 'count' (lines '426'-'445'). +src/net/sf/freecol/common/model/HighScore.java:427: Local variable 'score' could be declared final +src/net/sf/freecol/common/model/HighScore.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:429: Found 'DD'-anomaly for variable 'count' (lines '429'-'429'). +src/net/sf/freecol/common/model/HighScore.java:429: Found 'DU'-anomaly for variable 'count' (lines '429'-'445'). +src/net/sf/freecol/common/model/HighScore.java:431: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:432: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:436: Found 'DD'-anomaly for variable 'ret' (lines '436'-'439'). +src/net/sf/freecol/common/model/HighScore.java:439: Found 'DD'-anomaly for variable 'ret' (lines '439'-'442'). +src/net/sf/freecol/common/model/HighScore.java:454: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:455: Found 'DD'-anomaly for variable 'cmp' (lines '455'-'458'). +src/net/sf/freecol/common/model/HighScore.java:457: Avoid variables with short names like hs +src/net/sf/freecol/common/model/HighScore.java:457: Local variable 'hs' could be declared final +src/net/sf/freecol/common/model/HighScore.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/HighScore.java:460: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HighScore.java:470: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:470: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:471: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:471: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:472: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:472: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:473: Avoid excessively long variable names like INDEPENDENCE_TURN_TAG +src/net/sf/freecol/common/model/HighScore.java:473: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:473: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:474: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:474: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:475: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:475: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:476: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:476: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:477: Avoid excessively long variable names like NATION_TYPE_ID_TAG +src/net/sf/freecol/common/model/HighScore.java:477: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:477: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:478: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:478: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:479: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:479: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:480: Avoid excessively long variable names like RETIREMENT_TURN_TAG +src/net/sf/freecol/common/model/HighScore.java:480: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:480: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:481: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:481: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:482: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:482: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:484: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:484: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:485: Avoid excessively long variable names like OLD_NATION_TYPE_ID_TAG +src/net/sf/freecol/common/model/HighScore.java:485: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighScore.java:485: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighScore.java:493: Avoid variables with short names like xw +src/net/sf/freecol/common/model/HighScore.java:493: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:496: Avoid variables with short names like l +src/net/sf/freecol/common/model/HighScore.java:496: Local variable 'l' could be declared final +src/net/sf/freecol/common/model/HighScore.java:532: Avoid variables with short names like xr +src/net/sf/freecol/common/model/HighScore.java:532: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighScore.java:532: The method 'readAttributes' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/HighScore.java:535: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/HighScore.java:537: Avoid variables with short names like l +src/net/sf/freecol/common/model/HighScore.java:537: Local variable 'l' could be declared final +src/net/sf/freecol/common/model/HighScore.java:538: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HighScore.java:539: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/HighScore.java:545: Avoid variables with short names like f +src/net/sf/freecol/common/model/HighScore.java:545: Local variable 'f' could be declared final +src/net/sf/freecol/common/model/HighScore.java:549: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/HighScore.java:556: Local variable 'str' could be declared final +src/net/sf/freecol/common/model/HighScore.java:558: Static DateFormatter objects should be accessed in a synchronized manner +src/net/sf/freecol/common/model/HighScore.java:559: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/HighScore.java:560: There is log block not surrounded by if +src/net/sf/freecol/common/model/HighScore.java:564: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HighSeas.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/HighSeas.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/HighSeas.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighSeas.java:48: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:58: Avoid variables with short names like id +src/net/sf/freecol/common/model/HighSeas.java:58: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:58: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:77: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:78: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/HighSeas.java:79: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/HighSeas.java:82: There is log block not surrounded by if +src/net/sf/freecol/common/model/HighSeas.java:86: There is log block not surrounded by if +src/net/sf/freecol/common/model/HighSeas.java:95: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:106: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:136: Avoid using short method names +src/net/sf/freecol/common/model/HighSeas.java:167: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/HighSeas.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/HighSeas.java:168: Useless parentheses. +src/net/sf/freecol/common/model/HighSeas.java:168: Useless parentheses. +src/net/sf/freecol/common/model/HighSeas.java:176: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HighSeas.java:176: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HighSeas.java:183: Avoid variables with short names like xw +src/net/sf/freecol/common/model/HighSeas.java:183: Found 'UR'-anomaly for variable 'destination' (lines '183'-'187'). +src/net/sf/freecol/common/model/HighSeas.java:183: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:186: Local variable 'destination' could be declared final +src/net/sf/freecol/common/model/HighSeas.java:187: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HighSeas.java:201: Avoid variables with short names like xr +src/net/sf/freecol/common/model/HighSeas.java:201: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:212: Avoid variables with short names like xr +src/net/sf/freecol/common/model/HighSeas.java:212: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/HighSeas.java:213: Found 'DU'-anomaly for variable 'game' (lines '213'-'225'). +src/net/sf/freecol/common/model/HistoryEvent.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/HistoryEvent.java:27: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/HistoryEvent.java:39: enumCommentRequirement Required +src/net/sf/freecol/common/model/HistoryEvent.java:71: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/HistoryEvent.java:87: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HistoryEvent.java:90: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/HistoryEvent.java:107: Parameter 'eventType' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:107: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:107: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:111: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/HistoryEvent.java:121: Avoid variables with short names like xr +src/net/sf/freecol/common/model/HistoryEvent.java:121: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/HistoryEvent.java:121: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:130: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/HistoryEvent.java:130: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:159: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:162: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HistoryEvent.java:164: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HistoryEvent.java:166: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HistoryEvent.java:168: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HistoryEvent.java:189: Parameter 'playerId' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:207: Parameter 'score' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:218: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:218: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:226: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:226: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:234: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:234: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:242: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:242: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:250: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:250: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:261: Avoid variables with short names like o +src/net/sf/freecol/common/model/HistoryEvent.java:261: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:262: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HistoryEvent.java:262: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HistoryEvent.java:264: Avoid variables with short names like h +src/net/sf/freecol/common/model/HistoryEvent.java:264: Local variable 'h' could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:265: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/HistoryEvent.java:275: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HistoryEvent.java:275: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HistoryEvent.java:276: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HistoryEvent.java:276: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HistoryEvent.java:277: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HistoryEvent.java:277: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HistoryEvent.java:278: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/HistoryEvent.java:278: fieldCommentRequirement Required +src/net/sf/freecol/common/model/HistoryEvent.java:285: Avoid variables with short names like xw +src/net/sf/freecol/common/model/HistoryEvent.java:285: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:292: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/HistoryEvent.java:301: Avoid variables with short names like xr +src/net/sf/freecol/common/model/HistoryEvent.java:301: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:319: Avoid variables with short names like sb +src/net/sf/freecol/common/model/HistoryEvent.java:319: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/HistoryEvent.java:320: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/HistoryEvent.java:321: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/HistoryEvent.java:322: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/HistoryEvent.java:327: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/HistoryEvent.java:327: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/InciteTradeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/InciteTradeItem.java:27: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/InciteTradeItem.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/InciteTradeItem.java:48: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:48: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:48: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:49: Parameter 'victim' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:63: Avoid variables with short names like xr +src/net/sf/freecol/common/model/InciteTradeItem.java:63: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:63: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:92: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/InciteTradeItem.java:107: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:111: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/InciteTradeItem.java:113: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/InciteTradeItem.java:117: Local variable 'ratio' could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:119: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:130: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:132: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/InciteTradeItem.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/InciteTradeItem.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/InciteTradeItem.java:143: Local variable 'hash' could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/InciteTradeItem.java:150: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/InciteTradeItem.java:150: fieldCommentRequirement Required +src/net/sf/freecol/common/model/InciteTradeItem.java:157: Avoid variables with short names like xw +src/net/sf/freecol/common/model/InciteTradeItem.java:157: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:167: Avoid variables with short names like xr +src/net/sf/freecol/common/model/InciteTradeItem.java:167: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:179: Avoid variables with short names like sb +src/net/sf/freecol/common/model/InciteTradeItem.java:179: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/InciteTradeItem.java:180: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/InciteTradeItem.java:181: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/InciteTradeItem.java:181: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/IndianNationType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianNationType.java:42: Avoid using redundant field initializer for 'skills' +src/net/sf/freecol/common/model/IndianNationType.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/IndianNationType.java:45: Avoid using redundant field initializer for 'regions' +src/net/sf/freecol/common/model/IndianNationType.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/IndianNationType.java:54: Avoid variables with short names like id +src/net/sf/freecol/common/model/IndianNationType.java:54: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:54: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:95: Parameter 'plural' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianNationType.java:96: Useless parentheses. +src/net/sf/freecol/common/model/IndianNationType.java:96: Useless parentheses. +src/net/sf/freecol/common/model/IndianNationType.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianNationType.java:114: Avoid variables with short names like id +src/net/sf/freecol/common/model/IndianNationType.java:114: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:115: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianNationType.java:125: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianNationType.java:140: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianNationType.java:161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianNationType.java:171: Parameter 'probability' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:171: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:172: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianNationType.java:183: Found 'UR'-anomaly for variable 'entry' (lines '183'-'193'). +src/net/sf/freecol/common/model/IndianNationType.java:183: Found 'UR'-anomaly for variable 'skill' (lines '183'-'188'). +src/net/sf/freecol/common/model/IndianNationType.java:183: Found 'UR'-anomaly for variable 'skill' (lines '183'-'201'). +src/net/sf/freecol/common/model/IndianNationType.java:183: Found 'UR'-anomaly for variable 't' (lines '183'-'194'). +src/net/sf/freecol/common/model/IndianNationType.java:183: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:184: Local variable 'skills' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:185: Found 'DU'-anomaly for variable 'scale' (lines '185'-'208'). +src/net/sf/freecol/common/model/IndianNationType.java:185: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/IndianNationType.java:185: Local variable 'scale' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:187: Local variable 'skill' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianNationType.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianNationType.java:191: Local variable 't' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:192: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:193: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:199: Local variable 'scaledSkills' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:200: Local variable 'skill' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:201: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:202: Local variable 'scaleValue' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianNationType.java:203: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/IndianNationType.java:213: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianNationType.java:213: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianNationType.java:214: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianNationType.java:214: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianNationType.java:221: Avoid variables with short names like xw +src/net/sf/freecol/common/model/IndianNationType.java:221: Found 'UR'-anomaly for variable 'choice' (lines '221'-'227'). +src/net/sf/freecol/common/model/IndianNationType.java:221: Found 'UR'-anomaly for variable 'region' (lines '221'-'237'). +src/net/sf/freecol/common/model/IndianNationType.java:221: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:224: Local variable 'choice' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:234: Local variable 'region' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:247: Avoid variables with short names like xr +src/net/sf/freecol/common/model/IndianNationType.java:247: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:250: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/IndianNationType.java:251: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/IndianNationType.java:255: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:258: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/IndianNationType.java:259: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianNationType.java:259: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/model/IndianNationType.java:263: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/IndianNationType.java:264: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianNationType.java:264: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/model/IndianNationType.java:276: Avoid variables with short names like xr +src/net/sf/freecol/common/model/IndianNationType.java:276: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianNationType.java:277: Found 'DU'-anomaly for variable 'spec' (lines '277'-'293'). +src/net/sf/freecol/common/model/IndianNationType.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:20: Possible God class (WMC=214, ATFD=130, TCC=0.023157894736842106) +src/net/sf/freecol/common/model/IndianSettlement.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/model/IndianSettlement.java:45: Avoid really long classes. +src/net/sf/freecol/common/model/IndianSettlement.java:45: The class 'IndianSettlement' has a Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/common/model/IndianSettlement.java:45: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/IndianSettlement.java:47: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/IndianSettlement.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:59: Avoid excessively long variable names like exportGoodsComparator +src/net/sf/freecol/common/model/IndianSettlement.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/IndianSettlement.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:62: Parameter 'goods1' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:62: Parameter 'goods2' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:62: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:64: Avoid variables with short names like t1 +src/net/sf/freecol/common/model/IndianSettlement.java:64: Local variable 't1' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:65: Avoid variables with short names like t2 +src/net/sf/freecol/common/model/IndianSettlement.java:65: Local variable 't2' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:66: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:66: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:66: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:66: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:66: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:66: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:67: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:67: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:67: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:67: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:69: Avoid variables with short names like a1 +src/net/sf/freecol/common/model/IndianSettlement.java:69: Local variable 'a1' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:71: Avoid variables with short names like a2 +src/net/sf/freecol/common/model/IndianSettlement.java:71: Local variable 'a2' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:83: Avoid excessively long variable names like NATIVE_PRODUCTION_EFFICIENCY +src/net/sf/freecol/common/model/IndianSettlement.java:86: Avoid excessively long variable names like WANTED_GOODS_COUNT +src/net/sf/freecol/common/model/IndianSettlement.java:92: Avoid excessively long variable names like TRADE_MINIMUM_SIZE +src/net/sf/freecol/common/model/IndianSettlement.java:95: Avoid excessively long variable names like TRADE_MINIMUM_PRICE +src/net/sf/freecol/common/model/IndianSettlement.java:97: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:127: Avoid using redundant field initializer for 'learnableSkill' +src/net/sf/freecol/common/model/IndianSettlement.java:138: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/IndianSettlement.java:144: Avoid using redundant field initializer for 'missionary' +src/net/sf/freecol/common/model/IndianSettlement.java:147: Avoid using redundant field initializer for 'convertProgress' +src/net/sf/freecol/common/model/IndianSettlement.java:150: Avoid using redundant field initializer for 'lastTribute' +src/net/sf/freecol/common/model/IndianSettlement.java:153: Avoid using redundant field initializer for 'mostHated' +src/net/sf/freecol/common/model/IndianSettlement.java:174: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:174: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:174: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:175: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:187: Avoid variables with short names like id +src/net/sf/freecol/common/model/IndianSettlement.java:187: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:187: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:198: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:227: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:237: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:258: Parameter 'lastTribute' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:276: Parameter 'skill' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:287: Parameter 'visited' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:288: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:288: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:319: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:323: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:332: Parameter 'missionary' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:342: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:344: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:344: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:361: Parameter 'progress' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:371: Returning 'wantedGoods' may expose an internal array. +src/net/sf/freecol/common/model/IndianSettlement.java:379: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/model/IndianSettlement.java:379: Parameter 'wantedGoods' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:379: The user-supplied array 'wantedGoods' is stored directly. +src/net/sf/freecol/common/model/IndianSettlement.java:389: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:389: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:401: Found 'UR'-anomaly for variable 'gt' (lines '401'-'403'). +src/net/sf/freecol/common/model/IndianSettlement.java:402: Avoid variables with short names like n +src/net/sf/freecol/common/model/IndianSettlement.java:402: Found 'DD'-anomaly for variable 'n' (lines '402'-'403'). +src/net/sf/freecol/common/model/IndianSettlement.java:403: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:403: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:403: Found 'DD'-anomaly for variable 'n' (lines '403'-'403'). +src/net/sf/freecol/common/model/IndianSettlement.java:403: Local variable 'gt' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:414: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:414: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:420: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:420: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:421: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:422: Local variable 'sale' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:422: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:423: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:447: Parameter 'mostHated' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:459: Parameter 'contacted' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:460: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:460: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:473: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:474: Avoid variables with short names like cl +src/net/sf/freecol/common/model/IndianSettlement.java:474: Local variable 'cl' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:478: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:488: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:492: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:503: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:504: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:505: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/IndianSettlement.java:516: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:518: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:520: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:532: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:544: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:546: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:548: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:559: Avoid variables with short names like p +src/net/sf/freecol/common/model/IndianSettlement.java:570: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:571: Avoid variables with short names like cl +src/net/sf/freecol/common/model/IndianSettlement.java:571: Local variable 'cl' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:574: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:576: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:576: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:591: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:603: Parameter 'newAlarm' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:603: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:613: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:614: Local variable 'tension' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:615: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:625: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:626: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/IndianSettlement.java:626: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:626: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:628: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/IndianSettlement.java:630: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:633: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:643: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:644: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:649: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:660: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:664: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:680: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:680: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:686: Found 'DD'-anomaly for variable 'price' (lines '686'-'689'). +src/net/sf/freecol/common/model/IndianSettlement.java:692: Found 'DD'-anomaly for variable 'price' (lines '692'-'703'). +src/net/sf/freecol/common/model/IndianSettlement.java:696: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/IndianSettlement.java:705: There is log block not surrounded by if +src/net/sf/freecol/common/model/IndianSettlement.java:717: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:717: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:717: The method 'getNormalGoodsPriceToBuy' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/IndianSettlement.java:717: The method getNormalGoodsPriceToBuy() has an NPath complexity of 1125 +src/net/sf/freecol/common/model/IndianSettlement.java:718: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/IndianSettlement.java:718: Found 'DU'-anomaly for variable 'tradeGoodsAdd' (lines '718'-'755'). +src/net/sf/freecol/common/model/IndianSettlement.java:723: Local variable 'rawType' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:724: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/IndianSettlement.java:725: Local variable 'rawProduction' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:726: Found 'DD'-anomaly for variable 'add' (lines '726'-'731'). +src/net/sf/freecol/common/model/IndianSettlement.java:726: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:726: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:740: Local variable 'retain' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:741: Local variable 'valued' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:741: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:741: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:746: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:746: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:751: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:754: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:754: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:764: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:765: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:765: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:768: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:769: Found 'DU'-anomaly for variable 'militaryRoles' (lines '769'-'791'). +src/net/sf/freecol/common/model/IndianSettlement.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:773: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:774: Avoid variables with short names like u +src/net/sf/freecol/common/model/IndianSettlement.java:774: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:774: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:775: Avoid variables with short names like u +src/net/sf/freecol/common/model/IndianSettlement.java:776: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:779: Found 'DU'-anomaly for variable 'consumption' (lines '779'-'791'). +src/net/sf/freecol/common/model/IndianSettlement.java:779: Local variable 'consumption' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:780: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:782: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:787: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:800: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:800: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:801: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/IndianSettlement.java:801: Found 'DU'-anomaly for variable 'full' (lines '801'-'816'). +src/net/sf/freecol/common/model/IndianSettlement.java:801: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:802: Local variable 'required' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:803: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:803: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:809: Local variable 'valued' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:810: Local variable 'price' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:810: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:810: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:812: There is log block not surrounded by if +src/net/sf/freecol/common/model/IndianSettlement.java:818: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:829: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:833: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:845: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:845: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:850: Found 'DU'-anomaly for variable 'full' (lines '850'-'862'). +src/net/sf/freecol/common/model/IndianSettlement.java:850: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:855: Found 'DD'-anomaly for variable 'price' (lines '855'-'857'). +src/net/sf/freecol/common/model/IndianSettlement.java:855: Found 'DD'-anomaly for variable 'price' (lines '855'-'859'). +src/net/sf/freecol/common/model/IndianSettlement.java:871: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:882: Found 'UR'-anomaly for variable 'goods' (lines '882'-'889'). +src/net/sf/freecol/common/model/IndianSettlement.java:882: Parameter 'limit' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:882: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:883: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:884: Local variable 'settlementGoods' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:887: Found 'DD'-anomaly for variable 'count' (lines '887'-'904'). +src/net/sf/freecol/common/model/IndianSettlement.java:888: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:889: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:889: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:890: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:891: Local variable 'retain' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:892: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:895: Found 'DD'-anomaly for variable 'amount' (lines '895'-'898'). +src/net/sf/freecol/common/model/IndianSettlement.java:898: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:898: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:899: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:902: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:903: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/IndianSettlement.java:903: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:905: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:918: Found 'UR'-anomaly for variable 'goods' (lines '918'-'926'). +src/net/sf/freecol/common/model/IndianSettlement.java:918: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:919: Local variable 'armsType' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:919: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:920: Local variable 'horsesType' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:920: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:921: Local variable 'goodsToTrade' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:925: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:926: Local variable 'goodsInStock' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:927: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/IndianSettlement.java:930: Local variable 'goodsTraded' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:943: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:945: Avoid variables with short names like t +src/net/sf/freecol/common/model/IndianSettlement.java:948: Avoid variables with short names like t +src/net/sf/freecol/common/model/IndianSettlement.java:959: Found 'UR'-anomaly for variable 'e' (lines '959'-'970'). +src/net/sf/freecol/common/model/IndianSettlement.java:959: Found 'UR'-anomaly for variable 'gt' (lines '959'-'964'). +src/net/sf/freecol/common/model/IndianSettlement.java:962: Local variable 'gt' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:962: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:964: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:964: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:964: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:965: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:968: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:970: Found 'DU'-anomaly for variable 'goodsType' (lines '970'-'979'). +src/net/sf/freecol/common/model/IndianSettlement.java:970: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:970: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:971: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:971: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:977: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/IndianSettlement.java:981: Comment is too large: Too many lines +src/net/sf/freecol/common/model/IndianSettlement.java:990: Found 'UR'-anomaly for variable 'g' (lines '990'-'995'). +src/net/sf/freecol/common/model/IndianSettlement.java:991: Found 'DD'-anomaly for variable 'wantGoods' (lines '991'-'1,002'). +src/net/sf/freecol/common/model/IndianSettlement.java:992: Found 'DD'-anomaly for variable 'diff' (lines '992'-'995'). +src/net/sf/freecol/common/model/IndianSettlement.java:992: Found 'DU'-anomaly for variable 'diff' (lines '992'-'1,007'). +src/net/sf/freecol/common/model/IndianSettlement.java:992: Found 'DU'-anomaly for variable 'wantAmount' (lines '992'-'1,007'). +src/net/sf/freecol/common/model/IndianSettlement.java:992: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/IndianSettlement.java:993: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:993: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:995: Avoid assignments in operands +src/net/sf/freecol/common/model/IndianSettlement.java:995: Found 'DD'-anomaly for variable 'diff' (lines '995'-'995'). +src/net/sf/freecol/common/model/IndianSettlement.java:995: Found 'DU'-anomaly for variable 'diff' (lines '995'-'1,007'). +src/net/sf/freecol/common/model/IndianSettlement.java:995: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:996: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:997: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:998: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1002: Found 'DD'-anomaly for variable 'wantGoods' (lines '1,002'-'1,002'). +src/net/sf/freecol/common/model/IndianSettlement.java:1003: Found 'DU'-anomaly for variable 'wantAmount' (lines '1,003'-'1,007'). +src/net/sf/freecol/common/model/IndianSettlement.java:1015: Found 'UR'-anomaly for variable 'type' (lines '1,015'-'1,018'). +src/net/sf/freecol/common/model/IndianSettlement.java:1015: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1016: Local variable 'goodsList' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1017: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1017: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1018: Avoid variables with short names like n +src/net/sf/freecol/common/model/IndianSettlement.java:1021: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/IndianSettlement.java:1021: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1028: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/IndianSettlement.java:1028: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:1028: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:1039: Found 'UR'-anomaly for variable 'ag' (lines '1,039'-'1,043'). +src/net/sf/freecol/common/model/IndianSettlement.java:1039: Found 'UR'-anomaly for variable 'e' (lines '1,039'-'1,052'). +src/net/sf/freecol/common/model/IndianSettlement.java:1039: Found 'UR'-anomaly for variable 't' (lines '1,039'-'1,042'). +src/net/sf/freecol/common/model/IndianSettlement.java:1039: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1040: Local variable 'goodsMap' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1041: Local variable 't' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1042: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1042: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1043: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1043: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1043: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1044: Avoid variables with short names like i +src/net/sf/freecol/common/model/IndianSettlement.java:1044: Local variable 'i' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1044: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1045: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1046: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1046: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1049: Avoid variables with short names like d +src/net/sf/freecol/common/model/IndianSettlement.java:1049: Found 'DU'-anomaly for variable 'd' (lines '1,049'-'1,057'). +src/net/sf/freecol/common/model/IndianSettlement.java:1049: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1051: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1051: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1052: Avoid variables with short names like i +src/net/sf/freecol/common/model/IndianSettlement.java:1052: Found 'DD'-anomaly for variable 'i' (lines '1,052'-'1,053'). +src/net/sf/freecol/common/model/IndianSettlement.java:1052: Found 'DD'-anomaly for variable 'i' (lines '1,052'-'1,054'). +src/net/sf/freecol/common/model/IndianSettlement.java:1052: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1053: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:1053: Found 'DD'-anomaly for variable 'i' (lines '1,053'-'1,054'). +src/net/sf/freecol/common/model/IndianSettlement.java:1053: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1053: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1053: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1055: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:1055: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1066: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1079: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1102: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1103: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:1103: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:1111: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1112: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1114: Local variable 'indian' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1127: Avoid using short method names +src/net/sf/freecol/common/model/IndianSettlement.java:1159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1171: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:1171: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/model/IndianSettlement.java:1179: Found 'UR'-anomaly for variable 'nextUnit' (lines '1,179'-'1,183'). +src/net/sf/freecol/common/model/IndianSettlement.java:1179: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1181: Found 'DU'-anomaly for variable 'defencePower' (lines '1,181'-'1,192'). +src/net/sf/freecol/common/model/IndianSettlement.java:1182: Local variable 'nextUnit' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1183: Local variable 'unitPower' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1188: Found 'DU'-anomaly for variable 'defencePower' (lines '1,188'-'1,192'). +src/net/sf/freecol/common/model/IndianSettlement.java:1199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1215: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1241: Found 'UR'-anomaly for variable 'workTile' (lines '1,241'-'1,252'). +src/net/sf/freecol/common/model/IndianSettlement.java:1241: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:1243: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:1246: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:1249: Found 'DD'-anomaly for variable 'tiles' (lines '1,249'-'1,255'). +src/net/sf/freecol/common/model/IndianSettlement.java:1250: Found 'DD'-anomaly for variable 'potential' (lines '1,250'-'1,269'). +src/net/sf/freecol/common/model/IndianSettlement.java:1251: Local variable 'workTile' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1255: Found 'DD'-anomaly for variable 'tiles' (lines '1,255'-'1,255'). +src/net/sf/freecol/common/model/IndianSettlement.java:1274: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1281: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1290: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1291: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/IndianSettlement.java:1291: Local variable 'key' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1291: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:1291: Useless parentheses. +src/net/sf/freecol/common/model/IndianSettlement.java:1293: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/IndianSettlement.java:1295: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1296: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1296: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1297: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1308: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1308: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1309: Local variable 'present' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1311: Local variable 'wanted' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1319: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1319: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1320: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/IndianSettlement.java:1320: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:1322: Local variable 'present' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1324: Local variable 'capacity' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1335: Overriding method merely calls super +src/net/sf/freecol/common/model/IndianSettlement.java:1335: Overriding method merely calls super +src/net/sf/freecol/common/model/IndianSettlement.java:1335: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1342: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1342: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1343: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1343: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1344: Avoid excessively long variable names like CONVERT_PROGRESS_TAG +src/net/sf/freecol/common/model/IndianSettlement.java:1344: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1344: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1345: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1345: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1346: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1346: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1347: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1347: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1348: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1348: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1349: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1349: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1350: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1350: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1351: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1351: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1352: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1352: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1355: Avoid excessively long variable names like LEARNABLE_SKILL_TAG +src/net/sf/freecol/common/model/IndianSettlement.java:1355: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1355: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1356: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1356: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1358: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/IndianSettlement.java:1358: fieldCommentRequirement Required +src/net/sf/freecol/common/model/IndianSettlement.java:1366: Avoid variables with short names like xw +src/net/sf/freecol/common/model/IndianSettlement.java:1366: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1388: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1392: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/IndianSettlement.java:1399: Avoid variables with short names like xw +src/net/sf/freecol/common/model/IndianSettlement.java:1399: Found 'UR'-anomaly for variable 'p' (lines '1,399'-'1,415'). +src/net/sf/freecol/common/model/IndianSettlement.java:1399: Found 'UR'-anomaly for variable 'unit' (lines '1,399'-'1,435'). +src/net/sf/freecol/common/model/IndianSettlement.java:1399: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1412: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1422: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1427: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1427: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1432: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1441: Local variable 'client' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1443: Avoid variables with short names like cl +src/net/sf/freecol/common/model/IndianSettlement.java:1443: Local variable 'cl' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1454: Local variable 'alarm' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/IndianSettlement.java:1471: Avoid variables with short names like xr +src/net/sf/freecol/common/model/IndianSettlement.java:1471: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1496: Avoid variables with short names like xr +src/net/sf/freecol/common/model/IndianSettlement.java:1496: Found 'UR'-anomaly for variable 'u' (lines '1,496'-'1,507'). +src/net/sf/freecol/common/model/IndianSettlement.java:1496: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1500: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/IndianSettlement.java:1506: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1509: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/IndianSettlement.java:1509: There is log block not surrounded by if +src/net/sf/freecol/common/model/IndianSettlement.java:1521: Avoid variables with short names like xr +src/net/sf/freecol/common/model/IndianSettlement.java:1521: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1522: Found 'DU'-anomaly for variable 'game' (lines '1,522'-'1,576'). +src/net/sf/freecol/common/model/IndianSettlement.java:1526: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1539: Avoid variables with short names like cl +src/net/sf/freecol/common/model/IndianSettlement.java:1539: Local variable 'cl' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1541: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1548: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1568: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1583: Avoid variables with short names like sb +src/net/sf/freecol/common/model/IndianSettlement.java:1583: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/IndianSettlement.java:1585: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/IndianSettlement.java:1585: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/LandMap.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/LandMap.java:23: Avoid unused imports such as 'java.util.Arrays' +src/net/sf/freecol/common/model/LandMap.java:28: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/LandMap.java:40: The class 'LandMap' has a Cyclomatic Complexity of 5 (Highest = 23). +src/net/sf/freecol/common/model/LandMap.java:40: The class 'LandMap' has a Modified Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/common/model/LandMap.java:40: The class 'LandMap' has a Standard Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/common/model/LandMap.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/LandMap.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LandMap.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/LandMap.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/LandMap.java:57: Avoid excessively long variable names like preferredDistanceToEdge +src/net/sf/freecol/common/model/LandMap.java:57: Avoid unused private fields such as 'preferredDistanceToEdge'. +src/net/sf/freecol/common/model/LandMap.java:60: Avoid excessively long variable names like minimumNumberOfTiles +src/net/sf/freecol/common/model/LandMap.java:60: Avoid unused private fields such as 'minimumNumberOfTiles'. +src/net/sf/freecol/common/model/LandMap.java:69: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:69: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:81: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:86: Avoid variables with short names like n +src/net/sf/freecol/common/model/LandMap.java:89: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:89: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:92: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/LandMap.java:106: Parameter 'mgo' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:106: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:110: Avoid excessively long variable names like preferredDistanceToEdge +src/net/sf/freecol/common/model/LandMap.java:110: Local variable 'preferredDistanceToEdge' could be declared final +src/net/sf/freecol/common/model/LandMap.java:112: Avoid excessively long variable names like minimumNumberOfTiles +src/net/sf/freecol/common/model/LandMap.java:112: Local variable 'minimumNumberOfTiles' could be declared final +src/net/sf/freecol/common/model/LandMap.java:114: Local variable 'gen' could be declared final +src/net/sf/freecol/common/model/LandMap.java:115: Avoid variables with short names like so +src/net/sf/freecol/common/model/LandMap.java:115: Local variable 'so' could be declared final +src/net/sf/freecol/common/model/LandMap.java:117: There is log block not surrounded by if +src/net/sf/freecol/common/model/LandMap.java:117: There is log block not surrounded by if +src/net/sf/freecol/common/model/LandMap.java:148: Avoid variables with short names like x +src/net/sf/freecol/common/model/LandMap.java:148: Avoid variables with short names like y +src/net/sf/freecol/common/model/LandMap.java:148: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:148: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:159: Avoid variables with short names like x +src/net/sf/freecol/common/model/LandMap.java:159: Avoid variables with short names like y +src/net/sf/freecol/common/model/LandMap.java:159: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:159: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:160: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:160: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:174: Avoid excessively long variable names like preferredDistanceToEdge +src/net/sf/freecol/common/model/LandMap.java:174: Found 'UR'-anomaly for variable 'archsize' (lines '174'-'199'). +src/net/sf/freecol/common/model/LandMap.java:174: Parameter 'preferredDistanceToEdge' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:174: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:175: Avoid excessively long variable names like minimumNumberOfTiles +src/net/sf/freecol/common/model/LandMap.java:175: Parameter 'minimumNumberOfTiles' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:175: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:176: A switch statement does not contain a break +src/net/sf/freecol/common/model/LandMap.java:176: Switch statements should have a default label +src/net/sf/freecol/common/model/LandMap.java:185: Local variable 'contsize' could be declared final +src/net/sf/freecol/common/model/LandMap.java:197: Found 'DU'-anomaly for variable 'archsize' (lines '197'-'214'). +src/net/sf/freecol/common/model/LandMap.java:197: Local variable 'archsize' could be declared final +src/net/sf/freecol/common/model/LandMap.java:207: Avoid variables with short names like s +src/net/sf/freecol/common/model/LandMap.java:207: Local variable 's' could be declared final +src/net/sf/freecol/common/model/LandMap.java:219: Avoid excessively long variable names like preferredDistanceToEdge +src/net/sf/freecol/common/model/LandMap.java:219: Parameter 'preferredDistanceToEdge' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:220: Avoid excessively long variable names like minimumNumberOfTiles +src/net/sf/freecol/common/model/LandMap.java:220: Avoid reassigning parameters such as 'minimumNumberOfTiles' +src/net/sf/freecol/common/model/LandMap.java:220: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:221: Avoid variables with short names like x +src/net/sf/freecol/common/model/LandMap.java:221: Avoid variables with short names like y +src/net/sf/freecol/common/model/LandMap.java:221: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/LandMap.java:223: Found 'DD'-anomaly for variable 'failCounter' (lines '223'-'231'). +src/net/sf/freecol/common/model/LandMap.java:225: Found 'DU'-anomaly for variable 'x' (lines '225'-'244'). +src/net/sf/freecol/common/model/LandMap.java:225: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:225: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:228: Found 'DU'-anomaly for variable 'y' (lines '228'-'244'). +src/net/sf/freecol/common/model/LandMap.java:228: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:228: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:235: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/LandMap.java:236: Found 'DU'-anomaly for variable 'failCounter' (lines '236'-'244'). +src/net/sf/freecol/common/model/LandMap.java:260: Local variable 'limit' could be declared final +src/net/sf/freecol/common/model/LandMap.java:276: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/LandMap.java:288: Avoid variables with short names like x +src/net/sf/freecol/common/model/LandMap.java:288: Avoid variables with short names like y +src/net/sf/freecol/common/model/LandMap.java:288: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:288: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:289: Avoid variables with short names like p +src/net/sf/freecol/common/model/LandMap.java:289: Found 'DU'-anomaly for variable 'p' (lines '289'-'294'). +src/net/sf/freecol/common/model/LandMap.java:290: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/LandMap.java:290: Avoid variables with short names like d +src/net/sf/freecol/common/model/LandMap.java:291: Avoid variables with short names like n +src/net/sf/freecol/common/model/LandMap.java:291: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/LandMap.java:292: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:292: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:296: Comment is too large: Too many lines +src/net/sf/freecol/common/model/LandMap.java:308: Avoid excessively long variable names like preferredDistanceToEdge +src/net/sf/freecol/common/model/LandMap.java:308: Avoid variables with short names like x +src/net/sf/freecol/common/model/LandMap.java:308: Avoid variables with short names like y +src/net/sf/freecol/common/model/LandMap.java:308: Found 'UR'-anomaly for variable 'direction' (lines '308'-'318'). +src/net/sf/freecol/common/model/LandMap.java:308: Parameter 'preferredDistanceToEdge' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:308: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:308: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:309: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:310: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/LandMap.java:310: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/LandMap.java:316: Avoid variables with short names like p +src/net/sf/freecol/common/model/LandMap.java:316: Found 'DU'-anomaly for variable 'p' (lines '316'-'325'). +src/net/sf/freecol/common/model/LandMap.java:316: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/LandMap.java:317: Local variable 'direction' could be declared final +src/net/sf/freecol/common/model/LandMap.java:318: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/LandMap.java:318: Avoid variables with short names like n +src/net/sf/freecol/common/model/LandMap.java:318: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/LandMap.java:327: Comment is too large: Too many lines +src/net/sf/freecol/common/model/LandMap.java:341: Avoid excessively long variable names like preferredDistanceToEdge +src/net/sf/freecol/common/model/LandMap.java:341: Avoid variables with short names like x +src/net/sf/freecol/common/model/LandMap.java:341: Avoid variables with short names like y +src/net/sf/freecol/common/model/LandMap.java:341: Found 'UR'-anomaly for variable 'direction' (lines '341'-'359'). +src/net/sf/freecol/common/model/LandMap.java:341: Parameter 'preferredDistanceToEdge' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:341: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:341: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:342: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:343: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/LandMap.java:343: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/LandMap.java:351: Avoid variables with short names like r +src/net/sf/freecol/common/model/LandMap.java:351: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/LandMap.java:353: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:353: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:356: Found 'DD'-anomaly for variable 'sum' (lines '356'-'360'). +src/net/sf/freecol/common/model/LandMap.java:357: Avoid variables with short names like p +src/net/sf/freecol/common/model/LandMap.java:357: Found 'DU'-anomaly for variable 'p' (lines '357'-'365'). +src/net/sf/freecol/common/model/LandMap.java:357: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/LandMap.java:358: Local variable 'direction' could be declared final +src/net/sf/freecol/common/model/LandMap.java:359: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/LandMap.java:359: Avoid variables with short names like n +src/net/sf/freecol/common/model/LandMap.java:359: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/LandMap.java:360: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/LandMap.java:360: Found 'DD'-anomaly for variable 'sum' (lines '360'-'360'). +src/net/sf/freecol/common/model/LandMap.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:363: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:363: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:367: Comment is too large: Too many lines +src/net/sf/freecol/common/model/LandMap.java:380: Avoid reassigning parameters such as 'x' +src/net/sf/freecol/common/model/LandMap.java:380: Avoid reassigning parameters such as 'x' +src/net/sf/freecol/common/model/LandMap.java:380: Avoid reassigning parameters such as 'x' +src/net/sf/freecol/common/model/LandMap.java:380: Avoid reassigning parameters such as 'y' +src/net/sf/freecol/common/model/LandMap.java:380: Avoid reassigning parameters such as 'y' +src/net/sf/freecol/common/model/LandMap.java:380: Avoid reassigning parameters such as 'y' +src/net/sf/freecol/common/model/LandMap.java:380: Avoid variables with short names like x +src/net/sf/freecol/common/model/LandMap.java:380: Avoid variables with short names like y +src/net/sf/freecol/common/model/LandMap.java:380: Found 'UR'-anomaly for variable 'direction' (lines '380'-'404'). +src/net/sf/freecol/common/model/LandMap.java:380: Parameter 'maxSize' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:380: Parameter 'minSize' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:380: The method 'addLandMass' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/common/model/LandMap.java:380: The method 'addLandMass' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/LandMap.java:380: The method 'addLandMass' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/LandMap.java:380: The method addLandMass() has an NPath complexity of 6750 +src/net/sf/freecol/common/model/LandMap.java:381: Avoid excessively long variable names like preferredDistanceToEdge +src/net/sf/freecol/common/model/LandMap.java:381: Parameter 'preferredDistanceToEdge' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:381: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LandMap.java:382: Found 'DD'-anomaly for variable 'size' (lines '382'-'398'). +src/net/sf/freecol/common/model/LandMap.java:383: Found 'DD'-anomaly for variable 'newLand' (lines '383'-'397'). +src/net/sf/freecol/common/model/LandMap.java:397: Found 'DU'-anomaly for variable 'newLand' (lines '397'-'450'). +src/net/sf/freecol/common/model/LandMap.java:401: Avoid variables with short names like l +src/net/sf/freecol/common/model/LandMap.java:401: Local variable 'l' could be declared final +src/net/sf/freecol/common/model/LandMap.java:402: Avoid variables with short names like p +src/net/sf/freecol/common/model/LandMap.java:403: Local variable 'direction' could be declared final +src/net/sf/freecol/common/model/LandMap.java:404: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/LandMap.java:404: Avoid variables with short names like n +src/net/sf/freecol/common/model/LandMap.java:404: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/LandMap.java:405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:416: Local variable 'enough' could be declared final +src/net/sf/freecol/common/model/LandMap.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:419: Avoid variables with short names like i +src/net/sf/freecol/common/model/LandMap.java:419: Local variable 'i' could be declared final +src/net/sf/freecol/common/model/LandMap.java:419: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:422: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:422: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:423: Found 'DU'-anomaly for variable 'newLand' (lines '423'-'450'). +src/net/sf/freecol/common/model/LandMap.java:423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LandMap.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:426: Local variable 'direction' could be declared final +src/net/sf/freecol/common/model/LandMap.java:427: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/LandMap.java:427: Avoid variables with short names like n +src/net/sf/freecol/common/model/LandMap.java:427: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/LandMap.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:429: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:429: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:430: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:431: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:432: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LandMap.java:442: Avoid unnecessary comparisons in boolean expressions +src/net/sf/freecol/common/model/LandMap.java:449: Useless parentheses. +src/net/sf/freecol/common/model/LandMap.java:449: Useless parentheses. +src/net/sf/freecol/common/model/LastSale.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/LastSale.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/LastSale.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/LastSale.java:51: Parameter 'what' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:51: Parameter 'where' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:52: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:52: Parameter 'when' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:63: Avoid variables with short names like id +src/net/sf/freecol/common/model/LastSale.java:63: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/LastSale.java:63: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:63: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:63: Parameter 'when' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:75: Avoid variables with short names like xr +src/net/sf/freecol/common/model/LastSale.java:75: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/LastSale.java:75: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:84: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/LastSale.java:84: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:115: Parameter 'what' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:115: Parameter 'where' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:126: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:127: Found 'DD'-anomaly for variable 'cmp' (lines '127'-'130'). +src/net/sf/freecol/common/model/LastSale.java:129: Avoid variables with short names like ls +src/net/sf/freecol/common/model/LastSale.java:129: Local variable 'ls' could be declared final +src/net/sf/freecol/common/model/LastSale.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LastSale.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LastSale.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LastSale.java:132: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/LastSale.java:139: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/LastSale.java:139: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LastSale.java:140: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/LastSale.java:140: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LastSale.java:147: Avoid variables with short names like xw +src/net/sf/freecol/common/model/LastSale.java:147: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:159: Avoid variables with short names like xr +src/net/sf/freecol/common/model/LastSale.java:159: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/LastSale.java:172: Avoid variables with short names like sb +src/net/sf/freecol/common/model/LastSale.java:172: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/LastSale.java:173: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/LastSale.java:176: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Limit.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Limit.java:20: Possible God class (WMC=50, ATFD=29, TCC=0.125) +src/net/sf/freecol/common/model/Limit.java:37: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Limit.java:59: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:70: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Limit.java:70: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:70: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:84: Avoid variables with short names like id +src/net/sf/freecol/common/model/Limit.java:84: Avoid variables with short names like op +src/net/sf/freecol/common/model/Limit.java:84: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Limit.java:84: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:84: Parameter 'lhs' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:84: Parameter 'op' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:84: Parameter 'rhs' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:101: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Limit.java:147: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:157: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:158: Found 'DD'-anomaly for variable 'lhs' (lines '158'-'161'). +src/net/sf/freecol/common/model/Limit.java:158: Found 'DD'-anomaly for variable 'lhs' (lines '158'-'164'). +src/net/sf/freecol/common/model/Limit.java:159: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/common/model/Limit.java:167: Found 'DD'-anomaly for variable 'rhs' (lines '167'-'170'). +src/net/sf/freecol/common/model/Limit.java:167: Found 'DD'-anomaly for variable 'rhs' (lines '167'-'173'). +src/net/sf/freecol/common/model/Limit.java:168: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/common/model/Limit.java:186: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:187: Found 'DD'-anomaly for variable 'lhs' (lines '187'-'190'). +src/net/sf/freecol/common/model/Limit.java:187: Found 'DD'-anomaly for variable 'lhs' (lines '187'-'193'). +src/net/sf/freecol/common/model/Limit.java:187: Found 'DD'-anomaly for variable 'lhs' (lines '187'-'196'). +src/net/sf/freecol/common/model/Limit.java:200: Found 'DD'-anomaly for variable 'rhs' (lines '200'-'203'). +src/net/sf/freecol/common/model/Limit.java:200: Found 'DD'-anomaly for variable 'rhs' (lines '200'-'206'). +src/net/sf/freecol/common/model/Limit.java:200: Found 'DD'-anomaly for variable 'rhs' (lines '200'-'209'). +src/net/sf/freecol/common/model/Limit.java:222: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:223: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Limit.java:223: Avoid unused local variables such as 'spec'. +src/net/sf/freecol/common/model/Limit.java:223: Found 'DU'-anomaly for variable 'spec' (lines '223'-'257'). +src/net/sf/freecol/common/model/Limit.java:224: Found 'DD'-anomaly for variable 'lhs' (lines '224'-'227'). +src/net/sf/freecol/common/model/Limit.java:224: Found 'DD'-anomaly for variable 'lhs' (lines '224'-'230'). +src/net/sf/freecol/common/model/Limit.java:224: Found 'DD'-anomaly for variable 'lhs' (lines '224'-'233'). +src/net/sf/freecol/common/model/Limit.java:224: Found 'DD'-anomaly for variable 'lhs' (lines '224'-'236'). +src/net/sf/freecol/common/model/Limit.java:240: Found 'DD'-anomaly for variable 'rhs' (lines '240'-'243'). +src/net/sf/freecol/common/model/Limit.java:240: Found 'DD'-anomaly for variable 'rhs' (lines '240'-'246'). +src/net/sf/freecol/common/model/Limit.java:240: Found 'DD'-anomaly for variable 'rhs' (lines '240'-'249'). +src/net/sf/freecol/common/model/Limit.java:240: Found 'DD'-anomaly for variable 'rhs' (lines '240'-'252'). +src/net/sf/freecol/common/model/Limit.java:265: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:277: Parameter 'lhs' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:277: Parameter 'rhs' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:278: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Limit.java:278: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Limit.java:280: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Limit.java:280: Use equals() to compare object references. +src/net/sf/freecol/common/model/Limit.java:281: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Limit.java:282: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Limit.java:283: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Limit.java:284: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Limit.java:293: Avoid excessively long variable names like LEFT_HAND_SIDE_TAG +src/net/sf/freecol/common/model/Limit.java:293: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Limit.java:293: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Limit.java:294: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Limit.java:294: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Limit.java:295: Avoid excessively long variable names like RIGHT_HAND_SIDE_TAG +src/net/sf/freecol/common/model/Limit.java:295: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Limit.java:295: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Limit.java:297: Avoid excessively long variable names like OLD_LEFT_HAND_SIDE_TAG +src/net/sf/freecol/common/model/Limit.java:297: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Limit.java:297: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Limit.java:298: Avoid excessively long variable names like OLD_RIGHT_HAND_SIDE_TAG +src/net/sf/freecol/common/model/Limit.java:298: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Limit.java:298: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Limit.java:306: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Limit.java:306: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:316: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Limit.java:316: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:328: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Limit.java:328: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:339: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Limit.java:339: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Limit.java:366: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Limit.java:366: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Limit.java:367: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Limit.java:368: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Locatable.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Locatable.java:33: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Locatable.java:42: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Locatable.java:49: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Locatable.java:58: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Locatable.java:66: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Location.java:38: Avoid excessively long variable names like LOCATION_RANK_NOWHERE +src/net/sf/freecol/common/model/Location.java:38: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Location.java:39: Avoid excessively long variable names like LOCATION_RANK_EUROPE +src/net/sf/freecol/common/model/Location.java:39: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:39: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Location.java:40: Avoid excessively long variable names like LOCATION_RANK_HIGHSEAS +src/net/sf/freecol/common/model/Location.java:40: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Location.java:49: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:56: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:63: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:71: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:79: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:88: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:97: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:106: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:113: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:120: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:128: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:137: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:145: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:153: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:161: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:171: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:171: Avoid using short method names +src/net/sf/freecol/common/model/Location.java:179: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:186: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:195: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Location.java:196: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Location.java:205: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/LostCityRumour.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/LostCityRumour.java:33: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/LostCityRumour.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/LostCityRumour.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:47: Avoid excessively long variable names like MAYAN_PROPHESY_YEAR +src/net/sf/freecol/common/model/LostCityRumour.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:56: Avoid using redundant field initializer for 'type' +src/net/sf/freecol/common/model/LostCityRumour.java:63: Avoid using redundant field initializer for 'name' +src/net/sf/freecol/common/model/LostCityRumour.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/LostCityRumour.java:88: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:92: Parameter 'variant' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:92: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:104: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:104: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:116: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:116: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:116: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:116: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:129: Avoid variables with short names like id +src/net/sf/freecol/common/model/LostCityRumour.java:129: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:129: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:163: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:163: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:168: Comment is too large: Too many lines +src/net/sf/freecol/common/model/LostCityRumour.java:182: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:182: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:186: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:186: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:189: Found 'DD'-anomaly for variable 'percentBad' (lines '189'-'197'). +src/net/sf/freecol/common/model/LostCityRumour.java:189: Found 'DD'-anomaly for variable 'percentBad' (lines '189'-'204'). +src/net/sf/freecol/common/model/LostCityRumour.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LostCityRumour.java:190: Found 'DD'-anomaly for variable 'percentGood' (lines '190'-'198'). +src/net/sf/freecol/common/model/LostCityRumour.java:190: Found 'DD'-anomaly for variable 'percentGood' (lines '190'-'205'). +src/net/sf/freecol/common/model/LostCityRumour.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LostCityRumour.java:195: Local variable 'mod' could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:203: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:209: Local variable 'percentNeutral' could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:212: Avoid variables with short names like c +src/net/sf/freecol/common/model/LostCityRumour.java:212: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LostCityRumour.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LostCityRumour.java:268: Parameter 'mounds' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:268: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:269: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LostCityRumour.java:273: Local variable 'years' could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/LostCityRumour.java:274: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/LostCityRumour.java:279: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/LostCityRumour.java:283: Avoid variables with short names like i +src/net/sf/freecol/common/model/LostCityRumour.java:287: Local variable 'key' could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:288: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/LostCityRumour.java:324: Parameter 'tileType' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:332: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:332: Parameter 'potential' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:332: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:343: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:343: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:351: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:352: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:353: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/LostCityRumour.java:379: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:386: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/LostCityRumour.java:386: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:387: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/LostCityRumour.java:387: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:388: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/LostCityRumour.java:388: fieldCommentRequirement Required +src/net/sf/freecol/common/model/LostCityRumour.java:395: Avoid variables with short names like xw +src/net/sf/freecol/common/model/LostCityRumour.java:395: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/LostCityRumour.java:413: Avoid variables with short names like xr +src/net/sf/freecol/common/model/LostCityRumour.java:413: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:20: Possible God class (WMC=450, ATFD=282, TCC=0.01644736842105263) +src/net/sf/freecol/common/model/Map.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/model/Map.java:61: Avoid really long classes. +src/net/sf/freecol/common/model/Map.java:61: Avoid short class names like Map +src/net/sf/freecol/common/model/Map.java:61: The class 'Map' has a Cyclomatic Complexity of 4 (Highest = 73). +src/net/sf/freecol/common/model/Map.java:61: The class 'Map' has a Modified Cyclomatic Complexity of 4 (Highest = 59). +src/net/sf/freecol/common/model/Map.java:61: The class 'Map' has a Standard Cyclomatic Complexity of 4 (Highest = 64). +src/net/sf/freecol/common/model/Map.java:61: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Map.java:63: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Map.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:90: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:90: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:100: Parameter 'posX' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:100: Parameter 'posY' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:111: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:122: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:122: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:123: Local variable 'step' could be declared final +src/net/sf/freecol/common/model/Map.java:155: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:155: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:159: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:172: Avoid variables with short names like ax +src/net/sf/freecol/common/model/Map.java:172: Avoid variables with short names like ay +src/net/sf/freecol/common/model/Map.java:172: Avoid variables with short names like bx +src/net/sf/freecol/common/model/Map.java:172: Avoid variables with short names like by +src/net/sf/freecol/common/model/Map.java:172: Parameter 'ax' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:172: Parameter 'ay' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:172: Parameter 'bx' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:172: Parameter 'by' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:173: Avoid variables with short names like r +src/net/sf/freecol/common/model/Map.java:173: Found 'DD'-anomaly for variable 'r' (lines '173'-'176'). +src/net/sf/freecol/common/model/Map.java:173: Found 'DD'-anomaly for variable 'r' (lines '173'-'178'). +src/net/sf/freecol/common/model/Map.java:173: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:173: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:183: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:193: Parameter 'position' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:204: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:206: Avoid variables with short names like d +src/net/sf/freecol/common/model/Map.java:215: Avoid variables with short names like o +src/net/sf/freecol/common/model/Map.java:215: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:216: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:216: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:218: Avoid variables with short names like p +src/net/sf/freecol/common/model/Map.java:218: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/Map.java:219: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:243: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:243: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:246: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:253: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:260: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:263: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:263: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:266: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:269: Avoid using redundant field initializer for 'traceSearch' +src/net/sf/freecol/common/model/Map.java:269: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:269: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:279: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:279: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:279: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:284: Overridable method 'getHeight' called during object construction +src/net/sf/freecol/common/model/Map.java:295: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Map.java:295: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:295: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:301: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:310: Avoid variables with short names like id +src/net/sf/freecol/common/model/Map.java:310: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:310: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:315: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:325: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:325: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:325: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:325: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:325: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:325: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:336: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:336: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:336: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:336: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:346: Parameter 'position' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:350: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:360: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:360: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:360: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:360: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:361: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:361: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:361: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:370: Avoid variables with short names like p +src/net/sf/freecol/common/model/Map.java:370: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:381: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:381: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:381: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:381: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:381: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:403: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:407: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:420: Avoid excessively long variable names like newMinimumLatitude +src/net/sf/freecol/common/model/Map.java:420: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:434: Avoid excessively long variable names like newMaximumLatitude +src/net/sf/freecol/common/model/Map.java:434: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:459: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:469: Parameter 'latitude' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:487: Found 'UR'-anomaly for variable 'r' (lines '487'-'490'). +src/net/sf/freecol/common/model/Map.java:488: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Map.java:489: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/Map.java:490: Avoid variables with short names like n +src/net/sf/freecol/common/model/Map.java:490: Found 'DD'-anomaly for variable 'n' (lines '490'-'490'). +src/net/sf/freecol/common/model/Map.java:490: Found 'DU'-anomaly for variable 'n' (lines '490'-'494'). +src/net/sf/freecol/common/model/Map.java:490: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/Map.java:491: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:503: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:504: Avoid variables with short names like r +src/net/sf/freecol/common/model/Map.java:515: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:516: Avoid variables with short names like r +src/net/sf/freecol/common/model/Map.java:537: Avoid variables with short names like l1 +src/net/sf/freecol/common/model/Map.java:537: Avoid variables with short names like l2 +src/net/sf/freecol/common/model/Map.java:537: Parameter 'l1' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:537: Parameter 'l2' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:538: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:538: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:539: Use equals() to compare object references. +src/net/sf/freecol/common/model/Map.java:552: Avoid variables with short names like l1 +src/net/sf/freecol/common/model/Map.java:552: Avoid variables with short names like l2 +src/net/sf/freecol/common/model/Map.java:552: Parameter 'l1' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:552: Parameter 'l2' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:553: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:553: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:554: Use equals() to compare object references. +src/net/sf/freecol/common/model/Map.java:556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:565: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:570: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:581: Avoid variables with short names like t1 +src/net/sf/freecol/common/model/Map.java:581: Avoid variables with short names like t2 +src/net/sf/freecol/common/model/Map.java:581: Parameter 't1' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:581: Parameter 't2' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:582: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:582: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:582: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:594: Parameter 'dst' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:594: Parameter 'src' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:595: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:595: Local variable 'x' could be declared final +src/net/sf/freecol/common/model/Map.java:596: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:596: Local variable 'y' could be declared final +src/net/sf/freecol/common/model/Map.java:597: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:597: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:599: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:603: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:612: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:612: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:612: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:612: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:612: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:624: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:624: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:635: Avoid variables with short names like t1 +src/net/sf/freecol/common/model/Map.java:635: Avoid variables with short names like t2 +src/net/sf/freecol/common/model/Map.java:635: Parameter 't1' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:635: Parameter 't2' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:647: Found 'UR'-anomaly for variable 't' (lines '647'-'651'). +src/net/sf/freecol/common/model/Map.java:647: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:647: Parameter 'tiles' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:648: Found 'DD'-anomaly for variable 'result' (lines '648'-'654'). +src/net/sf/freecol/common/model/Map.java:649: Found 'DU'-anomaly for variable 'minimumDistance' (lines '649'-'658'). +src/net/sf/freecol/common/model/Map.java:650: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:651: Local variable 'distance' could be declared final +src/net/sf/freecol/common/model/Map.java:653: Found 'DU'-anomaly for variable 'minimumDistance' (lines '653'-'658'). +src/net/sf/freecol/common/model/Map.java:654: Found 'DD'-anomaly for variable 'result' (lines '654'-'654'). +src/net/sf/freecol/common/model/Map.java:666: Found 'UR'-anomaly for variable 't' (lines '666'-'680'). +src/net/sf/freecol/common/model/Map.java:666: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:667: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Map.java:668: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:668: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:668: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Map.java:679: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:680: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:680: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:692: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:701: Parameter 'endTile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:705: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:716: The method 'findRealStart' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/Map.java:716: The method 'findRealStart' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/common/model/Map.java:716: The method 'findRealStart' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/common/model/Map.java:716: The method findRealStart() has an NPath complexity of 360 +src/net/sf/freecol/common/model/Map.java:721: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:733: Local variable 'unitLoc' could be declared final +src/net/sf/freecol/common/model/Map.java:733: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:741: Use equals() to compare object references. +src/net/sf/freecol/common/model/Map.java:753: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:767: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:767: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:767: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:778: Parameter 'end' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:782: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:783: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:790: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:801: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:801: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:801: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:802: Parameter 'costDecider' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:804: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:809: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:820: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:820: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:820: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:821: Parameter 'costDecider' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:822: Local variable 'path' could be declared final +src/net/sf/freecol/common/model/Map.java:823: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:823: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:823: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:826: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:841: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:841: Parameter 'end' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:841: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:841: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:841: The method 'findMapPath' has a Cyclomatic Complexity of 22. +src/net/sf/freecol/common/model/Map.java:841: The method 'findMapPath' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/Map.java:841: The method 'findMapPath' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/Map.java:841: The method findMapPath() has an NPath complexity of 315 +src/net/sf/freecol/common/model/Map.java:842: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Map.java:842: Parameter 'costDecider' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:842: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:843: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:843: Found 'DU'-anomaly for variable 'offMapUnit' (lines '843'-'904'). +src/net/sf/freecol/common/model/Map.java:845: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:846: Avoid variables with short names like gd +src/net/sf/freecol/common/model/Map.java:846: Found 'DU'-anomaly for variable 'gd' (lines '846'-'904'). +src/net/sf/freecol/common/model/Map.java:847: Avoid variables with short names like sh +src/net/sf/freecol/common/model/Map.java:847: Found 'DU'-anomaly for variable 'sh' (lines '847'-'904'). +src/net/sf/freecol/common/model/Map.java:859: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:859: Local variable 'carrierPath' could be declared final +src/net/sf/freecol/common/model/Map.java:864: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:864: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:864: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:864: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:864: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:864: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:864: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:865: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:865: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:869: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:879: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:885: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:885: Found 'DU'-anomaly for variable 'embarkTo' (lines '885'-'904'). +src/net/sf/freecol/common/model/Map.java:887: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:888: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:896: Local variable 'last' could be declared final +src/net/sf/freecol/common/model/Map.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:897: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:901: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:913: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Map.java:913: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:913: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:913: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:916: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:916: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:916: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:917: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:917: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:917: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:917: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:919: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:925: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:928: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:945: Avoid really long methods. +src/net/sf/freecol/common/model/Map.java:945: The method 'findPath' has a Cyclomatic Complexity of 24. +src/net/sf/freecol/common/model/Map.java:945: The method 'findPath' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/Map.java:945: The method 'findPath' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/Map.java:945: The method findPath() has an NPath complexity of 420 +src/net/sf/freecol/common/model/Map.java:947: Parameter 'costDecider' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:948: Avoid reassigning parameters such as 'lb' +src/net/sf/freecol/common/model/Map.java:948: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Map.java:949: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:952: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Map.java:952: Found 'DU'-anomaly for variable 'realStart' (lines '952'-'1,056'). +src/net/sf/freecol/common/model/Map.java:953: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Map.java:955: Found 'DU'-anomaly for variable 'realEnd' (lines '955'-'1,056'). +src/net/sf/freecol/common/model/Map.java:961: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:963: Avoid variables with short names like p +src/net/sf/freecol/common/model/Map.java:963: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Map.java:965: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:969: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:980: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:980: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:981: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:984: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:986: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:993: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:993: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:993: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:994: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:994: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:994: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:996: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:997: Avoid variables with short names like l2 +src/net/sf/freecol/common/model/Map.java:997: Local variable 'l2' could be declared final +src/net/sf/freecol/common/model/Map.java:998: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1000: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1001: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1001: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1004: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1006: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1027: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1028: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1031: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:1034: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1037: Local variable 'last' could be declared final +src/net/sf/freecol/common/model/Map.java:1037: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1039: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1039: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1040: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1058: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1080: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1084: Avoid reassigning parameters such as 'lb' +src/net/sf/freecol/common/model/Map.java:1084: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Map.java:1085: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1088: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1088: Found 'DU'-anomaly for variable 'offMapUnit' (lines '1,088'-'1,120'). +src/net/sf/freecol/common/model/Map.java:1090: Avoid variables with short names like p +src/net/sf/freecol/common/model/Map.java:1090: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Map.java:1094: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1094: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1095: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1099: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:1099: Found 'DU'-anomaly for variable 'p' (lines '1,099'-'1,120'). +src/net/sf/freecol/common/model/Map.java:1100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1103: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1127: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Map.java:1137: Parameter 'trace' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1138: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/Map.java:1143: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1153: Avoid reassigning parameters such as 'path' +src/net/sf/freecol/common/model/Map.java:1155: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:1155: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1164: The class 'MoveCandidate' has a Cyclomatic Complexity of 3 (Highest = 11). +src/net/sf/freecol/common/model/Map.java:1166: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1166: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1167: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1167: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1168: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1168: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1169: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1169: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1170: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1170: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1171: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1171: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1172: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1172: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1173: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1173: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1174: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1174: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1177: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1189: Parameter 'current' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1189: Parameter 'dst' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1189: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1190: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1190: Parameter 'onCarrier' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1190: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1191: Parameter 'decider' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1206: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1221: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1232: Parameter 'goal' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1232: The method 'resetPath' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/Map.java:1258: Avoid variables with short names like s +src/net/sf/freecol/common/model/Map.java:1259: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:1260: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1260: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1263: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1276: Parameter 'best' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1279: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1279: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1291: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/model/Map.java:1291: Parameter 'openMap' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1292: Parameter 'openMapQueue' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1293: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/model/Map.java:1293: Avoid variables with short names like f +src/net/sf/freecol/common/model/Map.java:1293: Parameter 'f' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1294: Avoid variables with short names like sh +src/net/sf/freecol/common/model/Map.java:1294: Parameter 'sh' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1295: Local variable 'best' could be declared final +src/net/sf/freecol/common/model/Map.java:1314: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Map.java:1314: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Map.java:1322: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Map.java:1327: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1361: Avoid really long methods. +src/net/sf/freecol/common/model/Map.java:1361: The method 'searchMap' has a Cyclomatic Complexity of 73. +src/net/sf/freecol/common/model/Map.java:1361: The method 'searchMap' has a Modified Cyclomatic Complexity of 59. +src/net/sf/freecol/common/model/Map.java:1361: The method 'searchMap' has a Standard Cyclomatic Complexity of 64. +src/net/sf/freecol/common/model/Map.java:1361: The method searchMap() has an NCSS line count of 151 +src/net/sf/freecol/common/model/Map.java:1361: The method searchMap() has an NPath complexity of 1835541146 +src/net/sf/freecol/common/model/Map.java:1366: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Map.java:1367: Found 'DU'-anomaly for variable 'openMap' (lines '1,367'-'1,639'). +src/net/sf/freecol/common/model/Map.java:1367: Found 'DU'-anomaly for variable 'openMap' (lines '1,367'-'1,639'). +src/net/sf/freecol/common/model/Map.java:1368: Found 'DU'-anomaly for variable 'closedMap' (lines '1,368'-'1,639'). +src/net/sf/freecol/common/model/Map.java:1368: Found 'DU'-anomaly for variable 'closedMap' (lines '1,368'-'1,639'). +src/net/sf/freecol/common/model/Map.java:1369: Avoid variables with short names like f +src/net/sf/freecol/common/model/Map.java:1370: Found 'DU'-anomaly for variable 'openMapQueue' (lines '1,370'-'1,639'). +src/net/sf/freecol/common/model/Map.java:1370: Found 'DU'-anomaly for variable 'openMapQueue' (lines '1,370'-'1,639'). +src/net/sf/freecol/common/model/Map.java:1373: Avoid variables with short names like p1 +src/net/sf/freecol/common/model/Map.java:1373: Avoid variables with short names like p2 +src/net/sf/freecol/common/model/Map.java:1373: Parameter 'p1' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1373: Parameter 'p2' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1373: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1374: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1374: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1374: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1374: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1374: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1374: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1375: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1375: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1378: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1378: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Map.java:1378: Avoid unused local variables such as 'europe'. +src/net/sf/freecol/common/model/Map.java:1379: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1380: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1381: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1381: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1382: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1382: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1383: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1387: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1394: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1395: Use equals() to compare object references. +src/net/sf/freecol/common/model/Map.java:1396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1408: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1411: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1411: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1415: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1416: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1419: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1424: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1426: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1427: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1432: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1433: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1438: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1438: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1439: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1442: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1444: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1451: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1457: Local variable 'moveTile' could be declared final +src/net/sf/freecol/common/model/Map.java:1457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1459: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1461: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Map.java:1462: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1467: Avoid variables with short names like cc +src/net/sf/freecol/common/model/Map.java:1468: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:1468: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1468: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1470: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1477: Local variable 'isGoal' could be declared final +src/net/sf/freecol/common/model/Map.java:1478: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:1480: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1485: Local variable 'umt' could be declared final +src/net/sf/freecol/common/model/Map.java:1489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1507: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1507: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1513: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1514: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1520: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1525: Use equals() to compare object references. +src/net/sf/freecol/common/model/Map.java:1529: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1538: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1539: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1542: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1543: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1543: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1543: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1543: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1561: Local variable 'step' could be declared final +src/net/sf/freecol/common/model/Map.java:1561: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1561: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1562: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1562: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1565: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1565: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1565: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1565: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1567: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1567: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:1574: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:1576: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1580: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:1582: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1586: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:1588: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1590: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1593: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:1595: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1599: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1607: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1609: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1611: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1611: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1612: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1614: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1619: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1621: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1626: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1641: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1652: Found 'UR'-anomaly for variable 't' (lines '1,652'-'1,657'). +src/net/sf/freecol/common/model/Map.java:1654: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:1654: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1656: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:1657: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:1657: Local variable 'path' could be declared final +src/net/sf/freecol/common/model/Map.java:1659: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1664: Local variable 'best' could be declared final +src/net/sf/freecol/common/model/Map.java:1665: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Map.java:1665: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1679: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1681: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1683: Avoid variables with short names like n +src/net/sf/freecol/common/model/Map.java:1683: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1685: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:1685: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:1685: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1685: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1695: Parameter 'center' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1695: Parameter 'isFilled' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1695: Parameter 'radius' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1721: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1738: Found 'DU'-anomaly for variable 'started' (lines '1,738'-'1,782'). +src/net/sf/freecol/common/model/Map.java:1747: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Map.java:1752: Found 'DU'-anomaly for variable 'started' (lines '1,752'-'1,782'). +src/net/sf/freecol/common/model/Map.java:1753: Local variable 'step' could be declared final +src/net/sf/freecol/common/model/Map.java:1753: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Map.java:1758: Avoid variables with short names like i +src/net/sf/freecol/common/model/Map.java:1758: Local variable 'i' could be declared final +src/net/sf/freecol/common/model/Map.java:1777: Local variable 'step' could be declared final +src/net/sf/freecol/common/model/Map.java:1777: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:1800: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Map.java:1822: Parameter 'center' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1822: Parameter 'isFilled' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1823: Parameter 'radius' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1827: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1841: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1853: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:1853: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:1853: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1853: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:1879: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Map.java:1915: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:1924: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1933: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:1933: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:1933: Found 'UR'-anomaly for variable 't' (lines '1,933'-'1,935'). +src/net/sf/freecol/common/model/Map.java:1933: Parameter 'distance' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1933: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1933: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1934: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:1935: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:1935: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1940: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1951: Avoid reassigning parameters such as 'h' +src/net/sf/freecol/common/model/Map.java:1951: Avoid reassigning parameters such as 'h' +src/net/sf/freecol/common/model/Map.java:1951: Avoid reassigning parameters such as 'w' +src/net/sf/freecol/common/model/Map.java:1951: Avoid reassigning parameters such as 'w' +src/net/sf/freecol/common/model/Map.java:1951: Avoid reassigning parameters such as 'x' +src/net/sf/freecol/common/model/Map.java:1951: Avoid reassigning parameters such as 'y' +src/net/sf/freecol/common/model/Map.java:1951: Avoid variables with short names like h +src/net/sf/freecol/common/model/Map.java:1951: Avoid variables with short names like w +src/net/sf/freecol/common/model/Map.java:1951: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:1951: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:1951: The method 'forSubMap' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/Map.java:1951: The method forSubMap() has an NPath complexity of 432 +src/net/sf/freecol/common/model/Map.java:1952: Parameter 'consumer' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1961: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1962: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:1963: Local variable 'width' could be declared final +src/net/sf/freecol/common/model/Map.java:1964: Local variable 'height' could be declared final +src/net/sf/freecol/common/model/Map.java:1965: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1967: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1969: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:1971: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Map.java:1972: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Map.java:1973: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1973: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:1976: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:1986: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:1986: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:1986: Parameter 'boolmap' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1986: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1986: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:1990: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:2001: Avoid variables with short names like x +src/net/sf/freecol/common/model/Map.java:2001: Avoid variables with short names like y +src/net/sf/freecol/common/model/Map.java:2001: Found 'UR'-anomaly for variable 'direction' (lines '2,001'-'2,010'). +src/net/sf/freecol/common/model/Map.java:2001: Parameter 'boolmap' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2001: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2001: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2002: Avoid reassigning parameters such as 'limit' +src/net/sf/freecol/common/model/Map.java:2002: Avoid reassigning parameters such as 'limit' +src/net/sf/freecol/common/model/Map.java:2003: Avoid variables with short names like p +src/net/sf/freecol/common/model/Map.java:2004: Avoid variables with short names like q +src/net/sf/freecol/common/model/Map.java:2004: Local variable 'q' could be declared final +src/net/sf/freecol/common/model/Map.java:2005: Found 'DD'-anomaly for variable 'visited' (lines '2,005'-'2,006'). +src/net/sf/freecol/common/model/Map.java:2006: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2006: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2006: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2006: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2009: Local variable 'direction' could be declared final +src/net/sf/freecol/common/model/Map.java:2010: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:2010: Avoid variables with short names like n +src/net/sf/freecol/common/model/Map.java:2010: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/Map.java:2011: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2011: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2012: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2012: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2013: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2013: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2013: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2013: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2014: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2014: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2016: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2020: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2028: The method 'resetContiguity' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/common/model/Map.java:2028: The method 'resetContiguity' has a Modified Cyclomatic Complexity of 23. +src/net/sf/freecol/common/model/Map.java:2028: The method 'resetContiguity' has a Standard Cyclomatic Complexity of 23. +src/net/sf/freecol/common/model/Map.java:2028: The method resetContiguity() has an NPath complexity of 2704 +src/net/sf/freecol/common/model/Map.java:2031: Found 'DD'-anomaly for variable 'waterMap' (lines '2,031'-'2,035'). +src/net/sf/freecol/common/model/Map.java:2035: Found 'DD'-anomaly for variable 'waterMap' (lines '2,035'-'2,035'). +src/net/sf/freecol/common/model/Map.java:2035: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2035: Use bitwise inversion to invert boolean values +src/net/sf/freecol/common/model/Map.java:2036: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/Map.java:2037: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2048: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/Map.java:2049: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2049: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2051: Local variable 'found' could be declared final +src/net/sf/freecol/common/model/Map.java:2055: Avoid variables with short names like t +src/net/sf/freecol/common/model/Map.java:2055: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2056: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2057: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2070: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2070: Use bitwise inversion to invert boolean values +src/net/sf/freecol/common/model/Map.java:2078: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/Map.java:2079: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2079: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2081: Local variable 'found' could be declared final +src/net/sf/freecol/common/model/Map.java:2085: Avoid variables with short names like t +src/net/sf/freecol/common/model/Map.java:2085: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2086: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2087: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2092: Found 'DD'-anomaly for variable 'contig' (lines '2,092'-'2,092'). +src/net/sf/freecol/common/model/Map.java:2092: Found 'DU'-anomaly for variable 'contig' (lines '2,092'-'2,096'). +src/net/sf/freecol/common/model/Map.java:2098: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:2108: Avoid excessively long variable names like distToLandFromHighSeas +src/net/sf/freecol/common/model/Map.java:2108: Found 'UR'-anomaly for variable 't' (lines '2,108'-'2,128'). +src/net/sf/freecol/common/model/Map.java:2108: Parameter 'distToLandFromHighSeas' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2108: The method 'resetHighSeas' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/common/model/Map.java:2108: The method 'resetHighSeas' has a Modified Cyclomatic Complexity of 20. +src/net/sf/freecol/common/model/Map.java:2108: The method 'resetHighSeas' has a Standard Cyclomatic Complexity of 20. +src/net/sf/freecol/common/model/Map.java:2108: The method resetHighSeas() has an NPath complexity of 110160 +src/net/sf/freecol/common/model/Map.java:2109: Parameter 'maxDistanceToEdge' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2111: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Map.java:2111: Found 'DU'-anomaly for variable 'ocean' (lines '2,111'-'2,184'). +src/net/sf/freecol/common/model/Map.java:2111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2114: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Map.java:2117: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Map.java:2120: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Map.java:2123: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Map.java:2127: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2128: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2131: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Map.java:2132: Avoid variables with short names like t +src/net/sf/freecol/common/model/Map.java:2132: Found 'DD'-anomaly for variable 'seaL' (lines '2,132'-'2,147'). +src/net/sf/freecol/common/model/Map.java:2132: Found 'DD'-anomaly for variable 'seaR' (lines '2,132'-'2,163'). +src/net/sf/freecol/common/model/Map.java:2132: Found 'DD'-anomaly for variable 't' (lines '2,132'-'2,135'). +src/net/sf/freecol/common/model/Map.java:2132: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Map.java:2133: Found 'DD'-anomaly for variable 'totalL' (lines '2,133'-'2,142'). +src/net/sf/freecol/common/model/Map.java:2133: Found 'DD'-anomaly for variable 'totalR' (lines '2,133'-'2,158'). +src/net/sf/freecol/common/model/Map.java:2133: Found 'DU'-anomaly for variable 'distanceL' (lines '2,133'-'2,184'). +src/net/sf/freecol/common/model/Map.java:2133: Found 'DU'-anomaly for variable 'distanceR' (lines '2,133'-'2,184'). +src/net/sf/freecol/common/model/Map.java:2133: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Map.java:2135: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:2135: Found 'DD'-anomaly for variable 't' (lines '2,135'-'2,151'). +src/net/sf/freecol/common/model/Map.java:2137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2138: Local variable 'other' could be declared final +src/net/sf/freecol/common/model/Map.java:2141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2142: Found 'DD'-anomaly for variable 'totalL' (lines '2,142'-'2,142'). +src/net/sf/freecol/common/model/Map.java:2144: Local variable 'distance' could be declared final +src/net/sf/freecol/common/model/Map.java:2144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2146: Found 'DU'-anomaly for variable 'distanceL' (lines '2,146'-'2,184'). +src/net/sf/freecol/common/model/Map.java:2147: Found 'DD'-anomaly for variable 'seaL' (lines '2,147'-'2,147'). +src/net/sf/freecol/common/model/Map.java:2151: Avoid assignments in operands +src/net/sf/freecol/common/model/Map.java:2151: Found 'DD'-anomaly for variable 't' (lines '2,151'-'2,135'). +src/net/sf/freecol/common/model/Map.java:2151: Found 'DU'-anomaly for variable 't' (lines '2,151'-'2,184'). +src/net/sf/freecol/common/model/Map.java:2154: Local variable 'other' could be declared final +src/net/sf/freecol/common/model/Map.java:2157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2158: Found 'DD'-anomaly for variable 'totalR' (lines '2,158'-'2,158'). +src/net/sf/freecol/common/model/Map.java:2160: Local variable 'distance' could be declared final +src/net/sf/freecol/common/model/Map.java:2160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2162: Found 'DU'-anomaly for variable 'distanceR' (lines '2,162'-'2,184'). +src/net/sf/freecol/common/model/Map.java:2163: Found 'DD'-anomaly for variable 'seaR' (lines '2,163'-'2,163'). +src/net/sf/freecol/common/model/Map.java:2169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2177: There is log block not surrounded by if +src/net/sf/freecol/common/model/Map.java:2178: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:2178: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:2186: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Map.java:2200: Found 'UR'-anomaly for variable 'd' (lines '2,200'-'2,232'). +src/net/sf/freecol/common/model/Map.java:2200: Found 'UR'-anomaly for variable 't' (lines '2,200'-'2,205'). +src/net/sf/freecol/common/model/Map.java:2200: The method 'resetHighSeasCount' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/Map.java:2200: The method 'resetHighSeasCount' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/Map.java:2200: The method 'resetHighSeasCount' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/Map.java:2201: Local variable 'curr' could be declared final +src/net/sf/freecol/common/model/Map.java:2202: Local variable 'next' could be declared final +src/net/sf/freecol/common/model/Map.java:2204: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2221: Found 'DU'-anomaly for variable 'hsc' (lines '2,221'-'2,243'). +src/net/sf/freecol/common/model/Map.java:2225: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/Map.java:2230: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:2230: Found 'DD'-anomaly for variable 'position' (lines '2,230'-'2,230'). +src/net/sf/freecol/common/model/Map.java:2230: Found 'DU'-anomaly for variable 'position' (lines '2,230'-'2,243'). +src/net/sf/freecol/common/model/Map.java:2230: Local variable 'position' could be declared final +src/net/sf/freecol/common/model/Map.java:2230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2231: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/Map.java:2232: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Map.java:2232: Avoid variables with short names like p +src/net/sf/freecol/common/model/Map.java:2232: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/Map.java:2234: Avoid variables with short names like t +src/net/sf/freecol/common/model/Map.java:2234: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2237: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2248: Found 'UR'-anomaly for variable 't' (lines '2,248'-'2,255'). +src/net/sf/freecol/common/model/Map.java:2254: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2261: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:2261: Useless parentheses. +src/net/sf/freecol/common/model/Map.java:2273: Found 'UR'-anomaly for variable 'r' (lines '2,273'-'2,275'). +src/net/sf/freecol/common/model/Map.java:2274: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/Map.java:2275: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2276: Avoid variables with short names like p +src/net/sf/freecol/common/model/Map.java:2276: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2281: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2282: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2284: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2284: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2314: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2315: Local variable 'name' could be declared final +src/net/sf/freecol/common/model/Map.java:2323: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2327: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Map.java:2336: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2338: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/Map.java:2339: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Map.java:2339: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2348: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2351: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2358: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2375: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2383: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2422: Avoid using short method names +src/net/sf/freecol/common/model/Map.java:2449: Found 'UR'-anomaly for variable 't' (lines '2,449'-'2,452'). +src/net/sf/freecol/common/model/Map.java:2449: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2450: Found 'DD'-anomaly for variable 'result' (lines '2,450'-'2,452'). +src/net/sf/freecol/common/model/Map.java:2451: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2452: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2460: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:2460: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:2461: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:2461: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:2462: Avoid excessively long variable names like MAXIMUM_LATITUDE_TAG +src/net/sf/freecol/common/model/Map.java:2462: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:2462: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:2463: Avoid excessively long variable names like MINIMUM_LATITUDE_TAG +src/net/sf/freecol/common/model/Map.java:2463: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:2463: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:2464: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:2464: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:2466: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:2466: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:2466: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:2469: Avoid using redundant field initializer for 'fixupHighSeas' +src/net/sf/freecol/common/model/Map.java:2469: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Map.java:2469: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Map.java:2469: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Map.java:2477: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Map.java:2477: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2495: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Map.java:2495: Found 'UR'-anomaly for variable 'region' (lines '2,495'-'2,499'). +src/net/sf/freecol/common/model/Map.java:2495: Found 'UR'-anomaly for variable 'tile' (lines '2,495'-'2,503'). +src/net/sf/freecol/common/model/Map.java:2495: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2498: Local variable 'region' could be declared final +src/net/sf/freecol/common/model/Map.java:2502: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/Map.java:2511: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Map.java:2511: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2517: Local variable 'width' could be declared final +src/net/sf/freecol/common/model/Map.java:2522: Local variable 'height' could be declared final +src/net/sf/freecol/common/model/Map.java:2541: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Map.java:2541: Found 'UR'-anomaly for variable 't' (lines '2,541'-'2,568'). +src/net/sf/freecol/common/model/Map.java:2541: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2562: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2567: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2568: Avoid variables with short names like s +src/net/sf/freecol/common/model/Map.java:2568: Local variable 's' could be declared final +src/net/sf/freecol/common/model/Map.java:2569: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2582: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Map.java:2582: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Map.java:2583: Found 'DU'-anomaly for variable 'game' (lines '2,583'-'2,608'). +src/net/sf/freecol/common/model/Map.java:2586: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2589: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2590: Avoid variables with short names like t +src/net/sf/freecol/common/model/Map.java:2590: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Map.java:2591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2594: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Map.java:2594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2595: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Map.java:2595: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Map.java:2595: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2596: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Map.java:2600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/MarketData.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/MarketData.java:29: Avoid unused imports such as 'org.w3c.dom.Element' +src/net/sf/freecol/common/model/MarketData.java:36: The class 'MarketData' has a Cyclomatic Complexity of 1 (Highest = 13). +src/net/sf/freecol/common/model/MarketData.java:36: The class 'MarketData' has a Modified Cyclomatic Complexity of 1 (Highest = 10). +src/net/sf/freecol/common/model/MarketData.java:36: The class 'MarketData' has a Standard Cyclomatic Complexity of 1 (Highest = 10). +src/net/sf/freecol/common/model/MarketData.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/MarketData.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/MarketData.java:88: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:88: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:104: Comment is too large: Too many lines +src/net/sf/freecol/common/model/MarketData.java:113: Avoid variables with short names like id +src/net/sf/freecol/common/model/MarketData.java:113: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:113: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:249: Avoid excessively long variable names like newIncomeBeforeTaxes +src/net/sf/freecol/common/model/MarketData.java:267: Avoid excessively long variable names like newIncomeAfterTaxes +src/net/sf/freecol/common/model/MarketData.java:285: Parameter 'oldPrice' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:294: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/MarketData.java:303: Parameter 'traded' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:308: Comment is too large: Too many lines +src/net/sf/freecol/common/model/MarketData.java:318: The method 'price' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/MarketData.java:318: The method 'price' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/MarketData.java:318: The method 'price' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/MarketData.java:318: The method price() has an NPath complexity of 360 +src/net/sf/freecol/common/model/MarketData.java:319: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/MarketData.java:319: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/MarketData.java:320: Local variable 'diff' could be declared final +src/net/sf/freecol/common/model/MarketData.java:324: Found 'DD'-anomaly for variable 'newPrice' (lines '324'-'333'). +src/net/sf/freecol/common/model/MarketData.java:329: Useless parentheses. +src/net/sf/freecol/common/model/MarketData.java:329: Useless parentheses. +src/net/sf/freecol/common/model/MarketData.java:330: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/MarketData.java:348: There is log block not surrounded by if +src/net/sf/freecol/common/model/MarketData.java:348: There is log block not surrounded by if +src/net/sf/freecol/common/model/MarketData.java:353: Useless parentheses. +src/net/sf/freecol/common/model/MarketData.java:353: Useless parentheses. +src/net/sf/freecol/common/model/MarketData.java:356: There is log block not surrounded by if +src/net/sf/freecol/common/model/MarketData.java:356: There is log block not surrounded by if +src/net/sf/freecol/common/model/MarketData.java:361: Found 'DD'-anomaly for variable 'newSalePrice' (lines '361'-'367'). +src/net/sf/freecol/common/model/MarketData.java:373: Local variable 'oldCostToBuy' could be declared final +src/net/sf/freecol/common/model/MarketData.java:373: Local variable 'oldPaidForSale' could be declared final +src/net/sf/freecol/common/model/MarketData.java:373: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/MarketData.java:376: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/MarketData.java:395: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:395: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:396: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:396: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:397: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:397: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:398: Avoid excessively long variable names like INCOME_AFTER_TAXES_TAG +src/net/sf/freecol/common/model/MarketData.java:398: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:398: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:399: Avoid excessively long variable names like INCOME_BEFORE_TAXES_TAG +src/net/sf/freecol/common/model/MarketData.java:399: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:399: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:400: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:400: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:401: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:401: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:402: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/MarketData.java:402: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketData.java:409: Avoid variables with short names like xw +src/net/sf/freecol/common/model/MarketData.java:409: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:433: Avoid variables with short names like xr +src/net/sf/freecol/common/model/MarketData.java:433: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketData.java:464: Avoid variables with short names like sb +src/net/sf/freecol/common/model/MarketData.java:464: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/MarketData.java:465: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/MarketData.java:466: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/MarketData.java:477: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/MarketWas.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/MarketWas.java:27: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/MarketWas.java:28: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/MarketWas.java:29: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/MarketWas.java:30: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/MarketWas.java:31: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/MarketWas.java:32: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/MarketWas.java:41: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/MarketWas.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/MarketWas.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketWas.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/MarketWas.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketWas.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/MarketWas.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketWas.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/MarketWas.java:45: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/MarketWas.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketWas.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/MarketWas.java:46: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/MarketWas.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/model/MarketWas.java:54: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketWas.java:57: Local variable 'md' could be declared final +src/net/sf/freecol/common/model/MarketWas.java:69: Found 'UR'-anomaly for variable 'ag' (lines '69'-'70'). +src/net/sf/freecol/common/model/MarketWas.java:69: Parameter 'req' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketWas.java:70: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/MarketWas.java:70: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/MarketWas.java:79: Found 'UR'-anomaly for variable 'l' (lines '79'-'85'). +src/net/sf/freecol/common/model/MarketWas.java:79: Found 'UR'-anomaly for variable 'l' (lines '79'-'90'). +src/net/sf/freecol/common/model/MarketWas.java:79: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketWas.java:79: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/MarketWas.java:80: Local variable 'l' could be declared final +src/net/sf/freecol/common/model/MarketWas.java:82: Local variable 'buy' could be declared final +src/net/sf/freecol/common/model/MarketWas.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/MarketWas.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/MarketWas.java:82: Useless parentheses. +src/net/sf/freecol/common/model/MarketWas.java:82: Useless parentheses. +src/net/sf/freecol/common/model/MarketWas.java:87: Local variable 'sell' could be declared final +src/net/sf/freecol/common/model/MarketWas.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/MarketWas.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/MarketWas.java:87: Useless parentheses. +src/net/sf/freecol/common/model/MarketWas.java:87: Useless parentheses. +src/net/sf/freecol/common/model/MarketWas.java:90: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ModelMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ModelMessage.java:20: Possible God class (WMC=71, ATFD=18, TCC=0.1339031339031339) +src/net/sf/freecol/common/model/ModelMessage.java:40: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/ModelMessage.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:67: Parameter 'optionName' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:71: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:94: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:95: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:96: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:97: Avoid using redundant field initializer for 'beenDisplayed' +src/net/sf/freecol/common/model/ModelMessage.java:97: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ModelMessage.java:97: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:107: Avoid variables with short names like id +src/net/sf/freecol/common/model/ModelMessage.java:107: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:107: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:120: Avoid variables with short names like id +src/net/sf/freecol/common/model/ModelMessage.java:120: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:120: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:121: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:133: Avoid variables with short names like id +src/net/sf/freecol/common/model/ModelMessage.java:133: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:133: Parameter 'messageType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:134: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:138: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ModelMessage.java:147: Avoid variables with short names like id +src/net/sf/freecol/common/model/ModelMessage.java:147: Parameter 'defaultId' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:147: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:147: Parameter 'messageType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:148: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:153: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ModelMessage.java:162: Avoid variables with short names like id +src/net/sf/freecol/common/model/ModelMessage.java:162: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:162: Parameter 'messageType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:163: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:163: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:167: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ModelMessage.java:177: Avoid variables with short names like id +src/net/sf/freecol/common/model/ModelMessage.java:177: Parameter 'defaultId' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:177: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:177: Parameter 'messageType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:178: Parameter 'display' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:178: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:182: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/ModelMessage.java:191: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ModelMessage.java:191: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ModelMessage.java:191: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:201: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ModelMessage.java:201: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:220: Parameter 'sourceId' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:238: Parameter 'displayId' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:248: Parameter 'newSource' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:249: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ModelMessage.java:267: Parameter 'messageType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:285: Parameter 'beenDisplayed' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:297: Parameter 'messageType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:298: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:299: Avoid variables with short names like o +src/net/sf/freecol/common/model/ModelMessage.java:299: Found 'DD'-anomaly for variable 'o' (lines '299'-'303'). +src/net/sf/freecol/common/model/ModelMessage.java:299: Found 'DD'-anomaly for variable 'o' (lines '299'-'313'). +src/net/sf/freecol/common/model/ModelMessage.java:299: Found 'DD'-anomaly for variable 'o' (lines '299'-'316'). +src/net/sf/freecol/common/model/ModelMessage.java:299: Found 'DD'-anomaly for variable 'o' (lines '299'-'327'). +src/net/sf/freecol/common/model/ModelMessage.java:303: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ModelMessage.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ModelMessage.java:327: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ModelMessage.java:338: Found 'UR'-anomaly for variable 'k' (lines '338'-'345'). +src/net/sf/freecol/common/model/ModelMessage.java:342: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/common/model/ModelMessage.java:342: Switch statements should have a default label +src/net/sf/freecol/common/model/ModelMessage.java:344: Local variable 'k' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:346: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ModelMessage.java:346: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/model/ModelMessage.java:351: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ModelMessage.java:364: Found 'UR'-anomaly for variable 'key' (lines '364'-'376'). +src/net/sf/freecol/common/model/ModelMessage.java:364: Found 'UR'-anomaly for variable 'o' (lines '364'-'384'). +src/net/sf/freecol/common/model/ModelMessage.java:364: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:365: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ModelMessage.java:371: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:373: Local variable 'key' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:376: Local variable 'val' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:377: Avoid variables with short names like b +src/net/sf/freecol/common/model/ModelMessage.java:377: Local variable 'b' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:378: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ModelMessage.java:382: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ModelMessage.java:382: Local variable 'next' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:383: Local variable 'o' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:385: Local variable 'str' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:386: Found 'DD'-anomaly for variable 'index' (lines '386'-'387'). +src/net/sf/freecol/common/model/ModelMessage.java:386: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/ModelMessage.java:387: Avoid assignments in operands +src/net/sf/freecol/common/model/ModelMessage.java:387: Found 'DD'-anomaly for variable 'index' (lines '387'-'386'). +src/net/sf/freecol/common/model/ModelMessage.java:387: Found 'DU'-anomaly for variable 'index' (lines '387'-'402'). +src/net/sf/freecol/common/model/ModelMessage.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:389: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:389: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ModelMessage.java:411: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:411: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:419: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:427: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:427: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:435: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:443: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:443: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:451: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:451: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:459: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:459: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:467: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:467: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:475: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:486: Avoid variables with short names like o +src/net/sf/freecol/common/model/ModelMessage.java:486: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:487: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ModelMessage.java:487: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ModelMessage.java:489: Avoid variables with short names like m +src/net/sf/freecol/common/model/ModelMessage.java:489: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:490: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ModelMessage.java:502: Found 'DD'-anomaly for variable 'hash' (lines '502'-'503'). +src/net/sf/freecol/common/model/ModelMessage.java:510: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ModelMessage.java:510: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:511: Avoid excessively long variable names like HAS_BEEN_DISPLAYED_TAG +src/net/sf/freecol/common/model/ModelMessage.java:511: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ModelMessage.java:511: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:512: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ModelMessage.java:512: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:513: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ModelMessage.java:513: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ModelMessage.java:520: Avoid variables with short names like xw +src/net/sf/freecol/common/model/ModelMessage.java:520: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:525: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ModelMessage.java:536: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ModelMessage.java:536: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ModelMessage.java:554: Avoid variables with short names like sb +src/net/sf/freecol/common/model/ModelMessage.java:554: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Modifier.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Modifier.java:20: Possible God class (WMC=52, ATFD=33, TCC=0.32806324110671936) +src/net/sf/freecol/common/model/Modifier.java:39: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Modifier.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:43: Avoid excessively long variable names like ARTILLERY_AGAINST_RAID +src/net/sf/freecol/common/model/Modifier.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:45: Avoid excessively long variable names like ARTILLERY_IN_THE_OPEN +src/net/sf/freecol/common/model/Modifier.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:49: Avoid excessively long variable names like BIG_MOVEMENT_PENALTY +src/net/sf/freecol/common/model/Modifier.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:51: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:53: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:55: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:57: Avoid excessively long variable names like BUILDING_PRICE_BONUS +src/net/sf/freecol/common/model/Modifier.java:57: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:61: Avoid excessively long variable names like COLONY_GOODS_PARTY +src/net/sf/freecol/common/model/Modifier.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:63: Avoid excessively long variable names like CONSUME_ONLY_SURPLUS_PRODUCTION +src/net/sf/freecol/common/model/Modifier.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:65: Avoid excessively long variable names like CONVERSION_ALARM_RATE +src/net/sf/freecol/common/model/Modifier.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:69: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:71: Avoid excessively long variable names like EXPLORE_LOST_CITY_RUMOUR +src/net/sf/freecol/common/model/Modifier.java:71: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:73: Avoid excessively long variable names like EXPOSED_TILES_RADIUS +src/net/sf/freecol/common/model/Modifier.java:73: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:75: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:77: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:79: Avoid excessively long variable names like LAND_PAYMENT_MODIFIER +src/net/sf/freecol/common/model/Modifier.java:79: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:81: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:83: Avoid excessively long variable names like LINE_OF_SIGHT_BONUS +src/net/sf/freecol/common/model/Modifier.java:83: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:85: Avoid excessively long variable names like MINIMUM_COLONY_SIZE +src/net/sf/freecol/common/model/Modifier.java:85: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:87: Avoid excessively long variable names like MISSIONARY_TRADE_BONUS +src/net/sf/freecol/common/model/Modifier.java:87: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:89: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:91: Avoid excessively long variable names like NATIVE_ALARM_MODIFIER +src/net/sf/freecol/common/model/Modifier.java:91: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:93: Avoid excessively long variable names like NATIVE_CONVERT_BONUS +src/net/sf/freecol/common/model/Modifier.java:93: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:95: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:97: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:99: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:101: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:103: Avoid excessively long variable names like RELIGIOUS_UNREST_BONUS +src/net/sf/freecol/common/model/Modifier.java:103: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:105: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:107: Avoid excessively long variable names like SHIP_TRADE_PENALTY +src/net/sf/freecol/common/model/Modifier.java:107: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:109: Avoid excessively long variable names like SMALL_MOVEMENT_PENALTY +src/net/sf/freecol/common/model/Modifier.java:109: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:111: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:113: Avoid excessively long variable names like TILE_TYPE_CHANGE_PRODUCTION +src/net/sf/freecol/common/model/Modifier.java:113: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:115: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:117: Avoid excessively long variable names like TRADE_VOLUME_PENALTY +src/net/sf/freecol/common/model/Modifier.java:117: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:119: Avoid excessively long variable names like TREASURE_TRANSPORT_FEE +src/net/sf/freecol/common/model/Modifier.java:119: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:121: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:124: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:126: Avoid excessively long variable names like DEFAULT_MODIFIER_INDEX +src/net/sf/freecol/common/model/Modifier.java:126: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:131: Avoid excessively long variable names like RESOURCE_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:131: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:132: Avoid excessively long variable names like COLONY_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:132: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:133: Avoid excessively long variable names like EXPERT_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:133: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:134: Avoid excessively long variable names like FATHER_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:134: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:135: Avoid excessively long variable names like IMPROVEMENT_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:135: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:136: Avoid excessively long variable names like AUTO_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:136: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:137: Avoid excessively long variable names like BUILDING_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:137: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:138: Avoid excessively long variable names like NATION_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:138: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:139: Avoid excessively long variable names like PARTY_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:139: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:140: Avoid excessively long variable names like DISASTER_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:140: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:142: Avoid excessively long variable names like DEFAULT_PRODUCTION_INDEX +src/net/sf/freecol/common/model/Modifier.java:142: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:145: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:146: Avoid excessively long variable names like UNIT_ADDITIVE_COMBAT_INDEX +src/net/sf/freecol/common/model/Modifier.java:146: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:147: Avoid excessively long variable names like UNIT_NORMAL_COMBAT_INDEX +src/net/sf/freecol/common/model/Modifier.java:147: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:148: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:149: Avoid excessively long variable names like GENERAL_COMBAT_INDEX +src/net/sf/freecol/common/model/Modifier.java:149: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:151: enumCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:158: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Modifier.java:179: Document empty constructor +src/net/sf/freecol/common/model/Modifier.java:179: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Modifier.java:186: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Modifier.java:186: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:197: Avoid variables with short names like id +src/net/sf/freecol/common/model/Modifier.java:197: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Modifier.java:197: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:197: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:197: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:211: Avoid variables with short names like id +src/net/sf/freecol/common/model/Modifier.java:211: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:211: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:211: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:212: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:217: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Modifier.java:226: Avoid variables with short names like id +src/net/sf/freecol/common/model/Modifier.java:226: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:226: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:226: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:227: Parameter 'modifierIndex' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:227: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:237: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Modifier.java:237: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:253: Avoid variables with short names like id +src/net/sf/freecol/common/model/Modifier.java:253: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:253: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:266: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Modifier.java:266: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Modifier.java:266: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:266: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:277: Avoid variables with short names like e +src/net/sf/freecol/common/model/Modifier.java:277: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Modifier.java:277: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:277: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:283: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Modifier.java:296: Avoid variables with short names like id +src/net/sf/freecol/common/model/Modifier.java:296: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:296: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:297: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:298: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/Modifier.java:299: Local variable 'inc' could be declared final +src/net/sf/freecol/common/model/Modifier.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Modifier.java:344: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:347: Avoid variables with short names like f +src/net/sf/freecol/common/model/Modifier.java:347: Local variable 'f' could be declared final +src/net/sf/freecol/common/model/Modifier.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Modifier.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Modifier.java:349: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:351: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:412: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Modifier.java:424: Parameter 'firstTurn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:424: Parameter 'lastTurn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:460: Parameter 'base' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:460: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:464: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Modifier.java:473: Parameter 'base' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:473: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:473: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:476: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:478: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:480: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:493: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:505: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:505: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:517: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:517: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Modifier.java:530: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:531: Found 'DD'-anomaly for variable 'cmp' (lines '531'-'534'). +src/net/sf/freecol/common/model/Modifier.java:533: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/Modifier.java:536: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Modifier.java:540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Modifier.java:543: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Modifier.java:554: Avoid variables with short names like o +src/net/sf/freecol/common/model/Modifier.java:554: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:555: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:555: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Modifier.java:557: Avoid variables with short names like m +src/net/sf/freecol/common/model/Modifier.java:557: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/Modifier.java:558: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Modifier.java:558: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Modifier.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Modifier.java:573: Found 'DD'-anomaly for variable 'hash' (lines '573'-'574'). +src/net/sf/freecol/common/model/Modifier.java:584: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Modifier.java:584: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:585: Avoid excessively long variable names like INCREMENT_TYPE_TAG +src/net/sf/freecol/common/model/Modifier.java:585: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Modifier.java:585: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:586: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Modifier.java:586: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:587: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Modifier.java:587: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:589: Avoid excessively long variable names like OLD_INCREMENT_TYPE_TAG +src/net/sf/freecol/common/model/Modifier.java:589: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Modifier.java:589: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Modifier.java:597: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Modifier.java:597: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:619: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Modifier.java:619: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Modifier.java:641: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Modifier.java:652: Found 'UR'-anomaly for variable 's' (lines '652'-'666'). +src/net/sf/freecol/common/model/Modifier.java:653: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Modifier.java:653: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Modifier.java:656: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Modifier.java:658: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Modifier.java:659: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Modifier.java:663: Local variable 'scopes' could be declared final +src/net/sf/freecol/common/model/Modifier.java:664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Modifier.java:666: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Modifier.java:666: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Modifier.java:666: Local variable 's' could be declared final +src/net/sf/freecol/common/model/Modifier.java:669: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Monarch.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Monarch.java:20: Possible God class (WMC=182, ATFD=146, TCC=0.04336734693877551) +src/net/sf/freecol/common/model/Monarch.java:47: Avoid really long classes. +src/net/sf/freecol/common/model/Monarch.java:47: The class 'Monarch' has a Cyclomatic Complexity of 4 (Highest = 25). +src/net/sf/freecol/common/model/Monarch.java:47: The class 'Monarch' has a Modified Cyclomatic Complexity of 3 (Highest = 15). +src/net/sf/freecol/common/model/Monarch.java:47: The class 'Monarch' has a Standard Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/common/model/Monarch.java:47: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Monarch.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Monarch.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:54: The class 'Force' has a Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/common/model/Monarch.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:73: Document empty constructor +src/net/sf/freecol/common/model/Monarch.java:82: Parameter 'ability' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:82: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:84: Local variable 'units' could be declared final +src/net/sf/freecol/common/model/Monarch.java:85: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:86: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Monarch.java:94: There is log block not surrounded by if +src/net/sf/freecol/common/model/Monarch.java:102: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:106: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:116: Avoid variables with short names like nu +src/net/sf/freecol/common/model/Monarch.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:117: Avoid variables with short names like nu +src/net/sf/freecol/common/model/Monarch.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:120: Avoid variables with short names like lu +src/net/sf/freecol/common/model/Monarch.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:130: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Monarch.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:167: Avoid variables with short names like au +src/net/sf/freecol/common/model/Monarch.java:167: Found 'UR'-anomaly for variable 'refUnit' (lines '167'-'174'). +src/net/sf/freecol/common/model/Monarch.java:167: Found 'UR'-anomaly for variable 'refUnit' (lines '167'-'186'). +src/net/sf/freecol/common/model/Monarch.java:167: Parameter 'au' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:167: The method 'add' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/Monarch.java:170: Avoid variables with short names like n +src/net/sf/freecol/common/model/Monarch.java:170: Found 'DU'-anomaly for variable 'n' (lines '170'-'197'). +src/net/sf/freecol/common/model/Monarch.java:171: Found 'DD'-anomaly for variable 'added' (lines '171'-'179'). +src/net/sf/freecol/common/model/Monarch.java:171: Found 'DD'-anomaly for variable 'added' (lines '171'-'190'). +src/net/sf/freecol/common/model/Monarch.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:173: Local variable 'refUnit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:183: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:185: Local variable 'refUnit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:194: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:206: Parameter 'naval' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:208: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:208: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:212: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:213: Local variable 'aui' could be declared final +src/net/sf/freecol/common/model/Monarch.java:214: Local variable 'todo' could be declared final +src/net/sf/freecol/common/model/Monarch.java:216: Avoid variables with short names like au +src/net/sf/freecol/common/model/Monarch.java:216: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/Monarch.java:217: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Monarch.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:218: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Monarch.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:222: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Monarch.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:223: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Monarch.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:224: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:229: Avoid using while statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:236: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:236: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:237: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:237: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:243: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Monarch.java:243: Found 'UR'-anomaly for variable 'unit' (lines '243'-'248'). +src/net/sf/freecol/common/model/Monarch.java:243: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:243: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:243: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:248: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:248: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:254: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:254: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:261: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Monarch.java:261: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:261: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:271: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Monarch.java:275: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Monarch.java:278: There is log block not surrounded by if +src/net/sf/freecol/common/model/Monarch.java:285: Avoid excessively long variable names like MONARCH_MINIMUM_PRICE +src/net/sf/freecol/common/model/Monarch.java:285: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:288: Avoid excessively long variable names like HESSIAN_MINIMUM_PRICE +src/net/sf/freecol/common/model/Monarch.java:288: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:294: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:297: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:297: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:300: Avoid using redundant field initializer for 'supportSea' +src/net/sf/freecol/common/model/Monarch.java:300: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:303: Avoid using redundant field initializer for 'displeasure' +src/net/sf/freecol/common/model/Monarch.java:303: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:332: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:333: The String literal "model." appears 4 times in this file; the first occurrence is on line 333 +src/net/sf/freecol/common/model/Monarch.java:336: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:340: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:344: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:353: Avoid excessively long variable names like expeditionaryForce +src/net/sf/freecol/common/model/Monarch.java:353: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:353: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:359: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:359: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:364: Avoid using redundant field initializer for 'navalTypes' +src/net/sf/freecol/common/model/Monarch.java:364: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:364: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:366: Avoid using redundant field initializer for 'bombardTypes' +src/net/sf/freecol/common/model/Monarch.java:366: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:366: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:368: Avoid using redundant field initializer for 'landTypes' +src/net/sf/freecol/common/model/Monarch.java:368: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:368: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:370: Avoid using redundant field initializer for 'armedRole' +src/net/sf/freecol/common/model/Monarch.java:370: Avoid using redundant field initializer for 'mountedRole' +src/net/sf/freecol/common/model/Monarch.java:370: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:370: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:370: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:371: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:371: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:373: Avoid using redundant field initializer for 'mercenaryTypes' +src/net/sf/freecol/common/model/Monarch.java:373: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:373: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:375: Avoid using redundant field initializer for 'navalREFUnitTypes' +src/net/sf/freecol/common/model/Monarch.java:375: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:375: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:377: Avoid using redundant field initializer for 'landREFUnitTypes' +src/net/sf/freecol/common/model/Monarch.java:377: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:377: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Monarch.java:387: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:387: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:408: Avoid variables with short names like id +src/net/sf/freecol/common/model/Monarch.java:408: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:408: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:452: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:464: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:473: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Monarch.java:482: Parameter 'supportSea' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:491: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Monarch.java:500: Parameter 'displeasure' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:511: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:517: Found 'UR'-anomaly for variable 'r' (lines '517'-'542'). +src/net/sf/freecol/common/model/Monarch.java:517: Found 'UR'-anomaly for variable 'unitType' (lines '517'-'528'). +src/net/sf/freecol/common/model/Monarch.java:517: The method 'initializeCaches' has a Cyclomatic Complexity of 25. +src/net/sf/freecol/common/model/Monarch.java:517: The method 'initializeCaches' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/common/model/Monarch.java:517: The method 'initializeCaches' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/common/model/Monarch.java:517: The method initializeCaches() has an NPath complexity of 396 +src/net/sf/freecol/common/model/Monarch.java:518: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:527: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Monarch.java:527: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:528: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:529: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:531: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:533: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:537: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:541: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/Monarch.java:541: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:542: Avoid variables with short names like ok +src/net/sf/freecol/common/model/Monarch.java:542: Found 'DD'-anomaly for variable 'ok' (lines '542'-'542'). +src/net/sf/freecol/common/model/Monarch.java:542: Found 'DU'-anomaly for variable 'ok' (lines '542'-'561'). +src/net/sf/freecol/common/model/Monarch.java:542: Local variable 'ok' could be declared final +src/net/sf/freecol/common/model/Monarch.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:543: Local variable 'armed' could be declared final +src/net/sf/freecol/common/model/Monarch.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:544: Local variable 'mounted' could be declared final +src/net/sf/freecol/common/model/Monarch.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:545: Found 'DD'-anomaly for variable 'ref' (lines '545'-'545'). +src/net/sf/freecol/common/model/Monarch.java:545: Found 'DU'-anomaly for variable 'ref' (lines '545'-'561'). +src/net/sf/freecol/common/model/Monarch.java:545: Local variable 'ref' could be declared final +src/net/sf/freecol/common/model/Monarch.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:570: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:570: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:571: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:572: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:572: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:572: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:572: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:573: Avoid variables with short names like p +src/net/sf/freecol/common/model/Monarch.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:586: Avoid variables with short names like p +src/net/sf/freecol/common/model/Monarch.java:596: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:596: The method 'actionIsValid' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/Monarch.java:596: The method 'actionIsValid' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/Monarch.java:601: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:603: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:605: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:607: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:609: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:611: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:613: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:613: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:615: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:615: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:617: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:620: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:622: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:638: Local variable 'choices' could be declared final +src/net/sf/freecol/common/model/Monarch.java:639: Avoid variables with short names like dx +src/net/sf/freecol/common/model/Monarch.java:639: Local variable 'dx' could be declared final +src/net/sf/freecol/common/model/Monarch.java:639: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:640: Local variable 'turn' could be declared final +src/net/sf/freecol/common/model/Monarch.java:640: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:640: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:641: Local variable 'grace' could be declared final +src/net/sf/freecol/common/model/Monarch.java:646: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:648: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:663: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Monarch.java:680: Parameter 'choices' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:681: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:681: Parameter 'weight' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:693: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:695: Local variable 'taxAdjustment' could be declared final +src/net/sf/freecol/common/model/Monarch.java:695: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:696: Local variable 'turn' could be declared final +src/net/sf/freecol/common/model/Monarch.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:697: Local variable 'oldTax' could be declared final +src/net/sf/freecol/common/model/Monarch.java:698: Found 'DD'-anomaly for variable 'adjust' (lines '698'-'699'). +src/net/sf/freecol/common/model/Monarch.java:709: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:711: Local variable 'taxAdjustment' could be declared final +src/net/sf/freecol/common/model/Monarch.java:711: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:712: Local variable 'oldTax' could be declared final +src/net/sf/freecol/common/model/Monarch.java:713: Found 'DD'-anomaly for variable 'adjust' (lines '713'-'714'). +src/net/sf/freecol/common/model/Monarch.java:736: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:736: The method chooseForREF() has an NPath complexity of 450 +src/net/sf/freecol/common/model/Monarch.java:739: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Monarch.java:739: Found 'DU'-anomaly for variable 'spec' (lines '739'-'765'). +src/net/sf/freecol/common/model/Monarch.java:743: Local variable 'ref' could be declared final +src/net/sf/freecol/common/model/Monarch.java:744: Local variable 'needNaval' could be declared final +src/net/sf/freecol/common/model/Monarch.java:744: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:745: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:746: Local variable 'types' could be declared final +src/net/sf/freecol/common/model/Monarch.java:746: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:746: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:748: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:748: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:748: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:749: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Monarch.java:751: Local variable 'role' could be declared final +src/net/sf/freecol/common/model/Monarch.java:751: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:751: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:752: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:753: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:757: Local variable 'number' could be declared final +src/net/sf/freecol/common/model/Monarch.java:757: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:757: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:759: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Monarch.java:759: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:760: There is log block not surrounded by if +src/net/sf/freecol/common/model/Monarch.java:760: There is log block not surrounded by if +src/net/sf/freecol/common/model/Monarch.java:761: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:762: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:772: Found 'UR'-anomaly for variable 'ship' (lines '772'-'788'). +src/net/sf/freecol/common/model/Monarch.java:772: Found 'UR'-anomaly for variable 'unit' (lines '772'-'780'). +src/net/sf/freecol/common/model/Monarch.java:773: Local variable 'spec' could be declared final +src/net/sf/freecol/common/model/Monarch.java:774: Local variable 'interventionTurns' could be declared final +src/net/sf/freecol/common/model/Monarch.java:774: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:776: Local variable 'ivf' could be declared final +src/net/sf/freecol/common/model/Monarch.java:777: Found 'DU'-anomaly for variable 'updates' (lines '777'-'799'). +src/net/sf/freecol/common/model/Monarch.java:777: Local variable 'updates' could be declared final +src/net/sf/freecol/common/model/Monarch.java:777: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:777: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:778: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:778: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:780: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/Monarch.java:780: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:781: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:783: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:784: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:784: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:785: Found 'DD'-anomaly for variable 'progress' (lines '785'-'792'). +src/net/sf/freecol/common/model/Monarch.java:786: Local variable 'ship' could be declared final +src/net/sf/freecol/common/model/Monarch.java:786: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:788: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:788: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:789: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:789: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:790: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/Monarch.java:790: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:791: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:792: Found 'DD'-anomaly for variable 'progress' (lines '792'-'792'). +src/net/sf/freecol/common/model/Monarch.java:795: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:796: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:808: Parameter 'naval' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:808: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:811: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Monarch.java:811: Found 'DU'-anomaly for variable 'spec' (lines '811'-'869'). +src/net/sf/freecol/common/model/Monarch.java:812: Local variable 'support' could be declared final +src/net/sf/freecol/common/model/Monarch.java:819: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:829: Local variable 'difficulty' could be declared final +src/net/sf/freecol/common/model/Monarch.java:829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:836: The String literal "Choose mounted" appears 4 times in this file; the first occurrence is on line 836 +src/net/sf/freecol/common/model/Monarch.java:878: Found 'UR'-anomaly for variable 'au' (lines '878'-'908'). +src/net/sf/freecol/common/model/Monarch.java:878: Found 'UR'-anomaly for variable 'au' (lines '878'-'918'). +src/net/sf/freecol/common/model/Monarch.java:878: Parameter 'enemy' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:878: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:878: The method 'getWarSupport' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/Monarch.java:879: Found 'DU'-anomaly for variable 'spec' (lines '879'-'934'). +src/net/sf/freecol/common/model/Monarch.java:884: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Monarch.java:896: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Monarch.java:897: Avoid variables with short names like p +src/net/sf/freecol/common/model/Monarch.java:897: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/Monarch.java:899: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:899: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:900: Local variable 'wsf' could be declared final +src/net/sf/freecol/common/model/Monarch.java:901: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:901: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:902: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Monarch.java:903: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:907: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/Monarch.java:908: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:909: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:911: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:913: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Monarch.java:914: Avoid using while statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:914: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:914: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:915: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:915: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:917: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/Monarch.java:918: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:919: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:923: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:929: There is log block not surrounded by if +src/net/sf/freecol/common/model/Monarch.java:942: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:942: The method 'getMercenaries' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/Monarch.java:942: The method getMercenaries() has an NPath complexity of 364 +src/net/sf/freecol/common/model/Monarch.java:946: Found 'DU'-anomaly for variable 'defaultRole' (lines '946'-'990'). +src/net/sf/freecol/common/model/Monarch.java:946: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:947: Found 'DU'-anomaly for variable 'mercPrice' (lines '947'-'990'). +src/net/sf/freecol/common/model/Monarch.java:947: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:948: Local variable 'landRoles' could be declared final +src/net/sf/freecol/common/model/Monarch.java:949: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:950: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:953: Local variable 'mercs' could be declared final +src/net/sf/freecol/common/model/Monarch.java:955: Found 'DU'-anomaly for variable 'price' (lines '955'-'990'). +src/net/sf/freecol/common/model/Monarch.java:956: Found 'DD'-anomaly for variable 'unitType' (lines '956'-'959'). +src/net/sf/freecol/common/model/Monarch.java:957: Local variable 'unitTypes' could be declared final +src/net/sf/freecol/common/model/Monarch.java:958: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:961: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:962: Local variable 'role' could be declared final +src/net/sf/freecol/common/model/Monarch.java:962: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:962: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:962: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:962: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:966: Avoid variables with short names like n +src/net/sf/freecol/common/model/Monarch.java:968: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Monarch.java:968: Avoid variables with short names like au +src/net/sf/freecol/common/model/Monarch.java:968: Found 'DD'-anomaly for variable 'au' (lines '968'-'968'). +src/net/sf/freecol/common/model/Monarch.java:968: Found 'DU'-anomaly for variable 'au' (lines '968'-'990'). +src/net/sf/freecol/common/model/Monarch.java:968: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/Monarch.java:968: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:970: Local variable 'newPrice' could be declared final +src/net/sf/freecol/common/model/Monarch.java:972: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:977: Avoid assignments in operands +src/net/sf/freecol/common/model/Monarch.java:977: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:980: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:984: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:985: Avoid variables with short names like r +src/net/sf/freecol/common/model/Monarch.java:985: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/Monarch.java:985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:985: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:985: Useless parentheses. +src/net/sf/freecol/common/model/Monarch.java:987: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:1010: Found 'UR'-anomaly for variable 'au' (lines '1,010'-'1,041'). +src/net/sf/freecol/common/model/Monarch.java:1010: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:1011: Found 'DD'-anomaly for variable 'result' (lines '1,011'-'1,023'). +src/net/sf/freecol/common/model/Monarch.java:1011: Found 'DD'-anomaly for variable 'result' (lines '1,011'-'1,033'). +src/net/sf/freecol/common/model/Monarch.java:1011: Found 'DU'-anomaly for variable 'result' (lines '1,011'-'1,044'). +src/net/sf/freecol/common/model/Monarch.java:1014: Found 'DU'-anomaly for variable 'todo' (lines '1,014'-'1,044'). +src/net/sf/freecol/common/model/Monarch.java:1014: Local variable 'todo' could be declared final +src/net/sf/freecol/common/model/Monarch.java:1015: Local variable 'ref' could be declared final +src/net/sf/freecol/common/model/Monarch.java:1016: Avoid variables with short names like it +src/net/sf/freecol/common/model/Monarch.java:1016: Local variable 'it' could be declared final +src/net/sf/freecol/common/model/Monarch.java:1016: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1016: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:1019: Avoid variables with short names like au +src/net/sf/freecol/common/model/Monarch.java:1019: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/Monarch.java:1023: Found 'DD'-anomaly for variable 'result' (lines '1,023'-'1,023'). +src/net/sf/freecol/common/model/Monarch.java:1023: Found 'DD'-anomaly for variable 'result' (lines '1,023'-'1,033'). +src/net/sf/freecol/common/model/Monarch.java:1023: Found 'DU'-anomaly for variable 'result' (lines '1,023'-'1,044'). +src/net/sf/freecol/common/model/Monarch.java:1025: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:1027: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:1033: Found 'DD'-anomaly for variable 'result' (lines '1,033'-'1,023'). +src/net/sf/freecol/common/model/Monarch.java:1033: Found 'DD'-anomaly for variable 'result' (lines '1,033'-'1,033'). +src/net/sf/freecol/common/model/Monarch.java:1033: Found 'DU'-anomaly for variable 'result' (lines '1,033'-'1,044'). +src/net/sf/freecol/common/model/Monarch.java:1035: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:1037: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Monarch.java:1041: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:1041: Local variable 'au' could be declared final +src/net/sf/freecol/common/model/Monarch.java:1041: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Monarch.java:1049: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:1049: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:1050: Avoid excessively long variable names like EXPEDITIONARY_FORCE_TAG +src/net/sf/freecol/common/model/Monarch.java:1050: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:1050: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:1051: Avoid excessively long variable names like INTERVENTION_FORCE_TAG +src/net/sf/freecol/common/model/Monarch.java:1051: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:1051: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:1052: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:1052: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:1053: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:1053: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:1055: Avoid unused private fields such as 'NAME_TAG'. +src/net/sf/freecol/common/model/Monarch.java:1055: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:1055: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:1058: Avoid excessively long variable names like MERCENARY_FORCE_TAG +src/net/sf/freecol/common/model/Monarch.java:1058: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Monarch.java:1058: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Monarch.java:1066: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Monarch.java:1066: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:1069: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1071: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1083: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Monarch.java:1083: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:1086: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1088: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1090: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1098: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Monarch.java:1098: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:1113: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Monarch.java:1113: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:1115: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:1116: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Monarch.java:1125: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Monarch.java:1125: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Monarch.java:1138: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Monarch.java:1139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1141: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Monarch.java:1141: Local variable 'newUnit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:1142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1154: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Monarch.java:1155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Monarch.java:1157: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Monarch.java:1157: Local variable 'newUnit' could be declared final +src/net/sf/freecol/common/model/Monarch.java:1158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Movable.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Movable.java:34: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Movable.java:43: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Nameable.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Nameable.java:33: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Nameable.java:40: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Named.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Named.java:36: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Nation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Nation.java:47: Avoid excessively long variable names like UNKNOWN_NATION_COLOR +src/net/sf/freecol/common/model/Nation.java:53: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/Nation.java:53: Variables that are final and static should be all capitals, 'defaultColors' is not all capitals. +src/net/sf/freecol/common/model/Nation.java:87: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:96: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:99: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:99: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Nation.java:102: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:102: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Nation.java:105: Avoid using redundant field initializer for 'preferredLatitude' +src/net/sf/freecol/common/model/Nation.java:105: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:105: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Nation.java:108: Field startsOnEastCoast has the same name as a method +src/net/sf/freecol/common/model/Nation.java:108: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:108: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Nation.java:111: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:120: Avoid variables with short names like id +src/net/sf/freecol/common/model/Nation.java:120: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:120: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:148: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Nation.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Nation.java:177: Avoid variables with short names like n +src/net/sf/freecol/common/model/Nation.java:231: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:243: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/Nation.java:255: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:256: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:257: Local variable 'nations' could be declared final +src/net/sf/freecol/common/model/Nation.java:258: Found 'DU'-anomaly for variable 'start' (lines '258'-'268'). +src/net/sf/freecol/common/model/Nation.java:258: Local variable 'start' could be declared final +src/net/sf/freecol/common/model/Nation.java:260: Local variable 'nationId' could be declared final +src/net/sf/freecol/common/model/Nation.java:263: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Nation.java:272: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:272: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:273: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:273: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:274: Avoid excessively long variable names like PREFERRED_LATITUDE_TAG +src/net/sf/freecol/common/model/Nation.java:274: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:274: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:275: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:275: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:276: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:276: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:277: Avoid excessively long variable names like STARTS_ON_EAST_COAST_TAG +src/net/sf/freecol/common/model/Nation.java:277: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:277: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:279: Avoid excessively long variable names like OLD_PREFERRED_LATITUDE_TAG +src/net/sf/freecol/common/model/Nation.java:279: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:279: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:280: Avoid excessively long variable names like OLD_STARTS_ON_EAST_COAST_TAG +src/net/sf/freecol/common/model/Nation.java:280: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Nation.java:280: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Nation.java:288: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Nation.java:288: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:299: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Nation.java:301: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Nation.java:308: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Nation.java:308: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Nation.java:323: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Nation.java:330: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Nation.java:334: Local variable 'rgb' could be declared final +src/net/sf/freecol/common/model/Nation.java:335: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/NationOptions.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/NationOptions.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/NationOptions.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:58: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:59: The String literal "model." appears 4 times in this file; the first occurrence is on line 59 +src/net/sf/freecol/common/model/NationOptions.java:91: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:107: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationOptions.java:110: Avoid excessively long variable names like nationalAdvantages +src/net/sf/freecol/common/model/NationOptions.java:110: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationOptions.java:113: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/NationOptions.java:121: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/NationOptions.java:121: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:125: Local variable 'maxEuropeans' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:125: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/NationOptions.java:126: Local variable 'nation' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:151: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationOptions.java:151: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:152: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:183: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:202: Avoid excessively long variable names like NATIONAL_ADVANTAGES_TAG +src/net/sf/freecol/common/model/NationOptions.java:202: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationOptions.java:202: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:203: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationOptions.java:203: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:204: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationOptions.java:204: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:206: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationOptions.java:206: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:207: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationOptions.java:207: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationOptions.java:215: Avoid variables with short names like xw +src/net/sf/freecol/common/model/NationOptions.java:215: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:226: Avoid variables with short names like xw +src/net/sf/freecol/common/model/NationOptions.java:226: Found 'UR'-anomaly for variable 'nation' (lines '226'-'232'). +src/net/sf/freecol/common/model/NationOptions.java:226: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:229: Local variable 'nation' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:244: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationOptions.java:244: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:256: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationOptions.java:256: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:271: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationOptions.java:271: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:273: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/NationOptions.java:276: There is log block not surrounded by if +src/net/sf/freecol/common/model/NationOptions.java:285: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationOptions.java:285: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationOptions.java:289: Local variable 'nation' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:290: Local variable 'state' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:302: Local variable 'nation' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:303: Local variable 'state' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:326: Found 'UR'-anomaly for variable 'entry' (lines '326'-'331'). +src/net/sf/freecol/common/model/NationOptions.java:327: Avoid variables with short names like sb +src/net/sf/freecol/common/model/NationOptions.java:327: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:329: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/NationOptions.java:330: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/NationOptions.java:331: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/NationOptions.java:331: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/NationOptions.java:332: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/NationOptions.java:333: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/NationSummary.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/NationSummary.java:26: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/NationSummary.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:40: Avoid excessively long variable names like numberOfSettlements +src/net/sf/freecol/common/model/NationSummary.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationSummary.java:70: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/NationSummary.java:70: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationSummary.java:70: Parameter 'requester' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationSummary.java:74: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/NationSummary.java:83: Use equals() to compare object references. +src/net/sf/freecol/common/model/NationSummary.java:102: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/NationSummary.java:102: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationSummary.java:108: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:112: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:116: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:120: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:124: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:128: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:132: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:136: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:140: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:147: Avoid excessively long variable names like FOUNDING_FATHERS_TAG +src/net/sf/freecol/common/model/NationSummary.java:147: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:147: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:148: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:148: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:149: Avoid excessively long variable names like MILITARY_STRENGTH_TAG +src/net/sf/freecol/common/model/NationSummary.java:149: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:149: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:150: Avoid excessively long variable names like NAVAL_STRENGTH_TAG +src/net/sf/freecol/common/model/NationSummary.java:150: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:150: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:151: Avoid excessively long variable names like NUMBER_OF_SETTLEMENTS_TAG +src/net/sf/freecol/common/model/NationSummary.java:151: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:151: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:152: Avoid excessively long variable names like NUMBER_OF_UNITS_TAG +src/net/sf/freecol/common/model/NationSummary.java:152: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:152: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:153: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:153: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:154: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:154: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:155: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationSummary.java:155: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationSummary.java:162: Avoid variables with short names like xw +src/net/sf/freecol/common/model/NationSummary.java:162: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationSummary.java:194: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationSummary.java:194: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/NationType.java:37: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/NationType.java:39: enumCommentRequirement Required +src/net/sf/freecol/common/model/NationType.java:52: enumCommentRequirement Required +src/net/sf/freecol/common/model/NationType.java:67: Avoid excessively long variable names like numberOfSettlements +src/net/sf/freecol/common/model/NationType.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationType.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationType.java:73: Avoid using redundant field initializer for 'settlementTypes' +src/net/sf/freecol/common/model/NationType.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/NationType.java:82: Avoid variables with short names like id +src/net/sf/freecol/common/model/NationType.java:82: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:82: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/NationType.java:103: Parameter 'settlementType' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:104: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/NationType.java:113: Parameter 'types' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:114: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/NationType.java:133: Parameter 'isCapital' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:134: Avoid variables with short names like s +src/net/sf/freecol/common/model/NationType.java:143: Avoid variables with short names like id +src/net/sf/freecol/common/model/NationType.java:143: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:144: Avoid variables with short names like s +src/net/sf/freecol/common/model/NationType.java:189: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationType.java:189: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationType.java:190: Avoid excessively long variable names like NUMBER_OF_SETTLEMENTS_TAG +src/net/sf/freecol/common/model/NationType.java:190: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationType.java:190: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationType.java:191: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/NationType.java:191: fieldCommentRequirement Required +src/net/sf/freecol/common/model/NationType.java:198: Avoid variables with short names like xw +src/net/sf/freecol/common/model/NationType.java:198: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:210: Avoid variables with short names like xw +src/net/sf/freecol/common/model/NationType.java:210: Found 'UR'-anomaly for variable 'settlementType' (lines '210'-'214'). +src/net/sf/freecol/common/model/NationType.java:210: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:213: Local variable 'settlementType' could be declared final +src/net/sf/freecol/common/model/NationType.java:222: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationType.java:222: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:227: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/NationType.java:241: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationType.java:241: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:244: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/NationType.java:248: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/NationType.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/NationType.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/NationType.java:268: Avoid variables with short names like xr +src/net/sf/freecol/common/model/NationType.java:268: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/NationType.java:269: Found 'DU'-anomaly for variable 'spec' (lines '269'-'278'). +src/net/sf/freecol/common/model/Occupation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Occupation.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Occupation.java:34: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Occupation.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Occupation.java:35: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Occupation.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Occupation.java:36: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Occupation.java:39: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Occupation.java:48: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:49: Parameter 'productionType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:50: Parameter 'workType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:62: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:63: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Occupation.java:63: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Occupation.java:73: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Occupation.java:87: Avoid reassigning parameters such as 'bestAmount' +src/net/sf/freecol/common/model/Occupation.java:87: Avoid variables with short names like wl +src/net/sf/freecol/common/model/Occupation.java:87: Found 'UR'-anomaly for variable 'ag' (lines '87'-'108'). +src/net/sf/freecol/common/model/Occupation.java:87: Found 'UR'-anomaly for variable 'gt' (lines '87'-'104'). +src/net/sf/freecol/common/model/Occupation.java:87: Found 'UR'-anomaly for variable 'pt' (lines '87'-'101'). +src/net/sf/freecol/common/model/Occupation.java:87: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:87: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:88: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Occupation.java:88: Parameter 'alone' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:88: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:88: Parameter 'workTypes' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:91: Local variable 'productionTypes' could be declared final +src/net/sf/freecol/common/model/Occupation.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:100: Local variable 'pt' could be declared final +src/net/sf/freecol/common/model/Occupation.java:103: Local variable 'gt' could be declared final +src/net/sf/freecol/common/model/Occupation.java:104: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Occupation.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:105: Found 'DD'-anomaly for variable 'minInput' (lines '105'-'110'). +src/net/sf/freecol/common/model/Occupation.java:106: Local variable 'inputs' could be declared final +src/net/sf/freecol/common/model/Occupation.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:107: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/Occupation.java:108: Local variable 'input' could be declared final +src/net/sf/freecol/common/model/Occupation.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:112: Local variable 'potential' could be declared final +src/net/sf/freecol/common/model/Occupation.java:113: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/Occupation.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Occupation.java:115: Useless parentheses. +src/net/sf/freecol/common/model/Occupation.java:115: Useless parentheses. +src/net/sf/freecol/common/model/Occupation.java:128: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Occupation.java:140: Avoid variables with short names like wl +src/net/sf/freecol/common/model/Occupation.java:140: Parameter 'bestAmount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:140: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:140: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:141: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Occupation.java:141: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:141: Parameter 'workTypes' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:143: Local variable 'present' could be declared final +src/net/sf/freecol/common/model/Occupation.java:145: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Occupation.java:145: Useless parentheses. +src/net/sf/freecol/common/model/Occupation.java:145: Useless parentheses. +src/net/sf/freecol/common/model/Occupation.java:146: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Occupation.java:146: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Occupation.java:152: Local variable 'alone' could be declared final +src/net/sf/freecol/common/model/Occupation.java:154: Useless parentheses. +src/net/sf/freecol/common/model/Occupation.java:154: Useless parentheses. +src/net/sf/freecol/common/model/Occupation.java:158: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Occupation.java:170: Avoid variables with short names like wl +src/net/sf/freecol/common/model/Occupation.java:170: Parameter 'bestAmount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:170: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:170: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:171: Avoid variables with short names like lb +src/net/sf/freecol/common/model/Occupation.java:171: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:171: Parameter 'workTypes' is not assigned and could be declared final +src/net/sf/freecol/common/model/Occupation.java:181: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Occupation.java:181: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Occupation.java:184: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Occupation.java:184: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Occupation.java:185: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Operand.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Operand.java:33: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Operand.java:47: The class 'Operand' has a Cyclomatic Complexity of 3 (Highest = 12). +src/net/sf/freecol/common/model/Operand.java:47: The class 'Operand' has a Standard Cyclomatic Complexity of 3 (Highest = 12). +src/net/sf/freecol/common/model/Operand.java:49: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/Operand.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Operand.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Operand.java:51: enumCommentRequirement Required +src/net/sf/freecol/common/model/Operand.java:55: enumCommentRequirement Required +src/net/sf/freecol/common/model/Operand.java:66: Avoid using redundant field initializer for 'value' +src/net/sf/freecol/common/model/Operand.java:72: Document empty constructor +src/net/sf/freecol/common/model/Operand.java:72: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Operand.java:79: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Operand.java:79: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:89: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Operand.java:89: Parameter 'operandType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:89: Parameter 'scopeLevel' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:100: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Operand.java:100: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Operand.java:100: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:165: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:166: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Operand.java:168: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Operand.java:177: Found 'UR'-anomaly for variable 'colony' (lines '177'-'195'). +src/net/sf/freecol/common/model/Operand.java:177: Found 'UR'-anomaly for variable 'player' (lines '177'-'191'). +src/net/sf/freecol/common/model/Operand.java:177: Found 'UR'-anomaly for variable 'player' (lines '177'-'194'). +src/net/sf/freecol/common/model/Operand.java:177: Found 'UR'-anomaly for variable 'player' (lines '177'-'199'). +src/net/sf/freecol/common/model/Operand.java:177: Found 'UR'-anomaly for variable 'player' (lines '177'-'202'). +src/net/sf/freecol/common/model/Operand.java:177: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:177: The method 'calculateGameValue' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/Operand.java:177: The method 'calculateGameValue' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/Operand.java:178: Found 'DU'-anomaly for variable 'methodName' (lines '178'-'210'). +src/net/sf/freecol/common/model/Operand.java:181: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:183: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:185: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:187: Found 'DU'-anomaly for variable 'list' (lines '187'-'210'). +src/net/sf/freecol/common/model/Operand.java:187: Local variable 'list' could be declared final +src/net/sf/freecol/common/model/Operand.java:188: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Operand.java:194: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Operand.java:205: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:218: Found 'UR'-anomaly for variable 'colony' (lines '218'-'237'). +src/net/sf/freecol/common/model/Operand.java:218: Found 'UR'-anomaly for variable 'settlement' (lines '218'-'248'). +src/net/sf/freecol/common/model/Operand.java:218: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:218: The method 'getValue' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/Operand.java:218: The method 'getValue' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/Operand.java:219: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:219: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Operand.java:222: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:226: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:229: Found 'DU'-anomaly for variable 'spec' (lines '229'-'261'). +src/net/sf/freecol/common/model/Operand.java:230: Found 'DU'-anomaly for variable 'methodName' (lines '230'-'261'). +src/net/sf/freecol/common/model/Operand.java:231: Found 'DU'-anomaly for variable 'list' (lines '231'-'261'). +src/net/sf/freecol/common/model/Operand.java:231: Local variable 'list' could be declared final +src/net/sf/freecol/common/model/Operand.java:234: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:236: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Operand.java:239: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:242: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Operand.java:245: Found 'DU'-anomaly for variable 'methodValue' (lines '245'-'261'). +src/net/sf/freecol/common/model/Operand.java:246: Found 'DD'-anomaly for variable 'result' (lines '246'-'250'). +src/net/sf/freecol/common/model/Operand.java:247: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/Operand.java:248: Avoid variables with short names like b +src/net/sf/freecol/common/model/Operand.java:248: Local variable 'b' could be declared final +src/net/sf/freecol/common/model/Operand.java:250: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Operand.java:250: Found 'DD'-anomaly for variable 'result' (lines '250'-'250'). +src/net/sf/freecol/common/model/Operand.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:252: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:256: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:269: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:273: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Operand.java:274: Found 'DU'-anomaly for variable 'list' (lines '274'-'295'). +src/net/sf/freecol/common/model/Operand.java:274: Local variable 'list' could be declared final +src/net/sf/freecol/common/model/Operand.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Operand.java:280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Operand.java:283: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Operand.java:286: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:290: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:304: Found 'UR'-anomaly for variable 'object' (lines '304'-'307'). +src/net/sf/freecol/common/model/Operand.java:304: Parameter 'objects' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:305: Found 'DD'-anomaly for variable 'result' (lines '305'-'308'). +src/net/sf/freecol/common/model/Operand.java:306: Local variable 'object' could be declared final +src/net/sf/freecol/common/model/Operand.java:308: Found 'DD'-anomaly for variable 'result' (lines '308'-'308'). +src/net/sf/freecol/common/model/Operand.java:321: Avoid variables with short names like o +src/net/sf/freecol/common/model/Operand.java:321: Ensure you override both equals() and hashCode() +src/net/sf/freecol/common/model/Operand.java:321: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:323: Useless parentheses. +src/net/sf/freecol/common/model/Operand.java:323: Useless parentheses. +src/net/sf/freecol/common/model/Operand.java:326: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Operand.java:333: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Operand.java:333: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Operand.java:334: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Operand.java:334: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Operand.java:336: Avoid excessively long variable names like OLD_OPERAND_TYPE_TAG +src/net/sf/freecol/common/model/Operand.java:336: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Operand.java:336: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Operand.java:337: Avoid excessively long variable names like OLD_SCOPE_LEVEL_TAG +src/net/sf/freecol/common/model/Operand.java:337: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Operand.java:337: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Operand.java:345: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Operand.java:345: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:361: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Operand.java:361: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Operand.java:370: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Operand.java:379: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Operand.java:382: Local variable 'val' could be declared final +src/net/sf/freecol/common/model/Operand.java:383: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Operand.java:391: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Operand.java:391: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Operand.java:392: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Operand.java:392: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Operand.java:392: StringBuffer constructor is initialized with size 16, but has at least 26 characters appended. +src/net/sf/freecol/common/model/Ownable.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Ownable.java:35: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Ownable.java:44: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Ownable.java:44: Avoid variables with short names like p +src/net/sf/freecol/common/model/PathNode.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/PathNode.java:23: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/PathNode.java:55: Avoid using redundant field initializer for 'onCarrier' +src/net/sf/freecol/common/model/PathNode.java:58: Avoid using redundant field initializer for 'next' +src/net/sf/freecol/common/model/PathNode.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PathNode.java:61: Avoid using redundant field initializer for 'previous' +src/net/sf/freecol/common/model/PathNode.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PathNode.java:64: Comment is too large: Too many lines +src/net/sf/freecol/common/model/PathNode.java:78: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:78: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:78: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:79: Parameter 'next' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:79: Parameter 'onCarrier' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:79: Parameter 'previous' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:105: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/PathNode.java:123: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:145: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:154: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:179: Parameter 'onCarrier' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:189: Avoid variables with short names like n +src/net/sf/freecol/common/model/PathNode.java:189: Found 'DD'-anomaly for variable 'n' (lines '189'-'190'). +src/net/sf/freecol/common/model/PathNode.java:190: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:190: Found 'DD'-anomaly for variable 'n' (lines '190'-'190'). +src/net/sf/freecol/common/model/PathNode.java:203: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:205: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/PathNode.java:206: Local variable 'prev' could be declared final +src/net/sf/freecol/common/model/PathNode.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PathNode.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:217: Avoid variables with short names like p +src/net/sf/freecol/common/model/PathNode.java:218: Avoid using while statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:229: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:240: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:251: Local variable 'path' could be declared final +src/net/sf/freecol/common/model/PathNode.java:252: Avoid variables with short names like n +src/net/sf/freecol/common/model/PathNode.java:252: Found 'DD'-anomaly for variable 'n' (lines '252'-'253'). +src/net/sf/freecol/common/model/PathNode.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:253: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PathNode.java:268: Comment is too large: Too many lines +src/net/sf/freecol/common/model/PathNode.java:279: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:279: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:280: Useless parentheses. +src/net/sf/freecol/common/model/PathNode.java:280: Useless parentheses. +src/net/sf/freecol/common/model/PathNode.java:302: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/PathNode.java:302: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:313: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PathNode.java:322: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/PathNode.java:324: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/PathNode.java:324: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:325: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/PathNode.java:325: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:336: Avoid variables with short names like p +src/net/sf/freecol/common/model/PathNode.java:348: Avoid variables with short names like p +src/net/sf/freecol/common/model/PathNode.java:348: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/PathNode.java:360: Avoid variables with short names like lb +src/net/sf/freecol/common/model/PathNode.java:360: Local variable 'lb' could be declared final +src/net/sf/freecol/common/model/PathNode.java:373: Avoid variables with short names like lb +src/net/sf/freecol/common/model/PathNode.java:373: Local variable 'lb' could be declared final +src/net/sf/freecol/common/model/PathNode.java:374: Avoid variables with short names like p +src/net/sf/freecol/common/model/PathNode.java:375: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/PathNode.java:375: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PathNode.java:376: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:20: High amount of different objects as members denotes a high coupling +src/net/sf/freecol/common/model/Player.java:20: Possible God class (WMC=588, ATFD=356, TCC=0.013570043873074176) +src/net/sf/freecol/common/model/Player.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/model/Player.java:63: Avoid really long classes. +src/net/sf/freecol/common/model/Player.java:63: The class 'Player' has a Cyclomatic Complexity of 2 (Highest = 60). +src/net/sf/freecol/common/model/Player.java:63: The class 'Player' has a Modified Cyclomatic Complexity of 2 (Highest = 45). +src/net/sf/freecol/common/model/Player.java:63: The class 'Player' has a Standard Cyclomatic Complexity of 2 (Highest = 50). +src/net/sf/freecol/common/model/Player.java:63: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/Player.java:63: Too many fields +src/net/sf/freecol/common/model/Player.java:65: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Player.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:91: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:100: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:102: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:105: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:107: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:109: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:111: Avoid variables with short names like i +src/net/sf/freecol/common/model/Player.java:111: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:111: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:112: Avoid variables with short names like n +src/net/sf/freecol/common/model/Player.java:112: Local variable 'n' could be declared final +src/net/sf/freecol/common/model/Player.java:113: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:113: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:113: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:120: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/Player.java:120: Each class should declare at least one constructor +src/net/sf/freecol/common/model/Player.java:121: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:127: Each class should declare at least one constructor +src/net/sf/freecol/common/model/Player.java:136: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:147: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:147: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:148: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:148: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:158: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Player.java:158: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:158: Parameter 'tradeRoute' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:169: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:179: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:179: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:180: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:180: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:189: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:189: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:191: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:191: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:193: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:193: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:204: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:204: Parameter 'predicate' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:218: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:228: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:230: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:230: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:230: Found 'DU'-anomaly for variable 'first' (lines '230'-'242'). +src/net/sf/freecol/common/model/Player.java:230: Local variable 'first' could be declared final +src/net/sf/freecol/common/model/Player.java:230: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:230: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:232: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:232: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:237: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:237: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:250: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:250: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:272: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:287: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:287: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:287: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:305: Variables that are final and static should be all capitals, 'playerComparator' is not all capitals. +src/net/sf/freecol/common/model/Player.java:308: Parameter 'player1' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:308: Parameter 'player2' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:308: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:312: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:313: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:314: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:315: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:316: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:317: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:324: Avoid excessively long variable names like GOLD_NOT_ACCOUNTED +src/net/sf/freecol/common/model/Player.java:324: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:330: Avoid excessively long variable names like ASSIGN_SETTLEMENT_NAME +src/net/sf/freecol/common/model/Player.java:330: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:342: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:345: Avoid excessively long variable names like independentNationName +src/net/sf/freecol/common/model/Player.java:345: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:348: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:351: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:354: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:354: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:357: Avoid using redundant field initializer for 'newLandName' +src/net/sf/freecol/common/model/Player.java:357: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:360: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:360: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:363: Avoid variables with short names like ai +src/net/sf/freecol/common/model/Player.java:363: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:363: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:366: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:369: Avoid using redundant field initializer for 'dead' +src/net/sf/freecol/common/model/Player.java:369: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:372: Avoid excessively long variable names like attackedByPrivateers +src/net/sf/freecol/common/model/Player.java:372: Avoid using redundant field initializer for 'attackedByPrivateers' +src/net/sf/freecol/common/model/Player.java:372: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:378: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:381: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:384: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:391: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:397: Avoid excessively long variable names like immigrationRequired +src/net/sf/freecol/common/model/Player.java:397: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:404: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:407: Avoid using redundant field initializer for 'oldSoL' +src/net/sf/freecol/common/model/Player.java:407: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:407: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:410: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:410: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:413: Avoid using redundant field initializer for 'tax' +src/net/sf/freecol/common/model/Player.java:413: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:416: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:419: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:419: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:422: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:425: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:428: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:428: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:431: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:433: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:441: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:444: Avoid using redundant field initializer for 'bannedMissions' +src/net/sf/freecol/common/model/Player.java:444: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:444: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:450: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:453: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:456: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:459: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:462: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/model/Player.java:462: Avoid using redundant field initializer for 'lastSales' +src/net/sf/freecol/common/model/Player.java:462: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:462: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:467: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:470: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:473: Avoid using redundant field initializer for 'canSeeTiles' +src/net/sf/freecol/common/model/Player.java:473: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:473: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:475: Avoid using redundant field initializer for 'canSeeValid' +src/net/sf/freecol/common/model/Player.java:475: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:475: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:477: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:477: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:480: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:483: Avoid excessively long variable names like maximumFoodConsumption +src/net/sf/freecol/common/model/Player.java:483: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:483: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:486: Avoid excessively long variable names like nextActiveUnitIterator +src/net/sf/freecol/common/model/Player.java:486: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:486: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:490: Avoid excessively long variable names like nextGoingToUnitIterator +src/net/sf/freecol/common/model/Player.java:490: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:490: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:494: Avoid excessively long variable names like nextTradeRouteUnitIterator +src/net/sf/freecol/common/model/Player.java:494: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:494: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:501: Avoid using redundant field initializer for 'highSeas' +src/net/sf/freecol/common/model/Player.java:501: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:501: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:504: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:504: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Player.java:517: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:529: Avoid variables with short names like e +src/net/sf/freecol/common/model/Player.java:529: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:529: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:535: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:544: Avoid variables with short names like id +src/net/sf/freecol/common/model/Player.java:544: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:544: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:569: Parameter 'newName' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:579: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:579: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:579: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:579: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:592: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:609: Avoid excessively long variable names like newIndependentNationName +src/net/sf/freecol/common/model/Player.java:637: Parameter 'newLandName' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:656: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:665: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:674: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:674: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:686: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:686: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:689: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:699: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:709: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:719: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:759: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:769: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:778: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:788: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:799: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:799: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:823: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:827: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:836: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:917: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:921: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:935: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:938: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:959: Parameter 'newNationType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:968: Parameter 'newNationType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:969: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:971: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1007: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1015: Parameter 'newNation' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1016: Local variable 'oldNation' could be declared final +src/net/sf/freecol/common/model/Player.java:1018: Local variable 'nations' could be declared final +src/net/sf/freecol/common/model/Player.java:1019: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1019: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1020: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1021: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1047: Avoid variables with short names like ai +src/net/sf/freecol/common/model/Player.java:1047: Parameter 'ai' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1065: Parameter 'ready' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1086: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Player.java:1096: Parameter 'dead' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1105: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Player.java:1114: Parameter 'attacked' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1125: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1125: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1137: Avoid variables with short names like p +src/net/sf/freecol/common/model/Player.java:1150: Local variable 'ref' could be declared final +src/net/sf/freecol/common/model/Player.java:1150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1151: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:1151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1161: Local variable 'color' could be declared final +src/net/sf/freecol/common/model/Player.java:1161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1162: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:1162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1184: Parameter 'score' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1215: Parameter 'newGold' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1227: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1238: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1249: There is log block not surrounded by if +src/net/sf/freecol/common/model/Player.java:1264: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Player.java:1289: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1289: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1297: Parameter 'immigration' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1298: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1306: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1308: Local variable 'cost' could be declared final +src/net/sf/freecol/common/model/Player.java:1308: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1323: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1343: Avoid excessively long variable names like immigrationRequired +src/net/sf/freecol/common/model/Player.java:1343: Parameter 'immigrationRequired' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1352: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1355: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1357: Local variable 'base' could be declared final +src/net/sf/freecol/common/model/Player.java:1357: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1361: Local variable 'unreduced' could be declared final +src/net/sf/freecol/common/model/Player.java:1364: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Player.java:1364: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Player.java:1365: There is log block not surrounded by if +src/net/sf/freecol/common/model/Player.java:1375: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1375: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1385: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:1385: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1387: Avoid excessively long variable names like immigrationGoodsTypes +src/net/sf/freecol/common/model/Player.java:1387: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1390: Avoid variables with short names like c +src/net/sf/freecol/common/model/Player.java:1390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1391: Avoid variables with short names like gt +src/net/sf/freecol/common/model/Player.java:1394: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1404: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1424: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1424: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1432: Parameter 'liberty' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1433: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1442: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1444: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1452: Found 'UR'-anomaly for variable 'ability' (lines '1,452'-'1,456'). +src/net/sf/freecol/common/model/Player.java:1452: Found 'UR'-anomaly for variable 'modifier' (lines '1,452'-'1,459'). +src/net/sf/freecol/common/model/Player.java:1453: Found 'DU'-anomaly for variable 'libertyBonus' (lines '1,453'-'1,467'). +src/net/sf/freecol/common/model/Player.java:1453: Local variable 'libertyBonus' could be declared final +src/net/sf/freecol/common/model/Player.java:1454: Found 'DD'-anomaly for variable 'ret' (lines '1,454'-'1,461'). +src/net/sf/freecol/common/model/Player.java:1455: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/Player.java:1456: Local variable 'source' could be declared final +src/net/sf/freecol/common/model/Player.java:1456: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1458: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/Player.java:1459: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1459: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1461: Found 'DD'-anomaly for variable 'ret' (lines '1,461'-'1,461'). +src/net/sf/freecol/common/model/Player.java:1478: Local variable 'nextTurn' could be declared final +src/net/sf/freecol/common/model/Player.java:1478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1479: Avoid variables with short names like c +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1480: Avoid variables with short names like gt +src/net/sf/freecol/common/model/Player.java:1482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1493: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1493: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1493: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1493: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1494: Avoid variables with short names like c +src/net/sf/freecol/common/model/Player.java:1494: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1494: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1494: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1514: Parameter 'someFather' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1533: Found 'UR'-anomaly for variable 'colony' (lines '1,533'-'1,536'). +src/net/sf/freecol/common/model/Player.java:1533: Parameter 'father' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1536: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Player.java:1536: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Player.java:1539: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:1558: Parameter 'someFather' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1583: Parameter 'fathers' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1599: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:1610: Local variable 'base' could be declared final +src/net/sf/freecol/common/model/Player.java:1610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1611: Local variable 'count' could be declared final +src/net/sf/freecol/common/model/Player.java:1621: Found 'UR'-anomaly for variable 'e' (lines '1,621'-'1,624'). +src/net/sf/freecol/common/model/Player.java:1622: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Player.java:1623: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/Player.java:1625: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1625: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1639: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1640: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:1641: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1643: Avoid variables with short names like l +src/net/sf/freecol/common/model/Player.java:1643: Local variable 'limit' could be declared final +src/net/sf/freecol/common/model/Player.java:1643: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1644: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:1645: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1645: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1645: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1646: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1646: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1656: Parameter 'naval' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1657: Avoid variables with short names like cm +src/net/sf/freecol/common/model/Player.java:1657: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1659: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:1660: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:1660: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1669: Parameter 'naval' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1670: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:1670: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1671: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1671: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1672: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1672: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1694: Found 'UR'-anomaly for variable 'colony' (lines '1,694'-'1,697'). +src/net/sf/freecol/common/model/Player.java:1694: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1697: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Player.java:1697: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Player.java:1717: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:1726: Parameter 'what' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1726: Parameter 'where' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1727: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:1736: Parameter 'sale' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1737: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1748: Parameter 'what' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1748: Parameter 'where' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1749: Local variable 'data' could be declared final +src/net/sf/freecol/common/model/Player.java:1750: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:1750: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1759: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1760: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1769: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1780: Parameter 'access' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1780: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1781: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1782: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1782: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1782: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1782: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1783: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1783: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1783: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1784: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1784: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1784: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:1785: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1785: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1786: Avoid variables with short names like p +src/net/sf/freecol/common/model/Player.java:1796: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1797: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1806: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1806: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1807: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1816: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1817: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1820: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:1829: Found 'UR'-anomaly for variable 'colony' (lines '1,829'-'1,835'). +src/net/sf/freecol/common/model/Player.java:1829: Found 'UR'-anomaly for variable 'g' (lines '1,829'-'1,836'). +src/net/sf/freecol/common/model/Player.java:1830: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:1830: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1832: Found 'DD'-anomaly for variable 'goods' (lines '1,832'-'1,842'). +src/net/sf/freecol/common/model/Player.java:1833: Found 'DU'-anomaly for variable 'highValue' (lines '1,833'-'1,848'). +src/net/sf/freecol/common/model/Player.java:1834: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Player.java:1835: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/Player.java:1835: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1836: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1836: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1837: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/Player.java:1837: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1839: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/Player.java:1839: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1841: Found 'DU'-anomaly for variable 'highValue' (lines '1,841'-'1,848'). +src/net/sf/freecol/common/model/Player.java:1842: Found 'DD'-anomaly for variable 'goods' (lines '1,842'-'1,842'). +src/net/sf/freecol/common/model/Player.java:1856: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1857: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1866: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1866: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1867: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1876: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1877: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1886: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1886: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1887: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1910: Parameter 'europe' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1930: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1939: Avoid variables with short names like au +src/net/sf/freecol/common/model/Player.java:1939: Parameter 'au' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1942: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:1942: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:1942: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:1944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1945: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:1963: Parameter 'monarch' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:1978: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2001: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2002: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:2024: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2024: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2032: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2032: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2046: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2046: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2063: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2064: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2064: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2064: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2065: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:2075: Parameter 'naval' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2076: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2076: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2076: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2077: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:2087: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2087: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2087: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2088: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:2098: Parameter 'typeId' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2099: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:2099: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2099: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2099: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2099: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2117: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2145: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2199: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2200: Avoid variables with short names like t +src/net/sf/freecol/common/model/Player.java:2200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2227: Avoid variables with short names like o +src/net/sf/freecol/common/model/Player.java:2227: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2228: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2228: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2240: Avoid variables with short names like o +src/net/sf/freecol/common/model/Player.java:2240: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2241: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2241: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2274: Found 'UR'-anomaly for variable 'colony' (lines '2,274'-'2,278'). +src/net/sf/freecol/common/model/Player.java:2275: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2275: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2276: Avoid variables with short names like n +src/net/sf/freecol/common/model/Player.java:2276: Found 'DD'-anomaly for variable 'n' (lines '2,276'-'2,278'). +src/net/sf/freecol/common/model/Player.java:2277: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Player.java:2278: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2278: Found 'DD'-anomaly for variable 'n' (lines '2,278'-'2,278'). +src/net/sf/freecol/common/model/Player.java:2289: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:2289: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2289: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2290: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2303: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2313: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2314: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2314: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2318: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2318: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2329: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2340: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2340: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2340: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2341: Avoid variables with short names like c +src/net/sf/freecol/common/model/Player.java:2351: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2352: Avoid variables with short names like c +src/net/sf/freecol/common/model/Player.java:2352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2362: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2363: Avoid variables with short names like is +src/net/sf/freecol/common/model/Player.java:2363: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2363: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2363: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2372: Found 'UR'-anomaly for variable 's' (lines '2,372'-'2,375'). +src/net/sf/freecol/common/model/Player.java:2373: Found 'DU'-anomaly for variable 'colonies' (lines '2,373'-'2,382'). +src/net/sf/freecol/common/model/Player.java:2373: Local variable 'colonies' could be declared final +src/net/sf/freecol/common/model/Player.java:2374: Local variable 's' could be declared final +src/net/sf/freecol/common/model/Player.java:2378: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Player.java:2390: Avoid variables with short names like c +src/net/sf/freecol/common/model/Player.java:2390: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2391: Local variable 'colonies' could be declared final +src/net/sf/freecol/common/model/Player.java:2402: Found 'UR'-anomaly for variable 's' (lines '2,402'-'2,405'). +src/net/sf/freecol/common/model/Player.java:2403: Found 'DU'-anomaly for variable 'indianSettlements' (lines '2,403'-'2,412'). +src/net/sf/freecol/common/model/Player.java:2403: Local variable 'indianSettlements' could be declared final +src/net/sf/freecol/common/model/Player.java:2404: Local variable 's' could be declared final +src/net/sf/freecol/common/model/Player.java:2408: Avoid throwing raw exception types. +src/net/sf/freecol/common/model/Player.java:2420: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2421: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2421: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2430: Found 'UR'-anomaly for variable 'settlement' (lines '2,430'-'2,434'). +src/net/sf/freecol/common/model/Player.java:2431: Found 'DU'-anomaly for variable 'bestValue' (lines '2,431'-'2,441'). +src/net/sf/freecol/common/model/Player.java:2432: Found 'DD'-anomaly for variable 'best' (lines '2,432'-'2,437'). +src/net/sf/freecol/common/model/Player.java:2433: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/Player.java:2434: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/Player.java:2434: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2436: Found 'DU'-anomaly for variable 'bestValue' (lines '2,436'-'2,441'). +src/net/sf/freecol/common/model/Player.java:2437: Found 'DD'-anomaly for variable 'best' (lines '2,437'-'2,437'). +src/net/sf/freecol/common/model/Player.java:2468: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2468: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2469: Avoid variables with short names like m +src/net/sf/freecol/common/model/Player.java:2479: Parameter 'modelMessage' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2492: Parameter 'options' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2494: Local variable 'messageIterator' could be declared final +src/net/sf/freecol/common/model/Player.java:2496: Local variable 'message' could be declared final +src/net/sf/freecol/common/model/Player.java:2497: Avoid variables with short names like id +src/net/sf/freecol/common/model/Player.java:2497: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/Player.java:2497: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2497: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2498: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2508: Local variable 'messageIterator' could be declared final +src/net/sf/freecol/common/model/Player.java:2510: Local variable 'message' could be declared final +src/net/sf/freecol/common/model/Player.java:2511: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2511: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2525: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:2534: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2535: Parameter 'newSource' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2537: Local variable 'messageIterator' could be declared final +src/net/sf/freecol/common/model/Player.java:2539: Local variable 'message' could be declared final +src/net/sf/freecol/common/model/Player.java:2540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2555: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/Player.java:2555: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2556: Local variable 'sailTag' could be declared final +src/net/sf/freecol/common/model/Player.java:2557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2578: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2605: Parameter 'entryLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2618: Local variable 'settlements' could be declared final +src/net/sf/freecol/common/model/Player.java:2619: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:2619: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2619: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2619: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2619: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2620: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2621: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2639: Local variable 'game' could be declared final +src/net/sf/freecol/common/model/Player.java:2641: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2642: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2653: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2654: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2654: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2659: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2659: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2659: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2666: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:2713: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:2723: Local variable 'map' could be declared final +src/net/sf/freecol/common/model/Player.java:2723: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2724: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2724: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2726: Local variable 'cST' could be declared final +src/net/sf/freecol/common/model/Player.java:2740: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2744: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:2757: Found 'UR'-anomaly for variable 'colony' (lines '2,757'-'2,818'). +src/net/sf/freecol/common/model/Player.java:2757: Found 'UR'-anomaly for variable 'is' (lines '2,757'-'2,803'). +src/net/sf/freecol/common/model/Player.java:2757: Found 'UR'-anomaly for variable 'other' (lines '2,757'-'2,802'). +src/net/sf/freecol/common/model/Player.java:2757: Found 'UR'-anomaly for variable 'settlement' (lines '2,757'-'2,792'). +src/net/sf/freecol/common/model/Player.java:2757: Found 'UR'-anomaly for variable 't' (lines '2,757'-'2,765'). +src/net/sf/freecol/common/model/Player.java:2757: Found 'UR'-anomaly for variable 't' (lines '2,757'-'2,786'). +src/net/sf/freecol/common/model/Player.java:2757: Found 'UR'-anomaly for variable 'unit' (lines '2,757'-'2,781'). +src/net/sf/freecol/common/model/Player.java:2757: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2757: The method 'makeCanSeeTiles' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/common/model/Player.java:2757: The method 'makeCanSeeTiles' has a Modified Cyclomatic Complexity of 19. +src/net/sf/freecol/common/model/Player.java:2757: The method 'makeCanSeeTiles' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/common/model/Player.java:2757: The method makeCanSeeTiles() has an NPath complexity of 11520 +src/net/sf/freecol/common/model/Player.java:2761: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2762: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:2762: Found 'DD'-anomaly for variable 'cST' (lines '2,762'-'2,766'). +src/net/sf/freecol/common/model/Player.java:2764: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:2764: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2764: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2766: Found 'DD'-anomaly for variable 'cST' (lines '2,766'-'2,766'). +src/net/sf/freecol/common/model/Player.java:2766: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2766: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2766: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2766: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2769: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2776: Found 'DD'-anomaly for variable 'cST' (lines '2,776'-'2,786'). +src/net/sf/freecol/common/model/Player.java:2778: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Player.java:2781: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2781: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2781: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2784: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:2784: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2784: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2784: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2785: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2786: Found 'DD'-anomaly for variable 'cST' (lines '2,786'-'2,786'). +src/net/sf/freecol/common/model/Player.java:2786: Found 'DD'-anomaly for variable 'cST' (lines '2,786'-'2,794'). +src/net/sf/freecol/common/model/Player.java:2786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2786: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2786: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2787: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2791: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/Player.java:2792: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:2792: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2792: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2793: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2794: Found 'DD'-anomaly for variable 'cST' (lines '2,794'-'2,794'). +src/net/sf/freecol/common/model/Player.java:2794: Found 'DD'-anomaly for variable 'cST' (lines '2,794'-'2,808'). +src/net/sf/freecol/common/model/Player.java:2794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2800: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2801: Local variable 'other' could be declared final +src/net/sf/freecol/common/model/Player.java:2801: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2802: Local variable 'is' could be declared final +src/net/sf/freecol/common/model/Player.java:2802: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2803: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2806: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:2806: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2806: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2807: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2808: Found 'DD'-anomaly for variable 'cST' (lines '2,808'-'2,808'). +src/net/sf/freecol/common/model/Player.java:2808: Found 'DD'-anomaly for variable 'cST' (lines '2,808'-'2,820'). +src/net/sf/freecol/common/model/Player.java:2808: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2808: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2808: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2808: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2809: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2816: Local variable 'other' could be declared final +src/net/sf/freecol/common/model/Player.java:2816: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2817: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/Player.java:2817: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2818: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:2818: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2819: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2820: Found 'DD'-anomaly for variable 'cST' (lines '2,820'-'2,820'). +src/net/sf/freecol/common/model/Player.java:2820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2820: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2820: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2821: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:2840: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2841: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2856: Parameter 'newTension' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2856: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2857: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2867: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2868: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2877: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2886: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2887: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2896: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2897: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2906: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2907: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2907: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2912: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:2921: Parameter 'newStance' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2921: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2930: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2932: Local variable 'oldStance' could be declared final +src/net/sf/freecol/common/model/Player.java:2933: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:2933: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:2935: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Player.java:2935: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Player.java:2935: Found 'DD'-anomaly for variable 'valid' (lines '2,935'-'2,938'). +src/net/sf/freecol/common/model/Player.java:2936: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2936: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:2950: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2960: Avoid variables with short names like p +src/net/sf/freecol/common/model/Player.java:2960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2969: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:2979: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2979: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2980: Avoid variables with short names like p +src/net/sf/freecol/common/model/Player.java:2989: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2989: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:2990: Avoid variables with short names like p +src/net/sf/freecol/common/model/Player.java:3000: Parameter 'player1' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3000: Parameter 'player2' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3001: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3002: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3015: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3016: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3016: Found 'DU'-anomaly for variable 'spec' (lines '3,016'-'3,039'). +src/net/sf/freecol/common/model/Player.java:3017: Local variable 'nationOwner' could be declared final +src/net/sf/freecol/common/model/Player.java:3020: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3022: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3023: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3025: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3026: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3028: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3031: Local variable 'price' could be declared final +src/net/sf/freecol/common/model/Player.java:3031: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3032: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3032: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3034: Avoid variables with short names like gt +src/net/sf/freecol/common/model/Player.java:3034: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3035: Avoid variables with short names like gt +src/net/sf/freecol/common/model/Player.java:3037: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3037: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3047: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3057: Avoid variables with short names like ns +src/net/sf/freecol/common/model/Player.java:3057: Parameter 'ns' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3057: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3068: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3079: Parameter 'naval' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3079: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3080: Avoid variables with short names like ns +src/net/sf/freecol/common/model/Player.java:3080: Local variable 'ns' could be declared final +src/net/sf/freecol/common/model/Player.java:3081: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3081: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3082: Local variable 'strength' could be declared final +src/net/sf/freecol/common/model/Player.java:3083: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3093: Parameter 'ours' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3093: Parameter 'theirs' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3126: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3146: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3158: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3159: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3159: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3160: Avoid variables with short names like u +src/net/sf/freecol/common/model/Player.java:3163: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3163: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3166: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3166: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3177: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3181: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3194: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3196: Local variable 'reason' could be declared final +src/net/sf/freecol/common/model/Player.java:3197: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:3200: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3200: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3214: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3218: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3227: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3229: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:3229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3229: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3229: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3230: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:3232: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Player.java:3232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3244: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3245: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3246: Local variable 'build' could be declared final +src/net/sf/freecol/common/model/Player.java:3246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3249: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3250: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3251: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3251: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3251: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3251: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3253: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3253: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3253: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3260: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3272: Local variable 'settlements' could be declared final +src/net/sf/freecol/common/model/Player.java:3273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3274: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3274: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3278: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3289: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3290: Local variable 'owner' could be declared final +src/net/sf/freecol/common/model/Player.java:3302: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3307: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3318: Found 'UR'-anomaly for variable 'have' (lines '3,318'-'3,328'). +src/net/sf/freecol/common/model/Player.java:3318: Found 'UR'-anomaly for variable 'next' (lines '3,318'-'3,329'). +src/net/sf/freecol/common/model/Player.java:3318: Parameter 'centerTile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3318: Parameter 'radius' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3319: Local variable 'tiles' could be declared final +src/net/sf/freecol/common/model/Player.java:3320: Found 'DU'-anomaly for variable 'layer' (lines '3,320'-'3,339'). +src/net/sf/freecol/common/model/Player.java:3320: Local variable 'layer' could be declared final +src/net/sf/freecol/common/model/Player.java:3324: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Player.java:3324: Local variable 'lastLayer' could be declared final +src/net/sf/freecol/common/model/Player.java:3327: Local variable 'have' could be declared final +src/net/sf/freecol/common/model/Player.java:3328: Local variable 'next' could be declared final +src/net/sf/freecol/common/model/Player.java:3346: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3383: Comment is too large: Line too long +src/net/sf/freecol/common/model/Player.java:3423: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3432: Avoid really long methods. +src/net/sf/freecol/common/model/Player.java:3432: Found 'UR'-anomaly for variable 'ag' (lines '3,432'-'3,613'). +src/net/sf/freecol/common/model/Player.java:3432: Found 'UR'-anomaly for variable 'g' (lines '3,432'-'3,644'). +src/net/sf/freecol/common/model/Player.java:3432: Found 'UR'-anomaly for variable 'output' (lines '3,432'-'3,540'). +src/net/sf/freecol/common/model/Player.java:3432: Found 'UR'-anomaly for variable 'productionType' (lines '3,432'-'3,539'). +src/net/sf/freecol/common/model/Player.java:3432: Found 'UR'-anomaly for variable 't' (lines '3,432'-'3,586'). +src/net/sf/freecol/common/model/Player.java:3432: Found 'UR'-anomaly for variable 'u' (lines '3,432'-'3,631'). +src/net/sf/freecol/common/model/Player.java:3432: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3432: The method 'getAllColonyValues' has a Cyclomatic Complexity of 60. +src/net/sf/freecol/common/model/Player.java:3432: The method 'getAllColonyValues' has a Modified Cyclomatic Complexity of 45. +src/net/sf/freecol/common/model/Player.java:3432: The method 'getAllColonyValues' has a Standard Cyclomatic Complexity of 50. +src/net/sf/freecol/common/model/Player.java:3432: The method getAllColonyValues() has an NCSS line count of 173 +src/net/sf/freecol/common/model/Player.java:3434: Avoid excessively long variable names like LOW_SETTLEMENT_NUMBER +src/net/sf/freecol/common/model/Player.java:3434: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3437: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3437: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3437: Found 'DU'-anomaly for variable 'LONG_PATH_TILES' (lines '3,437'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3440: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3440: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3440: Found 'DU'-anomaly for variable 'MOD_HAS_RESOURCE' (lines '3,440'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3441: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3441: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3441: Found 'DU'-anomaly for variable 'MOD_FOOD_LOW' (lines '3,441'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3442: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3442: Avoid unused local variables such as 'MOD_INITIAL_FOOD'. +src/net/sf/freecol/common/model/Player.java:3442: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3442: Found 'DU'-anomaly for variable 'MOD_INITIAL_FOOD' (lines '3,442'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3443: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3443: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3443: Found 'DU'-anomaly for variable 'MOD_STEAL' (lines '3,443'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3444: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3444: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3444: Found 'DU'-anomaly for variable 'MOD_INLAND' (lines '3,444'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3447: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3447: Avoid excessively long variable names like MOD_OWNED_EUROPEAN +src/net/sf/freecol/common/model/Player.java:3447: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3447: Found 'DU'-anomaly for variable 'MOD_OWNED_EUROPEAN' (lines '3,447'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3448: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3448: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3448: Found 'DU'-anomaly for variable 'MOD_OWNED_NATIVE' (lines '3,448'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3451: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3451: Avoid excessively long variable names like MOD_HIGH_PRODUCTION +src/net/sf/freecol/common/model/Player.java:3451: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3451: Found 'DU'-anomaly for variable 'MOD_HIGH_PRODUCTION' (lines '3,451'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3452: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3452: Avoid excessively long variable names like MOD_GOOD_PRODUCTION +src/net/sf/freecol/common/model/Player.java:3452: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3452: Found 'DU'-anomaly for variable 'MOD_GOOD_PRODUCTION' (lines '3,452'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3455: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3455: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3455: Found 'DU'-anomaly for variable 'DISTANCE_MAX' (lines '3,455'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3456: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3456: Found 'DU'-anomaly for variable 'MOD_OWN_COLONY' (lines '3,456'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3457: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3457: Found 'DU'-anomaly for variable 'MOD_ENEMY_COLONY' (lines '3,457'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3458: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3458: Avoid excessively long variable names like MOD_NEUTRAL_COLONY +src/net/sf/freecol/common/model/Player.java:3458: Found 'DU'-anomaly for variable 'MOD_NEUTRAL_COLONY' (lines '3,458'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3459: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3459: Found 'DU'-anomaly for variable 'MOD_ENEMY_UNIT' (lines '3,459'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3462: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3462: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3462: Found 'DU'-anomaly for variable 'GOOD_PRODUCTION' (lines '3,462'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3463: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3463: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3463: Found 'DU'-anomaly for variable 'HIGH_PRODUCTION' (lines '3,463'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3467: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3467: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3467: Found 'DU'-anomaly for variable 'FOOD_LOW' (lines '3,467'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3468: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3468: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/model/Player.java:3468: Found 'DU'-anomaly for variable 'FOOD_VERY_LOW' (lines '3,468'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3471: Local variable 'values' could be declared final +src/net/sf/freecol/common/model/Player.java:3472: Avoid unused local variables such as 'c'. +src/net/sf/freecol/common/model/Player.java:3472: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/Player.java:3473: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3476: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3476: Found 'DU'-anomaly for variable 'development' (lines '3,476'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3476: Local variable 'development' could be declared final +src/net/sf/freecol/common/model/Player.java:3478: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3478: Found 'DU'-anomaly for variable 'portCount' (lines '3,478'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3478: Local variable 'portCount' could be declared final +src/net/sf/freecol/common/model/Player.java:3481: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3481: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3482: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3483: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3490: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3491: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3492: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3495: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3496: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3497: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3499: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3499: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3503: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3503: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3507: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3507: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3508: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3509: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3512: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3513: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3514: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3514: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3515: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3516: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3518: Local variable 'price' could be declared final +src/net/sf/freecol/common/model/Player.java:3520: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3520: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3525: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3526: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3527: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3532: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3532: Found 'DU'-anomaly for variable 'production' (lines '3,532'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3532: Local variable 'production' could be declared final +src/net/sf/freecol/common/model/Player.java:3536: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/Player.java:3536: Found 'DU'-anomaly for variable 'foodType' (lines '3,536'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3536: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3537: Local variable 'productionType' could be declared final +src/net/sf/freecol/common/model/Player.java:3537: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3539: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/Player.java:3539: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3540: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3540: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3541: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/Player.java:3541: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3542: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3546: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3547: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3548: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3550: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3551: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3552: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3556: Local variable 'tilesToHighSeas' could be declared final +src/net/sf/freecol/common/model/Player.java:3559: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3559: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3560: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3561: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3563: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3569: Local variable 'trip' could be declared final +src/net/sf/freecol/common/model/Player.java:3570: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3570: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3573: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3573: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3580: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3580: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3581: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3581: Useless parentheses. +src/net/sf/freecol/common/model/Player.java:3583: Found 'DU'-anomaly for variable 'highProduction' (lines '3,583'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3583: Local variable 'highProduction' could be declared final +src/net/sf/freecol/common/model/Player.java:3584: Found 'DU'-anomaly for variable 'goodProduction' (lines '3,584'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3584: Local variable 'goodProduction' could be declared final +src/net/sf/freecol/common/model/Player.java:3585: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:3586: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3586: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3587: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3588: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3588: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3589: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3590: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3593: Avoid variables with short names like pf +src/net/sf/freecol/common/model/Player.java:3593: Found 'DU'-anomaly for variable 'pf' (lines '3,593'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3595: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3595: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3597: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3597: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3598: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3599: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3601: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3601: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3602: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3607: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3612: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/Player.java:3612: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3613: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3614: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3615: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3616: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3616: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3617: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3617: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3618: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3620: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3624: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3626: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3630: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/Player.java:3630: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3633: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3633: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3633: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3634: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3634: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3640: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/Player.java:3641: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3641: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3642: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3642: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3644: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3646: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3647: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3648: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3648: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3655: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:3655: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3655: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3657: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/Player.java:3657: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3661: Found 'DU'-anomaly for variable 'supportingColony' (lines '3,661'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3662: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3662: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3663: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3663: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3666: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3667: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3667: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3667: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3668: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3668: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3671: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3671: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3671: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3672: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3677: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/Player.java:3677: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3680: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3680: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3680: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3681: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3681: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3689: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3690: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3690: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3691: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3691: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3694: Avoid variables with short names like a +src/net/sf/freecol/common/model/Player.java:3694: Found 'DU'-anomaly for variable 'a' (lines '3,694'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3694: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:3695: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/Player.java:3695: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3696: Found 'DD'-anomaly for variable 'amount' (lines '3,696'-'3,696'). +src/net/sf/freecol/common/model/Player.java:3696: Found 'DU'-anomaly for variable 'amount' (lines '3,696'-'3,709'). +src/net/sf/freecol/common/model/Player.java:3696: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/Player.java:3696: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3697: Local variable 'threshold' could be declared final +src/net/sf/freecol/common/model/Player.java:3698: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Player.java:3699: Avoid assignments in operands +src/net/sf/freecol/common/model/Player.java:3699: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3699: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3699: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3701: Local variable 'fraction' could be declared final +src/net/sf/freecol/common/model/Player.java:3702: Local variable 'zeroValue' could be declared final +src/net/sf/freecol/common/model/Player.java:3703: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3711: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3720: Found 'UR'-anomaly for variable 'd' (lines '3,720'-'3,724'). +src/net/sf/freecol/common/model/Player.java:3720: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3721: Local variable 'values' could be declared final +src/net/sf/freecol/common/model/Player.java:3722: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Player.java:3722: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/Player.java:3722: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3722: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3722: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3723: Avoid variables with short names like v +src/net/sf/freecol/common/model/Player.java:3724: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Player.java:3724: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/Player.java:3738: Parameter 'what' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3739: There is log block not surrounded by if +src/net/sf/freecol/common/model/Player.java:3750: Found 'UR'-anomaly for variable 'unitType' (lines '3,750'-'3,754'). +src/net/sf/freecol/common/model/Player.java:3752: Local variable 'spec' could be declared final +src/net/sf/freecol/common/model/Player.java:3753: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/model/Player.java:3753: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3754: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3755: Local variable 'foodConsumption' could be declared final +src/net/sf/freecol/common/model/Player.java:3755: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3755: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3755: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3755: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3756: Avoid variables with short names like ft +src/net/sf/freecol/common/model/Player.java:3756: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3756: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3772: Parameter 'ownable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3776: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Player.java:3788: Avoid variables with short names like id +src/net/sf/freecol/common/model/Player.java:3788: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3789: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3790: Avoid variables with short names like t +src/net/sf/freecol/common/model/Player.java:3790: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:3790: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3812: Found 'UR'-anomaly for variable 'unit' (lines '3,812'-'3,815'). +src/net/sf/freecol/common/model/Player.java:3812: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3813: Found 'DD'-anomaly for variable 'result' (lines '3,813'-'3,819'). +src/net/sf/freecol/common/model/Player.java:3813: Found 'DD'-anomaly for variable 'result' (lines '3,813'-'3,822'). +src/net/sf/freecol/common/model/Player.java:3813: Found 'DD'-anomaly for variable 'result' (lines '3,813'-'3,825'). +src/net/sf/freecol/common/model/Player.java:3813: Found 'DD'-anomaly for variable 'result' (lines '3,813'-'3,828'). +src/net/sf/freecol/common/model/Player.java:3814: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/Player.java:3815: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3817: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3818: There is log block not surrounded by if +src/net/sf/freecol/common/model/Player.java:3819: Found 'DD'-anomaly for variable 'result' (lines '3,819'-'3,825'). +src/net/sf/freecol/common/model/Player.java:3821: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3821: There is log block not surrounded by if +src/net/sf/freecol/common/model/Player.java:3822: Found 'DD'-anomaly for variable 'result' (lines '3,822'-'3,825'). +src/net/sf/freecol/common/model/Player.java:3825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:3849: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3849: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3850: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3850: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3851: Avoid excessively long variable names like ATTACKED_BY_PRIVATEERS_TAG +src/net/sf/freecol/common/model/Player.java:3851: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3851: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3852: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3852: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3853: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3853: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3854: Avoid excessively long variable names like CURRENT_FATHER_TAG +src/net/sf/freecol/common/model/Player.java:3854: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3854: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3855: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3855: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3856: Avoid excessively long variable names like ENTRY_LOCATION_TAG +src/net/sf/freecol/common/model/Player.java:3856: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3856: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3857: Avoid excessively long variable names like FOUNDING_FATHERS_TAG +src/net/sf/freecol/common/model/Player.java:3857: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3857: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3858: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3858: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3859: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3859: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3860: Avoid excessively long variable names like IMMIGRATION_REQUIRED_TAG +src/net/sf/freecol/common/model/Player.java:3860: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3860: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3861: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3861: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3862: Avoid excessively long variable names like INDEPENDENT_NATION_NAME_TAG +src/net/sf/freecol/common/model/Player.java:3862: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3862: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3863: Avoid excessively long variable names like INTERVENTION_BELLS_TAG +src/net/sf/freecol/common/model/Player.java:3863: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3863: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3864: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3864: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3865: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3865: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3866: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3866: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3867: Avoid excessively long variable names like NUMBER_OF_SETTLEMENTS_TAG +src/net/sf/freecol/common/model/Player.java:3867: Avoid unused private fields such as 'NUMBER_OF_SETTLEMENTS_TAG'. +src/net/sf/freecol/common/model/Player.java:3867: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3867: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3868: Avoid excessively long variable names like OFFERED_FATHERS_TAG +src/net/sf/freecol/common/model/Player.java:3868: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3868: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3869: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3869: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3870: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3870: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3871: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3871: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3872: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3872: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3873: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3873: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3874: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3874: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3875: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3875: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3876: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3876: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3877: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3877: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3879: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Player.java:3879: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Player.java:3887: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Player.java:3887: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3952: Avoid really long methods. +src/net/sf/freecol/common/model/Player.java:3952: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Player.java:3952: Found 'UR'-anomaly for variable 'ability' (lines '3,952'-'3,960'). +src/net/sf/freecol/common/model/Player.java:3952: Found 'UR'-anomaly for variable 'e' (lines '3,952'-'3,991'). +src/net/sf/freecol/common/model/Player.java:3952: Found 'UR'-anomaly for variable 'event' (lines '3,952'-'4,004'). +src/net/sf/freecol/common/model/Player.java:3952: Found 'UR'-anomaly for variable 'modifier' (lines '3,952'-'3,965'). +src/net/sf/freecol/common/model/Player.java:3952: Found 'UR'-anomaly for variable 'p' (lines '3,952'-'3,973'). +src/net/sf/freecol/common/model/Player.java:3952: Found 'UR'-anomaly for variable 'route' (lines '3,952'-'4,008'). +src/net/sf/freecol/common/model/Player.java:3952: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:3952: The method 'writeChildren' has a Cyclomatic Complexity of 25. +src/net/sf/freecol/common/model/Player.java:3952: The method 'writeChildren' has a Modified Cyclomatic Complexity of 23. +src/net/sf/freecol/common/model/Player.java:3952: The method 'writeChildren' has a Standard Cyclomatic Complexity of 23. +src/net/sf/freecol/common/model/Player.java:3952: The method writeChildren() has an NPath complexity of 82968 +src/net/sf/freecol/common/model/Player.java:3955: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3959: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/Player.java:3960: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:3963: Local variable 'turn' could be declared final +src/net/sf/freecol/common/model/Player.java:3963: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3964: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/Player.java:3970: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/Player.java:3975: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3975: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:3981: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/Player.java:3990: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/Player.java:3991: Avoid variables with short names like s +src/net/sf/freecol/common/model/Player.java:3991: Local variable 's' could be declared final +src/net/sf/freecol/common/model/Player.java:3992: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4003: Local variable 'event' could be declared final +src/net/sf/freecol/common/model/Player.java:4007: Local variable 'route' could be declared final +src/net/sf/freecol/common/model/Player.java:4011: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4017: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4019: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4021: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/Player.java:4021: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/Player.java:4024: Local variable 'ls' could be declared final +src/net/sf/freecol/common/model/Player.java:4030: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Player.java:4031: Avoid variables with short names like t +src/net/sf/freecol/common/model/Player.java:4031: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Player.java:4037: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:4045: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:4050: Avoid variables with short names like s +src/net/sf/freecol/common/model/Player.java:4050: Local variable 's' could be declared final +src/net/sf/freecol/common/model/Player.java:4067: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Player.java:4067: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:4082: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:4136: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Player.java:4136: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:4139: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4143: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:4144: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:4148: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:4149: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Player.java:4151: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4158: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/Player.java:4159: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4160: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/Player.java:4160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4160: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Player.java:4161: Invoke equals() on the object you've already ensured is not null +src/net/sf/freecol/common/model/Player.java:4161: Invoke equals() on the object you've already ensured is not null +src/net/sf/freecol/common/model/Player.java:4161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4174: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Player.java:4174: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Player.java:4174: The method 'readChild' has a Cyclomatic Complexity of 22. +src/net/sf/freecol/common/model/Player.java:4174: The method 'readChild' has a Modified Cyclomatic Complexity of 21. +src/net/sf/freecol/common/model/Player.java:4174: The method 'readChild' has a Standard Cyclomatic Complexity of 21. +src/net/sf/freecol/common/model/Player.java:4180: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Player.java:4182: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:4186: Local variable 'ffs' could be declared final +src/net/sf/freecol/common/model/Player.java:4189: Local variable 'ff' could be declared final +src/net/sf/freecol/common/model/Player.java:4195: Local variable 'ofs' could be declared final +src/net/sf/freecol/common/model/Player.java:4200: Local variable 'player' could be declared final +src/net/sf/freecol/common/model/Player.java:4202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:4212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4213: Local variable 'ability' could be declared final +src/net/sf/freecol/common/model/Player.java:4214: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:4216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4222: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4231: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4234: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4235: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/Player.java:4236: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Player.java:4236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Player.java:4238: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Player.java:4241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/PlayerExploredTile.java:20: Possible God class (WMC=48, ATFD=50, TCC=0.3111111111111111) +src/net/sf/freecol/common/model/PlayerExploredTile.java:33: Comment is too large: Too many lines +src/net/sf/freecol/common/model/PlayerExploredTile.java:43: The class 'PlayerExploredTile' has a Cyclomatic Complexity of 4 (Highest = 18). +src/net/sf/freecol/common/model/PlayerExploredTile.java:43: The class 'PlayerExploredTile' has a Modified Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/common/model/PlayerExploredTile.java:43: The class 'PlayerExploredTile' has a Standard Cyclomatic Complexity of 4 (Highest = 14). +src/net/sf/freecol/common/model/PlayerExploredTile.java:45: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/PlayerExploredTile.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:61: Avoid using redundant field initializer for 'tileItems' +src/net/sf/freecol/common/model/PlayerExploredTile.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:64: Avoid using redundant field initializer for 'colonyUnitCount' +src/net/sf/freecol/common/model/PlayerExploredTile.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:64: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:67: Avoid using redundant field initializer for 'missionary' +src/net/sf/freecol/common/model/PlayerExploredTile.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:68: Avoid using redundant field initializer for 'alarm' +src/net/sf/freecol/common/model/PlayerExploredTile.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:68: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:69: Avoid using redundant field initializer for 'mostHated' +src/net/sf/freecol/common/model/PlayerExploredTile.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/PlayerExploredTile.java:69: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:79: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:79: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:79: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:91: Avoid variables with short names like id +src/net/sf/freecol/common/model/PlayerExploredTile.java:91: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:91: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:111: Parameter 'item' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:112: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PlayerExploredTile.java:123: The method 'fixCache' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/PlayerExploredTile.java:123: The method 'fixCache' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/PlayerExploredTile.java:123: The method 'fixCache' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/PlayerExploredTile.java:123: The method fixCache() has an NPath complexity of 11200 +src/net/sf/freecol/common/model/PlayerExploredTile.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:129: Local variable 'copied' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Avoid variables with short names like ok +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'133'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'138'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'146'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'154'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'164'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'168'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:130: Found 'DD'-anomaly for variable 'ok' (lines '130'-'172'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:133: Found 'DD'-anomaly for variable 'ok' (lines '133'-'138'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:133: Found 'DD'-anomaly for variable 'ok' (lines '133'-'146'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:133: Found 'DD'-anomaly for variable 'ok' (lines '133'-'154'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:133: Found 'DD'-anomaly for variable 'ok' (lines '133'-'164'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:133: Found 'DD'-anomaly for variable 'ok' (lines '133'-'168'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:133: Found 'DD'-anomaly for variable 'ok' (lines '133'-'172'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:138: Found 'DD'-anomaly for variable 'ok' (lines '138'-'146'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:138: Found 'DD'-anomaly for variable 'ok' (lines '138'-'154'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:138: Found 'DD'-anomaly for variable 'ok' (lines '138'-'164'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:138: Found 'DD'-anomaly for variable 'ok' (lines '138'-'168'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:138: Found 'DD'-anomaly for variable 'ok' (lines '138'-'172'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:141: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/PlayerExploredTile.java:141: Avoid variables with short names like ti +src/net/sf/freecol/common/model/PlayerExploredTile.java:141: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:143: Method call on object which may be null +src/net/sf/freecol/common/model/PlayerExploredTile.java:143: Method call on object which may be null +src/net/sf/freecol/common/model/PlayerExploredTile.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:144: Useless parentheses. +src/net/sf/freecol/common/model/PlayerExploredTile.java:144: Useless parentheses. +src/net/sf/freecol/common/model/PlayerExploredTile.java:146: Found 'DD'-anomaly for variable 'ok' (lines '146'-'154'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:146: Found 'DD'-anomaly for variable 'ok' (lines '146'-'164'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:146: Found 'DD'-anomaly for variable 'ok' (lines '146'-'168'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:146: Found 'DD'-anomaly for variable 'ok' (lines '146'-'172'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:149: Avoid variables with short names like ts +src/net/sf/freecol/common/model/PlayerExploredTile.java:149: Local variable 'ts' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:151: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:160: Avoid variables with short names like is +src/net/sf/freecol/common/model/PlayerExploredTile.java:160: Local variable 'is' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:164: Found 'DD'-anomaly for variable 'ok' (lines '164'-'168'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:164: Found 'DD'-anomaly for variable 'ok' (lines '164'-'172'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:168: Found 'DD'-anomaly for variable 'ok' (lines '168'-'172'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:176: Useless parentheses. +src/net/sf/freecol/common/model/PlayerExploredTile.java:176: Useless parentheses. +src/net/sf/freecol/common/model/PlayerExploredTile.java:182: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:182: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:183: Avoid excessively long variable names like COLONY_UNIT_COUNT_TAG +src/net/sf/freecol/common/model/PlayerExploredTile.java:183: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:183: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:184: Avoid excessively long variable names like LEARNABLE_SKILL_TAG +src/net/sf/freecol/common/model/PlayerExploredTile.java:184: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:184: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:185: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:185: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:186: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:186: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:187: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:187: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:188: Avoid excessively long variable names like OWNING_SETTLEMENT_TAG +src/net/sf/freecol/common/model/PlayerExploredTile.java:188: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:188: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:189: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:189: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:190: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:190: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:191: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:191: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:193: Avoid excessively long variable names like OLD_TILE_IMPROVEMENT_TAG +src/net/sf/freecol/common/model/PlayerExploredTile.java:193: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/PlayerExploredTile.java:193: fieldCommentRequirement Required +src/net/sf/freecol/common/model/PlayerExploredTile.java:201: Avoid variables with short names like xw +src/net/sf/freecol/common/model/PlayerExploredTile.java:201: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:208: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PlayerExploredTile.java:218: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PlayerExploredTile.java:229: Avoid variables with short names like xw +src/net/sf/freecol/common/model/PlayerExploredTile.java:229: Found 'UR'-anomaly for variable 'ti' (lines '229'-'245'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:229: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:236: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:244: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:253: Avoid variables with short names like xr +src/net/sf/freecol/common/model/PlayerExploredTile.java:253: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:256: Found 'DU'-anomaly for variable 'spec' (lines '256'-'302'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:284: Avoid variables with short names like is +src/net/sf/freecol/common/model/PlayerExploredTile.java:284: Local variable 'is' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:286: Local variable 'skill' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:290: Found 'DD'-anomaly for variable 'wanted' (lines '290'-'292'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:290: Found 'DU'-anomaly for variable 'wanted' (lines '290'-'302'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:308: Avoid variables with short names like xr +src/net/sf/freecol/common/model/PlayerExploredTile.java:308: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:310: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PlayerExploredTile.java:311: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/PlayerExploredTile.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:317: There is log block not surrounded by if +src/net/sf/freecol/common/model/PlayerExploredTile.java:319: Avoid variables with short names like p +src/net/sf/freecol/common/model/PlayerExploredTile.java:319: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:320: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/PlayerExploredTile.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/PlayerExploredTile.java:321: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/PlayerExploredTile.java:329: Avoid variables with short names like xr +src/net/sf/freecol/common/model/PlayerExploredTile.java:329: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/PlayerExploredTile.java:330: Found 'DU'-anomaly for variable 'game' (lines '330'-'354'). +src/net/sf/freecol/common/model/PlayerExploredTile.java:338: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/PlayerExploredTile.java:344: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionCache.java:40: The class 'ProductionCache' has a Cyclomatic Complexity of 2 (Highest = 14). +src/net/sf/freecol/common/model/ProductionCache.java:40: The class 'ProductionCache' has a Modified Cyclomatic Complexity of 2 (Highest = 14). +src/net/sf/freecol/common/model/ProductionCache.java:40: The class 'ProductionCache' has a Standard Cyclomatic Complexity of 2 (Highest = 14). +src/net/sf/freecol/common/model/ProductionCache.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ProductionCache.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ProductionCache.java:54: Avoid excessively long variable names like productionAndConsumption +src/net/sf/freecol/common/model/ProductionCache.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ProductionCache.java:54: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/ProductionCache.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ProductionCache.java:64: Avoid using redundant field initializer for 'upToDate' +src/net/sf/freecol/common/model/ProductionCache.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ProductionCache.java:72: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionCache.java:93: Found 'UR'-anomaly for variable 'colonyTile' (lines '93'-'104'). +src/net/sf/freecol/common/model/ProductionCache.java:93: Found 'UR'-anomaly for variable 'consumer' (lines '93'-'126'). +src/net/sf/freecol/common/model/ProductionCache.java:93: Found 'UR'-anomaly for variable 'g' (lines '93'-'130'). +src/net/sf/freecol/common/model/ProductionCache.java:93: Found 'UR'-anomaly for variable 'goods' (lines '93'-'108'). +src/net/sf/freecol/common/model/ProductionCache.java:93: Found 'UR'-anomaly for variable 'output' (lines '93'-'147'). +src/net/sf/freecol/common/model/ProductionCache.java:93: The method 'update' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/ProductionCache.java:93: The method 'update' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/ProductionCache.java:93: The method 'update' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/ProductionCache.java:93: The method update() has an NPath complexity of 456 +src/net/sf/freecol/common/model/ProductionCache.java:93: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/ProductionCache.java:94: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionCache.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:101: Local variable 'production' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:103: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:104: Local variable 'info' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:107: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:116: Avoid excessively long variable names like unitsThatUseNoBells +src/net/sf/freecol/common/model/ProductionCache.java:116: Local variable 'unitsThatUseNoBells' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:118: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:119: Local variable 'bellsInfo' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:124: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:125: Local variable 'consumer' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:126: Found 'DU'-anomaly for variable 'modifiers' (lines '126'-'176'). +src/net/sf/freecol/common/model/ProductionCache.java:126: Local variable 'modifiers' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:129: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:131: Local variable 'surplus' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:132: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ProductionCache.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:142: Found 'DD'-anomaly for variable 'info' (lines '142'-'155'). +src/net/sf/freecol/common/model/ProductionCache.java:142: Found 'DD'-anomaly for variable 'info' (lines '142'-'157'). +src/net/sf/freecol/common/model/ProductionCache.java:142: Found 'DD'-anomaly for variable 'info' (lines '142'-'159'). +src/net/sf/freecol/common/model/ProductionCache.java:144: Local variable 'building' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:145: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ProductionCache.java:145: Local variable 'outputs' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:146: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:147: Local variable 'outputType' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:149: Local variable 'newOutput' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:150: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ProductionCache.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:164: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:168: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionCache.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionCache.java:186: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:197: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/ProductionCache.java:208: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:208: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/ProductionCache.java:220: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:223: Avoid variables with short names like pi +src/net/sf/freecol/common/model/ProductionCache.java:232: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:235: Avoid variables with short names like pi +src/net/sf/freecol/common/model/ProductionCache.java:245: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:257: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionCache.java:269: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionInfo.java:29: Each class should declare at least one constructor +src/net/sf/freecol/common/model/ProductionInfo.java:38: Avoid excessively long variable names like maximumConsumption +src/net/sf/freecol/common/model/ProductionInfo.java:44: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:52: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:52: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:56: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:60: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:64: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:68: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:68: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:72: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:76: Avoid excessively long variable names like newMaximumProduction +src/net/sf/freecol/common/model/ProductionInfo.java:76: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:80: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:80: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:90: Found 'UR'-anomaly for variable 'ag' (lines '90'-'96'). +src/net/sf/freecol/common/model/ProductionInfo.java:92: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionInfo.java:94: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:95: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:96: Local variable 'agMax' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionInfo.java:98: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionInfo.java:99: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionInfo.java:101: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ProductionInfo.java:113: Found 'UR'-anomaly for variable 'ag' (lines '113'-'119'). +src/net/sf/freecol/common/model/ProductionInfo.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionInfo.java:117: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:118: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:119: Local variable 'agMax' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionInfo.java:121: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionInfo.java:122: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionInfo.java:124: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ProductionInfo.java:136: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionInfo.java:136: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionInfo.java:139: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionInfo.java:139: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionInfo.java:141: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionInfo.java:141: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionInfo.java:142: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionInfo.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionInfo.java:147: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:151: Avoid excessively long variable names like newMaximumConsumption +src/net/sf/freecol/common/model/ProductionInfo.java:151: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:155: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:155: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionInfo.java:159: Found 'UR'-anomaly for variable 'goods' (lines '159'-'165'). +src/net/sf/freecol/common/model/ProductionInfo.java:159: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:159: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:160: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:161: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionInfo.java:164: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:166: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionInfo.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionInfo.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionInfo.java:169: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionInfo.java:173: Local variable 'length' could be declared final +src/net/sf/freecol/common/model/ProductionInfo.java:182: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionMap.java:32: Each class should declare at least one constructor +src/net/sf/freecol/common/model/ProductionMap.java:34: headerCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:48: Parameter 'leafs' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:48: Parameter 'root' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:52: Local variable 'leaf' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:53: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/ProductionMap.java:63: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:67: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:71: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:75: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:79: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:79: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:80: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/ProductionMap.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionMap.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionMap.java:84: Local variable 'leaf' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionMap.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionMap.java:95: Found 'UR'-anomaly for variable 'leaf' (lines '95'-'100'). +src/net/sf/freecol/common/model/ProductionMap.java:95: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:95: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:96: Local variable 'consumed' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:99: Local variable 'leaf' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionMap.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionMap.java:103: Local variable 'leaf' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionMap.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionMap.java:112: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:112: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:114: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionMap.java:116: Local variable 'leaf' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:118: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionMap.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionMap.java:128: Found 'UR'-anomaly for variable 'ag' (lines '128'-'132'). +src/net/sf/freecol/common/model/ProductionMap.java:129: Avoid variables with short names like sb +src/net/sf/freecol/common/model/ProductionMap.java:129: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:130: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionMap.java:130: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionMap.java:131: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:132: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionMap.java:140: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ProductionMap.java:140: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ProductionMap.java:140: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/ProductionMap.java:140: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:143: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:143: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:144: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:146: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionMap.java:148: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionMap.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionMap.java:154: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:154: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:155: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:159: Local variable 'rootType' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:160: Use equals() to compare object references. +src/net/sf/freecol/common/model/ProductionMap.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionMap.java:170: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:180: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionMap.java:184: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:184: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:185: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionMap.java:194: Found 'UR'-anomaly for variable 'g' (lines '194'-'196'). +src/net/sf/freecol/common/model/ProductionMap.java:194: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:194: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:195: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:200: Found 'UR'-anomaly for variable 'g' (lines '200'-'202'). +src/net/sf/freecol/common/model/ProductionMap.java:200: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:200: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/ProductionMap.java:201: Local variable 'g' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:210: Found 'UR'-anomaly for variable 'e' (lines '210'-'214'). +src/net/sf/freecol/common/model/ProductionMap.java:211: Avoid variables with short names like sb +src/net/sf/freecol/common/model/ProductionMap.java:211: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:212: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionMap.java:213: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/ProductionMap.java:214: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionMap.java:214: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionMap.java:215: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionMap.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionType.java:20: Possible God class (WMC=75, ATFD=29, TCC=0.15692307692307692) +src/net/sf/freecol/common/model/ProductionType.java:37: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/ProductionType.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ProductionType.java:49: Avoid using redundant field initializer for 'outputs' +src/net/sf/freecol/common/model/ProductionType.java:52: Avoid using redundant field initializer for 'inputs' +src/net/sf/freecol/common/model/ProductionType.java:60: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ProductionType.java:60: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:70: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ProductionType.java:70: Parameter 'outputs' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:81: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ProductionType.java:81: Parameter 'inputs' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:82: Parameter 'outputs' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:94: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ProductionType.java:94: Parameter 'output' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:94: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:95: Parameter 'level' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:110: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/ProductionType.java:110: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:110: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:110: Parameter 'output' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:128: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ProductionType.java:128: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:128: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:141: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:160: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:160: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:161: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionType.java:171: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:190: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:190: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:191: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionType.java:202: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:204: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:205: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionType.java:205: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionType.java:215: Found 'UR'-anomaly for variable 'output' (lines '215'-'220'). +src/net/sf/freecol/common/model/ProductionType.java:216: Found 'DD'-anomaly for variable 'best' (lines '216'-'222'). +src/net/sf/freecol/common/model/ProductionType.java:218: Found 'DU'-anomaly for variable 'amount' (lines '218'-'227'). +src/net/sf/freecol/common/model/ProductionType.java:219: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:221: Found 'DU'-anomaly for variable 'amount' (lines '221'-'227'). +src/net/sf/freecol/common/model/ProductionType.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:222: Found 'DD'-anomaly for variable 'best' (lines '222'-'222'). +src/net/sf/freecol/common/model/ProductionType.java:226: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/ProductionType.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:234: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/ProductionType.java:243: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:263: Parameter 'level' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:276: Parameter 'level' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:281: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionType.java:290: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:291: Parameter 'types' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:292: Avoid variables with short names like pt +src/net/sf/freecol/common/model/ProductionType.java:296: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionType.java:305: Found 'UR'-anomaly for variable 'pt' (lines '305'-'310'). +src/net/sf/freecol/common/model/ProductionType.java:305: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:306: Parameter 'types' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:307: Found 'DD'-anomaly for variable 'best' (lines '307'-'315'). +src/net/sf/freecol/common/model/ProductionType.java:308: Found 'DU'-anomaly for variable 'bestSum' (lines '308'-'319'). +src/net/sf/freecol/common/model/ProductionType.java:309: Local variable 'pt' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:310: Local variable 'sum' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:311: Avoid variables with short names like o +src/net/sf/freecol/common/model/ProductionType.java:314: Found 'DU'-anomaly for variable 'bestSum' (lines '314'-'319'). +src/net/sf/freecol/common/model/ProductionType.java:315: Found 'DD'-anomaly for variable 'best' (lines '315'-'315'). +src/net/sf/freecol/common/model/ProductionType.java:321: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ProductionType.java:330: Found 'UR'-anomaly for variable 'output' (lines '330'-'335'). +src/net/sf/freecol/common/model/ProductionType.java:330: Found 'UR'-anomaly for variable 'productionType' (lines '330'-'334'). +src/net/sf/freecol/common/model/ProductionType.java:330: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:331: Parameter 'types' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:333: Local variable 'productionType' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:334: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ProductionType.java:352: Avoid variables with short names like o +src/net/sf/freecol/common/model/ProductionType.java:352: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:353: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionType.java:353: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionType.java:355: Avoid variables with short names like pt +src/net/sf/freecol/common/model/ProductionType.java:355: Local variable 'pt' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:356: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/ProductionType.java:358: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:359: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:369: Found 'UR'-anomaly for variable 'ag' (lines '369'-'375'). +src/net/sf/freecol/common/model/ProductionType.java:370: Found 'DD'-anomaly for variable 'hash' (lines '370'-'371'). +src/net/sf/freecol/common/model/ProductionType.java:371: Useless parentheses. +src/net/sf/freecol/common/model/ProductionType.java:371: Useless parentheses. +src/net/sf/freecol/common/model/ProductionType.java:372: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ProductionType.java:374: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:379: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:389: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ProductionType.java:389: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ProductionType.java:390: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ProductionType.java:390: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ProductionType.java:391: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ProductionType.java:391: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ProductionType.java:392: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ProductionType.java:392: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ProductionType.java:393: Avoid excessively long variable names like PRODUCTION_LEVEL_TAG +src/net/sf/freecol/common/model/ProductionType.java:393: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ProductionType.java:393: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ProductionType.java:395: Avoid excessively long variable names like OLD_PRODUCTION_LEVEL_TAG +src/net/sf/freecol/common/model/ProductionType.java:395: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ProductionType.java:395: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ProductionType.java:403: Avoid variables with short names like xw +src/net/sf/freecol/common/model/ProductionType.java:403: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:420: Avoid variables with short names like xw +src/net/sf/freecol/common/model/ProductionType.java:420: Found 'UR'-anomaly for variable 'input' (lines '420'-'427'). +src/net/sf/freecol/common/model/ProductionType.java:420: Found 'UR'-anomaly for variable 'output' (lines '420'-'439'). +src/net/sf/freecol/common/model/ProductionType.java:420: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:424: Local variable 'input' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:436: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:452: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ProductionType.java:452: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:472: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ProductionType.java:472: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:474: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionType.java:475: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/ProductionType.java:484: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ProductionType.java:484: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/ProductionType.java:485: Found 'DU'-anomaly for variable 'spec' (lines '485'-'503'). +src/net/sf/freecol/common/model/ProductionType.java:489: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:495: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:509: Found 'UR'-anomaly for variable 'input' (lines '509'-'521'). +src/net/sf/freecol/common/model/ProductionType.java:509: Found 'UR'-anomaly for variable 'output' (lines '509'-'529'). +src/net/sf/freecol/common/model/ProductionType.java:510: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:511: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionType.java:511: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionType.java:513: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/ProductionType.java:520: Local variable 'input' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:523: Local variable 'length' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:528: Local variable 'output' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:531: Local variable 'length' could be declared final +src/net/sf/freecol/common/model/ProductionType.java:534: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/RandomRange.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/RandomRange.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/RandomRange.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/model/RandomRange.java:45: Avoid using redundant field initializer for 'probability' +src/net/sf/freecol/common/model/RandomRange.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/RandomRange.java:48: Avoid using redundant field initializer for 'minimum' +src/net/sf/freecol/common/model/RandomRange.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/RandomRange.java:51: Avoid using redundant field initializer for 'maximum' +src/net/sf/freecol/common/model/RandomRange.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/RandomRange.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/RandomRange.java:57: Avoid using redundant field initializer for 'scopes' +src/net/sf/freecol/common/model/RandomRange.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/RandomRange.java:68: Parameter 'factor' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:68: Parameter 'maximum' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:68: Parameter 'minimum' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:68: Parameter 'probability' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:90: Avoid variables with short names like xr +src/net/sf/freecol/common/model/RandomRange.java:90: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/RandomRange.java:146: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:147: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/RandomRange.java:157: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:158: Local variable 'scs' could be declared final +src/net/sf/freecol/common/model/RandomRange.java:159: Avoid variables with short names like s +src/net/sf/freecol/common/model/RandomRange.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/RandomRange.java:162: Comment is too large: Too many lines +src/net/sf/freecol/common/model/RandomRange.java:171: Parameter 'continuous' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:171: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:171: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:173: Useless parentheses. +src/net/sf/freecol/common/model/RandomRange.java:173: Useless parentheses. +src/net/sf/freecol/common/model/RandomRange.java:176: Local variable 'range' could be declared final +src/net/sf/freecol/common/model/RandomRange.java:178: Avoid variables with short names like r +src/net/sf/freecol/common/model/RandomRange.java:178: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/RandomRange.java:180: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/RandomRange.java:182: Avoid variables with short names like r +src/net/sf/freecol/common/model/RandomRange.java:182: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/RandomRange.java:184: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/RandomRange.java:193: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/RandomRange.java:193: fieldCommentRequirement Required +src/net/sf/freecol/common/model/RandomRange.java:194: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/RandomRange.java:194: fieldCommentRequirement Required +src/net/sf/freecol/common/model/RandomRange.java:195: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/RandomRange.java:195: fieldCommentRequirement Required +src/net/sf/freecol/common/model/RandomRange.java:196: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/RandomRange.java:196: fieldCommentRequirement Required +src/net/sf/freecol/common/model/RandomRange.java:197: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/RandomRange.java:197: fieldCommentRequirement Required +src/net/sf/freecol/common/model/RandomRange.java:208: Avoid variables with short names like xw +src/net/sf/freecol/common/model/RandomRange.java:208: Found 'UR'-anomaly for variable 'scope' (lines '208'-'219'). +src/net/sf/freecol/common/model/RandomRange.java:208: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:208: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:219: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/RandomRange.java:219: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/RandomRange.java:231: Avoid variables with short names like xr +src/net/sf/freecol/common/model/RandomRange.java:231: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/RandomRange.java:241: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/RandomRange.java:247: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/Region.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Region.java:20: Possible God class (WMC=70, ATFD=19, TCC=0.00995732574679943) +src/net/sf/freecol/common/model/Region.java:41: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/Region.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Region.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:44: Avoid excessively long variable names like predefinedRegionKeys +src/net/sf/freecol/common/model/Region.java:44: Variables that are final and static should be all capitals, 'predefinedRegionKeys' is not all capitals. +src/net/sf/freecol/common/model/Region.java:74: Parameter 'claimable' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:83: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Region.java:120: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Region.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Region.java:129: Avoid using redundant field initializer for 'children' +src/net/sf/freecol/common/model/Region.java:135: Avoid using redundant field initializer for 'claimable' +src/net/sf/freecol/common/model/Region.java:143: Avoid using redundant field initializer for 'discoverable' +src/net/sf/freecol/common/model/Region.java:155: Avoid using redundant field initializer for 'discoverer' +src/net/sf/freecol/common/model/Region.java:161: Avoid using redundant field initializer for 'scoreValue' +src/net/sf/freecol/common/model/Region.java:169: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:179: Avoid variables with short names like id +src/net/sf/freecol/common/model/Region.java:179: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:179: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Region.java:212: Useless parentheses. +src/net/sf/freecol/common/model/Region.java:212: Useless parentheses. +src/net/sf/freecol/common/model/Region.java:221: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Region.java:222: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Region.java:222: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Region.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Region.java:277: Parameter 'child' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:278: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Region.java:296: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Region.java:314: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Region.java:332: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/Region.java:341: Parameter 'discoverer' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:341: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/Region.java:345: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Region.java:355: Useless parentheses. +src/net/sf/freecol/common/model/Region.java:355: Useless parentheses. +src/net/sf/freecol/common/model/Region.java:356: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Region.java:356: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Region.java:357: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Region.java:421: Found 'UR'-anomaly for variable 'r' (lines '421'-'428'). +src/net/sf/freecol/common/model/Region.java:421: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:421: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:422: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/Region.java:426: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Region.java:427: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/Region.java:428: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Region.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Region.java:432: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Region.java:443: Found 'UR'-anomaly for variable 'r' (lines '443'-'446'). +src/net/sf/freecol/common/model/Region.java:443: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:444: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Region.java:444: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Region.java:445: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/Region.java:447: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Region.java:449: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Region.java:483: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Region.java:489: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:489: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:490: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:490: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:491: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:491: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:492: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:492: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:493: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:493: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:494: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:494: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:495: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:495: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:496: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:496: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:497: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:497: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:498: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:498: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:500: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Region.java:500: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Region.java:508: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Region.java:508: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:546: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Region.java:546: Found 'UR'-anomaly for variable 'child' (lines '546'-'553'). +src/net/sf/freecol/common/model/Region.java:546: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:549: Local variable 'child' could be declared final +src/net/sf/freecol/common/model/Region.java:563: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Region.java:563: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:574: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Region.java:584: Local variable 'turn' could be declared final +src/net/sf/freecol/common/model/Region.java:585: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Region.java:598: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Region.java:598: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:600: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Region.java:609: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Region.java:609: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Region.java:627: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Region.java:627: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Region.java:628: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Region.java:629: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Region.java:629: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Region.java:629: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Region.java:631: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Region.java:632: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Region.java:632: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Region.java:633: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Resource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Resource.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/Resource.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Resource.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Resource.java:53: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Resource.java:63: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:63: Parameter 'quantity' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:63: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:63: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:73: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Resource.java:82: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:82: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:82: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:92: Avoid variables with short names like id +src/net/sf/freecol/common/model/Resource.java:92: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:92: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:129: Parameter 'newQuantity' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:142: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Resource.java:151: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:151: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:152: Parameter 'potential' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:164: Parameter 'usedQuantity' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:166: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Resource.java:166: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/Resource.java:171: There is log block not surrounded by if +src/net/sf/freecol/common/model/Resource.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Resource.java:203: Parameter 'tileType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:211: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:211: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:212: Parameter 'potential' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:213: Local variable 'bonus' could be declared final +src/net/sf/freecol/common/model/Resource.java:214: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/Resource.java:216: Useless parentheses. +src/net/sf/freecol/common/model/Resource.java:216: Useless parentheses. +src/net/sf/freecol/common/model/Resource.java:224: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:224: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:225: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Resource.java:225: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Resource.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Resource.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Resource.java:236: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:237: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:238: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Resource.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Resource.java:266: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:273: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Resource.java:273: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Resource.java:274: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Resource.java:274: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Resource.java:275: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Resource.java:275: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Resource.java:282: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Resource.java:282: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:296: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Resource.java:296: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Resource.java:315: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Resource.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/ResourceType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/ResourceType.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ResourceType.java:34: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/ResourceType.java:43: Avoid variables with short names like id +src/net/sf/freecol/common/model/ResourceType.java:43: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/ResourceType.java:43: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/ResourceType.java:72: Found 'UR'-anomaly for variable 'modifier' (lines '72'-'77'). +src/net/sf/freecol/common/model/ResourceType.java:73: Found 'DU'-anomaly for variable 'spec' (lines '73'-'85'). +src/net/sf/freecol/common/model/ResourceType.java:75: Found 'DU'-anomaly for variable 'bestValue' (lines '75'-'85'). +src/net/sf/freecol/common/model/ResourceType.java:76: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/ResourceType.java:77: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/ResourceType.java:77: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ResourceType.java:77: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ResourceType.java:78: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/ResourceType.java:78: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ResourceType.java:78: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/ResourceType.java:81: Found 'DU'-anomaly for variable 'bestValue' (lines '81'-'85'). +src/net/sf/freecol/common/model/ResourceType.java:90: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ResourceType.java:90: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ResourceType.java:91: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/ResourceType.java:91: fieldCommentRequirement Required +src/net/sf/freecol/common/model/ResourceType.java:98: Avoid variables with short names like xw +src/net/sf/freecol/common/model/ResourceType.java:98: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/ResourceType.java:111: Avoid variables with short names like xr +src/net/sf/freecol/common/model/ResourceType.java:111: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Scope.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Scope.java:20: Possible God class (WMC=75, ATFD=26, TCC=0.20652173913043478) +src/net/sf/freecol/common/model/Scope.java:33: The class 'Scope' has a Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/common/model/Scope.java:33: The class 'Scope' has a Modified Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/common/model/Scope.java:33: The class 'Scope' has a Standard Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/common/model/Scope.java:39: Avoid using redundant field initializer for 'type' +src/net/sf/freecol/common/model/Scope.java:42: Avoid using redundant field initializer for 'abilityId' +src/net/sf/freecol/common/model/Scope.java:48: Avoid using redundant field initializer for 'methodName' +src/net/sf/freecol/common/model/Scope.java:54: Avoid using redundant field initializer for 'methodValue' +src/net/sf/freecol/common/model/Scope.java:60: Avoid using redundant field initializer for 'matchNegated' +src/net/sf/freecol/common/model/Scope.java:66: Document empty constructor +src/net/sf/freecol/common/model/Scope.java:66: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Scope.java:74: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Scope.java:74: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/Scope.java:74: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Scope.java:85: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Scope.java:86: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Scope.java:87: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/Scope.java:88: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/Scope.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:113: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:117: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:121: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:143: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/model/Scope.java:143: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:147: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:151: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:155: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:159: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:163: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:173: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/model/Scope.java:173: The method 'appliesTo' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/Scope.java:173: The method 'appliesTo' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/Scope.java:173: The method 'appliesTo' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/Scope.java:175: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:180: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:183: Local variable 'fcgot' could be declared final +src/net/sf/freecol/common/model/Scope.java:185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:186: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:189: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:193: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:196: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/Scope.java:197: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:197: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Scope.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Scope.java:210: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/Scope.java:224: Avoid variables with short names like o +src/net/sf/freecol/common/model/Scope.java:224: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Scope.java:224: The method 'equals' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/Scope.java:224: The method 'equals' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/Scope.java:224: The method 'equals' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/Scope.java:224: The method equals() has an NPath complexity of 4098 +src/net/sf/freecol/common/model/Scope.java:225: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:225: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Scope.java:227: Local variable 'otherScope' could be declared final +src/net/sf/freecol/common/model/Scope.java:229: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:232: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:236: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:239: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:246: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:249: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:253: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:255: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:256: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:260: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Scope.java:263: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:265: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Scope.java:274: The method hashCode() has an NPath complexity of 78125 +src/net/sf/freecol/common/model/Scope.java:275: Found 'DD'-anomaly for variable 'hash' (lines '275'-'276'). +src/net/sf/freecol/common/model/Scope.java:288: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:288: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:289: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:289: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:290: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:290: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:291: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:291: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:292: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:292: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:293: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:293: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:294: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:294: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:296: Avoid excessively long variable names like OLD_MATCH_NEGATED_TAG +src/net/sf/freecol/common/model/Scope.java:296: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:296: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:297: Avoid excessively long variable names like OLD_MATCHES_NULL_TAG +src/net/sf/freecol/common/model/Scope.java:297: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/Scope.java:297: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Scope.java:305: Avoid variables with short names like xw +src/net/sf/freecol/common/model/Scope.java:305: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/Scope.java:337: Avoid variables with short names like xr +src/net/sf/freecol/common/model/Scope.java:337: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/Scope.java:346: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Scope.java:353: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/Scope.java:380: Avoid variables with short names like sb +src/net/sf/freecol/common/model/Scope.java:380: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/Scope.java:383: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Scope.java:383: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Scope.java:386: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Scope.java:386: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Scope.java:388: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Scope.java:389: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/Scope.java:390: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/SettlementType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/SettlementType.java:35: The class 'SettlementType' has a Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/common/model/SettlementType.java:35: The class 'SettlementType' has a Modified Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/common/model/SettlementType.java:35: The class 'SettlementType' has a Standard Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/common/model/SettlementType.java:38: Avoid using redundant field initializer for 'capital' +src/net/sf/freecol/common/model/SettlementType.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:50: Avoid excessively long variable names like extraClaimableRadius +src/net/sf/freecol/common/model/SettlementType.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:77: Avoid using redundant field initializer for 'plunder' +src/net/sf/freecol/common/model/SettlementType.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:80: Avoid using redundant field initializer for 'gifts' +src/net/sf/freecol/common/model/SettlementType.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/SettlementType.java:89: Avoid variables with short names like id +src/net/sf/freecol/common/model/SettlementType.java:89: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:89: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:100: Avoid variables with short names like xr +src/net/sf/freecol/common/model/SettlementType.java:100: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:101: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:215: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:216: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/SettlementType.java:217: Avoid variables with short names like p +src/net/sf/freecol/common/model/SettlementType.java:226: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:227: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/SettlementType.java:228: Avoid variables with short names like g +src/net/sf/freecol/common/model/SettlementType.java:246: Parameter 'gift' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:247: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:256: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:257: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:264: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:264: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:265: Avoid excessively long variable names like CLAIMABLE_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:265: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:265: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:266: Avoid excessively long variable names like CONVERT_THRESHOLD_TAG +src/net/sf/freecol/common/model/SettlementType.java:266: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:266: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:267: Avoid excessively long variable names like EXTRA_CLAIMABLE_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:267: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:267: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:268: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:268: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:269: Avoid excessively long variable names like MAXIMUM_GROWTH_TAG +src/net/sf/freecol/common/model/SettlementType.java:269: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:269: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:270: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:270: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:271: Avoid excessively long variable names like MINIMUM_GROWTH_TAG +src/net/sf/freecol/common/model/SettlementType.java:271: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:271: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:272: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:272: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:273: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:273: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:274: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:274: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:275: Avoid excessively long variable names like VISIBLE_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:275: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:275: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:276: Avoid excessively long variable names like WANDERING_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:276: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:276: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:278: Avoid excessively long variable names like OLD_CLAIMABLE_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:278: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:278: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:279: Avoid excessively long variable names like OLD_CONVERT_THRESHOLD_TAG +src/net/sf/freecol/common/model/SettlementType.java:279: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:279: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:280: Avoid excessively long variable names like OLD_EXTRA_CLAIMABLE_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:280: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:280: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:281: Avoid excessively long variable names like OLD_MAXIMUM_GROWTH_TAG +src/net/sf/freecol/common/model/SettlementType.java:281: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:281: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:282: Avoid excessively long variable names like OLD_MAXIMUM_SIZE_TAG +src/net/sf/freecol/common/model/SettlementType.java:282: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:282: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:283: Avoid excessively long variable names like OLD_MINIMUM_GROWTH_TAG +src/net/sf/freecol/common/model/SettlementType.java:283: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:283: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:284: Avoid excessively long variable names like OLD_MINIMUM_SIZE_TAG +src/net/sf/freecol/common/model/SettlementType.java:284: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:284: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:285: Avoid excessively long variable names like OLD_TRADE_BONUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:285: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:285: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:286: Avoid excessively long variable names like OLD_VISIBLE_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:286: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:286: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:287: Avoid excessively long variable names like OLD_WANDERING_RADIUS_TAG +src/net/sf/freecol/common/model/SettlementType.java:287: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/SettlementType.java:287: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SettlementType.java:295: Avoid variables with short names like xw +src/net/sf/freecol/common/model/SettlementType.java:295: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:325: Avoid variables with short names like xw +src/net/sf/freecol/common/model/SettlementType.java:325: Found 'UR'-anomaly for variable 'range' (lines '325'-'329'). +src/net/sf/freecol/common/model/SettlementType.java:325: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:329: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:329: Local variable 'range' could be declared final +src/net/sf/freecol/common/model/SettlementType.java:333: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:333: Local variable 'range' could be declared final +src/net/sf/freecol/common/model/SettlementType.java:341: Avoid variables with short names like xr +src/net/sf/freecol/common/model/SettlementType.java:341: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:341: The method 'readAttributes' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/SettlementType.java:341: The method 'readAttributes' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/SettlementType.java:341: The method 'readAttributes' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/SettlementType.java:341: The method readAttributes() has an NPath complexity of 1024 +src/net/sf/freecol/common/model/SettlementType.java:351: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:358: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:365: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:372: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:379: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:386: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:393: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:400: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:407: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:414: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/SettlementType.java:421: Avoid variables with short names like xr +src/net/sf/freecol/common/model/SettlementType.java:421: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/SettlementType.java:424: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/SettlementType.java:425: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/SettlementType.java:435: Avoid variables with short names like xr +src/net/sf/freecol/common/model/SettlementType.java:435: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/SimpleCombatModel.java:20: Possible God class (WMC=150, ATFD=202, TCC=0.0) +src/net/sf/freecol/common/model/SimpleCombatModel.java:45: The class 'SimpleCombatModel' has a Cyclomatic Complexity of 8 (Highest = 53). +src/net/sf/freecol/common/model/SimpleCombatModel.java:45: The class 'SimpleCombatModel' has a Modified Cyclomatic Complexity of 6 (Highest = 37). +src/net/sf/freecol/common/model/SimpleCombatModel.java:45: The class 'SimpleCombatModel' has a Standard Cyclomatic Complexity of 6 (Highest = 37). +src/net/sf/freecol/common/model/SimpleCombatModel.java:45: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/SimpleCombatModel.java:47: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/SimpleCombatModel.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SimpleCombatModel.java:53: Avoid excessively long variable names like MAXIMUM_BOMBARD_POWER +src/net/sf/freecol/common/model/SimpleCombatModel.java:56: Avoid excessively long variable names like STRONG_DEFENCE_THRESHOLD +src/net/sf/freecol/common/model/SimpleCombatModel.java:58: Avoid excessively long variable names like UNKNOWN_DEFENCE_MODIFIER +src/net/sf/freecol/common/model/SimpleCombatModel.java:58: fieldCommentRequirement Required +src/net/sf/freecol/common/model/SimpleCombatModel.java:65: Avoid unnecessary constructors - the compiler will generate these for you +src/net/sf/freecol/common/model/SimpleCombatModel.java:65: Document empty constructor +src/net/sf/freecol/common/model/SimpleCombatModel.java:65: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/SimpleCombatModel.java:76: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:77: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:89: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:89: The method 'calculateCombatOdds' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/SimpleCombatModel.java:90: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:91: Avoid variables with short names like lb +src/net/sf/freecol/common/model/SimpleCombatModel.java:91: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:93: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/SimpleCombatModel.java:97: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:98: Local variable 'attackPower' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:99: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:100: Local variable 'defencePower' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:102: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/SimpleCombatModel.java:105: Local variable 'victory' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:106: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:118: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:119: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:129: Avoid variables with short names like lb +src/net/sf/freecol/common/model/SimpleCombatModel.java:129: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:129: Parameter 'modSet' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:142: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:142: The method 'getOffencePower' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/SimpleCombatModel.java:143: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:144: Avoid variables with short names like lb +src/net/sf/freecol/common/model/SimpleCombatModel.java:144: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:145: Found 'DD'-anomaly for variable 'result' (lines '145'-'154'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:145: Found 'DU'-anomaly for variable 'result' (lines '145'-'174'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:152: Local variable 'mods' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:153: Local variable 'turn' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:161: Avoid excessively long variable names like attackerSettlement +src/net/sf/freecol/common/model/SimpleCombatModel.java:161: Local variable 'attackerSettlement' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:164: Avoid variables with short names like u +src/net/sf/freecol/common/model/SimpleCombatModel.java:165: Avoid variables with short names like u +src/net/sf/freecol/common/model/SimpleCombatModel.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:167: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:168: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:171: The String literal "Bogus combat" appears 6 times in this file; the first occurrence is on line 171 +src/net/sf/freecol/common/model/SimpleCombatModel.java:184: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:185: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:197: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:198: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:199: Avoid variables with short names like lb +src/net/sf/freecol/common/model/SimpleCombatModel.java:199: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:205: Local variable 'mods' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:206: Local variable 'turn' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:206: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:227: Found 'UR'-anomaly for variable 'r' (lines '227'-'279'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:227: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:227: The method 'getOffensiveModifiers' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/SimpleCombatModel.java:228: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:229: Found 'DU'-anomaly for variable 'result' (lines '229'-'286'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:229: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:230: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/model/SimpleCombatModel.java:230: Avoid unused local variables such as 'm'. +src/net/sf/freecol/common/model/SimpleCombatModel.java:230: Avoid variables with short names like m +src/net/sf/freecol/common/model/SimpleCombatModel.java:230: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:256: Local variable 'owner' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:263: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:270: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/SimpleCombatModel.java:270: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/SimpleCombatModel.java:278: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:294: Found 'UR'-anomaly for variable 'm' (lines '294'-'304'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:294: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:295: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:301: Local variable 'goodsCount' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:303: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:304: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/SimpleCombatModel.java:304: Avoid variables with short names like c +src/net/sf/freecol/common/model/SimpleCombatModel.java:304: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:318: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:318: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:319: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:322: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:338: Found 'UR'-anomaly for variable 'm' (lines '338'-'394'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:338: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:338: The method 'addLandOffensiveModifiers' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/SimpleCombatModel.java:338: The method 'addLandOffensiveModifiers' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/SimpleCombatModel.java:338: The method 'addLandOffensiveModifiers' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/SimpleCombatModel.java:338: The method addLandOffensiveModifiers() has an NPath complexity of 240 +src/net/sf/freecol/common/model/SimpleCombatModel.java:339: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:340: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:352: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:364: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/SimpleCombatModel.java:364: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/SimpleCombatModel.java:376: Local variable 'defenderUnit' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:377: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:377: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:393: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:394: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/SimpleCombatModel.java:394: Local variable 'mod' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:424: Found 'UR'-anomaly for variable 'r' (lines '424'-'475'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:424: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:425: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:426: Found 'DU'-anomaly for variable 'result' (lines '426'-'482'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:426: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:431: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:431: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:435: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:444: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:455: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:457: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:474: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:490: Found 'UR'-anomaly for variable 'm' (lines '490'-'498'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:490: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:491: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:492: Found 'DU'-anomaly for variable 'spec' (lines '492'-'503'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:495: Local variable 'goodsCount' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:497: Local variable 'm' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:497: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:498: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/SimpleCombatModel.java:498: Avoid variables with short names like c +src/net/sf/freecol/common/model/SimpleCombatModel.java:498: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:511: Parameter 'fco' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:513: Avoid variables with short names like m +src/net/sf/freecol/common/model/SimpleCombatModel.java:524: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:524: The method 'addLandDefensiveModifiers' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/SimpleCombatModel.java:524: The method 'addLandDefensiveModifiers' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/SimpleCombatModel.java:524: The method 'addLandDefensiveModifiers' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/SimpleCombatModel.java:524: The method addLandDefensiveModifiers() has an NPath complexity of 410 +src/net/sf/freecol/common/model/SimpleCombatModel.java:525: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:526: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:527: Found 'DU'-anomaly for variable 'spec' (lines '527'-'580'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:529: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/SimpleCombatModel.java:529: Found 'DU'-anomaly for variable 'settlement' (lines '529'-'580'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:530: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:536: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:541: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:541: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:561: Local variable 'autoRole' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:567: Local variable 'stockade' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:577: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:582: Comment is too large: Too many lines +src/net/sf/freecol/common/model/SimpleCombatModel.java:592: Found 'UR'-anomaly for variable 'cr' (lines '592'-'686'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:592: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:592: The method 'generateAttackResult' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/SimpleCombatModel.java:593: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:593: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:594: Avoid variables with short names like lb +src/net/sf/freecol/common/model/SimpleCombatModel.java:594: Local variable 'lb' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:595: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:596: Found 'DU'-anomaly for variable 'crs' (lines '596'-'690'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:596: Local variable 'crs' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:597: Found 'DU'-anomaly for variable 'odds' (lines '597'-'690'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:597: Local variable 'odds' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:598: Avoid variables with short names like r +src/net/sf/freecol/common/model/SimpleCombatModel.java:598: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:599: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:600: Found 'DD'-anomaly for variable 'great' (lines '600'-'624'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:600: Found 'DD'-anomaly for variable 'great' (lines '600'-'634'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:600: Found 'DD'-anomaly for variable 'great' (lines '600'-'660'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:600: Found 'DU'-anomaly for variable 'great' (lines '600'-'690'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:604: Found 'DU'-anomaly for variable 'attackerUnit' (lines '604'-'690'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:604: Local variable 'attackerUnit' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:605: Local variable 'defenderUnit' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:630: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:631: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:632: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:635: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:643: Local variable 'defenderUnit' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:644: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:653: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:657: Local variable 'offencePower' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:658: Local variable 'defencePower' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:659: Local variable 'diff' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:665: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:667: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:674: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:675: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:685: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:686: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:686: Local variable 'cr' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:686: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:687: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:692: Comment is too large: Too many lines +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: Avoid really long methods. +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: Parameter 'great' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: The method 'resolveAttack' has a Cyclomatic Complexity of 53. +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: The method 'resolveAttack' has a Modified Cyclomatic Complexity of 37. +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: The method 'resolveAttack' has a Standard Cyclomatic Complexity of 37. +src/net/sf/freecol/common/model/SimpleCombatModel.java:701: The method resolveAttack() has an NPath complexity of 262600 +src/net/sf/freecol/common/model/SimpleCombatModel.java:702: Avoid variables with short names like r +src/net/sf/freecol/common/model/SimpleCombatModel.java:702: Parameter 'crs' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:702: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:703: Found 'DU'-anomaly for variable 'loserPlayer' (lines '703'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:703: Local variable 'loserPlayer' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:704: Found 'DU'-anomaly for variable 'tile' (lines '704'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:704: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:705: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:706: Found 'DU'-anomaly for variable 'attackerWon' (lines '706'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:706: Local variable 'attackerWon' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:707: Found 'DD'-anomaly for variable 'loserMustDie' (lines '707'-'762'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:707: Found 'DU'-anomaly for variable 'loserMustDie' (lines '707'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:714: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:727: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/SimpleCombatModel.java:727: Local variable 'autoRole' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:727: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:727: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:728: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:731: Found 'DD'-anomaly for variable 'done' (lines '731'-'754'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:731: Found 'DD'-anomaly for variable 'done' (lines '731'-'758'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:731: Found 'DD'-anomaly for variable 'done' (lines '731'-'763'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:731: Found 'DD'-anomaly for variable 'done' (lines '731'-'769'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:731: Found 'DD'-anomaly for variable 'done' (lines '731'-'791'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:731: Found 'DD'-anomaly for variable 'done' (lines '731'-'810'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:732: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:732: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:734: Found 'DU'-anomaly for variable 'colony' (lines '734'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:742: Local variable 'ships' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:742: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:743: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/SimpleCombatModel.java:743: Found 'DU'-anomaly for variable 'shipResult' (lines '743'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:743: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:743: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:743: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:743: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:744: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:744: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:748: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:752: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:756: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:760: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:762: Found 'DU'-anomaly for variable 'loserMustDie' (lines '762'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:767: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/SimpleCombatModel.java:774: Avoid variables with short names like is +src/net/sf/freecol/common/model/SimpleCombatModel.java:774: Found 'DU'-anomaly for variable 'is' (lines '774'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:781: Found 'DD'-anomaly for variable 'lose' (lines '781'-'787'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:791: Found 'DD'-anomaly for variable 'done' (lines '791'-'810'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:796: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:802: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:802: These nested if statements could be combined +src/net/sf/freecol/common/model/SimpleCombatModel.java:803: Avoid variables with short names like s +src/net/sf/freecol/common/model/SimpleCombatModel.java:808: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:808: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:815: Found 'DU'-anomaly for variable 'loserRole' (lines '815'-'877'). +src/net/sf/freecol/common/model/SimpleCombatModel.java:819: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/SimpleCombatModel.java:820: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/SimpleCombatModel.java:837: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:838: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/SimpleCombatModel.java:856: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/SimpleCombatModel.java:868: Local variable 'promotion' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:868: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:872: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:872: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:873: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:873: Useless parentheses. +src/net/sf/freecol/common/model/SimpleCombatModel.java:874: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:886: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:887: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:889: Local variable 'attackerUnit' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:890: Local variable 'defenderUnit' could be declared final +src/net/sf/freecol/common/model/SimpleCombatModel.java:891: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/SimpleCombatModel.java:891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:892: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:893: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:894: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:895: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:897: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:898: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:898: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:898: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:898: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:898: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/SimpleCombatModel.java:899: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/SimpleCombatModel.java:899: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Stance.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Stance.java:20: Possible God class (WMC=47, ATFD=23, TCC=0.0) +src/net/sf/freecol/common/model/Stance.java:23: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/Stance.java:24: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/Stance.java:29: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Stance.java:42: The class 'Stance' has a Cyclomatic Complexity of 5(Highest = 26). +src/net/sf/freecol/common/model/Stance.java:42: The class 'Stance' has a Standard Cyclomatic Complexity of 5(Highest = 26). +src/net/sf/freecol/common/model/Stance.java:54: Parameter 'newStance' is not assigned and could be declared final +src/net/sf/freecol/common/model/Stance.java:59: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Stance.java:68: Parameter 'tension' is not assigned and could be declared final +src/net/sf/freecol/common/model/Stance.java:69: Found 'DU'-anomaly for variable 'value' (lines '69'-'92'). +src/net/sf/freecol/common/model/Stance.java:69: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/Stance.java:72: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Stance.java:73: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:77: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Stance.java:78: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:82: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/Stance.java:83: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:101: Parameter 'newStance' is not assigned and could be declared final +src/net/sf/freecol/common/model/Stance.java:101: The method 'getTensionModifier' has a Cyclomatic Complexity of 26. +src/net/sf/freecol/common/model/Stance.java:101: The method 'getTensionModifier' has a Standard Cyclomatic Complexity of 26. +src/net/sf/freecol/common/model/Stance.java:105: A switch statement does not contain a break +src/net/sf/freecol/common/model/Stance.java:107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:109: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:114: A switch statement does not contain a break +src/net/sf/freecol/common/model/Stance.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:117: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:118: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:123: A switch statement does not contain a break +src/net/sf/freecol/common/model/Stance.java:127: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:132: A switch statement does not contain a break +src/net/sf/freecol/common/model/Stance.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:134: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:135: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/Stance.java:136: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StanceTradeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/StanceTradeItem.java:27: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/StanceTradeItem.java:48: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:48: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:48: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:49: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:63: Avoid variables with short names like xr +src/net/sf/freecol/common/model/StanceTradeItem.java:63: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:63: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:106: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:113: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:116: Found 'DD'-anomaly for variable 'value' (lines '116'-'120'). +src/net/sf/freecol/common/model/StanceTradeItem.java:116: Found 'DD'-anomaly for variable 'value' (lines '116'-'124'). +src/net/sf/freecol/common/model/StanceTradeItem.java:116: Found 'DD'-anomaly for variable 'value' (lines '116'-'125'). +src/net/sf/freecol/common/model/StanceTradeItem.java:116: Found 'DU'-anomaly for variable 'value' (lines '116'-'131'). +src/net/sf/freecol/common/model/StanceTradeItem.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StanceTradeItem.java:119: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/StanceTradeItem.java:119: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StanceTradeItem.java:120: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/StanceTradeItem.java:120: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StanceTradeItem.java:123: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StanceTradeItem.java:123: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/StanceTradeItem.java:123: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StanceTradeItem.java:124: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/StanceTradeItem.java:124: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/StanceTradeItem.java:125: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/StanceTradeItem.java:125: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StanceTradeItem.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StanceTradeItem.java:140: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:142: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StanceTradeItem.java:153: Local variable 'hash' could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StanceTradeItem.java:160: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/StanceTradeItem.java:160: fieldCommentRequirement Required +src/net/sf/freecol/common/model/StanceTradeItem.java:167: Avoid variables with short names like xw +src/net/sf/freecol/common/model/StanceTradeItem.java:167: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:178: Avoid variables with short names like sb +src/net/sf/freecol/common/model/StanceTradeItem.java:178: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/StanceTradeItem.java:179: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/StanceTradeItem.java:180: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/StanceTradeItem.java:180: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/StanceTradeItem.java:188: Avoid variables with short names like xr +src/net/sf/freecol/common/model/StanceTradeItem.java:188: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/StringTemplate.java:20: Possible God class (WMC=95, ATFD=33, TCC=0.013227513227513227) +src/net/sf/freecol/common/model/StringTemplate.java:34: Comment is too large: Too many lines +src/net/sf/freecol/common/model/StringTemplate.java:47: The class 'StringTemplate' has a Cyclomatic Complexity of 2 (Highest = 19). +src/net/sf/freecol/common/model/StringTemplate.java:47: The class 'StringTemplate' has a Modified Cyclomatic Complexity of 2 (Highest = 15). +src/net/sf/freecol/common/model/StringTemplate.java:47: The class 'StringTemplate' has a Standard Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/common/model/StringTemplate.java:47: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/StringTemplate.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/StringTemplate.java:66: Avoid using redundant field initializer for 'defaultId' +src/net/sf/freecol/common/model/StringTemplate.java:69: Avoid using redundant field initializer for 'keys' +src/net/sf/freecol/common/model/StringTemplate.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/StringTemplate.java:72: Avoid using redundant field initializer for 'replacements' +src/net/sf/freecol/common/model/StringTemplate.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/StringTemplate.java:78: Document empty constructor +src/net/sf/freecol/common/model/StringTemplate.java:78: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/StringTemplate.java:86: Avoid variables with short names like id +src/net/sf/freecol/common/model/StringTemplate.java:86: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/StringTemplate.java:86: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:86: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:101: Avoid variables with short names like id +src/net/sf/freecol/common/model/StringTemplate.java:101: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/StringTemplate.java:101: Parameter 'defaultId' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:101: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:102: Parameter 'templateType' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:106: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/StringTemplate.java:107: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/StringTemplate.java:116: Avoid variables with short names like xr +src/net/sf/freecol/common/model/StringTemplate.java:116: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/StringTemplate.java:116: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:123: Avoid variables with short names like id +src/net/sf/freecol/common/model/StringTemplate.java:123: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:123: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:123: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:127: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:127: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:129: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/StringTemplate.java:129: There is log block not surrounded by if +src/net/sf/freecol/common/model/StringTemplate.java:134: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:134: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:138: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:138: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:142: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:142: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:146: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:146: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:150: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:150: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:197: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:198: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:218: Parameter 'replacement' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:219: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:229: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:233: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:233: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/StringTemplate.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:233: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:233: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:241: Comment is too large: Too many lines +src/net/sf/freecol/common/model/StringTemplate.java:250: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:250: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:253: The String literal " to StringTemplate." appears 7 times in this file; the first occurrence is on line 253 +src/net/sf/freecol/common/model/StringTemplate.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:268: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:277: Comment is too large: Too many lines +src/net/sf/freecol/common/model/StringTemplate.java:286: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:286: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:292: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:296: Comment is too large: Too many lines +src/net/sf/freecol/common/model/StringTemplate.java:305: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:305: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:311: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:323: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:339: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:339: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:349: Parameter 'named' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:360: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:360: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:364: Comment is too large: Too many lines +src/net/sf/freecol/common/model/StringTemplate.java:373: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:374: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:392: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:408: Avoid variables with short names like o +src/net/sf/freecol/common/model/StringTemplate.java:408: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:408: The method 'equals' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/common/model/StringTemplate.java:408: The method 'equals' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/common/model/StringTemplate.java:408: The method 'equals' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/StringTemplate.java:408: The method equals() has an NPath complexity of 282 +src/net/sf/freecol/common/model/StringTemplate.java:409: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:409: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:411: Avoid variables with short names like t +src/net/sf/freecol/common/model/StringTemplate.java:411: Local variable 't' could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:412: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:414: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:414: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:417: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:417: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:417: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:417: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:417: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:418: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:420: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:420: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/model/StringTemplate.java:420: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/StringTemplate.java:422: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:424: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:424: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/model/StringTemplate.java:425: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:425: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/StringTemplate.java:430: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:430: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:430: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:430: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:430: Useless parentheses. +src/net/sf/freecol/common/model/StringTemplate.java:431: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:433: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:433: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/model/StringTemplate.java:433: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/StringTemplate.java:434: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:436: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:436: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/model/StringTemplate.java:437: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:437: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/StringTemplate.java:444: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/StringTemplate.java:453: Found 'UR'-anomaly for variable 'key' (lines '453'-'460'). +src/net/sf/freecol/common/model/StringTemplate.java:453: Found 'UR'-anomaly for variable 'replacement' (lines '453'-'465'). +src/net/sf/freecol/common/model/StringTemplate.java:454: Found 'DD'-anomaly for variable 'hash' (lines '454'-'455'). +src/net/sf/freecol/common/model/StringTemplate.java:456: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:457: A switch statement does not contain a break +src/net/sf/freecol/common/model/StringTemplate.java:459: Local variable 'key' could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:464: Local variable 'replacement' could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:477: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/StringTemplate.java:477: fieldCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:478: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/StringTemplate.java:478: fieldCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:479: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/StringTemplate.java:479: fieldCommentRequirement Required +src/net/sf/freecol/common/model/StringTemplate.java:486: Avoid variables with short names like xw +src/net/sf/freecol/common/model/StringTemplate.java:486: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:500: Avoid variables with short names like xw +src/net/sf/freecol/common/model/StringTemplate.java:500: Found 'UR'-anomaly for variable 'key' (lines '500'-'507'). +src/net/sf/freecol/common/model/StringTemplate.java:500: Found 'UR'-anomaly for variable 'replacement' (lines '500'-'515'). +src/net/sf/freecol/common/model/StringTemplate.java:500: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:504: Local variable 'key' could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:514: Local variable 'replacement' could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:524: Avoid variables with short names like xr +src/net/sf/freecol/common/model/StringTemplate.java:524: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:537: Avoid variables with short names like xr +src/net/sf/freecol/common/model/StringTemplate.java:537: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:539: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:540: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/StringTemplate.java:549: Avoid variables with short names like xr +src/net/sf/freecol/common/model/StringTemplate.java:549: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:556: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/StringTemplate.java:568: Found 'UR'-anomaly for variable 'object' (lines '568'-'577'). +src/net/sf/freecol/common/model/StringTemplate.java:568: The method 'toString' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/StringTemplate.java:568: The method 'toString' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/StringTemplate.java:569: Avoid variables with short names like sb +src/net/sf/freecol/common/model/StringTemplate.java:569: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:576: Local variable 'object' could be declared final +src/net/sf/freecol/common/model/StringTemplate.java:584: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/StringTemplate.java:589: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/StringTemplate.java:590: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/StringTemplate.java:593: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/StringTemplate.java:598: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/Tension.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Tension.java:33: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:35: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:39: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:41: Avoid excessively long variable names like TENSION_ADD_NORMAL +src/net/sf/freecol/common/model/Tension.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:45: Avoid excessively long variable names like TENSION_ADD_LAND_TAKEN +src/net/sf/freecol/common/model/Tension.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:47: Avoid excessively long variable names like TENSION_ADD_UNIT_DESTROYED +src/net/sf/freecol/common/model/Tension.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:49: Avoid excessively long variable names like TENSION_ADD_SETTLEMENT_ATTACKED +src/net/sf/freecol/common/model/Tension.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:51: Avoid excessively long variable names like TENSION_ADD_CAPITAL_ATTACKED +src/net/sf/freecol/common/model/Tension.java:51: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:53: Avoid excessively long variable names like TENSION_ADD_WAR_INCITER +src/net/sf/freecol/common/model/Tension.java:53: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:56: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:57: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:58: Avoid excessively long variable names like DROP_ALLIANCE_MODIFIER +src/net/sf/freecol/common/model/Tension.java:58: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:59: Avoid excessively long variable names like PEACE_TREATY_MODIFIER +src/net/sf/freecol/common/model/Tension.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:60: Avoid excessively long variable names like CEASE_FIRE_MODIFIER +src/net/sf/freecol/common/model/Tension.java:60: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:62: Avoid excessively long variable names like RESUME_WAR_MODIFIER +src/net/sf/freecol/common/model/Tension.java:62: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:78: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:80: Parameter 'limit' is not assigned and could be declared final +src/net/sf/freecol/common/model/Tension.java:84: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:98: fieldCommentRequirement Required +src/net/sf/freecol/common/model/Tension.java:113: Parameter 'newTension' is not assigned and could be declared final +src/net/sf/freecol/common/model/Tension.java:132: Parameter 'newValue' is not assigned and could be declared final +src/net/sf/freecol/common/model/Tension.java:157: Parameter 'newTension' is not assigned and could be declared final +src/net/sf/freecol/common/model/Tension.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Tension.java:186: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovement.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovement.java:20: Possible God class (WMC=106, ATFD=52, TCC=0.11428571428571428) +src/net/sf/freecol/common/model/TileImprovement.java:33: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/TileImprovement.java:39: The class 'TileImprovement' has a Cyclomatic Complexity of 3 (Highest = 13). +src/net/sf/freecol/common/model/TileImprovement.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/TileImprovement.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovement.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovement.java:72: Avoid using redundant field initializer for 'connected' +src/net/sf/freecol/common/model/TileImprovement.java:72: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovement.java:75: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovement.java:85: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:85: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:85: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:96: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:107: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:107: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:107: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:115: Overridable method 'getConnectionDirections' called during object construction +src/net/sf/freecol/common/model/TileImprovement.java:118: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovement.java:127: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileImprovement.java:127: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:127: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:159: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovement.java:170: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:170: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:172: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:189: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:207: Parameter 'magnitude' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:246: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:256: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:256: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:257: Local variable 'now' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:273: Found 'UR'-anomaly for variable 'd' (lines '273'-'278'). +src/net/sf/freecol/common/model/TileImprovement.java:274: Local variable 'dirns' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:275: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovement.java:275: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:276: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TileImprovement.java:276: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:277: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:278: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:278: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:288: Found 'UR'-anomaly for variable 'd' (lines '288'-'293'). +src/net/sf/freecol/common/model/TileImprovement.java:289: Local variable 'dirns' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:290: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovement.java:290: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:290: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovement.java:291: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/TileImprovement.java:291: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:292: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:293: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:305: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:306: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:306: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:306: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:317: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:317: Parameter 'moveCost' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:318: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:318: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:330: Parameter 'tileType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:331: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:331: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:331: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:340: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:341: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:341: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:355: Local variable 'directions' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:357: Found 'DU'-anomaly for variable 'mask' (lines '357'-'366'). +src/net/sf/freecol/common/model/TileImprovement.java:357: Local variable 'mask' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:359: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/TileImprovement.java:359: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovement.java:360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:375: Found 'UR'-anomaly for variable 'd' (lines '375'-'381'). +src/net/sf/freecol/common/model/TileImprovement.java:375: Parameter 'conns' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:375: The method 'updateRiverConnections' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/TileImprovement.java:375: The method updateRiverConnections() has an NPath complexity of 1260 +src/net/sf/freecol/common/model/TileImprovement.java:376: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovement.java:376: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:377: Found 'DU'-anomaly for variable 'tile' (lines '377'-'399'). +src/net/sf/freecol/common/model/TileImprovement.java:378: Avoid variables with short names like i +src/net/sf/freecol/common/model/TileImprovement.java:378: Found 'DU'-anomaly for variable 'i' (lines '378'-'399'). +src/net/sf/freecol/common/model/TileImprovement.java:379: Found 'DU'-anomaly for variable 'ret' (lines '379'-'399'). +src/net/sf/freecol/common/model/TileImprovement.java:380: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:381: Found 'DD'-anomaly for variable 'dReverse' (lines '381'-'381'). +src/net/sf/freecol/common/model/TileImprovement.java:381: Found 'DU'-anomaly for variable 'dReverse' (lines '381'-'399'). +src/net/sf/freecol/common/model/TileImprovement.java:381: Local variable 'dReverse' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:382: Avoid variables with short names like t +src/net/sf/freecol/common/model/TileImprovement.java:382: Local variable 't' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:383: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:383: Local variable 'river' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:384: Avoid variables with short names like c +src/net/sf/freecol/common/model/TileImprovement.java:384: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:392: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:395: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/model/TileImprovement.java:396: Found 'DU'-anomaly for variable 'i' (lines '396'-'399'). +src/net/sf/freecol/common/model/TileImprovement.java:398: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:408: Found 'UR'-anomaly for variable 'd' (lines '408'-'413'). +src/net/sf/freecol/common/model/TileImprovement.java:408: Parameter 'connect' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:408: The method updateRoadConnections() has an NPath complexity of 240 +src/net/sf/freecol/common/model/TileImprovement.java:409: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovement.java:409: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:410: Found 'DU'-anomaly for variable 'tile' (lines '410'-'421'). +src/net/sf/freecol/common/model/TileImprovement.java:411: Avoid unused local variables such as 'ret'. +src/net/sf/freecol/common/model/TileImprovement.java:411: Found 'DU'-anomaly for variable 'ret' (lines '411'-'421'). +src/net/sf/freecol/common/model/TileImprovement.java:411: Local variable 'ret' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:412: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:413: Avoid variables with short names like t +src/net/sf/freecol/common/model/TileImprovement.java:413: Local variable 't' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:413: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:414: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:414: Local variable 'road' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:415: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:416: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:420: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:431: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:449: Parameter 'tileType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:457: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:457: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:458: Parameter 'potential' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:479: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:479: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:489: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:490: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:492: Local variable 'disableUnattended' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovement.java:496: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:496: Local variable 'modifier' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:496: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:496: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:499: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:501: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovement.java:504: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovement.java:530: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:530: The method 'checkIntegrity' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/TileImprovement.java:530: The method checkIntegrity() has an NPath complexity of 450 +src/net/sf/freecol/common/model/TileImprovement.java:531: Found 'DD'-anomaly for variable 'result' (lines '531'-'545'). +src/net/sf/freecol/common/model/TileImprovement.java:531: Found 'DD'-anomaly for variable 'result' (lines '531'-'551'). +src/net/sf/freecol/common/model/TileImprovement.java:531: Found 'DD'-anomaly for variable 'result' (lines '531'-'555'). +src/net/sf/freecol/common/model/TileImprovement.java:531: Found 'DD'-anomaly for variable 'result' (lines '531'-'560'). +src/net/sf/freecol/common/model/TileImprovement.java:539: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:539: Local variable 'curr' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:540: Local variable 'found' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:540: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:540: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:542: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:543: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:543: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:544: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:544: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:548: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/TileImprovement.java:548: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:548: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:549: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:549: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovement.java:550: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileImprovement.java:553: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileImprovement.java:558: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileImprovement.java:569: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovement.java:569: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:570: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovement.java:570: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:571: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovement.java:571: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:572: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovement.java:572: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:573: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovement.java:573: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:574: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovement.java:574: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovement.java:581: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileImprovement.java:581: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:592: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:594: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:601: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileImprovement.java:601: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:601: The method 'readAttributes' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/TileImprovement.java:630: Local variable 'str' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:631: Local variable 'dirns' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:632: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:633: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:635: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/TileImprovement.java:635: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:636: Local variable 'old' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:637: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:643: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileImprovement.java:647: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovement.java:647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovement.java:651: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovement.java:668: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TileImprovement.java:668: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TileImprovement.java:669: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TileImprovement.java:669: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovement.java:673: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TileImprovement.java:673: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovement.java:674: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TileImprovementStyle.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovementStyle.java:26: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovementStyle.java:52: A class which only has private constructors should be final +src/net/sf/freecol/common/model/TileImprovementStyle.java:55: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/TileImprovementStyle.java:55: Variables that are final and static should be all capitals, 'cache' is not all capitals. +src/net/sf/freecol/common/model/TileImprovementStyle.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementStyle.java:69: Parameter 'style' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:72: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TileImprovementStyle.java:72: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:74: Avoid variables with short names like c +src/net/sf/freecol/common/model/TileImprovementStyle.java:74: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:75: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementStyle.java:110: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:110: Parameter 'pad' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:111: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementStyle.java:111: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementStyle.java:112: Found 'DU'-anomaly for variable 'isZero' (lines '112'-'130'). +src/net/sf/freecol/common/model/TileImprovementStyle.java:113: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TileImprovementStyle.java:113: Found 'DU'-anomaly for variable 'sb' (lines '113'-'130'). +src/net/sf/freecol/common/model/TileImprovementStyle.java:113: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:115: Found 'DU'-anomaly for variable 'value' (lines '115'-'130'). +src/net/sf/freecol/common/model/TileImprovementStyle.java:117: Local variable 'magnitude' could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:123: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementStyle.java:125: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementStyle.java:125: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementStyle.java:127: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TileImprovementStyle.java:139: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementStyle.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementStyle.java:140: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/TileImprovementStyle.java:140: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementStyle.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovementType.java:20: Possible God class (WMC=74, ATFD=49, TCC=0.10606060606060606) +src/net/sf/freecol/common/model/TileImprovementType.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:54: Avoid excessively long variable names like requiredImprovementType +src/net/sf/freecol/common/model/TileImprovementType.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:64: Avoid using redundant field initializer for 'deliverGoodsType' +src/net/sf/freecol/common/model/TileImprovementType.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:85: Avoid excessively long variable names like exposeResourcePercent +src/net/sf/freecol/common/model/TileImprovementType.java:85: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:88: Avoid using redundant field initializer for 'allowedWorkers' +src/net/sf/freecol/common/model/TileImprovementType.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:91: Avoid using redundant field initializer for 'tileTypeChanges' +src/net/sf/freecol/common/model/TileImprovementType.java:91: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:94: Avoid using redundant field initializer for 'disasters' +src/net/sf/freecol/common/model/TileImprovementType.java:94: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:100: Avoid using redundant field initializer for 'scopes' +src/net/sf/freecol/common/model/TileImprovementType.java:100: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileImprovementType.java:109: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileImprovementType.java:109: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:109: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:194: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:195: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementType.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:217: Parameter 'disaster' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:217: Parameter 'probability' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:218: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementType.java:245: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileImprovementType.java:245: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:258: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:271: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:276: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovementType.java:287: Parameter 'tileType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:288: Avoid variables with short names like s +src/net/sf/freecol/common/model/TileImprovementType.java:291: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:291: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:292: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:294: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementType.java:296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:300: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:300: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:301: Local variable 'modifierSet' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:303: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementType.java:305: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/TileImprovementType.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:306: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileImprovementType.java:309: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:329: Parameter 'from' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:330: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementType.java:330: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementType.java:331: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:332: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovementType.java:332: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:341: Parameter 'tileType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:342: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileImprovementType.java:342: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementType.java:343: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:344: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovementType.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:354: Parameter 'tileType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:365: Parameter 'change' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:366: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileImprovementType.java:370: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileImprovementType.java:381: Parameter 'originalCost' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:382: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovementType.java:382: Useless parentheses. +src/net/sf/freecol/common/model/TileImprovementType.java:395: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:395: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:396: Found 'DU'-anomaly for variable 'colonistType' (lines '396'-'417'). +src/net/sf/freecol/common/model/TileImprovementType.java:397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:398: Found 'DD'-anomaly for variable 'value' (lines '398'-'408'). +src/net/sf/freecol/common/model/TileImprovementType.java:398: Found 'DD'-anomaly for variable 'value' (lines '398'-'413'). +src/net/sf/freecol/common/model/TileImprovementType.java:400: Found 'DU'-anomaly for variable 'oldProduction' (lines '400'-'417'). +src/net/sf/freecol/common/model/TileImprovementType.java:400: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:402: Avoid variables with short names like tt +src/net/sf/freecol/common/model/TileImprovementType.java:402: Local variable 'tt' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:404: Local variable 'production' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:406: Local variable 'chg' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:411: Local variable 'chg' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:422: Avoid excessively long variable names like ADD_WORK_TURNS_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:422: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:422: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:423: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:423: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:424: Avoid excessively long variable names like DELIVER_AMOUNT_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:424: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:424: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:425: Avoid excessively long variable names like DELIVER_GOODS_TYPE_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:425: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:425: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:426: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:426: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:427: Avoid excessively long variable names like EXPENDED_AMOUNT_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:427: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:427: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:428: Avoid excessively long variable names like EXPOSE_RESOURCE_PERCENT_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:428: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:428: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:429: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:429: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:430: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:430: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:431: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:431: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:432: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:432: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:433: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:433: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:434: Avoid excessively long variable names like REQUIRED_IMPROVEMENT_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:434: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:434: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:435: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:435: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:436: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:436: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:437: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:437: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:438: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:438: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:440: Avoid excessively long variable names like EXPENDED_EQUIPMENT_TYPE_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:440: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:440: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:443: Avoid excessively long variable names like OLD_EXPOSE_RESOURCE_PERCENT_TAG +src/net/sf/freecol/common/model/TileImprovementType.java:443: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileImprovementType.java:443: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileImprovementType.java:452: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileImprovementType.java:452: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:485: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileImprovementType.java:485: Found 'UR'-anomaly for variable 'choice' (lines '485'-'510'). +src/net/sf/freecol/common/model/TileImprovementType.java:485: Found 'UR'-anomaly for variable 'e' (lines '485'-'503'). +src/net/sf/freecol/common/model/TileImprovementType.java:485: Found 'UR'-anomaly for variable 'id' (lines '485'-'494'). +src/net/sf/freecol/common/model/TileImprovementType.java:485: Found 'UR'-anomaly for variable 'scope' (lines '485'-'488'). +src/net/sf/freecol/common/model/TileImprovementType.java:485: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:488: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/TileImprovementType.java:488: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:491: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:501: Local variable 'e' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:507: Local variable 'choice' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:510: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:510: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileImprovementType.java:522: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileImprovementType.java:522: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileImprovementType.java:562: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/TileImprovementType.java:569: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileImprovementType.java:569: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:572: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovementType.java:573: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovementType.java:574: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovementType.java:575: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileImprovementType.java:585: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileImprovementType.java:585: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:586: Found 'DU'-anomaly for variable 'spec' (lines '586'-'625'). +src/net/sf/freecol/common/model/TileImprovementType.java:590: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:595: Local variable 'from' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:597: Avoid variables with short names like to +src/net/sf/freecol/common/model/TileImprovementType.java:597: Local variable 'to' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:609: Local variable 'disaster' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:611: Local variable 'probability' could be declared final +src/net/sf/freecol/common/model/TileImprovementType.java:619: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileItem.java:32: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/TileItem.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileItem.java:45: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItem.java:45: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItem.java:62: Avoid unused constructor parameters such as 'xr'. +src/net/sf/freecol/common/model/TileItem.java:62: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileItem.java:62: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItem.java:62: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItem.java:74: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileItem.java:74: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItem.java:74: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItem.java:96: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileItem.java:158: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItem.java:186: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TileItemContainer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileItemContainer.java:20: Possible God class (WMC=101, ATFD=43, TCC=0.1875) +src/net/sf/freecol/common/model/TileItemContainer.java:32: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/TileItemContainer.java:41: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/TileItemContainer.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/TileItemContainer.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileItemContainer.java:46: Avoid excessively long variable names like tileItemComparator +src/net/sf/freecol/common/model/TileItemContainer.java:46: Avoid unused private fields such as 'tileItemComparator'. +src/net/sf/freecol/common/model/TileItemContainer.java:46: Variables that are final and static should be all capitals, 'tileItemComparator' is not all capitals. +src/net/sf/freecol/common/model/TileItemContainer.java:49: Parameter 'tileItem1' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:49: Parameter 'tileItem2' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:49: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TileItemContainer.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileItemContainer.java:74: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:74: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:84: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileItemContainer.java:94: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:94: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:94: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:95: Parameter 'layer' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:99: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:101: Local variable 'resource' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:103: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TileItemContainer.java:108: Local variable 'rumour' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:110: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TileItemContainer.java:114: Local variable 'improvement' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:117: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TileItemContainer.java:120: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileItemContainer.java:131: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileItemContainer.java:131: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:131: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:161: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileItemContainer.java:170: Local variable 'colony' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:184: Avoid variables with short names like ti +src/net/sf/freecol/common/model/TileItemContainer.java:193: Avoid variables with short names like ti +src/net/sf/freecol/common/model/TileItemContainer.java:204: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:205: Local variable 'improvement' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:216: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:218: Avoid variables with short names like ti +src/net/sf/freecol/common/model/TileItemContainer.java:218: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:230: Avoid variables with short names like ti +src/net/sf/freecol/common/model/TileItemContainer.java:230: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:231: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:242: Avoid variables with short names like ti +src/net/sf/freecol/common/model/TileItemContainer.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:252: Found 'DU'-anomaly for variable 'tileType' (lines '252'-'264'). +src/net/sf/freecol/common/model/TileItemContainer.java:252: Local variable 'tileType' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:253: Local variable 'iterator' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:254: Found 'DD'-anomaly for variable 'removed' (lines '254'-'260'). +src/net/sf/freecol/common/model/TileItemContainer.java:256: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:260: Found 'DD'-anomaly for variable 'removed' (lines '260'-'260'). +src/net/sf/freecol/common/model/TileItemContainer.java:263: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileItemContainer.java:273: Found 'UR'-anomaly for variable 'item' (lines '273'-'276'). +src/net/sf/freecol/common/model/TileItemContainer.java:273: Parameter 'completedOnly' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:274: Local variable 'improvements' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:275: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:277: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:277: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:304: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileItemContainer.java:313: Parameter 'item' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:314: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileItemContainer.java:314: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileItemContainer.java:316: Local variable 'oldItem' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:319: Local variable 'oldTip' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:320: Local variable 'newTip' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:321: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:321: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:321: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:321: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:326: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileItemContainer.java:328: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileItemContainer.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:347: Parameter 'item' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:348: Local variable 'removed' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:352: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileItemContainer.java:362: Avoid variables with short names like c +src/net/sf/freecol/common/model/TileItemContainer.java:362: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:363: Local variable 'iterator' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:365: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileItemContainer.java:369: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileItemContainer.java:386: Found 'UR'-anomaly for variable 'item' (lines '386'-'390'). +src/net/sf/freecol/common/model/TileItemContainer.java:386: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:386: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:387: Parameter 'onlyNatural' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:387: Parameter 'potential' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:388: Found 'DD'-anomaly for variable 'result' (lines '388'-'391'). +src/net/sf/freecol/common/model/TileItemContainer.java:389: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:404: Found 'UR'-anomaly for variable 'item' (lines '404'-'408'). +src/net/sf/freecol/common/model/TileItemContainer.java:404: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:405: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:406: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:407: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:421: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:421: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:422: Avoid variables with short names like ti +src/net/sf/freecol/common/model/TileItemContainer.java:425: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileItemContainer.java:435: Found 'UR'-anomaly for variable 'item' (lines '435'-'438'). +src/net/sf/freecol/common/model/TileItemContainer.java:435: Parameter 'basicMoveCost' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:435: Parameter 'fromTile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:435: Parameter 'targetTile' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:436: Found 'DD'-anomaly for variable 'moveCost' (lines '436'-'442'). +src/net/sf/freecol/common/model/TileItemContainer.java:436: Found 'DU'-anomaly for variable 'moveCost' (lines '436'-'447'). +src/net/sf/freecol/common/model/TileItemContainer.java:437: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:439: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:440: Local variable 'direction' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:441: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileItemContainer.java:441: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileItemContainer.java:442: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:443: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:454: Parameter 'tic' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:464: Parameter 'importResources' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:464: Parameter 'tic' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:475: Found 'UR'-anomaly for variable 'item' (lines '475'-'479'). +src/net/sf/freecol/common/model/TileItemContainer.java:475: Parameter 'importResources' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:475: Parameter 'tic' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:476: Parameter 'copyOnlyNatural' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:478: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:481: Local variable 'ticR' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:482: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TileItemContainer.java:482: Avoid variables with short names like r +src/net/sf/freecol/common/model/TileItemContainer.java:482: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:488: Local variable 'ticR' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:489: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TileItemContainer.java:489: Avoid variables with short names like r +src/net/sf/freecol/common/model/TileItemContainer.java:489: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:494: These nested if statements could be combined +src/net/sf/freecol/common/model/TileItemContainer.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:495: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:496: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TileItemContainer.java:509: Avoid variables with short names like t +src/net/sf/freecol/common/model/TileItemContainer.java:509: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:532: Found 'UR'-anomaly for variable 'ti' (lines '532'-'535'). +src/net/sf/freecol/common/model/TileItemContainer.java:532: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:533: Found 'DD'-anomaly for variable 'result' (lines '533'-'565'). +src/net/sf/freecol/common/model/TileItemContainer.java:534: Local variable 'ti' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:535: Found 'DD'-anomaly for variable 'integ' (lines '535'-'544'). +src/net/sf/freecol/common/model/TileItemContainer.java:535: Found 'DD'-anomaly for variable 'integ' (lines '535'-'554'). +src/net/sf/freecol/common/model/TileItemContainer.java:535: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:541: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileItemContainer.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:549: Local variable 'tim' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:550: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:552: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:552: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:553: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileItemContainer.java:559: There is log block not surrounded by if +src/net/sf/freecol/common/model/TileItemContainer.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:573: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileItemContainer.java:573: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileItemContainer.java:575: Avoid excessively long variable names like OLD_TILE_IMPROVEMENT_TAG +src/net/sf/freecol/common/model/TileItemContainer.java:575: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileItemContainer.java:575: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileItemContainer.java:583: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileItemContainer.java:583: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:593: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileItemContainer.java:593: Found 'UR'-anomaly for variable 'item' (lines '593'-'597'). +src/net/sf/freecol/common/model/TileItemContainer.java:593: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:596: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:605: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileItemContainer.java:605: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:616: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileItemContainer.java:616: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:627: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileItemContainer.java:627: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:628: Found 'DU'-anomaly for variable 'game' (lines '628'-'654'). +src/net/sf/freecol/common/model/TileItemContainer.java:631: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:632: Local variable 'lcr' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:637: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileItemContainer.java:641: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:644: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileItemContainer.java:660: Found 'UR'-anomaly for variable 'item' (lines '660'-'663'). +src/net/sf/freecol/common/model/TileItemContainer.java:661: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TileItemContainer.java:661: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:662: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TileItemContainer.java:663: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TileItemContainer.java:663: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/TileItemContainer.java:663: Local variable 'item' could be declared final +src/net/sf/freecol/common/model/TileItemContainer.java:664: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TileType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileType.java:20: Possible God class (WMC=83, ATFD=51, TCC=0.07407407407407407) +src/net/sf/freecol/common/model/TileType.java:36: The class 'TileType' has a Cyclomatic Complexity of 3 (Highest = 25). +src/net/sf/freecol/common/model/TileType.java:36: The class 'TileType' has a Modified Cyclomatic Complexity of 2 (Highest = 20). +src/net/sf/freecol/common/model/TileType.java:36: The class 'TileType' has a Standard Cyclomatic Complexity of 2 (Highest = 20). +src/net/sf/freecol/common/model/TileType.java:36: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/TileType.java:38: enumCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:54: Field canSettle has the same name as a method +src/net/sf/freecol/common/model/TileType.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:76: Avoid using redundant field initializer for 'resourceTypes' +src/net/sf/freecol/common/model/TileType.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:79: Avoid using redundant field initializer for 'disasters' +src/net/sf/freecol/common/model/TileType.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:86: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TileType.java:95: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileType.java:95: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:95: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:99: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileType.java:108: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileType.java:108: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:108: Parameter 'water' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:197: Parameter 'rangeType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:197: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:200: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileType.java:202: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileType.java:204: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileType.java:218: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:227: Found 'UR'-anomaly for variable 'resource' (lines '227'-'231'). +src/net/sf/freecol/common/model/TileType.java:228: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/TileType.java:230: Local variable 'resource' could be declared final +src/net/sf/freecol/common/model/TileType.java:244: Parameter 'prob' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:244: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:245: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileType.java:255: Parameter 'resourceType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:276: Parameter 'disaster' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:276: Parameter 'probability' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:277: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileType.java:288: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:289: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:290: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:293: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileType.java:302: Found 'UR'-anomaly for variable 'productionType' (lines '302'-'307'). +src/net/sf/freecol/common/model/TileType.java:302: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:303: Parameter 'level' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:304: Local variable 'better' could be declared final +src/net/sf/freecol/common/model/TileType.java:304: Local variable 'good' could be declared final +src/net/sf/freecol/common/model/TileType.java:306: Local variable 'productionType' could be declared final +src/net/sf/freecol/common/model/TileType.java:307: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileType.java:314: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/TileType.java:314: Useless parentheses. +src/net/sf/freecol/common/model/TileType.java:314: Useless parentheses. +src/net/sf/freecol/common/model/TileType.java:328: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:328: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:334: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileType.java:345: Avoid reassigning parameters such as 'productionType' +src/net/sf/freecol/common/model/TileType.java:346: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:346: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:347: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileType.java:347: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileType.java:352: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileType.java:352: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileType.java:353: Local variable 'best' could be declared final +src/net/sf/freecol/common/model/TileType.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileType.java:357: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileType.java:366: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:367: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:368: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileType.java:368: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileType.java:369: Found 'DD'-anomaly for variable 'amount' (lines '369'-'370'). +src/net/sf/freecol/common/model/TileType.java:372: Useless parentheses. +src/net/sf/freecol/common/model/TileType.java:372: Useless parentheses. +src/net/sf/freecol/common/model/TileType.java:375: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileType.java:385: Found 'UR'-anomaly for variable 'pt' (lines '385'-'388'). +src/net/sf/freecol/common/model/TileType.java:385: Parameter 'unattended' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:386: Local variable 'production' could be declared final +src/net/sf/freecol/common/model/TileType.java:387: Local variable 'pt' could be declared final +src/net/sf/freecol/common/model/TileType.java:388: Local variable 'outputs' could be declared final +src/net/sf/freecol/common/model/TileType.java:389: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileType.java:389: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileType.java:400: Overriding method merely calls super +src/net/sf/freecol/common/model/TileType.java:400: Overriding method merely calls super +src/net/sf/freecol/common/model/TileType.java:407: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:407: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:408: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:408: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:409: Avoid excessively long variable names like BASIC_MOVE_COST_TAG +src/net/sf/freecol/common/model/TileType.java:409: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:409: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:410: Avoid excessively long variable names like BASIC_WORK_TURNS_TAG +src/net/sf/freecol/common/model/TileType.java:410: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:410: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:411: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:411: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:412: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:412: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:413: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:413: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:414: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:414: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:415: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:415: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:416: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:416: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:417: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:417: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:418: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:418: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:419: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:419: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:420: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:420: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:421: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:421: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:422: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:422: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:423: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:423: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:424: Avoid excessively long variable names like TEMPERATURE_MIN_TAG +src/net/sf/freecol/common/model/TileType.java:424: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:424: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:425: Avoid excessively long variable names like TEMPERATURE_MAX_TAG +src/net/sf/freecol/common/model/TileType.java:425: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:425: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:426: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:426: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:428: Avoid excessively long variable names like PRIMARY_PRODUCTION_TAG +src/net/sf/freecol/common/model/TileType.java:428: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:428: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:429: Avoid excessively long variable names like SECONDARY_PRODUCTION_TAG +src/net/sf/freecol/common/model/TileType.java:429: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:429: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:430: Avoid excessively long variable names like TILE_PRODUCTION_TAG +src/net/sf/freecol/common/model/TileType.java:430: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:430: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:433: Avoid excessively long variable names like OLD_ALTITUDE_MIN_TAG +src/net/sf/freecol/common/model/TileType.java:433: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:433: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:434: Avoid excessively long variable names like OLD_ALTITUDE_MAX_TAG +src/net/sf/freecol/common/model/TileType.java:434: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:434: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:435: Avoid excessively long variable names like OLD_HUMIDITY_MIN_TAG +src/net/sf/freecol/common/model/TileType.java:435: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:435: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:436: Avoid excessively long variable names like OLD_HUMIDITY_MAX_TAG +src/net/sf/freecol/common/model/TileType.java:436: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:436: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:437: Avoid excessively long variable names like OLD_TEMPERATURE_MIN_TAG +src/net/sf/freecol/common/model/TileType.java:437: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:437: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:438: Avoid excessively long variable names like OLD_TEMPERATURE_MAX_TAG +src/net/sf/freecol/common/model/TileType.java:438: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileType.java:438: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileType.java:446: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileType.java:446: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:468: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileType.java:468: Found 'UR'-anomaly for variable 'choice' (lines '468'-'494'). +src/net/sf/freecol/common/model/TileType.java:468: Found 'UR'-anomaly for variable 'productionType' (lines '468'-'488'). +src/net/sf/freecol/common/model/TileType.java:468: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:473: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:475: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:477: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:479: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:481: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:483: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:487: Local variable 'productionType' could be declared final +src/net/sf/freecol/common/model/TileType.java:491: Local variable 'choice' could be declared final +src/net/sf/freecol/common/model/TileType.java:501: Local variable 'choice' could be declared final +src/net/sf/freecol/common/model/TileType.java:516: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileType.java:516: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:539: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileType.java:539: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:542: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileType.java:543: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/TileType.java:554: Avoid really long methods. +src/net/sf/freecol/common/model/TileType.java:554: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileType.java:554: Found 'UR'-anomaly for variable 'productionType' (lines '554'-'627'). +src/net/sf/freecol/common/model/TileType.java:554: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileType.java:554: The method 'readChild' has a Cyclomatic Complexity of 25. +src/net/sf/freecol/common/model/TileType.java:554: The method 'readChild' has a Modified Cyclomatic Complexity of 20. +src/net/sf/freecol/common/model/TileType.java:554: The method 'readChild' has a Standard Cyclomatic Complexity of 20. +src/net/sf/freecol/common/model/TileType.java:555: Found 'DU'-anomaly for variable 'spec' (lines '555'-'658'). +src/net/sf/freecol/common/model/TileType.java:559: Avoid variables with short names like d +src/net/sf/freecol/common/model/TileType.java:559: Local variable 'd' could be declared final +src/net/sf/freecol/common/model/TileType.java:611: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/TileType.java:613: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/TileType.java:614: Found 'DU'-anomaly for variable 'goods' (lines '614'-'658'). +src/net/sf/freecol/common/model/TileType.java:614: Local variable 'goods' could be declared final +src/net/sf/freecol/common/model/TileType.java:615: Found 'DU'-anomaly for variable 'tileProduction' (lines '615'-'658'). +src/net/sf/freecol/common/model/TileType.java:615: Local variable 'tileProduction' could be declared final +src/net/sf/freecol/common/model/TileType.java:623: Local variable 'level' could be declared final +src/net/sf/freecol/common/model/TileType.java:623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileType.java:624: Local variable 'unattendedTypes' could be declared final +src/net/sf/freecol/common/model/TileType.java:626: Local variable 'productionType' could be declared final +src/net/sf/freecol/common/model/TileType.java:628: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileType.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:645: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TileType.java:648: Avoid variables with short names like id +src/net/sf/freecol/common/model/TileType.java:648: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/TileType.java:649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TileTypeChange.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TileTypeChange.java:39: Avoid variables with short names like to +src/net/sf/freecol/common/model/TileTypeChange.java:80: Avoid variables with short names like to +src/net/sf/freecol/common/model/TileTypeChange.java:109: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileTypeChange.java:109: The method compareTo() has an NPath complexity of 338 +src/net/sf/freecol/common/model/TileTypeChange.java:114: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileTypeChange.java:114: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TileTypeChange.java:126: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileTypeChange.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TileTypeChange.java:138: Found 'DD'-anomaly for variable 'hash' (lines '138'-'139'). +src/net/sf/freecol/common/model/TileTypeChange.java:147: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileTypeChange.java:147: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileTypeChange.java:148: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileTypeChange.java:148: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileTypeChange.java:149: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileTypeChange.java:149: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileTypeChange.java:150: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileTypeChange.java:150: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileTypeChange.java:151: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TileTypeChange.java:151: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TileTypeChange.java:161: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TileTypeChange.java:161: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileTypeChange.java:189: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TileTypeChange.java:189: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileTypeChange.java:190: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/common/model/TileTypeChange.java:199: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/TileTypeChange.java:202: Local variable 'amount' could be declared final +src/net/sf/freecol/common/model/TileTypeChange.java:204: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TradeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TradeItem.java:26: No need to import a type that lives in the same package +src/net/sf/freecol/common/model/TradeItem.java:33: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/TradeItem.java:53: Avoid variables with short names like id +src/net/sf/freecol/common/model/TradeItem.java:53: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/TradeItem.java:53: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:53: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:53: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:53: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:67: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeItem.java:67: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/TradeItem.java:67: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:67: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:125: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:126: Use equals() to compare object references. +src/net/sf/freecol/common/model/TradeItem.java:161: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:161: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:168: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:175: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:175: Document empty method +src/net/sf/freecol/common/model/TradeItem.java:175: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:182: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:189: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:189: Document empty method +src/net/sf/freecol/common/model/TradeItem.java:189: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:196: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:203: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:210: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:210: Document empty method +src/net/sf/freecol/common/model/TradeItem.java:210: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:217: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:224: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/TradeItem.java:224: Document empty method +src/net/sf/freecol/common/model/TradeItem.java:224: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:241: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeItem.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeItem.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeItem.java:244: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeItem.java:244: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeItem.java:255: Found 'DD'-anomaly for variable 'hash' (lines '255'-'256'). +src/net/sf/freecol/common/model/TradeItem.java:263: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TradeItem.java:263: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeItem.java:264: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TradeItem.java:264: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeItem.java:271: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TradeItem.java:271: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeItem.java:283: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeItem.java:283: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeLocation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TradeLocation.java:36: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/TradeLocation.java:46: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/TradeLocation.java:56: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/TradeRoute.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TradeRoute.java:41: The class 'TradeRoute' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/model/TradeRoute.java:42: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/TradeRoute.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/TradeRoute.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeRoute.java:60: Avoid using redundant field initializer for 'silent' +src/net/sf/freecol/common/model/TradeRoute.java:70: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:70: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:70: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:83: Avoid variables with short names like id +src/net/sf/freecol/common/model/TradeRoute.java:83: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:83: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:93: Avoid variables with short names like e +src/net/sf/freecol/common/model/TradeRoute.java:93: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:93: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:107: Found 'UR'-anomaly for variable 'otherStop' (lines '107'-'111'). +src/net/sf/freecol/common/model/TradeRoute.java:107: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:107: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/TradeRoute.java:110: Local variable 'otherStop' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:111: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TradeRoute.java:150: Parameter 'silent' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:171: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:172: Parameter 'end' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:173: Avoid variables with short names like i0 +src/net/sf/freecol/common/model/TradeRoute.java:173: Avoid variables with short names like in +src/net/sf/freecol/common/model/TradeRoute.java:173: Local variable 'in' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:173: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/TradeRoute.java:174: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:174: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:175: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRoute.java:178: Avoid assignments in operands +src/net/sf/freecol/common/model/TradeRoute.java:178: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:188: Parameter 'stop' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:197: Parameter 'stop' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:207: Found 'UR'-anomaly for variable 'trs' (lines '207'-'210'). +src/net/sf/freecol/common/model/TradeRoute.java:207: Parameter 'stop' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:208: Avoid variables with short names like i +src/net/sf/freecol/common/model/TradeRoute.java:208: Found 'DD'-anomaly for variable 'i' (lines '208'-'211'). +src/net/sf/freecol/common/model/TradeRoute.java:208: Found 'DU'-anomaly for variable 'i' (lines '208'-'214'). +src/net/sf/freecol/common/model/TradeRoute.java:209: Local variable 'trs' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:210: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:210: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:210: Use equals() to compare object references. +src/net/sf/freecol/common/model/TradeRoute.java:211: Found 'DD'-anomaly for variable 'i' (lines '211'-'211'). +src/net/sf/freecol/common/model/TradeRoute.java:211: Found 'DU'-anomaly for variable 'i' (lines '211'-'214'). +src/net/sf/freecol/common/model/TradeRoute.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:230: Avoid variables with short names like u +src/net/sf/freecol/common/model/TradeRoute.java:241: Parameter 'stop' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:241: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:252: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:252: Parameter 'stop' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:262: Found 'UR'-anomaly for variable 'stop' (lines '262'-'286'). +src/net/sf/freecol/common/model/TradeRoute.java:262: The method 'verify' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/TradeRoute.java:262: The method verify() has an NPath complexity of 240 +src/net/sf/freecol/common/model/TradeRoute.java:264: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:269: Avoid variables with short names like tr +src/net/sf/freecol/common/model/TradeRoute.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:270: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:270: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:275: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/TradeRoute.java:276: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:283: Found 'DU'-anomaly for variable 'always' (lines '283'-'299'). +src/net/sf/freecol/common/model/TradeRoute.java:283: Local variable 'always' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:284: Found 'DD'-anomaly for variable 'empty' (lines '284'-'289'). +src/net/sf/freecol/common/model/TradeRoute.java:284: Found 'DU'-anomaly for variable 'empty' (lines '284'-'299'). +src/net/sf/freecol/common/model/TradeRoute.java:285: Local variable 'stop' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:287: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:287: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRoute.java:289: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:289: Found 'DD'-anomaly for variable 'empty' (lines '289'-'289'). +src/net/sf/freecol/common/model/TradeRoute.java:289: Found 'DU'-anomaly for variable 'empty' (lines '289'-'299'). +src/net/sf/freecol/common/model/TradeRoute.java:289: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRoute.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRoute.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRoute.java:292: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:292: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRoute.java:294: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRoute.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:295: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRoute.java:327: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TradeRoute.java:327: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeRoute.java:328: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TradeRoute.java:328: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeRoute.java:329: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TradeRoute.java:329: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeRoute.java:336: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TradeRoute.java:336: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:350: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TradeRoute.java:350: Found 'UR'-anomaly for variable 'stop' (lines '350'-'353'). +src/net/sf/freecol/common/model/TradeRoute.java:350: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:353: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:353: Local variable 'stop' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:360: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeRoute.java:360: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:375: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeRoute.java:375: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:386: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeRoute.java:386: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:389: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRoute.java:401: Found 'UR'-anomaly for variable 'stop' (lines '401'-'407'). +src/net/sf/freecol/common/model/TradeRoute.java:402: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TradeRoute.java:402: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:403: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TradeRoute.java:404: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TradeRoute.java:405: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:407: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TradeRoute.java:407: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/TradeRoute.java:407: Local variable 'stop' could be declared final +src/net/sf/freecol/common/model/TradeRoute.java:408: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TradeRouteStop.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TradeRouteStop.java:38: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/TradeRouteStop.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/TradeRouteStop.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeRouteStop.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TradeRouteStop.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/TradeRouteStop.java:55: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/TradeRouteStop.java:55: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:55: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:69: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:81: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeRouteStop.java:81: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:81: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:111: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:112: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:112: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:113: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:114: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:114: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:114: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:114: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:132: Parameter 'newCargo' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:142: Parameter 'newCargo' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:154: Found 'UR'-anomaly for variable 'type' (lines '154'-'157'). +src/net/sf/freecol/common/model/TradeRouteStop.java:155: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:156: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:157: Avoid variables with short names like ag +src/net/sf/freecol/common/model/TradeRouteStop.java:157: Local variable 'ag' could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:158: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/TradeRouteStop.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRouteStop.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRouteStop.java:161: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/TradeRouteStop.java:174: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:174: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:186: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:197: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:197: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:199: Local variable 'stopGoods' could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:202: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRouteStop.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/TradeRouteStop.java:203: Avoid variables with short names like ag +src/net/sf/freecol/common/model/TradeRouteStop.java:204: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRouteStop.java:204: Avoid variables with short names like ag +src/net/sf/freecol/common/model/TradeRouteStop.java:207: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/TradeRouteStop.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:208: Avoid variables with short names like ag +src/net/sf/freecol/common/model/TradeRouteStop.java:209: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TradeRouteStop.java:209: Avoid variables with short names like ag +src/net/sf/freecol/common/model/TradeRouteStop.java:221: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:222: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:222: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:223: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:231: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:231: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:232: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:232: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:241: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:241: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:242: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:242: Useless parentheses. +src/net/sf/freecol/common/model/TradeRouteStop.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:250: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TradeRouteStop.java:250: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeRouteStop.java:251: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/TradeRouteStop.java:251: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TradeRouteStop.java:258: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TradeRouteStop.java:258: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:266: Avoid variables with short names like xw +src/net/sf/freecol/common/model/TradeRouteStop.java:266: Found 'UR'-anomaly for variable 'cargoType' (lines '266'-'271'). +src/net/sf/freecol/common/model/TradeRouteStop.java:266: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:267: Local variable 'cargoType' could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:281: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeRouteStop.java:281: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:289: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeRouteStop.java:289: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:300: Avoid variables with short names like xr +src/net/sf/freecol/common/model/TradeRouteStop.java:300: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:301: Found 'DU'-anomaly for variable 'spec' (lines '301'-'313'). +src/net/sf/freecol/common/model/TradeRouteStop.java:320: Found 'UR'-anomaly for variable 'goodsType' (lines '320'-'325'). +src/net/sf/freecol/common/model/TradeRouteStop.java:321: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TradeRouteStop.java:321: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:322: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TradeRouteStop.java:323: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TradeRouteStop.java:323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TradeRouteStop.java:324: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/TradeRouteStop.java:325: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TradeRouteStop.java:327: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TransactionListener.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TransactionListener.java:36: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/TransactionListener.java:46: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/Turn.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/Turn.java:29: Avoid short class names like Turn +src/net/sf/freecol/common/model/Turn.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/Turn.java:42: It is somewhat confusing to have a field name matching the declaring class name +src/net/sf/freecol/common/model/Turn.java:42: Private field 'turn' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/common/model/Turn.java:50: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:63: Parameter 'newStartingYear' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:63: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/Turn.java:64: Parameter 'newSeasonYear' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:65: Parameter 'newSeasonNumber' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:76: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/Turn.java:85: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/Turn.java:94: Use block level rather than method level synchronization +src/net/sf/freecol/common/model/Turn.java:104: Parameter 'year' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:115: Parameter 'season' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:115: Parameter 'year' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:116: Local variable 'startingYear' could be declared final +src/net/sf/freecol/common/model/Turn.java:116: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Turn.java:119: Local variable 'seasonYear' could be declared final +src/net/sf/freecol/common/model/Turn.java:157: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:158: Local variable 'seasonYear' could be declared final +src/net/sf/freecol/common/model/Turn.java:158: Local variable 'year' could be declared final +src/net/sf/freecol/common/model/Turn.java:158: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/Turn.java:159: Useless parentheses. +src/net/sf/freecol/common/model/Turn.java:159: Useless parentheses. +src/net/sf/freecol/common/model/Turn.java:170: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:171: Local variable 'year' could be declared final +src/net/sf/freecol/common/model/Turn.java:172: Useless parentheses. +src/net/sf/freecol/common/model/Turn.java:172: Useless parentheses. +src/net/sf/freecol/common/model/Turn.java:201: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:202: Local variable 'season' could be declared final +src/net/sf/freecol/common/model/Turn.java:203: Avoid variables with short names like t +src/net/sf/freecol/common/model/Turn.java:203: Local variable 't' could be declared final +src/net/sf/freecol/common/model/Turn.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Turn.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Turn.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/Turn.java:239: Avoid excessively long variable names like SeasonNumberDigits +src/net/sf/freecol/common/model/Turn.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/Turn.java:240: No need to call String.valueOf to append to a string. +src/net/sf/freecol/common/model/Turn.java:240: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/model/Turn.java:252: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:266: Avoid variables with short names like o +src/net/sf/freecol/common/model/Turn.java:266: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/model/Turn.java:268: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TypeCountMap.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/TypeCountMap.java:33: Each class should declare at least one constructor +src/net/sf/freecol/common/model/TypeCountMap.java:35: Field values has the same name as a method +src/net/sf/freecol/common/model/TypeCountMap.java:35: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/TypeCountMap.java:35: fieldCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:37: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:41: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:41: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:42: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:46: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:46: Parameter 'newCount' is not assigned and could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:46: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:47: Local variable 'oldValue' could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:49: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TypeCountMap.java:52: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/TypeCountMap.java:58: Found 'UR'-anomaly for variable 'entry' (lines '58'-'60'). +src/net/sf/freecol/common/model/TypeCountMap.java:58: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:58: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:59: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:59: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/TypeCountMap.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:68: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:72: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:76: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:76: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:80: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:84: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:88: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:88: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/TypeCountMap.java:97: Found 'UR'-anomaly for variable 'entry' (lines '97'-'101'). +src/net/sf/freecol/common/model/TypeCountMap.java:98: Avoid variables with short names like sb +src/net/sf/freecol/common/model/TypeCountMap.java:98: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:99: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TypeCountMap.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TypeCountMap.java:100: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/TypeCountMap.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/TypeCountMap.java:102: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TypeCountMap.java:102: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/TypeCountMap.java:104: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitLocation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitLocation.java:20: Possible God class (WMC=64, ATFD=30, TCC=0.0873015873015873) +src/net/sf/freecol/common/model/UnitLocation.java:46: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/model/UnitLocation.java:46: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/UnitLocation.java:48: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/UnitLocation.java:48: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitLocation.java:50: enumCommentRequirement Required +src/net/sf/freecol/common/model/UnitLocation.java:132: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitLocation.java:140: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:150: Avoid variables with short names like id +src/net/sf/freecol/common/model/UnitLocation.java:150: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:150: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:154: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitLocation.java:163: Avoid unused constructor parameters such as 'e'. +src/net/sf/freecol/common/model/UnitLocation.java:163: Avoid variables with short names like e +src/net/sf/freecol/common/model/UnitLocation.java:163: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:163: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:196: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:196: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:197: Local variable 'units' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:207: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:207: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:208: Local variable 'units' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:221: Avoid variables with short names like u +src/net/sf/freecol/common/model/UnitLocation.java:232: Parameter 'space' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:234: Avoid variables with short names like u +src/net/sf/freecol/common/model/UnitLocation.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:253: Found 'UR'-anomaly for variable 'u' (lines '253'-'255'). +src/net/sf/freecol/common/model/UnitLocation.java:253: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:254: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:255: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:255: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:267: Found 'UR'-anomaly for variable 'u' (lines '267'-'270'). +src/net/sf/freecol/common/model/UnitLocation.java:268: Local variable 'objects' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:270: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:270: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:272: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:297: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/UnitLocation.java:313: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:321: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:323: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:325: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:328: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:328: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:329: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:330: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:336: There is log block not surrounded by if +src/net/sf/freecol/common/model/UnitLocation.java:338: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:340: There is log block not surrounded by if +src/net/sf/freecol/common/model/UnitLocation.java:350: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:352: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:354: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:354: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:356: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:359: There is log block not surrounded by if +src/net/sf/freecol/common/model/UnitLocation.java:369: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:370: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitLocation.java:370: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:380: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:417: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/UnitLocation.java:425: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/model/UnitLocation.java:435: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:436: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitLocation.java:436: Useless parentheses. +src/net/sf/freecol/common/model/UnitLocation.java:436: Useless parentheses. +src/net/sf/freecol/common/model/UnitLocation.java:445: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:446: Useless parentheses. +src/net/sf/freecol/common/model/UnitLocation.java:446: Useless parentheses. +src/net/sf/freecol/common/model/UnitLocation.java:447: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitLocation.java:462: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:462: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:462: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:463: Avoid variables with short names like u +src/net/sf/freecol/common/model/UnitLocation.java:471: Avoid variables with short names like u +src/net/sf/freecol/common/model/UnitLocation.java:471: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:473: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitLocation.java:486: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitLocation.java:501: Parameter 'locatable' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:502: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitLocation.java:502: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:502: Useless parentheses. +src/net/sf/freecol/common/model/UnitLocation.java:502: Useless parentheses. +src/net/sf/freecol/common/model/UnitLocation.java:505: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/UnitLocation.java:505: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:505: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:505: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:509: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:509: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:531: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:543: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:543: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:543: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:554: Avoid variables with short names like xw +src/net/sf/freecol/common/model/UnitLocation.java:554: Found 'UR'-anomaly for variable 'unit' (lines '554'-'559'). +src/net/sf/freecol/common/model/UnitLocation.java:554: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:558: Local variable 'unit' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:560: There is log block not surrounded by if +src/net/sf/freecol/common/model/UnitLocation.java:574: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitLocation.java:574: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:585: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitLocation.java:585: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:588: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:589: Avoid variables with short names like u +src/net/sf/freecol/common/model/UnitLocation.java:589: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/UnitLocation.java:590: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:591: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitLocation.java:591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:591: There is log block not surrounded by if +src/net/sf/freecol/common/model/UnitLocation.java:593: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitLocation.java:596: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitTradeItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitTradeItem.java:47: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:47: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:47: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:48: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:62: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitTradeItem.java:62: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:62: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTradeItem.java:106: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:113: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:115: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/UnitTradeItem.java:115: Useless parentheses. +src/net/sf/freecol/common/model/UnitTradeItem.java:115: Useless parentheses. +src/net/sf/freecol/common/model/UnitTradeItem.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitTradeItem.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitTradeItem.java:128: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:130: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitTradeItem.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTradeItem.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTradeItem.java:141: Local variable 'hash' could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTradeItem.java:148: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTradeItem.java:148: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitTradeItem.java:155: Avoid variables with short names like xw +src/net/sf/freecol/common/model/UnitTradeItem.java:155: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:166: Avoid variables with short names like sb +src/net/sf/freecol/common/model/UnitTradeItem.java:166: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/UnitTradeItem.java:167: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitTradeItem.java:168: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitTradeItem.java:168: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitTradeItem.java:176: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitTradeItem.java:176: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitType.java:20: Possible God class (WMC=123, ATFD=119, TCC=0.045372050816696916) +src/net/sf/freecol/common/model/UnitType.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/model/UnitType.java:39: Avoid really long classes. +src/net/sf/freecol/common/model/UnitType.java:39: The class 'UnitType' has a Cyclomatic Complexity of 2 (Highest = 16). +src/net/sf/freecol/common/model/UnitType.java:39: The class 'UnitType' has a Modified Cyclomatic Complexity of 2 (Highest = 14). +src/net/sf/freecol/common/model/UnitType.java:39: The class 'UnitType' has a Standard Cyclomatic Complexity of 2 (Highest = 14). +src/net/sf/freecol/common/model/UnitType.java:39: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/UnitType.java:39: Too many fields +src/net/sf/freecol/common/model/UnitType.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:57: Avoid using redundant field initializer for 'space' +src/net/sf/freecol/common/model/UnitType.java:60: Avoid using redundant field initializer for 'defaultUnit' +src/net/sf/freecol/common/model/UnitType.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:67: Avoid using redundant field initializer for 'hitPoints' +src/net/sf/freecol/common/model/UnitType.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:82: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:85: Avoid excessively long variable names like recruitProbability +src/net/sf/freecol/common/model/UnitType.java:85: Avoid using redundant field initializer for 'recruitProbability' +src/net/sf/freecol/common/model/UnitType.java:85: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:88: Avoid using redundant field initializer for 'expertProduction' +src/net/sf/freecol/common/model/UnitType.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:91: Avoid using redundant field initializer for 'scoreValue' +src/net/sf/freecol/common/model/UnitType.java:91: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:94: Avoid using redundant field initializer for 'maximumExperience' +src/net/sf/freecol/common/model/UnitType.java:94: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:100: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:103: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:106: Avoid using redundant field initializer for 'skillTaught' +src/net/sf/freecol/common/model/UnitType.java:106: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:109: Avoid using redundant field initializer for 'defaultRole' +src/net/sf/freecol/common/model/UnitType.java:109: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:112: Avoid using redundant field initializer for 'typeChanges' +src/net/sf/freecol/common/model/UnitType.java:115: Avoid using redundant field initializer for 'consumption' +src/net/sf/freecol/common/model/UnitType.java:115: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitType.java:124: Avoid variables with short names like id +src/net/sf/freecol/common/model/UnitType.java:124: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:124: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:136: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/UnitType.java:136: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/UnitType.java:212: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitType.java:352: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/UnitType.java:352: Unnecessary final modifier in final class +src/net/sf/freecol/common/model/UnitType.java:400: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:400: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:400: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:400: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:401: Avoid variables with short names like r +src/net/sf/freecol/common/model/UnitType.java:410: Found 'UR'-anomaly for variable 'r' (lines '410'-'411'). +src/net/sf/freecol/common/model/UnitType.java:411: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitType.java:411: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:411: Local variable 'r' could be declared final +src/net/sf/freecol/common/model/UnitType.java:421: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:431: Parameter 'typeChanges' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:440: Parameter 'change' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:441: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:452: Parameter 'changeType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:452: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:453: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/UnitType.java:454: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitType.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:465: Parameter 'changeType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:466: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:467: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:468: Avoid variables with short names like c +src/net/sf/freecol/common/model/UnitType.java:468: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:469: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:478: Parameter 'newType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:479: Avoid variables with short names like c +src/net/sf/freecol/common/model/UnitType.java:482: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitType.java:495: Parameter 'changeType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:495: Parameter 'newType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:497: Avoid variables with short names like c +src/net/sf/freecol/common/model/UnitType.java:506: Found 'UR'-anomaly for variable 'change' (lines '506'-'509'). +src/net/sf/freecol/common/model/UnitType.java:507: Local variable 'unitTypes' could be declared final +src/net/sf/freecol/common/model/UnitType.java:508: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/UnitType.java:524: Parameter 'maximumSkill' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:526: Avoid variables with short names like c +src/net/sf/freecol/common/model/UnitType.java:528: Avoid variables with short names like ut +src/net/sf/freecol/common/model/UnitType.java:538: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:539: Local variable 'utc' could be declared final +src/net/sf/freecol/common/model/UnitType.java:540: Avoid variables with short names like c +src/net/sf/freecol/common/model/UnitType.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:599: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:609: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:609: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:623: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:624: Found 'DD'-anomaly for variable 'cmp' (lines '624'-'627'). +src/net/sf/freecol/common/model/UnitType.java:626: Avoid variables with short names like ut +src/net/sf/freecol/common/model/UnitType.java:626: Local variable 'ut' could be declared final +src/net/sf/freecol/common/model/UnitType.java:627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:629: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:642: Found 'UR'-anomaly for variable 'goodsType' (lines '642'-'646'). +src/net/sf/freecol/common/model/UnitType.java:643: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/UnitType.java:645: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/UnitType.java:646: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/model/UnitType.java:677: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:677: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:679: Avoid excessively long variable names like DEFAULT_EQUIPMENT_TAG +src/net/sf/freecol/common/model/UnitType.java:679: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:679: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:681: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:681: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:682: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:682: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:683: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:683: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:684: Avoid excessively long variable names like EXPERT_PRODUCTION_TAG +src/net/sf/freecol/common/model/UnitType.java:684: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:684: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:685: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:685: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:686: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:686: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:687: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:687: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:688: Avoid excessively long variable names like MAXIMUM_EXPERIENCE_TAG +src/net/sf/freecol/common/model/UnitType.java:688: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:688: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:689: Avoid excessively long variable names like MAXIMUM_ATTRITION_TAG +src/net/sf/freecol/common/model/UnitType.java:689: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:689: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:690: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:690: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:691: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:691: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:692: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:692: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:693: Avoid excessively long variable names like RECRUIT_PROBABILITY_TAG +src/net/sf/freecol/common/model/UnitType.java:693: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:693: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:694: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:694: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:695: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:695: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:696: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:696: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:697: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:697: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:698: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:698: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:699: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:699: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:700: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:700: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:701: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:701: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:703: Avoid excessively long variable names like OLD_DEFAULT_UNIT_TAG +src/net/sf/freecol/common/model/UnitType.java:703: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:703: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:704: Avoid excessively long variable names like OLD_HIT_POINTS_TAG +src/net/sf/freecol/common/model/UnitType.java:704: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:704: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:705: Avoid excessively long variable names like OLD_LINE_OF_SIGHT_TAG +src/net/sf/freecol/common/model/UnitType.java:705: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:705: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:706: Avoid excessively long variable names like OLD_MAXIMUM_EXPERIENCE_TAG +src/net/sf/freecol/common/model/UnitType.java:706: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:706: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:707: Avoid excessively long variable names like OLD_MAXIMUM_ATTRITION_TAG +src/net/sf/freecol/common/model/UnitType.java:707: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:707: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:708: Avoid excessively long variable names like OLD_RECRUIT_PROBABILITY_TAG +src/net/sf/freecol/common/model/UnitType.java:708: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:708: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:709: Avoid excessively long variable names like OLD_SCORE_VALUE_TAG +src/net/sf/freecol/common/model/UnitType.java:709: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:709: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:710: Avoid excessively long variable names like OLD_SKILL_TAUGHT_TAG +src/net/sf/freecol/common/model/UnitType.java:710: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:710: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:711: Avoid excessively long variable names like OLD_SPACE_TAKEN_TAG +src/net/sf/freecol/common/model/UnitType.java:711: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitType.java:711: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitType.java:718: Avoid variables with short names like xw +src/net/sf/freecol/common/model/UnitType.java:718: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:768: Avoid variables with short names like xw +src/net/sf/freecol/common/model/UnitType.java:768: Found 'UR'-anomaly for variable 'change' (lines '768'-'781'). +src/net/sf/freecol/common/model/UnitType.java:768: Found 'UR'-anomaly for variable 'goodsType' (lines '768'-'787'). +src/net/sf/freecol/common/model/UnitType.java:768: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:773: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:781: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:781: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/UnitType.java:784: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/model/UnitType.java:800: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitType.java:800: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:800: The method 'readAttributes' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/UnitType.java:800: The method 'readAttributes' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/UnitType.java:800: The method 'readAttributes' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/UnitType.java:800: The method readAttributes() has an NPath complexity of 1536 +src/net/sf/freecol/common/model/UnitType.java:805: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/UnitType.java:816: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:825: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:832: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:841: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:848: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:856: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:865: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:873: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:881: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:895: These nested if statements could be combined +src/net/sf/freecol/common/model/UnitType.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:905: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitType.java:905: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:905: The method 'readChildren' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/UnitType.java:905: The method 'readChildren' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/UnitType.java:905: The method 'readChildren' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/model/UnitType.java:905: The method readChildren() has an NPath complexity of 266 +src/net/sf/freecol/common/model/UnitType.java:910: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitType.java:911: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitType.java:915: Local variable 'parent' could be declared final +src/net/sf/freecol/common/model/UnitType.java:920: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:925: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitType.java:931: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:939: Avoid variables with short names like m +src/net/sf/freecol/common/model/UnitType.java:964: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitType.java:964: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitType.java:964: The method 'readChild' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/UnitType.java:964: The method 'readChild' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/UnitType.java:964: The method 'readChild' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/UnitType.java:965: Found 'DU'-anomaly for variable 'spec' (lines '965'-'1,023'). +src/net/sf/freecol/common/model/UnitType.java:976: Avoid variables with short names like id +src/net/sf/freecol/common/model/UnitType.java:976: Local variable 'id' could be declared final +src/net/sf/freecol/common/model/UnitType.java:977: Local variable 'roleId' could be declared final +src/net/sf/freecol/common/model/UnitType.java:977: Useless parentheses. +src/net/sf/freecol/common/model/UnitType.java:977: Useless parentheses. +src/net/sf/freecol/common/model/UnitType.java:986: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:992: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:998: Found 'DU'-anomaly for variable 'unitId' (lines '998'-'1,023'). +src/net/sf/freecol/common/model/UnitType.java:998: Local variable 'unitId' could be declared final +src/net/sf/freecol/common/model/UnitType.java:999: Avoid variables with short names like it +src/net/sf/freecol/common/model/UnitType.java:999: Local variable 'it' could be declared final +src/net/sf/freecol/common/model/UnitType.java:1001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:1001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:1001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:1001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:1001: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitType.java:1010: Local variable 'change' could be declared final +src/net/sf/freecol/common/model/UnitType.java:1013: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitType.java:1015: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTypeChange.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitTypeChange.java:40: enumCommentRequirement Required +src/net/sf/freecol/common/model/UnitTypeChange.java:56: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/UnitTypeChange.java:56: Variables that are final and static should be all capitals, 'tags' is not all capitals. +src/net/sf/freecol/common/model/UnitTypeChange.java:56: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitTypeChange.java:58: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/UnitTypeChange.java:58: Variables that are final and static should be all capitals, 'compatTags' is not all capitals. +src/net/sf/freecol/common/model/UnitTypeChange.java:58: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitTypeChange.java:85: Avoid using redundant field initializer for 'newUnitType' +src/net/sf/freecol/common/model/UnitTypeChange.java:85: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTypeChange.java:88: Avoid using redundant field initializer for 'turnsToLearn' +src/net/sf/freecol/common/model/UnitTypeChange.java:88: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTypeChange.java:91: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTypeChange.java:91: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/UnitTypeChange.java:95: Avoid using redundant field initializer for 'scopes' +src/net/sf/freecol/common/model/UnitTypeChange.java:95: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTypeChange.java:101: Document empty constructor +src/net/sf/freecol/common/model/UnitTypeChange.java:101: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/UnitTypeChange.java:110: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitTypeChange.java:110: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/model/UnitTypeChange.java:110: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:111: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:171: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:172: Local variable 'result' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:182: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTypeChange.java:212: Parameter 'scopes' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:221: Parameter 'scope' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:222: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitTypeChange.java:232: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:233: Local variable 'scopeList' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitTypeChange.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitTypeChange.java:234: Useless parentheses. +src/net/sf/freecol/common/model/UnitTypeChange.java:234: Useless parentheses. +src/net/sf/freecol/common/model/UnitTypeChange.java:235: Avoid variables with short names like s +src/net/sf/freecol/common/model/UnitTypeChange.java:241: Avoid excessively long variable names like TURNS_TO_LEARN_TAG +src/net/sf/freecol/common/model/UnitTypeChange.java:241: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTypeChange.java:241: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitTypeChange.java:242: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTypeChange.java:242: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitTypeChange.java:244: Avoid excessively long variable names like OLD_TURNS_TO_LEARN_TAG +src/net/sf/freecol/common/model/UnitTypeChange.java:244: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/UnitTypeChange.java:244: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitTypeChange.java:252: Avoid variables with short names like xw +src/net/sf/freecol/common/model/UnitTypeChange.java:252: Found 'UR'-anomaly for variable 'entry' (lines '252'-'265'). +src/net/sf/freecol/common/model/UnitTypeChange.java:252: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:264: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTypeChange.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTypeChange.java:274: Avoid variables with short names like xw +src/net/sf/freecol/common/model/UnitTypeChange.java:274: Found 'UR'-anomaly for variable 'scope' (lines '274'-'277'). +src/net/sf/freecol/common/model/UnitTypeChange.java:274: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:277: Avoid using for statements without curly braces +src/net/sf/freecol/common/model/UnitTypeChange.java:277: Local variable 'scope' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:284: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitTypeChange.java:284: Found 'UR'-anomaly for variable 'type' (lines '284'-'305'). +src/net/sf/freecol/common/model/UnitTypeChange.java:284: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:288: Found 'DU'-anomaly for variable 'spec' (lines '288'-'317'). +src/net/sf/freecol/common/model/UnitTypeChange.java:299: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/model/UnitTypeChange.java:304: Local variable 'type' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:308: Avoid variables with short names like x +src/net/sf/freecol/common/model/UnitTypeChange.java:308: Local variable 'x' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:309: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitTypeChange.java:323: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitTypeChange.java:323: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:325: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitTypeChange.java:334: Avoid variables with short names like xr +src/net/sf/freecol/common/model/UnitTypeChange.java:334: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitTypeChange.java:349: Found 'UR'-anomaly for variable 'entry' (lines '349'-'354'). +src/net/sf/freecol/common/model/UnitTypeChange.java:350: Avoid variables with short names like sb +src/net/sf/freecol/common/model/UnitTypeChange.java:350: Local variable 'sb' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:351: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitTypeChange.java:352: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitTypeChange.java:353: Local variable 'entry' could be declared final +src/net/sf/freecol/common/model/UnitTypeChange.java:354: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitTypeChange.java:355: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitTypeChange.java:357: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/model/UnitWas.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/UnitWas.java:20: Possible God class (WMC=58, ATFD=50, TCC=0.24444444444444444) +src/net/sf/freecol/common/model/UnitWas.java:34: The class 'UnitWas' has a Cyclomatic Complexity of 5 (Highest = 26). +src/net/sf/freecol/common/model/UnitWas.java:34: The class 'UnitWas' has a Modified Cyclomatic Complexity of 5 (Highest = 18). +src/net/sf/freecol/common/model/UnitWas.java:34: The class 'UnitWas' has a Standard Cyclomatic Complexity of 5 (Highest = 18). +src/net/sf/freecol/common/model/UnitWas.java:36: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/model/UnitWas.java:36: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/UnitWas.java:36: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:39: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/UnitWas.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:55: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitWas.java:72: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:76: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:80: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/UnitWas.java:89: The method 'fireChanges' has a Cyclomatic Complexity of 26. +src/net/sf/freecol/common/model/UnitWas.java:89: The method 'fireChanges' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/UnitWas.java:89: The method 'fireChanges' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/UnitWas.java:89: The method fireChanges() has an NPath complexity of 76440 +src/net/sf/freecol/common/model/UnitWas.java:90: Found 'DD'-anomaly for variable 'newType' (lines '90'-'101'). +src/net/sf/freecol/common/model/UnitWas.java:91: Found 'DD'-anomaly for variable 'newRole' (lines '91'-'102'). +src/net/sf/freecol/common/model/UnitWas.java:92: Found 'DD'-anomaly for variable 'newRoleCount' (lines '92'-'103'). +src/net/sf/freecol/common/model/UnitWas.java:93: Found 'DD'-anomaly for variable 'newLoc' (lines '93'-'99'). +src/net/sf/freecol/common/model/UnitWas.java:94: Found 'DD'-anomaly for variable 'newWork' (lines '94'-'104'). +src/net/sf/freecol/common/model/UnitWas.java:95: Found 'DD'-anomaly for variable 'newWorkAmount' (lines '95'-'105'). +src/net/sf/freecol/common/model/UnitWas.java:96: Found 'DD'-anomaly for variable 'newMovesLeft' (lines '96'-'108'). +src/net/sf/freecol/common/model/UnitWas.java:97: Found 'DD'-anomaly for variable 'ret' (lines '97'-'118'). +src/net/sf/freecol/common/model/UnitWas.java:97: Found 'DD'-anomaly for variable 'ret' (lines '97'-'124'). +src/net/sf/freecol/common/model/UnitWas.java:101: Found 'DU'-anomaly for variable 'newType' (lines '101'-'165'). +src/net/sf/freecol/common/model/UnitWas.java:103: Found 'DU'-anomaly for variable 'newRoleCount' (lines '103'-'165'). +src/net/sf/freecol/common/model/UnitWas.java:105: Found 'DU'-anomaly for variable 'newWorkAmount' (lines '105'-'165'). +src/net/sf/freecol/common/model/UnitWas.java:111: Local variable 'oldFcgo' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:112: Found 'DU'-anomaly for variable 'newFcgo' (lines '112'-'165'). +src/net/sf/freecol/common/model/UnitWas.java:112: Local variable 'newFcgo' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:113: Use equals() to compare object references. +src/net/sf/freecol/common/model/UnitWas.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'124'). +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'129'). +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'139'). +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'143'). +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'148'). +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'151'). +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'158'). +src/net/sf/freecol/common/model/UnitWas.java:118: Found 'DD'-anomaly for variable 'ret' (lines '118'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:121: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/UnitWas.java:121: Use equals() to compare object references. +src/net/sf/freecol/common/model/UnitWas.java:122: Avoid variables with short names like pc +src/net/sf/freecol/common/model/UnitWas.java:122: Local variable 'pc' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:122: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/model/UnitWas.java:124: Found 'DD'-anomaly for variable 'ret' (lines '124'-'139'). +src/net/sf/freecol/common/model/UnitWas.java:124: Found 'DD'-anomaly for variable 'ret' (lines '124'-'143'). +src/net/sf/freecol/common/model/UnitWas.java:124: Found 'DD'-anomaly for variable 'ret' (lines '124'-'148'). +src/net/sf/freecol/common/model/UnitWas.java:124: Found 'DD'-anomaly for variable 'ret' (lines '124'-'151'). +src/net/sf/freecol/common/model/UnitWas.java:124: Found 'DD'-anomaly for variable 'ret' (lines '124'-'158'). +src/net/sf/freecol/common/model/UnitWas.java:124: Found 'DD'-anomaly for variable 'ret' (lines '124'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:125: Use equals() to compare object references. +src/net/sf/freecol/common/model/UnitWas.java:126: Avoid variables with short names like pc +src/net/sf/freecol/common/model/UnitWas.java:126: Local variable 'pc' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:129: Found 'DD'-anomaly for variable 'ret' (lines '129'-'139'). +src/net/sf/freecol/common/model/UnitWas.java:129: Found 'DD'-anomaly for variable 'ret' (lines '129'-'143'). +src/net/sf/freecol/common/model/UnitWas.java:129: Found 'DD'-anomaly for variable 'ret' (lines '129'-'148'). +src/net/sf/freecol/common/model/UnitWas.java:129: Found 'DD'-anomaly for variable 'ret' (lines '129'-'151'). +src/net/sf/freecol/common/model/UnitWas.java:129: Found 'DD'-anomaly for variable 'ret' (lines '129'-'158'). +src/net/sf/freecol/common/model/UnitWas.java:129: Found 'DD'-anomaly for variable 'ret' (lines '129'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:131: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/UnitWas.java:131: Use equals() to compare object references. +src/net/sf/freecol/common/model/UnitWas.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:139: Found 'DD'-anomaly for variable 'ret' (lines '139'-'148'). +src/net/sf/freecol/common/model/UnitWas.java:139: Found 'DD'-anomaly for variable 'ret' (lines '139'-'151'). +src/net/sf/freecol/common/model/UnitWas.java:139: Found 'DD'-anomaly for variable 'ret' (lines '139'-'158'). +src/net/sf/freecol/common/model/UnitWas.java:139: Found 'DD'-anomaly for variable 'ret' (lines '139'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:143: Found 'DD'-anomaly for variable 'ret' (lines '143'-'148'). +src/net/sf/freecol/common/model/UnitWas.java:143: Found 'DD'-anomaly for variable 'ret' (lines '143'-'151'). +src/net/sf/freecol/common/model/UnitWas.java:143: Found 'DD'-anomaly for variable 'ret' (lines '143'-'158'). +src/net/sf/freecol/common/model/UnitWas.java:143: Found 'DD'-anomaly for variable 'ret' (lines '143'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:146: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/UnitWas.java:146: Use equals() to compare object references. +src/net/sf/freecol/common/model/UnitWas.java:148: Found 'DD'-anomaly for variable 'ret' (lines '148'-'158'). +src/net/sf/freecol/common/model/UnitWas.java:148: Found 'DD'-anomaly for variable 'ret' (lines '148'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:151: Found 'DD'-anomaly for variable 'ret' (lines '151'-'158'). +src/net/sf/freecol/common/model/UnitWas.java:151: Found 'DD'-anomaly for variable 'ret' (lines '151'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:158: Found 'DD'-anomaly for variable 'ret' (lines '158'-'162'). +src/net/sf/freecol/common/model/UnitWas.java:168: Parameter 'fcgo' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitWas.java:169: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:169: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:174: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/model/UnitWas.java:178: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitWas.java:178: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitWas.java:179: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitWas.java:179: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitWas.java:181: Local variable 'info' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:181: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:182: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitWas.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:193: Avoid variables with short names like uw +src/net/sf/freecol/common/model/UnitWas.java:193: Parameter 'uw' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitWas.java:205: Found 'DU'-anomaly for variable 'roles' (lines '205'-'212'). +src/net/sf/freecol/common/model/UnitWas.java:205: Local variable 'roles' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:206: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:220: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/model/UnitWas.java:222: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/UnitWas.java:232: Found 'DD'-anomaly for variable 'hash' (lines '232'-'233'). +src/net/sf/freecol/common/model/UnitWas.java:248: The method 'toString' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/UnitWas.java:248: The method 'toString' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/UnitWas.java:248: The method 'toString' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/common/model/UnitWas.java:248: The method toString() has an NPath complexity of 156060 +src/net/sf/freecol/common/model/UnitWas.java:249: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:251: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitWas.java:251: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/model/UnitWas.java:252: Local variable 'locStr' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:258: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:258: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:260: Local variable 'newLoc' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:262: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/UnitWas.java:262: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/model/UnitWas.java:263: Local variable 'newLocStr' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:267: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:267: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:267: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:269: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:269: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/UnitWas.java:271: Local variable 'newWork' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:272: Local variable 'newWorkAmount' could be declared final +src/net/sf/freecol/common/model/UnitWas.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:274: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/UnitWas.java:275: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:275: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:277: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:277: Useless parentheses. +src/net/sf/freecol/common/model/UnitWas.java:279: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/mission/AbstractMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/mission/AbstractMission.java:73: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:84: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:85: Avoid unused constructor parameters such as 'xr'. +src/net/sf/freecol/common/model/mission/AbstractMission.java:85: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/AbstractMission.java:85: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:95: Avoid variables with short names like e +src/net/sf/freecol/common/model/mission/AbstractMission.java:95: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:95: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:107: Avoid variables with short names like id +src/net/sf/freecol/common/model/mission/AbstractMission.java:107: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:107: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:178: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:185: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/mission/AbstractMission.java:185: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/AbstractMission.java:186: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/mission/AbstractMission.java:186: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/AbstractMission.java:187: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/mission/AbstractMission.java:187: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/AbstractMission.java:194: Avoid variables with short names like xw +src/net/sf/freecol/common/model/mission/AbstractMission.java:194: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/AbstractMission.java:209: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/AbstractMission.java:209: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/mission/CompoundMission.java:57: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:69: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/CompoundMission.java:69: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:79: Avoid variables with short names like e +src/net/sf/freecol/common/model/mission/CompoundMission.java:79: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:79: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:90: Avoid variables with short names like id +src/net/sf/freecol/common/model/mission/CompoundMission.java:90: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:90: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/mission/CompoundMission.java:137: Useless parentheses. +src/net/sf/freecol/common/model/mission/CompoundMission.java:137: Useless parentheses. +src/net/sf/freecol/common/model/mission/CompoundMission.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/mission/CompoundMission.java:147: Local variable 'state' could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/mission/CompoundMission.java:155: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/mission/CompoundMission.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/mission/CompoundMission.java:159: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/mission/CompoundMission.java:167: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/mission/CompoundMission.java:167: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/CompoundMission.java:174: Avoid variables with short names like xw +src/net/sf/freecol/common/model/mission/CompoundMission.java:174: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:184: Avoid variables with short names like xw +src/net/sf/freecol/common/model/mission/CompoundMission.java:184: Found 'UR'-anomaly for variable 'mission' (lines '184'-'188'). +src/net/sf/freecol/common/model/mission/CompoundMission.java:184: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:187: Local variable 'mission' could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:196: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/CompoundMission.java:196: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:207: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/CompoundMission.java:207: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:212: Local variable 'mission' could be declared final +src/net/sf/freecol/common/model/mission/CompoundMission.java:213: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/mission/GoToMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/mission/GoToMission.java:54: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:66: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/GoToMission.java:66: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:76: Avoid variables with short names like e +src/net/sf/freecol/common/model/mission/GoToMission.java:76: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:76: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:87: Avoid variables with short names like id +src/net/sf/freecol/common/model/mission/GoToMission.java:87: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:87: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:158: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:165: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/mission/GoToMission.java:165: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/GoToMission.java:166: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/mission/GoToMission.java:166: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/GoToMission.java:173: Avoid variables with short names like xw +src/net/sf/freecol/common/model/mission/GoToMission.java:173: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/GoToMission.java:185: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/GoToMission.java:185: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/mission/ImprovementMission.java:53: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:65: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/ImprovementMission.java:65: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:75: Avoid variables with short names like e +src/net/sf/freecol/common/model/mission/ImprovementMission.java:75: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:75: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:86: Avoid variables with short names like id +src/net/sf/freecol/common/model/mission/ImprovementMission.java:86: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:86: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:116: Local variable 'work' could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/mission/ImprovementMission.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/mission/ImprovementMission.java:119: Useless parentheses. +src/net/sf/freecol/common/model/mission/ImprovementMission.java:119: Useless parentheses. +src/net/sf/freecol/common/model/mission/ImprovementMission.java:143: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/mission/ImprovementMission.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/mission/ImprovementMission.java:146: Avoid variables with short names like ti +src/net/sf/freecol/common/model/mission/ImprovementMission.java:152: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/mission/ImprovementMission.java:152: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/ImprovementMission.java:159: Avoid variables with short names like xw +src/net/sf/freecol/common/model/mission/ImprovementMission.java:159: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/ImprovementMission.java:170: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/ImprovementMission.java:170: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/Mission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/mission/Mission.java:37: enumCommentRequirement Required +src/net/sf/freecol/common/model/mission/Mission.java:64: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/mission/Mission.java:75: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/mission/Mission.java:83: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/mission/Mission.java:93: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/mission/Mission.java:93: Avoid variables with short names like xw +src/net/sf/freecol/common/model/mission/MissionManager.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/mission/MissionManager.java:39: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/model/mission/MissionManager.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/model/mission/MissionManager.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/MissionManager.java:43: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/model/mission/MissionManager.java:43: Variables that are final and static should be all capitals, 'missionMap' is not all capitals. +src/net/sf/freecol/common/model/mission/MissionManager.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/model/mission/MissionManager.java:67: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/MissionManager.java:71: Comment is too large: Too many lines +src/net/sf/freecol/common/model/mission/MissionManager.java:80: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/MissionManager.java:81: Avoid variables with short names like xr +src/net/sf/freecol/common/model/mission/MissionManager.java:81: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/model/mission/MissionManager.java:82: Local variable 'tag' could be declared final +src/net/sf/freecol/common/model/mission/MissionManager.java:83: Avoid variables with short names like c +src/net/sf/freecol/common/model/mission/MissionManager.java:83: Local variable 'c' could be declared final +src/net/sf/freecol/common/model/mission/MissionManager.java:85: There is log block not surrounded by if +src/net/sf/freecol/common/model/mission/MissionManager.java:87: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/mission/MissionManager.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/mission/MissionManager.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/mission/MissionManager.java:91: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/model/mission/MissionManager.java:92: There is log block not surrounded by if +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:36: Each class should declare at least one constructor +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:36: The class 'BaseCostDecider' has a Cyclomatic Complexity of 7 (Highest = 17). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:36: The class 'BaseCostDecider' has a Modified Cyclomatic Complexity of 5 (Highest = 11). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:36: The class 'BaseCostDecider' has a Standard Cyclomatic Complexity of 5 (Highest = 13). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:45: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:56: The method 'getCost' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:56: The method 'getCost' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:56: The method 'getCost' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:57: Parameter 'movesLeftBefore' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:58: Found 'DD'-anomaly for variable 'cost' (lines '58'-'110'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:58: Found 'DD'-anomaly for variable 'cost' (lines '58'-'70'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:58: Found 'DD'-anomaly for variable 'cost' (lines '58'-'79'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:58: Found 'DU'-anomaly for variable 'cost' (lines '58'-'128'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:61: Found 'DU'-anomaly for variable 'oldTile' (lines '61'-'128'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:61: Local variable 'oldTile' could be declared final +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:62: Found 'DU'-anomaly for variable 'newTile' (lines '62'-'128'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:62: Local variable 'newTile' could be declared final +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:64: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:66: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:67: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:67: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:73: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:76: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:76: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:76: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:82: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:87: Found 'DD'-anomaly for variable 'consumeMove' (lines '87'-'104'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:87: Found 'DU'-anomaly for variable 'consumeMove' (lines '87'-'128'). +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:95: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/BaseCostDecider.java:115: Local variable 'initialMoves' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDecider.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/CostDecider.java:34: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/pathfinding/CostDecider.java:34: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDecider.java:36: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/CostDecider.java:48: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/pathfinding/CostDecider.java:57: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/pathfinding/CostDecider.java:65: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:20: Possible God class (WMC=62, ATFD=33, TCC=0.0) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:35: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:35: The class 'CostDeciders' has a Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:35: The class 'CostDeciders' has a Modified Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:35: The class 'CostDeciders' has a Standard Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:40: Avoid excessively long variable names like avoidIllegalCostDecider +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:40: Variables that are final and static should be all capitals, 'avoidIllegalCostDecider' is not all capitals. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:49: Avoid excessively long variable names like trivialCostDecider +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:49: Variables that are final and static should be all capitals, 'trivialCostDecider' is not all capitals. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:51: Parameter 'oldLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:51: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:51: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:52: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:52: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:59: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:61: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:70: Variables that are final and static should be all capitals, 'tileCostDecider' is not all capitals. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:72: Parameter 'oldLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:72: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:72: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:73: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:73: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:81: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:83: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:93: Parameter 'oldLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:93: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:93: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:94: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:94: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:95: Local variable 'cost' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:98: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:98: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:109: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:110: Avoid excessively long variable names like serverAvoidIllegalCostDecider +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:110: Variables that are final and static should be all capitals, 'serverAvoidIllegalCostDecider' is not all capitals. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:119: Parameter 'oldLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:119: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:119: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:120: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:120: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:121: Local variable 'cost' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:123: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:126: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:135: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:136: Avoid excessively long variable names like avoidSettlementsCostDecider +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:136: Variables that are final and static should be all capitals, 'avoidSettlementsCostDecider' is not all capitals. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:147: Parameter 'oldLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:147: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:147: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:148: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:148: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:149: Local variable 'cost' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:150: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:154: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:156: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:159: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:169: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:170: Avoid excessively long variable names like avoidSettlementsAndBlockingUnitsCostDecider +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:170: Variables that are final and static should be all capitals, 'avoidSettlementsAndBlockingUnitsCostDecider' is not all capitals. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:177: The class 'AvoidNavalDangerCostDecider' has a Cyclomatic Complexity of 12 (Highest = 11). +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:181: Found 'UR'-anomaly for variable 't' (lines '181'-'191'). +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:181: Found 'UR'-anomaly for variable 'u' (lines '181'-'192'). +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:181: Parameter 'oldLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:181: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:181: The method 'getCost' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:181: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:182: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:184: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:189: Found 'DU'-anomaly for variable 'owner' (lines '189'-'205'). +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:190: Local variable 't' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:191: Local variable 'u' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:191: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:192: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:194: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:194: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:211: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:222: The method 'getComposedCostDecider' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:222: The method 'getComposedCostDecider' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:222: The method 'getComposedCostDecider' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:222: The method getComposedCostDecider() has an NPath complexity of 352 +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:223: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:229: It is somewhat confusing to have a field name matching the declaring class name +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:229: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:230: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:231: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:234: Parameter 'oldLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:234: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:234: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:235: Parameter 'movesLeft' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:235: Parameter 'newLocation' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:237: Local variable 'cost' could be declared final +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:252: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:253: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:253: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:257: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:258: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/CostDeciders.java:258: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/GoalDecider.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/GoalDecider.java:27: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/GoalDecider.java:52: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/pathfinding/GoalDecider.java:61: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/pathfinding/GoalDecider.java:63: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/GoalDecider.java:79: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/model/pathfinding/GoalDecider.java:79: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:20: Possible God class (WMC=106, ATFD=56, TCC=0.0) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:40: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:40: The class 'GoalDeciders' has a Cyclomatic Complexity of 9 (Highest = 21). +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:40: The class 'GoalDeciders' has a Modified Cyclomatic Complexity of 8 (Highest = 16). +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:40: The class 'GoalDeciders' has a Standard Cyclomatic Complexity of 8 (Highest = 16). +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:40: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:40: Too many fields +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:42: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:53: The method 'getComposedGoalDecider' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:53: The method 'getComposedGoalDecider' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:53: The method 'getComposedGoalDecider' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:53: The method getComposedGoalDecider() has an NPath complexity of 680 +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:55: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:60: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:61: Avoid using redundant field initializer for 'goal' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:66: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:68: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:70: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:72: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:78: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:78: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:78: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:78: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:80: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:111: Avoid using redundant field initializer for 'bestPath' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:111: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:112: Avoid using redundant field initializer for 'bestValue' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:112: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:115: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:117: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:119: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:119: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:119: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:119: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:120: Local variable 'loc' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:121: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:123: Local variable 'value' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:123: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:123: Useless parentheses. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:142: The method 'getHighSeasGoalDecider' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:144: Avoid using redundant field initializer for 'best' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:144: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:147: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:149: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:151: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:151: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:151: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:151: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:152: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:158: These nested if statements could be combined +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:176: Avoid using redundant field initializer for 'first' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:176: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:179: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:181: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:183: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:183: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:183: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:183: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:184: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:204: Avoid using redundant field initializer for 'best' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:204: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:205: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:208: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:210: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:212: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:212: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:212: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:212: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:215: Avoid assignments in operands +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:233: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:235: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:235: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:238: Avoid using redundant field initializer for 'best' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:238: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:241: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:243: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:245: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:245: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:245: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:245: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:246: Avoid variables with short names like t +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:246: Local variable 't' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:265: Avoid using redundant field initializer for 'best' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:265: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:268: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:270: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:272: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:272: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:272: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:272: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:273: Avoid variables with short names like t +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:273: Local variable 't' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:274: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:275: Avoid variables with short names like s +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:275: Local variable 's' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:276: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:286: Comment is too large: Too many lines +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:300: The method 'getDisembarkGoalDecider' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:300: The method 'getDisembarkGoalDecider' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:300: The method 'getDisembarkGoalDecider' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:300: The method getDisembarkGoalDecider() has an NPath complexity of 968 +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:302: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:303: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:304: Avoid using redundant field initializer for 'goal' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:304: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:307: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:309: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: Parameter 'pathNode' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: The method 'check' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: The method 'check' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: The method 'check' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: The method check() has an NPath complexity of 960 +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:311: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:312: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:313: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:314: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:316: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:317: Local variable 't' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:318: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:319: Local variable 't2' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:320: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:323: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:338: Use bitwise inversion to invert boolean values +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:342: Local variable 'distance' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:342: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:342: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:344: Local variable 'score' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:364: Avoid using redundant field initializer for 'goal' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:364: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:367: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:369: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:371: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:371: Parameter 'pathNode' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:371: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:371: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:372: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:373: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:390: Avoid using redundant field initializer for 'goal' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:390: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:391: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:391: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:394: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:396: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:398: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:398: Parameter 'pathNode' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:398: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:398: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:399: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:401: Avoid variables with short names like s +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:401: Local variable 's' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:402: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:423: Avoid using redundant field initializer for 'goal' +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:423: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:424: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:427: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:429: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:431: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:431: Parameter 'pathNode' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:431: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:431: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:432: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:434: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:450: Avoid variables with short names like gd +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:450: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:450: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:452: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:452: fieldCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:465: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:467: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:469: Avoid variables with short names like u +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:469: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:469: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:469: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:470: Local variable 'tile' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:471: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:471: Avoid using if statements without curly braces +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:472: Local variable 'loc' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:473: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:474: Avoid variables with short names like p +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:474: Local variable 'p' could be declared final +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:486: publicMethodCommentRequirement Required +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:490: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/model/pathfinding/GoalDeciders.java:490: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:46: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:58: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:58: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:58: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:65: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:75: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:75: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:76: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:77: Found 'DU'-anomaly for variable 'serverPlayer' (lines '77'-'95'). +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:81: Found 'DU'-anomaly for variable 'colony' (lines '81'-'95'). +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:82: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:83: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:86: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AbandonColonyMessage.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AskSkillMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AskSkillMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AskSkillMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AskSkillMessage.java:54: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:54: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:68: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/AskSkillMessage.java:68: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:76: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AskSkillMessage.java:86: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:86: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:92: Found 'DU'-anomaly for variable 'unit' (lines '92'-'119'). +src/net/sf/freecol/common/networking/AskSkillMessage.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:93: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AskSkillMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AskSkillMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:100: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AskSkillMessage.java:101: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AskSkillMessage.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:104: Avoid variables with short names like is +src/net/sf/freecol/common/networking/AskSkillMessage.java:104: Local variable 'is' could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:106: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AskSkillMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:110: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/AskSkillMessage.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AskSkillMessage.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AskSkillMessage.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:50: Parameter 'student' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:50: Parameter 'teacher' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:72: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:81: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:81: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:82: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:83: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:83: Found 'DU'-anomaly for variable 'serverPlayer' (lines '83'-'122'). +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:87: Found 'DU'-anomaly for variable 'student' (lines '87'-'122'). +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:88: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:89: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:89: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:95: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:96: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:102: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:106: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:108: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:109: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:111: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTeacherMessage.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:50: Parameter 'tradeRoute' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:50: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:54: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:70: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:82: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:87: Found 'DU'-anomaly for variable 'unit' (lines '87'-'107'). +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:88: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:89: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:89: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:94: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:99: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:116: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/AssignTradeRouteMessage.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AttackMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AttackMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/AttackMessage.java:53: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:53: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:67: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/AttackMessage.java:67: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:67: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:75: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/AttackMessage.java:84: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:84: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:85: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:90: Found 'DU'-anomaly for variable 'unit' (lines '90'-'124'). +src/net/sf/freecol/common/networking/AttackMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:91: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AttackMessage.java:92: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AttackMessage.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:98: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/AttackMessage.java:99: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AttackMessage.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:102: Local variable 'moveType' could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:106: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/AttackMessage.java:106: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/AttackMessage.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AttackMessage.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AttackMessage.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AttackMessage.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:114: Local variable 'defender' could be declared final +src/net/sf/freecol/common/networking/AttackMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/AttackMessage.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AttackMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AttackMessage.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/AttackMessage.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AttackMessage.java:133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/AttackMessage.java:133: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/BuildColonyMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/BuildColonyMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuildColonyMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuildColonyMessage.java:51: Parameter 'builder' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:51: Parameter 'colonyName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/BuildColonyMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:72: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/BuildColonyMessage.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:83: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:84: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/BuildColonyMessage.java:84: Found 'DU'-anomaly for variable 'serverPlayer' (lines '84'-'116'). +src/net/sf/freecol/common/networking/BuildColonyMessage.java:85: Found 'DU'-anomaly for variable 'game' (lines '85'-'116'). +src/net/sf/freecol/common/networking/BuildColonyMessage.java:89: Found 'DU'-anomaly for variable 'unit' (lines '89'-'116'). +src/net/sf/freecol/common/networking/BuildColonyMessage.java:90: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/BuildColonyMessage.java:91: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuildColonyMessage.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuildColonyMessage.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuildColonyMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuildColonyMessage.java:99: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuildColonyMessage.java:100: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/networking/BuildColonyMessage.java:101: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/BuildColonyMessage.java:101: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/BuildColonyMessage.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuildColonyMessage.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuildColonyMessage.java:107: Local variable 'tile' could be declared final +src/net/sf/freecol/common/networking/BuildColonyMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuildColonyMessage.java:109: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuildColonyMessage.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/BuyMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/BuyMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyMessage.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyMessage.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyMessage.java:60: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:60: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:60: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:61: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:77: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:77: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyMessage.java:104: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/BuyMessage.java:113: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:113: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:114: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:115: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/BuyMessage.java:115: Found 'DU'-anomaly for variable 'serverPlayer' (lines '115'-'143'). +src/net/sf/freecol/common/networking/BuyMessage.java:119: Found 'DU'-anomaly for variable 'unit' (lines '119'-'143'). +src/net/sf/freecol/common/networking/BuyMessage.java:120: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/BuyMessage.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyMessage.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyMessage.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyMessage.java:127: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/BuyMessage.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyMessage.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyMessage.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyMessage.java:137: Local variable 'gold' could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:138: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyMessage.java:138: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/BuyMessage.java:141: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/BuyMessage.java:152: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/BuyMessage.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyMessage.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:60: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:60: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:61: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:61: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:77: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:77: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:104: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:114: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:114: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:115: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:116: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:116: Found 'DU'-anomaly for variable 'serverPlayer' (lines '116'-'144'). +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:120: Found 'DU'-anomaly for variable 'unit' (lines '120'-'144'). +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:121: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:122: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:125: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:132: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:137: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:153: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/BuyPropositionMessage.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:46: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:75: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:75: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:76: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:77: Found 'DU'-anomaly for variable 'serverPlayer' (lines '77'-'96'). +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:81: Found 'DU'-anomaly for variable 'unit' (lines '81'-'96'). +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:82: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:83: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:85: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:86: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:89: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/CashInTreasureTrainMessage.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChangeStateMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChangeStateMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChangeStateMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChangeStateMessage.java:51: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeStateMessage.java:51: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeStateMessage.java:65: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ChangeStateMessage.java:65: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeStateMessage.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeStateMessage.java:73: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChangeStateMessage.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeStateMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeStateMessage.java:83: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeStateMessage.java:84: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/ChangeStateMessage.java:84: Found 'DU'-anomaly for variable 'serverPlayer' (lines '84'-'109'). +src/net/sf/freecol/common/networking/ChangeStateMessage.java:88: Found 'DU'-anomaly for variable 'unit' (lines '88'-'109'). +src/net/sf/freecol/common/networking/ChangeStateMessage.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ChangeStateMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeStateMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeStateMessage.java:97: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ChangeStateMessage.java:98: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeStateMessage.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeStateMessage.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeStateMessage.java:101: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeStateMessage.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChangeStateMessage.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChangeStateMessage.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeStateMessage.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:38: The class 'ChangeWorkImprovementTypeMessage' has a Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:38: The class 'ChangeWorkImprovementTypeMessage' has a Modified Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:38: The class 'ChangeWorkImprovementTypeMessage' has a Standard Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:54: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:55: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:86: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:86: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:86: The method 'handle' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:86: The method 'handle' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:86: The method 'handle' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:88: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:88: Found 'DU'-anomaly for variable 'serverPlayer' (lines '88'-'132'). +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:92: Found 'DU'-anomaly for variable 'unit' (lines '92'-'132'). +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:93: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:97: Local variable 'tile' could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:99: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:101: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:105: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:109: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:114: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:117: Avoid assignments in operands +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkImprovementTypeMessage.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:51: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:51: Parameter 'workType' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:65: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:65: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:73: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:83: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:84: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:84: Found 'DU'-anomaly for variable 'serverPlayer' (lines '84'-'104'). +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:88: Found 'DU'-anomaly for variable 'unit' (lines '88'-'104'). +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:93: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:96: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:98: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChangeWorkTypeMessage.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChatMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChatMessage.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChatMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChatMessage.java:53: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:53: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:53: Parameter 'privateChat' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ChatMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:86: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:117: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:117: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChatMessage.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChatMessage.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:55: Parameter 'fathers' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:56: Avoid variables with short names like ff +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:56: Parameter 'ff' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:71: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:71: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:76: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:77: Avoid variables with short names like id +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:77: Local variable 'id' could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:78: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:79: Avoid variables with short names like ff +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:79: Local variable 'ff' could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:94: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:95: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:104: Avoid variables with short names like ff +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:104: Parameter 'ff' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:105: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:119: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:129: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:129: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:130: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:133: Found 'DU'-anomaly for variable 'offered' (lines '133'-'148'). +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:134: Avoid variables with short names like ff +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:134: Found 'DU'-anomaly for variable 'ff' (lines '134'-'148'). +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:136: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:137: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:142: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:156: Found 'UR'-anomaly for variable 'f' (lines '156'-'159'). +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:157: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:158: Local variable 'f' could be declared final +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ChooseFoundingFatherMessage.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ClaimLandMessage.java:38: The class 'ClaimLandMessage' has a Cyclomatic Complexity of 6 (Highest = 23). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:38: The class 'ClaimLandMessage' has a Modified Cyclomatic Complexity of 5 (Highest = 18). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:38: The class 'ClaimLandMessage' has a Standard Cyclomatic Complexity of 5 (Highest = 19). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:58: Parameter 'claimant' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:58: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:58: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:72: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:72: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:72: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:81: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ClaimLandMessage.java:90: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:90: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:90: The method 'handle' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:90: The method 'handle' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:90: The method 'handle' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:90: The method handle() has an NPath complexity of 1440 +src/net/sf/freecol/common/networking/ClaimLandMessage.java:91: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:92: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:92: Found 'DU'-anomaly for variable 'serverPlayer' (lines '92'-'181'). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:95: Local variable 'tile' could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:100: Found 'DD'-anomaly for variable 'unit' (lines '100'-'102'). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:103: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ClaimLandMessage.java:103: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ClaimLandMessage.java:104: Found 'DD'-anomaly for variable 'settlement' (lines '104'-'106'). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:106: Found 'DU'-anomaly for variable 'settlement' (lines '106'-'181'). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:108: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ClaimLandMessage.java:108: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ClaimLandMessage.java:109: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/ClaimLandMessage.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:111: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:113: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/ClaimLandMessage.java:114: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:120: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:126: Found 'DU'-anomaly for variable 'price' (lines '126'-'181'). +src/net/sf/freecol/common/networking/ClaimLandMessage.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:132: Local variable 'value' could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:133: Local variable 'owner' could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:134: Local variable 'ownerSettlement' could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:137: Use equals() to compare object references. +src/net/sf/freecol/common/networking/ClaimLandMessage.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:140: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:140: The String literal "Can not claim tile " appears 4 times in this file; the first occurrence is on line 140 +src/net/sf/freecol/common/networking/ClaimLandMessage.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:149: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:153: Local variable 'why' could be declared final +src/net/sf/freecol/common/networking/ClaimLandMessage.java:160: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:164: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:171: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClaimLandMessage.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClaimLandMessage.java:179: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:46: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:75: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:75: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:76: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:77: Found 'DU'-anomaly for variable 'serverPlayer' (lines '77'-'89'). +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:81: Found 'DU'-anomaly for variable 'unit' (lines '81'-'89'). +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:82: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:83: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ClearSpecialityMessage.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Client.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Client.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/networking/Client.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Client.java:43: Avoid variables with short names like c +src/net/sf/freecol/common/networking/Client.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Client.java:52: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Client.java:62: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:62: Parameter 'host' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:62: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:62: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:109: Avoid variables with short names like mh +src/net/sf/freecol/common/networking/Client.java:109: Parameter 'mh' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:129: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:133: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Client.java:142: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:146: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Client.java:155: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:159: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Client.java:169: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:173: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Client.java:183: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:187: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Client.java:198: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:208: Parameter 'reply' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Client.java:211: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/Client.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Client.java:213: There is log block not surrounded by if +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:55: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:55: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:85: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:85: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:86: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:87: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:87: Found 'DU'-anomaly for variable 'serverPlayer' (lines '87'-'106'). +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:91: Found 'DU'-anomaly for variable 'unit' (lines '91'-'106'). +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:92: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:93: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:99: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CloseTransactionMessage.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Connection.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Connection.java:20: Possible God class (WMC=47, ATFD=32, TCC=0.05263157894736842) +src/net/sf/freecol/common/networking/Connection.java:60: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/networking/Connection.java:62: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/networking/Connection.java:62: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:64: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:65: Avoid excessively long variable names like NETWORK_REPLY_ID_TAG +src/net/sf/freecol/common/networking/Connection.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:66: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:68: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:69: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:71: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:73: Avoid variables with short names like in +src/net/sf/freecol/common/networking/Connection.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:73: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:75: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:75: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:77: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:79: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:81: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:81: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:83: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:85: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:85: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:88: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:89: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Connection.java:89: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:97: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:98: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:99: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:100: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:103: Local variable 'factory' could be declared final +src/net/sf/freecol/common/networking/Connection.java:111: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:112: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:118: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:119: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:123: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Connection.java:133: Parameter 'host' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:133: Parameter 'messageHandler' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:133: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:134: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:138: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Connection.java:147: Parameter 'messageHandler' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:147: Parameter 'socket' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:148: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:169: Parameter 'host' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:169: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:171: Local variable 'socket' could be declared final +src/net/sf/freecol/common/networking/Connection.java:172: Local variable 'addr' could be declared final +src/net/sf/freecol/common/networking/Connection.java:201: Avoid variables with short names like mh +src/net/sf/freecol/common/networking/Connection.java:201: Parameter 'mh' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:228: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/Connection.java:235: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/Connection.java:242: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:257: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Connection.java:257: There is log block not surrounded by if +src/net/sf/freecol/common/networking/Connection.java:268: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/Connection.java:277: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:286: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:290: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Connection.java:290: There is log block not surrounded by if +src/net/sf/freecol/common/networking/Connection.java:299: Avoid variables with short names like e +src/net/sf/freecol/common/networking/Connection.java:299: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:299: Parameter 'send' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:309: Parameter 'send' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:309: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:322: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/Connection.java:322: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/Connection.java:334: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:335: Avoid variables with short names like os +src/net/sf/freecol/common/networking/Connection.java:335: Local variable 'os' could be declared final +src/net/sf/freecol/common/networking/Connection.java:337: Local variable 'source' could be declared final +src/net/sf/freecol/common/networking/Connection.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:357: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:358: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/Connection.java:358: Found 'DU'-anomaly for variable 'networkReplyId' (lines '358'-'380'). +src/net/sf/freecol/common/networking/Connection.java:358: Local variable 'networkReplyId' could be declared final +src/net/sf/freecol/common/networking/Connection.java:359: Found 'DU'-anomaly for variable 'tag' (lines '359'-'380'). +src/net/sf/freecol/common/networking/Connection.java:359: Local variable 'tag' could be declared final +src/net/sf/freecol/common/networking/Connection.java:365: Local variable 'question' could be declared final +src/net/sf/freecol/common/networking/Connection.java:365: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Connection.java:367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:371: Local variable 'nro' could be declared final +src/net/sf/freecol/common/networking/Connection.java:373: Local variable 'response' could be declared final +src/net/sf/freecol/common/networking/Connection.java:373: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:374: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:374: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/Connection.java:375: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Connection.java:375: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:378: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/Connection.java:378: Local variable 'child' could be declared final +src/net/sf/freecol/common/networking/Connection.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:379: Consider simply returning the value vs storing it in local variable 'child' +src/net/sf/freecol/common/networking/Connection.java:383: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Connection.java:392: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:394: There is log block not surrounded by if +src/net/sf/freecol/common/networking/Connection.java:397: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Connection.java:407: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:409: There is log block not surrounded by if +src/net/sf/freecol/common/networking/Connection.java:412: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Connection.java:421: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Connection.java:422: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/Connection.java:423: There is log block not surrounded by if +src/net/sf/freecol/common/networking/Connection.java:424: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:434: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/common/networking/Connection.java:434: Avoid variables with short names like in +src/net/sf/freecol/common/networking/Connection.java:440: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/networking/Connection.java:441: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/networking/Connection.java:442: Avoid variables with short names like xr +src/net/sf/freecol/common/networking/Connection.java:442: Found 'DD'-anomaly for variable 'xr' (lines '442'-'444'). +src/net/sf/freecol/common/networking/Connection.java:442: Found 'DD'-anomaly for variable 'xr' (lines '442'-'444'). +src/net/sf/freecol/common/networking/Connection.java:445: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:446: Found 'DU'-anomaly for variable 'question' (lines '446'-'501'). +src/net/sf/freecol/common/networking/Connection.java:446: Found 'DU'-anomaly for variable 'question' (lines '446'-'501'). +src/net/sf/freecol/common/networking/Connection.java:446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:447: Found 'DU'-anomaly for variable 'networkReplyId' (lines '447'-'501'). +src/net/sf/freecol/common/networking/Connection.java:447: Found 'DU'-anomaly for variable 'networkReplyId' (lines '447'-'501'). +src/net/sf/freecol/common/networking/Connection.java:447: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:452: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/Connection.java:456: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/networking/Connection.java:464: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/Connection.java:464: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:469: Avoid variables with short names like t +src/net/sf/freecol/common/networking/Connection.java:469: Local variable 't' could be declared final +src/net/sf/freecol/common/networking/Connection.java:469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:469: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/common/networking/Connection.java:469: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/common/networking/Connection.java:471: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/Connection.java:472: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Connection.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Connection.java:482: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:484: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:486: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:492: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/Connection.java:493: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/Connection.java:494: There is log block not surrounded by if +src/net/sf/freecol/common/networking/Connection.java:499: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:499: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:500: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Connection.java:510: Parameter 'request' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:38: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:47: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:58: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:59: Local variable 'game' could be declared final +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:60: Useless parentheses. +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:60: Useless parentheses. +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:61: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:68: Parameter 'conn' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:68: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:69: Local variable 'player' could be declared final +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:69: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:71: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/CurrentPlayerNetworkRequestHandler.java:73: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DOMMessage.java:20: Possible God class (WMC=55, ATFD=25, TCC=0.006535947712418301) +src/net/sf/freecol/common/networking/DOMMessage.java:57: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/networking/DOMMessage.java:59: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/networking/DOMMessage.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/DOMMessage.java:61: Avoid excessively long variable names like FREECOL_PROTOCOL_VERSION +src/net/sf/freecol/common/networking/DOMMessage.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/DOMMessage.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/DOMMessage.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DOMMessage.java:72: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DOMMessage.java:86: Parameter 'inputStream' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:91: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DOMMessage.java:100: Parameter 'inputSource' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:102: Local variable 'factory' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:104: Local variable 'dumpMsgOnError' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:112: Local variable 'builder' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:117: A catch statement that catches an exception only to rethrow it should be avoided. +src/net/sf/freecol/common/networking/DOMMessage.java:124: Local variable 'baos' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:127: Avoid variables with short names like i +src/net/sf/freecol/common/networking/DOMMessage.java:127: Local variable 'i' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:146: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:150: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DOMMessage.java:159: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:159: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:160: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DOMMessage.java:160: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/DOMMessage.java:161: Found 'DD'-anomaly for variable 'tag' (lines '161'-'162'). +src/net/sf/freecol/common/networking/DOMMessage.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:165: Local variable 'types' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:166: Local variable 'params' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:169: Found 'DD'-anomaly for variable 'message' (lines '169'-'172'). +src/net/sf/freecol/common/networking/DOMMessage.java:172: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/DOMMessage.java:193: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DOMMessage.java:193: Useless parentheses. +src/net/sf/freecol/common/networking/DOMMessage.java:193: Useless parentheses. +src/net/sf/freecol/common/networking/DOMMessage.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:205: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:206: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:215: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:225: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:225: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:235: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:235: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:245: Parameter 'attribute' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:255: Parameter 'newRoot' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:256: Local variable 'oldRoot' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:296: Local variable 'factory' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:298: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DOMMessage.java:298: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:313: Parameter 'tagName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:314: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:324: Parameter 'attributes' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:324: Parameter 'tagName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:325: Local variable 'root' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:326: Local variable 'all' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:341: Found 'UR'-anomaly for variable 'e' (lines '341'-'355'). +src/net/sf/freecol/common/networking/DOMMessage.java:341: Parameter 'elements' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:344: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DOMMessage.java:346: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DOMMessage.java:350: Local variable 'first' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:351: Local variable 'doc' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:351: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:352: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:352: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:354: Local variable 'e' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:360: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DOMMessage.java:369: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:369: Parameter 'messageID' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:370: Local variable 'errorElement' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:375: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:380: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DOMMessage.java:389: Avoid variables with short names like xw +src/net/sf/freecol/common/networking/DOMMessage.java:389: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:389: Parameter 'messageID' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:389: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:412: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:422: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DOMMessage.java:431: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:431: Parameter 'tagName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:432: Avoid variables with short names like n +src/net/sf/freecol/common/networking/DOMMessage.java:432: Local variable 'n' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:434: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:435: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:435: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DOMMessage.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:436: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DOMMessage.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:448: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:450: Local variable 'factory' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:451: Avoid variables with short names like xt +src/net/sf/freecol/common/networking/DOMMessage.java:451: Local variable 'xt' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:451: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:452: Avoid variables with short names like sw +src/net/sf/freecol/common/networking/DOMMessage.java:452: Local variable 'sw' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:458: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/networking/DOMMessage.java:459: Local variable 'index' could be declared final +src/net/sf/freecol/common/networking/DOMMessage.java:459: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DOMMessage.java:464: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DOMMessage.java:476: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:50: Parameter 'countryName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:50: Parameter 'nationName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:72: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:83: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:84: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:84: Found 'DU'-anomaly for variable 'serverPlayer' (lines '84'-'98'). +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:88: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:90: Local variable 'problem' could be declared final +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:92: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeclareIndependenceMessage.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:53: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:53: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:67: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:67: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:67: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:75: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:84: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:84: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:85: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:86: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:86: Found 'DU'-anomaly for variable 'serverPlayer' (lines '86'-'112'). +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:90: Found 'DU'-anomaly for variable 'unit' (lines '90'-'112'). +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:91: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:92: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:98: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:99: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:102: Local variable 'rumour' could be declared final +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:105: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeclineMoundsMessage.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:55: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:55: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:55: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:70: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:70: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:90: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:117: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:126: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:126: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:127: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:128: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:128: Found 'DU'-anomaly for variable 'serverPlayer' (lines '128'-'153'). +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:132: Found 'DU'-anomaly for variable 'unit' (lines '132'-'153'). +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:133: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:134: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:140: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:141: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:146: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:162: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DeliverGiftMessage.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DemandTributeMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DemandTributeMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DemandTributeMessage.java:55: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:55: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/DemandTributeMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DemandTributeMessage.java:86: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:86: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:88: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DemandTributeMessage.java:88: Found 'DU'-anomaly for variable 'serverPlayer' (lines '88'-'128'). +src/net/sf/freecol/common/networking/DemandTributeMessage.java:92: Found 'DU'-anomaly for variable 'unit' (lines '92'-'128'). +src/net/sf/freecol/common/networking/DemandTributeMessage.java:93: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DemandTributeMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DemandTributeMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:98: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/DemandTributeMessage.java:98: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/DemandTributeMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DemandTributeMessage.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:107: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DemandTributeMessage.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DemandTributeMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:111: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:114: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DemandTributeMessage.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:118: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/DemandTributeMessage.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DemandTributeMessage.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DemandTributeMessage.java:126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DiplomacyMessage.java:20: Possible God class (WMC=64, ATFD=40, TCC=0.14285714285714285) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:42: The class 'DiplomacyMessage' has a Cyclomatic Complexity of 5 (Highest = 51). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:42: The class 'DiplomacyMessage' has a Modified Cyclomatic Complexity of 4 (Highest = 41). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:42: The class 'DiplomacyMessage' has a Standard Cyclomatic Complexity of 5 (Highest = 44). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:70: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:70: Parameter 'our' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:71: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:77: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:87: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:87: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:88: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:99: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:99: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:100: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:111: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:111: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:112: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:124: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:124: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:130: Local variable 'nodes' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:131: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:131: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:131: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:133: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/networking/DiplomacyMessage.java:134: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:136: Avoid variables with short names like ue +src/net/sf/freecol/common/networking/DiplomacyMessage.java:136: Local variable 'ue' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:137: Avoid variables with short names like id +src/net/sf/freecol/common/networking/DiplomacyMessage.java:137: Local variable 'id' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:139: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/DiplomacyMessage.java:161: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:171: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:189: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:195: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DiplomacyMessage.java:204: Avoid really long methods. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:204: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:204: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:204: The method 'handle' has a Cyclomatic Complexity of 51. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:204: The method 'handle' has a Modified Cyclomatic Complexity of 41. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:204: The method 'handle' has a Standard Cyclomatic Complexity of 44. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:204: The method handle() has an NPath complexity of 1001952 +src/net/sf/freecol/common/networking/DiplomacyMessage.java:206: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:206: Found 'DU'-anomaly for variable 'game' (lines '206'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:209: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:212: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:212: Found 'DD'-anomaly for variable 'ourUnit' (lines '212'-'218'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:212: Found 'DU'-anomaly for variable 'ourUnit' (lines '212'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:213: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:213: Found 'DD'-anomaly for variable 'ourColony' (lines '213'-'226'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:213: Found 'DU'-anomaly for variable 'ourColony' (lines '213'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:214: Local variable 'our' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:216: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:219: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:220: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:222: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:228: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:231: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:234: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:234: Found 'DD'-anomaly for variable 'otherUnit' (lines '234'-'241'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:234: Found 'DU'-anomaly for variable 'otherUnit' (lines '234'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:235: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:235: Found 'DD'-anomaly for variable 'otherColony' (lines '235'-'258'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:235: Found 'DU'-anomaly for variable 'otherColony' (lines '235'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:236: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:236: Found 'DD'-anomaly for variable 'otherPlayer' (lines '236'-'256'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:236: Found 'DD'-anomaly for variable 'otherPlayer' (lines '236'-'270'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:236: Found 'DU'-anomaly for variable 'otherPlayer' (lines '236'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:237: Local variable 'other' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:239: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:244: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:245: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:247: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:248: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:249: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:253: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:256: Found 'DU'-anomaly for variable 'otherPlayer' (lines '256'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:260: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:261: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:262: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:263: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:266: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:267: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:270: Found 'DU'-anomaly for variable 'otherPlayer' (lines '270'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:272: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:275: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:278: Local variable 'senderPlayer' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:279: Found 'DU'-anomaly for variable 'recipientPlayer' (lines '279'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:279: Local variable 'recipientPlayer' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:280: Found 'DU'-anomaly for variable 'refPlayer' (lines '280'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:280: Local variable 'refPlayer' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:282: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:284: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:285: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:286: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:287: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:288: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:288: Use equals() to compare object references. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:289: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:291: Use equals() to compare object references. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:291: Use equals() to compare object references. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:292: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:296: Found 'DU'-anomaly for variable 'igc' (lines '296'-'360'). +src/net/sf/freecol/common/networking/DiplomacyMessage.java:299: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:299: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:302: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:308: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:308: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:309: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:309: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:309: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:314: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:316: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:316: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:316: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:316: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:316: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:322: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:322: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:323: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:323: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:323: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:323: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:323: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:326: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:331: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:333: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:333: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:333: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:333: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:333: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:336: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:342: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DiplomacyMessage.java:342: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/DiplomacyMessage.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:343: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:343: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:350: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:350: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:350: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:350: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:350: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:350: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:350: Useless parentheses. +src/net/sf/freecol/common/networking/DiplomacyMessage.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:369: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:372: Local variable 'doc' could be declared final +src/net/sf/freecol/common/networking/DiplomacyMessage.java:372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:373: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DiplomacyMessage.java:374: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/DiplomacyMessage.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:46: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:75: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:75: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:76: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:77: Found 'DU'-anomaly for variable 'serverPlayer' (lines '77'-'89'). +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:81: Found 'DU'-anomaly for variable 'unit' (lines '81'-'89'). +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:82: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:83: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DisbandUnitMessage.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/DisembarkMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DisembarkMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/DisembarkMessage.java:47: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisembarkMessage.java:60: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/DisembarkMessage.java:60: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisembarkMessage.java:60: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisembarkMessage.java:67: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/DisembarkMessage.java:76: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisembarkMessage.java:76: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisembarkMessage.java:77: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/DisembarkMessage.java:78: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/DisembarkMessage.java:78: Found 'DU'-anomaly for variable 'serverPlayer' (lines '78'-'90'). +src/net/sf/freecol/common/networking/DisembarkMessage.java:82: Found 'DU'-anomaly for variable 'unit' (lines '82'-'90'). +src/net/sf/freecol/common/networking/DisembarkMessage.java:83: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/DisembarkMessage.java:84: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/DisembarkMessage.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/DisembarkMessage.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/EmbarkMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/EmbarkMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/EmbarkMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/EmbarkMessage.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/EmbarkMessage.java:58: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:58: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:58: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:63: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/EmbarkMessage.java:74: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/EmbarkMessage.java:74: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:74: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:79: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/EmbarkMessage.java:79: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/EmbarkMessage.java:79: Useless parentheses. +src/net/sf/freecol/common/networking/EmbarkMessage.java:79: Useless parentheses. +src/net/sf/freecol/common/networking/EmbarkMessage.java:84: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/EmbarkMessage.java:93: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:93: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:94: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:95: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/EmbarkMessage.java:95: Found 'DU'-anomaly for variable 'serverPlayer' (lines '95'-'146'). +src/net/sf/freecol/common/networking/EmbarkMessage.java:99: Found 'DU'-anomaly for variable 'unit' (lines '99'-'146'). +src/net/sf/freecol/common/networking/EmbarkMessage.java:100: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/EmbarkMessage.java:101: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmbarkMessage.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:107: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/EmbarkMessage.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmbarkMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:111: Local variable 'sourceLocation' could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:117: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmbarkMessage.java:117: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/EmbarkMessage.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/EmbarkMessage.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:127: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmbarkMessage.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:134: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/EmbarkMessage.java:135: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmbarkMessage.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmbarkMessage.java:138: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmbarkMessage.java:144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/EmbarkMessage.java:155: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/EmbarkMessage.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:36: The class 'EmigrateUnitMessage' has a Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:47: Parameter 'slot' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:75: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:75: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:75: The method 'handle' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:76: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:77: Found 'DU'-anomaly for variable 'serverPlayer' (lines '77'-'118'). +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:79: Local variable 'europe' could be declared final +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:81: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:85: Found 'DU'-anomaly for variable 'slot' (lines '85'-'118'). +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:87: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EmigrateUnitMessage.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:54: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:54: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:54: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:68: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:68: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:86: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:86: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:88: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:88: Found 'DU'-anomaly for variable 'serverPlayer' (lines '88'-'125'). +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:89: Found 'DU'-anomaly for variable 'game' (lines '89'-'125'). +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:93: Found 'DU'-anomaly for variable 'unit' (lines '93'-'125'). +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:94: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:95: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:98: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:98: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:99: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:107: Local variable 'role' could be declared final +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:109: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/EquipForRoleMessage.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/FirstContactMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/FirstContactMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/FirstContactMessage.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/FirstContactMessage.java:62: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:62: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:62: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:67: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/FirstContactMessage.java:68: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/FirstContactMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:70: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/FirstContactMessage.java:80: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/FirstContactMessage.java:80: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:80: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:85: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/FirstContactMessage.java:85: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/FirstContactMessage.java:85: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:85: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:87: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/FirstContactMessage.java:87: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/FirstContactMessage.java:87: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:87: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:89: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/FirstContactMessage.java:89: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/FirstContactMessage.java:89: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:89: Useless parentheses. +src/net/sf/freecol/common/networking/FirstContactMessage.java:96: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:96: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/FirstContactMessage.java:100: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/FirstContactMessage.java:104: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:104: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/FirstContactMessage.java:108: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/FirstContactMessage.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/FirstContactMessage.java:111: Avoid empty catch blocks +src/net/sf/freecol/common/networking/FirstContactMessage.java:111: Avoid empty catch blocks +src/net/sf/freecol/common/networking/FirstContactMessage.java:115: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/networking/FirstContactMessage.java:115: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/FirstContactMessage.java:119: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:119: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/FirstContactMessage.java:133: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:133: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/FirstContactMessage.java:137: Local variable 'first' could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:139: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/FirstContactMessage.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/FirstContactMessage.java:141: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/FirstContactMessage.java:141: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/common/networking/FirstContactMessage.java:143: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/FirstContactMessage.java:146: Local variable 'otherPlayer' could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:148: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/FirstContactMessage.java:149: Use equals() to compare object references. +src/net/sf/freecol/common/networking/FirstContactMessage.java:150: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/FirstContactMessage.java:154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:166: Local variable 'element' could be declared final +src/net/sf/freecol/common/networking/FirstContactMessage.java:166: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:166: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/FirstContactMessage.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/FirstContactMessage.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/FirstContactMessage.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:50: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:54: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:63: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:67: Local variable 'nodes' could be declared final +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:68: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:85: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:94: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:94: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:98: Local variable 'player' could be declared final +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:102: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:118: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetNationSummaryMessage.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetTransactionMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/GetTransactionMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/GetTransactionMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/GetTransactionMessage.java:55: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetTransactionMessage.java:55: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetTransactionMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/GetTransactionMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetTransactionMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetTransactionMessage.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/GetTransactionMessage.java:86: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetTransactionMessage.java:86: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetTransactionMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GetTransactionMessage.java:88: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/GetTransactionMessage.java:88: Found 'DU'-anomaly for variable 'serverPlayer' (lines '88'-'106'). +src/net/sf/freecol/common/networking/GetTransactionMessage.java:92: Found 'DU'-anomaly for variable 'unit' (lines '92'-'106'). +src/net/sf/freecol/common/networking/GetTransactionMessage.java:93: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/GetTransactionMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/GetTransactionMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetTransactionMessage.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetTransactionMessage.java:100: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/GetTransactionMessage.java:101: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/GetTransactionMessage.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GetTransactionMessage.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:61: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:61: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:62: Parameter 'sellGoods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:77: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:77: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:83: Local variable 'children' could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:85: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:92: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:97: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:107: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:107: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:108: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:109: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:109: Found 'DU'-anomaly for variable 'serverPlayer' (lines '109'-'128'). +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:113: Found 'DU'-anomaly for variable 'unit' (lines '113'-'128'). +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:114: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:121: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:122: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:136: Found 'UR'-anomaly for variable 'goods' (lines '136'-'142'). +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:137: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:141: Local variable 'goods' could be declared final +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/GoodsForSaleMessage.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/InciteMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/InciteMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/InciteMessage.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/InciteMessage.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/InciteMessage.java:53: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/InciteMessage.java:63: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:63: Parameter 'enemy' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:63: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:64: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:80: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/InciteMessage.java:80: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:80: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:90: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/InciteMessage.java:99: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:99: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:100: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:101: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/InciteMessage.java:101: Found 'DU'-anomaly for variable 'serverPlayer' (lines '101'-'150'). +src/net/sf/freecol/common/networking/InciteMessage.java:102: Found 'DU'-anomaly for variable 'game' (lines '102'-'150'). +src/net/sf/freecol/common/networking/InciteMessage.java:106: Found 'DU'-anomaly for variable 'unit' (lines '106'-'150'). +src/net/sf/freecol/common/networking/InciteMessage.java:107: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/InciteMessage.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:114: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/InciteMessage.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:118: Avoid variables with short names like is +src/net/sf/freecol/common/networking/InciteMessage.java:118: Local variable 'is' could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:126: Local variable 'enemy' could be declared final +src/net/sf/freecol/common/networking/InciteMessage.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:129: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:130: Use equals() to compare object references. +src/net/sf/freecol/common/networking/InciteMessage.java:131: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:132: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/InciteMessage.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:134: Avoid assignments in operands +src/net/sf/freecol/common/networking/InciteMessage.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:136: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/InciteMessage.java:144: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/InciteMessage.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/IndianDemandMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:55: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/IndianDemandMessage.java:64: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:64: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:65: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:65: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:70: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:72: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:82: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:82: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:82: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:87: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:87: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/IndianDemandMessage.java:87: Useless parentheses. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:87: Useless parentheses. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:101: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:110: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:117: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:118: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:127: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/IndianDemandMessage.java:128: Avoid empty catch blocks +src/net/sf/freecol/common/networking/IndianDemandMessage.java:128: Avoid empty catch blocks +src/net/sf/freecol/common/networking/IndianDemandMessage.java:137: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/networking/IndianDemandMessage.java:146: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:151: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/IndianDemandMessage.java:160: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:160: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:161: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:162: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/IndianDemandMessage.java:162: Found 'DU'-anomaly for variable 'serverPlayer' (lines '162'-'203'). +src/net/sf/freecol/common/networking/IndianDemandMessage.java:163: Found 'DU'-anomaly for variable 'game' (lines '163'-'203'). +src/net/sf/freecol/common/networking/IndianDemandMessage.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:170: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/IndianDemandMessage.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:176: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/IndianDemandMessage.java:179: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/IndianDemandMessage.java:180: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/IndianDemandMessage.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:185: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:188: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/IndianDemandMessage.java:191: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/IndianDemandMessage.java:192: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/IndianDemandMessage.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:196: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/IndianDemandMessage.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:212: Local variable 'ret' could be declared final +src/net/sf/freecol/common/networking/IndianDemandMessage.java:216: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/IndianDemandMessage.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/IndianDemandMessage.java:217: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/IndianDemandMessage.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/JoinColonyMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/JoinColonyMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/JoinColonyMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/JoinColonyMessage.java:51: Parameter 'builder' is not assigned and could be declared final +src/net/sf/freecol/common/networking/JoinColonyMessage.java:51: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/JoinColonyMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/JoinColonyMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/JoinColonyMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/JoinColonyMessage.java:72: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/JoinColonyMessage.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/JoinColonyMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/JoinColonyMessage.java:83: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/JoinColonyMessage.java:84: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/JoinColonyMessage.java:84: Found 'DU'-anomaly for variable 'serverPlayer' (lines '84'-'103'). +src/net/sf/freecol/common/networking/JoinColonyMessage.java:88: Found 'DU'-anomaly for variable 'unit' (lines '88'-'103'). +src/net/sf/freecol/common/networking/JoinColonyMessage.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/JoinColonyMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/JoinColonyMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/JoinColonyMessage.java:96: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/JoinColonyMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/JoinColonyMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/JoinColonyMessage.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LearnSkillMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LearnSkillMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LearnSkillMessage.java:54: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:54: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:68: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/LearnSkillMessage.java:68: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:76: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LearnSkillMessage.java:85: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:85: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:86: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:87: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/LearnSkillMessage.java:87: Found 'DU'-anomaly for variable 'serverPlayer' (lines '87'-'122'). +src/net/sf/freecol/common/networking/LearnSkillMessage.java:91: Found 'DU'-anomaly for variable 'unit' (lines '91'-'122'). +src/net/sf/freecol/common/networking/LearnSkillMessage.java:92: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/LearnSkillMessage.java:93: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LearnSkillMessage.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:99: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/LearnSkillMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LearnSkillMessage.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:103: Avoid variables with short names like is +src/net/sf/freecol/common/networking/LearnSkillMessage.java:103: Local variable 'is' could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:105: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LearnSkillMessage.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:113: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/LearnSkillMessage.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LearnSkillMessage.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LearnSkillMessage.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:60: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:60: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:60: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:61: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:77: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:77: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:77: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:87: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:96: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:96: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:97: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:98: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:98: Found 'DU'-anomaly for variable 'serverPlayer' (lines '98'-'137'). +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:100: Local variable 'fcgo' could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:102: No need to check for null before an instanceof +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:108: Found 'DU'-anomaly for variable 'carrier' (lines '108'-'137'). +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:109: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:112: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:113: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:118: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:120: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:127: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:130: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LoadGoodsMessage.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/LoginMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LoginMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LoginMessage.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LoginMessage.java:64: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LoginMessage.java:77: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:77: Parameter 'userName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:77: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:78: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:78: Parameter 'startGame' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:79: Parameter 'activeUnit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:79: Parameter 'currentPlayer' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:80: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:90: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/LoginMessage.java:100: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/LoginMessage.java:100: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:100: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:104: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/LoginMessage.java:116: Local variable 'children' could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:117: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/LoginMessage.java:117: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/LoginMessage.java:124: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:128: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:132: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:136: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/networking/LoginMessage.java:136: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:140: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:144: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:148: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:149: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/LoginMessage.java:153: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/LoginMessage.java:158: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LoginMessage.java:168: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:168: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:169: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:180: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/LoginMessage.java:188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LoginMessage.java:188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LootCargoMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/LootCargoMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LootCargoMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/LootCargoMessage.java:58: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:58: Parameter 'loserId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:58: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:63: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/LootCargoMessage.java:73: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:73: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:78: Local variable 'children' could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:80: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/LootCargoMessage.java:84: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/networking/LootCargoMessage.java:97: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:128: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:128: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:129: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:130: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/LootCargoMessage.java:130: Found 'DU'-anomaly for variable 'serverPlayer' (lines '130'-'146'). +src/net/sf/freecol/common/networking/LootCargoMessage.java:135: Found 'DU'-anomaly for variable 'winner' (lines '135'-'146'). +src/net/sf/freecol/common/networking/LootCargoMessage.java:136: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/LootCargoMessage.java:137: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/LootCargoMessage.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LootCargoMessage.java:144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/LootCargoMessage.java:154: Found 'UR'-anomaly for variable 'g' (lines '154'-'160'). +src/net/sf/freecol/common/networking/LootCargoMessage.java:155: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:159: Local variable 'g' could be declared final +src/net/sf/freecol/common/networking/LootCargoMessage.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/LootCargoMessage.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/Message.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Message.java:48: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/networking/Message.java:48: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Message.java:50: Avoid excessively long variable names like FREECOL_PROTOCOL_VERSION +src/net/sf/freecol/common/networking/Message.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Message.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/Message.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/Message.java:58: protectedMethodCommentRequirement Required +src/net/sf/freecol/common/networking/Message.java:70: Parameter 'msg' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:74: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Message.java:83: Parameter 'inputStream' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:87: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/Message.java:96: Parameter 'inputSource' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:97: Local variable 'factory' could be declared final +src/net/sf/freecol/common/networking/Message.java:99: Local variable 'dumpMsgOnError' could be declared final +src/net/sf/freecol/common/networking/Message.java:108: Local variable 'builder' could be declared final +src/net/sf/freecol/common/networking/Message.java:113: A catch statement that catches an exception only to rethrow it should be avoided. +src/net/sf/freecol/common/networking/Message.java:120: Local variable 'baos' could be declared final +src/net/sf/freecol/common/networking/Message.java:123: Avoid variables with short names like i +src/net/sf/freecol/common/networking/Message.java:123: Local variable 'i' could be declared final +src/net/sf/freecol/common/networking/Message.java:141: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:161: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/Message.java:161: Useless parentheses. +src/net/sf/freecol/common/networking/Message.java:161: Useless parentheses. +src/net/sf/freecol/common/networking/Message.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Message.java:172: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Message.java:182: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Message.java:192: Parameter 'attribute' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:193: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Message.java:202: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:202: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:203: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/Message.java:212: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:212: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/networking/Message.java:231: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MessageHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MessageHandler.java:41: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/networking/MissionaryMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MissionaryMessage.java:39: The class 'MissionaryMessage' has a Cyclomatic Complexity of 3 (Highest = 12). +src/net/sf/freecol/common/networking/MissionaryMessage.java:39: The class 'MissionaryMessage' has a Modified Cyclomatic Complexity of 3 (Highest = 12). +src/net/sf/freecol/common/networking/MissionaryMessage.java:39: The class 'MissionaryMessage' has a Standard Cyclomatic Complexity of 3 (Highest = 12). +src/net/sf/freecol/common/networking/MissionaryMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MissionaryMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MissionaryMessage.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MissionaryMessage.java:59: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:59: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:60: Parameter 'denounce' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:75: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/MissionaryMessage.java:75: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:75: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:84: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MissionaryMessage.java:93: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:93: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:93: The method 'handle' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/networking/MissionaryMessage.java:93: The method 'handle' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/networking/MissionaryMessage.java:93: The method 'handle' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/networking/MissionaryMessage.java:93: The method handle() has an NPath complexity of 560 +src/net/sf/freecol/common/networking/MissionaryMessage.java:94: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:95: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/MissionaryMessage.java:95: Found 'DU'-anomaly for variable 'serverPlayer' (lines '95'-'152'). +src/net/sf/freecol/common/networking/MissionaryMessage.java:99: Found 'DU'-anomaly for variable 'unit' (lines '99'-'152'). +src/net/sf/freecol/common/networking/MissionaryMessage.java:100: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/MissionaryMessage.java:101: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:107: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/MissionaryMessage.java:108: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:111: Avoid variables with short names like is +src/net/sf/freecol/common/networking/MissionaryMessage.java:111: Local variable 'is' could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:114: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:118: Local variable 'missionary' could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:127: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:131: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/MissionaryMessage.java:132: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:135: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:140: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/MissionaryMessage.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:142: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MissionaryMessage.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MissionaryMessage.java:147: Useless parentheses. +src/net/sf/freecol/common/networking/MissionaryMessage.java:147: Useless parentheses. +src/net/sf/freecol/common/networking/MissionaryMessage.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MissionaryMessage.java:150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MonarchActionMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MonarchActionMessage.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MonarchActionMessage.java:61: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:62: Parameter 'monarchKey' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:62: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:68: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/MonarchActionMessage.java:69: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/MonarchActionMessage.java:79: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/MonarchActionMessage.java:79: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:79: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:87: Local variable 'children' could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:88: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/networking/MonarchActionMessage.java:92: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/MonarchActionMessage.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MonarchActionMessage.java:134: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/MonarchActionMessage.java:145: Parameter 'tax' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:155: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/networking/MonarchActionMessage.java:165: Parameter 'accept' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:171: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MonarchActionMessage.java:180: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:180: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:181: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:185: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MonarchActionMessage.java:196: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/MonarchActionMessage.java:199: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/MonarchActionMessage.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MonarchActionMessage.java:200: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/MonarchActionMessage.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MonarchActionMessage.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MonarchActionMessage.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MoveMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MoveMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MoveMessage.java:54: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:54: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:68: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/MoveMessage.java:68: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:76: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MoveMessage.java:85: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:85: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:86: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:87: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/MoveMessage.java:87: Found 'DU'-anomaly for variable 'serverPlayer' (lines '87'-'114'). +src/net/sf/freecol/common/networking/MoveMessage.java:91: Found 'DU'-anomaly for variable 'unit' (lines '91'-'114'). +src/net/sf/freecol/common/networking/MoveMessage.java:92: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/MoveMessage.java:93: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MoveMessage.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:99: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/MoveMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MoveMessage.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:103: Local variable 'moveType' could be declared final +src/net/sf/freecol/common/networking/MoveMessage.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:105: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MoveMessage.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MoveMessage.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MoveMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveMessage.java:112: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MoveMessage.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MoveMessage.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/MoveToMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MoveToMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MoveToMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/MoveToMessage.java:51: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:51: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:65: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/MoveToMessage.java:65: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:73: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/MoveToMessage.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:83: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:84: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/MoveToMessage.java:84: Found 'DU'-anomaly for variable 'serverPlayer' (lines '84'-'102'). +src/net/sf/freecol/common/networking/MoveToMessage.java:85: Found 'DU'-anomaly for variable 'game' (lines '85'-'102'). +src/net/sf/freecol/common/networking/MoveToMessage.java:89: Found 'DU'-anomaly for variable 'unit' (lines '89'-'102'). +src/net/sf/freecol/common/networking/MoveToMessage.java:90: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/MoveToMessage.java:91: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MoveToMessage.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveToMessage.java:94: Local variable 'destination' could be declared final +src/net/sf/freecol/common/networking/MoveToMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/MoveToMessage.java:96: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/MoveToMessage.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/NetworkConstants.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NetworkConstants.java:28: An Interface should be used only to model a behaviour; consider converting this to a class. +src/net/sf/freecol/common/networking/NetworkConstants.java:31: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/networking/NetworkConstants.java:34: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/networking/NetworkReplyObject.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NetworkReplyObject.java:30: Avoid using redundant field initializer for 'response' +src/net/sf/freecol/common/networking/NetworkReplyObject.java:30: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/NetworkReplyObject.java:31: Avoid using redundant field initializer for 'responseGiven' +src/net/sf/freecol/common/networking/NetworkReplyObject.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/NetworkReplyObject.java:31: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/NetworkReplyObject.java:32: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/NetworkReplyObject.java:41: Parameter 'networkReplyId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NetworkReplyObject.java:51: Parameter 'response' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NetworkReplyObject.java:51: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/NetworkReplyObject.java:53: Avoid throwing null pointer exceptions. +src/net/sf/freecol/common/networking/NetworkReplyObject.java:57: Call Thread.notifyAll() rather than Thread.notify() +src/net/sf/freecol/common/networking/NetworkReplyObject.java:66: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/NetworkReplyObject.java:91: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/NetworkReplyObject.java:93: Call Thread.notifyAll() rather than Thread.notify() +src/net/sf/freecol/common/networking/NetworkRequestHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NewLandNameMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NewLandNameMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/NewLandNameMessage.java:51: Parameter 'newLandName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:51: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:65: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/NewLandNameMessage.java:65: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:81: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:95: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NewLandNameMessage.java:104: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:104: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:105: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:106: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/NewLandNameMessage.java:106: Found 'DU'-anomaly for variable 'serverPlayer' (lines '106'-'130'). +src/net/sf/freecol/common/networking/NewLandNameMessage.java:110: Found 'DU'-anomaly for variable 'unit' (lines '110'-'130'). +src/net/sf/freecol/common/networking/NewLandNameMessage.java:111: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/NewLandNameMessage.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewLandNameMessage.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewLandNameMessage.java:115: Local variable 'tile' could be declared final +src/net/sf/freecol/common/networking/NewLandNameMessage.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewLandNameMessage.java:117: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewLandNameMessage.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewLandNameMessage.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewLandNameMessage.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewLandNameMessage.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:51: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:60: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:60: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:60: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:61: Parameter 'newRegionName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:77: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:77: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:77: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:95: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:105: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:115: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:128: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:137: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:137: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:138: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:142: Local variable 'tile' could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:144: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:149: Found 'DU'-anomaly for variable 'unit' (lines '149'-'167'). +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:150: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:151: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:154: Local variable 'region' could be declared final +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:156: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:160: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/NewRegionNameMessage.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/PayArrearsMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/PayArrearsMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/PayArrearsMessage.java:46: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayArrearsMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/PayArrearsMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayArrearsMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayArrearsMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/PayArrearsMessage.java:76: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayArrearsMessage.java:76: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayArrearsMessage.java:77: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayArrearsMessage.java:79: Local variable 'goodsType' could be declared final +src/net/sf/freecol/common/networking/PayArrearsMessage.java:79: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/PayArrearsMessage.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:46: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:76: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:76: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:77: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:78: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:78: Found 'DU'-anomaly for variable 'serverPlayer' (lines '78'-'90'). +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:82: Found 'DU'-anomaly for variable 'colony' (lines '82'-'90'). +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:83: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:84: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/PayForBuildingMessage.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:46: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:75: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:75: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:76: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:77: Found 'DU'-anomaly for variable 'serverPlayer' (lines '77'-'95'). +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:81: Found 'DU'-anomaly for variable 'unit' (lines '81'-'95'). +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:82: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:83: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:85: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:86: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:88: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/PutOutsideColonyMessage.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:43: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:48: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:51: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:54: Document empty constructor +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:54: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:56: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:56: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:56: Parameter 'work' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:56: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:57: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:57: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:65: Parameter 'unitId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:65: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:66: Parameter 'locId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:66: Parameter 'workId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:67: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:67: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:71: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:71: Parameter 'unitId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:71: Rather than using a lot of String arguments, consider using a container object for those values. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:71: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:72: Parameter 'locId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:72: Parameter 'workId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:73: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:73: Parameter 'roleId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:76: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:76: Useless parentheses. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:76: Useless parentheses. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:77: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:78: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:86: Avoid variables with short names like e +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:86: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:86: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:86: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:86: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:88: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:90: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:90: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:92: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:92: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:96: Avoid variables with short names like e +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:96: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:96: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:96: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:96: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:96: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:106: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:106: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:106: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:110: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:110: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:110: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:114: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:114: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:114: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:118: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:118: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:118: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:122: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:122: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:122: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:127: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:135: Variables that are final and static should be all capitals, 'roleComparator' is not all capitals. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:138: Parameter 'uc1' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:138: Parameter 'uc2' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:138: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:139: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:140: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:146: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:146: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:149: Avoid using redundant field initializer for 'unitChanges' +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:149: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:149: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:149: Private field 'unitChanges' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:158: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:172: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:172: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:176: Avoid variables with short names like n +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:184: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:200: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:209: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:209: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:209: Parameter 'work' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:210: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:210: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:214: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:223: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:223: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:224: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:225: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:225: Found 'DU'-anomaly for variable 'serverPlayer' (lines '225'-'256'). +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:229: Found 'DU'-anomaly for variable 'colony' (lines '229'-'256'). +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:230: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:231: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:235: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:237: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:237: Local variable 'i' could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:238: Local variable 'uc' could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:240: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:246: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:249: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:264: Found 'UR'-anomaly for variable 'uc' (lines '264'-'270'). +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:265: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:268: Avoid variables with short names like i +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:268: Found 'DU'-anomaly for variable 'i' (lines '268'-'274'). +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:269: Local variable 'uc' could be declared final +src/net/sf/freecol/common/networking/RearrangeColonyMessage.java:271: Found 'DU'-anomaly for variable 'i' (lines '271'-'274'). +src/net/sf/freecol/common/networking/ReceivingThread.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ReceivingThread.java:20: Possible God class (WMC=48, ATFD=11, TCC=0.022222222222222223) +src/net/sf/freecol/common/networking/ReceivingThread.java:42: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/common/networking/ReceivingThread.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/networking/ReceivingThread.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:46: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ReceivingThread.java:57: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:61: Avoid variables with short names like in +src/net/sf/freecol/common/networking/ReceivingThread.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:65: Avoid using redundant field initializer for 'bStart' +src/net/sf/freecol/common/networking/ReceivingThread.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:67: Avoid using redundant field initializer for 'bEnd' +src/net/sf/freecol/common/networking/ReceivingThread.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:69: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:71: Avoid using redundant field initializer for 'wait' +src/net/sf/freecol/common/networking/ReceivingThread.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:71: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ReceivingThread.java:80: Avoid variables with short names like in +src/net/sf/freecol/common/networking/ReceivingThread.java:80: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/networking/ReceivingThread.java:80: Parameter 'in' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:101: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:103: Avoid variables with short names like r +src/net/sf/freecol/common/networking/ReceivingThread.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ReceivingThread.java:112: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:116: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:129: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ReceivingThread.java:129: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ReceivingThread.java:138: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:139: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:148: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ReceivingThread.java:158: Avoid variables with short names like b +src/net/sf/freecol/common/networking/ReceivingThread.java:158: Parameter 'len' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:158: Parameter 'off' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:158: The method read() has an NPath complexity of 300 +src/net/sf/freecol/common/networking/ReceivingThread.java:159: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ReceivingThread.java:159: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:161: Avoid variables with short names like n +src/net/sf/freecol/common/networking/ReceivingThread.java:168: Local variable 'value' could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:170: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:171: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:180: Useless parentheses. +src/net/sf/freecol/common/networking/ReceivingThread.java:180: Useless parentheses. +src/net/sf/freecol/common/networking/ReceivingThread.java:185: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/ReceivingThread.java:188: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/ReceivingThread.java:188: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:188: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/networking/ReceivingThread.java:192: Avoid variables with short names like in +src/net/sf/freecol/common/networking/ReceivingThread.java:192: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/ReceivingThread.java:192: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:195: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/ReceivingThread.java:195: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:198: Field shouldRun has the same name as a method +src/net/sf/freecol/common/networking/ReceivingThread.java:198: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/ReceivingThread.java:198: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:201: Avoid excessively long variable names like nextNetworkReplyId +src/net/sf/freecol/common/networking/ReceivingThread.java:201: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/networking/ReceivingThread.java:201: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ReceivingThread.java:211: Avoid variables with short names like in +src/net/sf/freecol/common/networking/ReceivingThread.java:211: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:211: Parameter 'in' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:211: Parameter 'threadName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:226: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/ReceivingThread.java:230: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ReceivingThread.java:239: Parameter 'networkReplyId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:240: Local variable 'nro' could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:248: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/ReceivingThread.java:255: Found 'UR'-anomaly for variable 'o' (lines '255'-'259'). +src/net/sf/freecol/common/networking/ReceivingThread.java:255: Use block level rather than method level synchronization +src/net/sf/freecol/common/networking/ReceivingThread.java:258: Local variable 'o' could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:267: Parameter 'reason' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ReceivingThread.java:291: Avoid using final local variables, turn them into fields +src/net/sf/freecol/common/networking/ReceivingThread.java:292: Local variable 'bis' could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ReceivingThread.java:295: Avoid variables with short names like xr +src/net/sf/freecol/common/networking/ReceivingThread.java:295: Local variable 'xr' could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ReceivingThread.java:299: Found 'DD'-anomaly for variable 'tag' (lines '299'-'302'). +src/net/sf/freecol/common/networking/ReceivingThread.java:299: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ReceivingThread.java:305: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/networking/ReceivingThread.java:308: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/networking/ReceivingThread.java:309: Avoid variables with short names like id +src/net/sf/freecol/common/networking/ReceivingThread.java:309: Local variable 'id' could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ReceivingThread.java:310: Local variable 'nro' could be declared final +src/net/sf/freecol/common/networking/ReceivingThread.java:312: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ReceivingThread.java:314: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ReceivingThread.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ReceivingThread.java:323: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ReceivingThread.java:327: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:327: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ReceivingThread.java:337: Found 'DD'-anomaly for variable 'timesFailed' (lines '337'-'343'). +src/net/sf/freecol/common/networking/ReceivingThread.java:337: Found 'DU'-anomaly for variable 'timesFailed' (lines '337'-'364'). +src/net/sf/freecol/common/networking/ReceivingThread.java:343: Found 'DU'-anomaly for variable 'timesFailed' (lines '343'-'364'). +src/net/sf/freecol/common/networking/ReceivingThread.java:345: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:347: Avoid assignments in operands +src/net/sf/freecol/common/networking/ReceivingThread.java:351: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ReceivingThread.java:356: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ReceivingThread.java:363: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ReceivingThread.java:363: There is log block not surrounded by if +src/net/sf/freecol/common/networking/RenameMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/RenameMessage.java:38: Avoid variables with short names like id +src/net/sf/freecol/common/networking/RenameMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RenameMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/RenameMessage.java:51: Parameter 'newName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RenameMessage.java:51: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RenameMessage.java:65: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/RenameMessage.java:65: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RenameMessage.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RenameMessage.java:73: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/RenameMessage.java:83: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RenameMessage.java:83: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RenameMessage.java:84: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/RenameMessage.java:85: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/RenameMessage.java:85: Found 'DU'-anomaly for variable 'serverPlayer' (lines '85'-'100'). +src/net/sf/freecol/common/networking/RenameMessage.java:89: Found 'DU'-anomaly for variable 'fcgo' (lines '89'-'100'). +src/net/sf/freecol/common/networking/RenameMessage.java:90: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/RenameMessage.java:91: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RenameMessage.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/RenameMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/RenameMessage.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:55: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:55: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:86: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:86: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:88: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:88: Found 'DU'-anomaly for variable 'serverPlayer' (lines '88'-'123'). +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:92: Found 'DU'-anomaly for variable 'unit' (lines '92'-'123'). +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:93: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:104: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:105: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:108: Avoid variables with short names like is +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:108: Local variable 'is' could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:114: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutIndianSettlementMessage.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:55: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:55: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:77: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:86: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:86: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:88: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:88: Found 'DU'-anomaly for variable 'serverPlayer' (lines '88'-'123'). +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:92: Found 'DU'-anomaly for variable 'unit' (lines '92'-'123'). +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:93: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:104: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:105: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:108: Avoid variables with short names like is +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:108: Local variable 'is' could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:114: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ScoutSpeakToChiefMessage.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SellMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SellMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellMessage.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellMessage.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellMessage.java:60: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:60: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:60: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:61: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:77: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:77: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellMessage.java:104: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SellMessage.java:113: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:113: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:114: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:115: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/SellMessage.java:115: Found 'DU'-anomaly for variable 'serverPlayer' (lines '115'-'143'). +src/net/sf/freecol/common/networking/SellMessage.java:119: Found 'DU'-anomaly for variable 'unit' (lines '119'-'143'). +src/net/sf/freecol/common/networking/SellMessage.java:120: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SellMessage.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellMessage.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellMessage.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellMessage.java:127: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SellMessage.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellMessage.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellMessage.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellMessage.java:137: Local variable 'gold' could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:138: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellMessage.java:138: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/SellMessage.java:141: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SellMessage.java:152: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/SellMessage.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellMessage.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellPropositionMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SellPropositionMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellPropositionMessage.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellPropositionMessage.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellPropositionMessage.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SellPropositionMessage.java:59: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:59: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:60: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:60: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:76: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:76: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:96: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellPropositionMessage.java:103: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SellPropositionMessage.java:112: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:112: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:113: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:114: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/SellPropositionMessage.java:114: Found 'DU'-anomaly for variable 'serverPlayer' (lines '114'-'139'). +src/net/sf/freecol/common/networking/SellPropositionMessage.java:118: Found 'DU'-anomaly for variable 'unit' (lines '118'-'139'). +src/net/sf/freecol/common/networking/SellPropositionMessage.java:119: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SellPropositionMessage.java:120: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellPropositionMessage.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellPropositionMessage.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellPropositionMessage.java:126: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SellPropositionMessage.java:127: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellPropositionMessage.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellPropositionMessage.java:132: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SellPropositionMessage.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SellPropositionMessage.java:148: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/SellPropositionMessage.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SellPropositionMessage.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:21: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/common/networking/ServerAPI.java:21: Possible God class (WMC=157, ATFD=60, TCC=0.0047032474804031355) +src/net/sf/freecol/common/networking/ServerAPI.java:21: This class has a bunch of public methods and attributes +src/net/sf/freecol/common/networking/ServerAPI.java:73: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/networking/ServerAPI.java:73: Avoid really long classes. +src/net/sf/freecol/common/networking/ServerAPI.java:73: The class 'ServerAPI' has a Cyclomatic Complexity of 2 (Highest = 19). +src/net/sf/freecol/common/networking/ServerAPI.java:73: The class 'ServerAPI' has a Modified Cyclomatic Complexity of 2 (Highest = 15). +src/net/sf/freecol/common/networking/ServerAPI.java:73: The class 'ServerAPI' has a Standard Cyclomatic Complexity of 2 (Highest = 15). +src/net/sf/freecol/common/networking/ServerAPI.java:73: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/networking/ServerAPI.java:75: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/networking/ServerAPI.java:75: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/ServerAPI.java:78: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/ServerAPI.java:84: Avoid unnecessary constructors - the compiler will generate these for you +src/net/sf/freecol/common/networking/ServerAPI.java:84: Document empty constructor +src/net/sf/freecol/common/networking/ServerAPI.java:112: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:116: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ServerAPI.java:127: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:130: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:132: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ServerAPI.java:144: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:147: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:149: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ServerAPI.java:161: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:162: Found 'DD'-anomaly for variable 'reply' (lines '162'-'164'). +src/net/sf/freecol/common/networking/ServerAPI.java:166: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ServerAPI.java:178: Avoid reassigning parameters such as 'request' +src/net/sf/freecol/common/networking/ServerAPI.java:183: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ServerAPI.java:189: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:209: Found 'UR'-anomaly for variable 'k' (lines '209'-'246'). +src/net/sf/freecol/common/networking/ServerAPI.java:209: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:209: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:209: The method 'askExpecting' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/common/networking/ServerAPI.java:209: The method 'askExpecting' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/common/networking/ServerAPI.java:209: The method 'askExpecting' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/common/networking/ServerAPI.java:209: The method askExpecting() has an NPath complexity of 880 +src/net/sf/freecol/common/networking/ServerAPI.java:210: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/networking/ServerAPI.java:210: Parameter 'results' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:211: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:212: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:212: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:215: Local variable 'messageId' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:216: Local variable 'messageText' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:224: There is log block not surrounded by if +src/net/sf/freecol/common/networking/ServerAPI.java:228: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:239: Local variable 'len' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:239: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:241: Avoid variables with short names like n +src/net/sf/freecol/common/networking/ServerAPI.java:241: Local variable 'n' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:245: Local variable 'k' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:246: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/networking/ServerAPI.java:246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:252: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:257: Local variable 'replies' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:258: Local variable 'nodes' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:258: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:259: Found 'DD'-anomaly for variable 'result' (lines '259'-'264'). +src/net/sf/freecol/common/networking/ServerAPI.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:263: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:263: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:263: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:263: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:264: Found 'DD'-anomaly for variable 'result' (lines '264'-'264'). +src/net/sf/freecol/common/networking/ServerAPI.java:264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:266: Avoid variables with short names like e +src/net/sf/freecol/common/networking/ServerAPI.java:266: Local variable 'e' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:267: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:271: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:271: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:275: Local variable 'complaint' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:283: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:292: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:292: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:293: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/networking/ServerAPI.java:293: Parameter 'results' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:294: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:295: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:295: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:306: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/networking/ServerAPI.java:306: Found 'UR'-anomaly for variable 'q' (lines '306'-'308'). +src/net/sf/freecol/common/networking/ServerAPI.java:306: Parameter 'queries' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:307: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:308: Avoid using for statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:308: Local variable 'q' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:321: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ServerAPI.java:341: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ServerAPI.java:350: Parameter 'messageHandler' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:371: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ServerAPI.java:374: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:384: Avoid reassigning parameters such as 'port' +src/net/sf/freecol/common/networking/ServerAPI.java:384: Parameter 'host' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:384: Parameter 'threadName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:385: Parameter 'messageHandler' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:396: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/networking/ServerAPI.java:397: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:399: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/networking/ServerAPI.java:399: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:414: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:426: Parameter 'accept' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:426: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:439: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:439: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:451: Parameter 'student' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:451: Parameter 'teacher' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:463: Parameter 'tradeRoute' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:463: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:475: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:475: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:487: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:487: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:492: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:501: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:501: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:502: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:502: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:507: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:516: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:516: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:517: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:517: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:518: Local variable 'results' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:518: The String literal "gold" appears 6 times in this file; the first occurrence is on line 518 +src/net/sf/freecol/common/networking/ServerAPI.java:522: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:522: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:523: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ServerAPI.java:523: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ServerAPI.java:534: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:546: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:546: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:558: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:559: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:571: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:571: Parameter 'workType' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:582: Parameter 'chat' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:582: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:593: Parameter 'ffs' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:594: Avoid variables with short names like ff +src/net/sf/freecol/common/networking/ServerAPI.java:594: Parameter 'ff' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:598: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:607: Parameter 'claimant' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:607: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:607: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:618: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:630: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:630: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:651: Parameter 'country' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:651: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:656: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:665: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:665: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:678: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:678: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:679: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:692: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:692: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:705: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:705: Parameter 'ourUnit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:706: Parameter 'otherColony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:707: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:708: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:714: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:715: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:716: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:731: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:731: Parameter 'ourUnit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:732: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:733: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:734: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:738: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:739: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:740: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:755: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:755: Parameter 'ourColony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:756: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:757: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:758: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:762: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:763: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:764: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:777: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:788: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:793: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:802: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:802: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:802: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:814: Parameter 'slot' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:847: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:847: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:847: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:852: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:862: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:862: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:862: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:863: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:877: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:877: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:878: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:879: Local variable 'message' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:881: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:883: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:893: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:895: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:895: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:895: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:897: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:898: Local variable 'childElements' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:899: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:900: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/networking/ServerAPI.java:900: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:911: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:912: Local variable 'message' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:913: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:915: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:915: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:925: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/common/networking/ServerAPI.java:936: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:938: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:938: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:938: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/ServerAPI.java:940: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:941: Local variable 'childElements' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:942: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:943: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/networking/ServerAPI.java:943: Local variable 'unit' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:944: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:956: Local variable 'results' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:958: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ServerAPI.java:962: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:973: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:973: Parameter 'enemy' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:973: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:973: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:974: Local variable 'results' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:975: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:976: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:978: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:978: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:979: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ServerAPI.java:979: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ServerAPI.java:990: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:990: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1002: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1002: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1007: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:1016: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1016: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1016: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1017: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1029: Parameter 'userName' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1029: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1030: Local variable 'reply' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1034: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ServerAPI.java:1047: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:1058: Parameter 'defenderId' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1058: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1058: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1071: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1071: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1072: Parameter 'denounce' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1084: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1084: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1096: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1096: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1108: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1108: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1113: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:1122: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1122: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1122: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1123: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1136: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1136: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1137: Local variable 'results' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1139: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/ServerAPI.java:1141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1143: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:1143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1157: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1168: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1179: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1191: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1191: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1214: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:1224: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1224: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1225: Local variable 'results' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1226: Useless parentheses. +src/net/sf/freecol/common/networking/ServerAPI.java:1226: Useless parentheses. +src/net/sf/freecol/common/networking/ServerAPI.java:1227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1228: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ServerAPI.java:1239: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1239: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1240: Local variable 'results' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1241: Useless parentheses. +src/net/sf/freecol/common/networking/ServerAPI.java:1241: Useless parentheses. +src/net/sf/freecol/common/networking/ServerAPI.java:1242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1243: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/ServerAPI.java:1246: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:1255: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1255: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1256: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1256: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1257: Local variable 'results' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1261: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/ServerAPI.java:1261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1262: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ServerAPI.java:1262: Avoid empty catch blocks +src/net/sf/freecol/common/networking/ServerAPI.java:1267: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/ServerAPI.java:1276: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1276: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1277: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1277: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1289: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1289: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1303: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1304: Parameter 'buildQueue' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1317: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1317: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1331: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1331: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1344: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1344: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1356: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1356: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1368: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1381: Parameter 'nationType' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1394: Parameter 'ready' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1405: Parameter 'routes' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1417: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1417: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1437: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1450: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1450: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1450: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1463: Parameter 'gameOptions' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1464: Avoid variables with short names like up +src/net/sf/freecol/common/networking/ServerAPI.java:1464: Local variable 'up' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1465: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1465: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1477: Parameter 'mapOptions' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1478: Avoid variables with short names like up +src/net/sf/freecol/common/networking/ServerAPI.java:1478: Local variable 'up' could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/ServerAPI.java:1489: Parameter 'route' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1501: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/ServerAPI.java:1501: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:55: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:55: Parameter 'queue' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:72: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:72: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:72: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:88: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:93: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:103: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:103: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:104: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:105: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:105: Found 'DU'-anomaly for variable 'serverPlayer' (lines '105'-'132'). +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:107: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:107: Found 'DU'-anomaly for variable 'spec' (lines '107'-'132'). +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:111: Found 'DU'-anomaly for variable 'colony' (lines '111'-'132'). +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:112: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:113: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:117: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:119: Local variable 'buildQueue' could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:123: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:141: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetBuildQueueMessage.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:50: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:50: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:80: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:80: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:85: Found 'DU'-anomaly for variable 'serverUnit' (lines '85'-'110'). +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:87: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:88: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:90: Avoid variables with short names like tr +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:90: Local variable 'tr' could be declared final +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:92: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:104: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetCurrentStopMessage.java:108: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetDestinationMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetDestinationMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:50: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:50: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:54: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:68: Useless parentheses. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:70: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:82: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:84: Found 'DU'-anomaly for variable 'game' (lines '84'-'100'). +src/net/sf/freecol/common/networking/SetDestinationMessage.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetDestinationMessage.java:88: Found 'DU'-anomaly for variable 'unit' (lines '88'-'100'). +src/net/sf/freecol/common/networking/SetDestinationMessage.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetDestinationMessage.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SetDestinationMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetDestinationMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetDestinationMessage.java:94: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/SetDestinationMessage.java:94: Local variable 'destination' could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetDestinationMessage.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetDestinationMessage.java:109: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/SetDestinationMessage.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:51: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:51: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:65: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:65: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:65: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:73: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:82: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:82: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:83: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:84: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:84: Found 'DU'-anomaly for variable 'serverPlayer' (lines '84'-'96'). +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:88: Found 'DU'-anomaly for variable 'colony' (lines '88'-'96'). +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:105: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetGoodsLevelsMessage.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:41: Variables that are final and static should be all capitals, 'idPrefix' is not all capitals. +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:53: Parameter 'tradeRoutes' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:66: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:66: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:69: Local variable 'newRoutes' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:70: Local variable 'nodes' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:72: Local variable 'route' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:74: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:82: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:94: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:94: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:95: Avoid variables with short names like id +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:95: Local variable 'id' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:98: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:99: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:100: There is log block not surrounded by if +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:105: Parameter 'route' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:105: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:109: Parameter 'route' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:109: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:113: Parameter 'route' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:113: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:125: Found 'UR'-anomaly for variable 'tradeRoute' (lines '125'-'131'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:125: Found 'UR'-anomaly for variable 'tradeRoute' (lines '125'-'149'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:125: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:125: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:126: Found 'DU'-anomaly for variable 'serverPlayer' (lines '126'-'160'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:127: Found 'DU'-anomaly for variable 'game' (lines '127'-'160'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:130: Local variable 'tradeRoute' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:132: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:135: Avoid variables with short names like id +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:135: Local variable 'id' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:136: Avoid unused local variables such as 'realRoute'. +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:138: Found 'DD'-anomaly for variable 'realRoute' (lines '138'-'138'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:138: Found 'DD'-anomaly for variable 'realRoute' (lines '138'-'149'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:138: Found 'DU'-anomaly for variable 'realRoute' (lines '138'-'160'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:140: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:141: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:145: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:145: Avoid using if statements without curly braces +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:147: Local variable 'newRoutes' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:148: Local variable 'tradeRoute' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:149: Local variable 'realRoute' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:168: Found 'UR'-anomaly for variable 'tradeRoute' (lines '168'-'171'). +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:169: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:170: Local variable 'tradeRoute' could be declared final +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SetTradeRoutesMessage.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SpySettlementMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SpySettlementMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/SpySettlementMessage.java:54: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:54: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:68: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/SpySettlementMessage.java:68: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:68: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:76: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/SpySettlementMessage.java:87: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:87: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:92: Found 'DU'-anomaly for variable 'unit' (lines '92'-'123'). +src/net/sf/freecol/common/networking/SpySettlementMessage.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:93: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SpySettlementMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SpySettlementMessage.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:97: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SpySettlementMessage.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:104: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/SpySettlementMessage.java:105: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SpySettlementMessage.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:108: Local variable 'settlement' could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SpySettlementMessage.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:114: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/SpySettlementMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:116: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/SpySettlementMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/SpySettlementMessage.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:46: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:59: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:59: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:59: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:66: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:76: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:76: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:77: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:78: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:78: Found 'DU'-anomaly for variable 'serverPlayer' (lines '78'-'88'). +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:80: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:82: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/TrainUnitInEuropeMessage.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/TrivialMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/TrivialMessage.java:33: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/TrivialMessage.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/TrivialMessage.java:39: Parameter 'attributes' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrivialMessage.java:39: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/networking/TrivialMessage.java:39: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/TrivialMessage.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:54: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:54: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:54: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:69: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:69: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:78: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:87: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:87: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:88: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:89: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:89: Found 'DU'-anomaly for variable 'serverPlayer' (lines '89'-'126'). +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:93: Found 'DU'-anomaly for variable 'carrier' (lines '93'-'126'). +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:94: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:95: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:98: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:102: Local variable 'type' could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:104: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:111: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:114: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:117: Local variable 'present' could be declared final +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:119: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UnloadGoodsMessage.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:45: Parameter 'tradeRoute' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:58: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:58: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:61: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:61: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:67: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:76: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:76: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:77: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:77: Found 'DU'-anomaly for variable 'serverPlayer' (lines '77'-'96'). +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:81: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:84: Avoid variables with short names like id +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:84: Local variable 'id' could be declared final +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:87: Found 'DU'-anomaly for variable 'realRoute' (lines '87'-'96'). +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:105: Local variable 'result' could be declared final +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/UpdateTradeRouteMessage.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/WorkMessage.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/WorkMessage.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/networking/WorkMessage.java:51: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:51: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:64: Avoid unused constructor parameters such as 'game'. +src/net/sf/freecol/common/networking/WorkMessage.java:64: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:72: Comment is too large: Too many lines +src/net/sf/freecol/common/networking/WorkMessage.java:81: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:81: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:82: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:83: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/networking/WorkMessage.java:83: Found 'DU'-anomaly for variable 'serverPlayer' (lines '83'-'121'). +src/net/sf/freecol/common/networking/WorkMessage.java:84: Found 'DU'-anomaly for variable 'game' (lines '84'-'121'). +src/net/sf/freecol/common/networking/WorkMessage.java:88: Found 'DU'-anomaly for variable 'unit' (lines '88'-'121'). +src/net/sf/freecol/common/networking/WorkMessage.java:89: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/networking/WorkMessage.java:90: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/WorkMessage.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:94: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/WorkMessage.java:98: Local variable 'colony' could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:98: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/networking/WorkMessage.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:100: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/WorkMessage.java:104: Local variable 'workLocation' could be declared final +src/net/sf/freecol/common/networking/WorkMessage.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/WorkMessage.java:109: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/networking/WorkMessage.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/WorkMessage.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:113: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/networking/WorkMessage.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/networking/WorkMessage.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/AbstractOption.java:39: The class 'AbstractOption' has a Cyclomatic Complexity of 3 (Highest = 19). +src/net/sf/freecol/common/option/AbstractOption.java:39: The class 'AbstractOption' has a Modified Cyclomatic Complexity of 3 (Highest = 19). +src/net/sf/freecol/common/option/AbstractOption.java:39: The class 'AbstractOption' has a Standard Cyclomatic Complexity of 3 (Highest = 19). +src/net/sf/freecol/common/option/AbstractOption.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/AbstractOption.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractOption.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/AbstractOption.java:51: Avoid using redundant field initializer for 'isDefined' +src/net/sf/freecol/common/option/AbstractOption.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/AbstractOption.java:59: Avoid variables with short names like id +src/net/sf/freecol/common/option/AbstractOption.java:59: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/option/AbstractOption.java:59: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:68: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:78: Avoid variables with short names like id +src/net/sf/freecol/common/option/AbstractOption.java:78: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/option/AbstractOption.java:78: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:78: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:99: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:108: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:116: Comment is too large: Too many lines +src/net/sf/freecol/common/option/AbstractOption.java:128: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/AbstractOption.java:128: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:128: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:138: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/common/option/AbstractOption.java:159: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/AbstractOption.java:181: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AbstractOption.java:181: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractOption.java:182: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AbstractOption.java:182: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractOption.java:189: Avoid variables with short names like xr +src/net/sf/freecol/common/option/AbstractOption.java:189: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:192: Local variable 'defaultValue' could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:194: Local variable 'value' could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:216: Avoid variables with short names like xr +src/net/sf/freecol/common/option/AbstractOption.java:216: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractOption.java:216: The method 'readOption' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/common/option/AbstractOption.java:216: The method 'readOption' has a Modified Cyclomatic Complexity of 19. +src/net/sf/freecol/common/option/AbstractOption.java:216: The method 'readOption' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/common/option/AbstractOption.java:217: Found 'DU'-anomaly for variable 'spec' (lines '217'-'281'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'227'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'230'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'233'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'236'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'239'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'242'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'245'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'248'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'251'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'254'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'257'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'260'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'263'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'266'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'269'). +src/net/sf/freecol/common/option/AbstractOption.java:219: Found 'DD'-anomaly for variable 'option' (lines '219'-'272'). +src/net/sf/freecol/common/option/AbstractOption.java:223: There is log block not surrounded by if +src/net/sf/freecol/common/option/AbstractOption.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:235: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:238: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:244: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:247: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:262: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractOption.java:275: There is log block not surrounded by if +src/net/sf/freecol/common/option/AbstractOption.java:279: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AbstractUnitOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/AbstractUnitOption.java:41: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/common/option/AbstractUnitOption.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/AbstractUnitOption.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractUnitOption.java:43: Avoid unused private fields such as 'DEFAULT_SELECTOR'. +src/net/sf/freecol/common/option/AbstractUnitOption.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractUnitOption.java:46: Avoid using redundant field initializer for 'value' +src/net/sf/freecol/common/option/AbstractUnitOption.java:49: Avoid using redundant field initializer for 'unitType' +src/net/sf/freecol/common/option/AbstractUnitOption.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/AbstractUnitOption.java:52: Avoid using redundant field initializer for 'role' +src/net/sf/freecol/common/option/AbstractUnitOption.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/AbstractUnitOption.java:55: Avoid using redundant field initializer for 'number' +src/net/sf/freecol/common/option/AbstractUnitOption.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/AbstractUnitOption.java:63: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:73: Avoid variables with short names like id +src/net/sf/freecol/common/option/AbstractUnitOption.java:73: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:73: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:126: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/AbstractUnitOption.java:127: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/AbstractUnitOption.java:127: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/AbstractUnitOption.java:129: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/AbstractUnitOption.java:132: Avoid variables with short names like au +src/net/sf/freecol/common/option/AbstractUnitOption.java:132: Local variable 'au' could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/AbstractUnitOption.java:136: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AbstractUnitOption.java:137: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AbstractUnitOption.java:138: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AbstractUnitOption.java:154: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:155: Found 'DU'-anomaly for variable 'spec' (lines '155'-'176'). +src/net/sf/freecol/common/option/AbstractUnitOption.java:159: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/option/AbstractUnitOption.java:160: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/option/AbstractUnitOption.java:161: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/option/AbstractUnitOption.java:171: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:171: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:171: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:171: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:171: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:171: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:172: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:172: Useless parentheses. +src/net/sf/freecol/common/option/AbstractUnitOption.java:193: Found 'UR'-anomaly for variable 'r' (lines '193'-'197'). +src/net/sf/freecol/common/option/AbstractUnitOption.java:195: Local variable 'roles' could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:196: Local variable 'r' could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:196: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AbstractUnitOption.java:205: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AbstractUnitOption.java:205: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractUnitOption.java:206: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AbstractUnitOption.java:206: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractUnitOption.java:207: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AbstractUnitOption.java:207: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AbstractUnitOption.java:214: Avoid variables with short names like xw +src/net/sf/freecol/common/option/AbstractUnitOption.java:214: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:228: Avoid variables with short names like xr +src/net/sf/freecol/common/option/AbstractUnitOption.java:228: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:231: Avoid variables with short names like au +src/net/sf/freecol/common/option/AbstractUnitOption.java:231: Found 'DD'-anomaly for variable 'au' (lines '231'-'233'). +src/net/sf/freecol/common/option/AbstractUnitOption.java:244: Avoid variables with short names like xr +src/net/sf/freecol/common/option/AbstractUnitOption.java:244: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:245: Avoid unused local variables such as 'spec'. +src/net/sf/freecol/common/option/AbstractUnitOption.java:245: Found 'DU'-anomaly for variable 'spec' (lines '245'-'265'). +src/net/sf/freecol/common/option/AbstractUnitOption.java:248: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AbstractUnitOption.java:272: Avoid variables with short names like sb +src/net/sf/freecol/common/option/AbstractUnitOption.java:272: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/AbstractUnitOption.java:273: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/AbstractUnitOption.java:274: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/AbstractUnitOption.java:274: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/AudioMixerOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/AudioMixerOption.java:43: The Logger variable declaration does not contain the static and final modifiers +src/net/sf/freecol/common/option/AudioMixerOption.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/AudioMixerOption.java:58: Parameter 'mixerInfo' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:58: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:58: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:63: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:67: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:74: Avoid variables with short names like mw +src/net/sf/freecol/common/option/AudioMixerOption.java:74: Parameter 'mw' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:74: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AudioMixerOption.java:79: Avoid variables with short names like o +src/net/sf/freecol/common/option/AudioMixerOption.java:79: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:79: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:80: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/AudioMixerOption.java:80: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AudioMixerOption.java:82: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/AudioMixerOption.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AudioMixerOption.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AudioMixerOption.java:88: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AudioMixerOption.java:93: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/AudioMixerOption.java:99: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AudioMixerOption.java:103: Avoid excessively long variable names like AUTODETECTED_MIXER +src/net/sf/freecol/common/option/AudioMixerOption.java:103: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AudioMixerOption.java:108: Avoid empty catch blocks +src/net/sf/freecol/common/option/AudioMixerOption.java:108: Avoid empty catch blocks +src/net/sf/freecol/common/option/AudioMixerOption.java:113: Avoid excessively long variable names like DEFAULT_MIXER_WRAPPER +src/net/sf/freecol/common/option/AudioMixerOption.java:113: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AudioMixerOption.java:114: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/option/AudioMixerOption.java:118: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AudioMixerOption.java:118: Variables that are final and static should be all capitals, 'audioMixers' is not all capitals. +src/net/sf/freecol/common/option/AudioMixerOption.java:120: Local variable 'mi' could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:121: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/option/AudioMixerOption.java:129: Avoid using redundant field initializer for 'value' +src/net/sf/freecol/common/option/AudioMixerOption.java:129: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/AudioMixerOption.java:137: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:148: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:149: Avoid variables with short names like mw +src/net/sf/freecol/common/option/AudioMixerOption.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AudioMixerOption.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AudioMixerOption.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/AudioMixerOption.java:167: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/AudioMixerOption.java:168: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/AudioMixerOption.java:168: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/AudioMixerOption.java:169: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:186: Avoid reassigning parameters such as 'newValue' +src/net/sf/freecol/common/option/AudioMixerOption.java:188: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AudioMixerOption.java:203: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/AudioMixerOption.java:203: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:203: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/AudioMixerOption.java:204: Avoid variables with short names like mw +src/net/sf/freecol/common/option/AudioMixerOption.java:211: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/AudioMixerOption.java:223: Avoid variables with short names like xw +src/net/sf/freecol/common/option/AudioMixerOption.java:223: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/BooleanOption.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/BooleanOption.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/option/BooleanOption.java:48: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:58: Avoid variables with short names like id +src/net/sf/freecol/common/option/BooleanOption.java:58: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:58: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:68: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/BooleanOption.java:69: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/BooleanOption.java:69: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/BooleanOption.java:70: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:87: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:104: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/BooleanOption.java:104: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:104: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:105: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/BooleanOption.java:117: Avoid variables with short names like xw +src/net/sf/freecol/common/option/BooleanOption.java:117: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:128: Avoid variables with short names like sb +src/net/sf/freecol/common/option/BooleanOption.java:128: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/BooleanOption.java:129: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/BooleanOption.java:131: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/FileOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/FileOption.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/FileOption.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/option/FileOption.java:40: Avoid using redundant field initializer for 'value' +src/net/sf/freecol/common/option/FileOption.java:48: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/FileOption.java:58: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/FileOption.java:59: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/FileOption.java:59: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/FileOption.java:60: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/FileOption.java:77: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/FileOption.java:81: Use equals() to compare object references. +src/net/sf/freecol/common/option/FileOption.java:102: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/FileOption.java:102: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/FileOption.java:102: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/FileOption.java:103: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/FileOption.java:105: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/FileOption.java:108: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/option/FileOption.java:120: Avoid variables with short names like xw +src/net/sf/freecol/common/option/FileOption.java:120: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/FileOption.java:133: Avoid variables with short names like sb +src/net/sf/freecol/common/option/FileOption.java:133: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/FileOption.java:134: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/FileOption.java:136: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/IntegerOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/IntegerOption.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/IntegerOption.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/option/IntegerOption.java:54: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:64: Avoid variables with short names like id +src/net/sf/freecol/common/option/IntegerOption.java:64: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:64: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:83: Parameter 'minimumValue' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:101: Parameter 'maximumValue' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:111: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:112: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/IntegerOption.java:112: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/IntegerOption.java:112: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/IntegerOption.java:121: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/IntegerOption.java:122: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/IntegerOption.java:122: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/IntegerOption.java:123: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/IntegerOption.java:142: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:158: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/IntegerOption.java:158: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:158: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:159: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/IntegerOption.java:159: Local variable 'str' could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:163: There is log block not surrounded by if +src/net/sf/freecol/common/option/IntegerOption.java:170: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/IntegerOption.java:170: fieldCommentRequirement Required +src/net/sf/freecol/common/option/IntegerOption.java:171: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/IntegerOption.java:171: fieldCommentRequirement Required +src/net/sf/freecol/common/option/IntegerOption.java:178: Avoid variables with short names like xw +src/net/sf/freecol/common/option/IntegerOption.java:178: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:196: Avoid variables with short names like xr +src/net/sf/freecol/common/option/IntegerOption.java:196: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:203: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/IntegerOption.java:211: Avoid variables with short names like sb +src/net/sf/freecol/common/option/IntegerOption.java:211: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/IntegerOption.java:212: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/IntegerOption.java:214: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/LanguageOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/LanguageOption.java:46: The class 'LanguageOption' has a Cyclomatic Complexity of 3 (Highest = 11). +src/net/sf/freecol/common/option/LanguageOption.java:48: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/LanguageOption.java:48: fieldCommentRequirement Required +src/net/sf/freecol/common/option/LanguageOption.java:51: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/option/LanguageOption.java:51: Variables that are final and static should be all capitals, 'languageNames' is not all capitals. +src/net/sf/freecol/common/option/LanguageOption.java:61: headerCommentRequirement Required +src/net/sf/freecol/common/option/LanguageOption.java:70: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:70: Parameter 'locale' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:70: publicMethodCommentRequirement Required +src/net/sf/freecol/common/option/LanguageOption.java:117: Avoid variables with short names like l +src/net/sf/freecol/common/option/LanguageOption.java:117: Parameter 'l' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/LanguageOption.java:127: Avoid variables with short names like o +src/net/sf/freecol/common/option/LanguageOption.java:127: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:128: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/LanguageOption.java:128: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/LanguageOption.java:130: Avoid variables with short names like l +src/net/sf/freecol/common/option/LanguageOption.java:130: Local variable 'l' could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:131: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/LanguageOption.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/LanguageOption.java:142: Local variable 'hash' could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:143: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/LanguageOption.java:151: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/option/LanguageOption.java:152: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/LanguageOption.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/LanguageOption.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:168: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/LanguageOption.java:168: Variables that are final and static should be all capitals, 'languages' is not all capitals. +src/net/sf/freecol/common/option/LanguageOption.java:171: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/LanguageOption.java:175: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/LanguageOption.java:183: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:192: Found 'UR'-anomaly for variable 'file' (lines '192'-'202'). +src/net/sf/freecol/common/option/LanguageOption.java:192: The method 'initializeLanguages' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/common/option/LanguageOption.java:193: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/LanguageOption.java:195: Local variable 'i18nDirectory' could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:196: Local variable 'files' could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:198: Avoid throwing raw exception types. +src/net/sf/freecol/common/option/LanguageOption.java:201: Local variable 'file' could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:202: Local variable 'nam' could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:203: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/LanguageOption.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:207: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/option/LanguageOption.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:208: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/option/LanguageOption.java:213: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:213: This call to String.startsWith can be rewritten using String.charAt(0) +src/net/sf/freecol/common/option/LanguageOption.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/LanguageOption.java:217: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/option/LanguageOption.java:219: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/option/LanguageOption.java:220: There is log block not surrounded by if +src/net/sf/freecol/common/option/LanguageOption.java:233: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:234: Avoid variables with short names like l +src/net/sf/freecol/common/option/LanguageOption.java:252: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/LanguageOption.java:253: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/LanguageOption.java:253: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/LanguageOption.java:254: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:287: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/LanguageOption.java:287: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:287: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:288: Avoid variables with short names like l +src/net/sf/freecol/common/option/LanguageOption.java:309: Avoid variables with short names like xw +src/net/sf/freecol/common/option/LanguageOption.java:309: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/LanguageOption.java:312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/LanguageOption.java:312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/ListOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/ListOption.java:40: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/option/ListOption.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/ListOption.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/option/ListOption.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/ListOption.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/ListOption.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/ListOption.java:65: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:75: Avoid variables with short names like id +src/net/sf/freecol/common/option/ListOption.java:75: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:75: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:103: Found 'UR'-anomaly for variable 'option' (lines '103'-'106'). +src/net/sf/freecol/common/option/ListOption.java:104: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/ListOption.java:105: Local variable 'option' could be declared final +src/net/sf/freecol/common/option/ListOption.java:106: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/ListOption.java:116: Avoid variables with short names like ao +src/net/sf/freecol/common/option/ListOption.java:116: Parameter 'ao' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:117: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/ListOption.java:134: Parameter 'allowDuplicates' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:144: Avoid variables with short names like ao +src/net/sf/freecol/common/option/ListOption.java:144: Parameter 'ao' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:145: Useless parentheses. +src/net/sf/freecol/common/option/ListOption.java:145: Useless parentheses. +src/net/sf/freecol/common/option/ListOption.java:146: Avoid variables with short names like o +src/net/sf/freecol/common/option/ListOption.java:168: Found 'UR'-anomaly for variable 'op' (lines '168'-'174'). +src/net/sf/freecol/common/option/ListOption.java:168: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:170: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/ListOption.java:172: Local variable 'oldValue' could be declared final +src/net/sf/freecol/common/option/ListOption.java:174: Avoid using for statements without curly braces +src/net/sf/freecol/common/option/ListOption.java:174: Local variable 'op' could be declared final +src/net/sf/freecol/common/option/ListOption.java:196: Avoid excessively long variable names like MAXIMUM_NUMBER_TAG +src/net/sf/freecol/common/option/ListOption.java:196: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/ListOption.java:196: fieldCommentRequirement Required +src/net/sf/freecol/common/option/ListOption.java:197: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/ListOption.java:197: fieldCommentRequirement Required +src/net/sf/freecol/common/option/ListOption.java:198: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/ListOption.java:198: fieldCommentRequirement Required +src/net/sf/freecol/common/option/ListOption.java:205: Avoid variables with short names like xw +src/net/sf/freecol/common/option/ListOption.java:205: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:215: Avoid variables with short names like xw +src/net/sf/freecol/common/option/ListOption.java:215: Found 'UR'-anomaly for variable 'option' (lines '215'-'225'). +src/net/sf/freecol/common/option/ListOption.java:215: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:224: Local variable 'option' could be declared final +src/net/sf/freecol/common/option/ListOption.java:233: Avoid variables with short names like xr +src/net/sf/freecol/common/option/ListOption.java:233: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:243: Avoid variables with short names like xr +src/net/sf/freecol/common/option/ListOption.java:243: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:254: Avoid variables with short names like xr +src/net/sf/freecol/common/option/ListOption.java:254: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/ListOption.java:257: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/ListOption.java:260: Local variable 'modId' could be declared final +src/net/sf/freecol/common/option/ListOption.java:264: Local variable 'fcmf' could be declared final +src/net/sf/freecol/common/option/ListOption.java:265: Deeply nested if..then statements are hard to read +src/net/sf/freecol/common/option/ListOption.java:266: Local variable 'modOption' could be declared final +src/net/sf/freecol/common/option/ListOption.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/ListOption.java:279: Avoid variables with short names like op +src/net/sf/freecol/common/option/ListOption.java:279: Found 'DD'-anomaly for variable 'op' (lines '279'-'281'). +src/net/sf/freecol/common/option/ListOption.java:283: There is log block not surrounded by if +src/net/sf/freecol/common/option/ListOption.java:285: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/ListOption.java:294: Found 'UR'-anomaly for variable 'ao' (lines '294'-'300'). +src/net/sf/freecol/common/option/ListOption.java:295: Avoid variables with short names like sb +src/net/sf/freecol/common/option/ListOption.java:295: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/ListOption.java:296: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/ListOption.java:299: Local variable 'ao' could be declared final +src/net/sf/freecol/common/option/ListOption.java:300: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/ListOption.java:304: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/MapGeneratorOptions.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/MapGeneratorOptions.java:32: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/option/MapGeneratorOptions.java:36: Avoid excessively long variable names like MAPGENERATOROPTIONS_IMPORT +src/net/sf/freecol/common/option/MapGeneratorOptions.java:56: Avoid excessively long variable names like IMPORT_SETTLEMENTS +src/net/sf/freecol/common/option/MapGeneratorOptions.java:61: Avoid excessively long variable names like MAPGENERATOROPTIONS_LAND_GENERATOR +src/net/sf/freecol/common/option/MapGeneratorOptions.java:77: Avoid excessively long variable names like LAND_GENERATOR_TYPE +src/net/sf/freecol/common/option/MapGeneratorOptions.java:79: Avoid excessively long variable names like LAND_GENERATOR_CLASSIC +src/net/sf/freecol/common/option/MapGeneratorOptions.java:79: fieldCommentRequirement Required +src/net/sf/freecol/common/option/MapGeneratorOptions.java:80: Avoid excessively long variable names like LAND_GENERATOR_CONTINENT +src/net/sf/freecol/common/option/MapGeneratorOptions.java:81: Avoid excessively long variable names like LAND_GENERATOR_ARCHIPELAGO +src/net/sf/freecol/common/option/MapGeneratorOptions.java:82: Avoid excessively long variable names like LAND_GENERATOR_ISLANDS +src/net/sf/freecol/common/option/MapGeneratorOptions.java:85: Avoid excessively long variable names like PREFERRED_DISTANCE_TO_EDGE +src/net/sf/freecol/common/option/MapGeneratorOptions.java:89: Avoid excessively long variable names like MAXIMUM_DISTANCE_TO_EDGE +src/net/sf/freecol/common/option/MapGeneratorOptions.java:93: Avoid excessively long variable names like DISTANCE_TO_HIGH_SEA +src/net/sf/freecol/common/option/MapGeneratorOptions.java:98: Avoid excessively long variable names like MAPGENERATOROPTIONS_TERRAIN_GENERATOR +src/net/sf/freecol/common/option/MapGeneratorOptions.java:139: Avoid excessively long variable names like TEMPERATURE_CHILLY +src/net/sf/freecol/common/option/MapGeneratorOptions.java:140: Avoid excessively long variable names like TEMPERATURE_TEMPERATE +src/net/sf/freecol/common/option/ModListOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/ModListOption.java:37: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModListOption.java:49: Avoid variables with short names like id +src/net/sf/freecol/common/option/ModListOption.java:49: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModListOption.java:49: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModListOption.java:59: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/ModListOption.java:60: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/ModListOption.java:60: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/ModListOption.java:61: Local variable 'ret' could be declared final +src/net/sf/freecol/common/option/ModOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/ModOption.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/ModOption.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/option/ModOption.java:44: Avoid using redundant field initializer for 'value' +src/net/sf/freecol/common/option/ModOption.java:52: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModOption.java:72: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/ModOption.java:73: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/ModOption.java:73: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/ModOption.java:74: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/ModOption.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/ModOption.java:75: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/ModOption.java:96: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModOption.java:100: Use equals() to compare object references. +src/net/sf/freecol/common/option/ModOption.java:113: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/ModOption.java:113: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModOption.java:113: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModOption.java:114: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/ModOption.java:114: Avoid variables with short names like id +src/net/sf/freecol/common/option/ModOption.java:114: Local variable 'id' could be declared final +src/net/sf/freecol/common/option/ModOption.java:115: Local variable 'fcmf' could be declared final +src/net/sf/freecol/common/option/ModOption.java:137: Avoid variables with short names like o +src/net/sf/freecol/common/option/ModOption.java:137: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModOption.java:138: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/ModOption.java:138: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/ModOption.java:140: Local variable 'mod' could be declared final +src/net/sf/freecol/common/option/ModOption.java:141: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/ModOption.java:152: Local variable 'hash' could be declared final +src/net/sf/freecol/common/option/ModOption.java:153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/ModOption.java:164: Avoid variables with short names like xw +src/net/sf/freecol/common/option/ModOption.java:164: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/ModOption.java:177: Avoid variables with short names like sb +src/net/sf/freecol/common/option/ModOption.java:177: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/ModOption.java:178: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/ModOption.java:178: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/Option.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/Option.java:42: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/option/Option.java:42: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/Option.java:49: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/option/Option.java:56: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/option/Option.java:64: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/option/Option.java:64: Avoid variables with short names like xr +src/net/sf/freecol/common/option/Option.java:72: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/option/Option.java:72: Avoid variables with short names like xw +src/net/sf/freecol/common/option/Option.java:78: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/option/OptionGroup.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:20: Possible God class (WMC=70, ATFD=16, TCC=0.03208556149732621) +src/net/sf/freecol/common/option/OptionGroup.java:41: The class 'OptionGroup' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/option/OptionGroup.java:41: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/option/OptionGroup.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/OptionGroup.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/option/OptionGroup.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/OptionGroup.java:53: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/option/OptionGroup.java:64: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:64: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:73: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:83: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:83: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:83: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:94: Avoid variables with short names like xr +src/net/sf/freecol/common/option/OptionGroup.java:94: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:95: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:116: Parameter 'editable' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:154: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:154: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:164: Avoid variables with short names like o +src/net/sf/freecol/common/option/OptionGroup.java:173: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:174: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:174: Local variable 'id' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:188: Local variable 'group' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:194: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:208: Found 'UR'-anomaly for variable 'o' (lines '208'-'220'). +src/net/sf/freecol/common/option/OptionGroup.java:208: Parameter 'option' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:208: The method 'merge' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/option/OptionGroup.java:209: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:214: Local variable 'optionGroup' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:215: Found 'DD'-anomaly for variable 'result' (lines '215'-'220'). +src/net/sf/freecol/common/option/OptionGroup.java:216: Local variable 'o' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:225: There is log block not surrounded by if +src/net/sf/freecol/common/option/OptionGroup.java:227: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/OptionGroup.java:231: There is log block not surrounded by if +src/net/sf/freecol/common/option/OptionGroup.java:232: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/OptionGroup.java:236: Avoid variables with short names like o +src/net/sf/freecol/common/option/OptionGroup.java:236: Local variable 'o' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:241: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:241: There is log block not surrounded by if +src/net/sf/freecol/common/option/OptionGroup.java:243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/OptionGroup.java:246: Avoid variables with short names like og +src/net/sf/freecol/common/option/OptionGroup.java:246: Local variable 'og' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:247: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/option/OptionGroup.java:249: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/OptionGroup.java:253: There is log block not surrounded by if +src/net/sf/freecol/common/option/OptionGroup.java:263: Found 'UR'-anomaly for variable 'option' (lines '263'-'265'). +src/net/sf/freecol/common/option/OptionGroup.java:263: Parameter 'group' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:264: Local variable 'option' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:278: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:278: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:279: Avoid variables with short names like op +src/net/sf/freecol/common/option/OptionGroup.java:279: Local variable 'op' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:280: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/OptionGroup.java:305: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:315: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:315: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:320: The String literal " value associated with the specified option: " appears 9 times in this file; the first occurrence is on line 320 +src/net/sf/freecol/common/option/OptionGroup.java:324: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:334: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:334: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:336: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:343: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:353: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:353: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:353: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:355: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:362: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:372: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:372: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:374: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:381: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:391: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:391: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:391: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:393: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:400: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:410: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:410: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:412: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:414: The String literal "No String" appears 4 times in this file; the first occurrence is on line 414 +src/net/sf/freecol/common/option/OptionGroup.java:419: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:429: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:429: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:429: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:431: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:438: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:448: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:448: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:450: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:457: Comment is too large: Too many lines +src/net/sf/freecol/common/option/OptionGroup.java:467: Avoid variables with short names like id +src/net/sf/freecol/common/option/OptionGroup.java:467: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:467: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:469: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:482: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/OptionGroup.java:483: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/OptionGroup.java:483: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/OptionGroup.java:484: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:486: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:487: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:487: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/option/OptionGroup.java:488: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:488: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/common/option/OptionGroup.java:505: Found 'UR'-anomaly for variable 'other' (lines '505'-'508'). +src/net/sf/freecol/common/option/OptionGroup.java:505: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:507: Local variable 'other' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:508: Local variable 'mine' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:512: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:522: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/OptionGroup.java:522: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:522: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:540: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/OptionGroup.java:540: fieldCommentRequirement Required +src/net/sf/freecol/common/option/OptionGroup.java:547: Avoid variables with short names like xw +src/net/sf/freecol/common/option/OptionGroup.java:547: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:557: Avoid variables with short names like xw +src/net/sf/freecol/common/option/OptionGroup.java:557: Found 'UR'-anomaly for variable 'o' (lines '557'-'560'). +src/net/sf/freecol/common/option/OptionGroup.java:557: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:560: Avoid using for statements without curly braces +src/net/sf/freecol/common/option/OptionGroup.java:560: Local variable 'o' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:567: Avoid variables with short names like xr +src/net/sf/freecol/common/option/OptionGroup.java:567: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:577: Avoid variables with short names like xr +src/net/sf/freecol/common/option/OptionGroup.java:577: Overriding method merely calls super +src/net/sf/freecol/common/option/OptionGroup.java:577: Overriding method merely calls super +src/net/sf/freecol/common/option/OptionGroup.java:577: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:588: Avoid variables with short names like xr +src/net/sf/freecol/common/option/OptionGroup.java:588: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:589: Local variable 'optionId' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:590: Local variable 'option' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:592: Local variable 'abstractOption' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:595: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/OptionGroup.java:595: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:599: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/OptionGroup.java:607: Found 'UR'-anomaly for variable 'o' (lines '607'-'611'). +src/net/sf/freecol/common/option/OptionGroup.java:608: Avoid variables with short names like sb +src/net/sf/freecol/common/option/OptionGroup.java:608: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:609: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/OptionGroup.java:610: Local variable 'o' could be declared final +src/net/sf/freecol/common/option/OptionGroup.java:611: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/PercentageOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/PercentageOption.java:33: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/PercentageOption.java:33: fieldCommentRequirement Required +src/net/sf/freecol/common/option/PercentageOption.java:41: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/PercentageOption.java:56: Avoid variables with short names like sb +src/net/sf/freecol/common/option/PercentageOption.java:56: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/PercentageOption.java:57: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/PercentageOption.java:58: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/RangeOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/RangeOption.java:28: Comment is too large: Too many lines +src/net/sf/freecol/common/option/RangeOption.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/RangeOption.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/option/RangeOption.java:52: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/RangeOption.java:63: Found 'UR'-anomaly for variable 'i' (lines '63'-'66'). +src/net/sf/freecol/common/option/RangeOption.java:64: Found 'DD'-anomaly for variable 'rank' (lines '64'-'67'). +src/net/sf/freecol/common/option/RangeOption.java:64: Found 'DU'-anomaly for variable 'rank' (lines '64'-'70'). +src/net/sf/freecol/common/option/RangeOption.java:65: Local variable 'i' could be declared final +src/net/sf/freecol/common/option/RangeOption.java:65: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/RangeOption.java:66: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/RangeOption.java:66: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/RangeOption.java:67: Found 'DD'-anomaly for variable 'rank' (lines '67'-'67'). +src/net/sf/freecol/common/option/RangeOption.java:67: Found 'DU'-anomaly for variable 'rank' (lines '67'-'70'). +src/net/sf/freecol/common/option/RangeOption.java:78: Avoid reassigning parameters such as 'rank' +src/net/sf/freecol/common/option/RangeOption.java:79: Found 'DD'-anomaly for variable 'curValue' (lines '79'-'84'). +src/net/sf/freecol/common/option/RangeOption.java:80: Found 'DU'-anomaly for variable 'iterator' (lines '80'-'89'). +src/net/sf/freecol/common/option/RangeOption.java:80: Local variable 'iterator' could be declared final +src/net/sf/freecol/common/option/RangeOption.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/RangeOption.java:80: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/RangeOption.java:83: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/RangeOption.java:84: Found 'DD'-anomaly for variable 'curValue' (lines '84'-'84'). +src/net/sf/freecol/common/option/SelectOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/SelectOption.java:34: Comment is too large: Too many lines +src/net/sf/freecol/common/option/SelectOption.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/SelectOption.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/option/SelectOption.java:52: Avoid using redundant field initializer for 'localizedLabels' +src/net/sf/freecol/common/option/SelectOption.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/SelectOption.java:55: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/option/SelectOption.java:64: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:84: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:84: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:123: Found 'UR'-anomaly for variable 'i' (lines '123'-'129'). +src/net/sf/freecol/common/option/SelectOption.java:123: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:124: Local variable 'keys' could be declared final +src/net/sf/freecol/common/option/SelectOption.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/SelectOption.java:125: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/option/SelectOption.java:125: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/SelectOption.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/SelectOption.java:127: Found 'DU'-anomaly for variable 'fallback' (lines '127'-'138'). +src/net/sf/freecol/common/option/SelectOption.java:128: Local variable 'i' could be declared final +src/net/sf/freecol/common/option/SelectOption.java:129: Use equals() to compare object references. +src/net/sf/freecol/common/option/SelectOption.java:133: Avoid using if statements without curly braces +src/net/sf/freecol/common/option/SelectOption.java:133: Found 'DU'-anomaly for variable 'fallback' (lines '133'-'138'). +src/net/sf/freecol/common/option/SelectOption.java:135: There is log block not surrounded by if +src/net/sf/freecol/common/option/SelectOption.java:143: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/SelectOption.java:143: fieldCommentRequirement Required +src/net/sf/freecol/common/option/SelectOption.java:144: Avoid excessively long variable names like LOCALIZED_LABELS_TAG +src/net/sf/freecol/common/option/SelectOption.java:144: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/SelectOption.java:144: fieldCommentRequirement Required +src/net/sf/freecol/common/option/SelectOption.java:151: Avoid variables with short names like xw +src/net/sf/freecol/common/option/SelectOption.java:151: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:161: Avoid variables with short names like xw +src/net/sf/freecol/common/option/SelectOption.java:161: Found 'UR'-anomaly for variable 'entry' (lines '161'-'167'). +src/net/sf/freecol/common/option/SelectOption.java:161: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:164: Local variable 'entry' could be declared final +src/net/sf/freecol/common/option/SelectOption.java:179: Avoid variables with short names like xr +src/net/sf/freecol/common/option/SelectOption.java:179: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:189: Avoid variables with short names like xr +src/net/sf/freecol/common/option/SelectOption.java:189: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:192: Local variable 'value' could be declared final +src/net/sf/freecol/common/option/SelectOption.java:193: Local variable 'defaultValue' could be declared final +src/net/sf/freecol/common/option/SelectOption.java:208: Avoid variables with short names like xr +src/net/sf/freecol/common/option/SelectOption.java:208: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/SelectOption.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/SelectOption.java:226: Avoid variables with short names like sb +src/net/sf/freecol/common/option/SelectOption.java:226: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/SelectOption.java:226: StringBuffer constructor is initialized with size 16, but has at least 20 characters appended. +src/net/sf/freecol/common/option/SelectOption.java:227: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/SelectOption.java:230: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/StringOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/StringOption.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/StringOption.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/option/StringOption.java:55: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:65: Avoid variables with short names like id +src/net/sf/freecol/common/option/StringOption.java:65: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:65: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:95: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/StringOption.java:96: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/StringOption.java:96: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/StringOption.java:97: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/StringOption.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/StringOption.java:115: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:132: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/StringOption.java:132: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:132: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:133: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/StringOption.java:139: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/StringOption.java:139: fieldCommentRequirement Required +src/net/sf/freecol/common/option/StringOption.java:146: Avoid variables with short names like xw +src/net/sf/freecol/common/option/StringOption.java:146: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:156: Avoid variables with short names like xw +src/net/sf/freecol/common/option/StringOption.java:156: Found 'UR'-anomaly for variable 'choice' (lines '156'-'162'). +src/net/sf/freecol/common/option/StringOption.java:156: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:159: Local variable 'choice' could be declared final +src/net/sf/freecol/common/option/StringOption.java:172: Avoid variables with short names like xr +src/net/sf/freecol/common/option/StringOption.java:172: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:183: Avoid variables with short names like xr +src/net/sf/freecol/common/option/StringOption.java:183: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/StringOption.java:199: Found 'UR'-anomaly for variable 'choice' (lines '199'-'205'). +src/net/sf/freecol/common/option/StringOption.java:200: Avoid variables with short names like sb +src/net/sf/freecol/common/option/StringOption.java:200: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/StringOption.java:201: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/StringOption.java:205: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/StringOption.java:205: Avoid using for statements without curly braces +src/net/sf/freecol/common/option/StringOption.java:205: Local variable 'choice' could be declared final +src/net/sf/freecol/common/option/TextOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/TextOption.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/TextOption.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/option/TextOption.java:48: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/TextOption.java:58: Avoid variables with short names like id +src/net/sf/freecol/common/option/TextOption.java:58: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/TextOption.java:58: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/TextOption.java:68: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/TextOption.java:69: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/TextOption.java:69: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/TextOption.java:70: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/TextOption.java:87: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/TextOption.java:104: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/TextOption.java:104: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/TextOption.java:104: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/TextOption.java:105: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/TextOption.java:111: Avoid unused private fields such as 'CHOICE_TAG'. +src/net/sf/freecol/common/option/TextOption.java:111: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/TextOption.java:111: fieldCommentRequirement Required +src/net/sf/freecol/common/option/TextOption.java:118: Avoid variables with short names like xw +src/net/sf/freecol/common/option/TextOption.java:118: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/TextOption.java:129: Avoid variables with short names like sb +src/net/sf/freecol/common/option/TextOption.java:129: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/TextOption.java:130: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/TextOption.java:130: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/common/option/TextOption.java:132: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/UnitListOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/UnitListOption.java:37: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitListOption.java:47: Avoid variables with short names like id +src/net/sf/freecol/common/option/UnitListOption.java:47: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitListOption.java:47: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitListOption.java:54: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/UnitListOption.java:55: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/UnitListOption.java:55: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/UnitListOption.java:56: Local variable 'ret' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/option/UnitTypeOption.java:38: The class 'UnitTypeOption' has a Cyclomatic Complexity of 2 (Highest = 13). +src/net/sf/freecol/common/option/UnitTypeOption.java:38: The class 'UnitTypeOption' has a Modified Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/common/option/UnitTypeOption.java:38: The class 'UnitTypeOption' has a Standard Cyclomatic Complexity of 2 (Highest = 13). +src/net/sf/freecol/common/option/UnitTypeOption.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/option/UnitTypeOption.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/option/UnitTypeOption.java:55: Field addNone has the same name as a method +src/net/sf/freecol/common/option/UnitTypeOption.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/UnitTypeOption.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/option/UnitTypeOption.java:69: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:79: Avoid variables with short names like id +src/net/sf/freecol/common/option/UnitTypeOption.java:79: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:79: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:117: clone() method should be implemented only if implementing Cloneable interface +src/net/sf/freecol/common/option/UnitTypeOption.java:118: Object clone() should be implemented with super.clone() +src/net/sf/freecol/common/option/UnitTypeOption.java:118: clone() method should throw CloneNotSupportedException +src/net/sf/freecol/common/option/UnitTypeOption.java:119: Local variable 'result' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/option/UnitTypeOption.java:144: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:148: Use equals() to compare object references. +src/net/sf/freecol/common/option/UnitTypeOption.java:161: Avoid excessively long variable names like defaultValueString +src/net/sf/freecol/common/option/UnitTypeOption.java:161: Parameter 'defaultValueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:161: Parameter 'valueString' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:162: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/UnitTypeOption.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/UnitTypeOption.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/UnitTypeOption.java:164: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/option/UnitTypeOption.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/UnitTypeOption.java:165: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/UnitTypeOption.java:183: Found 'UR'-anomaly for variable 'unitType' (lines '183'-'195'). +src/net/sf/freecol/common/option/UnitTypeOption.java:183: The method 'generateChoices' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/common/option/UnitTypeOption.java:183: The method 'generateChoices' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/option/UnitTypeOption.java:183: The method 'generateChoices' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/common/option/UnitTypeOption.java:187: Found 'DU'-anomaly for variable 'unitTypeList' (lines '187'-'219'). +src/net/sf/freecol/common/option/UnitTypeOption.java:187: Local variable 'unitTypeList' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:187: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/option/UnitTypeOption.java:189: Switch statements should have a default label +src/net/sf/freecol/common/option/UnitTypeOption.java:194: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:201: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:208: Local variable 'unitType' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:224: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/UnitTypeOption.java:224: fieldCommentRequirement Required +src/net/sf/freecol/common/option/UnitTypeOption.java:225: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/UnitTypeOption.java:225: fieldCommentRequirement Required +src/net/sf/freecol/common/option/UnitTypeOption.java:226: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/option/UnitTypeOption.java:226: fieldCommentRequirement Required +src/net/sf/freecol/common/option/UnitTypeOption.java:233: Avoid variables with short names like xw +src/net/sf/freecol/common/option/UnitTypeOption.java:233: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:253: Avoid variables with short names like xw +src/net/sf/freecol/common/option/UnitTypeOption.java:253: Found 'UR'-anomaly for variable 'choice' (lines '253'-'260'). +src/net/sf/freecol/common/option/UnitTypeOption.java:253: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:257: Local variable 'choice' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:271: Avoid variables with short names like xr +src/net/sf/freecol/common/option/UnitTypeOption.java:271: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:284: Avoid variables with short names like xr +src/net/sf/freecol/common/option/UnitTypeOption.java:284: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:295: Avoid variables with short names like xr +src/net/sf/freecol/common/option/UnitTypeOption.java:295: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:296: Found 'DU'-anomaly for variable 'spec' (lines '296'-'307'). +src/net/sf/freecol/common/option/UnitTypeOption.java:314: Avoid variables with short names like sb +src/net/sf/freecol/common/option/UnitTypeOption.java:314: Local variable 'sb' could be declared final +src/net/sf/freecol/common/option/UnitTypeOption.java:315: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/option/UnitTypeOption.java:319: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/resources/AudioResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/AudioResource.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/AudioResource.java:35: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/AudioResource.java:38: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/resources/AudioResource.java:38: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/resources/AudioResource.java:38: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/AudioResource.java:48: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/common/resources/AudioResource.java:48: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/AudioResource.java:50: Avoid variables with short names like f +src/net/sf/freecol/common/resources/AudioResource.java:50: Local variable 'f' could be declared final +src/net/sf/freecol/common/resources/AudioResource.java:51: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ColorResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ColorResource.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/resources/ColorResource.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ColorResource.java:39: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ColorResource.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ColorResource.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ColorResource.java:46: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/resources/ColorResource.java:46: Parameter 'color' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ColorResource.java:46: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ColorResource.java:56: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/common/resources/ColorResource.java:56: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ColorResource.java:59: Local variable 'colorName' could be declared final +src/net/sf/freecol/common/resources/ColorResource.java:74: Parameter 'str' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ColorResource.java:75: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ColorResource.java:77: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ColorResource.java:79: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/resources/ColorResource.java:80: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ColorResource.java:94: Parameter 'colorName' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ColorResource.java:97: Local variable 'col' could be declared final +src/net/sf/freecol/common/resources/ColorResource.java:98: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ColorResource.java:100: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ColorResource.java:105: Local variable 'field' could be declared final +src/net/sf/freecol/common/resources/ColorResource.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ColorResource.java:106: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ColorResource.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/FAFile.java:39: The class 'FAFile' has a Cyclomatic Complexity of 5 (Highest = 17). +src/net/sf/freecol/common/resources/FAFile.java:39: The class 'FAFile' has a Modified Cyclomatic Complexity of 5 (Highest = 15). +src/net/sf/freecol/common/resources/FAFile.java:39: The class 'FAFile' has a Standard Cyclomatic Complexity of 5 (Highest = 15). +src/net/sf/freecol/common/resources/FAFile.java:42: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/FAFile.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:43: Avoid using redundant field initializer for 'maxHeight' +src/net/sf/freecol/common/resources/FAFile.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:53: Avoid variables with short names like is +src/net/sf/freecol/common/resources/FAFile.java:53: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFile.java:65: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFile.java:66: Avoid variables with short names like fn +src/net/sf/freecol/common/resources/FAFile.java:66: Local variable 'fn' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:68: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/FAFile.java:73: Avoid variables with short names like fl +src/net/sf/freecol/common/resources/FAFile.java:73: Local variable 'fl' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:80: Avoid variables with short names like p +src/net/sf/freecol/common/resources/FAFile.java:80: Local variable 'p' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:91: Avoid variables with short names like p +src/net/sf/freecol/common/resources/FAFile.java:91: Local variable 'p' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:110: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFile.java:111: Avoid variables with short names like fn +src/net/sf/freecol/common/resources/FAFile.java:111: Local variable 'fn' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:113: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/FAFile.java:115: Local variable 'points' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:116: Avoid variables with short names like x +src/net/sf/freecol/common/resources/FAFile.java:116: Found 'DU'-anomaly for variable 'x' (lines '116'-'127'). +src/net/sf/freecol/common/resources/FAFile.java:118: Avoid variables with short names like fl +src/net/sf/freecol/common/resources/FAFile.java:118: Local variable 'fl' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:120: Avoid variables with short names like p +src/net/sf/freecol/common/resources/FAFile.java:120: Local variable 'p' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:121: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:126: This call to Collection.toArray() may be optimizable +src/net/sf/freecol/common/resources/FAFile.java:129: Avoid unused private methods such as 'load(InputStream)'. +src/net/sf/freecol/common/resources/FAFile.java:129: Avoid variables with short names like is +src/net/sf/freecol/common/resources/FAFile.java:129: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFile.java:129: The method 'load' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/common/resources/FAFile.java:129: The method 'load' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/common/resources/FAFile.java:129: The method 'load' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/common/resources/FAFile.java:129: The method load() has an NPath complexity of 6732 +src/net/sf/freecol/common/resources/FAFile.java:132: Avoid variables with short names like in +src/net/sf/freecol/common/resources/FAFile.java:132: Local variable 'in' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:142: Avoid variables with short names like st +src/net/sf/freecol/common/resources/FAFile.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:147: Found 'DU'-anomaly for variable 'name' (lines '147'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:147: Local variable 'name' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:148: Avoid assignments in operands +src/net/sf/freecol/common/resources/FAFile.java:148: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/FAFile.java:148: Found 'DD'-anomaly for variable 'line' (lines '148'-'179'). +src/net/sf/freecol/common/resources/FAFile.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:149: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:150: Found 'DU'-anomaly for variable 'width' (lines '150'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:150: Local variable 'width' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:151: Found 'DU'-anomaly for variable 'height' (lines '151'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:151: Local variable 'height' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:152: Local variable 'numberOfPoints' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:153: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:153: Avoid variables with short names like xs +src/net/sf/freecol/common/resources/FAFile.java:153: Found 'DD'-anomaly for variable 'xs' (lines '153'-'159'). +src/net/sf/freecol/common/resources/FAFile.java:153: Found 'DD'-anomaly for variable 'xs' (lines '153'-'185'). +src/net/sf/freecol/common/resources/FAFile.java:153: Found 'DU'-anomaly for variable 'xs' (lines '153'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:154: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:154: Avoid variables with short names like ys +src/net/sf/freecol/common/resources/FAFile.java:154: Found 'DD'-anomaly for variable 'ys' (lines '154'-'165'). +src/net/sf/freecol/common/resources/FAFile.java:154: Found 'DD'-anomaly for variable 'ys' (lines '154'-'186'). +src/net/sf/freecol/common/resources/FAFile.java:154: Found 'DU'-anomaly for variable 'ys' (lines '154'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:156: Avoid assignments in operands +src/net/sf/freecol/common/resources/FAFile.java:156: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/FAFile.java:156: Found 'DD'-anomaly for variable 'line' (lines '156'-'179'). +src/net/sf/freecol/common/resources/FAFile.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:157: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:157: Found 'DD'-anomaly for variable 'st' (lines '157'-'163'). +src/net/sf/freecol/common/resources/FAFile.java:157: Found 'DD'-anomaly for variable 'st' (lines '157'-'181'). +src/net/sf/freecol/common/resources/FAFile.java:157: Found 'DU'-anomaly for variable 'st' (lines '157'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:159: Found 'DD'-anomaly for variable 'xs' (lines '159'-'159'). +src/net/sf/freecol/common/resources/FAFile.java:159: Found 'DD'-anomaly for variable 'xs' (lines '159'-'185'). +src/net/sf/freecol/common/resources/FAFile.java:159: Found 'DU'-anomaly for variable 'xs' (lines '159'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:162: Avoid assignments in operands +src/net/sf/freecol/common/resources/FAFile.java:162: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/FAFile.java:162: Found 'DD'-anomaly for variable 'line' (lines '162'-'179'). +src/net/sf/freecol/common/resources/FAFile.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:163: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:163: Found 'DD'-anomaly for variable 'st' (lines '163'-'181'). +src/net/sf/freecol/common/resources/FAFile.java:163: Found 'DU'-anomaly for variable 'st' (lines '163'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:165: Found 'DD'-anomaly for variable 'ys' (lines '165'-'165'). +src/net/sf/freecol/common/resources/FAFile.java:165: Found 'DD'-anomaly for variable 'ys' (lines '165'-'186'). +src/net/sf/freecol/common/resources/FAFile.java:165: Found 'DU'-anomaly for variable 'ys' (lines '165'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:168: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:168: Local variable 'newLetter' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:171: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:173: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:179: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:181: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:182: Found 'DU'-anomaly for variable 'letter' (lines '182'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:182: Local variable 'letter' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:183: Found 'DU'-anomaly for variable 'advance' (lines '183'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:183: Local variable 'advance' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:184: Local variable 'numberOfPoints' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:185: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:185: Avoid variables with short names like xs +src/net/sf/freecol/common/resources/FAFile.java:185: Found 'DD'-anomaly for variable 'xs' (lines '185'-'185'). +src/net/sf/freecol/common/resources/FAFile.java:185: Found 'DD'-anomaly for variable 'xs' (lines '185'-'190'). +src/net/sf/freecol/common/resources/FAFile.java:185: Found 'DU'-anomaly for variable 'xs' (lines '185'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:186: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:186: Avoid variables with short names like ys +src/net/sf/freecol/common/resources/FAFile.java:186: Found 'DD'-anomaly for variable 'ys' (lines '186'-'186'). +src/net/sf/freecol/common/resources/FAFile.java:186: Found 'DD'-anomaly for variable 'ys' (lines '186'-'196'). +src/net/sf/freecol/common/resources/FAFile.java:186: Found 'DU'-anomaly for variable 'ys' (lines '186'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:188: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:188: Found 'DD'-anomaly for variable 'st' (lines '188'-'194'). +src/net/sf/freecol/common/resources/FAFile.java:188: Found 'DU'-anomaly for variable 'st' (lines '188'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:190: Found 'DD'-anomaly for variable 'xs' (lines '190'-'185'). +src/net/sf/freecol/common/resources/FAFile.java:190: Found 'DD'-anomaly for variable 'xs' (lines '190'-'190'). +src/net/sf/freecol/common/resources/FAFile.java:190: Found 'DU'-anomaly for variable 'xs' (lines '190'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:193: Avoid assignments in operands +src/net/sf/freecol/common/resources/FAFile.java:193: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/FAFile.java:193: Found 'DU'-anomaly for variable 'line' (lines '193'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:194: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:194: Found 'DD'-anomaly for variable 'st' (lines '194'-'181'). +src/net/sf/freecol/common/resources/FAFile.java:194: Found 'DU'-anomaly for variable 'st' (lines '194'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:196: Found 'DD'-anomaly for variable 'ys' (lines '196'-'186'). +src/net/sf/freecol/common/resources/FAFile.java:196: Found 'DD'-anomaly for variable 'ys' (lines '196'-'196'). +src/net/sf/freecol/common/resources/FAFile.java:196: Found 'DU'-anomaly for variable 'ys' (lines '196'-'208'). +src/net/sf/freecol/common/resources/FAFile.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:199: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:199: Local variable 'newLetter' could be declared final +src/net/sf/freecol/common/resources/FAFile.java:201: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:203: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/FAFile.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/FAFile.java:211: Parameter 'letter' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFile.java:215: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFile.java:219: headerCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:220: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:220: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:221: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:221: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:224: headerCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:225: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:225: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:226: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:226: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:227: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:227: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFile.java:241: Avoid variables with short names like in +src/net/sf/freecol/common/resources/FAFile.java:241: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/resources/FAFile.java:241: Parameter 'in' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFile.java:253: Avoid variables with short names like c +src/net/sf/freecol/common/resources/FAFile.java:260: Avoid variables with short names like in +src/net/sf/freecol/common/resources/FAFile.java:260: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/FAFile.java:260: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FAFile.java:260: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFileResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/FAFileResource.java:34: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FAFileResource.java:37: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/resources/FAFileResource.java:37: Parameter 'FAFile' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFileResource.java:37: Variables should start with a lowercase character, 'FAFile' starts with uppercase character. +src/net/sf/freecol/common/resources/FAFileResource.java:37: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/FAFileResource.java:48: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/common/resources/FAFileResource.java:48: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FAFileResource.java:50: Local variable 'url' could be declared final +src/net/sf/freecol/common/resources/FontResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/FontResource.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/resources/FontResource.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FontResource.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FontResource.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/FontResource.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/FontResource.java:45: It is a good practice to call super() in a constructor +src/net/sf/freecol/common/resources/FontResource.java:45: Parameter 'font' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FontResource.java:45: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/FontResource.java:55: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/common/resources/FontResource.java:55: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/FontResource.java:57: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/FontResource.java:61: Local variable 'url' could be declared final +src/net/sf/freecol/common/resources/FontResource.java:64: Local variable 'name' could be declared final +src/net/sf/freecol/common/resources/FontResource.java:73: There is log block not surrounded by if +src/net/sf/freecol/common/resources/FontResource.java:73: There is log block not surrounded by if +src/net/sf/freecol/common/resources/FontResource.java:75: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/resources/FontResource.java:76: There is log block not surrounded by if +src/net/sf/freecol/common/resources/FontResource.java:83: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ImageResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ImageResource.java:42: The class 'ImageResource' has a Cyclomatic Complexity of 4 (Highest = 16). +src/net/sf/freecol/common/resources/ImageResource.java:45: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/resources/ImageResource.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ImageResource.java:47: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ImageResource.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ImageResource.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ImageResource.java:48: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ImageResource.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ImageResource.java:48: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ImageResource.java:49: Avoid using redundant field initializer for 'image' +src/net/sf/freecol/common/resources/ImageResource.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ImageResource.java:49: Use of modifier volatile is not recommended. +src/net/sf/freecol/common/resources/ImageResource.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ImageResource.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ImageResource.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ImageResource.java:59: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:72: Local variable 'url' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:72: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ImageResource.java:75: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ImageResource.java:79: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ImageResource.java:102: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ImageResource.java:115: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:116: Avoid variables with short names like im +src/net/sf/freecol/common/resources/ImageResource.java:117: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:118: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:130: Avoid variables with short names like d +src/net/sf/freecol/common/resources/ImageResource.java:130: Parameter 'd' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:130: The method 'getImage' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/common/resources/ImageResource.java:130: The method getImage() has an NPath complexity of 1944 +src/net/sf/freecol/common/resources/ImageResource.java:131: Avoid variables with short names like im +src/net/sf/freecol/common/resources/ImageResource.java:132: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:133: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:136: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:137: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:138: Avoid variables with short names like w +src/net/sf/freecol/common/resources/ImageResource.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:139: Avoid variables with short names like h +src/net/sf/freecol/common/resources/ImageResource.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:140: Use opposite operator instead of the logic complement operator. +src/net/sf/freecol/common/resources/ImageResource.java:140: Useless parentheses. +src/net/sf/freecol/common/resources/ImageResource.java:140: Useless parentheses. +src/net/sf/freecol/common/resources/ImageResource.java:141: Useless parentheses. +src/net/sf/freecol/common/resources/ImageResource.java:141: Useless parentheses. +src/net/sf/freecol/common/resources/ImageResource.java:143: Useless parentheses. +src/net/sf/freecol/common/resources/ImageResource.java:143: Useless parentheses. +src/net/sf/freecol/common/resources/ImageResource.java:145: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:146: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:149: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:149: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:156: Avoid instantiating new objects inside loops +src/net/sf/freecol/common/resources/ImageResource.java:156: Local variable 'halved' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:158: Avoid variables with short names like g +src/net/sf/freecol/common/resources/ImageResource.java:158: Local variable 'g' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:168: Local variable 'scaled' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:170: Avoid variables with short names like g +src/net/sf/freecol/common/resources/ImageResource.java:170: Local variable 'g' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:188: Avoid variables with short names like d +src/net/sf/freecol/common/resources/ImageResource.java:188: Parameter 'd' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:190: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:190: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:191: Avoid variables with short names like im +src/net/sf/freecol/common/resources/ImageResource.java:192: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:192: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:193: Local variable 'width' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:194: Local variable 'height' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:197: Local variable 'srcImage' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:199: Avoid variables with short names like g +src/net/sf/freecol/common/resources/ImageResource.java:199: Local variable 'g' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:202: Local variable 'filter' could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:217: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ImageResource.java:218: Avoid variables with short names like im +src/net/sf/freecol/common/resources/ImageResource.java:219: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ImageResource.java:219: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ImageResource.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ImageResource.java:224: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/Resource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/Resource.java:31: Abstract classes should be named AbstractXXX +src/net/sf/freecol/common/resources/Resource.java:42: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/resources/Resource.java:55: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/resources/Resource.java:63: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/Resource.java:66: protectedMethodCommentRequirement Required +src/net/sf/freecol/common/resources/Resource.java:78: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceFactory.java:34: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/resources/ResourceFactory.java:34: The class 'ResourceFactory' has a Cyclomatic Complexity of 16 (Highest = 17). +src/net/sf/freecol/common/resources/ResourceFactory.java:34: The class 'ResourceFactory' has a Modified Cyclomatic Complexity of 16 (Highest = 17). +src/net/sf/freecol/common/resources/ResourceFactory.java:34: The class 'ResourceFactory' has a Standard Cyclomatic Complexity of 16 (Highest = 17). +src/net/sf/freecol/common/resources/ResourceFactory.java:36: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:36: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:43: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:43: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:44: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:44: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:45: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:45: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:46: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:46: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:47: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:48: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:49: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:49: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:50: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceFactory.java:50: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:59: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:59: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:59: Variables that are final and static should be all capitals, 'colorResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:61: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:61: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:61: Variables that are final and static should be all capitals, 'fontResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:63: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:63: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:63: Variables that are final and static should be all capitals, 'stringResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:65: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:65: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:65: Variables that are final and static should be all capitals, 'fafResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:67: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:67: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:67: Variables that are final and static should be all capitals, 'szaResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:69: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:69: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:69: Variables that are final and static should be all capitals, 'audioResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:69: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:71: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:71: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:71: Variables that are final and static should be all capitals, 'videoResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:71: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:73: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/common/resources/ResourceFactory.java:73: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/common/resources/ResourceFactory.java:73: Variables that are final and static should be all capitals, 'imageResources' is not all capitals. +src/net/sf/freecol/common/resources/ResourceFactory.java:73: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceFactory.java:76: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceFactory.java:85: Parameter 'output' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:85: Parameter 'uri' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:85: The method 'findResource' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/common/resources/ResourceFactory.java:85: The method 'findResource' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/common/resources/ResourceFactory.java:85: The method 'findResource' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/common/resources/ResourceFactory.java:85: The method findResource() has an NPath complexity of 6561 +src/net/sf/freecol/common/resources/ResourceFactory.java:88: Avoid variables with short names like cr +src/net/sf/freecol/common/resources/ResourceFactory.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:91: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:96: Avoid variables with short names like fr +src/net/sf/freecol/common/resources/ResourceFactory.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:99: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:104: Avoid variables with short names like sr +src/net/sf/freecol/common/resources/ResourceFactory.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:123: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:128: Avoid variables with short names like ar +src/net/sf/freecol/common/resources/ResourceFactory.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:131: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:136: Avoid variables with short names like vr +src/net/sf/freecol/common/resources/ResourceFactory.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:139: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:144: Avoid variables with short names like ir +src/net/sf/freecol/common/resources/ResourceFactory.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceFactory.java:147: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceFactory.java:153: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceFactory.java:163: Parameter 'output' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:163: Parameter 'uri' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:163: The method 'createResource' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/common/resources/ResourceFactory.java:163: The method 'createResource' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/common/resources/ResourceFactory.java:163: The method 'createResource' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/common/resources/ResourceFactory.java:164: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ResourceFactory.java:169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:170: Avoid variables with short names like cr +src/net/sf/freecol/common/resources/ResourceFactory.java:170: Local variable 'cr' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:174: Avoid variables with short names like fr +src/net/sf/freecol/common/resources/ResourceFactory.java:174: Local variable 'fr' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:179: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:179: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:180: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:181: Avoid variables with short names like sr +src/net/sf/freecol/common/resources/ResourceFactory.java:181: Local variable 'sr' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:184: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:185: Local variable 'far' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:188: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:189: Local variable 'szr' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:192: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:193: Avoid variables with short names like fr +src/net/sf/freecol/common/resources/ResourceFactory.java:193: Local variable 'fr' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:196: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:197: Avoid variables with short names like ar +src/net/sf/freecol/common/resources/ResourceFactory.java:197: Local variable 'ar' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceFactory.java:202: Avoid variables with short names like vr +src/net/sf/freecol/common/resources/ResourceFactory.java:202: Local variable 'vr' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:206: Avoid variables with short names like ar +src/net/sf/freecol/common/resources/ResourceFactory.java:206: Local variable 'ar' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:211: Avoid variables with short names like ir +src/net/sf/freecol/common/resources/ResourceFactory.java:211: Local variable 'ir' could be declared final +src/net/sf/freecol/common/resources/ResourceFactory.java:215: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/resources/ResourceFactory.java:216: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:20: Possible God class (WMC=79, ATFD=31, TCC=0.028409090909090908) +src/net/sf/freecol/common/resources/ResourceManager.java:41: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/resources/ResourceManager.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/resources/ResourceManager.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:53: Avoid excessively long variable names like REPLACEMENT_STRING +src/net/sf/freecol/common/resources/ResourceManager.java:53: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:62: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:71: Avoid using redundant field initializer for 'preloadThread' +src/net/sf/freecol/common/resources/ResourceManager.java:71: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/common/resources/ResourceManager.java:71: Use of modifier volatile is not recommended. +src/net/sf/freecol/common/resources/ResourceManager.java:71: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:80: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:81: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:81: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:92: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:93: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:93: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:104: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:105: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:105: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:116: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:117: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:117: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:128: Found 'UR'-anomaly for variable 'entry' (lines '128'-'132'). +src/net/sf/freecol/common/resources/ResourceManager.java:128: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:130: Local variable 'entry' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:132: Local variable 'resource' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:133: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:137: Local variable 'entry' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:139: Local variable 'resource' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:144: Local variable 'entry' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:146: Local variable 'resource' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:151: Local variable 'entry' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:153: Local variable 'resource' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:157: Do not explicitly trigger a garbage collection. +src/net/sf/freecol/common/resources/ResourceManager.java:165: Parameter 'newItems' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:166: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:168: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/ResourceManager.java:181: Avoid variables with short names like mc +src/net/sf/freecol/common/resources/ResourceManager.java:181: Local variable 'mc' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:192: Found 'UR'-anomaly for variable 'r' (lines '192'-'213'). +src/net/sf/freecol/common/resources/ResourceManager.java:192: Found 'UR'-anomaly for variable 'r' (lines '192'-'213'). +src/net/sf/freecol/common/resources/ResourceManager.java:197: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/common/resources/ResourceManager.java:199: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:202: Local variable 'resources' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:203: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:204: Avoid variables with short names like n +src/net/sf/freecol/common/resources/ResourceManager.java:204: Found 'DD'-anomaly for variable 'n' (lines '204'-'215'). +src/net/sf/freecol/common/resources/ResourceManager.java:204: Found 'DD'-anomaly for variable 'n' (lines '204'-'215'). +src/net/sf/freecol/common/resources/ResourceManager.java:205: Local variable 'r' could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:207: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:207: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:214: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:215: Found 'DD'-anomaly for variable 'n' (lines '215'-'215'). +src/net/sf/freecol/common/resources/ResourceManager.java:215: Found 'DD'-anomaly for variable 'n' (lines '215'-'215'). +src/net/sf/freecol/common/resources/ResourceManager.java:218: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:218: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:226: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:235: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:236: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:240: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:240: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:245: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:245: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:250: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:250: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:255: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:255: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceManager.java:266: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:266: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:279: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:279: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:280: Parameter 'suffix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:281: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:291: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceManager.java:291: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:303: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:304: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:306: The String literal ") failed" appears 13 times in this file; the first occurrence is on line 306 +src/net/sf/freecol/common/resources/ResourceManager.java:306: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:311: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:312: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:314: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:319: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:320: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:322: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:327: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:328: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:330: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:335: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:336: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:338: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:343: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:344: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:346: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:351: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:352: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:354: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:359: Use block level rather than method level synchronization +src/net/sf/freecol/common/resources/ResourceManager.java:360: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:362: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:365: The String literal "Failed getting replacement image." appears 6 times in this file; the first occurrence is on line 365 +src/net/sf/freecol/common/resources/ResourceManager.java:371: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:382: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:384: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:385: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:393: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:406: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:408: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:409: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:417: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:430: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:431: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:439: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:451: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:452: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:460: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:472: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceManager.java:473: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceManager.java:481: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:494: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:495: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/ResourceManager.java:495: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/resources/ResourceManager.java:495: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:498: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:510: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:511: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/ResourceManager.java:511: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/resources/ResourceManager.java:511: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:514: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:526: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:527: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:530: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:541: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:542: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceManager.java:542: Avoid using if statements without curly braces +src/net/sf/freecol/common/resources/ResourceManager.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:546: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceManager.java:557: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:558: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/ResourceManager.java:558: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:570: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:571: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/ResourceManager.java:571: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/resources/ResourceManager.java:571: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:583: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:584: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/ResourceManager.java:584: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceManager.java:596: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceManager.java:597: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/ResourceMapper.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceMapper.java:27: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapper.java:27: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:28: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapper.java:28: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:30: Parameter 'resourceMapping' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:30: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:32: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/resources/ResourceMapper.java:35: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:35: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:41: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:41: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:41: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:46: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:46: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:46: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:51: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:51: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:51: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:56: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:56: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:56: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:61: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:61: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:61: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:66: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:66: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:66: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:71: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:71: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:71: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapper.java:76: Avoid variables with short names like r +src/net/sf/freecol/common/resources/ResourceMapper.java:76: Parameter 'r' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapper.java:76: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceMapping.java:35: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/resources/ResourceMapping.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/resources/ResourceMapping.java:37: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:40: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapping.java:41: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapping.java:41: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:42: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapping.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:43: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapping.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:44: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapping.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:45: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapping.java:45: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:46: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/ResourceMapping.java:46: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:47: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/ResourceMapping.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:68: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/ResourceMapping.java:77: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:77: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:79: The String literal "Rejecting malformed resource key: " appears 7 times in this file; the first occurrence is on line 79 +src/net/sf/freecol/common/resources/ResourceMapping.java:79: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceMapping.java:80: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:86: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:86: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:86: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:88: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceMapping.java:89: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:95: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:95: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:95: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:100: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:100: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:102: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceMapping.java:103: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:109: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:109: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:109: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:111: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceMapping.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:118: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:118: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:118: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:120: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceMapping.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:127: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:127: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:127: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:129: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceMapping.java:130: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:136: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:136: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:136: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:138: There is log block not surrounded by if +src/net/sf/freecol/common/resources/ResourceMapping.java:139: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:152: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:152: Parameter 'keyNew' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:152: The method duplicateResource() has an NPath complexity of 256 +src/net/sf/freecol/common/resources/ResourceMapping.java:153: Avoid variables with short names like cr +src/net/sf/freecol/common/resources/ResourceMapping.java:153: Local variable 'cr' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:155: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:157: Avoid variables with short names like fr +src/net/sf/freecol/common/resources/ResourceMapping.java:157: Local variable 'fr' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:159: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:161: Avoid variables with short names like sr +src/net/sf/freecol/common/resources/ResourceMapping.java:161: Local variable 'sr' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:163: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:165: Local variable 'far' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:167: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:169: Local variable 'szr' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:171: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:173: Avoid variables with short names like ar +src/net/sf/freecol/common/resources/ResourceMapping.java:173: Local variable 'ar' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:175: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:177: Avoid variables with short names like vr +src/net/sf/freecol/common/resources/ResourceMapping.java:177: Local variable 'vr' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:179: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:181: Avoid variables with short names like ir +src/net/sf/freecol/common/resources/ResourceMapping.java:181: Local variable 'ir' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:183: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/ResourceMapping.java:194: Avoid variables with short names like rc +src/net/sf/freecol/common/resources/ResourceMapping.java:194: Parameter 'rc' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:214: Local variable 'result' could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:226: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:230: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:230: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:241: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:241: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:245: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:245: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:255: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:259: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:259: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:263: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:263: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:267: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:267: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:271: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:271: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:275: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:275: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:279: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:279: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:283: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:283: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/ResourceMapping.java:293: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:294: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:295: Avoid variables with short names like k +src/net/sf/freecol/common/resources/ResourceMapping.java:304: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:305: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:305: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:305: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:306: Avoid variables with short names like k +src/net/sf/freecol/common/resources/ResourceMapping.java:317: Parameter 'prefix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:317: Parameter 'suffix' is not assigned and could be declared final +src/net/sf/freecol/common/resources/ResourceMapping.java:318: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:318: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:318: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/ResourceMapping.java:319: Avoid variables with short names like k +src/net/sf/freecol/common/resources/SZAResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/SZAResource.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/resources/SZAResource.java:38: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/SZAResource.java:40: Avoid excessively long variable names like scaledSzAnimations +src/net/sf/freecol/common/resources/SZAResource.java:40: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/common/resources/SZAResource.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/SZAResource.java:40: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/SZAResource.java:42: Avoid using redundant field initializer for 'szAnimation' +src/net/sf/freecol/common/resources/SZAResource.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/SZAResource.java:42: Use of modifier volatile is not recommended. +src/net/sf/freecol/common/resources/SZAResource.java:42: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/SZAResource.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/SZAResource.java:43: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/SZAResource.java:52: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/SZAResource.java:66: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/resources/SZAResource.java:68: There is log block not surrounded by if +src/net/sf/freecol/common/resources/SZAResource.java:84: There is log block not surrounded by if +src/net/sf/freecol/common/resources/SZAResource.java:90: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/SZAResource.java:99: Parameter 'scale' is not assigned and could be declared final +src/net/sf/freecol/common/resources/SZAResource.java:100: Found 'DU'-anomaly for variable 'sza' (lines '100'-'113'). +src/net/sf/freecol/common/resources/SZAResource.java:101: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/resources/SZAResource.java:102: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/SZAResource.java:104: Avoid excessively long variable names like cachedScaledVersion +src/net/sf/freecol/common/resources/SZAResource.java:107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/resources/SZAResource.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/resources/StringResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/StringResource.java:31: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/StringResource.java:31: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/StringResource.java:39: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/resources/StringResource.java:46: Local variable 'idx' could be declared final +src/net/sf/freecol/common/resources/Video.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/Video.java:30: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/resources/Video.java:30: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/Video.java:37: Parameter 'url' is not assigned and could be declared final +src/net/sf/freecol/common/resources/Video.java:42: publicMethodCommentRequirement Required +src/net/sf/freecol/common/resources/VideoResource.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/resources/VideoResource.java:33: fieldCommentRequirement Required +src/net/sf/freecol/common/resources/VideoResource.java:42: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/common/resources/VideoResource.java:42: Parameter 'resourceLocator' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:20: Possible God class (WMC=72, ATFD=17, TCC=0.03296703296703297) +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:48: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:53: The class 'OggStream' has a Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:53: The class 'OggStream' has a Modified Cyclomatic Complexity of 4 (Highest = 10). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:53: The class 'OggStream' has a Standard Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:56: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:59: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:61: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:62: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:63: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:64: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:65: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:66: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:67: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:68: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:70: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:73: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:75: Avoid using redundant field initializer for 'bufCount' +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:75: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:75: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:77: Avoid using redundant field initializer for 'offset' +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:77: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:80: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:81: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:81: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:84: Avoid using redundant field initializer for 'inputStream' +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:84: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:84: Private field 'inputStream' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:84: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:87: Parameter 'inputStream' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:87: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:90: Local variable 'err' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:91: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:102: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:109: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:124: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:125: Avoid variables with short names like b +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:125: Local variable 'b' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:126: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:126: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:130: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:130: Parameter 'buf' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:130: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:134: Comment is too large: Too many lines +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:143: Avoid reassigning parameters such as 'n' +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:143: Avoid variables with short names like n +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:143: Parameter 'buf' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:144: Avoid variables with short names like wr +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:144: Found 'DU'-anomaly for variable 'wr' (lines '144'-'162'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:144: Found 'DU'-anomaly for variable 'wrOffset' (lines '144'-'162'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:144: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:147: Local variable 'ret' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:148: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:149: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:153: Avoid variables with short names like rd +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:153: Local variable 'rd' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:153: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:153: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:161: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:161: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:171: Avoid reassigning parameters such as 'n' +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:171: Avoid variables with short names like n +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:172: Avoid variables with short names like wr +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:172: Found 'DU'-anomaly for variable 'wr' (lines '172'-'188'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:175: Local variable 'ret' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:176: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:177: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:181: Avoid variables with short names like rd +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:181: Local variable 'rd' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:181: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:181: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:195: Document empty method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:195: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:205: The method 'getHeader' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:205: The method 'getHeader' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:205: The method 'getHeader' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:225: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:229: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:230: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:234: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:239: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:239: Avoid assignments in operands +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:239: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:239: Found 'DD'-anomaly for variable 'input' (lines '239'-'254'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:239: Found 'DU'-anomaly for variable 'input' (lines '239'-'263'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:242: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:251: Found 'DU'-anomaly for variable 'packet' (lines '251'-'263'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:254: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:254: Avoid assignments in operands +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:254: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:254: Found 'DU'-anomaly for variable 'input' (lines '254'-'263'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:257: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:271: Found 'DD'-anomaly for variable 'count' (lines '271'-'274'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:273: Local variable 'idx' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:274: Found 'DU'-anomaly for variable 'count' (lines '274'-'280'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:276: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:276: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:278: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:279: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:279: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:279: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:292: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:292: Avoid assignments in operands +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:292: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:292: Found 'DU'-anomaly for variable 'input' (lines '292'-'301'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:296: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:308: Avoid variables with short names like is +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:308: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:310: Avoid unused local variables such as 'packet'. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:310: Found 'DD'-anomaly for variable 'packet' (lines '310'-'326'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:310: Found 'DU'-anomaly for variable 'packet' (lines '310'-'337'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:321: Avoid variables with short names like n +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:321: Local variable 'n' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:322: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:324: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:324: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:326: Found 'DU'-anomaly for variable 'packet' (lines '326'-'337'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:329: Avoid assignments in operands +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:329: Found 'DU'-anomaly for variable 'err' (lines '329'-'337'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:330: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:330: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:330: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:345: Parameter 'samples' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:346: Local variable 'range' could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:346: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:346: Useless parentheses. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:348: Found 'DD'-anomaly for variable 'sampleIndex' (lines '348'-'348'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:348: Found 'DU'-anomaly for variable 'sampleIndex' (lines '348'-'363'). +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:353: Avoid using Literals in Conditional Statements +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:353: Avoid using if...else statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:354: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:373: Avoid using redundant field initializer for 'os' +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:373: Avoid variables with short names like os +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:373: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:373: Private field 'os' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:373: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:381: Avoid variables with short names like os +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:381: Parameter 'os' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:387: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:397: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:402: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:407: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:407: Parameter 'buf' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:407: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:411: Avoid variables with short names like n +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:411: Parameter 'buf' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:411: Parameter 'n' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:411: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:416: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:421: Avoid variables with short names like n +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:421: Parameter 'n' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:421: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:426: Parameter 'readLimit' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:426: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:431: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:436: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:445: Avoid unnecessary constructors - the compiler will generate these for you +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:445: Document empty constructor +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:455: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/sound/OggVorbisDecoderFactory.java:456: Local variable 'fis' could be declared final +src/net/sf/freecol/common/sound/Playlist.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/sound/Playlist.java:30: The class 'Playlist' has a Cyclomatic Complexity of 8 (Highest = 25). +src/net/sf/freecol/common/sound/Playlist.java:30: The class 'Playlist' has a Modified Cyclomatic Complexity of 6 (Highest = 23). +src/net/sf/freecol/common/sound/Playlist.java:30: The class 'Playlist' has a Standard Cyclomatic Complexity of 7 (Highest = 24). +src/net/sf/freecol/common/sound/Playlist.java:45: Comment is too large: Line too long +src/net/sf/freecol/common/sound/Playlist.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/Playlist.java:47: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/Playlist.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/Playlist.java:48: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/Playlist.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/Playlist.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/Playlist.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/Playlist.java:50: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/Playlist.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/Playlist.java:51: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/Playlist.java:57: Comment is too large: Line too long +src/net/sf/freecol/common/sound/Playlist.java:59: Parameter 'soundFiles' is not assigned and could be declared final +src/net/sf/freecol/common/sound/Playlist.java:75: Comment is too large: Line too long +src/net/sf/freecol/common/sound/Playlist.java:76: Comment is too large: Line too long +src/net/sf/freecol/common/sound/Playlist.java:77: Comment is too large: Line too long +src/net/sf/freecol/common/sound/Playlist.java:79: Parameter 'pickMode' is not assigned and could be declared final +src/net/sf/freecol/common/sound/Playlist.java:79: Parameter 'repeatMode' is not assigned and could be declared final +src/net/sf/freecol/common/sound/Playlist.java:79: Parameter 'soundFiles' is not assigned and could be declared final +src/net/sf/freecol/common/sound/Playlist.java:79: The user-supplied array 'soundFiles' is stored directly. +src/net/sf/freecol/common/sound/Playlist.java:107: Parameter 'repeatMode' is not assigned and could be declared final +src/net/sf/freecol/common/sound/Playlist.java:118: Parameter 'pickMode' is not assigned and could be declared final +src/net/sf/freecol/common/sound/Playlist.java:128: The method 'next' has a Cyclomatic Complexity of 25. +src/net/sf/freecol/common/sound/Playlist.java:128: The method 'next' has a Modified Cyclomatic Complexity of 23. +src/net/sf/freecol/common/sound/Playlist.java:128: The method 'next' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/common/sound/Playlist.java:129: Avoid empty if statements +src/net/sf/freecol/common/sound/Playlist.java:129: Avoid empty if statements +src/net/sf/freecol/common/sound/Playlist.java:148: Avoid empty if statements +src/net/sf/freecol/common/sound/Playlist.java:148: Avoid empty if statements +src/net/sf/freecol/common/sound/Playlist.java:152: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/common/sound/Playlist.java:165: Avoid variables with short names like i +src/net/sf/freecol/common/sound/Playlist.java:172: Found 'DU'-anomaly for variable 'tmp' (lines '172'-'224'). +src/net/sf/freecol/common/sound/Playlist.java:179: Found 'DU'-anomaly for variable 'tmp' (lines '179'-'224'). +src/net/sf/freecol/common/sound/Playlist.java:219: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:219: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:219: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:219: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:220: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/Playlist.java:232: The method 'hasNext' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/sound/Playlist.java:235: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/Playlist.java:238: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/Playlist.java:241: Avoid unnecessary if..then..else statements when returning booleans +src/net/sf/freecol/common/sound/Playlist.java:241: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:241: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:241: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:241: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:241: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:241: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:242: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:242: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:242: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:242: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:242: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:242: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:243: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:243: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:243: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:243: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:243: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:243: Useless parentheses. +src/net/sf/freecol/common/sound/Playlist.java:244: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/Playlist.java:247: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/Playlist.java:252: Avoid unnecessary if..then..else statements when returning booleans +src/net/sf/freecol/common/sound/Playlist.java:253: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/Playlist.java:256: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/SoundPlayer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/sound/SoundPlayer.java:47: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/sound/SoundPlayer.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/sound/SoundPlayer.java:49: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:51: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:52: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/SoundPlayer.java:53: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:62: Parameter 'mixerOption' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:63: Parameter 'volumeOption' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:68: Avoid variables with short names like e +src/net/sf/freecol/common/sound/SoundPlayer.java:72: Avoid variables with short names like e +src/net/sf/freecol/common/sound/SoundPlayer.java:86: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:87: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/common/sound/SoundPlayer.java:88: Avoid variables with short names like in +src/net/sf/freecol/common/sound/SoundPlayer.java:89: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/sound/SoundPlayer.java:111: Avoid variables with short names like mw +src/net/sf/freecol/common/sound/SoundPlayer.java:111: Parameter 'mw' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:114: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/sound/SoundPlayer.java:116: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/sound/SoundPlayer.java:129: Parameter 'volume' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:138: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:139: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/SoundPlayer.java:143: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/sound/SoundPlayer.java:144: There is log block not surrounded by if +src/net/sf/freecol/common/sound/SoundPlayer.java:159: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/common/sound/SoundPlayer.java:161: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:163: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/SoundPlayer.java:163: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:165: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/SoundPlayer.java:165: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:167: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/sound/SoundPlayer.java:167: fieldCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:171: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:175: Use block level rather than method level synchronization +src/net/sf/freecol/common/sound/SoundPlayer.java:176: Call Thread.notifyAll() rather than Thread.notify() +src/net/sf/freecol/common/sound/SoundPlayer.java:179: Use block level rather than method level synchronization +src/net/sf/freecol/common/sound/SoundPlayer.java:183: Use block level rather than method level synchronization +src/net/sf/freecol/common/sound/SoundPlayer.java:183: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:187: Use block level rather than method level synchronization +src/net/sf/freecol/common/sound/SoundPlayer.java:187: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:191: Use block level rather than method level synchronization +src/net/sf/freecol/common/sound/SoundPlayer.java:191: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:195: Parameter 'ais' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:195: Use block level rather than method level synchronization +src/net/sf/freecol/common/sound/SoundPlayer.java:195: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:200: publicMethodCommentRequirement Required +src/net/sf/freecol/common/sound/SoundPlayer.java:210: Avoid variables with short names like in +src/net/sf/freecol/common/sound/SoundPlayer.java:220: Avoid variables with short names like t +src/net/sf/freecol/common/sound/SoundPlayer.java:220: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:224: Parameter 'line' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:224: Parameter 'vol' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:224: The method setVolume() has an NPath complexity of 648 +src/net/sf/freecol/common/sound/SoundPlayer.java:225: Local variable 'type' could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:226: Useless parentheses. +src/net/sf/freecol/common/sound/SoundPlayer.java:226: Useless parentheses. +src/net/sf/freecol/common/sound/SoundPlayer.java:230: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/sound/SoundPlayer.java:233: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/SoundPlayer.java:237: Found 'DU'-anomaly for variable 'control' (lines '237'-'274'). +src/net/sf/freecol/common/sound/SoundPlayer.java:259: Local variable 'min' could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:260: Local variable 'max' could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:261: Local variable 'gain' could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:261: Useless parentheses. +src/net/sf/freecol/common/sound/SoundPlayer.java:261: Useless parentheses. +src/net/sf/freecol/common/sound/SoundPlayer.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:266: There is log block not surrounded by if +src/net/sf/freecol/common/sound/SoundPlayer.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:269: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/sound/SoundPlayer.java:270: There is log block not surrounded by if +src/net/sf/freecol/common/sound/SoundPlayer.java:272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:276: Parameter 'audioFormat' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:277: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/sound/SoundPlayer.java:277: Found 'DD'-anomaly for variable 'line' (lines '277'-'285'). +src/net/sf/freecol/common/sound/SoundPlayer.java:277: Found 'DU'-anomaly for variable 'line' (lines '277'-'294'). +src/net/sf/freecol/common/sound/SoundPlayer.java:278: Local variable 'info' could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:281: There is log block not surrounded by if +src/net/sf/freecol/common/sound/SoundPlayer.java:282: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/SoundPlayer.java:286: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:287: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:289: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/sound/SoundPlayer.java:291: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/SoundPlayer.java:302: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/common/sound/SoundPlayer.java:302: Avoid variables with short names like in +src/net/sf/freecol/common/sound/SoundPlayer.java:302: Parameter 'in' is not assigned and could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:303: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/common/sound/SoundPlayer.java:303: Found 'DD'-anomaly for variable 'ret' (lines '303'-'313'). +src/net/sf/freecol/common/sound/SoundPlayer.java:303: Found 'DU'-anomaly for variable 'ret' (lines '303'-'321'). +src/net/sf/freecol/common/sound/SoundPlayer.java:305: Local variable 'line' could be declared final +src/net/sf/freecol/common/sound/SoundPlayer.java:306: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/sound/SoundPlayer.java:306: Avoid using if statements without curly braces +src/net/sf/freecol/common/sound/SoundPlayer.java:309: Avoid variables with short names like rd +src/net/sf/freecol/common/sound/SoundPlayer.java:310: Avoid assignments in operands +src/net/sf/freecol/common/sound/SoundPlayer.java:310: Found 'DU'-anomaly for variable 'rd' (lines '310'-'321'). +src/net/sf/freecol/common/sound/SoundPlayer.java:311: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/sound/SoundPlayer.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/util/Introspector.java:34: The class 'Introspector' has a Cyclomatic Complexity of 5 (Highest = 10). +src/net/sf/freecol/common/util/Introspector.java:34: The class 'Introspector' has a Modified Cyclomatic Complexity of 5 (Highest = 10). +src/net/sf/freecol/common/util/Introspector.java:34: The class 'Introspector' has a Standard Cyclomatic Complexity of 5 (Highest = 10). +src/net/sf/freecol/common/util/Introspector.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/util/Introspector.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/util/Introspector.java:49: Parameter 'field' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:49: Parameter 'theClass' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:64: Local variable 'methodName' could be declared final +src/net/sf/freecol/common/util/Introspector.java:64: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Introspector.java:82: Parameter 'argType' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:83: Local variable 'methodName' could be declared final +src/net/sf/freecol/common/util/Introspector.java:83: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Introspector.java:100: Parameter 'method' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:104: Found 'DU'-anomaly for variable 'ret' (lines '104'-'111'). +src/net/sf/freecol/common/util/Introspector.java:105: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/common/util/Introspector.java:120: Parameter 'argType' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:125: Found 'DU'-anomaly for variable 'method' (lines '125'-'139'). +src/net/sf/freecol/common/util/Introspector.java:132: Found 'DU'-anomaly for variable 'method' (lines '132'-'139'). +src/net/sf/freecol/common/util/Introspector.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Introspector.java:141: Comment is too large: Too many lines +src/net/sf/freecol/common/util/Introspector.java:150: Avoid reassigning parameters such as 'argType' +src/net/sf/freecol/common/util/Introspector.java:150: Avoid reassigning parameters such as 'argType' +src/net/sf/freecol/common/util/Introspector.java:150: Avoid reassigning parameters such as 'argType' +src/net/sf/freecol/common/util/Introspector.java:150: Avoid reassigning parameters such as 'argType' +src/net/sf/freecol/common/util/Introspector.java:150: Avoid reassigning parameters such as 'argType' +src/net/sf/freecol/common/util/Introspector.java:150: The method 'getFromStringConverter' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/common/util/Introspector.java:150: The method 'getFromStringConverter' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/common/util/Introspector.java:150: The method 'getFromStringConverter' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/common/util/Introspector.java:155: Found 'DU'-anomaly for variable 'method' (lines '155'-'183'). +src/net/sf/freecol/common/util/Introspector.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Introspector.java:176: Found 'DU'-anomaly for variable 'method' (lines '176'-'183'). +src/net/sf/freecol/common/util/Introspector.java:193: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:194: Local variable 'getMethod' could be declared final +src/net/sf/freecol/common/util/Introspector.java:195: Local variable 'fieldType' could be declared final +src/net/sf/freecol/common/util/Introspector.java:199: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Introspector.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:206: Found 'DD'-anomaly for variable 'result' (lines '206'-'208'). +src/net/sf/freecol/common/util/Introspector.java:208: Found 'DU'-anomaly for variable 'result' (lines '208'-'233'). +src/net/sf/freecol/common/util/Introspector.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:214: Local variable 'convertMethod' could be declared final +src/net/sf/freecol/common/util/Introspector.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:217: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Introspector.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:242: Parameter 'obj' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:242: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:243: Local variable 'getMethod' could be declared final +src/net/sf/freecol/common/util/Introspector.java:244: Local variable 'fieldType' could be declared final +src/net/sf/freecol/common/util/Introspector.java:245: Found 'DU'-anomaly for variable 'setMethod' (lines '245'-'285'). +src/net/sf/freecol/common/util/Introspector.java:245: Local variable 'setMethod' could be declared final +src/net/sf/freecol/common/util/Introspector.java:249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:256: Local variable 'convertMethod' could be declared final +src/net/sf/freecol/common/util/Introspector.java:257: Found 'DD'-anomaly for variable 'result' (lines '257'-'261'). +src/net/sf/freecol/common/util/Introspector.java:257: Found 'DD'-anomaly for variable 'result' (lines '257'-'270'). +src/net/sf/freecol/common/util/Introspector.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:261: Found 'DU'-anomaly for variable 'result' (lines '261'-'285'). +src/net/sf/freecol/common/util/Introspector.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:270: Found 'DU'-anomaly for variable 'result' (lines '270'-'285'). +src/net/sf/freecol/common/util/Introspector.java:270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:281: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:288: Comment is too large: Too many lines +src/net/sf/freecol/common/util/Introspector.java:298: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:298: Parameter 'types' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:299: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/util/Introspector.java:299: Parameter 'params' is not assigned and could be declared final +src/net/sf/freecol/common/util/Introspector.java:302: Found 'DU'-anomaly for variable 'messageClass' (lines '302'-'323'). +src/net/sf/freecol/common/util/Introspector.java:308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Introspector.java:310: Avoid variables with short names like p +src/net/sf/freecol/common/util/Introspector.java:311: Avoid using for statements without curly braces +src/net/sf/freecol/common/util/Introspector.java:311: Local variable 'type' could be declared final +src/net/sf/freecol/common/util/Introspector.java:311: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/util/Introspector.java:312: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/common/util/Introspector.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/LogBuilder.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/util/LogBuilder.java:35: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/util/LogBuilder.java:38: Avoid variables with short names like sb +src/net/sf/freecol/common/util/LogBuilder.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/util/LogBuilder.java:38: StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). +src/net/sf/freecol/common/util/LogBuilder.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/common/util/LogBuilder.java:49: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:50: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/util/LogBuilder.java:50: Useless parentheses. +src/net/sf/freecol/common/util/LogBuilder.java:50: Useless parentheses. +src/net/sf/freecol/common/util/LogBuilder.java:59: Avoid variables with short names like o +src/net/sf/freecol/common/util/LogBuilder.java:59: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:61: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/LogBuilder.java:63: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/LogBuilder.java:73: Avoid variables with short names like sb +src/net/sf/freecol/common/util/LogBuilder.java:73: Found 'UR'-anomaly for variable 'o' (lines '73'-'75'). +src/net/sf/freecol/common/util/LogBuilder.java:73: Found 'UR'-anomaly for variable 'o2' (lines '73'-'77'). +src/net/sf/freecol/common/util/LogBuilder.java:73: Parameter 'objects' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:73: Parameter 'sb' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:74: Local variable 'o' could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:76: Local variable 'o2' could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:90: Parameter 'objects' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:91: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:100: Avoid variables with short names like c +src/net/sf/freecol/common/util/LogBuilder.java:100: Found 'UR'-anomaly for variable 't' (lines '100'-'102'). +src/net/sf/freecol/common/util/LogBuilder.java:100: Parameter 'c' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:100: Parameter 'delim' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:102: Avoid using for statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:102: Local variable 't' could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:103: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:111: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:119: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:120: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:140: Parameter 'objects' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:141: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/LogBuilder.java:141: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:142: Avoid variables with short names like p +src/net/sf/freecol/common/util/LogBuilder.java:142: Local variable 'p' could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:143: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/LogBuilder.java:143: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:144: Local variable 'sb2' could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:157: Parameter 'delim' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:169: Parameter 'level' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:169: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:191: Avoid reassigning parameters such as 'size' +src/net/sf/freecol/common/util/LogBuilder.java:191: Parameter 'objects' is not assigned and could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:192: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/LogBuilder.java:192: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:193: Local variable 'left' could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:194: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:195: Avoid variables with short names like s2 +src/net/sf/freecol/common/util/LogBuilder.java:195: Local variable 's2' could be declared final +src/net/sf/freecol/common/util/LogBuilder.java:199: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/util/LogBuilder.java:199: Avoid using for statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:201: Avoid using for statements without curly braces +src/net/sf/freecol/common/util/LogBuilder.java:203: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/RandomChoice.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/util/RandomChoice.java:34: fieldCommentRequirement Required +src/net/sf/freecol/common/util/RandomChoice.java:35: fieldCommentRequirement Required +src/net/sf/freecol/common/util/RandomChoice.java:38: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:38: Parameter 'probability' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:38: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/RandomChoice.java:43: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/RandomChoice.java:47: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/RandomChoice.java:52: Found 'UR'-anomaly for variable 'choice' (lines '52'-'58'). +src/net/sf/freecol/common/util/RandomChoice.java:52: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:53: Parameter 'probability' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:54: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/RandomChoice.java:54: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/RandomChoice.java:56: Found 'DU'-anomaly for variable 'total' (lines '56'-'62'). +src/net/sf/freecol/common/util/RandomChoice.java:57: Local variable 'choice' could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:59: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/RandomChoice.java:59: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/RandomChoice.java:61: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/RandomChoice.java:61: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/RandomChoice.java:64: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:64: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/RandomChoice.java:65: Avoid variables with short names like c +src/net/sf/freecol/common/util/RandomChoice.java:65: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/RandomChoice.java:65: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/RandomChoice.java:68: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:68: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:68: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/RandomChoice.java:69: Parameter 'input' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:70: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomChoice.java:71: Avoid variables with short names like n +src/net/sf/freecol/common/util/RandomChoice.java:72: Useless parentheses. +src/net/sf/freecol/common/util/RandomChoice.java:72: Useless parentheses. +src/net/sf/freecol/common/util/RandomChoice.java:73: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/common/util/RandomChoice.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/RandomChoice.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/RandomUtils.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/util/RandomUtils.java:33: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/util/RandomUtils.java:35: Comment is too large: Too many lines +src/net/sf/freecol/common/util/RandomUtils.java:44: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:44: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:44: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:45: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:46: Local variable 'ret' could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:48: There is log block not surrounded by if +src/net/sf/freecol/common/util/RandomUtils.java:53: Comment is too large: Too many lines +src/net/sf/freecol/common/util/RandomUtils.java:63: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:63: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:63: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:64: Avoid variables with short names like n +src/net/sf/freecol/common/util/RandomUtils.java:64: Parameter 'n' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:64: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:65: Found 'DD'-anomaly for variable 'ret' (lines '65'-'66'). +src/net/sf/freecol/common/util/RandomUtils.java:66: Avoid using for statements without curly braces +src/net/sf/freecol/common/util/RandomUtils.java:66: Found 'DD'-anomaly for variable 'ret' (lines '66'-'66'). +src/net/sf/freecol/common/util/RandomUtils.java:68: Avoid variables with short names like sb +src/net/sf/freecol/common/util/RandomUtils.java:68: Local variable 'sb' could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:70: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/common/util/RandomUtils.java:70: Avoid using for statements without curly braces +src/net/sf/freecol/common/util/RandomUtils.java:85: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:85: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:86: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:87: Local variable 'ret' could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:102: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:102: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:103: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:104: Local variable 'ret' could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:111: Comment is too large: Too many lines +src/net/sf/freecol/common/util/RandomUtils.java:120: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:120: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:121: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:121: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/RandomUtils.java:126: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/RandomUtils.java:141: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:141: Parameter 'logger' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:142: Parameter 'list' is not assigned and could be declared final +src/net/sf/freecol/common/util/RandomUtils.java:142: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/util/StringUtils.java:31: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/util/StringUtils.java:31: The class 'StringUtils' has a Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/util/StringUtils.java:31: The class 'StringUtils' has a Modified Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/util/StringUtils.java:31: The class 'StringUtils' has a Standard Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/common/util/StringUtils.java:33: Comment is too large: Too many lines +src/net/sf/freecol/common/util/StringUtils.java:43: Parameter 'delimiter' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:43: Parameter 'strings' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:45: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/StringUtils.java:47: Local variable 'result' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:64: Parameter 'delimiter' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:64: Parameter 'strings' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:65: This call to Collection.toArray() may be optimizable +src/net/sf/freecol/common/util/StringUtils.java:75: Parameter 'maxLength' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:75: Parameter 'str' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:76: Useless parentheses. +src/net/sf/freecol/common/util/StringUtils.java:76: Useless parentheses. +src/net/sf/freecol/common/util/StringUtils.java:79: Comment is too large: Too many lines +src/net/sf/freecol/common/util/StringUtils.java:88: Avoid variables with short names like s +src/net/sf/freecol/common/util/StringUtils.java:88: Parameter 'delim' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:88: Parameter 's' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:89: Local variable 'last' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:90: Useless parentheses. +src/net/sf/freecol/common/util/StringUtils.java:90: Useless parentheses. +src/net/sf/freecol/common/util/StringUtils.java:94: Comment is too large: Too many lines +src/net/sf/freecol/common/util/StringUtils.java:103: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/StringUtils.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:106: Avoid variables with short names like sb +src/net/sf/freecol/common/util/StringUtils.java:106: Local variable 'sb' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:107: Found 'DD'-anomaly for variable 'idx' (lines '107'-'109'). +src/net/sf/freecol/common/util/StringUtils.java:107: Found 'DU'-anomaly for variable 'from' (lines '107'-'123'). +src/net/sf/freecol/common/util/StringUtils.java:107: Found 'DU'-anomaly for variable 'idx' (lines '107'-'123'). +src/net/sf/freecol/common/util/StringUtils.java:107: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/util/StringUtils.java:109: Avoid assignments in operands +src/net/sf/freecol/common/util/StringUtils.java:109: Found 'DU'-anomaly for variable 'idx' (lines '109'-'123'). +src/net/sf/freecol/common/util/StringUtils.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:115: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/StringUtils.java:116: Avoid variables with short names like ch +src/net/sf/freecol/common/util/StringUtils.java:116: Local variable 'ch' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:119: Found 'DU'-anomaly for variable 'from' (lines '119'-'123'). +src/net/sf/freecol/common/util/StringUtils.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:132: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:144: Parameter 'delim' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:144: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:145: Local variable 'center' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:148: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/StringUtils.java:150: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/StringUtils.java:156: Comment is too large: Too many lines +src/net/sf/freecol/common/util/StringUtils.java:167: Parameter 'delim' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:167: Parameter 'text' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:167: The method 'splitText' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/common/util/StringUtils.java:167: The method 'splitText' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/common/util/StringUtils.java:167: The method 'splitText' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/common/util/StringUtils.java:167: The method splitText() has an NPath complexity of 811 +src/net/sf/freecol/common/util/StringUtils.java:168: Parameter 'fontMetrics' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:168: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/common/util/StringUtils.java:169: Local variable 'result' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:171: Avoid variables with short names like i +src/net/sf/freecol/common/util/StringUtils.java:171: Found 'DD'-anomaly for variable 'start' (lines '171'-'179'). +src/net/sf/freecol/common/util/StringUtils.java:171: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/util/StringUtils.java:173: Avoid variables with short names like d +src/net/sf/freecol/common/util/StringUtils.java:176: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/StringUtils.java:178: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/StringUtils.java:181: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/StringUtils.java:183: Avoid variables with short names like s +src/net/sf/freecol/common/util/StringUtils.java:183: Local variable 's' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:184: Avoid variables with short names like t +src/net/sf/freecol/common/util/StringUtils.java:184: Local variable 't' could be declared final +src/net/sf/freecol/common/util/StringUtils.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:184: Useless parentheses. +src/net/sf/freecol/common/util/StringUtils.java:184: Useless parentheses. +src/net/sf/freecol/common/util/StringUtils.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:190: Found 'DU'-anomaly for variable 'top' (lines '190'-'202'). +src/net/sf/freecol/common/util/StringUtils.java:193: Found 'DU'-anomaly for variable 'top' (lines '193'-'202'). +src/net/sf/freecol/common/util/StringUtils.java:196: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/StringUtils.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/StringUtils.java:199: Found 'DU'-anomaly for variable 'd' (lines '199'-'202'). +src/net/sf/freecol/common/util/Utils.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/util/Utils.java:42: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/common/util/Utils.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/common/util/Utils.java:44: fieldCommentRequirement Required +src/net/sf/freecol/common/util/Utils.java:58: Parameter 'one' is not assigned and could be declared final +src/net/sf/freecol/common/util/Utils.java:58: Parameter 'two' is not assigned and could be declared final +src/net/sf/freecol/common/util/Utils.java:59: Useless parentheses. +src/net/sf/freecol/common/util/Utils.java:59: Useless parentheses. +src/net/sf/freecol/common/util/Utils.java:68: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/common/util/Utils.java:79: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/common/util/Utils.java:79: Use block level rather than method level synchronization +src/net/sf/freecol/common/util/Utils.java:80: Local variable 'bos' could be declared final +src/net/sf/freecol/common/util/Utils.java:82: Local variable 'oos' could be declared final +src/net/sf/freecol/common/util/Utils.java:88: Local variable 'bytes' could be declared final +src/net/sf/freecol/common/util/Utils.java:89: Avoid variables with short names like sb +src/net/sf/freecol/common/util/Utils.java:89: Local variable 'sb' could be declared final +src/net/sf/freecol/common/util/Utils.java:90: Local variable 'b' could be declared final +src/net/sf/freecol/common/util/Utils.java:103: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/common/util/Utils.java:103: Use block level rather than method level synchronization +src/net/sf/freecol/common/util/Utils.java:104: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Utils.java:104: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/Utils.java:106: Found 'DU'-anomaly for variable 'pos' (lines '106'-'120'). +src/net/sf/freecol/common/util/Utils.java:112: Local variable 'bis' could be declared final +src/net/sf/freecol/common/util/Utils.java:114: Local variable 'ois' could be declared final +src/net/sf/freecol/common/util/Utils.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Utils.java:128: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/common/util/Utils.java:131: Found 'DU'-anomaly for variable 'fos' (lines '131'-'151'). +src/net/sf/freecol/common/util/Utils.java:133: There is log block not surrounded by if +src/net/sf/freecol/common/util/Utils.java:135: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Utils.java:141: There is log block not surrounded by if +src/net/sf/freecol/common/util/Utils.java:148: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:1: Comment is too large: Too many lines +src/net/sf/freecol/common/util/Xml.java:44: Avoid short class names like Xml +src/net/sf/freecol/common/util/Xml.java:44: This class has too many methods, consider refactoring it. +src/net/sf/freecol/common/util/Xml.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:51: Local variable 'factory' could be declared final +src/net/sf/freecol/common/util/Xml.java:52: Local variable 'builder' could be declared final +src/net/sf/freecol/common/util/Xml.java:61: Parameter 'string' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:61: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:67: Parameter 'stream' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:67: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:73: Parameter 'document' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:73: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:75: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:79: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:79: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:79: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:81: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:85: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:85: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:85: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:87: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:90: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:90: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:90: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:90: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:92: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:98: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:98: Parameter 'separator' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:98: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:98: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:100: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:103: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:103: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:103: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:108: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/util/Xml.java:108: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:108: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:108: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:108: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:110: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:116: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:116: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:116: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:121: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:121: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:121: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:121: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:123: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:136: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:136: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:136: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:141: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:141: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:141: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:141: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:143: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:149: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:149: Parameter 'separator' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:149: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:149: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:150: Local variable 'array' could be declared final +src/net/sf/freecol/common/util/Xml.java:151: Found 'DD'-anomaly for variable 'output' (lines '151'-'153'). +src/net/sf/freecol/common/util/Xml.java:153: Found 'DD'-anomaly for variable 'output' (lines '153'-'153'). +src/net/sf/freecol/common/util/Xml.java:153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:158: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:158: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:158: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:163: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/util/Xml.java:163: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:163: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:163: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:163: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:165: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:172: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:172: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:172: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:177: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:177: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:177: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:177: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:179: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:185: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:185: Parameter 'separator' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:185: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:185: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:186: Local variable 'array' could be declared final +src/net/sf/freecol/common/util/Xml.java:191: Found 'DD'-anomaly for variable 'output' (lines '191'-'193'). +src/net/sf/freecol/common/util/Xml.java:193: Found 'DD'-anomaly for variable 'output' (lines '193'-'193'). +src/net/sf/freecol/common/util/Xml.java:193: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/common/util/Xml.java:198: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:198: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:198: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:203: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/common/util/Xml.java:203: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:203: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:203: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:203: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:205: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:211: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:211: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:211: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:216: Parameter 'attributeName' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:216: Parameter 'otherwise' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:216: Parameter 'xmlElement' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:216: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:218: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:224: Parameter 'method' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:224: Parameter 'xml' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:224: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:226: Local variable 'childList' could be declared final +src/net/sf/freecol/common/util/Xml.java:228: Local variable 'nc' could be declared final +src/net/sf/freecol/common/util/Xml.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Xml.java:228: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/common/util/Xml.java:229: Local variable 'child' could be declared final +src/net/sf/freecol/common/util/Xml.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/common/util/Xml.java:241: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:243: Local variable 'factory' could be declared final +src/net/sf/freecol/common/util/Xml.java:246: Local variable 'builder' could be declared final +src/net/sf/freecol/common/util/Xml.java:254: Parameter 'truthAsString' is not assigned and could be declared final +src/net/sf/freecol/common/util/Xml.java:256: Avoid using if statements without curly braces +src/net/sf/freecol/common/util/Xml.java:257: Switch statements should have a default label +src/net/sf/freecol/common/util/Xml.java:260: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/common/util/Xml.java:264: Avoid throwing raw exception types. +src/net/sf/freecol/common/util/Xml.java:276: headerCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:278: Avoid modifiers which are implied by the context +src/net/sf/freecol/common/util/Xml.java:278: publicMethodCommentRequirement Required +src/net/sf/freecol/common/util/Xml.java:282: Comment is too large: Too many lines +src/net/sf/freecol/common/util/Xml.java:294: Parameter 'cause' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:1: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaItem.java:33: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/metaserver/MetaItem.java:33: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaItem.java:35: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/metaserver/MetaItem.java:35: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaItem.java:38: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaItem.java:50: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:50: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:50: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:50: Parameter 'slotsAvailable' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:51: Parameter 'currentlyPlaying' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:51: Parameter 'isGameStarted' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:51: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:52: Parameter 'gameState' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:58: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaItem.java:69: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:69: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:69: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:69: Parameter 'slotsAvailable' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:70: Parameter 'currentlyPlaying' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:70: Parameter 'isGameStarted' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:70: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaItem.java:71: Parameter 'gameState' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:1: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaRegister.java:38: Each class should declare at least one constructor +src/net/sf/freecol/metaserver/MetaRegister.java:40: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/metaserver/MetaRegister.java:40: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaRegister.java:42: Avoid using implementation types like 'ArrayList'; use the interface instead +src/net/sf/freecol/metaserver/MetaRegister.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/metaserver/MetaRegister.java:42: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaRegister.java:53: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:53: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:54: Local variable 'index' could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:56: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/metaserver/MetaRegister.java:71: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:71: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaRegister.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaRegister.java:73: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaRegister.java:74: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/metaserver/MetaRegister.java:85: Use block level rather than method level synchronization +src/net/sf/freecol/metaserver/MetaRegister.java:88: Found 'DU'-anomaly for variable 'time' (lines '88'-'95'). +src/net/sf/freecol/metaserver/MetaRegister.java:88: Local variable 'time' could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:90: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaRegister.java:91: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:91: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:98: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaRegister.java:110: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:110: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:110: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:110: Parameter 'slotsAvailable' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:110: Use block level rather than method level synchronization +src/net/sf/freecol/metaserver/MetaRegister.java:111: Parameter 'currentlyPlaying' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:111: Parameter 'gameState' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:111: Parameter 'isGameStarted' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:111: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:113: Avoid variables with short names like mi +src/net/sf/freecol/metaserver/MetaRegister.java:113: Local variable 'mi' could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:117: Avoid variables with short names like mc +src/net/sf/freecol/metaserver/MetaRegister.java:127: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:127: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:135: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaRegister.java:147: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:147: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:147: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:147: Parameter 'slotsAvailable' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:147: Use block level rather than method level synchronization +src/net/sf/freecol/metaserver/MetaRegister.java:148: Parameter 'currentlyPlaying' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:148: Parameter 'gameState' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:148: Parameter 'isGameStarted' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:148: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:150: Avoid variables with short names like mi +src/net/sf/freecol/metaserver/MetaRegister.java:150: Local variable 'mi' could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:165: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:165: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:165: Use block level rather than method level synchronization +src/net/sf/freecol/metaserver/MetaRegister.java:166: Local variable 'index' could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:169: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:169: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:171: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:171: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:181: Found 'UR'-anomaly for variable 'item' (lines '181'-'184'). +src/net/sf/freecol/metaserver/MetaRegister.java:181: Use block level rather than method level synchronization +src/net/sf/freecol/metaserver/MetaRegister.java:182: Local variable 'element' could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:183: Local variable 'item' could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/metaserver/MetaRegister.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/metaserver/MetaRegister.java:190: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaRegister.java:206: Avoid variables with short names like mi +src/net/sf/freecol/metaserver/MetaRegister.java:206: Parameter 'address' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:206: Parameter 'mi' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:206: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:206: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:206: Parameter 'slotsAvailable' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:207: Parameter 'currentlyPlaying' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:207: Parameter 'gameState' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:207: Parameter 'isGameStarted' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:207: Parameter 'version' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaRegister.java:209: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaRegister.java:209: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaServer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/MetaServer.java:44: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/metaserver/MetaServer.java:46: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/metaserver/MetaServer.java:46: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaServer.java:48: Avoid excessively long variable names like REMOVE_DEAD_SERVERS_INTERVAL +src/net/sf/freecol/metaserver/MetaServer.java:48: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaServer.java:50: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaServer.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/metaserver/MetaServer.java:56: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/metaserver/MetaServer.java:56: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/metaserver/MetaServer.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/metaserver/MetaServer.java:67: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/MetaServer.java:75: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/metaserver/MetaServer.java:75: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaServer.java:76: Found 'DD'-anomaly for variable 'port' (lines '76'-'78'). +src/net/sf/freecol/metaserver/MetaServer.java:78: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaServer.java:80: System.out.println is used +src/net/sf/freecol/metaserver/MetaServer.java:81: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/metaserver/MetaServer.java:84: Found 'DD'-anomaly for variable 'metaServer' (lines '84'-'86'). +src/net/sf/freecol/metaserver/MetaServer.java:89: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/metaserver/MetaServer.java:102: It is a good practice to call super() in a constructor +src/net/sf/freecol/metaserver/MetaServer.java:102: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaServer.java:105: Avoid variables with short names like mr +src/net/sf/freecol/metaserver/MetaServer.java:109: Avoid variables with short names like t +src/net/sf/freecol/metaserver/MetaServer.java:109: Local variable 't' could be declared final +src/net/sf/freecol/metaserver/MetaServer.java:112: publicMethodCommentRequirement Required +src/net/sf/freecol/metaserver/MetaServer.java:115: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/metaserver/MetaServer.java:131: Found 'DD'-anomaly for variable 'clientSocket' (lines '131'-'133'). +src/net/sf/freecol/metaserver/MetaServer.java:134: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaServer.java:134: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaServer.java:134: There is log block not surrounded by if +src/net/sf/freecol/metaserver/MetaServer.java:135: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaServer.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/metaserver/MetaServer.java:136: Avoid instantiating new objects inside loops +src/net/sf/freecol/metaserver/MetaServer.java:136: Local variable 'connection' could be declared final +src/net/sf/freecol/metaserver/MetaServer.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/MetaServer.java:185: Avoid variables with short names like c +src/net/sf/freecol/metaserver/MetaServer.java:186: Avoid assignments in operands +src/net/sf/freecol/metaserver/MetaServer.java:186: Avoid using while statements without curly braces +src/net/sf/freecol/metaserver/MetaServer.java:186: Found 'DU'-anomaly for variable 'c' (lines '186'-'188'). +src/net/sf/freecol/metaserver/MetaServer.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/metaserver/MetaServer.java:197: Parameter 'socket' is not assigned and could be declared final +src/net/sf/freecol/metaserver/MetaServer.java:206: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/NetworkHandler.java:36: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/metaserver/NetworkHandler.java:36: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/NetworkHandler.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/metaserver/NetworkHandler.java:39: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/NetworkHandler.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/metaserver/NetworkHandler.java:40: fieldCommentRequirement Required +src/net/sf/freecol/metaserver/NetworkHandler.java:44: Comment is too large: Too many lines +src/net/sf/freecol/metaserver/NetworkHandler.java:53: Parameter 'metaRegister' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:53: Parameter 'metaServer' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:66: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:66: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:66: Use block level rather than method level synchronization +src/net/sf/freecol/metaserver/NetworkHandler.java:67: Found 'DD'-anomaly for variable 'reply' (lines '67'-'73'). +src/net/sf/freecol/metaserver/NetworkHandler.java:67: Found 'DD'-anomaly for variable 'reply' (lines '67'-'76'). +src/net/sf/freecol/metaserver/NetworkHandler.java:67: Found 'DD'-anomaly for variable 'reply' (lines '67'-'79'). +src/net/sf/freecol/metaserver/NetworkHandler.java:67: Found 'DD'-anomaly for variable 'reply' (lines '67'-'82'). +src/net/sf/freecol/metaserver/NetworkHandler.java:67: Found 'DD'-anomaly for variable 'reply' (lines '67'-'85'). +src/net/sf/freecol/metaserver/NetworkHandler.java:69: Local variable 'type' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:88: There is log block not surrounded by if +src/net/sf/freecol/metaserver/NetworkHandler.java:104: Avoid unused method parameters such as 'connection'. +src/net/sf/freecol/metaserver/NetworkHandler.java:104: Avoid unused method parameters such as 'element'. +src/net/sf/freecol/metaserver/NetworkHandler.java:104: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:104: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:116: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:116: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:117: Local variable 'name' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:118: Local variable 'address' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/NetworkHandler.java:118: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/NetworkHandler.java:119: Local variable 'port' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:120: Local variable 'slotsAvailable' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:121: Local variable 'currentlyPlaying' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:122: Local variable 'isGameStarted' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:123: Local variable 'version' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:124: Local variable 'gameState' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:129: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/metaserver/NetworkHandler.java:143: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:143: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:144: Local variable 'name' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:145: Local variable 'address' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/NetworkHandler.java:145: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/NetworkHandler.java:146: Local variable 'port' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:147: Local variable 'slotsAvailable' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:148: Local variable 'currentlyPlaying' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:149: Local variable 'isGameStarted' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:150: Local variable 'version' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:151: Local variable 'gameState' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:155: Avoid empty catch blocks +src/net/sf/freecol/metaserver/NetworkHandler.java:155: Avoid empty catch blocks +src/net/sf/freecol/metaserver/NetworkHandler.java:168: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:168: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:169: Local variable 'address' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/NetworkHandler.java:169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/metaserver/NetworkHandler.java:170: Local variable 'port' could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:185: Avoid unused method parameters such as 'element'. +src/net/sf/freecol/metaserver/NetworkHandler.java:185: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/metaserver/NetworkHandler.java:185: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/FreeColServer.java:20: Possible God class (WMC=133, ATFD=135, TCC=0.041628122109158186) +src/net/sf/freecol/server/FreeColServer.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/server/FreeColServer.java:105: Avoid really long classes. +src/net/sf/freecol/server/FreeColServer.java:105: The class 'FreeColServer' has a Cyclomatic Complexity of 3 (Highest = 20). +src/net/sf/freecol/server/FreeColServer.java:105: The class 'FreeColServer' has a Modified Cyclomatic Complexity of 2 (Highest = 19). +src/net/sf/freecol/server/FreeColServer.java:105: The class 'FreeColServer' has a Standard Cyclomatic Complexity of 2 (Highest = 19). +src/net/sf/freecol/server/FreeColServer.java:105: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/FreeColServer.java:105: Too many fields +src/net/sf/freecol/server/FreeColServer.java:107: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/FreeColServer.java:107: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:109: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:110: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:111: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:112: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:113: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:114: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:115: Avoid excessively long variable names like SERVER_OBJECTS_TAG +src/net/sf/freecol/server/FreeColServer.java:115: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:116: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:118: Avoid excessively long variable names like META_SERVER_UPDATE_INTERVAL +src/net/sf/freecol/server/FreeColServer.java:118: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:120: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:140: Avoid excessively long variable names like MINIMUM_SAVEGAME_VERSION +src/net/sf/freecol/server/FreeColServer.java:158: Avoid using redundant field initializer for 'publicServer' +src/net/sf/freecol/server/FreeColServer.java:167: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/FreeColServer.java:167: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:170: Avoid excessively long variable names like userConnectionHandler +src/net/sf/freecol/server/FreeColServer.java:170: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:172: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/FreeColServer.java:172: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:174: Avoid excessively long variable names like preGameInputHandler +src/net/sf/freecol/server/FreeColServer.java:174: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:176: Avoid excessively long variable names like inGameInputHandler +src/net/sf/freecol/server/FreeColServer.java:176: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:178: fieldCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:181: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/FreeColServer.java:187: Avoid using redundant field initializer for 'mapGenerator' +src/net/sf/freecol/server/FreeColServer.java:190: Avoid using redundant field initializer for 'random' +src/net/sf/freecol/server/FreeColServer.java:190: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/FreeColServer.java:193: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/FreeColServer.java:196: Avoid using redundant field initializer for 'activeUnit' +src/net/sf/freecol/server/FreeColServer.java:199: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:209: Parameter 'publicServer' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:209: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:210: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:210: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:210: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:234: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:249: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:249: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:249: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:268: Local variable 'seed' could be declared final +src/net/sf/freecol/server/FreeColServer.java:273: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/FreeColServer.java:284: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/server/FreeColServer.java:293: Parameter 'singlePlayer' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:302: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/server/FreeColServer.java:311: Parameter 'publicServer' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:329: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:339: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/FreeColServer.java:352: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:363: Parameter 'firstPort' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:364: Do not hard code the IP address +src/net/sf/freecol/server/FreeColServer.java:364: Found 'DU'-anomaly for variable 'host' (lines '364'-'392'). +src/net/sf/freecol/server/FreeColServer.java:364: Local variable 'host' could be declared final +src/net/sf/freecol/server/FreeColServer.java:364: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:364: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:365: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:366: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/FreeColServer.java:374: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:378: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/FreeColServer.java:382: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/FreeColServer.java:387: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/FreeColServer.java:387: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:421: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/FreeColServer.java:469: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:479: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:510: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:546: Parameter 'mapGenerator' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:564: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:582: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:598: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:607: Parameter 'firstTime' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:607: The method 'updateMetaServer' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/FreeColServer.java:607: The method 'updateMetaServer' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/FreeColServer.java:607: The method 'updateMetaServer' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/FreeColServer.java:607: The method updateMetaServer() has an NPath complexity of 1500 +src/net/sf/freecol/server/FreeColServer.java:608: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/FreeColServer.java:608: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:610: Avoid variables with short names like mc +src/net/sf/freecol/server/FreeColServer.java:612: Found 'DU'-anomaly for variable 'mc' (lines '612'-'665'). +src/net/sf/freecol/server/FreeColServer.java:612: Found 'DU'-anomaly for variable 'mc' (lines '612'-'665'). +src/net/sf/freecol/server/FreeColServer.java:616: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:619: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/FreeColServer.java:622: Local variable 'tag' could be declared final +src/net/sf/freecol/server/FreeColServer.java:622: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:622: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:623: Local variable 'port' could be declared final +src/net/sf/freecol/server/FreeColServer.java:623: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:624: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/FreeColServer.java:624: Local variable 'addr' could be declared final +src/net/sf/freecol/server/FreeColServer.java:625: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:625: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:625: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:625: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:626: Local variable 'nPlayers' could be declared final +src/net/sf/freecol/server/FreeColServer.java:627: Local variable 'started' could be declared final +src/net/sf/freecol/server/FreeColServer.java:629: Local variable 'reply' could be declared final +src/net/sf/freecol/server/FreeColServer.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:638: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/FreeColServer.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:640: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/FreeColServer.java:643: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:646: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/FreeColServer.java:648: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:656: Avoid variables with short names like t +src/net/sf/freecol/server/FreeColServer.java:656: Local variable 't' could be declared final +src/net/sf/freecol/server/FreeColServer.java:659: publicMethodCommentRequirement Required +src/net/sf/freecol/server/FreeColServer.java:660: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:674: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/FreeColServer.java:674: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:677: Avoid variables with short names like mc +src/net/sf/freecol/server/FreeColServer.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:681: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:682: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:682: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:682: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:684: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:688: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/FreeColServer.java:700: Found 'UR'-anomaly for variable 'player' (lines '700'-'703'). +src/net/sf/freecol/server/FreeColServer.java:701: Avoid variables with short names like n +src/net/sf/freecol/server/FreeColServer.java:701: Found 'DD'-anomaly for variable 'n' (lines '701'-'704'). +src/net/sf/freecol/server/FreeColServer.java:702: Local variable 'player' could be declared final +src/net/sf/freecol/server/FreeColServer.java:703: Avoid variables with short names like sp +src/net/sf/freecol/server/FreeColServer.java:703: Local variable 'sp' could be declared final +src/net/sf/freecol/server/FreeColServer.java:704: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:704: Found 'DD'-anomaly for variable 'n' (lines '704'-'704'). +src/net/sf/freecol/server/FreeColServer.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:714: Found 'UR'-anomaly for variable 'player' (lines '714'-'717'). +src/net/sf/freecol/server/FreeColServer.java:715: Avoid variables with short names like n +src/net/sf/freecol/server/FreeColServer.java:715: Found 'DD'-anomaly for variable 'n' (lines '715'-'718'). +src/net/sf/freecol/server/FreeColServer.java:716: Local variable 'player' could be declared final +src/net/sf/freecol/server/FreeColServer.java:717: Avoid variables with short names like sp +src/net/sf/freecol/server/FreeColServer.java:717: Local variable 'sp' could be declared final +src/net/sf/freecol/server/FreeColServer.java:718: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:718: Found 'DD'-anomaly for variable 'n' (lines '718'-'718'). +src/net/sf/freecol/server/FreeColServer.java:718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:730: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:730: Parameter 'options' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:742: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:742: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:748: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:757: Found 'UR'-anomaly for variable 'smo' (lines '757'-'816'). +src/net/sf/freecol/server/FreeColServer.java:757: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:757: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:757: Parameter 'options' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:771: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/FreeColServer.java:775: Local variable 'properties' could be declared final +src/net/sf/freecol/server/FreeColServer.java:776: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:776: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:776: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:776: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:777: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:777: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:777: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:777: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:785: Avoid variables with short names like xw +src/net/sf/freecol/server/FreeColServer.java:786: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/FreeColServer.java:790: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:790: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:815: Local variable 'smo' could be declared final +src/net/sf/freecol/server/FreeColServer.java:815: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:827: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:836: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/FreeColServer.java:841: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:855: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:866: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:866: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:867: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:868: Avoid variables with short names like g +src/net/sf/freecol/server/FreeColServer.java:868: Found 'DD'-anomaly for variable 'g' (lines '868'-'870'). +src/net/sf/freecol/server/FreeColServer.java:872: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:872: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:873: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/FreeColServer.java:874: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:879: Local variable 'startGame' could be declared final +src/net/sf/freecol/server/FreeColServer.java:881: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:881: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:887: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:901: The method 'readGame' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/server/FreeColServer.java:901: The method 'readGame' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/FreeColServer.java:901: The method 'readGame' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/FreeColServer.java:902: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:903: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:909: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:909: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:911: Found 'DD'-anomaly for variable 'game' (lines '911'-'946'). +src/net/sf/freecol/server/FreeColServer.java:911: Found 'DU'-anomaly for variable 'game' (lines '911'-'967'). +src/net/sf/freecol/server/FreeColServer.java:913: Avoid variables with short names like xr +src/net/sf/freecol/server/FreeColServer.java:918: Found 'DD'-anomaly for variable 'active' (lines '918'-'934'). +src/net/sf/freecol/server/FreeColServer.java:918: Found 'DU'-anomaly for variable 'active' (lines '918'-'967'). +src/net/sf/freecol/server/FreeColServer.java:928: Avoid variables with short names like r +src/net/sf/freecol/server/FreeColServer.java:928: Local variable 'r' could be declared final +src/net/sf/freecol/server/FreeColServer.java:934: Found 'DU'-anomaly for variable 'active' (lines '934'-'967'). +src/net/sf/freecol/server/FreeColServer.java:944: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:946: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/FreeColServer.java:948: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:950: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:951: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:952: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/FreeColServer.java:962: Avoid variables with short names like u +src/net/sf/freecol/server/FreeColServer.java:962: Local variable 'u' could be declared final +src/net/sf/freecol/server/FreeColServer.java:969: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:980: Avoid really long methods. +src/net/sf/freecol/server/FreeColServer.java:980: Found 'UR'-anomaly for variable 'is' (lines '980'-'1,001'). +src/net/sf/freecol/server/FreeColServer.java:980: Found 'UR'-anomaly for variable 'p' (lines '980'-'999'). +src/net/sf/freecol/server/FreeColServer.java:980: Found 'UR'-anomaly for variable 'player' (lines '980'-'1,066'). +src/net/sf/freecol/server/FreeColServer.java:980: Found 'UR'-anomaly for variable 'tile' (lines '980'-'1,029'). +src/net/sf/freecol/server/FreeColServer.java:980: Found 'UR'-anomaly for variable 'u' (lines '980'-'1,015'). +src/net/sf/freecol/server/FreeColServer.java:980: The method 'loadGame' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/server/FreeColServer.java:980: The method 'loadGame' has a Modified Cyclomatic Complexity of 19. +src/net/sf/freecol/server/FreeColServer.java:980: The method 'loadGame' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/server/FreeColServer.java:980: The method loadGame() has an NPath complexity of 70200 +src/net/sf/freecol/server/FreeColServer.java:981: Avoid reassigning parameters such as 'specification' +src/net/sf/freecol/server/FreeColServer.java:981: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:984: Local variable 'game' could be declared final +src/net/sf/freecol/server/FreeColServer.java:990: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:990: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:991: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:991: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:994: Local variable 'savegameVersion' could be declared final +src/net/sf/freecol/server/FreeColServer.java:996: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/FreeColServer.java:997: Local variable 'p' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1000: Local variable 'is' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1009: Local variable 'u' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1009: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1016: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:1016: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:1020: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:1020: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:1028: Local variable 'tile' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1028: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1035: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1039: Local variable 'unknown' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1053: Local variable 'aiIntegrity' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1059: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:1059: There is log block not surrounded by if +src/net/sf/freecol/server/FreeColServer.java:1060: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:1060: Useless parentheses. +src/net/sf/freecol/server/FreeColServer.java:1065: Local variable 'player' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1067: Local variable 'serverPlayer' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1068: Local variable 'theConnection' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1069: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/FreeColServer.java:1071: Local variable 'aiConnection' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1072: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/FreeColServer.java:1077: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1078: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1083: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1083: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1097: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1100: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1106: Comment is too large: Too many lines +src/net/sf/freecol/server/FreeColServer.java:1116: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1116: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1116: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1128: Found 'UR'-anomaly for variable 'entry' (lines '1,128'-'1,138'). +src/net/sf/freecol/server/FreeColServer.java:1128: Found 'UR'-anomaly for variable 'is' (lines '1,128'-'1,168'). +src/net/sf/freecol/server/FreeColServer.java:1128: Found 'UR'-anomaly for variable 'other' (lines '1,128'-'1,166'). +src/net/sf/freecol/server/FreeColServer.java:1128: Found 'UR'-anomaly for variable 'player' (lines '1,128'-'1,159'). +src/net/sf/freecol/server/FreeColServer.java:1130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1134: Local variable 'newAI' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1136: Local variable 'entry' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1138: Avoid using if statements without curly braces +src/net/sf/freecol/server/FreeColServer.java:1138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1151: Avoid variables with short names like lb +src/net/sf/freecol/server/FreeColServer.java:1151: Local variable 'lb' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1157: Found 'DU'-anomaly for variable 'random' (lines '1,157'-'1,183'). +src/net/sf/freecol/server/FreeColServer.java:1157: Local variable 'random' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1158: Local variable 'player' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1163: Found 'DD'-anomaly for variable 'alarm' (lines '1,163'-'1,163'). +src/net/sf/freecol/server/FreeColServer.java:1163: Found 'DU'-anomaly for variable 'alarm' (lines '1,163'-'1,183'). +src/net/sf/freecol/server/FreeColServer.java:1163: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/FreeColServer.java:1163: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/FreeColServer.java:1164: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/FreeColServer.java:1165: Local variable 'other' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1167: Local variable 'is' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1168: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/FreeColServer.java:1175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1193: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1194: Local variable 'theConnection' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1197: Local variable 'aiPlayer' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1200: Local variable 'aiConnection' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1219: Found 'UR'-anomaly for variable 'autosaveFile' (lines '1,219'-'1,221'). +src/net/sf/freecol/server/FreeColServer.java:1220: Local variable 'autosaveFile' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1233: Found 'UR'-anomaly for variable 'player' (lines '1,233'-'1,235'). +src/net/sf/freecol/server/FreeColServer.java:1233: Parameter 'reveal' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1234: Local variable 'player' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1234: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1235: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1240: Local variable 'fogOfWarSetting' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1240: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/FreeColServer.java:1249: Local variable 'player' could be declared final +src/net/sf/freecol/server/FreeColServer.java:1249: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1266: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1267: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1268: Avoid variables with short names like p +src/net/sf/freecol/server/FreeColServer.java:1268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/FreeColServer.java:1277: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/FreeColServer.java:1278: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/ai/AIColony.java:20: Possible God class (WMC=304, ATFD=242, TCC=0.09042553191489362) +src/net/sf/freecol/server/ai/AIColony.java:86: Avoid really long classes. +src/net/sf/freecol/server/ai/AIColony.java:86: The class 'AIColony' has a Cyclomatic Complexity of 6 (Highest = 68). +src/net/sf/freecol/server/ai/AIColony.java:86: The class 'AIColony' has a Modified Cyclomatic Complexity of 5 (Highest = 46). +src/net/sf/freecol/server/ai/AIColony.java:86: The class 'AIColony' has a Standard Cyclomatic Complexity of 5 (Highest = 46). +src/net/sf/freecol/server/ai/AIColony.java:86: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/AIColony.java:88: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/AIColony.java:88: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:90: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:102: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIColony.java:105: Avoid using redundant field initializer for 'colonyPlan' +src/net/sf/freecol/server/ai/AIColony.java:105: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIColony.java:114: Avoid excessively long variable names like tileImprovementPlans +src/net/sf/freecol/server/ai/AIColony.java:118: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIColony.java:124: Variables that are final and static should be all capitals, 'fullExport' is not all capitals. +src/net/sf/freecol/server/ai/AIColony.java:125: Variables that are final and static should be all capitals, 'partExport' is not all capitals. +src/net/sf/freecol/server/ai/AIColony.java:125: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:131: Variables that are final and static should be all capitals, 'pioneerComparator' is not all capitals. +src/net/sf/freecol/server/ai/AIColony.java:133: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:138: Avoid variables with short names like u1 +src/net/sf/freecol/server/ai/AIColony.java:138: Avoid variables with short names like u2 +src/net/sf/freecol/server/ai/AIColony.java:138: Parameter 'u1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:138: Parameter 'u2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:138: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:147: Variables that are final and static should be all capitals, 'scoutComparator' is not all capitals. +src/net/sf/freecol/server/ai/AIColony.java:149: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:154: Avoid variables with short names like u1 +src/net/sf/freecol/server/ai/AIColony.java:154: Avoid variables with short names like u2 +src/net/sf/freecol/server/ai/AIColony.java:154: Parameter 'u1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:154: Parameter 'u2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:154: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:166: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIColony.java:166: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:166: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:169: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:170: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:179: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:179: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:196: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:196: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:205: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:214: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIColony.java:214: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:214: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:233: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:233: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:234: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:237: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:238: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:250: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:259: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:259: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:267: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:276: Avoid really long methods. +src/net/sf/freecol/server/ai/AIColony.java:276: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:276: Found 'UR'-anomaly for variable 'g' (lines '276'-'424'). +src/net/sf/freecol/server/ai/AIColony.java:276: Found 'UR'-anomaly for variable 't' (lines '276'-'316'). +src/net/sf/freecol/server/ai/AIColony.java:276: Found 'UR'-anomaly for variable 'u' (lines '276'-'350'). +src/net/sf/freecol/server/ai/AIColony.java:276: Found 'UR'-anomaly for variable 'uw' (lines '276'-'394'). +src/net/sf/freecol/server/ai/AIColony.java:276: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:276: The method 'rearrangeWorkers' has a Cyclomatic Complexity of 68. +src/net/sf/freecol/server/ai/AIColony.java:276: The method 'rearrangeWorkers' has a Modified Cyclomatic Complexity of 46. +src/net/sf/freecol/server/ai/AIColony.java:276: The method 'rearrangeWorkers' has a Standard Cyclomatic Complexity of 46. +src/net/sf/freecol/server/ai/AIColony.java:276: The method rearrangeWorkers() has an NCSS line count of 154 +src/net/sf/freecol/server/ai/AIColony.java:277: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/AIColony.java:277: Found 'DU'-anomaly for variable 'aiMain' (lines '277'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:278: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:282: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:282: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:282: These nested if statements could be combined +src/net/sf/freecol/server/ai/AIColony.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:291: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIColony.java:295: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:301: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/AIColony.java:301: Found 'DU'-anomaly for variable 'spec' (lines '301'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:306: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/AIColony.java:306: Found 'DD'-anomaly for variable 'nextRearrange' (lines '306'-'412'). +src/net/sf/freecol/server/ai/AIColony.java:306: Found 'DU'-anomaly for variable 'nextRearrange' (lines '306'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:315: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:318: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:323: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:332: Local variable 'oldBuild' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:334: Use equals() to compare object references. +src/net/sf/freecol/server/ai/AIColony.java:335: Local variable 'queue' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:336: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:347: Local variable 'workers' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:348: Local variable 'was' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:349: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:350: Avoid unused local variables such as 'loc'. +src/net/sf/freecol/server/ai/AIColony.java:350: Found 'DD'-anomaly for variable 'loc' (lines '350'-'350'). +src/net/sf/freecol/server/ai/AIColony.java:350: Found 'DU'-anomaly for variable 'loc' (lines '350'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:350: Local variable 'loc' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:351: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/AIColony.java:353: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:354: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:356: Avoid variables with short names like m +src/net/sf/freecol/server/ai/AIColony.java:356: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:356: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:358: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:358: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:367: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/AIColony.java:373: Local variable 'aiPlayer' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:374: Avoid variables with short names like aw +src/net/sf/freecol/server/ai/AIColony.java:374: Local variable 'aw' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:375: Local variable 'preferScouts' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:376: Local variable 'scratch' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:381: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:394: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:394: Local variable 'uw' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:394: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/server/ai/AIColony.java:396: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:396: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:406: Local variable 'newBuild' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:409: Local variable 'queue' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:410: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:412: Found 'DD'-anomaly for variable 'nextRearrange' (lines '412'-'420'). +src/net/sf/freecol/server/ai/AIColony.java:418: Local variable 'net' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:419: Local variable 'when' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:422: Local variable 'warehouse' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:423: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:424: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:425: Local variable 'have' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:426: Local variable 'net' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:427: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:428: Local variable 'when' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:428: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:428: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:428: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:428: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:429: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:429: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:435: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:437: Local variable 'wic' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:452: Local variable 'pioneers' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:453: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:454: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:457: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:459: Avoid variables with short names like m +src/net/sf/freecol/server/ai/AIColony.java:460: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:460: Found 'DD'-anomaly for variable 'oldTarget' (lines '460'-'460'). +src/net/sf/freecol/server/ai/AIColony.java:460: Found 'DD'-anomaly for variable 'oldTarget' (lines '460'-'479'). +src/net/sf/freecol/server/ai/AIColony.java:460: Found 'DU'-anomaly for variable 'oldTarget' (lines '460'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:460: Local variable 'oldTarget' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:462: Avoid assignments in operands +src/net/sf/freecol/server/ai/AIColony.java:462: Found 'DD'-anomaly for variable 'm' (lines '462'-'459'). +src/net/sf/freecol/server/ai/AIColony.java:462: Found 'DD'-anomaly for variable 'm' (lines '462'-'472'). +src/net/sf/freecol/server/ai/AIColony.java:462: Found 'DU'-anomaly for variable 'm' (lines '462'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:465: Avoid assignments in operands +src/net/sf/freecol/server/ai/AIColony.java:465: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:470: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:472: Avoid variables with short names like m +src/net/sf/freecol/server/ai/AIColony.java:473: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:479: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:479: Found 'DD'-anomaly for variable 'oldTarget' (lines '479'-'479'). +src/net/sf/freecol/server/ai/AIColony.java:479: Found 'DU'-anomaly for variable 'oldTarget' (lines '479'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:479: Local variable 'oldTarget' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:481: Avoid assignments in operands +src/net/sf/freecol/server/ai/AIColony.java:481: Found 'DD'-anomaly for variable 'm' (lines '481'-'486'). +src/net/sf/freecol/server/ai/AIColony.java:486: Avoid assignments in operands +src/net/sf/freecol/server/ai/AIColony.java:486: Found 'DD'-anomaly for variable 'm' (lines '486'-'491'). +src/net/sf/freecol/server/ai/AIColony.java:491: Avoid assignments in operands +src/net/sf/freecol/server/ai/AIColony.java:491: Found 'DD'-anomaly for variable 'm' (lines '491'-'472'). +src/net/sf/freecol/server/ai/AIColony.java:491: Found 'DU'-anomaly for variable 'm' (lines '491'-'515'). +src/net/sf/freecol/server/ai/AIColony.java:502: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIColony.java:502: Local variable 'buildStr' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:503: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIColony.java:510: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:510: Local variable 'uw' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:524: Found 'UR'-anomaly for variable 'ag' (lines '524'-'550'). +src/net/sf/freecol/server/ai/AIColony.java:524: Found 'UR'-anomaly for variable 'g' (lines '524'-'536'). +src/net/sf/freecol/server/ai/AIColony.java:524: Found 'UR'-anomaly for variable 'role' (lines '524'-'548'). +src/net/sf/freecol/server/ai/AIColony.java:524: The method 'resetExports' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/AIColony.java:524: The method 'resetExports' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/server/ai/AIColony.java:524: The method 'resetExports' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/server/ai/AIColony.java:524: The method resetExports() has an NPath complexity of 210 +src/net/sf/freecol/server/ai/AIColony.java:526: Found 'DU'-anomaly for variable 'player' (lines '526'-'577'). +src/net/sf/freecol/server/ai/AIColony.java:535: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:535: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:547: Local variable 'role' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:547: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:548: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:549: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:558: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:560: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:561: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:564: Found 'DU'-anomaly for variable 'exportLevel' (lines '564'-'577'). +src/net/sf/freecol/server/ai/AIColony.java:564: Local variable 'exportLevel' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:565: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:568: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:571: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:573: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:583: Found 'UR'-anomaly for variable 't' (lines '583'-'590'). +src/net/sf/freecol/server/ai/AIColony.java:585: Found 'DU'-anomaly for variable 'explorers' (lines '585'-'604'). +src/net/sf/freecol/server/ai/AIColony.java:585: Local variable 'explorers' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:586: Avoid variables with short names like u +src/net/sf/freecol/server/ai/AIColony.java:586: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:589: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:589: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:591: Found 'DD'-anomaly for variable 'direction' (lines '591'-'591'). +src/net/sf/freecol/server/ai/AIColony.java:591: Found 'DU'-anomaly for variable 'direction' (lines '591'-'604'). +src/net/sf/freecol/server/ai/AIColony.java:591: Local variable 'direction' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:593: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:593: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:594: Avoid variables with short names like u +src/net/sf/freecol/server/ai/AIColony.java:594: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:595: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:595: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:595: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:596: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:614: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:614: Found 'UR'-anomaly for variable 't' (lines '614'-'634'). +src/net/sf/freecol/server/ai/AIColony.java:614: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:614: The method 'stealTiles' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/AIColony.java:614: The method stealTiles() has an NPath complexity of 208 +src/net/sf/freecol/server/ai/AIColony.java:615: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/AIColony.java:615: Found 'DU'-anomaly for variable 'spec' (lines '615'-'666'). +src/net/sf/freecol/server/ai/AIColony.java:617: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/AIColony.java:617: Found 'DU'-anomaly for variable 'player' (lines '617'-'666'). +src/net/sf/freecol/server/ai/AIColony.java:618: Local variable 'hasDefender' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:618: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:619: Avoid variables with short names like u +src/net/sf/freecol/server/ai/AIColony.java:620: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:621: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:624: Found 'DU'-anomaly for variable 'needed' (lines '624'-'666'). +src/net/sf/freecol/server/ai/AIColony.java:624: Local variable 'needed' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:624: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:624: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:624: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:624: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:625: Avoid variables with short names like gt +src/net/sf/freecol/server/ai/AIColony.java:630: Found 'DU'-anomaly for variable 'unitType' (lines '630'-'666'). +src/net/sf/freecol/server/ai/AIColony.java:630: Local variable 'unitType' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:630: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:631: Found 'DD'-anomaly for variable 'steal' (lines '631'-'654'). +src/net/sf/freecol/server/ai/AIColony.java:632: Found 'DU'-anomaly for variable 'score' (lines '632'-'666'). +src/net/sf/freecol/server/ai/AIColony.java:633: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:633: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:634: Local variable 'owner' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:634: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:635: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:635: Use equals() to compare object references. +src/net/sf/freecol/server/ai/AIColony.java:636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:637: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:642: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:648: Avoid variables with short names like s +src/net/sf/freecol/server/ai/AIColony.java:648: Local variable 's' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:648: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:648: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:648: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:649: Avoid variables with short names like gt +src/net/sf/freecol/server/ai/AIColony.java:649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:650: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:650: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:650: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:650: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:651: Avoid variables with short names like ft +src/net/sf/freecol/server/ai/AIColony.java:651: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:653: Found 'DU'-anomaly for variable 'score' (lines '653'-'666'). +src/net/sf/freecol/server/ai/AIColony.java:654: Found 'DD'-anomaly for variable 'steal' (lines '654'-'654'). +src/net/sf/freecol/server/ai/AIColony.java:659: Found 'DU'-anomaly for variable 'owner' (lines '659'-'666'). +src/net/sf/freecol/server/ai/AIColony.java:659: Local variable 'owner' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:659: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:661: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:663: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:668: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:678: Found 'UR'-anomaly for variable 'type' (lines '678'-'690'). +src/net/sf/freecol/server/ai/AIColony.java:678: Found 'UR'-anomaly for variable 'u' (lines '678'-'682'). +src/net/sf/freecol/server/ai/AIColony.java:678: Found 'UR'-anomaly for variable 'wl' (lines '678'-'688'). +src/net/sf/freecol/server/ai/AIColony.java:678: The method 'avertAutoDestruction' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/AIColony.java:679: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:679: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:680: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:682: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:682: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:682: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:683: Local variable 'libertyGoods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:683: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:685: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:685: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:686: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:687: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:688: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:689: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:712: Avoid variables with short names like wl +src/net/sf/freecol/server/ai/AIColony.java:712: Found 'UR'-anomaly for variable 'u' (lines '712'-'714'). +src/net/sf/freecol/server/ai/AIColony.java:712: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:713: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:716: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:717: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:717: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:746: Parameter 'aiGoods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:757: Parameter 'aiGoods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:774: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:784: Avoid variables with short names like ag +src/net/sf/freecol/server/ai/AIColony.java:784: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:786: Avoid empty while statements +src/net/sf/freecol/server/ai/AIColony.java:786: Avoid empty while statements +src/net/sf/freecol/server/ai/AIColony.java:795: Avoid variables with short names like ag +src/net/sf/freecol/server/ai/AIColony.java:795: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:796: Avoid variables with short names like tm +src/net/sf/freecol/server/ai/AIColony.java:797: Avoid assignments in operands +src/net/sf/freecol/server/ai/AIColony.java:797: Found 'DU'-anomaly for variable 'tm' (lines '797'-'803'). +src/net/sf/freecol/server/ai/AIColony.java:798: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:798: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:799: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:812: Avoid variables with short names like ag +src/net/sf/freecol/server/ai/AIColony.java:812: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:812: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:812: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:812: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:812: The method goodsLog() has an NPath complexity of 3125 +src/net/sf/freecol/server/ai/AIColony.java:813: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:813: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:814: Local variable 'amount' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:814: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:815: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:816: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:816: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:818: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:818: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:827: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:827: Found 'UR'-anomaly for variable 'aig' (lines '827'-'830'). +src/net/sf/freecol/server/ai/AIColony.java:827: Found 'UR'-anomaly for variable 'aig' (lines '827'-'836'). +src/net/sf/freecol/server/ai/AIColony.java:827: Found 'UR'-anomaly for variable 'gt' (lines '827'-'858'). +src/net/sf/freecol/server/ai/AIColony.java:827: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:827: The method 'updateExportGoods' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/server/ai/AIColony.java:827: The method 'updateExportGoods' has a Modified Cyclomatic Complexity of 21. +src/net/sf/freecol/server/ai/AIColony.java:827: The method 'updateExportGoods' has a Standard Cyclomatic Complexity of 21. +src/net/sf/freecol/server/ai/AIColony.java:827: The method updateExportGoods() has an NPath complexity of 97208 +src/net/sf/freecol/server/ai/AIColony.java:829: Local variable 'aig' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:835: Local variable 'aig' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:841: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIColony.java:841: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:846: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:846: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:854: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:856: Local variable 'newAIGoods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:857: Local variable 'gt' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:857: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:858: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:859: Local variable 'count' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:860: Local variable 'exportAmount' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:860: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:860: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:863: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:865: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:866: Found 'DD'-anomaly for variable 'priority' (lines '866'-'866'). +src/net/sf/freecol/server/ai/AIColony.java:866: Found 'DU'-anomaly for variable 'priority' (lines '866'-'912'). +src/net/sf/freecol/server/ai/AIColony.java:866: Local variable 'priority' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:866: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:866: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:878: Local variable 'aig' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:879: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:880: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:881: Local variable 'amount' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:881: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:883: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:888: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:900: Found 'DD'-anomaly for variable 'destination' (lines '900'-'900'). +src/net/sf/freecol/server/ai/AIColony.java:900: Found 'DU'-anomaly for variable 'destination' (lines '900'-'912'). +src/net/sf/freecol/server/ai/AIColony.java:900: Local variable 'destination' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:900: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:900: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:900: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:900: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:901: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:903: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/AIColony.java:903: Local variable 'newGoods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:920: Parameter 'wish' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:932: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:932: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:932: Parameter 'reason' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:932: Parameter 'wish' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:935: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:937: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:951: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:951: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:951: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:952: Found 'DD'-anomaly for variable 'ret' (lines '952'-'959'). +src/net/sf/freecol/server/ai/AIColony.java:953: Avoid variables with short names like i +src/net/sf/freecol/server/ai/AIColony.java:956: Avoid variables with short names like gw +src/net/sf/freecol/server/ai/AIColony.java:956: Local variable 'gw' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:957: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:959: Found 'DD'-anomaly for variable 'ret' (lines '959'-'959'). +src/net/sf/freecol/server/ai/AIColony.java:975: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:975: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:975: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:976: Found 'DD'-anomaly for variable 'ret' (lines '976'-'983'). +src/net/sf/freecol/server/ai/AIColony.java:977: Avoid variables with short names like i +src/net/sf/freecol/server/ai/AIColony.java:980: Avoid variables with short names like ww +src/net/sf/freecol/server/ai/AIColony.java:980: Local variable 'ww' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:981: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:983: Found 'DD'-anomaly for variable 'ret' (lines '983'-'983'). +src/net/sf/freecol/server/ai/AIColony.java:999: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:999: Avoid variables with short names like t +src/net/sf/freecol/server/ai/AIColony.java:999: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:999: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1001: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:1003: Local variable 'aiUnit' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1004: Avoid variables with short names like wm +src/net/sf/freecol/server/ai/AIColony.java:1004: Local variable 'wm' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1005: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1006: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1008: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1009: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1010: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:1030: Found 'UR'-anomaly for variable 'wish' (lines '1,030'-'1,033'). +src/net/sf/freecol/server/ai/AIColony.java:1031: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1032: Local variable 'wish' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1045: Found 'UR'-anomaly for variable 'wish' (lines '1,045'-'1,048'). +src/net/sf/freecol/server/ai/AIColony.java:1046: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1047: Local variable 'wish' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1055: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:1066: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1066: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1066: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1067: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:1067: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1068: Avoid variables with short names like gw +src/net/sf/freecol/server/ai/AIColony.java:1068: Avoid variables with short names like w +src/net/sf/freecol/server/ai/AIColony.java:1068: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1068: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1069: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1070: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIColony.java:1080: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIColony.java:1090: Parameter 'expertNeeded' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1090: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1091: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:1091: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1091: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1092: Avoid variables with short names like w +src/net/sf/freecol/server/ai/AIColony.java:1092: Avoid variables with short names like ww +src/net/sf/freecol/server/ai/AIColony.java:1092: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1092: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1093: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1094: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIColony.java:1109: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:1109: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1120: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:1120: Found 'UR'-anomaly for variable 'u' (lines '1,120'-'1,138'). +src/net/sf/freecol/server/ai/AIColony.java:1120: Found 'UR'-anomaly for variable 'u' (lines '1,120'-'1,138'). +src/net/sf/freecol/server/ai/AIColony.java:1120: Found 'UR'-anomaly for variable 'wl' (lines '1,120'-'1,137'). +src/net/sf/freecol/server/ai/AIColony.java:1120: Found 'UR'-anomaly for variable 'wl' (lines '1,120'-'1,137'). +src/net/sf/freecol/server/ai/AIColony.java:1120: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1120: The method 'updateWorkerWishes' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/server/ai/AIColony.java:1120: The method 'updateWorkerWishes' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/AIColony.java:1120: The method 'updateWorkerWishes' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/AIColony.java:1120: The method updateWorkerWishes() has an NPath complexity of 1980 +src/net/sf/freecol/server/ai/AIColony.java:1121: Found 'DU'-anomaly for variable 'spec' (lines '1,121'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1121: Found 'DU'-anomaly for variable 'spec' (lines '1,121'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1122: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/AIColony.java:1122: Found 'DU'-anomaly for variable 'baseValue' (lines '1,122'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1122: Found 'DU'-anomaly for variable 'baseValue' (lines '1,122'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1123: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/AIColony.java:1123: Found 'DU'-anomaly for variable 'priorityMax' (lines '1,123'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1123: Found 'DU'-anomaly for variable 'priorityMax' (lines '1,123'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1124: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/AIColony.java:1124: Found 'DU'-anomaly for variable 'priorityDecay' (lines '1,124'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1124: Found 'DU'-anomaly for variable 'priorityDecay' (lines '1,124'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1125: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/AIColony.java:1125: Found 'DU'-anomaly for variable 'multipleBonus' (lines '1,125'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1125: Found 'DU'-anomaly for variable 'multipleBonus' (lines '1,125'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1126: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/AIColony.java:1126: Found 'DU'-anomaly for variable 'multipleMax' (lines '1,126'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1126: Found 'DU'-anomaly for variable 'multipleMax' (lines '1,126'-'1,203'). +src/net/sf/freecol/server/ai/AIColony.java:1135: Local variable 'producing' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1136: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1137: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1141: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1147: Avoid variables with short names like g1 +src/net/sf/freecol/server/ai/AIColony.java:1147: Avoid variables with short names like g2 +src/net/sf/freecol/server/ai/AIColony.java:1147: Parameter 'g1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1147: Parameter 'g2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1147: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1152: Local variable 'experts' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1153: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1154: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1155: Local variable 'expert' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1155: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1155: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1156: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:1156: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1162: Local variable 'expert' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1163: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1164: Local variable 'value' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1177: Local variable 'needFood' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1179: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1183: Local variable 'plan' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1183: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1183: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1185: Local variable 'location' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1186: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1188: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/ai/AIColony.java:1198: Local variable 'bestDefender' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1210: Avoid really long methods. +src/net/sf/freecol/server/ai/AIColony.java:1210: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:1210: Found 'UR'-anomaly for variable 'ag' (lines '1,210'-'1,222'). +src/net/sf/freecol/server/ai/AIColony.java:1210: Found 'UR'-anomaly for variable 'g' (lines '1,210'-'1,256'). +src/net/sf/freecol/server/ai/AIColony.java:1210: Found 'UR'-anomaly for variable 'goods' (lines '1,210'-'1,247'). +src/net/sf/freecol/server/ai/AIColony.java:1210: Found 'UR'-anomaly for variable 'plan' (lines '1,210'-'1,230'). +src/net/sf/freecol/server/ai/AIColony.java:1210: Found 'UR'-anomaly for variable 'type' (lines '1,210'-'1,295'). +src/net/sf/freecol/server/ai/AIColony.java:1210: Found 'UR'-anomaly for variable 'unit' (lines '1,210'-'1,268'). +src/net/sf/freecol/server/ai/AIColony.java:1210: Found 'UR'-anomaly for variable 'workLocation' (lines '1,210'-'1,239'). +src/net/sf/freecol/server/ai/AIColony.java:1210: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1210: The method 'updateGoodsWishes' has a Cyclomatic Complexity of 30. +src/net/sf/freecol/server/ai/AIColony.java:1210: The method 'updateGoodsWishes' has a Modified Cyclomatic Complexity of 27. +src/net/sf/freecol/server/ai/AIColony.java:1210: The method 'updateGoodsWishes' has a Standard Cyclomatic Complexity of 27. +src/net/sf/freecol/server/ai/AIColony.java:1210: The method updateGoodsWishes() has an NPath complexity of 364800 +src/net/sf/freecol/server/ai/AIColony.java:1212: Found 'DU'-anomaly for variable 'goodsWishValue' (lines '1,212'-'1,311'). +src/net/sf/freecol/server/ai/AIColony.java:1212: Local variable 'goodsWishValue' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1216: Local variable 'required' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1220: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1229: Local variable 'plan' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1230: Local variable 'role' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1230: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1231: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1232: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1238: Local variable 'workLocation' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1240: Local variable 'building' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1241: Local variable 'inputs' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1243: Local variable 'info' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1245: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1255: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1255: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1258: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1258: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1265: Local variable 'role' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1265: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1266: Avoid unused local variables such as 'owner'. +src/net/sf/freecol/server/ai/AIColony.java:1266: Found 'DU'-anomaly for variable 'owner' (lines '1,266'-'1,311'). +src/net/sf/freecol/server/ai/AIColony.java:1266: Local variable 'owner' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1267: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1267: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1268: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1269: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1269: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1272: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1275: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/ai/AIColony.java:1280: Avoid variables with short names like i +src/net/sf/freecol/server/ai/AIColony.java:1283: Avoid variables with short names like g +src/net/sf/freecol/server/ai/AIColony.java:1283: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1284: Avoid variables with short names like t +src/net/sf/freecol/server/ai/AIColony.java:1284: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1294: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1294: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1297: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1300: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1301: Local variable 'amount' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1302: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1302: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1306: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1327: Parameter 'plan' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1339: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1340: Parameter 'plans' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1351: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:1351: Found 'UR'-anomaly for variable 'ag' (lines '1,351'-'1,366'). +src/net/sf/freecol/server/ai/AIColony.java:1351: Found 'UR'-anomaly for variable 'tip' (lines '1,351'-'1,410'). +src/net/sf/freecol/server/ai/AIColony.java:1351: Found 'UR'-anomaly for variable 'wl' (lines '1,351'-'1,354'). +src/net/sf/freecol/server/ai/AIColony.java:1351: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1351: The method 'updateTileImprovementPlans' has a Cyclomatic Complexity of 22. +src/net/sf/freecol/server/ai/AIColony.java:1351: The method 'updateTileImprovementPlans' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/AIColony.java:1351: The method 'updateTileImprovementPlans' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/AIColony.java:1351: The method updateTileImprovementPlans() has an NPath complexity of 10083 +src/net/sf/freecol/server/ai/AIColony.java:1352: Local variable 'newPlans' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1353: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1354: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1355: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1356: Local variable 'workTile' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1356: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1357: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1357: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1363: Found 'DD'-anomaly for variable 'goodsType' (lines '1,363'-'1,367'). +src/net/sf/freecol/server/ai/AIColony.java:1363: Found 'DD'-anomaly for variable 'goodsType' (lines '1,363'-'1,373'). +src/net/sf/freecol/server/ai/AIColony.java:1364: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1365: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1366: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1366: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1367: Found 'DD'-anomaly for variable 'goodsType' (lines '1,367'-'1,373'). +src/net/sf/freecol/server/ai/AIColony.java:1367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1372: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1373: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1375: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1380: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1383: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/AIColony.java:1384: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1387: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:1387: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1389: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1392: Local variable 'change' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1393: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1396: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1396: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1396: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1396: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1396: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1396: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1397: Avoid variables with short names like ct +src/net/sf/freecol/server/ai/AIColony.java:1397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1398: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1399: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1399: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1409: Local variable 'tip' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1432: Found 'UR'-anomaly for variable 'aig' (lines '1,432'-'1,443'). +src/net/sf/freecol/server/ai/AIColony.java:1432: Found 'UR'-anomaly for variable 'tip' (lines '1,432'-'1,438'). +src/net/sf/freecol/server/ai/AIColony.java:1432: Found 'UR'-anomaly for variable 'w' (lines '1,432'-'1,441'). +src/net/sf/freecol/server/ai/AIColony.java:1433: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIColony.java:1433: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1435: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIColony.java:1435: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1437: Local variable 'tip' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1441: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1441: Local variable 'w' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1443: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1443: Local variable 'aig' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1453: Found 'UR'-anomaly for variable 'aig' (lines '1,453'-'1,464'). +src/net/sf/freecol/server/ai/AIColony.java:1453: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1460: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1461: Found 'DU'-anomaly for variable 'left' (lines '1,461'-'1,483'). +src/net/sf/freecol/server/ai/AIColony.java:1461: Local variable 'left' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1462: Local variable 'aig' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1463: Found 'DD'-anomaly for variable 'remove' (lines '1,463'-'1,465'). +src/net/sf/freecol/server/ai/AIColony.java:1463: Found 'DD'-anomaly for variable 'remove' (lines '1,463'-'1,468'). +src/net/sf/freecol/server/ai/AIColony.java:1463: Found 'DD'-anomaly for variable 'remove' (lines '1,463'-'1,474'). +src/net/sf/freecol/server/ai/AIColony.java:1464: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1466: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1467: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1471: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1471: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1473: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1500: Found 'UR'-anomaly for variable 'o' (lines '1,500'-'1,509'). +src/net/sf/freecol/server/ai/AIColony.java:1501: Local variable 'objects' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1501: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1501: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1501: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1501: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1502: Avoid variables with short names like ag +src/net/sf/freecol/server/ai/AIColony.java:1503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIColony.java:1505: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1507: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1509: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1509: Local variable 'o' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1509: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1510: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:1523: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1525: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1532: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIColony.java:1532: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1534: Avoid excessively long variable names like GOODS_WISH_LIST_TAG +src/net/sf/freecol/server/ai/AIColony.java:1534: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIColony.java:1534: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1536: Avoid excessively long variable names like TILE_IMPROVEMENT_PLAN_LIST_TAG +src/net/sf/freecol/server/ai/AIColony.java:1536: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIColony.java:1536: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1538: Avoid excessively long variable names like WORKER_WISH_LIST_TAG +src/net/sf/freecol/server/ai/AIColony.java:1538: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIColony.java:1538: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1541: Avoid excessively long variable names like OLD_GOODS_WISH_TAG +src/net/sf/freecol/server/ai/AIColony.java:1541: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIColony.java:1541: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1543: Avoid excessively long variable names like OLD_TILE_IMPROVEMENT_PLAN_LIST_TAG +src/net/sf/freecol/server/ai/AIColony.java:1543: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIColony.java:1543: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1545: Avoid excessively long variable names like OLD_WORKER_WISH_TAG +src/net/sf/freecol/server/ai/AIColony.java:1545: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIColony.java:1545: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIColony.java:1554: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/AIColony.java:1554: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1554: The method 'writeChildren' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/AIColony.java:1554: The method writeChildren() has an NPath complexity of 333 +src/net/sf/freecol/server/ai/AIColony.java:1557: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1558: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1566: Local variable 'tip' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1567: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1576: Local variable 'w' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1577: Local variable 'tag' could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1577: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1577: Useless parentheses. +src/net/sf/freecol/server/ai/AIColony.java:1579: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIColony.java:1580: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1595: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIColony.java:1595: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIColony.java:1608: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIColony.java:1608: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIColony.java:1617: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIColony.java:1624: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIColony.java:1624: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:20: Possible God class (WMC=70, ATFD=55, TCC=0.008333333333333333) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:62: The class 'AIInGameInputHandler' has a Cyclomatic Complexity of 3 (Highest = 16). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:62: The class 'AIInGameInputHandler' has a Standard Cyclomatic Complexity of 3 (Highest = 16). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:62: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:64: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:64: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:70: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:84: Avoid variables with short names like me +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:84: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:84: Parameter 'me' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:85: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:87: Avoid throwing null pointer exceptions. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:89: Avoid throwing null pointer exceptions. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:90: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:91: Avoid throwing raw exception types. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:93: Avoid throwing null pointer exceptions. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:117: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:133: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:133: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:133: The method 'handle' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:133: The method 'handle' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:133: Use block level rather than method level synchronization +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:134: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:134: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'142'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'144'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'146'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'148'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'150'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'152'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'154'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'156'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'158'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'160'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:136: Found 'DD'-anomaly for variable 'reply' (lines '136'-'162'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:176: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:179: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:180: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:197: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:197: The String literal "unused" appears 10 times in this file; the first occurrence is on line 197 +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:198: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:202: Local variable 'message' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:204: Avoid variables with short names like ff +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:204: Local variable 'ff' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:205: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:206: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:218: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:219: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:224: Avoid variables with short names like sb +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:224: Local variable 'sb' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:226: Local variable 'status' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:244: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:245: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:260: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:261: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:262: Found 'DU'-anomaly for variable 'aiPlayer' (lines '262'-'273'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:264: Local variable 'migrants' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:265: Avoid variables with short names like n +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:267: Found 'DD'-anomaly for variable 'n' (lines '267'-'269'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:271: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:275: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:285: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:286: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:290: Local variable 'message' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:291: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:292: Local variable 'colony' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:293: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:294: Local variable 'amount' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:295: Local variable 'accept' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:297: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:310: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:311: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:315: Local variable 'message' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:316: Found 'DU'-anomaly for variable 'unit' (lines '316'-'338'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:316: Found 'DU'-anomaly for variable 'unit' (lines '316'-'338'). +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:316: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:317: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:320: Avoid variables with short names like g1 +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:320: Avoid variables with short names like g2 +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:320: Parameter 'g1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:320: Parameter 'g2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:320: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:321: Avoid variables with short names like p1 +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:321: Local variable 'p1' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:323: Avoid variables with short names like p2 +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:323: Local variable 'p2' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:328: Local variable 'loot' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:329: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:331: Avoid variables with short names like g +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:331: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:331: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:332: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:332: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:348: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:349: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:352: Local variable 'message' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:353: Local variable 'action' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:357: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:357: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:359: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:364: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:366: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:371: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:372: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:384: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:384: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:385: Local variable 'nodes' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:386: Local variable 'results' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:390: Local variable 'reply' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:391: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:392: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:393: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:408: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:409: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:422: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:423: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:436: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:440: Local variable 'str' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:444: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:444: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:445: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:446: Local variable 'nam' could be declared final +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:448: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:450: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:452: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIInGameInputHandler.java:453: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/ai/AIMain.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMain.java:20: Possible God class (WMC=94, ATFD=41, TCC=0.018461538461538463) +src/net/sf/freecol/server/ai/AIMain.java:53: The class 'AIMain' has a Cyclomatic Complexity of 3 (Highest = 23). +src/net/sf/freecol/server/ai/AIMain.java:53: The class 'AIMain' has a Modified Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/server/ai/AIMain.java:53: The class 'AIMain' has a Standard Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/server/ai/AIMain.java:54: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/AIMain.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/AIMain.java:56: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIMain.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIMain.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIMain.java:68: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/AIMain.java:77: It is a good practice to call super() in a constructor +src/net/sf/freecol/server/ai/AIMain.java:77: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:81: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMain.java:91: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:92: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIMain.java:92: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:123: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIMain.java:123: Local variable 'id' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:135: Parameter 'logMe' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:140: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMain.java:153: Parameter 'fcgo' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:154: Useless parentheses. +src/net/sf/freecol/server/ai/AIMain.java:154: Useless parentheses. +src/net/sf/freecol/server/ai/AIMain.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:167: Found 'UR'-anomaly for variable 'fcgo' (lines '167'-'170'). +src/net/sf/freecol/server/ai/AIMain.java:167: Parameter 'overwrite' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:168: Local variable 'fcgo' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:170: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:177: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMain.java:186: Parameter 'fcgo' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:197: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIMain.java:197: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:210: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIMain.java:210: Parameter 'aiObject' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:210: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:212: Avoid throwing null pointer exceptions. +src/net/sf/freecol/server/ai/AIMain.java:217: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:220: Avoid throwing raw exception types. +src/net/sf/freecol/server/ai/AIMain.java:230: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIMain.java:230: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:235: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:235: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:258: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIMain.java:258: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:258: Parameter 'returnClass' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:259: Local variable 'aio' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:261: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIMain.java:273: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:283: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:293: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:301: Found 'UR'-anomaly for variable 'aio' (lines '301'-'305'). +src/net/sf/freecol/server/ai/AIMain.java:301: Found 'UR'-anomaly for variable 'entry' (lines '301'-'316'). +src/net/sf/freecol/server/ai/AIMain.java:302: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/AIMain.java:302: Local variable 'stats' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:303: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/AIMain.java:303: Local variable 'objStats' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:304: Local variable 'aio' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:305: Local variable 'className' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:305: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:307: Found 'DD'-anomaly for variable 'count' (lines '307'-'308'). +src/net/sf/freecol/server/ai/AIMain.java:311: Local variable 'count' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:315: Local variable 'entry' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:330: Found 'UR'-anomaly for variable 'aio' (lines '330'-'333'). +src/net/sf/freecol/server/ai/AIMain.java:330: Found 'UR'-anomaly for variable 'fcgo' (lines '330'-'346'). +src/net/sf/freecol/server/ai/AIMain.java:330: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:331: Found 'DD'-anomaly for variable 'result' (lines '331'-'342'). +src/net/sf/freecol/server/ai/AIMain.java:331: Found 'DD'-anomaly for variable 'result' (lines '331'-'351'). +src/net/sf/freecol/server/ai/AIMain.java:331: Found 'DD'-anomaly for variable 'result' (lines '331'-'354'). +src/net/sf/freecol/server/ai/AIMain.java:332: Local variable 'aio' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:335: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:336: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:336: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:345: Local variable 'fcgo' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:345: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:349: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:350: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:351: Found 'DD'-anomaly for variable 'result' (lines '351'-'351'). +src/net/sf/freecol/server/ai/AIMain.java:351: Found 'DD'-anomaly for variable 'result' (lines '351'-'354'). +src/net/sf/freecol/server/ai/AIMain.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:353: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:354: Found 'DD'-anomaly for variable 'result' (lines '354'-'351'). +src/net/sf/freecol/server/ai/AIMain.java:354: Found 'DD'-anomaly for variable 'result' (lines '354'-'354'). +src/net/sf/freecol/server/ai/AIMain.java:364: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMain.java:376: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIMain.java:376: Parameter 'fcgo' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:376: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:376: The method 'setFreeColGameObject' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/AIMain.java:376: The method 'setFreeColGameObject' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/AIMain.java:376: The method 'setFreeColGameObject' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/AIMain.java:377: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:384: Local variable 'player' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:385: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:389: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:389: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:412: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIMain.java:412: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:413: Avoid variables with short names like o +src/net/sf/freecol/server/ai/AIMain.java:413: Local variable 'o' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:414: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:426: Parameter 'oldOwner' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:426: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:427: Parameter 'newOwner' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:428: Avoid variables with short names like ao +src/net/sf/freecol/server/ai/AIMain.java:428: Local variable 'ao' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:429: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:431: Local variable 'aiOwner' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:434: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:440: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:453: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:459: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIMain.java:459: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIMain.java:461: Avoid excessively long variable names like COLONIAL_AI_PLAYER_TAG +src/net/sf/freecol/server/ai/AIMain.java:461: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIMain.java:461: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIMain.java:462: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIMain.java:462: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIMain.java:465: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIMain.java:465: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIMain.java:468: Avoid excessively long variable names like OLD_TILE_IMPROVEMENT_PLAN_TAG +src/net/sf/freecol/server/ai/AIMain.java:468: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIMain.java:468: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIMain.java:476: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/AIMain.java:476: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:487: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/AIMain.java:487: Found 'UR'-anomaly for variable 'aio' (lines '487'-'491'). +src/net/sf/freecol/server/ai/AIMain.java:487: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:490: Local variable 'aio' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:503: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:503: These nested if statements could be combined +src/net/sf/freecol/server/ai/AIMain.java:508: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:508: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:509: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:513: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/ai/AIMain.java:514: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:524: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIMain.java:524: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:527: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:535: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIMain.java:535: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:546: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIMain.java:546: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMain.java:546: The method 'readChild' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/server/ai/AIMain.java:546: The method 'readChild' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/server/ai/AIMain.java:546: The method 'readChild' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/server/ai/AIMain.java:551: Found 'DD'-anomaly for variable 'wish' (lines '551'-'595'). +src/net/sf/freecol/server/ai/AIMain.java:551: Found 'DD'-anomaly for variable 'wish' (lines '551'-'605'). +src/net/sf/freecol/server/ai/AIMain.java:551: Found 'DU'-anomaly for variable 'wish' (lines '551'-'625'). +src/net/sf/freecol/server/ai/AIMain.java:559: Avoid assignments in operands +src/net/sf/freecol/server/ai/AIMain.java:559: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIMain.java:559: Found 'DU'-anomaly for variable 'aio' (lines '559'-'625'). +src/net/sf/freecol/server/ai/AIMain.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:570: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:573: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:574: Avoid variables with short names like p +src/net/sf/freecol/server/ai/AIMain.java:574: Local variable 'p' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:574: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:583: Avoid throwing raw exception types. +src/net/sf/freecol/server/ai/AIMain.java:587: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:597: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:604: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMain.java:612: Avoid variables with short names like ac +src/net/sf/freecol/server/ai/AIMain.java:612: Local variable 'ac' could be declared final +src/net/sf/freecol/server/ai/AIMain.java:613: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:613: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMain.java:616: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/ai/AIMain.java:617: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMain.java:622: Avoid using while statements without curly braces +src/net/sf/freecol/server/ai/AIMain.java:623: Avoid empty while statements +src/net/sf/freecol/server/ai/AIMain.java:623: Avoid empty while statements +src/net/sf/freecol/server/ai/AIMessage.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMessage.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/ai/AIMessage.java:20: Possible God class (WMC=66, ATFD=84, TCC=0.0) +src/net/sf/freecol/server/ai/AIMessage.java:87: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/server/ai/AIMessage.java:87: The class 'AIMessage' has a Cyclomatic Complexity of 2 (Highest = 12). +src/net/sf/freecol/server/ai/AIMessage.java:87: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/AIMessage.java:89: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/AIMessage.java:89: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIMessage.java:100: Parameter 'conn' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:100: Parameter 'request' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:103: Found 'DD'-anomaly for variable 'reply' (lines '103'-'107'). +src/net/sf/freecol/server/ai/AIMessage.java:105: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMessage.java:107: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIMessage.java:119: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:119: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:120: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/AIMessage.java:121: Local variable 'messageId' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:122: Local variable 'messageText' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:123: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMessage.java:126: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIMessage.java:139: Avoid reassigning parameters such as 'request' +src/net/sf/freecol/server/ai/AIMessage.java:139: Parameter 'conn' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:141: Local variable 'reply' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:142: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMessage.java:143: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIMessage.java:143: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMessage.java:147: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMessage.java:148: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIMessage.java:162: Avoid unused private methods such as 'askExpecting(Connection,Element,String)'. +src/net/sf/freecol/server/ai/AIMessage.java:162: Parameter 'conn' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:162: Parameter 'request' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:162: The method 'askExpecting' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/server/ai/AIMessage.java:163: Parameter 'expect' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:165: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMessage.java:166: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIMessage.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:170: Local variable 'replies' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:171: Local variable 'nodes' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:172: Found 'DD'-anomaly for variable 'result' (lines '172'-'177'). +src/net/sf/freecol/server/ai/AIMessage.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:177: Found 'DD'-anomaly for variable 'result' (lines '177'-'177'). +src/net/sf/freecol/server/ai/AIMessage.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:181: Avoid variables with short names like e +src/net/sf/freecol/server/ai/AIMessage.java:181: Local variable 'e' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:182: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMessage.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:184: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMessage.java:187: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMessage.java:188: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIMessage.java:192: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIMessage.java:192: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMessage.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:193: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIMessage.java:206: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:207: Parameter 'request' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:211: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMessage.java:220: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:221: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:222: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIMessage.java:222: Useless parentheses. +src/net/sf/freecol/server/ai/AIMessage.java:222: Useless parentheses. +src/net/sf/freecol/server/ai/AIMessage.java:235: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:235: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:236: Parameter 'attributes' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:247: Parameter 'attributes' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:247: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:248: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/AIMessage.java:262: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:262: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:263: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:275: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:275: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:276: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:287: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:300: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:300: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:301: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:313: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:313: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:314: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:326: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:327: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:328: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:333: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMessage.java:342: Parameter 'claimant' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:342: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:343: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:347: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:348: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:350: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:351: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:356: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:356: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:367: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:368: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:380: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:381: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:382: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:396: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:396: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:397: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:398: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:410: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:411: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:422: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:436: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:436: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:437: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:438: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:451: Parameter 'aiPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:451: Parameter 'slot' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:463: Parameter 'aiPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:476: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:476: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:477: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:478: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:491: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:492: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:493: Parameter 'denounce' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:494: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:508: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:509: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:510: Local variable 'reply' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:524: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:525: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:526: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:532: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMessage.java:542: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:542: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:543: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:543: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:544: Local variable 'reply' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:544: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:552: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMessage.java:561: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:561: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:562: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:562: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:563: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:576: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:576: Parameter 'defenderId' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:577: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:578: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:591: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:591: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:604: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:604: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:616: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:617: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:622: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIMessage.java:631: Found 'UR'-anomaly for variable 'u' (lines '631'-'637'). +src/net/sf/freecol/server/ai/AIMessage.java:631: Parameter 'aiColony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:632: Parameter 'workers' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:633: Parameter 'scratch' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:634: Local variable 'colony' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:635: Local variable 'message' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:636: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:637: Avoid variables with short names like su +src/net/sf/freecol/server/ai/AIMessage.java:637: Local variable 'su' could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:638: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIMessage.java:638: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:638: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:638: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:638: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:639: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:641: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:643: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:643: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:644: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:644: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:644: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIMessage.java:646: Useless parentheses. +src/net/sf/freecol/server/ai/AIMessage.java:646: Useless parentheses. +src/net/sf/freecol/server/ai/AIMessage.java:647: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:647: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:658: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:659: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:660: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:673: Parameter 'aiColony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:674: Parameter 'queue' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:675: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:688: Parameter 'aiPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:689: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:703: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:703: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:704: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:705: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIMessage.java:717: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:717: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIMessage.java:718: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIObject.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIObject.java:39: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/ai/AIObject.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/AIObject.java:42: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIObject.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIObject.java:48: Avoid using redundant field initializer for 'uninitialized' +src/net/sf/freecol/server/ai/AIObject.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIObject.java:56: It is a good practice to call super() in a constructor +src/net/sf/freecol/server/ai/AIObject.java:56: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:69: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIObject.java:69: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:69: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:86: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:86: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:93: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIObject.java:102: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:103: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIObject.java:103: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIObject.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIObject.java:162: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIObject.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIObject.java:187: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIObject.java:188: Useless parentheses. +src/net/sf/freecol/server/ai/AIObject.java:188: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/ai/AIPlayer.java:20: Possible God class (WMC=98, ATFD=47, TCC=0.013414634146341463) +src/net/sf/freecol/server/ai/AIPlayer.java:71: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/ai/AIPlayer.java:71: The class 'AIPlayer' has a Cyclomatic Complexity of 2 (Highest = 11). +src/net/sf/freecol/server/ai/AIPlayer.java:71: The class 'AIPlayer' has a Modified Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/server/ai/AIPlayer.java:71: The class 'AIPlayer' has a Standard Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/server/ai/AIPlayer.java:71: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/AIPlayer.java:73: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/AIPlayer.java:73: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIPlayer.java:76: Avoid excessively long variable names like aiUnitLocationComparator +src/net/sf/freecol/server/ai/AIPlayer.java:76: Variables that are final and static should be all capitals, 'aiUnitLocationComparator' is not all capitals. +src/net/sf/freecol/server/ai/AIPlayer.java:79: Avoid variables with short names like a1 +src/net/sf/freecol/server/ai/AIPlayer.java:79: Avoid variables with short names like a2 +src/net/sf/freecol/server/ai/AIPlayer.java:79: Parameter 'a1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:79: Parameter 'a2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:79: The method compare() has an NPath complexity of 2025 +src/net/sf/freecol/server/ai/AIPlayer.java:79: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/AIPlayer.java:80: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:80: Avoid variables with short names like l1 +src/net/sf/freecol/server/ai/AIPlayer.java:80: Local variable 'l1' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:81: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:82: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:83: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:83: Avoid variables with short names like l2 +src/net/sf/freecol/server/ai/AIPlayer.java:83: Local variable 'l2' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:84: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:86: Avoid variables with short names like f1 +src/net/sf/freecol/server/ai/AIPlayer.java:86: Local variable 'f1' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:86: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:86: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:89: Avoid variables with short names like f2 +src/net/sf/freecol/server/ai/AIPlayer.java:89: Local variable 'f2' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:89: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:89: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:97: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIPlayer.java:100: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIPlayer.java:106: Avoid excessively long variable names like debuggingConnection +src/net/sf/freecol/server/ai/AIPlayer.java:106: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIPlayer.java:114: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/AIPlayer.java:124: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:124: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:133: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:142: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:143: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIPlayer.java:143: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:160: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:191: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:200: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:209: Found 'UR'-anomaly for variable 'u' (lines '209'-'212'). +src/net/sf/freecol/server/ai/AIPlayer.java:211: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:213: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIPlayer.java:216: Avoid variables with short names like a +src/net/sf/freecol/server/ai/AIPlayer.java:216: Local variable 'a' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:217: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:224: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIPlayer.java:236: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/AIPlayer.java:237: Avoid variables with short names like id +src/net/sf/freecol/server/ai/AIPlayer.java:237: Local variable 'id' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:237: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:237: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:238: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:239: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:239: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:250: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:254: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:263: Avoid excessively long variable names like debuggingConnection +src/net/sf/freecol/server/ai/AIPlayer.java:263: Parameter 'debuggingConnection' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:273: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:274: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:282: Found 'UR'-anomaly for variable 'colony' (lines '282'-'285'). +src/net/sf/freecol/server/ai/AIPlayer.java:283: Avoid variables with short names like ac +src/net/sf/freecol/server/ai/AIPlayer.java:283: Local variable 'ac' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:284: Local variable 'colony' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:284: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:285: Avoid variables with short names like a +src/net/sf/freecol/server/ai/AIPlayer.java:285: Local variable 'a' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:286: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:289: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIPlayer.java:301: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/server/ai/AIPlayer.java:301: Document empty method +src/net/sf/freecol/server/ai/AIPlayer.java:301: Parameter 'aic' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:309: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:319: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:330: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:340: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:351: Found 'UR'-anomaly for variable 'au' (lines '351'-'354'). +src/net/sf/freecol/server/ai/AIPlayer.java:351: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:352: Found 'DD'-anomaly for variable 'defenders' (lines '352'-'358'). +src/net/sf/freecol/server/ai/AIPlayer.java:353: Local variable 'au' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:354: Avoid variables with short names like dm +src/net/sf/freecol/server/ai/AIPlayer.java:354: Local variable 'dm' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:356: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:357: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:358: Found 'DD'-anomaly for variable 'defenders' (lines '358'-'358'). +src/net/sf/freecol/server/ai/AIPlayer.java:364: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:373: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:373: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:373: The method 'isTargetValidForSeekAndDestroy' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/AIPlayer.java:373: The method 'isTargetValidForSeekAndDestroy' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/AIPlayer.java:373: The method 'isTargetValidForSeekAndDestroy' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/AIPlayer.java:373: The method isTargetValidForSeekAndDestroy() has an NPath complexity of 432 +src/net/sf/freecol/server/ai/AIPlayer.java:375: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIPlayer.java:375: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:377: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/AIPlayer.java:377: Found 'DU'-anomaly for variable 'attackerPlayer' (lines '377'-'405'). +src/net/sf/freecol/server/ai/AIPlayer.java:377: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:380: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:381: Local variable 'defender' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:382: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:382: Local variable 'defenderPlayer' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:383: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:384: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:387: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIPlayer.java:387: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:390: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIPlayer.java:390: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:390: Use equals() to compare object references. +src/net/sf/freecol/server/ai/AIPlayer.java:395: Found 'DU'-anomaly for variable 'atWar' (lines '395'-'405'). +src/net/sf/freecol/server/ai/AIPlayer.java:395: Local variable 'atWar' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:397: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIPlayer.java:397: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:399: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:399: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:399: These nested if statements could be combined +src/net/sf/freecol/server/ai/AIPlayer.java:401: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIPlayer.java:415: Found 'UR'-anomaly for variable 'aiu' (lines '415'-'420'). +src/net/sf/freecol/server/ai/AIPlayer.java:415: Parameter 'reasons' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:416: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIPlayer.java:416: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:417: Local variable 'units' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:419: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:420: Avoid variables with short names like u +src/net/sf/freecol/server/ai/AIPlayer.java:420: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:422: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:423: Avoid variables with short names like ms +src/net/sf/freecol/server/ai/AIPlayer.java:423: Found 'DD'-anomaly for variable 'ms' (lines '423'-'427'). +src/net/sf/freecol/server/ai/AIPlayer.java:424: Found 'DD'-anomaly for variable 'target' (lines '424'-'429'). +src/net/sf/freecol/server/ai/AIPlayer.java:425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:426: Avoid variables with short names like m +src/net/sf/freecol/server/ai/AIPlayer.java:426: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:426: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:427: Found 'DD'-anomaly for variable 'ms' (lines '427'-'428'). +src/net/sf/freecol/server/ai/AIPlayer.java:427: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:427: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:427: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:429: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:432: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:434: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:434: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/AIPlayer.java:434: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:438: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:449: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:450: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/AIPlayer.java:450: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:452: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:453: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:455: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:455: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:455: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:457: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:467: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:468: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:469: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:469: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:479: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:480: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:480: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:491: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:491: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:492: Found 'DD'-anomaly for variable 'loc' (lines '492'-'494'). +src/net/sf/freecol/server/ai/AIPlayer.java:496: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:507: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:507: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:508: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:508: Useless parentheses. +src/net/sf/freecol/server/ai/AIPlayer.java:509: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:519: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:520: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/AIPlayer.java:520: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:532: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:533: Found 'DD'-anomaly for variable 'result' (lines '533'-'535'). +src/net/sf/freecol/server/ai/AIPlayer.java:557: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/AIPlayer.java:557: Found 'UR'-anomaly for variable 'aiu' (lines '557'-'561'). +src/net/sf/freecol/server/ai/AIPlayer.java:557: Parameter 'aiUnits' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:557: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:559: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:560: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:562: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:562: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:566: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/ai/AIPlayer.java:567: There is log block not surrounded by if +src/net/sf/freecol/server/ai/AIPlayer.java:569: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/AIPlayer.java:569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/AIPlayer.java:574: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:587: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:596: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:596: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:597: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:597: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:608: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:620: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:635: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/AIPlayer.java:657: Parameter 'tax' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:678: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/server/ai/AIPlayer.java:678: Parameter 'ffs' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:685: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/AIPlayer.java:685: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/AIPlayer.java:692: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/AIPlayer.java:692: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:702: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIPlayer.java:702: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:710: Local variable 'rnd' could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:712: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/AIPlayer.java:720: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/AIPlayer.java:720: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/AIPlayer.java:723: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/CacheEntryComparator.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/CacheEntryComparator.java:28: Each class should declare at least one constructor +src/net/sf/freecol/server/ai/CacheEntryComparator.java:28: The class 'CacheEntryComparator' has a Cyclomatic Complexity of 8 (Highest = 14). +src/net/sf/freecol/server/ai/CacheEntryComparator.java:28: The class 'CacheEntryComparator' has a Modified Cyclomatic Complexity of 8 (Highest = 14). +src/net/sf/freecol/server/ai/CacheEntryComparator.java:28: The class 'CacheEntryComparator' has a Standard Cyclomatic Complexity of 8 (Highest = 14). +src/net/sf/freecol/server/ai/CacheEntryComparator.java:30: Parameter 'entry1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/CacheEntryComparator.java:30: Parameter 'entry2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/CacheEntryComparator.java:30: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/CacheEntryComparator.java:35: Parameter 'entry1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/CacheEntryComparator.java:35: Parameter 'entry2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/CacheEntryComparator.java:35: The method 'compare' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/CacheEntryComparator.java:35: The method 'compare' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/CacheEntryComparator.java:35: The method 'compare' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/CacheEntryComparator.java:35: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/CacheEntryComparator.java:37: Local variable 'production' could be declared final +src/net/sf/freecol/server/ai/CacheEntryComparator.java:38: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/CacheEntryComparator.java:39: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:42: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:44: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:47: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:51: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:51: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/CacheEntryComparator.java:52: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/CacheEntryComparator.java:54: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:57: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:61: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:61: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/CacheEntryComparator.java:62: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/CacheEntryComparator.java:64: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:67: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:70: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:73: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/CacheEntryComparator.java:76: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ColonyPlan.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/ai/ColonyPlan.java:20: Possible God class (WMC=303, ATFD=263, TCC=0.03694581280788178) +src/net/sf/freecol/server/ai/ColonyPlan.java:57: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ColonyPlan.java:77: Avoid really long classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:77: The class 'ColonyPlan' has a Cyclomatic Complexity of 10 (Highest = 77). +src/net/sf/freecol/server/ai/ColonyPlan.java:77: The class 'ColonyPlan' has a Modified Cyclomatic Complexity of 9 (Highest = 69). +src/net/sf/freecol/server/ai/ColonyPlan.java:77: The class 'ColonyPlan' has a Standard Cyclomatic Complexity of 9 (Highest = 69). +src/net/sf/freecol/server/ai/ColonyPlan.java:77: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/ColonyPlan.java:79: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/ColonyPlan.java:79: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:82: Avoid excessively long variable names like LOW_PRODUCTION_THRESHOLD +src/net/sf/freecol/server/ai/ColonyPlan.java:88: Avoid excessively long variable names like PRODUCTION_TURNOVER_TURNS +src/net/sf/freecol/server/ai/ColonyPlan.java:103: Parameter 'size' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:104: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:104: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:111: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:111: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:114: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:117: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:122: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:122: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:123: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:123: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:124: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:124: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:125: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:125: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:127: Parameter 'support' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:127: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:127: Parameter 'weight' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:127: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:134: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:148: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:148: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:148: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:154: Avoid excessively long variable names like buildPlanComparator +src/net/sf/freecol/server/ai/ColonyPlan.java:154: Variables that are final and static should be all capitals, 'buildPlanComparator' is not all capitals. +src/net/sf/freecol/server/ai/ColonyPlan.java:157: Avoid variables with short names like b1 +src/net/sf/freecol/server/ai/ColonyPlan.java:157: Avoid variables with short names like b2 +src/net/sf/freecol/server/ai/ColonyPlan.java:157: Parameter 'b1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:157: Parameter 'b2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:157: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:158: Avoid variables with short names like d +src/net/sf/freecol/server/ai/ColonyPlan.java:158: Local variable 'd' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:159: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:159: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:164: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:167: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:167: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:173: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:173: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:174: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:174: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:174: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:175: Avoid excessively long variable names like immigrationGoodsTypes +src/net/sf/freecol/server/ai/ColonyPlan.java:175: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:175: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:175: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:176: Avoid excessively long variable names like militaryGoodsTypes +src/net/sf/freecol/server/ai/ColonyPlan.java:176: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:176: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:176: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:177: Avoid excessively long variable names like rawBuildingGoodsTypes +src/net/sf/freecol/server/ai/ColonyPlan.java:177: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:177: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:177: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:178: Avoid excessively long variable names like buildingGoodsTypes +src/net/sf/freecol/server/ai/ColonyPlan.java:178: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:178: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:178: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:179: Avoid excessively long variable names like rawLuxuryGoodsTypes +src/net/sf/freecol/server/ai/ColonyPlan.java:179: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:179: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:179: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:180: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:180: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:180: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:181: Avoid excessively long variable names like otherRawGoodsTypes +src/net/sf/freecol/server/ai/ColonyPlan.java:181: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:181: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ColonyPlan.java:181: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:190: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:190: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:191: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:192: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:216: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:237: Found 'UR'-anomaly for variable 'b' (lines '237'-'239'). +src/net/sf/freecol/server/ai/ColonyPlan.java:238: Local variable 'build' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:239: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:239: Local variable 'b' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:250: Avoid variables with short names like bp +src/net/sf/freecol/server/ai/ColonyPlan.java:250: Avoid variables with short names like p +src/net/sf/freecol/server/ai/ColonyPlan.java:250: Local variable 'bp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:251: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:259: Found 'UR'-anomaly for variable 'b' (lines '259'-'262'). +src/net/sf/freecol/server/ai/ColonyPlan.java:260: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/ColonyPlan.java:260: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:262: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:262: Local variable 'b' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:274: Avoid variables with short names like wp +src/net/sf/freecol/server/ai/ColonyPlan.java:274: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:286: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:287: Avoid variables with short names like wp +src/net/sf/freecol/server/ai/ColonyPlan.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:298: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/ColonyPlan.java:298: Found 'UR'-anomaly for variable 'ag' (lines '298'-'301'). +src/net/sf/freecol/server/ai/ColonyPlan.java:298: Parameter 'build' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:298: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:298: The method 'refine' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/server/ai/ColonyPlan.java:298: The method 'refine' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/ColonyPlan.java:298: The method 'refine' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/ColonyPlan.java:299: Found 'DU'-anomaly for variable 'required' (lines '299'-'363'). +src/net/sf/freecol/server/ai/ColonyPlan.java:299: Local variable 'required' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:300: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:303: Found 'DU'-anomaly for variable 'suppressed' (lines '303'-'363'). +src/net/sf/freecol/server/ai/ColonyPlan.java:303: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/ColonyPlan.java:303: Local variable 'suppressed' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:325: Local variable 'plans' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:326: Found 'DU'-anomaly for variable 'offset' (lines '326'-'363'). +src/net/sf/freecol/server/ai/ColonyPlan.java:327: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:329: Local variable 'wlp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:329: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:330: Avoid variables with short names like g +src/net/sf/freecol/server/ai/ColonyPlan.java:330: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:331: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:331: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:332: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:332: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:333: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:333: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:336: Found 'DU'-anomaly for variable 'offset' (lines '336'-'363'). +src/net/sf/freecol/server/ai/ColonyPlan.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:338: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ColonyPlan.java:338: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:346: Avoid variables with short names like n +src/net/sf/freecol/server/ai/ColonyPlan.java:346: Found 'DD'-anomaly for variable 'idx' (lines '346'-'346'). +src/net/sf/freecol/server/ai/ColonyPlan.java:346: Found 'DU'-anomaly for variable 'idx' (lines '346'-'363'). +src/net/sf/freecol/server/ai/ColonyPlan.java:346: Local variable 'idx' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:346: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/ai/ColonyPlan.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:349: Avoid assignments in operands +src/net/sf/freecol/server/ai/ColonyPlan.java:349: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:349: Found 'DD'-anomaly for variable 'wls' (lines '349'-'337'). +src/net/sf/freecol/server/ai/ColonyPlan.java:349: Found 'DD'-anomaly for variable 'wls' (lines '349'-'349'). +src/net/sf/freecol/server/ai/ColonyPlan.java:349: Found 'DU'-anomaly for variable 'wls' (lines '349'-'363'). +src/net/sf/freecol/server/ai/ColonyPlan.java:349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:350: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:352: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:374: Local variable 'production' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:406: Found 'UR'-anomaly for variable 'g' (lines '406'-'410'). +src/net/sf/freecol/server/ai/ColonyPlan.java:406: Found 'UR'-anomaly for variable 'wl' (lines '406'-'410'). +src/net/sf/freecol/server/ai/ColonyPlan.java:407: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/ColonyPlan.java:407: Local variable 'production' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:408: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:409: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:409: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:410: Avoid variables with short names like p +src/net/sf/freecol/server/ai/ColonyPlan.java:410: Local variable 'p' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:412: Avoid variables with short names like m +src/net/sf/freecol/server/ai/ColonyPlan.java:414: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ColonyPlan.java:424: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ColonyPlan.java:443: Found 'UR'-anomaly for variable 'g' (lines '443'-'454'). +src/net/sf/freecol/server/ai/ColonyPlan.java:443: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:443: The method 'updateGoodsTypeLists' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/server/ai/ColonyPlan.java:443: The method 'updateGoodsTypeLists' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/ColonyPlan.java:443: The method 'updateGoodsTypeLists' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/ColonyPlan.java:453: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:470: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:475: There is log block not surrounded by if +src/net/sf/freecol/server/ai/ColonyPlan.java:490: Found 'UR'-anomaly for variable 'g' (lines '490'-'503'). +src/net/sf/freecol/server/ai/ColonyPlan.java:490: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:490: The method 'updateRawMaterials' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/server/ai/ColonyPlan.java:490: The method 'updateRawMaterials' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/ColonyPlan.java:490: The method 'updateRawMaterials' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/ColonyPlan.java:490: The method updateRawMaterials() has an NPath complexity of 1687 +src/net/sf/freecol/server/ai/ColonyPlan.java:491: Local variable 'player' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:492: Local variable 'market' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:492: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:493: Local variable 'nationType' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:493: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:494: Avoid excessively long variable names like primaryRawMaterial +src/net/sf/freecol/server/ai/ColonyPlan.java:495: Avoid excessively long variable names like secondaryRawMaterial +src/net/sf/freecol/server/ai/ColonyPlan.java:500: Local variable 'rawMaterials' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:501: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:502: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:504: Avoid variables with short names like e +src/net/sf/freecol/server/ai/ColonyPlan.java:514: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:515: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:516: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:517: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:518: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:518: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:526: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:529: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:535: Found 'DU'-anomaly for variable 'secondaryRawMaterial' (lines '535'-'556'). +src/net/sf/freecol/server/ai/ColonyPlan.java:536: Found 'DU'-anomaly for variable 'secondaryValue' (lines '536'-'556'). +src/net/sf/freecol/server/ai/ColonyPlan.java:538: Found 'DU'-anomaly for variable 'primaryValue' (lines '538'-'556'). +src/net/sf/freecol/server/ai/ColonyPlan.java:540: Found 'DU'-anomaly for variable 'secondaryRawMaterial' (lines '540'-'556'). +src/net/sf/freecol/server/ai/ColonyPlan.java:541: Found 'DU'-anomaly for variable 'secondaryValue' (lines '541'-'556'). +src/net/sf/freecol/server/ai/ColonyPlan.java:546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:547: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:552: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:563: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:563: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:565: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:565: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:567: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:567: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:569: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:569: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:571: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:571: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:573: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:573: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:575: Avoid excessively long variable names like IMMIGRATION_WEIGHT +src/net/sf/freecol/server/ai/ColonyPlan.java:575: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:575: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:577: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:577: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:579: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:579: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:581: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:581: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:583: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:583: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:585: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:585: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:587: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:587: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:589: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/ColonyPlan.java:589: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:597: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:598: Avoid variables with short names like bp +src/net/sf/freecol/server/ai/ColonyPlan.java:601: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ColonyPlan.java:610: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:611: Parameter 'support' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:611: Parameter 'weight' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:612: Avoid variables with short names like bp +src/net/sf/freecol/server/ai/ColonyPlan.java:612: Local variable 'bp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:615: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:620: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:633: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:633: The method 'prioritizeProduction' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/server/ai/ColonyPlan.java:633: The method 'prioritizeProduction' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/server/ai/ColonyPlan.java:633: The method 'prioritizeProduction' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/server/ai/ColonyPlan.java:634: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:635: Local variable 'player' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:636: Local variable 'nationType' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:637: Found 'DU'-anomaly for variable 'advantage' (lines '637'-'666'). +src/net/sf/freecol/server/ai/ColonyPlan.java:637: Local variable 'advantage' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:637: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:637: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:638: Found 'DD'-anomaly for variable 'ret' (lines '638'-'646'). +src/net/sf/freecol/server/ai/ColonyPlan.java:638: Found 'DD'-anomaly for variable 'ret' (lines '638'-'649'). +src/net/sf/freecol/server/ai/ColonyPlan.java:638: Found 'DD'-anomaly for variable 'ret' (lines '638'-'653'). +src/net/sf/freecol/server/ai/ColonyPlan.java:638: Found 'DD'-anomaly for variable 'ret' (lines '638'-'657'). +src/net/sf/freecol/server/ai/ColonyPlan.java:638: Found 'DD'-anomaly for variable 'ret' (lines '638'-'662'). +src/net/sf/freecol/server/ai/ColonyPlan.java:638: Found 'DU'-anomaly for variable 'ret' (lines '638'-'666'). +src/net/sf/freecol/server/ai/ColonyPlan.java:639: Found 'DD'-anomaly for variable 'factor' (lines '639'-'645'). +src/net/sf/freecol/server/ai/ColonyPlan.java:639: Found 'DD'-anomaly for variable 'factor' (lines '639'-'656'). +src/net/sf/freecol/server/ai/ColonyPlan.java:639: Found 'DD'-anomaly for variable 'factor' (lines '639'-'660'). +src/net/sf/freecol/server/ai/ColonyPlan.java:639: Found 'DU'-anomaly for variable 'factor' (lines '639'-'666'). +src/net/sf/freecol/server/ai/ColonyPlan.java:640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:645: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:652: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:652: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:652: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:654: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:654: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:656: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:660: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:660: Found 'DU'-anomaly for variable 'factor' (lines '660'-'666'). +src/net/sf/freecol/server/ai/ColonyPlan.java:660: The String literal "trade" appears 4 times in this file; the first occurrence is on line 660 +src/net/sf/freecol/server/ai/ColonyPlan.java:661: Avoid variables with short names like f +src/net/sf/freecol/server/ai/ColonyPlan.java:661: Local variable 'f' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:671: Avoid really long methods. +src/net/sf/freecol/server/ai/ColonyPlan.java:671: Found 'UR'-anomaly for variable 'a' (lines '671'-'742'). +src/net/sf/freecol/server/ai/ColonyPlan.java:671: Found 'UR'-anomaly for variable 'ag' (lines '671'-'721'). +src/net/sf/freecol/server/ai/ColonyPlan.java:671: Found 'UR'-anomaly for variable 'bp' (lines '671'-'820'). +src/net/sf/freecol/server/ai/ColonyPlan.java:671: Found 'UR'-anomaly for variable 't' (lines '671'-'718'). +src/net/sf/freecol/server/ai/ColonyPlan.java:671: Found 'UR'-anomaly for variable 'type' (lines '671'-'692'). +src/net/sf/freecol/server/ai/ColonyPlan.java:671: Found 'UR'-anomaly for variable 'unitType' (lines '671'-'800'). +src/net/sf/freecol/server/ai/ColonyPlan.java:671: The method 'updateBuildableTypes' has a Cyclomatic Complexity of 53. +src/net/sf/freecol/server/ai/ColonyPlan.java:671: The method 'updateBuildableTypes' has a Modified Cyclomatic Complexity of 46. +src/net/sf/freecol/server/ai/ColonyPlan.java:671: The method 'updateBuildableTypes' has a Standard Cyclomatic Complexity of 49. +src/net/sf/freecol/server/ai/ColonyPlan.java:671: The method updateBuildableTypes() has an NCSS line count of 119 +src/net/sf/freecol/server/ai/ColonyPlan.java:671: The method updateBuildableTypes() has an NPath complexity of 1050120728 +src/net/sf/freecol/server/ai/ColonyPlan.java:672: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:674: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/ColonyPlan.java:674: Local variable 'advantage' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:674: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:689: Local variable 'player' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:690: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:690: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:691: Found 'DD'-anomaly for variable 'expectFail' (lines '691'-'765'). +src/net/sf/freecol/server/ai/ColonyPlan.java:692: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:695: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:696: Found 'DD'-anomaly for variable 'factor' (lines '696'-'697'). +src/net/sf/freecol/server/ai/ColonyPlan.java:697: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:701: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:703: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:709: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:709: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:712: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:715: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:716: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/ai/ColonyPlan.java:717: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:717: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:719: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:720: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:720: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:721: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:721: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:722: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:723: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:725: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:737: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:738: Found 'DD'-anomaly for variable 'factor' (lines '738'-'739'). +src/net/sf/freecol/server/ai/ColonyPlan.java:739: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:740: Found 'DD'-anomaly for variable 'support' (lines '740'-'743'). +src/net/sf/freecol/server/ai/ColonyPlan.java:741: Local variable 'a' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:741: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:742: Local variable 'scopes' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:743: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:743: Found 'DD'-anomaly for variable 'support' (lines '743'-'743'). +src/net/sf/freecol/server/ai/ColonyPlan.java:743: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:749: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:754: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:756: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:761: Local variable 'output' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:761: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:762: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/ColonyPlan.java:768: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:768: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:769: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:769: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:770: These nested if statements could be combined +src/net/sf/freecol/server/ai/ColonyPlan.java:776: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:778: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:782: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:789: There is log block not surrounded by if +src/net/sf/freecol/server/ai/ColonyPlan.java:793: Found 'DD'-anomaly for variable 'wagonNeed' (lines '793'-'796'). +src/net/sf/freecol/server/ai/ColonyPlan.java:793: Found 'DU'-anomaly for variable 'wagonNeed' (lines '793'-'834'). +src/net/sf/freecol/server/ai/ColonyPlan.java:795: Local variable 'wagons' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:796: Found 'DU'-anomaly for variable 'wagonNeed' (lines '796'-'834'). +src/net/sf/freecol/server/ai/ColonyPlan.java:796: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:796: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:799: Local variable 'unitType' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:799: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:800: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:801: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:802: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/ColonyPlan.java:802: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/ColonyPlan.java:803: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:808: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:809: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/ColonyPlan.java:809: These nested if statements could be combined +src/net/sf/freecol/server/ai/ColonyPlan.java:811: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:819: Local variable 'bp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:820: Found 'DU'-anomaly for variable 'difficulty' (lines '820'-'834'). +src/net/sf/freecol/server/ai/ColonyPlan.java:820: Local variable 'difficulty' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:820: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/ColonyPlan.java:821: Avoid variables with short names like ag +src/net/sf/freecol/server/ai/ColonyPlan.java:822: Avoid variables with short names like ag +src/net/sf/freecol/server/ai/ColonyPlan.java:827: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:827: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:827: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:836: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ColonyPlan.java:851: Found 'UR'-anomaly for variable 'entry' (lines '851'-'855'). +src/net/sf/freecol/server/ai/ColonyPlan.java:851: Found 'UR'-anomaly for variable 'entry' (lines '851'-'855'). +src/net/sf/freecol/server/ai/ColonyPlan.java:851: Found 'UR'-anomaly for variable 'wl' (lines '851'-'862'). +src/net/sf/freecol/server/ai/ColonyPlan.java:851: Found 'UR'-anomaly for variable 'wl' (lines '851'-'862'). +src/net/sf/freecol/server/ai/ColonyPlan.java:851: Found 'UR'-anomaly for variable 'wlp' (lines '851'-'875'). +src/net/sf/freecol/server/ai/ColonyPlan.java:851: Found 'UR'-anomaly for variable 'wlp' (lines '851'-'875'). +src/net/sf/freecol/server/ai/ColonyPlan.java:851: Parameter 'production' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:851: The method 'updatePlans' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/ColonyPlan.java:851: The method 'updatePlans' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/ColonyPlan.java:851: The method 'updatePlans' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/ColonyPlan.java:851: The method updatePlans() has an NPath complexity of 918 +src/net/sf/freecol/server/ai/ColonyPlan.java:853: Local variable 'entry' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:855: Avoid variables with short names like g +src/net/sf/freecol/server/ai/ColonyPlan.java:855: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:855: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:857: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:857: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:859: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:861: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:861: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:861: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:862: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:862: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:863: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ColonyPlan.java:872: Local variable 'oldPlans' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:874: Local variable 'wlp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:875: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:875: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:875: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:884: Avoid variables with short names like w1 +src/net/sf/freecol/server/ai/ColonyPlan.java:884: Avoid variables with short names like w2 +src/net/sf/freecol/server/ai/ColonyPlan.java:884: Parameter 'w1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:884: Parameter 'w2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:884: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:885: Avoid variables with short names like g1 +src/net/sf/freecol/server/ai/ColonyPlan.java:885: Local variable 'g1' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:886: Avoid variables with short names like g2 +src/net/sf/freecol/server/ai/ColonyPlan.java:886: Local variable 'g2' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:887: Avoid variables with short names like i1 +src/net/sf/freecol/server/ai/ColonyPlan.java:888: Avoid variables with short names like i2 +src/net/sf/freecol/server/ai/ColonyPlan.java:889: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:889: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:890: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:890: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:893: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:894: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:906: The method 'updateProductionList' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/server/ai/ColonyPlan.java:906: The method 'updateProductionList' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/server/ai/ColonyPlan.java:906: The method 'updateProductionList' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/server/ai/ColonyPlan.java:906: The method updateProductionList() has an NPath complexity of 960 +src/net/sf/freecol/server/ai/ColonyPlan.java:907: Avoid excessively long variable names like productionComparator +src/net/sf/freecol/server/ai/ColonyPlan.java:907: Found 'DU'-anomaly for variable 'productionComparator' (lines '907'-'983'). +src/net/sf/freecol/server/ai/ColonyPlan.java:907: Found 'DU'-anomaly for variable 'productionComparator' (lines '907'-'983'). +src/net/sf/freecol/server/ai/ColonyPlan.java:907: Found 'DU'-anomaly for variable 'productionComparator' (lines '907'-'983'). +src/net/sf/freecol/server/ai/ColonyPlan.java:910: Avoid variables with short names like g1 +src/net/sf/freecol/server/ai/ColonyPlan.java:910: Avoid variables with short names like g2 +src/net/sf/freecol/server/ai/ColonyPlan.java:910: Parameter 'g1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:910: Parameter 'g2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:910: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:911: Avoid variables with short names like p1 +src/net/sf/freecol/server/ai/ColonyPlan.java:911: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:911: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:911: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:911: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:911: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:913: Avoid variables with short names like p2 +src/net/sf/freecol/server/ai/ColonyPlan.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:918: Local variable 'toAdd' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:921: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/ColonyPlan.java:922: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:923: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:932: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:934: Local variable 'raw' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:943: Avoid variables with short names like g1 +src/net/sf/freecol/server/ai/ColonyPlan.java:943: Avoid variables with short names like g2 +src/net/sf/freecol/server/ai/ColonyPlan.java:943: Parameter 'g1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:943: Parameter 'g2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:943: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:944: Avoid variables with short names like i1 +src/net/sf/freecol/server/ai/ColonyPlan.java:944: Local variable 'i1' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:945: Avoid variables with short names like i2 +src/net/sf/freecol/server/ai/ColonyPlan.java:945: Local variable 'i2' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:950: Local variable 'make' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:951: Local variable 'raw' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:951: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:967: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:968: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:975: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:976: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:977: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:993: Found 'UR'-anomaly for variable 'other' (lines '993'-'999'). +src/net/sf/freecol/server/ai/ColonyPlan.java:993: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:993: Parameter 'expert' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:993: Parameter 'others' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:994: Found 'DU'-anomaly for variable 'oldRole' (lines '994'-'1,017'). +src/net/sf/freecol/server/ai/ColonyPlan.java:994: Local variable 'oldRole' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:995: Found 'DU'-anomaly for variable 'oldRoleCount' (lines '995'-'1,017'). +src/net/sf/freecol/server/ai/ColonyPlan.java:995: Local variable 'oldRoleCount' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:996: Found 'DU'-anomaly for variable 'work' (lines '996'-'1,017'). +src/net/sf/freecol/server/ai/ColonyPlan.java:996: Local variable 'work' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:996: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:997: Found 'DU'-anomaly for variable 'oldWork' (lines '997'-'1,017'). +src/net/sf/freecol/server/ai/ColonyPlan.java:997: Local variable 'oldWork' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:998: Local variable 'other' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:999: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1002: Avoid variables with short names like l1 +src/net/sf/freecol/server/ai/ColonyPlan.java:1002: Local variable 'l1' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1003: Avoid variables with short names like l2 +src/net/sf/freecol/server/ai/ColonyPlan.java:1003: Local variable 'l2' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1008: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1009: Local variable 'tmpRole' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1010: Local variable 'tmpRoleCount' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1013: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1027: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1028: Parameter 'plans' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1032: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: Avoid really long methods. +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: Avoid variables with short names like wl +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: Found 'UR'-anomaly for variable 'u' (lines '1,051'-'1,080'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: Parameter 'wl' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: The method 'getBestWorker' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: The method 'getBestWorker' has a Modified Cyclomatic Complexity of 23. +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: The method 'getBestWorker' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/server/ai/ColonyPlan.java:1051: The method getBestWorker() has an NPath complexity of 8803080 +src/net/sf/freecol/server/ai/ColonyPlan.java:1052: Parameter 'workers' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1053: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1053: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1054: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/ColonyPlan.java:1054: Found 'DU'-anomaly for variable 'colony' (lines '1,054'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1055: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/ColonyPlan.java:1055: Found 'DU'-anomaly for variable 'outputType' (lines '1,055'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1055: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1055: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1060: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/ColonyPlan.java:1061: Avoid variables with short names like u +src/net/sf/freecol/server/ai/ColonyPlan.java:1061: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1062: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1062: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1063: Local variable 'oldLoc' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1063: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1064: Local variable 'oldWork' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1064: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1065: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1066: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1067: Local variable 'production' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1068: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1069: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1070: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1070: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:1070: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1070: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1074: Local variable 'todo' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1075: Local variable 'best' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1076: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1077: Found 'DD'-anomaly for variable 'special' (lines '1,077'-'1,092'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1078: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1079: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1080: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1081: Local variable 'oldLoc' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1081: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1082: Local variable 'oldWork' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1082: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1083: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1084: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1086: Local variable 'value' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1086: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1088: Found 'DD'-anomaly for variable 'bestValue' (lines '1,088'-'1,122'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1088: Found 'DU'-anomaly for variable 'bestValue' (lines '1,088'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1089: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1090: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1091: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1091: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1092: Found 'DD'-anomaly for variable 'special' (lines '1,092'-'1,092'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1092: Found 'DU'-anomaly for variable 'special' (lines '1,092'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1094: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1095: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1096: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1096: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1106: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1107: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1111: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1111: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1119: Local variable 'spec' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1119: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1120: Found 'DU'-anomaly for variable 'expert' (lines '1,120'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1120: Local variable 'expert' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1122: Found 'DU'-anomaly for variable 'bestValue' (lines '1,122'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1123: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1124: Local variable 'relevant' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1125: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1125: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1127: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1130: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1136: Found 'DU'-anomaly for variable 'bestValue' (lines '1,136'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1143: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1149: Found 'DU'-anomaly for variable 'worstSkill' (lines '1,149'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1150: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:1150: Found 'DD'-anomaly for variable 'special' (lines '1,150'-'1,153'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1151: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1153: Found 'DD'-anomaly for variable 'special' (lines '1,153'-'1,153'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1154: Found 'DU'-anomaly for variable 'worstSkill' (lines '1,154'-'1,158'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1154: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1168: Found 'UR'-anomaly for variable 'r' (lines '1,168'-'1,172'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1168: Parameter 'spec' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1168: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1169: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1169: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1171: Local variable 'r' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1172: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1173: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1175: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: Avoid really long methods. +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: Found 'UR'-anomaly for variable 'outdoorRole' (lines '1,188'-'1,230'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: Found 'UR'-anomaly for variable 'outdoorRole' (lines '1,188'-'1,230'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: Found 'UR'-anomaly for variable 'u' (lines '1,188'-'1,205'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: Found 'UR'-anomaly for variable 'u' (lines '1,188'-'1,205'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: Parameter 'preferScout' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: Parameter 'workers' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: The method 'assignWorkers' has a Cyclomatic Complexity of 77. +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: The method 'assignWorkers' has a Modified Cyclomatic Complexity of 69. +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: The method 'assignWorkers' has a Standard Cyclomatic Complexity of 69. +src/net/sf/freecol/server/ai/ColonyPlan.java:1188: The method assignWorkers() has an NCSS line count of 231 +src/net/sf/freecol/server/ai/ColonyPlan.java:1189: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/ColonyPlan.java:1189: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1190: Found 'DU'-anomaly for variable 'foodType' (lines '1,190'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1190: Found 'DU'-anomaly for variable 'foodType' (lines '1,190'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1194: Found 'DU'-anomaly for variable 'produce' (lines '1,194'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1194: Found 'DU'-anomaly for variable 'produce' (lines '1,194'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1195: Found 'DU'-anomaly for variable 'foodPlans' (lines '1,195'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1195: Found 'DU'-anomaly for variable 'foodPlans' (lines '1,195'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1195: Local variable 'foodPlans' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1196: Found 'DU'-anomaly for variable 'workPlans' (lines '1,196'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1196: Found 'DU'-anomaly for variable 'workPlans' (lines '1,196'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1196: Local variable 'workPlans' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1200: Local variable 'tile' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1203: Local variable 'otherWorkers' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1205: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1205: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1210: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1218: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1223: Local variable 'tmp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1227: Local variable 'outdoorRole' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1228: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ColonyPlan.java:1228: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1229: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/ColonyPlan.java:1229: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1229: Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() +src/net/sf/freecol/server/ai/ColonyPlan.java:1232: Avoid assignments in operands +src/net/sf/freecol/server/ai/ColonyPlan.java:1232: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1232: These nested if statements could be combined +src/net/sf/freecol/server/ai/ColonyPlan.java:1234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1247: Found 'DU'-anomaly for variable 'soldierComparator' (lines '1,247'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1247: Found 'DU'-anomaly for variable 'soldierComparator' (lines '1,247'-'1,551'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1247: Local variable 'soldierComparator' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1249: Avoid variables with short names like u1 +src/net/sf/freecol/server/ai/ColonyPlan.java:1249: Avoid variables with short names like u2 +src/net/sf/freecol/server/ai/ColonyPlan.java:1249: Parameter 'u1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1249: Parameter 'u2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1249: The method compare() has an NPath complexity of 1352 +src/net/sf/freecol/server/ai/ColonyPlan.java:1249: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ColonyPlan.java:1252: Avoid variables with short names like g1 +src/net/sf/freecol/server/ai/ColonyPlan.java:1252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1253: Avoid variables with short names like g2 +src/net/sf/freecol/server/ai/ColonyPlan.java:1253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1256: Avoid variables with short names like i +src/net/sf/freecol/server/ai/ColonyPlan.java:1257: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1257: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1259: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1259: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1269: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1270: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/ColonyPlan.java:1270: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1270: Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() +src/net/sf/freecol/server/ai/ColonyPlan.java:1271: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1272: Local variable 'role' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1276: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1281: Local variable 'buildGoods' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1282: Local variable 'build' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1282: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1283: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1291: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:1292: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:1293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1297: Avoid assignments in operands +src/net/sf/freecol/server/ai/ColonyPlan.java:1297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1306: Avoid variables with short names like wl +src/net/sf/freecol/server/ai/ColonyPlan.java:1310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1322: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:1323: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1323: The String literal " " appears 4 times in this file; the first occurrence is on line 1,323 +src/net/sf/freecol/server/ai/ColonyPlan.java:1324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1328: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/ColonyPlan.java:1328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1332: Avoid assignments in operands +src/net/sf/freecol/server/ai/ColonyPlan.java:1337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1346: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1355: Local variable 'net' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1356: Local variable 'count' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1356: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1361: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1362: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:1363: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1380: Local variable 'raw' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1380: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1381: Local variable 'rawNeeded' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1381: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1381: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1381: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1381: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1381: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1382: Avoid variables with short names like ag +src/net/sf/freecol/server/ai/ColonyPlan.java:1385: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1386: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1386: Useless parentheses. +src/net/sf/freecol/server/ai/ColonyPlan.java:1387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1397: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1398: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1409: Local variable 'rawWlp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1414: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1416: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1424: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1426: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1427: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/ai/ColonyPlan.java:1432: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1433: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1444: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1445: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1445: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1446: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ColonyPlan.java:1446: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1447: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1449: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1450: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1451: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1452: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1460: Local variable 'w' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1461: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1462: Avoid variables with short names like wl +src/net/sf/freecol/server/ai/ColonyPlan.java:1462: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1462: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1462: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1463: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ColonyPlan.java:1463: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1464: Local variable 'oldWork' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1464: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1465: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1466: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1467: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1472: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1473: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1484: Local variable 'experts' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1485: Local variable 'nonExperts' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1486: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1486: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1487: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/ColonyPlan.java:1487: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1487: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1488: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1488: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1488: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1492: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1496: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1497: Avoid variables with short names like u1 +src/net/sf/freecol/server/ai/ColonyPlan.java:1497: Local variable 'u1' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1497: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1499: Avoid assignments in operands +src/net/sf/freecol/server/ai/ColonyPlan.java:1499: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/ColonyPlan.java:1500: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1500: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1501: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1501: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1502: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1503: Avoid assignments in operands +src/net/sf/freecol/server/ai/ColonyPlan.java:1503: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/ColonyPlan.java:1504: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1504: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1505: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1505: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1506: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1511: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1512: Local variable 'work' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1512: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1512: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1514: Local variable 'other' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1514: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1516: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1517: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1517: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1526: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1527: Local variable 'role' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1527: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1528: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1530: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1530: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1530: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1530: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1531: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1533: Avoid using if...else statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1535: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1535: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1536: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1537: There is log block not surrounded by if +src/net/sf/freecol/server/ai/ColonyPlan.java:1538: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1538: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1538: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1545: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1546: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1546: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1549: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/ColonyPlan.java:1549: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ColonyPlan.java:1549: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1560: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1561: Local variable 'name' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1573: Found 'UR'-anomaly for variable 'wlp' (lines '1,573'-'1,582'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1574: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/ColonyPlan.java:1574: Avoid unused local variables such as 'tile'. +src/net/sf/freecol/server/ai/ColonyPlan.java:1574: Found 'DU'-anomaly for variable 'tile' (lines '1,574'-'1,595'). +src/net/sf/freecol/server/ai/ColonyPlan.java:1575: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/ColonyPlan.java:1575: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1581: Local variable 'wlp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1582: Avoid variables with short names like wl +src/net/sf/freecol/server/ai/ColonyPlan.java:1582: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1583: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1584: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1588: Local variable 'wlp' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1589: Avoid variables with short names like wl +src/net/sf/freecol/server/ai/ColonyPlan.java:1589: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/ColonyPlan.java:1590: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ColonyPlan.java:1591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ColonyPlan.java:1592: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/GoodsWish.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/GoodsWish.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/GoodsWish.java:44: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/GoodsWish.java:47: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/GoodsWish.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/GoodsWish.java:59: Avoid variables with short names like id +src/net/sf/freecol/server/ai/GoodsWish.java:59: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:59: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:62: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/GoodsWish.java:66: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/GoodsWish.java:79: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:79: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:79: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:80: Parameter 'amountRequested' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:80: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:84: Avoid throwing null pointer exceptions. +src/net/sf/freecol/server/ai/GoodsWish.java:102: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:102: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:108: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/GoodsWish.java:117: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:118: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/GoodsWish.java:118: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:132: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:132: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:132: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:136: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/GoodsWish.java:174: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:185: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:198: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:199: Found 'DD'-anomaly for variable 'result' (lines '199'-'200'). +src/net/sf/freecol/server/ai/GoodsWish.java:200: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/GoodsWish.java:207: Avoid excessively long variable names like AMOUNT_REQUESTED_TAG +src/net/sf/freecol/server/ai/GoodsWish.java:207: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/GoodsWish.java:207: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/GoodsWish.java:208: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/GoodsWish.java:208: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/GoodsWish.java:209: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/GoodsWish.java:209: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/GoodsWish.java:216: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/GoodsWish.java:216: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:228: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/GoodsWish.java:228: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:235: Useless parentheses. +src/net/sf/freecol/server/ai/GoodsWish.java:235: Useless parentheses. +src/net/sf/freecol/server/ai/GoodsWish.java:238: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/GoodsWish.java:251: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/GoodsWish.java:251: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/GoodsWish.java:254: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/GoodsWish.java:262: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/GoodsWish.java:262: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/NativeAIPlayer.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:20: Possible God class (WMC=173, ATFD=163, TCC=0.07352941176470588) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:77: The class 'NativeAIPlayer' has a Cyclomatic Complexity of 10 (Highest = 42). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:77: The class 'NativeAIPlayer' has a Modified Cyclomatic Complexity of 8 (Highest = 35). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:77: The class 'NativeAIPlayer' has a Standard Cyclomatic Complexity of 8 (Highest = 35). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:77: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:79: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:79: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/NativeAIPlayer.java:81: Avoid excessively long variable names like MAX_DISTANCE_TO_BRING_GIFTS +src/net/sf/freecol/server/ai/NativeAIPlayer.java:81: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/NativeAIPlayer.java:83: Avoid excessively long variable names like MAX_NUMBER_OF_GIFTS_BEING_DELIVERED +src/net/sf/freecol/server/ai/NativeAIPlayer.java:83: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/NativeAIPlayer.java:85: Avoid excessively long variable names like MAX_DISTANCE_TO_MAKE_DEMANDS +src/net/sf/freecol/server/ai/NativeAIPlayer.java:85: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/NativeAIPlayer.java:87: Avoid excessively long variable names like MAX_NUMBER_OF_DEMANDS +src/net/sf/freecol/server/ai/NativeAIPlayer.java:87: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/NativeAIPlayer.java:93: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/server/ai/NativeAIPlayer.java:93: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:99: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:109: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:109: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:122: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:123: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/NativeAIPlayer.java:123: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:136: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:136: Found 'UR'-anomaly for variable 'is' (lines '136'-'146'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:136: Found 'UR'-anomaly for variable 'u' (lines '136'-'155'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:136: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:137: Avoid unused local variables such as 'aiMain'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:137: Found 'DU'-anomaly for variable 'aiMain' (lines '137'-'160'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:143: Found 'DU'-anomaly for variable 'units' (lines '143'-'160'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:143: Local variable 'units' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:144: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:149: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:149: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:150: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:151: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:151: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:152: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:154: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:155: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:156: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:156: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:157: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:168: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:168: Found 'UR'-anomaly for variable 'p' (lines '168'-'173'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:168: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:172: Local variable 'p' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:173: Local variable 'newStance' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:181: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:192: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:192: Found 'UR'-anomaly for variable 'is' (lines '192'-'201'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:192: Found 'UR'-anomaly for variable 'is' (lines '192'-'207'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:192: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:192: Parameter 'randoms' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:193: Found 'DU'-anomaly for variable 'randomIdx' (lines '193'-'211'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:194: Local variable 'settlements' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:196: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:199: Avoid variables with short names like n +src/net/sf/freecol/server/ai/NativeAIPlayer.java:199: Local variable 'n' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:200: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:201: Use equals() to compare object references. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:205: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:209: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:220: Avoid variables with short names like is +src/net/sf/freecol/server/ai/NativeAIPlayer.java:220: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:220: Found 'UR'-anomaly for variable 'u' (lines '220'-'233'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:220: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:220: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:221: Avoid unused local variables such as 'spec'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:221: Found 'DU'-anomaly for variable 'spec' (lines '221'-'241'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:224: Local variable 'units' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:231: Avoid unused local variables such as 'moreHorses'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:231: Avoid unused local variables such as 'moreMuskets'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:231: Found 'DU'-anomaly for variable 'moreHorses' (lines '231'-'241'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:231: Found 'DU'-anomaly for variable 'moreMuskets' (lines '231'-'241'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:231: Local variable 'moreHorses' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:231: Local variable 'moreMuskets' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:231: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:232: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:233: Avoid variables with short names like r +src/net/sf/freecol/server/ai/NativeAIPlayer.java:233: Local variable 'r' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:235: Local variable 'old' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:236: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Avoid really long methods. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Avoid variables with short names like is +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Found 'UR'-anomaly for variable 't' (lines '250'-'286'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Found 'UR'-anomaly for variable 't' (lines '250'-'286'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Found 'UR'-anomaly for variable 't' (lines '250'-'286'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Found 'UR'-anomaly for variable 'u' (lines '250'-'264'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Found 'UR'-anomaly for variable 'u' (lines '250'-'264'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: Found 'UR'-anomaly for variable 'u' (lines '250'-'264'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: The method 'secureIndianSettlement' has a Cyclomatic Complexity of 42. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: The method 'secureIndianSettlement' has a Modified Cyclomatic Complexity of 35. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: The method 'secureIndianSettlement' has a Standard Cyclomatic Complexity of 35. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: The method secureIndianSettlement() has an NCSS line count of 117 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:250: The method secureIndianSettlement() has an NPath complexity of 565488 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:251: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:251: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:254: Avoid variables with short names like cm +src/net/sf/freecol/server/ai/NativeAIPlayer.java:254: Found 'DU'-anomaly for variable 'cm' (lines '254'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:254: Found 'DU'-anomaly for variable 'cm' (lines '254'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:254: Found 'DU'-anomaly for variable 'cm' (lines '254'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:254: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:255: Found 'DU'-anomaly for variable 'minimumDefence' (lines '255'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:255: Found 'DU'-anomaly for variable 'minimumDefence' (lines '255'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:255: Found 'DU'-anomaly for variable 'minimumDefence' (lines '255'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:256: Avoid variables with short names like dm +src/net/sf/freecol/server/ai/NativeAIPlayer.java:259: Local variable 'units' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:260: Local variable 'defenders' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:262: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:262: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:263: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:264: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:268: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:269: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:272: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:282: Found 'DU'-anomaly for variable 'threats' (lines '282'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:282: Found 'DU'-anomaly for variable 'threats' (lines '282'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:282: Found 'DU'-anomaly for variable 'threats' (lines '282'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:285: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:285: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:286: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:286: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:287: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/NativeAIPlayer.java:287: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Found 'DD'-anomaly for variable 'enemy' (lines '288'-'288'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Found 'DD'-anomaly for variable 'enemy' (lines '288'-'288'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Found 'DD'-anomaly for variable 'enemy' (lines '288'-'288'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Found 'DU'-anomaly for variable 'enemy' (lines '288'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Found 'DU'-anomaly for variable 'enemy' (lines '288'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Found 'DU'-anomaly for variable 'enemy' (lines '288'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:290: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:292: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:292: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:292: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:294: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/NativeAIPlayer.java:294: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/NativeAIPlayer.java:295: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:299: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:302: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:303: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:304: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/NativeAIPlayer.java:304: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'bonus' (lines '307'-'310'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'bonus' (lines '307'-'310'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'bonus' (lines '307'-'310'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'bonus' (lines '307'-'313'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'bonus' (lines '307'-'313'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'bonus' (lines '307'-'313'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'threshold' (lines '307'-'309'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'threshold' (lines '307'-'309'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'threshold' (lines '307'-'309'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'threshold' (lines '307'-'312'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'threshold' (lines '307'-'312'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Found 'DD'-anomaly for variable 'threshold' (lines '307'-'312'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:307: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:308: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:313: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:314: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:316: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:317: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:318: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:319: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/NativeAIPlayer.java:319: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:326: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/NativeAIPlayer.java:326: Found 'DU'-anomaly for variable 'homeBonus' (lines '326'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:326: Found 'DU'-anomaly for variable 'homeBonus' (lines '326'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:326: Found 'DU'-anomaly for variable 'homeBonus' (lines '326'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:328: Found 'DU'-anomaly for variable 'isComparator' (lines '328'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:328: Found 'DU'-anomaly for variable 'isComparator' (lines '328'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:328: Found 'DU'-anomaly for variable 'isComparator' (lines '328'-'403'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:331: Avoid variables with short names like u1 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:331: Avoid variables with short names like u2 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:331: Parameter 'u1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:331: Parameter 'u2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:331: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/NativeAIPlayer.java:332: Avoid variables with short names like t1 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:333: Avoid variables with short names like s1 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:334: Avoid variables with short names like t2 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:335: Avoid variables with short names like s2 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:336: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:337: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:343: Local variable 'needed' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:346: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:347: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:347: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:348: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:349: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:349: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:352: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:353: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:356: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:359: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:365: Local variable 'threatTiles' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:368: Avoid variables with short names like t1 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:368: Avoid variables with short names like t2 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:368: Parameter 't1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:368: Parameter 't2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:368: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/NativeAIPlayer.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:376: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:376: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:383: Local variable 'tile' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:386: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:387: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:388: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:389: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:390: Local variable 'distance' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:390: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:396: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:397: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:398: Local variable 'aiUnit' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:399: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:400: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:400: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:401: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: Found 'UR'-anomaly for variable 'aiUnit' (lines '410'-'421'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: Found 'UR'-anomaly for variable 'aiu' (lines '410'-'485'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: The method 'giveNormalMissions' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: The method 'giveNormalMissions' has a Modified Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: The method 'giveNormalMissions' has a Standard Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:410: The method giveNormalMissions() has an NPath complexity of 588 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:411: Avoid unused local variables such as 'aiMain'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:411: Found 'DU'-anomaly for variable 'aiMain' (lines '411'-'490'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:413: Avoid unused local variables such as 'spec'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:413: Found 'DU'-anomaly for variable 'spec' (lines '413'-'490'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:414: Avoid unused local variables such as 'turnNumber'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:414: Found 'DU'-anomaly for variable 'turnNumber' (lines '414'-'490'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:414: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:414: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:415: Local variable 'aiUnits' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:418: Local variable 'done' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:420: Local variable 'aiUnit' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:421: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:422: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:422: Found 'DD'-anomaly for variable 'm' (lines '422'-'422'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:422: Found 'DD'-anomaly for variable 'm' (lines '422'-'443'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:422: Found 'DU'-anomaly for variable 'm' (lines '422'-'490'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:422: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:423: Avoid unused local variables such as 'reason'. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:423: Found 'DD'-anomaly for variable 'reason' (lines '423'-'423'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:423: Found 'DU'-anomaly for variable 'reason' (lines '423'-'490'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:423: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:425: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:434: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:437: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:439: Local variable 'aiUnit' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:440: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:442: Avoid variables with short names like is +src/net/sf/freecol/server/ai/NativeAIPlayer.java:442: Found 'DD'-anomaly for variable 'is' (lines '442'-'442'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:442: Found 'DU'-anomaly for variable 'is' (lines '442'-'490'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:442: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:443: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:445: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:449: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:451: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:456: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/NativeAIPlayer.java:457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:462: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:465: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:471: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:478: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:482: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:485: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:485: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:488: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: Found 'UR'-anomaly for variable 'is' (lines '498'-'511'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: Found 'UR'-anomaly for variable 'ou' (lines '498'-'519'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: Found 'UR'-anomaly for variable 't' (lines '498'-'560'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: Parameter 'randoms' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: The method 'bringGifts' has a Cyclomatic Complexity of 23. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: The method 'bringGifts' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: The method 'bringGifts' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:498: The method bringGifts() has an NPath complexity of 28802 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:500: Avoid variables with short names like cd +src/net/sf/freecol/server/ai/NativeAIPlayer.java:501: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:506: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:506: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:508: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:508: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:511: Local variable 'gift' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:511: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:512: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:516: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:516: Local variable 'availableUnits' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:517: Avoid excessively long variable names like alreadyAssignedUnits +src/net/sf/freecol/server/ai/NativeAIPlayer.java:517: Found 'DD'-anomaly for variable 'alreadyAssignedUnits' (lines '517'-'523'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:518: Local variable 'ou' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:518: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:519: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:522: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:529: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:532: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:533: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:538: Found 'DD'-anomaly for variable 'aiUnit' (lines '538'-'544'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:538: Found 'DU'-anomaly for variable 'aiUnit' (lines '538'-'590'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:539: Local variable 'home' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:539: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:541: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:541: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:541: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:558: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:558: Local variable 'nearbyColonies' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:559: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:559: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:560: Avoid variables with short names like c +src/net/sf/freecol/server/ai/NativeAIPlayer.java:560: Local variable 'c' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:562: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:562: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:567: Local variable 'alarm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:567: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:567: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:568: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:574: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:575: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:578: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:585: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:585: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:585: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:586: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:587: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:589: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: Found 'UR'-anomaly for variable 'is' (lines '598'-'614'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: Found 'UR'-anomaly for variable 'ou' (lines '598'-'615'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: Found 'UR'-anomaly for variable 't' (lines '598'-'655'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: Parameter 'randoms' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: The method 'demandTribute' has a Cyclomatic Complexity of 22. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: The method 'demandTribute' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: The method 'demandTribute' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:598: The method demandTribute() has an NPath complexity of 49922 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:600: Avoid variables with short names like cd +src/net/sf/freecol/server/ai/NativeAIPlayer.java:601: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:606: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:606: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:608: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:608: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:612: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:612: Local variable 'availableUnits' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:613: Avoid excessively long variable names like alreadyAssignedUnits +src/net/sf/freecol/server/ai/NativeAIPlayer.java:613: Found 'DD'-anomaly for variable 'alreadyAssignedUnits' (lines '613'-'618'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:614: Local variable 'ou' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:614: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:615: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:617: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:618: Found 'DD'-anomaly for variable 'alreadyAssignedUnits' (lines '618'-'618'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:620: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:628: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:633: Local variable 'home' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:633: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:635: Found 'DD'-anomaly for variable 'aiUnit' (lines '635'-'640'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:637: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:637: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:637: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:639: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:642: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:642: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:653: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:653: Local variable 'nearbyColonies' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:654: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:654: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:655: Avoid variables with short names like c +src/net/sf/freecol/server/ai/NativeAIPlayer.java:655: Local variable 'c' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:655: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:657: Avoid assignments in operands +src/net/sf/freecol/server/ai/NativeAIPlayer.java:657: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:658: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:658: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:660: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:660: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:662: Local variable 'alarm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:662: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:663: Local variable 'defence' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:663: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:663: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:664: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:664: Useless parentheses. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:664: Useless parentheses. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:665: Local variable 'weight' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:666: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:667: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:673: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:676: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:679: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:684: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:684: Avoid variables with short names like m +src/net/sf/freecol/server/ai/NativeAIPlayer.java:684: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:685: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:688: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:697: Found 'UR'-anomaly for variable 'm' (lines '697'-'702'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:697: Parameter 'sense' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:699: Found 'DU'-anomaly for variable 'penalty' (lines '699'-'707'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:699: Local variable 'penalty' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:699: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:700: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:701: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:701: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:702: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/NativeAIPlayer.java:702: Avoid variables with short names like n +src/net/sf/freecol/server/ai/NativeAIPlayer.java:702: Local variable 'n' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:703: Useless parentheses. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:703: Useless parentheses. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:714: Found 'UR'-anomaly for variable 'au' (lines '714'-'716'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:715: Local variable 'au' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:716: Local variable 'mission' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:717: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:717: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:717: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:718: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:737: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:738: Found 'DU'-anomaly for variable 'nSettlements' (lines '738'-'773'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:738: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:739: Found 'DU'-anomaly for variable 'air' (lines '739'-'773'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:741: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/NativeAIPlayer.java:741: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:749: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:766: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:772: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:779: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:779: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:779: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:780: Avoid reassigning parameters such as 'value' +src/net/sf/freecol/server/ai/NativeAIPlayer.java:780: Avoid reassigning parameters such as 'value' +src/net/sf/freecol/server/ai/NativeAIPlayer.java:783: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:789: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:791: Local variable 'targetPlayer' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:791: Useless parentheses. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:791: Useless parentheses. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:792: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:793: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:794: Avoid variables with short names like is +src/net/sf/freecol/server/ai/NativeAIPlayer.java:794: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:794: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:796: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:797: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:797: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:798: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:809: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:810: Local variable 'goldKey' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:810: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:811: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:819: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:819: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:819: The method 'buyProposition' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:819: The method 'buyProposition' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:819: The method buyProposition() has an NPath complexity of 600 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:820: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:820: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:822: Found 'DU'-anomaly for variable 'spec' (lines '822'-'874'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:822: Local variable 'spec' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:823: Avoid variables with short names like is +src/net/sf/freecol/server/ai/NativeAIPlayer.java:823: Found 'DU'-anomaly for variable 'is' (lines '823'-'874'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:823: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:824: Found 'DU'-anomaly for variable 'buyer' (lines '824'-'874'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:824: Local variable 'buyer' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:825: Local variable 'goldKey' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:825: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:827: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:827: Found 'DU'-anomaly for variable 'hagglingKey' (lines '827'-'874'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:827: Local variable 'hagglingKey' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:829: Local variable 'registered' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:831: Found 'DD'-anomaly for variable 'price' (lines '831'-'850'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:831: Found 'DU'-anomaly for variable 'price' (lines '831'-'874'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:831: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:832: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:832: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:839: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:841: Local variable 'modifiers' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:842: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:843: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:844: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:844: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:844: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:845: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:845: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:848: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:850: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:851: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:853: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:856: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:856: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:860: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:863: Found 'DD'-anomaly for variable 'haggling' (lines '863'-'865'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:867: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/NativeAIPlayer.java:869: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:880: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:880: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:880: The method 'sellProposition' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:880: The method 'sellProposition' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:880: The method 'sellProposition' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:880: The method sellProposition() has an NPath complexity of 1752 +src/net/sf/freecol/server/ai/NativeAIPlayer.java:881: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:881: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:883: Found 'DU'-anomaly for variable 'spec' (lines '883'-'940'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:883: Local variable 'spec' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:884: Avoid variables with short names like is +src/net/sf/freecol/server/ai/NativeAIPlayer.java:884: Found 'DU'-anomaly for variable 'is' (lines '884'-'940'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:884: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:885: Found 'DU'-anomaly for variable 'seller' (lines '885'-'940'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:885: Local variable 'seller' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:886: Local variable 'goldKey' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:886: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:889: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/NativeAIPlayer.java:889: Found 'DU'-anomaly for variable 'hagglingKey' (lines '889'-'940'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:889: Local variable 'hagglingKey' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:894: Found 'DD'-anomaly for variable 'price' (lines '894'-'918'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:894: Found 'DU'-anomaly for variable 'price' (lines '894'-'940'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:894: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:895: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:895: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:902: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:902: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:903: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:907: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:909: Local variable 'modifiers' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:910: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:911: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:912: Avoid variables with short names like u +src/net/sf/freecol/server/ai/NativeAIPlayer.java:912: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/NativeAIPlayer.java:912: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:913: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:913: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:916: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:918: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:919: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/NativeAIPlayer.java:920: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:920: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:923: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:923: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/NativeAIPlayer.java:927: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/NativeAIPlayer.java:929: Found 'DD'-anomaly for variable 'haggling' (lines '929'-'931'). +src/net/sf/freecol/server/ai/NativeAIPlayer.java:933: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/NativeAIPlayer.java:935: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/ProductionCache.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ProductionCache.java:20: Possible God class (WMC=56, ATFD=32, TCC=0.029239766081871343) +src/net/sf/freecol/server/ai/ProductionCache.java:52: The class 'ProductionCache' has a Cyclomatic Complexity of 3 (Highest = 11). +src/net/sf/freecol/server/ai/ProductionCache.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:54: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:84: Variables that are final and static should be all capitals, 'defaultComparator' is not all capitals. +src/net/sf/freecol/server/ai/ProductionCache.java:90: Avoid excessively long variable names like marketValueComparator +src/net/sf/freecol/server/ai/ProductionCache.java:90: Variables that are final and static should be all capitals, 'marketValueComparator' is not all capitals. +src/net/sf/freecol/server/ai/ProductionCache.java:93: Parameter 'entry1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:93: Parameter 'entry2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:93: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:94: Found 'DD'-anomaly for variable 'production' (lines '94'-'97'). +src/net/sf/freecol/server/ai/ProductionCache.java:95: Local variable 'market' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:95: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:107: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:112: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:115: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:115: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:121: Local variable 'someUnit' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:122: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:130: Found 'UR'-anomaly for variable 'colonyTile' (lines '130'-'135'). +src/net/sf/freecol/server/ai/ProductionCache.java:130: Found 'UR'-anomaly for variable 'unit' (lines '130'-'141'). +src/net/sf/freecol/server/ai/ProductionCache.java:130: Found 'UR'-anomaly for variable 'wl' (lines '130'-'147'). +src/net/sf/freecol/server/ai/ProductionCache.java:130: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:130: The method 'createEntries' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/ProductionCache.java:132: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:134: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:135: Local variable 'tile' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:137: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:137: Useless parentheses. +src/net/sf/freecol/server/ai/ProductionCache.java:137: Useless parentheses. +src/net/sf/freecol/server/ai/ProductionCache.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:140: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:141: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ProductionCache.java:146: Local variable 'wl' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:147: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/ProductionCache.java:148: Local variable 'building' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:150: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:151: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/ProductionCache.java:161: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:165: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:169: Parameter 'buildingType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:169: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:173: Parameter 'buildingType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:173: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:174: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:178: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:182: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:187: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:187: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:195: Parameter 'goodsTypes' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:195: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:199: Found 'UR'-anomaly for variable 'goodsType' (lines '199'-'202'). +src/net/sf/freecol/server/ai/ProductionCache.java:199: Parameter 'goodsTypes' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:199: Parameter 'useMarketValues' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:199: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:200: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:201: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:221: Found 'UR'-anomaly for variable 'entryList' (lines '221'-'250'). +src/net/sf/freecol/server/ai/ProductionCache.java:221: Parameter 'entry' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:222: Found 'DD'-anomaly for variable 'colonyTile' (lines '222'-'225'). +src/net/sf/freecol/server/ai/ProductionCache.java:223: Found 'DD'-anomaly for variable 'building' (lines '223'-'228'). +src/net/sf/freecol/server/ai/ProductionCache.java:223: Found 'DU'-anomaly for variable 'building' (lines '223'-'253'). +src/net/sf/freecol/server/ai/ProductionCache.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:231: Found 'DD'-anomaly for variable 'unit' (lines '231'-'233'). +src/net/sf/freecol/server/ai/ProductionCache.java:231: Found 'DU'-anomaly for variable 'unit' (lines '231'-'253'). +src/net/sf/freecol/server/ai/ProductionCache.java:232: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/ProductionCache.java:239: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/ProductionCache.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:249: Local variable 'entryList' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:255: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ProductionCache.java:268: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/ProductionCache.java:277: Parameter 'entryList' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:277: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:277: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:278: Local variable 'entryIterator' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:279: Local variable 'removedEntries' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:281: Local variable 'entry' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:282: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/ProductionCache.java:301: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:302: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:303: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:304: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:305: Avoid using redundant field initializer for 'isExpert' +src/net/sf/freecol/server/ai/ProductionCache.java:305: Field isExpert has the same name as a method +src/net/sf/freecol/server/ai/ProductionCache.java:305: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:305: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:306: Avoid using redundant field initializer for 'isOtherExpert' +src/net/sf/freecol/server/ai/ProductionCache.java:306: Field isOtherExpert has the same name as a method +src/net/sf/freecol/server/ai/ProductionCache.java:306: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:306: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:307: Avoid using redundant field initializer for 'unitUpgrades' +src/net/sf/freecol/server/ai/ProductionCache.java:307: Field unitUpgrades has the same name as a method +src/net/sf/freecol/server/ai/ProductionCache.java:307: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:307: Private field 'unitUpgrades' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/server/ai/ProductionCache.java:307: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:308: Avoid excessively long variable names like unitUpgradesToExpert +src/net/sf/freecol/server/ai/ProductionCache.java:308: Avoid using redundant field initializer for 'unitUpgradesToExpert' +src/net/sf/freecol/server/ai/ProductionCache.java:308: Field unitUpgradesToExpert has the same name as a method +src/net/sf/freecol/server/ai/ProductionCache.java:308: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/ProductionCache.java:308: Private field 'unitUpgradesToExpert' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/server/ai/ProductionCache.java:308: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:310: Avoid variables with short names like g +src/net/sf/freecol/server/ai/ProductionCache.java:310: Avoid variables with short names like u +src/net/sf/freecol/server/ai/ProductionCache.java:310: Avoid variables with short names like w +src/net/sf/freecol/server/ai/ProductionCache.java:310: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:310: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:310: Parameter 'w' is not assigned and could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:310: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/ProductionCache.java:315: Local variable 'expertProduction' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:316: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/ProductionCache.java:317: Use equals() to compare object references. +src/net/sf/freecol/server/ai/ProductionCache.java:323: Local variable 'change' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:415: Avoid variables with short names like sb +src/net/sf/freecol/server/ai/ProductionCache.java:415: Local variable 'sb' could be declared final +src/net/sf/freecol/server/ai/ProductionCache.java:418: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/ProductionCache.java:421: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:421: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/ProductionCache.java:425: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/REFAIPlayer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/REFAIPlayer.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/ai/REFAIPlayer.java:20: Possible God class (WMC=181, ATFD=152, TCC=0.04395604395604396) +src/net/sf/freecol/server/ai/REFAIPlayer.java:68: The class 'REFAIPlayer' has a Cyclomatic Complexity of 20 (Highest = 82). +src/net/sf/freecol/server/ai/REFAIPlayer.java:68: The class 'REFAIPlayer' has a Modified Cyclomatic Complexity of 17 (Highest = 60). +src/net/sf/freecol/server/ai/REFAIPlayer.java:68: The class 'REFAIPlayer' has a Standard Cyclomatic Complexity of 17 (Highest = 60). +src/net/sf/freecol/server/ai/REFAIPlayer.java:68: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/REFAIPlayer.java:70: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/REFAIPlayer.java:70: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:73: Avoid excessively long variable names like UNIT_USAD_THRESHOLD +src/net/sf/freecol/server/ai/REFAIPlayer.java:78: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/REFAIPlayer.java:78: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/REFAIPlayer.java:79: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/REFAIPlayer.java:80: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:81: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/REFAIPlayer.java:81: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:82: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/REFAIPlayer.java:82: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:85: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:85: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:85: Parameter 'score' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:85: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:89: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/REFAIPlayer.java:90: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/REFAIPlayer.java:93: Avoid variables with short names like t +src/net/sf/freecol/server/ai/REFAIPlayer.java:93: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:105: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:105: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:106: Local variable 'cmp' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:107: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:107: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:116: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:118: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:128: Found 'DD'-anomaly for variable 'hash' (lines '128'-'129'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:137: Avoid excessively long variable names like seekAndDestroyRange +src/net/sf/freecol/server/ai/REFAIPlayer.java:137: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/REFAIPlayer.java:137: Variables that are final and static should be all capitals, 'seekAndDestroyRange' is not all capitals. +src/net/sf/freecol/server/ai/REFAIPlayer.java:137: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:140: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/REFAIPlayer.java:140: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/REFAIPlayer.java:140: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/REFAIPlayer.java:150: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:150: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:163: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:164: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/REFAIPlayer.java:164: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: Found 'UR'-anomaly for variable 'ag' (lines '179'-'209'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: Found 'UR'-anomaly for variable 'b' (lines '179'-'206'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: Found 'UR'-anomaly for variable 'c' (lines '179'-'187'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: Found 'UR'-anomaly for variable 'p' (lines '179'-'186'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: Found 'UR'-anomaly for variable 't' (lines '179'-'204'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: Parameter 'aiu' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: The method 'findColonyTargets' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: The method 'findColonyTargets' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: The method 'findColonyTargets' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/REFAIPlayer.java:179: The method findColonyTargets() has an NPath complexity of 976 +src/net/sf/freecol/server/ai/REFAIPlayer.java:180: Parameter 'aiCarrier' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:185: Local variable 'p' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:186: Local variable 'c' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:187: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:188: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:189: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:190: Local variable 'score' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:191: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/REFAIPlayer.java:198: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/ai/REFAIPlayer.java:199: Local variable 'twiddle' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:204: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:205: Local variable 'b' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:205: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:206: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/REFAIPlayer.java:207: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:208: Local variable 'ag' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:209: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:212: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:218: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/REFAIPlayer.java:218: Local variable 'stockade' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:218: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:218: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:218: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:218: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:219: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:225: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/REFAIPlayer.java:225: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:227: Avoid using for statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:227: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:232: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: Avoid really long methods. +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: Found 'UR'-anomaly for variable 'u' (lines '256'-'392'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: Found 'UR'-anomaly for variable 'u' (lines '256'-'392'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: Found 'UR'-anomaly for variable 'u' (lines '256'-'392'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: Found 'UR'-anomaly for variable 'u' (lines '256'-'392'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: Parameter 'teleport' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: The method 'initialize' has a Cyclomatic Complexity of 45. +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: The method 'initialize' has a Modified Cyclomatic Complexity of 39. +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: The method 'initialize' has a Standard Cyclomatic Complexity of 39. +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: The method initialize() has an NCSS line count of 142 +src/net/sf/freecol/server/ai/REFAIPlayer.java:256: The method initialize() has an NPath complexity of 864162432 +src/net/sf/freecol/server/ai/REFAIPlayer.java:257: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/REFAIPlayer.java:257: Found 'DU'-anomaly for variable 'aiMain' (lines '257'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:257: Found 'DU'-anomaly for variable 'aiMain' (lines '257'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:257: Found 'DU'-anomaly for variable 'aiMain' (lines '257'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:257: Found 'DU'-anomaly for variable 'aiMain' (lines '257'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:258: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/REFAIPlayer.java:258: Found 'DU'-anomaly for variable 'aiRandom' (lines '258'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:258: Found 'DU'-anomaly for variable 'aiRandom' (lines '258'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:258: Found 'DU'-anomaly for variable 'aiRandom' (lines '258'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:258: Found 'DU'-anomaly for variable 'aiRandom' (lines '258'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:261: Local variable 'aiUnit' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:261: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:262: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:265: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:270: There is log block not surrounded by if +src/net/sf/freecol/server/ai/REFAIPlayer.java:271: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:275: There is log block not surrounded by if +src/net/sf/freecol/server/ai/REFAIPlayer.java:276: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:279: Local variable 'targets' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:282: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:285: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:285: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:286: Local variable 'ratio' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:287: Avoid variables with short names like n +src/net/sf/freecol/server/ai/REFAIPlayer.java:287: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:288: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/REFAIPlayer.java:288: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:295: Found 'DD'-anomaly for variable 'fail' (lines '295'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:295: Found 'DD'-anomaly for variable 'fail' (lines '295'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:295: Found 'DD'-anomaly for variable 'fail' (lines '295'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:295: Found 'DD'-anomaly for variable 'fail' (lines '295'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:297: Avoid variables with short names like t +src/net/sf/freecol/server/ai/REFAIPlayer.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:298: Avoid variables with short names like gd +src/net/sf/freecol/server/ai/REFAIPlayer.java:299: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:300: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:302: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/REFAIPlayer.java:303: Found 'DD'-anomaly for variable 'fail' (lines '303'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:303: Found 'DD'-anomaly for variable 'fail' (lines '303'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:303: Found 'DD'-anomaly for variable 'fail' (lines '303'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:303: Found 'DD'-anomaly for variable 'fail' (lines '303'-'303'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:307: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:307: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:314: Avoid variables with short names like i +src/net/sf/freecol/server/ai/REFAIPlayer.java:315: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:316: Avoid variables with short names like t +src/net/sf/freecol/server/ai/REFAIPlayer.java:316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'320'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'320'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'320'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'320'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'335'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'335'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'335'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:320: Found 'DD'-anomaly for variable 'n' (lines '320'-'335'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:328: Avoid variables with short names like t +src/net/sf/freecol/server/ai/REFAIPlayer.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:329: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:329: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:329: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:335: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:335: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:344: Local variable 'stealthGD' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:348: Avoid variables with short names like t +src/net/sf/freecol/server/ai/REFAIPlayer.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:349: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:350: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:350: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:352: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/REFAIPlayer.java:354: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:365: Found 'DU'-anomaly for variable 'navy' (lines '365'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:365: Found 'DU'-anomaly for variable 'navy' (lines '365'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:365: Found 'DU'-anomaly for variable 'navy' (lines '365'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:365: Found 'DU'-anomaly for variable 'navy' (lines '365'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:365: Local variable 'navy' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:366: Local variable 'auIterator' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:366: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:367: Found 'DU'-anomaly for variable 'land' (lines '367'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:367: Found 'DU'-anomaly for variable 'land' (lines '367'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:367: Found 'DU'-anomaly for variable 'land' (lines '367'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:367: Found 'DU'-anomaly for variable 'land' (lines '367'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:367: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:369: Avoid variables with short names like m +src/net/sf/freecol/server/ai/REFAIPlayer.java:371: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:372: Avoid variables with short names like t +src/net/sf/freecol/server/ai/REFAIPlayer.java:372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:373: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:376: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:377: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:377: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:377: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:378: Local variable 'ship' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:379: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:380: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:384: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:389: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:390: Found 'DD'-anomaly for variable 'used' (lines '390'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:390: Found 'DD'-anomaly for variable 'used' (lines '390'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:390: Found 'DD'-anomaly for variable 'used' (lines '390'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:390: Found 'DD'-anomaly for variable 'used' (lines '390'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:391: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:391: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:392: Local variable 'laiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:394: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:395: Found 'DD'-anomaly for variable 'used' (lines '395'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:395: Found 'DD'-anomaly for variable 'used' (lines '395'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:395: Found 'DD'-anomaly for variable 'used' (lines '395'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:395: Found 'DD'-anomaly for variable 'used' (lines '395'-'395'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:409: Found 'DU'-anomaly for variable 'rebelNavy' (lines '409'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:409: Found 'DU'-anomaly for variable 'rebelNavy' (lines '409'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:409: Found 'DU'-anomaly for variable 'rebelNavy' (lines '409'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:409: Found 'DU'-anomaly for variable 'rebelNavy' (lines '409'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:410: Found 'DU'-anomaly for variable 'navyGD' (lines '410'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:410: Found 'DU'-anomaly for variable 'navyGD' (lines '410'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:410: Found 'DU'-anomaly for variable 'navyGD' (lines '410'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:410: Found 'DU'-anomaly for variable 'navyGD' (lines '410'-'465'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:412: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:414: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:416: Parameter 'pathNode' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:416: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:416: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:419: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:421: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:422: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:430: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:430: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:430: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:430: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:431: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:438: Avoid variables with short names like ui +src/net/sf/freecol/server/ai/REFAIPlayer.java:438: Local variable 'ui' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:438: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:439: Local variable 'entries' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:440: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:440: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:440: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:442: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:443: Avoid variables with short names like u +src/net/sf/freecol/server/ai/REFAIPlayer.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:444: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/REFAIPlayer.java:444: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:444: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:447: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:450: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:451: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:454: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:455: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:455: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:456: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:463: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:467: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: Avoid variables with short names like nt +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: Found 'UR'-anomaly for variable 'aiu' (lines '479'-'489'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: Found 'UR'-anomaly for variable 'aiu' (lines '479'-'489'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: Parameter 'nt' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: Parameter 'transports' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: The method 'requireTransports' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: The method 'requireTransports' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/REFAIPlayer.java:479: The method 'requireTransports' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/REFAIPlayer.java:480: Parameter 'privateers' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:481: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/REFAIPlayer.java:481: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:482: Avoid variables with short names like m +src/net/sf/freecol/server/ai/REFAIPlayer.java:483: Found 'DU'-anomaly for variable 'naval' (lines '483'-'524'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:483: Found 'DU'-anomaly for variable 'naval' (lines '483'-'524'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:483: Local variable 'naval' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:484: Found 'DU'-anomaly for variable 'result' (lines '484'-'524'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:484: Found 'DU'-anomaly for variable 'result' (lines '484'-'524'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:484: Local variable 'result' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:488: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:489: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:489: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:490: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:491: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:492: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:492: Found 'DD'-anomaly for variable 'm' (lines '492'-'492'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:492: Found 'DD'-anomaly for variable 'm' (lines '492'-'492'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:492: Found 'DU'-anomaly for variable 'm' (lines '492'-'524'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:492: Found 'DU'-anomaly for variable 'm' (lines '492'-'524'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:494: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:502: Avoid variables with short names like a1 +src/net/sf/freecol/server/ai/REFAIPlayer.java:502: Avoid variables with short names like a2 +src/net/sf/freecol/server/ai/REFAIPlayer.java:502: Parameter 'a1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:502: Parameter 'a2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:502: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:503: Avoid variables with short names like d1 +src/net/sf/freecol/server/ai/REFAIPlayer.java:503: Local variable 'd1' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:503: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:505: Avoid variables with short names like d2 +src/net/sf/freecol/server/ai/REFAIPlayer.java:505: Local variable 'd2' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:505: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:510: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:511: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:511: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:512: Local variable 'distance' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:512: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:512: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:514: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:516: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:517: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:517: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:530: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:534: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:534: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:536: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/REFAIPlayer.java:536: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:536: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:536: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:536: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Avoid really long methods. +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Found 'UR'-anomaly for variable 'aiCarrier' (lines '544'-'723'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Found 'UR'-anomaly for variable 'aiCarrier' (lines '544'-'723'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Found 'UR'-anomaly for variable 'aiu' (lines '544'-'559'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Found 'UR'-anomaly for variable 'aiu' (lines '544'-'559'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Found 'UR'-anomaly for variable 'e' (lines '544'-'716'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Found 'UR'-anomaly for variable 'e' (lines '544'-'716'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: The method 'giveNormalMissions' has a Cyclomatic Complexity of 82. +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: The method 'giveNormalMissions' has a Modified Cyclomatic Complexity of 60. +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: The method 'giveNormalMissions' has a Standard Cyclomatic Complexity of 60. +src/net/sf/freecol/server/ai/REFAIPlayer.java:544: The method giveNormalMissions() has an NCSS line count of 199 +src/net/sf/freecol/server/ai/REFAIPlayer.java:546: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/REFAIPlayer.java:547: Local variable 'privateers' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:548: Local variable 'transports' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:549: Local variable 'todo' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:550: Local variable 'land' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:551: Avoid variables with short names like m +src/net/sf/freecol/server/ai/REFAIPlayer.java:558: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:559: Avoid variables with short names like u +src/net/sf/freecol/server/ai/REFAIPlayer.java:559: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:559: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:560: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:561: Local variable 'mission' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:562: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:566: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:568: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:569: Local variable 'loc' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:570: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:572: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:576: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:578: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:579: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:581: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:582: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:583: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:587: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:590: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:593: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:597: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:599: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:605: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:606: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:608: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:611: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:614: Avoid variables with short names like nt +src/net/sf/freecol/server/ai/REFAIPlayer.java:614: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:624: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:625: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:628: Local variable 'count' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:628: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:628: Useless parentheses. +src/net/sf/freecol/server/ai/REFAIPlayer.java:630: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:636: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:642: Avoid throwing raw exception types. +src/net/sf/freecol/server/ai/REFAIPlayer.java:647: Avoid variables with short names like u +src/net/sf/freecol/server/ai/REFAIPlayer.java:647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:648: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:651: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:651: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:652: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Local variable 'best' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:658: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:660: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:670: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:670: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:671: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/REFAIPlayer.java:672: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:672: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:673: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:675: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:686: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:689: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:690: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/ai/REFAIPlayer.java:690: Local variable 'ready' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:691: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:692: Avoid variables with short names like tm +src/net/sf/freecol/server/ai/REFAIPlayer.java:692: Local variable 'tm' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:692: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:693: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:693: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:694: Avoid variables with short names like u +src/net/sf/freecol/server/ai/REFAIPlayer.java:694: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:694: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:696: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:696: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:697: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:697: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:699: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:699: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:700: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:703: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:712: Local variable 'idlePorts' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:713: Local variable 'aiCarriers' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:715: Local variable 'e' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:715: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:716: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:716: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:717: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:718: Local variable 'key' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:719: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:719: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:720: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:720: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:721: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:721: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:722: Local variable 'aiCarrier' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:722: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:723: Local variable 'carrier' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:723: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:724: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:724: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:725: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:726: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:727: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:733: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:733: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:738: Found 'DD'-anomaly for variable 'found' (lines '738'-'742'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:738: Found 'DD'-anomaly for variable 'found' (lines '738'-'742'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:739: Found 'DD'-anomaly for variable 'target' (lines '739'-'750'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:739: Found 'DD'-anomaly for variable 'target' (lines '739'-'750'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:740: Local variable 'aiCarrier' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:741: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:741: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:742: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:742: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:745: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:746: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:747: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:749: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:750: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:755: Local variable 'aiCarrier' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:755: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:755: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:755: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:756: Avoid variables with short names like ct +src/net/sf/freecol/server/ai/REFAIPlayer.java:758: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:761: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:762: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:762: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:765: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:768: Local variable 'aiCarrier' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:769: Avoid variables with short names like tm +src/net/sf/freecol/server/ai/REFAIPlayer.java:769: Found 'DD'-anomaly for variable 'tm' (lines '769'-'769'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:769: Found 'DD'-anomaly for variable 'tm' (lines '769'-'769'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:769: Found 'DU'-anomaly for variable 'tm' (lines '769'-'839'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:769: Found 'DU'-anomaly for variable 'tm' (lines '769'-'839'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:769: Local variable 'tm' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:772: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:772: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:772: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:773: Avoid assignments in operands +src/net/sf/freecol/server/ai/REFAIPlayer.java:773: Found 'DD'-anomaly for variable 'm' (lines '773'-'773'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:773: Found 'DD'-anomaly for variable 'm' (lines '773'-'773'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:773: Found 'DU'-anomaly for variable 'm' (lines '773'-'839'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:773: Found 'DU'-anomaly for variable 'm' (lines '773'-'839'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:773: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:777: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:778: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:778: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:784: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:784: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:785: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:786: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:787: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:787: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:791: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:794: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:795: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:796: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:796: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:798: Found 'DU'-anomaly for variable 'nt' (lines '798'-'839'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:798: Found 'DU'-anomaly for variable 'nt' (lines '798'-'839'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:798: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:808: Avoid variables with short names like l1 +src/net/sf/freecol/server/ai/REFAIPlayer.java:808: Avoid variables with short names like l2 +src/net/sf/freecol/server/ai/REFAIPlayer.java:808: Parameter 'l1' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:808: Parameter 'l2' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:808: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/REFAIPlayer.java:809: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:809: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:814: Local variable 'l' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:817: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:818: Local variable 'value' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:818: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:828: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:829: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:830: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:831: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:849: Found 'UR'-anomaly for variable 'aiu' (lines '849'-'862'). +src/net/sf/freecol/server/ai/REFAIPlayer.java:851: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:852: There is log block not surrounded by if +src/net/sf/freecol/server/ai/REFAIPlayer.java:859: Local variable 'transport' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:860: Local variable 'land' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:861: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:862: Avoid variables with short names like u +src/net/sf/freecol/server/ai/REFAIPlayer.java:863: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:868: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:868: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/REFAIPlayer.java:872: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/REFAIPlayer.java:872: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:882: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:882: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:882: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:882: The method 'adjustMission' has a Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/REFAIPlayer.java:882: The method 'adjustMission' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/REFAIPlayer.java:882: The method 'adjustMission' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/REFAIPlayer.java:883: Avoid reassigning parameters such as 'value' +src/net/sf/freecol/server/ai/REFAIPlayer.java:883: Avoid reassigning parameters such as 'value' +src/net/sf/freecol/server/ai/REFAIPlayer.java:887: Local variable 'loc' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:888: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:889: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:892: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/REFAIPlayer.java:897: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:900: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:901: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:906: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:907: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/REFAIPlayer.java:910: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/REFAIPlayer.java:910: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:910: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:910: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:910: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:910: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:910: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/REFAIPlayer.java:913: Avoid variables with short names like m +src/net/sf/freecol/server/ai/REFAIPlayer.java:916: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/TileImprovementPlan.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TileImprovementPlan.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:44: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/TileImprovementPlan.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:56: Avoid using redundant field initializer for 'pioneer' +src/net/sf/freecol/server/ai/TileImprovementPlan.java:59: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TileImprovementPlan.java:68: Avoid variables with short names like id +src/net/sf/freecol/server/ai/TileImprovementPlan.java:68: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:68: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:72: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:73: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:74: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:77: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TileImprovementPlan.java:87: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:87: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:88: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:88: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:93: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:106: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:106: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:112: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TileImprovementPlan.java:121: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:122: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/TileImprovementPlan.java:122: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:129: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TileImprovementPlan.java:142: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TileImprovementPlan.java:151: Parameter 'pioneer' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:170: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:185: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TileImprovementPlan.java:194: Found 'UR'-anomaly for variable 'impType' (lines '194'-'200'). +src/net/sf/freecol/server/ai/TileImprovementPlan.java:194: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:195: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:196: Found 'DU'-anomaly for variable 'bestValue' (lines '196'-'216'). +src/net/sf/freecol/server/ai/TileImprovementPlan.java:197: Found 'DD'-anomaly for variable 'bestType' (lines '197'-'211'). +src/net/sf/freecol/server/ai/TileImprovementPlan.java:198: Local variable 'impType' could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:208: Local variable 'value' could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:210: Found 'DU'-anomaly for variable 'bestValue' (lines '210'-'216'). +src/net/sf/freecol/server/ai/TileImprovementPlan.java:211: Found 'DD'-anomaly for variable 'bestType' (lines '211'-'211'). +src/net/sf/freecol/server/ai/TileImprovementPlan.java:225: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:226: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:227: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/TileImprovementPlan.java:227: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TileImprovementPlan.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:251: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/TileImprovementPlan.java:256: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/TileImprovementPlan.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:260: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:260: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/TileImprovementPlan.java:278: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:290: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:291: Found 'DD'-anomaly for variable 'result' (lines '291'-'293'). +src/net/sf/freecol/server/ai/TileImprovementPlan.java:291: Found 'DD'-anomaly for variable 'result' (lines '291'-'295'). +src/net/sf/freecol/server/ai/TileImprovementPlan.java:295: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TileImprovementPlan.java:302: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:302: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/TileImprovementPlan.java:303: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:303: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/TileImprovementPlan.java:304: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:304: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/TileImprovementPlan.java:311: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/TileImprovementPlan.java:311: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:312: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TileImprovementPlan.java:319: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/TileImprovementPlan.java:319: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:335: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/TileImprovementPlan.java:335: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:344: Useless parentheses. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:344: Useless parentheses. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:347: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:357: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/TileImprovementPlan.java:357: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:360: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TileImprovementPlan.java:368: Avoid variables with short names like sb +src/net/sf/freecol/server/ai/TileImprovementPlan.java:368: Local variable 'sb' could be declared final +src/net/sf/freecol/server/ai/TileImprovementPlan.java:369: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:370: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:373: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/TileImprovementPlan.java:374: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/TransportableAIObject.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TransportableAIObject.java:45: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/ai/TransportableAIObject.java:45: The class 'TransportableAIObject' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/server/ai/TransportableAIObject.java:45: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/TransportableAIObject.java:50: Avoid excessively long variable names like IMPORTANT_DELIVERY +src/net/sf/freecol/server/ai/TransportableAIObject.java:61: Avoid excessively long variable names like TOOLS_FOR_COLONY_PRIORITY +src/net/sf/freecol/server/ai/TransportableAIObject.java:68: Avoid excessively long variable names like TOOLS_FOR_IMPROVEMENT +src/net/sf/freecol/server/ai/TransportableAIObject.java:83: Avoid excessively long variable names like TOOLS_FOR_BUILDING +src/net/sf/freecol/server/ai/TransportableAIObject.java:98: Avoid variables with short names like id +src/net/sf/freecol/server/ai/TransportableAIObject.java:98: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:98: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:101: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TransportableAIObject.java:112: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:112: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:116: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TransportableAIObject.java:125: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:126: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/TransportableAIObject.java:126: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:147: Parameter 'transportPriority' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:172: Parameter 'transport' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:185: Avoid variables with short names like l +src/net/sf/freecol/server/ai/TransportableAIObject.java:185: Local variable 'l' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:197: Local variable 'transport' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:201: Avoid variables with short names like tm +src/net/sf/freecol/server/ai/TransportableAIObject.java:201: Local variable 'tm' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:203: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TransportableAIObject.java:203: Deeply nested if..then statements are hard to read +src/net/sf/freecol/server/ai/TransportableAIObject.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:210: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TransportableAIObject.java:223: Parameter 'aiCarrier' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:223: The method 'changeTransport' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/TransportableAIObject.java:226: Avoid variables with short names like l +src/net/sf/freecol/server/ai/TransportableAIObject.java:226: Local variable 'l' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:227: Avoid assignments in operands +src/net/sf/freecol/server/ai/TransportableAIObject.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:229: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/TransportableAIObject.java:229: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TransportableAIObject.java:229: These nested if statements could be combined +src/net/sf/freecol/server/ai/TransportableAIObject.java:232: Local variable 'old' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:234: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/TransportableAIObject.java:234: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TransportableAIObject.java:234: Use equals() to compare object references. +src/net/sf/freecol/server/ai/TransportableAIObject.java:236: Avoid variables with short names like tm +src/net/sf/freecol/server/ai/TransportableAIObject.java:236: Local variable 'tm' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:237: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/TransportableAIObject.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:256: Avoid variables with short names like l +src/net/sf/freecol/server/ai/TransportableAIObject.java:256: Local variable 'l' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:257: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/TransportableAIObject.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:295: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TransportableAIObject.java:306: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/TransportableAIObject.java:372: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/TransportableAIObject.java:372: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/TransportableAIObject.java:379: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/TransportableAIObject.java:379: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:383: Avoid variables with short names like u +src/net/sf/freecol/server/ai/TransportableAIObject.java:383: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:384: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/TransportableAIObject.java:394: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/TransportableAIObject.java:394: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/TransportableAIObject.java:399: Useless parentheses. +src/net/sf/freecol/server/ai/TransportableAIObject.java:399: Useless parentheses. +src/net/sf/freecol/server/ai/TransportableAIObject.java:402: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/Wish.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/Wish.java:38: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/ai/Wish.java:38: Avoid short class names like Wish +src/net/sf/freecol/server/ai/Wish.java:40: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/Wish.java:40: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/Wish.java:40: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/Wish.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/Wish.java:58: Avoid variables with short names like id +src/net/sf/freecol/server/ai/Wish.java:58: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:58: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:61: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/Wish.java:62: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/Wish.java:73: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:73: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:77: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/Wish.java:86: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/Wish.java:86: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:86: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:120: Parameter 'transportable' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:141: Useless parentheses. +src/net/sf/freecol/server/ai/Wish.java:141: Useless parentheses. +src/net/sf/freecol/server/ai/Wish.java:142: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/Wish.java:143: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/Wish.java:155: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/Wish.java:156: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/Wish.java:160: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/Wish.java:170: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:171: Found 'DD'-anomaly for variable 'result' (lines '171'-'173'). +src/net/sf/freecol/server/ai/Wish.java:171: Found 'DD'-anomaly for variable 'result' (lines '171'-'178'). +src/net/sf/freecol/server/ai/Wish.java:177: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/Wish.java:186: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/Wish.java:186: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/Wish.java:187: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/Wish.java:187: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/Wish.java:194: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/Wish.java:194: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:211: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/Wish.java:211: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/Wish.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/WorkLocationPlan.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/WorkLocationPlan.java:37: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/WorkLocationPlan.java:37: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/WorkLocationPlan.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/WorkLocationPlan.java:46: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/WorkLocationPlan.java:55: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkLocationPlan.java:55: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkLocationPlan.java:56: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkLocationPlan.java:72: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkLocationPlan.java:72: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkLocationPlan.java:106: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkLocationPlan.java:129: Avoid variables with short names like sb +src/net/sf/freecol/server/ai/WorkLocationPlan.java:129: Local variable 'sb' could be declared final +src/net/sf/freecol/server/ai/WorkLocationPlan.java:130: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/WorkLocationPlan.java:131: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/WorkLocationPlan.java:133: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/ai/WorkerWish.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/WorkerWish.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/WorkerWish.java:43: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/WorkerWish.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/WorkerWish.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/WorkerWish.java:59: Avoid variables with short names like id +src/net/sf/freecol/server/ai/WorkerWish.java:59: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:59: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:62: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/WorkerWish.java:66: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/WorkerWish.java:80: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:80: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:80: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:81: Parameter 'expertNeeded' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:81: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:85: Avoid throwing null pointer exceptions. +src/net/sf/freecol/server/ai/WorkerWish.java:103: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:103: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:109: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/WorkerWish.java:118: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:119: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/WorkerWish.java:119: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:133: Parameter 'expertNeeded' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:133: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:133: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:137: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/WorkerWish.java:156: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:157: Useless parentheses. +src/net/sf/freecol/server/ai/WorkerWish.java:157: Useless parentheses. +src/net/sf/freecol/server/ai/WorkerWish.java:159: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/WorkerWish.java:173: Parameter 'fix' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:174: Found 'DD'-anomaly for variable 'result' (lines '174'-'175'). +src/net/sf/freecol/server/ai/WorkerWish.java:175: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/WorkerWish.java:182: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/WorkerWish.java:182: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/WorkerWish.java:183: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/WorkerWish.java:183: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/WorkerWish.java:184: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/WorkerWish.java:184: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/WorkerWish.java:191: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/WorkerWish.java:191: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:203: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/WorkerWish.java:203: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:210: Useless parentheses. +src/net/sf/freecol/server/ai/WorkerWish.java:210: Useless parentheses. +src/net/sf/freecol/server/ai/WorkerWish.java:213: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/WorkerWish.java:225: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/WorkerWish.java:225: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:228: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/WorkerWish.java:236: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/WorkerWish.java:236: Local variable 'lb' could be declared final +src/net/sf/freecol/server/ai/WorkerWish.java:239: Useless parentheses. +src/net/sf/freecol/server/ai/WorkerWish.java:239: Useless parentheses. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:38: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:48: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:50: The class 'CreateMissionAtSettlementGoal' has a Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:50: The class 'CreateMissionAtSettlementGoal' has a Modified Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:50: The class 'CreateMissionAtSettlementGoal' has a Standard Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:52: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:55: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:58: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:58: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Avoid variables with short names like i +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Avoid variables with short names like p +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Avoid variables with short names like w +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Parameter 'i' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: Parameter 'w' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:60: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:63: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:67: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:74: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:77: Local variable 'subGoalList' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:85: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:85: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:85: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:86: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:88: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:89: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:101: The method 'plan' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:101: The method 'plan' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:101: The method 'plan' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:113: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:115: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:115: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:122: Local variable 'units' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:124: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:133: Avoid excessively long variable names like hasFoundMissionary +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:133: Found 'DU'-anomaly for variable 'hasFoundMissionary' (lines '133'-'175'). +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:134: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:136: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:136: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:138: Avoid empty if statements +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:138: Avoid empty if statements +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:138: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:138: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:138: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:142: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:143: Found 'DU'-anomaly for variable 'hasFoundMissionary' (lines '143'-'175'). +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:147: Local variable 'pathNode' could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:162: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:178: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:180: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:181: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:183: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:190: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:190: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:190: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:195: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:195: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/CreateMissionAtSettlementGoal.java:195: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:24: Possible God class (WMC=66, ATFD=14, TCC=0.06159420289855073) +src/net/sf/freecol/server/ai/goal/Goal.java:40: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:56: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/ai/goal/Goal.java:56: Avoid short class names like Goal +src/net/sf/freecol/server/ai/goal/Goal.java:56: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/goal/Goal.java:58: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/goal/Goal.java:58: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:60: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/Goal.java:60: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:61: Field needsPlanning has the same name as a method +src/net/sf/freecol/server/ai/goal/Goal.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/Goal.java:61: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:62: Field isFinished has the same name as a method +src/net/sf/freecol/server/ai/goal/Goal.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/Goal.java:62: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:63: Avoid excessively long variable names like availableUnitsList +src/net/sf/freecol/server/ai/goal/Goal.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/Goal.java:63: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/Goal.java:65: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:66: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/Goal.java:66: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/Goal.java:75: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:75: Avoid variables with short names like p +src/net/sf/freecol/server/ai/goal/Goal.java:75: Avoid variables with short names like w +src/net/sf/freecol/server/ai/goal/Goal.java:75: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:75: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:75: Parameter 'w' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:86: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:88: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:95: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:95: Avoid variables with short names like p +src/net/sf/freecol/server/ai/goal/Goal.java:95: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:95: Avoid variables with short names like w +src/net/sf/freecol/server/ai/goal/Goal.java:95: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:95: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:95: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:95: Parameter 'w' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:110: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:122: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:123: Avoid excessively long variable names like cancelledUnitsList +src/net/sf/freecol/server/ai/goal/Goal.java:123: Local variable 'cancelledUnitsList' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:126: Local variable 'git' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:128: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:128: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:129: Local variable 'ulist' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:134: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:136: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:136: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:139: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:139: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:144: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:148: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:149: Found 'DD'-anomaly for variable 'subgoalsPlanned' (lines '149'-'158'). +src/net/sf/freecol/server/ai/goal/Goal.java:153: Local variable 'git' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:155: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:155: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:158: Found 'DD'-anomaly for variable 'subgoalsPlanned' (lines '158'-'158'). +src/net/sf/freecol/server/ai/goal/Goal.java:172: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:175: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:177: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/goal/Goal.java:179: Local variable 'git' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:181: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:181: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:183: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/goal/Goal.java:198: Avoid variables with short names like p +src/net/sf/freecol/server/ai/goal/Goal.java:198: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:199: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:202: Local variable 'git' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:204: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:204: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:223: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:228: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/goal/Goal.java:234: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:237: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:254: Avoid variables with short names like w +src/net/sf/freecol/server/ai/goal/Goal.java:254: Parameter 'w' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:270: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:270: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:278: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:278: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:279: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:279: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:290: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:291: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:296: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:297: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:304: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:310: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:316: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:328: An empty method in an abstract class should be abstract instead +src/net/sf/freecol/server/ai/goal/Goal.java:328: Avoid variables with short names like gt +src/net/sf/freecol/server/ai/goal/Goal.java:328: Parameter 'gt' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:328: Parameter 'minProduction' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:332: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:335: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:343: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:347: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:347: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:348: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:349: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:349: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:363: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:363: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:364: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:365: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/goal/Goal.java:374: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:385: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:387: Avoid variables with short names like o +src/net/sf/freecol/server/ai/goal/Goal.java:387: Avoid variables with short names like ut +src/net/sf/freecol/server/ai/goal/Goal.java:387: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:387: Parameter 'ut' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:388: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:390: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:390: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:393: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/goal/Goal.java:397: Local variable 'git' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:399: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:399: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:401: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/goal/Goal.java:408: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:409: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:421: Avoid variables with short names like o +src/net/sf/freecol/server/ai/goal/Goal.java:421: Avoid variables with short names like ut +src/net/sf/freecol/server/ai/goal/Goal.java:421: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:421: Parameter 'ut' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:424: Found 'DD'-anomaly for variable 'unitWeight' (lines '424'-'431'). +src/net/sf/freecol/server/ai/goal/Goal.java:426: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:428: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:428: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:430: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:430: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:430: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:431: Found 'DD'-anomaly for variable 'unitWeight' (lines '431'-'431'). +src/net/sf/freecol/server/ai/goal/Goal.java:435: Local variable 'git' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:437: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:437: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:438: Local variable 'newWeight' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:438: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:446: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:458: Avoid variables with short names like o +src/net/sf/freecol/server/ai/goal/Goal.java:458: Avoid variables with short names like ut +src/net/sf/freecol/server/ai/goal/Goal.java:458: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:458: Parameter 'ut' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:459: Found 'DD'-anomaly for variable 'unitWeight' (lines '459'-'469'). +src/net/sf/freecol/server/ai/goal/Goal.java:459: Found 'DU'-anomaly for variable 'unitWeight' (lines '459'-'490'). +src/net/sf/freecol/server/ai/goal/Goal.java:460: Found 'DD'-anomaly for variable 'yieldedUnit' (lines '460'-'470'). +src/net/sf/freecol/server/ai/goal/Goal.java:460: Found 'DD'-anomaly for variable 'yieldedUnit' (lines '460'-'481'). +src/net/sf/freecol/server/ai/goal/Goal.java:461: Found 'DD'-anomaly for variable 'isOwnUnit' (lines '461'-'471'). +src/net/sf/freecol/server/ai/goal/Goal.java:461: Found 'DD'-anomaly for variable 'isOwnUnit' (lines '461'-'482'). +src/net/sf/freecol/server/ai/goal/Goal.java:464: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:466: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:466: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:468: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:468: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:468: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:469: Found 'DD'-anomaly for variable 'unitWeight' (lines '469'-'469'). +src/net/sf/freecol/server/ai/goal/Goal.java:469: Found 'DU'-anomaly for variable 'unitWeight' (lines '469'-'490'). +src/net/sf/freecol/server/ai/goal/Goal.java:470: Found 'DD'-anomaly for variable 'yieldedUnit' (lines '470'-'470'). +src/net/sf/freecol/server/ai/goal/Goal.java:470: Found 'DD'-anomaly for variable 'yieldedUnit' (lines '470'-'481'). +src/net/sf/freecol/server/ai/goal/Goal.java:471: Found 'DD'-anomaly for variable 'isOwnUnit' (lines '471'-'471'). +src/net/sf/freecol/server/ai/goal/Goal.java:471: Found 'DD'-anomaly for variable 'isOwnUnit' (lines '471'-'482'). +src/net/sf/freecol/server/ai/goal/Goal.java:475: Local variable 'git' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:477: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/Goal.java:477: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:478: Local variable 'newWeight' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:478: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:480: Found 'DU'-anomaly for variable 'unitWeight' (lines '480'-'490'). +src/net/sf/freecol/server/ai/goal/Goal.java:481: Found 'DD'-anomaly for variable 'yieldedUnit' (lines '481'-'481'). +src/net/sf/freecol/server/ai/goal/Goal.java:481: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:482: Found 'DD'-anomaly for variable 'isOwnUnit' (lines '482'-'482'). +src/net/sf/freecol/server/ai/goal/Goal.java:501: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:503: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:503: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:504: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:504: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:504: Use opposite operator instead of the logic complement operator. +src/net/sf/freecol/server/ai/goal/Goal.java:505: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:505: There is log block not surrounded by if +src/net/sf/freecol/server/ai/goal/Goal.java:506: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:506: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:524: Local variable 'goalName' could be declared final +src/net/sf/freecol/server/ai/goal/Goal.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:525: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/Goal.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/Goal.java:535: Found 'DD'-anomaly for variable 'descr' (lines '535'-'540'). +src/net/sf/freecol/server/ai/goal/Goal.java:573: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:584: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/Goal.java:586: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:596: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:597: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:623: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:627: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/Goal.java:663: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:664: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/Goal.java:669: Comment is too large: Line too long +src/net/sf/freecol/server/ai/goal/GoalConstants.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/GoalConstants.java:28: An Interface should be used only to model a behaviour; consider converting this to a class. +src/net/sf/freecol/server/ai/goal/GoalConstants.java:31: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/ai/goal/GoalConstants.java:31: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:39: The class 'GotoAdjacentGoal' has a Cyclomatic Complexity of 3 (Highest = 13). +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:41: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:41: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:44: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Avoid variables with short names like p +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Avoid variables with short names like t +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Avoid variables with short names like w +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: Parameter 'w' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:46: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:52: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:59: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:64: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:64: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:64: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:65: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:67: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:68: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:75: The method 'plan' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:75: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:81: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:83: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:83: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:94: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:96: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:123: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:125: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:126: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:128: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:135: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:135: Document empty method +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:135: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:135: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:139: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:139: Document empty method +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:139: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/GotoAdjacentGoal.java:139: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:39: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:54: The class 'ManageMissionariesGoal' has a Cyclomatic Complexity of 2 (Highest = 10). +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:56: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:59: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:61: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:61: Avoid variables with short names like p +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:61: Avoid variables with short names like w +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:61: Parameter 'g' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:61: Parameter 'p' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:61: Parameter 'w' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:61: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:67: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:74: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:80: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:80: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:80: protectedMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:81: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:83: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:96: The method 'plan' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:103: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:103: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:105: Local variable 'units' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:117: Local variable 'uit' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:119: Avoid variables with short names like u +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:119: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:123: Avoid variables with short names like i +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:123: Local variable 'i' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:125: Local variable 'pathNode' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:128: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:128: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:128: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:145: Found 'DU'-anomaly for variable 'newWeight' (lines '145'-'152'). +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:145: Local variable 'newWeight' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:148: Avoid variables with short names like g +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:148: Local variable 'g' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:155: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:156: Local variable 'descr' could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:163: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:166: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:171: Avoid variables with short names like t +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:172: Avoid variables with short names like is +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:178: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:178: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:178: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:183: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:183: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/goal/ManageMissionariesGoal.java:183: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:20: Possible God class (WMC=74, ATFD=36, TCC=0.03508771929824561) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:49: The class 'DefendSettlementMission' has a Cyclomatic Complexity of 3 (Highest = 29). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:49: The class 'DefendSettlementMission' has a Modified Cyclomatic Complexity of 3 (Highest = 20). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:49: The class 'DefendSettlementMission' has a Standard Cyclomatic Complexity of 3 (Highest = 23). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:49: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:51: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:51: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:54: This final field could be made static +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:57: Avoid unused private fields such as 'MAX_TURNS'. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:71: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:71: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:72: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:76: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:87: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:87: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:88: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:88: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:103: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:103: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:104: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:104: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:106: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:108: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:118: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:118: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:120: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:120: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:137: Avoid using redundant field initializer for 'bestPath' +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:137: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:138: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:141: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:143: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:145: Avoid variables with short names like u +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:145: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:145: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:145: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:146: Local variable 'value' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:165: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:165: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:166: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:167: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:167: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:184: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:184: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:185: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:186: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:187: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:187: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:197: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:198: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:199: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:199: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:201: Avoid variables with short names like cm +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:202: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:202: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:203: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:213: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:214: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:215: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:224: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:225: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:226: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:230: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:240: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:240: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:241: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:242: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:274: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: Avoid really long methods. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: Found 'UR'-anomaly for variable 'd' (lines '300'-'388'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: Found 'UR'-anomaly for variable 'u' (lines '300'-'356'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: The method 'doMission' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: The method 'doMission' has a Modified Cyclomatic Complexity of 20. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: The method 'doMission' has a Standard Cyclomatic Complexity of 23. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:300: The method doMission() has an NPath complexity of 1296000 +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:302: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:304: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:306: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:310: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:311: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:311: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:319: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:322: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:325: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:330: Found 'DU'-anomaly for variable 'aiMain' (lines '330'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:331: Found 'DU'-anomaly for variable 'aiUnit' (lines '331'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:332: Avoid variables with short names like m +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:332: Found 'DD'-anomaly for variable 'm' (lines '332'-'337'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:332: Found 'DU'-anomaly for variable 'm' (lines '332'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:334: Local variable 'colony' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:336: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:336: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:339: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:345: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:346: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:351: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:352: Found 'DD'-anomaly for variable 'defenderCount' (lines '352'-'358'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:352: Found 'DD'-anomaly for variable 'fortifyCount' (lines '352'-'360'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:352: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:353: Local variable 'units' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:354: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:354: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:354: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:355: Local variable 'u' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:356: Local variable 'aiu' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:356: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:359: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:366: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:366: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:366: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:366: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:366: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:366: Useless parentheses. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:378: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:379: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:382: Avoid variables with short names like cm +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:382: Found 'DU'-anomaly for variable 'cm' (lines '382'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:382: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:383: Found 'DD'-anomaly for variable 'bestTarget' (lines '383'-'404'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:384: Found 'DU'-anomaly for variable 'bestDifference' (lines '384'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:385: Found 'DD'-anomaly for variable 'bestDirection' (lines '385'-'405'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:385: Found 'DU'-anomaly for variable 'bestDirection' (lines '385'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:386: Local variable 'd' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:388: Avoid variables with short names like t +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:388: Local variable 't' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:388: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:389: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:390: Local variable 'defender' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:392: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:393: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:394: Local variable 'enemyUnit' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:395: Local variable 'enemyAttack' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:396: Local variable 'weAttack' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:397: Local variable 'enemyDefend' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:397: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:398: Local variable 'weDefend' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:399: Local variable 'difference' could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:402: These nested if statements could be combined +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:403: Found 'DU'-anomaly for variable 'bestDifference' (lines '403'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:404: Found 'DD'-anomaly for variable 'bestTarget' (lines '404'-'404'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:405: Found 'DD'-anomaly for variable 'bestDirection' (lines '405'-'405'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:405: Found 'DU'-anomaly for variable 'bestDirection' (lines '405'-'418'). +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:414: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:423: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:423: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:430: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:430: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:442: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/DefendSettlementMission.java:442: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:20: Possible God class (WMC=63, ATFD=14, TCC=0.01098901098901099) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:43: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:54: The class 'IndianBringGiftMission' has a Cyclomatic Complexity of 3 (Highest = 21). +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:54: The class 'IndianBringGiftMission' has a Modified Cyclomatic Complexity of 2 (Highest = 12). +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:54: The class 'IndianBringGiftMission' has a Standard Cyclomatic Complexity of 3 (Highest = 18). +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:56: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:56: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:59: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:75: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:75: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:75: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:81: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:91: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:91: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:92: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:92: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:99: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:117: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:118: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:120: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:122: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:125: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:128: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:137: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:137: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:138: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:139: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:139: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:142: Local variable 'targetPlayer' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:143: Switch statements should have a default label +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:145: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:147: Local variable 'tension' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:149: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:149: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:150: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:161: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:172: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:172: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:173: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:174: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:199: Useless parentheses. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:199: Useless parentheses. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:207: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:233: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:233: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:233: The method 'doMission' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:233: The method 'doMission' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:233: The method 'doMission' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:233: The method doMission() has an NPath complexity of 14874 +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:235: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:236: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:236: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:238: Found 'DU'-anomaly for variable 'aiUnit' (lines '238'-'325'). +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:240: Avoid variables with short names like is +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:240: Found 'DU'-anomaly for variable 'is' (lines '240'-'325'). +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:243: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:243: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:250: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:253: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:256: Local variable 'blocker' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:258: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:260: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:266: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:271: Local variable 'gift' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:272: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:272: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:275: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:279: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:279: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:285: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:285: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:290: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:293: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:299: Local variable 'blocker' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:301: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:301: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:303: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:309: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:314: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:315: Found 'DD'-anomaly for variable 'result' (lines '315'-'317'). +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:318: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:318: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:321: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:321: Useless parentheses. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:321: Useless parentheses. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:330: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:330: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:331: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:331: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:338: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:338: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:344: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:344: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:352: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/IndianBringGiftMission.java:352: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:20: Possible God class (WMC=94, ATFD=47, TCC=0.016666666666666666) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:51: The class 'IndianDemandMission' has a Cyclomatic Complexity of 4 (Highest = 28). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:51: The class 'IndianDemandMission' has a Modified Cyclomatic Complexity of 3 (Highest = 22). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:51: The class 'IndianDemandMission' has a Standard Cyclomatic Complexity of 4 (Highest = 25). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:51: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:53: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:53: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:53: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:59: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:75: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:75: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:75: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:81: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:91: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:91: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:92: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:92: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:114: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: Found 'UR'-anomaly for variable 'currentGoods' (lines '124'-'139'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: Found 'UR'-anomaly for variable 'currentGoods' (lines '124'-'199'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: Found 'UR'-anomaly for variable 'preferred' (lines '124'-'155'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: The method 'selectGoods' has a Cyclomatic Complexity of 24. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: The method 'selectGoods' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: The method 'selectGoods' has a Standard Cyclomatic Complexity of 22. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:124: The method selectGoods() has an NPath complexity of 1608 +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:126: Local variable 'tension' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:126: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:128: Avoid variables with short names like dx +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:128: Local variable 'dx' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:130: Found 'DD'-anomaly for variable 'goods' (lines '130'-'145'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:130: Found 'DD'-anomaly for variable 'goods' (lines '130'-'202'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:130: Found 'DU'-anomaly for variable 'goods' (lines '130'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:134: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:136: Found 'DD'-anomaly for variable 'market' (lines '136'-'196'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:136: Found 'DU'-anomaly for variable 'market' (lines '136'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:136: Local variable 'market' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:136: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:137: Found 'DD'-anomaly for variable 'value' (lines '137'-'197'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:137: Found 'DU'-anomaly for variable 'value' (lines '137'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:138: Local variable 'currentGoods' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:139: Found 'DD'-anomaly for variable 'goodsValue' (lines '139'-'139'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:139: Found 'DU'-anomaly for variable 'goodsValue' (lines '139'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:139: Local variable 'goodsValue' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:141: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:144: Found 'DD'-anomaly for variable 'value' (lines '144'-'197'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:144: Found 'DU'-anomaly for variable 'value' (lines '144'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:145: Found 'DD'-anomaly for variable 'goods' (lines '145'-'145'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:150: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:154: Local variable 'preferred' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:158: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:164: Local variable 'preferred' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:168: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:174: Local variable 'preferred' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:178: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:184: Local variable 'preferred' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:184: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:185: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:188: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:196: Found 'DU'-anomaly for variable 'market' (lines '196'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:196: Local variable 'market' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:196: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:197: Found 'DU'-anomaly for variable 'value' (lines '197'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:198: Local variable 'currentGoods' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:199: Local variable 'goodsValue' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:201: Found 'DU'-anomaly for variable 'value' (lines '201'-'209'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:202: Found 'DD'-anomaly for variable 'goods' (lines '202'-'202'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:211: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:211: Parameter 'difficulty' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:216: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:227: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:228: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:230: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:234: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:237: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:246: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:246: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:247: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:248: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:248: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:251: Local variable 'targetPlayer' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:252: Switch statements should have a default label +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:254: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:256: Local variable 'tension' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:258: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:258: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:259: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:271: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:282: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:282: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:283: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:284: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:289: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:289: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:310: Useless parentheses. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:310: Useless parentheses. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:318: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: Avoid really long methods. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: Found 'UR'-anomaly for variable 'goods' (lines '344'-'443'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: The method 'doMission' has a Cyclomatic Complexity of 28. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: The method 'doMission' has a Modified Cyclomatic Complexity of 20. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: The method 'doMission' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:344: The method doMission() has an NPath complexity of 4500030 +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:346: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:347: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:347: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:349: Found 'DU'-anomaly for variable 'aiUnit' (lines '349'-'448'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:351: Avoid variables with short names like is +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:351: Found 'DU'-anomaly for variable 'is' (lines '351'-'448'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:351: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:352: Avoid variables with short names like d +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:355: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:355: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:359: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:362: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:365: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:365: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:365: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:366: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:369: Local variable 'blocker' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:374: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:376: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:381: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:386: Local variable 'colony' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:387: Found 'DU'-anomaly for variable 'enemy' (lines '387'-'448'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:387: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:388: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:389: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:389: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:389: Found 'DU'-anomaly for variable 'type' (lines '389'-'448'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:389: Local variable 'type' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:390: Found 'DD'-anomaly for variable 'amount' (lines '390'-'395'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:390: Found 'DU'-anomaly for variable 'amount' (lines '390'-'448'). +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:393: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:396: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:402: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:406: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:410: Local variable 'unitTension' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:410: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:411: Local variable 'tension' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:411: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:411: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:412: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:412: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:413: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:413: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:413: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:414: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:415: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:415: These nested if statements could be combined +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:417: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:417: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:422: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:422: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:427: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:430: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:436: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:441: Local variable 'container' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:442: Local variable 'goods' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:442: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:443: Local variable 'tribute' could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:444: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:446: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:453: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:453: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:454: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:454: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:461: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:461: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:468: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:475: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/IndianDemandMission.java:475: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:20: Possible God class (WMC=73, ATFD=29, TCC=0.02857142857142857) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:51: The class 'MissionaryMission' has a Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:51: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:53: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:53: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:53: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:56: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:73: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:73: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:73: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:77: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:88: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:88: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:89: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:89: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:104: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:104: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:105: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:105: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:107: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:107: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:108: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:108: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:115: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:126: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:126: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:127: Local variable 'loc' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:128: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:128: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:142: Avoid variables with short names like gd +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:142: Found 'DU'-anomaly for variable 'gd' (lines '142'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:142: Found 'DU'-anomaly for variable 'gd' (lines '142'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:142: Found 'DU'-anomaly for variable 'gd' (lines '142'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:142: Found 'DU'-anomaly for variable 'gd' (lines '142'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:142: Local variable 'gd' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:143: Avoid using redundant field initializer for 'bestPath' +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:143: Found 'DU'-anomaly for variable 'bestPath' (lines '143'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:143: Found 'DU'-anomaly for variable 'bestPath' (lines '143'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:143: Found 'DU'-anomaly for variable 'bestPath' (lines '143'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:143: Found 'DU'-anomaly for variable 'bestPath' (lines '143'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:143: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:144: Found 'DU'-anomaly for variable 'bestValue' (lines '144'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:144: Found 'DU'-anomaly for variable 'bestValue' (lines '144'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:144: Found 'DU'-anomaly for variable 'bestValue' (lines '144'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:144: Found 'DU'-anomaly for variable 'bestValue' (lines '144'-'167'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:144: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:147: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:149: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:151: Avoid variables with short names like u +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:151: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:151: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:151: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:164: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:164: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:177: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:177: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:178: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:179: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:179: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:183: Avoid variables with short names like gd +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:190: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:199: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:199: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:200: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:201: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:202: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:212: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:217: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:217: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:221: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:221: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:222: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:234: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:235: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:236: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:236: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:238: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:238: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:238: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:243: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:243: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:243: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:245: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:247: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:257: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:257: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:269: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:270: Avoid variables with short names like is +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:270: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:271: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:272: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:272: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:273: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:274: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:274: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:274: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:276: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:276: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:280: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:289: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:300: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:300: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:301: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:302: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:335: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:361: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:361: Found 'UR'-anomaly for variable 'd' (lines '361'-'361'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:361: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:361: The method 'doMission' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:363: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:365: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:367: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:371: Found 'DU'-anomaly for variable 'aiUnit' (lines '371'-'412'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:372: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:372: Found 'DU'-anomaly for variable 'unit' (lines '372'-'412'). +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:374: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:374: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:381: Local variable 'completed' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:382: Local variable 'newTarget' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:383: Use equals() to compare object references. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:384: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:387: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:391: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:394: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:400: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:405: Avoid variables with short names like d +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:405: Local variable 'd' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:405: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:405: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:405: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:407: Avoid variables with short names like is +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:407: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:409: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:409: Useless parentheses. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:417: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:417: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:424: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:424: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:436: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/MissionaryMission.java:436: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:20: Possible God class (WMC=84, ATFD=45, TCC=0.04329004329004329) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:50: The class 'PrivateerMission' has a Cyclomatic Complexity of 3 (Highest = 15). +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:50: The class 'PrivateerMission' has a Modified Cyclomatic Complexity of 3 (Highest = 11). +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:50: The class 'PrivateerMission' has a Standard Cyclomatic Complexity of 3 (Highest = 14). +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:50: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:52: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:52: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:55: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:73: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:73: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:73: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:77: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:88: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:88: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:89: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:89: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:104: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:104: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:117: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:117: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:118: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:118: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:122: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:123: Local variable 'tile' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:124: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:124: Local variable 'other' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:125: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:125: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:130: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:140: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:140: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:141: Found 'DU'-anomaly for variable 'attacker' (lines '141'-'152'). +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:147: Avoid variables with short names like co +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:147: Local variable 'co' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:147: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:149: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:161: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:161: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:162: Local variable 'loc' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:164: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:166: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:168: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:182: Avoid unused method parameters such as 'deferOK'. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:182: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:184: Avoid using redundant field initializer for 'bestPath' +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:184: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:185: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:188: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:190: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:192: Avoid variables with short names like u +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:192: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:192: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:192: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:193: Local variable 'value' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:212: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:212: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:213: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:214: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:214: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:232: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:232: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:233: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:234: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:235: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:236: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:246: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:247: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:248: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:248: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:250: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:250: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:250: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:251: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:252: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:254: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:265: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:266: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:267: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:267: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:268: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:280: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:280: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:282: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:282: Avoid unused local variables such as 'pirate'. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:282: Found 'DU'-anomaly for variable 'pirate' (lines '282'-'295'). +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:282: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:286: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:290: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:294: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:303: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:314: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:314: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:315: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:316: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:317: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:319: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:319: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:320: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:322: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:330: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:330: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:330: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:330: Useless parentheses. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:331: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:359: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:387: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:387: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:387: The method 'doMission' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:387: The method 'doMission' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:387: The method 'doMission' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:387: The method doMission() has an NPath complexity of 1728 +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:391: Avoid variables with short names like m +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:391: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:391: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:392: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:395: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:397: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:399: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:404: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:405: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:405: Local variable 'tile' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:410: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:410: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:410: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:412: Local variable 'newTarget' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:415: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:419: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:419: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:426: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:430: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:433: Local variable 'direction' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:433: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:434: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:435: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:439: Local variable 'blocker' could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:442: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:443: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:443: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:450: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:453: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:462: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:462: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:469: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:469: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:481: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/PrivateerMission.java:481: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:20: Possible God class (WMC=96, ATFD=59, TCC=0.043478260869565216) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:50: The class 'UnitSeekAndDestroyMission' has a Cyclomatic Complexity of 4 (Highest = 22). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:50: The class 'UnitSeekAndDestroyMission' has a Modified Cyclomatic Complexity of 3 (Highest = 12). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:50: The class 'UnitSeekAndDestroyMission' has a Standard Cyclomatic Complexity of 3 (Highest = 14). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:50: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:52: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:55: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:61: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:72: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:72: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:73: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:77: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:88: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:88: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:89: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:89: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:103: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:103: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:104: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:105: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:106: Avoid variables with short names like t +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:107: Avoid variables with short names like u +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:108: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:108: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:109: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:116: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:119: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:133: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:133: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:134: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:136: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:149: Local variable 'colony' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:152: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:156: Avoid variables with short names like is +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:156: Local variable 'is' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:157: Local variable 'tension' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:158: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:160: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:172: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:172: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:173: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:175: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:179: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:179: Found 'DU'-anomaly for variable 'turns' (lines '179'-'202'). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:180: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:182: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:182: Found 'DU'-anomaly for variable 'def' (lines '182'-'202'). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:183: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:183: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:190: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:191: Avoid variables with short names like u +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:195: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:197: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:212: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:212: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:213: Local variable 'loc' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:214: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:214: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:230: Avoid unused method parameters such as 'deferOK'. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:230: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:232: Avoid using redundant field initializer for 'bestPath' +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:232: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:233: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:236: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:238: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:240: Avoid variables with short names like u +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:240: Parameter 'path' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:240: Parameter 'u' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:240: publicMethodCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:241: Local variable 'value' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:260: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:260: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:261: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:262: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:262: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:280: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:280: Parameter 'range' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:281: Parameter 'deferOK' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:282: Local variable 'path' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:283: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:284: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:294: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:295: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:296: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:298: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:298: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:298: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:300: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:300: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:302: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:305: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:314: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:315: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:316: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:317: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:317: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:319: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:319: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:319: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:326: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:335: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:335: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:336: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:337: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:337: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:345: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:345: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:345: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:356: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:367: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:367: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:368: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:369: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:395: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:395: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:396: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:396: Local variable 'loc' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:397: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:397: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:397: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:412: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:416: Local variable 'unit' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:417: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:419: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:419: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:420: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:421: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:422: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:424: There is log block not surrounded by if +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:426: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:426: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:426: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:426: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:455: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:455: Found 'UR'-anomaly for variable 'd' (lines '455'-'455'). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:455: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:455: The method 'doMission' has a Cyclomatic Complexity of 22. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:455: The method 'doMission' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:455: The method 'doMission' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:455: The method doMission() has an NPath complexity of 28600 +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:457: Found 'DU'-anomaly for variable 'aiUnit' (lines '457'-'533'). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:458: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:461: Avoid unused local variables such as 'm'. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:461: Avoid variables with short names like m +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:462: Avoid assignments in operands +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:462: Found 'DU'-anomaly for variable 'm' (lines '462'-'533'). +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:462: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:465: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:466: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:466: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:468: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:468: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:470: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:472: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:477: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:477: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:477: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:477: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:477: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:482: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:485: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:487: Local variable 'now' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:487: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:488: Local variable 'nearbyTile' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:488: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:489: Local variable 'targetTile' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:489: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:491: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:491: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:491: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:491: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:492: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:493: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:501: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:501: Local variable 'currentTarget' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:504: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:504: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:509: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:512: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:515: Local variable 'unitTile' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:515: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:516: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:516: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:517: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:520: Avoid variables with short names like m +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:520: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:520: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:522: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:525: Avoid variables with short names like d +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:525: Local variable 'd' could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:528: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:538: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:538: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:545: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:545: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:557: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/UnitSeekAndDestroyMission.java:557: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:42: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:42: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:45: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:54: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:54: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:58: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:69: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:69: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:70: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:70: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:84: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:86: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:86: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:86: Useless parentheses. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:87: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:88: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:97: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:99: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:100: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:101: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:111: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:112: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:114: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:115: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:116: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:135: Document empty method +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:135: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:165: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:165: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:167: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:168: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:168: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:173: Found 'DU'-anomaly for variable 'aiUnit' (lines '173'-'190'). +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:174: Found 'DU'-anomaly for variable 'check' (lines '174'-'190'). +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:174: Found 'DU'-anomaly for variable 'checkTurns' (lines '174'-'190'). +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:174: Local variable 'checkTurns' could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:174: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:176: Avoid variables with short names like d +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:176: Found 'DD'-anomaly for variable 'd' (lines '176'-'187'). +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:176: Found 'DU'-anomaly for variable 'd' (lines '176'-'190'). +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:180: Avoid variables with short names like m +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:180: Local variable 'm' could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:180: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:182: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:182: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:184: Found 'DU'-anomaly for variable 'check' (lines '184'-'190'). +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:185: Avoid using if...else statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:185: Found 'DU'-anomaly for variable 'check' (lines '185'-'190'). +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:187: Avoid assignments in operands +src/net/sf/freecol/server/ai/mission/UnitWanderHostileMission.java:187: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:38: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:38: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:38: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:41: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:50: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:50: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:54: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:65: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:65: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:66: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:66: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:88: Document empty method +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:88: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:118: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:118: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:120: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/UnitWanderMission.java:121: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:47: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:47: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:47: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:50: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:53: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:64: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:64: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:64: Parameter 'wish' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:71: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:82: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:82: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:83: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:83: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:106: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:106: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:108: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:109: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:110: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:111: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:125: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:143: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:150: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:175: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:175: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:177: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:178: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:178: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:181: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:181: Found 'DU'-anomaly for variable 'unit' (lines '181'-'230'). +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:182: Local variable 'target' could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:183: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:183: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:191: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:194: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:197: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:210: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:211: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:218: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:228: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:235: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:235: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:237: Avoid excessively long variable names like OLD_GOODS_WISH_TAG +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:237: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:237: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:245: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:245: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:255: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:255: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WishRealizationMission.java:260: Found 'DU'-anomaly for variable 'wid' (lines '260'-'277'). +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:43: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:43: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:46: Variables that are final and static should be all capitals, 'tag' is not all capitals. +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:60: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:60: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:61: Parameter 'aiColony' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:65: Comment is too large: Too many lines +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:76: Parameter 'aiMain' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:76: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:77: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:77: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:90: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:100: Parameter 'aiUnit' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:100: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:102: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:103: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:103: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:104: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:106: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:133: Parameter 'target' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:159: Avoid variables with short names like lb +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:159: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:161: Local variable 'reason' could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:162: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:162: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:164: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:164: Found 'DU'-anomaly for variable 'unit' (lines '164'-'185'). +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:165: Avoid variables with short names like mt +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:165: Local variable 'mt' could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:173: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:176: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:179: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:183: Avoid using if statements without curly braces +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:190: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:190: fieldCommentRequirement Required +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:197: Avoid variables with short names like xw +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:197: Parameter 'xw' is not assigned and could be declared final +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:207: Avoid variables with short names like xr +src/net/sf/freecol/server/ai/mission/WorkInsideColonyMission.java:207: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/control/Controller.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/Controller.java:32: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/control/Controller.java:34: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/control/Controller.java:34: fieldCommentRequirement Required +src/net/sf/freecol/server/control/Controller.java:42: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/control/Controller.java:51: Local variable 'server' could be declared final +src/net/sf/freecol/server/control/Controller.java:51: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/Controller.java:52: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/Controller.java:53: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/FreeColServerHolder.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/FreeColServerHolder.java:41: Parameter 'server' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/control/InGameController.java:20: Possible God class (WMC=539, ATFD=820, TCC=0.04692982456140351) +src/net/sf/freecol/server/control/InGameController.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/server/control/InGameController.java:149: Avoid really long classes. +src/net/sf/freecol/server/control/InGameController.java:149: The class 'InGameController' has a Cyclomatic Complexity of 5 (Highest = 43). +src/net/sf/freecol/server/control/InGameController.java:149: The class 'InGameController' has a Modified Cyclomatic Complexity of 5 (Highest = 32). +src/net/sf/freecol/server/control/InGameController.java:149: The class 'InGameController' has a Standard Cyclomatic Complexity of 5 (Highest = 32). +src/net/sf/freecol/server/control/InGameController.java:149: The type has an NCSS line count of 1973 +src/net/sf/freecol/server/control/InGameController.java:149: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/control/InGameController.java:151: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/control/InGameController.java:151: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:154: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:157: Avoid using redundant field initializer for 'debugOnlyAITurns' +src/net/sf/freecol/server/control/InGameController.java:157: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:158: Avoid excessively long variable names like debugMonarchAction +src/net/sf/freecol/server/control/InGameController.java:158: Avoid using redundant field initializer for 'debugMonarchAction' +src/net/sf/freecol/server/control/InGameController.java:158: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:158: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:159: Avoid excessively long variable names like debugMonarchPlayer +src/net/sf/freecol/server/control/InGameController.java:159: Avoid using redundant field initializer for 'debugMonarchPlayer' +src/net/sf/freecol/server/control/InGameController.java:159: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:159: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:168: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:168: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:180: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:180: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:189: Parameter 'turns' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:202: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:203: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:227: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:228: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:228: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:240: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:241: Parameter 'father' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:242: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:242: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:245: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:249: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:259: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:259: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:260: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:260: Parameter 'symmetric' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:261: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:261: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:263: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:273: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:274: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:275: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:275: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:276: Local variable 'owner' could be declared final +src/net/sf/freecol/server/control/InGameController.java:278: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:278: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:290: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:290: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:291: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:291: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:292: Local variable 'owner' could be declared final +src/net/sf/freecol/server/control/InGameController.java:293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:295: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:295: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:298: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:308: Found 'UR'-anomaly for variable 'message' (lines '308'-'320'). +src/net/sf/freecol/server/control/InGameController.java:308: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:308: Parameter 'disaster' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:309: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:309: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:310: Local variable 'owner' could be declared final +src/net/sf/freecol/server/control/InGameController.java:311: Local variable 'messages' could be declared final +src/net/sf/freecol/server/control/InGameController.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:317: The String literal "%colony%" appears 5 times in this file; the first occurrence is on line 317 +src/net/sf/freecol/server/control/InGameController.java:319: Local variable 'message' could be declared final +src/net/sf/freecol/server/control/InGameController.java:322: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:335: Avoid unused private methods such as 'moveGoods(GoodsLocation,GoodsType,int,GoodsLocation)'. +src/net/sf/freecol/server/control/InGameController.java:335: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:335: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:335: Parameter 'src' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:336: Parameter 'dst' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:340: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:352: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:353: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:357: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:368: Found 'UR'-anomaly for variable 't' (lines '368'-'377'). +src/net/sf/freecol/server/control/InGameController.java:368: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:369: Local variable 'refNation' could be declared final +src/net/sf/freecol/server/control/InGameController.java:369: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:370: Local variable 'monarch' could be declared final +src/net/sf/freecol/server/control/InGameController.java:371: Local variable 'refPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:371: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:372: Local variable 'europe' could be declared final +src/net/sf/freecol/server/control/InGameController.java:372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:375: Local variable 'explore' could be declared final +src/net/sf/freecol/server/control/InGameController.java:376: Local variable 't' could be declared final +src/net/sf/freecol/server/control/InGameController.java:376: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:376: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:377: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:384: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:392: Local variable 'exf' could be declared final +src/net/sf/freecol/server/control/InGameController.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:397: Avoid variables with short names like ut +src/net/sf/freecol/server/control/InGameController.java:397: Found 'DU'-anomaly for variable 'ut' (lines '397'-'410'). +src/net/sf/freecol/server/control/InGameController.java:397: Local variable 'ut' could be declared final +src/net/sf/freecol/server/control/InGameController.java:397: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:399: Avoid variables with short names like au +src/net/sf/freecol/server/control/InGameController.java:399: Local variable 'au' could be declared final +src/net/sf/freecol/server/control/InGameController.java:400: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:404: Local variable 'landUnits' could be declared final +src/net/sf/freecol/server/control/InGameController.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:406: Local variable 'navalUnits' could be declared final +src/net/sf/freecol/server/control/InGameController.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:417: headerCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:418: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/control/InGameController.java:418: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:421: headerCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:423: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:423: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:424: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:424: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:425: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:425: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:426: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:426: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:429: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:429: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:429: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:430: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:431: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:439: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:442: Found 'DU'-anomaly for variable 'reply' (lines '442'-'449'). +src/net/sf/freecol/server/control/InGameController.java:444: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:446: Local variable 'replyMessage' could be declared final +src/net/sf/freecol/server/control/InGameController.java:447: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:453: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/control/InGameController.java:453: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InGameController.java:453: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:455: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:464: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:465: Parameter 'question' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:466: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:467: Local variable 'callable' could be declared final +src/net/sf/freecol/server/control/InGameController.java:480: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:481: Parameter 'request' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:482: Found 'DU'-anomaly for variable 'future' (lines '482'-'503'). +src/net/sf/freecol/server/control/InGameController.java:482: Found 'DU'-anomaly for variable 'future' (lines '482'-'503'). +src/net/sf/freecol/server/control/InGameController.java:482: Local variable 'future' could be declared final +src/net/sf/freecol/server/control/InGameController.java:485: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:485: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:491: Local variable 'single' could be declared final +src/net/sf/freecol/server/control/InGameController.java:491: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:492: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:497: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:499: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:505: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:521: Avoid variables with short names like is +src/net/sf/freecol/server/control/InGameController.java:521: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:521: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:522: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:522: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:522: Parameter 'scout' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:528: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:528: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:528: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:539: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:548: Avoid really long methods. +src/net/sf/freecol/server/control/InGameController.java:548: Found 'UR'-anomaly for variable 'p' (lines '548'-'602'). +src/net/sf/freecol/server/control/InGameController.java:548: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:548: The method 'endTurn' has a Cyclomatic Complexity of 28. +src/net/sf/freecol/server/control/InGameController.java:548: The method 'endTurn' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/server/control/InGameController.java:548: The method 'endTurn' has a Standard Cyclomatic Complexity of 23. +src/net/sf/freecol/server/control/InGameController.java:548: The method endTurn() has an NPath complexity of 552966 +src/net/sf/freecol/server/control/InGameController.java:549: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:549: Found 'DU'-anomaly for variable 'freeColServer' (lines '549'-'709'). +src/net/sf/freecol/server/control/InGameController.java:551: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:551: Found 'DU'-anomaly for variable 'winner' (lines '551'-'709'). +src/net/sf/freecol/server/control/InGameController.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:553: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:554: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:561: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:562: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:565: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:565: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:565: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:566: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:567: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:567: Local variable 'next' could be declared final +src/net/sf/freecol/server/control/InGameController.java:568: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:569: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:571: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:571: Avoid variables with short names like lb +src/net/sf/freecol/server/control/InGameController.java:571: Local variable 'lb' could be declared final +src/net/sf/freecol/server/control/InGameController.java:572: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:572: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:572: The String literal " for " appears 4 times in this file; the first occurrence is on line 572 +src/net/sf/freecol/server/control/InGameController.java:573: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:574: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:575: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:577: Avoid assignments in operands +src/net/sf/freecol/server/control/InGameController.java:577: Deeply nested if..then statements are hard to read +src/net/sf/freecol/server/control/InGameController.java:577: These nested if statements could be combined +src/net/sf/freecol/server/control/InGameController.java:586: Avoid assignments in operands +src/net/sf/freecol/server/control/InGameController.java:586: Found 'DU'-anomaly for variable 'player' (lines '586'-'709'). +src/net/sf/freecol/server/control/InGameController.java:586: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:588: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:592: A switch statement does not contain a break +src/net/sf/freecol/server/control/InGameController.java:592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:594: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:595: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:595: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:596: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:597: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:601: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/InGameController.java:601: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:604: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:605: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:605: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:605: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:606: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:611: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:617: Local variable 'onlyAI' could be declared final +src/net/sf/freecol/server/control/InGameController.java:617: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:617: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:628: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:628: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:634: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:635: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:635: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:635: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:636: Local variable 'highScore' could be declared final +src/net/sf/freecol/server/control/InGameController.java:636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:641: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:646: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:650: Local variable 'refAIPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:650: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:652: Local variable 'teleport' could be declared final +src/net/sf/freecol/server/control/InGameController.java:652: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:652: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:654: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:660: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:665: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:666: Found 'DU'-anomaly for variable 'monarch' (lines '666'-'709'). +src/net/sf/freecol/server/control/InGameController.java:666: Local variable 'monarch' could be declared final +src/net/sf/freecol/server/control/InGameController.java:666: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:667: Found 'DD'-anomaly for variable 'action' (lines '667'-'670'). +src/net/sf/freecol/server/control/InGameController.java:667: Found 'DD'-anomaly for variable 'action' (lines '667'-'675'). +src/net/sf/freecol/server/control/InGameController.java:669: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:671: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:672: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:673: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:677: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:680: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:681: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:684: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:696: Local variable 'debugSkip' could be declared final +src/net/sf/freecol/server/control/InGameController.java:696: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:697: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:700: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:701: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:706: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:706: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:707: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/control/InGameController.java:707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:718: Found 'UR'-anomaly for variable 'p' (lines '718'-'725'). +src/net/sf/freecol/server/control/InGameController.java:718: Found 'UR'-anomaly for variable 'u' (lines '718'-'732'). +src/net/sf/freecol/server/control/InGameController.java:718: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:718: Parameter 'teleport' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:719: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:719: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:724: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/InGameController.java:725: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:725: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:726: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/control/InGameController.java:730: Found 'DU'-anomaly for variable 'seen' (lines '730'-'754'). +src/net/sf/freecol/server/control/InGameController.java:730: Local variable 'seen' could be declared final +src/net/sf/freecol/server/control/InGameController.java:731: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:732: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:733: Local variable 'entry' could be declared final +src/net/sf/freecol/server/control/InGameController.java:733: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:741: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:747: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:748: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:751: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:751: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:756: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:765: Found 'UR'-anomaly for variable 'p' (lines '765'-'786'). +src/net/sf/freecol/server/control/InGameController.java:765: Found 'UR'-anomaly for variable 'u' (lines '765'-'798'). +src/net/sf/freecol/server/control/InGameController.java:765: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:766: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:766: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:766: Parameter 'independent' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:769: Local variable 'game' could be declared final +src/net/sf/freecol/server/control/InGameController.java:770: Local variable 'turn' could be declared final +src/net/sf/freecol/server/control/InGameController.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:773: Avoid variables with short names like h +src/net/sf/freecol/server/control/InGameController.java:773: Local variable 'h' could be declared final +src/net/sf/freecol/server/control/InGameController.java:784: Avoid variables with short names like n +src/net/sf/freecol/server/control/InGameController.java:784: Found 'DD'-anomaly for variable 'n' (lines '784'-'786'). +src/net/sf/freecol/server/control/InGameController.java:785: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/InGameController.java:785: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:786: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:786: Found 'DD'-anomaly for variable 'n' (lines '786'-'786'). +src/net/sf/freecol/server/control/InGameController.java:796: Local variable 'surrenderUnits' could be declared final +src/net/sf/freecol/server/control/InGameController.java:797: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:803: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:803: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:819: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:819: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:823: The String literal "%nation%" appears 13 times in this file; the first occurrence is on line 823 +src/net/sf/freecol/server/control/InGameController.java:831: Found 'UR'-anomaly for variable 'u' (lines '831'-'834'). +src/net/sf/freecol/server/control/InGameController.java:831: Parameter 'base' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:831: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:832: Local variable 'template' could be declared final +src/net/sf/freecol/server/control/InGameController.java:833: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:834: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:847: Avoid unused private methods such as 'raiseTax(ServerPlayer,int,Goods,boolean)'. +src/net/sf/freecol/server/control/InGameController.java:847: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:847: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:847: Parameter 'taxRaise' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:848: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:849: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:849: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:854: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:865: Avoid really long methods. +src/net/sf/freecol/server/control/InGameController.java:865: The method 'csMonarchAction' has a Cyclomatic Complexity of 24. +src/net/sf/freecol/server/control/InGameController.java:865: The method 'csMonarchAction' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/server/control/InGameController.java:865: The method 'csMonarchAction' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/server/control/InGameController.java:865: The method csMonarchAction() has an NCSS line count of 113 +src/net/sf/freecol/server/control/InGameController.java:866: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:866: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:866: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:869: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:869: Found 'DU'-anomaly for variable 'spec' (lines '869'-'1,033'). +src/net/sf/freecol/server/control/InGameController.java:870: Local variable 'valid' could be declared final +src/net/sf/freecol/server/control/InGameController.java:871: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:872: Found 'DU'-anomaly for variable 'messageId' (lines '872'-'1,033'). +src/net/sf/freecol/server/control/InGameController.java:872: Local variable 'messageId' could be declared final +src/net/sf/freecol/server/control/InGameController.java:875: Found 'DU'-anomaly for variable 'monarchKey' (lines '875'-'1,033'). +src/net/sf/freecol/server/control/InGameController.java:875: Local variable 'monarchKey' could be declared final +src/net/sf/freecol/server/control/InGameController.java:881: Found 'DU'-anomaly for variable 'taxRaise' (lines '881'-'1,033'). +src/net/sf/freecol/server/control/InGameController.java:887: Found 'DD'-anomaly for variable 'template' (lines '887'-'891'). +src/net/sf/freecol/server/control/InGameController.java:887: Found 'DD'-anomaly for variable 'template' (lines '887'-'894'). +src/net/sf/freecol/server/control/InGameController.java:887: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:887: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:887: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:888: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:889: The String literal "%amount%" appears 6 times in this file; the first occurrence is on line 889 +src/net/sf/freecol/server/control/InGameController.java:894: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:894: The String literal "%number%" appears 5 times in this file; the first occurrence is on line 894 +src/net/sf/freecol/server/control/InGameController.java:905: Local variable 'oldTax' could be declared final +src/net/sf/freecol/server/control/InGameController.java:906: Local variable 'taxLower' could be declared final +src/net/sf/freecol/server/control/InGameController.java:908: Found 'DD'-anomaly for variable 'template' (lines '908'-'912'). +src/net/sf/freecol/server/control/InGameController.java:908: Found 'DD'-anomaly for variable 'template' (lines '908'-'915'). +src/net/sf/freecol/server/control/InGameController.java:908: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:908: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:927: Local variable 'refAdditions' could be declared final +src/net/sf/freecol/server/control/InGameController.java:928: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:929: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:930: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:930: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:938: Local variable 'friends' could be declared final +src/net/sf/freecol/server/control/InGameController.java:939: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:940: Local variable 'friend' could be declared final +src/net/sf/freecol/server/control/InGameController.java:945: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:951: Local variable 'enemies' could be declared final +src/net/sf/freecol/server/control/InGameController.java:952: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:953: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/control/InGameController.java:955: Local variable 'warSupport' could be declared final +src/net/sf/freecol/server/control/InGameController.java:957: Found 'DD'-anomaly for variable 'warGold' (lines '957'-'961'). +src/net/sf/freecol/server/control/InGameController.java:966: The String literal "gold" appears 21 times in this file; the first occurrence is on line 966 +src/net/sf/freecol/server/control/InGameController.java:966: The String literal "score" appears 6 times in this file; the first occurrence is on line 966 +src/net/sf/freecol/server/control/InGameController.java:967: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:967: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:967: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:974: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:974: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:974: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:975: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:975: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:984: Local variable 'sea' could be declared final +src/net/sf/freecol/server/control/InGameController.java:985: Local variable 'support' could be declared final +src/net/sf/freecol/server/control/InGameController.java:986: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:991: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1000: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1002: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1002: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1015: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1016: Avoid variables with short names like n +src/net/sf/freecol/server/control/InGameController.java:1016: Local variable 'n' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1018: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1018: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1018: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1030: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1035: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1035: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:1036: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1036: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1037: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1040: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1041: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1042: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1043: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1046: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1046: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1047: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1057: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1058: Local variable 'highScore' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1059: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1059: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1061: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1073: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1074: Found 'DU'-anomaly for variable 'game' (lines '1,074'-'1,095'). +src/net/sf/freecol/server/control/InGameController.java:1075: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:1075: Avoid unused local variables such as 'reply'. +src/net/sf/freecol/server/control/InGameController.java:1075: Found 'DU'-anomaly for variable 'reply' (lines '1,075'-'1,095'). +src/net/sf/freecol/server/control/InGameController.java:1075: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1076: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:1076: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1078: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:1078: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1079: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1083: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1084: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1084: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1086: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1086: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1088: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1088: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1090: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1090: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1104: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1104: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1105: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1105: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1108: Local variable 'fullAmount' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1128: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:1128: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:1132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1157: Avoid really long methods. +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'colony' (lines '1,157'-'1,240'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'colony' (lines '1,157'-'1,240'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'entry' (lines '1,157'-'1,258'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'entry' (lines '1,157'-'1,258'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'u' (lines '1,157'-'1,187'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'u' (lines '1,157'-'1,187'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'unit' (lines '1,157'-'1,247'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'unit' (lines '1,157'-'1,247'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'unitType' (lines '1,157'-'1,233'). +src/net/sf/freecol/server/control/InGameController.java:1157: Found 'UR'-anomaly for variable 'unitType' (lines '1,157'-'1,233'). +src/net/sf/freecol/server/control/InGameController.java:1157: The method 'declareIndependence' has a Cyclomatic Complexity of 26. +src/net/sf/freecol/server/control/InGameController.java:1157: The method 'declareIndependence' has a Modified Cyclomatic Complexity of 23. +src/net/sf/freecol/server/control/InGameController.java:1157: The method 'declareIndependence' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/server/control/InGameController.java:1157: The method declareIndependence() has an NCSS line count of 132 +src/net/sf/freecol/server/control/InGameController.java:1157: The method declareIndependence() has an NPath complexity of 375408 +src/net/sf/freecol/server/control/InGameController.java:1158: Parameter 'countryName' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1158: Parameter 'nationName' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1161: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1161: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1164: Found 'DU'-anomaly for variable 'oldNation' (lines '1,164'-'1,372'). +src/net/sf/freecol/server/control/InGameController.java:1164: Found 'DU'-anomaly for variable 'oldNation' (lines '1,164'-'1,372'). +src/net/sf/freecol/server/control/InGameController.java:1164: Local variable 'oldNation' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1171: Local variable 'turn' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1172: Avoid variables with short names like h +src/net/sf/freecol/server/control/InGameController.java:1172: Local variable 'h' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1183: Local variable 'europe' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1184: Local variable 'seized' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1185: Found 'DD'-anomaly for variable 'lost' (lines '1,185'-'1,190'). +src/net/sf/freecol/server/control/InGameController.java:1185: Found 'DD'-anomaly for variable 'lost' (lines '1,185'-'1,190'). +src/net/sf/freecol/server/control/InGameController.java:1186: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1186: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1189: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1190: Found 'DD'-anomaly for variable 'lost' (lines '1,190'-'1,190'). +src/net/sf/freecol/server/control/InGameController.java:1190: Found 'DD'-anomaly for variable 'lost' (lines '1,190'-'1,190'). +src/net/sf/freecol/server/control/InGameController.java:1190: Found 'DD'-anomaly for variable 'lost' (lines '1,190'-'1,197'). +src/net/sf/freecol/server/control/InGameController.java:1190: Found 'DD'-anomaly for variable 'lost' (lines '1,190'-'1,197'). +src/net/sf/freecol/server/control/InGameController.java:1192: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1192: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1197: Found 'DD'-anomaly for variable 'lost' (lines '1,197'-'1,197'). +src/net/sf/freecol/server/control/InGameController.java:1197: Found 'DD'-anomaly for variable 'lost' (lines '1,197'-'1,197'). +src/net/sf/freecol/server/control/InGameController.java:1210: Local variable 'refPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1214: Local variable 'otherKey' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1231: Local variable 'upgrades' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1232: Local variable 'unitType' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1233: Local variable 'upgrade' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1235: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1237: Local variable 'unitMap' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1238: Local variable 'colony' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1239: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:1239: Local variable 'allUnits' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1240: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1240: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1243: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1246: Local variable 'unit' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1250: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:1251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1256: Local variable 'entry' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1257: Avoid variables with short names like n +src/net/sf/freecol/server/control/InGameController.java:1258: Local variable 'type' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1258: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1259: Local variable 'units' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1259: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1261: Local variable 'unit' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1263: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1267: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:1270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1283: Found 'DU'-anomaly for variable 'natives' (lines '1,283'-'1,372'). +src/net/sf/freecol/server/control/InGameController.java:1283: Found 'DU'-anomaly for variable 'natives' (lines '1,283'-'1,372'). +src/net/sf/freecol/server/control/InGameController.java:1283: Local variable 'natives' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1284: Avoid variables with short names like p +src/net/sf/freecol/server/control/InGameController.java:1286: Avoid variables with short names like p1 +src/net/sf/freecol/server/control/InGameController.java:1286: Avoid variables with short names like p2 +src/net/sf/freecol/server/control/InGameController.java:1286: Parameter 'p1' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1286: Parameter 'p2' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1286: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameController.java:1287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1288: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1292: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1293: Local variable 'good' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1293: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1294: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1294: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1302: The default label should be the last label in a switch statement +src/net/sf/freecol/server/control/InGameController.java:1307: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:1308: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1311: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:1312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1315: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1317: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1318: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:1322: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1323: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1323: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:1324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1326: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1328: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1328: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1332: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:1333: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1342: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1343: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1345: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1346: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1346: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1358: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1358: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1370: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1371: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1382: Parameter 'object' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1382: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1383: Parameter 'newName' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1384: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1384: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1387: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1387: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1390: Local variable 'fcgo' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1394: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1399: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1408: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1408: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1409: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1410: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1410: Found 'DU'-anomaly for variable 'cs' (lines '1,410'-'1,436'). +src/net/sf/freecol/server/control/InGameController.java:1410: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1415: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1423: The String literal "movesLeft" appears 13 times in this file; the first occurrence is on line 1,423 +src/net/sf/freecol/server/control/InGameController.java:1447: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1447: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1448: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1449: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1452: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1455: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1455: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1476: Found 'UR'-anomaly for variable 'goods' (lines '1,476'-'1,486'). +src/net/sf/freecol/server/control/InGameController.java:1476: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1476: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1477: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1478: Found 'DD'-anomaly for variable 'sellGoods' (lines '1,478'-'1,484'). +src/net/sf/freecol/server/control/InGameController.java:1478: Found 'DU'-anomaly for variable 'sellGoods' (lines '1,478'-'1,493'). +src/net/sf/freecol/server/control/InGameController.java:1481: Local variable 'indianSettlement' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1482: Found 'DU'-anomaly for variable 'aiPlayer' (lines '1,482'-'1,493'). +src/net/sf/freecol/server/control/InGameController.java:1482: Local variable 'aiPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1482: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1484: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1485: Local variable 'goods' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1486: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1489: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1496: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1506: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1507: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1507: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1508: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1508: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1509: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1512: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1514: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1515: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1517: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1517: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1523: Avoid variables with short names like ai +src/net/sf/freecol/server/control/InGameController.java:1523: Local variable 'ai' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1523: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1524: Local variable 'gold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1532: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1542: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1543: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1543: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1544: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1544: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1545: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1548: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1550: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1551: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1553: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1553: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1559: Avoid variables with short names like ai +src/net/sf/freecol/server/control/InGameController.java:1559: Local variable 'ai' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1559: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1560: Local variable 'gold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1568: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1577: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1577: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1578: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1578: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1580: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1583: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:1583: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1583: Found 'DU'-anomaly for variable 'cs' (lines '1,583'-'1,602'). +src/net/sf/freecol/server/control/InGameController.java:1583: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1584: Local variable 'container' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1586: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:1586: Found 'DU'-anomaly for variable 'gold' (lines '1,586'-'1,602'). +src/net/sf/freecol/server/control/InGameController.java:1586: Local variable 'gold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1587: Local variable 'buyAmount' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1589: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1597: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1604: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1613: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1613: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1614: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1614: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1616: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1616: Found 'DU'-anomaly for variable 'cs' (lines '1,616'-'1,642'). +src/net/sf/freecol/server/control/InGameController.java:1616: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1617: Local variable 'container' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1620: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:1620: Found 'DU'-anomaly for variable 'gold' (lines '1,620'-'1,642'). +src/net/sf/freecol/server/control/InGameController.java:1620: Local variable 'gold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1621: Local variable 'sellAmount' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1623: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1629: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1635: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:1653: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1653: Parameter 'slot' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1654: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1655: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1655: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1671: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1671: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1672: Parameter 'newTile' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1673: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1673: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1675: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1686: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1686: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1691: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1691: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1693: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1705: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1705: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1706: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1707: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1707: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1716: Local variable 'turn' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1716: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1717: Avoid variables with short names like h +src/net/sf/freecol/server/control/InGameController.java:1717: Local variable 'h' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1725: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1734: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1734: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1735: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1735: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1736: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:1736: Found 'DU'-anomaly for variable 'game' (lines '1,736'-'1,750'). +src/net/sf/freecol/server/control/InGameController.java:1737: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:1737: Found 'DU'-anomaly for variable 'serverRegion' (lines '1,737'-'1,750'). +src/net/sf/freecol/server/control/InGameController.java:1737: Local variable 'serverRegion' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1740: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1744: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1744: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1745: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1745: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1748: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1760: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1760: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1760: The method 'moveTo' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/server/control/InGameController.java:1760: The method 'moveTo' has a Modified Cyclomatic Complexity of 18. +src/net/sf/freecol/server/control/InGameController.java:1760: The method 'moveTo' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/server/control/InGameController.java:1761: Parameter 'destination' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1762: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1762: Found 'DU'-anomaly for variable 'cs' (lines '1,762'-'1,852'). +src/net/sf/freecol/server/control/InGameController.java:1762: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1763: Found 'DU'-anomaly for variable 'highSeas' (lines '1,763'-'1,852'). +src/net/sf/freecol/server/control/InGameController.java:1763: Local variable 'highSeas' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1764: Found 'DU'-anomaly for variable 'current' (lines '1,764'-'1,852'). +src/net/sf/freecol/server/control/InGameController.java:1764: Local variable 'current' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1765: Found 'DD'-anomaly for variable 'others' (lines '1,765'-'1,792'). +src/net/sf/freecol/server/control/InGameController.java:1765: Found 'DU'-anomaly for variable 'others' (lines '1,765'-'1,852'). +src/net/sf/freecol/server/control/InGameController.java:1766: Found 'DD'-anomaly for variable 'invalid' (lines '1,766'-'1,769'). +src/net/sf/freecol/server/control/InGameController.java:1766: Found 'DD'-anomaly for variable 'invalid' (lines '1,766'-'1,794'). +src/net/sf/freecol/server/control/InGameController.java:1766: Found 'DD'-anomaly for variable 'invalid' (lines '1,766'-'1,818'). +src/net/sf/freecol/server/control/InGameController.java:1766: Found 'DD'-anomaly for variable 'invalid' (lines '1,766'-'1,838'). +src/net/sf/freecol/server/control/InGameController.java:1766: Found 'DU'-anomaly for variable 'invalid' (lines '1,766'-'1,852'). +src/net/sf/freecol/server/control/InGameController.java:1768: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:1768: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1771: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:1771: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1771: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1772: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1781: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1783: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1790: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1791: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1792: Found 'DU'-anomaly for variable 'others' (lines '1,792'-'1,852'). +src/net/sf/freecol/server/control/InGameController.java:1797: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:1797: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1797: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1798: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1801: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:1802: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1803: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1803: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1809: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1811: Local variable 'europe' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1816: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1821: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1822: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:1822: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1822: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1822: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1823: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1831: Local variable 'europe' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1836: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1841: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1845: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1845: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1846: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1850: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:1850: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1851: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1854: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1863: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1863: Parameter 'serverUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1864: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1866: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1869: Local variable 'reason' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1871: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1875: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1875: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1879: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1891: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1892: Parameter 'serverUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1894: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1897: Local variable 'carrier' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1899: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1903: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1903: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1905: Local variable 'newLocation' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1905: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1906: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:1906: Local variable 'newTiles' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1906: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1907: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1922: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:1931: Parameter 'attackerPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1932: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1933: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1934: Parameter 'crs' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1935: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1935: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1940: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1942: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1954: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1954: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1955: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1956: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1956: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1959: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1960: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:1977: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1978: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1979: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:1981: Local variable 'skill' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1983: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1986: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1987: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:1989: The String literal " at " appears 5 times in this file; the first occurrence is on line 1,989 +src/net/sf/freecol/server/control/InGameController.java:1993: Found 'DU'-anomaly for variable 'spec' (lines '1,993'-'2,029'). +src/net/sf/freecol/server/control/InGameController.java:1993: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1994: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:1994: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:1997: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1999: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:1999: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2017: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2022: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2023: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2027: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2032: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2042: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2042: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2043: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2044: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2044: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2045: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/control/InGameController.java:2049: Found 'DU'-anomaly for variable 'indianPlayer' (lines '2,049'-'2,099'). +src/net/sf/freecol/server/control/InGameController.java:2049: Local variable 'indianPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2050: Found 'DD'-anomaly for variable 'gold' (lines '2,050'-'2,057'). +src/net/sf/freecol/server/control/InGameController.java:2050: Found 'DD'-anomaly for variable 'gold' (lines '2,050'-'2,061'). +src/net/sf/freecol/server/control/InGameController.java:2050: Found 'DD'-anomaly for variable 'gold' (lines '2,050'-'2,066'). +src/net/sf/freecol/server/control/InGameController.java:2051: Local variable 'year' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2051: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2051: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2052: Local variable 'gifts' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2052: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2055: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2076: Avoid variables with short names like m +src/net/sf/freecol/server/control/InGameController.java:2091: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2092: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2101: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2110: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2111: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2112: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2113: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2113: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2114: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2134: Found 'UR'-anomaly for variable 't' (lines '2,134'-'2,196'). +src/net/sf/freecol/server/control/InGameController.java:2134: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2134: The method 'scoutSpeakToChief' has a Cyclomatic Complexity of 20. +src/net/sf/freecol/server/control/InGameController.java:2134: The method 'scoutSpeakToChief' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/server/control/InGameController.java:2134: The method 'scoutSpeakToChief' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/server/control/InGameController.java:2134: The method scoutSpeakToChief() has an NPath complexity of 3902 +src/net/sf/freecol/server/control/InGameController.java:2135: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2135: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2136: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2136: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2137: Found 'DU'-anomaly for variable 'tile' (lines '2,137'-'2,227'). +src/net/sf/freecol/server/control/InGameController.java:2137: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2138: Found 'DD'-anomaly for variable 'tileDirty' (lines '2,138'-'2,190'). +src/net/sf/freecol/server/control/InGameController.java:2142: Local variable 'tension' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2144: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2153: Local variable 'scoutTypes' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2153: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2155: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:2155: Found 'DU'-anomaly for variable 'scoutSkill' (lines '2,155'-'2,227'). +src/net/sf/freecol/server/control/InGameController.java:2155: Local variable 'scoutSkill' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2155: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2155: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2157: Found 'DD'-anomaly for variable 'radius' (lines '2,157'-'2,176'). +src/net/sf/freecol/server/control/InGameController.java:2158: Found 'DU'-anomaly for variable 'skill' (lines '2,158'-'2,227'). +src/net/sf/freecol/server/control/InGameController.java:2158: Local variable 'skill' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2159: Found 'DU'-anomaly for variable 'rnd' (lines '2,159'-'2,227'). +src/net/sf/freecol/server/control/InGameController.java:2159: Local variable 'rnd' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2164: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2164: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2172: Local variable 'gifts' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2183: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2194: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2195: Local variable 't' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2230: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2239: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2239: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2240: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2241: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2241: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2245: Local variable 'missionary' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2247: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2249: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2259: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/control/InGameController.java:2260: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2264: Local variable 'owner' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2279: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2279: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2291: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2300: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2300: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2301: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2302: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2302: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2308: Switch statements should have a default label +src/net/sf/freecol/server/control/InGameController.java:2310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2310: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2312: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2330: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2339: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2343: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2353: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2353: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2354: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2355: Parameter 'enemy' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2355: Parameter 'gold' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2356: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2356: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2358: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2360: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2361: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2364: Local variable 'enemyPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2365: Local variable 'nativePlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2366: Local variable 'payingValue' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2366: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2366: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2367: Local variable 'targetValue' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2367: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2368: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2368: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2381: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2385: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2394: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2397: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2404: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2417: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2417: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2418: Avoid reassigning parameters such as 'destination' +src/net/sf/freecol/server/control/InGameController.java:2422: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2441: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2441: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2442: Parameter 'index' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2443: Avoid variables with short names like tr +src/net/sf/freecol/server/control/InGameController.java:2443: Local variable 'tr' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2445: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2447: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2447: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2448: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2459: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2469: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2469: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2470: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2471: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2471: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2472: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2472: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2475: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2478: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2481: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2484: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2488: Avoid variables with short names like ai +src/net/sf/freecol/server/control/InGameController.java:2488: Local variable 'ai' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2488: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2489: Local variable 'returnGold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2491: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2494: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2501: Local variable 'settlementPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2502: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2504: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2507: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2510: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2511: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:2515: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2519: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2529: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2529: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2530: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2531: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2531: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2532: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2532: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2535: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2538: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2541: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2545: Avoid variables with short names like ai +src/net/sf/freecol/server/control/InGameController.java:2545: Local variable 'ai' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2545: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2546: Local variable 'returnGold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2548: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2555: Local variable 'settlementPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2556: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2559: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2567: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:2571: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2575: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2584: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2585: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2585: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2586: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2587: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2590: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2593: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2596: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2596: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2597: Found 'DU'-anomaly for variable 'tile' (lines '2,597'-'2,632'). +src/net/sf/freecol/server/control/InGameController.java:2597: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2601: Local variable 'sis' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2603: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2603: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2605: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2606: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2609: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2612: Avoid variables with short names like m +src/net/sf/freecol/server/control/InGameController.java:2612: Local variable 'm' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2620: Local variable 'receiver' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2621: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2626: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:2626: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:2630: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2635: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2645: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2645: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2646: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2646: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2646: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2649: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2651: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2656: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2658: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:2658: Avoid variables with short names like gl +src/net/sf/freecol/server/control/InGameController.java:2658: Found 'DU'-anomaly for variable 'gl' (lines '2,658'-'2,685'). +src/net/sf/freecol/server/control/InGameController.java:2658: Local variable 'gl' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2660: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2663: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2665: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2666: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2667: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2671: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2671: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2673: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:2676: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2687: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2696: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2696: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2697: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2697: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2699: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2702: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2705: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2705: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2706: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:2707: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2709: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:2711: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2711: The String literal " to " appears 4 times in this file; the first occurrence is on line 2,711 +src/net/sf/freecol/server/control/InGameController.java:2712: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2720: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:2724: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2730: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2740: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2740: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2741: Local variable 'newType' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2744: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2754: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:2774: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2774: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2775: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2775: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2778: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2778: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2780: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2780: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2786: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2791: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2801: Found 'UR'-anomaly for variable 'p' (lines '2,801'-'2,866'). +src/net/sf/freecol/server/control/InGameController.java:2801: Found 'UR'-anomaly for variable 'sp' (lines '2,801'-'2,834'). +src/net/sf/freecol/server/control/InGameController.java:2801: Found 'UR'-anomaly for variable 't' (lines '2,801'-'2,817'). +src/net/sf/freecol/server/control/InGameController.java:2801: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2801: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2801: The method 'buildSettlement' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/control/InGameController.java:2801: The method 'buildSettlement' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/control/InGameController.java:2801: The method 'buildSettlement' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/control/InGameController.java:2802: Avoid reassigning parameters such as 'name' +src/net/sf/freecol/server/control/InGameController.java:2804: Found 'DU'-anomaly for variable 'spec' (lines '2,804'-'2,884'). +src/net/sf/freecol/server/control/InGameController.java:2805: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2805: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2808: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2810: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:2814: Found 'DU'-anomaly for variable 'nation' (lines '2,814'-'2,884'). +src/net/sf/freecol/server/control/InGameController.java:2814: Local variable 'nation' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2816: Local variable 't' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2833: Local variable 'sp' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2834: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:2838: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:2844: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2847: Local variable 'nationType' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2854: Local variable 'scouts' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2860: Local variable 't' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2865: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2865: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2866: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:2866: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:2867: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2867: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:2868: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:2868: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:2882: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2894: Found 'UR'-anomaly for variable 't' (lines '2,894'-'2,910'). +src/net/sf/freecol/server/control/InGameController.java:2894: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2894: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2895: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2896: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2897: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2897: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2898: Found 'DU'-anomaly for variable 'ownedTiles' (lines '2,898'-'2,918'). +src/net/sf/freecol/server/control/InGameController.java:2898: Local variable 'ownedTiles' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2899: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2902: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2905: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2909: Local variable 't' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2909: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2910: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:2916: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2928: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2929: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2930: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2930: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2936: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2945: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2950: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2960: Found 'UR'-anomaly for variable 'sp' (lines '2,960'-'2,968'). +src/net/sf/freecol/server/control/InGameController.java:2960: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2960: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2961: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2961: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2962: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2962: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2967: Local variable 'sp' could be declared final +src/net/sf/freecol/server/control/InGameController.java:2967: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2978: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:2983: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:2995: Avoid really long methods. +src/net/sf/freecol/server/control/InGameController.java:2995: Found 'UR'-anomaly for variable 'tradeItem' (lines '2,995'-'3,006'). +src/net/sf/freecol/server/control/InGameController.java:2995: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2995: The method 'csAcceptTrade' has a Cyclomatic Complexity of 43. +src/net/sf/freecol/server/control/InGameController.java:2995: The method 'csAcceptTrade' has a Modified Cyclomatic Complexity of 32. +src/net/sf/freecol/server/control/InGameController.java:2995: The method 'csAcceptTrade' has a Standard Cyclomatic Complexity of 32. +src/net/sf/freecol/server/control/InGameController.java:2995: The method csAcceptTrade() has an NCSS line count of 125 +src/net/sf/freecol/server/control/InGameController.java:2995: The method csAcceptTrade() has an NPath complexity of 304968964 +src/net/sf/freecol/server/control/InGameController.java:2996: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:2996: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:2996: Parameter 'session' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3000: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:3001: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:3004: Found 'DD'-anomaly for variable 'fail' (lines '3,004'-'3,010'). +src/net/sf/freecol/server/control/InGameController.java:3005: Local variable 'tradeItem' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3006: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3007: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3008: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3009: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3010: Found 'DD'-anomaly for variable 'fail' (lines '3,010'-'3,016'). +src/net/sf/freecol/server/control/InGameController.java:3013: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:3013: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:3014: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3015: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3016: Found 'DD'-anomaly for variable 'fail' (lines '3,016'-'3,022'). +src/net/sf/freecol/server/control/InGameController.java:3019: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:3019: Use equals() to compare object references. +src/net/sf/freecol/server/control/InGameController.java:3020: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3021: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3022: Found 'DD'-anomaly for variable 'fail' (lines '3,022'-'3,029'). +src/net/sf/freecol/server/control/InGameController.java:3026: Local variable 'colony' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3026: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3028: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3032: Local variable 'gold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3032: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3033: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3034: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3039: Local variable 'goods' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3039: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3041: Local variable 'loc' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3041: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3043: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3044: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3046: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:3047: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3048: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3051: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3051: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3052: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3059: Avoid variables with short names like u +src/net/sf/freecol/server/control/InGameController.java:3059: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3059: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3061: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:3061: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3062: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3065: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3065: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3066: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3072: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3072: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:3074: Local variable 'tradeItem' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3075: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3076: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3081: Local variable 'stance' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3081: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3083: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3084: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3086: Local variable 'colony' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3086: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3088: Local variable 'former' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3088: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3089: Local variable 't' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3089: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3090: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3092: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3093: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3094: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3094: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3094: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3097: Local variable 'gold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3097: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3099: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3104: Local variable 'goods' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3118: Local variable 'victim' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3126: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:3127: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:3129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3133: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3136: Local variable 'newUnit' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3138: Local variable 'former' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3139: Local variable 'oldTile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3142: Local variable 'carrier' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3143: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3144: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3169: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3182: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3183: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3183: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3184: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3185: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3185: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3188: Avoid variables with short names like u +src/net/sf/freecol/server/control/InGameController.java:3188: Local variable 'u' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3189: Avoid variables with short names like s +src/net/sf/freecol/server/control/InGameController.java:3189: Local variable 's' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3190: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3193: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3208: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3213: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3225: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3226: Parameter 'otherPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3227: Avoid reassigning parameters such as 'agreement' +src/net/sf/freecol/server/control/InGameController.java:3227: Avoid reassigning parameters such as 'agreement' +src/net/sf/freecol/server/control/InGameController.java:3227: Avoid reassigning parameters such as 'agreement' +src/net/sf/freecol/server/control/InGameController.java:3227: Avoid reassigning parameters such as 'agreement' +src/net/sf/freecol/server/control/InGameController.java:3228: Parameter 'session' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3229: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3230: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3230: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3244: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3245: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3252: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3253: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3258: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3260: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3279: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3293: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3302: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3303: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3303: Parameter 'ourUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3304: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3305: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3305: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3315: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3317: The String literal " with " appears 5 times in this file; the first occurrence is on line 3,317 +src/net/sf/freecol/server/control/InGameController.java:3323: Local variable 'otherPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3334: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3343: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3344: Parameter 'otherColony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3344: Parameter 'ourUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3345: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3346: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3346: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3352: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3360: Local variable 'otherPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3371: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3380: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3381: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3381: Parameter 'ourColony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3382: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3383: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:3383: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3383: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3384: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3388: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3392: Local variable 'otherPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3403: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3412: Parameter 'ourUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3412: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3413: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3413: Parameter 'otherColony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3414: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:3414: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3414: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3415: Local variable 'status' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3421: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3427: Local variable 'otherPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3437: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3446: Parameter 'ourColony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3446: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3447: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3447: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3448: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:3448: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3448: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3449: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3453: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3457: Local variable 'otherPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3462: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3475: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3475: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3476: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3477: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3477: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3494: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3494: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3495: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3496: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3498: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3500: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3500: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3502: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3502: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3503: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3509: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3509: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3512: Local variable 'newType' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3514: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:3520: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:3520: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3520: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3522: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3529: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3542: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3542: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3543: Parameter 'loot' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3543: Parameter 'loserId' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3544: Local variable 'session' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3547: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3550: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3554: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3554: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3555: Local variable 'available' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3555: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3560: Local variable 'g' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3562: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3566: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3572: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3574: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3587: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3587: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3588: Local variable 'arrears' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3590: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3593: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3597: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3597: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3598: Local variable 'market' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3607: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3619: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3619: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3620: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3620: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3621: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3621: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3624: Local variable 'serverEurope' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3627: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:3628: Local variable 'serverColony' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3629: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3631: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameController.java:3632: Local variable 'sis' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3633: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3635: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3638: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3638: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:3643: Local variable 'carrier' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3645: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3645: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3646: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3660: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3660: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3661: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3661: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3663: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3666: Local variable 'build' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3668: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3671: Local variable 'required' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3672: Local variable 'price' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3674: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3680: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/InGameController.java:3680: Local variable 'savedGold' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3683: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3683: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3684: Local variable 'container' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3685: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3686: Local variable 'ag' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3687: Local variable 'type' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3687: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3688: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3689: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3691: Avoid assignments in operands +src/net/sf/freecol/server/control/InGameController.java:3692: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3698: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3705: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3711: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameController.java:3722: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3723: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3723: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3723: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3725: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3726: Local variable 'victim' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3727: Local variable 'difficulty' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3727: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3728: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3728: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3730: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3732: Local variable 'result' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3732: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:3732: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:3733: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3735: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3735: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:3739: Local variable 'message' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3745: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3750: Local variable 'colonyContainer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3751: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3752: Local variable 'unitContainer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3753: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3758: Local variable 'tension' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3759: Avoid variables with short names like is +src/net/sf/freecol/server/control/InGameController.java:3759: Local variable 'is' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3764: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3768: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3780: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3780: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3782: Local variable 'europe' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3784: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3786: Local variable 'price' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3786: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3788: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3790: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:3796: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3797: Local variable 'role' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3797: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3797: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3797: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:3797: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:3799: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3800: Local variable 'unit' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3804: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3807: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3807: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3822: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3822: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3823: Parameter 'queue' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3824: Local variable 'current' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3826: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3826: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3829: Local variable 'ag' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3830: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3838: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3838: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3852: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3852: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3853: Parameter 'exportData' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3867: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3867: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3868: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3869: Local variable 'colony' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3870: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:3870: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3875: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3875: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3877: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3877: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3890: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3890: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3891: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3911: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3912: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3913: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3914: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3938: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3938: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3938: The method 'changeState' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/server/control/InGameController.java:3938: The method changeState() has an NPath complexity of 404 +src/net/sf/freecol/server/control/InGameController.java:3939: Parameter 'state' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3940: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3940: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3942: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3943: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3945: Local variable 'colony' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3945: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3945: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3945: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:3945: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:3946: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3947: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:3948: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:3948: Local variable 'owner' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3948: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3953: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3954: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3957: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3965: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3967: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3971: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:3972: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3984: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3984: Parameter 'student' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3985: Parameter 'teacher' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:3986: Local variable 'oldStudent' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3987: Local variable 'oldTeacher' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3990: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:3990: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:3992: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:3996: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4015: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4015: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4016: Parameter 'tradeRoute' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4021: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:4021: Useless parentheses. +src/net/sf/freecol/server/control/InGameController.java:4022: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4023: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/control/InGameController.java:4026: Local variable 'stops' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4028: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4029: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4030: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4030: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4035: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:4052: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4053: Parameter 'routes' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4067: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4068: Local variable 'routes' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4069: Local variable 'route' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4071: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4083: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4083: The method 'getREFUnits' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/control/InGameController.java:4083: The method 'getREFUnits' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/control/InGameController.java:4083: The method 'getREFUnits' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/control/InGameController.java:4090: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4090: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4092: Local variable 'REFPlayer' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4092: Variables should start with a lowercase character, 'REFPlayer' starts with uppercase character. +src/net/sf/freecol/server/control/InGameController.java:4093: Local variable 'unitHash' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4095: Local variable 'unit' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4098: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4103: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:4103: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:4104: Local variable 'roleId' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4105: Local variable 'count' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4111: Local variable 'typeEntry' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4111: Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map.Entry' +src/net/sf/freecol/server/control/InGameController.java:4112: Local variable 'roleEntry' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4112: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4112: Unnecessary use of fully qualified name 'java.util.Map.Entry' due to existing import 'java.util.Map.Entry' +src/net/sf/freecol/server/control/InGameController.java:4113: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/control/InGameController.java:4118: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:4118: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4121: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4123: Local variable 'unit' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4136: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4137: Local variable 'scores' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4138: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:4138: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4141: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4143: Local variable 'score' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4159: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4159: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4160: Parameter 'pri' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4173: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4175: Local variable 'stats' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4175: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4180: Local variable 'all' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4181: Local variable 'e' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4187: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:4187: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4190: This call to Collection.toArray() may be optimizable +src/net/sf/freecol/server/control/InGameController.java:4200: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4202: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:4205: Local variable 'game' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4206: Local variable 'undeads' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4206: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4208: Local variable 'navalUnits' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4209: Local variable 'landUnits' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4210: Local variable 'undead' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4218: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:4222: Avoid variables with short names like cs +src/net/sf/freecol/server/control/InGameController.java:4222: Local variable 'cs' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4223: Local variable 'navalType' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4225: Local variable 'start' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4225: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4227: Local variable 'theFlyingDutchman' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4230: Local variable 'landType' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4238: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4246: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4268: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4268: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4268: The method 'rearrangeColony' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/server/control/InGameController.java:4268: The method 'rearrangeColony' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/server/control/InGameController.java:4268: The method 'rearrangeColony' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/server/control/InGameController.java:4268: The method rearrangeColony() has an NPath complexity of 495 +src/net/sf/freecol/server/control/InGameController.java:4269: Parameter 'unitChanges' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameController.java:4270: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4270: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameController.java:4271: Local variable 'tile' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4272: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4275: Local variable 'uc' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4276: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:4277: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:4282: Local variable 'todo' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4284: Avoid variables with short names like uc +src/net/sf/freecol/server/control/InGameController.java:4284: Local variable 'uc' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4285: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:4286: Avoid variables with short names like wl +src/net/sf/freecol/server/control/InGameController.java:4286: Local variable 'wl' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4290: A switch statement does not contain a break +src/net/sf/freecol/server/control/InGameController.java:4290: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameController.java:4292: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:4295: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:4296: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:4303: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameController.java:4308: Local variable 'uci' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4310: Avoid variables with short names like uc +src/net/sf/freecol/server/control/InGameController.java:4310: Local variable 'uc' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4311: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameController.java:4311: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameController.java:4317: Local variable 'uc' could be declared final +src/net/sf/freecol/server/control/InGameController.java:4319: These nested if statements could be combined +src/net/sf/freecol/server/control/InGameController.java:4321: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameController.java:4322: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/control/InGameInputHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameInputHandler.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/control/InGameInputHandler.java:20: Possible God class (WMC=64, ATFD=77, TCC=0.0) +src/net/sf/freecol/server/control/InGameInputHandler.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/server/control/InGameInputHandler.java:104: The class 'InGameInputHandler' has a Cyclomatic Complexity of 33 (Highest = 60). +src/net/sf/freecol/server/control/InGameInputHandler.java:104: The class 'InGameInputHandler' has a Modified Cyclomatic Complexity of 32 (Highest = 60). +src/net/sf/freecol/server/control/InGameInputHandler.java:104: The class 'InGameInputHandler' has a Standard Cyclomatic Complexity of 32 (Highest = 60). +src/net/sf/freecol/server/control/InGameInputHandler.java:105: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/control/InGameInputHandler.java:107: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/control/InGameInputHandler.java:107: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:115: The constructor 'InGameInputHandler' has a Cyclomatic Complexity of 60. +src/net/sf/freecol/server/control/InGameInputHandler.java:115: The constructor 'InGameInputHandler' has a Modified Cyclomatic Complexity of 60. +src/net/sf/freecol/server/control/InGameInputHandler.java:115: The constructor 'InGameInputHandler' has a Standard Cyclomatic Complexity of 60. +src/net/sf/freecol/server/control/InGameInputHandler.java:125: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:125: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:125: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:126: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:133: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:133: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:133: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:134: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:141: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:141: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:141: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:142: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:149: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:149: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:149: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:150: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:157: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:157: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:157: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:158: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:165: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:165: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:165: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:166: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:173: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:173: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:173: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:174: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:181: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:181: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:181: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:182: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:189: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:189: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:189: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:190: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:197: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:197: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:197: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:198: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:205: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:205: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:205: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:206: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:213: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:213: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:213: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:214: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:221: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:221: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:221: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:222: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:229: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:229: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:229: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:230: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:237: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:237: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:237: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:238: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:245: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:245: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:245: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:246: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:253: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:253: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:253: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:254: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:261: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:261: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:261: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:262: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:269: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:269: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:269: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:270: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:277: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:277: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:277: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:278: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:285: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:285: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:285: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:286: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:293: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:293: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:293: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:294: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:301: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:301: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:301: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:302: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:309: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:309: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:309: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:310: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:311: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:317: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:317: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:317: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:318: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:325: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:325: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:325: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:326: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:327: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:333: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:333: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:333: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:334: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:341: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:341: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:341: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:342: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:349: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:349: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:349: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:350: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:357: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:357: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:357: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:358: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:365: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:365: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:365: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:366: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:373: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:373: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:373: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:374: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:381: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:381: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:381: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:382: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:389: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:389: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:389: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:390: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:397: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:397: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:397: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:398: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:405: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:405: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:405: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:406: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:413: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:413: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:413: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:414: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:421: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:421: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:421: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:422: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:429: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:429: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:429: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:430: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:437: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:437: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:437: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:438: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:445: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:445: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:445: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:446: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:453: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:453: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:453: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:454: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:461: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:461: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:461: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:462: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:469: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:469: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:469: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:470: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:477: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:477: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:477: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:478: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:485: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:485: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:485: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:486: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:493: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:493: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:493: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:494: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:501: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:501: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:501: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:502: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:509: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:509: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:509: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:510: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:517: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:517: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:517: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:518: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:525: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:525: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:525: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:526: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:533: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:533: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:533: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:534: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:541: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:541: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:541: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:542: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:549: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:549: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:549: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:550: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:558: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:558: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:558: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InGameInputHandler.java:559: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:561: Local variable 'results' could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameInputHandler.java:564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameInputHandler.java:565: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameInputHandler.java:567: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:567: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:569: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InGameInputHandler.java:570: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameInputHandler.java:572: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameInputHandler.java:573: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/control/InGameInputHandler.java:574: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameInputHandler.java:644: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InGameInputHandler.java:654: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:654: Parameter 'logoutElement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:655: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/InGameInputHandler.java:655: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:656: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameInputHandler.java:656: There is log block not surrounded by if +src/net/sf/freecol/server/control/InGameInputHandler.java:657: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InGameInputHandler.java:657: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameInputHandler.java:659: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InGameInputHandler.java:677: Found 'DD'-anomaly for variable 'reply' (lines '677'-'681'). +src/net/sf/freecol/server/control/InGameInputHandler.java:678: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InGameInputHandler.java:679: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:679: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:680: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:681: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InGameInputHandler.java:683: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InputHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InputHandler.java:46: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/control/InputHandler.java:48: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/control/InputHandler.java:48: fieldCommentRequirement Required +src/net/sf/freecol/server/control/InputHandler.java:54: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/InputHandler.java:54: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/control/InputHandler.java:80: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:80: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:91: Parameter 'handler' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:91: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:105: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:105: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:106: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InputHandler.java:106: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/InputHandler.java:107: Local variable 'tagName' could be declared final +src/net/sf/freecol/server/control/InputHandler.java:108: Local variable 'handler' could be declared final +src/net/sf/freecol/server/control/InputHandler.java:109: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InputHandler.java:111: There is log block not surrounded by if +src/net/sf/freecol/server/control/InputHandler.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/InputHandler.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InputHandler.java:113: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/server/control/InputHandler.java:120: There is log block not surrounded by if +src/net/sf/freecol/server/control/InputHandler.java:130: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:146: Parameter 'message' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:151: Comment is too large: Too many lines +src/net/sf/freecol/server/control/InputHandler.java:163: Each class should declare at least one constructor +src/net/sf/freecol/server/control/InputHandler.java:163: headerCommentRequirement Required +src/net/sf/freecol/server/control/InputHandler.java:166: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:166: Parameter 'disconnectElement' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:166: publicMethodCommentRequirement Required +src/net/sf/freecol/server/control/InputHandler.java:168: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/InputHandler.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InputHandler.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InputHandler.java:174: Local variable 'server' could be declared final +src/net/sf/freecol/server/control/InputHandler.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/InputHandler.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/InputHandler.java:181: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:181: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/control/InputHandler.java:182: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/InputHandler.java:182: There is log block not surrounded by if +src/net/sf/freecol/server/control/InputHandler.java:182: There is log block not surrounded by if +src/net/sf/freecol/server/control/PreGameController.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/PreGameController.java:37: Comment is too large: Too many lines +src/net/sf/freecol/server/control/PreGameController.java:50: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/control/PreGameController.java:50: fieldCommentRequirement Required +src/net/sf/freecol/server/control/PreGameController.java:57: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameController.java:61: Comment is too large: Too many lines +src/net/sf/freecol/server/control/PreGameController.java:70: Comment is too large: Line too long +src/net/sf/freecol/server/control/PreGameController.java:76: Found 'UR'-anomaly for variable 'player' (lines '76'-'82'). +src/net/sf/freecol/server/control/PreGameController.java:78: Local variable 'game' could be declared final +src/net/sf/freecol/server/control/PreGameController.java:78: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:81: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameController.java:81: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:82: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/PreGameController.java:85: Local variable 'conn' could be declared final +src/net/sf/freecol/server/control/PreGameController.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameController.java:86: Local variable 'update' could be declared final +src/net/sf/freecol/server/control/PreGameController.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:99: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameController.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:101: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameController.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameController.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/PreGameInputHandler.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/control/PreGameInputHandler.java:49: fieldCommentRequirement Required +src/net/sf/freecol/server/control/PreGameInputHandler.java:52: Avoid using redundant field initializer for 'launching' +src/net/sf/freecol/server/control/PreGameInputHandler.java:52: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/control/PreGameInputHandler.java:60: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:68: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:102: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:102: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:103: There is log block not surrounded by if +src/net/sf/freecol/server/control/PreGameInputHandler.java:103: There is log block not surrounded by if +src/net/sf/freecol/server/control/PreGameInputHandler.java:104: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:110: The String literal "player" appears 4 times in this file; the first occurrence is on line 110 +src/net/sf/freecol/server/control/PreGameInputHandler.java:112: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:123: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:123: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:124: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:124: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:125: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/PreGameInputHandler.java:126: Local variable 'ready' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:126: The String literal "value" appears 6 times in this file; the first occurrence is on line 126 +src/net/sf/freecol/server/control/PreGameInputHandler.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:128: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:146: Found 'UR'-anomaly for variable 'player' (lines '146'-'163'). +src/net/sf/freecol/server/control/PreGameInputHandler.java:146: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:147: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:148: Local variable 'freeColServer' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:151: Local variable 'launchingPlayer' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:153: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:157: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:157: Avoid using if statements without curly braces +src/net/sf/freecol/server/control/PreGameInputHandler.java:161: Found 'DU'-anomaly for variable 'nations' (lines '161'-'185'). +src/net/sf/freecol/server/control/PreGameInputHandler.java:161: Local variable 'nations' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:162: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:163: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:166: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:174: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:180: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:194: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:194: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:195: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:196: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/PreGameInputHandler.java:197: Local variable 'nation' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:197: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:199: Local variable 'state' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:202: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:217: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:217: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:218: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:218: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:219: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/PreGameInputHandler.java:220: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/PreGameInputHandler.java:220: Found 'DU'-anomaly for variable 'nation' (lines '220'-'241'). +src/net/sf/freecol/server/control/PreGameInputHandler.java:220: Local variable 'nation' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:222: Local variable 'str' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:225: Local variable 'rgb' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:226: Found 'DU'-anomaly for variable 'color' (lines '226'-'241'). +src/net/sf/freecol/server/control/PreGameInputHandler.java:228: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:232: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:250: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:250: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:251: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:251: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:252: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/PreGameInputHandler.java:253: Local variable 'nation' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:253: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:264: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:280: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:280: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:281: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:282: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/PreGameInputHandler.java:283: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:284: Local variable 'nationType' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:285: Found 'DU'-anomaly for variable 'fixedNationType' (lines '285'-'319'). +src/net/sf/freecol/server/control/PreGameInputHandler.java:285: Local variable 'fixedNationType' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:285: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:285: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:287: Local variable 'advantages' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:287: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:289: Avoid variables with short names like ok +src/net/sf/freecol/server/control/PreGameInputHandler.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:306: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:306: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:312: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/PreGameInputHandler.java:328: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:328: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:329: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:329: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:333: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:334: Local variable 'gameOptions' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:335: Local variable 'child' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:335: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:339: Avoid variables with short names like up +src/net/sf/freecol/server/control/PreGameInputHandler.java:339: Local variable 'up' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:352: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:353: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:354: Local variable 'player' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:354: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:358: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:359: Local variable 'mgo' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:359: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:360: Local variable 'child' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:360: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:361: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:362: Local variable 'umge' could be declared final +src/net/sf/freecol/server/control/PreGameInputHandler.java:363: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:363: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:363: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/PreGameInputHandler.java:364: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/PreGameInputHandler.java:364: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/UserConnectionHandler.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/control/UserConnectionHandler.java:22: Avoid unused imports such as 'java.util.logging.Level' +src/net/sf/freecol/server/control/UserConnectionHandler.java:46: The class 'UserConnectionHandler' has a Cyclomatic Complexity of 5 (Highest = 18). +src/net/sf/freecol/server/control/UserConnectionHandler.java:46: The class 'UserConnectionHandler' has a Modified Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/server/control/UserConnectionHandler.java:46: The class 'UserConnectionHandler' has a Standard Cyclomatic Complexity of 4 (Highest = 15). +src/net/sf/freecol/server/control/UserConnectionHandler.java:49: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/control/UserConnectionHandler.java:49: fieldCommentRequirement Required +src/net/sf/freecol/server/control/UserConnectionHandler.java:57: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:72: Parameter 'conn' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:72: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:72: Use block level rather than method level synchronization +src/net/sf/freecol/server/control/UserConnectionHandler.java:74: Useless parentheses. +src/net/sf/freecol/server/control/UserConnectionHandler.java:74: Useless parentheses. +src/net/sf/freecol/server/control/UserConnectionHandler.java:87: Comment is too large: Too many lines +src/net/sf/freecol/server/control/UserConnectionHandler.java:96: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:97: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:97: The String literal "unused" appears 5 times in this file; the first occurrence is on line 97 +src/net/sf/freecol/server/control/UserConnectionHandler.java:110: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:111: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:114: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:115: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/UserConnectionHandler.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/UserConnectionHandler.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:120: Comment is too large: Too many lines +src/net/sf/freecol/server/control/UserConnectionHandler.java:129: Found 'UR'-anomaly for variable 'p' (lines '129'-'138'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:130: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:131: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:132: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/control/UserConnectionHandler.java:132: Avoid unused local variables such as 'freeColServer'. +src/net/sf/freecol/server/control/UserConnectionHandler.java:132: Found 'DU'-anomaly for variable 'freeColServer' (lines '132'-'146'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:135: Local variable 'reply' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:136: Found 'DU'-anomaly for variable 'doc' (lines '136'-'146'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:136: Local variable 'doc' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:137: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/UserConnectionHandler.java:139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/UserConnectionHandler.java:140: Local variable 'playerElement' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:148: Comment is too large: Too many lines +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: Avoid really long methods. +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: Found 'UR'-anomaly for variable 'p' (lines '161'-'228'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: The method 'login' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: The method 'login' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: The method 'login' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/server/control/UserConnectionHandler.java:161: The method login() has an NPath complexity of 210 +src/net/sf/freecol/server/control/UserConnectionHandler.java:163: Found 'DU'-anomaly for variable 'version' (lines '163'-'266'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:166: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:168: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:170: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:175: Found 'DU'-anomaly for variable 'server' (lines '175'-'266'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:178: Found 'DD'-anomaly for variable 'active' (lines '178'-'252'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:178: Found 'DU'-anomaly for variable 'active' (lines '178'-'266'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:179: Found 'DD'-anomaly for variable 'isCurrentPlayer' (lines '179'-'249'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:179: Found 'DU'-anomaly for variable 'isCurrentPlayer' (lines '179'-'266'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:180: Avoid variables with short names like mh +src/net/sf/freecol/server/control/UserConnectionHandler.java:181: Local variable 'starting' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:186: Found 'DU'-anomaly for variable 'timeOut' (lines '186'-'266'). +src/net/sf/freecol/server/control/UserConnectionHandler.java:187: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:191: Avoid assignments in operands +src/net/sf/freecol/server/control/UserConnectionHandler.java:192: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:197: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/control/UserConnectionHandler.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:198: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:200: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:205: Local variable 'admin' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:205: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/control/UserConnectionHandler.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:213: Local variable 'add' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:224: Avoid variables with short names like sb +src/net/sf/freecol/server/control/UserConnectionHandler.java:224: Local variable 'sb' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:225: StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. +src/net/sf/freecol/server/control/UserConnectionHandler.java:227: Local variable 'p' could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:228: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/control/UserConnectionHandler.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:230: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/control/UserConnectionHandler.java:230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:231: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:234: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/control/UserConnectionHandler.java:237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:260: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:263: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/control/UserConnectionHandler.java:274: Parameter 'tag' is not assigned and could be declared final +src/net/sf/freecol/server/control/UserConnectionHandler.java:275: There is log block not surrounded by if +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:35: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:66: The class 'ColonizationMapLoader' has a Cyclomatic Complexity of 7 (Highest = 19). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:66: The class 'ColonizationMapLoader' has a Modified Cyclomatic Complexity of 5 (Highest = 13). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:66: The class 'ColonizationMapLoader' has a Standard Cyclomatic Complexity of 5 (Highest = 13). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:68: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:69: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:70: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:71: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:73: Variables that are final and static should be all capitals, 'tiletypes' is not all capitals. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:73: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:104: Variables that are final and static should be all capitals, 'header' is not all capitals. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:104: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:107: Possible unsafe assignment to a non-final static field in a constructor. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:107: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:109: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:109: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:109: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:111: Local variable 'reader' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:114: Local variable 'size' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:121: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:121: Parameter 'layer' is not assigned and could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:121: The method 'loadMap' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:121: The method 'loadMap' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:121: The method 'loadMap' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:121: The method loadMap() has an NPath complexity of 345 +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:121: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:122: Found 'DU'-anomaly for variable 'spec' (lines '122'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:122: Local variable 'spec' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:123: Found 'DD'-anomaly for variable 'tiles' (lines '123'-'154'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:123: Found 'DU'-anomaly for variable 'tiles' (lines '123'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:124: Local variable 'highestLayer' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:126: Found 'DU'-anomaly for variable 'index' (lines '126'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:127: Found 'DD'-anomaly for variable 'tileType' (lines '127'-'134'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:127: Found 'DD'-anomaly for variable 'tileType' (lines '127'-'148'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:127: Found 'DU'-anomaly for variable 'tileType' (lines '127'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:132: Local variable 'decimal' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:133: Local variable 'terrain' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:134: Found 'DD'-anomaly for variable 'tileType' (lines '134'-'134'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:134: Found 'DU'-anomaly for variable 'tileType' (lines '134'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:134: Useless parentheses. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:134: Useless parentheses. +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:136: Found 'DU'-anomaly for variable 'index' (lines '136'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:140: Found 'DU'-anomaly for variable 'riverType' (lines '140'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:140: Local variable 'riverType' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:143: Local variable 'decimal' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:144: Local variable 'terrain' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:145: Local variable 'overlay' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:154: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:154: Found 'DD'-anomaly for variable 'tiles' (lines '154'-'154'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:154: Found 'DU'-anomaly for variable 'tiles' (lines '154'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:157: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:157: Local variable 'container' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:158: Local variable 'river' could be declared final +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:159: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:162: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:164: Found 'DU'-anomaly for variable 'index' (lines '164'-'169'). +src/net/sf/freecol/server/generator/ColonizationMapLoader.java:172: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/FreeColMapLoader.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/FreeColMapLoader.java:46: The class 'FreeColMapLoader' has a Cyclomatic Complexity of 7 (Highest = 17). +src/net/sf/freecol/server/generator/FreeColMapLoader.java:46: The class 'FreeColMapLoader' has a Modified Cyclomatic Complexity of 7 (Highest = 17). +src/net/sf/freecol/server/generator/FreeColMapLoader.java:46: The class 'FreeColMapLoader' has a Standard Cyclomatic Complexity of 7 (Highest = 17). +src/net/sf/freecol/server/generator/FreeColMapLoader.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/FreeColMapLoader.java:48: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/FreeColMapLoader.java:50: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/server/generator/FreeColMapLoader.java:50: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:50: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: Found 'UR'-anomaly for variable 'region' (lines '56'-'127'). +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: Parameter 'layer' is not assigned and could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: The method 'loadMap' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: The method 'loadMap' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: The method 'loadMap' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: The method loadMap() has an NPath complexity of 310 +src/net/sf/freecol/server/generator/FreeColMapLoader.java:56: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/FreeColMapLoader.java:57: Local variable 'importMap' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:58: Local variable 'highestLayer' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:60: Local variable 'width' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:61: Local variable 'height' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:63: Local variable 'regions' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:65: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/generator/FreeColMapLoader.java:65: Local variable 'map' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:70: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/FreeColMapLoader.java:70: Avoid variables with short names like t +src/net/sf/freecol/server/generator/FreeColMapLoader.java:70: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:71: Useless parentheses. +src/net/sf/freecol/server/generator/FreeColMapLoader.java:71: Useless parentheses. +src/net/sf/freecol/server/generator/FreeColMapLoader.java:80: Local variable 'template' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:81: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/FreeColMapLoader.java:81: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:89: Local variable 'region' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:92: Deeply nested if..then statements are hard to read +src/net/sf/freecol/server/generator/FreeColMapLoader.java:93: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/FreeColMapLoader.java:101: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/FreeColMapLoader.java:103: Deeply nested if..then statements are hard to read +src/net/sf/freecol/server/generator/FreeColMapLoader.java:105: These nested if statements could be combined +src/net/sf/freecol/server/generator/FreeColMapLoader.java:106: Local variable 'nationId' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:106: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:109: Local variable 'nation' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:109: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/FreeColMapLoader.java:110: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/FreeColMapLoader.java:115: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:116: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/FreeColMapLoader.java:126: Local variable 'region' could be declared final +src/net/sf/freecol/server/generator/FreeColMapLoader.java:136: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/MapGenerator.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/MapGenerator.java:38: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/generator/MapGenerator.java:38: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/MapGenerator.java:45: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/generator/MapGenerator.java:45: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/MapLayerGenerator.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/MapLayerGenerator.java:37: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/generator/MapLayerGenerator.java:44: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/generator/MapLoader.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/MapLoader.java:28: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/MapLoader.java:38: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/generator/MapLoader.java:46: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/generator/River.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/River.java:20: Possible God class (WMC=61, ATFD=62, TCC=0.10833333333333334) +src/net/sf/freecol/server/generator/River.java:41: The class 'River' has a Cyclomatic Complexity of 3 (Highest = 16). +src/net/sf/freecol/server/generator/River.java:41: The class 'River' has a Modified Cyclomatic Complexity of 3 (Highest = 14). +src/net/sf/freecol/server/generator/River.java:41: The class 'River' has a Standard Cyclomatic Complexity of 3 (Highest = 14). +src/net/sf/freecol/server/generator/River.java:43: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/generator/River.java:43: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/River.java:45: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:45: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/River.java:51: The class 'DirectionChange' has a Cyclomatic Complexity of 13(Highest = 12). +src/net/sf/freecol/server/generator/River.java:51: The class 'DirectionChange' has a Standard Cyclomatic Complexity of 13(Highest = 12). +src/net/sf/freecol/server/generator/River.java:56: Parameter 'oldDirection' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:56: The method 'getNewDirection' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/server/generator/River.java:56: The method 'getNewDirection' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/server/generator/River.java:56: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/River.java:57: Switch statements should have a default label +src/net/sf/freecol/server/generator/River.java:59: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:63: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:65: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:67: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:69: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:71: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:76: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:78: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:80: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:82: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:84: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:94: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:99: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:104: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:109: Avoid using redundant field initializer for 'nextRiver' +src/net/sf/freecol/server/generator/River.java:109: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:119: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:124: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:129: Avoid using redundant field initializer for 'connected' +src/net/sf/freecol/server/generator/River.java:129: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/River.java:140: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:140: Parameter 'riverMap' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:141: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:141: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:150: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:153: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/River.java:166: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/River.java:194: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:194: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:204: Found 'UR'-anomaly for variable 'section' (lines '204'-'210'). +src/net/sf/freecol/server/generator/River.java:204: Found 'UR'-anomaly for variable 'section' (lines '204'-'211'). +src/net/sf/freecol/server/generator/River.java:204: Parameter 'lastSection' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:204: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:206: Found 'DU'-anomaly for variable 'found' (lines '206'-'224'). +src/net/sf/freecol/server/generator/River.java:208: Local variable 'section' could be declared final +src/net/sf/freecol/server/generator/River.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:211: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:212: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/River.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:215: Found 'DU'-anomaly for variable 'found' (lines '215'-'224'). +src/net/sf/freecol/server/generator/River.java:220: Local variable 'section' could be declared final +src/net/sf/freecol/server/generator/River.java:221: Local variable 'neighbor' could be declared final +src/net/sf/freecol/server/generator/River.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:232: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:234: Avoid variables with short names like d +src/net/sf/freecol/server/generator/River.java:234: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:243: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:244: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:245: Avoid variables with short names like d +src/net/sf/freecol/server/generator/River.java:246: Avoid variables with short names like t +src/net/sf/freecol/server/generator/River.java:246: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/River.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:257: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:258: Avoid variables with short names like rs +src/net/sf/freecol/server/generator/River.java:267: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:268: Local variable 'riverType' could be declared final +src/net/sf/freecol/server/generator/River.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:270: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/generator/River.java:270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:272: The String literal "Tile (" appears 9 times in this file; the first occurrence is on line 272 +src/net/sf/freecol/server/generator/River.java:272: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:273: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:275: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:276: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:278: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:289: Found 'UR'-anomaly for variable 'change' (lines '289'-'301'). +src/net/sf/freecol/server/generator/River.java:289: Found 'UR'-anomaly for variable 'change2' (lines '289'-'319'). +src/net/sf/freecol/server/generator/River.java:289: Parameter 'source' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:289: The method 'flow' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/server/generator/River.java:289: The method 'flow' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/server/generator/River.java:289: The method 'flow' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/server/generator/River.java:293: Local variable 'length' could be declared final +src/net/sf/freecol/server/generator/River.java:293: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:294: Local variable 'index' could be declared final +src/net/sf/freecol/server/generator/River.java:295: Local variable 'change' could be declared final +src/net/sf/freecol/server/generator/River.java:295: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:296: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:297: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:300: Local variable 'change' could be declared final +src/net/sf/freecol/server/generator/River.java:301: Local variable 'dir' could be declared final +src/net/sf/freecol/server/generator/River.java:302: Local variable 'nextTile' could be declared final +src/net/sf/freecol/server/generator/River.java:303: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/River.java:306: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/generator/River.java:308: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:311: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:314: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:318: Local variable 'change2' could be declared final +src/net/sf/freecol/server/generator/River.java:319: Local variable 'lastDir' could be declared final +src/net/sf/freecol/server/generator/River.java:320: Avoid variables with short names like t +src/net/sf/freecol/server/generator/River.java:320: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/River.java:321: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/River.java:322: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/River.java:324: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/River.java:325: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/River.java:325: Local variable 'lastSection' could be declared final +src/net/sf/freecol/server/generator/River.java:330: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:337: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/generator/River.java:343: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:344: Local variable 'someRiver' could be declared final +src/net/sf/freecol/server/generator/River.java:346: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/River.java:351: Local variable 'waterSection' could be declared final +src/net/sf/freecol/server/generator/River.java:358: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:358: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/generator/River.java:361: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:362: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/River.java:363: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/River.java:370: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:370: Parameter 'section' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:370: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:371: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/River.java:372: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/River.java:375: Avoid variables with short names like d +src/net/sf/freecol/server/generator/River.java:375: Parameter 'd' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:375: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:375: Parameter 'section' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:375: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:376: Avoid variables with short names like t +src/net/sf/freecol/server/generator/River.java:376: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/River.java:377: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/generator/River.java:378: Local variable 'deltaSections' could be declared final +src/net/sf/freecol/server/generator/River.java:383: Avoid variables with short names like t2 +src/net/sf/freecol/server/generator/River.java:383: Local variable 't2' could be declared final +src/net/sf/freecol/server/generator/River.java:385: Local variable 'deltaSections' could be declared final +src/net/sf/freecol/server/generator/River.java:387: Avoid variables with short names like rs +src/net/sf/freecol/server/generator/River.java:401: Found 'UR'-anomaly for variable 'section' (lines '401'-'405'). +src/net/sf/freecol/server/generator/River.java:401: Parameter 'sections' is not assigned and could be declared final +src/net/sf/freecol/server/generator/River.java:402: Found 'DU'-anomaly for variable 'oldSection' (lines '402'-'430'). +src/net/sf/freecol/server/generator/River.java:404: Local variable 'section' could be declared final +src/net/sf/freecol/server/generator/River.java:405: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:407: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:407: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/River.java:408: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:410: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/River.java:410: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:413: Local variable 'greatRiver' could be declared final +src/net/sf/freecol/server/generator/River.java:413: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/River.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:417: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:417: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:419: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:420: Local variable 'style' could be declared final +src/net/sf/freecol/server/generator/River.java:420: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:421: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:421: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:422: There is log block not surrounded by if +src/net/sf/freecol/server/generator/River.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/River.java:427: Found 'DU'-anomaly for variable 'oldSection' (lines '427'-'430'). +src/net/sf/freecol/server/generator/RiverSection.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/RiverSection.java:31: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/RiverSection.java:42: Comment is too large: Line too long +src/net/sf/freecol/server/generator/RiverSection.java:44: Avoid unused private fields such as 'template'. +src/net/sf/freecol/server/generator/RiverSection.java:44: Variables that are final and static should be all capitals, 'template' is not all capitals. +src/net/sf/freecol/server/generator/RiverSection.java:44: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/RiverSection.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/RiverSection.java:57: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/RiverSection.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/RiverSection.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/RiverSection.java:76: Parameter 'branches' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:86: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:86: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:112: Avoid reassigning parameters such as 'size' +src/net/sf/freecol/server/generator/RiverSection.java:112: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:122: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:124: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/RiverSection.java:133: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:140: Parameter 'direction' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:140: Parameter 'increment' is not assigned and could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:141: Local variable 'newSize' could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:156: Found 'UR'-anomaly for variable 'direction' (lines '156'-'159'). +src/net/sf/freecol/server/generator/RiverSection.java:156: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/RiverSection.java:157: Avoid variables with short names like sb +src/net/sf/freecol/server/generator/RiverSection.java:157: Local variable 'sb' could be declared final +src/net/sf/freecol/server/generator/RiverSection.java:158: Local variable 'direction' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:20: Possible God class (WMC=183, ATFD=240, TCC=0.2578947368421053) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:88: Avoid really long classes. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:88: The class 'SimpleMapGenerator' has a Cyclomatic Complexity of 10 (Highest = 55). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:88: The class 'SimpleMapGenerator' has a Modified Cyclomatic Complexity of 9 (Highest = 46). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:88: The class 'SimpleMapGenerator' has a Standard Cyclomatic Complexity of 9 (Highest = 50). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:88: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:90: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:90: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:97: Avoid excessively long variable names like MIN_DISTANCE_FROM_POLE +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:100: headerCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:101: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:101: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:102: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:102: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:103: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:103: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:104: Avoid excessively long variable names like numberOfSettlements +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:104: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:104: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:106: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:106: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:106: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:111: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:111: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:111: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:116: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:116: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:117: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:117: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:118: Avoid variables with short names like xy +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:118: Local variable 'xy' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:132: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:132: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:135: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:135: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:138: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:138: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:141: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:141: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:144: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:144: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:154: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:154: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:165: Parameter 'checkImport' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:168: Local variable 'importFile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:168: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:168: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:168: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:170: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:171: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: Found 'UR'-anomaly for variable 'importTile' (lines '194'-'200'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: The method 'makeLostCityRumours' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: The method 'makeLostCityRumours' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: The method 'makeLostCityRumours' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:194: The method makeLostCityRumours() has an NPath complexity of 384 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:198: Found 'DD'-anomaly for variable 'nLCRs' (lines '198'-'209'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:199: Local variable 'importTile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:199: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:200: Local variable 'rumour' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:200: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:202: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:203: Avoid variables with short names like x +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:203: Local variable 'x' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:204: Avoid variables with short names like y +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:204: Local variable 'y' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:206: Avoid variables with short names like t +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:209: Found 'DD'-anomaly for variable 'nLCRs' (lines '209'-'209'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:221: Found 'DD'-anomaly for variable 'number' (lines '221'-'226'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:222: Found 'DD'-anomaly for variable 'counter' (lines '222'-'242'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:231: Avoid variables with short names like t +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:231: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:232: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:235: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:235: Avoid variables with short names like r +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:235: Local variable 'r' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:248: The String literal ".\n" appears 6 times in this file; the first occurrence is on line 248 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: Found 'UR'-anomaly for variable 'g' (lines '251'-'305'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: Found 'UR'-anomaly for variable 'player' (lines '251'-'255'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: Found 'UR'-anomaly for variable 't' (lines '251'-'282'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: Found 'UR'-anomaly for variable 'tile' (lines '251'-'273'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: The method 'importIndianSettlements' has a Cyclomatic Complexity of 19. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: The method 'importIndianSettlements' has a Modified Cyclomatic Complexity of 19. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: The method 'importIndianSettlements' has a Standard Cyclomatic Complexity of 19. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:251: The method importIndianSettlements() has an NPath complexity of 4680 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:252: Found 'DD'-anomaly for variable 'nSettlements' (lines '252'-'313'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:254: Local variable 'player' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:257: Local variable 'nation' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:263: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:272: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:272: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:273: Avoid variables with short names like is +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:273: Local variable 'is' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:274: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:275: Local variable 'indian' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:275: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:276: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:277: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:279: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:281: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:281: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:282: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:286: Local variable 'units' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:286: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:287: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:290: Local variable 'unit' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:291: Avoid variables with short names like t +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:291: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:291: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:293: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:293: Avoid variables with short names like u +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:293: Local variable 'u' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:300: Local variable 'goods' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:304: Local variable 'g' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:305: Avoid variables with short names like t +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:305: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:305: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:305: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:311: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:313: Found 'DD'-anomaly for variable 'nSettlements' (lines '313'-'313'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:317: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:318: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:319: Local variable 'owner' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:319: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:319: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:321: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:322: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:323: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:326: Local variable 'name' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:326: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:326: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:327: Avoid variables with short names like is +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:327: Local variable 'is' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Avoid really long methods. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Found 'UR'-anomaly for variable 'c' (lines '343'-'573'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Found 'UR'-anomaly for variable 'goodsType' (lines '343'-'552'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Found 'UR'-anomaly for variable 'iss' (lines '343'-'601'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Found 'UR'-anomaly for variable 'player' (lines '343'-'358'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Found 'UR'-anomaly for variable 't' (lines '343'-'425'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Found 'UR'-anomaly for variable 'tile' (lines '343'-'431'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: The method 'makeNativeSettlements' has a Cyclomatic Complexity of 55. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: The method 'makeNativeSettlements' has a Modified Cyclomatic Complexity of 46. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: The method 'makeNativeSettlements' has a Standard Cyclomatic Complexity of 50. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:343: The method makeNativeSettlements() has an NCSS line count of 185 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:347: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:347: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:347: These nested if statements could be combined +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:353: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:353: Found 'DU'-anomaly for variable 'settlements' (lines '353'-'610'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:353: Local variable 'settlements' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:354: Local variable 'indians' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:355: Local variable 'territoryMap' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:357: Local variable 'player' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:358: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:358: Switch statements should have a default label +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:371: Local variable 'regionKeys' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:372: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:373: Found 'DD'-anomaly for variable 'territory' (lines '373'-'375'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:375: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:378: Local variable 'key' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:380: Local variable 'region' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:382: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:384: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:395: Local variable 'key' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:396: Local variable 'otherTerritory' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:397: Local variable 'otherKey' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:397: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:397: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:397: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:400: Local variable 'foundRegion' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:403: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:412: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:418: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:424: Local variable 'allTiles' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:425: Avoid using for statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:425: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:429: Local variable 'settlementTiles' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:430: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:431: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:433: Avoid variables with short names like t +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:439: Avoid excessively long variable names like settlementsToPlace +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:439: Local variable 'settlementsToPlace' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:440: Local variable 'share' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:450: Local variable 'territories' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:452: Found 'DD'-anomaly for variable 'settlementsPlaced' (lines '452'-'472'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:453: Local variable 'territory' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:454: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:454: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:454: Switch statements should have a default label +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:466: Local variable 'radius' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:466: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:466: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:466: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:468: Avoid variables with short names like is +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:468: Local variable 'is' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:469: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:472: Found 'DD'-anomaly for variable 'settlementsPlaced' (lines '472'-'472'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:472: Found 'DD'-anomaly for variable 'settlementsPlaced' (lines '472'-'498'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:482: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:483: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:486: Local variable 'radius' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:486: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:486: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:489: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:489: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:491: Local variable 'name' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:492: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:498: Found 'DD'-anomaly for variable 'settlementsPlaced' (lines '498'-'498'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:510: Local variable 'skills' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:512: Local variable 'is' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:513: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:513: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:514: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:515: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:523: Local variable 'minGrow' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:523: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:524: Local variable 'maxGrow' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:524: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:529: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:530: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:537: Local variable 'skill' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:540: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:550: Local variable 'expertsNeeded' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:551: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:552: Local variable 'expert' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:553: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:556: Local variable 'isList' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:559: Local variable 'neededSkill' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:561: Local variable 'extras' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:562: Found 'DD'-anomaly for variable 'extraSkill' (lines '562'-'562'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:562: Found 'DU'-anomaly for variable 'extraSkill' (lines '562'-'610'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:562: Local variable 'extraSkill' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:562: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:563: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:563: Local variable 'choices' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:567: Local variable 'is' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:568: Local variable 'nation' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:569: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:570: Avoid variables with short names like cm +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:570: Found 'DD'-anomaly for variable 'cm' (lines '570'-'570'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:570: Found 'DU'-anomaly for variable 'cm' (lines '570'-'610'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:570: Local variable 'cm' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:570: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:570: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:571: Avoid variables with short names like rc +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:571: Found 'DD'-anomaly for variable 'rc' (lines '571'-'574'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:572: Local variable 'c' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:574: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:578: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:579: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:581: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:583: Local variable 'chose' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:589: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:592: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:592: Local variable 'neededList' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:600: Local variable 'iss' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:604: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:604: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:605: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:612: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:623: Found 'UR'-anomaly for variable 't' (lines '623'-'627'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:623: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:624: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:624: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:624: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:625: Avoid variables with short names like n +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:625: Found 'DD'-anomaly for variable 'good' (lines '625'-'627'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:625: Found 'DD'-anomaly for variable 'n' (lines '625'-'628'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:625: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:626: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:627: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:627: Found 'DD'-anomaly for variable 'good' (lines '627'-'627'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:627: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:628: Found 'DD'-anomaly for variable 'n' (lines '628'-'628'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:633: Avoid variables with short names like is +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:633: Found 'UR'-anomaly for variable 'd' (lines '633'-'638'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:633: Found 'UR'-anomaly for variable 'tile' (lines '633'-'638'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:633: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:634: Parameter 'tiles' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:635: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:636: Local variable 'd' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:638: Avoid variables with short names like t +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:638: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:639: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:639: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:639: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:640: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:640: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:640: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:641: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:641: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:641: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:641: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:641: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:647: Found 'UR'-anomaly for variable 'territory' (lines '647'-'652'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:647: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:647: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:648: Parameter 'territories' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:649: Found 'DD'-anomaly for variable 'result' (lines '649'-'655'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:650: Found 'DU'-anomaly for variable 'minimumDistance' (lines '650'-'659'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:651: Local variable 'territory' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:652: Local variable 'distance' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:652: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:654: Found 'DU'-anomaly for variable 'minimumDistance' (lines '654'-'659'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:655: Found 'DD'-anomaly for variable 'result' (lines '655'-'655'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:661: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:673: Parameter 'radius' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:673: Parameter 'tiles' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:674: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:674: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:678: Avoid variables with short names like t1 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:678: Avoid variables with short names like t2 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:678: Parameter 't1' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:678: Parameter 't2' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:678: publicMethodCommentRequirement Required +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:682: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:685: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:685: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:687: Local variable 'name' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:688: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:691: Avoid variables with short names like is +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:691: Local variable 'is' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:695: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:701: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:713: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:714: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:714: Parameter 'capital' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:714: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:714: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:714: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:715: Local variable 'name' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:715: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:715: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:717: Local variable 'skill' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:719: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:723: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:724: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:733: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:742: Found 'UR'-anomaly for variable 'entry' (lines '742'-'753'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:742: Found 'UR'-anomaly for variable 'skill' (lines '742'-'748'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:742: Found 'UR'-anomaly for variable 'skill' (lines '742'-'761'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:742: Found 'UR'-anomaly for variable 't' (lines '742'-'754'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:742: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:742: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:743: Parameter 'nationType' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:744: Local variable 'skills' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:745: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:746: Found 'DU'-anomaly for variable 'scale' (lines '746'-'775'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:746: Local variable 'scale' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:747: Local variable 'skill' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:748: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:748: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:748: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:751: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:752: Local variable 'entry' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:753: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:759: Local variable 'scaledSkills' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:760: Local variable 'skill' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:761: Local variable 'unitType' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:761: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:762: Local variable 'scaleValue' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:762: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:763: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:764: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:766: Local variable 'skill' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:770: Local variable 'unitList' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:770: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:771: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:777: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Avoid really long methods. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Found 'UR'-anomaly for variable 'carrier' (lines '787'-'879'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Found 'UR'-anomaly for variable 'player' (lines '787'-'795'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Found 'UR'-anomaly for variable 'startingUnit' (lines '787'-'822'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Found 'UR'-anomaly for variable 't' (lines '787'-'867'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Found 'UR'-anomaly for variable 'unit' (lines '787'-'884'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: Parameter 'players' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: The method 'createEuropeanUnits' has a Cyclomatic Complexity of 27. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: The method 'createEuropeanUnits' has a Modified Cyclomatic Complexity of 26. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: The method 'createEuropeanUnits' has a Standard Cyclomatic Complexity of 26. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:787: The method createEuropeanUnits() has an NPath complexity of 1159205 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:788: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:788: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:793: Local variable 'europeanPlayers' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:794: Local variable 'player' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:795: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:797: Avoid variables with short names like x +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:797: Local variable 'x' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:799: Avoid variables with short names like y +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:799: Local variable 'y' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:801: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:804: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:804: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:804: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:807: Local variable 'positions' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:808: Local variable 'startingTiles' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:809: Local variable 'carriers' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:810: Local variable 'passengers' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:812: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:813: Local variable 'player' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:814: Local variable 'position' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:814: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:817: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:819: Local variable 'unitList' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:819: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:819: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:819: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:821: Local variable 'startingUnit' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:822: Local variable 'type' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:822: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:823: Local variable 'role' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:823: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:824: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:824: Local variable 'newUnit' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:826: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:827: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:828: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:832: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:833: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:838: Found 'DD'-anomaly for variable 'startAtSea' (lines '838'-'841'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:839: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:844: Found 'DD'-anomaly for variable 'startTile' (lines '844'-'851'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:845: Avoid variables with short names like x +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:845: Local variable 'x' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:845: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:846: Avoid variables with short names like y +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:846: Local variable 'y' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:846: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:848: Local variable 'offset' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:849: Local variable 'row' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:850: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:853: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:854: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:854: Found 'DD'-anomaly for variable 'startTile' (lines '854'-'851'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:856: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:862: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:862: Local variable 'lb2' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:864: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:864: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:867: Avoid using for statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:867: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:872: Avoid throwing raw exception types. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:875: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:878: Local variable 'carrier' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:880: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:882: Local variable 'unit' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:883: Local variable 'carrier' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:890: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:893: Local variable 'unit' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:895: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:901: Avoid variables with short names like op +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:901: Local variable 'op' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:902: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:902: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:907: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:907: Parameter 'row' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:907: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:907: Parameter 'startAtSea' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:908: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:908: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:909: Found 'DD'-anomaly for variable 'tile' (lines '909'-'913'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:909: Found 'DU'-anomaly for variable 'tile' (lines '909'-'922'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:910: Found 'DD'-anomaly for variable 'seas' (lines '910'-'915'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:910: Found 'DU'-anomaly for variable 'seas' (lines '910'-'922'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:911: Found 'DU'-anomaly for variable 'offset' (lines '911'-'922'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:911: Local variable 'offset' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:914: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:915: Found 'DD'-anomaly for variable 'seas' (lines '915'-'915'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:915: Found 'DU'-anomaly for variable 'seas' (lines '915'-'922'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:916: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:917: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:917: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:917: Useless parentheses. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: Avoid really long methods. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: Found 'UR'-anomaly for variable 't' (lines '924'-'976'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: Found 'UR'-anomaly for variable 'tempTile' (lines '924'-'942'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: Found 'UR'-anomaly for variable 'tile' (lines '924'-'963'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: Parameter 'startTile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: The method 'createDebugUnits' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: The method 'createDebugUnits' has a Modified Cyclomatic Complexity of 14. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: The method 'createDebugUnits' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:924: The method createDebugUnits() has an NPath complexity of 960 +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:925: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:925: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:928: Local variable 'unit4' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:930: Local variable 'privateer' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:931: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:933: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:933: Avoid unused local variables such as 'unit5'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:933: Found 'DU'-anomaly for variable 'unit5' (lines '933'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:933: Local variable 'unit5' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:935: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:935: Avoid unused local variables such as 'unit6'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:935: Found 'DU'-anomaly for variable 'unit6' (lines '935'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:935: Local variable 'unit6' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:937: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:937: Avoid unused local variables such as 'unit7'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:937: Found 'DU'-anomaly for variable 'unit7' (lines '937'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:937: Local variable 'unit7' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:939: Found 'DD'-anomaly for variable 'colonyTile' (lines '939'-'944'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:940: Local variable 'tempTile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:942: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:942: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:953: Avoid variables with short names like t +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:953: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:955: Local variable 'buildColonyUnit' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:957: Local variable 'colonyName' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:959: Local variable 'colony' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:961: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:962: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:962: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:963: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:964: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:965: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:965: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:966: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:967: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:968: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:972: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:973: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:974: Avoid variables with short names like ct +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:974: Found 'DU'-anomaly for variable 'ct' (lines '974'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:974: Local variable 'ct' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:974: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:974: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:974: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:975: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:976: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:977: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:978: Local variable 'plowType' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:978: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:980: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:980: Local variable 'plow' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:981: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:982: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:987: Local variable 'schoolType' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:988: Local variable 'schoolhouse' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:989: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:992: Local variable 'statesman' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:993: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:993: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:993: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:993: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:994: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:994: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:997: Local variable 'lumberjack' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:998: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:999: Avoid variables with short names like lt +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:999: Found 'DU'-anomaly for variable 'lt' (lines '999'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:999: Local variable 'lt' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:999: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:999: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:999: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1000: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1001: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1002: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1006: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1006: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1006: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1006: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1011: Avoid unused local variables such as 'carpenter'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1011: Found 'DU'-anomaly for variable 'carpenter' (lines '1,011'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1011: Local variable 'carpenter' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1014: Local variable 'scout' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1015: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1018: Avoid unused local variables such as 'unit8'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1018: Found 'DU'-anomaly for variable 'unit8' (lines '1,018'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1018: Local variable 'unit8' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1019: Avoid unused local variables such as 'unit9'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1019: Found 'DU'-anomaly for variable 'unit9' (lines '1,019'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1019: Local variable 'unit9' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1021: Avoid unused local variables such as 'unit10'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1021: Found 'DU'-anomaly for variable 'unit10' (lines '1,021'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1021: Local variable 'unit10' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1022: Avoid unused local variables such as 'unit11'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1022: Found 'DU'-anomaly for variable 'unit11' (lines '1,022'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1022: Local variable 'unit11' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1023: Avoid unused local variables such as 'unit12'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1023: Found 'DU'-anomaly for variable 'unit12' (lines '1,023'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1023: Local variable 'unit12' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1025: Local variable 'unit13' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1026: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1028: Local variable 'unit14' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1029: Local variable 'cigarsType' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1030: Local variable 'cigards' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1031: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1033: Avoid unused local variables such as 'unit15'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1033: Found 'DU'-anomaly for variable 'unit15' (lines '1,033'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1033: Local variable 'unit15' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1034: Avoid unused local variables such as 'unit16'. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1034: Found 'DU'-anomaly for variable 'unit16' (lines '1,034'-'1,037'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1034: Local variable 'unit16' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1036: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1039: Found 'UR'-anomaly for variable 'player' (lines '1,039'-'1,073'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1039: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1039: The method 'generateStartingPositions' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1039: The method 'generateStartingPositions' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1040: Parameter 'players' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1041: Local variable 'number' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1042: Local variable 'positions' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1044: Found 'DU'-anomaly for variable 'west' (lines '1,044'-'1,081'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1044: Local variable 'west' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1045: Found 'DU'-anomaly for variable 'east' (lines '1,045'-'1,081'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1045: Local variable 'east' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1046: Switch statements should have a default label +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1049: Found 'DU'-anomaly for variable 'row' (lines '1,049'-'1,081'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1051: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1059: Found 'DU'-anomaly for variable 'row' (lines '1,059'-'1,081'). +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1062: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1064: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1072: Local variable 'player' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1073: Local variable 'nation' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1074: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1074: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1075: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1090: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1090: Parameter 'height' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1090: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1090: Parameter 'width' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1101: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1101: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1105: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1105: Local variable 'landMap' could be declared final +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1109: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/generator/SimpleMapGenerator.java:1109: Local variable 'map' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/TerrainGenerator.java:20: Possible God class (WMC=164, ATFD=206, TCC=0.30833333333333335) +src/net/sf/freecol/server/generator/TerrainGenerator.java:59: The class 'TerrainGenerator' has a Cyclomatic Complexity of 10 (Highest = 30). +src/net/sf/freecol/server/generator/TerrainGenerator.java:59: The class 'TerrainGenerator' has a Modified Cyclomatic Complexity of 8 (Highest = 30). +src/net/sf/freecol/server/generator/TerrainGenerator.java:59: The class 'TerrainGenerator' has a Standard Cyclomatic Complexity of 9 (Highest = 30). +src/net/sf/freecol/server/generator/TerrainGenerator.java:59: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/generator/TerrainGenerator.java:61: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/generator/TerrainGenerator.java:61: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/TerrainGenerator.java:63: Avoid excessively long variable names like LAND_REGIONS_SCORE_VALUE +src/net/sf/freecol/server/generator/TerrainGenerator.java:63: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/TerrainGenerator.java:64: Avoid excessively long variable names like LAND_REGION_MIN_SCORE +src/net/sf/freecol/server/generator/TerrainGenerator.java:64: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/TerrainGenerator.java:65: Avoid excessively long variable names like LAND_REGION_MAX_SIZE +src/net/sf/freecol/server/generator/TerrainGenerator.java:65: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/TerrainGenerator.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/TerrainGenerator.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/TerrainGenerator.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/TerrainGenerator.java:83: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/TerrainGenerator.java:86: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/TerrainGenerator.java:89: Avoid using redundant field initializer for 'landTileTypes' +src/net/sf/freecol/server/generator/TerrainGenerator.java:89: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/TerrainGenerator.java:90: Avoid using redundant field initializer for 'oceanTileTypes' +src/net/sf/freecol/server/generator/TerrainGenerator.java:90: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/generator/TerrainGenerator.java:90: fieldCommentRequirement Required +src/net/sf/freecol/server/generator/TerrainGenerator.java:101: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:101: Parameter 'importGame' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:101: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:113: Parameter 'lower' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:113: Parameter 'upper' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:113: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:129: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/TerrainGenerator.java:138: Avoid variables with short names like x +src/net/sf/freecol/server/generator/TerrainGenerator.java:138: Avoid variables with short names like y +src/net/sf/freecol/server/generator/TerrainGenerator.java:138: Parameter 'landMap' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:138: Parameter 'latitude' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:138: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:138: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:139: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:139: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:144: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/TerrainGenerator.java:153: Parameter 'latitude' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:157: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:158: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:170: Parameter 'latitude' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:172: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:173: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:181: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/TerrainGenerator.java:191: Avoid really long methods. +src/net/sf/freecol/server/generator/TerrainGenerator.java:191: Parameter 'candidates' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:191: The method 'getRandomTileType' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/server/generator/TerrainGenerator.java:191: The method 'getRandomTileType' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/generator/TerrainGenerator.java:191: The method 'getRandomTileType' has a Standard Cyclomatic Complexity of 18. +src/net/sf/freecol/server/generator/TerrainGenerator.java:191: The method getRandomTileType() has an NPath complexity of 4374 +src/net/sf/freecol/server/generator/TerrainGenerator.java:192: Parameter 'latitude' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:194: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/TerrainGenerator.java:194: Found 'DU'-anomaly for variable 'forestChance' (lines '194'-'317'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:196: Avoid excessively long variable names like temperaturePreference +src/net/sf/freecol/server/generator/TerrainGenerator.java:200: Found 'DD'-anomaly for variable 'poleTemperature' (lines '200'-'204'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:200: Found 'DD'-anomaly for variable 'poleTemperature' (lines '200'-'208'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:200: Found 'DD'-anomaly for variable 'poleTemperature' (lines '200'-'212'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:201: Avoid excessively long variable names like equatorTemperature +src/net/sf/freecol/server/generator/TerrainGenerator.java:201: Found 'DD'-anomaly for variable 'equatorTemperature' (lines '201'-'205'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:201: Found 'DD'-anomaly for variable 'equatorTemperature' (lines '201'-'209'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:201: Found 'DD'-anomaly for variable 'equatorTemperature' (lines '201'-'213'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:228: Local variable 'temperatureRange' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:231: Avoid excessively long variable names like temperatureDeviation +src/net/sf/freecol/server/generator/TerrainGenerator.java:231: Local variable 'temperatureDeviation' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:238: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:240: Local variable 'humidityDeviation' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:246: Avoid excessively long variable names like candidateTileTypes +src/net/sf/freecol/server/generator/TerrainGenerator.java:246: Local variable 'candidateTileTypes' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:249: Avoid variables with short names like i +src/net/sf/freecol/server/generator/TerrainGenerator.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:251: Local variable 'type' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:261: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:263: Avoid throwing raw exception types. +src/net/sf/freecol/server/generator/TerrainGenerator.java:266: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/TerrainGenerator.java:266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:273: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:274: Local variable 'type' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:275: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:277: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:286: Avoid throwing raw exception types. +src/net/sf/freecol/server/generator/TerrainGenerator.java:289: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/TerrainGenerator.java:289: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:295: Found 'DU'-anomaly for variable 'forested' (lines '295'-'317'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:295: Local variable 'forested' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:297: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:298: Local variable 'type' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:299: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:307: Found 'DU'-anomaly for variable 'i' (lines '307'-'317'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:307: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:309: Avoid throwing raw exception types. +src/net/sf/freecol/server/generator/TerrainGenerator.java:312: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/TerrainGenerator.java:312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:314: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:322: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: Avoid really long methods. +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: The method 'createLandRegions' has a Cyclomatic Complexity of 30. +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: The method 'createLandRegions' has a Modified Cyclomatic Complexity of 30. +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: The method 'createLandRegions' has a Standard Cyclomatic Complexity of 30. +src/net/sf/freecol/server/generator/TerrainGenerator.java:335: The method createLandRegions() has an NPath complexity of 272160 +src/net/sf/freecol/server/generator/TerrainGenerator.java:337: Found 'DD'-anomaly for variable 'continents' (lines '337'-'363'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:338: Found 'DD'-anomaly for variable 'landmap' (lines '338'-'346'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:339: Found 'DD'-anomaly for variable 'continentmap' (lines '339'-'345'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:340: Found 'DD'-anomaly for variable 'landsize' (lines '340'-'353'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:345: Found 'DD'-anomaly for variable 'continentmap' (lines '345'-'345'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:345: Found 'DD'-anomaly for variable 'continentmap' (lines '345'-'369'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:346: Found 'DD'-anomaly for variable 'landmap' (lines '346'-'351'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:348: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:351: Found 'DD'-anomaly for variable 'landmap' (lines '351'-'346'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:351: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:352: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:353: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:353: Found 'DD'-anomaly for variable 'landsize' (lines '353'-'353'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:353: Found 'DU'-anomaly for variable 'landsize' (lines '353'-'465'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:364: Local variable 'continent' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:369: Found 'DD'-anomaly for variable 'continentmap' (lines '369'-'369'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:370: Found 'DD'-anomaly for variable 'landmap' (lines '370'-'370'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:370: Found 'DU'-anomaly for variable 'landmap' (lines '370'-'465'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:380: Found 'DD'-anomaly for variable 'continentsize' (lines '380'-'383'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:383: Found 'DD'-anomaly for variable 'continentsize' (lines '383'-'383'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:388: Local variable 'oldcontinents' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:392: Found 'DD'-anomaly for variable 'splitcontinent' (lines '392'-'399'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:393: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:394: Found 'DD'-anomaly for variable 'splitX' (lines '394'-'400'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:394: Found 'DD'-anomaly for variable 'splitY' (lines '394'-'400'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:394: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/generator/TerrainGenerator.java:399: Found 'DD'-anomaly for variable 'splitcontinent' (lines '399'-'399'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:400: Found 'DD'-anomaly for variable 'splitX' (lines '400'-'400'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:400: Found 'DD'-anomaly for variable 'splitY' (lines '400'-'400'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:408: Found 'DD'-anomaly for variable 'targetsize' (lines '408'-'410'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:413: Local variable 'newregion' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:418: Found 'DD'-anomaly for variable 'continentmap' (lines '418'-'418'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:418: Found 'DU'-anomaly for variable 'continentmap' (lines '418'-'465'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:420: Found 'DD'-anomaly for variable 'continentsize' (lines '420'-'420'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:423: Found 'DD'-anomaly for variable 'splitX' (lines '423'-'394'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:423: Found 'DD'-anomaly for variable 'splitX' (lines '423'-'423'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:423: Found 'DD'-anomaly for variable 'splitY' (lines '423'-'394'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:423: Found 'DD'-anomaly for variable 'splitY' (lines '423'-'423'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:423: Found 'DU'-anomaly for variable 'splitX' (lines '423'-'465'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:423: Found 'DU'-anomaly for variable 'splitY' (lines '423'-'465'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:433: Found 'DD'-anomaly for variable 'landregions' (lines '433'-'437'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:434: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/TerrainGenerator.java:434: Avoid unused local variables such as 'landIndex'. +src/net/sf/freecol/server/generator/TerrainGenerator.java:434: Found 'DU'-anomaly for variable 'landIndex' (lines '434'-'465'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:434: Local variable 'landIndex' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:437: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:437: Found 'DD'-anomaly for variable 'landregions' (lines '437'-'437'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:444: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:445: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:445: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:445: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:445: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:451: Avoid variables with short names like sr +src/net/sf/freecol/server/generator/TerrainGenerator.java:451: Local variable 'sr' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:454: Local variable 'score' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:454: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:459: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:460: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:462: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:462: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:473: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:474: Found 'DU'-anomaly for variable 'hills' (lines '474'-'493'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:475: Found 'DU'-anomaly for variable 'mountains' (lines '475'-'493'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:476: Found 'DD'-anomaly for variable 'tile' (lines '476'-'477'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:477: Avoid assignments in operands +src/net/sf/freecol/server/generator/TerrainGenerator.java:477: Found 'DU'-anomaly for variable 'tile' (lines '477'-'493'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:479: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:483: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:488: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:488: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:489: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: Found 'UR'-anomaly for variable 'neighbour' (lines '503'-'546'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: The method 'createMountains' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: The method 'createMountains' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: The method 'createMountains' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/server/generator/TerrainGenerator.java:503: The method createMountains() has an NPath complexity of 7875 +src/net/sf/freecol/server/generator/TerrainGenerator.java:504: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/TerrainGenerator.java:504: Found 'DU'-anomaly for variable 'result' (lines '504'-'585'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:504: Local variable 'result' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:505: Local variable 'randomHillsRatio' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:509: Local variable 'maximumLength' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:522: Avoid throwing raw exception types. +src/net/sf/freecol/server/generator/TerrainGenerator.java:526: Found 'DD'-anomaly for variable 'counter' (lines '526'-'544'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:528: Local variable 'startTile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:529: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:531: Local variable 'mountainRegion' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:532: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:533: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:534: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:535: Local variable 'direction' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:537: Local variable 'length' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:540: Local variable 'nextTile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:540: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:541: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:541: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:542: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:544: Found 'DD'-anomaly for variable 'counter' (lines '544'-'552'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:545: Local variable 'neighbour' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:546: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:546: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:547: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:548: Avoid variables with short names like r +src/net/sf/freecol/server/generator/TerrainGenerator.java:548: Local variable 'r' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:550: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:551: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:552: Found 'DD'-anomaly for variable 'counter' (lines '552'-'544'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:552: Found 'DD'-anomaly for variable 'counter' (lines '552'-'552'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:553: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/generator/TerrainGenerator.java:554: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:555: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:559: Local variable 'scoreValue' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:559: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:564: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:566: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:571: Found 'DU'-anomaly for variable 'number' (lines '571'-'585'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:575: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:575: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:576: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:579: Avoid variables with short names like m +src/net/sf/freecol/server/generator/TerrainGenerator.java:579: Local variable 'm' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:580: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:580: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:580: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:581: Avoid assignments in operands +src/net/sf/freecol/server/generator/TerrainGenerator.java:581: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:595: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/TerrainGenerator.java:595: Found 'UR'-anomaly for variable 'river' (lines '595'-'636'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:595: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:595: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:595: The method 'createRivers' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/generator/TerrainGenerator.java:595: The method 'createRivers' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/generator/TerrainGenerator.java:595: The method 'createRivers' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/generator/TerrainGenerator.java:596: Local variable 'result' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:597: Found 'DU'-anomaly for variable 'riverType' (lines '597'-'644'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:602: Found 'DU'-anomaly for variable 'riverMap' (lines '602'-'644'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:602: Local variable 'riverMap' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:603: Local variable 'rivers' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:607: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:608: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:610: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:613: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:613: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:613: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:618: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:618: Local variable 'riverRegion' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:619: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:619: Local variable 'river' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:625: Avoid assignments in operands +src/net/sf/freecol/server/generator/TerrainGenerator.java:625: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:635: Local variable 'river' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:636: Local variable 'region' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:637: Local variable 'scoreValue' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:637: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:637: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:637: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:638: Avoid variables with short names like rs +src/net/sf/freecol/server/generator/TerrainGenerator.java:639: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:653: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/TerrainGenerator.java:653: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:653: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:654: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/generator/TerrainGenerator.java:654: Avoid unused local variables such as 'lakeType'. +src/net/sf/freecol/server/generator/TerrainGenerator.java:654: Found 'DU'-anomaly for variable 'lakeType' (lines '654'-'675'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:659: Local variable 'lakes' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:664: Avoid assignments in operands +src/net/sf/freecol/server/generator/TerrainGenerator.java:664: Found 'DD'-anomaly for variable 'tile' (lines '664'-'664'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:664: Found 'DU'-anomaly for variable 'tile' (lines '664'-'675'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:665: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:666: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:667: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:677: Comment is too large: Too many lines +src/net/sf/freecol/server/generator/TerrainGenerator.java:688: Found 'UR'-anomaly for variable 'd' (lines '688'-'715'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:688: Parameter 'lakes' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:688: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:689: Local variable 'game' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:690: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:692: Local variable 'todo' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:693: Local variable 'result' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:694: Avoid unused local variables such as 'lakeCount'. +src/net/sf/freecol/server/generator/TerrainGenerator.java:694: Found 'DU'-anomaly for variable 'lakeCount' (lines '694'-'723'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:694: Local variable 'lakeCount' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:696: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:697: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:697: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:699: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:699: Local variable 'lakeRegion' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:704: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:704: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:714: Local variable 'd' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:715: Avoid variables with short names like t0 +src/net/sf/freecol/server/generator/TerrainGenerator.java:715: Local variable 't0' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:716: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:732: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:732: Found 'UR'-anomaly for variable 'direction' (lines '732'-'750'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:732: Parameter 'generateBonus' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:732: Parameter 't' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:732: The method 'perhapsAddBonus' has a Cyclomatic Complexity of 16. +src/net/sf/freecol/server/generator/TerrainGenerator.java:732: The method 'perhapsAddBonus' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/generator/TerrainGenerator.java:732: The method 'perhapsAddBonus' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/generator/TerrainGenerator.java:734: Found 'DU'-anomaly for variable 'fishBonusLandType' (lines '734'-'786'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:734: Local variable 'fishBonusLandType' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:735: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:736: Avoid excessively long variable names like fishBonusRiverType +src/net/sf/freecol/server/generator/TerrainGenerator.java:736: Found 'DU'-anomaly for variable 'fishBonusRiverType' (lines '736'-'786'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:736: Local variable 'fishBonusRiverType' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:737: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:738: Found 'DU'-anomaly for variable 'bonusNumber' (lines '738'-'786'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:747: Found 'DD'-anomaly for variable 'adjacentLand' (lines '747'-'752'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:748: Found 'DD'-anomaly for variable 'adjacentRiver' (lines '748'-'754'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:749: Local variable 'direction' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:750: Local variable 'otherTile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:751: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:752: Found 'DD'-anomaly for variable 'adjacentLand' (lines '752'-'752'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:753: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:754: Found 'DD'-anomaly for variable 'adjacentRiver' (lines '754'-'754'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:761: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/generator/TerrainGenerator.java:773: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:794: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:795: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/TerrainGenerator.java:795: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:796: Local variable 'resourceType' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:796: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:797: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:798: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/generator/TerrainGenerator.java:798: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:799: Local variable 'minValue' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:799: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:800: Local variable 'maxValue' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:800: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:801: Local variable 'quantity' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:802: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:802: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:818: Found 'UR'-anomaly for variable 'd' (lines '818'-'824'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:818: Found 'UR'-anomaly for variable 'd' (lines '818'-'829'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:818: Found 'UR'-anomaly for variable 'd' (lines '818'-'842'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:818: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:819: Found 'DU'-anomaly for variable 'connections' (lines '819'-'850'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:819: Local variable 'connections' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:823: Local variable 'd' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:824: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:824: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:828: Local variable 'd' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:829: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:829: Local variable 't' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:840: Found 'DD'-anomaly for variable 'index' (lines '840'-'843'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:840: Found 'DD'-anomaly for variable 'index' (lines '840'-'847'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:840: Found 'DU'-anomaly for variable 'index' (lines '840'-'850'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:841: Local variable 'd' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:842: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:843: Found 'DD'-anomaly for variable 'index' (lines '843'-'843'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:843: Found 'DD'-anomaly for variable 'index' (lines '843'-'847'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:843: Found 'DU'-anomaly for variable 'index' (lines '843'-'850'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:845: Local variable 'd' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:846: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:847: Found 'DD'-anomaly for variable 'index' (lines '847'-'847'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:847: Found 'DU'-anomaly for variable 'index' (lines '847'-'850'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Avoid really long methods. +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Avoid variables with short names like lb +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Found 'UR'-anomaly for variable 'c' (lines '861'-'896'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Found 'UR'-anomaly for variable 'gr' (lines '861'-'978'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Found 'UR'-anomaly for variable 'r' (lines '861'-'885'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Found 'UR'-anomaly for variable 'sr' (lines '861'-'974'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Found 'UR'-anomaly for variable 'sr' (lines '861'-'978'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Found 'UR'-anomaly for variable 'sr' (lines '861'-'985'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Found 'UR'-anomaly for variable 'tile' (lines '861'-'995'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Parameter 'landMap' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: The method 'createMap' has a Cyclomatic Complexity of 28. +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: The method 'createMap' has a Modified Cyclomatic Complexity of 25. +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: The method 'createMap' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: The method createMap() has an NCSS line count of 103 +src/net/sf/freecol/server/generator/TerrainGenerator.java:861: The method createMap() has an NPath complexity of 73440 +src/net/sf/freecol/server/generator/TerrainGenerator.java:864: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:864: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:866: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:866: Useless parentheses. +src/net/sf/freecol/server/generator/TerrainGenerator.java:869: Found 'DD'-anomaly for variable 'mapHasLand' (lines '869'-'907'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:870: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/generator/TerrainGenerator.java:870: Local variable 'map' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:871: Found 'DD'-anomaly for variable 'minimumLatitude' (lines '871'-'876'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:873: Found 'DD'-anomaly for variable 'maximumLatitude' (lines '873'-'877'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:878: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:879: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:881: Local variable 'regionMap' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:884: Local variable 'r' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:884: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:885: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:885: Local variable 'region' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:886: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:888: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:890: Local variable 'r' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:890: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:891: Local variable 'region' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:892: Avoid variables with short names like x +src/net/sf/freecol/server/generator/TerrainGenerator.java:892: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:893: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:893: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:893: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:894: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:895: Local variable 'c' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:895: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:896: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:897: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:897: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:903: Local variable 'fixRegions' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:905: Found 'DD'-anomaly for variable 'latitude' (lines '905'-'905'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:905: Found 'DU'-anomaly for variable 'latitude' (lines '905'-'1,005'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:905: Local variable 'latitude' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:905: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:907: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:907: Found 'DD'-anomaly for variable 'mapHasLand' (lines '907'-'907'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:907: Found 'DU'-anomaly for variable 'mapHasLand' (lines '907'-'1,005'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:908: Avoid variables with short names like t +src/net/sf/freecol/server/generator/TerrainGenerator.java:908: Found 'DD'-anomaly for variable 'importTile' (lines '908'-'909'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:908: Found 'DD'-anomaly for variable 't' (lines '908'-'914'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:908: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/generator/TerrainGenerator.java:909: Avoid assignments in operands +src/net/sf/freecol/server/generator/TerrainGenerator.java:910: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:911: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:911: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:912: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:913: Avoid variables with short names like id +src/net/sf/freecol/server/generator/TerrainGenerator.java:913: Local variable 'id' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/generator/TerrainGenerator.java:913: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:914: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:915: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:916: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:916: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:918: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:919: Local variable 'container' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:920: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/generator/TerrainGenerator.java:924: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:924: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:926: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:928: Avoid variables with short names like r +src/net/sf/freecol/server/generator/TerrainGenerator.java:928: Local variable 'r' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:928: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:930: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:932: Local variable 'ours' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:932: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:932: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:934: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:936: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:938: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:944: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:950: Local variable 'fixed' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:951: Local variable 'newRegions' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:953: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:958: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:972: Found 'DU'-anomaly for variable 'geographic' (lines '972'-'1,005'). +src/net/sf/freecol/server/generator/TerrainGenerator.java:972: Local variable 'geographic' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:973: Local variable 'sr' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:974: Avoid using if statements without curly braces +src/net/sf/freecol/server/generator/TerrainGenerator.java:976: Local variable 'sr' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:977: Local variable 'gr' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:989: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:994: Local variable 'tile' could be declared final +src/net/sf/freecol/server/generator/TerrainGenerator.java:994: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:1002: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/generator/TerrainGenerator.java:1003: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/DiplomacySession.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/DiplomacySession.java:36: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/model/DiplomacySession.java:36: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/DiplomacySession.java:36: fieldCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:51: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/DiplomacySession.java:51: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/DiplomacySession.java:51: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:53: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/DiplomacySession.java:56: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/DiplomacySession.java:59: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/server/model/DiplomacySession.java:59: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/DiplomacySession.java:59: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:61: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/DiplomacySession.java:63: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/DiplomacySession.java:68: Avoid variables with short names like cs +src/net/sf/freecol/server/model/DiplomacySession.java:68: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/DiplomacySession.java:68: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:74: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:78: Parameter 'agreement' is not assigned and could be declared final +src/net/sf/freecol/server/model/DiplomacySession.java:78: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:82: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:86: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/DiplomacySession.java:90: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/LootSession.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/LootSession.java:35: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/model/LootSession.java:35: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/LootSession.java:35: fieldCommentRequirement Required +src/net/sf/freecol/server/model/LootSession.java:41: Parameter 'capture' is not assigned and could be declared final +src/net/sf/freecol/server/model/LootSession.java:41: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/LootSession.java:41: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/LootSession.java:41: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/LootSession.java:48: Avoid variables with short names like cs +src/net/sf/freecol/server/model/LootSession.java:48: Overriding method merely calls super +src/net/sf/freecol/server/model/LootSession.java:48: Overriding method merely calls super +src/net/sf/freecol/server/model/LootSession.java:48: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/LootSession.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/LootSession.java:52: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/MonarchSession.java:36: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/model/MonarchSession.java:36: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/MonarchSession.java:36: fieldCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/MonarchSession.java:48: Avoid using redundant field initializer for 'goods' +src/net/sf/freecol/server/model/MonarchSession.java:48: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/MonarchSession.java:48: Private field 'goods' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/server/model/MonarchSession.java:51: Avoid using redundant field initializer for 'mercenaries' +src/net/sf/freecol/server/model/MonarchSession.java:51: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/MonarchSession.java:51: Private field 'mercenaries' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/server/model/MonarchSession.java:57: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:57: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:57: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:58: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:58: Parameter 'tax' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:65: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/MonarchSession.java:69: Parameter 'action' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:69: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:69: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:70: Parameter 'mercenaries' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:70: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:76: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/MonarchSession.java:81: Avoid variables with short names like cs +src/net/sf/freecol/server/model/MonarchSession.java:81: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:81: Parameter 'result' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:81: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:87: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/MonarchSession.java:96: Avoid variables with short names like cs +src/net/sf/freecol/server/model/MonarchSession.java:96: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/MonarchSession.java:96: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:110: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:114: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:118: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:122: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/MonarchSession.java:126: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/ServerBuilding.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerBuilding.java:47: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerBuilding.java:47: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerBuilding.java:53: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerBuilding.java:53: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:53: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:64: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:64: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:64: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:77: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerBuilding.java:77: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerBuilding.java:77: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:77: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:77: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:78: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:80: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerBuilding.java:82: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:92: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerBuilding.java:92: Found 'UR'-anomaly for variable 'teacher' (lines '92'-'96'). +src/net/sf/freecol/server/model/ServerBuilding.java:92: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:93: Found 'DU'-anomaly for variable 'owner' (lines '93'-'118'). +src/net/sf/freecol/server/model/ServerBuilding.java:93: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:95: Local variable 'teacher' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:103: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerBuilding.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:120: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerBuilding.java:131: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerBuilding.java:131: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:131: Parameter 'teacher' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:132: Found 'DU'-anomaly for variable 'owner' (lines '132'-'145'). +src/net/sf/freecol/server/model/ServerBuilding.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:134: Local variable 'student' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:141: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerBuilding.java:142: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerBuilding.java:155: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerBuilding.java:155: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:155: Parameter 'student' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:155: Parameter 'teacher' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:156: Found 'DU'-anomaly for variable 'owner' (lines '156'-'184'). +src/net/sf/freecol/server/model/ServerBuilding.java:156: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:157: Found 'DU'-anomaly for variable 'oldName' (lines '157'-'184'). +src/net/sf/freecol/server/model/ServerBuilding.java:157: Local variable 'oldName' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:158: Local variable 'teach' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:159: Local variable 'skill' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:160: Local variable 'ret' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:162: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerBuilding.java:166: Local variable 'newName' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:173: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:193: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerBuilding.java:193: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:193: Parameter 'teacher' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:204: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerBuilding.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:218: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerBuilding.java:218: Found 'UR'-anomaly for variable 'unit' (lines '218'-'220'). +src/net/sf/freecol/server/model/ServerBuilding.java:218: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:219: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:223: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:228: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerBuilding.java:237: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerBuilding.java:237: Avoid variables with short names like pi +src/net/sf/freecol/server/model/ServerBuilding.java:237: Found 'UR'-anomaly for variable 'goods' (lines '237'-'244'). +src/net/sf/freecol/server/model/ServerBuilding.java:237: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:237: Parameter 'pi' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:238: Local variable 'inputs' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerBuilding.java:242: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerBuilding.java:243: Local variable 'goods' could be declared final +src/net/sf/freecol/server/model/ServerBuilding.java:245: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerBuilding.java:250: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColony.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/model/ServerColony.java:20: Possible God class (WMC=137, ATFD=116, TCC=0.0) +src/net/sf/freecol/server/model/ServerColony.java:60: No need to import a type that lives in the same package +src/net/sf/freecol/server/model/ServerColony.java:66: The class 'ServerColony' has a Cyclomatic Complexity of 9 (Highest = 78). +src/net/sf/freecol/server/model/ServerColony.java:66: The class 'ServerColony' has a Modified Cyclomatic Complexity of 7 (Highest = 60). +src/net/sf/freecol/server/model/ServerColony.java:66: The class 'ServerColony' has a Standard Cyclomatic Complexity of 7 (Highest = 61). +src/net/sf/freecol/server/model/ServerColony.java:66: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/model/ServerColony.java:68: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerColony.java:68: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerColony.java:74: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerColony.java:74: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:74: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:86: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:86: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:86: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:86: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:88: Local variable 'spec' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:95: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:97: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:98: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:102: Local variable 'buildingTypes' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:103: Local variable 'buildingType' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:106: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:120: Local variable 'unitType' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:127: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColony.java:137: Avoid really long methods. +src/net/sf/freecol/server/model/ServerColony.java:137: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:137: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'buildingType' (lines '137'-'429'). +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'g' (lines '137'-'447'). +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'goods' (lines '137'-'166'). +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'goodsType' (lines '137'-'245'). +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'queue' (lines '137'-'189'). +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'teacher' (lines '137'-'490'). +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'unit' (lines '137'-'169'). +src/net/sf/freecol/server/model/ServerColony.java:137: Found 'UR'-anomaly for variable 'workLocation' (lines '137'-'161'). +src/net/sf/freecol/server/model/ServerColony.java:137: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:137: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:137: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:137: The method 'csNewTurn' has a Cyclomatic Complexity of 78. +src/net/sf/freecol/server/model/ServerColony.java:137: The method 'csNewTurn' has a Modified Cyclomatic Complexity of 60. +src/net/sf/freecol/server/model/ServerColony.java:137: The method 'csNewTurn' has a Standard Cyclomatic Complexity of 61. +src/net/sf/freecol/server/model/ServerColony.java:137: The method csNewTurn() has an NCSS line count of 197 +src/net/sf/freecol/server/model/ServerColony.java:139: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerColony.java:139: Found 'DU'-anomaly for variable 'spec' (lines '139'-'502'). +src/net/sf/freecol/server/model/ServerColony.java:141: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerColony.java:141: Found 'DU'-anomaly for variable 'queues' (lines '141'-'502'). +src/net/sf/freecol/server/model/ServerColony.java:141: Local variable 'queues' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:143: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerColony.java:143: Found 'DU'-anomaly for variable 'tile' (lines '143'-'502'). +src/net/sf/freecol/server/model/ServerColony.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:151: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColony.java:154: Found 'DD'-anomaly for variable 'tileDirty' (lines '154'-'319'). +src/net/sf/freecol/server/model/ServerColony.java:156: Local variable 'container' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:160: Local variable 'workLocation' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:162: Local variable 'productionInfo' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:163: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:165: Local variable 'goods' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:166: Local variable 'expert' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:167: Local variable 'experience' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:168: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:169: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:170: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:179: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:187: Local variable 'built' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:188: Local variable 'queue' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:189: Local variable 'info' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:190: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:191: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:192: Local variable 'build' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:194: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:194: Local variable 'needed' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:195: Local variable 'complete' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:200: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:203: The String literal "%colony%" appears 17 times in this file; the first occurrence is on line 203 +src/net/sf/freecol/server/model/ServerColony.java:205: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:206: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:211: Local variable 'buildable' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:213: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerColony.java:213: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerColony.java:215: Local variable 'newUnit' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:219: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:221: Local variable 'unitCount' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:223: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:243: Local variable 'productionMap' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:244: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:245: Local variable 'net' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:246: Local variable 'stored' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:257: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerColony.java:258: Local variable 'victim' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:264: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:270: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:274: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:278: Local variable 'turns' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:281: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:297: Local variable 'queue' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:300: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerColony.java:326: Local variable 'lb2' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:327: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:328: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:329: Local variable 'goods' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:330: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:331: Local variable 'data' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:332: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:332: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:333: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:334: Local variable 'amount' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:334: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:335: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:336: Local variable 'oldGold' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:337: Local variable 'marketAmount' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:337: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:339: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:341: Avoid variables with short names like st +src/net/sf/freecol/server/model/ServerColony.java:341: Local variable 'st' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:341: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:343: The String literal "%goods%" appears 4 times in this file; the first occurrence is on line 343 +src/net/sf/freecol/server/model/ServerColony.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:344: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:344: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:355: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:361: Local variable 'limit' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:362: Local variable 'adjustment' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:363: Local variable 'goods' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:364: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:364: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:365: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:366: Local variable 'exportData' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:367: Local variable 'low' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:368: Local variable 'high' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:368: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:369: Local variable 'amount' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:370: Local variable 'oldAmount' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:370: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:373: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:375: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:383: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:385: Found 'DD'-anomaly for variable 'messageId' (lines '385'-'391'). +src/net/sf/freecol/server/model/ServerColony.java:386: Found 'DD'-anomaly for variable 'waste' (lines '386'-'389'). +src/net/sf/freecol/server/model/ServerColony.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:401: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:410: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:410: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:414: Local variable 'loss' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:417: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:428: Local variable 'buildingType' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:430: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:444: Local variable 'queue' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:446: Local variable 'g' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:453: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:468: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:468: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:471: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:476: Local variable 'govMgtMessage' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:486: Local variable 'workLocation' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:488: Local variable 'building' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:489: Local variable 'teacher' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:511: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:513: Local variable 'buildables' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:514: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:515: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:516: Avoid variables with short names like bt +src/net/sf/freecol/server/model/ServerColony.java:528: Parameter 'buildQueue' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:529: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:529: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:529: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:530: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:531: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:549: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:549: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerColony.java:549: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerColony.java:553: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColony.java:565: Found 'UR'-anomaly for variable 'u' (lines '565'-'569'). +src/net/sf/freecol/server/model/ServerColony.java:565: Found 'UR'-anomaly for variable 'u' (lines '565'-'573'). +src/net/sf/freecol/server/model/ServerColony.java:565: Found 'UR'-anomaly for variable 'wl' (lines '565'-'569'). +src/net/sf/freecol/server/model/ServerColony.java:565: Parameter 'units' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:565: Parameter 'workLocation' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:566: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColony.java:566: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:567: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:568: Local variable 'wl' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:569: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:569: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerColony.java:571: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/model/ServerColony.java:575: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:588: Parameter 'buildQueue' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:589: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:589: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:590: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:591: Found 'DU'-anomaly for variable 'copied' (lines '591'-'621'). +src/net/sf/freecol/server/model/ServerColony.java:591: Local variable 'copied' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:591: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:592: Local variable 'from' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:597: Local variable 'building' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:598: Local variable 'eject' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:598: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:602: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:602: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:617: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerColony.java:617: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerColony.java:618: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:631: Found 'UR'-anomaly for variable 'goodsType' (lines '631'-'648'). +src/net/sf/freecol/server/model/ServerColony.java:631: Parameter 'queue' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:631: The method 'csNextBuildable' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerColony.java:632: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:632: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:633: Found 'DU'-anomaly for variable 'spec' (lines '633'-'682'). +src/net/sf/freecol/server/model/ServerColony.java:633: Local variable 'spec' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:634: Found 'DU'-anomaly for variable 'owner' (lines '634'-'682'). +src/net/sf/freecol/server/model/ServerColony.java:634: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:636: Found 'DD'-anomaly for variable 'invalidate' (lines '636'-'678'). +src/net/sf/freecol/server/model/ServerColony.java:636: Found 'DU'-anomaly for variable 'invalidate' (lines '636'-'682'). +src/net/sf/freecol/server/model/ServerColony.java:638: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerColony.java:638: Found 'DU'-anomaly for variable 'buildable' (lines '638'-'682'). +src/net/sf/freecol/server/model/ServerColony.java:645: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColony.java:647: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:648: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:649: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:653: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:659: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColony.java:663: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColony.java:670: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerColony.java:678: Found 'DD'-anomaly for variable 'invalidate' (lines '678'-'678'). +src/net/sf/freecol/server/model/ServerColony.java:678: Found 'DU'-anomaly for variable 'invalidate' (lines '678'-'682'). +src/net/sf/freecol/server/model/ServerColony.java:680: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:691: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:691: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:691: Parameter 'enemyUnit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:692: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerColony.java:692: Found 'DU'-anomaly for variable 'serverPlayer' (lines '692'-'708'). +src/net/sf/freecol/server/model/ServerColony.java:692: Local variable 'serverPlayer' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:693: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:694: Avoid variables with short names like ct +src/net/sf/freecol/server/model/ServerColony.java:694: Local variable 'ct' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:695: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColony.java:695: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:696: Local variable 'colonyTile' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:696: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:696: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:697: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerColony.java:697: Found 'DU'-anomaly for variable 'copied' (lines '697'-'708'). +src/net/sf/freecol/server/model/ServerColony.java:697: Local variable 'copied' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:697: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:698: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:698: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:699: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:704: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:710: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColony.java:720: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:720: Found 'UR'-anomaly for variable 'bt' (lines '720'-'746'). +src/net/sf/freecol/server/model/ServerColony.java:720: Found 'UR'-anomaly for variable 'exportDatum' (lines '720'-'738'). +src/net/sf/freecol/server/model/ServerColony.java:720: Found 'UR'-anomaly for variable 't' (lines '720'-'723'). +src/net/sf/freecol/server/model/ServerColony.java:720: Found 'UR'-anomaly for variable 'u' (lines '720'-'732'). +src/net/sf/freecol/server/model/ServerColony.java:720: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:720: Parameter 'newOwner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:723: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:723: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:727: Found 'DU'-anomaly for variable 'change' (lines '727'-'753'). +src/net/sf/freecol/server/model/ServerColony.java:727: Local variable 'change' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:727: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:727: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:729: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:730: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:730: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:730: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:731: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:732: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:737: Local variable 'exportDatum' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:745: Local variable 'bt' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:755: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColony.java:764: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:764: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:764: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:770: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:782: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:783: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/model/ServerColony.java:783: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/model/ServerColony.java:784: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerColony.java:784: Found 'DU'-anomaly for variable 'copied' (lines '784'-'790'). +src/net/sf/freecol/server/model/ServerColony.java:784: Local variable 'copied' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:784: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:784: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:784: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:784: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:785: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerColony.java:785: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:786: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColony.java:786: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:787: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:792: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColony.java:802: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:802: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:802: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:803: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:803: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:803: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:804: Local variable 'ret' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:807: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:808: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:809: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:822: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColony.java:822: Parameter 'brave' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:822: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:823: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:824: Local variable 'newOwner' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:825: Local variable 'oldOwner' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:826: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:828: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:828: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:833: Local variable 'nation' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:833: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:839: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColony.java:840: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerColony.java:850: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColony.java:851: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerColony.java:851: Found 'DU'-anomaly for variable 'copied' (lines '851'-'858'). +src/net/sf/freecol/server/model/ServerColony.java:851: Local variable 'copied' could be declared final +src/net/sf/freecol/server/model/ServerColony.java:851: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:851: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:851: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:851: Useless parentheses. +src/net/sf/freecol/server/model/ServerColony.java:852: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerColony.java:852: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColony.java:853: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColony.java:853: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColony.java:854: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColonyTile.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColonyTile.java:44: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/model/ServerColonyTile.java:44: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerColonyTile.java:44: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerColonyTile.java:50: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerColonyTile.java:50: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:50: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:62: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:62: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:62: Parameter 'workTile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:75: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerColonyTile.java:75: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerColonyTile.java:75: Found 'UR'-anomaly for variable 'unit' (lines '75'-'82'). +src/net/sf/freecol/server/model/ServerColonyTile.java:75: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:75: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:75: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:76: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:77: Found 'DU'-anomaly for variable 'owner' (lines '77'-'97'). +src/net/sf/freecol/server/model/ServerColonyTile.java:77: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:77: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColonyTile.java:79: Found 'DU'-anomaly for variable 'workTile' (lines '79'-'97'). +src/net/sf/freecol/server/model/ServerColonyTile.java:79: Local variable 'workTile' could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:81: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:82: Local variable 'resource' could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:85: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColonyTile.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerColonyTile.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColonyTile.java:88: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerColonyTile.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColonyTile.java:99: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerColonyTile.java:110: Parameter 'goodsType' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:110: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:111: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:112: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColonyTile.java:112: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColonyTile.java:114: Local variable 'resource' could be declared final +src/net/sf/freecol/server/model/ServerColonyTile.java:115: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerColonyTile.java:115: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerColonyTile.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColonyTile.java:117: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerColonyTile.java:121: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerEurope.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerEurope.java:50: The class 'ServerEurope' has a Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/server/model/ServerEurope.java:50: The class 'ServerEurope' has a Modified Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/server/model/ServerEurope.java:50: The class 'ServerEurope' has a Standard Cyclomatic Complexity of 3 (Highest = 10). +src/net/sf/freecol/server/model/ServerEurope.java:52: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerEurope.java:52: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerEurope.java:58: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerEurope.java:58: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:58: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:69: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:69: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:78: Found 'UR'-anomaly for variable 'ag' (lines '78'-'101'). +src/net/sf/freecol/server/model/ServerEurope.java:78: Found 'UR'-anomaly for variable 'ag' (lines '78'-'91'). +src/net/sf/freecol/server/model/ServerEurope.java:78: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:78: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:78: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:78: The method 'equipForRole' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerEurope.java:78: The method 'equipForRole' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/model/ServerEurope.java:78: The method 'equipForRole' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/model/ServerEurope.java:78: The method equipForRole() has an NPath complexity of 210 +src/net/sf/freecol/server/model/ServerEurope.java:79: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerEurope.java:79: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerEurope.java:82: Local variable 'required' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:85: Local variable 'price' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:86: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerEurope.java:86: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerEurope.java:86: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerEurope.java:89: Found 'DU'-anomaly for variable 'owner' (lines '89'-'110'). +src/net/sf/freecol/server/model/ServerEurope.java:90: Local variable 'ag' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:91: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerEurope.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:93: Avoid variables with short names like rm +src/net/sf/freecol/server/model/ServerEurope.java:93: Local variable 'rm' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:93: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:95: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerEurope.java:100: Local variable 'ag' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:101: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerEurope.java:102: Avoid variables with short names like m +src/net/sf/freecol/server/model/ServerEurope.java:102: Local variable 'm' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:104: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerEurope.java:118: Found 'UR'-anomaly for variable 'au' (lines '118'-'126'). +src/net/sf/freecol/server/model/ServerEurope.java:118: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerEurope.java:122: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:123: Local variable 'option' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:125: Local variable 'au' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:126: Found 'DD'-anomaly for variable 'unitType' (lines '126'-'126'). +src/net/sf/freecol/server/model/ServerEurope.java:126: Found 'DD'-anomaly for variable 'unitType' (lines '126'-'146'). +src/net/sf/freecol/server/model/ServerEurope.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:131: Found 'DU'-anomaly for variable 'index' (lines '131'-'149'). +src/net/sf/freecol/server/model/ServerEurope.java:132: Local variable 'optionId' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:134: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerEurope.java:134: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerEurope.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:138: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/model/ServerEurope.java:144: Local variable 'recruits' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:156: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:160: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerEurope.java:171: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:171: Parameter 'slot' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:175: Local variable 'index' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:175: Useless parentheses. +src/net/sf/freecol/server/model/ServerEurope.java:175: Useless parentheses. +src/net/sf/freecol/server/model/ServerEurope.java:178: Local variable 'result' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:192: Found 'UR'-anomaly for variable 'unitType' (lines '192'-'196'). +src/net/sf/freecol/server/model/ServerEurope.java:193: Found 'DU'-anomaly for variable 'owner' (lines '193'-'203'). +src/net/sf/freecol/server/model/ServerEurope.java:194: Local variable 'recruits' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:195: Local variable 'unitType' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerEurope.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:198: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerEurope.java:211: Found 'UR'-anomaly for variable 'ut' (lines '211'-'216'). +src/net/sf/freecol/server/model/ServerEurope.java:211: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:212: Found 'DU'-anomaly for variable 'recruits' (lines '212'-'224'). +src/net/sf/freecol/server/model/ServerEurope.java:212: Local variable 'recruits' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:213: Found 'DD'-anomaly for variable 'result' (lines '213'-'220'). +src/net/sf/freecol/server/model/ServerEurope.java:214: Avoid variables with short names like i +src/net/sf/freecol/server/model/ServerEurope.java:214: Found 'DU'-anomaly for variable 'i' (lines '214'-'224'). +src/net/sf/freecol/server/model/ServerEurope.java:215: Local variable 'ut' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:216: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerEurope.java:217: Local variable 'newType' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:220: Found 'DD'-anomaly for variable 'result' (lines '220'-'220'). +src/net/sf/freecol/server/model/ServerEurope.java:221: Found 'DU'-anomaly for variable 'i' (lines '221'-'224'). +src/net/sf/freecol/server/model/ServerEurope.java:234: Avoid variables with short names like n +src/net/sf/freecol/server/model/ServerEurope.java:234: Parameter 'n' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:234: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:235: Found 'DU'-anomaly for variable 'game' (lines '235'-'243'). +src/net/sf/freecol/server/model/ServerEurope.java:236: Found 'DU'-anomaly for variable 'owner' (lines '236'-'243'). +src/net/sf/freecol/server/model/ServerEurope.java:237: Found 'DU'-anomaly for variable 'recruits' (lines '237'-'243'). +src/net/sf/freecol/server/model/ServerEurope.java:237: Local variable 'recruits' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:239: Avoid variables with short names like ut +src/net/sf/freecol/server/model/ServerEurope.java:239: Local variable 'ut' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:241: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerEurope.java:251: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:251: Parameter 'unitType' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:253: Local variable 'baseOption' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:254: Local variable 'option' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:254: Useless parentheses. +src/net/sf/freecol/server/model/ServerEurope.java:254: Useless parentheses. +src/net/sf/freecol/server/model/ServerEurope.java:257: Local variable 'increase' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:257: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:257: Useless parentheses. +src/net/sf/freecol/server/model/ServerEurope.java:257: Useless parentheses. +src/net/sf/freecol/server/model/ServerEurope.java:263: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerEurope.java:273: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerEurope.java:273: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerEurope.java:273: Found 'UR'-anomaly for variable 'unit' (lines '273'-'277'). +src/net/sf/freecol/server/model/ServerEurope.java:273: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:273: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:273: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:274: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerEurope.java:276: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:278: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerEurope.java:283: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerEurope.java:293: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:293: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:293: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:294: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerEurope.java:294: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:294: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:295: Local variable 'ret' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:298: Local variable 'serverPlayer' could be declared final +src/net/sf/freecol/server/model/ServerEurope.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerEurope.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerGame.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/model/ServerGame.java:20: Possible God class (WMC=62, ATFD=60, TCC=0.0) +src/net/sf/freecol/server/model/ServerGame.java:24: Avoid unused imports such as 'java.util.Arrays' +src/net/sf/freecol/server/model/ServerGame.java:68: The class 'ServerGame' has a Cyclomatic Complexity of 4 (Highest = 29). +src/net/sf/freecol/server/model/ServerGame.java:68: The class 'ServerGame' has a Modified Cyclomatic Complexity of 3 (Highest = 25). +src/net/sf/freecol/server/model/ServerGame.java:68: The class 'ServerGame' has a Standard Cyclomatic Complexity of 3 (Highest = 25). +src/net/sf/freecol/server/model/ServerGame.java:68: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/model/ServerGame.java:70: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerGame.java:70: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerGame.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/ServerGame.java:82: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:86: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerGame.java:89: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerGame.java:100: Avoid excessively long variable names like freeColGameObjectListener +src/net/sf/freecol/server/model/ServerGame.java:100: Parameter 'freeColGameObjectListener' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:101: Avoid variables with short names like xr +src/net/sf/freecol/server/model/ServerGame.java:101: Parameter 'specification' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:101: Parameter 'xr' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:118: Parameter 'serverPlayers' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:119: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:120: Avoid variables with short names like p +src/net/sf/freecol/server/model/ServerGame.java:121: Avoid variables with short names like sp +src/net/sf/freecol/server/model/ServerGame.java:122: Avoid variables with short names like s +src/net/sf/freecol/server/model/ServerGame.java:133: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerGame.java:133: Found 'UR'-anomaly for variable 'sp' (lines '133'-'136'). +src/net/sf/freecol/server/model/ServerGame.java:133: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:133: Parameter 'serverPlayers' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:134: Local variable 'live' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:135: Local variable 'sp' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:136: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:147: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerGame.java:147: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:147: Parameter 'serverPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:156: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerGame.java:156: Found 'UR'-anomaly for variable 's' (lines '156'-'157'). +src/net/sf/freecol/server/model/ServerGame.java:156: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:156: Parameter 'serverPlayers' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:157: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:157: Local variable 's' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:169: Avoid reassigning parameters such as 'type' +src/net/sf/freecol/server/model/ServerGame.java:169: Avoid unused private methods such as 'makeServerObject(String,String)'. +src/net/sf/freecol/server/model/ServerGame.java:169: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerGame.java:169: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:175: Avoid variables with short names like c +src/net/sf/freecol/server/model/ServerGame.java:175: Local variable 'c' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:176: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:185: Found 'UR'-anomaly for variable 'fcgo' (lines '185'-'188'). +src/net/sf/freecol/server/model/ServerGame.java:186: Local variable 'objs' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:187: Local variable 'fcgo' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:200: Found 'UR'-anomaly for variable 'sp' (lines '200'-'202'). +src/net/sf/freecol/server/model/ServerGame.java:200: Parameter 'players' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:201: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerGame.java:201: Local variable 'cs' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:202: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:202: Local variable 'sp' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:213: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerGame.java:213: Local variable 'id' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:223: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:224: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:235: Local variable 'winner' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:236: Avoid variables with short names like p +src/net/sf/freecol/server/model/ServerGame.java:237: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerGame.java:237: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:239: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:240: Local variable 'winners' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:240: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:240: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:240: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:241: Avoid variables with short names like p +src/net/sf/freecol/server/model/ServerGame.java:243: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerGame.java:243: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerGame.java:243: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:246: Local variable 'winners' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:247: Avoid variables with short names like p +src/net/sf/freecol/server/model/ServerGame.java:249: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerGame.java:249: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerGame.java:249: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:249: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:259: Local variable 'nextPlayer' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:270: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerGame.java:270: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:271: Found 'DD'-anomaly for variable 'duration' (lines '271'-'274'). +src/net/sf/freecol/server/model/ServerGame.java:272: Local variable 'now' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:279: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:279: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:280: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerGame.java:281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:282: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:282: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:293: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerGame.java:293: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerGame.java:293: Found 'UR'-anomaly for variable 'player' (lines '293'-'296'). +src/net/sf/freecol/server/model/ServerGame.java:293: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:293: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:293: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:295: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:296: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:300: Local variable 'succession' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:300: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:302: Avoid unused local variables such as 'loser'. +src/net/sf/freecol/server/model/ServerGame.java:302: Found 'DU'-anomaly for variable 'loser' (lines '302'-'307'). +src/net/sf/freecol/server/model/ServerGame.java:302: Local variable 'loser' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:309: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerGame.java:321: Avoid really long methods. +src/net/sf/freecol/server/model/ServerGame.java:321: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerGame.java:321: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerGame.java:321: Found 'UR'-anomaly for variable 'colony' (lines '321'-'389'). +src/net/sf/freecol/server/model/ServerGame.java:321: Found 'UR'-anomaly for variable 'entry' (lines '321'-'349'). +src/net/sf/freecol/server/model/ServerGame.java:321: Found 'UR'-anomaly for variable 'fcgo' (lines '321'-'440'). +src/net/sf/freecol/server/model/ServerGame.java:321: Found 'UR'-anomaly for variable 'is' (lines '321'-'375'). +src/net/sf/freecol/server/model/ServerGame.java:321: Found 'UR'-anomaly for variable 'player' (lines '321'-'334'). +src/net/sf/freecol/server/model/ServerGame.java:321: Found 'UR'-anomaly for variable 't' (lines '321'-'390'). +src/net/sf/freecol/server/model/ServerGame.java:321: Found 'UR'-anomaly for variable 'unit' (lines '321'-'400'). +src/net/sf/freecol/server/model/ServerGame.java:321: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:321: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:321: The method 'csSpanishSuccession' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/server/model/ServerGame.java:321: The method 'csSpanishSuccession' has a Modified Cyclomatic Complexity of 25. +src/net/sf/freecol/server/model/ServerGame.java:321: The method 'csSpanishSuccession' has a Standard Cyclomatic Complexity of 25. +src/net/sf/freecol/server/model/ServerGame.java:321: The method csSpanishSuccession() has an NPath complexity of 564480 +src/net/sf/freecol/server/model/ServerGame.java:322: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerGame.java:323: Local variable 'yearLimit' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:325: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerGame.java:325: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:327: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerGame.java:327: Found 'DU'-anomaly for variable 'weakLimit' (lines '327'-'448'). +src/net/sf/freecol/server/model/ServerGame.java:327: Local variable 'weakLimit' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:329: Local variable 'strongLimit' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:331: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/model/ServerGame.java:331: Local variable 'scores' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:333: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:334: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:335: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:342: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerGame.java:342: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:346: Found 'DD'-anomaly for variable 'weakestAIPlayer' (lines '346'-'353'). +src/net/sf/freecol/server/model/ServerGame.java:347: Found 'DD'-anomaly for variable 'strongestAIPlayer' (lines '347'-'357'). +src/net/sf/freecol/server/model/ServerGame.java:348: Local variable 'entry' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:349: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:350: Local variable 'score' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:351: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:352: Found 'DU'-anomaly for variable 'worstScore' (lines '352'-'448'). +src/net/sf/freecol/server/model/ServerGame.java:353: Found 'DD'-anomaly for variable 'weakestAIPlayer' (lines '353'-'353'). +src/net/sf/freecol/server/model/ServerGame.java:356: Found 'DU'-anomaly for variable 'bestScore' (lines '356'-'448'). +src/net/sf/freecol/server/model/ServerGame.java:357: Found 'DD'-anomaly for variable 'strongestAIPlayer' (lines '357'-'357'). +src/net/sf/freecol/server/model/ServerGame.java:360: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:362: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerGame.java:362: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerGame.java:365: Local variable 'entry' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:366: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:366: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:368: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:370: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:371: Local variable 'strongest' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:372: Local variable 'weakest' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:373: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:374: Local variable 'is' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:375: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:377: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:380: Local variable 'missionary' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:381: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:383: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:384: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:384: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:388: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:389: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:393: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:399: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:399: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:412: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:413: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerGame.java:413: Deeply nested if..then statements are hard to read +src/net/sf/freecol/server/model/ServerGame.java:418: Local variable 'loser' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:418: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:419: Local variable 'winner' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:419: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:435: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:436: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:439: Local variable 'fcgo' could be declared final +src/net/sf/freecol/server/model/ServerGame.java:441: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerGame.java:442: Avoid throwing raw exception types. +src/net/sf/freecol/server/model/ServerGame.java:442: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerGame.java:457: Avoid variables with short names like o +src/net/sf/freecol/server/model/ServerGame.java:457: Overriding method merely calls super +src/net/sf/freecol/server/model/ServerGame.java:457: Overriding method merely calls super +src/net/sf/freecol/server/model/ServerGame.java:457: Parameter 'o' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:20: Possible God class (WMC=59, ATFD=50, TCC=0.01098901098901099) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:53: The class 'ServerIndianSettlement' has a Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:54: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:56: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:56: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerIndianSettlement.java:59: Avoid excessively long variable names like ALARM_NEW_MISSIONARY +src/net/sf/freecol/server/model/ServerIndianSettlement.java:62: Avoid excessively long variable names like MAX_CONVERT_DISTANCE +src/net/sf/freecol/server/model/ServerIndianSettlement.java:64: Avoid excessively long variable names like MAX_HORSES_PER_TURN +src/net/sf/freecol/server/model/ServerIndianSettlement.java:64: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerIndianSettlement.java:70: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerIndianSettlement.java:70: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:70: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:74: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:86: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:86: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:86: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:87: Parameter 'isCapital' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:87: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:88: Parameter 'learnableSkill' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:89: Parameter 'missionary' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:109: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:109: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:109: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:110: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:116: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:117: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerIndianSettlement.java:117: Local variable 'newUnit' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:122: Local variable 'missionary' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:131: Local variable 'goods' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:132: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:145: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerIndianSettlement.java:145: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:145: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:146: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:146: Avoid unused local variables such as 'spec'. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:146: Found 'DU'-anomaly for variable 'spec' (lines '146'-'183'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:148: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerIndianSettlement.java:149: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:155: Local variable 'cMiss' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:155: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:158: Local variable 'alarm' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:158: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:159: Local variable 'cAlarm' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:162: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerIndianSettlement.java:165: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:167: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:177: Avoid variables with short names like ul +src/net/sf/freecol/server/model/ServerIndianSettlement.java:177: Local variable 'ul' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:178: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerIndianSettlement.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:179: Local variable 'brave' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:181: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:193: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:194: Local variable 'low' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:194: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:195: Local variable 'high' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:195: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:196: Local variable 'count' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:207: Parameter 'count' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:209: Found 'DU'-anomaly for variable 'game' (lines '209'-'218'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:210: Found 'DU'-anomaly for variable 'brave' (lines '210'-'218'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:213: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerIndianSettlement.java:213: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:214: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: Found 'UR'-anomaly for variable 'g' (lines '228'-'236'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: The method 'csNewTurn' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:228: The method csNewTurn() has an NPath complexity of 432 +src/net/sf/freecol/server/model/ServerIndianSettlement.java:230: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:231: Local variable 'spec' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:234: Local variable 'goodsList' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:235: Local variable 'g' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:240: Local variable 'g' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:245: Local variable 'storedFood' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:247: Local variable 'victim' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:256: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:259: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:264: Local variable 'foodType' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:264: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:265: Local variable 'rumType' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:265: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:266: Local variable 'unitTypes' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:267: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:269: Useless parentheses. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:269: Useless parentheses. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:271: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:276: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:278: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:292: Local variable 'horsesType' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:292: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:294: Local variable 'grainType' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:294: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:295: Local variable 'foodProdAvail' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:296: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:298: Local variable 'nHorses' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:303: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:315: Avoid reassigning parameters such as 'amount' +src/net/sf/freecol/server/model/ServerIndianSettlement.java:315: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:331: Parameter 'newAlarm' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:331: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:346: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:353: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:362: Found 'UR'-anomaly for variable 'p' (lines '362'-'367'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:363: Local variable 'old' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:364: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:365: Found 'DU'-anomaly for variable 'bestValue' (lines '365'-'377'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:366: Local variable 'p' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:366: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:367: Local variable 'alarm' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:368: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerIndianSettlement.java:369: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:370: Local variable 'value' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:370: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:372: Found 'DU'-anomaly for variable 'bestValue' (lines '372'-'377'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:379: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:389: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:389: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:395: Local variable 'oldLevel' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:397: Local variable 'change' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:398: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:401: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:415: Parameter 'add' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:415: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:415: Parameter 'propagate' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:416: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerIndianSettlement.java:416: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:417: Local variable 'change' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:420: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:421: Useless parentheses. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:421: Useless parentheses. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:423: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:423: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerIndianSettlement.java:426: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:430: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:444: Parameter 'add' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:444: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:444: Parameter 'propagate' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:445: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerIndianSettlement.java:445: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:446: Found 'DU'-anomaly for variable 'copied' (lines '446'-'453'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:446: Local variable 'copied' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:447: Local variable 'change' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:455: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:464: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerIndianSettlement.java:464: Found 'UR'-anomaly for variable 't' (lines '464'-'498'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:464: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:464: Parameter 'missionary' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:466: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerIndianSettlement.java:466: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:469: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerIndianSettlement.java:471: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:474: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:478: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:494: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:496: Local variable 'radius' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:497: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:497: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:498: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:498: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:502: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:502: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:503: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:514: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerIndianSettlement.java:514: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:514: Parameter 'destroy' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:515: Local variable 'missionary' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:516: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerIndianSettlement.java:520: Found 'DU'-anomaly for variable 'missionaryOwner' (lines '520'-'536'). +src/net/sf/freecol/server/model/ServerIndianSettlement.java:520: Local variable 'missionaryOwner' could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:520: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerIndianSettlement.java:538: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerIndianSettlement.java:548: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:548: Parameter 'roleCount' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:548: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:549: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerIndianSettlement.java:549: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:549: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerIndianSettlement.java:550: Local variable 'ret' could be declared final +src/net/sf/freecol/server/model/ServerModelObject.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerModelObject.java:34: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerModelObject.java:49: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/model/ServerModelObject.java:56: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/model/ServerModelObject.java:65: Avoid modifiers which are implied by the context +src/net/sf/freecol/server/model/ServerModelObject.java:65: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerModelObject.java:65: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerPlayer.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:20: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/model/ServerPlayer.java:20: Possible God class (WMC=714, ATFD=888, TCC=0.01632302405498282) +src/net/sf/freecol/server/model/ServerPlayer.java:20: This class has a bunch of public methods and attributes +src/net/sf/freecol/server/model/ServerPlayer.java:112: Avoid really long classes. +src/net/sf/freecol/server/model/ServerPlayer.java:112: The class 'ServerPlayer' has a Cyclomatic Complexity of 7 (Highest = 113). +src/net/sf/freecol/server/model/ServerPlayer.java:112: The class 'ServerPlayer' has a Modified Cyclomatic Complexity of 6 (Highest = 80). +src/net/sf/freecol/server/model/ServerPlayer.java:112: The class 'ServerPlayer' has a Standard Cyclomatic Complexity of 6 (Highest = 105). +src/net/sf/freecol/server/model/ServerPlayer.java:112: The type has an NCSS line count of 2155 +src/net/sf/freecol/server/model/ServerPlayer.java:112: This class has too many methods, consider refactoring it. +src/net/sf/freecol/server/model/ServerPlayer.java:114: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerPlayer.java:114: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:117: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:118: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:121: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:122: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:123: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:126: Avoid excessively long variable names like SCORE_SETTLEMENT_DESTROYED +src/net/sf/freecol/server/model/ServerPlayer.java:126: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:129: Avoid excessively long variable names like SCORE_NATION_DESTROYED +src/net/sf/freecol/server/model/ServerPlayer.java:129: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:132: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:135: Avoid excessively long variable names like SCORE_FOUNDING_FATHER +src/net/sf/freecol/server/model/ServerPlayer.java:135: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:139: Avoid excessively long variable names like SCORE_INDEPENDENCE_BONUS_FIRST +src/net/sf/freecol/server/model/ServerPlayer.java:139: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:140: Avoid excessively long variable names like SCORE_INDEPENDENCE_BONUS_SECOND +src/net/sf/freecol/server/model/ServerPlayer.java:140: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:141: Avoid excessively long variable names like SCORE_INDEPENDENCE_BONUS_THIRD +src/net/sf/freecol/server/model/ServerPlayer.java:141: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:144: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/ServerPlayer.java:149: Avoid using redundant field initializer for 'connected' +src/net/sf/freecol/server/model/ServerPlayer.java:149: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:152: Avoid excessively long variable names like remainingEmigrants +src/net/sf/freecol/server/model/ServerPlayer.java:152: Avoid using redundant field initializer for 'remainingEmigrants' +src/net/sf/freecol/server/model/ServerPlayer.java:155: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/ServerPlayer.java:158: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/ServerPlayer.java:164: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerPlayer.java:164: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:164: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:168: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:177: Parameter 'admin' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:177: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:177: Parameter 'nation' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:178: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:178: Parameter 'socket' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:181: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:189: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:191: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:192: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:195: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:199: A catch statement should never catch throwable since it includes errors. +src/net/sf/freecol/server/model/ServerPlayer.java:200: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/server/model/ServerPlayer.java:210: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:210: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:233: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:257: Parameter 'connected' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:283: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:285: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:285: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:293: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:293: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:303: Avoid reassigning parameters such as 'request' +src/net/sf/freecol/server/model/ServerPlayer.java:304: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:310: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:312: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:320: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:332: Avoid variables with short names like ff +src/net/sf/freecol/server/model/ServerPlayer.java:332: Parameter 'ff' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:336: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:336: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:337: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:346: Avoid variables with short names like ag +src/net/sf/freecol/server/model/ServerPlayer.java:346: Parameter 'ag' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:355: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:357: Avoid variables with short names like ag +src/net/sf/freecol/server/model/ServerPlayer.java:357: Local variable 'ag' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:367: Found 'UR'-anomaly for variable 'type' (lines '367'-'387'). +src/net/sf/freecol/server/model/ServerPlayer.java:367: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:367: The method 'randomizeGame' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerPlayer.java:368: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:369: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:372: Avoid variables with short names like i0 +src/net/sf/freecol/server/model/ServerPlayer.java:372: Local variable 'i0' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:372: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:377: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:380: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:383: Found 'DU'-anomaly for variable 'market' (lines '383'-'414'). +src/net/sf/freecol/server/model/ServerPlayer.java:383: Local variable 'market' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:384: Avoid variables with short names like sb +src/net/sf/freecol/server/model/ServerPlayer.java:384: Found 'DU'-anomaly for variable 'sb' (lines '384'-'414'). +src/net/sf/freecol/server/model/ServerPlayer.java:384: Local variable 'sb' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:385: Found 'DD'-anomaly for variable 'changed' (lines '385'-'406'). +src/net/sf/freecol/server/model/ServerPlayer.java:386: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:387: Local variable 'prefix' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:388: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:390: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:392: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:393: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:395: Local variable 'bad' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:398: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:399: Local variable 'add' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:401: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:402: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:403: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:405: The String literal " -> " appears 6 times in this file; the first occurrence is on line 405 +src/net/sf/freecol/server/model/ServerPlayer.java:406: Found 'DD'-anomaly for variable 'changed' (lines '406'-'406'). +src/net/sf/freecol/server/model/ServerPlayer.java:411: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:411: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:423: Avoid really long methods. +src/net/sf/freecol/server/model/ServerPlayer.java:423: Found 'UR'-anomaly for variable 'type' (lines '423'-'523'). +src/net/sf/freecol/server/model/ServerPlayer.java:423: Found 'UR'-anomaly for variable 'unit' (lines '423'-'469'). +src/net/sf/freecol/server/model/ServerPlayer.java:423: The method 'checkForDeath' has a Cyclomatic Complexity of 40. +src/net/sf/freecol/server/model/ServerPlayer.java:423: The method 'checkForDeath' has a Modified Cyclomatic Complexity of 30. +src/net/sf/freecol/server/model/ServerPlayer.java:423: The method 'checkForDeath' has a Standard Cyclomatic Complexity of 34. +src/net/sf/freecol/server/model/ServerPlayer.java:423: The method checkForDeath() has an NPath complexity of 104288256 +src/net/sf/freecol/server/model/ServerPlayer.java:424: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:424: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:425: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:425: Found 'DU'-anomaly for variable 'spec' (lines '425'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:425: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:435: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:435: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:435: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:435: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:435: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:443: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:443: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:443: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:446: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:446: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:446: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:449: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:449: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:449: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:456: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:456: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:456: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:459: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:459: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:462: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:462: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:466: Found 'DD'-anomaly for variable 'hasCarrier' (lines '466'-'471'). +src/net/sf/freecol/server/model/ServerPlayer.java:466: Found 'DD'-anomaly for variable 'hasColonist' (lines '466'-'477'). +src/net/sf/freecol/server/model/ServerPlayer.java:466: Found 'DD'-anomaly for variable 'hasEmbarked' (lines '466'-'487'). +src/net/sf/freecol/server/model/ServerPlayer.java:466: Found 'DU'-anomaly for variable 'hasEmbarked' (lines '466'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:466: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/model/ServerPlayer.java:467: Found 'DD'-anomaly for variable 'hasGoods' (lines '467'-'470'). +src/net/sf/freecol/server/model/ServerPlayer.java:468: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:470: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:470: Found 'DD'-anomaly for variable 'hasGoods' (lines '470'-'470'). +src/net/sf/freecol/server/model/ServerPlayer.java:470: Found 'DU'-anomaly for variable 'hasGoods' (lines '470'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:470: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:471: Found 'DD'-anomaly for variable 'hasCarrier' (lines '471'-'471'). +src/net/sf/freecol/server/model/ServerPlayer.java:471: Found 'DU'-anomaly for variable 'hasCarrier' (lines '471'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:476: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:477: Found 'DD'-anomaly for variable 'hasColonist' (lines '477'-'477'). +src/net/sf/freecol/server/model/ServerPlayer.java:477: Found 'DU'-anomaly for variable 'hasColonist' (lines '477'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:481: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerPlayer.java:481: Found 'DU'-anomaly for variable 'carrier' (lines '481'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:481: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:482: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:483: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:483: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:485: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:487: Found 'DD'-anomaly for variable 'hasEmbarked' (lines '487'-'487'). +src/net/sf/freecol/server/model/ServerPlayer.java:487: Found 'DU'-anomaly for variable 'hasEmbarked' (lines '487'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:489: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:490: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:490: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:490: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:492: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:497: Local variable 'mandatory' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:497: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:498: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:501: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:501: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:502: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:508: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:508: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:509: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:511: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:511: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:512: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:516: Found 'DU'-anomaly for variable 'europe' (lines '516'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:517: Found 'DU'-anomaly for variable 'goldNeeded' (lines '517'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:521: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:522: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:523: Avoid variables with short names like p +src/net/sf/freecol/server/model/ServerPlayer.java:523: Local variable 'p' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:523: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:524: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:528: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:528: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:529: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:536: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:536: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:537: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:539: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:539: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:540: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:542: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:542: Avoid unused local variables such as 'unitType'. +src/net/sf/freecol/server/model/ServerPlayer.java:542: Found 'DU'-anomaly for variable 'unitType' (lines '542'-'558'). +src/net/sf/freecol/server/model/ServerPlayer.java:542: Local variable 'unitType' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:543: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:544: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:545: Avoid variables with short names like p +src/net/sf/freecol/server/model/ServerPlayer.java:545: Local variable 'p' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:545: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:546: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:550: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:550: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:551: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:556: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:556: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:565: Found 'UR'-anomaly for variable 'rebel' (lines '565'-'598'). +src/net/sf/freecol/server/model/ServerPlayer.java:565: Found 'UR'-anomaly for variable 'u' (lines '565'-'585'). +src/net/sf/freecol/server/model/ServerPlayer.java:565: The method 'checkForREFDefeat' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerPlayer.java:565: The method 'checkForREFDefeat' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/model/ServerPlayer.java:565: The method 'checkForREFDefeat' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/server/model/ServerPlayer.java:565: The method checkForREFDefeat() has an NPath complexity of 384 +src/net/sf/freecol/server/model/ServerPlayer.java:573: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:573: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:573: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:576: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:576: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:576: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:579: Avoid excessively long variable names like landREFUnitsRequired +src/net/sf/freecol/server/model/ServerPlayer.java:579: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/model/ServerPlayer.java:580: Avoid variables with short names like cm +src/net/sf/freecol/server/model/ServerPlayer.java:580: Found 'DU'-anomaly for variable 'cm' (lines '580'-'606'). +src/net/sf/freecol/server/model/ServerPlayer.java:580: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:581: Found 'DD'-anomaly for variable 'naval' (lines '581'-'585'). +src/net/sf/freecol/server/model/ServerPlayer.java:582: Found 'DD'-anomaly for variable 'land' (lines '582'-'587'). +src/net/sf/freecol/server/model/ServerPlayer.java:583: Found 'DU'-anomaly for variable 'power' (lines '583'-'606'). +src/net/sf/freecol/server/model/ServerPlayer.java:584: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:585: Avoid using if...else statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:585: Found 'DD'-anomaly for variable 'naval' (lines '585'-'585'). +src/net/sf/freecol/server/model/ServerPlayer.java:585: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:586: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:587: Found 'DD'-anomaly for variable 'land' (lines '587'-'587'). +src/net/sf/freecol/server/model/ServerPlayer.java:588: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:592: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:592: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:597: Local variable 'rebel' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:598: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:599: Avoid variables with short names like u +src/net/sf/freecol/server/model/ServerPlayer.java:600: Avoid variables with short names like u +src/net/sf/freecol/server/model/ServerPlayer.java:600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:602: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:602: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:616: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:616: Found 'UR'-anomaly for variable 'other' (lines '616'-'623'). +src/net/sf/freecol/server/model/ServerPlayer.java:616: Found 'UR'-anomaly for variable 's' (lines '616'-'625'). +src/net/sf/freecol/server/model/ServerPlayer.java:616: Found 'UR'-anomaly for variable 'tile' (lines '616'-'644'). +src/net/sf/freecol/server/model/ServerPlayer.java:616: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:616: The method 'csKill' has a Cyclomatic Complexity of 18. +src/net/sf/freecol/server/model/ServerPlayer.java:616: The method 'csKill' has a Modified Cyclomatic Complexity of 17. +src/net/sf/freecol/server/model/ServerPlayer.java:616: The method 'csKill' has a Standard Cyclomatic Complexity of 17. +src/net/sf/freecol/server/model/ServerPlayer.java:616: The method csKill() has an NPath complexity of 13824 +src/net/sf/freecol/server/model/ServerPlayer.java:622: Local variable 'other' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:622: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:624: Local variable 's' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:624: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:625: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:626: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:628: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:628: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:629: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:631: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:633: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:637: Local variable 'settlements' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:639: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:643: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:643: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:643: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:644: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:645: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:646: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:647: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:647: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:652: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:653: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:654: Avoid variables with short names like u +src/net/sf/freecol/server/model/ServerPlayer.java:654: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:654: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:655: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:655: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:655: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:656: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:656: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:657: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:658: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:664: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:668: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:672: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:674: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:675: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:676: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:678: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:681: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:681: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:692: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:692: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:695: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:695: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:699: The String literal "%nation%" appears 38 times in this file; the first occurrence is on line 699 +src/net/sf/freecol/server/model/ServerPlayer.java:700: Local variable 'game' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:702: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:709: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:713: Parameter 'emigrants' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:713: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:723: Found 'DD'-anomaly for variable 'father' (lines '723'-'730'). +src/net/sf/freecol/server/model/ServerPlayer.java:725: Local variable 'extraLiberty' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:727: Local variable 'overflow' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:727: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:729: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:729: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:731: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:743: Found 'DU'-anomaly for variable 'spec' (lines '743'-'756'). +src/net/sf/freecol/server/model/ServerPlayer.java:743: Local variable 'spec' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:743: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:748: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:748: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:748: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:751: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:754: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:755: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:755: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:765: Found 'UR'-anomaly for variable 'father' (lines '765'-'773'). +src/net/sf/freecol/server/model/ServerPlayer.java:765: Found 'UR'-anomaly for variable 'type' (lines '765'-'788'). +src/net/sf/freecol/server/model/ServerPlayer.java:765: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:769: Found 'DU'-anomaly for variable 'age' (lines '769'-'800'). +src/net/sf/freecol/server/model/ServerPlayer.java:770: Found 'DU'-anomaly for variable 'choices' (lines '770'-'800'). +src/net/sf/freecol/server/model/ServerPlayer.java:770: Local variable 'choices' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:772: Local variable 'father' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:774: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:775: Avoid variables with short names like rc +src/net/sf/freecol/server/model/ServerPlayer.java:776: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:776: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:777: Local variable 'weight' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:778: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:784: Local variable 'randomFathers' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:785: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerPlayer.java:785: Local variable 'lb' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:787: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:788: Avoid variables with short names like rc +src/net/sf/freecol/server/model/ServerPlayer.java:788: Local variable 'rc' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:790: Avoid variables with short names like f +src/net/sf/freecol/server/model/ServerPlayer.java:790: Local variable 'f' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:794: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:808: Parameter 'event' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:812: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:829: Found 'UR'-anomaly for variable 'h' (lines '829'-'843'). +src/net/sf/freecol/server/model/ServerPlayer.java:830: Local variable 'oldScore' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:831: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:832: Avoid variables with short names like u +src/net/sf/freecol/server/model/ServerPlayer.java:832: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:832: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:833: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:833: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:833: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:834: Avoid variables with short names like c +src/net/sf/freecol/server/model/ServerPlayer.java:835: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:836: Local variable 'gold' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:841: Found 'DD'-anomaly for variable 'bonus' (lines '841'-'847'). +src/net/sf/freecol/server/model/ServerPlayer.java:841: Found 'DD'-anomaly for variable 'bonus' (lines '841'-'848'). +src/net/sf/freecol/server/model/ServerPlayer.java:841: Found 'DD'-anomaly for variable 'bonus' (lines '841'-'849'). +src/net/sf/freecol/server/model/ServerPlayer.java:841: Found 'DD'-anomaly for variable 'bonus' (lines '841'-'850'). +src/net/sf/freecol/server/model/ServerPlayer.java:842: Local variable 'h' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:843: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:843: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:844: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:846: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:854: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:873: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:885: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:886: Local variable 'ret' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:887: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:899: Found 'UR'-anomaly for variable 't' (lines '899'-'902'). +src/net/sf/freecol/server/model/ServerPlayer.java:899: Parameter 'tiles' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:900: Local variable 'result' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:901: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:902: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:915: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:916: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:917: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:930: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:931: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:931: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:931: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:933: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:934: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:934: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:944: Found 'UR'-anomaly for variable 's' (lines '944'-'954'). +src/net/sf/freecol/server/model/ServerPlayer.java:944: Found 'UR'-anomaly for variable 'tile' (lines '944'-'947'). +src/net/sf/freecol/server/model/ServerPlayer.java:944: Found 'UR'-anomaly for variable 'u' (lines '944'-'955'). +src/net/sf/freecol/server/model/ServerPlayer.java:944: Parameter 'reveal' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:945: Local variable 'result' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:946: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:946: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:946: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:954: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:954: Local variable 's' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:955: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:955: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:960: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:971: Found 'UR'-anomaly for variable 'e' (lines '971'-'1,025'). +src/net/sf/freecol/server/model/ServerPlayer.java:971: Found 'UR'-anomaly for variable 'entry' (lines '971'-'1,011'). +src/net/sf/freecol/server/model/ServerPlayer.java:971: Found 'UR'-anomaly for variable 't' (lines '971'-'981'). +src/net/sf/freecol/server/model/ServerPlayer.java:971: Found 'UR'-anomaly for variable 'tile' (lines '971'-'978'). +src/net/sf/freecol/server/model/ServerPlayer.java:971: Parameter 'tiles' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:971: The method 'reassignTiles' has a Cyclomatic Complexity of 21. +src/net/sf/freecol/server/model/ServerPlayer.java:971: The method 'reassignTiles' has a Modified Cyclomatic Complexity of 15. +src/net/sf/freecol/server/model/ServerPlayer.java:971: The method 'reassignTiles' has a Standard Cyclomatic Complexity of 15. +src/net/sf/freecol/server/model/ServerPlayer.java:971: The method reassignTiles() has an NPath complexity of 2973 +src/net/sf/freecol/server/model/ServerPlayer.java:972: Parameter 'prefer' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:973: Parameter 'avoid' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:974: Local variable 'votes' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:975: Local variable 'claims' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:977: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:978: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:978: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:979: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:980: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:980: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:981: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:986: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:987: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:988: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:988: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:989: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:989: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:989: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:989: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:989: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:990: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:990: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:991: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:997: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:997: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:998: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:998: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:998: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:998: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1001: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1002: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1004: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1007: Found 'DD'-anomaly for variable 'lastResort' (lines '1,007'-'1,012'). +src/net/sf/freecol/server/model/ServerPlayer.java:1008: Found 'DU'-anomaly for variable 'bestValue' (lines '1,008'-'1,033'). +src/net/sf/freecol/server/model/ServerPlayer.java:1009: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:1009: Found 'DD'-anomaly for variable 'claimant' (lines '1,009'-'1,018'). +src/net/sf/freecol/server/model/ServerPlayer.java:1010: Local variable 'entry' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1010: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1012: Found 'DD'-anomaly for variable 'lastResort' (lines '1,012'-'1,012'). +src/net/sf/freecol/server/model/ServerPlayer.java:1015: Local variable 'value' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1015: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1017: Found 'DD'-anomaly for variable 'bestValue' (lines '1,017'-'1,008'). +src/net/sf/freecol/server/model/ServerPlayer.java:1017: Found 'DU'-anomaly for variable 'bestValue' (lines '1,017'-'1,033'). +src/net/sf/freecol/server/model/ServerPlayer.java:1018: Found 'DD'-anomaly for variable 'claimant' (lines '1,018'-'1,018'). +src/net/sf/freecol/server/model/ServerPlayer.java:1018: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1021: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1022: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1024: Local variable 'e' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1024: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1025: Avoid variables with short names like t +src/net/sf/freecol/server/model/ServerPlayer.java:1025: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1025: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1026: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerPlayer.java:1026: Found 'DD'-anomaly for variable 'claimant' (lines '1,026'-'1,026'). +src/net/sf/freecol/server/model/ServerPlayer.java:1026: Found 'DU'-anomaly for variable 'claimant' (lines '1,026'-'1,033'). +src/net/sf/freecol/server/model/ServerPlayer.java:1026: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1027: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1029: Local variable 'newOwner' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1029: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1030: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1035: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1048: Found 'UR'-anomaly for variable 'au' (lines '1,048'-'1,056'). +src/net/sf/freecol/server/model/ServerPlayer.java:1048: Parameter 'abstractUnits' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1048: The method 'createUnits' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerPlayer.java:1048: The method 'createUnits' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/server/model/ServerPlayer.java:1048: The method 'createUnits' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerPlayer.java:1049: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1050: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:1050: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1050: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1051: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1054: Found 'DU'-anomaly for variable 'spec' (lines '1,054'-'1,099'). +src/net/sf/freecol/server/model/ServerPlayer.java:1054: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1055: Local variable 'au' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1056: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1056: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1057: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1068: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1069: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/server/model/ServerPlayer.java:1069: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1069: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1069: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1069: Switch statements should have a default label +src/net/sf/freecol/server/model/ServerPlayer.java:1069: These nested if statements could be combined +src/net/sf/freecol/server/model/ServerPlayer.java:1071: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1074: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1079: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1080: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1084: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1085: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1092: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1093: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1093: Avoid variables with short names like su +src/net/sf/freecol/server/model/ServerPlayer.java:1093: Local variable 'su' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1095: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1101: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1119: Found 'UR'-anomaly for variable 'carrier' (lines '1,119'-'1,129'). +src/net/sf/freecol/server/model/ServerPlayer.java:1119: Found 'UR'-anomaly for variable 'unit' (lines '1,119'-'1,129'). +src/net/sf/freecol/server/model/ServerPlayer.java:1119: Found 'UR'-anomaly for variable 'unit' (lines '1,119'-'1,135'). +src/net/sf/freecol/server/model/ServerPlayer.java:1119: Parameter 'landUnits' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1120: Parameter 'navalUnits' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1121: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1122: Local variable 'leftOver' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1125: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerPlayer.java:1125: Local variable 'lb' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1127: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1128: Local variable 'carrier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1150: Parameter 'mercenaries' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1152: Avoid variables with short names like au +src/net/sf/freecol/server/model/ServerPlayer.java:1153: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1163: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1163: Found 'UR'-anomaly for variable 'type' (lines '1,163'-'1,170'). +src/net/sf/freecol/server/model/ServerPlayer.java:1163: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1164: Local variable 'market' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1165: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:1165: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1166: Found 'DD'-anomaly for variable 'ret' (lines '1,166'-'1,172'). +src/net/sf/freecol/server/model/ServerPlayer.java:1167: Avoid variables with short names like sb +src/net/sf/freecol/server/model/ServerPlayer.java:1167: Local variable 'sb' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1168: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:1168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1169: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1169: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1171: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:1171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1172: Found 'DD'-anomaly for variable 'ret' (lines '1,172'-'1,172'). +src/net/sf/freecol/server/model/ServerPlayer.java:1175: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1186: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1186: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1186: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1188: Local variable 'ret' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1188: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1194: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1200: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1209: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1209: Parameter 'container' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1209: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1211: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1212: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:1212: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1215: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1216: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1217: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1219: Local variable 'marketAmount' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1219: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1220: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1225: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1234: Parameter 'amount' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1234: Parameter 'container' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1234: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1241: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1242: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1245: Local variable 'marketAmount' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1245: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1246: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1247: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1256: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1257: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1260: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1269: Parameter 'otherPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1269: Parameter 'stance' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1270: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1270: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1270: Parameter 'symmetric' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1271: Found 'DU'-anomaly for variable 'other' (lines '1,271'-'1,322'). +src/net/sf/freecol/server/model/ServerPlayer.java:1271: Local variable 'other' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1272: Found 'DD'-anomaly for variable 'change' (lines '1,272'-'1,295'). +src/net/sf/freecol/server/model/ServerPlayer.java:1272: Found 'DD'-anomaly for variable 'change' (lines '1,272'-'1,318'). +src/net/sf/freecol/server/model/ServerPlayer.java:1276: Local variable 'modifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1276: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1281: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1284: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1284: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1295: Found 'DD'-anomaly for variable 'change' (lines '1,295'-'1,318'). +src/net/sf/freecol/server/model/ServerPlayer.java:1297: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerPlayer.java:1297: Found 'DU'-anomaly for variable 'old' (lines '1,297'-'1,322'). +src/net/sf/freecol/server/model/ServerPlayer.java:1298: Local variable 'modifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1298: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1303: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1306: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1306: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1309: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1324: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1333: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1333: Parameter 'add' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1333: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1333: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1337: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1348: Found 'UR'-anomaly for variable 'is' (lines '1,348'-'1,360'). +src/net/sf/freecol/server/model/ServerPlayer.java:1348: Parameter 'add' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1348: Parameter 'origin' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1348: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1349: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1349: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1350: Local variable 'oldLevel' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1350: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1351: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1359: Local variable 'is' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1360: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1360: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerPlayer.java:1361: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Avoid really long methods. +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Found 'UR'-anomaly for variable 'p' (lines '1,375'-'1,495'). +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Found 'UR'-anomaly for variable 'settlement' (lines '1,375'-'1,382'). +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Found 'UR'-anomaly for variable 'unit' (lines '1,375'-'1,410'). +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1375: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1375: The method 'csNewTurn' has a Cyclomatic Complexity of 27. +src/net/sf/freecol/server/model/ServerPlayer.java:1375: The method 'csNewTurn' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/server/model/ServerPlayer.java:1375: The method 'csNewTurn' has a Standard Cyclomatic Complexity of 22. +src/net/sf/freecol/server/model/ServerPlayer.java:1375: The method csNewTurn() has an NPath complexity of 219996 +src/net/sf/freecol/server/model/ServerPlayer.java:1379: Local variable 'settlements' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1380: Found 'DD'-anomaly for variable 'newImmigration' (lines '1,380'-'1,385'). +src/net/sf/freecol/server/model/ServerPlayer.java:1380: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/model/ServerPlayer.java:1381: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1382: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1383: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1387: Local variable 'numberOfColonies' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1393: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:1393: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:1404: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1408: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1410: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1412: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1428: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1432: Local variable 'probability' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1432: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1438: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1442: Local variable 'ports' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1443: Local variable 'port' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1445: Local variable 'portTile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1445: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1446: Local variable 'entry' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1446: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1455: Found 'DD'-anomaly for variable 'ivf' (lines '1,455'-'1,456'). +src/net/sf/freecol/server/model/ServerPlayer.java:1456: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerPlayer.java:1458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1458: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1459: Local variable 'landUnits' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1459: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1461: Local variable 'navalUnits' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1461: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1463: Local variable 'leftOver' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1465: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1467: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1471: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1471: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1472: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1472: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1472: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1479: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1479: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1480: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1481: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1482: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1483: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1490: Avoid variables with short names like s +src/net/sf/freecol/server/model/ServerPlayer.java:1490: Local variable 's' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1491: Local variable 'sta' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1492: Found 'DD'-anomaly for variable 'war' (lines '1,492'-'1,492'). +src/net/sf/freecol/server/model/ServerPlayer.java:1492: Found 'DU'-anomaly for variable 'war' (lines '1,492'-'1,509'). +src/net/sf/freecol/server/model/ServerPlayer.java:1492: Local variable 'war' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1493: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1494: Local variable 'p' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1494: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1495: Avoid variables with short names like sp +src/net/sf/freecol/server/model/ServerPlayer.java:1495: Found 'DD'-anomaly for variable 'sp' (lines '1,495'-'1,495'). +src/net/sf/freecol/server/model/ServerPlayer.java:1495: Found 'DU'-anomaly for variable 'sp' (lines '1,495'-'1,509'). +src/net/sf/freecol/server/model/ServerPlayer.java:1495: Local variable 'sp' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1496: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1496: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerPlayer.java:1502: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1503: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1505: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1511: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1511: Found 'UR'-anomaly for variable 'effect' (lines '1,511'-'1,526'). +src/net/sf/freecol/server/model/ServerPlayer.java:1511: Found 'UR'-anomaly for variable 'modifier' (lines '1,511'-'1,527'). +src/net/sf/freecol/server/model/ServerPlayer.java:1511: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1511: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1511: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:1513: Found 'DU'-anomaly for variable 'bankruptcy' (lines '1,513'-'1,547'). +src/net/sf/freecol/server/model/ServerPlayer.java:1513: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1515: Found 'DD'-anomaly for variable 'changed' (lines '1,515'-'1,522'). +src/net/sf/freecol/server/model/ServerPlayer.java:1515: Found 'DD'-anomaly for variable 'changed' (lines '1,515'-'1,538'). +src/net/sf/freecol/server/model/ServerPlayer.java:1516: Local variable 'upkeep' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1516: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1517: Avoid variables with short names like s +src/net/sf/freecol/server/model/ServerPlayer.java:1525: Local variable 'effect' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1525: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1526: Local variable 'modifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1526: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1526: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1545: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1545: The String literal "gold" appears 10 times in this file; the first occurrence is on line 1,545 +src/net/sf/freecol/server/model/ServerPlayer.java:1546: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1549: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1549: Found 'UR'-anomaly for variable 'message' (lines '1,549'-'1,574'). +src/net/sf/freecol/server/model/ServerPlayer.java:1549: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1549: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1549: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:1550: Parameter 'probability' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1552: Local variable 'size' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1553: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:1553: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerPlayer.java:1553: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1557: Found 'DU'-anomaly for variable 'start' (lines '1,557'-'1,581'). +src/net/sf/freecol/server/model/ServerPlayer.java:1557: Local variable 'start' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1559: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1559: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1560: Local variable 'disasters' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1562: Local variable 'disaster' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1565: Local variable 'messages' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1567: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1569: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1571: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1571: The String literal "%colony%" appears 22 times in this file; the first occurrence is on line 1,571 +src/net/sf/freecol/server/model/ServerPlayer.java:1573: Local variable 'message' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1583: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:1597: Avoid really long methods. +src/net/sf/freecol/server/model/ServerPlayer.java:1597: Found 'UR'-anomaly for variable 'effect' (lines '1,597'-'1,635'). +src/net/sf/freecol/server/model/ServerPlayer.java:1597: Found 'UR'-anomaly for variable 'modifier' (lines '1,597'-'1,636'). +src/net/sf/freecol/server/model/ServerPlayer.java:1597: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1597: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1597: The method 'csApplyDisaster' has a Cyclomatic Complexity of 29. +src/net/sf/freecol/server/model/ServerPlayer.java:1597: The method 'csApplyDisaster' has a Modified Cyclomatic Complexity of 22. +src/net/sf/freecol/server/model/ServerPlayer.java:1597: The method 'csApplyDisaster' has a Standard Cyclomatic Complexity of 28. +src/net/sf/freecol/server/model/ServerPlayer.java:1597: The method csApplyDisaster() has an NCSS line count of 106 +src/net/sf/freecol/server/model/ServerPlayer.java:1597: The method csApplyDisaster() has an NPath complexity of 960 +src/net/sf/freecol/server/model/ServerPlayer.java:1598: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1598: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1598: Parameter 'disaster' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1599: Avoid variables with short names like sb +src/net/sf/freecol/server/model/ServerPlayer.java:1599: Local variable 'sb' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1600: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1603: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1603: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1604: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:1604: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1605: Local variable 'effects' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1606: A switch statement does not contain a break +src/net/sf/freecol/server/model/ServerPlayer.java:1606: Switch statements should have a default label +src/net/sf/freecol/server/model/ServerPlayer.java:1608: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1610: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:1610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1610: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1613: Local variable 'effect' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1615: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1616: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1616: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1617: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:1617: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1617: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1622: Local variable 'effect' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1623: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1624: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:1624: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1624: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1627: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1628: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1630: Found 'DD'-anomaly for variable 'colonyDirty' (lines '1,630'-'1,664'). +src/net/sf/freecol/server/model/ServerPlayer.java:1630: Found 'DD'-anomaly for variable 'colonyDirty' (lines '1,630'-'1,677'). +src/net/sf/freecol/server/model/ServerPlayer.java:1630: Found 'DD'-anomaly for variable 'colonyDirty' (lines '1,630'-'1,690'). +src/net/sf/freecol/server/model/ServerPlayer.java:1630: Found 'DD'-anomaly for variable 'colonyDirty' (lines '1,630'-'1,698'). +src/net/sf/freecol/server/model/ServerPlayer.java:1631: Local variable 'messages' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1633: Local variable 'effect' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1635: Local variable 'modifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1635: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1636: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1637: Local variable 'timedModifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1637: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1638: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1638: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1639: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1646: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1647: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1649: Local variable 'plunder' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1652: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1653: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1654: The String literal "%amount%" appears 10 times in this file; the first occurrence is on line 1,654 +src/net/sf/freecol/server/model/ServerPlayer.java:1657: Local variable 'building' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1660: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1661: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1668: Local variable 'goods' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1672: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1674: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1675: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1676: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1682: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1684: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerPlayer.java:1685: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1686: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1693: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1694: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1695: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1695: The String literal "%unit%" appears 30 times in this file; the first occurrence is on line 1,695 +src/net/sf/freecol/server/model/ServerPlayer.java:1697: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1704: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1705: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1706: Local variable 'repairLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1708: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1709: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1710: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1713: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1714: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1715: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1723: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1724: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1725: Local variable 'modifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1725: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1726: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1727: Local variable 'timedModifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1727: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1728: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1728: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1729: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1741: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1745: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1745: Parameter 'effect' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1745: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1745: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:1746: Local variable 'buildings' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1747: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:1747: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1747: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1752: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1752: Parameter 'effect' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1752: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1752: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/ServerPlayer.java:1753: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1754: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1759: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1759: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1764: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:1764: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1775: Avoid reassigning parameters such as 'amount' +src/net/sf/freecol/server/model/ServerPlayer.java:1775: Avoid reassigning parameters such as 'amount' +src/net/sf/freecol/server/model/ServerPlayer.java:1775: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1776: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1777: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:1777: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1780: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/model/ServerPlayer.java:1781: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/model/ServerPlayer.java:1785: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1789: Local variable 'p' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1789: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1790: Local variable 'market' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1791: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1791: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1803: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1803: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1803: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1805: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1805: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1812: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerPlayer.java:1812: Avoid using while statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1813: Avoid empty while statements +src/net/sf/freecol/server/model/ServerPlayer.java:1813: Avoid empty while statements +src/net/sf/freecol/server/model/ServerPlayer.java:1816: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1817: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1818: Local variable 'add' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1818: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1819: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1820: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1820: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1821: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1821: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerPlayer.java:1822: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1825: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1826: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1827: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:1829: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1830: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1831: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1845: Avoid really long methods. +src/net/sf/freecol/server/model/ServerPlayer.java:1845: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:1845: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1845: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1845: The method 'csStartTurn' has a Cyclomatic Complexity of 39. +src/net/sf/freecol/server/model/ServerPlayer.java:1845: The method 'csStartTurn' has a Modified Cyclomatic Complexity of 32. +src/net/sf/freecol/server/model/ServerPlayer.java:1845: The method 'csStartTurn' has a Standard Cyclomatic Complexity of 32. +src/net/sf/freecol/server/model/ServerPlayer.java:1845: The method csStartTurn() has an NPath complexity of 1382917 +src/net/sf/freecol/server/model/ServerPlayer.java:1846: Local variable 'game' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1852: Local variable 'father' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1859: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1863: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1882: Local variable 'allSettlements' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1883: Local variable 'oldLevels' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1885: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1886: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1886: Local variable 'oldLevel' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1887: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1888: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1888: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1889: Local variable 'alarm' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1890: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1891: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:1891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1896: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1897: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1897: Local variable 'extra' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1898: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1898: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1899: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1903: Local variable 'alarmRadius' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1904: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1904: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1906: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1906: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1907: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:1907: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1908: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1908: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1908: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1909: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1910: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1911: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1912: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1912: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1912: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1912: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1912: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1912: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1913: Avoid variables with short names like u +src/net/sf/freecol/server/model/ServerPlayer.java:1914: Avoid variables with short names like u +src/net/sf/freecol/server/model/ServerPlayer.java:1914: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1914: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1915: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1917: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:1918: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1918: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1919: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1919: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1921: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1922: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1923: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1923: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1923: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1924: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1925: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1925: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1932: Local variable 'missionary' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1933: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1933: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1935: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1938: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1938: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1939: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1940: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1943: Local variable 'entry' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1943: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1944: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1947: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1948: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1949: Local variable 'sis' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1951: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1958: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1958: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1959: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1960: Local variable 'change' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1960: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1968: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1969: Local variable 'oldLevel' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1970: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1971: Local variable 'entry' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1971: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1972: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1973: Local variable 'newTension' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1974: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:1974: Local variable 'newLevel' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1975: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1976: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1979: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1981: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1981: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1984: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1985: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:1985: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:1986: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1987: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1988: Local variable 'key' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:1989: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:1990: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:1992: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:1995: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:1996: The String literal "%settlement%" appears 5 times in this file; the first occurrence is on line 1,996 +src/net/sf/freecol/server/model/ServerPlayer.java:2000: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2012: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2012: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2012: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2012: The method 'csBombardEnemyShips' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/server/model/ServerPlayer.java:2013: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2015: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2015: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2017: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2018: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2037: Avoid really long methods. +src/net/sf/freecol/server/model/ServerPlayer.java:2037: Parameter 'father' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2037: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2037: The method 'csAddFoundingFather' has a Cyclomatic Complexity of 44. +src/net/sf/freecol/server/model/ServerPlayer.java:2037: The method 'csAddFoundingFather' has a Modified Cyclomatic Complexity of 41. +src/net/sf/freecol/server/model/ServerPlayer.java:2037: The method 'csAddFoundingFather' has a Standard Cyclomatic Complexity of 41. +src/net/sf/freecol/server/model/ServerPlayer.java:2037: The method csAddFoundingFather() has an NCSS line count of 123 +src/net/sf/freecol/server/model/ServerPlayer.java:2037: The method csAddFoundingFather() has an NPath complexity of 42688 +src/net/sf/freecol/server/model/ServerPlayer.java:2038: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2038: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2040: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2042: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2043: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/model/ServerPlayer.java:2060: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2061: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2066: Local variable 'upgrades' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2068: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2069: Local variable 'newType' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2069: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2078: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2082: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2083: Local variable 'c' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2084: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2086: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2086: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2086: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2088: Local variable 'other' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2088: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2089: Local variable 'c' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2089: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2090: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2097: Local variable 'c' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2098: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2099: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2103: Local variable 'm' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2104: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2104: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2106: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2106: Local variable 'c' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2110: Local variable 'event' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2111: Local variable 'eventId' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2113: Local variable 'p' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2120: Local variable 'p' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2121: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2122: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:2123: Local variable 'is' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2124: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2125: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2127: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:2135: Local variable 'market' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2136: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2138: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2144: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2145: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2146: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2151: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2151: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2152: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2153: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2154: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:2154: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2160: Avoid variables with short names like c +src/net/sf/freecol/server/model/ServerPlayer.java:2160: Local variable 'c' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2160: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2161: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2175: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerPlayer.java:2177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2180: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2189: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2190: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2201: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2202: Local variable 'result' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2203: Local variable 'ff' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2204: Local variable 'event' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2205: Local variable 'eventId' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2214: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:2223: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2223: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2223: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2223: The method csClaimLand() has an NPath complexity of 225 +src/net/sf/freecol/server/model/ServerPlayer.java:2224: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2224: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2225: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2226: Local variable 'ownerSettlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2237: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2238: Avoid variables with short names like is +src/net/sf/freecol/server/model/ServerPlayer.java:2238: Local variable 'is' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2247: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2247: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:2248: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2262: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2262: Parameter 'slot' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2262: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2263: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2263: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2265: Local variable 'europe' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2266: Local variable 'recruitType' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2266: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2269: Local variable 'role' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2269: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2269: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2269: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2271: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2272: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2276: A switch statement does not contain a break +src/net/sf/freecol/server/model/ServerPlayer.java:2281: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2283: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2309: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:2318: Avoid really long methods. +src/net/sf/freecol/server/model/ServerPlayer.java:2318: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2318: The method 'csCombat' has a Cyclomatic Complexity of 113. +src/net/sf/freecol/server/model/ServerPlayer.java:2318: The method 'csCombat' has a Modified Cyclomatic Complexity of 80. +src/net/sf/freecol/server/model/ServerPlayer.java:2318: The method 'csCombat' has a Standard Cyclomatic Complexity of 105. +src/net/sf/freecol/server/model/ServerPlayer.java:2318: The method csCombat() has an NCSS line count of 335 +src/net/sf/freecol/server/model/ServerPlayer.java:2319: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2320: Avoid reassigning parameters such as 'crs' +src/net/sf/freecol/server/model/ServerPlayer.java:2321: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2322: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2322: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2323: Local variable 'combatModel' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2323: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2324: Local variable 'isAttack' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2324: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2325: Local variable 'isBombard' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2325: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2327: Avoid excessively long variable names like attackerSettlement +src/net/sf/freecol/server/model/ServerPlayer.java:2336: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2339: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2340: Local variable 'bombard' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2341: The String literal "sound" appears 5 times in this file; the first occurrence is on line 2,341 +src/net/sf/freecol/server/model/ServerPlayer.java:2342: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2342: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2342: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2342: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2344: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2346: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2346: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2348: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2348: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2350: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2351: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2352: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2352: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2352: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2357: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2362: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2364: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2375: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2385: Local variable 'result' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2391: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2394: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerPlayer.java:2395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2396: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:2405: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2408: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerPlayer.java:2409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2410: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:2426: Avoid excessively long variable names like burnedNativeCapital +src/net/sf/freecol/server/model/ServerPlayer.java:2427: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2427: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2428: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2429: Local variable 'natives' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2429: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2429: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2431: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerPlayer.java:2434: Local variable 'cr' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2435: Avoid variables with short names like ok +src/net/sf/freecol/server/model/ServerPlayer.java:2446: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2463: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2475: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2514: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2514: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2514: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2528: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2549: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2575: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2582: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2589: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2589: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2621: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2650: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2650: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2650: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2664: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2706: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2707: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2712: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerPlayer.java:2712: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerPlayer.java:2714: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2714: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2716: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2716: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2718: Local variable 'is' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2718: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2719: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2720: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2720: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2723: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2724: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2724: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2730: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2742: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2743: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2744: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2756: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2763: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2763: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2764: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2765: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2779: Local variable 'movecost' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2779: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2780: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2780: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2783: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2793: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2797: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2808: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2810: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2811: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:2813: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:2813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2813: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2813: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:2817: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:2820: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:2833: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2833: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2834: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2834: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2835: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2850: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2850: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2851: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2851: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2852: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2853: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2853: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2854: Local variable 'nativePlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2855: Local variable 'nativeNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2855: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2862: The String literal "%enemyNation%" appears 20 times in this file; the first occurrence is on line 2,862 +src/net/sf/freecol/server/model/ServerPlayer.java:2865: Local variable 'here' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2866: Local variable 's' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2866: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2868: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2872: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2882: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2882: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2883: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2883: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2884: Local variable 'role' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2897: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2897: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2898: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2898: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2898: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2899: Local variable 'game' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2900: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2901: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2901: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2902: Local variable 'colonyPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2903: Local variable 'colonyNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2903: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2904: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2905: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2907: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2908: Local variable 'plunder' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2912: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2917: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2932: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2936: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2937: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2943: Local variable 'm' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2952: Local variable 'tiles' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2953: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2954: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2955: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2960: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2962: Avoid variables with short names like ct +src/net/sf/freecol/server/model/ServerPlayer.java:2962: Local variable 'ct' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2963: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2971: Local variable 'explored' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2973: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2974: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:2974: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2976: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2976: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2976: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2976: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:2985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2986: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:2997: Avoid variables with short names like is +src/net/sf/freecol/server/model/ServerPlayer.java:2997: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2997: Parameter 'is' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2998: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:2998: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2998: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:2999: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3000: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3001: Local variable 'nativePlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3002: Local variable 'convertNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3002: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3003: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3003: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3004: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3004: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3004: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3005: Local variable 'convert' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3007: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3013: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3019: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3020: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3031: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3031: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3031: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3031: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3032: Local variable 'role' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3045: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3045: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3046: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3046: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3046: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3047: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3048: Local variable 'loserPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3049: Local variable 'newRole' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3051: Local variable 'newGoods' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3053: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3053: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3053: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3059: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3060: Local variable 'winnerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3060: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3072: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3074: Local variable 'ag' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3075: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3076: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3077: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3092: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3092: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3092: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3092: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3093: Local variable 'loserPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3094: Local variable 'loserNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3094: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3095: Local variable 'loserLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3095: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3097: Local variable 'oldName' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3098: Local variable 'messageId' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3099: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3100: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3101: Local variable 'winnerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3102: Local variable 'winnerLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3109: Local variable 'oldTile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3110: Local variable 'change' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3110: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3110: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3124: The String literal "%enemyUnit%" appears 19 times in this file; the first occurrence is on line 3,124 +src/net/sf/freecol/server/model/ServerPlayer.java:3125: The String literal "%location%" appears 10 times in this file; the first occurrence is on line 3,125 +src/net/sf/freecol/server/model/ServerPlayer.java:3135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3146: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3146: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3147: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3147: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3148: Local variable 'captureRepairing' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3148: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3150: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3150: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3152: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3166: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3166: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3166: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3166: Parameter 'ship' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3167: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3168: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3169: Local variable 'shipPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3170: Local variable 'repair' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3171: Local variable 'repairLoc' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3172: Local variable 'shipNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3198: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3198: Parameter 'ship' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3199: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3199: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3200: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3201: Local variable 'shipPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3202: Local variable 'repair' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3203: Local variable 'repairLoc' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3204: Local variable 'shipNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3229: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3229: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3229: Parameter 'repair' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3229: Parameter 'ship' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3230: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3233: Local variable 'g' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3233: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3236: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3243: Local variable 'shipLoc' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3243: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3243: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3251: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3261: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3261: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3261: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3261: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3262: Local variable 'loserPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3263: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3263: Local variable 'loserNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3264: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3264: Local variable 'loserLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3264: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3266: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3266: Local variable 'oldName' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3267: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3267: Local variable 'messageId' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3267: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3268: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3269: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3269: Local variable 'winnerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3270: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3270: Local variable 'winnerLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3270: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3273: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3275: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:3280: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3284: The String literal "combat.unitDemoted" appears 4 times in this file; the first occurrence is on line 3,284 +src/net/sf/freecol/server/model/ServerPlayer.java:3286: The String literal "%oldName%" appears 5 times in this file; the first occurrence is on line 3,286 +src/net/sf/freecol/server/model/ServerPlayer.java:3288: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3294: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3310: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3310: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3310: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3311: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3311: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3312: Local variable 'game' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3313: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3314: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3315: Local variable 'colonyPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3316: Local variable 'colonyNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3316: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3317: Local variable 'plunder' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3321: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3332: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3342: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3343: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3360: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3361: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3362: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3362: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3362: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3365: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3366: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3367: Local variable 'nativePlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3368: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3369: Local variable 'nativeNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3370: Local variable 'settlementName' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3371: Local variable 'capital' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3372: Local variable 'plunder' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3375: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3385: Local variable 'unitTypes' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3387: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3389: Local variable 'train' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3395: Local variable 'score' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3396: Avoid variables with short names like h +src/net/sf/freecol/server/model/ServerPlayer.java:3436: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3436: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3436: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3436: The method 'csDisposeSettlement' has a Cyclomatic Complexity of 13. +src/net/sf/freecol/server/model/ServerPlayer.java:3436: The method 'csDisposeSettlement' has a Modified Cyclomatic Complexity of 13. +src/net/sf/freecol/server/model/ServerPlayer.java:3436: The method 'csDisposeSettlement' has a Standard Cyclomatic Complexity of 13. +src/net/sf/freecol/server/model/ServerPlayer.java:3436: The method csDisposeSettlement() has an NPath complexity of 1344 +src/net/sf/freecol/server/model/ServerPlayer.java:3437: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:3438: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3439: Local variable 'owned' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3440: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3440: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3441: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3441: Local variable 'centerTile' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3447: Local variable 'sis' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3448: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3449: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3449: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3450: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3451: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3457: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3458: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3466: Local variable 'vis' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3466: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3467: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3467: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3471: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3475: Local variable 'surrounding' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3476: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3476: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3477: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3477: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3482: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3483: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3483: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3487: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3487: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3492: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3492: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3493: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3493: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3503: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3503: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3503: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3503: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3504: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3505: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3506: Local variable 'defenderPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3507: Local variable 'defenderNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3530: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3530: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3531: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3531: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3532: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3533: Local variable 'defenderPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3534: Local variable 'defenderNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3557: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3557: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3557: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3557: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3558: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3559: Local variable 'capture' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3561: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3561: Local variable 'g' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3566: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3577: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3577: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3577: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3577: Parameter 'defender' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3578: Local variable 'defenderPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3579: Local variable 'defenderNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3579: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3580: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3581: Local variable 'defenderLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3581: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3583: Local variable 'role' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3584: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3585: Local variable 'attackerLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3585: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3587: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3591: Local variable 'ag' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3591: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3592: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3599: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3602: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3612: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3624: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3624: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3624: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3624: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3626: Local variable 'loserPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3627: Local variable 'loserNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3627: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3628: Local variable 'loserLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3628: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3630: Local variable 'oldName' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3631: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3632: Local variable 'winnerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3633: Local variable 'winnerLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3633: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3635: Local variable 'role' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3637: Local variable 'downgrade' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3637: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3638: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:3641: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3649: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:3653: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3662: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3683: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3683: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3683: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3684: Local variable 'tr' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3686: Local variable 'trsi' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3686: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3686: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3688: Local variable 'trs' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3689: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3695: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3695: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3700: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerPlayer.java:3702: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3717: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3717: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3718: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3718: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3718: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3719: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3720: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3721: Local variable 'colonyPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3722: Local variable 'colonyNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3722: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3725: Local variable 'buildingList' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3726: Local variable 'shipList' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3726: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3727: Local variable 'goodsList' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3730: Local variable 'pillage' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3731: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3731: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3731: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3732: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3732: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3733: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3734: Local variable 'building' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3734: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3743: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3743: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3744: Local variable 'ship' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3744: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3744: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3745: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3750: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3750: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3751: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3752: Local variable 'goods' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3752: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3752: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3753: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3754: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3754: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3756: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3760: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3761: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3767: Local variable 'plunder' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3768: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3769: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3779: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3787: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:3797: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3797: Parameter 'building' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3797: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3798: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3799: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3799: Local variable 'copied' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3799: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3799: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3801: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3802: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3803: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3804: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3805: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3806: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3811: Local variable 'wl' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3811: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3812: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3812: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3813: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3814: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3814: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:3814: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:3815: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3816: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3820: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3821: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3825: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:3825: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3825: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3827: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3838: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3838: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3838: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3839: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3840: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3840: Local variable 'winnerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3840: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3841: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:3841: Local variable 'oldName' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3843: Local variable 'type' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3846: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:3851: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3868: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3868: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3868: Parameter 'colony' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3868: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3869: Local variable 'captureRepairing' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3869: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3871: Local variable 'units' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3871: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3872: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3873: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3873: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3874: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3874: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3887: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3887: Parameter 'attacker' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3887: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3887: Parameter 'ship' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3888: Local variable 'shipPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3889: Local variable 'shipNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3890: Local variable 'attackerUnit' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3891: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3892: Local variable 'attackerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3892: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3897: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3904: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3917: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3917: Parameter 'ship' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3918: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3918: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3919: Local variable 'attackerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3920: Local variable 'shipPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3921: Local variable 'shipNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3946: Parameter 'attackerPlayer' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3946: Parameter 'ship' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3947: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3947: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3948: Local variable 'shipPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3949: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3949: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3952: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3966: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:3966: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3966: Parameter 'loser' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3966: Parameter 'winner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3966: The method csSlaughterUnit() has an NPath complexity of 375 +src/net/sf/freecol/server/model/ServerPlayer.java:3967: Local variable 'winnerPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3968: Local variable 'winnerNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3969: Local variable 'winnerLoc' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3969: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3969: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3971: Local variable 'winnerLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3972: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3973: Local variable 'loserPlayer' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3974: Local variable 'loserNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3975: Local variable 'loserLoc' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3975: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3975: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:3977: Local variable 'loserLocation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3978: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3979: Local variable 'messageId' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3980: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:3987: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3993: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3998: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3998: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:3999: Local variable 'nativeNation' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:3999: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4001: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4012: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:4012: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4014: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4017: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4027: Parameter 'newTiles' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4028: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4028: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4041: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4042: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4043: Local variable 'modifier' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4043: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4044: Avoid variables with short names like m +src/net/sf/freecol/server/model/ServerPlayer.java:4044: Local variable 'm' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4046: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4047: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:4047: Avoid using a branching statement as the last in a loop. +src/net/sf/freecol/server/model/ServerPlayer.java:4060: Parameter 'accepted' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4060: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4060: Parameter 'tax' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4061: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4061: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4062: Local variable 'goodsType' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4063: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4064: Local variable 'amount' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4065: Local variable 'monarchKey' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4069: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:4069: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:4070: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4073: Avoid using final local variables, turn them into fields +src/net/sf/freecol/server/model/ServerPlayer.java:4077: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4077: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/model/ServerPlayer.java:4080: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:4080: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:4082: Local variable 'spec' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4082: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4083: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4083: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4084: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4086: Local variable 'arrears' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4086: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4087: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4088: Local variable 'market' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4089: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4091: Local variable 'tpm' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4093: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4094: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4097: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4099: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4099: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4099: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:4099: Useless parentheses. +src/net/sf/freecol/server/model/ServerPlayer.java:4106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4109: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/model/ServerPlayer.java:4110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4110: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:4110: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:4113: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4127: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4127: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4127: Parameter 'goods' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4127: Parameter 'tax' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4140: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4140: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4145: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:4154: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4154: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4154: Parameter 'tax' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4170: Parameter 'mercs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4170: Parameter 'price' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4171: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4171: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4181: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/model/ServerPlayer.java:4193: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4193: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4193: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4194: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:4194: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:4198: Local variable 'turn' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4201: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:4213: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4213: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerPlayer.java:4218: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:4227: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4227: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4228: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4228: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4241: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:4250: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4250: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4251: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4251: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4251: Parameter 'otherUnit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4252: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerPlayer.java:4255: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:4257: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:4264: Local variable 'agreement' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4267: Local variable 'session' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4276: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerPlayer.java:4291: Parameter 'newOwner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4291: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4291: The method 'csChangeOwner' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/server/model/ServerPlayer.java:4291: The method 'csChangeOwner' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerPlayer.java:4291: The method 'csChangeOwner' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerPlayer.java:4291: The method csChangeOwner() has an NPath complexity of 672 +src/net/sf/freecol/server/model/ServerPlayer.java:4292: Parameter 'change' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4292: Parameter 'loc' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4293: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerPlayer.java:4293: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4294: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:4294: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:4298: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:4299: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4300: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4300: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerPlayer.java:4302: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerPlayer.java:4305: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4307: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:4307: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4308: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerPlayer.java:4308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4310: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4312: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerPlayer.java:4323: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerPlayer.java:4339: Avoid variables with short names like sb +src/net/sf/freecol/server/model/ServerPlayer.java:4339: Local variable 'sb' could be declared final +src/net/sf/freecol/server/model/ServerPlayer.java:4341: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:4342: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerPlayer.java:4343: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerRegion.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerRegion.java:20: Possible God class (WMC=80, ATFD=107, TCC=0.12727272727272726) +src/net/sf/freecol/server/model/ServerRegion.java:46: The class 'ServerRegion' has a Cyclomatic Complexity of 5 (Highest = 53). +src/net/sf/freecol/server/model/ServerRegion.java:46: The class 'ServerRegion' has a Modified Cyclomatic Complexity of 5 (Highest = 47). +src/net/sf/freecol/server/model/ServerRegion.java:46: The class 'ServerRegion' has a Standard Cyclomatic Complexity of 5 (Highest = 47). +src/net/sf/freecol/server/model/ServerRegion.java:49: Avoid excessively long variable names like PACIFIC_SCORE_VALUE +src/net/sf/freecol/server/model/ServerRegion.java:52: Avoid using redundant field initializer for 'size' +src/net/sf/freecol/server/model/ServerRegion.java:55: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/ServerRegion.java:55: Private field 'bounds' could be made final; it is only initialized in the declaration or constructor. +src/net/sf/freecol/server/model/ServerRegion.java:63: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerRegion.java:63: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:63: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:70: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:70: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:76: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerRegion.java:90: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:90: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:105: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:105: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:105: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:106: Parameter 'parent' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:120: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:120: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:120: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:121: Parameter 'parent' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:125: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerRegion.java:128: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:131: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerRegion.java:132: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerRegion.java:189: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:190: Avoid variables with short names like xy +src/net/sf/freecol/server/model/ServerRegion.java:190: Local variable 'xy' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:191: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:199: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:218: Found 'UR'-anomaly for variable 'r' (lines '218'-'225'). +src/net/sf/freecol/server/model/ServerRegion.java:218: Parameter 'newName' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:218: Parameter 'player' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:218: Parameter 'turn' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:219: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerRegion.java:219: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:220: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:221: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:221: Useless parentheses. +src/net/sf/freecol/server/model/ServerRegion.java:221: Useless parentheses. +src/net/sf/freecol/server/model/ServerRegion.java:224: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:225: Avoid using for statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:225: Local variable 'r' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:226: Avoid variables with short names like h +src/net/sf/freecol/server/model/ServerRegion.java:226: Local variable 'h' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:241: Avoid really long methods. +src/net/sf/freecol/server/model/ServerRegion.java:241: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerRegion.java:241: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:241: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:241: The method 'requireFixedRegions' has a Cyclomatic Complexity of 53. +src/net/sf/freecol/server/model/ServerRegion.java:241: The method 'requireFixedRegions' has a Modified Cyclomatic Complexity of 47. +src/net/sf/freecol/server/model/ServerRegion.java:241: The method 'requireFixedRegions' has a Standard Cyclomatic Complexity of 47. +src/net/sf/freecol/server/model/ServerRegion.java:241: The method requireFixedRegions() has an NCSS line count of 185 +src/net/sf/freecol/server/model/ServerRegion.java:241: The method requireFixedRegions() has an NPath complexity of 1179648 +src/net/sf/freecol/server/model/ServerRegion.java:242: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerRegion.java:242: Avoid unused local variables such as 'game'. +src/net/sf/freecol/server/model/ServerRegion.java:242: Found 'DU'-anomaly for variable 'game' (lines '242'-'493'). +src/net/sf/freecol/server/model/ServerRegion.java:244: Local variable 'result' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:254: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:261: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:262: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:262: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:268: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:270: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:277: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:278: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:278: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:284: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:295: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:302: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:311: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:313: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:320: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:322: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:329: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:331: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:338: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:340: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:347: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:349: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:356: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:358: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:365: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:367: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:374: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:376: Found 'DD'-anomaly for variable 'allOceans' (lines '376'-'383'). +src/net/sf/freecol/server/model/ServerRegion.java:377: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:381: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:382: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:383: Found 'DD'-anomaly for variable 'allOceans' (lines '383'-'392'). +src/net/sf/freecol/server/model/ServerRegion.java:386: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:387: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:391: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:392: Found 'DD'-anomaly for variable 'allOceans' (lines '392'-'401'). +src/net/sf/freecol/server/model/ServerRegion.java:395: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:396: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:400: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:401: Found 'DD'-anomaly for variable 'allOceans' (lines '401'-'411'). +src/net/sf/freecol/server/model/ServerRegion.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:410: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:411: Found 'DD'-anomaly for variable 'allOceans' (lines '411'-'420'). +src/net/sf/freecol/server/model/ServerRegion.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:415: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:419: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:420: Found 'DD'-anomaly for variable 'allOceans' (lines '420'-'429'). +src/net/sf/freecol/server/model/ServerRegion.java:423: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:424: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:428: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:432: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:452: Avoid variables with short names like t +src/net/sf/freecol/server/model/ServerRegion.java:452: Found 'DD'-anomaly for variable 't' (lines '452'-'454'). +src/net/sf/freecol/server/model/ServerRegion.java:452: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/model/ServerRegion.java:454: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerRegion.java:454: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:455: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerRegion.java:455: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:456: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:459: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerRegion.java:459: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:460: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerRegion.java:460: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:461: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:463: Found 'DU'-anomaly for variable 'nSA' (lines '463'-'493'). +src/net/sf/freecol/server/model/ServerRegion.java:463: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/model/ServerRegion.java:465: Local variable 'rNP' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:466: Local variable 'rSP' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:467: Found 'DU'-anomaly for variable 'rNA' (lines '467'-'493'). +src/net/sf/freecol/server/model/ServerRegion.java:467: Local variable 'rNA' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:468: Found 'DU'-anomaly for variable 'rSA' (lines '468'-'493'). +src/net/sf/freecol/server/model/ServerRegion.java:468: Local variable 'rSA' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:469: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:470: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:471: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:472: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:474: Avoid variables with short names like rN +src/net/sf/freecol/server/model/ServerRegion.java:474: Found 'DU'-anomaly for variable 'rN' (lines '474'-'493'). +src/net/sf/freecol/server/model/ServerRegion.java:474: Local variable 'rN' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:475: Avoid variables with short names like rS +src/net/sf/freecol/server/model/ServerRegion.java:475: Found 'DU'-anomaly for variable 'rS' (lines '475'-'493'). +src/net/sf/freecol/server/model/ServerRegion.java:475: Local variable 'rS' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:476: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:477: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:478: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:479: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:481: Found 'DU'-anomaly for variable 'rAll' (lines '481'-'493'). +src/net/sf/freecol/server/model/ServerRegion.java:481: Local variable 'rAll' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:482: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:483: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:484: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:485: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerRegion.java:495: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerRegion.java:504: Avoid reassigning parameters such as 'tile' +src/net/sf/freecol/server/model/ServerRegion.java:504: Found 'UR'-anomaly for variable 'direction' (lines '504'-'517'). +src/net/sf/freecol/server/model/ServerRegion.java:504: Parameter 'map' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:504: Parameter 'region' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:505: Parameter 'bounds' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:506: Avoid variables with short names like q +src/net/sf/freecol/server/model/ServerRegion.java:506: Local variable 'q' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:507: Avoid variables with short names like n +src/net/sf/freecol/server/model/ServerRegion.java:507: Found 'DD'-anomaly for variable 'n' (lines '507'-'514'). +src/net/sf/freecol/server/model/ServerRegion.java:508: Found 'DD'-anomaly for variable 'visited' (lines '508'-'509'). +src/net/sf/freecol/server/model/ServerRegion.java:509: Found 'DU'-anomaly for variable 'visited' (lines '509'-'530'). +src/net/sf/freecol/server/model/ServerRegion.java:509: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:509: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:510: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:512: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerRegion.java:512: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:514: Found 'DD'-anomaly for variable 'n' (lines '514'-'514'). +src/net/sf/freecol/server/model/ServerRegion.java:516: Local variable 'direction' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:517: Avoid variables with short names like t +src/net/sf/freecol/server/model/ServerRegion.java:517: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:519: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:519: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:519: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:519: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:520: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:520: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:521: Found 'DU'-anomaly for variable 'visited' (lines '521'-'530'). +src/net/sf/freecol/server/model/ServerRegion.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:521: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerRegion.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:521: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:522: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:522: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:523: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:524: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerRegion.java:540: Avoid variables with short names like sb +src/net/sf/freecol/server/model/ServerRegion.java:540: Local variable 'sb' could be declared final +src/net/sf/freecol/server/model/ServerRegion.java:543: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerRegion.java:543: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerRegion.java:544: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/server/model/ServerUnit.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerUnit.java:21: A high number of imports can indicate a high degree of coupling within an object. +src/net/sf/freecol/server/model/ServerUnit.java:21: Possible God class (WMC=179, ATFD=180, TCC=0.18181818181818182) +src/net/sf/freecol/server/model/ServerUnit.java:84: Avoid really long classes. +src/net/sf/freecol/server/model/ServerUnit.java:84: The class 'ServerUnit' has a Cyclomatic Complexity of 13 (Highest = 62). +src/net/sf/freecol/server/model/ServerUnit.java:84: The class 'ServerUnit' has a Modified Cyclomatic Complexity of 8 (Highest = 36). +src/net/sf/freecol/server/model/ServerUnit.java:84: The class 'ServerUnit' has a Standard Cyclomatic Complexity of 9 (Highest = 36). +src/net/sf/freecol/server/model/ServerUnit.java:86: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/ServerUnit.java:86: fieldCommentRequirement Required +src/net/sf/freecol/server/model/ServerUnit.java:92: Avoid variables with short names like id +src/net/sf/freecol/server/model/ServerUnit.java:92: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:92: Parameter 'id' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:96: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerUnit.java:107: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:107: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:107: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:108: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:112: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerUnit.java:126: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:126: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:126: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:148: Comment is too large: Too many lines +src/net/sf/freecol/server/model/ServerUnit.java:160: Parameter 'game' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:160: Parameter 'location' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:160: Parameter 'owner' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:161: Parameter 'role' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:161: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:164: Local variable 'newType' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:169: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:170: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:175: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:176: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:180: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:183: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:185: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:188: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:190: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:191: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:217: Avoid really long methods. +src/net/sf/freecol/server/model/ServerUnit.java:217: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:217: Avoid variables with short names like lb +src/net/sf/freecol/server/model/ServerUnit.java:217: Found 'UR'-anomaly for variable 't' (lines '217'-'306'). +src/net/sf/freecol/server/model/ServerUnit.java:217: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:217: Parameter 'lb' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:217: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:217: The method 'csNewTurn' has a Cyclomatic Complexity of 38. +src/net/sf/freecol/server/model/ServerUnit.java:217: The method 'csNewTurn' has a Modified Cyclomatic Complexity of 27. +src/net/sf/freecol/server/model/ServerUnit.java:217: The method 'csNewTurn' has a Standard Cyclomatic Complexity of 29. +src/net/sf/freecol/server/model/ServerUnit.java:217: The method csNewTurn() has an NCSS line count of 126 +src/net/sf/freecol/server/model/ServerUnit.java:217: The method csNewTurn() has an NPath complexity of 1566720 +src/net/sf/freecol/server/model/ServerUnit.java:219: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:220: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:220: Found 'DU'-anomaly for variable 'spec' (lines '220'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:220: Local variable 'spec' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:221: Local variable 'loc' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:222: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:222: Found 'DD'-anomaly for variable 'locDirty' (lines '222'-'308'). +src/net/sf/freecol/server/model/ServerUnit.java:222: Found 'DD'-anomaly for variable 'locDirty' (lines '222'-'346'). +src/net/sf/freecol/server/model/ServerUnit.java:222: Found 'DD'-anomaly for variable 'locDirty' (lines '222'-'360'). +src/net/sf/freecol/server/model/ServerUnit.java:222: Found 'DD'-anomaly for variable 'locDirty' (lines '222'-'369'). +src/net/sf/freecol/server/model/ServerUnit.java:222: Found 'DU'-anomaly for variable 'locDirty' (lines '222'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:223: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:223: Found 'DD'-anomaly for variable 'unitDirty' (lines '223'-'271'). +src/net/sf/freecol/server/model/ServerUnit.java:223: Found 'DU'-anomaly for variable 'unitDirty' (lines '223'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:226: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:227: Local variable 'attrition' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:229: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:233: The String literal "%unit%" appears 6 times in this file; the first occurrence is on line 233 +src/net/sf/freecol/server/model/ServerUnit.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:237: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:251: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerUnit.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:255: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:256: Local variable 'maximumExperience' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:256: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:257: Local variable 'maxValue' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:258: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:262: Local variable 'oldName' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:269: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:271: Found 'DD'-anomaly for variable 'unitDirty' (lines '271'-'286'). +src/net/sf/freecol/server/model/ServerUnit.java:277: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:286: Found 'DD'-anomaly for variable 'unitDirty' (lines '286'-'325'). +src/net/sf/freecol/server/model/ServerUnit.java:286: Found 'DD'-anomaly for variable 'unitDirty' (lines '286'-'360'). +src/net/sf/freecol/server/model/ServerUnit.java:286: Found 'DD'-anomaly for variable 'unitDirty' (lines '286'-'373'). +src/net/sf/freecol/server/model/ServerUnit.java:286: Found 'DD'-anomaly for variable 'unitDirty' (lines '286'-'378'). +src/net/sf/freecol/server/model/ServerUnit.java:286: Found 'DU'-anomaly for variable 'unitDirty' (lines '286'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:287: A high ratio of statements to labels in a switch statement. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:287: A switch with less than three branches is inefficient, use a if statement instead. +src/net/sf/freecol/server/model/ServerUnit.java:290: Avoid variables with short names like ti +src/net/sf/freecol/server/model/ServerUnit.java:290: Local variable 'ti' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:292: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:297: Local variable 'amount' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:297: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:297: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:297: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:297: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:299: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:300: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerUnit.java:300: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:303: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:304: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:305: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:305: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:306: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:306: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:308: Found 'DD'-anomaly for variable 'locDirty' (lines '308'-'346'). +src/net/sf/freecol/server/model/ServerUnit.java:308: Found 'DD'-anomaly for variable 'locDirty' (lines '308'-'360'). +src/net/sf/freecol/server/model/ServerUnit.java:308: Found 'DD'-anomaly for variable 'locDirty' (lines '308'-'369'). +src/net/sf/freecol/server/model/ServerUnit.java:317: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:325: Found 'DD'-anomaly for variable 'unitDirty' (lines '325'-'360'). +src/net/sf/freecol/server/model/ServerUnit.java:325: Found 'DD'-anomaly for variable 'unitDirty' (lines '325'-'373'). +src/net/sf/freecol/server/model/ServerUnit.java:325: Found 'DD'-anomaly for variable 'unitDirty' (lines '325'-'378'). +src/net/sf/freecol/server/model/ServerUnit.java:325: Found 'DU'-anomaly for variable 'unitDirty' (lines '325'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:330: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:331: Found 'DU'-anomaly for variable 'dst' (lines '331'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:333: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerUnit.java:345: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:349: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:351: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:353: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:353: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:353: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:357: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:360: Found 'DU'-anomaly for variable 'unitDirty' (lines '360'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:373: Found 'DU'-anomaly for variable 'unitDirty' (lines '373'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:378: Found 'DU'-anomaly for variable 'unitDirty' (lines '378'-'392'). +src/net/sf/freecol/server/model/ServerUnit.java:402: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:402: Found 'UR'-anomaly for variable 'unit' (lines '402'-'470'). +src/net/sf/freecol/server/model/ServerUnit.java:402: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:402: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:402: The method 'csImproveTile' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/server/model/ServerUnit.java:402: The method 'csImproveTile' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerUnit.java:402: The method 'csImproveTile' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/server/model/ServerUnit.java:402: The method csImproveTile() has an NPath complexity of 960 +src/net/sf/freecol/server/model/ServerUnit.java:403: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:404: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:405: Local variable 'deliver' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:405: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:405: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:406: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:408: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:409: Found 'DD'-anomaly for variable 'amount' (lines '409'-'410'). +src/net/sf/freecol/server/model/ServerUnit.java:409: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:411: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:412: Local variable 'settlement' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:412: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:414: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:415: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:416: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:416: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:421: Avoid variables with short names like ti +src/net/sf/freecol/server/model/ServerUnit.java:421: Local variable 'ti' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:422: Local variable 'changeType' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:422: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:427: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:431: Avoid excessively long variable names like tileImprovementType +src/net/sf/freecol/server/model/ServerUnit.java:431: Local variable 'tileImprovementType' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:431: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:432: Local variable 'exposeResource' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:432: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:433: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:434: These nested if statements could be combined +src/net/sf/freecol/server/model/ServerUnit.java:436: Local variable 'resType' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:436: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:438: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:438: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:440: Local variable 'minValue' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:440: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:441: Local variable 'maxValue' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:441: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:442: Local variable 'value' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:451: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:451: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:451: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:454: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:455: Local variable 'locName' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:456: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:469: Local variable 'unit' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:469: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:471: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:471: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:487: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:487: Parameter 'carrier' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:487: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:487: The method csEmbark() has an NPath complexity of 300 +src/net/sf/freecol/server/model/ServerUnit.java:490: Local variable 'oldLocation' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:491: Local variable 'colony' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:491: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:491: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:492: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:493: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:493: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:493: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:497: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerUnit.java:506: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:517: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:517: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:518: Local variable 'owner' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:521: Local variable 'loc' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:527: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:541: Found 'UR'-anomaly for variable 'enemyUnit' (lines '541'-'559'). +src/net/sf/freecol/server/model/ServerUnit.java:541: Found 'UR'-anomaly for variable 'tile' (lines '541'-'554'). +src/net/sf/freecol/server/model/ServerUnit.java:541: Parameter 'newTile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:541: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:541: The method 'getSlowedBy' has a Cyclomatic Complexity of 17. +src/net/sf/freecol/server/model/ServerUnit.java:541: The method getSlowedBy() has an NPath complexity of 369 +src/net/sf/freecol/server/model/ServerUnit.java:542: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:542: Found 'DU'-anomaly for variable 'player' (lines '542'-'585'). +src/net/sf/freecol/server/model/ServerUnit.java:542: Local variable 'player' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:543: Local variable 'game' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:544: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:544: Found 'DU'-anomaly for variable 'combatModel' (lines '544'-'585'). +src/net/sf/freecol/server/model/ServerUnit.java:544: Local variable 'combatModel' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:544: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:545: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:545: Found 'DU'-anomaly for variable 'pirate' (lines '545'-'585'). +src/net/sf/freecol/server/model/ServerUnit.java:545: Local variable 'pirate' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:546: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:546: Found 'DD'-anomaly for variable 'attacker' (lines '546'-'565'). +src/net/sf/freecol/server/model/ServerUnit.java:546: Found 'DU'-anomaly for variable 'attacker' (lines '546'-'585'). +src/net/sf/freecol/server/model/ServerUnit.java:547: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:547: Found 'DU'-anomaly for variable 'attackPower' (lines '547'-'585'). +src/net/sf/freecol/server/model/ServerUnit.java:547: Found 'DU'-anomaly for variable 'totalAttackPower' (lines '547'-'585'). +src/net/sf/freecol/server/model/ServerUnit.java:547: Use one line for each declaration, it enhances code readability. +src/net/sf/freecol/server/model/ServerUnit.java:549: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerUnit.java:549: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:550: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:554: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerUnit.java:554: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:554: Found 'DD'-anomaly for variable 'enemy' (lines '554'-'554'). +src/net/sf/freecol/server/model/ServerUnit.java:554: Found 'DU'-anomaly for variable 'enemy' (lines '554'-'585'). +src/net/sf/freecol/server/model/ServerUnit.java:554: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:555: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:556: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:557: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:557: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:558: Local variable 'enemyUnit' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:558: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:559: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:560: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:560: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:560: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:561: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:562: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:563: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:565: Found 'DD'-anomaly for variable 'attacker' (lines '565'-'565'). +src/net/sf/freecol/server/model/ServerUnit.java:570: Local variable 'defencePower' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:570: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:571: Local variable 'totalProbability' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:574: Local variable 'diff' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:576: Local variable 'moves' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:578: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:578: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:578: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:581: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:592: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:592: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:593: Local variable 'serverPlayer' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:594: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:595: Local variable 'indianPlayer' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:595: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:596: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:597: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:598: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/model/ServerUnit.java:599: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:602: Potential violation of Law of Demeter (static property access) +src/net/sf/freecol/server/model/ServerUnit.java:603: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:613: Avoid really long methods. +src/net/sf/freecol/server/model/ServerUnit.java:613: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:613: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:613: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:613: The method 'csExploreLostCityRumour' has a Cyclomatic Complexity of 34. +src/net/sf/freecol/server/model/ServerUnit.java:613: The method 'csExploreLostCityRumour' has a Modified Cyclomatic Complexity of 20. +src/net/sf/freecol/server/model/ServerUnit.java:613: The method 'csExploreLostCityRumour' has a Standard Cyclomatic Complexity of 32. +src/net/sf/freecol/server/model/ServerUnit.java:613: The method csExploreLostCityRumour() has an NCSS line count of 133 +src/net/sf/freecol/server/model/ServerUnit.java:613: The method csExploreLostCityRumour() has an NPath complexity of 22848 +src/net/sf/freecol/server/model/ServerUnit.java:614: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:614: Found 'DU'-anomaly for variable 'serverPlayer' (lines '614'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:614: Local variable 'serverPlayer' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:615: Local variable 'tile' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:616: Local variable 'lostCity' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:617: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/server/model/ServerUnit.java:617: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:619: Local variable 'game' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:620: Local variable 'spec' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:621: Local variable 'difficulty' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:622: Avoid variables with short names like dx +src/net/sf/freecol/server/model/ServerUnit.java:622: Found 'DU'-anomaly for variable 'dx' (lines '622'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:622: Local variable 'dx' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:624: Found 'DD'-anomaly for variable 'newUnit' (lines '624'-'736'). +src/net/sf/freecol/server/model/ServerUnit.java:624: Found 'DD'-anomaly for variable 'newUnit' (lines '624'-'749'). +src/net/sf/freecol/server/model/ServerUnit.java:624: Found 'DD'-anomaly for variable 'newUnit' (lines '624'-'776'). +src/net/sf/freecol/server/model/ServerUnit.java:624: Found 'DU'-anomaly for variable 'newUnit' (lines '624'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:625: Found 'DU'-anomaly for variable 'treasureUnitTypes' (lines '625'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:625: Local variable 'treasureUnitTypes' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:636: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:641: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:641: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:650: Local variable 'mounds' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:653: Found 'DU'-anomaly for variable 'nothing' (lines '653'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:656: A switch statement does not contain a break +src/net/sf/freecol/server/model/ServerUnit.java:659: Found 'DU'-anomaly for variable 'done' (lines '659'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:661: Found 'DU'-anomaly for variable 'nothing' (lines '661'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:665: Found 'DU'-anomaly for variable 'done' (lines '665'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:668: Found 'DD'-anomaly for variable 'done' (lines '668'-'680'). +src/net/sf/freecol/server/model/ServerUnit.java:668: Found 'DU'-anomaly for variable 'done' (lines '668'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:672: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:677: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:680: Found 'DU'-anomaly for variable 'done' (lines '680'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:683: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerUnit.java:683: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerUnit.java:688: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:688: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:689: Found 'DD'-anomaly for variable 'result' (lines '689'-'699'). +src/net/sf/freecol/server/model/ServerUnit.java:690: Found 'DU'-anomaly for variable 'key' (lines '690'-'822'). +src/net/sf/freecol/server/model/ServerUnit.java:690: Local variable 'key' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:706: Local variable 'oldName' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:707: Local variable 'learnTypes' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:707: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:719: Local variable 'chiefAmount' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:725: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:725: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:732: Local variable 'foundTypes' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:743: Local variable 'cityName' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:745: Local variable 'treasureAmount' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:767: Local variable 'ruinsAmount' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:769: Avoid using Literals in Conditional Statements +src/net/sf/freecol/server/model/ServerUnit.java:782: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:782: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:784: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerUnit.java:788: Local variable 'europe' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:798: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:816: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:830: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:830: Found 'UR'-anomaly for variable 'u' (lines '830'-'832'). +src/net/sf/freecol/server/model/ServerUnit.java:830: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:830: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:831: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:846: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:848: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:848: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:848: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:848: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:849: Avoid variables with short names like t +src/net/sf/freecol/server/model/ServerUnit.java:849: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:849: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:859: Avoid really long methods. +src/net/sf/freecol/server/model/ServerUnit.java:859: Avoid variables with short names like cs +src/net/sf/freecol/server/model/ServerUnit.java:859: Found 'UR'-anomaly for variable 't' (lines '859'-'959'). +src/net/sf/freecol/server/model/ServerUnit.java:859: Found 'UR'-anomaly for variable 'u' (lines '859'-'1,045'). +src/net/sf/freecol/server/model/ServerUnit.java:859: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:859: Parameter 'newTile' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:859: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:859: The method 'csMove' has a Cyclomatic Complexity of 62. +src/net/sf/freecol/server/model/ServerUnit.java:859: The method 'csMove' has a Modified Cyclomatic Complexity of 36. +src/net/sf/freecol/server/model/ServerUnit.java:859: The method 'csMove' has a Standard Cyclomatic Complexity of 36. +src/net/sf/freecol/server/model/ServerUnit.java:859: The method csMove() has an NCSS line count of 104 +src/net/sf/freecol/server/model/ServerUnit.java:859: The method csMove() has an NPath complexity of 497131520 +src/net/sf/freecol/server/model/ServerUnit.java:865: Local variable 'oldTiles' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:865: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:866: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:867: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:867: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:868: Avoid declaring a variable if it is unreferenced before a possible exit point. +src/net/sf/freecol/server/model/ServerUnit.java:868: Found 'DU'-anomaly for variable 'newTiles' (lines '868'-'1,071'). +src/net/sf/freecol/server/model/ServerUnit.java:868: Local variable 'newTiles' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:874: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerUnit.java:874: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerUnit.java:879: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:879: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:881: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:881: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:891: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:891: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:894: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:896: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:896: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:900: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:903: Avoid variables with short names like it +src/net/sf/freecol/server/model/ServerUnit.java:903: Local variable 'it' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:903: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:905: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:905: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:907: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:907: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:913: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:915: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:915: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:920: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:920: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:921: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:922: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:926: Found 'DD'-anomaly for variable 'unit' (lines '926'-'964'). +src/net/sf/freecol/server/model/ServerUnit.java:927: Avoid variables with short names like d +src/net/sf/freecol/server/model/ServerUnit.java:929: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerUnit.java:930: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:930: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:930: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:932: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:934: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:934: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:934: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:934: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:935: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:935: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:935: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:936: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:936: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:943: Found 'DD'-anomaly for variable 'newLand' (lines '943'-'946'). +src/net/sf/freecol/server/model/ServerUnit.java:944: Local variable 'firstLanding' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:944: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:945: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:946: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:949: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:952: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:957: Local variable 'pending' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:958: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:964: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerUnit.java:964: Local variable 'other' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:965: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:966: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/server/model/ServerUnit.java:967: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:968: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:969: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:970: Use equals() to compare object references. +src/net/sf/freecol/server/model/ServerUnit.java:971: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:972: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:977: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:978: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:979: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:980: Local variable 'offer' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:980: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:980: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:980: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:982: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:983: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:985: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:989: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:990: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerUnit.java:990: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/server/model/ServerUnit.java:992: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:999: Found 'DD'-anomaly for variable 'contactPlayer' (lines '999'-'1,003'). +src/net/sf/freecol/server/model/ServerUnit.java:1000: Avoid variables with short names like is +src/net/sf/freecol/server/model/ServerUnit.java:1000: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:1000: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:1002: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/ServerUnit.java:1003: Avoid assignments in operands +src/net/sf/freecol/server/model/ServerUnit.java:1003: Found 'DD'-anomaly for variable 'is' (lines '1,003'-'1,003'). +src/net/sf/freecol/server/model/ServerUnit.java:1003: Found 'DU'-anomaly for variable 'contactPlayer' (lines '1,003'-'1,071'). +src/net/sf/freecol/server/model/ServerUnit.java:1004: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:1004: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:1005: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1006: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:1006: Useless parentheses. +src/net/sf/freecol/server/model/ServerUnit.java:1007: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:1007: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1010: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1011: Found 'DD'-anomaly for variable 'copied' (lines '1,011'-'1,011'). +src/net/sf/freecol/server/model/ServerUnit.java:1011: Found 'DU'-anomaly for variable 'copied' (lines '1,011'-'1,071'). +src/net/sf/freecol/server/model/ServerUnit.java:1011: Local variable 'copied' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:1011: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:1011: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1012: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1013: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1014: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:1014: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1017: Local variable 'nation' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:1017: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:1017: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1019: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/model/ServerUnit.java:1023: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1024: There is log block not surrounded by if +src/net/sf/freecol/server/model/ServerUnit.java:1025: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1032: Local variable 't' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:1036: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/ServerUnit.java:1036: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:1043: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:1044: Local variable 'u' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:1045: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/server/model/ServerUnit.java:1051: Local variable 'slowedBy' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:1053: Local variable 'enemy' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:1053: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1058: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1063: Local variable 'region' could be declared final +src/net/sf/freecol/server/model/ServerUnit.java:1064: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1065: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1068: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/ServerUnit.java:1069: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/model/TradeSession.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/TradeSession.java:34: Avoid unused private fields such as 'logger'. +src/net/sf/freecol/server/model/TradeSession.java:34: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/TradeSession.java:34: fieldCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/TradeSession.java:43: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/TradeSession.java:46: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/TradeSession.java:49: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/TradeSession.java:58: Parameter 'settlement' is not assigned and could be declared final +src/net/sf/freecol/server/model/TradeSession.java:58: Parameter 'unit' is not assigned and could be declared final +src/net/sf/freecol/server/model/TradeSession.java:62: Local variable 'atWar' could be declared final +src/net/sf/freecol/server/model/TradeSession.java:63: Use bitwise inversion to invert boolean values +src/net/sf/freecol/server/model/TradeSession.java:69: Avoid variables with short names like cs +src/net/sf/freecol/server/model/TradeSession.java:69: Overriding method merely calls super +src/net/sf/freecol/server/model/TradeSession.java:69: Overriding method merely calls super +src/net/sf/freecol/server/model/TradeSession.java:69: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/TradeSession.java:69: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:73: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:77: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/server/model/TradeSession.java:77: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:81: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/server/model/TradeSession.java:81: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:85: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/server/model/TradeSession.java:85: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:89: A getX() method which returns a boolean should be named isX() +src/net/sf/freecol/server/model/TradeSession.java:89: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:93: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:98: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TradeSession.java:103: publicMethodCommentRequirement Required +src/net/sf/freecol/server/model/TransactionSession.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/model/TransactionSession.java:33: Abstract classes should be named AbstractXXX +src/net/sf/freecol/server/model/TransactionSession.java:33: This abstract class does not have any abstract methods +src/net/sf/freecol/server/model/TransactionSession.java:35: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/model/TransactionSession.java:35: fieldCommentRequirement Required +src/net/sf/freecol/server/model/TransactionSession.java:40: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/server/model/TransactionSession.java:40: Variables that are final and static should be all capitals, 'allSessions' is not all capitals. +src/net/sf/freecol/server/model/TransactionSession.java:44: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/model/TransactionSession.java:53: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:59: There is log block not surrounded by if +src/net/sf/freecol/server/model/TransactionSession.java:70: Avoid variables with short names like cs +src/net/sf/freecol/server/model/TransactionSession.java:70: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:82: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:83: Avoid variables with short names like o1 +src/net/sf/freecol/server/model/TransactionSession.java:83: Avoid variables with short names like o2 +src/net/sf/freecol/server/model/TransactionSession.java:83: Parameter 'o1' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:83: Parameter 'o2' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:95: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:96: Avoid variables with short names like o1 +src/net/sf/freecol/server/model/TransactionSession.java:96: Parameter 'o1' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:97: Avoid variables with short names like o2 +src/net/sf/freecol/server/model/TransactionSession.java:97: Parameter 'o2' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:109: Avoid variables with short names like cs +src/net/sf/freecol/server/model/TransactionSession.java:109: Found 'UR'-anomaly for variable 'ts' (lines '109'-'111'). +src/net/sf/freecol/server/model/TransactionSession.java:109: Parameter 'cs' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:110: Local variable 'ts' could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:111: Avoid using if statements without curly braces +src/net/sf/freecol/server/model/TransactionSession.java:131: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:132: Avoid variables with short names like o1 +src/net/sf/freecol/server/model/TransactionSession.java:132: Avoid variables with short names like o2 +src/net/sf/freecol/server/model/TransactionSession.java:132: Parameter 'o1' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:132: Parameter 'o2' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:136: Comment is too large: Too many lines +src/net/sf/freecol/server/model/TransactionSession.java:146: Parameter 'type' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:147: Avoid variables with short names like s1 +src/net/sf/freecol/server/model/TransactionSession.java:147: Avoid variables with short names like s2 +src/net/sf/freecol/server/model/TransactionSession.java:147: Parameter 's1' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:147: Parameter 's2' is not assigned and could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:148: Local variable 'key' could be declared final +src/net/sf/freecol/server/model/TransactionSession.java:149: Avoid variables with short names like ts +src/net/sf/freecol/server/model/TransactionSession.java:152: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/model/TransactionSession.java:154: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/networking/DummyConnection.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/networking/DummyConnection.java:37: Avoid excessively long variable names like outgoingMessageHandler +src/net/sf/freecol/server/networking/DummyConnection.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/networking/DummyConnection.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/networking/DummyConnection.java:39: fieldCommentRequirement Required +src/net/sf/freecol/server/networking/DummyConnection.java:48: Avoid excessively long variable names like incomingMessageHandler +src/net/sf/freecol/server/networking/DummyConnection.java:48: Parameter 'incomingMessageHandler' is not assigned and could be declared final +src/net/sf/freecol/server/networking/DummyConnection.java:48: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/server/networking/DummyConnection.java:59: Avoid variables with short names like mh +src/net/sf/freecol/server/networking/DummyConnection.java:59: Parameter 'mh' is not assigned and could be declared final +src/net/sf/freecol/server/networking/DummyConnection.java:68: Avoid variables with short names like dc +src/net/sf/freecol/server/networking/DummyConnection.java:68: Parameter 'dc' is not assigned and could be declared final +src/net/sf/freecol/server/networking/DummyConnection.java:90: Comment is too large: Too many lines +src/net/sf/freecol/server/networking/DummyConnection.java:100: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/networking/DummyConnection.java:104: Avoid empty catch blocks +src/net/sf/freecol/server/networking/DummyConnection.java:104: Avoid empty catch blocks +src/net/sf/freecol/server/networking/DummyConnection.java:108: Comment is too large: Too many lines +src/net/sf/freecol/server/networking/DummyConnection.java:119: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/networking/DummyConnection.java:123: Comment is too large: Too many lines +src/net/sf/freecol/server/networking/DummyConnection.java:133: Parameter 'request' is not assigned and could be declared final +src/net/sf/freecol/server/networking/DummyConnection.java:141: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/server/networking/Server.java:1: Comment is too large: Too many lines +src/net/sf/freecol/server/networking/Server.java:39: Comment is too large: Too many lines +src/net/sf/freecol/server/networking/Server.java:51: To be compliant to J2EE, a webapp should not use any thread. +src/net/sf/freecol/server/networking/Server.java:53: Variables that are final and static should be all capitals, 'logger' is not all capitals. +src/net/sf/freecol/server/networking/Server.java:53: fieldCommentRequirement Required +src/net/sf/freecol/server/networking/Server.java:59: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/networking/Server.java:62: Avoid using implementation types like 'HashMap'; use the interface instead +src/net/sf/freecol/server/networking/Server.java:62: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/networking/Server.java:68: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/networking/Server.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/networking/Server.java:80: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/server/networking/Server.java:83: Comment is too large: Too many lines +src/net/sf/freecol/server/networking/Server.java:92: Parameter 'freeColServer' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:92: Parameter 'host' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:93: Parameter 'port' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:130: Parameter 'socket' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:139: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:140: Avoid using if statements without curly braces +src/net/sf/freecol/server/networking/Server.java:149: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:150: Avoid using if statements without curly braces +src/net/sf/freecol/server/networking/Server.java:159: Parameter 'connection' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:168: Avoid variables with short names like mh +src/net/sf/freecol/server/networking/Server.java:168: Found 'UR'-anomaly for variable 'c' (lines '168'-'170'). +src/net/sf/freecol/server/networking/Server.java:168: Parameter 'mh' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:169: Local variable 'c' could be declared final +src/net/sf/freecol/server/networking/Server.java:181: Found 'UR'-anomaly for variable 'c' (lines '181'-'183'). +src/net/sf/freecol/server/networking/Server.java:181: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:181: Parameter 'exceptConnection' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:182: Local variable 'c' could be declared final +src/net/sf/freecol/server/networking/Server.java:183: Avoid using if statements without curly braces +src/net/sf/freecol/server/networking/Server.java:183: Use equals() to compare object references. +src/net/sf/freecol/server/networking/Server.java:188: There is log block not surrounded by if +src/net/sf/freecol/server/networking/Server.java:191: There is log block not surrounded by if +src/net/sf/freecol/server/networking/Server.java:202: Parameter 'element' is not assigned and could be declared final +src/net/sf/freecol/server/networking/Server.java:230: Found 'DD'-anomaly for variable 'clientSocket' (lines '230'-'232'). +src/net/sf/freecol/server/networking/Server.java:234: There is log block not surrounded by if +src/net/sf/freecol/server/networking/Server.java:234: There is log block not surrounded by if +src/net/sf/freecol/server/networking/Server.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/networking/Server.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/server/networking/Server.java:237: Local variable 'connection' could be declared final +src/net/sf/freecol/server/networking/Server.java:238: Avoid instantiating new objects inside loops +src/net/sf/freecol/server/networking/Server.java:254: Found 'UR'-anomaly for variable 'c' (lines '254'-'270'). +src/net/sf/freecol/server/networking/Server.java:269: Local variable 'c' could be declared final +src/net/sf/freecol/server/networking/Server.java:270: Avoid using if statements without curly braces +src/net/sf/freecol/tools/ColonizationMapReader.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/ColonizationMapReader.java:26: Comment is too large: Too many lines +src/net/sf/freecol/tools/ColonizationMapReader.java:59: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/ColonizationMapReader.java:59: The class 'ColonizationMapReader' has a Cyclomatic Complexity of 16 (Highest = 15). +src/net/sf/freecol/tools/ColonizationMapReader.java:59: The class 'ColonizationMapReader' has a Modified Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/tools/ColonizationMapReader.java:59: The class 'ColonizationMapReader' has a Standard Cyclomatic Complexity of 15 (Highest = 14). +src/net/sf/freecol/tools/ColonizationMapReader.java:61: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationMapReader.java:62: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationMapReader.java:64: Variables that are final and static should be all capitals, 'tiletypes' is not all capitals. +src/net/sf/freecol/tools/ColonizationMapReader.java:64: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationMapReader.java:103: Variables that are final and static should be all capitals, 'header' is not all capitals. +src/net/sf/freecol/tools/ColonizationMapReader.java:103: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationMapReader.java:106: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationMapReader.java:108: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/ColonizationMapReader.java:108: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/ColonizationMapReader.java:108: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:108: The method 'main' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/tools/ColonizationMapReader.java:108: The method 'main' has a Standard Cyclomatic Complexity of 14. +src/net/sf/freecol/tools/ColonizationMapReader.java:108: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationMapReader.java:111: Local variable 'writer' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:112: Local variable 'width' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:113: Local variable 'height' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:114: Local variable 'size' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:116: System.arraycopy is more efficient +src/net/sf/freecol/tools/ColonizationMapReader.java:120: Local variable 'ROWS' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:120: Variables should start with a lowercase character, 'ROWS' starts with uppercase character. +src/net/sf/freecol/tools/ColonizationMapReader.java:121: Found 'DU'-anomaly for variable 'COLUMNS' (lines '121'-'175'). +src/net/sf/freecol/tools/ColonizationMapReader.java:121: Local variable 'COLUMNS' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:121: Variables should start with a lowercase character, 'COLUMNS' starts with uppercase character. +src/net/sf/freecol/tools/ColonizationMapReader.java:122: Found 'DU'-anomaly for variable 'offset' (lines '122'-'175'). +src/net/sf/freecol/tools/ColonizationMapReader.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ColonizationMapReader.java:136: Local variable 'reader' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ColonizationMapReader.java:139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/ColonizationMapReader.java:139: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/ColonizationMapReader.java:139: System.out.println is used +src/net/sf/freecol/tools/ColonizationMapReader.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/ColonizationMapReader.java:140: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/ColonizationMapReader.java:140: System.out.println is used +src/net/sf/freecol/tools/ColonizationMapReader.java:142: Local variable 'size' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:144: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ColonizationMapReader.java:149: Local variable 'decimal' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:150: Found 'DD'-anomaly for variable 'terrain' (lines '150'-'153'). +src/net/sf/freecol/tools/ColonizationMapReader.java:150: Found 'DD'-anomaly for variable 'terrain' (lines '150'-'155'). +src/net/sf/freecol/tools/ColonizationMapReader.java:150: Found 'DD'-anomaly for variable 'terrain' (lines '150'-'157'). +src/net/sf/freecol/tools/ColonizationMapReader.java:150: Found 'DD'-anomaly for variable 'terrain' (lines '150'-'159'). +src/net/sf/freecol/tools/ColonizationMapReader.java:150: Found 'DD'-anomaly for variable 'terrain' (lines '150'-'161'). +src/net/sf/freecol/tools/ColonizationMapReader.java:150: Found 'DD'-anomaly for variable 'terrain' (lines '150'-'163'). +src/net/sf/freecol/tools/ColonizationMapReader.java:151: Local variable 'overlay' could be declared final +src/net/sf/freecol/tools/ColonizationMapReader.java:167: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/tools/ColonizationMapReader.java:167: An empty statement (semicolon) not part of a loop +src/net/sf/freecol/tools/ColonizationMapReader.java:168: System.out.print is used +src/net/sf/freecol/tools/ColonizationMapReader.java:169: Found 'DU'-anomaly for variable 'index' (lines '169'-'175'). +src/net/sf/freecol/tools/ColonizationMapReader.java:171: System.out.println is used +src/net/sf/freecol/tools/ColonizationMapReader.java:173: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:28: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:29: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:30: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:34: headerCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:36: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:36: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:37: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:38: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:39: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:41: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:41: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:41: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:48: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:49: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:50: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:51: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:54: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:59: headerCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:61: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:63: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:63: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:64: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:64: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:65: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:65: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:67: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:67: Parameter 'offset' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:67: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:70: Useless parentheses. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:70: Useless parentheses. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:73: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:74: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:76: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:81: headerCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:83: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:84: Avoid excessively long variable names like COLONIST_OCCUPATION +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:84: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:85: Avoid excessively long variable names like COLONIST_SPECIALITY +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:85: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:86: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:88: Avoid variables with short names like x +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:88: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:88: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:89: Avoid variables with short names like y +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:89: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:89: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:90: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:90: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:91: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:91: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:92: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:92: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:94: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:94: Parameter 'offset' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:94: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:108: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:116: Found 'UR'-anomaly for variable 'colonist' (lines '116'-'120'). +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:116: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:117: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:119: Local variable 'colonist' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:125: headerCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:127: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:127: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:161: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:161: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:165: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:165: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:165: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:166: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:166: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:166: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:167: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:167: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:167: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:169: Parameter 'occupation' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:169: Parameter 'speciality' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:169: Parameter 'tile' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:169: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:175: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:176: Local variable 'tileString' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:176: Useless parentheses. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:176: Useless parentheses. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:178: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:178: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:185: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:185: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:185: fieldCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:187: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:187: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:187: The user-supplied array 'data' is stored directly. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:187: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:191: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:191: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:191: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:191: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:204: Local variable 'gameData' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:207: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:207: System.out.println is used +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:208: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:208: Local variable 'playerData' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:212: Local variable 'count' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:214: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:214: Local variable 'colonyData' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:222: Parameter 'data' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:222: Parameter 'length' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:222: Parameter 'start' is not assigned and could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:222: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:223: Local variable 'bytes' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:224: Local variable 'value' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:225: Local variable 'index' could be declared final +src/net/sf/freecol/tools/ColonizationSaveGameReader.java:227: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/tools/DesktopEntry.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/DesktopEntry.java:32: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/DesktopEntry.java:32: The class 'DesktopEntry' has a Cyclomatic Complexity of 13 (Highest = 12). +src/net/sf/freecol/tools/DesktopEntry.java:32: The class 'DesktopEntry' has a Modified Cyclomatic Complexity of 11 (Highest = 10). +src/net/sf/freecol/tools/DesktopEntry.java:32: The class 'DesktopEntry' has a Standard Cyclomatic Complexity of 12 (Highest = 11). +src/net/sf/freecol/tools/DesktopEntry.java:34: fieldCommentRequirement Required +src/net/sf/freecol/tools/DesktopEntry.java:37: fieldCommentRequirement Required +src/net/sf/freecol/tools/DesktopEntry.java:39: fieldCommentRequirement Required +src/net/sf/freecol/tools/DesktopEntry.java:45: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/DesktopEntry.java:45: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/DesktopEntry.java:45: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:45: The method 'main' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/tools/DesktopEntry.java:45: The method 'main' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/tools/DesktopEntry.java:45: The method 'main' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/tools/DesktopEntry.java:48: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:49: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:50: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:51: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:52: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:53: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:54: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:56: Found 'DU'-anomaly for variable 'sourceFiles' (lines '56'-'115'). +src/net/sf/freecol/tools/DesktopEntry.java:56: Found 'DU'-anomaly for variable 'sourceFiles' (lines '56'-'115'). +src/net/sf/freecol/tools/DesktopEntry.java:56: Local variable 'sourceFiles' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:58: Parameter 'dir' is not assigned and could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:58: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:58: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/DesktopEntry.java:64: Local variable 'name' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:66: System.out.println is used +src/net/sf/freecol/tools/DesktopEntry.java:69: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:70: Local variable 'index' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:70: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:71: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/DesktopEntry.java:71: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:77: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/DesktopEntry.java:77: Local variable 'sourceFile' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:78: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/DesktopEntry.java:78: Local variable 'fileReader' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:79: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/DesktopEntry.java:79: Local variable 'bufferedReader' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:82: Local variable 'index' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:82: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:84: Local variable 'key' could be declared final +src/net/sf/freecol/tools/DesktopEntry.java:84: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/DesktopEntry.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:85: A switch statement does not contain a break +src/net/sf/freecol/tools/DesktopEntry.java:85: Avoid using if statements without curly braces +src/net/sf/freecol/tools/DesktopEntry.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/DesktopEntry.java:102: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/DesktopEntry.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:102: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:103: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:108: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/DesktopEntry.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/FSGConverter.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/FSGConverter.java:41: A class which only has private constructors should be final +src/net/sf/freecol/tools/FSGConverter.java:41: The class 'FSGConverter' has a Cyclomatic Complexity of 5 (Highest = 15). +src/net/sf/freecol/tools/FSGConverter.java:41: The class 'FSGConverter' has a Modified Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/tools/FSGConverter.java:41: The class 'FSGConverter' has a Standard Cyclomatic Complexity of 4 (Highest = 12). +src/net/sf/freecol/tools/FSGConverter.java:64: Singleton is not thread safe +src/net/sf/freecol/tools/FSGConverter.java:71: Comment is too large: Too many lines +src/net/sf/freecol/tools/FSGConverter.java:87: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/tools/FSGConverter.java:87: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/tools/FSGConverter.java:87: Avoid variables with short names like in +src/net/sf/freecol/tools/FSGConverter.java:87: Parameter 'in' is not assigned and could be declared final +src/net/sf/freecol/tools/FSGConverter.java:87: Parameter 'out' is not assigned and could be declared final +src/net/sf/freecol/tools/FSGConverter.java:96: Comment is too large: Too many lines +src/net/sf/freecol/tools/FSGConverter.java:112: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/tools/FSGConverter.java:112: Avoid prefixing parameters by in, out or inOut. Uses Javadoc to document this behavior. +src/net/sf/freecol/tools/FSGConverter.java:112: Avoid reassigning parameters such as 'in' +src/net/sf/freecol/tools/FSGConverter.java:112: Avoid reassigning parameters such as 'in' +src/net/sf/freecol/tools/FSGConverter.java:112: Avoid reassigning parameters such as 'out' +src/net/sf/freecol/tools/FSGConverter.java:112: Avoid variables with short names like in +src/net/sf/freecol/tools/FSGConverter.java:112: The method 'convertToXML' has a Cyclomatic Complexity of 15. +src/net/sf/freecol/tools/FSGConverter.java:112: The method 'convertToXML' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/tools/FSGConverter.java:112: The method 'convertToXML' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/tools/FSGConverter.java:119: Local variable 'buf' could be declared final +src/net/sf/freecol/tools/FSGConverter.java:122: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/FSGConverter.java:127: Found 'DU'-anomaly for variable 'indent' (lines '127'-'168'). +src/net/sf/freecol/tools/FSGConverter.java:128: Avoid variables with short names like i +src/net/sf/freecol/tools/FSGConverter.java:129: Avoid assignments in operands +src/net/sf/freecol/tools/FSGConverter.java:129: Found 'DU'-anomaly for variable 'i' (lines '129'-'168'). +src/net/sf/freecol/tools/FSGConverter.java:130: Avoid variables with short names like c +src/net/sf/freecol/tools/FSGConverter.java:131: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/FSGConverter.java:133: Avoid variables with short names like b +src/net/sf/freecol/tools/FSGConverter.java:133: Local variable 'b' could be declared final +src/net/sf/freecol/tools/FSGConverter.java:134: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/FSGConverter.java:147: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/FSGConverter.java:151: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/FSGConverter.java:156: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/FSGConverter.java:175: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:176: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:177: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:178: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:179: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:180: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:181: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:189: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/FSGConverter.java:189: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/FSGConverter.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/FSGConverter.java:190: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/FSGConverter.java:191: Avoid variables with short names like in +src/net/sf/freecol/tools/FSGConverter.java:191: Local variable 'in' could be declared final +src/net/sf/freecol/tools/FSGConverter.java:194: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/FSGConverter.java:197: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/FSGConverter.java:200: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/FSGConverter.java:203: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/tools/FSGConverter.java:208: Local variable 'fsgc' could be declared final +src/net/sf/freecol/tools/FSGConverter.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/FSGConverter.java:211: System.out.println is used +src/net/sf/freecol/tools/FSGConverter.java:212: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/tools/FSGConverter.java:213: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/FSGConverter.java:217: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/FlagTest.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/FlagTest.java:50: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:50: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:62: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:67: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:67: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:69: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:69: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:71: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:71: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:73: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:73: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:75: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:75: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:77: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:77: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:79: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:79: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:81: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:81: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:84: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:84: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:85: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:85: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:86: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:86: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:87: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:87: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:92: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:92: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:100: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/FlagTest.java:100: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/FlagTest.java:100: fieldCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:103: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:152: Local variable 'button' could be declared final +src/net/sf/freecol/tools/FlagTest.java:169: Avoid variables with short names like e +src/net/sf/freecol/tools/FlagTest.java:169: Found 'UR'-anomaly for variable 'position' (lines '169'-'198'). +src/net/sf/freecol/tools/FlagTest.java:169: Parameter 'e' is not assigned and could be declared final +src/net/sf/freecol/tools/FlagTest.java:169: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:170: Local variable 'newBackground' could be declared final +src/net/sf/freecol/tools/FlagTest.java:171: Found 'DU'-anomaly for variable 'newDecoration' (lines '171'-'212'). +src/net/sf/freecol/tools/FlagTest.java:171: Local variable 'newDecoration' could be declared final +src/net/sf/freecol/tools/FlagTest.java:172: Found 'DU'-anomaly for variable 'newPosition' (lines '172'-'212'). +src/net/sf/freecol/tools/FlagTest.java:172: Local variable 'newPosition' could be declared final +src/net/sf/freecol/tools/FlagTest.java:173: Found 'DU'-anomaly for variable 'newShape' (lines '173'-'212'). +src/net/sf/freecol/tools/FlagTest.java:173: Local variable 'newShape' could be declared final +src/net/sf/freecol/tools/FlagTest.java:174: Local variable 'newFlag' could be declared final +src/net/sf/freecol/tools/FlagTest.java:174: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/FlagTest.java:185: Found 'DU'-anomaly for variable 'colors' (lines '185'-'212'). +src/net/sf/freecol/tools/FlagTest.java:185: Local variable 'colors' could be declared final +src/net/sf/freecol/tools/FlagTest.java:187: Local variable 'color' could be declared final +src/net/sf/freecol/tools/FlagTest.java:187: Useless parentheses. +src/net/sf/freecol/tools/FlagTest.java:187: Useless parentheses. +src/net/sf/freecol/tools/FlagTest.java:188: Assigning an Object to null is a code smell. Consider refactoring. +src/net/sf/freecol/tools/FlagTest.java:189: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/FlagTest.java:189: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/FlagTest.java:195: Local variable 'oldPosition' could be declared final +src/net/sf/freecol/tools/FlagTest.java:197: Local variable 'position' could be declared final +src/net/sf/freecol/tools/FlagTest.java:215: Avoid variables with short names like ae +src/net/sf/freecol/tools/FlagTest.java:215: Parameter 'ae' is not assigned and could be declared final +src/net/sf/freecol/tools/FlagTest.java:215: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:216: Local variable 'button' could be declared final +src/net/sf/freecol/tools/FlagTest.java:217: Local variable 'color' could be declared final +src/net/sf/freecol/tools/FlagTest.java:217: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/FlagTest.java:220: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/FlagTest.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/FlagTest.java:226: Found 'UR'-anomaly for variable 'button' (lines '226'-'232'). +src/net/sf/freecol/tools/FlagTest.java:230: Found 'DU'-anomaly for variable 'colors' (lines '230'-'238'). +src/net/sf/freecol/tools/FlagTest.java:230: Local variable 'colors' could be declared final +src/net/sf/freecol/tools/FlagTest.java:231: Local variable 'button' could be declared final +src/net/sf/freecol/tools/FlagTest.java:232: Local variable 'color' could be declared final +src/net/sf/freecol/tools/FlagTest.java:240: Parameter 'count' is not assigned and could be declared final +src/net/sf/freecol/tools/FlagTest.java:240: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:241: Found 'DD'-anomaly for variable 'result' (lines '241'-'243'). +src/net/sf/freecol/tools/FlagTest.java:243: Found 'DD'-anomaly for variable 'result' (lines '243'-'243'). +src/net/sf/freecol/tools/FlagTest.java:248: Found 'UR'-anomaly for variable 'component' (lines '248'-'250'). +src/net/sf/freecol/tools/FlagTest.java:248: Parameter 'components' is not assigned and could be declared final +src/net/sf/freecol/tools/FlagTest.java:248: Parameter 'value' is not assigned and could be declared final +src/net/sf/freecol/tools/FlagTest.java:249: Local variable 'component' could be declared final +src/net/sf/freecol/tools/FlagTest.java:255: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/FlagTest.java:255: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/FlagTest.java:255: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/FlagTest.java:256: Local variable 'frame' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/ForestMaker.java:42: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/ForestMaker.java:42: The class 'ForestMaker' has a Cyclomatic Complexity of 12 (Highest = 31). +src/net/sf/freecol/tools/ForestMaker.java:42: The class 'ForestMaker' has a Modified Cyclomatic Complexity of 9 (Highest = 24). +src/net/sf/freecol/tools/ForestMaker.java:42: The class 'ForestMaker' has a Standard Cyclomatic Complexity of 9 (Highest = 24). +src/net/sf/freecol/tools/ForestMaker.java:44: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:46: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:47: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:48: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:49: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:50: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:51: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:53: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:54: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:56: Avoid unused private fields such as 'LIMIT'. +src/net/sf/freecol/tools/ForestMaker.java:56: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:60: Avoid unused private fields such as 'SLOPE'. +src/net/sf/freecol/tools/ForestMaker.java:60: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:64: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:68: Variables that are final and static should be all capitals, 'drawBorders' is not all capitals. +src/net/sf/freecol/tools/ForestMaker.java:68: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:69: Variables that are final and static should be all capitals, 'drawTrees' is not all capitals. +src/net/sf/freecol/tools/ForestMaker.java:69: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:72: headerCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:74: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ForestMaker.java:74: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/ForestMaker.java:74: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:75: Avoid variables with short names like x +src/net/sf/freecol/tools/ForestMaker.java:75: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ForestMaker.java:75: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/ForestMaker.java:75: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:76: Avoid variables with short names like y +src/net/sf/freecol/tools/ForestMaker.java:76: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/ForestMaker.java:76: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/ForestMaker.java:76: fieldCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:79: Avoid variables with short names like x +src/net/sf/freecol/tools/ForestMaker.java:79: Avoid variables with short names like y +src/net/sf/freecol/tools/ForestMaker.java:79: Parameter 'image' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:79: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:79: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:79: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:88: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:88: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/ForestMaker.java:89: Avoid variables with short names like dy +src/net/sf/freecol/tools/ForestMaker.java:89: Local variable 'dy' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:99: Parameter 'other' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:101: A method should have only one exit point, and that should be the last statement in the method +src/net/sf/freecol/tools/ForestMaker.java:111: Found 'DD'-anomaly for variable 'hash' (lines '111'-'112'). +src/net/sf/freecol/tools/ForestMaker.java:122: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/ForestMaker.java:122: Avoid really long methods. +src/net/sf/freecol/tools/ForestMaker.java:122: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/ForestMaker.java:122: Found 'UR'-anomaly for variable 'arg' (lines '122'-'140'). +src/net/sf/freecol/tools/ForestMaker.java:122: Found 'UR'-anomaly for variable 'imageFile' (lines '122'-'163'). +src/net/sf/freecol/tools/ForestMaker.java:122: Found 'UR'-anomaly for variable 'imageLocation' (lines '122'-'301'). +src/net/sf/freecol/tools/ForestMaker.java:122: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:122: The method 'main' has a Cyclomatic Complexity of 31. +src/net/sf/freecol/tools/ForestMaker.java:122: The method 'main' has a Modified Cyclomatic Complexity of 24. +src/net/sf/freecol/tools/ForestMaker.java:122: The method 'main' has a Standard Cyclomatic Complexity of 24. +src/net/sf/freecol/tools/ForestMaker.java:122: The method main() has an NCSS line count of 103 +src/net/sf/freecol/tools/ForestMaker.java:122: The method main() has an NPath complexity of 905570 +src/net/sf/freecol/tools/ForestMaker.java:125: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:126: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:127: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:128: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/ForestMaker.java:131: Local variable 'riverName' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:133: Found 'DD'-anomaly for variable 'river' (lines '133'-'135'). +src/net/sf/freecol/tools/ForestMaker.java:135: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:136: Local variable 'rectangle' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:137: Local variable 'texture' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:139: Local variable 'arg' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:140: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:140: Local variable 'sourceDirectory' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:142: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:145: Local variable 'baseName' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:146: Avoid excessively long variable names like destinationDirectory +src/net/sf/freecol/tools/ForestMaker.java:146: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:146: Local variable 'destinationDirectory' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:148: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:152: Local variable 'imageFiles' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:154: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:157: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:160: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:160: Local variable 'images' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:162: Local variable 'imageFile' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:165: Local variable 'image' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:168: Found 'DD'-anomaly for variable 'maximumHeight' (lines '168'-'161'). +src/net/sf/freecol/tools/ForestMaker.java:168: Found 'DU'-anomaly for variable 'maximumHeight' (lines '168'-'312'). +src/net/sf/freecol/tools/ForestMaker.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:171: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:171: System.out.println is used +src/net/sf/freecol/tools/ForestMaker.java:172: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/tools/ForestMaker.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:176: Local variable 'numberOfImages' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:177: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:177: Local variable 'random' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:179: Comment is too large: Too many lines +src/net/sf/freecol/tools/ForestMaker.java:193: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:193: Local variable 'base' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:195: Avoid variables with short names like g +src/net/sf/freecol/tools/ForestMaker.java:195: Local variable 'g' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:196: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:200: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:200: Found 'DD'-anomaly for variable 'branches' (lines '200'-'204'). +src/net/sf/freecol/tools/ForestMaker.java:204: Found 'DD'-anomaly for variable 'branches' (lines '204'-'204'). +src/net/sf/freecol/tools/ForestMaker.java:205: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/tools/ForestMaker.java:207: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/tools/ForestMaker.java:213: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:213: Local variable 'right' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:214: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:214: Local variable 'left' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:215: Found 'DD'-anomaly for variable 'treeCount' (lines '215'-'219'). +src/net/sf/freecol/tools/ForestMaker.java:218: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:219: Found 'DD'-anomaly for variable 'treeCount' (lines '219'-'223'). +src/net/sf/freecol/tools/ForestMaker.java:222: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:223: Found 'DU'-anomaly for variable 'treeCount' (lines '223'-'312'). +src/net/sf/freecol/tools/ForestMaker.java:227: Avoid variables with short names like dx +src/net/sf/freecol/tools/ForestMaker.java:227: Local variable 'dx' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:228: Avoid variables with short names like dy +src/net/sf/freecol/tools/ForestMaker.java:228: Local variable 'dy' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:237: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:237: Local variable 'trees' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:239: Local variable 'numberOfTrees' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:243: Local variable 'image' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:243: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:244: Local variable 'width' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:244: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:245: Local variable 'height' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:245: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:246: Local variable 'halfWidth' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:252: Avoid variables with short names like a +src/net/sf/freecol/tools/ForestMaker.java:252: Local variable 'a' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:252: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:253: Avoid variables with short names like b +src/net/sf/freecol/tools/ForestMaker.java:253: Local variable 'b' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:253: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:254: Avoid variables with short names like x +src/net/sf/freecol/tools/ForestMaker.java:255: Avoid variables with short names like y +src/net/sf/freecol/tools/ForestMaker.java:255: Local variable 'y' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:272: Local variable 'crown' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:294: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:300: Local variable 'imageLocation' could be declared final +src/net/sf/freecol/tools/ForestMaker.java:301: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:305: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:307: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/ForestMaker.java:308: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/ForestMaker.java:314: Avoid unused private methods such as 'getY(int,int,double,int)'. +src/net/sf/freecol/tools/ForestMaker.java:314: Avoid variables with short names like x +src/net/sf/freecol/tools/ForestMaker.java:314: Avoid variables with short names like y +src/net/sf/freecol/tools/ForestMaker.java:314: Parameter 'newX' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:314: Parameter 'slope' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:314: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:314: Parameter 'y' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:318: Avoid unused private methods such as 'getRandomY(Random,int)'. +src/net/sf/freecol/tools/ForestMaker.java:318: Avoid variables with short names like x +src/net/sf/freecol/tools/ForestMaker.java:318: Parameter 'random' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:318: Parameter 'x' is not assigned and could be declared final +src/net/sf/freecol/tools/ForestMaker.java:319: Local variable 'height' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/GenerateDocumentation.java:46: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/GenerateDocumentation.java:46: The class 'GenerateDocumentation' has a Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/tools/GenerateDocumentation.java:46: The class 'GenerateDocumentation' has a Modified Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/tools/GenerateDocumentation.java:46: The class 'GenerateDocumentation' has a Standard Cyclomatic Complexity of 4 (Highest = 11). +src/net/sf/freecol/tools/GenerateDocumentation.java:48: fieldCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:50: fieldCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:52: fieldCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:54: Avoid excessively long variable names like DESTINATION_DIRECTORY +src/net/sf/freecol/tools/GenerateDocumentation.java:54: fieldCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:57: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/tools/GenerateDocumentation.java:57: Variables that are final and static should be all capitals, 'resources' is not all capitals. +src/net/sf/freecol/tools/GenerateDocumentation.java:57: fieldCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:59: Variables that are final and static should be all capitals, 'sourceFiles' is not all capitals. +src/net/sf/freecol/tools/GenerateDocumentation.java:59: fieldCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:62: Parameter 'dir' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:62: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:62: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:70: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/GenerateDocumentation.java:70: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/GenerateDocumentation.java:70: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:70: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:80: Found 'UR'-anomaly for variable 'sourceFile' (lines '80'-'80'). +src/net/sf/freecol/tools/GenerateDocumentation.java:81: System.out.println is used +src/net/sf/freecol/tools/GenerateDocumentation.java:82: Found 'DU'-anomaly for variable 'sourceFile' (lines '82'-'100'). +src/net/sf/freecol/tools/GenerateDocumentation.java:82: Local variable 'sourceFile' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:89: Local variable 'index' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:89: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:91: Local variable 'key' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:91: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:91: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:92: Local variable 'value' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:92: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:97: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/tools/GenerateDocumentation.java:98: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/tools/GenerateDocumentation.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:103: Avoid unused private methods such as 'generateTMX()'. +src/net/sf/freecol/tools/GenerateDocumentation.java:103: Found 'UR'-anomaly for variable 'destinationFile' (lines '103'-'103'). +src/net/sf/freecol/tools/GenerateDocumentation.java:103: Found 'UR'-anomaly for variable 'name' (lines '103'-'109'). +src/net/sf/freecol/tools/GenerateDocumentation.java:103: Found 'UR'-anomaly for variable 'sourceFile' (lines '103'-'103'). +src/net/sf/freecol/tools/GenerateDocumentation.java:103: Found 'UR'-anomaly for variable 'tu' (lines '103'-'155'). +src/net/sf/freecol/tools/GenerateDocumentation.java:103: Found 'UR'-anomaly for variable 'tuv' (lines '103'-'157'). +src/net/sf/freecol/tools/GenerateDocumentation.java:103: The method 'generateTMX' has a Cyclomatic Complexity of 11. +src/net/sf/freecol/tools/GenerateDocumentation.java:103: The method 'generateTMX' has a Modified Cyclomatic Complexity of 11. +src/net/sf/freecol/tools/GenerateDocumentation.java:103: The method 'generateTMX' has a Standard Cyclomatic Complexity of 11. +src/net/sf/freecol/tools/GenerateDocumentation.java:105: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/tools/GenerateDocumentation.java:105: Local variable 'translations' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:107: Local variable 'name' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:109: System.out.println is used +src/net/sf/freecol/tools/GenerateDocumentation.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:113: Found 'DU'-anomaly for variable 'languageCode' (lines '113'-'169'). +src/net/sf/freecol/tools/GenerateDocumentation.java:114: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/GenerateDocumentation.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:121: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/GenerateDocumentation.java:121: Found 'DD'-anomaly for variable 'sourceFile' (lines '121'-'121'). +src/net/sf/freecol/tools/GenerateDocumentation.java:121: Found 'DU'-anomaly for variable 'sourceFile' (lines '121'-'169'). +src/net/sf/freecol/tools/GenerateDocumentation.java:121: Local variable 'sourceFile' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:124: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/GenerateDocumentation.java:125: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/GenerateDocumentation.java:127: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:129: Local variable 'index' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:129: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:131: Local variable 'key' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:131: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:131: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:132: Local variable 'value' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:132: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:132: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:134: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:136: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/GenerateDocumentation.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:143: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/tools/GenerateDocumentation.java:143: Avoid empty catch blocks +src/net/sf/freecol/tools/GenerateDocumentation.java:143: Avoid empty catch blocks +src/net/sf/freecol/tools/GenerateDocumentation.java:147: Found 'DU'-anomaly for variable 'destinationFile' (lines '147'-'169'). +src/net/sf/freecol/tools/GenerateDocumentation.java:147: Local variable 'destinationFile' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:152: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:154: Local variable 'tu' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:154: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:155: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:156: Local variable 'tuv' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:156: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/GenerateDocumentation.java:157: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:158: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:159: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:166: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/tools/GenerateDocumentation.java:167: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/tools/GenerateDocumentation.java:167: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:171: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/GenerateDocumentation.java:171: Found 'UR'-anomaly for variable 'name' (lines '171'-'174'). +src/net/sf/freecol/tools/GenerateDocumentation.java:171: Parameter 'languages' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:171: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:172: Local variable 'name' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:177: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/GenerateDocumentation.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:180: System.out.println is used +src/net/sf/freecol/tools/GenerateDocumentation.java:189: System.out.println is used +src/net/sf/freecol/tools/GenerateDocumentation.java:194: Local variable 'factory' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:195: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/GenerateDocumentation.java:195: Local variable 'xsl' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:198: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:200: System.err.println is used +src/net/sf/freecol/tools/GenerateDocumentation.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:202: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/tools/GenerateDocumentation.java:202: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:206: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/GenerateDocumentation.java:206: Local variable 'request' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:207: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/GenerateDocumentation.java:207: Local variable 'response' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:209: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:212: Avoid printStackTrace(); use a logger call instead. +src/net/sf/freecol/tools/GenerateDocumentation.java:212: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/GenerateDocumentation.java:218: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:218: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:222: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:222: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:226: Parameter 'key' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:226: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:226: Parameter 'template' is not assigned and could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:226: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/GenerateDocumentation.java:227: Local variable 'num' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:228: Local variable 'stringTemplate' could be declared final +src/net/sf/freecol/tools/GenerateDocumentation.java:228: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/InstallerTranslations.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/InstallerTranslations.java:34: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/InstallerTranslations.java:34: The class 'InstallerTranslations' has a Cyclomatic Complexity of 8 (Highest = 12). +src/net/sf/freecol/tools/InstallerTranslations.java:34: The class 'InstallerTranslations' has a Modified Cyclomatic Complexity of 8 (Highest = 12). +src/net/sf/freecol/tools/InstallerTranslations.java:34: The class 'InstallerTranslations' has a Standard Cyclomatic Complexity of 8 (Highest = 12). +src/net/sf/freecol/tools/InstallerTranslations.java:36: fieldCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:38: fieldCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:40: Avoid excessively long variable names like DESTINATION_DIRECTORY +src/net/sf/freecol/tools/InstallerTranslations.java:40: fieldCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:42: Avoid unused private fields such as 'LANGUAGE_CODES'. +src/net/sf/freecol/tools/InstallerTranslations.java:42: fieldCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:46: fieldCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:75: fieldCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:100: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/InstallerTranslations.java:100: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/InstallerTranslations.java:100: Found 'UR'-anomaly for variable 'destinationFile' (lines '100'-'100'). +src/net/sf/freecol/tools/InstallerTranslations.java:100: Found 'UR'-anomaly for variable 'destinationFile' (lines '100'-'100'). +src/net/sf/freecol/tools/InstallerTranslations.java:100: Found 'UR'-anomaly for variable 'mapping' (lines '100'-'121'). +src/net/sf/freecol/tools/InstallerTranslations.java:100: Found 'UR'-anomaly for variable 'mapping' (lines '100'-'121'). +src/net/sf/freecol/tools/InstallerTranslations.java:100: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:100: The method 'main' has a Cyclomatic Complexity of 12. +src/net/sf/freecol/tools/InstallerTranslations.java:100: The method 'main' has a Modified Cyclomatic Complexity of 12. +src/net/sf/freecol/tools/InstallerTranslations.java:100: The method 'main' has a Standard Cyclomatic Complexity of 12. +src/net/sf/freecol/tools/InstallerTranslations.java:100: The method main() has an NPath complexity of 392 +src/net/sf/freecol/tools/InstallerTranslations.java:100: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:110: System.out.println is used +src/net/sf/freecol/tools/InstallerTranslations.java:111: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/InstallerTranslations.java:119: Found 'DU'-anomaly for variable 'languageMappings' (lines '119'-'187'). +src/net/sf/freecol/tools/InstallerTranslations.java:119: Found 'DU'-anomaly for variable 'languageMappings' (lines '119'-'187'). +src/net/sf/freecol/tools/InstallerTranslations.java:119: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/tools/InstallerTranslations.java:119: Local variable 'languageMappings' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:120: Local variable 'mapping' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/InstallerTranslations.java:121: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/InstallerTranslations.java:121: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:123: Found 'DU'-anomaly for variable 'mainProperties' (lines '123'-'187'). +src/net/sf/freecol/tools/InstallerTranslations.java:123: Found 'DU'-anomaly for variable 'mainProperties' (lines '123'-'187'). +src/net/sf/freecol/tools/InstallerTranslations.java:123: Local variable 'mainProperties' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:126: Found 'DU'-anomaly for variable 'sourceFiles' (lines '126'-'187'). +src/net/sf/freecol/tools/InstallerTranslations.java:126: Found 'DU'-anomaly for variable 'sourceFiles' (lines '126'-'187'). +src/net/sf/freecol/tools/InstallerTranslations.java:126: Local variable 'sourceFiles' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:128: Parameter 'dir' is not assigned and could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:128: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:128: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/InstallerTranslations.java:133: Local variable 'name' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:140: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:142: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:146: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:152: System.out.println is used +src/net/sf/freecol/tools/InstallerTranslations.java:156: System.out.println is used +src/net/sf/freecol/tools/InstallerTranslations.java:158: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/InstallerTranslations.java:158: Local variable 'sourceFile' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:159: Local variable 'sourceProperties' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:160: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/InstallerTranslations.java:160: Local variable 'output' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:160: StringBuffer constructor is initialized with size 16, but has at least 228 characters appended. +src/net/sf/freecol/tools/InstallerTranslations.java:161: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:161: StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. +src/net/sf/freecol/tools/InstallerTranslations.java:161: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/InstallerTranslations.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:162: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/InstallerTranslations.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:163: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/InstallerTranslations.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:164: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/InstallerTranslations.java:165: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:165: StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. +src/net/sf/freecol/tools/InstallerTranslations.java:165: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/InstallerTranslations.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:168: Local variable 'key' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:169: Local variable 'longKey' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:170: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:174: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:175: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:180: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:181: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/InstallerTranslations.java:181: Local variable 'destinationFile' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:182: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/InstallerTranslations.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:183: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:189: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:190: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/tools/InstallerTranslations.java:190: Local variable 'result' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:197: Local variable 'index' could be declared final +src/net/sf/freecol/tools/InstallerTranslations.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:199: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:201: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/InstallerTranslations.java:203: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/tools/InstallerTranslations.java:203: Avoid empty catch blocks +src/net/sf/freecol/tools/InstallerTranslations.java:203: Avoid empty catch blocks +src/net/sf/freecol/tools/InstallerTranslations.java:208: Comment is too large: Too many lines +src/net/sf/freecol/tools/MapConverter.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/MapConverter.java:41: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/MapConverter.java:43: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/MapConverter.java:43: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/MapConverter.java:43: Found 'UR'-anomaly for variable 'filename' (lines '43'-'48'). +src/net/sf/freecol/tools/MapConverter.java:43: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/MapConverter.java:43: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/MapConverter.java:45: Found 'DU'-anomaly for variable 'specification' (lines '45'-'77'). +src/net/sf/freecol/tools/MapConverter.java:45: Local variable 'specification' could be declared final +src/net/sf/freecol/tools/MapConverter.java:47: Local variable 'filename' could be declared final +src/net/sf/freecol/tools/MapConverter.java:48: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MapConverter.java:48: Local variable 'out' could be declared final +src/net/sf/freecol/tools/MapConverter.java:49: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MapConverter.java:51: Local variable 'newName' could be declared final +src/net/sf/freecol/tools/MapConverter.java:52: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MapConverter.java:52: Avoid variables with short names like in +src/net/sf/freecol/tools/MapConverter.java:52: Local variable 'in' could be declared final +src/net/sf/freecol/tools/MapConverter.java:53: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MapConverter.java:54: System.out.println is used +src/net/sf/freecol/tools/MapConverter.java:55: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MapConverter.java:55: Local variable 'savegame' could be declared final +src/net/sf/freecol/tools/MapConverter.java:56: Found 'DD'-anomaly for variable 'thumbnail' (lines '56'-'58'). +src/net/sf/freecol/tools/MapConverter.java:58: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MapConverter.java:59: System.out.println is used +src/net/sf/freecol/tools/MapConverter.java:61: System.out.println is used +src/net/sf/freecol/tools/MapConverter.java:63: Local variable 'server' could be declared final +src/net/sf/freecol/tools/MapConverter.java:64: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MapConverter.java:67: System.out.println is used +src/net/sf/freecol/tools/MapConverter.java:69: System.out.println is used +src/net/sf/freecol/tools/MapConverter.java:71: System.out.println is used +src/net/sf/freecol/tools/MapConverter.java:73: System.out.println is used +src/net/sf/freecol/tools/MergeTranslations.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/MergeTranslations.java:39: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/MergeTranslations.java:39: The class 'MergeTranslations' has a Cyclomatic Complexity of 8 (Highest = 10). +src/net/sf/freecol/tools/MergeTranslations.java:39: The class 'MergeTranslations' has a Modified Cyclomatic Complexity of 8 (Highest = 10). +src/net/sf/freecol/tools/MergeTranslations.java:39: The class 'MergeTranslations' has a Standard Cyclomatic Complexity of 8 (Highest = 10). +src/net/sf/freecol/tools/MergeTranslations.java:41: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/MergeTranslations.java:41: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/MergeTranslations.java:41: Found 'UR'-anomaly for variable 'sourceFile' (lines '41'-'41'). +src/net/sf/freecol/tools/MergeTranslations.java:41: Found 'UR'-anomaly for variable 'sourceFile' (lines '41'-'41'). +src/net/sf/freecol/tools/MergeTranslations.java:41: Found 'UR'-anomaly for variable 'targetFile' (lines '41'-'41'). +src/net/sf/freecol/tools/MergeTranslations.java:41: Found 'UR'-anomaly for variable 'targetFile' (lines '41'-'41'). +src/net/sf/freecol/tools/MergeTranslations.java:41: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:41: The method 'main' has a Cyclomatic Complexity of 10. +src/net/sf/freecol/tools/MergeTranslations.java:41: The method 'main' has a Modified Cyclomatic Complexity of 10. +src/net/sf/freecol/tools/MergeTranslations.java:41: The method 'main' has a Standard Cyclomatic Complexity of 10. +src/net/sf/freecol/tools/MergeTranslations.java:41: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/MergeTranslations.java:43: Local variable 'sourceDirectory' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:44: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:45: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/MergeTranslations.java:48: Local variable 'targetDirectory' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:49: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:50: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/MergeTranslations.java:54: Found 'DU'-anomaly for variable 'sourceFiles' (lines '54'-'104'). +src/net/sf/freecol/tools/MergeTranslations.java:54: Found 'DU'-anomaly for variable 'sourceFiles' (lines '54'-'104'). +src/net/sf/freecol/tools/MergeTranslations.java:54: Local variable 'sourceFiles' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:56: Parameter 'dir' is not assigned and could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:56: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:56: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/MergeTranslations.java:61: Local variable 'name' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:63: System.out.println is used +src/net/sf/freecol/tools/MergeTranslations.java:65: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MergeTranslations.java:65: Local variable 'sourceFile' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:66: Local variable 'sourceProperties' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:68: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MergeTranslations.java:68: Local variable 'targetFile' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:70: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:71: Local variable 'targetProperties' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:73: Local variable 'missingProperties' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/MergeTranslations.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/MergeTranslations.java:74: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/MergeTranslations.java:74: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:75: Avoid variables with short names like e +src/net/sf/freecol/tools/MergeTranslations.java:75: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:75: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:77: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:78: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MergeTranslations.java:80: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MergeTranslations.java:82: Local variable 'entry' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:83: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:84: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:85: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:91: System.out.println is used +src/net/sf/freecol/tools/MergeTranslations.java:93: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MergeTranslations.java:93: Avoid variables with short names like in +src/net/sf/freecol/tools/MergeTranslations.java:94: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/MergeTranslations.java:95: Avoid variables with short names like c +src/net/sf/freecol/tools/MergeTranslations.java:96: Avoid assignments in operands +src/net/sf/freecol/tools/MergeTranslations.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:97: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:106: Parameter 'file' is not assigned and could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:107: If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation +src/net/sf/freecol/tools/MergeTranslations.java:107: Local variable 'result' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:112: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:114: Local variable 'index' could be declared final +src/net/sf/freecol/tools/MergeTranslations.java:114: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:118: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/MergeTranslations.java:120: Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block +src/net/sf/freecol/tools/MergeTranslations.java:120: Avoid empty catch blocks +src/net/sf/freecol/tools/MergeTranslations.java:120: Avoid empty catch blocks +src/net/sf/freecol/tools/RiverMaker.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/RiverMaker.java:36: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/RiverMaker.java:38: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:39: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:40: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:41: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:43: Avoid unused private fields such as 'EDGE_LENGTH'. +src/net/sf/freecol/tools/RiverMaker.java:43: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:45: Avoid variables with short names like DY +src/net/sf/freecol/tools/RiverMaker.java:45: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:46: Avoid variables with short names like DX +src/net/sf/freecol/tools/RiverMaker.java:46: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:48: Avoid variables with short names like NE +src/net/sf/freecol/tools/RiverMaker.java:48: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:50: Avoid variables with short names like SE +src/net/sf/freecol/tools/RiverMaker.java:50: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:52: Avoid variables with short names like SW +src/net/sf/freecol/tools/RiverMaker.java:52: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:54: Avoid variables with short names like NW +src/net/sf/freecol/tools/RiverMaker.java:54: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:56: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:59: fieldCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:63: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/RiverMaker.java:63: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/RiverMaker.java:63: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/RiverMaker.java:63: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/RiverMaker.java:65: Local variable 'riverName' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:67: Local variable 'riverDir' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:68: Found 'DD'-anomaly for variable 'river' (lines '68'-'70'). +src/net/sf/freecol/tools/RiverMaker.java:70: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:71: Local variable 'rectangle' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:71: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:71: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:72: Local variable 'texture' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:73: Found 'DU'-anomaly for variable 'minor' (lines '73'-'150'). +src/net/sf/freecol/tools/RiverMaker.java:73: Local variable 'minor' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:74: Found 'DU'-anomaly for variable 'major' (lines '74'-'150'). +src/net/sf/freecol/tools/RiverMaker.java:74: Local variable 'major' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:92: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/RiverMaker.java:92: Local variable 'result' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:94: Avoid variables with short names like g +src/net/sf/freecol/tools/RiverMaker.java:94: Local variable 'g' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:94: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:95: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:96: Local variable 'name' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:97: Found 'DD'-anomaly for variable 'count' (lines '97'-'97'). +src/net/sf/freecol/tools/RiverMaker.java:97: Found 'DU'-anomaly for variable 'count' (lines '97'-'150'). +src/net/sf/freecol/tools/RiverMaker.java:97: Local variable 'count' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:99: Local variable 'size' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:102: Found 'DD'-anomaly for variable 'next' (lines '102'-'102'). +src/net/sf/freecol/tools/RiverMaker.java:102: Found 'DU'-anomaly for variable 'next' (lines '102'-'150'). +src/net/sf/freecol/tools/RiverMaker.java:102: Local variable 'next' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:103: Local variable 'other' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:104: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/RiverMaker.java:104: Local variable 'bend' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:105: Avoid variables with short names like px +src/net/sf/freecol/tools/RiverMaker.java:105: Found 'DD'-anomaly for variable 'px' (lines '105'-'105'). +src/net/sf/freecol/tools/RiverMaker.java:105: Found 'DU'-anomaly for variable 'px' (lines '105'-'150'). +src/net/sf/freecol/tools/RiverMaker.java:105: Local variable 'px' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:106: Avoid variables with short names like py +src/net/sf/freecol/tools/RiverMaker.java:106: Found 'DD'-anomaly for variable 'py' (lines '106'-'106'). +src/net/sf/freecol/tools/RiverMaker.java:106: Found 'DU'-anomaly for variable 'py' (lines '106'-'150'). +src/net/sf/freecol/tools/RiverMaker.java:106: Local variable 'py' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:107: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:107: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:108: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/RiverMaker.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:115: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:116: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:116: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:120: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:120: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:123: Potential violation of Law of Demeter (method chain calls) +src/net/sf/freecol/tools/RiverMaker.java:123: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:129: Comment is too large: Too many lines +src/net/sf/freecol/tools/RiverMaker.java:145: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/RiverMaker.java:146: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/RiverMaker.java:153: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/RiverMaker.java:155: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/RiverMaker.java:165: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/RiverMaker.java:165: Found 'UR'-anomaly for variable 'branche' (lines '165'-'168'). +src/net/sf/freecol/tools/RiverMaker.java:165: Parameter 'branches' is not assigned and could be declared final +src/net/sf/freecol/tools/RiverMaker.java:166: Found 'DD'-anomaly for variable 'result' (lines '166'-'169'). +src/net/sf/freecol/tools/RiverMaker.java:167: Local variable 'branche' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:169: Found 'DD'-anomaly for variable 'result' (lines '169'-'169'). +src/net/sf/freecol/tools/RiverMaker.java:175: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/RiverMaker.java:175: Found 'UR'-anomaly for variable 'branche' (lines '175'-'178'). +src/net/sf/freecol/tools/RiverMaker.java:175: Parameter 'branches' is not assigned and could be declared final +src/net/sf/freecol/tools/RiverMaker.java:177: Local variable 'branche' could be declared final +src/net/sf/freecol/tools/RiverMaker.java:178: Prefer StringBuffer over += for concatenating strings +src/net/sf/freecol/tools/SaveGameValidator.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/SaveGameValidator.java:42: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/SaveGameValidator.java:42: The class 'SaveGameValidator' has a Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/tools/SaveGameValidator.java:42: The class 'SaveGameValidator' has a Modified Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/tools/SaveGameValidator.java:42: The class 'SaveGameValidator' has a Standard Cyclomatic Complexity of 10 (Highest = 9). +src/net/sf/freecol/tools/SaveGameValidator.java:44: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/SaveGameValidator.java:44: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/SaveGameValidator.java:44: Found 'UR'-anomaly for variable 'file' (lines '44'-'67'). +src/net/sf/freecol/tools/SaveGameValidator.java:44: Found 'UR'-anomaly for variable 'fsg' (lines '44'-'58'). +src/net/sf/freecol/tools/SaveGameValidator.java:44: Found 'UR'-anomaly for variable 'name' (lines '44'-'54'). +src/net/sf/freecol/tools/SaveGameValidator.java:44: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:44: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/SaveGameValidator.java:46: Local variable 'factory' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:47: Local variable 'schemaLocation' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:48: Local variable 'schema' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:49: Found 'DU'-anomaly for variable 'saveGameValidator' (lines '49'-'80'). +src/net/sf/freecol/tools/SaveGameValidator.java:49: Local variable 'saveGameValidator' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:51: Local variable 'allFiles' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:52: Avoid variables with short names like ff +src/net/sf/freecol/tools/SaveGameValidator.java:52: Found 'DU'-anomaly for variable 'ff' (lines '52'-'80'). +src/net/sf/freecol/tools/SaveGameValidator.java:52: Local variable 'ff' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:53: Local variable 'name' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:54: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/SaveGameValidator.java:54: Local variable 'file' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:57: Local variable 'fsg' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:60: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/SaveGameValidator.java:66: Local variable 'file' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:67: System.out.println is used +src/net/sf/freecol/tools/SaveGameValidator.java:69: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/SaveGameValidator.java:69: Local variable 'mapFile' could be declared final +src/net/sf/freecol/tools/SaveGameValidator.java:70: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/SaveGameValidator.java:71: System.out.println is used +src/net/sf/freecol/tools/SaveGameValidator.java:73: System.out.println is used +src/net/sf/freecol/tools/SaveGameValidator.java:77: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:1: Comment is too large: Too many lines +src/net/sf/freecol/tools/TranslationReport.java:34: All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. +src/net/sf/freecol/tools/TranslationReport.java:34: The class 'TranslationReport' has a Cyclomatic Complexity of 12 (Highest = 39). +src/net/sf/freecol/tools/TranslationReport.java:34: The class 'TranslationReport' has a Modified Cyclomatic Complexity of 11 (Highest = 35). +src/net/sf/freecol/tools/TranslationReport.java:34: The class 'TranslationReport' has a Standard Cyclomatic Complexity of 11 (Highest = 35). +src/net/sf/freecol/tools/TranslationReport.java:36: headerCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:37: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/TranslationReport.java:37: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/TranslationReport.java:37: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:38: Avoid using redundant field initializer for 'missingKeys' +src/net/sf/freecol/tools/TranslationReport.java:38: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/TranslationReport.java:38: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/TranslationReport.java:38: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:39: Avoid using redundant field initializer for 'missingVariables' +src/net/sf/freecol/tools/TranslationReport.java:39: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/TranslationReport.java:39: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/TranslationReport.java:39: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:40: Avoid using redundant field initializer for 'copiedKeys' +src/net/sf/freecol/tools/TranslationReport.java:40: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/TranslationReport.java:40: Use explicit scoping instead of the default package private level +src/net/sf/freecol/tools/TranslationReport.java:40: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:41: Avoid excessively long variable names like superfluousVariables +src/net/sf/freecol/tools/TranslationReport.java:41: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/TranslationReport.java:41: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:42: Found non-transient, non-static member. Please mark as transient or provide accessors. +src/net/sf/freecol/tools/TranslationReport.java:42: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:45: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/tools/TranslationReport.java:45: Variables that are final and static should be all capitals, 'stars' is not all capitals. +src/net/sf/freecol/tools/TranslationReport.java:45: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:48: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. +src/net/sf/freecol/tools/TranslationReport.java:48: Variables that are final and static should be all capitals, 'printSummary' is not all capitals. +src/net/sf/freecol/tools/TranslationReport.java:48: fieldCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:50: A method/constructor shouldnt explicitly throw java.lang.Exception +src/net/sf/freecol/tools/TranslationReport.java:50: Avoid really long methods. +src/net/sf/freecol/tools/TranslationReport.java:50: Consider using varargs for methods or constructors which take an array the last parameter. +src/net/sf/freecol/tools/TranslationReport.java:50: Parameter 'args' is not assigned and could be declared final +src/net/sf/freecol/tools/TranslationReport.java:50: The method 'main' has a Cyclomatic Complexity of 39. +src/net/sf/freecol/tools/TranslationReport.java:50: The method 'main' has a Modified Cyclomatic Complexity of 35. +src/net/sf/freecol/tools/TranslationReport.java:50: The method 'main' has a Standard Cyclomatic Complexity of 35. +src/net/sf/freecol/tools/TranslationReport.java:50: The method main() has an NCSS line count of 148 +src/net/sf/freecol/tools/TranslationReport.java:50: The method main() has an NPath complexity of 64152030 +src/net/sf/freecol/tools/TranslationReport.java:50: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:51: Found 'DU'-anomaly for variable 'statistics' (lines '51'-'245'). +src/net/sf/freecol/tools/TranslationReport.java:51: Found 'DU'-anomaly for variable 'statistics' (lines '51'-'245'). +src/net/sf/freecol/tools/TranslationReport.java:51: Local variable 'statistics' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:54: Local variable 'dirName' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:55: Local variable 'directory' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:56: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:57: System.exit() should not be used in J2EE/JEE apps +src/net/sf/freecol/tools/TranslationReport.java:60: Found 'DU'-anomaly for variable 'languageFiles' (lines '60'-'245'). +src/net/sf/freecol/tools/TranslationReport.java:60: Found 'DU'-anomaly for variable 'languageFiles' (lines '60'-'245'). +src/net/sf/freecol/tools/TranslationReport.java:60: Local variable 'languageFiles' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:62: Parameter 'dir' is not assigned and could be declared final +src/net/sf/freecol/tools/TranslationReport.java:62: Parameter 'name' is not assigned and could be declared final +src/net/sf/freecol/tools/TranslationReport.java:62: publicMethodCommentRequirement Required +src/net/sf/freecol/tools/TranslationReport.java:67: Local variable 'masterFile' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:68: Local variable 'master' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:70: Comment is too large: Line too long +src/net/sf/freecol/tools/TranslationReport.java:72: Local variable 'name' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:73: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:73: Local variable 'lstat' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:75: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:75: Local variable 'propertyFile' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:76: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:76: Local variable 'properties' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:77: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:78: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:78: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:78: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:79: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:80: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:80: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:82: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:82: Local variable 'missingKeys' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:83: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:83: Local variable 'missingVariables' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:84: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:84: Local variable 'copiedFromMaster' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:86: Local variable 'keys' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:86: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:87: Local variable 'key' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:87: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:88: Local variable 'value' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:88: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:90: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:92: Local variable 'masterValue' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:92: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:96: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:98: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:98: These nested if statements could be combined +src/net/sf/freecol/tools/TranslationReport.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:99: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:100: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:101: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:105: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:106: Local variable 'current' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:106: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:107: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/TranslationReport.java:109: Local variable 'var' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:109: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:110: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:111: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:125: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/tools/TranslationReport.java:125: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:126: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:126: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:126: The String literal "** Total of " appears 5 times in this file; the first occurrence is on line 126 +src/net/sf/freecol/tools/TranslationReport.java:127: Local variable 'key' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:128: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:128: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:130: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:131: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:133: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:136: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/tools/TranslationReport.java:136: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:137: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:137: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:138: Local variable 'key' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:139: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:139: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:141: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:142: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:144: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:147: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/tools/TranslationReport.java:147: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:148: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:148: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:149: Local variable 'key' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:150: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:150: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:151: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:151: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:153: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:154: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:156: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:160: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:160: Local variable 'superfluousKeys' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:161: Avoid excessively long variable names like superfluousVariables +src/net/sf/freecol/tools/TranslationReport.java:161: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:161: Local variable 'superfluousVariables' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:162: Local variable 'keys' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:162: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:163: Local variable 'key' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:163: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:164: Local variable 'value' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:164: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:166: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:168: Local variable 'propertiesValue' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:168: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:172: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:173: Local variable 'current' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:173: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:174: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/TranslationReport.java:176: Local variable 'var' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:176: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:177: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:178: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:192: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/tools/TranslationReport.java:192: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:193: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:193: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:194: Local variable 'key' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:195: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:195: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:197: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:198: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:200: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:203: Avoid if (x != y) ..; else ..; +src/net/sf/freecol/tools/TranslationReport.java:203: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:204: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:204: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:206: Local variable 'key' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:207: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:207: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:208: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:208: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:210: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:211: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:213: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:216: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:220: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:221: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:221: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:222: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:223: Local variable 'stats' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:224: Avoid instantiating new objects inside loops +src/net/sf/freecol/tools/TranslationReport.java:224: Local variable 'output' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:225: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:225: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:226: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:226: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:227: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:227: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:228: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:228: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:229: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:229: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:230: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:230: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:231: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:231: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:232: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:232: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:233: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:233: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:234: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:234: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:235: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:235: StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. +src/net/sf/freecol/tools/TranslationReport.java:236: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:238: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:240: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:242: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:242: System.out.println is used +src/net/sf/freecol/tools/TranslationReport.java:247: Parameter 'localFile' is not assigned and could be declared final +src/net/sf/freecol/tools/TranslationReport.java:248: Local variable 'out' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:249: Local variable 'temp' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:250: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/TranslationReport.java:250: Avoid using if statements without curly braces +src/net/sf/freecol/tools/TranslationReport.java:250: Potential violation of Law of Demeter (object not created locally) +src/net/sf/freecol/tools/TranslationReport.java:256: Parameter 'number' is not assigned and could be declared final +src/net/sf/freecol/tools/TranslationReport.java:257: Local variable 'output' could be declared final +src/net/sf/freecol/tools/TranslationReport.java:258: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/TranslationReport.java:258: Avoid using if statements without curly braces +src/net/sf/freecol/tools/TranslationReport.java:259: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/tools/TranslationReport.java:260: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/TranslationReport.java:260: Avoid using if statements without curly braces +src/net/sf/freecol/tools/TranslationReport.java:261: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/tools/TranslationReport.java:262: Avoid using Literals in Conditional Statements +src/net/sf/freecol/tools/TranslationReport.java:262: Avoid using if statements without curly braces +src/net/sf/freecol/tools/TranslationReport.java:263: Avoid appending characters as strings in StringBuffer.append. +src/net/sf/freecol/tools/TranslationReport.java:268: Avoid using implementation types like 'ArrayList'; use the interface instead +src/net/sf/freecol/tools/TranslationReport.java:268: Avoid using implementation types like 'TreeSet'; use the interface instead +src/net/sf/freecol/tools/TranslationReport.java:268: Parameter 'missingKeys' is not assigned and could be declared final +src/net/sf/freecol/tools/TranslationReport.java:269: Local variable 'sorted' could be declared final diff --git a/src/net/sf/freecol/client/control/ConnectController.java b/src/net/sf/freecol/client/control/ConnectController.java index 4ee59d28..596aa920 100644 --- a/src/net/sf/freecol/client/control/ConnectController.java +++ b/src/net/sf/freecol/client/control/ConnectController.java @@ -39,7 +39,6 @@ import net.sf.freecol.client.gui.ChoiceItem; import net.sf.freecol.client.gui.GUI; import net.sf.freecol.client.gui.LoadingSavegameInfo; -import net.sf.freecol.common.FreeColException; import net.sf.freecol.common.ServerInfo; import net.sf.freecol.common.debug.FreeColDebugger; import net.sf.freecol.common.i18n.Messages; @@ -88,7 +87,7 @@ public ConnectController(FreeColClient freeColClient) { /** * The game is finishing. Release/unhook everything. */ - private void finish() { + public boolean finish() { ResourceManager.setScenarioMapping(null); if (!freeColClient.isHeadless()) { @@ -98,6 +97,7 @@ private void finish() { freeColClient.setMyPlayer(null); freeColClient.askServer().reset(); freeColClient.setLoggedIn(false); + return false; } /** diff --git a/src/net/sf/freecol/client/control/InGameController.java b/src/net/sf/freecol/client/control/InGameController.java index e2792ea4..46e0fb4c 100644 --- a/src/net/sf/freecol/client/control/InGameController.java +++ b/src/net/sf/freecol/client/control/InGameController.java @@ -590,8 +590,8 @@ private String getSaveGameString(Game game) { } /** - * Creates at least one autosave game file of the currently played - * game in the autosave directory. Does nothing if there is no + * Creates at least one auto save game file of the currently played + * game in the auto save directory. Does nothing if there is no * game running. */ private void autoSaveGame () { @@ -734,7 +734,7 @@ public void displayTurnReportMessages() { * @param endOfTurn Use a turn report panel if necessary. * @return True if any messages were displayed. */ - public boolean displayModelMessages(final boolean allMessages, + private boolean displayModelMessages(final boolean allMessages, final boolean endOfTurn) { final Player player = freeColClient.getMyPlayer(); final Turn thisTurn = freeColClient.getGame().getTurn(); @@ -999,7 +999,7 @@ private boolean moveToDestination(Unit unit, List messages) { * @param interactive Interactive mode: play sounds and emit errors. * @return True if the unit can possibly move further. */ - public boolean moveDirection(Unit unit, Direction direction, + boolean moveDirection(Unit unit, Direction direction, boolean interactive) { // If this move would reach the unit destination but we // discover that it would be permanently impossible to complete, @@ -1336,7 +1336,6 @@ private boolean moveDiplomacy(Unit unit, Direction direction, final Player other = colony.getOwner(); if (other == player.getREFPlayer()) return false; - StringTemplate nation = other.getNationLabel(); while (dt != null) { // Inform server of current agreement. dt = askServer().diplomacy(game, unit, colony, dt); @@ -1361,7 +1360,8 @@ private boolean moveDiplomacy(Unit unit, Direction direction, * @return True if the disembark "succeeds" (which deliberately includes * declined disembarks). */ - private boolean moveDisembark(Unit unit, final Direction direction) { + @SuppressWarnings("finally") + private boolean moveDisembark(Unit unit, final Direction direction) { Tile tile = unit.getTile().getNeighbourOrNull(direction); if (tile.getFirstUnit() != null && tile.getFirstUnit().getOwner() != unit.getOwner()) { @@ -1398,18 +1398,19 @@ private boolean moveDisembark(Unit unit, final Direction direction) { "none", choices); if (u == null) { // Cancelled, done. - } else if (u == unit) { + } + + else if (u == unit) { // Disembark all. for (Unit dUnit : disembarkable) { // Guard against loss of control when asking the // server to move the unit. try { moveDirection(dUnit, direction, false); - } finally { - continue; - } - } - } else { + } + finally { continue; } + }} + else { moveDirection(u, direction, false); } } @@ -1580,7 +1581,8 @@ private boolean moveLearnSkill(Unit unit, Direction direction) { * @param direction The direction in which to move the Unit. * @return True if the unit can move further. */ - private boolean moveMove(Unit unit, Direction direction) { + @SuppressWarnings("finally") + private boolean moveMove(Unit unit, Direction direction) { final ClientOptions options = freeColClient.getClientOptions(); if (unit.canCarryUnits() && unit.hasSpaceLeft() && options.getBoolean(ClientOptions.AUTOLOAD_SENTRIES)) { @@ -2425,9 +2427,6 @@ private boolean unloadUnitAtStop(Unit unit, LogBuilder lb) { final List goodsTypesToLoad = stop.getCargo(); boolean ret = false; - // Unload everything that is on the carrier but not listed to - // be loaded at this stop. - Game game = freeColClient.getGame(); for (Goods goods : unit.getCompactGoodsList()) { GoodsType type = goods.getType(); if (goodsTypesToLoad.contains(type)) continue; // Keep this cargo. @@ -2576,7 +2575,7 @@ public boolean abandonColony(Colony colony) { * @param defenderTile The Tile the defence takes place on. * @param success True if the attack succeeds. */ - public void animateAttack(Unit attacker, Unit defender, + void animateAttack(Unit attacker, Unit defender, Tile attackerTile, Tile defenderTile, boolean success) { // Note: we used to focus the map on the unit even when @@ -2600,7 +2599,7 @@ public void animateAttack(Unit attacker, Unit defender, * @param oldTile The Tile the move begins at. * @param newTile The Tile the move ends at. */ - public void animateMove(Unit unit, Tile oldTile, Tile newTile) { + void animateMove(Unit unit, Tile oldTile, Tile newTile) { // Note: we used to focus the map on the unit even when // animation is off as long as the center-active-unit option // was set. However IR#115 requested that if animation is off @@ -2703,8 +2702,7 @@ public boolean boardShip(Unit unit, Unit carrier) { public boolean buildColony(Unit unit) { if (!requireOurTurn() || unit == null) return false; - // Check unit, which must be on the map and able to build. - if (unit == null) return false; + final Tile tile = unit.getTile(); if (tile == null) return false; if (!unit.canBuildColony()) { @@ -2712,7 +2710,7 @@ public boolean buildColony(Unit unit) { .template("buildColony.badUnit") .addName("%unit%", unit.getName())); return false; - } + } // Join existing colony if present final Colony colony = tile.getColony(); @@ -2815,7 +2813,7 @@ public boolean buyGoods(GoodsType type, int amount, Unit carrier) { * @param message What to say. * @param pri If true, the message is private. */ - public void chat(Player player, String message, boolean pri) { + void chat(Player player, String message, boolean pri) { gui.displayChatMessage(player, message, pri); } @@ -2968,7 +2966,7 @@ public boolean checkCashInTreasureTrain(Unit unit) { * @param ff The chosen FoundingFather (may be null). * @return True if a father was chosen. */ - public boolean chooseFoundingFather(List ffs, + private boolean chooseFoundingFather(List ffs, FoundingFather ff) { if (ffs == null) return false; @@ -2984,7 +2982,7 @@ public boolean chooseFoundingFather(List ffs, * * @param ffs A list of FoundingFathers to choose from. */ - public void chooseFoundingFather(List ffs) { + void chooseFoundingFather(List ffs) { if (ffs == null) return; gui.showChooseFoundingFatherDialog(ffs, (FoundingFather ff) -> chooseFoundingFather(ffs, ff)); @@ -3121,7 +3119,7 @@ public boolean clearSpeciality(Unit unit) { * * Called from IGIH.closeMenus. */ - public void closeMenus() { + void closeMenus() { gui.closeMenus(); } @@ -3177,7 +3175,7 @@ public boolean declareIndependence() { * @return A counter agreement, a rejected agreement, or null if * the original agreement was already decided. */ - public DiplomaticTrade diplomacy(FreeColGameObject our, + DiplomaticTrade diplomacy(FreeColGameObject our, FreeColGameObject other, DiplomaticTrade agreement) { final Player player = freeColClient.getMyPlayer(); @@ -3276,7 +3274,7 @@ public boolean displayHighScores(Boolean high) { * @param allMessages Display all messages or just the undisplayed ones. * @return True if any messages were displayed. */ - public boolean displayModelMessages(boolean allMessages) { + boolean displayModelMessages(boolean allMessages) { return displayModelMessages(allMessages, false); } @@ -3290,7 +3288,7 @@ public boolean displayModelMessages(boolean allMessages) { * @param n The number of remaining units known to be eligible to migrate. * @param foY True if this migration is due to a fountain of youth event. */ - public void emigrate(Player player, int slot, int n, boolean foY) { + private void emigrate(Player player, int slot, int n, boolean foY) { if (player == null || !player.isColonial() || !MigrationType.validMigrantSlot(slot)) return; @@ -3389,7 +3387,7 @@ public boolean equipUnitForRole(Unit unit, Role role, int roleCount) { * display if the resource specified by messageId * is unavailable. */ - public void error(String messageId, String message) { + void error(String messageId, String message) { gui.showErrorMessage(messageId, message); } @@ -3419,7 +3417,7 @@ public boolean executeGotoOrders() { * @param result Whether the initial treaty was accepted. * @return True if first contact occurs. */ - public boolean firstContact(Player player, Player other, Tile tile, + private boolean firstContact(Player player, Player other, Tile tile, boolean result) { if (player == null || player == null || player == other || tile == null) return false; @@ -3442,7 +3440,7 @@ public boolean firstContact(Player player, Player other, Tile tile, * they have made a first landing. * @param n The number of settlements claimed by the native player. */ - public void firstContact(Player player, Player other, Tile tile, int n) { + void firstContact(Player player, Player other, Tile tile, int n) { gui.showFirstContactDialog(player, other, tile, n, (Boolean b) -> firstContact(player, other, tile, b)); } @@ -3454,7 +3452,7 @@ public void firstContact(Player player, Player other, Tile tile, int n) { * * @param n The number of migrants available for selection. */ - public void fountainOfYouth(int n) { + void fountainOfYouth(int n) { Player player = freeColClient.getMyPlayer(); final boolean fountainOfYouth = true; gui.showEmigrationDialog(player, fountainOfYouth, @@ -3583,7 +3581,7 @@ public boolean ignoreMessage(ModelMessage message, boolean flag) { * @param amount The amount of goods/gold demanded. * @return Whether the demand was accepted or not. */ - public boolean indianDemand(Unit unit, Colony colony, + boolean indianDemand(Unit unit, Colony colony, GoodsType type, int amount) { if (unit == null || colony == null) return false; @@ -3784,7 +3782,7 @@ public void loadGame() { * @param defenderId The identifier of the defender unit (may have sunk). * @return True if looting occurs. */ - public boolean lootCargo(Unit unit, List goods, String defenderId) { + private boolean lootCargo(Unit unit, List goods, String defenderId) { if (unit == null || goods == null || goods.isEmpty() || defenderId == null) return false; @@ -3806,7 +3804,7 @@ public boolean lootCargo(Unit unit, List goods, String defenderId) { * @param goods A list of Goods to choose from. * @param defenderId The identifier of the defender unit (may have sunk). */ - public void loot(Unit unit, List goods, String defenderId) { + void loot(Unit unit, List goods, String defenderId) { gui.showCaptureGoodsDialog(unit, goods, (List gl) -> lootCargo(unit, gl, defenderId)); } @@ -3847,7 +3845,7 @@ public boolean monarchAction(MonarchAction action, boolean accept) { * @param template A StringTemplate describing the action. * @param monarchKey A key for the monarch involved. */ - public void monarch(MonarchAction action, StringTemplate template, + void monarch(MonarchAction action, StringTemplate template, String monarchKey) { gui.showMonarchDialog(action, template, monarchKey, (Boolean b) -> monarchAction(action, b)); @@ -3928,8 +3926,6 @@ public boolean moveUnit(Unit unit, Direction direction) { if (!askClearGotoOrders(unit)) return false; - final int unitCount = unit.getUnitCount(), - goodsCount = unit.getGoodsList().size(); final Tile oldTile = unit.getTile(); UnitWas unitWas = new UnitWas(unit); ColonyWas colonyWas = (unit.getColony() == null) ? null @@ -3980,7 +3976,7 @@ public boolean moveTileCursor(Direction direction) { * @param name The name to use. * @return True if the new land was named. */ - public boolean nameNewLand(Unit unit, String name) { + private boolean nameNewLand(Unit unit, String name) { if (unit == null || name == null) return false; // Respond to the server. @@ -4017,7 +4013,7 @@ public boolean nameNewLand(Unit unit, String name) { * @param name The name to offer. * @return True if the new region was named. */ - public boolean nameNewRegion(final Tile tile, final Unit unit, + private boolean nameNewRegion(final Tile tile, final Unit unit, final Region region, final String name) { if (tile == null || unit == null || region == null) return false; @@ -4032,7 +4028,7 @@ public boolean nameNewRegion(final Tile tile, final Unit unit, * @param defaultName The default name to use. * @param unit The Unit that has landed. */ - public void newLandName(String defaultName, Unit unit) { + void newLandName(String defaultName, Unit unit) { gui.showNamingDialog( StringTemplate.key("newLand.text"), defaultName, unit, (String name) -> { @@ -4051,7 +4047,7 @@ public void newLandName(String defaultName, Unit unit) { * @param tile The Tile the unit landed at. * @param unit The Unit that has landed. */ - public void newRegionName(Region region, String defaultName, Tile tile, + void newRegionName(Region region, String defaultName, Tile tile, Unit unit) { if (region.hasName()) { if (region.isPacific()) { @@ -4079,7 +4075,7 @@ public void newRegionName(Region region, String defaultName, Tile tile, * @param turn The turn number. * @return True if the new turn occurs. */ - public boolean newTurn(int turn) { + boolean newTurn(int turn) { final Game game = freeColClient.getGame(); final Player player = freeColClient.getMyPlayer(); @@ -4100,7 +4096,7 @@ public boolean newTurn(int turn) { player.addModelMessage(new ModelMessage(MessageType.WARNING, "twoTurnsPerYear", player) .addStringTemplate("%year%", currTurn.getLabel()) - .addAmount("%amount%", currTurn.getSeasonNumber())); + .addAmount("%amount%", Turn.getSeasonNumber())); } return true; } @@ -4284,7 +4280,7 @@ public boolean recruitUnitInEurope(int index) { * * @param objects A list of FreeColGameObjects to remove. */ - public void remove(List objects, + void remove(List objects, FreeColGameObject divert) { final Player player = freeColClient.getMyPlayer(); boolean visibilityChange = false; @@ -4512,7 +4508,7 @@ public boolean setBuildQueue(Colony colony, * @param player The Player to be the new current player. * @return True if the current player changes. */ - public boolean setCurrentPlayer(Player player) { + boolean setCurrentPlayer(Player player) { if (FreeColDebugger.isInDebugMode(FreeColDebugger.DebugMode.MENUS) && freeColClient.currentPlayerIsMyPlayer()) { gui.closeMenus(); @@ -4569,7 +4565,7 @@ public boolean setCurrentPlayer(Player player) { * @param dead The dead Player. * @return True if the player is marked as dead. */ - public boolean setDead(Player dead) { + boolean setDead(Player dead) { if (dead == null) return false; final Player player = freeColClient.getMyPlayer(); @@ -4603,7 +4599,7 @@ public boolean setDead(Player dead) { * * No status returned to connect controller. */ - public void setGameConnected () { + void setGameConnected () { final Player player = freeColClient.getMyPlayer(); if (player != null) { player.refilterModelMessages(freeColClient.getClientOptions()); @@ -4649,7 +4645,7 @@ public boolean setInDebugMode() { * @param second The second Player. * @return True if the stance change succeeds. */ - public boolean setStance(Stance stance, Player first, Player second) { + boolean setStance(Stance stance, Player first, Player second) { if (stance == null || first == null || second == null) return false; final Player player = freeColClient.getMyPlayer(); @@ -4689,7 +4685,7 @@ public boolean setTradeRoutes(List routes) { * @param recover A Runnable to restore the normal * player view of the tile when the spying colony panel is closed. */ - public void spyColony(Tile tile, Runnable recover) { + void spyColony(Tile tile, Runnable recover) { gui.showSpyColonyPanel(tile, recover); } @@ -4827,7 +4823,7 @@ public boolean updateTradeRoute(TradeRoute route) { * * @param score If "true", a new high score was reached. */ - public void victory(String score) { + void victory(String score) { displayHighScores("true".equalsIgnoreCase(score)); gui.showVictoryDialog((Boolean result) -> victory(result)); } @@ -4840,7 +4836,7 @@ public void victory(String score) { * @param quit If true, leave this game and start a new one. * @return True. */ - public boolean victory(Boolean quit) { + private boolean victory(Boolean quit) { if (quit) { freeColClient.newGame(false); } else { @@ -4878,7 +4874,6 @@ public boolean work(Unit unit, WorkLocation workLocation) { if (!requireOurTurn() || unit == null || workLocation == null) return false; - StringTemplate template; if (unit.getStudent() != null && !gui.confirmAbandonEducation(unit, false)) return false; diff --git a/src/net/sf/freecol/client/control/InGameInputHandler.java b/src/net/sf/freecol/client/control/InGameInputHandler.java index 3f95b68a..034caed2 100644 --- a/src/net/sf/freecol/client/control/InGameInputHandler.java +++ b/src/net/sf/freecol/client/control/InGameInputHandler.java @@ -576,35 +576,6 @@ private Element diplomacy(Element element) { : message.toXMLElement(); } - /** - * Disposes of the Units which are the children of this - * Element. - * - * @param element The element (root element in a DOM-parsed XML - * tree) that holds all the information. - * @return Null. - */ - private Element disposeUnits(Element element) { - Game game = getGame(); - NodeList nodes = element.getChildNodes(); - - for (int i = 0; i < nodes.getLength(); i++) { - // Do not read the whole unit out of the element as we are - // only going to dispose of it, not forgetting that the - // server may have already done so and its view will only - // mislead us here in the client. - Element e = (Element) nodes.item(i); - String id = FreeColObject.readId(e); - Unit u = game.getFreeColGameObject(id, Unit.class); - if (u == null) { - logger.warning("Object is not a unit"); - } else { - u.dispose(); - } - } - return null; - } - /** * Handle an "error"-message. * @@ -613,9 +584,10 @@ private Element disposeUnits(Element element) { * @return Null. */ private Element error(Element element) { - final String messageId = element.getAttribute("messageID"); + final String message = element.getAttribute("message"); - + final String messageId = element.getAttribute("messageId"); + invokeLater(() -> { igc().error(messageId, message); }); return null; } @@ -903,7 +875,7 @@ private Element newTurn(Element element) { * tree) that holds all the information. * @return Null. */ - private Element reconnect(@SuppressWarnings("unused") Element element) { + private Element reconnect(Element element) { logger.finest("Entered reconnect."); invokeLater(reconnectRunnable); @@ -928,10 +900,6 @@ private Element remove(Element element) { String idString = FreeColObject.readId(e); FreeColGameObject fcgo = game.getFreeColGameObject(idString); if (fcgo == null) { - // This can happen legitimately when an update that - // removes pointers to a disappearing unit happens, - // then a gc which drops the weak reference in - // freeColGameObjects, before this remove is processed. continue; } objects.add(fcgo); diff --git a/src/net/sf/freecol/client/control/InputHandler.java b/src/net/sf/freecol/client/control/InputHandler.java index da1b4aa7..3e15d37c 100644 --- a/src/net/sf/freecol/client/control/InputHandler.java +++ b/src/net/sf/freecol/client/control/InputHandler.java @@ -33,7 +33,7 @@ /** * Provides common methods for input handlers. */ -public abstract class InputHandler implements MessageHandler { +abstract class InputHandler implements MessageHandler { private static final Logger logger = Logger.getLogger(InputHandler.class.getName()); @@ -46,11 +46,11 @@ public abstract class InputHandler implements MessageHandler { * * @param freeColClient The FreeColClient for the game. */ - public InputHandler(FreeColClient freeColClient) { + InputHandler(FreeColClient freeColClient) { this.freeColClient = freeColClient; } - + /** * Gets the main freecol client object. * @@ -121,7 +121,7 @@ protected Element disconnect(Element element) { * holds all the information. * @return Null. */ - protected Element unknown(Element element) { + public Element unknown(Element element) { logger.warning("Unknown message type: " + element.getTagName()); return null; } diff --git a/src/net/sf/freecol/client/control/MapEditorController.java b/src/net/sf/freecol/client/control/MapEditorController.java index 4142d64e..bc4ef3a6 100644 --- a/src/net/sf/freecol/client/control/MapEditorController.java +++ b/src/net/sf/freecol/client/control/MapEditorController.java @@ -44,7 +44,6 @@ import net.sf.freecol.common.model.Tile; import net.sf.freecol.common.option.MapGeneratorOptions; import net.sf.freecol.common.option.OptionGroup; -import net.sf.freecol.common.util.LogBuilder; import net.sf.freecol.server.FreeColServer; import net.sf.freecol.server.generator.MapGenerator; import net.sf.freecol.server.model.ServerPlayer; @@ -172,14 +171,10 @@ public void transform(Tile t) { */ public void newMap() { final Game game = freeColClient.getGame(); - final Specification spec = game.getSpecification(); - gui.removeInGameComponents(); OptionGroup mgo = gui.showMapGeneratorOptionsDialog(true); if (mgo == null) return; game.setMapGeneratorOptions(mgo); - Map map = freeColClient.getFreeColServer().getMapGenerator() - .createMap(new LogBuilder(-1)); requireNativeNations(game); gui.setFocus(game.getMap().getTile(1,1)); gui.updateMenuBar(); @@ -237,6 +232,7 @@ public void run() { public void loadGame() { File file = gui.showLoadSaveFileDialog(); if (file != null) loadGame(file); + } /** @@ -244,7 +240,7 @@ public void loadGame() { * * @param game The Game to add native nations to. */ - public void requireNativeNations(Game game) { + private void requireNativeNations(Game game) { final Specification spec = game.getSpecification(); for (Nation n : spec.getIndianNations()) { Player p = game.getPlayerByNation(n); @@ -268,7 +264,7 @@ public void loadGame(File file) { class ErrorJob implements Runnable { private final StringTemplate template; - ErrorJob(StringTemplate template) { + private ErrorJob(StringTemplate template) { this.template = template; } diff --git a/src/net/sf/freecol/client/control/PreGameController.java b/src/net/sf/freecol/client/control/PreGameController.java index 6a36aa63..c2d3c23a 100644 --- a/src/net/sf/freecol/client/control/PreGameController.java +++ b/src/net/sf/freecol/client/control/PreGameController.java @@ -21,8 +21,6 @@ import java.awt.Color; -import java.util.logging.Logger; - import net.sf.freecol.client.FreeColClient; import net.sf.freecol.client.gui.GUI; import net.sf.freecol.common.debug.FreeColDebugger; @@ -42,8 +40,6 @@ */ public final class PreGameController { - private static final Logger logger = Logger.getLogger(PreGameController.class.getName()); - /** The main client. */ private final FreeColClient freeColClient; @@ -150,7 +146,7 @@ public void setNationType(NationType nationType) { * @return True if the player should continue, false if we are in * a debug run and should be skipping turns. */ - public boolean startGame() { + boolean startGame() { final Player player = freeColClient.getMyPlayer(); if (!freeColClient.isHeadless()) { gui.closeMainPanel(); diff --git a/src/net/sf/freecol/client/control/PreGameInputHandler.java b/src/net/sf/freecol/client/control/PreGameInputHandler.java index 1e9e309d..0b518d6f 100644 --- a/src/net/sf/freecol/client/control/PreGameInputHandler.java +++ b/src/net/sf/freecol/client/control/PreGameInputHandler.java @@ -195,7 +195,7 @@ private Element logout(Element element) { * holds all the information. * @return The result of handling the last Element. */ - public Element multiple(Connection connection, Element element) { + private Element multiple(Connection connection, Element element) { NodeList nodes = element.getChildNodes(); Element reply = null; @@ -273,8 +273,8 @@ private Element setAvailable(Element element) { * tree) that holds all the information. * @return Null. */ - private Element startGame(@SuppressWarnings("unused") Element element) { - new Thread(FreeCol.CLIENT_THREAD + "Starting game") { + private Element startGame(Element element){ + new Thread(FreeCol.CLIENT_THREAD + "Starting game") { @Override public void run() { while (getFreeColClient().getGame().getMap() == null) { diff --git a/src/net/sf/freecol/client/control/SoundController.java b/src/net/sf/freecol/client/control/SoundController.java index 276d5309..f3f46c68 100644 --- a/src/net/sf/freecol/client/control/SoundController.java +++ b/src/net/sf/freecol/client/control/SoundController.java @@ -42,7 +42,7 @@ public class SoundController { private static final Logger logger = Logger.getLogger(SoundController.class.getName()); - private SoundPlayer soundPlayer; + public SoundPlayer soundPlayer; /** @@ -55,8 +55,9 @@ public SoundController(FreeColClient freeColClient, boolean sound) { final ClientOptions opts = freeColClient.getClientOptions(); if (sound) { this.soundPlayer = null; - Option amo = opts.getOption(ClientOptions.AUDIO_MIXER); - Option vo = opts.getOption(ClientOptions.AUDIO_VOLUME); + + Option amo = opts.getOption(ClientOptions.AUDIO_MIXER); + Option vo = opts.getOption(ClientOptions.AUDIO_VOLUME); if (!(amo instanceof AudioMixerOption)) { logger.warning(ClientOptions.AUDIO_MIXER + " is not an AudioMixerOption"); } else if (!(vo instanceof PercentageOption)) { diff --git a/src/net/sf/freecol/client/gui/MapViewer.java b/src/net/sf/freecol/client/gui/MapViewer.java index b5dedd73..97f68925 100644 --- a/src/net/sf/freecol/client/gui/MapViewer.java +++ b/src/net/sf/freecol/client/gui/MapViewer.java @@ -126,7 +126,11 @@ public TextSpecification(String newText, Font newFont) { // Helper variables for displaying the map. private int tileHeight, tileWidth, halfHeight, halfWidth, topSpace, topRows, /*bottomSpace,*/ bottomRows, leftSpace, rightSpace; + + //For hex grid + private double testHeight, testWidth; + // The y-coordinate of the Tiles that will be drawn at the bottom private int bottomRow = -1; @@ -1242,7 +1246,11 @@ private void setImageLibraryAndUpdateData(ImageLibrary lib) { tileWidth = tileSize.width; halfHeight = tileHeight/2; halfWidth = tileWidth/2; + testWidth = tileWidth * .204; + testWidth = tileWidth * .204; + + int dx = tileWidth/16; int dy = tileHeight/16; int ddx = dx + dx/2; @@ -1335,20 +1343,23 @@ void displayMap(Graphics2D g) { g.translate(-xt, -yt); }); - // Draw the grid, if needed + // Draw the grid, if needed if (options.getBoolean(ClientOptions.DISPLAY_GRID)) { // Generate a zigzag GeneralPath - GeneralPath gridPath = new GeneralPath(); - gridPath.moveTo(0, 0); - int nextX = halfWidth; - int nextY = -halfHeight; - for (int i = 0; i <= ((lastColumn - firstColumn) * 2 + 1); i++) { - gridPath.lineTo(nextX, nextY); - nextX += halfWidth; - nextY = (nextY == 0 ? -halfHeight : 0); + GeneralPath gridPath = new GeneralPath(); + gridPath.moveTo(0, 0); + double startX = halfWidth + 0.0; + double nextX = testWidth; + double startY = -halfHeight + 0.0; + double nextY = -testHeight; + for (int i = 0; i <= ((lastColumn - firstColumn) * 2 + 1); i++) { + gridPath.lineTo(startX + nextX, startY); + startX += halfWidth; + startY = (startY == 0 ? -halfHeight : 0); + gridPath.lineTo(startX + - nextX, startY); + gridPath.lineTo(startX, startY); } - // Display the grid g.setStroke(gridStroke); g.setColor(Color.BLACK); for (int row = firstRow; row <= lastRow; row++) { @@ -1361,8 +1372,10 @@ void displayMap(Graphics2D g) { g.setTransform(rowTransform); } g.setTransform(baseTransform); + } + // Paint full region borders if (options.getInteger(ClientOptions.DISPLAY_TILE_TEXT) == ClientOptions.DISPLAY_TILE_TEXT_REGIONS) { diff --git a/src/net/sf/freecol/common/ServerInfo.java b/src/net/sf/freecol/common/ServerInfo.java index 8e39d290..5c5c8202 100644 --- a/src/net/sf/freecol/common/ServerInfo.java +++ b/src/net/sf/freecol/common/ServerInfo.java @@ -47,7 +47,7 @@ public class ServerInfo { /** * Empty constructor that can be used by subclasses. */ - protected ServerInfo() {} + public ServerInfo() {} /** * Creates a new object with the given information. diff --git a/src/net/sf/freecol/common/i18n/Relation.java b/src/net/sf/freecol/common/i18n/Relation.java index 4337be8d..c864eb8d 100644 --- a/src/net/sf/freecol/common/i18n/Relation.java +++ b/src/net/sf/freecol/common/i18n/Relation.java @@ -76,7 +76,8 @@ public void setInteger(boolean value) { */ public boolean matches(double number) { double value = (mod == 1) ? number : number % mod; - if (integer && value != (int) value) { + + if (integer) { return false; } return (low <= value && value <= high) != negated; diff --git a/src/net/sf/freecol/server/generator/ColonizationMapLoader.java b/src/net/sf/freecol/server/generator/ColonizationMapLoader.java index f49801c3..1ac465e1 100644 --- a/src/net/sf/freecol/server/generator/ColonizationMapLoader.java +++ b/src/net/sf/freecol/server/generator/ColonizationMapLoader.java @@ -19,159 +19,148 @@ package net.sf.freecol.server.generator; -import java.io.File; -import java.io.RandomAccessFile; -import net.sf.freecol.common.model.Game; -import net.sf.freecol.common.model.Tile; -import net.sf.freecol.common.model.TileImprovement; -import net.sf.freecol.common.model.TileImprovementType; -import net.sf.freecol.common.model.TileItemContainer; -import net.sf.freecol.common.model.TileType; -import net.sf.freecol.common.model.Map.Layer; -import net.sf.freecol.common.model.Specification; - - -/** - * Just pass the name of a Colonization map file (with extension ".MP"). - * - * The map file starts with a six-byte header. Byte zero encodes the - * map width, byte two encodes the map height. The function of the - * other bytes is unknown, their values, however, are fixed. The - * header is followed by three "layers", each the size of the map. The - * first "layer" encodes the terrain type. The function of the other - * layers is unknown. They are filled with zero bytes. - * - * It seems that the least significant three bits encode the basic - * terrain type, the next two bits encode the forest overlay and - * the special tile types ice, ocean and sea lanes. The three most - * significant bits encode combinations of the hill, mountain and - * river overlays. - * - * bits 0-2: tile type - * bit 3 (8): forest - * bit 4 (16): forest - * bits 3+4 (24): special, values larger than 26 are not defined - * - * bits 5-7: overlays - * 0: nothing - * 1: hill - * 2: minor river - * 3: hill + minor river (extremely rare) - * 4: nothing - * 5: mountain - * 6: major river - * 7: mountain + major river (never seen) - */ -public class ColonizationMapLoader implements MapLoader { - - public static final int WIDTH = 0; - public static final int HEIGHT = 2; - public static final int OCEAN = 25; - public static final int HIGH_SEAS = 26; - - private static final String[] tiletypes = { - "tundra", - "desert", - "plains", - "prairie", - "grassland", - "savannah", - "marsh", - "swamp", - "borealForest", - "scrubForest", - "mixedForest", - "broadleafForest", - "coniferForest", - "tropicalForest", - "wetlandForest", - "rainForest", - "borealForest", - "scrubForest", - "mixedForest", - "broadleafForest", - "coniferForest", - "tropicalForest", - "wetlandForest", - "rainForest", - "arctic", - "ocean", - "highSeas", - }; - - - private static final byte[] header = { - 58, 0, 72, 0, 4, 0 - }; - private static byte[] layer1; - - public ColonizationMapLoader(File file) throws Exception { - - RandomAccessFile reader = new RandomAccessFile(file, "r"); - reader.read(header); - - int size = header[WIDTH] * header[HEIGHT]; - layer1 = new byte[size]; - reader.read(layer1); - - } - - @Override - public Layer loadMap(Game game, Layer layer) { - Specification spec = game.getSpecification(); - Tile[][] tiles = new Tile[header[WIDTH]][header[HEIGHT]]; - Layer highestLayer = layer.compareTo(getHighestLayer()) < 0 - ? layer : getHighestLayer(); - int index = 0; - TileType tileType = null; - if (highestLayer == Layer.LAND) { - // import only the land / water distinction - for (int y = 0; y < header[HEIGHT]; y++) { - for (int x = 0; x < header[WIDTH]; x++) { - int decimal = layer1[index] & 0xff; - int terrain = decimal & 0b11111; - tileType = (terrain == OCEAN || terrain == HIGH_SEAS) ? - TileType.WATER : TileType.LAND; - index++; - } - } - } else { - TileImprovementType riverType = spec.getTileImprovementType("model.improvement.river"); - for (int y = 0; y < header[HEIGHT]; y++) { - for (int x = 0; x < header[WIDTH]; x++) { - int decimal = layer1[index] & 0xff; - int terrain = decimal & 0b11111; - int overlay = decimal >> 5; - - if (terrain < tiletypes.length) { - tileType = spec.getTileType("model.tile." + tiletypes[terrain]); - } else if (overlay == 1 || overlay == 3) { - tileType = spec.getTileType("model.tile.hills"); - } else if (overlay == 5 || overlay == 7) { - tileType = spec.getTileType("model.tile.mountains"); - } - tiles[x][y] = new Tile(game, tileType, x, y); - if (highestLayer == Layer.RIVERS - && (overlay == 2 || overlay == 3 || overlay == 6 || overlay == 7)) { - TileItemContainer container = new TileItemContainer(game, tiles[x][y]); - TileImprovement river = - new TileImprovement(game, tiles[x][y], riverType); - river.setMagnitude (overlay <= 3 ? 1 : 2); - container.addTileItem(river); - tiles[x][y].setTileItemContainer(container); - } - index++; - } - } - } - return highestLayer; - } - - @Override - public Layer getHighestLayer() { - return Layer.RIVERS; - } - - -} +// TODO Remove unused code found by UCDetector +// /** +// * Just pass the name of a Colonization map file (with extension ".MP"). +// * +// * The map file starts with a six-byte header. Byte zero encodes the +// * map width, byte two encodes the map height. The function of the +// * other bytes is unknown, their values, however, are fixed. The +// * header is followed by three "layers", each the size of the map. The +// * first "layer" encodes the terrain type. The function of the other +// * layers is unknown. They are filled with zero bytes. +// * +// * It seems that the least significant three bits encode the basic +// * terrain type, the next two bits encode the forest overlay and +// * the special tile types ice, ocean and sea lanes. The three most +// * significant bits encode combinations of the hill, mountain and +// * river overlays. +// * +// * bits 0-2: tile type +// * bit 3 (8): forest +// * bit 4 (16): forest +// * bits 3+4 (24): special, values larger than 26 are not defined +// * +// * bits 5-7: overlays +// * 0: nothing +// * 1: hill +// * 2: minor river +// * 3: hill + minor river (extremely rare) +// * 4: nothing +// * 5: mountain +// * 6: major river +// * 7: mountain + major river (never seen) +// */ +// public class ColonizationMapLoader implements MapLoader { +// +// public static final int WIDTH = 0; +// public static final int HEIGHT = 2; +// public static final int OCEAN = 25; +// public static final int HIGH_SEAS = 26; +// +// private static final String[] tiletypes = { +// "tundra", +// "desert", +// "plains", +// "prairie", +// "grassland", +// "savannah", +// "marsh", +// "swamp", +// "borealForest", +// "scrubForest", +// "mixedForest", +// "broadleafForest", +// "coniferForest", +// "tropicalForest", +// "wetlandForest", +// "rainForest", +// "borealForest", +// "scrubForest", +// "mixedForest", +// "broadleafForest", +// "coniferForest", +// "tropicalForest", +// "wetlandForest", +// "rainForest", +// "arctic", +// "ocean", +// "highSeas", +// }; +// +// +// private static final byte[] header = { +// 58, 0, 72, 0, 4, 0 +// }; +// private static byte[] layer1; +// +// public ColonizationMapLoader(File file) throws Exception { +// +// RandomAccessFile reader = new RandomAccessFile(file, "r"); +// reader.read(header); +// +// int size = header[WIDTH] * header[HEIGHT]; +// layer1 = new byte[size]; +// reader.read(layer1); +// +// } +// +// @Override +// public Layer loadMap(Game game, Layer layer) { +// Specification spec = game.getSpecification(); +// Tile[][] tiles = new Tile[header[WIDTH]][header[HEIGHT]]; +// Layer highestLayer = layer.compareTo(getHighestLayer()) < 0 +// ? layer : getHighestLayer(); +// int index = 0; +// TileType tileType = null; +// if (highestLayer == Layer.LAND) { +// // import only the land / water distinction +// for (int y = 0; y < header[HEIGHT]; y++) { +// for (int x = 0; x < header[WIDTH]; x++) { +// int decimal = layer1[index] & 0xff; +// int terrain = decimal & 0b11111; +// tileType = (terrain == OCEAN || terrain == HIGH_SEAS) ? +// TileType.WATER : TileType.LAND; +// index++; +// } +// } +// } else { +// TileImprovementType riverType = spec.getTileImprovementType("model.improvement.river"); +// for (int y = 0; y < header[HEIGHT]; y++) { +// for (int x = 0; x < header[WIDTH]; x++) { +// int decimal = layer1[index] & 0xff; +// int terrain = decimal & 0b11111; +// int overlay = decimal >> 5; +// +// if (terrain < tiletypes.length) { +// tileType = spec.getTileType("model.tile." + tiletypes[terrain]); +// } else if (overlay == 1 || overlay == 3) { +// tileType = spec.getTileType("model.tile.hills"); +// } else if (overlay == 5 || overlay == 7) { +// tileType = spec.getTileType("model.tile.mountains"); +// } +// tiles[x][y] = new Tile(game, tileType, x, y); +// if (highestLayer == Layer.RIVERS +// && (overlay == 2 || overlay == 3 || overlay == 6 || overlay == 7)) { +// TileItemContainer container = new TileItemContainer(game, tiles[x][y]); +// TileImprovement river = +// new TileImprovement(game, tiles[x][y], riverType); +// river.setMagnitude (overlay <= 3 ? 1 : 2); +// container.addTileItem(river); +// tiles[x][y].setTileItemContainer(container); +// } +// index++; +// } +// } +// } +// return highestLayer; +// } +// +// @Override +// public Layer getHighestLayer() { +// return Layer.RIVERS; +// } +// +// +// } diff --git a/src/net/sf/freecol/server/generator/FreeColMapLoader.java b/src/net/sf/freecol/server/generator/FreeColMapLoader.java index 71b0f9a4..123a025e 100644 --- a/src/net/sf/freecol/server/generator/FreeColMapLoader.java +++ b/src/net/sf/freecol/server/generator/FreeColMapLoader.java @@ -17,123 +17,104 @@ * along with FreeCol. If not, see . */ -package net.sf.freecol.server.generator; +//package net.sf.freecol.server.generator; -import java.io.File; -import java.util.HashMap; -import net.sf.freecol.common.io.FreeColSavegameFile; -import net.sf.freecol.common.model.Game; -import net.sf.freecol.common.model.IndianSettlement; -import net.sf.freecol.common.model.Map; -import net.sf.freecol.common.model.Map.Layer; -import net.sf.freecol.common.model.Nation; -import net.sf.freecol.common.model.Player; -import net.sf.freecol.common.model.Region; -import net.sf.freecol.common.model.Tile; -import net.sf.freecol.common.model.TileItemContainer; -import net.sf.freecol.common.model.TileType; -import net.sf.freecol.server.FreeColServer; -import net.sf.freecol.server.model.ServerGame; -import net.sf.freecol.server.model.ServerIndianSettlement; -import net.sf.freecol.server.model.ServerPlayer; -import net.sf.freecol.server.model.ServerRegion; - - -/** - * Load a map. - */ -public class FreeColMapLoader implements MapLoader { - - private final ServerGame importGame; - - public FreeColMapLoader(File file) throws Exception { - importGame = FreeColServer.readGame(new FreeColSavegameFile(file), null, null); - } - - - @Override - public Layer loadMap(Game game, Layer layer) { - Map importMap = importGame.getMap(); - Layer highestLayer = layer.compareTo(importMap.getLayer()) < 0 - ? layer : importMap.getLayer(); - int width = importMap.getWidth(); - int height = importMap.getHeight(); - - java.util.Map regions = new HashMap<>(); - - Map map = new Map(game, width, height); - if (highestLayer == Layer.LAND) { - // import only the land / water distinction - for (int x = 0; x < width; x++) { - for (int y = 0; y < height; y++) { - Tile t = new Tile(game, - (importMap.getTile(x, y).getType().isWater()) - ? TileType.WATER : TileType.LAND, - x, y); - map.setTile(t, x, y); - } - } - } else { - for (int x = 0; x < width; x++) { - for (int y = 0; y < height; y++) { - Tile template = importMap.getTile(x, y); - Tile tile = new Tile(game, null, x, y); - map.setTile(tile, x, y); - - // import tile types - tile.setType(game.getSpecification().getTileType(template.getType().getId())); - tile.setMoveToEurope(template.getMoveToEurope()); - if (highestLayer.compareTo(Layer.REGIONS) >= 0) { - // import regions - Region region = template.getRegion(); - if (region != null) { - ServerRegion ours = regions.get(region.getId()); - if (ours == null) { - ours = new ServerRegion(game, region); - regions.put(region.getId(), ours); - } - tile.setRegion(ours); - ours.addTile(tile); - } - if (highestLayer.compareTo(Layer.RIVERS) >= 0) { - // import tile improvements - tile.setTileItemContainer(new TileItemContainer(game, tile, template - .getTileItemContainer(), layer)); - if (layer.compareTo(Layer.NATIVES) >= 0) { - // import native settlements - if (template.getOwner() != null) { - String nationId = template.getOwner().getNationId(); - Player player = game.getPlayerByNationId(nationId); - if (player == null) { - Nation nation = game.getSpecification().getNation(nationId); - player = new ServerPlayer(game, false, nation, null, null); - game.addPlayer(player); - } - tile.setOwner(player); - if (template.getOwningSettlement() != null) { - IndianSettlement settlement = (IndianSettlement) template.getOwningSettlement(); - tile.setOwningSettlement(new ServerIndianSettlement(game, - player, tile, settlement)); - } - } - } - } - } - } - } - } - for (Region region : regions.values()) { - map.addRegion(region); - } - map.setLayer(highestLayer); - game.setMap(map); - return highestLayer; - } - - - @Override - public Layer getHighestLayer() { - return Layer.NATIVES; - } -} +// TODO Remove unused code found by UCDetector +// /** +// * Load a map. +// */ +// public class FreeColMapLoader implements MapLoader { +// +// private final ServerGame importGame; +// +// public FreeColMapLoader(File file) throws Exception { +// importGame = FreeColServer.readGame(new FreeColSavegameFile(file), null, null); +// } +// +// +// @Override +// public Layer loadMap(Game game, Layer layer) { +// Map importMap = importGame.getMap(); +// Layer highestLayer = layer.compareTo(importMap.getLayer()) < 0 +// ? layer : importMap.getLayer(); +// int width = importMap.getWidth(); +// int height = importMap.getHeight(); +// +// java.util.Map regions = new HashMap<>(); +// +// Map map = new Map(game, width, height); +// if (highestLayer == Layer.LAND) { +// // import only the land / water distinction +// for (int x = 0; x < width; x++) { +// for (int y = 0; y < height; y++) { +// Tile t = new Tile(game, +// (importMap.getTile(x, y).getType().isWater()) +// ? TileType.WATER : TileType.LAND, +// x, y); +// map.setTile(t, x, y); +// } +// } +// } else { +// for (int x = 0; x < width; x++) { +// for (int y = 0; y < height; y++) { +// Tile template = importMap.getTile(x, y); +// Tile tile = new Tile(game, null, x, y); +// map.setTile(tile, x, y); +// +// // import tile types +// tile.setType(game.getSpecification().getTileType(template.getType().getId())); +// tile.setMoveToEurope(template.getMoveToEurope()); +// if (highestLayer.compareTo(Layer.REGIONS) >= 0) { +// // import regions +// Region region = template.getRegion(); +// if (region != null) { +// ServerRegion ours = regions.get(region.getId()); +// if (ours == null) { +// ours = new ServerRegion(game, region); +// regions.put(region.getId(), ours); +// } +// tile.setRegion(ours); +// ours.addTile(tile); +// } +// if (highestLayer.compareTo(Layer.RIVERS) >= 0) { +// // import tile improvements +// tile.setTileItemContainer(new TileItemContainer(game, tile, template +// .getTileItemContainer(), layer)); +// if (layer.compareTo(Layer.NATIVES) >= 0) { +// // import native settlements +// if (template.getOwner() != null) { +// String nationId = template.getOwner().getNationId(); +// Player player = game.getPlayerByNationId(nationId); +// if (player == null) { +// Nation nation = game.getSpecification().getNation(nationId); +// player = new ServerPlayer(game, false, nation, null, null); +// game.addPlayer(player); +// } +// tile.setOwner(player); +// if (template.getOwningSettlement() != null) { +// IndianSettlement settlement = (IndianSettlement) template.getOwningSettlement(); +// tile.setOwningSettlement(new ServerIndianSettlement(game, +// player, tile, settlement)); +// } +// } +// } +// } +// } +// } +// } +// } +// for (Region region : regions.values()) { +// map.addRegion(region); +// } +// map.setLayer(highestLayer); +// game.setMap(map); +// return highestLayer; +// } +// +// +// @Override +// public Layer getHighestLayer() { +// return Layer.NATIVES; +// } +// } diff --git a/src/net/sf/freecol/server/generator/MapLayerGenerator.java b/src/net/sf/freecol/server/generator/MapLayerGenerator.java index 18136544..83e71d3a 100644 --- a/src/net/sf/freecol/server/generator/MapLayerGenerator.java +++ b/src/net/sf/freecol/server/generator/MapLayerGenerator.java @@ -17,30 +17,31 @@ * along with FreeCol. If not, see . */ -package net.sf.freecol.server.generator; +//package net.sf.freecol.server.generator; -import net.sf.freecol.common.model.Game; -import net.sf.freecol.common.model.Map.Layer; +//import net.sf.freecol.common.model.Game; +//import net.sf.freecol.common.model.Map.Layer; -/** - * Generates a map layer. - */ -public interface MapLayerGenerator { - - /** - * Generates the layer in the map of the given game. Returns true - * if the layer was generated, and false otherwise. - * - * @param game a Game value - * @return a boolean value - */ - public boolean generateLayer(Game game); - - /** - * Returns the Layer this MapLayerGenerator is able to generate. - * - * @return a Layer value - */ - public Layer getLayer(); - -} \ No newline at end of file +// TODO Remove unused code found by UCDetector +// /** +// * Generates a map layer. +// */ +// public interface MapLayerGenerator { +// +// /** +// * Generates the layer in the map of the given game. Returns true +// * if the layer was generated, and false otherwise. +// * +// * @param game a Game value +// * @return a boolean value +// */ +// public boolean generateLayer(Game game); +// +// /** +// * Returns the Layer this MapLayerGenerator is able to generate. +// * +// * @return a Layer value +// */ +// public Layer getLayer(); +// +// } \ No newline at end of file diff --git a/src/net/sf/freecol/server/generator/MapLoader.java b/src/net/sf/freecol/server/generator/MapLoader.java index 0c2a10c0..175e8c72 100644 --- a/src/net/sf/freecol/server/generator/MapLoader.java +++ b/src/net/sf/freecol/server/generator/MapLoader.java @@ -23,7 +23,7 @@ import net.sf.freecol.common.model.Map.Layer; -public interface MapLoader { +interface MapLoader { /** * Load a map into the given game, copying all layers up to the diff --git a/src/net/sf/freecol/server/generator/River.java b/src/net/sf/freecol/server/generator/River.java index 58377080..f1025162 100644 --- a/src/net/sf/freecol/server/generator/River.java +++ b/src/net/sf/freecol/server/generator/River.java @@ -38,7 +38,7 @@ /** * A river for the map generator. */ -public class River { +class River { private static final Logger logger = Logger.getLogger(SimpleMapGenerator.class.getName()); @@ -137,7 +137,7 @@ public Direction getNewDirection(Direction oldDirection) { * @param region The region for this river. * @param random The Random number source to use. */ - public River(Map map, java.util.Map riverMap, + River(Map map, java.util.Map riverMap, ServerRegion region, Random random) { this.map = map; this.riverMap = riverMap; @@ -185,15 +185,16 @@ public final void setRegion(final ServerRegion newServerRegion) { this.region = newServerRegion; } - /** - * Adds a new section to this river. - * - * @param tile The Tile where this section is located. - * @param direction The Direction the river is flowing in. - */ - public void add(Tile tile, Direction direction) { - this.sections.add(new RiverSection(tile, direction)); - } +// TODO Remove unused code found by UCDetector +// /** +// * Adds a new section to this river. +// * +// * @param tile The Tile where this section is located. +// * @param direction The Direction the river is flowing in. +// */ +// public void add(Tile tile, Direction direction) { +// this.sections.add(new RiverSection(tile, direction)); +// } /** * Increases the size of this river. @@ -201,7 +202,7 @@ public void add(Tile tile, Direction direction) { * @param lastSection The last section of the river flowing into this one. * @param tile The Tile of the confluence. */ - public void grow(RiverSection lastSection, Tile tile) { + private void grow(RiverSection lastSection, Tile tile) { boolean found = false; @@ -229,7 +230,7 @@ public void grow(RiverSection lastSection, Tile tile) { * @param tile A map tile. * @return true if the given tile is next to this river. */ - public boolean isNextToSelf(Tile tile) { + private boolean isNextToSelf(Tile tile) { return any(Direction.longSides, d -> this.contains(tile.getNeighbourOrNull(d))); } @@ -240,7 +241,7 @@ public boolean isNextToSelf(Tile tile) { * @param tile A map tile. * @return true if the given tile is next to a river, lake or sea. */ - public boolean isNextToWater(Tile tile) { + private boolean isNextToWater(Tile tile) { return any(Direction.longSides, d -> { Tile t = tile.getNeighbourOrNull(d); @@ -254,7 +255,7 @@ public boolean isNextToWater(Tile tile) { * @param tile A map tile. * @return true if this river already contains the given tile. */ - public boolean contains(Tile tile) { + private boolean contains(Tile tile) { return any(getSections(), rs -> rs.getTile() == tile); } @@ -264,7 +265,7 @@ public boolean contains(Tile tile) { * @param tile An origin map Tile. * @return True if a river was created, false otherwise. */ - public boolean flowFromSource(Tile tile) { + boolean flowFromSource(Tile tile) { TileImprovementType riverType = map.getSpecification().getTileImprovementType("model.improvement.river"); if (!riverType.isTileTypeAllowed(tile.getType())) { diff --git a/src/net/sf/freecol/server/generator/RiverSection.java b/src/net/sf/freecol/server/generator/RiverSection.java index 137d615b..07d9d40d 100644 --- a/src/net/sf/freecol/server/generator/RiverSection.java +++ b/src/net/sf/freecol/server/generator/RiverSection.java @@ -37,15 +37,9 @@ * manipulation of individual stream(s) to neighboring Tiles (there * are many in case of confluence) */ -public class RiverSection { +class RiverSection { -// private static final Logger logger = Logger.getLogger(RiverImprovementBuilder.class.getName()); - - private static final char[] template = { - '0', '1', '2', '3' - }; - - /** +/** * River magnitude (size) for each direction toward the edges of the tile */ private java.util.Map branches @@ -59,7 +53,7 @@ public class RiverSection { /** * Direction the river is flowing toward, at the current section */ - public Direction direction; + Direction direction; /** * Tile of the current river section @@ -67,26 +61,27 @@ public class RiverSection { private Tile tile; - /** - * Creates a new RiverSection with the given branches. This - * constructor is used by the MapEditor. - * - * @param branches The encoded style - */ - public RiverSection(java.util.Map branches) { - this.branches = branches; - } - - /** - * Constructor used to automatically generate rivers. - * - * @param tile The map tile - * @param direction The direction the river is flowing toward - */ - public RiverSection(Tile tile, Direction direction) { - this.tile = tile; - this.direction = direction; - setBranch(direction, TileImprovement.SMALL_RIVER); +// TODO Remove unused code found by UCDetector +// /** +// * Creates a new RiverSection with the given branches. This +// * constructor is used by the MapEditor. +// * +// * @param branches The encoded style +// */ +// public RiverSection(java.util.Map branches) { +// this.branches = branches; +// } + +// /** +// * Constructor used to automatically generate rivers. +// * +// * @param tile The map tile +// * @param direction The direction the river is flowing toward +// */ + public RiverSection(Tile tile, Direction direction) { + this.tile = tile; + this.direction = direction; + setBranch(direction, TileImprovement.SMALL_RIVER); } /** @@ -109,7 +104,7 @@ public final int getSize() { /** * Sets the size of a branch */ - public final void setBranch(Direction direction, int size) { + final void setBranch(Direction direction, int size) { if (size != TileImprovement.SMALL_RIVER) { size = TileImprovement.LARGE_RIVER; } @@ -119,7 +114,7 @@ public final void setBranch(Direction direction, int size) { /** * Gets the size of a branch */ - public final int getBranch(Direction direction) { + private final int getBranch(Direction direction) { if (branches.containsKey(direction)) { return branches.get(direction); } else { @@ -127,33 +122,35 @@ public final int getBranch(Direction direction) { } } - /** - * Removes a branch - */ - public final void removeBranch(Direction direction) { - branches.remove(direction); - } - - /** - * Increases the size a branch - */ - public final void growBranch(Direction direction, int increment) { - int newSize = Math.min(TileImprovement.LARGE_RIVER, - Math.max(TileImprovement.NO_RIVER, - getBranch(direction) + increment)); - setBranch(direction, newSize); - } +// TODO Remove unused code found by UCDetector +// /** +// * Removes a branch +// */ +// public final void removeBranch(Direction direction) { +// branches.remove(direction); +// } + +// TODO Remove unused code found by UCDetector +// /** +// * Increases the size a branch +// */ +// public final void growBranch(Direction direction, int increment) { +// int newSize = Math.min(TileImprovement.LARGE_RIVER, +// Math.max(TileImprovement.NO_RIVER, +// getBranch(direction) + increment)); +// setBranch(direction, newSize); +// } /** * Increases the size of this section by one. */ - public void grow() { + void grow() { this.size++; setBranch(direction, TileImprovement.LARGE_RIVER); } - public String encodeStyle() { + String encodeStyle() { StringBuilder sb = new StringBuilder(); for (Direction direction : Direction.longSides) { sb.append(Integer.toString(getBranch(direction), Character.MAX_RADIX)); diff --git a/src/net/sf/freecol/server/generator/SimpleMapGenerator.java b/src/net/sf/freecol/server/generator/SimpleMapGenerator.java index 6a1815c4..f20763b7 100644 --- a/src/net/sf/freecol/server/generator/SimpleMapGenerator.java +++ b/src/net/sf/freecol/server/generator/SimpleMapGenerator.java @@ -355,18 +355,7 @@ private void makeNativeSettlements(final Map map, LogBuilder lb) { HashMap territoryMap = new HashMap<>(); for (Player player : game.getLiveNativePlayers(null)) { - switch (player.getNationType() - .getNumberOfSettlements()) { - case HIGH: - shares += 4; - break; - case AVERAGE: - shares += 3; - break; - case LOW: - shares += 2; - break; - } + shares = updateShares(shares, player); indians.add(player); List regionKeys = ((IndianNationType)player.getNationType()).getRegionNames(); @@ -377,12 +366,7 @@ private void makeNativeSettlements(final Map map, LogBuilder lb) { } else { for (String key : regionKeys) { if (territoryMap.get(key) == null) { - ServerRegion region = (ServerRegion)map.getRegionByKey(key); - if (region == null) { - territory = new Territory(player, map.getRandomLandTile(random)); - } else { - territory = new Territory(player, region); - } + territory = newTerritory(map, player, key); territoryMap.put(key, territory); lb.add("Allocated region ", key, " for ", player, ".\n"); @@ -428,10 +412,7 @@ private void makeNativeSettlements(final Map map, LogBuilder lb) { = spec.getRangeOption(GameOptions.SETTLEMENT_NUMBER).getValue(); List settlementTiles = new ArrayList<>(); for (Tile tile : allTiles) { - if (!tile.isPolar() - && suitableForNativeSettlement(tile) - && none(settlementTiles, t -> t.getDistanceTo(tile) < minDistance)) - settlementTiles.add(tile); + settlementTiles = checkPolar(minDistance, settlementTiles, tile); } randomShuffle(logger, "Settlement tiles", settlementTiles, random); @@ -451,18 +432,7 @@ && none(settlementTiles, t -> t.getDistanceTo(tile) < minDistance)) = new ArrayList<>(territoryMap.values()); int settlementsPlaced = 0; for (Territory territory : territories) { - switch (territory.player.getNationType() - .getNumberOfSettlements()) { - case HIGH: - territory.numberOfSettlements = Math.round(4 * share); - break; - case AVERAGE: - territory.numberOfSettlements = Math.round(3 * share); - break; - case LOW: - territory.numberOfSettlements = Math.round(2 * share); - break; - } + territory = updateSettlementNo(share, territory); int radius = territory.player.getNationType().getCapitalType() .getClaimableRadius(); IndianSettlement is = placeCapital(map, territory, radius, @@ -500,7 +470,6 @@ && none(settlementTiles, t -> t.getDistanceTo(tile) < minDistance)) if (territory.numberOfSettlements <= 0) { territories.remove(territory); } - } } @@ -511,14 +480,7 @@ && none(settlementTiles, t -> t.getDistanceTo(tile) < minDistance)) randomShuffle(logger, "Settlements", settlements, random); for (IndianSettlement is : settlements) { List tiles = new ArrayList<>(); - for (Tile tile : is.getOwnedTiles()) { - for (Tile t : tile.getSurroundingTiles(1)) { - if (t.getOwningSettlement() == null) { - tiles.add(tile); - break; - } - } - } + tiles = addTile(is, tiles); randomShuffle(logger, "Settlement tiles", tiles, random); int minGrow = is.getType().getMinimumGrowth(); int maxGrow = is.getType().getMaximumGrowth(); @@ -565,18 +527,7 @@ && none(settlementTiles, t -> t.getDistanceTo(tile) < minDistance)) // with a bit of favoritism to capitals as the needed skill // is so rare,... for (IndianSettlement is : extras) { - IndianNationType nation - = (IndianNationType) is.getOwner().getNationType(); - int cm = (is.isCapital()) ? 2 : 1; - RandomChoice rc = null; - for (RandomChoice c : nation.generateSkillsForTile(is.getTile())) { - if (c.getObject() == neededSkill) { - rc = new RandomChoice<>(is, c.getProbability() * cm); - break; - } - } - choices.add((rc != null) ? rc - : new RandomChoice<>(is, 1)); + choices = addChoices(neededSkill, choices, is); } if (!choices.isEmpty()) { // ...and pick one that could do the missing job. @@ -596,19 +547,119 @@ && none(settlementTiles, t -> t.getDistanceTo(tile) < minDistance)) lb.add("Game is missing skill: ", neededSkill, "\n"); } } + + //done refactoring below lb.add("Settlement skills:"); for (List iss : isList) { - if (iss.isEmpty()) { - lb.add(" 0 x "); - } else { - lb.add(" ", iss.size(), - " x ", iss.get(0).getLearnableSkill().getSuffix()); - } + lb = addSettlementSkill(lb, iss); } lb.add("\nCreated ", settlementsPlaced, " Indian settlements of maximum ", settlementsToPlace, ".\n"); } + + private List> addChoices(UnitType neededSkill, List> choices, IndianSettlement is) { + IndianNationType nation + = (IndianNationType) is.getOwner().getNationType(); + int cm = (is.isCapital()) ? 2 : 1; + RandomChoice rc = null; + rc = updateRC(neededSkill, is, nation, cm, rc); + choices.add((rc != null) ? rc + : new RandomChoice<>(is, 1)); + return choices; + } + + + private RandomChoice updateRC(UnitType neededSkill, IndianSettlement is, IndianNationType nation, + int cm, RandomChoice rc) { + for (RandomChoice c : nation.generateSkillsForTile(is.getTile())) { + if (c.getObject() == neededSkill) { + rc = new RandomChoice<>(is, c.getProbability() * cm); + break; + } + } + return rc; + } + + + private List addTile(IndianSettlement is, List tiles) { + for (Tile tile : is.getOwnedTiles()) { + for (Tile t : tile.getSurroundingTiles(1)) { + if (t.getOwningSettlement() == null) { + tiles.add(tile); + break; + } + } + } + return tiles; + } + + + private Territory updateSettlementNo(float share, Territory territory) { + switch (territory.player.getNationType() + .getNumberOfSettlements()) { + case HIGH: + territory.numberOfSettlements = Math.round(4 * share); + break; + case AVERAGE: + territory.numberOfSettlements = Math.round(3 * share); + break; + case LOW: + territory.numberOfSettlements = Math.round(2 * share); + break; + } + return territory; + } + + + private List checkPolar(final int minDistance, List settlementTiles, Tile tile) { + if (!tile.isPolar() + && suitableForNativeSettlement(tile) + && none(settlementTiles, t -> t.getDistanceTo(tile) < minDistance)) + settlementTiles.add(tile); + return settlementTiles; + } + + + private Territory newTerritory(final Map map, Player player, String key) { + Territory territory; + ServerRegion region = (ServerRegion)map.getRegionByKey(key); + if (region == null) { + territory = new Territory(player, map.getRandomLandTile(random)); + } else { + territory = new Territory(player, region); + } + return territory; + } + + + private float updateShares(float shares, Player player) { + switch (player.getNationType() + .getNumberOfSettlements()) { + case HIGH: + shares += 4; + break; + case AVERAGE: + shares += 3; + break; + case LOW: + shares += 2; + break; + } + return shares; + } + + + private LogBuilder addSettlementSkill(LogBuilder lb, List iss) { + if (iss.isEmpty()) { + lb.add(" 0 x "); + } else { + lb.add(" ", iss.size(), + " x ", iss.get(0).getLearnableSkill().getSuffix()); + } + return lb; + } + /** * Is a tile suitable for a native settlement? * Require the tile be settleable, and at least half its neighbours @@ -921,7 +972,8 @@ private Tile findTileFor(Map map, int row, int start, boolean startAtSea, return null; } - private void createDebugUnits(Map map, Player player, Tile startTile, + @SuppressWarnings("unused") + private void createDebugUnits(Map map, Player player, Tile startTile, LogBuilder lb) { // In debug mode give each player a few more units and a colony. UnitType unitType = spec.getUnitType("model.unit.galleon"); @@ -930,11 +982,12 @@ private void createDebugUnits(Map map, Player player, Tile startTile, Unit privateer = new ServerUnit(game, startTile, player, unitType); ((ServerPlayer)player).exploreForUnit(privateer); unitType = spec.getUnitType("model.unit.freeColonist"); - Unit unit5 = new ServerUnit(game, unit4, player, unitType); + Unit unit5 = new ServerUnit(game, unit4, player, unitType); unitType = spec.getUnitType("model.unit.veteranSoldier"); - Unit unit6 = new ServerUnit(game, unit4, player, unitType); + Unit unit6 = new ServerUnit(game, unit4, player, unitType); unitType = spec.getUnitType("model.unit.jesuitMissionary"); - Unit unit7 = new ServerUnit(game, unit4, player, unitType); + + Unit unit7 = new ServerUnit(game, unit4, player, unitType); Tile colonyTile = null; for (Tile tempTile : map.getCircleTiles(startTile, true, diff --git a/src/net/sf/freecol/server/generator/TerrainGenerator.java b/src/net/sf/freecol/server/generator/TerrainGenerator.java index 77fbdb07..417b7c7e 100644 --- a/src/net/sf/freecol/server/generator/TerrainGenerator.java +++ b/src/net/sf/freecol/server/generator/TerrainGenerator.java @@ -60,9 +60,9 @@ public class TerrainGenerator { private static final Logger logger = Logger.getLogger(TerrainGenerator.class.getName()); - public static final int LAND_REGIONS_SCORE_VALUE = 1000; - public static final int LAND_REGION_MIN_SCORE = 5; - public static final int LAND_REGION_MAX_SIZE = 75; + private static final int LAND_REGIONS_SCORE_VALUE = 1000; + private static final int LAND_REGION_MIN_SCORE = 5; + private static final int LAND_REGION_MAX_SIZE = 75; /** The Game to generate for. */ private final Game game; @@ -98,7 +98,7 @@ public class TerrainGenerator { * @param random A Random number source. * @see #createMap */ - public TerrainGenerator(Game game, Game importGame, Random random) { + TerrainGenerator(Game game, Game importGame, Random random) { this.game = game; this.importGame = importGame; this.random = random; @@ -431,7 +431,8 @@ private List createLandRegions(Map map, LogBuilder lb) { // Create ServerRegions for all land regions ServerRegion[] landregions = new ServerRegion[continents+1]; - int landIndex = 1; + @SuppressWarnings("unused") + int landIndex = 1; for (int c = 1; c <= continents; c++) { // c starting at 1, c=0 is all water tiles landregions[c] = new ServerRegion(game, RegionType.LAND); @@ -651,8 +652,6 @@ private List createRivers(Map map, LogBuilder lb) { * @return A list of created ServerRegions. */ private List createLakeRegions(Map map, LogBuilder lb) { - final TileType lakeType = spec.getTileType("model.tile.lake"); - // Create the water map, and find any tiles that are water but // not part of any region (such as the oceans). These are // lake tiles. @@ -691,7 +690,6 @@ public static List makeLakes(Map map, List lakes) { .getTileType("model.tile.lake"); List todo = new ArrayList<>(); List result = new ArrayList<>(); - int lakeCount = 0; while (!lakes.isEmpty()) { Tile tile = lakes.get(0); if (tile.getRegion() != null) continue; @@ -858,7 +856,7 @@ public static void encodeStyle(Tile tile) { * @param lb A LogBuilder to log to. * @return The new Map. */ - public Map createMap(LandMap landMap, LogBuilder lb) { + Map createMap(LandMap landMap, LogBuilder lb) { final int width = landMap.getWidth(); final int height = landMap.getHeight(); final boolean importTerrain = (importGame != null) diff --git a/test/src/net/sf/freecol/client/gui/FontTest.java b/test/src/net/sf/freecol/client/gui/FontTest.java index c2a90334..8d8471a2 100644 --- a/test/src/net/sf/freecol/client/gui/FontTest.java +++ b/test/src/net/sf/freecol/client/gui/FontTest.java @@ -19,12 +19,43 @@ package net.sf.freecol.client.gui; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; + +import java.awt.Color; +import java.awt.Container; import java.awt.Font; +import java.awt.event.ActionEvent; +import java.awt.event.MouseEvent; +import java.awt.geom.GeneralPath; +import java.io.ByteArrayInputStream; import java.io.File; import java.io.FileFilter; +import java.util.ArrayList; import java.util.HashMap; +import java.util.List; import java.util.Map; +import javax.swing.ImageIcon; +import javax.swing.JInternalFrame; +import javax.swing.JScrollPane; +import javax.swing.JTextArea; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +import net.sf.freecol.client.FreeColClient; +import net.sf.freecol.client.gui.menu.FreeColMenuTest; +import net.sf.freecol.client.gui.panel.AboutPanel; +import net.sf.freecol.client.gui.panel.ClassicMapControls; +import net.sf.freecol.client.gui.panel.ColopediaTreeCellRenderer; +import net.sf.freecol.client.gui.panel.Flag; + +import net.sf.freecol.client.gui.panel.MapControls; +import net.sf.freecol.common.model.IndianNationType; +import net.sf.freecol.common.model.Specification; import net.sf.freecol.util.test.FreeColTestCase; @@ -46,6 +77,112 @@ public boolean accept(File pathname) { } + public void testFreeColMenuTest_1() + throws Exception { + FreeColMenuTest result = new FreeColMenuTest(); + assertNotNull(result); + // add additional test code here + } + + /* + public void testCreateContentPane_1() + throws Exception { + FreeColMenuTest fixture = new FreeColMenuTest(); + fixture.output = new JTextArea(); + fixture.scrollPane = new JScrollPane(); + + Container result = fixture.createContentPane(); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getComponentCount()); + assertEquals(0.5f, result.getAlignmentX(), 1.0f); + assertEquals(0.5f, result.getAlignmentY(), 1.0f); + assertEquals(null, result.getFocusTraversalPolicy()); + assertEquals(false, result.isFocusCycleRoot()); + assertEquals(false, result.isValidateRoot()); + //assertEquals(1, result.countComponents()); + assertEquals(false, result.isFocusTraversalPolicyProvider()); + assertEquals(false, result.isFocusTraversalPolicySet()); + assertEquals("javax.swing.JPanel[,0,0,0x0,invalid,layout=java.awt.BorderLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=16777225,maximumSize=,minimumSize=,preferredSize=]", result.toString()); + assertEquals(null, result.getName()); + assertEquals(null, result.getParent()); + assertEquals(true, result.isOpaque()); + assertEquals(false, result.isValid()); + assertEquals(0, result.getY()); + assertEquals(true, result.isEnabled()); + assertEquals(false, result.requestFocusInWindow()); + assertEquals(null, result.getInputContext()); + assertEquals(0, result.getWidth()); + assertEquals(false, result.hasFocus()); + assertEquals(false, result.isShowing()); + assertEquals(true, result.isVisible()); + assertEquals(null, result.getMousePosition()); + assertEquals(null, result.getGraphics()); + assertEquals(null, result.getFocusCycleRootAncestor()); + // assertEquals(null, result.getPeer()); + assertEquals(false, result.isDisplayable()); + assertEquals(true, result.isDoubleBuffered()); + assertEquals(false, result.isMaximumSizeSet()); + assertEquals(false, result.isMinimumSizeSet()); + assertEquals(false, result.isPreferredSizeSet()); + assertEquals(0, result.getX()); + assertEquals(0, result.getHeight()); + assertEquals(null, result.getGraphicsConfiguration()); + assertEquals(false, result.isFocusOwner()); + assertEquals(true, result.isFocusable()); + assertEquals(false, result.isLightweight()); + assertEquals(null, result.getDropTarget()); + assertEquals(true, result.getFocusTraversalKeysEnabled()); + assertEquals(false, result.getIgnoreRepaint()); + assertEquals(null, result.getInputMethodRequests()); + assertEquals(true, result.isBackgroundSet()); + assertEquals(false, result.isCursorSet()); + + assertEquals(true, result.isFontSet()); + assertEquals(true, result.isForegroundSet()); + } + + public void testGetClassName_1() + throws Exception { + FreeColMenuTest fixture = new FreeColMenuTest(); + fixture.output = new JTextArea(); + fixture.scrollPane = new JScrollPane(); + Object o = new Object(); + + String result = fixture.getClassName(o); + + // add additional test code here + assertEquals("Object", result); + } +*/ + /** + * Run the void itemStateChanged(ItemEvent) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/16/17 1:20 AM + */ + + /** + * Run the void itemStateChanged(ItemEvent) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/16/17 1:20 AM + */ + + @Test + public void testMain_1() + throws Exception { + String[] args = new String[] {}; + + FreeColMenuTest.main(args); + + // add additional test code here + } + + public void testLogicalSerif() { try { @@ -60,21 +197,977 @@ public void testLogicalSerif() { } } - /* - public void testLiberationSerif() { + public void testFlag_1() + throws Exception { + Flag.Background background = Flag.Background.FESSES; + Flag.Decoration decoration = Flag.Decoration.BEND; + Flag.UnionPosition unionPosition = Flag.UnionPosition.BOTTOM; - File liberationSerif = new File("data/base/resources/fonts/LiberationSerif-Regular.ttf"); - try { - Font font = Font.createFont(Font.TRUETYPE_FONT, liberationSerif); - assertNotNull(font); - for (Map.Entry entry : specialCharacters.entrySet()) { - assertTrue(font.getName() + " can not display " + entry.getValue(), - font.canDisplay(entry.getKey())); - } - } catch (Exception e) { - fail(e.toString()); - } - } - */ + Flag result = new Flag(background, decoration, unionPosition); + + // add additional test code here + assertNotNull(result); + assertEquals(13, result.getStars()); + assertEquals(13, result.getStripes()); + } + + public void testGetBackground_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Flag.Background result = fixture.getBackground(); + + // add additional test code here + assertNotNull(result); + assertEquals("FESSES", result.name()); + assertEquals("FESSES", result.toString()); + assertEquals(3, result.ordinal()); + } + + public void testGetBackgroundColors_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + List result = fixture.getBackgroundColors(); + + // add additional test code here + assertNotNull(result); + assertEquals(0, result.size()); + } + + public void testGetDecoration_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Flag.Decoration result = fixture.getDecoration(); + + // add additional test code here + assertNotNull(result); + assertEquals("BEND", result.name()); + assertEquals("BEND", result.toString()); + assertEquals(6, result.ordinal()); + } + + public void testGetDecorationColor_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Color result = fixture.getDecorationColor(); + + // add additional test code here + assertNotNull(result); + assertEquals("java.awt.Color[r=0,g=0,b=1]", result.toString()); + assertEquals(-16777215, result.getRGB()); + assertEquals(255, result.getAlpha()); + assertEquals(1, result.getTransparency()); + assertEquals(0, result.getGreen()); + assertEquals(1, result.getBlue()); + assertEquals(0, result.getRed()); + } + + public void testGetGridOfStars_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + java.awt.geom.Rectangle2D.Double union = new java.awt.geom.Rectangle2D.Double(); + + GeneralPath result = fixture.getGridOfStars(union); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getWindingRule()); + } + + /** + * Run the GeneralPath getGridOfStars(Double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetGridOfStars_2() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + java.awt.geom.Rectangle2D.Double union = new java.awt.geom.Rectangle2D.Double(); + + GeneralPath result = fixture.getGridOfStars(union); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getWindingRule()); + } + + /** + * Run the GeneralPath getGridOfStars(Double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetGridOfStars_3() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(0); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + java.awt.geom.Rectangle2D.Double union = new java.awt.geom.Rectangle2D.Double(); + + GeneralPath result = fixture.getGridOfStars(union); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getWindingRule()); + assertEquals(null, result.getCurrentPoint()); + } + + /** + * Run the GeneralPath getGridOfStars(Double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + + @Test + public void testGetStar_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + double x = 1.0; + double y = 1.0; + + GeneralPath result = fixture.getStar(x, y); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getWindingRule()); + } + + /** + * Run the GeneralPath getStar(double,double,double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetStar_2() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + double scale = 1.0; + double x = 1.0; + double y = 1.0; + + GeneralPath result = fixture.getStar(scale, x, y); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getWindingRule()); + } + + /** + * Run the GeneralPath getStar(double,double,double) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetStar_3() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + double scale = -4.9E-324; + double x = 1.0; + double y = 1.0; + + GeneralPath result = fixture.getStar(scale, x, y); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getWindingRule()); + } + + /** + * Run the Color getStarColor() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetStarColor_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Color result = fixture.getStarColor(); + + // add additional test code here + assertNotNull(result); + assertEquals("java.awt.Color[r=0,g=0,b=1]", result.toString()); + assertEquals(-16777215, result.getRGB()); + assertEquals(255, result.getAlpha()); + assertEquals(1, result.getTransparency()); + assertEquals(0, result.getGreen()); + assertEquals(1, result.getBlue()); + assertEquals(0, result.getRed()); + } + + /** + * Run the int getStars() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetStars_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + int result = fixture.getStars(); + + // add additional test code here + assertEquals(1, result); + } + + /** + * Run the int getStripes() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetStripes_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + int result = fixture.getStripes(); + + // add additional test code here + assertEquals(1, result); + } + + /** + * Run the Color getUnionColor() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetUnionColor_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Color result = fixture.getUnionColor(); + + // add additional test code here + assertNotNull(result); + assertEquals("java.awt.Color[r=0,g=0,b=1]", result.toString()); + assertEquals(-16777215, result.getRGB()); + assertEquals(255, result.getAlpha()); + assertEquals(1, result.getTransparency()); + assertEquals(0, result.getGreen()); + assertEquals(1, result.getBlue()); + assertEquals(0, result.getRed()); + } + + /** + * Run the Flag.UnionPosition getUnionPosition() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetUnionPosition_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Flag.UnionPosition result = fixture.getUnionPosition(); + + // add additional test code here + assertNotNull(result); + assertEquals("BOTTOM", result.name()); + assertEquals("BOTTOM", result.toString()); + assertEquals(5, result.ordinal()); + } + + /** + * Run the Flag.UnionShape getUnionShape() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testGetUnionShape_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Flag.UnionShape result = fixture.getUnionShape(); + + // add additional test code here + assertNotNull(result); + assertEquals("BEND", result.name()); + assertEquals("BEND", result.toString()); + assertEquals(3, result.ordinal()); + } + + /** + * Run the Flag setBackground(Background) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetBackground_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + Flag.Background background = Flag.Background.FESSES; + + Flag result = fixture.setBackground(background); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setBackgroundColors(List) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetBackgroundColors_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + List backgroundColors = new ArrayList(); + + Flag result = fixture.setBackgroundColors(backgroundColors); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setBackgroundColors(Color[]) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetBackgroundColors_2() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Flag result = fixture.setBackgroundColors(); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setBackgroundColors(Color[]) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetBackgroundColors_3() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Flag result = fixture.setBackgroundColors(); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setBackgroundColors(Color[]) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetBackgroundColors_4() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + + Flag result = fixture.setBackgroundColors(); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setDecoration(Decoration) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetDecoration_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + Flag.Decoration decoration = Flag.Decoration.BEND; + + Flag result = fixture.setDecoration(decoration); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setDecorationColor(Color) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetDecorationColor_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + Color decorationColor = new Color(1); + + Flag result = fixture.setDecorationColor(decorationColor); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setStarColor(Color) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetStarColor_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + Color starColor = new Color(1); + + Flag result = fixture.setStarColor(starColor); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setStars(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetStars_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + int stars = 1; + + Flag result = fixture.setStars(stars); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setStripes(int) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetStripes_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + int stripes = 1; + + Flag result = fixture.setStripes(stripes); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setUnionColor(Color) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetUnionColor_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + Color unionColor = new Color(1); + + Flag result = fixture.setUnionColor(unionColor); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setUnionPosition(UnionPosition) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetUnionPosition_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + Flag.UnionPosition position = Flag.UnionPosition.BOTTOM; + + Flag result = fixture.setUnionPosition(position); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + /** + * Run the Flag setUnionShape(UnionShape) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/15/17 8:50 PM + */ + @Test + public void testSetUnionShape_1() + throws Exception { + Flag fixture = new Flag(Flag.Background.FESSES, Flag.Decoration.BEND, Flag.UnionPosition.BOTTOM, Flag.UnionShape.BEND); + fixture.setDecorationColor(new Color(1)); + fixture.setUnionColor(new Color(1)); + fixture.setStarColor(new Color(1)); + fixture.setStars(1); + fixture.setStripes(1); + fixture.setBackgroundColors(new ArrayList()); + Flag.UnionShape shape = Flag.UnionShape.BEND; + + Flag result = fixture.setUnionShape(shape); + + // add additional test code here + assertNotNull(result); + assertEquals(1, result.getStars()); + assertEquals(1, result.getStripes()); + } + + + + + + public void testChoiceItem() + throws Exception { + String text = ""; + + ChoiceItem result = new ChoiceItem(text, null); + + + + assertNotNull(result); + assertEquals("", result.toString()); + assertEquals(null, result.getObject()); + assertEquals(false, result.isDefault()); + assertEquals(true, result.isEnabled()); + assertEquals(false, result.isOK()); + assertEquals(null, result.getIcon()); + + } + + + + public void testCancelOption_1() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(fixture.getIcon()); + + ChoiceItem result = fixture.cancelOption(); + + // add additional test code here + assertNotNull(result); + assertEquals("", result.toString()); + assertEquals(null, result.getObject()); + assertEquals(false, result.isDefault()); + assertEquals(true, result.isEnabled()); + assertEquals(false, result.isOK()); + assertEquals(true, result.isCancel()); + } + + public void testCompareTo1() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(fixture.getIcon()); + ChoiceItem other = new ChoiceItem((String) null, (Object) null, true); + + int result = fixture.compareTo(other); + + + assertEquals(1, result); + } + + + + + + public void testGetObject_1() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(fixture.getIcon()); + + Object result = fixture.getObject(); + + // add additional test code here + assertEquals(null, result); + } + + public void testDefaultOption_1() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(fixture.getIcon()); + + ChoiceItem result = fixture.defaultOption(); + + // add additional test code here + assertNotNull(result); + assertEquals("", result.toString()); + assertEquals(null, result.getObject()); + assertEquals(true, result.isDefault()); + assertEquals(true, result.isEnabled()); + assertEquals(false, result.isOK()); + + } + + public void testOkOption_1() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(fixture.getIcon()); + + ChoiceItem result = fixture.okOption(); + + // add additional test code here + assertNotNull(result); + assertEquals("", result.toString()); + assertEquals(null, result.getObject()); + assertEquals(false, result.isDefault()); + assertEquals(true, result.isEnabled()); + assertEquals(true, result.isOK()); + + } + + public void testGetIcon_1() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(new ImageIcon()); + + ImageIcon result = fixture.getIcon(); + + // add additional test code here + assertNotNull(result); + assertEquals(null, result.getDescription()); + assertEquals(null, result.getImage()); + assertEquals(-1, result.getIconHeight()); + assertEquals(-1, result.getIconWidth()); + assertEquals(0, result.getImageLoadStatus()); + assertEquals(null, result.getImageObserver()); + } + + public void testIsDefault_2() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(new ImageIcon()); + + boolean result = fixture.isDefault(); + + // add additional test code here + assertEquals(false, result); + } + + + public void testIsEnabled_1() + throws Exception { + ChoiceItem fixture = new ChoiceItem("", (Object) null, true); + fixture.setIcon(new ImageIcon()); + + boolean result = fixture.isEnabled(); + + // add additional test code here + assertEquals(true, result); + } + + public void testFrameMotionListener_1() + throws Exception { + JInternalFrame f = new JInternalFrame(); + + FrameMotionListener result = new FrameMotionListener(f); + result.mouseDragged(null); + result.mousePressed(null); + + assertNotNull(result); + } + + public void testTerrainCursor_1() + throws Exception { + + TerrainCursor result = new TerrainCursor(); + + + assertNotNull(result); + assertEquals(true, result.isActive()); + } + + public void testFireActionEvent_1() + throws Exception { + TerrainCursor fixture = new TerrainCursor(); + fixture.setActive(true); + ActionEvent ae = new ActionEvent(new Object(), 1, ""); + + fixture.fireActionEvent(ae); + + + } + + public void testIsActive_1() + throws Exception { + TerrainCursor fixture = new TerrainCursor(); + fixture.setActive(true); + + boolean result = fixture.isActive(); + + + assertEquals(true, result); + } + + public void testIndianNationType_1() + throws Exception { + String id = ""; + Specification specification = new Specification(); + + IndianNationType result = new IndianNationType(id, specification); + + + assertNotNull(result); + assertEquals(false, result.isEuropean()); + assertEquals(false, result.isREF()); + assertEquals(true, result.isIndian()); + assertEquals("indian-nation-type", result.getXMLTagName()); + assertEquals(null, result.getCapitalType()); + assertEquals("", result.toString()); + assertEquals(".description", result.getDescriptionKey()); + assertEquals(".name", result.getNameKey()); + assertEquals(false, result.isAbstractType()); + assertEquals("", result.getId()); + assertEquals("", result.getSuffix()); + assertEquals("", result.serialize()); + + assertEquals("", result.getIdType()); + assertEquals(-1, result.getIdNumber()); + } + + + } diff --git a/test/src/net/sf/freecol/common/i18n/CLDRTest.java b/test/src/net/sf/freecol/common/i18n/CLDRTest.java index 630f9e84..f861b014 100644 --- a/test/src/net/sf/freecol/common/i18n/CLDRTest.java +++ b/test/src/net/sf/freecol/common/i18n/CLDRTest.java @@ -1,4 +1,6 @@ /** + + * Copyright (C) 2002-2015 The FreeCol Team * * This file is part of FreeCol. @@ -19,10 +21,22 @@ package net.sf.freecol.common.i18n; +import java.awt.List; import java.io.File; import java.io.FileInputStream; +import org.w3c.dom.Element; + +import net.sf.freecol.common.FreeColSeed; +import net.sf.freecol.common.ServerInfo; import net.sf.freecol.common.i18n.Number.Category; +import net.sf.freecol.common.model.AbstractGoods; +import net.sf.freecol.common.model.Game; +import net.sf.freecol.common.model.GoodsType; +import net.sf.freecol.common.model.IndianNationType; +import net.sf.freecol.common.model.ResourceType; +import net.sf.freecol.common.model.Specification; +import net.sf.freecol.common.model.Tile; import net.sf.freecol.util.test.FreeColTestCase; @@ -64,8 +78,6 @@ public void testPlurals() { } catch (Exception e) { fail("Failed to open input stream."); } - NumberRules numberRules = new NumberRules(in); - try { in.close(); } catch (Exception e) { @@ -108,4 +120,152 @@ public void testPlurals() { assertNotNull(NumberRules.getNumberForLanguage("sms")); assertTrue(NumberRules.getNumberForLanguage("sms") instanceof DualNumberRule); } + + public void testFreeColSeed_1() + throws Exception { + FreeColSeed result = new FreeColSeed(); + assertNotNull(result); + // add additional test code here + } + + + + public void testGetFreeColSeed_1() + throws Exception { + boolean generate = true; + + long result = FreeColSeed.getFreeColSeed(generate); + + + assertNotNull(result); + } + + public void testServerInfo_1() + throws Exception { + + ServerInfo result = new ServerInfo(); + + // add additional test code here + assertNotNull(result); + assertEquals("null(null:0) 0, 0, false, null, 0", result.toString()); + assertEquals(null, result.getAddress()); + assertEquals(null, result.getName()); + assertEquals(0, result.getPort()); + assertEquals(null, result.getVersion()); + assertEquals(0, result.getGameState()); + assertEquals(0, result.getSlotsAvailable()); + assertEquals(0, result.getCurrentlyPlaying()); + } + + + public void testGetRegionNames_1() + throws Exception { + IndianNationType fixture = new IndianNationType("", new Specification()); + + java.util.List result = fixture.getRegionNames(); + + // add additional test code here + assertNotNull(result); + assertEquals(0, result.size()); + } + + public void testIndianNationType_1() + throws Exception { + String id = ""; + Specification specification = new Specification(); + + IndianNationType result = new IndianNationType(id, specification); + + // add additional test code here + assertNotNull(result); + assertEquals(false, result.isEuropean()); + assertEquals(false, result.isREF()); + assertEquals(true, result.isIndian()); + assertEquals("indian-nation-type", result.getXMLTagName()); + assertEquals(null, result.getCapitalType()); + assertEquals("", result.toString()); + assertEquals(".description", result.getDescriptionKey()); + assertEquals(".name", result.getNameKey()); + assertEquals(false, result.isAbstractType()); + assertEquals("", result.getId()); + assertEquals("", result.getSuffix()); + assertEquals("", result.serialize()); + + assertEquals("", result.getIdType()); + assertEquals(-1, result.getIdNumber()); + } + + public void testGetAddress_1() + throws Exception { + ServerInfo fixture = new ServerInfo(); + fixture.update("", "", 1, 1, 1, true, "", 1); + + String result = fixture.getAddress(); + + + assertEquals("", result); + } + + public void testGetCurrentlyPlaying_1() + throws Exception { + ServerInfo fixture = new ServerInfo(); + fixture.update("", "", 1, 1, 1, true, "", 1); + + int result = fixture.getCurrentlyPlaying(); + + // add additional test code here + assertEquals(1, result); + } + + public void testGetCurrentlyPlaying_2() + throws Exception { + ServerInfo fixture = new ServerInfo(); + fixture.update("", "", 1, 1, 1, true, "", 1); + + String result = ServerInfo.getXMLElementTagName(); + + + // add additional test code here + assertNotNull(result); + } + + + public void testGetBestGoodsType_2() + throws Exception { + ResourceType fixture = new ResourceType("", new Specification()); + + GoodsType result = fixture.getBestGoodsType(); + + assertEquals(null, result); + } + + + public void testGetMaxValue_1() + throws Exception { + ResourceType fixture = new ResourceType("", new Specification()); + + int result = fixture.getMaxValue(); + + assertEquals(0, result); + } + + + public void testGetMinValue_1() + throws Exception { + ResourceType fixture = new ResourceType("", new Specification()); + + int result = fixture.getMinValue(); + + assertEquals(0, result); + } + public void testGetTagName_1() + throws Exception { + + String result = ResourceType.getXMLElementTagName(); + + // add additional test code here + assertEquals("resource-type", result); + } + } + diff --git a/test/src/net/sf/freecol/common/io/ModTest.java b/test/src/net/sf/freecol/common/io/ModTest.java index 924f09ef..1b9817ab 100644 --- a/test/src/net/sf/freecol/common/io/ModTest.java +++ b/test/src/net/sf/freecol/common/io/ModTest.java @@ -19,30 +19,42 @@ package net.sf.freecol.common.io; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; + +import java.io.BufferedInputStream; +import java.io.File; +import java.io.FileFilter; +import java.util.Collection; import java.util.HashSet; +import java.util.List; +import java.util.Locale; import java.util.Set; +import java.io.IOException; +import org.junit.*; + + +import org.junit.Test; import net.sf.freecol.util.test.FreeColTestCase; public class ModTest extends FreeColTestCase { - public void testGetAllMods() { - // There should not be any mods present until they are loaded. - assertTrue(Mods.getAllMods().isEmpty()); - // Load them and check that there are some mods - Mods.loadMods(); - assertFalse(Mods.getAllMods().isEmpty()); - // Check that all mod files can be loaded - for (FreeColModFile mod : Mods.getAllMods()) { - assertNotNull("Null identifier for " + mod, mod.getId()); - assertEquals(mod, Mods.getModFile(mod.getId())); - } + public void testMakeFileFilter_1() + throws Exception { + String requiredFile = ""; + + FileFilter result = FreeColDataFile.makeFileFilter(requiredFile); + + // add additional test code here + assertNotNull(result); + } - } public void testGetRuleSets() { - // Check that all rule sets can be loaded + Set ids = new HashSet(); for (FreeColModFile mod : Mods.getRuleSets()) { assertNotNull("Null identifier for " + mod, mod.getId()); @@ -51,7 +63,163 @@ public void testGetRuleSets() { assertTrue(ids.contains("freecol")); assertTrue(ids.contains("classic")); - // Testing has no mod descriptor + assertFalse(ids.contains("testing")); } + + public void testMods_1() + throws Exception { + Mods result = new Mods(); + assertNotNull(result); + + } + + /** + * Run the Collection getAllMods() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/16/17 12:31 AM + */ + @Test + public void testGetAllMods_1() + throws Exception { + + Collection result = Mods.getAllMods(); + + + assertNotNull(result); + + } + + /** + * Run the FreeColModFile getFreeColModFile(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/16/17 12:31 AM + */ + @Test + public void testGetFreeColModFile_1() + throws Exception { + String id = ""; + + FreeColModFile result = Mods.getFreeColModFile(id); + + + assertEquals(null, result); + } + + /** + * Run the FreeColModFile getModFile(String) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/16/17 12:31 AM + */ + @Test + public void testGetModFile_1() + throws Exception { + String id = ""; + + FreeColModFile result = Mods.getModFile(id); + + assertEquals(null, result); + } + + /** + * Run the List getRuleSets() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/16/17 12:31 AM + */ + @Test + public void testGetRuleSets_1() + throws Exception { + + List result = Mods.getRuleSets(); + + + assertNotNull(result); + } + + + public void testLoadMods_1() + throws Exception { + + Mods.loadMods(); + + + } + + + + /** + * Run the FileFilter getFileFilter() method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/16/17 12:31 AM + */ + @Test + public void testGetFileFilter_1() + throws Exception { + + FileFilter result = FreeColSavegameFile.getFileFilter(); + + + assertNotNull(result); + } + + + public void testGetFileNames_1() + throws Exception { + String prefix = ""; + String suffix = ""; + Locale locale = Locale.getDefault(); + + List result = FreeColDataFile.getFileNames(prefix, suffix, locale); + + + assertNotNull(result); + assertEquals(3, result.size()); + assertTrue(result.contains("")); + assertTrue(result.contains("_en")); + assertTrue(result.contains("_en_US")); + } + + public void testGetFileNames_2() + throws Exception { + String prefix = ""; + String suffix = ""; + Locale locale = Locale.getDefault(); + + List result = FreeColDataFile.getFileNames(prefix, suffix, locale); + + + assertNotNull(result); + assertEquals(3, result.size()); + assertTrue(result.contains("")); + assertTrue(result.contains("_en")); + assertTrue(result.contains("_en_US")); + } + + + + @Test + public void testGetResourceFileNames_1() + throws Exception { + + List result = FreeColDataFile.getResourceFileNames(); + + + assertNotNull(result); + assertEquals(3, result.size()); + assertTrue(result.contains("resources.properties")); + assertTrue(result.contains("resources_en.properties")); + assertTrue(result.contains("resources_en_US.properties")); + } + + } diff --git a/test/src/net/sf/freecol/server/generator/MapGeneratorTest.java b/test/src/net/sf/freecol/server/generator/MapGeneratorTest.java index 1ddc4cf2..15e6f972 100644 --- a/test/src/net/sf/freecol/server/generator/MapGeneratorTest.java +++ b/test/src/net/sf/freecol/server/generator/MapGeneratorTest.java @@ -19,14 +19,21 @@ package net.sf.freecol.server.generator; +import static org.junit.Assert.assertNotNull; + import java.io.File; import java.util.Random; import java.util.Vector; +import javax.imageio.metadata.IIOMetadataNode; + +import org.junit.Test; + import net.sf.freecol.common.io.FreeColSavegameFile; import net.sf.freecol.common.model.FreeColObject; import net.sf.freecol.common.model.Game; import net.sf.freecol.common.model.IndianSettlement; +import net.sf.freecol.common.model.LandMap; import net.sf.freecol.common.model.Map; import net.sf.freecol.common.model.Nation; import net.sf.freecol.common.model.NationOptions; @@ -45,6 +52,44 @@ public class MapGeneratorTest extends FreeColTestCase { + public void testCreateEmptyMap(){ + ((FileOption) spec().getOption(MapGeneratorOptions.IMPORT_FILE)).setValue(null); + + Game g = new ServerGame(spec()); + g.setNationOptions(new NationOptions(spec())); + + // A new game does not have a map yet + assertEquals(null, g.getMap()); + + MapGenerator gen = new SimpleMapGenerator(g, new Random(1)); + LogBuilder lb = new LogBuilder(10); + Map map = gen.createEmptyMap(10, 10, lb); + } + + public void testCreateMap(){ + ((FileOption) spec().getOption(MapGeneratorOptions.IMPORT_FILE)).setValue(null); + + Game g = new ServerGame(spec()); + g.setNationOptions(new NationOptions(spec())); + + // A new game does not have a map yet + assertEquals(null, g.getMap()); + + MapGenerator gen = new SimpleMapGenerator(g, new Random(1)); + LogBuilder lb = new LogBuilder(10); + Map map = gen.createMap(lb); + } + + public void testCreateDebugUnits1(){ + //Map map, Player player, Tile startTile, + //LogBuilder lb + //above are params to the method + // Create land map. + + + + } + public void testWithNoIndians() { ((FileOption) spec().getOption(MapGeneratorOptions.IMPORT_FILE)).setValue(null); @@ -252,4 +297,80 @@ public void testRegions() { assertFalse(northAtlantic.getDiscoverable()); assertNull(northAtlantic.getDiscoverableRegion()); } + + //codepro test cases + //modified to set up a game for each test + + public void testSimpleMapGenerator_1() + throws Exception { + //Game g = new ServerGame(spec()); + //g.setNationOptions(new NationOptions(spec())); + Game game = new ServerGame(spec()); + game.setNationOptions(new NationOptions(spec())); + Random random = new Random(); + + SimpleMapGenerator result = new SimpleMapGenerator(game, random); + + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + public void testCreateEmptyMap_1() + throws Exception { + Game game = new ServerGame(spec()); + game.setNationOptions(new NationOptions(spec())); + SimpleMapGenerator fixture = new SimpleMapGenerator(game, new Random()); + int width = 1; + int height = 1; + LogBuilder lb = new LogBuilder(1); + + Map result = fixture.createEmptyMap(width, height, lb); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + public void testCreateMap_1() + throws Exception { + Game game = new ServerGame(spec()); + game.setNationOptions(new NationOptions(spec())); + SimpleMapGenerator fixture = new SimpleMapGenerator(game, new Random()); + LogBuilder lb = new LogBuilder(1); + + Map result = fixture.createMap(lb); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + public void testCreateMap_2() + throws Exception { + Game game = new ServerGame(spec()); + game.setNationOptions(new NationOptions(spec())); + SimpleMapGenerator fixture = new SimpleMapGenerator(game, new Random()); + LogBuilder lb = new LogBuilder(1); + + Map result = fixture.createMap(lb); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + } diff --git a/test/src/net/sf/freecol/server/generator/SimpleMapGeneratorTest.java b/test/src/net/sf/freecol/server/generator/SimpleMapGeneratorTest.java new file mode 100644 index 00000000..b733ca82 --- /dev/null +++ b/test/src/net/sf/freecol/server/generator/SimpleMapGeneratorTest.java @@ -0,0 +1,152 @@ +package net.sf.freecol.server.generator; + +import java.util.Random; +import javax.imageio.metadata.IIOMetadataNode; +import org.junit.*; +import net.sf.freecol.common.model.Map; +import net.sf.freecol.common.model.Game; +import static org.junit.Assert.*; +import org.w3c.dom.Element; +import net.sf.freecol.common.util.LogBuilder; + +/** + * The class SimpleMapGeneratorTest contains tests for the class {@link SimpleMapGenerator}. + * + * @generatedBy CodePro at 5/18/17 10:37 PM + * @author featherylizard + * @version $Revision: 1.0 $ + */ +public class SimpleMapGeneratorTest { + /** + * Run the SimpleMapGenerator(Game,Random) constructor test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + @Test + public void testSimpleMapGenerator_1() + throws Exception { + Game game = new Game(new IIOMetadataNode(), ""); + Random random = new Random(); + + SimpleMapGenerator result = new SimpleMapGenerator(game, random); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the Map createEmptyMap(int,int,LogBuilder) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + @Test + public void testCreateEmptyMap_1() + throws Exception { + SimpleMapGenerator fixture = new SimpleMapGenerator(new Game(new IIOMetadataNode(), ""), new Random()); + int width = 1; + int height = 1; + LogBuilder lb = new LogBuilder(1); + + Map result = fixture.createEmptyMap(width, height, lb); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the Map createMap(LogBuilder) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + @Test + public void testCreateMap_1() + throws Exception { + SimpleMapGenerator fixture = new SimpleMapGenerator(new Game(new IIOMetadataNode(), ""), new Random()); + LogBuilder lb = new LogBuilder(1); + + Map result = fixture.createMap(lb); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Run the Map createMap(LogBuilder) method test. + * + * @throws Exception + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + @Test + public void testCreateMap_2() + throws Exception { + SimpleMapGenerator fixture = new SimpleMapGenerator(new Game(new IIOMetadataNode(), ""), new Random()); + LogBuilder lb = new LogBuilder(1); + + Map result = fixture.createMap(lb); + + // add additional test code here + // An unexpected exception was thrown in user code while executing this test: + // java.lang.RuntimeException: Read failure + // at net.sf.freecol.common.model.FreeColObject.readFromXMLElement(FreeColObject.java:912) + // at net.sf.freecol.common.model.Game.(Game.java:216) + assertNotNull(result); + } + + /** + * Perform pre-test initialization. + * + * @throws Exception + * if the initialization fails for some reason + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + @Before + public void setUp() + throws Exception { + // add additional set up code here + } + + /** + * Perform post-test clean-up. + * + * @throws Exception + * if the clean-up fails for some reason + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + @After + public void tearDown() + throws Exception { + // Add additional tear down code here + } + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + public static void main(String[] args) { + new org.junit.runner.JUnitCore().run(SimpleMapGeneratorTest.class); + } +} \ No newline at end of file diff --git a/test/src/net/sf/freecol/server/generator/TestAll.java b/test/src/net/sf/freecol/server/generator/TestAll.java new file mode 100644 index 00000000..30b4a230 --- /dev/null +++ b/test/src/net/sf/freecol/server/generator/TestAll.java @@ -0,0 +1,32 @@ +package net.sf.freecol.server.generator; + +import org.junit.runner.JUnitCore; +import org.junit.runner.RunWith; +import org.junit.runners.Suite; + +/** + * The class TestAll builds a suite that can be used to run all + * of the tests within its package as well as within any subpackages of its + * package. + * + * @generatedBy CodePro at 5/18/17 10:37 PM + * @author featherylizard + * @version $Revision: 1.0 $ + */ +@RunWith(Suite.class) +@Suite.SuiteClasses({ + SimpleMapGeneratorTest.class, +}) +public class TestAll { + + /** + * Launch the test. + * + * @param args the command line arguments + * + * @generatedBy CodePro at 5/18/17 10:37 PM + */ + public static void main(String[] args) { + JUnitCore.runClasses(new Class[] { TestAll.class }); + } +}