Skip to content

Conversation

@cloudgray
Copy link
Contributor

@cloudgray cloudgray commented Nov 20, 2025

Description

Closes: #832

  • Provide a minimal, copy‑friendly evmd/app skeleton that only wires the foundational keepers so third‑party chain developers can drop it into their projects without carrying the full Cosmos SDK scaffolding.
  • All of the extra keepers, precompiles, and test‑only plumbing that our existing suites rely on now live in lightweight wrappers tailored to each test harness; the wrappers layer their custom wiring on top of the base app before injecting it into the suites.

Consideration

  • The reason why test code coverage is lower than before is because werc20 precompile tests were removed. I didn't handled werc20 precompile tests because it will be removed. (#808)

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.51%. Comparing base (651ccd0) to head (f8587d2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   65.24%   62.51%   -2.73%     
==========================================
  Files         317      317              
  Lines       21613    21614       +1     
==========================================
- Hits        14101    13513     -588     
- Misses       6352     6895     +543     
- Partials     1160     1206      +46     
Files with missing lines Coverage Δ
encoding/config.go 100.00% <100.00%> (ø)
x/vm/keeper/keeper.go 82.18% <100.00%> (+0.41%) ⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cloudgray cloudgray changed the title refactor: inject evmd into tests refactor: modify tests to inject minimum app Dec 1, 2025
@cloudgray cloudgray changed the base branch from vlad/evmd-refactor to main December 1, 2025 10:10
@cloudgray cloudgray self-assigned this Dec 1, 2025
Comment on lines +753 to +763
for _, m := range app.ModuleManager.Modules {
moduleWithName, hasName := m.(module.HasName)
appModule, isAppModule := m.(appmodule.AppModule)
if !hasName || !isAppModule {
continue
}
entries = append(entries, moduleEntry{
name: moduleWithName.Name(),
module: appModule,
})
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
@cloudgray cloudgray requested a review from vladjdk December 1, 2025 11:17
@cloudgray cloudgray marked this pull request as ready for review December 1, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor evmd to have necessary keepers

3 participants