-
Notifications
You must be signed in to change notification settings - Fork 130
refactor: modify tests to inject minimum app #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cloudgray
wants to merge
55
commits into
cosmos:main
Choose a base branch
from
cloudgray:cloudgray/evmd-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+7,972
−1,177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #845 +/- ##
==========================================
- Coverage 65.24% 62.51% -2.73%
==========================================
Files 317 317
Lines 21613 21614 +1
==========================================
- Hits 14101 13513 -588
- Misses 6352 6895 +543
- Partials 1160 1206 +46
🚀 New features to boost your workflow:
|
Comment on lines
+753
to
+763
| for _, m := range app.ModuleManager.Modules { | ||
| moduleWithName, hasName := m.(module.HasName) | ||
| appModule, isAppModule := m.(appmodule.AppModule) | ||
| if !hasName || !isAppModule { | ||
| continue | ||
| } | ||
| entries = append(entries, moduleEntry{ | ||
| name: moduleWithName.Name(), | ||
| module: appModule, | ||
| }) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Iteration over map may be a possible source of non-determinism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #832
Consideration
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch