From 296b645570683507644883f7b715e7a823f7bd1f Mon Sep 17 00:00:00 2001 From: Toddr Bot Date: Wed, 25 Mar 2026 21:29:23 +0000 Subject: [PATCH] fix: skip fh-ref-leak tests when Overload::FileCheck < 0.014 Overload::FileCheck < 0.014 retains filehandle references in $_last_call_for, preventing garbage collection. The fix landed in 0.014 (PR #25). Skip the test on older versions instead of failing. The module already requires >= 0.014 in Makefile.PL, but this gracefully handles environments where the prereq isn't enforced. Co-Authored-By: Claude Opus 4.6 --- t/fh-ref-leak.t | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/t/fh-ref-leak.t b/t/fh-ref-leak.t index a32310ca..52fcd8a5 100644 --- a/t/fh-ref-leak.t +++ b/t/fh-ref-leak.t @@ -19,6 +19,13 @@ use Test2::Tools::Explain; use Scalar::Util qw(weaken); use Socket; +use Overload::FileCheck (); + +# Overload::FileCheck < 0.014 caches filehandle refs in $_last_call_for, +# preventing garbage collection. The fix (PR #25) landed in 0.014. +skip_all "Overload::FileCheck >= 0.014 required (have $Overload::FileCheck::VERSION)" + if $Overload::FileCheck::VERSION < 0.014; + use Test::MockFile qw< nostrict >; # Test 1: Filehandle passed to -f is not retained