Remove incorrect assets arg

Author: karnkaul

guide/src/shader_objects/locating_assets.md

@@ -47,37 +47,3 @@ Add a helper function to locate the assets dir, and assign `m_assets_dir` to its
 // ...
 m_assets_dir = locate_assets_dir();
 ```
-
-We can also support a command line argument to override this algorithm:
-
-```cpp
-// app.hpp
-void run(std::string_view assets_dir);
-
-// app.cpp
-[[nodiscard]] auto locate_assets_dir(std::string_view const in) -> fs::path {
-  if (!in.empty()) {
-    std::println("[lvk] Using custom assets directory: '{}'", in);
-    return in;
-  }
-  // ...
-}
-
-// ...
-void App::run(std::string_view const assets_dir) {
-  m_assets_dir = locate_assets_dir(assets_dir);
-  // ...
-}
-
-// main.cpp
-auto assets_dir = std::string_view{};
-
-// ...
-if (arg == "-x" || arg == "--force-x11") {
-  glfwInitHint(GLFW_PLATFORM, GLFW_PLATFORM_X11);
-}
-if (arg == "-a" || arg == "--assets") { assets_dir = arg; }
-
-// ...
-lvk::App{}.run(assets_dir);
-```

src/app.cpp

@@ -11,11 +11,7 @@ namespace lvk {
 using namespace std::chrono_literals;
 
 namespace {
-[[nodiscard]] auto locate_assets_dir(std::string_view const in) -> fs::path {
-	if (!in.empty()) {
-		std::println("[lvk] Using custom assets directory: '{}'", in);
-		return in;
-	}
+[[nodiscard]] auto locate_assets_dir() -> fs::path {
 	// look for '<path>/assets/', starting from the working
 	// directory and walking up the parent directory tree.
 	static constexpr std::string_view dir_name_v{"assets"};
@@ -54,8 +50,8 @@ namespace {
 }
 } // namespace
 
-void App::run(std::string_view const assets_dir) {
-	m_assets_dir = locate_assets_dir(assets_dir);
+void App::run() {
+	m_assets_dir = locate_assets_dir();
 
 	create_window();
 	create_instance();

src/app.hpp

@@ -13,7 +13,7 @@ namespace fs = std::filesystem;
 
 class App {
   public:
-	void run(std::string_view assets_dir);
+	void run();
 
   private:
 	struct RenderSync {

src/main.cpp

@@ -5,18 +5,16 @@
 
 auto main(int argc, char** argv) -> int {
 	try {
-		auto assets_dir = std::string_view{};
 		// skip the first argument.
 		auto args = std::span{argv, static_cast<std::size_t>(argc)}.subspan(1);
 		while (!args.empty()) {
 			auto const arg = std::string_view{args.front()};
 			if (arg == "-x" || arg == "--force-x11") {
 				glfwInitHint(GLFW_PLATFORM, GLFW_PLATFORM_X11);
 			}
-			if (arg == "-a" || arg == "--assets") { assets_dir = arg; }
 			args = args.subspan(1);
 		}
-		lvk::App{}.run(assets_dir);
+		lvk::App{}.run();
 	} catch (std::exception const& e) {
 		std::println(stderr, "PANIC: {}", e.what());
 		return EXIT_FAILURE;