Skip to content

Commit 1f35303

Browse files
authored
prefer inline suppressions in selfchecks (danmar#7939)
1 parent ca87cc1 commit 1f35303

File tree

3 files changed

+5
-18
lines changed

3 files changed

+5
-18
lines changed

.selfcheck_suppressions

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,6 @@ missingIncludeSystem
22
# should not be reported - see #13387
33
checkersReport
44

5-
# temporary suppressions - fix the warnings!
6-
simplifyUsing:lib/valueptr.h
7-
naming-privateMemberVariable:gui/test/cppchecklibrarydata/testcppchecklibrarydata.h
8-
bitwiseOnBoolean:lib/library.cpp
9-
templateInstantiation:lib/checkunusedfunctions.cpp
10-
templateInstantiation:lib/errorlogger.cpp
11-
templateInstantiation:lib/liobrary.cpp
12-
shadowFunction:lib/checkbufferoverrun.cpp
13-
shadowFunction:lib/checkclass.cpp
14-
shadowFunction:lib/checknullpointer.cpp
15-
shadowFunction:lib/cppcheck.cpp
16-
shadowFunction:lib/fwdanalysis.cpp
17-
shadowFunction:lib/library.cpp
18-
shadowFunction:lib/symboldatabase.cpp
19-
shadowFunction:lib/templatesimplifier.cpp
20-
shadowFunction:lib/token.cpp
21-
shadowFunction:tools/triage/mainwindow.cpp
22-
235
# warnings in Qt generated code we cannot fix
246
funcArgNamesDifferent:*/moc_checkthread.cpp
257
funcArgNamesDifferent:*/moc_codeeditstylecontrols.cpp

gui/test/cppchecklibrarydata/testcppchecklibrarydata.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,13 @@ private slots:
4848
static void loadCfgFile(const QString &filename, CppcheckLibraryData &data, QString &res, bool removeFile = false);
4949
static void saveCfgFile(const QString &filename, CppcheckLibraryData &data);
5050

51+
// cppcheck-suppress naming-privateMemberVariable - TODO: fix this
5152
CppcheckLibraryData libraryData;
53+
// cppcheck-suppress naming-privateMemberVariable - TODO: fix this
5254
CppcheckLibraryData fileLibraryData;
55+
// cppcheck-suppress naming-privateMemberVariable - TODO: fix this
5356
QString result;
5457

58+
// cppcheck-suppress naming-privateMemberVariable - TODO: fix this
5559
static const QString TempCfgFile;
5660
};

lib/valueptr.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ class CPPCHECKLIB ValuePtr {
3737
public:
3838
using pointer = T*;
3939
using element_type = T;
40+
// cppcheck-suppress simplifyUsing - TODO: fix this
4041
using cloner_type = decltype(&cloner<T>::apply);
4142

4243
ValuePtr() : mPtr(nullptr), mClone() {}

0 commit comments

Comments
 (0)