From 0b9f2811f9de19dd0e476cd3f9331508d0713b3b Mon Sep 17 00:00:00 2001 From: Hassan Khan Date: Sat, 24 Jun 2017 20:08:02 +0100 Subject: [PATCH 1/2] Remove double-spaces --- serverless.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/serverless.yml b/serverless.yml index 49e18d5..369d223 100644 --- a/serverless.yml +++ b/serverless.yml @@ -20,8 +20,8 @@ provider: restrictedOrgs: ${env:CODEBOX_RESTRICTED_ORGS} registry: ${env:CODEBOX_REGISTRY} githubUrl: ${env:CODEBOX_GITHUB_URL} - githubClientId: ${env:CODEBOX_GITHUB_CLIENT_ID} - githubSecret: ${env:CODEBOX_GITHUB_SECRET} + githubClientId: ${env:CODEBOX_GITHUB_CLIENT_ID} + githubSecret: ${env:CODEBOX_GITHUB_SECRET} bucket: ${env:CODEBOX_BUCKET}-${self:provider.stage} region: ${self:provider.region} From 0a66034006e84d957d06428c93c9352758def842 Mon Sep 17 00:00:00 2001 From: Hassan Khan Date: Sat, 24 Jun 2017 20:08:22 +0100 Subject: [PATCH 2/2] Use `:` instead of `''` in `Fn::Join` --- serverless.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/serverless.yml b/serverless.yml index 369d223..9346548 100644 --- a/serverless.yml +++ b/serverless.yml @@ -40,12 +40,11 @@ provider: Resource: - "arn:aws:s3:::${self:provider.environment.bucket}*" - "Fn::Join": - - "" - - - "arn:aws:sns:" + - ":" + - - "arn:aws:sns" - Ref: "AWS::Region" - - ":" - Ref: "AWS::AccountId" - - ":${self:service}-${opt:stage}-log" + - "${self:service}-${opt:stage}-log" functions: authorizerGithub: