Skip to content

Should we fix tab-indented multi-line strings? #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turbo8p opened this issue Oct 3, 2017 · 3 comments
Open

Should we fix tab-indented multi-line strings? #43

turbo8p opened this issue Oct 3, 2017 · 3 comments
Labels

Comments

@turbo8p
Copy link

turbo8p commented Oct 3, 2017

$txt = 'text
           text2
           text3
';

If there are tab indents in front of "text2" and "text3", the sniff does not convert them to spaces.

@turbo8p turbo8p added the bug label Oct 3, 2017
@wmathes
Copy link
Contributor

wmathes commented Oct 3, 2017

That's intentional. I'm not sure if we should auto-fix this.

It's a temporary inconvenience when converting the old files.

@wmathes wmathes added question and removed bug labels Oct 3, 2017
@wmathes wmathes changed the title Tab to space does not work on multi line string Should we fix/warn tab-indented multi-line strings? Oct 3, 2017
@wmathes wmathes changed the title Should we fix/warn tab-indented multi-line strings? Should we fix tab-indented multi-line strings? Oct 3, 2017
@turbo8p
Copy link
Author

turbo8p commented Oct 3, 2017

Why don't we convert tab to space for multi line string ? For what reason.

@wmathes
Copy link
Contributor

wmathes commented Oct 4, 2017

We should do that project-wide once. Afterwards it shouldn't appear again anyway.

Currently i can't think of a scenarios in which we'd want the tabs. So yes we could do an automatic fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants