From 0e0bddce00e20912e6e0161d914a21e1a8df0522 Mon Sep 17 00:00:00 2001 From: Will Speak Date: Fri, 13 Feb 2026 12:50:18 +0000 Subject: [PATCH] test: stop requesting explicit auth scopes --- __tests__/functional/e2e.functional.test.ts | 1 - __tests__/functional/main.functional.test.ts | 18 ++++++++++++------ __tests__/unit/authenticationManager.test.ts | 3 +-- __tests__/unit/main.test.ts | 3 --- __tests__/unit/module-import.test.ts | 1 - 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/__tests__/functional/e2e.functional.test.ts b/__tests__/functional/e2e.functional.test.ts index 528d104..2040521 100644 --- a/__tests__/functional/e2e.functional.test.ts +++ b/__tests__/functional/e2e.functional.test.ts @@ -65,7 +65,6 @@ describe('E2E Test Cases', () => { clientId: process.env.VITE_ATHENA_CLIENT_ID ?? '', clientSecret: process.env.VITE_ATHENA_CLIENT_SECRET ?? '', audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE), - scope: 'manage:classify', }, }); diff --git a/__tests__/functional/main.functional.test.ts b/__tests__/functional/main.functional.test.ts index bb20104..8db7d76 100644 --- a/__tests__/functional/main.functional.test.ts +++ b/__tests__/functional/main.functional.test.ts @@ -4,6 +4,7 @@ import { ClassifierSdk, type ClassifyImageInput, ImageFormat, + parseAudience, } from '../../src'; import fs from 'fs'; import { randomUUID } from 'crypto'; @@ -18,11 +19,12 @@ describe('ClassifierSdk Functional Tests', () => { const sdk = new ClassifierSdk({ deploymentId: process.env.VITE_ATHENA_DEPLOYMENT_ID, affiliate: process.env.VITE_ATHENA_AFFILIATE, + grpcAddress: process.env.VITE_ATHENA_GRPC_ADDRESS, authentication: { issuerUrl: process.env.VITE_OAUTH_ISSUER, clientId: process.env.VITE_ATHENA_CLIENT_ID, clientSecret: process.env.VITE_ATHENA_CLIENT_SECRET, - scope: 'manage:classify', + audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE), }, }); @@ -46,11 +48,12 @@ describe('ClassifierSdk Functional Tests', () => { const sdk = new ClassifierSdk({ deploymentId: process.env.VITE_ATHENA_DEPLOYMENT_ID, affiliate: process.env.VITE_ATHENA_AFFILIATE, + grpcAddress: process.env.VITE_ATHENA_GRPC_ADDRESS, authentication: { issuerUrl: process.env.VITE_OAUTH_ISSUER, clientId: process.env.VITE_ATHENA_CLIENT_ID, clientSecret: process.env.VITE_ATHENA_CLIENT_SECRET, - scope: 'manage:classify', + audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE), }, }); @@ -60,7 +63,7 @@ describe('ClassifierSdk Functional Tests', () => { }; const response = await sdk.classifySingle(input); - expect(response.classifications).toBe(true); + expect(Array.isArray(response.classifications)).toBe(true); expect(response.error).toBeNull(); }, 10000); }); @@ -76,11 +79,12 @@ describe('ClassifierSdk Functional Tests', () => { const sdk = new ClassifierSdk({ deploymentId: process.env.VITE_ATHENA_DEPLOYMENT_ID, affiliate: process.env.VITE_ATHENA_AFFILIATE, + grpcAddress: process.env.VITE_ATHENA_GRPC_ADDRESS, authentication: { issuerUrl: process.env.VITE_OAUTH_ISSUER, clientId: process.env.VITE_ATHENA_CLIENT_ID, clientSecret: process.env.VITE_ATHENA_CLIENT_SECRET, - scope: 'manage:classify', + audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE), }, }); @@ -172,11 +176,12 @@ describe('ClassifierSdk Functional Tests', () => { const sdk = new ClassifierSdk({ deploymentId: process.env.VITE_ATHENA_DEPLOYMENT_ID, affiliate: process.env.VITE_ATHENA_AFFILIATE, + grpcAddress: process.env.VITE_ATHENA_GRPC_ADDRESS, authentication: { issuerUrl: process.env.VITE_OAUTH_ISSUER, clientId: process.env.VITE_ATHENA_CLIENT_ID, clientSecret: process.env.VITE_ATHENA_CLIENT_SECRET, - scope: 'manage:classify', + audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE), }, }); @@ -257,11 +262,12 @@ describe('ClassifierSdk Functional Tests', () => { const sdk = new ClassifierSdk({ deploymentId: process.env.VITE_ATHENA_DEPLOYMENT_ID, affiliate: process.env.VITE_ATHENA_AFFILIATE, + grpcAddress: process.env.VITE_ATHENA_GRPC_ADDRESS, authentication: { issuerUrl: process.env.VITE_OAUTH_ISSUER, clientId: process.env.VITE_ATHENA_CLIENT_ID, clientSecret: process.env.VITE_ATHENA_CLIENT_SECRET, - scope: 'manage:classify', + audience: parseAudience(process.env.VITE_ATHENA_AUDIENCE), }, }); diff --git a/__tests__/unit/authenticationManager.test.ts b/__tests__/unit/authenticationManager.test.ts index 5a59567..82935e5 100644 --- a/__tests__/unit/authenticationManager.test.ts +++ b/__tests__/unit/authenticationManager.test.ts @@ -22,7 +22,6 @@ const options: AuthenticationOptions = { clientId: 'client-id', clientSecret: 'client-secret', issuerUrl: 'https://issuer.example.com', - scope: 'manage:classify', }; describe('AuthenticationManager', () => { @@ -46,7 +45,7 @@ describe('AuthenticationManager', () => { ); expect(openidClient.clientCredentialsGrant).toHaveBeenCalledWith( mockDiscovery, - { audience: 'crisp-athena-live', scope: options.scope }, + { audience: 'crisp-athena-live' }, ); }); diff --git a/__tests__/unit/main.test.ts b/__tests__/unit/main.test.ts index 08f375f..ba12a7a 100644 --- a/__tests__/unit/main.test.ts +++ b/__tests__/unit/main.test.ts @@ -37,7 +37,6 @@ describe('ClassifierSdk', () => { issuerUrl: 'https://test-issuer.com', clientId: 'test-client-id', clientSecret: 'test-client-secret', - scope: 'manage:classify', }, }); }); @@ -57,7 +56,6 @@ describe('ClassifierSdk', () => { issuerUrl: 'https://test-issuer.com', clientId: 'test-client-id', clientSecret: 'test-client-secret', - scope: 'manage:classify', }, }); @@ -74,7 +72,6 @@ describe('ClassifierSdk', () => { issuerUrl: 'https://test-issuer.com', clientId: 'test-client-id', clientSecret: 'test-client-secret', - scope: 'manage:classify', }, }); diff --git a/__tests__/unit/module-import.test.ts b/__tests__/unit/module-import.test.ts index d31c5db..1157900 100644 --- a/__tests__/unit/module-import.test.ts +++ b/__tests__/unit/module-import.test.ts @@ -63,7 +63,6 @@ describe('Module Import Tests', () => { issuerUrl: 'https://test-issuer.com', clientId: 'test-client-id', clientSecret: 'test-client-secret', - scope: 'manage:classify', }, });