From fbdf1d2124ce028a705e51568b3d7c87408deaed Mon Sep 17 00:00:00 2001 From: Michael Juliano Date: Fri, 6 Mar 2026 14:03:46 -0500 Subject: [PATCH] Fix kubebuilder enum for StringTransformType: add Join and Replace The Join string transform type was added in v0.7.0 (#133) and Replace was added later, but the kubebuilder validation enum marker on StringTransform.Type was not updated to include them. This causes CRD schema validation to reject valid Compositions using these transform types. Signed-off-by: Michael Juliano Co-Authored-By: Claude Opus 4.6 --- input/v1beta1/resources_transforms.go | 2 +- package/input/pt.fn.crossplane.io_resources.yaml | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/input/v1beta1/resources_transforms.go b/input/v1beta1/resources_transforms.go index 38f061e..1ff95eb 100644 --- a/input/v1beta1/resources_transforms.go +++ b/input/v1beta1/resources_transforms.go @@ -230,7 +230,7 @@ const ( // A StringTransform returns a string given the supplied input. type StringTransform struct { // Type of the string transform to be run. - // +kubebuilder:validation:Enum=Format;Convert;TrimPrefix;TrimSuffix;Regexp + // +kubebuilder:validation:Enum=Format;Convert;TrimPrefix;TrimSuffix;Regexp;Join;Replace // +kubebuilder:default=Format Type StringTransformType `json:"type"` diff --git a/package/input/pt.fn.crossplane.io_resources.yaml b/package/input/pt.fn.crossplane.io_resources.yaml index 07edd02..365b75d 100644 --- a/package/input/pt.fn.crossplane.io_resources.yaml +++ b/package/input/pt.fn.crossplane.io_resources.yaml @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 kind: CustomResourceDefinition metadata: annotations: - controller-gen.kubebuilder.io/version: v0.18.0 + controller-gen.kubebuilder.io/version: v0.20.0 name: resources.pt.fn.crossplane.io spec: group: pt.fn.crossplane.io @@ -364,6 +364,8 @@ spec: - TrimPrefix - TrimSuffix - Regexp + - Join + - Replace type: string required: - type @@ -744,6 +746,8 @@ spec: - TrimPrefix - TrimSuffix - Regexp + - Join + - Replace type: string required: - type @@ -1184,6 +1188,8 @@ spec: - TrimPrefix - TrimSuffix - Regexp + - Join + - Replace type: string required: - type @@ -1635,6 +1641,8 @@ spec: - TrimPrefix - TrimSuffix - Regexp + - Join + - Replace type: string required: - type