Skip to content

Commit df4fca5

Browse files
Merge pull request #72 from cuappdev/staging
Trial 3: Fix remembers
2 parents cb38d3a + 8b6e8b0 commit df4fca5

File tree

7 files changed

+34
-11
lines changed

7 files changed

+34
-11
lines changed

app/src/main/java/com/cornellappdev/uplift/ui/components/general/CalendarBar.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ private fun CalendarBarSelection(
127127
.height(58.dp)
128128
.width(screenWidth / 7f)
129129
.clickable(
130-
interactionSource = MutableInteractionSource(),
130+
interactionSource = remember { MutableInteractionSource()},
131131
indication = null,
132132
onClick = onSelect
133133
), horizontalAlignment = Alignment.CenterHorizontally

app/src/main/java/com/cornellappdev/uplift/ui/components/general/ClassInfoCard.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import androidx.compose.material.ExperimentalMaterialApi
1010
import androidx.compose.material.Surface
1111
import androidx.compose.material.Text
1212
import androidx.compose.runtime.Composable
13+
import androidx.compose.runtime.remember
1314
import androidx.compose.ui.Alignment
1415
import androidx.compose.ui.Modifier
1516
import androidx.compose.ui.graphics.Color
@@ -132,7 +133,7 @@ fun ClassInfoCard(
132133
modifier = Modifier
133134
.size(24.dp)
134135
.clickable(
135-
interactionSource = MutableInteractionSource(),
136+
interactionSource = remember { MutableInteractionSource() },
136137
indication = null
137138
) {
138139
thisClass.toggleFavorite()

app/src/main/java/com/cornellappdev/uplift/ui/components/general/DayOfWeekSelector.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ fun DayOfWeekSelector(today: Int, onDaySelected: (Int) -> Unit) {
5252

5353
Box(
5454
modifier = Modifier.clickable(
55-
interactionSource = MutableInteractionSource(),
55+
interactionSource = remember { MutableInteractionSource() } ,
5656
indication = null
5757
) {
5858
selectedDay = i

app/src/main/java/com/cornellappdev/uplift/ui/components/gymdetail/PopularTimes.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,10 @@ fun PopularTimesSection(popularTimes: PopularTimes) {
8686
Column(
8787
modifier = Modifier
8888
.fillMaxWidth()
89-
.clickable(interactionSource = MutableInteractionSource(), indication = null) {
89+
.clickable(
90+
interactionSource = remember { MutableInteractionSource() },
91+
indication = null
92+
) {
9093
deselect()
9194
}
9295
.background(Color.White)
@@ -170,7 +173,7 @@ fun PopularTimesSection(popularTimes: PopularTimes) {
170173
.padding(horizontal = 1.dp)
171174
.padding(bottom = 1.dp)
172175
.clickable(
173-
interactionSource = MutableInteractionSource(),
176+
interactionSource = remember { MutableInteractionSource() },
174177
indication = null
175178
) {
176179
if (selectedPopularTime == i) deselect()

app/src/main/java/com/cornellappdev/uplift/ui/screens/ClassDetailScreen.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import androidx.compose.material.Text
3030
import androidx.compose.runtime.Composable
3131
import androidx.compose.runtime.collectAsState
3232
import androidx.compose.runtime.getValue
33+
import androidx.compose.runtime.remember
3334
import androidx.compose.ui.Alignment
3435
import androidx.compose.ui.Modifier
3536
import androidx.compose.ui.graphics.Color
@@ -152,7 +153,7 @@ fun ClassDetailScreen(
152153
)
153154
.padding(top = 47.dp, start = 22.dp)
154155
.clickable(
155-
interactionSource = MutableInteractionSource(),
156+
interactionSource = remember { MutableInteractionSource() },
156157
indication = null,
157158
onClick = onBack
158159
),

app/src/main/java/com/cornellappdev/uplift/ui/screens/GymDetailScreen.kt

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,16 @@ import androidx.compose.foundation.Image
1111
import androidx.compose.foundation.background
1212
import androidx.compose.foundation.clickable
1313
import androidx.compose.foundation.interaction.MutableInteractionSource
14-
import androidx.compose.foundation.layout.*
14+
import androidx.compose.foundation.layout.Box
15+
import androidx.compose.foundation.layout.Column
16+
import androidx.compose.foundation.layout.Spacer
17+
import androidx.compose.foundation.layout.aspectRatio
18+
import androidx.compose.foundation.layout.fillMaxSize
19+
import androidx.compose.foundation.layout.fillMaxWidth
20+
import androidx.compose.foundation.layout.height
21+
import androidx.compose.foundation.layout.offset
22+
import androidx.compose.foundation.layout.padding
23+
import androidx.compose.foundation.layout.size
1524
import androidx.compose.foundation.rememberScrollState
1625
import androidx.compose.foundation.shape.CircleShape
1726
import androidx.compose.foundation.shape.RoundedCornerShape
@@ -23,6 +32,7 @@ import androidx.compose.material.Text
2332
import androidx.compose.runtime.Composable
2433
import androidx.compose.runtime.collectAsState
2534
import androidx.compose.runtime.getValue
35+
import androidx.compose.runtime.remember
2636
import androidx.compose.ui.Alignment
2737
import androidx.compose.ui.Modifier
2838
import androidx.compose.ui.draw.clip
@@ -52,7 +62,14 @@ import com.cornellappdev.uplift.ui.components.gymdetail.GymCapacitiesSection
5262
import com.cornellappdev.uplift.ui.components.gymdetail.GymTodaysClasses
5363
import com.cornellappdev.uplift.ui.viewmodels.ClassDetailViewModel
5464
import com.cornellappdev.uplift.ui.viewmodels.GymDetailViewModel
55-
import com.cornellappdev.uplift.util.*
65+
import com.cornellappdev.uplift.util.ACCENT_CLOSED
66+
import com.cornellappdev.uplift.util.ACCENT_OPEN
67+
import com.cornellappdev.uplift.util.GRAY01
68+
import com.cornellappdev.uplift.util.GRAY03
69+
import com.cornellappdev.uplift.util.colorInterp
70+
import com.cornellappdev.uplift.util.isOpen
71+
import com.cornellappdev.uplift.util.montserratFamily
72+
import com.cornellappdev.uplift.util.todayIndex
5673

5774
/**
5875
* A screen displaying all the information about a selected gym.
@@ -155,7 +172,7 @@ fun GymDetailScreen(
155172
.padding(top = 47.dp, start = 22.dp)
156173
.clip(RoundedCornerShape(4.dp))
157174
.clickable(
158-
interactionSource = MutableInteractionSource(),
175+
interactionSource = remember { MutableInteractionSource() },
159176
indication = null,
160177
onClick = onBack
161178
),
@@ -209,7 +226,7 @@ fun GymDetailScreen(
209226
.align(Alignment.TopCenter)
210227
.offset(y = 25.dp)
211228
)
212-
}else{
229+
} else {
213230
Text(
214231
text = "OPEN",
215232
fontWeight = FontWeight(700),

app/src/main/java/com/cornellappdev/uplift/ui/screens/subscreens/MainLoaded.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import androidx.compose.material.pullrefresh.PullRefreshIndicator
3535
import androidx.compose.material.pullrefresh.pullRefresh
3636
import androidx.compose.material.pullrefresh.rememberPullRefreshState
3737
import androidx.compose.runtime.Composable
38+
import androidx.compose.runtime.remember
3839
import androidx.compose.runtime.rememberCoroutineScope
3940
import androidx.compose.ui.Alignment
4041
import androidx.compose.ui.Modifier
@@ -265,7 +266,7 @@ fun MainLoaded(
265266
.widthIn(min = 143.dp)
266267
.clickable(
267268
indication = null,
268-
interactionSource = MutableInteractionSource()
269+
interactionSource = remember { MutableInteractionSource() }
269270
) {
270271
navController.navigateToGym(
271272
gymDetailViewModel = gymDetailViewModel,

0 commit comments

Comments
 (0)