Skip to content

Commit c4dc88b

Browse files
authored
refactor: add attachment timestamp (#1809)
* WIP: Add #timestamp to Attachment message * Cleanups * Remove 3.1 testing whilst we have a slow transition out of 3.1 support
1 parent 7e4cfa8 commit c4dc88b

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
strategy:
2020
matrix:
2121
os: [ubuntu-latest, macos-latest, windows-latest]
22-
ruby: ['3.1', '3.2', '3.3', '3.4']
22+
ruby: ['3.2', '3.3', '3.4']
2323
include:
2424
- os: ubuntu-latest
2525
ruby: jruby-9.4

.github/workflows/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
fail-fast: false
1818
matrix:
1919
os: [ubuntu-latest, macos-latest, windows-latest]
20-
ruby: ['3.1', '3.2', '3.3', '3.4']
20+
ruby: ['3.2', '3.3', '3.4']
2121
include:
2222
- os: ubuntu-latest
2323
ruby: jruby-9.4

lib/cucumber/formatter/message_builder.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,13 @@ def initialize(config)
4141
@current_test_step_id = nil
4242
end
4343

44-
def output_message
45-
raise 'To be implemented'
46-
end
47-
4844
def attach(src, media_type, filename)
4945
attachment_data = {
5046
test_step_id: @current_test_step_id,
5147
test_case_started_id: @current_test_case_started_id,
5248
media_type: media_type,
53-
file_name: filename
49+
file_name: filename,
50+
timestamp: time_to_timestamp(Time.now)
5451
}
5552

5653
if media_type&.start_with?('text/')

0 commit comments

Comments
 (0)